PluginProbe
aBlocks – Gutenberg Blocks, User Dashboard Builder, Popup Builder, Form Builder & Animation Builder / 2.14.0
aBlocks – Gutenberg Blocks, User Dashboard Builder, Popup Builder, Form Builder & Animation Builder v2.14.0
2.14.0 2.13.0 2.13.1 2.12.0 2.11.1 2.11.0 2.10.0 2.9.0 2.7.4 2.7.5 2.7.6 2.7.7 2.8.0 2.8.1 2.9.1 trunk 1.0 1.0-beta1 1.0-beta2 1.0-beta3 1.0.1 1.0.2 1.0.3 1.1.0 1.1.1 All 81 releases
← All changes | includes/classes/css-generator.php +130 -48 2.9.0 → 2.14.0 View file →
@@ -5,11 +5,11 @@
5 5 exit;
6 6 }
7 7
8 8 use ABlocks\Classes\AssetsGenerator;
9 +use ABlocks\Classes\FontStack;
9 10
10 11 class CssGenerator {
11 - private $font_category;
12 12 private $custom_css = '';
13 13 private $parent_class;
14 14 private $class_styles = [];
15 15
@@ -21,9 +21,8 @@
21 21 if ( isset( $attributes['_custom_css'] ) ) {
22 22 $this->custom_css = $attributes['_custom_css'];
23 23 }
24 24
25 - $this->font_category = include ABLOCKS_BLOCKS_DIR_PATH . 'fonts.php';
26 25
27 26 // Alert - don't touch here
28 27 if ( isset( $attributes['_margin'] ) ) { // check has advanced tab or not
29 28 $this->add_class_styles(
@@ -29,9 +28,12 @@
29 28 $this->add_class_styles(
30 29 '{{WRAPPER}}',
31 30 BlockGlobal::get_wrapper_css( $attributes ),
32 31 BlockGlobal::get_wrapper_css( $attributes, 'Tablet' ),
33 - BlockGlobal::get_wrapper_css( $attributes, 'Mobile' )
32 + BlockGlobal::get_wrapper_css( $attributes, 'Mobile' ),
33 + $this->custom_device_map( function ( $device ) use ( $attributes ) {
34 + return BlockGlobal::get_wrapper_css( $attributes, $device );
35 + } )
34 36 );
35 37 $this->add_class_styles(
36 38 '{{WRAPPER}}:hover',
37 39 BlockGlobal::get_wrapper_hover_css( $attributes ),
@@ -53,22 +55,76 @@
53 55 $this->add_class_styles(
54 56 '{{WRAPPER}} > .ablocks-block-container',
55 57 BlockGlobal::get_container_css( $attributes ),
56 58 BlockGlobal::get_container_css( $attributes, 'Tablet' ),
57 - BlockGlobal::get_container_css( $attributes, 'Mobile' )
59 + BlockGlobal::get_container_css( $attributes, 'Mobile' ),
60 + $this->custom_device_map( function ( $device ) use ( $attributes ) {
61 + return BlockGlobal::get_container_css( $attributes, $device );
62 + } )
58 63 );
59 64 }//end if
60 65 }
61 66
62 - public function add_class_styles( $class_name, $desktop_styles, $tablet_styles = [], $mobile_styles = [] ) {
67 + public function add_class_styles( $class_name, $desktop_styles, $tablet_styles = [], $mobile_styles = [], $responsive_styles = [] ) {
63 68 $this->class_styles[] = [
64 69 'class_name' => $class_name,
65 70 'desktop_styles' => $desktop_styles,
66 71 'tablet_styles' => $tablet_styles,
67 - 'mobile_styles' => $mobile_styles
72 + 'mobile_styles' => $mobile_styles,
73 + 'responsive_styles' => $responsive_styles,
68 74 ];
69 75 }
70 76
77 + /**
78 + * Custom-breakpoint style map from a per-device builder (excludes the
79 + * built-in Tablet/Mobile so the standard path is untouched).
80 + */
81 + public function custom_device_map( $builder ) {
82 + $map = [];
83 +
84 + // Nothing to build when the site registers no custom breakpoints — and
85 + // running the phantom probe anyway is not free: it hands every control a
86 + // device suffix that has no stored keys, which is what made controls that
87 + // read `$value[ 'x' . $device ]` unguarded spray "Undefined array key
88 + // …___ablocksphantom___" notices on every page under WP_DEBUG.
89 + $custom_devices = [];
90 + foreach ( \ABlocks\Helper::get_responsive_devices() as $d ) {
91 + if ( $d['width'] <= 0 || 'Tablet' === $d['id'] || 'Mobile' === $d['id'] ) {
92 + continue;
93 + }
94 + $custom_devices[] = $d;
95 + }
96 + if ( empty( $custom_devices ) ) {
97 + return $map;
98 + }
99 +
100 + // Subtract a "phantom" baseline (builder run against a value-less suffix)
101 + // so controls that only default Tablet/Mobile don't leak phantom
102 + // declarations into custom breakpoints. Leaves only real overrides.
103 + $phantom = \ABlocks\Helper::call_device_builder( $builder, '__ablocksphantom__' );
104 + foreach ( $custom_devices as $d ) {
105 + if ( $d['width'] <= 0 || 'Tablet' === $d['id'] || 'Mobile' === $d['id'] ) {
106 + continue;
107 + }
108 + $actual = \ABlocks\Helper::call_device_builder( $builder, $d['suffix'] );
109 + $real = [];
110 + foreach ( $actual as $prop => $val ) {
111 + if ( ! array_key_exists( $prop, $phantom ) || $phantom[ $prop ] !== $val ) {
112 + $real[ $prop ] = $val;
113 + }
114 + }
115 + if ( ! empty( $real ) ) {
116 + $map[ $d['suffix'] ] = [
117 + 'width' => (int) $d['width'],
118 + 'min' => isset( $d['min'] ) ? (int) $d['min'] : 0,
119 + 'max' => isset( $d['max'] ) ? (int) $d['max'] : (int) $d['width'],
120 + 'styles' => $real,
121 + ];
122 + }
123 + }
124 + return $map;
125 + }
126 +
71 127 public function generate_css() {
72 128 $css_output = '';
73 129
74 130 foreach ( $this->class_styles as $class_style ) {
@@ -95,18 +151,62 @@
95 151
96 152 // Always add desktop CSS
97 153 $addToCssBlocks( '', '', $desktop_css );
98 154
99 - // Only add tablet CSS if it differs from desktop
100 - if ( $tablet_raw !== $desktop_raw ) {
101 - $addToCssBlocks( 'tablet', $this->get_breakpoint( 'tablet' ), $tablet_css );
155 + if ( empty( $class_style['responsive_styles'] ) ) {
156 + // Standard path (no custom breakpoints) — unchanged output.
157 + if ( $tablet_raw !== $desktop_raw ) {
158 + $addToCssBlocks( 'tablet', $this->get_breakpoint( 'tablet' ), $tablet_css );
159 + }
160 + if ( $mobile_raw !== $tablet_raw ) {
161 + $addToCssBlocks( 'mobile', $this->get_breakpoint( 'mobile' ), $mobile_css );
162 + }
163 + } else {
164 + // Custom breakpoints present: emit every breakpoint width-descending
165 + // (narrowest last so it wins), each deduped against what it inherits.
166 + $bp_defaults = \ABlocks\Helper::get_breakpoints();
167 + $bp_list = [
168 + [ 'width' => $bp_defaults['tablet'], 'min' => 0, 'max' => $bp_defaults['tablet'], 'styles' => $class_style['tablet_styles'] ],
169 + [ 'width' => $bp_defaults['mobile'], 'min' => 0, 'max' => $bp_defaults['mobile'], 'styles' => $class_style['mobile_styles'] ],
170 + ];
171 + foreach ( $class_style['responsive_styles'] as $bp ) {
172 + $bp_list[] = [
173 + 'width' => (int) $bp['width'],
174 + 'min' => isset( $bp['min'] ) ? (int) $bp['min'] : 0,
175 + 'max' => isset( $bp['max'] ) ? (int) $bp['max'] : (int) $bp['width'],
176 + 'styles' => $bp['styles'],
177 + ];
178 + }
179 + usort( $bp_list, function ( $a, $b ) {
180 + return (int) $b['width'] - (int) $a['width'];
181 + } );
182 + $emitted = [];
183 + foreach ( $bp_list as $i => $bp ) {
184 + // Dedupe against what this breakpoint inherits — desktop plus every
185 + // wider breakpoint whose range contains it — not desktop alone, so an
186 + // explicit value that equals desktop's still overrides a wider
187 + // custom breakpoint's.
188 + $parent = $desktop_styles;
189 + for ( $j = 0; $j < $i; $j++ ) {
190 + if ( \ABlocks\Helper::breakpoint_contains( $bp_list[ $j ], $bp ) ) {
191 + $parent = array_merge( $parent, $emitted[ $j ] );
192 + }
193 + }
194 + $bp_styles = $this->filter_responsive_styles( $parent, $bp['styles'] );
195 + $emitted[ $i ] = $bp_styles;
196 + $bp_raw = $this->generate_css_for_media_query( 'bp', $bp_styles );
197 + if ( '' === trim( $bp_raw ) ) {
198 + continue;
199 + }
200 + $bp_css = AssetsGenerator::minify_css( $bp_raw );
201 + $media = \ABlocks\Helper::breakpoint_media_condition( $bp['min'], $bp['max'] );
202 + if ( '' === $bp_css || '' === $media ) {
203 + continue;
204 + }
205 + $css_blocks[] = "@media screen and $media {\n$parent_selector {\n$bp_css\n}\n}";
206 + }
102 207 }
103 208
104 - // Only add mobile CSS if it differs from desktop AND tablet
105 - if ( $mobile_raw !== $tablet_raw ) {
106 - $addToCssBlocks( 'mobile', $this->get_breakpoint( 'mobile' ), $mobile_css );
107 - }
108 -
109 209 $css_output .= implode( "\n\n", $css_blocks ) . "\n\n";
110 210 }//end foreach
111 211
112 212 $css_output .= $this->get_custom_css();
@@ -121,8 +221,12 @@
121 221 return '';
122 222 }
123 223 $css_string = implode("\n", array_map(
124 224 function ( $property, $value ) {
225 + // See Helper::esc_css_value(): these values come from block
226 + // attributes and land inside an inline <style> element.
227 + $property = \ABlocks\Helper::esc_css_value( $property );
228 + $value = \ABlocks\Helper::esc_css_value( $value );
125 229 return "$property: $value;";
126 230 },
127 231 array_keys( $styles ),
128 232 $styles
@@ -131,13 +235,14 @@
131 235 return $css_string . "\n";
132 236 }
133 237
134 238 public function get_breakpoint( $media_query ) {
239 + $bp = \ABlocks\Helper::get_breakpoints();
135 240 switch ( $media_query ) {
136 241 case 'tablet':
137 - return '800px';
242 + return $bp['tablet'] . 'px';
138 243 case 'mobile':
139 - return '480px';
244 + return $bp['mobile'] . 'px';
140 245 default:
141 246 return '1200px';
142 247 }
143 248 }
@@ -153,15 +258,17 @@
153 258
154 259 $styles = [];
155 260
156 261 foreach ( $base_styles as $prop => $value ) {
157 - if ( 'font-family' === $prop && isset( $this->font_category[ $value ] ) ) {
158 - $value = $this->get_font_family_css( $value, $this->font_category[ $value ] );
262 + if ( 'font-family' === $prop ) {
263 + // Safety net for styles that bypass the Typography control and set a
264 + // bare family name directly. FontStack leaves finished values alone.
265 + $value = FontStack::build( $value );
159 266 }
160 267 // Trim value to avoid whitespace-only entries
161 268 $trimmed = trim( $value );
162 269 // // Remove if empty, or if it matches only a unit (like 'px', '%', 'em') without any number
163 - if ( $trimmed === '' || preg_match( '/^(px|em|rem|vh|vw|vmin|vmax|cm|mm|in|pt|pc|%)$/i', $trimmed ) ) {
270 + if ( $trimmed === '' || preg_match( '/^(px|em|rem|vh|vw|vmin|vmax|cm|mm|in|pt|pc|%|s|ms|deg|fr|ch|ex)$/i', $trimmed ) ) {
164 271 continue;
165 272 }
166 273
167 274 $styles[ $prop ] = $trimmed;
@@ -180,9 +287,9 @@
180 287 foreach ( $responsive_styles as $prop => $value ) {
181 288 $trimmed = trim( $value );
182 289
183 290 // // Remove if empty, or if it matches only a unit (like 'px', '%', 'em') without any number
184 - if ( $trimmed === '' || preg_match( '/^(px|em|rem|vh|vw|vmin|vmax|cm|mm|in|pt|pc|%)$/i', $trimmed ) ) {
291 + if ( $trimmed === '' || preg_match( '/^(px|em|rem|vh|vw|vmin|vmax|cm|mm|in|pt|pc|%|s|ms|deg|fr|ch|ex)$/i', $trimmed ) ) {
185 292 continue;
186 293 }
187 294
188 295 // Only include if the value is different from base styles
@@ -194,35 +301,10 @@
194 301 return $difference;
195 302 }
196 303
197 304
198 - public function get_font_family_css( string $font_name, string $category ): string {
199 - // Quote font name if it contains spaces
200 - if ( strpos( $font_name, ' ' ) !== false ) {
201 - $font_name = '"' . $font_name . '"';
202 - }
203 -
204 - // Map category to fallback
205 - switch ( $category ) {
206 - case 'serif':
207 - $fallback = 'serif';
208 - break;
209 - case 'sans-serif':
210 - $fallback = 'sans-serif';
211 - break;
212 - case 'monospace':
213 - $fallback = 'monospace';
214 - break;
215 - case 'display':
216 - $fallback = 'sans-serif';
217 - break;
218 - case 'handwriting':
219 - $fallback = 'cursive';
220 - break;
221 - default:
222 - $fallback = 'sans-serif';
223 - }
224 -
225 - return $font_name . ', ' . $fallback;
305 + public function get_font_family_css( string $font_name, string $category = '' ): string {
306 + // Kept for back-compat; the stack is built centrally now.
307 + return FontStack::build( $font_name );
226 308 }
227 309 }
228 310