← All changes | includes/handler/class-undo.php +27 -79 9.3.1 → 2.6.0 View file →

		@@ -1,102 +1,50 @@
1	1	<?php
2		-/**
3		- * Undo handler file.
4		- *
5		- * @package Activitypub
6		- */
7		-
8	2	namespace Activitypub\Handler;
9	3
10		-use Activitypub\Collection\Inbox as Inbox_Collection;
	4	+use Activitypub\Collection\Users;
	5	+use Activitypub\Collection\Followers;
11	6
12	7	use function Activitypub\object_to_uri;
13	8
14	9	/**
15		- * Handle Undo requests.
	10	+ * Handle Undo requests
16	11	*/
17	12	class Undo {
18	13	/**
19		- * Initialize the class, registering WordPress hooks.
	14	+ * Initialize the class, registering WordPress hooks
20	15	*/
21	16	public static function init() {
22		- \add_action( 'activitypub_inbox_undo', array( self::class, 'handle_undo' ), 10, 2 );
23		- \add_action( 'activitypub_validate_object', array( self::class, 'validate_object' ), 10, 3 );
	17	+ \add_action(
	18	+ 'activitypub_inbox_undo',
	19	+ array( self::class, 'handle_undo' )
	20	+ );
24	21	}
25	22
26	23	/**
27		- * Handle "Unfollow" requests.
	24	+ * Handle "Unfollow" requests
28	25	*
29		- * @param array $activity The JSON "Undo" Activity.
30		- * @param int|int[]|null $user_ids The user ID(s).
	26	+ * @param array $activity The JSON "Undo" Activity
	27	+ * @param int $user_id The ID of the ID of the WordPress User
31	28	*/
32		- public static function handle_undo( $activity, $user_ids ) {
33		- $success = false;
	29	+ public static function handle_undo( $activity ) {
	30	+ if (
	31	+ isset( $activity['object']['type'] ) &&
	32	+ 'Follow' === $activity['object']['type'] &&
	33	+ isset( $activity['object']['object'] )
	34	+ ) {
	35	+ $user_id = object_to_uri( $activity['object']['object'] );
	36	+ $user = Users::get_by_resource( $user_id );
34	37
35		- /*
36		- * Resolve the sender so Inbox::undo() can verify ownership. A genuinely absent actor
37		- * maps to null (no ownership check, for programmatic callers), but an actor that is
38		- * present yet unparseable must be rejected rather than skipping the check — passing
39		- * null there would re-open the undo-by-id attack.
40		- */
41		- $actor = isset( $activity['actor'] ) ? object_to_uri( $activity['actor'] ) : null;
	38	+ if ( ! $user || is_wp_error( $user ) ) {
	39	+ // If we can not find a user,
	40	+ // we can not initiate a follow process
	41	+ return;
	42	+ }
42	43
43		- if ( isset( $activity['actor'] ) && empty( $actor ) ) {
44		- $result = new \WP_Error(
45		- 'activitypub_undo_invalid_actor',
46		- \__( 'The Undo activity has an invalid actor.', 'activitypub' ),
47		- array( 'status' => 400 )
48		- );
49		- } else {
50		- $result = Inbox_Collection::undo( object_to_uri( $activity['object'] ), $actor );
51		- }
	44	+ $user_id = $user->get__id();
	45	+ $actor = object_to_uri( $activity['actor'] );
52	46
53		- if ( $result && ! \is_wp_error( $result ) ) {
54		- $success = true;
	47	+ Followers::remove_follower( $user_id, $actor );
55	48	}
56		-
57		- /**
58		- * Fires after an ActivityPub Undo activity has been handled.
59		- *
60		- * @param array $activity The ActivityPub activity data.
61		- * @param int[] $user_ids The local user IDs.
62		- * @param bool $success True on success, false on failure.
63		- * @param \WP_Comment|string $result The target, based on the activity that is being undone.
64		- */
65		- \do_action( 'activitypub_handled_undo', $activity, (array) $user_ids, $success, $result );
66		- }
67		-
68		- /**
69		- * Validate the object.
70		- *
71		- * @param bool $valid The validation state.
72		- * @param string $param The object parameter.
73		- * @param \WP_REST_Request $request The request object.
74		- *
75		- * @return bool The validation state: true if valid, false if not.
76		- */
77		- public static function validate_object( $valid, $param, $request ) {
78		- $activity = $request->get_json_params();
79		-
80		- if ( empty( $activity['type'] ) ) {
81		- return false;
82		- }
83		-
84		- if ( 'Undo' !== $activity['type'] ) {
85		- return $valid;
86		- }
87		-
88		- if ( ! isset( $activity['actor'], $activity['object'] ) ) {
89		- return false;
90		- }
91		-
92		- if ( ! \is_array( $activity['object'] ) && ! \is_string( $activity['object'] ) ) {
93		- return false;
94		- }
95		-
96		- if ( \is_array( $activity['object'] ) && ! isset( $activity['object']['id'] ) ) {
97		- return false;
98		- }
99		-
100		- return $valid;
101	49	}
102	50	}