| @@ -54,9 +54,9 @@ | ||
| 54 | 54 | |
| 55 | 55 | return $results; |
| 56 | 56 | } |
| 57 | 57 | |
| 58 | - public function getOneById($id) | |
| 58 | + public function getOneById(int $id): ?object | |
| 59 | 59 | { |
| 60 | 60 | $segment = parent::getOneById($id); |
| 61 | 61 | |
| 62 | 62 | if (!empty($segment)) { |
| @@ -65,22 +65,24 @@ | ||
| 65 | 65 | |
| 66 | 66 | return $segment; |
| 67 | 67 | } |
| 68 | 68 | |
| 69 | - public function getByIds($ids) | |
| 69 | + public function getByIds(array $ids): array | |
| 70 | 70 | { |
| 71 | 71 | $segments = parent::getByIds($ids); |
| 72 | 72 | |
| 73 | - if (empty($segments)) return []; | |
| 73 | + if (empty($segments)) { | |
| 74 | + return []; | |
| 75 | + } | |
| 74 | 76 | |
| 75 | - foreach ($segments as $key => $segment) { | |
| 76 | - $segments[$key]->filters = empty($segment->filters) ? [] : json_decode($segment->filters, true); | |
| 77 | + foreach ($segments as $segment) { | |
| 78 | + $segment->filters = empty($segment->filters) ? [] : json_decode($segment->filters, true); | |
| 77 | 79 | } |
| 78 | 80 | |
| 79 | 81 | return $segments; |
| 80 | 82 | } |
| 81 | 83 | |
| 82 | - public function getAllForSelect($firstEmpty = true) | |
| 84 | + public function getAllForSelect(bool $firstEmpty = true): array | |
| 83 | 85 | { |
| 84 | 86 | $segments = acym_loadObjectList('SELECT * FROM #__acym_segment WHERE active = 1'); |
| 85 | 87 | |
| 86 | 88 | if ($firstEmpty) { |
| @@ -97,9 +99,9 @@ | ||
| 97 | 99 | |
| 98 | 100 | return $return; |
| 99 | 101 | } |
| 100 | 102 | |
| 101 | - public function updateSegments() | |
| 103 | + public function updateSegments(): void | |
| 102 | 104 | { |
| 103 | 105 | $segments = $this->getAll(); |
| 104 | 106 | |
| 105 | 107 | if (empty($segments)) return; |