| @@ -46,96 +46,8 @@ | ||
| 46 | 46 | } |
| 47 | 47 | |
| 48 | 48 | } |
| 49 | 49 | |
| 50 | - /** | |
| 51 | - * Get the relative admin path without subdirectory prefix | |
| 52 | - * Handles root, subdirectory, subdomain, and multisite installations | |
| 53 | - * | |
| 54 | - * @return string Normalized path (e.g., /wp-admin/edit.php) | |
| 55 | - */ | |
| 56 | - private function get_normalized_admin_path() { | |
| 57 | - $php_self = $_SERVER['PHP_SELF'] ?? ''; | |
| 58 | - | |
| 59 | - // Method 1: Use WordPress native function to get subdirectory path | |
| 60 | - // site_url() returns full URL including subdirectory | |
| 61 | - // e.g., https://example.com/blog or https://example.com | |
| 62 | - $site_url_path = wp_parse_url( site_url(), PHP_URL_PATH ); | |
| 63 | - | |
| 64 | - // Remove subdirectory prefix if exists | |
| 65 | - if ( ! empty( $site_url_path ) && $site_url_path !== '/' ) { | |
| 66 | - // Ensure path starts with subdirectory | |
| 67 | - if ( strpos( $php_self, $site_url_path ) === 0 ) { | |
| 68 | - $php_self = substr( $php_self, strlen( $site_url_path ) ); | |
| 69 | - } | |
| 70 | - } | |
| 71 | - | |
| 72 | - // Ensure path starts with / | |
| 73 | - if ( empty( $php_self ) || $php_self[0] !== '/' ) { | |
| 74 | - $php_self = '/' . $php_self; | |
| 75 | - } | |
| 76 | - | |
| 77 | - return $php_self; | |
| 78 | - } | |
| 79 | - | |
| 80 | - /** | |
| 81 | - * Check if current path matches the blocked URL pattern | |
| 82 | - * Supports exact match and ends-with matching for subdirectory compatibility | |
| 83 | - * | |
| 84 | - * @param string $blocked_url The URL pattern to check against | |
| 85 | - * @return bool True if current path matches the blocked URL | |
| 86 | - */ | |
| 87 | - private function matches_blocked_url( $blocked_url ) { | |
| 88 | - $current_path = $this->get_normalized_admin_path(); | |
| 89 | - | |
| 90 | - // Exact match (normalized) | |
| 91 | - if ( $current_path === $blocked_url ) { | |
| 92 | - return true; | |
| 93 | - } | |
| 94 | - | |
| 95 | - // Fallback: ends-with check for edge cases | |
| 96 | - // e.g., /wp-admin/customize.php should match even if normalization fails | |
| 97 | - if ( $this->url_ends_with( $_SERVER['PHP_SELF'] ?? '', $blocked_url ) ) { | |
| 98 | - return true; | |
| 99 | - } | |
| 100 | - | |
| 101 | - return false; | |
| 102 | - } | |
| 103 | - | |
| 104 | - /** | |
| 105 | - * Check if a URL ends with a specific path | |
| 106 | - * Useful for subdirectory WordPress installs | |
| 107 | - * | |
| 108 | - * @param string $url Full URL or path to check | |
| 109 | - * @param string $ending The ending pattern to match | |
| 110 | - * @return bool | |
| 111 | - */ | |
| 112 | - private function url_ends_with( $url, $ending ) { | |
| 113 | - $ending_length = strlen( $ending ); | |
| 114 | - if ( $ending_length === 0 ) { | |
| 115 | - return true; | |
| 116 | - } | |
| 117 | - return substr( $url, -$ending_length ) === $ending; | |
| 118 | - } | |
| 119 | - | |
| 120 | - /** | |
| 121 | - * Get WordPress installation context for debugging | |
| 122 | - * | |
| 123 | - * @return array Installation details | |
| 124 | - */ | |
| 125 | - public function get_install_context() { | |
| 126 | - return [ | |
| 127 | - 'is_multisite' => is_multisite(), | |
| 128 | - 'is_subdomain' => defined( 'SUBDOMAIN_INSTALL' ) && SUBDOMAIN_INSTALL, | |
| 129 | - 'site_url' => site_url(), | |
| 130 | - 'home_url' => home_url(), | |
| 131 | - 'admin_url' => admin_url(), | |
| 132 | - 'subdirectory' => wp_parse_url( site_url(), PHP_URL_PATH ) ?: '/', | |
| 133 | - 'php_self' => $_SERVER['PHP_SELF'] ?? '', | |
| 134 | - 'normalized_path' => $this->get_normalized_admin_path(), | |
| 135 | - ]; | |
| 136 | - } | |
| 137 | - | |
| 138 | 50 | public function is_allowed() { |
| 139 | 51 | |
| 140 | 52 | $not_allowed_urls = Admin::get_not_allowed_urls(); |
| 141 | 53 | |
| @@ -142,39 +54,26 @@ | ||
| 142 | 54 | foreach ( $not_allowed_urls as $url_object ) { |
| 143 | 55 | if ( is_string( $url_object ) ) { |
| 144 | 56 | |
| 145 | 57 | $is_allowed = true; // Scoped Default allowed |
| 146 | - // Use normalized path matching for subdirectory compatibility | |
| 147 | - if ( $this->matches_blocked_url( $url_object ) ) { | |
| 148 | - $is_allowed = false; // not allowed | |
| 149 | - } | |
| 58 | + if ( $url_object === $_SERVER['PHP_SELF'] ) $is_allowed = false; // not allowed | |
| 150 | 59 | |
| 151 | 60 | } else { |
| 152 | 61 | |
| 153 | 62 | $is_allowed = false; // Scoped Default not allowed |
| 154 | 63 | |
| 155 | - // Use normalized path matching for subdirectory compatibility | |
| 156 | - if ( $url_object['url'] !== '*' && ! $this->matches_blocked_url( $url_object['url'] ) ) { | |
| 157 | - $is_allowed = true; // allowed | |
| 158 | - } | |
| 159 | - | |
| 64 | + if ( $url_object['url'] !== '*' && $url_object['url'] !== $_SERVER['PHP_SELF'] ) $is_allowed = true; // allowed | |
| 160 | 65 | if ( ! $is_allowed && array_key_exists( 'query_params', $url_object ) ) { |
| 161 | - if ( ! $this->check_query_params( $url_object['query_params'] ) ) { | |
| 162 | - $is_allowed = true; // allowed | |
| 163 | - } | |
| 66 | + if ( ! $this->check_query_params( $url_object['query_params'] ) ) $is_allowed = true; // allowed | |
| 164 | 67 | } |
| 165 | 68 | |
| 166 | 69 | if ( ! $is_allowed && array_key_exists( 'post_type', $url_object ) ) { |
| 167 | - if ( ! $this->check_post_type( $url_object['post_type'] ) ) { | |
| 168 | - $is_allowed = true; // allowed | |
| 169 | - } | |
| 70 | + if ( ! $this->check_post_type( $url_object['post_type'] ) ) $is_allowed = true; // allowed | |
| 170 | 71 | } |
| 171 | 72 | |
| 172 | 73 | } |
| 173 | 74 | |
| 174 | - if ( ! $is_allowed ) { | |
| 175 | - return $is_allowed; | |
| 176 | - } | |
| 75 | + if ( ! $is_allowed ) return $is_allowed; | |
| 177 | 76 | |
| 178 | 77 | } |
| 179 | 78 | |
| 180 | 79 | return true; |