| @@ -45,8 +45,26 @@ | ||
| 45 | 45 | case '2.2': |
| 46 | 46 | $this->upgrade_from_2_2(); |
| 47 | 47 | $major_update = true; |
| 48 | 48 | // No break, intentionally, so all upgrades are ran during a single request... |
| 49 | + case '2.4': | |
| 50 | + if ( autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' ) == '2.4.2' ) { | |
| 51 | + $this->upgrade_from_2_4_2(); | |
| 52 | + } | |
| 53 | + $this->upgrade_from_2_4(); | |
| 54 | + $major_update = false; | |
| 55 | + // No break, intentionally, so all upgrades are ran during a single request... | |
| 56 | + case '2.7': | |
| 57 | + $this->upgrade_from_2_7(); | |
| 58 | + $major_update = true; | |
| 59 | + // No break, intentionally, so all upgrades are ran during a single request... | |
| 60 | + case '2.8': | |
| 61 | + // nothing | |
| 62 | + case '2.9': | |
| 63 | + if ( version_compare( autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' ), '2.9.999', 'lt' ) ) { | |
| 64 | + $this->upgrade_from_2_9_before_compatibility(); | |
| 65 | + } | |
| 66 | + $major_update = false; | |
| 49 | 67 | } |
| 50 | 68 | |
| 51 | 69 | if ( true === $major_update ) { |
| 52 | 70 | $this->on_major_version_update(); |
| @@ -61,9 +79,9 @@ | ||
| 61 | 79 | * @param string $target Target version to check against (ie., the currently running one). |
| 62 | 80 | */ |
| 63 | 81 | public static function check_installed_and_update( $target ) |
| 64 | 82 | { |
| 65 | - $db_version = get_option( 'autoptimize_version', 'none' ); | |
| 83 | + $db_version = autoptimizeOptionWrapper::get_option( 'autoptimize_version', 'none' ); | |
| 66 | 84 | if ( $db_version !== $target ) { |
| 67 | 85 | if ( 'none' === $db_version ) { |
| 68 | 86 | add_action( 'admin_notices', 'autoptimizeMain::notice_installed' ); |
| 69 | 87 | } else { |
| @@ -71,9 +89,9 @@ | ||
| 71 | 89 | $updater->run_needed_major_upgrades(); |
| 72 | 90 | } |
| 73 | 91 | |
| 74 | 92 | // Versions differed, upgrades happened if needed, store the new version. |
| 75 | - update_option( 'autoptimize_version', $target ); | |
| 93 | + autoptimizeOptionWrapper::update_option( 'autoptimize_version', $target ); | |
| 76 | 94 | } |
| 77 | 95 | } |
| 78 | 96 | |
| 79 | 97 | /** |
| @@ -95,9 +113,9 @@ | ||
| 95 | 113 | */ |
| 96 | 114 | private function upgrade_from_1_6() |
| 97 | 115 | { |
| 98 | 116 | // If user was on version 1.6.x, force advanced options to be shown by default. |
| 99 | - update_option( 'autoptimize_show_adv', '1' ); | |
| 117 | + autoptimizeOptionWrapper::update_option( 'autoptimize_show_adv', '1' ); | |
| 100 | 118 | |
| 101 | 119 | // And remove old options. |
| 102 | 120 | $to_delete_options = array( |
| 103 | 121 | 'autoptimize_cdn_css', |
| @@ -120,15 +138,15 @@ | ||
| 120 | 138 | */ |
| 121 | 139 | private function upgrade_from_1_7() |
| 122 | 140 | { |
| 123 | 141 | if ( ! is_multisite() ) { |
| 124 | - $css_exclude = get_option( 'autoptimize_css_exclude' ); | |
| 142 | + $css_exclude = autoptimizeOptionWrapper::get_option( 'autoptimize_css_exclude' ); | |
| 125 | 143 | if ( empty( $css_exclude ) ) { |
| 126 | 144 | $css_exclude = 'admin-bar.min.css, dashicons.min.css'; |
| 127 | 145 | } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) { |
| 128 | 146 | $css_exclude .= ', dashicons.min.css'; |
| 129 | 147 | } |
| 130 | - update_option( 'autoptimize_css_exclude', $css_exclude ); | |
| 148 | + autoptimizeOptionWrapper::update_option( 'autoptimize_css_exclude', $css_exclude ); | |
| 131 | 149 | } else { |
| 132 | 150 | global $wpdb; |
| 133 | 151 | $blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" ); |
| 134 | 152 | $original_blog_id = get_current_blog_id(); |
| @@ -133,15 +151,15 @@ | ||
| 133 | 151 | $blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" ); |
| 134 | 152 | $original_blog_id = get_current_blog_id(); |
| 135 | 153 | foreach ( $blog_ids as $blog_id ) { |
| 136 | 154 | switch_to_blog( $blog_id ); |
| 137 | - $css_exclude = get_option( 'autoptimize_css_exclude' ); | |
| 155 | + $css_exclude = autoptimizeOptionWrapper::get_option( 'autoptimize_css_exclude' ); | |
| 138 | 156 | if ( empty( $css_exclude ) ) { |
| 139 | 157 | $css_exclude = 'admin-bar.min.css, dashicons.min.css'; |
| 140 | 158 | } elseif ( false === strpos( $css_exclude, 'dashicons.min.css' ) ) { |
| 141 | 159 | $css_exclude .= ', dashicons.min.css'; |
| 142 | 160 | } |
| 143 | - update_option( 'autoptimize_css_exclude', $css_exclude ); | |
| 161 | + autoptimizeOptionWrapper::update_option( 'autoptimize_css_exclude', $css_exclude ); | |
| 144 | 162 | } |
| 145 | 163 | switch_to_blog( $original_blog_id ); |
| 146 | 164 | } |
| 147 | 165 | } |
| @@ -154,10 +172,10 @@ | ||
| 154 | 172 | */ |
| 155 | 173 | private function upgrade_from_1_9() |
| 156 | 174 | { |
| 157 | 175 | if ( ! is_multisite() ) { |
| 158 | - update_option( 'autoptimize_css_include_inline', 'on' ); | |
| 159 | - update_option( 'autoptimize_js_include_inline', 'on' ); | |
| 176 | + autoptimizeOptionWrapper::update_option( 'autoptimize_css_include_inline', 'on' ); | |
| 177 | + autoptimizeOptionWrapper::update_option( 'autoptimize_js_include_inline', 'on' ); | |
| 160 | 178 | } else { |
| 161 | 179 | global $wpdb; |
| 162 | 180 | $blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" ); |
| 163 | 181 | $original_blog_id = get_current_blog_id(); |
| @@ -162,10 +180,10 @@ | ||
| 162 | 180 | $blog_ids = $wpdb->get_col( "SELECT blog_id FROM $wpdb->blogs" ); |
| 163 | 181 | $original_blog_id = get_current_blog_id(); |
| 164 | 182 | foreach ( $blog_ids as $blog_id ) { |
| 165 | 183 | switch_to_blog( $blog_id ); |
| 166 | - update_option( 'autoptimize_css_include_inline', 'on' ); | |
| 167 | - update_option( 'autoptimize_js_include_inline', 'on' ); | |
| 184 | + autoptimizeOptionWrapper::update_option( 'autoptimize_css_include_inline', 'on' ); | |
| 185 | + autoptimizeOptionWrapper::update_option( 'autoptimize_js_include_inline', 'on' ); | |
| 168 | 186 | } |
| 169 | 187 | switch_to_blog( $original_blog_id ); |
| 170 | 188 | } |
| 171 | 189 | } |
| @@ -195,12 +213,72 @@ | ||
| 195 | 213 | * Helper for 2.2 autoptimize_extra_settings upgrade to avoid duplicate code |
| 196 | 214 | */ |
| 197 | 215 | private function do_2_2_settings_update() |
| 198 | 216 | { |
| 199 | - $nogooglefont = get_option( 'autoptimize_css_nogooglefont', '' ); | |
| 200 | - $ao_extrasetting = get_option( 'autoptimize_extra_settings', '' ); | |
| 217 | + $nogooglefont = autoptimizeOptionWrapper::get_option( 'autoptimize_css_nogooglefont', '' ); | |
| 218 | + $ao_extrasetting = autoptimizeOptionWrapper::get_option( 'autoptimize_extra_settings', '' ); | |
| 201 | 219 | if ( ( $nogooglefont ) && ( empty( $ao_extrasetting ) ) ) { |
| 202 | - update_option( 'autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options() ); | |
| 220 | + autoptimizeOptionWrapper::update_option( 'autoptimize_extra_settings', autoptimizeConfig::get_ao_extra_default_options() ); | |
| 203 | 221 | } |
| 204 | 222 | delete_option( 'autoptimize_css_nogooglefont' ); |
| 223 | + } | |
| 224 | + | |
| 225 | + /** | |
| 226 | + * 2.4.2 introduced too many cronned ao_cachecheckers, make this right | |
| 227 | + */ | |
| 228 | + private function upgrade_from_2_4_2() { | |
| 229 | + // below code by Thomas Sjolshagen (http://eighty20results.com/) | |
| 230 | + // as found on https://www.paidmembershipspro.com/deleting-oldextra-cron-events/. | |
| 231 | + $jobs = _get_cron_array(); | |
| 232 | + | |
| 233 | + // Remove all ao_cachechecker cron jobs (for now). | |
| 234 | + foreach ( $jobs as $when => $job ) { | |
| 235 | + $name = key( $job ); | |
| 236 | + | |
| 237 | + if ( false !== strpos( $name, 'ao_cachechecker' ) ) { | |
| 238 | + unset( $jobs[ $when ] ); | |
| 239 | + } | |
| 240 | + } | |
| 241 | + | |
| 242 | + // Save the data. | |
| 243 | + _set_cron_array( $jobs ); | |
| 244 | + } | |
| 245 | + | |
| 246 | + /** | |
| 247 | + * Migrate imgopt options from autoptimize_extra_settings to autoptimize_imgopt_settings | |
| 248 | + */ | |
| 249 | + private function upgrade_from_2_4() { | |
| 250 | + $extra_settings = autoptimizeOptionWrapper::get_option( 'autoptimize_extra_settings', '' ); | |
| 251 | + $imgopt_settings = autoptimizeOptionWrapper::get_option( 'autoptimize_imgopt_settings', '' ); | |
| 252 | + if ( empty( $imgopt_settings ) && ! empty( $extra_settings ) ) { | |
| 253 | + $imgopt_settings = autoptimizeConfig::get_ao_imgopt_default_options(); | |
| 254 | + if ( array_key_exists( 'autoptimize_extra_checkbox_field_5', $extra_settings ) ) { | |
| 255 | + $imgopt_settings['autoptimize_imgopt_checkbox_field_1'] = $extra_settings['autoptimize_extra_checkbox_field_5']; | |
| 256 | + } | |
| 257 | + if ( array_key_exists( 'autoptimize_extra_select_field_6', $extra_settings ) ) { | |
| 258 | + $imgopt_settings['autoptimize_imgopt_select_field_2'] = $extra_settings['autoptimize_extra_select_field_6']; | |
| 259 | + } | |
| 260 | + autoptimizeOptionWrapper::update_option( 'autoptimize_imgopt_settings', $imgopt_settings ); | |
| 261 | + } | |
| 262 | + } | |
| 263 | + | |
| 264 | + /** | |
| 265 | + * remove CCSS request limit option + update jquery exclusion to include WordPress 5.6 jquery.min.js. | |
| 266 | + */ | |
| 267 | + private function upgrade_from_2_7() { | |
| 268 | + delete_option( 'autoptimize_ccss_rlimit' ); | |
| 269 | + $js_exclusions = get_option( 'autoptimize_js_exclude', '' ); | |
| 270 | + if ( strpos( $js_exclusions, 'js/jquery/jquery.js' ) !== false && strpos( $js_exclusions, 'js/jquery/jquery.min.js' ) === false ) { | |
| 271 | + $js_exclusions .= ', js/jquery/jquery.min.js'; | |
| 272 | + autoptimizeOptionWrapper::update_option( 'autoptimize_js_exclude', $js_exclusions ); | |
| 273 | + } | |
| 274 | + } | |
| 275 | + | |
| 276 | + /** | |
| 277 | + * set an option to indicate the AO installation predates the compatibility logic, this way we | |
| 278 | + * can avoid adding compatibility code that is likely not needed and maybe not wanted as it | |
| 279 | + * can introduce performance regressions. | |
| 280 | + */ | |
| 281 | + private function upgrade_from_2_9_before_compatibility() { | |
| 282 | + autoptimizeOptionWrapper::update_option( 'autoptimize_installed_before_compatibility', true ); | |
| 205 | 283 | } |
| 206 | 284 | } |