← All changes | includes/features/bbp_voting/helpers.php +134 -20 1.3.2 → 2.5.1 View file →

		@@ -35,46 +35,44 @@
35	35
36	36
37	37	if ( ! function_exists( 'bbp_voting_field' ) ) {
38	38	function bbp_voting_field( $key, $name, $label = '', $description = '', $type = 'bool', $pro = false ) {
39		- $name_and_id = 'name="' . $key . '" id="' . $key . '"';
	39	+ $name_and_id = 'name="' . esc_attr( $key ) . '" id="' . esc_attr( $key ) . '"';
40	40	$teaser = defined( 'BBPVOTINGPRO' ) ? false : $pro;
41	41	$attributes = $teaser ? 'disabled' : $name_and_id;
42	42	?>
43	43	<tr valign="top">
44	44	<th scope="row">
45		- <?php echo $name; ?>:
	45	+ <?php echo esc_html( $name ); ?>:
46	46	<?php if ( $pro ) { ?>
47		- <a href="https://wpforthewin.com/product/bbpress-voting-pro/" target="_blank"><span class="bbp-voting-pro-badge bbp-voting-pro-green">Pro</span></a>
	47	+ <a href="<?php echo esc_url( 'https://wpforthewin.com/product/bbpress-voting-pro/' ); ?>" target="_blank" rel="noopener noreferrer">
	48	+ <span class="bbp-voting-pro-badge bbp-voting-pro-green">Pro</span>
	49	+ </a>
48	50	<?php } ?>
49	51	</th>
50	52	<td>
51		- <?php if ( $type == 'bool' ) { ?>
52		- <input type="checkbox" <?php echo $attributes; ?> value="true"
53		- <?php
54		- if ( get_option( $key ) == 'true' ) {
55		- echo 'checked';}
56		- ?>
57		- />
	53	+ <?php if ( $type === 'bool' ) { ?>
	54	+ <input type="checkbox" <?php echo wp_kses_post( $attributes ); ?> value="true"
	55	+ <?php checked( get_option( $key ), 'true' ); ?> />
58	56	<?php } elseif ( is_array( $type ) ) { ?>
59		- <select <?php echo $attributes; ?>>
	57	+ <select <?php echo wp_kses_post( $attributes ); ?>>
60	58	<?php foreach ( $type as $option ) { ?>
61		- <option value="<?php echo $option; ?>"
62		- <?php
63		- if ( get_option( $key ) == $option ) {
64		- echo ' selected';}
65		- ?>
66		- ><?php echo ucwords( str_replace( '-', ' ', $option ) ); ?></option>
	59	+ <option value="<?php echo esc_attr( $option ); ?>" <?php selected( get_option( $key ), $option ); ?>>
	60	+ <?php echo esc_html( ucwords( str_replace( '-', ' ', $option ) ) ); ?>
	61	+ </option>
67	62	<?php } ?>
68	63	</select>
69	64	<?php } else { ?>
70		- <input type="<?php echo $type; ?>" <?php echo $attributes; ?> value="<?php echo get_option( $key ); ?>" data-lpignore="true" />
	65	+ <input type="<?php echo esc_attr( $type ); ?>" <?php echo wp_kses_post( $attributes ); ?>
	66	+ value="<?php echo esc_attr( get_option( $key ) ); ?>" data-lpignore="true" />
71	67	<?php } ?>
	68	+
72	69	<?php if ( ! empty( $label ) ) { ?>
73		- <label for="<?php echo $key; ?>"><?php echo $label; ?></label>
	70	+ <label for="<?php echo esc_attr( $key ); ?>"><?php echo esc_html( $label ); ?></label>
74	71	<?php } ?>
	72	+
75	73	<?php if ( ! empty( $description ) ) { ?>
76		- <p class="description"><?php echo $description; ?></p>
	74	+ <p class="description"><?php echo wp_kses_post( $description ); ?></p>
77	75	<?php } ?>
78	76	</td>
79	77	</tr>
80	78	<?php
		@@ -153,6 +151,122 @@
153	151	}
154	152
155	153	// Return the parsed results
156	154	return $r;
	155	+ }
	156	+}
	157	+
	158	+
	159	+if ( ! function_exists( 'forumax_init_voting_scores' ) ) {
	160	+ /**
	161	+ * Initialize voting scores for new topics and replies.
	162	+ *
	163	+ * @param int $post_id Post ID.
	164	+ */
	165	+ function forumax_init_voting_scores( $post_id ) {
	166	+ update_post_meta( $post_id, 'bbp_voting_score', '0' );
	167	+ update_post_meta( $post_id, 'bbp_voting_ups', '0' );
	168	+ update_post_meta( $post_id, 'bbp_voting_downs', '0' );
	169	+ update_post_meta( $post_id, 'bbp_voting_log', [] );
	170	+ }
	171	+ add_action( 'bbp_new_topic', 'forumax_init_voting_scores' );
	172	+ add_action( 'bbp_new_reply', 'forumax_init_voting_scores' );
	173	+}
	174	+
	175	+if ( ! function_exists( 'forumax_ensure_voting_score_meta' ) ) {
	176	+ /**
	177	+ * Give every saved topic/reply a vote score, including ones created in
	178	+ * wp-admin or by importers, so "sort by votes" never drops them.
	179	+ *
	180	+ * @param int $post_id Post ID.
	181	+ */
	182	+ function forumax_ensure_voting_score_meta( $post_id ) {
	183	+ if ( wp_is_post_revision( $post_id ) || wp_is_post_autosave( $post_id ) ) {
	184	+ return;
	185	+ }
	186	+
	187	+ add_post_meta( $post_id, 'bbp_voting_score', '0', true );
	188	+ }
	189	+ add_action( 'save_post_topic', 'forumax_ensure_voting_score_meta' );
	190	+ add_action( 'save_post_reply', 'forumax_ensure_voting_score_meta' );
	191	+}
	192	+
	193	+if ( ! function_exists( 'forumax_backfill_voting_score_meta_once' ) ) {
	194	+ /**
	195	+ * One-time bulk backfill of bbp_voting_score for existing topics/replies.
	196	+ *
	197	+ * Replaces the old per-page-view backfill, which ran an extra query and
	198	+ * stored a new transient for every distinct topic list.
	199	+ */
	200	+ function forumax_backfill_voting_score_meta_once() {
	201	+ if ( get_option( 'forumax_vote_score_backfilled' ) ) {
	202	+ return;
	203	+ }
	204	+
	205	+ global $wpdb;
	206	+
	207	+ // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
	208	+ $wpdb->query(
	209	+ "INSERT INTO {$wpdb->postmeta} ( post_id, meta_key, meta_value )
	210	+ SELECT p.ID, 'bbp_voting_score', '0'
	211	+ FROM {$wpdb->posts} p
	212	+ LEFT JOIN {$wpdb->postmeta} pm ON pm.post_id = p.ID AND pm.meta_key = 'bbp_voting_score'
	213	+ WHERE p.post_type IN ( 'topic', 'reply' ) AND pm.meta_id IS NULL"
	214	+ );
	215	+
	216	+ update_option( 'forumax_vote_score_backfilled', 1 );
	217	+
	218	+ // Drop the transients the old per-page backfill left behind.
	219	+ // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching
	220	+ $wpdb->query(
	221	+ $wpdb->prepare(
	222	+ "DELETE FROM {$wpdb->options} WHERE option_name LIKE %s OR option_name LIKE %s",
	223	+ $wpdb->esc_like( '_transient_frmx_vote_backfill_' ) . '%',
	224	+ $wpdb->esc_like( '_transient_timeout_frmx_vote_backfill_' ) . '%'
	225	+ )
	226	+ );
	227	+ }
	228	+ add_action( 'admin_init', 'forumax_backfill_voting_score_meta_once' );
	229	+}
	230	+
	231	+if ( ! function_exists( 'forumax_backfill_voting_sort_meta' ) ) {
	232	+ /**
	233	+ * Backfill a custom (filtered) sort meta key for the posts of one query.
	234	+ *
	235	+ * Only used when bbp_voting_sort_meta_key points at a non-default key.
	236	+ * Results are remembered in the object cache for the request/day.
	237	+ *
	238	+ * @param string $sort_meta_key Meta key used for sorting.
	239	+ * @param array $args bbPress query args.
	240	+ */
	241	+ function forumax_backfill_voting_sort_meta( $sort_meta_key, $args ) {
	242	+ $cache_key = 'vote_backfill_' . md5( $sort_meta_key . wp_json_encode( $args ) );
	243	+ if ( false !== wp_cache_get( $cache_key, 'forumax' ) ) {
	244	+ return;
	245	+ }
	246	+
	247	+ $query = new WP_Query(
	248	+ array_merge(
	249	+ $args,
	250	+ [
	251	+ 'meta_query' => [
	252	+ [
	253	+ 'key' => $sort_meta_key,
	254	+ 'compare' => 'NOT EXISTS',
	255	+ ],
	256	+ ],
	257	+ 'fields' => 'ids',
	258	+ 'no_found_rows' => true,
	259	+ 'update_post_meta_cache' => false,
	260	+ 'update_post_term_cache' => false,
	261	+ ]
	262	+ )
	263	+ );
	264	+
	265	+ foreach ( $query->posts as $post_id ) {
	266	+ $default_value = apply_filters( 'bbp_voting_sort_meta_key_default_value', '0', $post_id );
	267	+ update_post_meta( $post_id, $sort_meta_key, $default_value );
	268	+ }
	269	+
	270	+ wp_cache_set( $cache_key, 1, 'forumax', DAY_IN_SECONDS );
157	271	}
158	272	}