PluginProbe
Better Payment – Instant Payments, Donations, Fundraising with Subscriptions & More / 2.4.1
Better Payment – Instant Payments, Donations, Fundraising with Subscriptions & More v2.4.1
2.4.1 2.4.0 2.3.4 2.3.3 2.3.2 2.3.1 2.3.0 2.2.2 2.2.1 2.2.0 2.1.2 2.1.1 trunk 0.0.1 0.0.2 0.0.3 0.0.4 0.0.5 0.0.6 0.0.7 1.0.0 1.0.1 1.0.2 1.0.3 1.0.4 All 68 releases
← All changes | includes/Classes/Helper.php +9 -8 2.4.0 → 2.4.1 View file →
@@ -517,9 +517,16 @@
517 517
518 518 /**
519 519 * Get interval text for recurring and split payment
520 520 *
521 + * Lite never calls this. Better Payment Pro <= 1.4.3's layout partials did, from
522 + * templates that no longer load (Pro 1.4.3 fills no `layout_template` filter), and
523 + * tests/Unit/ProCouplingContractTest.php still pins it. Pro 1.4.4+ uses its own
524 + * Admin\Elementor\LayoutRenderer::interval_text().
525 + *
521 526 * @since 1.3.0
527 + * @deprecated 2.4.0 Kept as belt-and-braces for Pro 1.4.3. Delete once no supported
528 + * site can run it.
522 529 */
523 530 public function get_interval_text( $interval = '' ){
524 531 $interval_text = '';
525 532
@@ -546,12 +553,10 @@
546 553 * the CSV export print it.
547 554 *
548 555 * Lite's own checkouts only take one-time payments, so Lite says 'One Time'.
549 556 * `better_payment/transaction/payment_type` ($label, $form_fields_info) relabels
550 - * a row: Pro returns 'Subscription' for its recurring and split payments. Lite's
551 - * copy of that (ProSubscriptionTransactionData::payment_type()) serves only an
552 - * active Pro that does not (<= 1.4.3). The CSV import reads the label back, so
553 - * keep these two strings.
557 + * a row: Pro returns 'Subscription' for its recurring and split payments. The CSV
558 + * import reads the label back, so keep these two strings.
554 559 *
555 560 * @since 2.4.0
556 561 *
557 562 * @param mixed $form_fields_info The transaction's unserialized form_fields_info.
@@ -559,12 +564,8 @@
559 564 */
560 565 public static function payment_type_label( $form_fields_info ): string {
561 566 $form_fields_info = is_array( $form_fields_info ) ? $form_fields_info : [];
562 567 $label = 'One Time';
563 -
564 - if ( ProSubscriptionTransactionData::lite_copy_applies() ) {
565 - $label = ProSubscriptionTransactionData::payment_type( $label, $form_fields_info );
566 - }
567 568
568 569 $filtered = apply_filters( 'better_payment/transaction/payment_type', $label, $form_fields_info );
569 570
570 571 return is_string( $filtered ) ? $filtered : $label;