← All changes | includes/Shortcodes/SearchForm.php +9 -178 4.8.2 → 4.2.0 View file →

		@@ -1,12 +1,8 @@
1	1	<?php
	2	+
2	3	namespace WPDeveloper\BetterDocs\Shortcodes;
3	4
4		-if ( ! defined( 'ABSPATH' ) ) {
5		- exit;
6		-}
7		-
8		-
9	5	use WPDeveloper\BetterDocs\Core\Query;
10	6	use WPDeveloper\BetterDocs\Utils\Helper;
11	7	use WPDeveloper\BetterDocs\Core\Settings;
12	8	use WPDeveloper\BetterDocs\Core\Shortcode;
		@@ -19,139 +15,8 @@
19	15	add_action( 'wp_ajax_nopriv_betterdocs_get_search_result', [ $this, 'get_search_results' ] );
20	16	add_action( 'wp_ajax_betterdocs_get_search_result', [ $this, 'get_search_results' ] );
21	17	}
22	18
23		- /**
24		- * Modify search query to properly handle non-English characters
25		- *
26		- * @param string $search The search SQL for WHERE clause
27		- * @param WP_Query $query The WP_Query instance
28		- * @return string Modified search SQL
29		- */
30		- public function improve_search_for_non_english( $search, $query ) {
31		- global $wpdb;
32		-
33		- // Only modify our BetterDocs search queries
34		- if ( ! isset( $query->query_vars['post_type'] ) || $query->query_vars['post_type'] !== 'docs' ) {
35		- return $search;
36		- }
37		-
38		- // Only modify if there's a search term
39		- if ( empty( $query->query_vars['s'] ) ) {
40		- return $search;
41		- }
42		-
43		- $search_term = $query->query_vars['s'];
44		-
45		- // If the search term contains non-ASCII characters, we need to ensure proper UTF-8 handling
46		- if ( preg_match('/[^\x00-\x7F]/', $search_term) ) {
47		- // Get the search term with proper escaping
48		- $like = '%' . $wpdb->esc_like( $search_term ) . '%';
49		-
50		- // Build a UTF-8 compatible search query
51		- // Search in post_title, post_content, and post_excerpt
52		- // Note: Removed COLLATE clause to avoid collation mismatch with TranslatePress tables
53		- $search = $wpdb->prepare(
54		- " AND (
55		- ({$wpdb->posts}.post_title LIKE %s)
56		- OR ({$wpdb->posts}.post_content LIKE %s)
57		- OR ({$wpdb->posts}.post_excerpt LIKE %s)",
58		- $like,
59		- $like,
60		- $like
61		- );
62		-
63		- // If TranslatePress is active, also search in the translation dictionary
64		- if ( class_exists( '\TRP_Translate_Press' ) ) {
65		- // Get language codes
66		- $lang_codes = $this->get_trp_language_code();
67		- $default_lang = $lang_codes['default_language'];
68		- $current_lang = $lang_codes['current_language'];
69		-
70		- // Only search in translation table if current language is different from default
71		- if ( $default_lang !== $current_lang ) {
72		- $default_lang = preg_replace( '/[^a-z0-9_]/', '', $default_lang );
73		- $current_lang = preg_replace( '/[^a-z0-9_]/', '', $current_lang );
74		- // TranslatePress table naming: wp_trp_dictionary_{default_lang}_{current_lang}
75		- $trp_table = $wpdb->prefix . 'trp_dictionary_' . $default_lang . '_' . $current_lang;
76		-
77		- if ( $this->table_exists( $trp_table ) ) {
78		- // $trp_table is composed from $wpdb->prefix + sanitized lang slugs (preg_replace allowlist above);
79		- // $like is esc_like()-wrapped with intentional % wildcards; CONCAT() wildcards are query literals, not user input.
80		- // phpcs:disable WordPress.DB.PreparedSQLPlaceholders.LikeWildcardsInQuery,WordPress.DB.PreparedSQL.InterpolatedNotPrepared
81		- $trp_search = $wpdb->prepare(
82		- " OR EXISTS (
83		- SELECT 1 FROM {$trp_table} trp
84		- WHERE (trp.original LIKE %s OR trp.translated LIKE %s)
85		- AND trp.status != 2
86		- AND (
87		- {$wpdb->posts}.post_title COLLATE utf8mb4_unicode_ci = trp.original COLLATE utf8mb4_unicode_ci
88		- OR {$wpdb->posts}.post_content COLLATE utf8mb4_unicode_ci LIKE CONCAT('%%', trp.original COLLATE utf8mb4_unicode_ci, '%%')
89		- OR {$wpdb->posts}.post_excerpt COLLATE utf8mb4_unicode_ci = trp.original COLLATE utf8mb4_unicode_ci
90		- )
91		- )",
92		- $like,
93		- $like
94		- );
95		- // phpcs:enable WordPress.DB.PreparedSQLPlaceholders.LikeWildcardsInQuery,WordPress.DB.PreparedSQL.InterpolatedNotPrepared
96		-
97		- $search .= $trp_search;
98		- }
99		- }
100		- }
101		-
102		-
103		- $search .= " ) ";
104		- }
105		-
106		- return $search;
107		- }
108		-
109		- /**
110		- * Get TranslatePress language codes (default and current) for table name construction
111		- *
112		- * @return array Array with 'default_language' and 'current_language' keys
113		- */
114		- private function get_trp_language_code() {
115		- $result = [
116		- 'default_language' => 'en_US',
117		- 'current_language' => 'en_US'
118		- ];
119		-
120		- if ( class_exists( '\TRP_Translate_Press' ) ) {
121		- $trp = \TRP_Translate_Press::get_trp_instance();
122		- if ( isset( $trp ) && method_exists( $trp, 'get_component' ) ) {
123		- $trp_settings = $trp->get_component( 'settings' );
124		-
125		- // Get default language from settings
126		- if ( $trp_settings ) {
127		- $settings = $trp_settings->get_settings();
128		- if ( isset( $settings['default-language'] ) ) {
129		- $result['default_language'] = strtolower( $settings['default-language'] );
130		- }
131		- }
132		-
133		- // Get current language from global variable
134		- global $TRP_LANGUAGE;
135		- if ( isset( $TRP_LANGUAGE ) && ! empty( $TRP_LANGUAGE ) ) {
136		- $result['current_language'] = strtolower( $TRP_LANGUAGE );
137		- }
138		- }
139		- }
140		-
141		- return $result;
142		- }
143		-
144		- /**
145		- * Check if a database table exists
146		- */
147		- private function table_exists( $table_name ) {
148		- global $wpdb;
149		- // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching -- schema check, caching would mask plugin-activation state.
150		- $result = $wpdb->get_var( $wpdb->prepare( "SHOW TABLES LIKE %s", $table_name ) );
151		- return $result === $table_name;
152		- }
153		-
154	19	public function get_style_depends() {
155	20	$handlers = [ 'betterdocs-search' ];
156	21	return $handlers;
157	22	}
		@@ -166,14 +31,12 @@
166	31	}
167	32
168	33	public function get_search_results() {
169	34	global $wpdb;
170		- // phpcs:disable WordPress.Security.NonceVerification.Missing -- public live-search endpoint, no state change.
171		- $search_input = isset( $_POST['search_input'] ) ? sanitize_text_field( wp_unslash( $_POST['search_input'] ) ) : '';
172		- $search_cat = isset( $_POST['search_cat'] ) ? wp_strip_all_tags( wp_unslash( $_POST['search_cat'] ) ) : '';
173		- $lang = isset( $_POST['lang'] ) ? wp_strip_all_tags( wp_unslash( $_POST['lang'] ) ) : '';
174		- $kb_slug = isset( $_POST['kb_slug'] ) ? sanitize_text_field( wp_unslash( $_POST['kb_slug'] ) ) : '';
175		- // phpcs:enable WordPress.Security.NonceVerification.Missing
	35	+ $search_input = isset( $_POST['search_input'] ) ? sanitize_text_field( $_POST['search_input'] ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
	36	+ $search_cat = isset( $_POST['search_cat'] ) ? wp_strip_all_tags( $_POST['search_cat'] ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
	37	+ $lang = isset( $_POST['lang'] ) ? wp_strip_all_tags( $_POST['lang'] ) : ''; // phpcs:ignore WordPress.Security.NonceVerification.Missing
	38	+ $search_input = preg_replace( '/[^A-Za-z0-9_\- ][]]/', '', strtolower( $search_input ) );
176	39
177	40	$tax_query = [];
178	41	if ( $search_cat ) {
179	42	$tax_query = [
		@@ -186,11 +49,8 @@
186	49	]
187	50	];
188	51	}
189	52
190		- // Don't build KB tax_query here - let the MultipleKB filter handle it
191		- // We just pass kb_slug in the args
192		-
193	53	$term = get_term_by( 'slug', $search_cat );
194	54
195	55	$post_status = ['publish'];
196	56
		@@ -197,50 +57,26 @@
197	57	if( current_user_can( 'read_private_docs' ) ) {
198	58	array_push($post_status, 'private');
199	59	}
200	60
201		- // phpcs:ignore WordPress.DB.SlowDBQuery.slow_db_query_tax_query -- search query supports user-selected category filter.
202	61	$args = [
203	62	'term_id' => isset( $term->term_id ) ? $term->term_id : 0,
204	63	'post_type' => 'docs',
205	64	'post_status' => $post_status,
206	65	'posts_per_page' => -1,
207		- 'suppress_filters' => false, // Changed to false to allow posts_search filter
	66	+ 'suppress_filters' => true,
208	67	's' => $search_input,
209	68	'orderby' => 'relevance',
210		- // phpcs:ignore WordPress.DB.SlowDBQuery.slow_db_query_tax_query -- category-scoped search is a core BetterDocs feature; the taxonomy filter is intrinsic to the query.
211		- 'tax_query' => $tax_query,
212		- 'kb_slug' => $kb_slug // Pass kb_slug for filter hooks
	69	+ 'tax_query' => $tax_query
213	70	];
214	71
215		- // Handle WPML multilingual search
216	72	if ( is_plugin_active( 'sitepress-multilingual-cms/sitepress.php' ) ) {
217		- // If search term contains non-ASCII characters (e.g., Chinese, Japanese, Bangla),
218		- // search across all languages to find translated posts
219		- if ( preg_match('/[^\x00-\x7F]/', $search_input) ) {
220		- // Non-ASCII search: bypass WPML language filtering but allow posts_search filter
221		- // This allows searching across all languages
222		- $args['suppress_filters'] = true; // phpcs:ignore WordPressVIPMinimum.Hooks.PreGetPosts.PreGetPosts,WordPressVIPMinimum.Performance.WPQueryParams.SuppressFilters_suppress_filters -- non-ASCII search must reach all WPML translations.
223		- } else {
224		- // ASCII-only search (English), use WPML filters to restrict to current language
225		- $args['suppress_filters'] = false;
226		- $args['lang'] = ICL_LANGUAGE_CODE;
227		- }
228		- }
229		- // Handle TranslatePress - always allow posts_search filter for non-ASCII
230		- elseif ( class_exists( '\TRP_Translate_Press' ) && preg_match('/[^\x00-\x7F]/', $search_input) ) {
231		- // For TranslatePress, we need posts_search filter to run
232	73	$args['suppress_filters'] = false;
	74	+ $args['lang'] = ICL_LANGUAGE_CODE;
233	75	}
234	76
235		- // Add filter to improve search for non-English characters
236		- add_filter( 'posts_search', [ $this, 'improve_search_for_non_english' ], 10, 2 );
237		-
238	77	$search_results = $this->query->get_posts( $args );
239	78
240		- // Remove filter after query to avoid affecting other queries
241		- remove_filter( 'posts_search', [ $this, 'improve_search_for_non_english' ], 10 );
242		-
243	79	$response = [];
244	80
245	81	ob_start();
246	82	betterdocs()->views->get(
		@@ -284,24 +120,19 @@
284	120	'placeholder' => __( 'Search', 'betterdocs' ),
285	121	'heading' => '',
286	122	'subheading' => '',
287	123	'heading_tag' => 'h1',
288		- 'subheading_tag' => 'p',
289		- 'kb_based_search' => '' // KB slug to filter search results
	124	+ 'subheading_tag' => 'p'
290	125	]
291	126	);
292	127	}
293	128
294	129	public function render( $atts, $content = null ) {
295		- // Get kb_based_search from shortcode attribute (KB slug)
296		- $kb_based_search = isset( $atts['kb_based_search'] ) ? sanitize_text_field( $atts['kb_based_search'] ) : '';
297		-
298	130	betterdocs()->assets->localize(
299	131	'betterdocs-search',
300	132	'betterdocsSearchConfigTwo',
301	133	[
302	134	'is_post_type_archive' => is_post_type_archive( 'docs' ),
303		- 'kb_based_search' => $kb_based_search,
304	135	]
305	136	);
306	137
307	138	$this->views( 'shortcodes/search' );