← All changes | includes/Frontend/Form/FrontendFormHandler.php +322 -84 3.1.2 → V3.3.2 View file →

		@@ -8,8 +8,9 @@
8	8
9	9	use BitCode\BitForm\Admin\Form\AdminFormHandler;
10	10	use BitCode\BitForm\Admin\Form\FrontEndScriptGenerator;
11	11	use BitCode\BitForm\Admin\Form\Helpers;
	12	+use BitCode\BitForm\Core\Cryptography\Cryptography;
12	13	use BitCode\BitForm\Core\Database\FormEntryMetaModel;
13	14	use BitCode\BitForm\Core\Database\FormModel;
14	15	use BitCode\BitForm\Core\Form\FormManager;
15	16	use BitCode\BitForm\Core\Integration\IntegrationHandler;
		@@ -15,16 +16,21 @@
15	16	use BitCode\BitForm\Core\Integration\IntegrationHandler;
16	17	use BitCode\BitForm\Core\Util\EscapingHelper;
17	18	use BitCode\BitForm\Core\Util\FieldValueHandler;
18	19	use BitCode\BitForm\Core\Util\FileDownloadProvider;
	20	+use BitCode\BitForm\Core\Util\FileHandler;
19	21	use BitCode\BitForm\Core\Util\FrontendHelpers;
	22	+use BitCode\BitForm\Core\Util\Log;
	23	+use BitCode\BitForm\Core\Util\SmartTagRegistry;
20	24	use BitCode\BitForm\Core\Util\SmartTags;
21		-use BitCode\BitForm\Core\Util\SmartTagRegistry;
	25	+use BitCode\BitForm\Core\Util\Utilities;
22	26	use BitCode\BitForm\Core\WorkFlow\WorkFlow;
23		-use Error;
24	27
25	28	final class FrontendFormHandler
26	29	{
	30	+ /** Largest stored signature inlined into the page as a data URI. */
	31	+ private const MAX_INLINE_SIGNATURE_BYTES = 2097152;
	32	+
27	33	public function __construct()
28	34	{
29	35	// before markup load - formids [], posts [1,2]
30	36	add_action('wp_enqueue_scripts', [$this, 'loadAssets']);
		@@ -30,29 +36,37 @@
30	36	add_action('wp_enqueue_scripts', [$this, 'loadAssets']);
31	37	// markup loads - formids []
32	38	add_shortcode('bitform', [$this, 'handleFrontendRenderRequest']);
33	39	// after markup load - formids [1,35,3]
34		- add_action('wp_footer', [$this, 'generateJS']);
	40	+ // After popup plugins render at 10 (that is when popup-only forms register
	41	+ // their formID), before wp_print_footer_scripts at 20.
	42	+ add_action('wp_footer', [$this, 'generateJS'], 15);
35	43	}
36	44
37		- private function validPassowordResetToken($token, $userID, $formId)
	45	+ /**
	46	+ * A reset form opened from a used or expired link cannot succeed, so show why instead of
	47	+ * the form. Returns the notice markup, or '' when the link is fine or the form is not a
	48	+ * reset form. Rendered in place of the form (the old exit() cut the page off mid-theme).
	49	+ *
	50	+ * @param string $token key from the reset link
	51	+ * @param string $userID user ID from the reset link
	52	+ * @param int $formId form being rendered
	53	+ *
	54	+ * @return string
	55	+ */
	56	+ private function invalidPasswordResetNotice($token, $userID, $formId)
38	57	{
39	58	$existResetInteg = (new IntegrationHandler($formId))->getAllIntegration('wp_user_auth', 'wp_auth', 1);
40		- if (!is_wp_error($existResetInteg) && count($existResetInteg) > 0) {
41		- if ('reset' === $existResetInteg[0]->integration_name) {
42		- $user = get_userdata($userID);
43		- if ($user) {
44		- $validKey = check_password_reset_key($token, $user->user_login);
45		- if (is_wp_error($validKey)) {
46		- echo "<div id='bf-resp' style='display:grid;justify-content:center;color:#860000;'>This password reset token is invalid.</div>";
47		- exit();
48		- }
49		- } else {
50		- echo "<div id='bf-resp' style='display:grid;justify-content:center;color:#860000;'>Invalid User!!</div>";
51		- exit();
52		- }
53		- }
	59	+ if (is_wp_error($existResetInteg) || empty($existResetInteg) || 'reset' !== $existResetInteg[0]->integration_name) {
	60	+ return '';
54	61	}
	62	+ $user = get_userdata((int) $userID);
	63	+ if ($user && !is_wp_error(check_password_reset_key($token, $user->user_login))) {
	64	+ return '';
	65	+ }
	66	+ return "<div id='bf-resp' role='alert' style='display:grid;justify-content:center;color:#860000;'>"
	67	+ . esc_html__('This password reset link is invalid or has expired. Please request a new one.', 'bit-form')
	68	+ . '</div>';
55	69	}
56	70
57	71	private function getJSFileSrc($postId)
58	72	{
		@@ -61,10 +75,43 @@
61	75
62	76	return $formScriptSrc;
63	77	}
64	78
	79	+ private function getJSFilePath($postId)
	80	+ {
	81	+ return BITFORMS_CONTENT_DIR . "/form-scripts/$postId/bitform-js-$postId.js";
	82	+ }
	83	+
	84	+ /**
	85	+ * Does this page's bundle need (re)generating?
	86	+ *
	87	+ * The DB flag alone is not enough: a page marked generated whose file was never written
	88	+ * (crashed generation, unwritable uploads dir) would enqueue a 404 forever. Conversely a
	89	+ * file that cannot be written must not make every request rebuild it, so a missing file
	90	+ * is retried on a backoff window rather than on every hit.
	91	+ *
	92	+ * @param int $postId
	93	+ * @param bool $regenerateScriptFlag DB-side verdict from regenerateScriptChecker()
	94	+ *
	95	+ * @return bool
	96	+ */
	97	+ private function needsScriptGeneration($postId, $regenerateScriptFlag)
	98	+ {
	99	+ if (file_exists($this->getJSFilePath($postId))) {
	100	+ return (bool) $regenerateScriptFlag;
	101	+ }
	102	+ $retryKey = 'bitforms_js_regen_' . $postId;
	103	+ if (get_transient($retryKey)) {
	104	+ return false;
	105	+ }
	106	+ set_transient($retryKey, 1, 5 * MINUTE_IN_SECONDS);
	107	+ return true;
	108	+ }
	109	+
65	110	public function generateJs($formID = null, $entryID = null, $formType = null)
66	111	{
	112	+ // bitform-js-{postId}.js is disk-cached per post ID with no language key.
	113	+ // Display strings must stay out of it and travel in bf_globals per request.
67	114	// return true;
68	115	$isFormPreview = get_transient('bitform_form_preview');
69	116	if ($isFormPreview && !$formID) {
70	117	delete_transient('bitform_form_preview');
		@@ -124,8 +171,10 @@
124	171	if (!$regenerateScriptFlag) {
125	172	$regenerateScriptFlag = $this->deleteUnusedFormPageIds($postId, $bfUniqFormIds);
126	173	}
127	174	$isJsGenerating = get_option('bitforms_frontend_js_generating');
	175	+ // The fast path also requires the cached bundle to exist on disk, not just be flagged in the DB.
	176	+ $regenerateScriptFlag = $this->needsScriptGeneration($postId, $regenerateScriptFlag);
128	177	if (!$regenerateScriptFlag && !$isJsGenerating && !empty($formIDs)) {
129	178	wp_enqueue_script('bit-form-all-script-test', $this->getJSFileSrc($postId), [], $formUpdateVersion, true);
130	179	return;
131	180	}
		@@ -158,8 +207,13 @@
158	207	$frontendScriptGenObj->generateJsFile($formContents, $allFields, $contentIds, $postId, $formIDs, $previewMode);
159	208	if ('preview' === $previewMode) {
160	209	return;
161	210	}
	211	+ // Only mark the page as generated once the bundle is verifiably on disk; otherwise the
	212	+ // next request must retry generation instead of fast-pathing to a stale/missing file.
	213	+ if (!empty($bfUniqFormIds) && file_exists($this->getJSFilePath($postId))) {
	214	+ $this->markScriptGenerated($bfUniqFormIds, $postId);
	215	+ }
162	216	wp_enqueue_script('bit-form-all-script-test', $this->getJSFileSrc($postId), [], $formUpdateVersion, true);
163	217	}
164	218
165	219	private function deleteUnusedFormPageIds($postId, $formIDs)
		@@ -175,9 +229,9 @@
175	229	);
176	230	$regenerateScriptFlag = false;
177	231	foreach ($forms as $form) {
178	232	$formId = $form->id;
179		- $generatedScriptPageIdsDecoded = json_decode($form->generated_script_page_ids, true);
	233	+ $generatedScriptPageIdsDecoded = json_decode((string) $form->generated_script_page_ids, true);
180	234	$generatedScriptPageIds = is_array($generatedScriptPageIdsDecoded) ? array_keys($generatedScriptPageIdsDecoded) : [];
181	235	if (!empty($generatedScriptPageIds) && !in_array($formId, $formIDs) && in_array($postId, $generatedScriptPageIds)) {
182	236	unset($generatedScriptPageIdsDecoded[$postId]);
183	237	if (empty($generatedScriptPageIdsDecoded)) {
		@@ -205,10 +259,11 @@
205	259	if (!is_a($post, 'WP_Post') && !isset($post->ID)) {
206	260	return;
207	261	}
208	262	$postId = $post->ID;
209		- $regenerateScriptFlag = false;
210		- $formModel = new FormModel();
	263	+ // Read-only check. Marking the page as generated is deferred to markScriptGenerated(),
	264	+ // called only after the bundle file is actually written — marking here left the DB
	265	+ // saying "generated" while the file stayed stale whenever generation failed mid-way.
211	266	foreach ($formsIds as $formId) {
212	267	$formInstance = FormManager::getInstance($formId);
213	268	if (!$formInstance->isExist()) {
214	269	continue;
		@@ -214,18 +269,35 @@
214	269	continue;
215	270	}
216	271	$generatedPages = $formInstance->getFormData('generated_script_page_ids');
217	272	if (empty($generatedPages)) {
218		- $regenerateScriptFlag = true;
219		- } elseif (is_object($generatedPages) && (!isset($generatedPages->{$postId}) || (isset($generatedPages->{$postId}) && false === $generatedPages->{$postId}))) {
220		- $regenerateScriptFlag = true;
	273	+ return true;
221	274	}
222		- if (!$regenerateScriptFlag) {
	275	+ if (is_object($generatedPages) && (!isset($generatedPages->{$postId}) || false === $generatedPages->{$postId})) {
	276	+ return true;
	277	+ }
	278	+ }
	279	+ return false;
	280	+ }
	281	+
	282	+ private function markScriptGenerated($formsIds, $postId)
	283	+ {
	284	+ // Fetched via FormModel rather than FormManager: FormManager keeps its row in a static
	285	+ // property shared across instances, so after the render loop it holds the last form's
	286	+ // data regardless of which instance is asked.
	287	+ $formModel = new FormModel();
	288	+ foreach ($formsIds as $formId) {
	289	+ $form = $formModel->get(['generated_script_page_ids'], ['id' => $formId]);
	290	+ if (is_wp_error($form) || empty($form)) {
223	291	continue;
224	292	}
	293	+ $generatedPages = Utilities::jsonObj($form[0]->generated_script_page_ids ?? '');
225	294	if (!is_object($generatedPages)) {
226	295	$generatedPages = (object) [];
227	296	}
	297	+ if (!empty($generatedPages->{$postId})) {
	298	+ continue;
	299	+ }
228	300	$generatedPages->{$postId} = true;
229	301	$formModel->update(
230	302	[
231	303	'generated_script_page_ids' => \wp_json_encode($generatedPages)
		@@ -234,9 +306,8 @@
234	306	'id' => $formId,
235	307	]
236	308	);
237	309	}
238		- return $regenerateScriptFlag;
239	310	}
240	311
241	312	private function addInlineScript($code, $handle = '', $position = 'after')
242	313	{
		@@ -281,9 +352,9 @@
281	352
282	353	return $fields;
283	354	}
284	355
285		- private function executeOnUserInput($formID, $shortCodeCounter, $fields)
	356	+ private function executeOnUserInput($formID, $shortCodeCounter, $workFlowRunType = 'create')
286	357	{
287	358	$FrontendFormManager = FrontendFormManager::getInstance($formID, $shortCodeCounter);
288	359	$previousValue = $this->getValuesFromQueryParams();
289	360	$formContent = $FrontendFormManager->getFormContentWithValue($previousValue);
		@@ -289,9 +360,9 @@
289	360	$formContent = $FrontendFormManager->getFormContentWithValue($previousValue);
290	361	$customCodesExist = strpos(FrontEndScriptGenerator::getCustomCodes($formID)['JavaScript'], 'bfVars');
291	362	if ($customCodesExist || (!empty($formContent->workFlowExist) && !empty($formContent->workFlowExist->oninput))) {
292	363	$workFlowRunHelper = new WorkFlow($formID);
293		- return $workFlowRunHelper->executeOnUserInput('create', $fields);
	364	+ return $workFlowRunHelper->executeOnUserInput($workFlowRunType);
294	365	}
295	366	}
296	367
297	368	private function getValuesFromQueryParams()
		@@ -298,21 +369,20 @@
298	369	{
299	370	// Read-only: query string parsed to pre-fill form fields. Values are sanitized per field before use.
300	371	$queryParamsValue = [];
301	372	if (isset($_SERVER['QUERY_STRING']) && !empty($_SERVER['QUERY_STRING'])) {
302		- $reqField = sanitize_text_field(wp_unslash($_SERVER['QUERY_STRING']));
	373	+ $reqField = wp_unslash($_SERVER['QUERY_STRING']);
303	374	foreach (explode('&', $reqField) as $keyValue) {
304		- // $pattern = '/([a-zA-Z0-9])([a-zA-Z])\=+/';
305		- $pattern = '/([^.]+)=(.*?)([^.]+)/';
306		- $matches = preg_match($pattern, $keyValue, $matchFormat);
307		- if ($matches) {
	375	+ if (false !== strpos($keyValue, '=')) {
308	376	list($field, $value) = explode('=', $keyValue, 2);
309	377
310	378	if (!trim($value)) {
311	379	continue;
312	380	}
313		-
314		- $queryParamsValue[$field][] = sanitize_text_field(urldecode($value));
	381	+ $field = sanitize_text_field(urldecode($field));
	382	+ if (!empty($field)) {
	383	+ $queryParamsValue[$field][] = sanitize_text_field(urldecode($value));
	384	+ }
315	385	}
316	386	}
317	387	}
318	388
		@@ -347,10 +417,13 @@
347	417	/* translators: %s: form ID */
348	418	return sprintf(__('#%s no. Form doesn\'t exists', 'bit-form'), $formID);
349	419	}
350	420
351		- // Add-ons may detect whether the current visitor is resuming an abandoned entry.
352		- $isAbandoned = (bool) apply_filters('bitform_is_abandoned_entry', false, $formID, $entryId, $atts);
	421	+ // Add-ons return the id of the abandoned entry this visitor can resume. A bare
	422	+ // true (older Pro) carries no id, so nothing is restored rather than entry #1.
	423	+ $abandonedEntryId = apply_filters('bitform_is_abandoned_entry', false, $formID, $entryId, $atts);
	424	+ $abandonedEntryId = (!is_bool($abandonedEntryId) && is_numeric($abandonedEntryId)) ? (int) $abandonedEntryId : 0;
	425	+ $isAbandoned = $abandonedEntryId > 0;
353	426
354	427	FrontendHelpers::setBfFrontendFormIds($formID);
355	428	$bfFrontendFormIds = FrontendHelpers::$bfFrontendFormIds;
356	429	$shortCodeCounter = count($bfFrontendFormIds);
		@@ -370,9 +443,13 @@
370	443	}
371	444
372	445	// Read-only: password reset token from URL for display-time validation. No state written until form is submitted.
373	446	if (!empty($_GET['token']) && !empty($_GET['id'])) {
374		- $this->validPassowordResetToken(sanitize_text_field(wp_unslash($_GET['token'])), sanitize_text_field(wp_unslash($_GET['id'])), $formID);
	447	+ $resetNotice = $this->invalidPasswordResetNotice(sanitize_text_field(wp_unslash($_GET['token'])), sanitize_text_field(wp_unslash($_GET['id'])), $formID);
	448	+ if ('' !== $resetNotice) {
	449	+ ob_end_clean();
	450	+ return $resetNotice;
	451	+ }
375	452	}
376	453
377	454	$previousValue = $this->getValuesFromQueryParams();
378	455	$errorMessages = []; // delete
		@@ -412,9 +489,9 @@
412	489	$fields = apply_filters('bitform_filter_before_workflow_onload_fields', $fields, $formID);
413	490	$fields = $this->triggerWorkflowOnLoad($formID, $shortCodeCounter, $fields, $workFlowRunType);
414	491	$fields = apply_filters('bitform_filter_after_workflow_onload_fields', $fields, $formID);
415	492	do_action('bitform_onload_fields', $fields, $formID);
416		- $workFlowreturnedOnUserInput = $this->executeOnUserInput($formID, $shortCodeCounter, $fields);
	493	+ $workFlowreturnedOnUserInput = $this->executeOnUserInput($formID, $shortCodeCounter, $workFlowRunType);
417	494
418	495	// test for form before remove
419	496	$noLabelFieldTypes = ['decision-box', 'gdpr', 'html', 'shortcode', 'button', 'paypal', 'razorpay', 'recaptcha', 'turnstile', 'hcaptcha', 'stripe', 'spacer'];
420	497	foreach ($fields as $fldKey => $field) {
		@@ -435,12 +512,14 @@
435	512	$FrontendFormManager->getCaptchaSettings()
436	513	&& !is_null($integration->integration_type)
437	514	&& 'gReCaptcha' === $integration->integration_type
438	515	) {
439		- $integrationDetails = json_decode($integration->integration_details);
440		- $integrationDetails->id = $integration->id;
441		- $reCAPTCHA = $integrationDetails;
442		- $reCAPTCHAVersion = 'v2';
	516	+ $integrationDetails = Utilities::jsonObj($integration->integration_details);
	517	+ if ($integrationDetails) {
	518	+ $integrationDetails->id = $integration->id;
	519	+ $reCAPTCHA = $integrationDetails;
	520	+ $reCAPTCHAVersion = 'v2';
	521	+ }
443	522	}
444	523
445	524	if (
446	525	$FrontendFormManager->getTurnstileSettings()
		@@ -446,10 +525,10 @@
446	525	$FrontendFormManager->getTurnstileSettings()
447	526	&& !is_null($integration->integration_type)
448	527	&& 'turnstileCaptcha' === $integration->integration_type
449	528	) {
450		- $integrationDetails = json_decode($integration->integration_details);
451		- $turnstileSiteKey = $integrationDetails->siteKey;
	529	+ $integrationDetails = Utilities::jsonObj($integration->integration_details);
	530	+ $turnstileSiteKey = $integrationDetails->siteKey ?? '';
452	531	}
453	532
454	533	if (
455	534	$FrontendFormManager->isFieldTypeExist('hcaptcha')
		@@ -455,18 +534,20 @@
455	534	$FrontendFormManager->isFieldTypeExist('hcaptcha')
456	535	&& !is_null($integration->integration_type)
457	536	&& 'hcaptcha' === $integration->integration_type
458	537	) {
459		- $integrationDetails = json_decode($integration->integration_details);
460		- $hCaptchaSiteKey = $integrationDetails->siteKey;
	538	+ $integrationDetails = Utilities::jsonObj($integration->integration_details);
	539	+ $hCaptchaSiteKey = $integrationDetails->siteKey ?? '';
461	540	}
462	541
463	542	if ($captchaV3Settings) {
464	543	if (!is_null($integration->integration_type) && 'gReCaptchaV3' === $integration->integration_type) {
465		- $integrationDetails = json_decode($integration->integration_details);
466		- $integrationDetails->id = $integration->id;
467		- $reCAPTCHA = $integrationDetails;
468		- $reCAPTCHAVersion = 'v3';
	544	+ $integrationDetails = Utilities::jsonObj($integration->integration_details);
	545	+ if ($integrationDetails) {
	546	+ $integrationDetails->id = $integration->id;
	547	+ $reCAPTCHA = $integrationDetails;
	548	+ $reCAPTCHAVersion = 'v3';
	549	+ }
469	550	}
470	551	}
471	552	}
472	553	}
		@@ -499,19 +580,20 @@
499	580	$paymentIntegration = $integrationHandler->getAIntegration($fldData->payIntegID);
500	581	if (is_wp_error($paymentIntegration)) {
501	582	continue;
502	583	}
	584	+ $paymentIntegrationRow = Utilities::firstRow($paymentIntegration);
503	585	if ('paypal' === $fldData->typ) {
504		- $integrationDetails = json_decode($paymentIntegration[0]->integration_details);
505		- $clientID = $integrationDetails->clientID;
	586	+ $integrationDetails = Utilities::jsonObj($paymentIntegrationRow->integration_details ?? '');
	587	+ $clientID = $integrationDetails->clientID ?? '';
506	588	$fields->{$fldKey}->clientId = $clientID;
507	589	} elseif ('razorpay' === $fldData->typ) {
508		- $integrationDetails = json_decode($paymentIntegration[0]->integration_details);
509		- $clientID = $integrationDetails->apiKey;
	590	+ $integrationDetails = Utilities::jsonObj($paymentIntegrationRow->integration_details ?? '');
	591	+ $clientID = $integrationDetails->apiKey ?? '';
510	592	$fields->{$fldKey}->clientId = $clientID;
511	593	} elseif ('stripe' === $fldData->typ) {
512		- $integrationDetails = json_decode($paymentIntegration[0]->integration_details);
513		- $publishableKey = $integrationDetails->publishableKey;
	594	+ $integrationDetails = Utilities::jsonObj($paymentIntegrationRow->integration_details ?? '');
	595	+ $publishableKey = $integrationDetails->publishableKey ?? '';
514	596	$fields->{$fldKey}->publishableKey = $publishableKey;
515	597	}
516	598	}
517	599	}
		@@ -541,8 +623,9 @@
541	623	];
542	624
543	625	if ($entryId) {
544	626	$bitFormFrontArr['entryId'] = $entryId;
	627	+ self::markResponseUncacheable();
545	628	}
546	629
547	630	if (isset($additional->enabled->validateFocusLost)) {
548	631	$bitFormFrontArr['validateFocusLost'] = true;
		@@ -547,12 +630,19 @@
547	630	if (isset($additional->enabled->validateFocusLost)) {
548	631	$bitFormFrontArr['validateFocusLost'] = true;
549	632	}
550	633
551		- if (!empty($isAbandoned)) {
552		- $bitFormFrontArr['oldValues'] = $this->getFieldsValue($formID, $isAbandoned);
	634	+ if ($isAbandoned) {
	635	+ // One visitor's typed values, so this response must not be page-cached.
	636	+ $bitFormFrontArr['oldValues'] = $this->getFieldsValue($formID, $abandonedEntryId);
	637	+ self::markResponseUncacheable();
553	638	if (empty($entryId)) {
554		- $bitFormFrontArr['entryId'] = $isAbandoned;
	639	+ // Later draft saves must update this entry, not start a new one each time.
	640	+ $bitFormFrontArr['entryId'] = $abandonedEntryId;
	641	+ $entryToken = Cryptography::encrypt($abandonedEntryId, Helpers::getBitformSalt());
	642	+ if (is_string($entryToken)) {
	643	+ $bitFormFrontArr['entryToken'] = $entryToken;
	644	+ }
555	645	}
556	646	}
557	647
558	648	$formInfo = $FrontendFormManager->getFormInfo();
		@@ -587,27 +677,31 @@
587	677	$layout = wp_json_encode($layout);
588	678	$buttons = wp_json_encode($buttons);
589	679	$frontArr = wp_json_encode($bitFormFrontArr);
590	680
591		- $bfGlobals = sprintf('
592		- if(!window.bf_globals) {
593		- window.bf_globals = {}
594		- } if(!window.bf_globals.%1$s) {
595		- window.bf_globals.%1$s = {}
	681	+ $bfGlobals = sprintf('
	682	+ if(!window.bf_globals) {
	683	+ window.bf_globals = {}
	684	+ } if(!window.bf_globals.%1$s) {
	685	+ window.bf_globals.%1$s = {}
596	686	}
597		- if(document.getElementById("%1$s")) {
598		- window.bf_globals.%1$s = {
599		- ...window.bf_globals.%1$s,
600		- ...%2$s
601		- };
602		- }', $FormIdentifier, $frontArr);
	687	+ window.bf_globals.%1$s = {
	688	+ ...window.bf_globals.%1$s,
	689	+ ...%2$s
	690	+ };
	691	+ if (typeof window.bitformInit === "function") { window.bitformInit("%1$s"); }', $FormIdentifier, $frontArr);
603	692
	693	+ // Inert copy of the config. Optimizers only rewrite executable scripts, so
	694	+ // this survives and travels with the markup; the runtime hydrates from it
	695	+ // whenever bf_globals is missing.
	696	+ $configTag = self::buildFormConfigTag($FormIdentifier, $bitFormFrontArr);
	697	+
604	698	if ('conversational' === $formType
605	699	&& isset($formContent->formInfo->conversationalSettings->enable)
606	700	&& $formContent->formInfo->conversationalSettings->enable) {
607		- $html = $FrontendFormManager->conversationalFormView($fields, $file, $errorMessages);
	701	+ $html = $FrontendFormManager->conversationalFormView($fields, $file, $errorMessages, null, !empty($entryId));
608	702	} else {
609		- $html = $FrontendFormManager->formView($fields, $file, $errorMessages);
	703	+ $html = $FrontendFormManager->formView($fields, $file, $errorMessages, null, !empty($entryId));
610	704	}
611	705
612	706	// if form preview then return html otherwise echo with output buffer
613	707	if ($formPreview) {
		@@ -615,8 +709,9 @@
615	709	$formViewObject = new \stdClass();
616	710	$formViewObject->html = $html;
617	711	$formViewObject->font = $font;
618	712	$formViewObject->bfGlobals = $bfGlobals;
	713	+ $formViewObject->configTag = $configTag;
619	714	$formViewObject->formContent = $formContent;
620	715	return $formViewObject;
621	716	}
622	717
		@@ -623,13 +718,60 @@
623	718	$bfGlobalsHandle = 'bitform-bf-globals-' . sanitize_key($FormIdentifier);
624	719	$this->addInlineScript($bfGlobals, $bfGlobalsHandle, 'after');
625	720	$this->emitShowPickerBridge();
626	721
	722	+ // Printed outside wp_kses rather than allowing <script> in form markup.
	723	+ // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- built by buildFormConfigTag(), JSON_HEX_* escaped.
	724	+ echo $configTag;
627	725	echo wp_kses(trim($html), EscapingHelper::getFormAllowedHtml($formContent));
628	726	return ob_get_clean();
629	727	}
630	728
631	729	/**
	730	+ * Keep per-visitor config (oldValues, entryId) out of full-page caches.
	731	+ *
	732	+ * @return void
	733	+ */
	734	+ public static function markResponseUncacheable()
	735	+ {
	736	+ // DONOTCACHEPAGE does the work; caches read it at shutdown. Rendering
	737	+ // usually runs after headers are sent, so nocache_headers() is a bonus.
	738	+ if (!defined('DONOTCACHEPAGE')) {
	739	+ define('DONOTCACHEPAGE', true);
	740	+ }
	741	+ if (!headers_sent() && function_exists('nocache_headers')) {
	742	+ nocache_headers();
	743	+ }
	744	+ }
	745	+
	746	+ /**
	747	+ * Build the inert JSON config block for a rendered form.
	748	+ *
	749	+ * JSON_HEX_* escapes < > & as \u00XX so no field value can close the script
	750	+ * element or inject markup.
	751	+ *
	752	+ * @param string $formIdentifier
	753	+ * @param array $config
	754	+ *
	755	+ * @return string
	756	+ */
	757	+ public static function buildFormConfigTag($formIdentifier, $config)
	758	+ {
	759	+ $json = wp_json_encode($config, JSON_HEX_TAG | JSON_HEX_AMP | JSON_HEX_APOS | JSON_HEX_QUOT);
	760	+ if (false === $json) {
	761	+ return '';
	762	+ }
	763	+ // Some optimizers wrap any inline <script>, including application/json,
	764	+ // in DOMContentLoaded boilerplate that corrupts the JSON. These attributes
	765	+ // make the common ones skip it; the JS side also salvage-parses.
	766	+ return sprintf(
	767	+ '<script type="application/json" class="bf-form-config" id="bf-config-%1$s" data-bf-form="%1$s" data-no-optimize="1" data-no-defer="1" data-no-minify="1" data-cfasync="false" nowprocket>%2$s</script>',
	768	+ esc_attr($formIdentifier),
	769	+ $json
	770	+ );
	771	+ }
	772	+
	773	+ /**
632	774	* Build the smart-tag map exposed to the browser in window.bf_globals[formId].smartTags.
633	775	*
634	776	* Security: the legacy code shipped the ENTIRE ~43-tag map to every visitor, leaking
635	777	* PII (admin/user/author email) and freezing per-visitor request data (IP, time,
		@@ -661,9 +803,9 @@
661	803	continue; // identity / request / param tags never travel to the browser
662	804	}
663	805	// Match '${' . key prefix so keys containing spaces/slashes/commas are handled.
664	806	if (false !== strpos($haystack, '${' . $key)) {
665		- $referenced[] = $key;
	807	+ $referenced[] = $key;
666	808	$frontendSmartTags[$key] = SmartTagRegistry::resolve($key, $ctx);
667	809	}
668	810	}
669	811
		@@ -694,8 +836,15 @@
694	836	$code = 'if(!window.__bfShowPickerBound){window.__bfShowPickerBound=true;document.addEventListener("click",function(e){var t=e.target;if(t&&t.matches&&t.matches("input[data-bf-show-picker=\"1\"]")&&typeof t.showPicker==="function"){try{t.showPicker();}catch(_){}}});}';
695	837	$this->addInlineScript($code, 'bitform-show-picker-bridge', 'after');
696	838	}
697	839
	840	+ /**
	841	+ * Does this form row exist?
	842	+ *
	843	+ * @param int $formID
	844	+ *
	845	+ * @return bool
	846	+ */
698	847	private function isExist($formID)
699	848	{
700	849	$formModel = new FormModel();
701	850	$form = $formModel->get(
		@@ -705,12 +854,32 @@
705	854	[
706	855	'id' => $formID,
707	856	]
708	857	);
709		- if (!is_wp_error($form)) {
710		- return true;
	858	+
	859	+ if (is_wp_error($form)) {
	860	+ if ('result_empty' !== $form->get_error_code()) {
	861	+ Log::debug_log([
	862	+ 'message' => 'Form lookup failed — reported to the visitor as a missing form',
	863	+ 'formID' => $formID,
	864	+ 'code' => $form->get_error_code(),
	865	+ 'error' => $form->get_error_message(),
	866	+ ]);
	867	+ }
	868	+
	869	+ return false;
711	870	}
712		- return false;
	871	+
	872	+ if (empty($form)) {
	873	+ Log::debug_log([
	874	+ 'message' => 'Form lookup returned no rows without an error (is the form table present?)',
	875	+ 'formID' => $formID,
	876	+ ]);
	877	+
	878	+ return false;
	879	+ }
	880	+
	881	+ return true;
713	882	}
714	883
715	884	private function getFieldsValue($formID, $entryID)
716	885	{
		@@ -740,8 +909,12 @@
740	909	} else {
741	910	$metaVal = implode(BITFORMS_BF_SEPARATOR, $metaVal);
742	911	}
743	912	}
	913	+ // A restored draft never gets the password back; the visitor types it again.
	914	+ if (isset($formFields[$metaKey]['type']) && 'password' === $formFields[$metaKey]['type']) {
	915	+ continue;
	916	+ }
744	917	if (!isset($fldsData->{$metaKey})) {
745	918	$fldsData->{$metaKey} = '';
746	919	}
747	920	$fldsData->{$metaKey} = $metaVal;
		@@ -766,8 +939,23 @@
766	939	'bitforms_form_entry_id' => $entryID,
767	940	]
768	941	);
769	942	if (!is_wp_error($metaValues)) {
	943	+ $urlQuery = wp_parse_url(FileDownloadProvider::getBaseDownloadURL(), PHP_URL_QUERY);
	944	+ $baseDLURL = FileDownloadProvider::getBaseDownloadURL();
	945	+ $baseDLURL = empty($urlQuery) ? $baseDLURL . '?' : $baseDLURL . '&';
	946	+ $baseDLURL .= "formID={$formID}&entryID={$entryID}";
	947	+
	948	+ foreach ($fields as $field) {
	949	+ if ('file-up' === $field->typ || 'advanced-file-up' === $field->typ) {
	950	+ if (!isset($field->config)) {
	951	+ $field->config = (object) [];
	952	+ } elseif (is_array($field->config)) {
	953	+ $field->config = (object) $field->config;
	954	+ }
	955	+ $field->config->baseDLURL = $baseDLURL;
	956	+ }
	957	+ }
770	958	foreach ($metaValues as $metaValue) {
771	959	$metaKey = $metaValue->meta_key;
772	960	$metaVal = $metaValue->meta_value;
773	961	// if meta value is array then convert to string
		@@ -779,18 +967,25 @@
779	967	} else {
780	968	$metaVal = implode(BITFORMS_BF_SEPARATOR, $metaVal);
781	969	}
782	970	}
	971	+ if (property_exists($fields, $metaKey) && 'password' === $fields->{$metaKey}->typ) {
	972	+ // Never hand a stored password back to the browser; blank keeps it on update.
	973	+ $fields->{$metaKey}->val = '';
	974	+ if ('' !== (string) $metaValue->meta_value && isset($fields->{$metaKey}->valid) && is_object($fields->{$metaKey}->valid)) {
	975	+ $fields->{$metaKey}->valid->req = false;
	976	+ }
	977	+ continue;
	978	+ }
783	979	if (property_exists($fields, $metaKey)) {
784	980	$fields->{$metaKey}->val = $metaVal;
785	981	if ('file-up' === $fields->{$metaKey}->typ || 'advanced-file-up' === $fields->{$metaKey}->typ) {
786	982	$fields->{$metaKey}->val = $metaValue->meta_value;
787	983	$fields->{$metaKey}->config->oldFiles = $metaValue->meta_value;
788		- $urlQuery = wp_parse_url(FileDownloadProvider::getBaseDownloadURL(), PHP_URL_QUERY);
789		- $baseDLURL = FileDownloadProvider::getBaseDownloadURL();
790		- $baseDLURL = empty($urlQuery) ? $baseDLURL . '?' : $baseDLURL . '&';
791		- $fields->{$metaKey}->config->baseDLURL = $baseDLURL . "formID={$formID}&entryID={$entryID}";
792	984	}
	985	+ if ('signature' === $fields->{$metaKey}->typ) {
	986	+ $this->setOldSignature($fields->{$metaKey}, $formID, $entryID, $metaValue->meta_value);
	987	+ }
793	988	}
794	989	}
795	990	}
796	991	return $fields;
		@@ -795,8 +990,51 @@
795	990	}
796	991	return $fields;
797	992	}
798	993
	994	+ /** Give the signature field its stored signature: a data URI to redraw, and the name it posts back as `_old`. */
	995	+ private function setOldSignature($field, $formID, $entryID, $storedValue)
	996	+ {
	997	+ $fileName = is_string($storedValue) ? trim($storedValue) : '';
	998	+ $decoded = json_decode($fileName, true);
	999	+ if (is_array($decoded)) {
	1000	+ $fileName = empty($decoded) ? '' : trim((string) reset($decoded));
	1001	+ }
	1002	+ // signature-failed.png means the stored signature was never usable.
	1003	+ if ('' === $fileName || 'signature-failed.png' === $fileName) {
	1004	+ return;
	1005	+ }
	1006	+ $fileName = sanitize_file_name($fileName);
	1007	+ if (!isset($field->config)) {
	1008	+ $field->config = (object) [];
	1009	+ } elseif (is_array($field->config)) {
	1010	+ $field->config = (object) $field->config;
	1011	+ }
	1012	+ $field->config->oldSignatureFile = $fileName;
	1013	+
	1014	+ $filePath = FileHandler::getEntriesFileUploadDir($formID, $entryID) . DIRECTORY_SEPARATOR . $fileName;
	1015	+ if (!is_file($filePath) || !is_readable($filePath)) {
	1016	+ return;
	1017	+ }
	1018	+ // The types getSignatureFilePath() writes; wp_check_filetype() reports none for SVG.
	1019	+ $signatureMimeTypes = ['png' => 'image/png', 'jpg' => 'image/jpeg', 'svg' => 'image/svg+xml'];
	1020	+ $extension = strtolower((string) pathinfo($fileName, PATHINFO_EXTENSION));
	1021	+ if (!isset($signatureMimeTypes[$extension])) {
	1022	+ return;
	1023	+ }
	1024	+ $mimeType = $signatureMimeTypes[$extension];
	1025	+ // A hand-drawn signature is a few KB; a larger file is not worth inlining.
	1026	+ if (filesize($filePath) > self::MAX_INLINE_SIGNATURE_BYTES) {
	1027	+ return;
	1028	+ }
	1029	+ // phpcs:ignore WordPress.WP.AlternativeFunctions.file_system_operations_file_get_contents -- local upload dir read, inlined as a data URI for the signature pad.
	1030	+ $contents = file_get_contents($filePath);
	1031	+ if (false === $contents || '' === $contents) {
	1032	+ return;
	1033	+ }
	1034	+ $field->config->oldSignature = 'data:' . $mimeType . ';base64,' . base64_encode($contents);
	1035	+ }
	1036	+
799	1037	public function loadAssets($formID = 0, $fromType = 'classic')
800	1038	{
801	1039	$bfUniqFormIds = FrontendHelpers::getAllFormIdsInPage();
802	1040	$isPageBuilder = FrontendHelpers::$isPageBuilder;
		@@ -820,9 +1058,9 @@
820	1058	$formUpdateVersion = get_option('bitform_form_update_version');
821	1059	if (!wp_style_is('bitform-style-' . $newFormId) && is_readable(BITFORMS_CONTENT_DIR . '/form-styles/bitform-' . $newFormId . '.css')) {
822	1060	wp_enqueue_style(
823	1061	'bitform-style-' . $newFormId,
824		- BITFORMS_UPLOAD_BASE_URL . "/form-styles/bitform-{$newFormId}.css",
	1062	+ FrontendHelpers::styleSrc("form-styles/bitform-{$newFormId}.css"),
825	1063	[],
826	1064	$formUpdateVersion
827	1065	);
828	1066	if ($isPageBuilder) {
		@@ -832,9 +1070,9 @@
832	1070	}
833	1071	if (!wp_style_is('bitform-style-custom-' . $formID) && is_readable(BITFORMS_CONTENT_DIR . '/form-styles/bitform-custom-' . $formID . '.css')) {
834	1072	wp_enqueue_style(
835	1073	'bitform-style-custom-' . $formID,
836		- BITFORMS_UPLOAD_BASE_URL . "/form-styles/bitform-custom-{$formID}.css",
	1074	+ FrontendHelpers::styleSrc("form-styles/bitform-custom-{$formID}.css"),
837	1075	[],
838	1076	$formUpdateVersion
839	1077	);
840	1078	if ($isPageBuilder) {
		@@ -847,9 +1085,9 @@
847	1085	if (!wp_style_is('bitform-conversational-style-' . $formID) &&
848	1086	is_readable(BITFORMS_CONTENT_DIR . "/form-styles/bitform-conversational-{$formID}.css")) {
849	1087	wp_enqueue_style(
850	1088	'bitform-conversational-style',
851		- BITFORMS_UPLOAD_BASE_URL . "/form-styles/bitform-conversational-{$formID}.css",
	1089	+ FrontendHelpers::styleSrc("form-styles/bitform-conversational-{$formID}.css"),
852	1090	[],
853	1091	$formUpdateVersion
854	1092	);
855	1093	}