| @@ -14,12 +14,8 @@ | ||
| 14 | 14 | public $site_url = null; |
| 15 | 15 | public $mwcode = null; |
| 16 | 16 | public $licenser = null; |
| 17 | 17 | |
| 18 | - // IDs of global snippets already executed this request (by the plugins_loaded pass | |
| 19 | - // or by load_global_snippets), so a global never runs twice and never re-declares. | |
| 20 | - public $loaded_global_ids = []; | |
| 21 | - | |
| 22 | 18 | private $option_name = 'mwcode_options'; |
| 23 | 19 | |
| 24 | 20 | public function __construct() { |
| 25 | 21 | global $mwcode; |
| @@ -136,9 +132,9 @@ | ||
| 136 | 132 | |
| 137 | 133 | $options = $this->sanitize_options( $options ); |
| 138 | 134 | |
| 139 | 135 | if ( !update_option( $this->option_name, $options, false ) ) { |
| 140 | - //$this->log( '💾 There was an issue updating the options.' ); | |
| 136 | + $this->log( '💾 There was an issue updating the options.' ); | |
| 141 | 137 | } |
| 142 | 138 | |
| 143 | 139 | return $options; |
| 144 | 140 | } |
| @@ -189,9 +185,9 @@ | ||
| 189 | 185 | |
| 190 | 186 | private function updateAIEngineStatus( &$options ) { |
| 191 | 187 | global $mwai; |
| 192 | 188 | |
| 193 | - $options['mwai_has_ai'] = !empty( $mwai ) && method_exists( $mwai, 'hasAI' ) && $mwai->hasAI(); | |
| 189 | + $options['mwai_has_ai'] = !empty( $mwai ) && $mwai->hasAI(); | |
| 194 | 190 | // Legacy |
| 195 | 191 | $options['ai_engine_status'] = $options['mwai_has_ai']; |
| 196 | 192 | |
| 197 | 193 | return $options; |
| @@ -386,18 +382,8 @@ | ||
| 386 | 382 | |
| 387 | 383 | $this->log( '⚡ Arguments provided: ' . json_encode( $args ) ); |
| 388 | 384 | } |
| 389 | 385 | |
| 390 | - // Global snippets are meant to be always accessible. On non-whitelisted REST routes | |
| 391 | - // (Workflow Engine, MCP, AI function-calling) the plugins_loaded pass blocks them, so | |
| 392 | - // make sure their helper library is loaded before we run a function that may call it. | |
| 393 | - $this->load_global_snippets(); | |
| 394 | - | |
| 395 | - // Make every *other* active PHP function snippet available so this function can | |
| 396 | - // call its siblings. We pass the current name as the exception so the target is | |
| 397 | - // still defined below (with the edited/test code when testing), not pre-defined here. | |
| 398 | - $this->define_all_functions( $params['name'] ); | |
| 399 | - | |
| 400 | 386 | // Check if the function has already been defined |
| 401 | 387 | if ( !in_array( $params['name'], $defined_functions ) ) { |
| 402 | 388 | |
| 403 | 389 | // If not, proceed with modification and definition |
| @@ -509,132 +495,8 @@ | ||
| 509 | 495 | return $lint; |
| 510 | 496 | } |
| 511 | 497 | |
| 512 | 498 | return null; |
| 513 | - } | |
| 514 | - | |
| 515 | - /** | |
| 516 | - * Load the active global snippets (persistent + backend/frontend for this context) | |
| 517 | - * that haven't already run this request, so on-demand function execution has the same | |
| 518 | - * always-available helper library a normal page load would. Callable functions are | |
| 519 | - * typically small wrappers around these globals. | |
| 520 | - * | |
| 521 | - * On non-whitelisted REST routes (Workflow Engine, MCP, AI function-calling) the | |
| 522 | - * plugins_loaded pass blocks global snippets for safety; this restores them for the | |
| 523 | - * deliberate, authorized act of executing a snippet. The loaded-id registry guarantees | |
| 524 | - * each global runs at most once per request, so nothing is ever re-declared. | |
| 525 | - */ | |
| 526 | - function load_global_snippets() { | |
| 527 | - global $current_mwcode_snippet; | |
| 528 | - static $done = false; | |
| 529 | - if ( $done ) { | |
| 530 | - return; | |
| 531 | - } | |
| 532 | - $done = true; | |
| 533 | - | |
| 534 | - if ( empty( $this->snippet ) ) { | |
| 535 | - $this->snippet = new Meow_MWCODE_Modules_Snippet( $this ); | |
| 536 | - } | |
| 537 | - | |
| 538 | - $scope = is_admin() ? [ 'backend', 'persistent' ] : [ 'frontend', 'persistent' ]; | |
| 539 | - | |
| 540 | - $snippets = $this->snippet->select( | |
| 541 | - null, // offset | |
| 542 | - -1, // limit (all) | |
| 543 | - [ | |
| 544 | - [ 'accessor' => 'active', 'value' => 1 ], | |
| 545 | - [ 'accessor' => 'scope', 'value' => $scope ], | |
| 546 | - ], | |
| 547 | - [ 'accessor' => 'priority', 'by' => 'DESC' ] | |
| 548 | - )['data'] ?? []; | |
| 549 | - | |
| 550 | - foreach ( $snippets as $snippet ) { | |
| 551 | - // Skip globals already executed this request (e.g. by the plugins_loaded pass). | |
| 552 | - if ( in_array( $snippet['id'], $this->loaded_global_ids ) ) { | |
| 553 | - continue; | |
| 554 | - } | |
| 555 | - $this->loaded_global_ids[] = $snippet['id']; | |
| 556 | - | |
| 557 | - $code = $this->snippet->sanitize_code( $snippet['code'] ); | |
| 558 | - $current_mwcode_snippet = $snippet; | |
| 559 | - try { | |
| 560 | - ob_start(); | |
| 561 | - eval( $code ); | |
| 562 | - ob_end_clean(); | |
| 563 | - } catch ( Throwable $e ) { | |
| 564 | - ob_end_clean(); | |
| 565 | - $this->log( "⚠️ Code Engine: Failed to load global snippet \"{$snippet['name']}\": " . $e->getMessage() ); | |
| 566 | - } | |
| 567 | - } | |
| 568 | - $current_mwcode_snippet = null; | |
| 569 | - } | |
| 570 | - | |
| 571 | - /** | |
| 572 | - * Declare every active PHP function snippet in the current request, without | |
| 573 | - * invoking any of them, so function snippets can call one another. | |
| 574 | - * | |
| 575 | - * Function snippets are not auto-loaded on every request (unlike global/backend/ | |
| 576 | - * frontend scopes) — they are meant to run on demand. This is the PHP counterpart | |
| 577 | - * to get_js_functions_to_push(): it makes the whole library of functions callable | |
| 578 | - * before a function is executed (via REST, MCP, AI function-calling, Workflow Engine). | |
| 579 | - * | |
| 580 | - * Idempotent: a static guard runs the full pass only once per request, and each | |
| 581 | - * definition is wrapped in function_exists() so nothing is ever redefined. | |
| 582 | - * | |
| 583 | - * @param string|null $except Function name to skip (the one run_snippet is about to | |
| 584 | - * define itself, so edited/test code keeps priority). | |
| 585 | - */ | |
| 586 | - function define_all_functions( $except = null ) { | |
| 587 | - static $loaded = false; | |
| 588 | - if ( $loaded ) { | |
| 589 | - return; | |
| 590 | - } | |
| 591 | - $loaded = true; | |
| 592 | - | |
| 593 | - if ( empty( $this->snippet ) ) { | |
| 594 | - $this->snippet = new Meow_MWCODE_Modules_Snippet( $this ); | |
| 595 | - } | |
| 596 | - | |
| 597 | - // One query for every active function snippet (code included), then enrich with | |
| 598 | - // the function metadata (name + target) the same way run_snippet does. | |
| 599 | - $snippets = $this->snippet->select( | |
| 600 | - null, // offset | |
| 601 | - -1, // limit (all) | |
| 602 | - [ | |
| 603 | - [ 'accessor' => 'active', 'value' => 1 ], | |
| 604 | - [ 'accessor' => 'scope', 'value' => 'function' ], | |
| 605 | - ], | |
| 606 | - [] // sort | |
| 607 | - )['data'] ?? []; | |
| 608 | - | |
| 609 | - if ( empty( $snippets ) ) { | |
| 610 | - return; | |
| 611 | - } | |
| 612 | - | |
| 613 | - $this->snippet->get_function_snippets_data( $snippets ); | |
| 614 | - | |
| 615 | - foreach ( $snippets as $snippet ) { | |
| 616 | - $name = $snippet['functionName'] ?? ''; | |
| 617 | - $target = strtolower( $snippet['functionTarget'] ?? 'php' ); | |
| 618 | - | |
| 619 | - // Skip JS functions (pushed to the front-end separately), the function the | |
| 620 | - // caller will define itself, and anything already declared in this request. | |
| 621 | - if ( $name === '' || $target === 'js' || $name === $except || function_exists( $name ) ) { | |
| 622 | - continue; | |
| 623 | - } | |
| 624 | - | |
| 625 | - // Mirror run_snippet()'s non-test handling: drop echo statements, then declare | |
| 626 | - // (never call) the function, guarded so a later run_snippet() call is a no-op. | |
| 627 | - $code = $this->snippet->sanitize_code( $snippet['code'] ); | |
| 628 | - $code = preg_replace( '/echo\s+(.+?);/s', '', $code ); | |
| 629 | - $code = "if (!function_exists('{$name}')) {\n{$code}\n}\n"; | |
| 630 | - | |
| 631 | - try { | |
| 632 | - eval( $code ); | |
| 633 | - } catch ( Throwable $e ) { | |
| 634 | - $this->log( "⚠️ Code Engine: Failed to pre-define function \"{$name}\": " . $e->getMessage() ); | |
| 635 | - } | |
| 636 | - } | |
| 637 | 499 | } |
| 638 | 500 | |
| 639 | 501 | public function get_js_functions_to_push() { |
| 640 | 502 | $functions = $this->snippet->get_functions(); |