'desktop-1', 'label' => 'Desktop 1', ); } /** * Returns the default empty session shape. * * Includes a default desktop ("Desktop 1") so the client can always * assume at least one desktop exists at boot — the shell can't * function with zero desktops. * * @since 0.4.0 * * @return array{windows: array, desktops: array, activeDesktop: string, focused: string, updated: int} */ function desktop_mode_empty_session() { return array( 'windows' => array(), 'desktops' => array( desktop_mode_default_desktop() ), 'activeDesktop' => 'desktop-1', 'focused' => '', 'updated' => 0, ); } /** * Retrieves the saved desktop session for a user. * * Always returns a well-shaped array so callers don't have to defend * against corrupt or partial meta. * * @since 0.4.0 * * @param int $user_id The user ID. * @return array{windows: array, focused: string, updated: int} */ function desktop_mode_get_session( $user_id ) { $user_id = (int) $user_id; if ( $user_id <= 0 ) { return desktop_mode_empty_session(); } $raw = get_user_meta( $user_id, DESKTOP_MODE_SESSION_META_KEY, true ); if ( ! is_array( $raw ) ) { return desktop_mode_empty_session(); } // Desktops + activeDesktop are post-0.4.0 additions. Sessions // saved before they existed don't carry either field — fall back // to the single default desktop so older sessions degrade // gracefully rather than booting into a zero-desktop limbo. $desktops = isset( $raw['desktops'] ) && is_array( $raw['desktops'] ) ? array_values( $raw['desktops'] ) : array( desktop_mode_default_desktop() ); $active_desktop = isset( $raw['activeDesktop'] ) ? (string) $raw['activeDesktop'] : 'desktop-1'; return array( 'windows' => isset( $raw['windows'] ) && is_array( $raw['windows'] ) ? array_values( $raw['windows'] ) : array(), 'desktops' => $desktops, 'activeDesktop' => $active_desktop, 'focused' => isset( $raw['focused'] ) ? (string) $raw['focused'] : '', 'updated' => isset( $raw['updated'] ) ? (int) $raw['updated'] : 0, ); } /** * Persists a sanitized desktop session to user meta. * * Rejects writes whose `updated` timestamp is older than what's * already on file — a simple last-write-wins guard that prevents two * tabs open on the same user from clobbering each other. The client * stamps `updated` with `Math.floor(Date.now() / 1000)` at snapshot * time (see `WindowManager.snapshot`), so this comparison lines up * with real wall-clock ordering on same-machine multi-tab setups. * * Equal timestamps (two writes in the same second) are accepted — * that's a tie and whichever the server processes first wins, which * matches the pre-0.8 behavior for simultaneous saves. * * @since 0.4.0 * * @param int $user_id The user ID. * @param array $session Raw session payload (will be sanitized). * @return bool True on success, false when stale / invalid / failed. */ function desktop_mode_save_session( $user_id, $session ) { $user_id = (int) $user_id; if ( $user_id <= 0 ) { return false; } if ( is_array( $session ) && isset( $session['updated'] ) ) { $incoming = (int) $session['updated']; if ( $incoming > 0 ) { $existing = desktop_mode_get_session( $user_id ); $stored = isset( $existing['updated'] ) ? (int) $existing['updated'] : 0; if ( $incoming < $stored ) { // Stale write — another tab saved a newer snapshot // after this one was taken. Bail so the user's latest // work isn't overwritten by a slow-to-arrive payload. return false; } } } $clean = desktop_mode_sanitize_session( $session ); return false !== update_user_meta( $user_id, DESKTOP_MODE_SESSION_META_KEY, $clean ); } /** * Clears a user's saved desktop session. * * @since 0.4.0 * * @param int $user_id The user ID. * @return bool True on success. */ function desktop_mode_clear_session( $user_id ) { $user_id = (int) $user_id; if ( $user_id <= 0 ) { return false; } return (bool) delete_user_meta( $user_id, DESKTOP_MODE_SESSION_META_KEY ); } /** * Sanitizes a session payload before persistence. * * Rejects windows whose `url` isn't a same-origin admin URL, clamps * geometry to sane integer ranges, and normalizes the state enum. * Windows beyond {@see DESKTOP_MODE_SESSION_MAX_WINDOWS} are dropped. * * @since 0.4.0 * * @param mixed $session Raw session data from the client. * @return array{windows: array, focused: string, updated: int} */ function desktop_mode_sanitize_session( $session ) { $clean = desktop_mode_empty_session(); if ( ! is_array( $session ) ) { $clean['updated'] = time(); return $clean; } // Preserve the client's `updated` timestamp so the stale-write guard // in desktop_mode_save_session compares client-to-client (not client-to-server // wallclock) — two saves landing in the same second must tie, not lose. $incoming_updated = isset( $session['updated'] ) ? (int) $session['updated'] : 0; $clean['updated'] = $incoming_updated > 0 ? $incoming_updated : time(); if ( isset( $session['focused'] ) && is_string( $session['focused'] ) ) { $clean['focused'] = sanitize_key( $session['focused'] ); } // --- Desktops list ------------------------------------------- // Build a sanitized desktops array first so we can validate // per-window desktopId against it below — windows assigned to // non-existent desktops are quietly remapped to the active // desktop on restore client-side, but we want server-side // integrity too. $desktop_ids = array(); if ( isset( $session['desktops'] ) && is_array( $session['desktops'] ) ) { $clean_desktops = array(); foreach ( $session['desktops'] as $d ) { if ( ! is_array( $d ) ) { continue; } $d_id = isset( $d['id'] ) ? sanitize_key( (string) $d['id'] ) : ''; if ( '' === $d_id ) { continue; } $d_label = isset( $d['label'] ) ? wp_strip_all_tags( (string) $d['label'] ) : ''; if ( '' === $d_label ) { $d_label = $d_id; } // 64-char cap on labels — generous for any sensible // human-typed desktop name, hard ceiling on meta size. if ( strlen( $d_label ) > 64 ) { $d_label = substr( $d_label, 0, 64 ); } $clean_desktops[] = array( 'id' => $d_id, 'label' => $d_label, ); $desktop_ids[] = $d_id; if ( count( $clean_desktops ) >= DESKTOP_MODE_SESSION_MAX_DESKTOPS ) { break; } } if ( ! empty( $clean_desktops ) ) { $clean['desktops'] = $clean_desktops; } } // Always at least one desktop in the persisted shape — guards // against a client clearing every desktop and saving an empty // list, or omitting the key entirely. if ( empty( $clean['desktops'] ) ) { $clean['desktops'] = array( desktop_mode_default_desktop() ); } if ( empty( $desktop_ids ) ) { // Rebuild ids from the authoritative desktops list so the // per-window desktopId validation below has something to // compare against — otherwise a client that omits `desktops` // but sends windows would hit `$desktop_ids[0]` on an empty // array. $desktop_ids = array_map( static function ( $d ) { return isset( $d['id'] ) ? (string) $d['id'] : ''; }, $clean['desktops'] ); $desktop_ids = array_values( array_filter( $desktop_ids ) ); if ( empty( $desktop_ids ) ) { $desktop_ids = array( 'desktop-1' ); } } // --- Active desktop ------------------------------------------ if ( isset( $session['activeDesktop'] ) && is_string( $session['activeDesktop'] ) ) { $candidate = sanitize_key( $session['activeDesktop'] ); if ( in_array( $candidate, $desktop_ids, true ) ) { $clean['activeDesktop'] = $candidate; } } // Fallback: first valid desktop. Already true via desktop_mode_empty_session // when the client passed nothing, but guards the case where // activeDesktop named a desktop that didn't survive sanitization. if ( ! in_array( $clean['activeDesktop'], $desktop_ids, true ) ) { $clean['activeDesktop'] = $desktop_ids[ 0 ]; } if ( isset( $session['windows'] ) && is_array( $session['windows'] ) ) { foreach ( $session['windows'] as $win ) { if ( ! is_array( $win ) ) { continue; } $id = isset( $win['id'] ) ? sanitize_key( (string) $win['id'] ) : ''; if ( '' === $id ) { continue; } // `baseId` groups multi-instance windows of the same admin page // (e.g. `edit-php`, `edit-php-2`, `edit-php-3` all share baseId // `edit-php`). Optional — older sessions predate the field and // the client falls back to `id` when missing. $base_id = isset( $win['baseId'] ) ? sanitize_key( (string) $win['baseId'] ) : ''; if ( '' === $base_id ) { $base_id = $id; } $url = isset( $win['url'] ) ? esc_url_raw( (string) $win['url'] ) : ''; // Only allow URLs that land inside our own wp-admin — both // a safety net against storing arbitrary origins in user meta // and a guarantee the restore path won't try to iframe a // cross-origin page. Host+path parsing rejects tricks like // `//evil.com/wp-admin/…` that a raw prefix check would miss. if ( '' === $url || ! desktop_mode_url_is_same_admin( $url ) ) { continue; } // Strip transient/routing flags before storage. The chromeless // `desktop_mode_chromeless` flag is an iframe-only concern and must never // end up in a top-level URL (e.g., the portal's entry URL); // the portal and classic flags only live on a single request. $url = remove_query_arg( array( 'desktop_mode_chromeless', DESKTOP_MODE_PORTAL_FLAG, DESKTOP_MODE_CLASSIC_FLAG ), $url ); $state = isset( $win['state'] ) ? (string) $win['state'] : 'normal'; if ( ! in_array( $state, DESKTOP_MODE_SESSION_STATES, true ) ) { $state = 'normal'; } // Map the window to a known desktop. A client that sends a // desktopId pointing at a non-existent desktop (race with // a desktop close, or a malicious payload) is silently // remapped to the active desktop so the window remains // visible — losing it on restore would be the worse UX. $win_desktop = isset( $win['desktopId'] ) ? sanitize_key( (string) $win['desktopId'] ) : ''; if ( '' === $win_desktop || ! in_array( $win_desktop, $desktop_ids, true ) ) { $win_desktop = $clean['activeDesktop']; } $entry = array( 'id' => $id, 'baseId' => $base_id, 'desktopId' => $win_desktop, 'url' => $url, 'title' => isset( $win['title'] ) ? wp_strip_all_tags( (string) $win['title'] ) : '', 'icon' => isset( $win['icon'] ) ? sanitize_html_class( (string) $win['icon'] ) : 'dashicons-admin-generic', 'state' => $state, 'x' => desktop_mode_sanitize_session_dimension( $win['x'] ?? 0, -10000, 10000 ), 'y' => desktop_mode_sanitize_session_dimension( $win['y'] ?? 0, -10000, 10000 ), 'width' => desktop_mode_sanitize_session_dimension( $win['width'] ?? 800, 0, 20000 ), 'height' => desktop_mode_sanitize_session_dimension( $win['height'] ?? 600, 0, 20000 ), ); // Sanitize external sub-tabs. Each entry carries a URL // (any http/https — external tabs are explicitly for links // OUT of wp-admin, so we don't restrict to same-origin // here) and a label. Capped at a reasonable per-window // limit so a runaway client can't balloon user meta. if ( isset( $win['externalTabs'] ) && is_array( $win['externalTabs'] ) ) { $tabs = array(); foreach ( $win['externalTabs'] as $tab ) { if ( ! is_array( $tab ) ) { continue; } $tab_url = isset( $tab['url'] ) ? esc_url_raw( (string) $tab['url'], array( 'http', 'https' ) ) : ''; if ( '' === $tab_url ) { continue; } // Hard cap on URL length — a runaway client (or a // malicious payload) could otherwise push many // megabytes of URL into user meta. 2048 is the // de-facto IE-legacy URL length limit and covers // every real URL the shell restores. if ( strlen( $tab_url ) > 2048 ) { continue; } $label = isset( $tab['label'] ) ? wp_strip_all_tags( (string) $tab['label'] ) : ''; // Trim long labels server-side too, mirroring the // client-side 80-char slice in the chromeless // bridge. Keeps meta size predictable. if ( strlen( $label ) > 80 ) { $label = substr( $label, 0, 80 ); } $tabs[] = array( 'url' => $tab_url, 'label' => $label, ); if ( count( $tabs ) >= 16 ) { break; } } if ( ! empty( $tabs ) ) { $entry['externalTabs'] = $tabs; } } $clean['windows'][] = $entry; if ( count( $clean['windows'] ) >= DESKTOP_MODE_SESSION_MAX_WINDOWS ) { break; } } } return $clean; } /** * Clamps a numeric dimension into a sane range. * * Geometry coming from the client is untrusted. A malicious or buggy * payload could try to stash multi-million-pixel values in meta, * negative values that break the shell, or non-numeric garbage * (strings, arrays, objects). This enforces numeric type and min/max * bounds, falling back to `$min` for anything non-numeric so the * window restores to a sane geometry rather than colliding with 0. * * `INF`, `NAN`, and array/object input are rejected by `is_numeric()` * before the `(int)` cast, eliminating any overflow or type-juggling * surprise. * * @since 0.4.0 * @since 0.11.0 Rejects non-numeric input explicitly instead of * relying on PHP's permissive `(int)` cast. * * @param mixed $value The raw value. * @param int $min Minimum allowed value. * @param int $max Maximum allowed value. * @return int The clamped integer. */ function desktop_mode_sanitize_session_dimension( $value, $min, $max ) { if ( is_string( $value ) ) { $value = trim( $value ); } if ( ! is_numeric( $value ) ) { return (int) $min; } $value = (int) $value; if ( $value < $min ) { return (int) $min; } if ( $value > $max ) { return (int) $max; } return $value; } /** * Registers the REST routes used by the desktop shell to load and save * the current user's session. * * @since 0.4.0 */ function desktop_mode_register_session_rest_routes() { register_rest_route( 'desktop-mode/v1', '/session', array( array( 'methods' => WP_REST_Server::READABLE, 'callback' => 'desktop_mode_rest_get_session', 'permission_callback' => 'desktop_mode_rest_session_permission', ), array( 'methods' => WP_REST_Server::CREATABLE, 'callback' => 'desktop_mode_rest_save_session', 'permission_callback' => 'desktop_mode_rest_session_permission', 'args' => array( 'session' => array( 'required' => true, 'type' => 'object', ), ), ), array( 'methods' => WP_REST_Server::DELETABLE, 'callback' => 'desktop_mode_rest_clear_session', 'permission_callback' => 'desktop_mode_rest_session_permission', ), ) ); } add_action( 'rest_api_init', 'desktop_mode_register_session_rest_routes' ); /** * Permission gate for the session REST routes: logged-in users with * basic admin-read capability. * * @since 0.4.0 * * @return bool */ function desktop_mode_rest_session_permission() { return is_user_logged_in() && current_user_can( 'read' ); } /** * GET /desktop-mode/v1/session — returns the caller's session. * * @since 0.4.0 * * @return WP_REST_Response */ function desktop_mode_rest_get_session() { return rest_ensure_response( desktop_mode_get_session( get_current_user_id() ) ); } /** * POST /desktop-mode/v1/session — replaces the caller's session. * * @since 0.4.0 * * @param WP_REST_Request $request The REST request. * @return WP_REST_Response The stored session (after sanitization). */ function desktop_mode_rest_save_session( WP_REST_Request $request ) { $user_id = get_current_user_id(); $payload = $request->get_param( 'session' ); desktop_mode_save_session( $user_id, $payload ); return rest_ensure_response( desktop_mode_get_session( $user_id ) ); } /** * DELETE /desktop-mode/v1/session — clears the caller's session. * * @since 0.4.0 * * @return WP_REST_Response */ function desktop_mode_rest_clear_session() { desktop_mode_clear_session( get_current_user_id() ); return rest_ensure_response( desktop_mode_empty_session() ); }