| @@ -4,16 +4,15 @@ | ||
| 4 | 4 | use Elementor\Base_Data_Control; |
| 5 | 5 | use Elementor\Control_Repeater; |
| 6 | 6 | use Elementor\Controls_Manager; |
| 7 | 7 | use Elementor\Controls_Stack; |
| 8 | -use Elementor\Core\Breakpoints\Manager as Breakpoints_Manager; | |
| 9 | 8 | use Elementor\Core\Files\Base as Base_File; |
| 10 | 9 | use Elementor\Core\DynamicTags\Manager; |
| 11 | 10 | use Elementor\Core\DynamicTags\Tag; |
| 12 | -use Elementor\Core\Frontend\Performance; | |
| 13 | -use Elementor\Core\Frontend\Widget_Content_Render_Mode; | |
| 14 | 11 | use Elementor\Core\Kits\Documents\Tabs\Global_Typography; |
| 12 | +use Elementor\Element_Base; | |
| 15 | 13 | use Elementor\Plugin; |
| 14 | +use Elementor\Core\Responsive\Responsive; | |
| 16 | 15 | use Elementor\Stylesheet; |
| 17 | 16 | use Elementor\Icons_Manager; |
| 18 | 17 | |
| 19 | 18 | if ( ! defined( 'ABSPATH' ) ) { |
| @@ -65,10 +64,8 @@ | ||
| 65 | 64 | private $icons_fonts = []; |
| 66 | 65 | |
| 67 | 66 | private $dynamic_elements_ids = []; |
| 68 | 67 | |
| 69 | - private $preserved_dynamic_style_values = []; | |
| 70 | - | |
| 71 | 68 | /** |
| 72 | 69 | * Stylesheet object. |
| 73 | 70 | * |
| 74 | 71 | * Holds the CSS file stylesheet instance. |
| @@ -180,19 +177,8 @@ | ||
| 180 | 177 | } |
| 181 | 178 | } |
| 182 | 179 | |
| 183 | 180 | /** |
| 184 | - * Get Responsive Control Duplication Mode | |
| 185 | - * | |
| 186 | - * @since 3.4.0 | |
| 187 | - * | |
| 188 | - * @return string | |
| 189 | - */ | |
| 190 | - protected function get_responsive_control_duplication_mode() { | |
| 191 | - return 'on'; | |
| 192 | - } | |
| 193 | - | |
| 194 | - /** | |
| 195 | 181 | * Enqueue CSS. |
| 196 | 182 | * |
| 197 | 183 | * Either enqueue the CSS file in Elementor or add inline style. |
| 198 | 184 | * |
| @@ -201,12 +187,8 @@ | ||
| 201 | 187 | * @since 1.2.0 |
| 202 | 188 | * @access public |
| 203 | 189 | */ |
| 204 | 190 | public function enqueue() { |
| 205 | - if ( $this->should_skip_enqueue() ) { | |
| 206 | - return; | |
| 207 | - } | |
| 208 | - | |
| 209 | 191 | $handle_id = $this->get_file_handle_id(); |
| 210 | 192 | |
| 211 | 193 | if ( isset( self::$printed[ $handle_id ] ) ) { |
| 212 | 194 | return; |
| @@ -219,17 +201,8 @@ | ||
| 219 | 201 | if ( self::CSS_STATUS_EMPTY === $meta['status'] ) { |
| 220 | 202 | return; |
| 221 | 203 | } |
| 222 | 204 | |
| 223 | - /** | |
| 224 | - * Enqueue CSS file. | |
| 225 | - * | |
| 226 | - * Fires before enqueuing a CSS file. | |
| 227 | - * | |
| 228 | - * @param Base $this The current CSS file. | |
| 229 | - */ | |
| 230 | - do_action( 'elementor/css-file/before_enqueue', $this ); | |
| 231 | - | |
| 232 | 205 | // First time after clear cache and etc. |
| 233 | 206 | if ( '' === $meta['status'] || $this->is_update_required() ) { |
| 234 | 207 | $this->update(); |
| 235 | 208 | |
| @@ -237,17 +210,16 @@ | ||
| 237 | 210 | } |
| 238 | 211 | |
| 239 | 212 | if ( self::CSS_STATUS_INLINE === $meta['status'] ) { |
| 240 | 213 | $dep = $this->get_inline_dependency(); |
| 241 | - $is_dependency_registered = (bool) wp_styles()->query( $dep, 'registered' ); | |
| 242 | - | |
| 243 | - if ( ! $is_dependency_registered || wp_styles()->query( $dep, 'done' ) ) { | |
| 244 | - printf( '<style id="%1$s">%2$s</style>', $this->get_file_handle_id(), $meta['css'] ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 214 | + // If the dependency has already been printed ( like a template in footer ) | |
| 215 | + if ( wp_styles()->query( $dep, 'done' ) ) { | |
| 216 | + printf( '<style id="%1$s">%2$s</style>', $this->get_file_handle_id(), $meta['css'] ); // XSS ok. | |
| 245 | 217 | } else { |
| 246 | 218 | wp_add_inline_style( $dep, $meta['css'] ); |
| 247 | 219 | } |
| 248 | 220 | } elseif ( self::CSS_STATUS_FILE === $meta['status'] ) { // Re-check if it's not empty after CSS update. |
| 249 | - wp_enqueue_style( $this->get_file_handle_id(), $this->get_url(), $this->get_registered_enqueue_dependencies(), null ); | |
| 221 | + wp_enqueue_style( $this->get_file_handle_id(), $this->get_url(), $this->get_enqueue_dependencies(), null ); // phpcs:ignore WordPress.WP.EnqueuedResourceParameters.MissingVersion | |
| 250 | 222 | } |
| 251 | 223 | |
| 252 | 224 | // Handle fonts. |
| 253 | 225 | if ( ! empty( $meta['fonts'] ) ) { |
| @@ -279,17 +251,8 @@ | ||
| 279 | 251 | * |
| 280 | 252 | * @param Base $this The current CSS file. |
| 281 | 253 | */ |
| 282 | 254 | do_action( "elementor/css-file/{$name}/enqueue", $this ); |
| 283 | - | |
| 284 | - /** | |
| 285 | - * Enqueue CSS file. | |
| 286 | - * | |
| 287 | - * Fires after enqueuing a CSS file. | |
| 288 | - * | |
| 289 | - * @param Base $this The current CSS file. | |
| 290 | - */ | |
| 291 | - do_action( 'elementor/css-file/after_enqueue', $this ); | |
| 292 | 255 | } |
| 293 | 256 | |
| 294 | 257 | /** |
| 295 | 258 | * Print CSS. |
| @@ -300,9 +263,9 @@ | ||
| 300 | 263 | * @since 1.9.4 |
| 301 | 264 | * @access public |
| 302 | 265 | */ |
| 303 | 266 | public function print_css() { |
| 304 | - echo '<style>' . $this->get_content() . '</style>'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 267 | + echo '<style>' . $this->get_content() . '</style>'; // XSS ok. | |
| 305 | 268 | Plugin::$instance->frontend->print_fonts_links(); |
| 306 | 269 | } |
| 307 | 270 | |
| 308 | 271 | /** |
| @@ -353,10 +316,8 @@ | ||
| 353 | 316 | } |
| 354 | 317 | |
| 355 | 318 | $stylesheet = $this->get_stylesheet(); |
| 356 | 319 | |
| 357 | - $control = apply_filters( 'elementor/files/css/selectors', $control, $value ?? [], $this ); | |
| 358 | - | |
| 359 | 320 | foreach ( $control['selectors'] as $selector => $css_property ) { |
| 360 | 321 | $output_css_property = ''; |
| 361 | 322 | |
| 362 | 323 | if ( $global_key ) { |
| @@ -366,19 +327,13 @@ | ||
| 366 | 327 | $output_css_property = preg_replace( '/(:)[^;]+(;?)/', '$1' . $selector_global_value . '$2', $css_property ); |
| 367 | 328 | } |
| 368 | 329 | } else { |
| 369 | 330 | try { |
| 370 | - if ( $this->unit_has_custom_selector( $control, $value ) ) { | |
| 371 | - $css_property = $control['unit_selectors_dictionary'][ $value['unit'] ]; | |
| 372 | - } | |
| 373 | - | |
| 374 | 331 | $output_css_property = preg_replace_callback( '/{{(?:([^.}]+)\.)?([^}| ]*)(?: *\|\| *(?:([^.}]+)\.)?([^}| ]*) *)*}}/', function( $matches ) use ( $control, $value_callback, $controls_stack, $value, $css_property ) { |
| 375 | 332 | $external_control_missing = $matches[1] && ! isset( $controls_stack[ $matches[1] ] ); |
| 376 | 333 | |
| 377 | 334 | $parsed_value = ''; |
| 378 | 335 | |
| 379 | - $value = apply_filters( 'elementor/files/css/property', $value, $css_property, $matches, $control ); | |
| 380 | - | |
| 381 | 336 | if ( ! $external_control_missing ) { |
| 382 | 337 | $parsed_value = $this->parse_property_placeholder( $control, $value, $controls_stack, $value_callback, $matches[2], $matches[1] ); |
| 383 | 338 | } |
| 384 | 339 | |
| @@ -407,12 +362,8 @@ | ||
| 407 | 362 | throw new \Exception(); |
| 408 | 363 | } |
| 409 | 364 | } |
| 410 | 365 | |
| 411 | - if ( '__EMPTY__' === $parsed_value ) { | |
| 412 | - $parsed_value = ''; | |
| 413 | - } | |
| 414 | - | |
| 415 | 366 | return $parsed_value; |
| 416 | 367 | }, $css_property ); |
| 417 | 368 | } catch ( \Exception $e ) { |
| 418 | 369 | return; |
| @@ -436,9 +387,9 @@ | ||
| 436 | 387 | |
| 437 | 388 | $pure_device_rules = $pure_device_rules[1]; |
| 438 | 389 | |
| 439 | 390 | foreach ( $pure_device_rules as $device_rule ) { |
| 440 | - if ( Breakpoints_Manager::BREAKPOINT_KEY_DESKTOP === $device_rule ) { | |
| 391 | + if ( Element_Base::RESPONSIVE_DESKTOP === $device_rule ) { | |
| 441 | 392 | continue; |
| 442 | 393 | } |
| 443 | 394 | |
| 444 | 395 | $device = preg_replace( '/\+$/', '', $device_rule ); |
| @@ -453,9 +404,9 @@ | ||
| 453 | 404 | |
| 454 | 405 | if ( ! $query && ! empty( $control['responsive'] ) ) { |
| 455 | 406 | $query = array_intersect_key( $control['responsive'], array_flip( [ 'min', 'max' ] ) ); |
| 456 | 407 | |
| 457 | - if ( ! empty( $query['max'] ) && Breakpoints_Manager::BREAKPOINT_KEY_DESKTOP === $query['max'] ) { | |
| 408 | + if ( ! empty( $query['max'] ) && Element_Base::RESPONSIVE_DESKTOP === $query['max'] ) { | |
| 458 | 409 | unset( $query['max'] ); |
| 459 | 410 | } |
| 460 | 411 | } |
| 461 | 412 | |
| @@ -462,12 +413,8 @@ | ||
| 462 | 413 | $stylesheet->add_rules( $parsed_selector, $output_css_property, $query ); |
| 463 | 414 | } |
| 464 | 415 | } |
| 465 | 416 | |
| 466 | - protected function unit_has_custom_selector( $control, $value ) { | |
| 467 | - return isset( $control['unit_selectors_dictionary'] ) && isset( $control['unit_selectors_dictionary'][ $value['unit'] ] ); | |
| 468 | - } | |
| 469 | - | |
| 470 | 417 | /** |
| 471 | 418 | * @param array $control |
| 472 | 419 | * @param mixed $value |
| 473 | 420 | * @param array $controls_stack |
| @@ -478,27 +425,15 @@ | ||
| 478 | 425 | * @return string |
| 479 | 426 | */ |
| 480 | 427 | public function parse_property_placeholder( array $control, $value, array $controls_stack, $value_callback, $placeholder, $parser_control_name = null ) { |
| 481 | 428 | if ( $parser_control_name ) { |
| 482 | - // If both the processed control and the control name found in the placeholder are responsive | |
| 483 | - if ( ! empty( $control['responsive'] ) && ! empty( $controls_stack[ $parser_control_name ]['responsive'] ) ) { | |
| 484 | - $device_suffix = Controls_Manager::get_responsive_control_device_suffix( $control ); | |
| 429 | + $control = $controls_stack[ $parser_control_name ]; | |
| 485 | 430 | |
| 486 | - $control = $controls_stack[ $parser_control_name . $device_suffix ] ?? $controls_stack[ $parser_control_name ]; | |
| 487 | - } else { | |
| 488 | - $control = $controls_stack[ $parser_control_name ]; | |
| 489 | - } | |
| 490 | - | |
| 491 | 431 | $value = call_user_func( $value_callback, $control ); |
| 492 | 432 | } |
| 493 | 433 | |
| 494 | - // If the control value is empty, check for global default. `0` (integer, string) are falsy but are valid values. | |
| 495 | - if ( empty( $value ) && '0' !== $value && 0 !== $value ) { | |
| 496 | - $value = $this->get_control_global_default_value( $control ); | |
| 497 | - } | |
| 498 | - | |
| 499 | 434 | if ( Controls_Manager::FONT === $control['type'] ) { |
| 500 | - $this->add_font( $value ); | |
| 435 | + $this->fonts[] = $value; | |
| 501 | 436 | } |
| 502 | 437 | |
| 503 | 438 | /** @var Base_Data_Control $control_obj */ |
| 504 | 439 | $control_obj = Plugin::$instance->controls_manager->get_control( $control['type'] ); |
| @@ -554,9 +489,9 @@ | ||
| 554 | 489 | * @param array $placeholders Placeholders. |
| 555 | 490 | * @param array $replacements Replacements. |
| 556 | 491 | * @param array $all_controls All controls. |
| 557 | 492 | */ |
| 558 | - public function add_controls_stack_style_rules( Controls_Stack $controls_stack, array $controls, array $values, array $placeholders, array $replacements, ?array $all_controls = null ) { | |
| 493 | + public function add_controls_stack_style_rules( Controls_Stack $controls_stack, array $controls, array $values, array $placeholders, array $replacements, array $all_controls = null ) { | |
| 559 | 494 | if ( ! $all_controls ) { |
| 560 | 495 | $all_controls = $controls_stack->get_controls(); |
| 561 | 496 | } |
| 562 | 497 | |
| @@ -578,13 +513,8 @@ | ||
| 578 | 513 | if ( ! empty( $parsed_dynamic_settings[ Manager::DYNAMIC_SETTING_KEY ][ $control['name'] ] ) ) { |
| 579 | 514 | // Dynamic CSS should not be added to the CSS files. |
| 580 | 515 | // Instead it's handled by \Elementor\Core\DynamicTags\Dynamic_CSS |
| 581 | 516 | // and printed in a style tag. |
| 582 | - $should_preserve_value = isset( $control['control_type'] ) && 'content' === $control['control_type']; | |
| 583 | - if ( $should_preserve_value ) { | |
| 584 | - $this->preserved_dynamic_style_values[ $control['name'] ] = $parsed_dynamic_settings[ $control['name'] ]; | |
| 585 | - } | |
| 586 | - | |
| 587 | 517 | unset( $parsed_dynamic_settings[ $control['name'] ] ); |
| 588 | 518 | |
| 589 | 519 | $this->dynamic_elements_ids[] = $controls_stack->get_id(); |
| 590 | 520 | |
| @@ -611,31 +541,8 @@ | ||
| 611 | 541 | * @return string CSS file handle ID. |
| 612 | 542 | */ |
| 613 | 543 | abstract protected function get_file_handle_id(); |
| 614 | 544 | |
| 615 | - protected function should_skip_enqueue(): bool { | |
| 616 | - if ( Widget_Content_Render_Mode::is( Widget_Content_Render_Mode::MARKDOWN ) ) { | |
| 617 | - return true; | |
| 618 | - } | |
| 619 | - | |
| 620 | - if ( ! is_admin() ) { | |
| 621 | - return false; | |
| 622 | - } | |
| 623 | - | |
| 624 | - $editor = Plugin::$instance->editor; | |
| 625 | - | |
| 626 | - return $editor && $editor->is_editor_request(); | |
| 627 | - } | |
| 628 | - | |
| 629 | - protected function get_registered_enqueue_dependencies(): array { | |
| 630 | - return array_values( array_filter( | |
| 631 | - $this->get_enqueue_dependencies(), | |
| 632 | - static function ( $handle ) { | |
| 633 | - return (bool) wp_styles()->query( $handle, 'registered' ); | |
| 634 | - } | |
| 635 | - ) ); | |
| 636 | - } | |
| 637 | - | |
| 638 | 545 | /** |
| 639 | 546 | * Render CSS. |
| 640 | 547 | * |
| 641 | 548 | * Parse the CSS. |
| @@ -706,14 +613,8 @@ | ||
| 706 | 613 | * @since 1.2.0 |
| 707 | 614 | * @access protected |
| 708 | 615 | */ |
| 709 | 616 | protected function parse_content() { |
| 710 | - Performance::set_use_style_controls( true ); | |
| 711 | - | |
| 712 | - $initial_responsive_controls_duplication_mode = Plugin::$instance->breakpoints->get_responsive_control_duplication_mode(); | |
| 713 | - | |
| 714 | - Plugin::$instance->breakpoints->set_responsive_control_duplication_mode( $this->get_responsive_control_duplication_mode() ); | |
| 715 | - | |
| 716 | 617 | $this->render_css(); |
| 717 | 618 | |
| 718 | 619 | $name = $this->get_name(); |
| 719 | 620 | |
| @@ -729,12 +630,8 @@ | ||
| 729 | 630 | * @param Base $this The current CSS file. |
| 730 | 631 | */ |
| 731 | 632 | do_action( "elementor/css-file/{$name}/parse", $this ); |
| 732 | 633 | |
| 733 | - Plugin::$instance->breakpoints->set_responsive_control_duplication_mode( $initial_responsive_controls_duplication_mode ); | |
| 734 | - | |
| 735 | - Performance::set_use_style_controls( false ); | |
| 736 | - | |
| 737 | 634 | return $this->get_stylesheet()->__toString(); |
| 738 | 635 | } |
| 739 | 636 | |
| 740 | 637 | /** |
| @@ -759,44 +656,8 @@ | ||
| 759 | 656 | ); |
| 760 | 657 | } |
| 761 | 658 | |
| 762 | 659 | /** |
| 763 | - * Get Control Global Default Value | |
| 764 | - * | |
| 765 | - * If the control has a global default value, and the corresponding global default setting is enabled, this method | |
| 766 | - * fetches and returns the global default value. Otherwise, it returns null. | |
| 767 | - * | |
| 768 | - * @since 3.7.0 | |
| 769 | - * @access private | |
| 770 | - * | |
| 771 | - * @param $control | |
| 772 | - * @return string|null | |
| 773 | - */ | |
| 774 | - private function get_control_global_default_value( $control ) { | |
| 775 | - if ( empty( $control['global']['default'] ) ) { | |
| 776 | - return null; | |
| 777 | - } | |
| 778 | - | |
| 779 | - // If the control value is empty, and the control has a global default set, fetch the global value and use it. | |
| 780 | - $global_enabled = false; | |
| 781 | - | |
| 782 | - if ( 'color' === $control['type'] ) { | |
| 783 | - $global_enabled = Plugin::$instance->kits_manager->is_custom_colors_enabled(); | |
| 784 | - } elseif ( isset( $control['groupType'] ) && 'typography' === $control['groupType'] ) { | |
| 785 | - $global_enabled = Plugin::$instance->kits_manager->is_custom_typography_enabled(); | |
| 786 | - } | |
| 787 | - | |
| 788 | - $value = null; | |
| 789 | - | |
| 790 | - // Only apply the global default if Global Colors are enabled. | |
| 791 | - if ( $global_enabled ) { | |
| 792 | - $value = $this->get_selector_global_value( $control, $control['global']['default'] ); | |
| 793 | - } | |
| 794 | - | |
| 795 | - return $value; | |
| 796 | - } | |
| 797 | - | |
| 798 | - /** | |
| 799 | 660 | * Get style control value. |
| 800 | 661 | * |
| 801 | 662 | * Retrieve the value of the style control for any give control and values. |
| 802 | 663 | * |
| @@ -815,11 +676,9 @@ | ||
| 815 | 676 | // When the control itself has no global value, but it refers to another control global value |
| 816 | 677 | return $this->get_selector_global_value( $control, $values['__globals__'][ $control['name'] ] ); |
| 817 | 678 | } |
| 818 | 679 | |
| 819 | - $value = isset( $values[ $control['name'] ] ) | |
| 820 | - ? $values[ $control['name'] ] | |
| 821 | - : $this->preserved_dynamic_style_values[ $control['name'] ] ?? null; | |
| 680 | + $value = $values[ $control['name'] ]; | |
| 822 | 681 | |
| 823 | 682 | if ( isset( $control['selectors_dictionary'][ $value ] ) ) { |
| 824 | 683 | $value = $control['selectors_dictionary'][ $value ]; |
| 825 | 684 | } |
| @@ -842,13 +701,14 @@ | ||
| 842 | 701 | */ |
| 843 | 702 | private function init_stylesheet() { |
| 844 | 703 | $this->stylesheet_obj = new Stylesheet(); |
| 845 | 704 | |
| 846 | - $active_breakpoints = Plugin::$instance->breakpoints->get_active_breakpoints(); | |
| 705 | + $breakpoints = Responsive::get_breakpoints(); | |
| 847 | 706 | |
| 848 | - foreach ( $active_breakpoints as $breakpoint_name => $breakpoint ) { | |
| 849 | - $this->stylesheet_obj->add_device( $breakpoint_name, $breakpoint->get_value() ); | |
| 850 | - } | |
| 707 | + $this->stylesheet_obj | |
| 708 | + ->add_device( 'mobile', 0 ) | |
| 709 | + ->add_device( 'tablet', $breakpoints['md'] ) | |
| 710 | + ->add_device( 'desktop', $breakpoints['lg'] ); | |
| 851 | 711 | } |
| 852 | 712 | |
| 853 | 713 | /** |
| 854 | 714 | * Add repeater control style rules. |
| @@ -902,9 +762,9 @@ | ||
| 902 | 762 | } ); |
| 903 | 763 | } |
| 904 | 764 | |
| 905 | 765 | private function get_selector_global_value( $control, $global_key ) { |
| 906 | - $data = Plugin::$instance->data_manager_v2->run( $global_key ); | |
| 766 | + $data = Plugin::$instance->data_manager->run( $global_key ); | |
| 907 | 767 | |
| 908 | 768 | if ( empty( $data['value'] ) ) { |
| 909 | 769 | return null; |
| 910 | 770 | } |
| @@ -913,18 +773,10 @@ | ||
| 913 | 773 | |
| 914 | 774 | $id = $global_args[1]; |
| 915 | 775 | |
| 916 | 776 | if ( ! empty( $control['groupType'] ) ) { |
| 917 | - $strings_to_replace = [ $control['groupPrefix'] ]; | |
| 777 | + $property_name = str_replace( [ $control['groupPrefix'], '_tablet', '_mobile' ], '', $control['name'] ); | |
| 918 | 778 | |
| 919 | - $active_breakpoint_keys = array_keys( Plugin::$instance->breakpoints->get_active_breakpoints() ); | |
| 920 | - | |
| 921 | - foreach ( $active_breakpoint_keys as $breakpoint ) { | |
| 922 | - $strings_to_replace[] = '_' . $breakpoint; | |
| 923 | - } | |
| 924 | - | |
| 925 | - $property_name = str_replace( $strings_to_replace, '', $control['name'] ); | |
| 926 | - | |
| 927 | 779 | // TODO: This check won't retrieve the proper answer for array values (multiple controls). |
| 928 | 780 | if ( empty( $data['value'][ Global_Typography::TYPOGRAPHY_GROUP_PREFIX . $property_name ] ) ) { |
| 929 | 781 | return null; |
| 930 | 782 | } |
| @@ -931,16 +783,8 @@ | ||
| 931 | 783 | |
| 932 | 784 | $property_name = str_replace( '_', '-', $property_name ); |
| 933 | 785 | |
| 934 | 786 | $value = "var( --e-global-$control[groupType]-$id-$property_name )"; |
| 935 | - | |
| 936 | - if ( $control['groupPrefix'] . 'font_family' === $control['name'] ) { | |
| 937 | - $default_generic_fonts = Plugin::$instance->kits_manager->get_current_settings( 'default_generic_fonts' ); | |
| 938 | - | |
| 939 | - if ( $default_generic_fonts ) { | |
| 940 | - $value .= ", $default_generic_fonts"; | |
| 941 | - } | |
| 942 | - } | |
| 943 | 787 | } else { |
| 944 | 788 | $value = "var( --e-global-$control[type]-$id )"; |
| 945 | 789 | } |
| 946 | 790 | |
| @@ -946,9 +790,9 @@ | ||
| 946 | 790 | |
| 947 | 791 | return $value; |
| 948 | 792 | } |
| 949 | 793 | |
| 950 | - final protected function get_active_controls( Controls_Stack $controls_stack, ?array $controls = null, ?array $settings = null ) { | |
| 794 | + final protected function get_active_controls( Controls_Stack $controls_stack, array $controls = null, array $settings = null ) { | |
| 951 | 795 | if ( ! $controls ) { |
| 952 | 796 | $controls = $controls_stack->get_controls(); |
| 953 | 797 | } |
| 954 | 798 | |
| @@ -963,9 +807,9 @@ | ||
| 963 | 807 | $active_controls = array_reduce( |
| 964 | 808 | array_keys( $controls ), function( $active_controls, $control_key ) use ( $controls_stack, $controls, $settings ) { |
| 965 | 809 | $control = $controls[ $control_key ]; |
| 966 | 810 | |
| 967 | - if ( $controls_stack->is_control_visible( $control, $settings, $controls ) ) { | |
| 811 | + if ( $controls_stack->is_control_visible( $control, $settings ) ) { | |
| 968 | 812 | $active_controls[ $control_key ] = $control; |
| 969 | 813 | } |
| 970 | 814 | |
| 971 | 815 | return $active_controls; |
| @@ -974,9 +818,9 @@ | ||
| 974 | 818 | |
| 975 | 819 | return $active_controls; |
| 976 | 820 | } |
| 977 | 821 | |
| 978 | - final public function get_style_controls( Controls_Stack $controls_stack, ?array $controls = null, ?array $settings = null ) { | |
| 822 | + final public function get_style_controls( Controls_Stack $controls_stack, array $controls = null, array $settings = null ) { | |
| 979 | 823 | $controls = $this->get_active_controls( $controls_stack, $controls, $settings ); |
| 980 | 824 | |
| 981 | 825 | $style_controls = []; |
| 982 | 826 | |
| @@ -1053,12 +897,6 @@ | ||
| 1053 | 897 | |
| 1054 | 898 | $globals = $controls_stack->get_settings( '__globals__' ); |
| 1055 | 899 | |
| 1056 | 900 | return ! empty( $globals[ $control_global_key ] ); |
| 1057 | - } | |
| 1058 | - | |
| 1059 | - public function add_font( $font ) { | |
| 1060 | - if ( ! in_array( $font, $this->fonts, true ) ) { | |
| 1061 | - $this->fonts[] = $font; | |
| 1062 | - } | |
| 1063 | 901 | } |
| 1064 | 902 | } |
