PluginProbe
Elementor Website Builder – more than just a page builder / 3.10.0-dev1
Elementor Website Builder – more than just a page builder v3.10.0-dev1
4.3.0-beta3 4.3.0-beta2 4.3.0-beta1 4.2.4 4.2.3 4.2.2 4.2.1 4.2.0 4.1.5 4.2.0-beta2 4.2.0-dev2 4.2.0-beta1 4.1.4 4.1.3 4.1.2 4.1.1 4.1.0 4.1.0-beta3 4.1.0-dev3 4.0.9 4.1.0-beta2 4.1.0-dev2 4.0.8 4.1.0-beta1 4.1.0-dev1 All 452 releases
← All changes | core/experiments/manager.php +194 -425 4.3.0-beta13.10.0-dev1 View file →
@@ -1,9 +1,8 @@
1 1 <?php
2 2 namespace Elementor\Core\Experiments;
3 3
4 4 use Elementor\Core\Base\Base_Object;
5 -use Elementor\Core\Experiments\Exceptions\Dependency_Exception;
6 5 use Elementor\Core\Upgrade\Manager as Upgrade_Manager;
7 6 use Elementor\Core\Utils\Collection;
8 7 use Elementor\Modules\System_Info\Module as System_Info;
9 8 use Elementor\Plugin;
@@ -11,9 +10,9 @@
11 10 use Elementor\Tracker;
12 11 use Elementor\Utils;
13 12
14 13 if ( ! defined( 'ABSPATH' ) ) {
15 - exit; // Exit if accessed directly.
14 + exit; // Exit if accessed directly
16 15 }
17 16
18 17 class Manager extends Base_Object {
19 18
@@ -22,8 +21,10 @@
22 21 const RELEASE_STATUS_ALPHA = 'alpha';
23 22
24 23 const RELEASE_STATUS_BETA = 'beta';
25 24
25 + const RELEASE_STATUS_RC = 'rc';
26 +
26 27 const RELEASE_STATUS_STABLE = 'stable';
27 28
28 29 const STATE_DEFAULT = 'default';
29 30
@@ -32,10 +33,8 @@
32 33 const STATE_INACTIVE = 'inactive';
33 34
34 35 const TYPE_HIDDEN = 'hidden';
35 36
36 - const OPTION_PREFIX = 'elementor_experiment-';
37 -
38 37 private $states;
39 38
40 39 private $release_statuses;
41 40
@@ -43,26 +42,23 @@
43 42
44 43 /**
45 44 * Add Feature
46 45 *
47 - * Each feature has to provide the following information:
48 - * [
49 - * 'name' => string,
50 - * 'title' => string,
51 - * 'description' => string,
52 - * 'tag' => string,
53 - * 'release_status' => string,
54 - * 'default' => string,
55 - * 'new_site' => array,
56 - * ]
57 - *
58 46 * @since 3.1.0
59 47 * @access public
60 48 *
61 - * @param array $options Feature options.
49 + * @param array $options {
50 + * @type string $name
51 + * @type string $title
52 + * @type string $tag
53 + * @type string $description
54 + * @type string $release_status
55 + * @type string $default
56 + * @type callable $on_state_change
57 + * }
58 + *
62 59 * @return array|null
63 - *
64 - * @throws Dependency_Exception If can't change feature state.
60 + * @throws \Exception
65 61 */
66 62 public function add_feature( array $options ) {
67 63 if ( isset( $this->features[ $options['name'] ] ) ) {
68 64 return null;
@@ -67,14 +63,41 @@
67 63 if ( isset( $this->features[ $options['name'] ] ) ) {
68 64 return null;
69 65 }
70 66
71 - $experimental_data = $this->set_feature_initial_options( $options );
67 + $default_experimental_data = [
68 + 'tag' => '',
69 + 'description' => '',
70 + 'release_status' => self::RELEASE_STATUS_ALPHA,
71 + 'default' => self::STATE_INACTIVE,
72 + 'mutable' => true,
73 + static::TYPE_HIDDEN => false,
74 + 'new_site' => [
75 + 'default_active' => false,
76 + 'always_active' => false,
77 + 'minimum_installation_version' => null,
78 + ],
79 + 'on_state_change' => null,
80 + ];
72 81
82 + $allowed_options = [ 'name', 'title', 'tag', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies' ];
83 +
84 + $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options );
85 +
73 86 $new_site = $experimental_data['new_site'];
74 87
75 - if ( $new_site['default_active'] || $new_site['always_active'] || $new_site['default_inactive'] ) {
76 - $experimental_data = $this->set_new_site_default_state( $new_site, $experimental_data );
88 + if ( $new_site['default_active'] || $new_site['always_active'] ) {
89 + $is_new_installation = Upgrade_Manager::install_compare( $new_site['minimum_installation_version'], '>=' );
90 +
91 + if ( $is_new_installation ) {
92 + if ( $new_site['always_active'] ) {
93 + $experimental_data['state'] = self::STATE_ACTIVE;
94 +
95 + $experimental_data['mutable'] = false;
96 + } elseif ( $new_site['default_active'] ) {
97 + $experimental_data['default'] = self::STATE_ACTIVE;
98 + }
99 + }
77 100 }
78 101
79 102 if ( $experimental_data['mutable'] ) {
80 103 $experimental_data['state'] = $this->get_saved_feature_state( $options['name'] );
@@ -84,9 +107,21 @@
84 107 $experimental_data['state'] = self::STATE_DEFAULT;
85 108 }
86 109
87 110 if ( ! empty( $experimental_data['dependencies'] ) ) {
88 - $experimental_data = $this->initialize_feature_dependencies( $experimental_data );
111 + foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
112 + $feature = $this->get_features( $dependency );
113 +
114 + if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
115 + throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' );
116 + }
117 +
118 + if ( ! class_exists( $dependency ) && ! empty( $feature ) ) {
119 + $experimental_data['dependencies'][ $key ] = new Wrap_Core_Dependency( $feature );
120 + } else {
121 + $experimental_data['dependencies'][ $key ] = $dependency::instance();
122 + }
123 + }
89 124 }
90 125
91 126 $this->features[ $options['name'] ] = $experimental_data;
92 127
@@ -99,9 +134,9 @@
99 134 } catch ( Exceptions\Dependency_Exception $e ) {
100 135 $message = sprintf(
101 136 '<p>%s</p><p><a href="#" onclick="location.href=\'%s\'">%s</a></p>',
102 137 esc_html( $e->getMessage() ),
103 - Settings::get_settings_tab_url( 'experiments' ),
138 + site_url( 'wp-admin/admin.php?page=elementor#tab-experiments' ),
104 139 esc_html__( 'Back', 'elementor' )
105 140 );
106 141
107 142 wp_die( $message ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
@@ -116,98 +151,9 @@
116 151
117 152 return $experimental_data;
118 153 }
119 154
120 - private function install_compare( $version ) {
121 - $installs_history = Upgrade_Manager::get_installs_history();
122 -
123 - if ( empty( $installs_history ) ) {
124 - // Fresh installation: upgrade manager hasn't written history yet on this first request.
125 - // Use the current plugin version as the effective first-install version.
126 - return version_compare( ELEMENTOR_VERSION, $version, '>=' );
127 - }
128 -
129 - $cleaned_version = preg_replace( '/-(beta|cloud|dev)\d*$/', '', key( $installs_history ) );
130 -
131 - return version_compare(
132 - $cleaned_version,
133 - $version,
134 - '>='
135 - );
136 - }
137 -
138 155 /**
139 - * Combine 'tag' and 'tags' into one property.
140 - *
141 - * @param array $experimental_data
142 - *
143 - * @return array
144 - */
145 - private function unify_feature_tags( array $experimental_data ): array {
146 - foreach ( [ 'tag', 'tags' ] as $key ) {
147 - if ( empty( $experimental_data[ $key ] ) ) {
148 - continue;
149 - }
150 -
151 - $experimental_data[ $key ] = $this->format_feature_tags( $experimental_data[ $key ] );
152 - }
153 -
154 - if ( is_array( $experimental_data['tag'] ) ) {
155 - $experimental_data['tags'] = array_merge( $experimental_data['tag'], $experimental_data['tags'] );
156 - }
157 -
158 - return $experimental_data;
159 - }
160 -
161 - /**
162 - * Format feature tags into the right format.
163 - *
164 - * If an array of tags provided, each tag has to provide the following information:
165 - * [
166 - * [
167 - * 'type' => string,
168 - * 'label' => string,
169 - * ]
170 - * ]
171 - *
172 - * @param string|array $tags A string of comma separated tags, or an array of tags.
173 - *
174 - * @return array
175 - */
176 - private function format_feature_tags( $tags ): array {
177 - if ( ! is_string( $tags ) && ! is_array( $tags ) ) {
178 - return [];
179 - }
180 -
181 - $default_tag = [
182 - 'type' => 'default',
183 - 'label' => '',
184 - ];
185 -
186 - $allowed_tag_properties = [ 'type', 'label' ];
187 -
188 - // If $tags is string, explode by commas and convert to array.
189 - if ( is_string( $tags ) ) {
190 - $tags = array_filter( explode( ',', $tags ) );
191 -
192 - foreach ( $tags as $i => $tag ) {
193 - $tags[ $i ] = [ 'label' => trim( $tag ) ];
194 - }
195 - }
196 -
197 - foreach ( $tags as $i => $tag ) {
198 - if ( empty( $tag['label'] ) ) {
199 - unset( $tags[ $i ] );
200 - continue;
201 - }
202 -
203 - $tags[ $i ] = $this->merge_properties( $default_tag, $tag, $allowed_tag_properties );
204 - }
205 -
206 - return $tags;
207 - }
208 -
209 - /**
210 156 * Remove Feature
211 157 *
212 158 * @since 3.1.0
213 159 * @access public
@@ -223,9 +169,9 @@
223 169 *
224 170 * @since 3.1.0
225 171 * @access public
226 172 *
227 - * @param string $feature_name Optional. Default is null.
173 + * @param string $feature_name Optional. Default is null
228 174 *
229 175 * @return array|null
230 176 */
231 177 public function get_features( $feature_name = null ) {
@@ -253,27 +199,16 @@
253 199 * @param string $feature_name
254 200 *
255 201 * @return bool
256 202 */
257 - public function is_feature_active( $feature_name, $check_dependencies = false ) {
203 + public function is_feature_active( $feature_name ) {
258 204 $feature = $this->get_features( $feature_name );
259 205
260 - if ( ! $feature || self::STATE_ACTIVE !== $this->get_feature_actual_state( $feature ) ) {
206 + if ( ! $feature ) {
261 207 return false;
262 208 }
263 209
264 - if ( $check_dependencies && isset( $feature['dependencies'] ) && is_array( $feature['dependencies'] ) ) {
265 - foreach ( $feature['dependencies'] as $dependency ) {
266 - $dependent_feature = $this->get_features( $dependency->get_name() );
267 - $feature_state = self::STATE_ACTIVE === $this->get_feature_actual_state( $dependent_feature );
268 -
269 - if ( ! $feature_state ) {
270 - return false;
271 - }
272 - }
273 - }
274 -
275 - return true;
210 + return self::STATE_ACTIVE === $this->get_feature_actual_state( $feature );
276 211 }
277 212
278 213 /**
279 214 * Set Feature Default State
@@ -304,89 +239,134 @@
304 239 *
305 240 * @return string
306 241 */
307 242 public function get_feature_option_key( $feature_name ) {
308 - return static::OPTION_PREFIX . $feature_name;
243 + return 'elementor_experiment-' . $feature_name;
309 244 }
310 245
311 246 private function add_default_features() {
312 247 $this->add_feature( [
248 + 'name' => 'e_dom_optimization',
249 + 'title' => esc_html__( 'Optimized DOM Output', 'elementor' ),
250 + 'tag' => esc_html__( 'Performance', 'elementor' ),
251 + 'description' => esc_html__( 'Developers, Please Note! This experiment includes some markup changes. If you\'ve used custom code in Elementor, you might have experienced a snippet of code not running. Turning this experiment off allows you to keep prior Elementor markup output settings, and have that lovely code running again.', 'elementor' )
252 + . ' <a href="https://go.elementor.com/wp-dash-legacy-optimized-dom/" target="_blank">'
253 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
254 + 'release_status' => self::RELEASE_STATUS_STABLE,
255 + 'new_site' => [
256 + 'default_active' => true,
257 + 'minimum_installation_version' => '3.1.0-beta',
258 + ],
259 + ] );
260 +
261 + $this->add_feature( [
262 + 'name' => 'e_optimized_assets_loading',
263 + 'title' => esc_html__( 'Improved Asset Loading', 'elementor' ),
264 + 'tag' => esc_html__( 'Performance', 'elementor' ),
265 + 'description' => esc_html__( 'Please Note! The "Improved Asset Loading" mode reduces the amount of code that is loaded on the page by default. When activated, parts of the infrastructure code will be loaded dynamically, only when needed. Keep in mind that activating this experiment may cause conflicts with incompatible plugins.', 'elementor' )
266 + . ' <a href="https://go.elementor.com/wp-dash-improved-asset-loading/" target="_blank">'
267 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
268 + 'release_status' => self::RELEASE_STATUS_STABLE,
269 + 'new_site' => [
270 + 'default_active' => true,
271 + 'minimum_installation_version' => '3.2.0-beta',
272 + ],
273 + ] );
274 +
275 + $this->add_feature( [
276 + 'name' => 'e_optimized_css_loading',
277 + 'title' => esc_html__( 'Improved CSS Loading', 'elementor' ),
278 + 'tag' => esc_html__( 'Performance', 'elementor' ),
279 + 'description' => esc_html__( 'Please Note! The “Improved CSS Loading” mode reduces the amount of CSS code that is loaded on the page by default. When activated, the CSS code will be loaded, rather inline or in a dedicated file, only when needed. Activating this experiment may cause conflicts with incompatible plugins.', 'elementor' )
280 + . ' <a href="https://go.elementor.com/wp-dash-improved-css-loading/" target="_blank">'
281 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
282 + 'release_status' => self::RELEASE_STATUS_RC,
283 + 'new_site' => [
284 + 'default_active' => true,
285 + 'minimum_installation_version' => '3.3.0-beta',
286 + ],
287 + ] );
288 +
289 + $this->add_feature( [
313 290 'name' => 'e_font_icon_svg',
314 291 'title' => esc_html__( 'Inline Font Icons', 'elementor' ),
315 292 'tag' => esc_html__( 'Performance', 'elementor' ),
316 - 'description' => sprintf(
317 - '%1$s <a href="https://go.elementor.com/wp-dash-inline-font-awesome/" target="_blank">%2$s</a>',
318 - esc_html__( 'The “Inline Font Icons” will render the icons as inline SVG without loading the Font-Awesome and the eicons libraries and its related CSS files and fonts.', 'elementor' ),
319 - esc_html__( 'Learn more', 'elementor' )
320 - ),
293 + 'description' => esc_html__( 'The “Inline Font Icons” will render the icons as inline SVG without loading the Font-Awesome and the eicons libraries and its related CSS files and fonts.', 'elementor' )
294 + . ' <a href="https://go.elementor.com/wp-dash-inline-font-awesome/" target="_blank">'
295 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
296 + 'release_status' => self::RELEASE_STATUS_ALPHA,
297 + ] );
298 +
299 + $this->add_feature( [
300 + 'name' => 'a11y_improvements',
301 + 'title' => esc_html__( 'Accessibility Improvements', 'elementor' ),
302 + 'tag' => esc_html__( 'Performance', 'elementor' ),
303 + 'description' => esc_html__( 'An array of accessibility enhancements in Elementor pages.', 'elementor' )
304 + . '<br><strong>' . esc_html__( 'Please note!', 'elementor' ) . '</strong> ' . esc_html__( 'These enhancements may include some markup changes to existing elementor widgets', 'elementor' )
305 + . ' <a href="https://go.elementor.com/wp-dash-a11y-improvements/" target="_blank">'
306 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
321 307 'release_status' => self::RELEASE_STATUS_STABLE,
322 308 'new_site' => [
323 309 'default_active' => true,
324 - 'minimum_installation_version' => '3.17.0',
310 + 'minimum_installation_version' => '3.1.0-beta',
325 311 ],
326 - 'generator_tag' => true,
327 312 ] );
328 313
329 314 $this->add_feature( [
330 315 'name' => 'additional_custom_breakpoints',
331 316 'title' => esc_html__( 'Additional Custom Breakpoints', 'elementor' ),
332 - 'description' => sprintf(
333 - '%1$s <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">%2$s</a>',
334 - esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' ),
335 - esc_html__( 'Learn more', 'elementor' )
336 - ),
317 + 'tag' => esc_html__( 'Performance', 'elementor' ),
318 + 'description' => esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' )
319 + . ' <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">'
320 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
337 321 'release_status' => self::RELEASE_STATUS_STABLE,
338 - 'default' => self::STATE_ACTIVE,
339 - 'generator_tag' => true,
322 + 'new_site' => [
323 + 'default_active' => true,
324 + 'minimum_installation_version' => '3.4.0-beta',
325 + ],
340 326 ] );
341 327
342 328 $this->add_feature( [
343 - 'name' => 'container',
344 - 'title' => esc_html__( 'Container', 'elementor' ),
345 - 'description' => sprintf(
346 - /* translators: 1: Link opening tag, 2: Link closing tag, 3: Link opening tag, 4: Link closing tag */
347 - esc_html__( 'Create advanced layouts and responsive designs with %1$sFlexbox%2$s and %3$sGrid%4$s container elements.', 'elementor' ),
348 - '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">',
349 - '</a>',
350 - '<a target="_blank" href="https://go.elementor.com/wp-dash-grid-container/">',
351 - '</a>'
352 - ),
329 + 'name' => 'e_import_export',
330 + 'title' => esc_html__( 'Import Export Website Kit', 'elementor' ),
331 + 'tag' => esc_html__( 'Feature', 'elementor' ),
332 + 'description' => esc_html__( 'Design sites faster with a Website Kit that contains some or all components of a complete site, like templates, content & site settings.', 'elementor' )
333 + . '<br>'
334 + . esc_html__( 'You can import a kit and apply it to your site, or export the elements from this site to be used anywhere else.', 'elementor' ),
353 335 'release_status' => self::RELEASE_STATUS_STABLE,
354 - 'default' => self::STATE_INACTIVE,
336 + 'default' => self::STATE_ACTIVE,
355 337 'new_site' => [
356 338 'default_active' => true,
357 - 'minimum_installation_version' => '3.16.0',
339 + 'minimum_installation_version' => '3.2.0-beta',
358 340 ],
359 - 'messages' => [
360 - 'on_deactivate' => sprintf(
361 - '%1$s <a target="_blank" href="https://go.elementor.com/wp-dash-deactivate-container/">%2$s</a>',
362 - esc_html__( 'Container-based content will be hidden from your site and may not be recoverable in all cases.', 'elementor' ),
363 - esc_html__( 'Learn more', 'elementor' ),
364 - ),
365 - ],
366 341 ] );
367 342
368 343 $this->add_feature( [
369 - 'name' => 'e_optimized_markup',
370 - 'title' => esc_html__( 'Optimized Markup', 'elementor' ),
371 - 'tag' => esc_html__( 'Performance', 'elementor' ),
372 - 'description' => esc_html__( 'Reduce the DOM size by eliminating HTML tags in various elements and widgets. This experiment includes markup changes so it might require updating custom CSS/JS code and cause compatibility issues with third party plugins.', 'elementor' ),
344 + 'name' => 'e_hidden_wordpress_widgets',
345 + 'title' => esc_html__( 'Hide native WordPress widgets from search results', 'elementor' ),
346 + 'tag' => esc_html__( 'Improvement', 'elementor' ),
347 + 'description' => esc_html__( 'WordPress widgets will not be shown when searching in the editor panel. Instead, these widgets can be found in the “WordPress” dropdown at the bottom of the panel.', 'elementor' ),
373 348 'release_status' => self::RELEASE_STATUS_STABLE,
374 - 'default' => self::STATE_INACTIVE,
375 - 'new_site' => [
376 - 'default_active' => true,
377 - 'minimum_installation_version' => '3.30.0',
378 - ],
349 + 'default' => self::STATE_ACTIVE,
379 350 ] );
380 351
381 352 $this->add_feature( [
382 - 'name' => 'e_optimized_css_files',
383 - 'title' => esc_html__( 'Optimized CSS Files', 'elementor' ),
384 - 'tag' => esc_html__( 'Performance', 'elementor' ),
385 - 'description' => esc_html__( 'Keeps external CSS files available and consistent for sites behind page caching or a CDN.', 'elementor' ),
386 - 'release_status' => self::RELEASE_STATUS_ALPHA,
353 + 'name' => 'admin_menu_rearrangement',
354 + 'mutable' => false,
355 + ] );
356 +
357 + $this->add_feature( [
358 + 'name' => 'container',
359 + 'title' => esc_html__( 'Flexbox Container', 'elementor' ),
360 + 'tag' => esc_html__( 'Feature', 'elementor' ),
361 + 'description' => sprintf( esc_html__(
362 + 'Create advanced layouts and responsive designs with the new %1$sFlexbox Container element%2$s.
363 + This experiment replaces the current section/column structure, but you\'ll still keep your existing
364 + Sections, Inner Sections and Columns and be able to edit them. Ready to give it a try? Check out the %3$sFlexbox playground%4$s.',
365 + 'elementor'
366 + ), '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">', '</a>', '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container-playground/">', '</a>'),
367 + 'release_status' => self::RELEASE_STATUS_BETA,
387 368 'default' => self::STATE_INACTIVE,
388 - 'generator_tag' => true,
389 369 ] );
390 370 }
391 371
392 372 /**
@@ -413,8 +393,9 @@
413 393 $this->release_statuses = [
414 394 self::RELEASE_STATUS_DEV => esc_html__( 'Development', 'elementor' ),
415 395 self::RELEASE_STATUS_ALPHA => esc_html__( 'Alpha', 'elementor' ),
416 396 self::RELEASE_STATUS_BETA => esc_html__( 'Beta', 'elementor' ),
397 + self::RELEASE_STATUS_RC => esc_html__( 'Release Candidate', 'elementor' ),
417 398 self::RELEASE_STATUS_STABLE => esc_html__( 'Stable', 'elementor' ),
418 399 ];
419 400 }
420 401
@@ -438,8 +419,9 @@
438 419 * @param Settings $settings
439 420 *
440 421 * @since 3.1.0
441 422 * @access private
423 + *
442 424 */
443 425 private function register_settings_fields( Settings $settings ) {
444 426 $features = $this->get_features();
445 427
@@ -445,13 +427,9 @@
445 427
446 428 $fields = [];
447 429
448 430 foreach ( $features as $feature_name => $feature ) {
449 - $is_hidden = $feature[ static::TYPE_HIDDEN ];
450 - $is_mutable = $feature['mutable'];
451 - $should_hide_experiment = ! $is_mutable || ( $is_hidden && ! $this->should_show_hidden() ) || $this->has_non_existing_dependency( $feature );
452 -
453 - if ( $should_hide_experiment ) {
431 + if ( ! $feature['mutable'] || $feature[ static::TYPE_HIDDEN ] ) {
454 432 unset( $features[ $feature_name ] );
455 433
456 434 continue;
457 435 }
@@ -486,9 +464,9 @@
486 464 }
487 465
488 466 $settings->add_tab(
489 467 'experiments', [
490 - 'label' => esc_html__( 'Features', 'elementor' ),
468 + 'label' => esc_html__( 'Experiments', 'elementor' ),
491 469 'sections' => [
492 470 'ongoing_experiments' => [
493 471 'callback' => function() {
494 472 $this->render_settings_intro();
@@ -523,34 +501,36 @@
523 501 */
524 502 private function render_settings_intro() {
525 503 ?>
526 504 <h2>
527 - <?php echo esc_html__( 'Experiments and Features', 'elementor' ); ?>
505 + <?php echo esc_html__( 'Elementor Experiments', 'elementor' ); ?>
528 506 </h2>
529 507 <p class="e-experiment__description">
530 508 <?php
531 - printf(
532 - /* translators: %1$s Link open tag, %2$s: Link close tag. */
533 - esc_html__( 'Personalize your Elementor experience by controlling which features and experiments are active on your site. Help make Elementor better by %1$ssharing your experience and feedback with us%2$s.', 'elementor' ),
534 - '<a href="https://go.elementor.com/wp-dash-experiments-report-an-issue/" target="_blank">',
535 - '</a>'
536 - );
509 + printf(
510 + /* translators: %1$s Link open tag, %2$s: Link close tag. */
511 + esc_html__( 'Access new and experimental features from Elementor before they\'re officially released. As these features are still in development, they are likely to change, evolve or even be removed altogether. %1$sLearn More.%2$s', 'elementor' ),
512 + '<a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">',
513 + '</a>'
514 + );
537 515 ?>
538 516 </p>
539 517 <p class="e-experiment__description">
518 + <?php echo esc_html__( 'To use an experiment on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time.', 'elementor' ); ?>
519 + </p>
520 + <p class="e-experiment__description">
540 521 <?php
541 - printf(
542 - '%1$s <a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">%2$s</a>',
543 - esc_html__( 'To use an experiment or feature on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time.', 'elementor' ),
544 - esc_html__( 'Learn more', 'elementor' ),
545 - );
522 + printf(
523 + /* translators: %1$s Link open tag, %2$s: Link close tag. */
524 + esc_html__( 'Your feedback is important - %1$shelp us%2$s improve these features by sharing your thoughts and inputs.', 'elementor' ),
525 + '<a href="https://go.elementor.com/wp-dash-experiments-report-an-issue/" target="_blank">',
526 + '</a>'
527 + );
546 528 ?>
547 529 </p>
548 -
549 530 <?php if ( $this->get_features() ) { ?>
550 - <button type="button" class="button e-experiment__button" value="active"><?php echo esc_html__( 'Activate All', 'elementor' ); ?></button>
551 - <button type="button" class="button e-experiment__button" value="inactive"><?php echo esc_html__( 'Deactivate All', 'elementor' ); ?></button>
552 - <button type="button" class="button e-experiment__button" value="default"><?php echo esc_html__( 'Back to default', 'elementor' ); ?></button>
531 + <button type="button" class="button e-experiment__button" value="active">Activate All Experiments</button>
532 + <button type="button" class="button e-experiment__button" value="inactive">Deactivate All Experiments</button>
553 533 <?php } ?>
554 534 <hr>
555 535 <h2 class="e-experiment__table-title">
556 536 <?php echo esc_html__( 'Ongoing Experiments', 'elementor' ); ?>
@@ -570,9 +550,8 @@
570 550 $control_id = 'e-experiment-' . $feature['name'];
571 551 $control_name = $this->get_feature_option_key( $feature['name'] );
572 552
573 553 $status = sprintf(
574 - /* translators: %s Release status. */
575 554 esc_html__( 'Status: %s', 'elementor' ),
576 555 $this->release_statuses[ $feature['release_status'] ]
577 556 );
578 557
@@ -625,19 +604,10 @@
625 604 </div>
626 605 <?php
627 606 }
628 607
629 - private function has_non_existing_dependency( $feature ) {
630 - $non_existing_dep = ( new Collection( $feature['dependencies'] ?? [] ) )
631 - ->find( function ( $dependency ) {
632 - return $dependency instanceof Non_Existing_Dependency;
633 - } );
634 -
635 - return (bool) $non_existing_dep;
636 - }
637 -
638 608 /**
639 - * Get Feature Settings Label HTML.
609 + * Get Feature Settings Label HTML
640 610 *
641 611 * @since 3.1.0
642 612 * @access private
643 613 *
@@ -661,17 +631,11 @@
661 631 ?>
662 632 <div class="e-experiment__title">
663 633 <div class="<?php echo $indicator_classes; ?>" data-tooltip="<?php echo $indicator_tooltip; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"></div>
664 634 <label class="e-experiment__title__label" for="e-experiment-<?php echo $feature['name']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"><?php echo $feature['title']; ?></label>
665 - <?php foreach ( $feature['tags'] as $tag ) { ?>
666 - <?php
667 - $tag_classes = 'e-experiment__title__tag e-experiment__title__tag__' . $tag['type'] . ' e-editor-one';
668 - ?>
669 - <span class="<?php echo esc_attr( $tag_classes ); ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
670 - <?php } ?>
671 - <?php if ( $feature['deprecated'] ) { ?>
672 - <span class="e-experiment__title__tag e-experiment__title__tag__deprecated"><?php echo esc_html__( 'Deprecated', 'elementor' ); ?></span>
673 - <?php } ?>
635 + <?php if ( ! empty( $feature['tag'] ) ) : ?>
636 + <span class="e-experiment__title__tag"><?php echo $feature['tag']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
637 + <?php endif; ?>
674 638 </div>
675 639 <?php
676 640
677 641 return ob_get_clean();
@@ -722,9 +686,9 @@
722 686 *
723 687 * @return string
724 688 */
725 689 private function get_feature_actual_state( array $feature ) {
726 - if ( ! empty( $feature['state'] ) && self::STATE_DEFAULT !== $feature['state'] ) {
690 + if ( self::STATE_DEFAULT !== $feature['state'] ) {
727 691 return $feature['state'];
728 692 }
729 693
730 694 return $feature['default'];
@@ -735,11 +699,12 @@
735 699 *
736 700 * @since 3.1.0
737 701 * @access private
738 702 *
739 - * @param array $old_feature_data
703 + * @param array $old_feature_data
740 704 * @param string $new_state
741 - * @param string $old_state
705 + *
706 + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception
742 707 */
743 708 private function on_feature_state_change( array $old_feature_data, $new_state, $old_state ) {
744 709 $new_feature_data = $this->get_features( $old_feature_data['name'] );
745 710 $this->validate_dependency( $new_feature_data, $new_state );
@@ -751,14 +716,12 @@
751 716 Plugin::$instance->files_manager->clear_cache();
752 717 if ( $new_feature_data['on_state_change'] ) {
753 718 $new_feature_data['on_state_change']( $old_state, $new_state );
754 719 }
755 -
756 - do_action( 'elementor/experiments/feature-state-change/' . $old_feature_data['name'], $old_state, $new_state );
757 720 }
758 721
759 722 /**
760 - * @throws Exceptions\Dependency_Exception If the feature dependency is not available or not active.
723 + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception
761 724 */
762 725 private function validate_dependency( array $feature, $new_state ) {
763 726 $rollback = function ( $feature_option_key, $state ) {
764 727 remove_all_actions( 'add_option_' . $feature_option_key );
@@ -785,12 +748,11 @@
785 748 if ( ! $dependency_feature ) {
786 749 $rollback( $feature_option_key, self::STATE_INACTIVE );
787 750
788 751 throw new Exceptions\Dependency_Exception(
789 - sprintf(
790 - 'The feature `%s` has a dependency `%s` that is not available.',
791 - esc_html( $feature['name'] ),
792 - esc_html( $dependency->get_name() )
752 + sprintf( 'The feature `%s` has a dependency `%s` that is not available.',
753 + $feature['name'],
754 + $dependency->get_name()
793 755 )
794 756 );
795 757 }
796 758
@@ -799,13 +761,14 @@
799 761 // If dependency is not active.
800 762 if ( self::STATE_INACTIVE === $dependency_state ) {
801 763 $rollback( $feature_option_key, self::STATE_INACTIVE );
802 764
765 + /* translators: 1: feature_name_that_change_state, 2: dependency_feature_name. */
803 766 throw new Exceptions\Dependency_Exception(
804 767 sprintf(
805 - 'To turn on `%1$s`, Experiment: `%2$s` activity is required!',
806 - esc_html( $feature['name'] ),
807 - esc_html( $dependency_feature['name'] )
768 + esc_html__( 'To turn on `%1$s`, Experiment: `%2$s` activity is required!', 'elementor' ),
769 + $feature['name'],
770 + $dependency_feature['name']
808 771 )
809 772 );
810 773 }
811 774 }
@@ -826,90 +789,8 @@
826 789 }
827 790 }
828 791 }
829 792
830 - private function should_show_hidden() {
831 - return defined( 'ELEMENTOR_SHOW_HIDDEN_EXPERIMENTS' ) && ELEMENTOR_SHOW_HIDDEN_EXPERIMENTS;
832 - }
833 -
834 - private function create_dependency_class( $dependency_name, $dependency_args ) {
835 - if ( class_exists( $dependency_name ) ) {
836 - return $dependency_name::instance();
837 - }
838 -
839 - if ( ! empty( $dependency_args ) ) {
840 - return new Wrap_Core_Dependency( $dependency_args );
841 - }
842 -
843 - return new Non_Existing_Dependency( $dependency_name );
844 - }
845 -
846 - /**
847 - * The experiments page is a WordPress options page, which means all the experiments are registered via WordPress' register_settings(),
848 - * and their states are being sent in the POST request when saving.
849 - * The options are being updated in a chronological order based on the POST data.
850 - * This behavior interferes with the experiments dependency mechanism because the data that's being sent can be in any order,
851 - * while the dependencies mechanism expects it to be in a specific order (dependencies should be activated before their dependents can).
852 - * In order to solve this issue, we sort the experiments in the POST data based on their dependencies tree.
853 - *
854 - * @param array $allowed_options
855 - */
856 - private function sort_allowed_options_by_dependencies( $allowed_options ) {
857 - if ( ! isset( $allowed_options['elementor'] ) ) {
858 - return $allowed_options;
859 - }
860 -
861 - $sorted = Collection::make();
862 - $visited = Collection::make();
863 -
864 - $sort = function ( $item ) use ( &$sort, $sorted, $visited ) {
865 - if ( $visited->contains( $item ) ) {
866 - return;
867 - }
868 -
869 - $visited->push( $item );
870 -
871 - $feature = $this->get_features( $item );
872 -
873 - if ( ! $feature ) {
874 - return;
875 - }
876 -
877 - foreach ( $feature['dependencies'] ?? [] as $dep ) {
878 - $name = is_string( $dep ) ? $dep : $dep->get_name();
879 -
880 - $sort( $name );
881 - }
882 -
883 - $sorted->push( $item );
884 - };
885 -
886 - foreach ( $allowed_options['elementor'] as $option ) {
887 - $is_experiment_option = strpos( $option, static::OPTION_PREFIX ) === 0;
888 -
889 - if ( ! $is_experiment_option ) {
890 - continue;
891 - }
892 -
893 - $sort(
894 - str_replace( static::OPTION_PREFIX, '', $option )
895 - );
896 - }
897 -
898 - $allowed_options['elementor'] = Collection::make( $allowed_options['elementor'] )
899 - ->filter( function ( $option ) {
900 - return 0 !== strpos( $option, static::OPTION_PREFIX );
901 - } )
902 - ->merge(
903 - $sorted->map( function ( $item ) {
904 - return static::OPTION_PREFIX . $item;
905 - } )
906 - )
907 - ->values();
908 -
909 - return $allowed_options;
910 - }
911 -
912 793 public function __construct() {
913 794 $this->init_states();
914 795
915 796 $this->init_release_statuses();
@@ -930,12 +811,8 @@
930 811
931 812 add_action( "elementor/admin/after_create_settings/{$page_id}", function( Settings $settings ) {
932 813 $this->register_settings_fields( $settings );
933 814 }, 11 );
934 -
935 - add_filter( 'allowed_options', function ( $allowed_options ) {
936 - return $this->sort_allowed_options_by_dependencies( $allowed_options );
937 - }, 11 );
938 815 }
939 816
940 817 // Register CLI commands.
941 818 if ( Utils::is_wp_cli() ) {
@@ -940,114 +817,6 @@
940 817 // Register CLI commands.
941 818 if ( Utils::is_wp_cli() ) {
942 819 \WP_CLI::add_command( 'elementor experiments', WP_CLI::class );
943 820 }
944 - }
945 -
946 - /**
947 - * @param array $experimental_data
948 - * @return array
949 - *
950 - * @throws Exceptions\Dependency_Exception If the feature dependency is not initialized or depends on a hidden experiment.
951 - */
952 - private function initialize_feature_dependencies( array $experimental_data ): array {
953 - foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
954 - $feature = $this->get_features( $dependency );
955 -
956 - if ( ! isset( $feature ) ) {
957 - // since we must validate the state of each dependency, we have to make sure that dependencies are initialized in the correct order, otherwise, error.
958 - throw new Exceptions\Dependency_Exception(
959 - sprintf(
960 - 'Feature %s cannot be initialized before dependency feature: %s.',
961 - esc_html( $experimental_data['name'] ),
962 - esc_html( $dependency )
963 - )
964 - );
965 - }
966 -
967 - if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
968 - throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' );
969 - }
970 -
971 - $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature );
972 - $experimental_data = $this->set_feature_default_state_to_match_dependencies( $feature, $experimental_data );
973 - }
974 -
975 - return $experimental_data;
976 - }
977 -
978 - /**
979 - * @param array $feature
980 - * @param array $experimental_data
981 - * @return array
982 - *
983 - * we must validate the state:
984 - * * A user can set a dependant feature to inactive and in upgrade we don't change users settings.
985 - * * A developer can set the default state to be invalid (e.g. dependant feature is inactive).
986 - * if one of the dependencies is inactive, the main feature should be inactive as well.
987 - */
988 - private function set_feature_default_state_to_match_dependencies( array $feature, array $experimental_data ): array {
989 - if ( self::STATE_INACTIVE !== $this->get_feature_actual_state( $feature ) ) {
990 - return $experimental_data;
991 - }
992 -
993 - if ( self::STATE_ACTIVE === $experimental_data['state'] ) {
994 - $experimental_data['state'] = self::STATE_INACTIVE;
995 - } elseif ( self::STATE_DEFAULT === $experimental_data['state'] ) {
996 - $experimental_data['default'] = self::STATE_INACTIVE;
997 - }
998 -
999 - return $experimental_data;
1000 - }
1001 -
1002 - /**
1003 - * @param array $new_site
1004 - * @param array $experimental_data
1005 - * @return array
1006 - */
1007 - private function set_new_site_default_state( $new_site, array $experimental_data ): array {
1008 - if ( ! $this->install_compare( $new_site['minimum_installation_version'] ) ) {
1009 - return $experimental_data;
1010 - }
1011 -
1012 - if ( $new_site['always_active'] ) {
1013 - $experimental_data['state'] = self::STATE_ACTIVE;
1014 - $experimental_data['mutable'] = false;
1015 - } elseif ( $new_site['default_active'] ) {
1016 - $experimental_data['default'] = self::STATE_ACTIVE;
1017 - } elseif ( $new_site['default_inactive'] ) {
1018 - $experimental_data['default'] = self::STATE_INACTIVE;
1019 - }
1020 -
1021 - return $experimental_data;
1022 - }
1023 -
1024 - /**
1025 - * @param array $options
1026 - * @return array
1027 - */
1028 - private function set_feature_initial_options( array $options ): array {
1029 - $default_experimental_data = [
1030 - 'tag' => '', // Deprecated, use 'tags' instead.
1031 - 'tags' => [],
1032 - 'description' => '',
1033 - 'release_status' => self::RELEASE_STATUS_ALPHA,
1034 - 'default' => self::STATE_INACTIVE,
1035 - 'mutable' => true,
1036 - static::TYPE_HIDDEN => false,
1037 - 'new_site' => [
1038 - 'always_active' => false,
1039 - 'default_active' => false,
1040 - 'default_inactive' => false,
1041 - 'minimum_installation_version' => null,
1042 - ],
1043 - 'on_state_change' => null,
1044 - 'generator_tag' => false,
1045 - 'deprecated' => false,
1046 - ];
1047 -
1048 - $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages', 'deprecated' ];
1049 - $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options );
1050 -
1051 - return $this->unify_feature_tags( $experimental_data );
1052 821 }
1053 822 }