PluginProbe
Elementor Website Builder – more than just a page builder / 3.13.0-beta1
Elementor Website Builder – more than just a page builder v3.13.0-beta1
4.3.4 4.3.3 4.3.2 4.3.1 4.3.0 4.3.0-beta3 4.3.0-beta2 4.3.0-beta1 4.2.4 4.2.3 4.2.2 4.2.1 4.2.0 4.1.5 4.2.0-beta2 4.2.0-dev2 4.2.0-beta1 4.1.4 4.1.3 4.1.2 4.1.1 4.1.0 4.1.0-beta3 4.1.0-dev3 4.0.9 All 457 releases
← All changes | core/experiments/manager.php +187 -314 4.1.4 → 3.13.0-beta1 View file →
@@ -1,9 +1,8 @@
1 1 <?php
2 2 namespace Elementor\Core\Experiments;
3 3
4 4 use Elementor\Core\Base\Base_Object;
5 -use Elementor\Core\Experiments\Exceptions\Dependency_Exception;
6 5 use Elementor\Core\Upgrade\Manager as Upgrade_Manager;
7 6 use Elementor\Core\Utils\Collection;
8 7 use Elementor\Modules\System_Info\Module as System_Info;
9 8 use Elementor\Plugin;
@@ -11,9 +10,9 @@
11 10 use Elementor\Tracker;
12 11 use Elementor\Utils;
13 12
14 13 if ( ! defined( 'ABSPATH' ) ) {
15 - exit; // Exit if accessed directly.
14 + exit; // Exit if accessed directly
16 15 }
17 16
18 17 class Manager extends Base_Object {
19 18
@@ -22,8 +21,10 @@
22 21 const RELEASE_STATUS_ALPHA = 'alpha';
23 22
24 23 const RELEASE_STATUS_BETA = 'beta';
25 24
25 + const RELEASE_STATUS_RC = 'rc';
26 +
26 27 const RELEASE_STATUS_STABLE = 'stable';
27 28
28 29 const STATE_DEFAULT = 'default';
29 30
@@ -32,10 +33,8 @@
32 33 const STATE_INACTIVE = 'inactive';
33 34
34 35 const TYPE_HIDDEN = 'hidden';
35 36
36 - const OPTION_PREFIX = 'elementor_experiment-';
37 -
38 37 private $states;
39 38
40 39 private $release_statuses;
41 40
@@ -43,26 +42,24 @@
43 42
44 43 /**
45 44 * Add Feature
46 45 *
47 - * Each feature has to provide the following information:
48 - * [
49 - * 'name' => string,
50 - * 'title' => string,
51 - * 'description' => string,
52 - * 'tag' => string,
53 - * 'release_status' => string,
54 - * 'default' => string,
55 - * 'new_site' => array,
56 - * ]
57 - *
58 46 * @since 3.1.0
59 47 * @access public
60 48 *
61 - * @param array $options Feature options.
49 + * @param array $options {
50 + * @type string $name
51 + * @type string $title
52 + * @type string $tag
53 + * @type array $tags
54 + * @type string $description
55 + * @type string $release_status
56 + * @type string $default
57 + * @type callable $on_state_change
58 + * }
59 + *
62 60 * @return array|null
63 - *
64 - * @throws Dependency_Exception If can't change feature state.
61 + * @throws \Exception
65 62 */
66 63 public function add_feature( array $options ) {
67 64 if ( isset( $this->features[ $options['name'] ] ) ) {
68 65 return null;
@@ -67,14 +64,45 @@
67 64 if ( isset( $this->features[ $options['name'] ] ) ) {
68 65 return null;
69 66 }
70 67
71 - $experimental_data = $this->set_feature_initial_options( $options );
68 + $default_experimental_data = [
69 + 'tag' => '', // Deprecated, use 'tags' instead.
70 + 'tags' => [],
71 + 'description' => '',
72 + 'release_status' => self::RELEASE_STATUS_ALPHA,
73 + 'default' => self::STATE_INACTIVE,
74 + 'mutable' => true,
75 + static::TYPE_HIDDEN => false,
76 + 'new_site' => [
77 + 'default_active' => false,
78 + 'always_active' => false,
79 + 'minimum_installation_version' => null,
80 + ],
81 + 'on_state_change' => null,
82 + 'generator_tag' => false,
83 + ];
72 84
85 + $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages' ];
86 +
87 + $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options );
88 +
89 + $experimental_data = $this->unify_feature_tags( $experimental_data );
90 +
73 91 $new_site = $experimental_data['new_site'];
74 92
75 - if ( $new_site['default_active'] || $new_site['always_active'] || $new_site['default_inactive'] ) {
76 - $experimental_data = $this->set_new_site_default_state( $new_site, $experimental_data );
93 + if ( $new_site['default_active'] || $new_site['always_active'] ) {
94 + $is_new_installation = Upgrade_Manager::install_compare( $new_site['minimum_installation_version'], '>=' );
95 +
96 + if ( $is_new_installation ) {
97 + if ( $new_site['always_active'] ) {
98 + $experimental_data['state'] = self::STATE_ACTIVE;
99 +
100 + $experimental_data['mutable'] = false;
101 + } elseif ( $new_site['default_active'] ) {
102 + $experimental_data['default'] = self::STATE_ACTIVE;
103 + }
104 + }
77 105 }
78 106
79 107 if ( $experimental_data['mutable'] ) {
80 108 $experimental_data['state'] = $this->get_saved_feature_state( $options['name'] );
@@ -84,9 +112,17 @@
84 112 $experimental_data['state'] = self::STATE_DEFAULT;
85 113 }
86 114
87 115 if ( ! empty( $experimental_data['dependencies'] ) ) {
88 - $experimental_data = $this->initialize_feature_dependencies( $experimental_data );
116 + foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
117 + $feature = $this->get_features( $dependency );
118 +
119 + if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
120 + throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' );
121 + }
122 +
123 + $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature );
124 + }
89 125 }
90 126
91 127 $this->features[ $options['name'] ] = $experimental_data;
92 128
@@ -99,9 +135,9 @@
99 135 } catch ( Exceptions\Dependency_Exception $e ) {
100 136 $message = sprintf(
101 137 '<p>%s</p><p><a href="#" onclick="location.href=\'%s\'">%s</a></p>',
102 138 esc_html( $e->getMessage() ),
103 - Settings::get_settings_tab_url( 'experiments' ),
139 + site_url( 'wp-admin/admin.php?page=elementor#tab-experiments' ),
104 140 esc_html__( 'Back', 'elementor' )
105 141 );
106 142
107 143 wp_die( $message ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
@@ -116,26 +152,8 @@
116 152
117 153 return $experimental_data;
118 154 }
119 155
120 - private function install_compare( $version ) {
121 - $installs_history = Upgrade_Manager::get_installs_history();
122 -
123 - if ( empty( $installs_history ) ) {
124 - // Fresh installation: upgrade manager hasn't written history yet on this first request.
125 - // Use the current plugin version as the effective first-install version.
126 - return version_compare( ELEMENTOR_VERSION, $version, '>=' );
127 - }
128 -
129 - $cleaned_version = preg_replace( '/-(beta|cloud|dev)\d*$/', '', key( $installs_history ) );
130 -
131 - return version_compare(
132 - $cleaned_version,
133 - $version,
134 - '>='
135 - );
136 - }
137 -
138 156 /**
139 157 * Combine 'tag' and 'tags' into one property.
140 158 *
141 159 * @param array $experimental_data
@@ -141,9 +159,9 @@
141 159 * @param array $experimental_data
142 160 *
143 161 * @return array
144 162 */
145 - private function unify_feature_tags( array $experimental_data ): array {
163 + private function unify_feature_tags( array $experimental_data ) : array {
146 164 foreach ( [ 'tag', 'tags' ] as $key ) {
147 165 if ( empty( $experimental_data[ $key ] ) ) {
148 166 continue;
149 167 }
@@ -160,21 +178,18 @@
160 178
161 179 /**
162 180 * Format feature tags into the right format.
163 181 *
164 - * If an array of tags provided, each tag has to provide the following information:
165 - * [
166 - * [
167 - * 'type' => string,
168 - * 'label' => string,
169 - * ]
170 - * ]
182 + * @param string|array[
183 + * [
184 + * 'type' => string,
185 + * 'label' => string
186 + * ]
187 + * ] $tag
171 188 *
172 - * @param string|array $tags A string of comma separated tags, or an array of tags.
173 - *
174 189 * @return array
175 190 */
176 - private function format_feature_tags( $tags ): array {
191 + private function format_feature_tags( $tags ) : array {
177 192 if ( ! is_string( $tags ) && ! is_array( $tags ) ) {
178 193 return [];
179 194 }
180 195
@@ -223,9 +238,9 @@
223 238 *
224 239 * @since 3.1.0
225 240 * @access public
226 241 *
227 - * @param string $feature_name Optional. Default is null.
242 + * @param string $feature_name Optional. Default is null
228 243 *
229 244 * @return array|null
230 245 */
231 246 public function get_features( $feature_name = null ) {
@@ -253,27 +268,16 @@
253 268 * @param string $feature_name
254 269 *
255 270 * @return bool
256 271 */
257 - public function is_feature_active( $feature_name, $check_dependencies = false ) {
272 + public function is_feature_active( $feature_name ) {
258 273 $feature = $this->get_features( $feature_name );
259 274
260 - if ( ! $feature || self::STATE_ACTIVE !== $this->get_feature_actual_state( $feature ) ) {
275 + if ( ! $feature ) {
261 276 return false;
262 277 }
263 278
264 - if ( $check_dependencies && isset( $feature['dependencies'] ) && is_array( $feature['dependencies'] ) ) {
265 - foreach ( $feature['dependencies'] as $dependency ) {
266 - $dependent_feature = $this->get_features( $dependency->get_name() );
267 - $feature_state = self::STATE_ACTIVE === $this->get_feature_actual_state( $dependent_feature );
268 -
269 - if ( ! $feature_state ) {
270 - return false;
271 - }
272 - }
273 - }
274 -
275 - return true;
279 + return self::STATE_ACTIVE === $this->get_feature_actual_state( $feature );
276 280 }
277 281
278 282 /**
279 283 * Set Feature Default State
@@ -304,37 +308,88 @@
304 308 *
305 309 * @return string
306 310 */
307 311 public function get_feature_option_key( $feature_name ) {
308 - return static::OPTION_PREFIX . $feature_name;
312 + return 'elementor_experiment-' . $feature_name;
309 313 }
310 314
311 315 private function add_default_features() {
312 316 $this->add_feature( [
313 - 'name' => 'e_font_icon_svg',
314 - 'title' => esc_html__( 'Inline Font Icons', 'elementor' ),
317 + 'name' => 'e_dom_optimization',
318 + 'title' => esc_html__( 'Optimized DOM Output', 'elementor' ),
315 319 'tag' => esc_html__( 'Performance', 'elementor' ),
316 - 'description' => sprintf(
317 - '%1$s <a href="https://go.elementor.com/wp-dash-inline-font-awesome/" target="_blank">%2$s</a>',
318 - esc_html__( 'The “Inline Font Icons” will render the icons as inline SVG without loading the Font-Awesome and the eicons libraries and its related CSS files and fonts.', 'elementor' ),
319 - esc_html__( 'Learn more', 'elementor' )
320 - ),
320 + 'description' => esc_html__( 'Developers, Please Note! This experiment includes some markup changes. If you\'ve used custom code in Elementor, you might have experienced a snippet of code not running. Turning this experiment off allows you to keep prior Elementor markup output settings, and have that lovely code running again.', 'elementor' )
321 + . ' <a href="https://go.elementor.com/wp-dash-legacy-optimized-dom/" target="_blank">'
322 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
321 323 'release_status' => self::RELEASE_STATUS_STABLE,
322 324 'new_site' => [
323 325 'default_active' => true,
324 - 'minimum_installation_version' => '3.17.0',
326 + 'minimum_installation_version' => '3.1.0-beta',
325 327 ],
326 328 'generator_tag' => true,
327 329 ] );
328 330
329 331 $this->add_feature( [
332 + 'name' => 'e_optimized_assets_loading',
333 + 'title' => esc_html__( 'Improved Asset Loading', 'elementor' ),
334 + 'tag' => esc_html__( 'Performance', 'elementor' ),
335 + 'description' => esc_html__( 'Please Note! The "Improved Asset Loading" mode reduces the amount of code that is loaded on the page by default. When activated, parts of the infrastructure code will be loaded dynamically, only when needed. Keep in mind that activating this experiment may cause conflicts with incompatible plugins.', 'elementor' )
336 + . ' <a href="https://go.elementor.com/wp-dash-improved-asset-loading/" target="_blank">'
337 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
338 + 'release_status' => self::RELEASE_STATUS_STABLE,
339 + 'new_site' => [
340 + 'default_active' => true,
341 + 'minimum_installation_version' => '3.2.0-beta',
342 + ],
343 + 'generator_tag' => true,
344 + ] );
345 +
346 + $this->add_feature( [
347 + 'name' => 'e_optimized_css_loading',
348 + 'title' => esc_html__( 'Improved CSS Loading', 'elementor' ),
349 + 'tag' => esc_html__( 'Performance', 'elementor' ),
350 + 'description' => esc_html__( 'Please Note! The “Improved CSS Loading” mode reduces the amount of CSS code that is loaded on the page by default. When activated, the CSS code will be loaded, rather inline or in a dedicated file, only when needed. Activating this experiment may cause conflicts with incompatible plugins.', 'elementor' )
351 + . ' <a href="https://go.elementor.com/wp-dash-improved-css-loading/" target="_blank">'
352 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
353 + 'release_status' => self::RELEASE_STATUS_STABLE,
354 + 'new_site' => [
355 + 'default_active' => true,
356 + 'minimum_installation_version' => '3.3.0-beta',
357 + ],
358 + 'generator_tag' => true,
359 + ] );
360 +
361 + $this->add_feature( [
362 + 'name' => 'e_font_icon_svg',
363 + 'title' => esc_html__( 'Inline Font Icons', 'elementor' ),
364 + 'tag' => esc_html__( 'Performance', 'elementor' ),
365 + 'description' => esc_html__( 'The “Inline Font Icons” will render the icons as inline SVG without loading the Font-Awesome and the eicons libraries and its related CSS files and fonts.', 'elementor' )
366 + . ' <a href="https://go.elementor.com/wp-dash-inline-font-awesome/" target="_blank">'
367 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
368 + 'release_status' => self::RELEASE_STATUS_BETA,
369 + 'generator_tag' => true,
370 + ] );
371 +
372 + $this->add_feature( [
373 + 'name' => 'a11y_improvements',
374 + 'title' => esc_html__( 'Accessibility Improvements', 'elementor' ),
375 + 'tag' => esc_html__( 'Performance', 'elementor' ),
376 + 'description' => esc_html__( 'An array of accessibility enhancements in Elementor pages.', 'elementor' )
377 + . '<br><strong>' . esc_html__( 'Please note!', 'elementor' ) . '</strong> ' . esc_html__( 'These enhancements may include some markup changes to existing elementor widgets', 'elementor' )
378 + . ' <a href="https://go.elementor.com/wp-dash-a11y-improvements/" target="_blank">'
379 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
380 + 'release_status' => self::RELEASE_STATUS_STABLE,
381 + 'default' => self::STATE_ACTIVE,
382 + 'generator_tag' => true,
383 + ] );
384 +
385 + $this->add_feature( [
330 386 'name' => 'additional_custom_breakpoints',
331 387 'title' => esc_html__( 'Additional Custom Breakpoints', 'elementor' ),
332 - 'description' => sprintf(
333 - '%1$s <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">%2$s</a>',
334 - esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' ),
335 - esc_html__( 'Learn more', 'elementor' )
336 - ),
388 + 'tag' => esc_html__( 'Performance', 'elementor' ),
389 + 'description' => esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' )
390 + . ' <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">'
391 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
337 392 'release_status' => self::RELEASE_STATUS_STABLE,
338 393 'default' => self::STATE_ACTIVE,
339 394 'generator_tag' => true,
340 395 ] );
@@ -339,55 +394,54 @@
339 394 'generator_tag' => true,
340 395 ] );
341 396
342 397 $this->add_feature( [
398 + 'name' => 'admin_menu_rearrangement',
399 + 'mutable' => false,
400 + ] );
401 +
402 + $this->add_feature( [
343 403 'name' => 'container',
344 - 'title' => esc_html__( 'Container', 'elementor' ),
345 - 'description' => sprintf(
346 - /* translators: 1: Link opening tag, 2: Link closing tag, 3: Link opening tag, 4: Link closing tag, 5: Link opening tag, 6: Link closing tag */
347 - esc_html__( 'Create advanced layouts and responsive designs with %1$sFlexbox%2$s and %3$sGrid%4$s container elements. Give it a try using the %5$sContainer playground%6$s.', 'elementor' ),
348 - '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">',
349 - '</a>',
350 - '<a target="_blank" href="https://go.elementor.com/wp-dash-grid-container/">',
351 - '</a>',
352 - '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container-playground/">',
353 - '</a>'
354 - ),
355 - 'release_status' => self::RELEASE_STATUS_STABLE,
404 + 'title' => esc_html__( 'Flexbox Container', 'elementor' ),
405 + 'description' => sprintf( esc_html__(
406 + 'Create advanced layouts and responsive designs with the new %1$sFlexbox Container element%2$s.
407 + This experiment replaces the current section/column structure, but you\'ll still keep your existing
408 + Sections, Inner Sections and Columns and be able to edit them. Ready to give it a try? Check out the %3$sFlexbox playground%4$s.',
409 + 'elementor'
410 + ), '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">', '</a>', '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container-playground/">', '</a>'),
411 + 'release_status' => self::RELEASE_STATUS_RC,
356 412 'default' => self::STATE_INACTIVE,
357 - 'new_site' => [
358 - 'default_active' => true,
359 - 'minimum_installation_version' => '3.16.0',
360 - ],
361 413 'messages' => [
362 - 'on_deactivate' => sprintf(
363 - '%1$s <a target="_blank" href="https://go.elementor.com/wp-dash-deactivate-container/">%2$s</a>',
364 - esc_html__( 'Container-based content will be hidden from your site and may not be recoverable in all cases.', 'elementor' ),
365 - esc_html__( 'Learn more', 'elementor' ),
414 + 'on_deactivate' => esc_html__(
415 + 'If you deactivate Flexbox Container, you will permanently delete all content created with containers and lose access to container-based features like Tabs and Menu widgets',
416 + 'elementor'
366 417 ),
367 418 ],
368 419 ] );
369 420
370 421 $this->add_feature( [
371 - 'name' => 'e_optimized_markup',
372 - 'title' => esc_html__( 'Optimized Markup', 'elementor' ),
373 - 'tag' => esc_html__( 'Performance', 'elementor' ),
374 - 'description' => esc_html__( 'Reduce the DOM size by eliminating HTML tags in various elements and widgets. This experiment includes markup changes so it might require updating custom CSS/JS code and cause compatibility issues with third party plugins.', 'elementor' ),
422 + 'name' => 'e_swiper_latest',
423 + 'title' => esc_html__( 'Upgrade Swiper Library', 'elementor' ),
424 + 'description' => esc_html__( 'Prepare your website for future improvements to carousel features by upgrading the Swiper library integrated into your site from v5.36 to v8.45. This experiment includes markup changes so it might require updating custom code and cause compatibility issues with third party plugins.', 'elementor' ),
375 425 'release_status' => self::RELEASE_STATUS_STABLE,
376 - 'default' => self::STATE_INACTIVE,
377 426 'new_site' => [
378 427 'default_active' => true,
379 - 'minimum_installation_version' => '3.30.0',
428 + 'minimum_installation_version' => '3.11.0',
380 429 ],
430 + 'default' => self::STATE_INACTIVE,
381 431 ] );
382 432
383 433 $this->add_feature( [
384 - 'name' => 'e_panel_promotions',
385 - 'title' => esc_html__( 'Panel Promotions', 'elementor' ),
386 - 'description' => esc_html__( 'Enable experimental rendering for targeted promotions within the elements panels.', 'elementor' ),
387 - 'release_status' => self::RELEASE_STATUS_DEV,
388 - 'default' => self::STATE_ACTIVE,
389 - 'type' => self::TYPE_HIDDEN,
434 + 'name' => 'container_grid',
435 + 'title' => esc_html__( 'Grid Container', 'elementor' ),
436 + 'tag' => esc_html__( 'Feature', 'elementor' ),
437 + 'description' => esc_html__( 'Create advanced layouts and responsive designs with the new Container Grid element.', 'elementor' ),
438 + 'release_status' => self::RELEASE_STATUS_ALPHA,
439 + 'default' => self::STATE_INACTIVE,
440 + 'hidden' => false,
441 + 'dependencies' => [
442 + 'container',
443 + ],
390 444 ] );
391 445 }
392 446
393 447 /**
@@ -414,8 +468,9 @@
414 468 $this->release_statuses = [
415 469 self::RELEASE_STATUS_DEV => esc_html__( 'Development', 'elementor' ),
416 470 self::RELEASE_STATUS_ALPHA => esc_html__( 'Alpha', 'elementor' ),
417 471 self::RELEASE_STATUS_BETA => esc_html__( 'Beta', 'elementor' ),
472 + self::RELEASE_STATUS_RC => esc_html__( 'Release Candidate', 'elementor' ),
418 473 self::RELEASE_STATUS_STABLE => esc_html__( 'Stable', 'elementor' ),
419 474 ];
420 475 }
421 476
@@ -439,8 +494,9 @@
439 494 * @param Settings $settings
440 495 *
441 496 * @since 3.1.0
442 497 * @access private
498 + *
443 499 */
444 500 private function register_settings_fields( Settings $settings ) {
445 501 $features = $this->get_features();
446 502
@@ -529,9 +585,9 @@
529 585 </h2>
530 586 <p class="e-experiment__description">
531 587 <?php
532 588 printf(
533 - /* translators: %1$s Link open tag, %2$s: Link close tag. */
589 + /* translators: %1$s Link open tag, %2$s: Link close tag. */
534 590 esc_html__( 'Personalize your Elementor experience by controlling which features and experiments are active on your site. Help make Elementor better by %1$ssharing your experience and feedback with us%2$s.', 'elementor' ),
535 591 '<a href="https://go.elementor.com/wp-dash-experiments-report-an-issue/" target="_blank">',
536 592 '</a>'
537 593 );
@@ -538,13 +594,14 @@
538 594 ?>
539 595 </p>
540 596 <p class="e-experiment__description">
541 597 <?php
542 - printf(
543 - '%1$s <a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">%2$s</a>',
544 - esc_html__( 'To use an experiment or feature on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time.', 'elementor' ),
545 - esc_html__( 'Learn more', 'elementor' ),
546 - );
598 + printf(
599 + /* translators: %1$s Link open tag, %2$s: Link close tag. */
600 + esc_html__( 'To use an experiment or feature on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time. %1$sLearn More.%2$s', 'elementor' ),
601 + '<a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">',
602 + '</a>'
603 + );
547 604 ?>
548 605 </p>
549 606
550 607 <?php if ( $this->get_features() ) { ?>
@@ -571,9 +628,8 @@
571 628 $control_id = 'e-experiment-' . $feature['name'];
572 629 $control_name = $this->get_feature_option_key( $feature['name'] );
573 630
574 631 $status = sprintf(
575 - /* translators: %s Release status. */
576 632 esc_html__( 'Status: %s', 'elementor' ),
577 633 $this->release_statuses[ $feature['release_status'] ]
578 634 );
579 635
@@ -632,13 +688,13 @@
632 688 ->find( function ( $dependency ) {
633 689 return $dependency instanceof Non_Existing_Dependency;
634 690 } );
635 691
636 - return (bool) $non_existing_dep;
692 + return ! ! $non_existing_dep;
637 693 }
638 694
639 695 /**
640 - * Get Feature Settings Label HTML.
696 + * Get Feature Settings Label HTML
641 697 *
642 698 * @since 3.1.0
643 699 * @access private
644 700 *
@@ -663,16 +719,10 @@
663 719 <div class="e-experiment__title">
664 720 <div class="<?php echo $indicator_classes; ?>" data-tooltip="<?php echo $indicator_tooltip; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"></div>
665 721 <label class="e-experiment__title__label" for="e-experiment-<?php echo $feature['name']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"><?php echo $feature['title']; ?></label>
666 722 <?php foreach ( $feature['tags'] as $tag ) { ?>
667 - <?php
668 - $tag_classes = 'e-experiment__title__tag e-experiment__title__tag__' . $tag['type'] . ' e-editor-one';
669 - ?>
670 - <span class="<?php echo esc_attr( $tag_classes ); ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
723 + <span class="e-experiment__title__tag e-experiment__title__tag__<?php echo $tag['type']; ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
671 724 <?php } ?>
672 - <?php if ( $feature['deprecated'] ) { ?>
673 - <span class="e-experiment__title__tag e-experiment__title__tag__deprecated"><?php echo esc_html__( 'Deprecated', 'elementor' ); ?></span>
674 - <?php } ?>
675 725 </div>
676 726 <?php
677 727
678 728 return ob_get_clean();
@@ -736,11 +786,12 @@
736 786 *
737 787 * @since 3.1.0
738 788 * @access private
739 789 *
740 - * @param array $old_feature_data
790 + * @param array $old_feature_data
741 791 * @param string $new_state
742 - * @param string $old_state
792 + *
793 + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception
743 794 */
744 795 private function on_feature_state_change( array $old_feature_data, $new_state, $old_state ) {
745 796 $new_feature_data = $this->get_features( $old_feature_data['name'] );
746 797 $this->validate_dependency( $new_feature_data, $new_state );
@@ -757,9 +808,9 @@
757 808 do_action( 'elementor/experiments/feature-state-change/' . $old_feature_data['name'], $old_state, $new_state );
758 809 }
759 810
760 811 /**
761 - * @throws Exceptions\Dependency_Exception If the feature dependency is not available or not active.
812 + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception
762 813 */
763 814 private function validate_dependency( array $feature, $new_state ) {
764 815 $rollback = function ( $feature_option_key, $state ) {
765 816 remove_all_actions( 'add_option_' . $feature_option_key );
@@ -788,10 +839,10 @@
788 839
789 840 throw new Exceptions\Dependency_Exception(
790 841 sprintf(
791 842 'The feature `%s` has a dependency `%s` that is not available.',
792 - esc_html( $feature['name'] ),
793 - esc_html( $dependency->get_name() )
843 + $feature['name'],
844 + $dependency->get_name()
794 845 )
795 846 );
796 847 }
797 848
@@ -803,10 +854,10 @@
803 854
804 855 throw new Exceptions\Dependency_Exception(
805 856 sprintf(
806 857 'To turn on `%1$s`, Experiment: `%2$s` activity is required!',
807 - esc_html( $feature['name'] ),
808 - esc_html( $dependency_feature['name'] )
858 + $feature['name'],
859 + $dependency_feature['name']
809 860 )
810 861 );
811 862 }
812 863 }
@@ -843,74 +894,8 @@
843 894
844 895 return new Non_Existing_Dependency( $dependency_name );
845 896 }
846 897
847 - /**
848 - * The experiments page is a WordPress options page, which means all the experiments are registered via WordPress' register_settings(),
849 - * and their states are being sent in the POST request when saving.
850 - * The options are being updated in a chronological order based on the POST data.
851 - * This behavior interferes with the experiments dependency mechanism because the data that's being sent can be in any order,
852 - * while the dependencies mechanism expects it to be in a specific order (dependencies should be activated before their dependents can).
853 - * In order to solve this issue, we sort the experiments in the POST data based on their dependencies tree.
854 - *
855 - * @param array $allowed_options
856 - */
857 - private function sort_allowed_options_by_dependencies( $allowed_options ) {
858 - if ( ! isset( $allowed_options['elementor'] ) ) {
859 - return $allowed_options;
860 - }
861 -
862 - $sorted = Collection::make();
863 - $visited = Collection::make();
864 -
865 - $sort = function ( $item ) use ( &$sort, $sorted, $visited ) {
866 - if ( $visited->contains( $item ) ) {
867 - return;
868 - }
869 -
870 - $visited->push( $item );
871 -
872 - $feature = $this->get_features( $item );
873 -
874 - if ( ! $feature ) {
875 - return;
876 - }
877 -
878 - foreach ( $feature['dependencies'] ?? [] as $dep ) {
879 - $name = is_string( $dep ) ? $dep : $dep->get_name();
880 -
881 - $sort( $name );
882 - }
883 -
884 - $sorted->push( $item );
885 - };
886 -
887 - foreach ( $allowed_options['elementor'] as $option ) {
888 - $is_experiment_option = strpos( $option, static::OPTION_PREFIX ) === 0;
889 -
890 - if ( ! $is_experiment_option ) {
891 - continue;
892 - }
893 -
894 - $sort(
895 - str_replace( static::OPTION_PREFIX, '', $option )
896 - );
897 - }
898 -
899 - $allowed_options['elementor'] = Collection::make( $allowed_options['elementor'] )
900 - ->filter( function ( $option ) {
901 - return 0 !== strpos( $option, static::OPTION_PREFIX );
902 - } )
903 - ->merge(
904 - $sorted->map( function ( $item ) {
905 - return static::OPTION_PREFIX . $item;
906 - } )
907 - )
908 - ->values();
909 -
910 - return $allowed_options;
911 - }
912 -
913 898 public function __construct() {
914 899 $this->init_states();
915 900
916 901 $this->init_release_statuses();
@@ -931,12 +916,8 @@
931 916
932 917 add_action( "elementor/admin/after_create_settings/{$page_id}", function( Settings $settings ) {
933 918 $this->register_settings_fields( $settings );
934 919 }, 11 );
935 -
936 - add_filter( 'allowed_options', function ( $allowed_options ) {
937 - return $this->sort_allowed_options_by_dependencies( $allowed_options );
938 - }, 11 );
939 920 }
940 921
941 922 // Register CLI commands.
942 923 if ( Utils::is_wp_cli() ) {
@@ -941,114 +922,6 @@
941 922 // Register CLI commands.
942 923 if ( Utils::is_wp_cli() ) {
943 924 \WP_CLI::add_command( 'elementor experiments', WP_CLI::class );
944 925 }
945 - }
946 -
947 - /**
948 - * @param array $experimental_data
949 - * @return array
950 - *
951 - * @throws Exceptions\Dependency_Exception If the feature dependency is not initialized or depends on a hidden experiment.
952 - */
953 - private function initialize_feature_dependencies( array $experimental_data ): array {
954 - foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
955 - $feature = $this->get_features( $dependency );
956 -
957 - if ( ! isset( $feature ) ) {
958 - // since we must validate the state of each dependency, we have to make sure that dependencies are initialized in the correct order, otherwise, error.
959 - throw new Exceptions\Dependency_Exception(
960 - sprintf(
961 - 'Feature %s cannot be initialized before dependency feature: %s.',
962 - esc_html( $experimental_data['name'] ),
963 - esc_html( $dependency )
964 - )
965 - );
966 - }
967 -
968 - if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
969 - throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' );
970 - }
971 -
972 - $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature );
973 - $experimental_data = $this->set_feature_default_state_to_match_dependencies( $feature, $experimental_data );
974 - }
975 -
976 - return $experimental_data;
977 - }
978 -
979 - /**
980 - * @param array $feature
981 - * @param array $experimental_data
982 - * @return array
983 - *
984 - * we must validate the state:
985 - * * A user can set a dependant feature to inactive and in upgrade we don't change users settings.
986 - * * A developer can set the default state to be invalid (e.g. dependant feature is inactive).
987 - * if one of the dependencies is inactive, the main feature should be inactive as well.
988 - */
989 - private function set_feature_default_state_to_match_dependencies( array $feature, array $experimental_data ): array {
990 - if ( self::STATE_INACTIVE !== $this->get_feature_actual_state( $feature ) ) {
991 - return $experimental_data;
992 - }
993 -
994 - if ( self::STATE_ACTIVE === $experimental_data['state'] ) {
995 - $experimental_data['state'] = self::STATE_INACTIVE;
996 - } elseif ( self::STATE_DEFAULT === $experimental_data['state'] ) {
997 - $experimental_data['default'] = self::STATE_INACTIVE;
998 - }
999 -
1000 - return $experimental_data;
1001 - }
1002 -
1003 - /**
1004 - * @param array $new_site
1005 - * @param array $experimental_data
1006 - * @return array
1007 - */
1008 - private function set_new_site_default_state( $new_site, array $experimental_data ): array {
1009 - if ( ! $this->install_compare( $new_site['minimum_installation_version'] ) ) {
1010 - return $experimental_data;
1011 - }
1012 -
1013 - if ( $new_site['always_active'] ) {
1014 - $experimental_data['state'] = self::STATE_ACTIVE;
1015 - $experimental_data['mutable'] = false;
1016 - } elseif ( $new_site['default_active'] ) {
1017 - $experimental_data['default'] = self::STATE_ACTIVE;
1018 - } elseif ( $new_site['default_inactive'] ) {
1019 - $experimental_data['default'] = self::STATE_INACTIVE;
1020 - }
1021 -
1022 - return $experimental_data;
1023 - }
1024 -
1025 - /**
1026 - * @param array $options
1027 - * @return array
1028 - */
1029 - private function set_feature_initial_options( array $options ): array {
1030 - $default_experimental_data = [
1031 - 'tag' => '', // Deprecated, use 'tags' instead.
1032 - 'tags' => [],
1033 - 'description' => '',
1034 - 'release_status' => self::RELEASE_STATUS_ALPHA,
1035 - 'default' => self::STATE_INACTIVE,
1036 - 'mutable' => true,
1037 - static::TYPE_HIDDEN => false,
1038 - 'new_site' => [
1039 - 'always_active' => false,
1040 - 'default_active' => false,
1041 - 'default_inactive' => false,
1042 - 'minimum_installation_version' => null,
1043 - ],
1044 - 'on_state_change' => null,
1045 - 'generator_tag' => false,
1046 - 'deprecated' => false,
1047 - ];
1048 -
1049 - $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages', 'deprecated' ];
1050 - $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options );
1051 -
1052 - return $this->unify_feature_tags( $experimental_data );
1053 926 }
1054 927 }