PluginProbe
Elementor Website Builder – more than just a page builder / 3.13.0-beta1
Elementor Website Builder – more than just a page builder v3.13.0-beta1
4.3.4 4.3.3 4.3.2 4.3.1 4.3.0 4.3.0-beta3 4.3.0-beta2 4.3.0-beta1 4.2.4 4.2.3 4.2.2 4.2.1 4.2.0 4.1.5 4.2.0-beta2 4.2.0-dev2 4.2.0-beta1 4.1.4 4.1.3 4.1.2 4.1.1 4.1.0 4.1.0-beta3 4.1.0-dev3 4.0.9 All 457 releases
← All changes | core/experiments/manager.php +189 -370 4.3.2 → 3.13.0-beta1 View file →
@@ -1,9 +1,8 @@
1 1 <?php
2 2 namespace Elementor\Core\Experiments;
3 3
4 4 use Elementor\Core\Base\Base_Object;
5 -use Elementor\Core\Experiments\Exceptions\Dependency_Exception;
6 5 use Elementor\Core\Upgrade\Manager as Upgrade_Manager;
7 6 use Elementor\Core\Utils\Collection;
8 7 use Elementor\Modules\System_Info\Module as System_Info;
9 8 use Elementor\Plugin;
@@ -11,9 +10,9 @@
11 10 use Elementor\Tracker;
12 11 use Elementor\Utils;
13 12
14 13 if ( ! defined( 'ABSPATH' ) ) {
15 - exit; // Exit if accessed directly.
14 + exit; // Exit if accessed directly
16 15 }
17 16
18 17 class Manager extends Base_Object {
19 18
@@ -22,8 +21,10 @@
22 21 const RELEASE_STATUS_ALPHA = 'alpha';
23 22
24 23 const RELEASE_STATUS_BETA = 'beta';
25 24
25 + const RELEASE_STATUS_RC = 'rc';
26 +
26 27 const RELEASE_STATUS_STABLE = 'stable';
27 28
28 29 const STATE_DEFAULT = 'default';
29 30
@@ -32,10 +33,8 @@
32 33 const STATE_INACTIVE = 'inactive';
33 34
34 35 const TYPE_HIDDEN = 'hidden';
35 36
36 - const OPTION_PREFIX = 'elementor_experiment-';
37 -
38 37 private $states;
39 38
40 39 private $release_statuses;
41 40
@@ -43,26 +42,24 @@
43 42
44 43 /**
45 44 * Add Feature
46 45 *
47 - * Each feature has to provide the following information:
48 - * [
49 - * 'name' => string,
50 - * 'title' => string,
51 - * 'description' => string,
52 - * 'tag' => string,
53 - * 'release_status' => string,
54 - * 'default' => string,
55 - * 'new_site' => array,
56 - * ]
57 - *
58 46 * @since 3.1.0
59 47 * @access public
60 48 *
61 - * @param array $options Feature options.
49 + * @param array $options {
50 + * @type string $name
51 + * @type string $title
52 + * @type string $tag
53 + * @type array $tags
54 + * @type string $description
55 + * @type string $release_status
56 + * @type string $default
57 + * @type callable $on_state_change
58 + * }
59 + *
62 60 * @return array|null
63 - *
64 - * @throws Dependency_Exception If can't change feature state.
61 + * @throws \Exception
65 62 */
66 63 public function add_feature( array $options ) {
67 64 if ( isset( $this->features[ $options['name'] ] ) ) {
68 65 return null;
@@ -67,14 +64,45 @@
67 64 if ( isset( $this->features[ $options['name'] ] ) ) {
68 65 return null;
69 66 }
70 67
71 - $experimental_data = $this->set_feature_initial_options( $options );
68 + $default_experimental_data = [
69 + 'tag' => '', // Deprecated, use 'tags' instead.
70 + 'tags' => [],
71 + 'description' => '',
72 + 'release_status' => self::RELEASE_STATUS_ALPHA,
73 + 'default' => self::STATE_INACTIVE,
74 + 'mutable' => true,
75 + static::TYPE_HIDDEN => false,
76 + 'new_site' => [
77 + 'default_active' => false,
78 + 'always_active' => false,
79 + 'minimum_installation_version' => null,
80 + ],
81 + 'on_state_change' => null,
82 + 'generator_tag' => false,
83 + ];
72 84
85 + $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages' ];
86 +
87 + $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options );
88 +
89 + $experimental_data = $this->unify_feature_tags( $experimental_data );
90 +
73 91 $new_site = $experimental_data['new_site'];
74 92
75 - if ( $new_site['default_active'] || $new_site['always_active'] || $new_site['default_inactive'] ) {
76 - $experimental_data = $this->set_new_site_default_state( $new_site, $experimental_data );
93 + if ( $new_site['default_active'] || $new_site['always_active'] ) {
94 + $is_new_installation = Upgrade_Manager::install_compare( $new_site['minimum_installation_version'], '>=' );
95 +
96 + if ( $is_new_installation ) {
97 + if ( $new_site['always_active'] ) {
98 + $experimental_data['state'] = self::STATE_ACTIVE;
99 +
100 + $experimental_data['mutable'] = false;
101 + } elseif ( $new_site['default_active'] ) {
102 + $experimental_data['default'] = self::STATE_ACTIVE;
103 + }
104 + }
77 105 }
78 106
79 107 if ( $experimental_data['mutable'] ) {
80 108 $experimental_data['state'] = $this->get_saved_feature_state( $options['name'] );
@@ -84,9 +112,17 @@
84 112 $experimental_data['state'] = self::STATE_DEFAULT;
85 113 }
86 114
87 115 if ( ! empty( $experimental_data['dependencies'] ) ) {
88 - $experimental_data = $this->initialize_feature_dependencies( $experimental_data );
116 + foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
117 + $feature = $this->get_features( $dependency );
118 +
119 + if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
120 + throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' );
121 + }
122 +
123 + $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature );
124 + }
89 125 }
90 126
91 127 $this->features[ $options['name'] ] = $experimental_data;
92 128
@@ -99,9 +135,9 @@
99 135 } catch ( Exceptions\Dependency_Exception $e ) {
100 136 $message = sprintf(
101 137 '<p>%s</p><p><a href="#" onclick="location.href=\'%s\'">%s</a></p>',
102 138 esc_html( $e->getMessage() ),
103 - Settings::get_settings_tab_url( 'experiments' ),
139 + site_url( 'wp-admin/admin.php?page=elementor#tab-experiments' ),
104 140 esc_html__( 'Back', 'elementor' )
105 141 );
106 142
107 143 wp_die( $message ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
@@ -116,26 +152,8 @@
116 152
117 153 return $experimental_data;
118 154 }
119 155
120 - private function install_compare( $version ) {
121 - $installs_history = Upgrade_Manager::get_installs_history();
122 -
123 - if ( empty( $installs_history ) ) {
124 - // Fresh installation: upgrade manager hasn't written history yet on this first request.
125 - // Use the current plugin version as the effective first-install version.
126 - return version_compare( ELEMENTOR_VERSION, $version, '>=' );
127 - }
128 -
129 - $cleaned_version = preg_replace( '/-(beta|cloud|dev)\d*$/', '', key( $installs_history ) );
130 -
131 - return version_compare(
132 - $cleaned_version,
133 - $version,
134 - '>='
135 - );
136 - }
137 -
138 156 /**
139 157 * Combine 'tag' and 'tags' into one property.
140 158 *
141 159 * @param array $experimental_data
@@ -141,9 +159,9 @@
141 159 * @param array $experimental_data
142 160 *
143 161 * @return array
144 162 */
145 - private function unify_feature_tags( array $experimental_data ): array {
163 + private function unify_feature_tags( array $experimental_data ) : array {
146 164 foreach ( [ 'tag', 'tags' ] as $key ) {
147 165 if ( empty( $experimental_data[ $key ] ) ) {
148 166 continue;
149 167 }
@@ -160,21 +178,18 @@
160 178
161 179 /**
162 180 * Format feature tags into the right format.
163 181 *
164 - * If an array of tags provided, each tag has to provide the following information:
165 - * [
166 - * [
167 - * 'type' => string,
168 - * 'label' => string,
169 - * ]
170 - * ]
182 + * @param string|array[
183 + * [
184 + * 'type' => string,
185 + * 'label' => string
186 + * ]
187 + * ] $tag
171 188 *
172 - * @param string|array $tags A string of comma separated tags, or an array of tags.
173 - *
174 189 * @return array
175 190 */
176 - private function format_feature_tags( $tags ): array {
191 + private function format_feature_tags( $tags ) : array {
177 192 if ( ! is_string( $tags ) && ! is_array( $tags ) ) {
178 193 return [];
179 194 }
180 195
@@ -223,9 +238,9 @@
223 238 *
224 239 * @since 3.1.0
225 240 * @access public
226 241 *
227 - * @param string $feature_name Optional. Default is null.
242 + * @param string $feature_name Optional. Default is null
228 243 *
229 244 * @return array|null
230 245 */
231 246 public function get_features( $feature_name = null ) {
@@ -249,42 +264,20 @@
249 264 *
250 265 * @since 3.1.0
251 266 * @access public
252 267 *
253 - * @param string $feature_name Experiment feature name.
254 - * @param bool $check_dependencies When true, also require dependency experiments to be active.
255 - * Missing or hidden dependencies are treated as active for compatibility.
268 + * @param string $feature_name
256 269 *
257 270 * @return bool
258 271 */
259 - public function is_feature_active( $feature_name, $check_dependencies = false ) {
272 + public function is_feature_active( $feature_name ) {
260 273 $feature = $this->get_features( $feature_name );
261 274
262 - if ( ! $feature || self::STATE_ACTIVE !== $this->get_feature_actual_state( $feature ) ) {
275 + if ( ! $feature ) {
263 276 return false;
264 277 }
265 278
266 - if ( $check_dependencies && isset( $feature['dependencies'] ) && is_array( $feature['dependencies'] ) ) {
267 - foreach ( $feature['dependencies'] as $dependency ) {
268 - if ( $dependency instanceof Non_Existing_Dependency ) {
269 - continue;
270 - }
271 -
272 - $dependent_feature = $this->get_features( $dependency->get_name() );
273 -
274 - if ( $this->is_removed_or_hidden_dependency( $dependent_feature ) ) {
275 - continue;
276 - }
277 -
278 - $feature_state = self::STATE_ACTIVE === $this->get_feature_actual_state( $dependent_feature );
279 -
280 - if ( ! $feature_state ) {
281 - return false;
282 - }
283 - }
284 - }
285 -
286 - return true;
279 + return self::STATE_ACTIVE === $this->get_feature_actual_state( $feature );
287 280 }
288 281
289 282 /**
290 283 * Set Feature Default State
@@ -315,37 +308,88 @@
315 308 *
316 309 * @return string
317 310 */
318 311 public function get_feature_option_key( $feature_name ) {
319 - return static::OPTION_PREFIX . $feature_name;
312 + return 'elementor_experiment-' . $feature_name;
320 313 }
321 314
322 315 private function add_default_features() {
323 316 $this->add_feature( [
324 - 'name' => 'e_font_icon_svg',
325 - 'title' => esc_html__( 'Inline Font Icons', 'elementor' ),
317 + 'name' => 'e_dom_optimization',
318 + 'title' => esc_html__( 'Optimized DOM Output', 'elementor' ),
326 319 'tag' => esc_html__( 'Performance', 'elementor' ),
327 - 'description' => sprintf(
328 - '%1$s <a href="https://go.elementor.com/wp-dash-inline-font-awesome/" target="_blank">%2$s</a>',
329 - esc_html__( 'The “Inline Font Icons” will render the icons as inline SVG without loading the Font-Awesome and the eicons libraries and its related CSS files and fonts.', 'elementor' ),
330 - esc_html__( 'Learn more', 'elementor' )
331 - ),
320 + 'description' => esc_html__( 'Developers, Please Note! This experiment includes some markup changes. If you\'ve used custom code in Elementor, you might have experienced a snippet of code not running. Turning this experiment off allows you to keep prior Elementor markup output settings, and have that lovely code running again.', 'elementor' )
321 + . ' <a href="https://go.elementor.com/wp-dash-legacy-optimized-dom/" target="_blank">'
322 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
332 323 'release_status' => self::RELEASE_STATUS_STABLE,
333 324 'new_site' => [
334 325 'default_active' => true,
335 - 'minimum_installation_version' => '3.17.0',
326 + 'minimum_installation_version' => '3.1.0-beta',
336 327 ],
337 328 'generator_tag' => true,
338 329 ] );
339 330
340 331 $this->add_feature( [
332 + 'name' => 'e_optimized_assets_loading',
333 + 'title' => esc_html__( 'Improved Asset Loading', 'elementor' ),
334 + 'tag' => esc_html__( 'Performance', 'elementor' ),
335 + 'description' => esc_html__( 'Please Note! The "Improved Asset Loading" mode reduces the amount of code that is loaded on the page by default. When activated, parts of the infrastructure code will be loaded dynamically, only when needed. Keep in mind that activating this experiment may cause conflicts with incompatible plugins.', 'elementor' )
336 + . ' <a href="https://go.elementor.com/wp-dash-improved-asset-loading/" target="_blank">'
337 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
338 + 'release_status' => self::RELEASE_STATUS_STABLE,
339 + 'new_site' => [
340 + 'default_active' => true,
341 + 'minimum_installation_version' => '3.2.0-beta',
342 + ],
343 + 'generator_tag' => true,
344 + ] );
345 +
346 + $this->add_feature( [
347 + 'name' => 'e_optimized_css_loading',
348 + 'title' => esc_html__( 'Improved CSS Loading', 'elementor' ),
349 + 'tag' => esc_html__( 'Performance', 'elementor' ),
350 + 'description' => esc_html__( 'Please Note! The “Improved CSS Loading” mode reduces the amount of CSS code that is loaded on the page by default. When activated, the CSS code will be loaded, rather inline or in a dedicated file, only when needed. Activating this experiment may cause conflicts with incompatible plugins.', 'elementor' )
351 + . ' <a href="https://go.elementor.com/wp-dash-improved-css-loading/" target="_blank">'
352 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
353 + 'release_status' => self::RELEASE_STATUS_STABLE,
354 + 'new_site' => [
355 + 'default_active' => true,
356 + 'minimum_installation_version' => '3.3.0-beta',
357 + ],
358 + 'generator_tag' => true,
359 + ] );
360 +
361 + $this->add_feature( [
362 + 'name' => 'e_font_icon_svg',
363 + 'title' => esc_html__( 'Inline Font Icons', 'elementor' ),
364 + 'tag' => esc_html__( 'Performance', 'elementor' ),
365 + 'description' => esc_html__( 'The “Inline Font Icons” will render the icons as inline SVG without loading the Font-Awesome and the eicons libraries and its related CSS files and fonts.', 'elementor' )
366 + . ' <a href="https://go.elementor.com/wp-dash-inline-font-awesome/" target="_blank">'
367 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
368 + 'release_status' => self::RELEASE_STATUS_BETA,
369 + 'generator_tag' => true,
370 + ] );
371 +
372 + $this->add_feature( [
373 + 'name' => 'a11y_improvements',
374 + 'title' => esc_html__( 'Accessibility Improvements', 'elementor' ),
375 + 'tag' => esc_html__( 'Performance', 'elementor' ),
376 + 'description' => esc_html__( 'An array of accessibility enhancements in Elementor pages.', 'elementor' )
377 + . '<br><strong>' . esc_html__( 'Please note!', 'elementor' ) . '</strong> ' . esc_html__( 'These enhancements may include some markup changes to existing elementor widgets', 'elementor' )
378 + . ' <a href="https://go.elementor.com/wp-dash-a11y-improvements/" target="_blank">'
379 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
380 + 'release_status' => self::RELEASE_STATUS_STABLE,
381 + 'default' => self::STATE_ACTIVE,
382 + 'generator_tag' => true,
383 + ] );
384 +
385 + $this->add_feature( [
341 386 'name' => 'additional_custom_breakpoints',
342 387 'title' => esc_html__( 'Additional Custom Breakpoints', 'elementor' ),
343 - 'description' => sprintf(
344 - '%1$s <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">%2$s</a>',
345 - esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' ),
346 - esc_html__( 'Learn more', 'elementor' )
347 - ),
388 + 'tag' => esc_html__( 'Performance', 'elementor' ),
389 + 'description' => esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' )
390 + . ' <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">'
391 + . esc_html__( 'Learn More', 'elementor' ) . '</a>',
348 392 'release_status' => self::RELEASE_STATUS_STABLE,
349 393 'default' => self::STATE_ACTIVE,
350 394 'generator_tag' => true,
351 395 ] );
@@ -350,54 +394,54 @@
350 394 'generator_tag' => true,
351 395 ] );
352 396
353 397 $this->add_feature( [
398 + 'name' => 'admin_menu_rearrangement',
399 + 'mutable' => false,
400 + ] );
401 +
402 + $this->add_feature( [
354 403 'name' => 'container',
355 - 'title' => esc_html__( 'Container', 'elementor' ),
356 - 'description' => sprintf(
357 - /* translators: 1: Link opening tag, 2: Link closing tag, 3: Link opening tag, 4: Link closing tag */
358 - esc_html__( 'Create advanced layouts and responsive designs with %1$sFlexbox%2$s and %3$sGrid%4$s container elements.', 'elementor' ),
359 - '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">',
360 - '</a>',
361 - '<a target="_blank" href="https://go.elementor.com/wp-dash-grid-container/">',
362 - '</a>'
363 - ),
364 - 'release_status' => self::RELEASE_STATUS_STABLE,
404 + 'title' => esc_html__( 'Flexbox Container', 'elementor' ),
405 + 'description' => sprintf( esc_html__(
406 + 'Create advanced layouts and responsive designs with the new %1$sFlexbox Container element%2$s.
407 + This experiment replaces the current section/column structure, but you\'ll still keep your existing
408 + Sections, Inner Sections and Columns and be able to edit them. Ready to give it a try? Check out the %3$sFlexbox playground%4$s.',
409 + 'elementor'
410 + ), '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">', '</a>', '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container-playground/">', '</a>'),
411 + 'release_status' => self::RELEASE_STATUS_RC,
365 412 'default' => self::STATE_INACTIVE,
366 - 'new_site' => [
367 - 'default_active' => true,
368 - 'minimum_installation_version' => '3.16.0',
369 - ],
370 413 'messages' => [
371 - 'on_deactivate' => sprintf(
372 - '%1$s <a target="_blank" href="https://go.elementor.com/wp-dash-deactivate-container/">%2$s</a>',
373 - esc_html__( 'Container-based content will be hidden from your site and may not be recoverable in all cases.', 'elementor' ),
374 - esc_html__( 'Learn more', 'elementor' ),
414 + 'on_deactivate' => esc_html__(
415 + 'If you deactivate Flexbox Container, you will permanently delete all content created with containers and lose access to container-based features like Tabs and Menu widgets',
416 + 'elementor'
375 417 ),
376 418 ],
377 419 ] );
378 420
379 421 $this->add_feature( [
380 - 'name' => 'e_optimized_markup',
381 - 'title' => esc_html__( 'Optimized Markup', 'elementor' ),
382 - 'tag' => esc_html__( 'Performance', 'elementor' ),
383 - 'description' => esc_html__( 'Reduce the DOM size by eliminating HTML tags in various elements and widgets. This experiment includes markup changes so it might require updating custom CSS/JS code and cause compatibility issues with third party plugins.', 'elementor' ),
422 + 'name' => 'e_swiper_latest',
423 + 'title' => esc_html__( 'Upgrade Swiper Library', 'elementor' ),
424 + 'description' => esc_html__( 'Prepare your website for future improvements to carousel features by upgrading the Swiper library integrated into your site from v5.36 to v8.45. This experiment includes markup changes so it might require updating custom code and cause compatibility issues with third party plugins.', 'elementor' ),
384 425 'release_status' => self::RELEASE_STATUS_STABLE,
385 - 'default' => self::STATE_INACTIVE,
386 426 'new_site' => [
387 427 'default_active' => true,
388 - 'minimum_installation_version' => '3.30.0',
428 + 'minimum_installation_version' => '3.11.0',
389 429 ],
430 + 'default' => self::STATE_INACTIVE,
390 431 ] );
391 432
392 433 $this->add_feature( [
393 - 'name' => 'e_optimized_css_files',
394 - 'title' => esc_html__( 'Optimized CSS Files', 'elementor' ),
395 - 'tag' => esc_html__( 'Performance', 'elementor' ),
396 - 'description' => esc_html__( 'Keeps external CSS files available and consistent for sites behind page caching or a CDN.', 'elementor' ),
434 + 'name' => 'container_grid',
435 + 'title' => esc_html__( 'Grid Container', 'elementor' ),
436 + 'tag' => esc_html__( 'Feature', 'elementor' ),
437 + 'description' => esc_html__( 'Create advanced layouts and responsive designs with the new Container Grid element.', 'elementor' ),
397 438 'release_status' => self::RELEASE_STATUS_ALPHA,
398 439 'default' => self::STATE_INACTIVE,
399 - 'generator_tag' => true,
440 + 'hidden' => false,
441 + 'dependencies' => [
442 + 'container',
443 + ],
400 444 ] );
401 445 }
402 446
403 447 /**
@@ -424,8 +468,9 @@
424 468 $this->release_statuses = [
425 469 self::RELEASE_STATUS_DEV => esc_html__( 'Development', 'elementor' ),
426 470 self::RELEASE_STATUS_ALPHA => esc_html__( 'Alpha', 'elementor' ),
427 471 self::RELEASE_STATUS_BETA => esc_html__( 'Beta', 'elementor' ),
472 + self::RELEASE_STATUS_RC => esc_html__( 'Release Candidate', 'elementor' ),
428 473 self::RELEASE_STATUS_STABLE => esc_html__( 'Stable', 'elementor' ),
429 474 ];
430 475 }
431 476
@@ -449,8 +494,9 @@
449 494 * @param Settings $settings
450 495 *
451 496 * @since 3.1.0
452 497 * @access private
498 + *
453 499 */
454 500 private function register_settings_fields( Settings $settings ) {
455 501 $features = $this->get_features();
456 502
@@ -539,9 +585,9 @@
539 585 </h2>
540 586 <p class="e-experiment__description">
541 587 <?php
542 588 printf(
543 - /* translators: %1$s Link open tag, %2$s: Link close tag. */
589 + /* translators: %1$s Link open tag, %2$s: Link close tag. */
544 590 esc_html__( 'Personalize your Elementor experience by controlling which features and experiments are active on your site. Help make Elementor better by %1$ssharing your experience and feedback with us%2$s.', 'elementor' ),
545 591 '<a href="https://go.elementor.com/wp-dash-experiments-report-an-issue/" target="_blank">',
546 592 '</a>'
547 593 );
@@ -548,13 +594,14 @@
548 594 ?>
549 595 </p>
550 596 <p class="e-experiment__description">
551 597 <?php
552 - printf(
553 - '%1$s <a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">%2$s</a>',
554 - esc_html__( 'To use an experiment or feature on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time.', 'elementor' ),
555 - esc_html__( 'Learn more', 'elementor' ),
556 - );
598 + printf(
599 + /* translators: %1$s Link open tag, %2$s: Link close tag. */
600 + esc_html__( 'To use an experiment or feature on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time. %1$sLearn More.%2$s', 'elementor' ),
601 + '<a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">',
602 + '</a>'
603 + );
557 604 ?>
558 605 </p>
559 606
560 607 <?php if ( $this->get_features() ) { ?>
@@ -581,9 +628,8 @@
581 628 $control_id = 'e-experiment-' . $feature['name'];
582 629 $control_name = $this->get_feature_option_key( $feature['name'] );
583 630
584 631 $status = sprintf(
585 - /* translators: %s Release status. */
586 632 esc_html__( 'Status: %s', 'elementor' ),
587 633 $this->release_statuses[ $feature['release_status'] ]
588 634 );
589 635
@@ -642,13 +688,13 @@
642 688 ->find( function ( $dependency ) {
643 689 return $dependency instanceof Non_Existing_Dependency;
644 690 } );
645 691
646 - return (bool) $non_existing_dep;
692 + return ! ! $non_existing_dep;
647 693 }
648 694
649 695 /**
650 - * Get Feature Settings Label HTML.
696 + * Get Feature Settings Label HTML
651 697 *
652 698 * @since 3.1.0
653 699 * @access private
654 700 *
@@ -673,16 +719,10 @@
673 719 <div class="e-experiment__title">
674 720 <div class="<?php echo $indicator_classes; ?>" data-tooltip="<?php echo $indicator_tooltip; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"></div>
675 721 <label class="e-experiment__title__label" for="e-experiment-<?php echo $feature['name']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"><?php echo $feature['title']; ?></label>
676 722 <?php foreach ( $feature['tags'] as $tag ) { ?>
677 - <?php
678 - $tag_classes = 'e-experiment__title__tag e-experiment__title__tag__' . $tag['type'] . ' e-editor-one';
679 - ?>
680 - <span class="<?php echo esc_attr( $tag_classes ); ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
723 + <span class="e-experiment__title__tag e-experiment__title__tag__<?php echo $tag['type']; ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span>
681 724 <?php } ?>
682 - <?php if ( $feature['deprecated'] ) { ?>
683 - <span class="e-experiment__title__tag e-experiment__title__tag__deprecated"><?php echo esc_html__( 'Deprecated', 'elementor' ); ?></span>
684 - <?php } ?>
685 725 </div>
686 726 <?php
687 727
688 728 return ob_get_clean();
@@ -746,11 +786,12 @@
746 786 *
747 787 * @since 3.1.0
748 788 * @access private
749 789 *
750 - * @param array $old_feature_data
790 + * @param array $old_feature_data
751 791 * @param string $new_state
752 - * @param string $old_state
792 + *
793 + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception
753 794 */
754 795 private function on_feature_state_change( array $old_feature_data, $new_state, $old_state ) {
755 796 $new_feature_data = $this->get_features( $old_feature_data['name'] );
756 797 $this->validate_dependency( $new_feature_data, $new_state );
@@ -767,9 +808,9 @@
767 808 do_action( 'elementor/experiments/feature-state-change/' . $old_feature_data['name'], $old_state, $new_state );
768 809 }
769 810
770 811 /**
771 - * @throws Exceptions\Dependency_Exception If the feature dependency is not available or not active.
812 + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception
772 813 */
773 814 private function validate_dependency( array $feature, $new_state ) {
774 815 $rollback = function ( $feature_option_key, $state ) {
775 816 remove_all_actions( 'add_option_' . $feature_option_key );
@@ -790,41 +831,20 @@
790 831 }
791 832
792 833 // Validate if the current feature dependency is available.
793 834 foreach ( $feature['dependencies'] as $dependency ) {
794 - if ( $dependency instanceof Non_Existing_Dependency ) {
795 - $this->warn_removed_or_hidden_dependency(
796 - sprintf(
797 - 'The feature `%s` has a dependency `%s` that is not available in Core.',
798 - esc_html( $feature['name'] ),
799 - esc_html( $dependency->get_name() )
800 - )
801 - );
802 - continue;
803 - }
804 -
805 835 $dependency_feature = $this->get_features( $dependency->get_name() );
806 836
807 837 if ( ! $dependency_feature ) {
808 - $this->warn_removed_or_hidden_dependency(
809 - sprintf(
810 - 'The feature `%s` has a dependency `%s` that is not available in Core.',
811 - esc_html( $feature['name'] ),
812 - esc_html( $dependency->get_name() )
813 - )
814 - );
815 - continue;
816 - }
838 + $rollback( $feature_option_key, self::STATE_INACTIVE );
817 839
818 - if ( $this->is_removed_or_hidden_dependency( $dependency_feature ) ) {
819 - $this->warn_removed_or_hidden_dependency(
840 + throw new Exceptions\Dependency_Exception(
820 841 sprintf(
821 - 'The feature `%1$s` depends on hidden experiment `%2$s`.',
822 - esc_html( $feature['name'] ),
823 - esc_html( $dependency_feature['name'] )
842 + 'The feature `%s` has a dependency `%s` that is not available.',
843 + $feature['name'],
844 + $dependency->get_name()
824 845 )
825 846 );
826 - continue;
827 847 }
828 848
829 849 $dependency_state = $this->get_feature_actual_state( $dependency_feature );
830 850
@@ -834,10 +854,10 @@
834 854
835 855 throw new Exceptions\Dependency_Exception(
836 856 sprintf(
837 857 'To turn on `%1$s`, Experiment: `%2$s` activity is required!',
838 - esc_html( $feature['name'] ),
839 - esc_html( $dependency_feature['name'] )
858 + $feature['name'],
859 + $dependency_feature['name']
840 860 )
841 861 );
842 862 }
843 863 }
@@ -874,74 +894,8 @@
874 894
875 895 return new Non_Existing_Dependency( $dependency_name );
876 896 }
877 897
878 - /**
879 - * The experiments page is a WordPress options page, which means all the experiments are registered via WordPress' register_settings(),
880 - * and their states are being sent in the POST request when saving.
881 - * The options are being updated in a chronological order based on the POST data.
882 - * This behavior interferes with the experiments dependency mechanism because the data that's being sent can be in any order,
883 - * while the dependencies mechanism expects it to be in a specific order (dependencies should be activated before their dependents can).
884 - * In order to solve this issue, we sort the experiments in the POST data based on their dependencies tree.
885 - *
886 - * @param array $allowed_options
887 - */
888 - private function sort_allowed_options_by_dependencies( $allowed_options ) {
889 - if ( ! isset( $allowed_options['elementor'] ) ) {
890 - return $allowed_options;
891 - }
892 -
893 - $sorted = Collection::make();
894 - $visited = Collection::make();
895 -
896 - $sort = function ( $item ) use ( &$sort, $sorted, $visited ) {
897 - if ( $visited->contains( $item ) ) {
898 - return;
899 - }
900 -
901 - $visited->push( $item );
902 -
903 - $feature = $this->get_features( $item );
904 -
905 - if ( ! $feature ) {
906 - return;
907 - }
908 -
909 - foreach ( $feature['dependencies'] ?? [] as $dep ) {
910 - $name = is_string( $dep ) ? $dep : $dep->get_name();
911 -
912 - $sort( $name );
913 - }
914 -
915 - $sorted->push( $item );
916 - };
917 -
918 - foreach ( $allowed_options['elementor'] as $option ) {
919 - $is_experiment_option = strpos( $option, static::OPTION_PREFIX ) === 0;
920 -
921 - if ( ! $is_experiment_option ) {
922 - continue;
923 - }
924 -
925 - $sort(
926 - str_replace( static::OPTION_PREFIX, '', $option )
927 - );
928 - }
929 -
930 - $allowed_options['elementor'] = Collection::make( $allowed_options['elementor'] )
931 - ->filter( function ( $option ) {
932 - return 0 !== strpos( $option, static::OPTION_PREFIX );
933 - } )
934 - ->merge(
935 - $sorted->map( function ( $item ) {
936 - return static::OPTION_PREFIX . $item;
937 - } )
938 - )
939 - ->values();
940 -
941 - return $allowed_options;
942 - }
943 -
944 898 public function __construct() {
945 899 $this->init_states();
946 900
947 901 $this->init_release_statuses();
@@ -962,12 +916,8 @@
962 916
963 917 add_action( "elementor/admin/after_create_settings/{$page_id}", function( Settings $settings ) {
964 918 $this->register_settings_fields( $settings );
965 919 }, 11 );
966 -
967 - add_filter( 'allowed_options', function ( $allowed_options ) {
968 - return $this->sort_allowed_options_by_dependencies( $allowed_options );
969 - }, 11 );
970 920 }
971 921
972 922 // Register CLI commands.
973 923 if ( Utils::is_wp_cli() ) {
@@ -972,137 +922,6 @@
972 922 // Register CLI commands.
973 923 if ( Utils::is_wp_cli() ) {
974 924 \WP_CLI::add_command( 'elementor experiments', WP_CLI::class );
975 925 }
976 - }
977 -
978 - /**
979 - * @param array $experimental_data
980 - * @return array
981 - */
982 - private function initialize_feature_dependencies( array $experimental_data ): array {
983 - foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
984 - $feature = $this->get_features( $dependency );
985 -
986 - if ( ! isset( $feature ) ) {
987 - $this->warn_removed_or_hidden_dependency(
988 - sprintf(
989 - 'Feature %1$s depends on experiment %2$s that is not registered in Core.',
990 - esc_html( $experimental_data['name'] ),
991 - esc_html( $dependency )
992 - )
993 - );
994 -
995 - $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, null );
996 - continue;
997 - }
998 -
999 - if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
1000 - $this->warn_removed_or_hidden_dependency(
1001 - sprintf(
1002 - 'Feature %1$s depends on hidden experiment %2$s.',
1003 - esc_html( $experimental_data['name'] ),
1004 - esc_html( $dependency )
1005 - )
1006 - );
1007 - }
1008 -
1009 - $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature );
1010 - $experimental_data = $this->set_feature_default_state_to_match_dependencies( $feature, $experimental_data );
1011 - }
1012 -
1013 - return $experimental_data;
1014 - }
1015 -
1016 - private function is_removed_or_hidden_dependency( $dependency_feature ): bool {
1017 - if ( ! $dependency_feature ) {
1018 - return true;
1019 - }
1020 -
1021 - return ! empty( $dependency_feature[ static::TYPE_HIDDEN ] );
1022 - }
1023 -
1024 - private function warn_removed_or_hidden_dependency( string $message ): void {
1025 - if ( ! defined( 'WP_DEBUG' ) || ! WP_DEBUG ) {
1026 - return;
1027 - }
1028 -
1029 - // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Developer notice; message is escaped.
1030 - _doing_it_wrong( __METHOD__, esc_html( $message ), ELEMENTOR_VERSION );
1031 - }
1032 -
1033 - /**
1034 - * @param array $feature
1035 - * @param array $experimental_data
1036 - * @return array
1037 - *
1038 - * we must validate the state:
1039 - * * A user can set a dependant feature to inactive and in upgrade we don't change users settings.
1040 - * * A developer can set the default state to be invalid (e.g. dependant feature is inactive).
1041 - * if one of the dependencies is inactive, the main feature should be inactive as well.
1042 - */
1043 - private function set_feature_default_state_to_match_dependencies( array $feature, array $experimental_data ): array {
1044 - if ( self::STATE_INACTIVE !== $this->get_feature_actual_state( $feature ) ) {
1045 - return $experimental_data;
1046 - }
1047 -
1048 - if ( self::STATE_ACTIVE === $experimental_data['state'] ) {
1049 - $experimental_data['state'] = self::STATE_INACTIVE;
1050 - } elseif ( self::STATE_DEFAULT === $experimental_data['state'] ) {
1051 - $experimental_data['default'] = self::STATE_INACTIVE;
1052 - }
1053 -
1054 - return $experimental_data;
1055 - }
1056 -
1057 - /**
1058 - * @param array $new_site
1059 - * @param array $experimental_data
1060 - * @return array
1061 - */
1062 - private function set_new_site_default_state( $new_site, array $experimental_data ): array {
1063 - if ( ! $this->install_compare( $new_site['minimum_installation_version'] ) ) {
1064 - return $experimental_data;
1065 - }
1066 -
1067 - if ( $new_site['always_active'] ) {
1068 - $experimental_data['state'] = self::STATE_ACTIVE;
1069 - $experimental_data['mutable'] = false;
1070 - } elseif ( $new_site['default_active'] ) {
1071 - $experimental_data['default'] = self::STATE_ACTIVE;
1072 - } elseif ( $new_site['default_inactive'] ) {
1073 - $experimental_data['default'] = self::STATE_INACTIVE;
1074 - }
1075 -
1076 - return $experimental_data;
1077 - }
1078 -
1079 - /**
1080 - * @param array $options
1081 - * @return array
1082 - */
1083 - private function set_feature_initial_options( array $options ): array {
1084 - $default_experimental_data = [
1085 - 'tag' => '', // Deprecated, use 'tags' instead.
1086 - 'tags' => [],
1087 - 'description' => '',
1088 - 'release_status' => self::RELEASE_STATUS_ALPHA,
1089 - 'default' => self::STATE_INACTIVE,
1090 - 'mutable' => true,
1091 - static::TYPE_HIDDEN => false,
1092 - 'new_site' => [
1093 - 'always_active' => false,
1094 - 'default_active' => false,
1095 - 'default_inactive' => false,
1096 - 'minimum_installation_version' => null,
1097 - ],
1098 - 'on_state_change' => null,
1099 - 'generator_tag' => false,
1100 - 'deprecated' => false,
1101 - ];
1102 -
1103 - $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages', 'deprecated' ];
1104 - $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options );
1105 -
1106 - return $this->unify_feature_tags( $experimental_data );
1107 926 }
1108 927 }