| @@ -90,36 +90,8 @@ | ||
| 90 | 90 | return [ 'text', 'editor' ]; |
| 91 | 91 | } |
| 92 | 92 | |
| 93 | 93 | /** |
| 94 | - * Get style dependencies. | |
| 95 | - * | |
| 96 | - * Retrieve the list of style dependencies the widget requires. | |
| 97 | - * | |
| 98 | - * The 'widget-text-editor' style is required only when the drop cap is used. | |
| 99 | - * Therefor, style should not be loaded on the widget level, rather only on | |
| 100 | - * control level when the drop cap is active. | |
| 101 | - * | |
| 102 | - * Only in the Editor, these style should be loaded on the widget level. | |
| 103 | - * | |
| 104 | - * @since 3.24.0 | |
| 105 | - * @access public | |
| 106 | - * | |
| 107 | - * @return array Widget style dependencies. | |
| 108 | - */ | |
| 109 | - public function get_style_depends(): array { | |
| 110 | - $style_dependencies = Plugin::$instance->editor->is_edit_mode() || Plugin::$instance->preview->is_preview_mode() | |
| 111 | - ? [ 'widget-text-editor' ] | |
| 112 | - : []; | |
| 113 | - | |
| 114 | - return $style_dependencies; | |
| 115 | - } | |
| 116 | - | |
| 117 | - public function has_widget_inner_wrapper(): bool { | |
| 118 | - return ! Plugin::$instance->experiments->is_feature_active( 'e_optimized_markup' ); | |
| 119 | - } | |
| 120 | - | |
| 121 | - /** | |
| 122 | 94 | * Register text editor widget controls. |
| 123 | 95 | * |
| 124 | 96 | * Adds different input fields to allow the user to change and customize the widget settings. |
| 125 | 97 | * |
| @@ -150,28 +122,15 @@ | ||
| 150 | 122 | 'label_off' => esc_html__( 'Off', 'elementor' ), |
| 151 | 123 | 'label_on' => esc_html__( 'On', 'elementor' ), |
| 152 | 124 | 'prefix_class' => 'elementor-drop-cap-', |
| 153 | 125 | 'frontend_available' => true, |
| 154 | - 'assets' => [ | |
| 155 | - 'styles' => [ | |
| 156 | - [ | |
| 157 | - 'name' => 'widget-text-editor', | |
| 158 | - 'conditions' => [ | |
| 159 | - 'terms' => [ | |
| 160 | - [ | |
| 161 | - 'name' => 'drop_cap', | |
| 162 | - 'operator' => '===', | |
| 163 | - 'value' => 'yes', | |
| 164 | - ], | |
| 165 | - ], | |
| 166 | - ], | |
| 167 | - ], | |
| 168 | - ], | |
| 169 | - | |
| 170 | - ], | |
| 171 | 126 | ] |
| 172 | 127 | ); |
| 173 | 128 | |
| 129 | + $text_columns = range( 1, 10 ); | |
| 130 | + $text_columns = array_combine( $text_columns, $text_columns ); | |
| 131 | + $text_columns[''] = esc_html__( 'Default', 'elementor' ); | |
| 132 | + | |
| 174 | 133 | $this->add_responsive_control( |
| 175 | 134 | 'text_columns', |
| 176 | 135 | [ |
| 177 | 136 | 'label' => esc_html__( 'Columns', 'elementor' ), |
| @@ -176,21 +135,9 @@ | ||
| 176 | 135 | [ |
| 177 | 136 | 'label' => esc_html__( 'Columns', 'elementor' ), |
| 178 | 137 | 'type' => Controls_Manager::SELECT, |
| 179 | 138 | 'separator' => 'before', |
| 180 | - 'options' => [ | |
| 181 | - '' => esc_html__( 'Default', 'elementor' ), | |
| 182 | - '1' => esc_html__( '1', 'elementor' ), | |
| 183 | - '2' => esc_html__( '2', 'elementor' ), | |
| 184 | - '3' => esc_html__( '3', 'elementor' ), | |
| 185 | - '4' => esc_html__( '4', 'elementor' ), | |
| 186 | - '5' => esc_html__( '5', 'elementor' ), | |
| 187 | - '6' => esc_html__( '6', 'elementor' ), | |
| 188 | - '7' => esc_html__( '7', 'elementor' ), | |
| 189 | - '8' => esc_html__( '8', 'elementor' ), | |
| 190 | - '9' => esc_html__( '9', 'elementor' ), | |
| 191 | - '10' => esc_html__( '10', 'elementor' ), | |
| 192 | - ], | |
| 139 | + 'options' => $text_columns, | |
| 193 | 140 | 'selectors' => [ |
| 194 | 141 | '{{WRAPPER}}' => 'columns: {{VALUE}};', |
| 195 | 142 | ], |
| 196 | 143 | ] |
| @@ -215,31 +162,14 @@ | ||
| 215 | 162 | 'step' => 0.1, |
| 216 | 163 | ], |
| 217 | 164 | 'em' => [ |
| 218 | 165 | 'max' => 10, |
| 166 | + 'step' => 0.1, | |
| 219 | 167 | ], |
| 220 | - 'rem' => [ | |
| 221 | - 'max' => 10, | |
| 222 | - ], | |
| 223 | 168 | ], |
| 224 | 169 | 'selectors' => [ |
| 225 | 170 | '{{WRAPPER}}' => 'column-gap: {{SIZE}}{{UNIT}};', |
| 226 | 171 | ], |
| 227 | - 'conditions' => [ | |
| 228 | - 'relation' => 'or', | |
| 229 | - 'terms' => [ | |
| 230 | - [ | |
| 231 | - 'name' => 'text_columns', | |
| 232 | - 'operator' => '>', | |
| 233 | - 'value' => 1, | |
| 234 | - ], | |
| 235 | - [ | |
| 236 | - 'name' => 'text_columns', | |
| 237 | - 'operator' => '===', | |
| 238 | - 'value' => '', | |
| 239 | - ], | |
| 240 | - ], | |
| 241 | - ], | |
| 242 | 172 | ] |
| 243 | 173 | ); |
| 244 | 174 | |
| 245 | 175 | $this->end_controls_section(); |
| @@ -257,10 +187,10 @@ | ||
| 257 | 187 | [ |
| 258 | 188 | 'label' => esc_html__( 'Alignment', 'elementor' ), |
| 259 | 189 | 'type' => Controls_Manager::CHOOSE, |
| 260 | 190 | 'options' => [ |
| 261 | - 'start' => [ | |
| 262 | - 'title' => esc_html__( 'Start', 'elementor' ), | |
| 191 | + 'left' => [ | |
| 192 | + 'title' => esc_html__( 'Left', 'elementor' ), | |
| 263 | 193 | 'icon' => 'eicon-text-align-left', |
| 264 | 194 | ], |
| 265 | 195 | 'center' => [ |
| 266 | 196 | 'title' => esc_html__( 'Center', 'elementor' ), |
| @@ -265,10 +195,10 @@ | ||
| 265 | 195 | 'center' => [ |
| 266 | 196 | 'title' => esc_html__( 'Center', 'elementor' ), |
| 267 | 197 | 'icon' => 'eicon-text-align-center', |
| 268 | 198 | ], |
| 269 | - 'end' => [ | |
| 270 | - 'title' => esc_html__( 'End', 'elementor' ), | |
| 199 | + 'right' => [ | |
| 200 | + 'title' => esc_html__( 'Right', 'elementor' ), | |
| 271 | 201 | 'icon' => 'eicon-text-align-right', |
| 272 | 202 | ], |
| 273 | 203 | 'justify' => [ |
| 274 | 204 | 'title' => esc_html__( 'Justified', 'elementor' ), |
| @@ -274,76 +204,15 @@ | ||
| 274 | 204 | 'title' => esc_html__( 'Justified', 'elementor' ), |
| 275 | 205 | 'icon' => 'eicon-text-align-justify', |
| 276 | 206 | ], |
| 277 | 207 | ], |
| 278 | - 'classes' => 'elementor-control-start-end', | |
| 279 | - 'selectors_dictionary' => [ | |
| 280 | - 'left' => is_rtl() ? 'end' : 'start', | |
| 281 | - 'right' => is_rtl() ? 'start' : 'end', | |
| 282 | - ], | |
| 283 | 208 | 'selectors' => [ |
| 284 | 209 | '{{WRAPPER}}' => 'text-align: {{VALUE}};', |
| 285 | 210 | ], |
| 286 | - 'separator' => 'after', | |
| 287 | 211 | ] |
| 288 | 212 | ); |
| 289 | 213 | |
| 290 | - $this->add_group_control( | |
| 291 | - Group_Control_Typography::get_type(), | |
| 292 | - [ | |
| 293 | - 'name' => 'typography', | |
| 294 | - 'global' => [ | |
| 295 | - 'default' => Global_Typography::TYPOGRAPHY_TEXT, | |
| 296 | - ], | |
| 297 | - ] | |
| 298 | - ); | |
| 299 | - | |
| 300 | - $this->add_group_control( | |
| 301 | - Group_Control_Text_Shadow::get_type(), | |
| 302 | - [ | |
| 303 | - 'name' => 'text_shadow', | |
| 304 | - 'selector' => '{{WRAPPER}}', | |
| 305 | - ] | |
| 306 | - ); | |
| 307 | - | |
| 308 | - $this->add_responsive_control( | |
| 309 | - 'paragraph_spacing', | |
| 310 | - [ | |
| 311 | - 'label' => esc_html__( 'Paragraph Spacing', 'elementor' ), | |
| 312 | - 'type' => Controls_Manager::SLIDER, | |
| 313 | - 'size_units' => [ 'px', 'em', 'rem', 'vh', 'custom' ], | |
| 314 | - 'range' => [ | |
| 315 | - 'px' => [ | |
| 316 | - 'max' => 100, | |
| 317 | - ], | |
| 318 | - 'em' => [ | |
| 319 | - 'min' => 0.1, | |
| 320 | - 'max' => 20, | |
| 321 | - ], | |
| 322 | - ], | |
| 323 | - 'selectors' => [ | |
| 324 | - '{{WRAPPER}} p' => 'margin-block-end: {{SIZE}}{{UNIT}}', | |
| 325 | - ], | |
| 326 | - ] | |
| 327 | - ); | |
| 328 | - | |
| 329 | 214 | $this->add_control( |
| 330 | - 'separator', | |
| 331 | - [ | |
| 332 | - 'type' => Controls_Manager::DIVIDER, | |
| 333 | - ] | |
| 334 | - ); | |
| 335 | - | |
| 336 | - $this->start_controls_tabs( 'link_colors' ); | |
| 337 | - | |
| 338 | - $this->start_controls_tab( | |
| 339 | - 'colors_normal', | |
| 340 | - [ | |
| 341 | - 'label' => esc_html__( 'Normal', 'elementor' ), | |
| 342 | - ] | |
| 343 | - ); | |
| 344 | - | |
| 345 | - $this->add_control( | |
| 346 | 215 | 'text_color', |
| 347 | 216 | [ |
| 348 | 217 | 'label' => esc_html__( 'Text Color', 'elementor' ), |
| 349 | 218 | 'type' => Controls_Manager::COLOR, |
| @@ -356,58 +225,26 @@ | ||
| 356 | 225 | ], |
| 357 | 226 | ] |
| 358 | 227 | ); |
| 359 | 228 | |
| 360 | - $this->add_control( | |
| 361 | - 'link_color', | |
| 229 | + $this->add_group_control( | |
| 230 | + Group_Control_Typography::get_type(), | |
| 362 | 231 | [ |
| 363 | - 'label' => esc_html__( 'Link Color', 'elementor' ), | |
| 364 | - 'type' => Controls_Manager::COLOR, | |
| 365 | - 'selectors' => [ | |
| 366 | - '{{WRAPPER}} a' => 'color: {{VALUE}};', | |
| 232 | + 'name' => 'typography', | |
| 233 | + 'global' => [ | |
| 234 | + 'default' => Global_Typography::TYPOGRAPHY_TEXT, | |
| 367 | 235 | ], |
| 368 | 236 | ] |
| 369 | 237 | ); |
| 370 | 238 | |
| 371 | - $this->end_controls_tab(); | |
| 372 | - | |
| 373 | - $this->start_controls_tab( | |
| 374 | - 'colors_hover', | |
| 239 | + $this->add_group_control( | |
| 240 | + Group_Control_Text_Shadow::get_type(), | |
| 375 | 241 | [ |
| 376 | - 'label' => esc_html__( 'Hover', 'elementor' ), | |
| 242 | + 'name' => 'text_shadow', | |
| 243 | + 'selector' => '{{WRAPPER}}', | |
| 377 | 244 | ] |
| 378 | 245 | ); |
| 379 | 246 | |
| 380 | - $this->add_control( | |
| 381 | - 'link_hover_color', | |
| 382 | - [ | |
| 383 | - 'label' => esc_html__( 'Link Color', 'elementor' ), | |
| 384 | - 'type' => Controls_Manager::COLOR, | |
| 385 | - 'selectors' => [ | |
| 386 | - '{{WRAPPER}} a:hover, {{WRAPPER}} a:focus' => 'color: {{VALUE}};', | |
| 387 | - ], | |
| 388 | - ] | |
| 389 | - ); | |
| 390 | - | |
| 391 | - $this->add_control( | |
| 392 | - 'link_hover_color_transition_duration', | |
| 393 | - [ | |
| 394 | - 'label' => esc_html__( 'Transition Duration', 'elementor' ), | |
| 395 | - 'type' => Controls_Manager::SLIDER, | |
| 396 | - 'size_units' => [ 's', 'ms', 'custom' ], | |
| 397 | - 'default' => [ | |
| 398 | - 'unit' => 's', | |
| 399 | - ], | |
| 400 | - 'selectors' => [ | |
| 401 | - '{{WRAPPER}} a' => 'transition-duration: {{SIZE}}{{UNIT}};', | |
| 402 | - ], | |
| 403 | - ] | |
| 404 | - ); | |
| 405 | - | |
| 406 | - $this->end_controls_tab(); | |
| 407 | - | |
| 408 | - $this->end_controls_tabs(); | |
| 409 | - | |
| 410 | 247 | $this->end_controls_section(); |
| 411 | 248 | |
| 412 | 249 | $this->start_controls_section( |
| 413 | 250 | 'section_drop_cap', |
| @@ -477,9 +314,8 @@ | ||
| 477 | 314 | 'drop_cap_size', |
| 478 | 315 | [ |
| 479 | 316 | 'label' => esc_html__( 'Size', 'elementor' ), |
| 480 | 317 | 'type' => Controls_Manager::SLIDER, |
| 481 | - 'size_units' => [ 'px', 'em', 'rem', 'custom' ], | |
| 482 | 318 | 'default' => [ |
| 483 | 319 | 'size' => 5, |
| 484 | 320 | ], |
| 485 | 321 | 'range' => [ |
| @@ -485,14 +321,8 @@ | ||
| 485 | 321 | 'range' => [ |
| 486 | 322 | 'px' => [ |
| 487 | 323 | 'max' => 30, |
| 488 | 324 | ], |
| 489 | - 'em' => [ | |
| 490 | - 'max' => 3, | |
| 491 | - ], | |
| 492 | - 'rem' => [ | |
| 493 | - 'max' => 3, | |
| 494 | - ], | |
| 495 | 325 | ], |
| 496 | 326 | 'selectors' => [ |
| 497 | 327 | '{{WRAPPER}} .elementor-drop-cap' => 'padding: {{SIZE}}{{UNIT}};', |
| 498 | 328 | ], |
| @@ -506,9 +336,8 @@ | ||
| 506 | 336 | 'drop_cap_space', |
| 507 | 337 | [ |
| 508 | 338 | 'label' => esc_html__( 'Space', 'elementor' ), |
| 509 | 339 | 'type' => Controls_Manager::SLIDER, |
| 510 | - 'size_units' => [ 'px', 'em', 'rem', 'custom' ], | |
| 511 | 340 | 'default' => [ |
| 512 | 341 | 'size' => 10, |
| 513 | 342 | ], |
| 514 | 343 | 'range' => [ |
| @@ -514,17 +343,12 @@ | ||
| 514 | 343 | 'range' => [ |
| 515 | 344 | 'px' => [ |
| 516 | 345 | 'max' => 50, |
| 517 | 346 | ], |
| 518 | - 'em' => [ | |
| 519 | - 'max' => 5, | |
| 520 | - ], | |
| 521 | - 'rem' => [ | |
| 522 | - 'max' => 5, | |
| 523 | - ], | |
| 524 | 347 | ], |
| 525 | 348 | 'selectors' => [ |
| 526 | - '{{WRAPPER}} .elementor-drop-cap' => 'margin-inline-end: {{SIZE}}{{UNIT}};', | |
| 349 | + 'body:not(.rtl) {{WRAPPER}} .elementor-drop-cap' => 'margin-right: {{SIZE}}{{UNIT}};', | |
| 350 | + 'body.rtl {{WRAPPER}} .elementor-drop-cap' => 'margin-left: {{SIZE}}{{UNIT}};', | |
| 527 | 351 | ], |
| 528 | 352 | ] |
| 529 | 353 | ); |
| 530 | 354 | |
| @@ -544,11 +368,8 @@ | ||
| 544 | 368 | ], |
| 545 | 369 | 'selectors' => [ |
| 546 | 370 | '{{WRAPPER}} .elementor-drop-cap' => 'border-radius: {{SIZE}}{{UNIT}};', |
| 547 | 371 | ], |
| 548 | - 'condition' => [ | |
| 549 | - 'drop_cap_view!' => 'default', | |
| 550 | - ], | |
| 551 | 372 | ] |
| 552 | 373 | ); |
| 553 | 374 | |
| 554 | 375 | $this->add_control( |
| @@ -587,17 +408,15 @@ | ||
| 587 | 408 | * @since 1.0.0 |
| 588 | 409 | * @access protected |
| 589 | 410 | */ |
| 590 | 411 | protected function render() { |
| 591 | - $should_render_inline_editing = Plugin::$instance->editor->is_edit_mode(); | |
| 412 | + $is_dom_optimized = Plugin::$instance->experiments->is_feature_active( 'e_dom_optimization' ); | |
| 413 | + $is_edit_mode = Plugin::$instance->editor->is_edit_mode(); | |
| 414 | + $should_render_inline_editing = ( ! $is_dom_optimized || $is_edit_mode ); | |
| 592 | 415 | |
| 593 | 416 | $editor_content = $this->get_settings_for_display( 'editor' ); |
| 594 | 417 | $editor_content = $this->parse_text_editor( $editor_content ); |
| 595 | 418 | |
| 596 | - if ( empty( $editor_content ) ) { | |
| 597 | - return; | |
| 598 | - } | |
| 599 | - | |
| 600 | 419 | if ( $should_render_inline_editing ) { |
| 601 | 420 | $this->add_render_attribute( 'editor', 'class', [ 'elementor-text-editor', 'elementor-clearfix' ] ); |
| 602 | 421 | } |
| 603 | 422 | |
| @@ -605,11 +424,10 @@ | ||
| 605 | 424 | ?> |
| 606 | 425 | <?php if ( $should_render_inline_editing ) { ?> |
| 607 | 426 | <div <?php $this->print_render_attribute_string( 'editor' ); ?>> |
| 608 | 427 | <?php } ?> |
| 609 | - <?php // PHPCS - DO NOT REMOVE THIS ECHO - THE MAIN TEXT OF A WIDGET SHOULD NOT BE ESCAPED! | |
| 610 | - echo $editor_content; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | |
| 611 | - ?> | |
| 428 | + <?php // PHPCS - the main text of a widget should not be escaped. | |
| 429 | + echo $editor_content; // phpcs:ignore WordPress.Security.EscapeOutput ?> | |
| 612 | 430 | <?php if ( $should_render_inline_editing ) { ?> |
| 613 | 431 | </div> |
| 614 | 432 | <?php } ?> |
| 615 | 433 | <?php |
| @@ -638,13 +456,11 @@ | ||
| 638 | 456 | */ |
| 639 | 457 | protected function content_template() { |
| 640 | 458 | ?> |
| 641 | 459 | <# |
| 642 | - if ( '' === settings.editor ) { | |
| 643 | - return; | |
| 644 | - } | |
| 645 | - | |
| 646 | - const shouldRenderInlineEditing = elementorFrontend.isEditMode(); | |
| 460 | + const isDomOptimized = ! ! elementorFrontend.config.experimentalFeatures.e_dom_optimization, | |
| 461 | + isEditMode = elementorFrontend.isEditMode(), | |
| 462 | + shouldRenderInlineEditing = ( ! isDomOptimized || isEditMode ); | |
| 647 | 463 | |
| 648 | 464 | if ( shouldRenderInlineEditing ) { |
| 649 | 465 | view.addRenderAttribute( 'editor', 'class', [ 'elementor-text-editor', 'elementor-clearfix' ] ); |
| 650 | 466 | } |