| @@ -1,9 +1,8 @@ | ||
| 1 | 1 | <?php |
| 2 | 2 | namespace Elementor\Core\Experiments; |
| 3 | 3 | |
| 4 | 4 | use Elementor\Core\Base\Base_Object; |
| 5 | -use Elementor\Core\Experiments\Exceptions\Dependency_Exception; | |
| 6 | 5 | use Elementor\Core\Upgrade\Manager as Upgrade_Manager; |
| 7 | 6 | use Elementor\Core\Utils\Collection; |
| 8 | 7 | use Elementor\Modules\System_Info\Module as System_Info; |
| 9 | 8 | use Elementor\Plugin; |
| @@ -11,9 +10,9 @@ | ||
| 11 | 10 | use Elementor\Tracker; |
| 12 | 11 | use Elementor\Utils; |
| 13 | 12 | |
| 14 | 13 | if ( ! defined( 'ABSPATH' ) ) { |
| 15 | - exit; // Exit if accessed directly. | |
| 14 | + exit; // Exit if accessed directly | |
| 16 | 15 | } |
| 17 | 16 | |
| 18 | 17 | class Manager extends Base_Object { |
| 19 | 18 | |
| @@ -22,8 +21,10 @@ | ||
| 22 | 21 | const RELEASE_STATUS_ALPHA = 'alpha'; |
| 23 | 22 | |
| 24 | 23 | const RELEASE_STATUS_BETA = 'beta'; |
| 25 | 24 | |
| 25 | + const RELEASE_STATUS_RC = 'rc'; | |
| 26 | + | |
| 26 | 27 | const RELEASE_STATUS_STABLE = 'stable'; |
| 27 | 28 | |
| 28 | 29 | const STATE_DEFAULT = 'default'; |
| 29 | 30 | |
| @@ -43,26 +44,24 @@ | ||
| 43 | 44 | |
| 44 | 45 | /** |
| 45 | 46 | * Add Feature |
| 46 | 47 | * |
| 47 | - * Each feature has to provide the following information: | |
| 48 | - * [ | |
| 49 | - * 'name' => string, | |
| 50 | - * 'title' => string, | |
| 51 | - * 'description' => string, | |
| 52 | - * 'tag' => string, | |
| 53 | - * 'release_status' => string, | |
| 54 | - * 'default' => string, | |
| 55 | - * 'new_site' => array, | |
| 56 | - * ] | |
| 57 | - * | |
| 58 | 48 | * @since 3.1.0 |
| 59 | 49 | * @access public |
| 60 | 50 | * |
| 61 | - * @param array $options Feature options. | |
| 51 | + * @param array $options { | |
| 52 | + * @type string $name | |
| 53 | + * @type string $title | |
| 54 | + * @type string $tag | |
| 55 | + * @type array $tags | |
| 56 | + * @type string $description | |
| 57 | + * @type string $release_status | |
| 58 | + * @type string $default | |
| 59 | + * @type callable $on_state_change | |
| 60 | + * } | |
| 61 | + * | |
| 62 | 62 | * @return array|null |
| 63 | - * | |
| 64 | - * @throws Dependency_Exception If can't change feature state. | |
| 63 | + * @throws \Exception | |
| 65 | 64 | */ |
| 66 | 65 | public function add_feature( array $options ) { |
| 67 | 66 | if ( isset( $this->features[ $options['name'] ] ) ) { |
| 68 | 67 | return null; |
| @@ -67,14 +66,45 @@ | ||
| 67 | 66 | if ( isset( $this->features[ $options['name'] ] ) ) { |
| 68 | 67 | return null; |
| 69 | 68 | } |
| 70 | 69 | |
| 71 | - $experimental_data = $this->set_feature_initial_options( $options ); | |
| 70 | + $default_experimental_data = [ | |
| 71 | + 'tag' => '', // Deprecated, use 'tags' instead. | |
| 72 | + 'tags' => [], | |
| 73 | + 'description' => '', | |
| 74 | + 'release_status' => self::RELEASE_STATUS_ALPHA, | |
| 75 | + 'default' => self::STATE_INACTIVE, | |
| 76 | + 'mutable' => true, | |
| 77 | + static::TYPE_HIDDEN => false, | |
| 78 | + 'new_site' => [ | |
| 79 | + 'default_active' => false, | |
| 80 | + 'always_active' => false, | |
| 81 | + 'minimum_installation_version' => null, | |
| 82 | + ], | |
| 83 | + 'on_state_change' => null, | |
| 84 | + 'generator_tag' => false, | |
| 85 | + ]; | |
| 72 | 86 | |
| 87 | + $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages' ]; | |
| 88 | + | |
| 89 | + $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options ); | |
| 90 | + | |
| 91 | + $experimental_data = $this->unify_feature_tags( $experimental_data ); | |
| 92 | + | |
| 73 | 93 | $new_site = $experimental_data['new_site']; |
| 74 | 94 | |
| 75 | - if ( $new_site['default_active'] || $new_site['always_active'] || $new_site['default_inactive'] ) { | |
| 76 | - $experimental_data = $this->set_new_site_default_state( $new_site, $experimental_data ); | |
| 95 | + if ( $new_site['default_active'] || $new_site['always_active'] ) { | |
| 96 | + $is_new_installation = $this->install_compare( $new_site['minimum_installation_version'] ); | |
| 97 | + | |
| 98 | + if ( $is_new_installation ) { | |
| 99 | + if ( $new_site['always_active'] ) { | |
| 100 | + $experimental_data['state'] = self::STATE_ACTIVE; | |
| 101 | + | |
| 102 | + $experimental_data['mutable'] = false; | |
| 103 | + } elseif ( $new_site['default_active'] ) { | |
| 104 | + $experimental_data['default'] = self::STATE_ACTIVE; | |
| 105 | + } | |
| 106 | + } | |
| 77 | 107 | } |
| 78 | 108 | |
| 79 | 109 | if ( $experimental_data['mutable'] ) { |
| 80 | 110 | $experimental_data['state'] = $this->get_saved_feature_state( $options['name'] ); |
| @@ -84,15 +114,21 @@ | ||
| 84 | 114 | $experimental_data['state'] = self::STATE_DEFAULT; |
| 85 | 115 | } |
| 86 | 116 | |
| 87 | 117 | if ( ! empty( $experimental_data['dependencies'] ) ) { |
| 88 | - $experimental_data = $this->initialize_feature_dependencies( $experimental_data ); | |
| 118 | + foreach ( $experimental_data['dependencies'] as $key => $dependency ) { | |
| 119 | + $feature = $this->get_features( $dependency ); | |
| 120 | + | |
| 121 | + if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) { | |
| 122 | + throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' ); | |
| 123 | + } | |
| 124 | + | |
| 125 | + $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature ); | |
| 126 | + } | |
| 89 | 127 | } |
| 90 | 128 | |
| 91 | 129 | $this->features[ $options['name'] ] = $experimental_data; |
| 92 | 130 | |
| 93 | - $this->resolve_registered_dependants( $options['name'], $experimental_data ); | |
| 94 | - | |
| 95 | 131 | if ( $experimental_data['mutable'] && is_admin() ) { |
| 96 | 132 | $feature_option_key = $this->get_feature_option_key( $options['name'] ); |
| 97 | 133 | |
| 98 | 134 | $on_state_change_callback = function( $old_state, $new_state ) use ( $experimental_data, $feature_option_key ) { |
| @@ -101,9 +137,9 @@ | ||
| 101 | 137 | } catch ( Exceptions\Dependency_Exception $e ) { |
| 102 | 138 | $message = sprintf( |
| 103 | 139 | '<p>%s</p><p><a href="#" onclick="location.href=\'%s\'">%s</a></p>', |
| 104 | 140 | esc_html( $e->getMessage() ), |
| 105 | - Settings::get_settings_tab_url( 'experiments' ), | |
| 141 | + site_url( 'wp-admin/admin.php?page=elementor#tab-experiments' ), | |
| 106 | 142 | esc_html__( 'Back', 'elementor' ) |
| 107 | 143 | ); |
| 108 | 144 | |
| 109 | 145 | wp_die( $message ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped |
| @@ -122,11 +158,9 @@ | ||
| 122 | 158 | private function install_compare( $version ) { |
| 123 | 159 | $installs_history = Upgrade_Manager::get_installs_history(); |
| 124 | 160 | |
| 125 | 161 | if ( empty( $installs_history ) ) { |
| 126 | - // Fresh installation: upgrade manager hasn't written history yet on this first request. | |
| 127 | - // Use the current plugin version as the effective first-install version. | |
| 128 | - return version_compare( ELEMENTOR_VERSION, $version, '>=' ); | |
| 162 | + return false; | |
| 129 | 163 | } |
| 130 | 164 | |
| 131 | 165 | $cleaned_version = preg_replace( '/-(beta|cloud|dev)\d*$/', '', key( $installs_history ) ); |
| 132 | 166 | |
| @@ -143,9 +177,9 @@ | ||
| 143 | 177 | * @param array $experimental_data |
| 144 | 178 | * |
| 145 | 179 | * @return array |
| 146 | 180 | */ |
| 147 | - private function unify_feature_tags( array $experimental_data ): array { | |
| 181 | + private function unify_feature_tags( array $experimental_data ) : array { | |
| 148 | 182 | foreach ( [ 'tag', 'tags' ] as $key ) { |
| 149 | 183 | if ( empty( $experimental_data[ $key ] ) ) { |
| 150 | 184 | continue; |
| 151 | 185 | } |
| @@ -162,21 +196,18 @@ | ||
| 162 | 196 | |
| 163 | 197 | /** |
| 164 | 198 | * Format feature tags into the right format. |
| 165 | 199 | * |
| 166 | - * If an array of tags provided, each tag has to provide the following information: | |
| 167 | - * [ | |
| 168 | - * [ | |
| 169 | - * 'type' => string, | |
| 170 | - * 'label' => string, | |
| 171 | - * ] | |
| 172 | - * ] | |
| 200 | + * @param string|array[ | |
| 201 | + * [ | |
| 202 | + * 'type' => string, | |
| 203 | + * 'label' => string | |
| 204 | + * ] | |
| 205 | + * ] $tag | |
| 173 | 206 | * |
| 174 | - * @param string|array $tags A string of comma separated tags, or an array of tags. | |
| 175 | - * | |
| 176 | 207 | * @return array |
| 177 | 208 | */ |
| 178 | - private function format_feature_tags( $tags ): array { | |
| 209 | + private function format_feature_tags( $tags ) : array { | |
| 179 | 210 | if ( ! is_string( $tags ) && ! is_array( $tags ) ) { |
| 180 | 211 | return []; |
| 181 | 212 | } |
| 182 | 213 | |
| @@ -225,9 +256,9 @@ | ||
| 225 | 256 | * |
| 226 | 257 | * @since 3.1.0 |
| 227 | 258 | * @access public |
| 228 | 259 | * |
| 229 | - * @param string $feature_name Optional. Default is null. | |
| 260 | + * @param string $feature_name Optional. Default is null | |
| 230 | 261 | * |
| 231 | 262 | * @return array|null |
| 232 | 263 | */ |
| 233 | 264 | public function get_features( $feature_name = null ) { |
| @@ -251,58 +282,20 @@ | ||
| 251 | 282 | * |
| 252 | 283 | * @since 3.1.0 |
| 253 | 284 | * @access public |
| 254 | 285 | * |
| 255 | - * @param string $feature_name Experiment feature name. | |
| 256 | - * @param bool $check_dependencies When true, also require dependency experiments to be active. | |
| 257 | - * Missing dependencies always fail closed. Hidden dependencies are treated as satisfied. | |
| 286 | + * @param string $feature_name | |
| 258 | 287 | * |
| 259 | 288 | * @return bool |
| 260 | 289 | */ |
| 261 | - public function is_feature_active( $feature_name, $check_dependencies = false ) { | |
| 290 | + public function is_feature_active( $feature_name ) { | |
| 262 | 291 | $feature = $this->get_features( $feature_name ); |
| 263 | 292 | |
| 264 | - if ( ! $feature || self::STATE_ACTIVE !== $this->get_feature_actual_state( $feature ) ) { | |
| 293 | + if ( ! $feature ) { | |
| 265 | 294 | return false; |
| 266 | 295 | } |
| 267 | 296 | |
| 268 | - if ( isset( $feature['dependencies'] ) && is_array( $feature['dependencies'] ) ) { | |
| 269 | - foreach ( $feature['dependencies'] as $dependency ) { | |
| 270 | - $dependent_feature = $this->get_features( $dependency->get_name() ); | |
| 271 | - | |
| 272 | - // A dependency that Core still does not ship can never be verified as active. | |
| 273 | - // Non existing dependencies are re-resolved first to cover later registrations. | |
| 274 | - if ( $dependency instanceof Non_Existing_Dependency && ! $dependent_feature ) { | |
| 275 | - return false; | |
| 276 | - } | |
| 277 | - | |
| 278 | - if ( ! $dependent_feature ) { | |
| 279 | - // A Core experiment dependency that no longer resolves fails closed. | |
| 280 | - // Class dependencies are not experiment names and stay exempt. | |
| 281 | - if ( $dependency instanceof Wrap_Core_Dependency ) { | |
| 282 | - return false; | |
| 283 | - } | |
| 284 | - | |
| 285 | - continue; | |
| 286 | - } | |
| 287 | - | |
| 288 | - if ( ! $check_dependencies ) { | |
| 289 | - continue; | |
| 290 | - } | |
| 291 | - | |
| 292 | - if ( ! empty( $dependent_feature[ static::TYPE_HIDDEN ] ) ) { | |
| 293 | - continue; | |
| 294 | - } | |
| 295 | - | |
| 296 | - $feature_state = self::STATE_ACTIVE === $this->get_feature_actual_state( $dependent_feature ); | |
| 297 | - | |
| 298 | - if ( ! $feature_state ) { | |
| 299 | - return false; | |
| 300 | - } | |
| 301 | - } | |
| 302 | - } | |
| 303 | - | |
| 304 | - return true; | |
| 297 | + return self::STATE_ACTIVE === $this->get_feature_actual_state( $feature ); | |
| 305 | 298 | } |
| 306 | 299 | |
| 307 | 300 | /** |
| 308 | 301 | * Set Feature Default State |
| @@ -338,8 +331,39 @@ | ||
| 338 | 331 | } |
| 339 | 332 | |
| 340 | 333 | private function add_default_features() { |
| 341 | 334 | $this->add_feature( [ |
| 335 | + 'name' => 'e_optimized_assets_loading', | |
| 336 | + 'title' => esc_html__( 'Improved Asset Loading', 'elementor' ), | |
| 337 | + 'tag' => esc_html__( 'Performance', 'elementor' ), | |
| 338 | + 'description' => sprintf( | |
| 339 | + '%1$s <a href="https://go.elementor.com/wp-dash-improved-asset-loading/" target="_blank">%2$s</a>', | |
| 340 | + esc_html__( 'Please Note! The "Improved Asset Loading" mode reduces the amount of code that is loaded on the page by default. When activated, parts of the infrastructure code will be loaded dynamically, only when needed. Keep in mind that activating this experiment may cause conflicts with incompatible plugins.', 'elementor' ), | |
| 341 | + esc_html__( 'Learn more', 'elementor' ) | |
| 342 | + ), | |
| 343 | + 'release_status' => self::RELEASE_STATUS_STABLE, | |
| 344 | + 'default' => self::STATE_ACTIVE, | |
| 345 | + 'generator_tag' => true, | |
| 346 | + ] ); | |
| 347 | + | |
| 348 | + $this->add_feature( [ | |
| 349 | + 'name' => 'e_optimized_css_loading', | |
| 350 | + 'title' => esc_html__( 'Improved CSS Loading', 'elementor' ), | |
| 351 | + 'tag' => esc_html__( 'Performance', 'elementor' ), | |
| 352 | + 'description' => sprintf( | |
| 353 | + '%1$s <a href="https://go.elementor.com/wp-dash-improved-css-loading/" target="_blank">%2$s</a>', | |
| 354 | + esc_html__( 'Please Note! The “Improved CSS Loading” mode reduces the amount of CSS code that is loaded on the page by default. When activated, the CSS code will be loaded, rather inline or in a dedicated file, only when needed. Activating this experiment may cause conflicts with incompatible plugins.', 'elementor' ), | |
| 355 | + esc_html__( 'Learn more', 'elementor' ) | |
| 356 | + ), | |
| 357 | + 'release_status' => self::RELEASE_STATUS_STABLE, | |
| 358 | + 'new_site' => [ | |
| 359 | + 'default_active' => true, | |
| 360 | + 'minimum_installation_version' => '3.3.0', | |
| 361 | + ], | |
| 362 | + 'generator_tag' => true, | |
| 363 | + ] ); | |
| 364 | + | |
| 365 | + $this->add_feature( [ | |
| 342 | 366 | 'name' => 'e_font_icon_svg', |
| 343 | 367 | 'title' => esc_html__( 'Inline Font Icons', 'elementor' ), |
| 344 | 368 | 'tag' => esc_html__( 'Performance', 'elementor' ), |
| 345 | 369 | 'description' => sprintf( |
| @@ -357,8 +381,9 @@ | ||
| 357 | 381 | |
| 358 | 382 | $this->add_feature( [ |
| 359 | 383 | 'name' => 'additional_custom_breakpoints', |
| 360 | 384 | 'title' => esc_html__( 'Additional Custom Breakpoints', 'elementor' ), |
| 385 | + 'tag' => esc_html__( 'Performance', 'elementor' ), | |
| 361 | 386 | 'description' => sprintf( |
| 362 | 387 | '%1$s <a href="https://go.elementor.com/wp-dash-additional-custom-breakpoints/" target="_blank">%2$s</a>', |
| 363 | 388 | esc_html__( 'Get pixel-perfect design for every screen size. You can now add up to 6 customizable breakpoints beyond the default desktop setting: mobile, mobile extra, tablet, tablet extra, laptop, and widescreen.', 'elementor' ), |
| 364 | 389 | esc_html__( 'Learn more', 'elementor' ) |
| @@ -368,16 +393,25 @@ | ||
| 368 | 393 | 'generator_tag' => true, |
| 369 | 394 | ] ); |
| 370 | 395 | |
| 371 | 396 | $this->add_feature( [ |
| 397 | + 'name' => 'admin_menu_rearrangement', | |
| 398 | + 'mutable' => false, | |
| 399 | + ] ); | |
| 400 | + | |
| 401 | + $this->add_feature( [ | |
| 372 | 402 | 'name' => 'container', |
| 373 | - 'title' => esc_html__( 'Container', 'elementor' ), | |
| 403 | + 'title' => esc_html__( 'Flexbox Container', 'elementor' ), | |
| 374 | 404 | 'description' => sprintf( |
| 375 | - /* translators: 1: Link opening tag, 2: Link closing tag, 3: Link opening tag, 4: Link closing tag */ | |
| 376 | - esc_html__( 'Create advanced layouts and responsive designs with %1$sFlexbox%2$s and %3$sGrid%4$s container elements.', 'elementor' ), | |
| 405 | + esc_html__( | |
| 406 | + 'Create advanced layouts and responsive designs with the new %1$sFlexbox Container element%2$s. | |
| 407 | + This experiment replaces the current section/column structure, but you\'ll still keep your existing | |
| 408 | + Sections, Inner Sections and Columns and be able to edit them. Ready to give it a try? Check out the %3$sFlexbox playground%4$s.', | |
| 409 | + 'elementor' | |
| 410 | + ), | |
| 377 | 411 | '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container/">', |
| 378 | 412 | '</a>', |
| 379 | - '<a target="_blank" href="https://go.elementor.com/wp-dash-grid-container/">', | |
| 413 | + '<a target="_blank" href="https://go.elementor.com/wp-dash-flex-container-playground/">', | |
| 380 | 414 | '</a>' |
| 381 | 415 | ), |
| 382 | 416 | 'release_status' => self::RELEASE_STATUS_STABLE, |
| 383 | 417 | 'default' => self::STATE_INACTIVE, |
| @@ -394,29 +428,34 @@ | ||
| 394 | 428 | ], |
| 395 | 429 | ] ); |
| 396 | 430 | |
| 397 | 431 | $this->add_feature( [ |
| 398 | - 'name' => 'e_optimized_markup', | |
| 399 | - 'title' => esc_html__( 'Optimized Markup', 'elementor' ), | |
| 400 | - 'tag' => esc_html__( 'Performance', 'elementor' ), | |
| 401 | - 'description' => esc_html__( 'Reduce the DOM size by eliminating HTML tags in various elements and widgets. This experiment includes markup changes so it might require updating custom CSS/JS code and cause compatibility issues with third party plugins.', 'elementor' ), | |
| 432 | + 'name' => 'e_swiper_latest', | |
| 433 | + 'title' => esc_html__( 'Upgrade Swiper Library', 'elementor' ), | |
| 434 | + 'description' => esc_html__( 'Prepare your website for future improvements to carousel features by upgrading the Swiper library integrated into your site from v5.36 to v8.45. This experiment includes markup changes so it might require updating custom code and cause compatibility issues with third party plugins.', 'elementor' ), | |
| 402 | 435 | 'release_status' => self::RELEASE_STATUS_STABLE, |
| 436 | + 'default' => self::STATE_ACTIVE, | |
| 437 | + ] ); | |
| 438 | + | |
| 439 | + $this->add_feature( [ | |
| 440 | + 'name' => 'container_grid', | |
| 441 | + 'title' => esc_html__( 'Grid Container', 'elementor' ), | |
| 442 | + 'tag' => esc_html__( 'Feature', 'elementor' ), | |
| 443 | + 'description' => sprintf( | |
| 444 | + '%1$s <a target="_blank" href="https://go.elementor.com/wp-dash-grid-container/">%2$s</a>', | |
| 445 | + esc_html__( 'Create pixel perfect layouts by placing elements in a customizable grid. Activate to add the CSS Grid option to container elements.', 'elementor' ), | |
| 446 | + esc_html__( 'Learn more', 'elementor' ), | |
| 447 | + ), | |
| 448 | + 'release_status' => self::RELEASE_STATUS_BETA, | |
| 403 | 449 | 'default' => self::STATE_INACTIVE, |
| 404 | 450 | 'new_site' => [ |
| 405 | 451 | 'default_active' => true, |
| 406 | - 'minimum_installation_version' => '3.30.0', | |
| 452 | + 'minimum_installation_version' => '3.20.0', | |
| 407 | 453 | ], |
| 454 | + 'dependencies' => [ | |
| 455 | + 'container', | |
| 456 | + ], | |
| 408 | 457 | ] ); |
| 409 | - | |
| 410 | - $this->add_feature( [ | |
| 411 | - 'name' => 'e_optimized_css_files', | |
| 412 | - 'title' => esc_html__( 'Optimized CSS Files', 'elementor' ), | |
| 413 | - 'tag' => esc_html__( 'Performance', 'elementor' ), | |
| 414 | - 'description' => esc_html__( 'Keeps external CSS files available and consistent for sites behind page caching or a CDN.', 'elementor' ), | |
| 415 | - 'release_status' => self::RELEASE_STATUS_ALPHA, | |
| 416 | - 'default' => self::STATE_INACTIVE, | |
| 417 | - 'generator_tag' => true, | |
| 418 | - ] ); | |
| 419 | 458 | } |
| 420 | 459 | |
| 421 | 460 | /** |
| 422 | 461 | * Init States |
| @@ -442,8 +481,9 @@ | ||
| 442 | 481 | $this->release_statuses = [ |
| 443 | 482 | self::RELEASE_STATUS_DEV => esc_html__( 'Development', 'elementor' ), |
| 444 | 483 | self::RELEASE_STATUS_ALPHA => esc_html__( 'Alpha', 'elementor' ), |
| 445 | 484 | self::RELEASE_STATUS_BETA => esc_html__( 'Beta', 'elementor' ), |
| 485 | + self::RELEASE_STATUS_RC => esc_html__( 'Release Candidate', 'elementor' ), | |
| 446 | 486 | self::RELEASE_STATUS_STABLE => esc_html__( 'Stable', 'elementor' ), |
| 447 | 487 | ]; |
| 448 | 488 | } |
| 449 | 489 | |
| @@ -467,8 +507,9 @@ | ||
| 467 | 507 | * @param Settings $settings |
| 468 | 508 | * |
| 469 | 509 | * @since 3.1.0 |
| 470 | 510 | * @access private |
| 511 | + * | |
| 471 | 512 | */ |
| 472 | 513 | private function register_settings_fields( Settings $settings ) { |
| 473 | 514 | $features = $this->get_features(); |
| 474 | 515 | |
| @@ -556,9 +597,9 @@ | ||
| 556 | 597 | <?php echo esc_html__( 'Experiments and Features', 'elementor' ); ?> |
| 557 | 598 | </h2> |
| 558 | 599 | <p class="e-experiment__description"> |
| 559 | 600 | <?php |
| 560 | - printf( | |
| 601 | + echo sprintf( | |
| 561 | 602 | /* translators: %1$s Link open tag, %2$s: Link close tag. */ |
| 562 | 603 | esc_html__( 'Personalize your Elementor experience by controlling which features and experiments are active on your site. Help make Elementor better by %1$ssharing your experience and feedback with us%2$s.', 'elementor' ), |
| 563 | 604 | '<a href="https://go.elementor.com/wp-dash-experiments-report-an-issue/" target="_blank">', |
| 564 | 605 | '</a>' |
| @@ -566,9 +607,9 @@ | ||
| 566 | 607 | ?> |
| 567 | 608 | </p> |
| 568 | 609 | <p class="e-experiment__description"> |
| 569 | 610 | <?php |
| 570 | - printf( | |
| 611 | + echo sprintf( | |
| 571 | 612 | '%1$s <a href="https://go.elementor.com/wp-dash-experiments/" target="_blank">%2$s</a>', |
| 572 | 613 | esc_html__( 'To use an experiment or feature on your site, simply click on the dropdown next to it and switch to Active. You can always deactivate them at any time.', 'elementor' ), |
| 573 | 614 | esc_html__( 'Learn more', 'elementor' ), |
| 574 | 615 | ); |
| @@ -660,13 +701,13 @@ | ||
| 660 | 701 | ->find( function ( $dependency ) { |
| 661 | 702 | return $dependency instanceof Non_Existing_Dependency; |
| 662 | 703 | } ); |
| 663 | 704 | |
| 664 | - return (bool) $non_existing_dep; | |
| 705 | + return ! ! $non_existing_dep; | |
| 665 | 706 | } |
| 666 | 707 | |
| 667 | 708 | /** |
| 668 | - * Get Feature Settings Label HTML. | |
| 709 | + * Get Feature Settings Label HTML | |
| 669 | 710 | * |
| 670 | 711 | * @since 3.1.0 |
| 671 | 712 | * @access private |
| 672 | 713 | * |
| @@ -691,16 +732,10 @@ | ||
| 691 | 732 | <div class="e-experiment__title"> |
| 692 | 733 | <div class="<?php echo $indicator_classes; ?>" data-tooltip="<?php echo $indicator_tooltip; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"></div> |
| 693 | 734 | <label class="e-experiment__title__label" for="e-experiment-<?php echo $feature['name']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>"><?php echo $feature['title']; ?></label> |
| 694 | 735 | <?php foreach ( $feature['tags'] as $tag ) { ?> |
| 695 | - <?php | |
| 696 | - $tag_classes = 'e-experiment__title__tag e-experiment__title__tag__' . $tag['type'] . ' e-editor-one'; | |
| 697 | - ?> | |
| 698 | - <span class="<?php echo esc_attr( $tag_classes ); ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span> | |
| 736 | + <span class="e-experiment__title__tag e-experiment__title__tag__<?php echo $tag['type']; ?>"><?php echo $tag['label']; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?></span> | |
| 699 | 737 | <?php } ?> |
| 700 | - <?php if ( $feature['deprecated'] ) { ?> | |
| 701 | - <span class="e-experiment__title__tag e-experiment__title__tag__deprecated"><?php echo esc_html__( 'Deprecated', 'elementor' ); ?></span> | |
| 702 | - <?php } ?> | |
| 703 | 738 | </div> |
| 704 | 739 | <?php |
| 705 | 740 | |
| 706 | 741 | return ob_get_clean(); |
| @@ -764,11 +799,12 @@ | ||
| 764 | 799 | * |
| 765 | 800 | * @since 3.1.0 |
| 766 | 801 | * @access private |
| 767 | 802 | * |
| 768 | - * @param array $old_feature_data | |
| 803 | + * @param array $old_feature_data | |
| 769 | 804 | * @param string $new_state |
| 770 | - * @param string $old_state | |
| 805 | + * | |
| 806 | + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception | |
| 771 | 807 | */ |
| 772 | 808 | private function on_feature_state_change( array $old_feature_data, $new_state, $old_state ) { |
| 773 | 809 | $new_feature_data = $this->get_features( $old_feature_data['name'] ); |
| 774 | 810 | $this->validate_dependency( $new_feature_data, $new_state ); |
| @@ -785,9 +821,9 @@ | ||
| 785 | 821 | do_action( 'elementor/experiments/feature-state-change/' . $old_feature_data['name'], $old_state, $new_state ); |
| 786 | 822 | } |
| 787 | 823 | |
| 788 | 824 | /** |
| 789 | - * @throws Exceptions\Dependency_Exception If the feature dependency is not available or not active. | |
| 825 | + * @throws \Elementor\Core\Experiments\Exceptions\Dependency_Exception | |
| 790 | 826 | */ |
| 791 | 827 | private function validate_dependency( array $feature, $new_state ) { |
| 792 | 828 | $rollback = function ( $feature_option_key, $state ) { |
| 793 | 829 | remove_all_actions( 'add_option_' . $feature_option_key ); |
| @@ -808,41 +844,20 @@ | ||
| 808 | 844 | } |
| 809 | 845 | |
| 810 | 846 | // Validate if the current feature dependency is available. |
| 811 | 847 | foreach ( $feature['dependencies'] as $dependency ) { |
| 812 | - if ( $dependency instanceof Non_Existing_Dependency ) { | |
| 813 | - $this->warn_removed_or_hidden_dependency( | |
| 814 | - sprintf( | |
| 815 | - 'The feature `%s` has a dependency `%s` that is not available in Core.', | |
| 816 | - esc_html( $feature['name'] ), | |
| 817 | - esc_html( $dependency->get_name() ) | |
| 818 | - ) | |
| 819 | - ); | |
| 820 | - continue; | |
| 821 | - } | |
| 822 | - | |
| 823 | 848 | $dependency_feature = $this->get_features( $dependency->get_name() ); |
| 824 | 849 | |
| 825 | 850 | if ( ! $dependency_feature ) { |
| 826 | - $this->warn_removed_or_hidden_dependency( | |
| 827 | - sprintf( | |
| 828 | - 'The feature `%s` has a dependency `%s` that is not available in Core.', | |
| 829 | - esc_html( $feature['name'] ), | |
| 830 | - esc_html( $dependency->get_name() ) | |
| 831 | - ) | |
| 832 | - ); | |
| 833 | - continue; | |
| 834 | - } | |
| 851 | + $rollback( $feature_option_key, self::STATE_INACTIVE ); | |
| 835 | 852 | |
| 836 | - if ( $this->is_removed_or_hidden_dependency( $dependency_feature ) ) { | |
| 837 | - $this->warn_removed_or_hidden_dependency( | |
| 853 | + throw new Exceptions\Dependency_Exception( | |
| 838 | 854 | sprintf( |
| 839 | - 'The feature `%1$s` depends on hidden experiment `%2$s`.', | |
| 840 | - esc_html( $feature['name'] ), | |
| 841 | - esc_html( $dependency_feature['name'] ) | |
| 855 | + 'The feature `%s` has a dependency `%s` that is not available.', | |
| 856 | + $feature['name'], | |
| 857 | + $dependency->get_name() | |
| 842 | 858 | ) |
| 843 | 859 | ); |
| 844 | - continue; | |
| 845 | 860 | } |
| 846 | 861 | |
| 847 | 862 | $dependency_state = $this->get_feature_actual_state( $dependency_feature ); |
| 848 | 863 | |
| @@ -852,10 +867,10 @@ | ||
| 852 | 867 | |
| 853 | 868 | throw new Exceptions\Dependency_Exception( |
| 854 | 869 | sprintf( |
| 855 | 870 | 'To turn on `%1$s`, Experiment: `%2$s` activity is required!', |
| 856 | - esc_html( $feature['name'] ), | |
| 857 | - esc_html( $dependency_feature['name'] ) | |
| 871 | + $feature['name'], | |
| 872 | + $dependency_feature['name'] | |
| 858 | 873 | ) |
| 859 | 874 | ); |
| 860 | 875 | } |
| 861 | 876 | } |
| @@ -900,9 +915,11 @@ | ||
| 900 | 915 | * This behavior interferes with the experiments dependency mechanism because the data that's being sent can be in any order, |
| 901 | 916 | * while the dependencies mechanism expects it to be in a specific order (dependencies should be activated before their dependents can). |
| 902 | 917 | * In order to solve this issue, we sort the experiments in the POST data based on their dependencies tree. |
| 903 | 918 | * |
| 904 | - * @param array $allowed_options | |
| 919 | + * @param $allowed_options | |
| 920 | + * | |
| 921 | + * @return mixed | |
| 905 | 922 | */ |
| 906 | 923 | private function sort_allowed_options_by_dependencies( $allowed_options ) { |
| 907 | 924 | if ( ! isset( $allowed_options['elementor'] ) ) { |
| 908 | 925 | return $allowed_options; |
| @@ -990,160 +1007,6 @@ | ||
| 990 | 1007 | // Register CLI commands. |
| 991 | 1008 | if ( Utils::is_wp_cli() ) { |
| 992 | 1009 | \WP_CLI::add_command( 'elementor experiments', WP_CLI::class ); |
| 993 | 1010 | } |
| 994 | - } | |
| 995 | - | |
| 996 | - /** | |
| 997 | - * @param array $experimental_data | |
| 998 | - * @return array | |
| 999 | - */ | |
| 1000 | - private function initialize_feature_dependencies( array $experimental_data ): array { | |
| 1001 | - foreach ( $experimental_data['dependencies'] as $key => $dependency ) { | |
| 1002 | - $feature = $this->get_features( $dependency ); | |
| 1003 | - | |
| 1004 | - if ( ! isset( $feature ) ) { | |
| 1005 | - $this->warn_removed_or_hidden_dependency( | |
| 1006 | - sprintf( | |
| 1007 | - 'Feature %1$s depends on experiment %2$s that is not registered in Core.', | |
| 1008 | - esc_html( $experimental_data['name'] ), | |
| 1009 | - esc_html( $dependency ) | |
| 1010 | - ) | |
| 1011 | - ); | |
| 1012 | - | |
| 1013 | - $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, null ); | |
| 1014 | - continue; | |
| 1015 | - } | |
| 1016 | - | |
| 1017 | - if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) { | |
| 1018 | - $this->warn_removed_or_hidden_dependency( | |
| 1019 | - sprintf( | |
| 1020 | - 'Feature %1$s depends on hidden experiment %2$s.', | |
| 1021 | - esc_html( $experimental_data['name'] ), | |
| 1022 | - esc_html( $dependency ) | |
| 1023 | - ) | |
| 1024 | - ); | |
| 1025 | - } | |
| 1026 | - | |
| 1027 | - $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature ); | |
| 1028 | - $experimental_data = $this->set_feature_default_state_to_match_dependencies( $feature, $experimental_data ); | |
| 1029 | - } | |
| 1030 | - | |
| 1031 | - return $experimental_data; | |
| 1032 | - } | |
| 1033 | - | |
| 1034 | - private function is_removed_or_hidden_dependency( $dependency_feature ): bool { | |
| 1035 | - if ( ! $dependency_feature ) { | |
| 1036 | - return true; | |
| 1037 | - } | |
| 1038 | - | |
| 1039 | - return ! empty( $dependency_feature[ static::TYPE_HIDDEN ] ); | |
| 1040 | - } | |
| 1041 | - | |
| 1042 | - /** | |
| 1043 | - * Re-resolve non existing dependency placeholders of dependants that were | |
| 1044 | - * registered before this feature existed. | |
| 1045 | - * | |
| 1046 | - * @param string $feature_name Newly registered feature name. | |
| 1047 | - * @param array $feature_data Newly registered feature data. | |
| 1048 | - */ | |
| 1049 | - private function resolve_registered_dependants( string $feature_name, array $feature_data ): void { | |
| 1050 | - foreach ( $this->features as $name => $registered_feature ) { | |
| 1051 | - if ( $name === $feature_name || empty( $registered_feature['dependencies'] ) || ! is_array( $registered_feature['dependencies'] ) ) { | |
| 1052 | - continue; | |
| 1053 | - } | |
| 1054 | - | |
| 1055 | - foreach ( $registered_feature['dependencies'] as $key => $dependency ) { | |
| 1056 | - if ( ! ( $dependency instanceof Non_Existing_Dependency ) || $dependency->get_name() !== $feature_name ) { | |
| 1057 | - continue; | |
| 1058 | - } | |
| 1059 | - | |
| 1060 | - $this->features[ $name ]['dependencies'][ $key ] = $this->create_dependency_class( $feature_name, $feature_data ); | |
| 1061 | - } | |
| 1062 | - } | |
| 1063 | - } | |
| 1064 | - | |
| 1065 | - private function warn_removed_or_hidden_dependency( string $message ): void { | |
| 1066 | - if ( ! defined( 'WP_DEBUG' ) || ! WP_DEBUG ) { | |
| 1067 | - return; | |
| 1068 | - } | |
| 1069 | - | |
| 1070 | - // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Developer notice; message is escaped. | |
| 1071 | - _doing_it_wrong( __METHOD__, esc_html( $message ), ELEMENTOR_VERSION ); | |
| 1072 | - } | |
| 1073 | - | |
| 1074 | - /** | |
| 1075 | - * @param array $feature | |
| 1076 | - * @param array $experimental_data | |
| 1077 | - * @return array | |
| 1078 | - * | |
| 1079 | - * we must validate the state: | |
| 1080 | - * * A user can set a dependant feature to inactive and in upgrade we don't change users settings. | |
| 1081 | - * * A developer can set the default state to be invalid (e.g. dependant feature is inactive). | |
| 1082 | - * if one of the dependencies is inactive, the main feature should be inactive as well. | |
| 1083 | - */ | |
| 1084 | - private function set_feature_default_state_to_match_dependencies( array $feature, array $experimental_data ): array { | |
| 1085 | - if ( self::STATE_INACTIVE !== $this->get_feature_actual_state( $feature ) ) { | |
| 1086 | - return $experimental_data; | |
| 1087 | - } | |
| 1088 | - | |
| 1089 | - if ( self::STATE_ACTIVE === $experimental_data['state'] ) { | |
| 1090 | - $experimental_data['state'] = self::STATE_INACTIVE; | |
| 1091 | - } elseif ( self::STATE_DEFAULT === $experimental_data['state'] ) { | |
| 1092 | - $experimental_data['default'] = self::STATE_INACTIVE; | |
| 1093 | - } | |
| 1094 | - | |
| 1095 | - return $experimental_data; | |
| 1096 | - } | |
| 1097 | - | |
| 1098 | - /** | |
| 1099 | - * @param array $new_site | |
| 1100 | - * @param array $experimental_data | |
| 1101 | - * @return array | |
| 1102 | - */ | |
| 1103 | - private function set_new_site_default_state( $new_site, array $experimental_data ): array { | |
| 1104 | - if ( ! $this->install_compare( $new_site['minimum_installation_version'] ) ) { | |
| 1105 | - return $experimental_data; | |
| 1106 | - } | |
| 1107 | - | |
| 1108 | - if ( $new_site['always_active'] ) { | |
| 1109 | - $experimental_data['state'] = self::STATE_ACTIVE; | |
| 1110 | - $experimental_data['mutable'] = false; | |
| 1111 | - } elseif ( $new_site['default_active'] ) { | |
| 1112 | - $experimental_data['default'] = self::STATE_ACTIVE; | |
| 1113 | - } elseif ( $new_site['default_inactive'] ) { | |
| 1114 | - $experimental_data['default'] = self::STATE_INACTIVE; | |
| 1115 | - } | |
| 1116 | - | |
| 1117 | - return $experimental_data; | |
| 1118 | - } | |
| 1119 | - | |
| 1120 | - /** | |
| 1121 | - * @param array $options | |
| 1122 | - * @return array | |
| 1123 | - */ | |
| 1124 | - private function set_feature_initial_options( array $options ): array { | |
| 1125 | - $default_experimental_data = [ | |
| 1126 | - 'tag' => '', // Deprecated, use 'tags' instead. | |
| 1127 | - 'tags' => [], | |
| 1128 | - 'description' => '', | |
| 1129 | - 'release_status' => self::RELEASE_STATUS_ALPHA, | |
| 1130 | - 'default' => self::STATE_INACTIVE, | |
| 1131 | - 'mutable' => true, | |
| 1132 | - static::TYPE_HIDDEN => false, | |
| 1133 | - 'new_site' => [ | |
| 1134 | - 'always_active' => false, | |
| 1135 | - 'default_active' => false, | |
| 1136 | - 'default_inactive' => false, | |
| 1137 | - 'minimum_installation_version' => null, | |
| 1138 | - ], | |
| 1139 | - 'on_state_change' => null, | |
| 1140 | - 'generator_tag' => false, | |
| 1141 | - 'deprecated' => false, | |
| 1142 | - ]; | |
| 1143 | - | |
| 1144 | - $allowed_options = [ 'name', 'title', 'tag', 'tags', 'description', 'release_status', 'default', 'mutable', static::TYPE_HIDDEN, 'new_site', 'on_state_change', 'dependencies', 'generator_tag', 'messages', 'deprecated' ]; | |
| 1145 | - $experimental_data = $this->merge_properties( $default_experimental_data, $options, $allowed_options ); | |
| 1146 | - | |
| 1147 | - return $this->unify_feature_tags( $experimental_data ); | |
| 1148 | 1011 | } |
| 1149 | 1012 | } |
