← All changes | core/experiments/manager.php +66 -11 4.3.1 → 4.3.2 View file →

		@@ -249,9 +249,11 @@
249	249	*
250	250	* @since 3.1.0
251	251	* @access public
252	252	*
253		- * @param string $feature_name
	253	+ * @param string $feature_name Experiment feature name.
	254	+ * @param bool $check_dependencies When true, also require dependency experiments to be active.
	255	+ * Missing or hidden dependencies are treated as active for compatibility.
254	256	*
255	257	* @return bool
256	258	*/
257	259	public function is_feature_active( $feature_name, $check_dependencies = false ) {
		@@ -262,9 +264,18 @@
262	264	}
263	265
264	266	if ( $check_dependencies && isset( $feature['dependencies'] ) && is_array( $feature['dependencies'] ) ) {
265	267	foreach ( $feature['dependencies'] as $dependency ) {
	268	+ if ( $dependency instanceof Non_Existing_Dependency ) {
	269	+ continue;
	270	+ }
	271	+
266	272	$dependent_feature = $this->get_features( $dependency->get_name() );
	273	+
	274	+ if ( $this->is_removed_or_hidden_dependency( $dependent_feature ) ) {
	275	+ continue;
	276	+ }
	277	+
267	278	$feature_state = self::STATE_ACTIVE === $this->get_feature_actual_state( $dependent_feature );
268	279
269	280	if ( ! $feature_state ) {
270	281	return false;
		@@ -779,20 +790,41 @@
779	790	}
780	791
781	792	// Validate if the current feature dependency is available.
782	793	foreach ( $feature['dependencies'] as $dependency ) {
	794	+ if ( $dependency instanceof Non_Existing_Dependency ) {
	795	+ $this->warn_removed_or_hidden_dependency(
	796	+ sprintf(
	797	+ 'The feature `%s` has a dependency `%s` that is not available in Core.',
	798	+ esc_html( $feature['name'] ),
	799	+ esc_html( $dependency->get_name() )
	800	+ )
	801	+ );
	802	+ continue;
	803	+ }
	804	+
783	805	$dependency_feature = $this->get_features( $dependency->get_name() );
784	806
785	807	if ( ! $dependency_feature ) {
786		- $rollback( $feature_option_key, self::STATE_INACTIVE );
	808	+ $this->warn_removed_or_hidden_dependency(
	809	+ sprintf(
	810	+ 'The feature `%s` has a dependency `%s` that is not available in Core.',
	811	+ esc_html( $feature['name'] ),
	812	+ esc_html( $dependency->get_name() )
	813	+ )
	814	+ );
	815	+ continue;
	816	+ }
787	817
788		- throw new Exceptions\Dependency_Exception(
	818	+ if ( $this->is_removed_or_hidden_dependency( $dependency_feature ) ) {
	819	+ $this->warn_removed_or_hidden_dependency(
789	820	sprintf(
790		- 'The feature `%s` has a dependency `%s` that is not available.',
	821	+ 'The feature `%1$s` depends on hidden experiment `%2$s`.',
791	822	esc_html( $feature['name'] ),
792		- esc_html( $dependency->get_name() )
	823	+ esc_html( $dependency_feature['name'] )
793	824	)
794	825	);
	826	+ continue;
795	827	}
796	828
797	829	$dependency_state = $this->get_feature_actual_state( $dependency_feature );
798	830
		@@ -945,10 +977,8 @@
945	977
946	978	/**
947	979	* @param array $experimental_data
948	980	* @return array
949		- *
950		- * @throws Exceptions\Dependency_Exception If the feature dependency is not initialized or depends on a hidden experiment.
951	981	*/
952	982	private function initialize_feature_dependencies( array $experimental_data ): array {
953	983	foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
954	984	$feature = $this->get_features( $dependency );
		@@ -953,20 +983,28 @@
953	983	foreach ( $experimental_data['dependencies'] as $key => $dependency ) {
954	984	$feature = $this->get_features( $dependency );
955	985
956	986	if ( ! isset( $feature ) ) {
957		- // since we must validate the state of each dependency, we have to make sure that dependencies are initialized in the correct order, otherwise, error.
958		- throw new Exceptions\Dependency_Exception(
	987	+ $this->warn_removed_or_hidden_dependency(
959	988	sprintf(
960		- 'Feature %s cannot be initialized before dependency feature: %s.',
	989	+ 'Feature %1$s depends on experiment %2$s that is not registered in Core.',
961	990	esc_html( $experimental_data['name'] ),
962	991	esc_html( $dependency )
963	992	)
964	993	);
	994	+
	995	+ $experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, null );
	996	+ continue;
965	997	}
966	998
967	999	if ( ! empty( $feature[ static::TYPE_HIDDEN ] ) ) {
968		- throw new Exceptions\Dependency_Exception( 'Depending on a hidden experiment is not allowed.' );
	1000	+ $this->warn_removed_or_hidden_dependency(
	1001	+ sprintf(
	1002	+ 'Feature %1$s depends on hidden experiment %2$s.',
	1003	+ esc_html( $experimental_data['name'] ),
	1004	+ esc_html( $dependency )
	1005	+ )
	1006	+ );
969	1007	}
970	1008
971	1009	$experimental_data['dependencies'][ $key ] = $this->create_dependency_class( $dependency, $feature );
972	1010	$experimental_data = $this->set_feature_default_state_to_match_dependencies( $feature, $experimental_data );
		@@ -972,8 +1010,25 @@
972	1010	$experimental_data = $this->set_feature_default_state_to_match_dependencies( $feature, $experimental_data );
973	1011	}
974	1012
975	1013	return $experimental_data;
	1014	+ }
	1015	+
	1016	+ private function is_removed_or_hidden_dependency( $dependency_feature ): bool {
	1017	+ if ( ! $dependency_feature ) {
	1018	+ return true;
	1019	+ }
	1020	+
	1021	+ return ! empty( $dependency_feature[ static::TYPE_HIDDEN ] );
	1022	+ }
	1023	+
	1024	+ private function warn_removed_or_hidden_dependency( string $message ): void {
	1025	+ if ( ! defined( 'WP_DEBUG' ) || ! WP_DEBUG ) {
	1026	+ return;
	1027	+ }
	1028	+
	1029	+ // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- Developer notice; message is escaped.
	1030	+ _doing_it_wrong( __METHOD__, esc_html( $message ), ELEMENTOR_VERSION );
976	1031	}
977	1032
978	1033	/**
979	1034	* @param array $feature