← All changes | src/AutoLaunch/functions/plugins.js +134 -26 3.1.0 → 3.2.2 View file →

		@@ -1,6 +1,11 @@
1	1	import { recordPluginActivity } from '@shared/api/DataApi';
	2	+import { digest } from '@shared/api/digest';
2	3	import { enableAutoUpdate } from '@shared/api/wp';
	4	+import {
	5	+ failedDependencies,
	6	+ processWithSecondPass,
	7	+} from '@shared/lib/patterns';
3	8	import apiFetch from '@wordpress/api-fetch';
4	9	import { addQueryArgs } from '@wordpress/url';
5	10
6	11	export const getActivePlugins = () =>
		@@ -8,9 +13,34 @@
8	13
9	14	export const alreadyActive = (activePlugins, pluginSlug) =>
10	15	activePlugins?.filter((p) => p.includes(pluginSlug))?.length;
11	16
12		-export const installPlugin = async (slug) => {
	17	+// WP unpacks every install through one shared dir; two at once corrupt both.
	18	+let installQueue = Promise.resolve();
	19	+
	20	+// Re-installing is not free: WP unpacks before it finds the folder exists.
	21	+const installed = new Map();
	22	+
	23	+const enqueue = (task) => {
	24	+ const result = installQueue.then(task);
	25	+ installQueue = result.catch(() => {});
	26	+ return result;
	27	+};
	28	+
	29	+const INSTALL_DRAIN_MS = 60_000;
	30	+
	31	+// The install POST has no timeout; uncapped, one stall parks the build.
	32	+const waitForInstalls = () => {
	33	+ let timer;
	34	+ return Promise.race([
	35	+ installQueue,
	36	+ new Promise((resolve) => {
	37	+ timer = setTimeout(resolve, INSTALL_DRAIN_MS);
	38	+ }),
	39	+ ]).finally(() => clearTimeout(timer));
	40	+};
	41	+
	42	+const install = async (slug) => {
13	43	const fn = async () => {
14	44	const p = await apiFetch({
15	45	path: '/wp/v2/plugins',
16	46	method: 'POST',
		@@ -15,10 +45,11 @@
15	45	path: '/wp/v2/plugins',
16	46	method: 'POST',
17	47	data: { slug },
18	48	});
19		- await recordPluginActivity({ slug, source: 'auto-launch' });
20		- await enableAutoUpdate(p?.plugin);
	49	+ // Unawaited: no timeout on these, and a stall would hold the queue.
	50	+ recordPluginActivity({ slug, source: 'auto-launch' });
	51	+ enableAutoUpdate(p?.plugin);
21	52	return p;
22	53	};
23	54	try {
24	55	return await fn();
		@@ -23,23 +54,33 @@
23	54	try {
24	55	return await fn();
25	56	} catch (error) {
26	57	if (error?.code === 'folder_exists') {
27		- console.warn(
28		- `Plugin ${slug} already installed. Attempting to activate...`,
29		- );
30		- // Get the plugin info directly here
	58	+ // Already on disk — fetch its record so the caller can activate it.
31	59	return await getPlugin(slug);
32	60	}
33		- console.error(`Error installing ${slug}. Retrying...`, error);
34	61	try {
35	62	return await fn();
36	63	} catch (error) {
37		- console.error(`Failed ${slug} again. Giving up`, error);
	64	+ digest({
	65	+ error,
	66	+ details: { source: 'auto-launch', caller: 'installPlugin' },
	67	+ });
	68	+ return null;
38	69	}
39	70	}
40	71	};
41	72
	73	+export const installPlugin = (slug) =>
	74	+ enqueue(async () => {
	75	+ const known = installed.get(slug);
	76	+ if (known) return { plugin: known };
	77	+
	78	+ const plugin = await install(slug);
	79	+ if (plugin?.plugin) installed.set(slug, plugin.plugin);
	80	+ return plugin;
	81	+ });
	82	+
42	83	export const getPlugin = async (slug) => {
43	84	const response = await apiFetch({
44	85	path: addQueryArgs('/wp/v2/plugins', { search: slug }),
45	86	});
		@@ -55,20 +96,91 @@
55	96	});
56	97
57	98	try {
58	99	await fn(slug);
59		- } catch (_) {
60		- console.warn(`Error activating ${slug}. Retrying with fresh data...`);
	100	+ return true;
	101	+ } catch (error) {
	102	+ const report = (e) => {
	103	+ digest({
	104	+ error: e,
	105	+ details: { source: 'auto-launch', caller: 'activatePlugin' },
	106	+ });
	107	+ return false;
	108	+ };
	109	+ const found = await getPlugin(slug).catch(() => undefined);
	110	+ if (!found?.plugin) return report(error);
	111	+ return fn(found.plugin).then(() => true, report);
	112	+ }
	113	+};
	114	+
	115	+// Exact match, not substring: woocommerce-payments would mask a missing woocommerce.
	116	+const notActive = (activePlugins, slugs) =>
	117	+ slugs.filter(
	118	+ (slug) => !activePlugins?.some((path) => path.split('/')[0] === slug),
	119	+ );
	120	+
	121	+export const ensurePluginsActive = async (slugs) => {
	122	+ // Two callers don't await this; a throw here silently skips every install.
	123	+ const active = await getActivePlugins().catch((error) => {
	124	+ digest({
	125	+ error,
	126	+ details: { source: 'auto-launch', caller: 'ensurePluginsActive' },
	127	+ });
	128	+ return [];
	129	+ });
	130	+ const missing = notActive(active, slugs);
	131	+ if (!missing.length) return { failed: [] };
	132	+
	133	+ const onDisk = window.extSharedData?.installedPluginsSlugs ?? [];
	134	+ const failed = [];
	135	+ for (const slug of missing) {
61	136	try {
62		- // try once more but get the slug first
63		- const { plugin } = await getPlugin(slug);
64		- await fn(plugin);
65		- } catch (error) {
66		- console.error(`Failed to activate ${slug} again. Giving up`, error);
	137	+ const plugin = onDisk.includes(slug) ? null : await installPlugin(slug);
	138	+ const activated = await activatePlugin(plugin?.plugin ?? slug);
	139	+ if (!activated) failed.push(slug);
	140	+ } catch (_) {
	141	+ failed.push(slug);
67	142	}
68	143	}
	144	+ return { failed };
69	145	};
70	146
	147	+export const reportInactivePlugins = async (slugs) => {
	148	+ // Falling back to an empty list would name every plugin as inactive.
	149	+ const active = await getActivePlugins().catch(() => null);
	150	+ if (!active) return;
	151	+
	152	+ const inactive = notActive(active, slugs);
	153	+ if (!inactive.length) return;
	154	+
	155	+ digest({
	156	+ error: { message: `Plugins inactive after launch: ${inactive.join(', ')}` },
	157	+ details: {
	158	+ source: 'auto-launch',
	159	+ caller: 'reportInactivePlugins',
	160	+ inactive,
	161	+ },
	162	+ });
	163	+};
	164	+
	165	+export const reportFailedDependencies = (pages) => {
	166	+ const failed = [
	167	+ ...new Set(pages.flatMap(({ patterns }) => failedDependencies(patterns))),
	168	+ ];
	169	+ if (!failed.length) return;
	170	+
	171	+ digest({
	172	+ error: {
	173	+ message: `Patterns left static after a failed dependency: ${failed.join(', ')}`,
	174	+ },
	175	+ details: {
	176	+ source: 'auto-launch',
	177	+ caller: 'reportFailedDependencies',
	178	+ failed,
	179	+ },
	180	+ });
	181	+};
	182	+
71	183	// Currently this only processes patterns with placeholders
72	184	// by swapping out the placeholders with the actual code
73	185	// returns the patterns as blocks with the placeholders replaced
74	186	export const replacePlaceholderPatterns = async (patterns) => {
		@@ -103,20 +215,16 @@
103	215	source: 'auto-launch',
104	216	});
105	217	}
106	218
107		- try {
108		- return await processPlaceholders(patterns);
109		- } catch (_e) {
110		- // Try one more time (plugins installed may not be fully loaded)
111		- return await processPlaceholders(patterns)
112		- // If this fails, just return the original patterns
113		- .catch(() => patterns);
114		- }
	219	+ return await processWithSecondPass(processPlaceholders, patterns);
115	220	};
116	221
117		-export const processPlaceholders = (patterns) =>
118		- apiFetch({
	222	+// This endpoint installs pattern dependencies from PHP, outside the queue.
	223	+export const processPlaceholders = async (patterns) => {
	224	+ await waitForInstalls();
	225	+ return apiFetch({
119	226	path: '/extendify/v1/shared/process-placeholders',
120	227	method: 'POST',
121	228	data: { patterns },
122	229	});
	230	+};