PluginProbe
FeedWordPress / 2010.0531
FeedWordPress v2010.0531
trunk 0.8 0.9 0.91 0.95 0.96 0.97 0.98 0.981 0.99 0.991 0.992 0.993 2008.1030 2008.1101 2008.1105 2008.1214 2009.0612 2009.0613 2009.0618 2009.0707 2009.1111 2009.1112 2010.0127 2010.0528 All 65 releases
← All changes | feedwordpress.php +481 -240 2009.11112010.0531 View file →
@@ -2,14 +2,19 @@
2 2 /*
3 3 Plugin Name: FeedWordPress
4 4 Plugin URI: http://feedwordpress.radgeek.com/
5 5 Description: simple and flexible Atom/RSS syndication for WordPress
6 -Version: 2009.1111
6 +Version: 2010.0531
7 7 Author: Charles Johnson
8 8 Author URI: http://radgeek.com/
9 9 License: GPL
10 10 */
11 11
12 +/**
13 + * @package FeedWordPress
14 + * @version 2010.0531
15 + */
16 +
12 17 # This uses code derived from:
13 18 # - wp-rss-aggregate.php by Kellan Elliot-McCrea <kellan@protest.net>
14 19 # - HTTP Navigator 2 by Keyvan Minoukadeh <keyvan@k1m.com>
15 20 # - Ultra-Liberal Feed Finder by Mark Pilgrim <mark@diveintomark.org>
@@ -27,9 +32,9 @@
27 32 # or use a cron job.
28 33
29 34 # -- Don't change these unless you know what you're doing...
30 35
31 -define ('FEEDWORDPRESS_VERSION', '2009.0803');
36 +define ('FEEDWORDPRESS_VERSION', '2010.0531');
32 37 define ('FEEDWORDPRESS_AUTHOR_CONTACT', 'http://radgeek.com/contact');
33 38
34 39 // Defaults
35 40 define ('DEFAULT_SYNDICATION_CATEGORY', 'Contributors');
@@ -59,14 +64,14 @@
59 64 define ('FWP_SCHEMA_25', 7558); // Database schema # for WP 2.5
60 65 define ('FWP_SCHEMA_26', 8201); // Database schema # for WP 2.6
61 66 define ('FWP_SCHEMA_27', 9872); // Database schema # for WP 2.7
62 67 define ('FWP_SCHEMA_28', 11548); // Database schema # for WP 2.8
68 +define ('FWP_SCHEMA_29', 12329); // Database schema # for WP 2.9
63 69
64 70 if (FEEDWORDPRESS_DEBUG) :
65 71 // Help us to pick out errors, if any.
66 72 ini_set('error_reporting', E_ALL & ~E_NOTICE);
67 73 ini_set('display_errors', true);
68 - define('MAGPIE_DEBUG', true);
69 74
70 75 // When testing we don't want cache issues to interfere. But this is
71 76 // a VERY BAD SETTING for a production server. Webmasters will eat your
72 77 // face for breakfast if you use it, and the baby Jesus will cry. So
@@ -71,24 +76,25 @@
71 76 // a VERY BAD SETTING for a production server. Webmasters will eat your
72 77 // face for breakfast if you use it, and the baby Jesus will cry. So
73 78 // make sure FEEDWORDPRESS_DEBUG is FALSE for any site that will be
74 79 // used for more than testing purposes!
75 - define('MAGPIE_CACHE_AGE', 1);
80 + define('FEEDWORDPRESS_CACHE_AGE', 1);
81 + define('FEEDWORDPRESS_CACHE_LIFETIME', 1);
82 + define('FEEDWORDPRESS_FETCH_TIME_OUT', 60);
76 83 else :
77 - define('MAGPIE_DEBUG', false);
78 -
79 - define('MAGPIE_CACHE_AGE', 1*60);
84 + // Hold onto data all day for conditional GET purposes,
85 + // but consider it stale after 1 min (requiring a conditional GET)
86 + define('FEEDWORDPRESS_CACHE_LIFETIME', 24*60*60);
87 + define('FEEDWORDPRESS_CACHE_AGE', 1*60);
88 + define('FEEDWORDPRESS_FETCH_TIME_OUT', 10);
80 89 endif;
81 90
82 -// Note that the rss-functions.php that comes prepackaged with WordPress is
83 -// old & busted. For the new hotness, drop a copy of rss.php from
84 -// this archive into wp-includes/rss.php
91 +// Use our the cache settings that we want.
92 +add_filter('wp_feed_cache_transient_lifetime', array('FeedWordPress', 'cache_lifetime'));
85 93
86 -if (is_readable(ABSPATH . WPINC . '/rss.php')) :
87 - require_once (ABSPATH . WPINC . '/rss.php');
88 -else :
89 - require_once (ABSPATH . WPINC . '/rss-functions.php');
90 -endif;
94 +// Ensure that we have SimplePie loaded up and ready to go.
95 +// We no longer need a MagpieRSS upgrade module. Hallelujah!
96 +require_once(ABSPATH . WPINC . '/feed.php');
91 97
92 98 if (isset($wp_db_version)) :
93 99 if ($wp_db_version >= FWP_SCHEMA_23) :
94 100 require_once (ABSPATH . WPINC . '/registration.php'); // for wp_insert_user
@@ -121,13 +127,20 @@
121 127 else : // Something went wrong. Let's just guess.
122 128 $fwp_path = 'feedwordpress';
123 129 endif;
124 130
131 +function feedwordpress_admin_scripts () {
132 + wp_enqueue_script('post'); // for magic tag and category boxes
133 + wp_enqueue_script('admin-forms'); // for checkbox selection
134 +}
135 +
125 136 // If this is a FeedWordPress admin page, queue up scripts for AJAX functions that FWP uses
126 137 // If it is a display page or a non-FeedWordPress admin page, don't.
127 138 if (is_admin() and isset($_REQUEST['page']) and preg_match("|^{$fwp_path}/|", $_REQUEST['page'])) :
128 139 if (function_exists('wp_enqueue_script')) :
129 - if (isset($wp_db_version) and $wp_db_version >= FWP_SCHEMA_25) :
140 + if (FeedWordPressCompatibility::test_version(FWP_SCHEMA_29)) :
141 + add_action('admin_print_scripts', 'feedwordpress_admin_scripts');
142 + elseif (FeedWordPressCompatibility::test_version(FWP_SCHEMA_25)) :
130 143 wp_enqueue_script('post'); // for magic tag and category boxes
131 144 wp_enqueue_script('thickbox'); // for fold-up boxes
132 145 wp_enqueue_script('admin-forms'); // for checkbox selection
133 146 else :
@@ -168,8 +181,15 @@
168 181
169 182 # Filter in original permalinks if the user wants that
170 183 add_filter('post_link', 'syndication_permalink', 1);
171 184
185 + # When foreign URLs are used for permalinks in feeds or display
186 + # contexts, they need to be escaped properly.
187 + add_filter('the_permalink', 'syndication_permalink_escaped');
188 + add_filter('the_permalink_rss', 'syndication_permalink_escaped');
189 +
190 + add_filter('post_comments_feed_link', 'syndication_comments_feed_link');
191 +
172 192 # WTF? By default, wp_insert_link runs incoming link_url and link_rss
173 193 # URIs through default filters that include `wp_kses()`. But `wp_kses()`
174 194 # just happens to escape any occurrence of & to &amp; -- which just
175 195 # happens to fuck up any URI with a & to separate GET parameters.
@@ -178,11 +198,14 @@
178 198
179 199 # Admin menu
180 200 add_action('admin_menu', 'fwp_add_pages');
181 201 add_action('admin_notices', 'fwp_check_debug');
182 - add_action('admin_notices', 'fwp_check_magpie');
183 - add_action('init', 'feedwordpress_check_for_magpie_fix');
184 202
203 + add_action('admin_menu', 'feedwordpress_add_post_edit_controls');
204 + add_action('save_post', 'feedwordpress_save_post_edit_controls');
205 +
206 + add_action('admin_footer', array('FeedWordPress', 'admin_footer'));
207 +
185 208 # Inbound XML-RPC update methods
186 209 add_filter('xmlrpc_methods', 'feedwordpress_xmlrpc_hook');
187 210
188 211 # Outbound XML-RPC ping reform
@@ -204,14 +227,18 @@
204 227 add_action('feedwordpress_check_feed', 'log_feedwordpress_check_feed', 100);
205 228 add_action('feedwordpress_update_complete', 'log_feedwordpress_update_complete', 100);
206 229 endif;
207 230
208 - if (FeedWordPress::update_requested() and FEEDWORDPRESS_DEBUG) :
209 - add_action('post_syndicated_item', 'debug_out_feedwordpress_post', 100);
210 - add_action('update_syndicated_item', 'debug_out_feedwordpress_update_post', 100);
211 - add_action('feedwordpress_update', 'debug_out_feedwordpress_update_feeds', 100);
212 - add_action('feedwordpress_check_feed', 'debug_out_feedwordpress_check_feed', 100);
213 - add_action('feedwordpress_update_complete', 'debug_out_feedwordpress_update_complete', 100);
231 + if (FeedWordPress::update_requested()) :
232 + if (FEEDWORDPRESS_DEBUG) :
233 + add_action('post_syndicated_item', 'debug_out_feedwordpress_post', 100);
234 + add_action('update_syndicated_item', 'debug_out_feedwordpress_update_post', 100);
235 + add_action('feedwordpress_update', 'debug_out_feedwordpress_update_feeds', 100);
236 + add_action('feedwordpress_check_feed', 'debug_out_feedwordpress_check_feed', 100);
237 + add_action('feedwordpress_update_complete', 'debug_out_feedwordpress_update_complete', 100);
238 + endif;
239 +
240 + add_action('feedwordpress_check_feed_complete', 'debug_out_feedwordpress_feed_error', 100, 3);
214 241 endif;
215 242
216 243 # Cron-less auto-update. Hooray!
217 244 $autoUpdateHook = get_option('feedwordpress_automatic_updates');
@@ -230,55 +257,44 @@
230 257 # Hook in the menus, which will just point to the upgrade interface
231 258 add_action('admin_menu', 'fwp_add_pages');
232 259 endif; // if (!FeedWordPress::needs_upgrade())
233 260
234 -function feedwordpress_check_for_magpie_fix () {
235 - if (isset($_POST['action']) and $_POST['action']=='fix_magpie_version') :
236 - FeedWordPressCompatibility::validate_http_request(/*action=*/ 'feedwordpress_fix_magpie', /*capability=*/ 'edit_files');
237 -
238 - $back_to = $_SERVER['REQUEST_URI'];
239 - if (isset($_POST['ignore'])) :
240 - // kill error message by telling it we ignored the upgrade request for this version
241 - update_option('feedwordpress_magpie_ignored_upgrade_to', EXPECTED_MAGPIE_VERSION);
242 - $ret = 'ignored';
243 - elseif (isset($_POST['upgrade'])) :
244 - $source = dirname(__FILE__)."/MagpieRSS-upgrade/rss.php";
245 - $destination = ABSPATH . WPINC . '/rss.php';
246 - $success = @copy($source, $destination);
247 -
248 - // Copy over rss-functions.php, too, to avoid collisions
249 - // on pre-lapsarian versions of WordPress.
250 - if ($success) :
251 - $source = dirname(__FILE__)."/MagpieRSS-upgrade/rss-functions.php";
252 - $destination = ABSPATH . WPINC . '/rss-functions.php';
253 - $success = @copy($source, $destination);
254 - endif;
255 - $ret = (int) $success;
256 - endif;
257 -
258 - if (strpos($back_to, '?')===false) : $sep = '?';
259 - else : $sep = '&';
260 - endif;
261 -
262 - header("Location: {$back_to}{$sep}feedwordpress_magpie_fix=".$ret);
263 - exit;
264 - endif;
265 -} /* feedwordpress_check_for_magpie_fix() */
266 -
267 261 function feedwordpress_auto_update () {
268 262 if (FeedWordPress::stale()) :
269 - $feedwordpress =& new FeedWordPress;
263 + $feedwordpress = new FeedWordPress;
270 264 $feedwordpress->update();
271 265 endif;
272 266 } /* feedwordpress_auto_update () */
273 267
274 268 function feedwordpress_update_magic_url () {
269 + global $wpdb;
270 +
275 271 // Explicit update request in the HTTP request (e.g. from a cron job)
276 272 if (FeedWordPress::update_requested()) :
277 - $feedwordpress =& new FeedWordPress;
273 + $feedwordpress = new FeedWordPress;
278 274 $feedwordpress->update(FeedWordPress::update_requested_url());
279 275
280 - // Magic URL should return nothing but a 200 OK header packet
276 + if (FEEDWORDPRESS_DEBUG and count($wpdb->queries) > 0) :
277 + $mysqlTime = 0.0;
278 + $byTime = array();
279 + foreach ($wpdb->queries as $query) :
280 + $time = $query[1] * 1000000.0;
281 + $mysqlTime += $query[1];
282 + if (!isset($byTime[$time])) : $byTime[$time] = array(); endif;
283 + $byTime[$time][] = $query[0]. ' // STACK: ' . $query[2];
284 + endforeach;
285 + krsort($byTime);
286 +
287 + foreach ($byTime as $time => $querySet) :
288 + foreach ($querySet as $query) :
289 + print "[".(sprintf('%4.4f', $time/1000.0)) . "ms] $query\n";
290 + endforeach;
291 + endforeach;
292 + echo "[feedwordpress] $wpdb->num_queries queries. $mysqlTime seconds in MySQL. Total of "; timer_stop(1); print " seconds.";
293 + endif;
294 +
295 +
296 + // Magic URL should return nothing but a 200 OK header packet
281 297 // when successful.
282 298 exit;
283 299 endif;
284 300 } /* feedwordpress_magic_update_url () */
@@ -352,13 +368,33 @@
352 368 .(is_null($delta) ? "Error: I don't syndicate that URI"
353 369 : implode(' and ', $mesg))."\n");
354 370 }
355 371
372 +function debug_out_feedwordpress_feed_error ($feed, $added, $dt) {
373 + if (is_wp_error($added)) :
374 + $mesgs = $added->get_error_messages();
375 + foreach ($mesgs as $mesg) :
376 + echo "[feedwordpress] Error updating [{$feed['link/uri']}]: $mesg\n";
377 + endforeach;
378 + endif;
379 +}
380 +
356 381 ################################################################################
357 382 ## TEMPLATE API: functions to make your templates syndication-aware ############
358 383 ################################################################################
359 384
360 -function is_syndicated ($id = NULL) { return (strlen(get_syndication_feed_id($id)) > 0); }
385 +/**
386 + * is_syndicated: Tests whether the current post in a Loop context, or a post
387 + * given by ID number, was syndicated by FeedWordPress. Useful for templates
388 + * to determine whether or not to retrieve syndication-related meta-data in
389 + * displaying a post.
390 + *
391 + * @param int $id The post to check for syndicated status. Defaults to the current post in a Loop context.
392 + * @return bool TRUE if the post's meta-data indicates it was syndicated; FALSE otherwise
393 + */
394 +function is_syndicated ($id = NULL) {
395 + return (strlen(get_syndication_feed_id($id)) > 0);
396 +} /* function is_syndicated() */
361 397
362 398 function get_syndication_source_link ($original = NULL, $id = NULL) {
363 399 if (is_null($original)) : $original = FeedWordPress::use_aggregator_source_data();
364 400 endif;
@@ -388,8 +424,9 @@
388 424 // Reassemble bit-by-bit with minimum of crufty elements
389 425 $url = (isset($bits['user'])?$bits['user'].'@':'')
390 426 .(isset($bits['host'])?$bits['host']:'')
391 427 .(isset($bits['path'])?$bits['path']:'')
428 + .(isset($uri_bits['port'])?':'.$uri_bits['port']:'')
392 429 .(isset($bits['query'])?'?'.$bits['query']:'');
393 430
394 431 if (strlen($url) > ($before+$after)) :
395 432 $url = substr($url, 0, $before).'…'.substr($url, 0 - $after, $after);
@@ -468,22 +505,30 @@
468 505 function get_syndication_feed_id ($id = NULL) { list($u) = get_post_custom_values('syndication_feed_id', $id); return $u; }
469 506 function the_syndication_feed_id ($id = NULL) { echo get_syndication_feed_id($id); }
470 507
471 508 $feedwordpress_linkcache = array (); // only load links from database once
509 +function get_syndication_feed_object ($id = NULL) {
510 + global $feedwordpress_linkcache;
472 511
473 -function get_feed_meta ($key, $id = NULL) {
474 - global $wpdb, $feedwordpress_linkcache;
512 + $link = NULL;
513 +
475 514 $feed_id = get_syndication_feed_id($id);
476 -
477 - $ret = NULL;
478 515 if (strlen($feed_id) > 0):
479 516 if (isset($feedwordpress_linkcache[$feed_id])) :
480 517 $link = $feedwordpress_linkcache[$feed_id];
481 518 else :
482 - $link =& new SyndicatedLink($feed_id);
519 + $link = new SyndicatedLink($feed_id);
483 520 $feedwordpress_linkcache[$feed_id] = $link;
484 521 endif;
522 + endif;
523 + return $link;
524 +}
485 525
526 +function get_feed_meta ($key, $id = NULL) {
527 + $ret = NULL;
528 +
529 + $link = get_syndication_feed_object($id);
530 + if (is_object($link) and isset($link->settings[$key])) :
486 531 $ret = $link->settings[$key];
487 532 endif;
488 533 return $ret;
489 534 } /* get_feed_meta() */
@@ -494,13 +539,55 @@
494 539 function the_syndication_permalink ($id = NULL) {
495 540 echo get_syndication_permalink($id);
496 541 }
497 542
543 +/**
544 + * get_local_permalink: returns a string containing the internal permalink
545 + * for a post (whether syndicated or not) on your local WordPress installation.
546 + * This may be useful if you want permalinks to point to the original source of
547 + * an article for most purposes, but want to retrieve a URL for the local
548 + * representation of the post for one or two limited purposes (for example,
549 + * linking to a comments page on your local aggregator site).
550 + *
551 + * @param $id The numerical ID of the post to get the permalink for. If empty,
552 + * defaults to the current post in a Loop context.
553 + * @return string The URL of the local permalink for this post.
554 + *
555 + * @uses get_permalink()
556 + * @global $feedwordpress_the_original_permalink
557 + *
558 + * @since 2010.0217
559 + */
560 +function get_local_permalink ($id = NULL) {
561 + global $feedwordpress_the_original_permalink;
562 +
563 + // get permalink, and thus activate filter and force global to be filled
564 + // with original URL.
565 + $url = get_permalink($id);
566 + return $feedwordpress_the_original_permalink;
567 +} /* get_local_permalink() */
568 +
569 +/**
570 + * the_original_permalink: displays the contents of get_original_permalink()
571 + *
572 + * @param $id The numerical ID of the post to get the permalink for. If empty,
573 + * defaults to the current post in a Loop context.
574 + *
575 + * @uses get_local_permalinks()
576 + * @uses apply_filters
577 + *
578 + * @since 2010.0217
579 + */
580 +function the_local_permalink ($id = NULL) {
581 + print apply_filters('the_permalink', get_local_permalink($id));
582 +} /* function the_local_permalink() */
583 +
498 584 ################################################################################
499 585 ## FILTERS: syndication-aware handling of post data for templates and feeds ####
500 586 ################################################################################
501 587
502 588 $feedwordpress_the_syndicated_content = NULL;
589 +$feedwordpress_the_original_permalink = NULL;
503 590
504 591 function feedwordpress_preserve_syndicated_content ($text) {
505 592 global $feedwordpress_the_syndicated_content;
506 593
@@ -530,16 +617,16 @@
530 617 // In a post context....
531 618 if (is_syndicated()) :
532 619 ?>
533 620 <source>
534 - <title><?php the_syndication_source(); ?></title>
535 - <link rel="alternate" type="text/html" href="<?php the_syndication_source_link(); ?>" />
536 - <link rel="self" href="<?php the_syndication_feed(); ?>" />
621 + <title><?php print htmlspecialchars(get_syndication_source()); ?></title>
622 + <link rel="alternate" type="text/html" href="<?php print htmlspecialchars(get_syndication_source_link()); ?>" />
623 + <link rel="self" href="<?php print htmlspecialchars(get_syndication_feed()); ?>" />
537 624 <?php
538 625 $id = get_syndication_feed_guid();
539 626 if (strlen($id) > 0) :
540 627 ?>
541 - <id><?php print $id; ?></id>
628 + <id><?php print htmlspecialchars($id); ?></id>
542 629 <?php
543 630 endif;
544 631 $updated = get_feed_meta('feed/updated');
545 632 if (strlen($updated) > 0) : ?>
@@ -551,17 +638,131 @@
551 638 <?php
552 639 endif;
553 640 }
554 641
642 +/**
643 + * syndication_permalink: Allow WordPress to use the original remote URL of
644 + * syndicated posts as their permalink. Can be turned on or off by by setting in
645 + * Syndication => Posts & Links. Saves the old internal permalink in a global
646 + * variable for later use.
647 + *
648 + * @param string $permalink The internal permalink
649 + * @return string The new permalink. Same as the old if the post is not
650 + * syndicated, or if FWP is set to use internal permalinks, or if the post
651 + * was syndicated, but didn't have a proper permalink recorded.
652 + *
653 + * @uses FeedWordPress::munge_permalinks()
654 + * @uses get_syndication_permalink()
655 + * @global $feedwordpress_the_original_permalink
656 + */
555 657 function syndication_permalink ($permalink = '') {
556 - if (get_option('feedwordpress_munge_permalink') != 'no'):
557 - $uri = get_syndication_permalink();
558 - return ((strlen($uri) > 0) ? $uri : $permalink);
559 - else:
560 - return $permalink;
658 + global $feedwordpress_the_original_permalink;
659 +
660 + // Save the local permalink in case we need to retrieve it later.
661 + $feedwordpress_the_original_permalink = $permalink;
662 +
663 + // Map this permalink to a post ID so we can get the correct permalink
664 + // even outside of the Post Loop. Props Björn.
665 + $id = url_to_postid($permalink);
666 +
667 + $munge = false;
668 + $link = get_syndication_feed_object($id);
669 + if (is_object($link)) :
670 + $munge = ($link->setting('munge permalink', 'munge_permalink', 'yes') != 'no');
561 671 endif;
562 -} // function syndication_permalink ()
563 672
673 + if ($munge):
674 + $uri = get_syndication_permalink($id);
675 + $permalink = ((strlen($uri) > 0) ? $uri : $permalink);
676 + endif;
677 + return $permalink;
678 +} /* function syndication_permalink () */
679 +
680 +/**
681 + * syndication_permalink_escaped: Escape XML special characters in syndicated
682 + * permalinks when used in feed contexts and HTML display contexts.
683 + *
684 + * @param string $permalink
685 + * @return string
686 + *
687 + * @uses is_syndicated()
688 + * @uses FeedWordPress::munge_permalinks()
689 + *
690 + */
691 +function syndication_permalink_escaped ($permalink) {
692 + if (is_syndicated() and FeedWordPress::munge_permalinks()) :
693 + // This is a foreign link; WordPress can't vouch for its not
694 + // having any entities that need to be &-escaped. So we'll do
695 + // it here.
696 + $permalink = esc_html($permalink);
697 + endif;
698 + return $permalink;
699 +} /* function syndication_permalink_escaped() */
700 +
701 +/**
702 + * syndication_comments_feed_link: Escape XML special characters in comments
703 + * feed links
704 + *
705 + * @param string $link
706 + * @return string
707 + *
708 + * @uses is_syndicated()
709 + * @uses FeedWordPress::munge_permalinks()
710 + */
711 +function syndication_comments_feed_link ($link) {
712 + global $feedwordpress_the_original_permalink, $id;
713 +
714 + if (is_syndicated() and FeedWordPress::munge_permalinks()) :
715 + // If the source post provided a comment feed URL using
716 + // wfw:commentRss or atom:link/@rel="replies" we can make use of
717 + // that value here.
718 + $source = get_syndication_feed_object();
719 + $replacement = NULL;
720 + if ($source->setting('munge comments feed links', 'munge_comments_feed_links', 'yes') != 'no') :
721 + $commentFeeds = get_post_custom_values('wfw:commentRSS');
722 + if (
723 + is_array($commentFeeds)
724 + and (count($commentFeeds) > 0)
725 + and (strlen($commentFeeds[0]) > 0)
726 + ) :
727 + $replacement = $commentFeeds[0];
728 +
729 + // This is a foreign link; WordPress can't vouch for its not
730 + // having any entities that need to be &-escaped. So we'll do it
731 + // here.
732 + $replacement = esc_html($replacement);
733 + endif;
734 + endif;
735 +
736 + if (is_null($replacement)) :
737 + // Q: How can we get the proper feed format, since the
738 + // format is, stupidly, not passed to the filter?
739 + // A: Kludge kludge kludge kludge!
740 + $fancy_permalinks = ('' != get_option('permalink_structure'));
741 + if ($fancy_permalinks) :
742 + preg_match('|/feed(/([^/]+))?/?$|', $link, $ref);
743 +
744 + $format = (isset($ref[2]) ? $ref[2] : '');
745 + if (strlen($format) == 0) : $format = get_default_feed(); endif;
746 +
747 + $replacement = trailingslashit($feedwordpress_the_original_permalink) . 'feed';
748 + if ($format != get_default_feed()) :
749 + $replacement .= '/'.$format;
750 + endif;
751 + $replacement = user_trailingslashit($replacement, 'single_feed');
752 + else :
753 + // No fancy permalinks = no problem
754 + // WordPress doesn't call get_permalink() to
755 + // generate the comment feed URL, so the
756 + // comments feed link is never munged by FWP.
757 + endif;
758 + endif;
759 +
760 + if (!is_null($replacement)) : $link = $replacement; endif;
761 + endif;
762 + return $link;
763 +} /* function syndication_comments_feed_link() */
764 +
564 765 ################################################################################
565 766 ## ADMIN MENU ADD-ONS: register Dashboard management pages #####################
566 767 ################################################################################
567 768
@@ -579,9 +780,10 @@
579 780 add_submenu_page($fwp_path.'/syndication.php', 'Syndicated Feeds & Updates', 'Feeds & Updates', $fwp_capability['manage_options'], $fwp_path.'/feeds-page.php');
580 781 add_submenu_page($fwp_path.'/syndication.php', 'Syndicated Posts & Links', 'Posts & Links', $fwp_capability['manage_options'], $fwp_path.'/posts-page.php');
581 782 add_submenu_page($fwp_path.'/syndication.php', 'Syndicated Authors', 'Authors', $fwp_capability['manage_options'], $fwp_path.'/authors-page.php');
582 783 add_submenu_page($fwp_path.'/syndication.php', 'Categories'.FEEDWORDPRESS_AND_TAGS, 'Categories'.FEEDWORDPRESS_AND_TAGS, $fwp_capability['manage_options'], $fwp_path.'/categories-page.php');
583 - add_submenu_page($fwp_path.'/syndication.php', 'FeedWordPress Back End', 'Back End', $fwp_capability['manage_options'], $fwp_path.'/backend-page.php');
784 + add_submenu_page($fwp_path.'/syndication.php', 'FeedWordPress Performance', 'Performance', $fwp_capability['manage_options'], $fwp_path.'/performance-page.php');
785 + add_submenu_page($fwp_path.'/syndication.php', 'FeedWordPress Diagnostics', 'Diagnostics', $fwp_capability['manage_options'], $fwp_path.'/diagnostics-page.php');
584 786 } /* function fwp_add_pages () */
585 787
586 788 function fwp_check_debug () {
587 789 // This is a horrible fucking kludge that I have to do because the
@@ -604,97 +806,8 @@
604 806 <?php
605 807 endif;
606 808 } /* function fwp_check_debug () */
607 809
608 -define('EXPECTED_MAGPIE_VERSION', '2009.0725');
609 -function fwp_check_magpie () {
610 - if (isset($_REQUEST['feedwordpress_magpie_fix'])) :
611 - if ($_REQUEST['feedwordpress_magpie_fix']=='ignored') :
612 -?>
613 -<div class="updated fade">
614 -<p>O.K., we'll ignore the problem for now. FeedWordPress will not display any
615 -more error messages.</p>
616 -</div>
617 -<?php
618 - elseif ((bool) $_REQUEST['feedwordpress_magpie_fix']) :
619 -?>
620 -<div class="updated fade">
621 -<p>Congratulations! Your MagpieRSS has been successfully upgraded to the version
622 -shipped with FeedWordPress.</p>
623 -</div>
624 -<?php
625 - else :
626 - $source = dirname(__FILE__)."/MagpieRSS-upgrade/rss.php";
627 - $destination = ABSPATH . WPINC . '/rss.php';
628 - $cmd = "cp '".htmlspecialchars(addslashes($source))."' '".htmlspecialchars(addslashes($destination))."'";
629 - $cmd = wordwrap($cmd, /*width=*/ 75, /*break=*/ " \\\n\t");
630 -
631 -?>
632 -<div class="error">
633 -<p><strong>FeedWordPress was unable to automatically upgrade your copy of MagpieRSS.</strong></p>
634 -<p>It's likely that you need to change the file permissions on <code><?php print htmlspecialchars($source); ?></code>
635 -to allow FeedWordPress to overwrite it.</p>
636 -<p><strong>To perform the upgrade manually,</strong> you can
637 -use a SFTP or FTP client to upload a copy of <code>rss.php</code> from the
638 -<code>MagpieRSS-upgrades/</code> directory of your FeedWordPress archive so that
639 -it overwrites <code><?php print htmlspecialchars($destination); ?></code>. Or,
640 -if your web host provides shell access, you can issue the following command from
641 -a command prompt to perform the upgrade:</p>
642 -<pre>
643 -<samp>$</samp> <kbd><?php print $cmd; ?></kbd>
644 -</pre>
645 -<p><strong>If you've fixed the file permissions,</strong> you can try the
646 -automatic upgrade again.</p>
647 -
648 -<?php feedwordpress_upgrade_old_and_busted_buttons(); ?>
649 -</div>
650 -<?php
651 - endif;
652 - else :
653 - $magpie_version = FeedWordPress::magpie_version();
654 -
655 - $ignored = get_option('feedwordpress_magpie_ignored_upgrade_to');
656 - if (EXPECTED_MAGPIE_VERSION != $magpie_version and EXPECTED_MAGPIE_VERSION != $ignored) :
657 - if (current_user_can('edit_files')) :
658 - $youAre = 'you are';
659 - $itIsRecommendedThatYou = 'It is <strong>strongly recommended</strong> that you';
660 - else :
661 - $youAre = 'this site is';
662 - $itIsRecommendedThatYou = 'You may want to contact the administrator of the site; it is <strong>strongly recommended</strong> that they';
663 - endif;
664 - print '<div class="error">';
665 -?>
666 -<p style="font-style: italic"><strong>FeedWordPress has detected that <?php print $youAre; ?> currently using a version of
667 -MagpieRSS other than the upgraded version that ships with this version of FeedWordPress.</strong></p>
668 -<ul>
669 -<li><strong>Currently running:</strong> MagpieRSS <?php print $magpie_version; ?></li>
670 -<li><strong>Version included with FeedWordPress <?php print FEEDWORDPRESS_VERSION; ?>:</strong> MagpieRSS <?php print EXPECTED_MAGPIE_VERSION; ?></li>
671 -</ul>
672 -<p><?php print $itIsRecommendedThatYou; ?> install the upgraded
673 -version of MagpieRSS supplied with FeedWordPress. The version of
674 -MagpieRSS that ships with WordPress is very old and buggy, and
675 -encounters a number of errors when trying to parse modern Atom
676 -and RSS feeds.</p>
677 -<?php
678 - feedwordpress_upgrade_old_and_busted_buttons();
679 - print '</div>';
680 - endif;
681 - endif;
682 -}
683 -
684 -function feedwordpress_upgrade_old_and_busted_buttons() {
685 - if (current_user_can('edit_files')) :
686 -?>
687 -<form action="" method="post"><div>
688 -<?php FeedWordPressCompatibility::stamp_nonce('feedwordpress_fix_magpie'); ?>
689 -<input type="hidden" name="action" value="fix_magpie_version" />
690 -<input class="button-secondary" type="submit" name="ignore" value="<?php _e('Ignore this problem'); ?>" />
691 -<input class="button-primary" type="submit" name="upgrade" value="<?php _e('Upgrade'); ?>" />
692 -</div></form>
693 -<?php
694 - endif;
695 -}
696 -
697 810 ################################################################################
698 811 ## fwp_hold_pings() and fwp_release_pings(): Outbound XML-RPC ping reform ####
699 812 ## ... 'coz it's rude to send 500 pings the first time your aggregator runs ####
700 813 ################################################################################
@@ -750,8 +863,67 @@
750 863 endif;
751 864 endif;
752 865 }
753 866
867 + function feedwordpress_add_post_edit_controls () {
868 + add_meta_box('feedwordpress-post-controls', __('Syndication'), 'feedwordpress_post_edit_controls', 'post', 'side', 'high');
869 + } // function FeedWordPress::postEditControls
870 +
871 + function feedwordpress_post_edit_controls () {
872 + global $post;
873 +
874 + $frozen_values = get_post_custom_values('_syndication_freeze_updates', $post->ID);
875 + $frozen_post = (count($frozen_values) > 0 and 'yes' == $frozen_values[0]);
876 +
877 + if (is_syndicated($post->ID)) :
878 + ?>
879 + <p>This is a syndicated post, which originally appeared at
880 + <cite><?php print esc_html(get_syndication_source(NULL, $post->ID)); ?></cite>.
881 + <a href="<?php print esc_html(get_syndication_permalink($post->ID)); ?>">View original post</a>.</p>
882 +
883 + <p><input type="hidden" name="feedwordpress_noncename" id="feedwordpress_noncename" value="<?php print wp_create_nonce(plugin_basename(__FILE__)); ?>" />
884 + <label><input type="checkbox" name="freeze_updates" value="yes" <?php if ($frozen_post) : ?>checked="checked"<?php endif; ?> /> <strong>Manual editing.</strong>
885 + If set, FeedWordPress will not overwrite the changes you make manually
886 + to this post, if the syndicated content is updated on the
887 + feed.</label></p>
888 + <?php
889 + else :
890 + ?>
891 + <p>This post was created locally at this website.</p>
892 + <?php
893 + endif;
894 + } // function feedwordpress_post_edit_controls () */
895 +
896 + function feedwordpress_save_post_edit_controls ( $post_id ) {
897 + global $post;
898 +
899 + if (!isset($_POST['feedwordpress_noncename']) or !wp_verify_nonce($_POST['feedwordpress_noncename'], plugin_basename(__FILE__))) :
900 + return $post_id;
901 + endif;
902 +
903 + // Verify if this is an auto save routine. If it is our form has
904 + // not been submitted, so we don't want to do anything.
905 + if ( defined('DOING_AUTOSAVE') and DOING_AUTOSAVE ) :
906 + return $post_id;
907 + endif;
908 +
909 + // Check permissions
910 + if ( !current_user_can( 'edit_'.$_POST['post_type'], $post_id) ) :
911 + return $post_id;
912 + endif;
913 +
914 + // OK, we're golden. Now let's save some data.
915 + if (isset($_POST['freeze_updates'])) :
916 + update_post_meta($post_id, '_syndication_freeze_updates', $_POST['freeze_updates']);
917 + $ret = $_POST['freeze_updates'];
918 + else :
919 + delete_post_meta($post_id, '_syndication_freeze_updates');
920 + $ret = NULL;
921 + endif;
922 +
923 + return $ret;
924 + } // function feedwordpress_save_edit_controls
925 +
754 926 ################################################################################
755 927 ## class FeedWordPress #########################################################
756 928 ################################################################################
757 929
@@ -795,9 +967,9 @@
795 967 function FeedWordPress () {
796 968 $this->feeds = array ();
797 969 $links = FeedWordPress::syndicated_links();
798 970 if ($links): foreach ($links as $link):
799 - $this->feeds[] =& new SyndicatedLink($link);
971 + $this->feeds[] = new SyndicatedLink($link);
800 972 endforeach; endif;
801 973 } // FeedWordPress::FeedWordPress ()
802 974
803 975 # function update (): polls for updates on one or more Contributor feeds
@@ -901,10 +1073,12 @@
901 1073 $start_ts = time();
902 1074 $added = $feed->poll($crash_ts);
903 1075 do_action('feedwordpress_check_feed_complete', $feed->settings, $added, time() - $start_ts);
904 1076
905 - if (isset($added['new'])) : $delta['new'] += $added['new']; endif;
906 - if (isset($added['updated'])) : $delta['updated'] += $added['updated']; endif;
1077 + if (is_array($added)) : // Success
1078 + if (isset($added['new'])) : $delta['new'] += $added['new']; endif;
1079 + if (isset($added['updated'])) : $delta['updated'] += $added['updated']; endif;
1080 + endif;
907 1081 endif;
908 1082 endforeach;
909 1083
910 1084 do_action('feedwordpress_update_complete', $delta);
@@ -1019,8 +1193,10 @@
1019 1193 );
1020 1194
1021 1195 if (is_string($override)) :
1022 1196 $ret = strtolower($override);
1197 + else :
1198 + $ret = NULL;
1023 1199 endif;
1024 1200
1025 1201 if (!is_numeric($override) and !in_array($ret, $set[$what])) :
1026 1202 $ret = get_option('feedwordpress_unfamiliar_'.$what);
@@ -1056,8 +1232,19 @@
1056 1232 $ret = get_option('feedwordpress_use_aggregator_source_data');
1057 1233 return apply_filters('syndicated_post_use_aggregator_source_data', ($ret=='yes'));
1058 1234 }
1059 1235
1236 + /**
1237 + * FeedWordPress::munge_permalinks: check whether or not FeedWordPress
1238 + * should rewrite permalinks for syndicated items to reflect their
1239 + * original location.
1240 + *
1241 + * @return bool TRUE if FeedWordPress SHOULD rewrite permalinks; FALSE otherwise
1242 + */
1243 + /*static*/ function munge_permalinks () {
1244 + return (get_option('feedwordpress_munge_permalink', /*default=*/ 'yes') != 'no');
1245 + } /* FeedWordPress::munge_permalinks() */
1246 +
1060 1247 function syndicated_links () {
1061 1248 $contributors = FeedWordPress::link_category_id();
1062 1249 if (function_exists('get_bookmarks')) :
1063 1250 $links = get_bookmarks(array("category" => $contributors));
@@ -1141,58 +1328,14 @@
1141 1328
1142 1329 if (is_null($from) or $from <= 0.96) : $from = 0.96; endif;
1143 1330
1144 1331 switch ($from) :
1145 - case 0.96: // account for changes to syndication custom values and guid
1146 - echo "<p>Upgrading database from {$from} to ".FEEDWORDPRESS_VERSION."...</p>\n";
1332 + case 0.96:
1333 + // Dropping legacy upgrade code. If anyone is still
1334 + // using 0.96 and just now decided to upgrade, well, I'm
1335 + // sorry about that. You'll just have to cope with a few
1336 + // duplicate posts.
1147 1337
1148 - $cat_id = FeedWordPress::link_category_id();
1149 -
1150 - // Avoid duplicates
1151 - $wpdb->query("DELETE FROM `{$wpdb->postmeta}` WHERE meta_key = 'syndication_feed_id'");
1152 -
1153 - // Look up all the link IDs
1154 - $wpdb->query("
1155 - CREATE TEMPORARY TABLE tmp_custom_values
1156 - SELECT
1157 - NULL AS meta_id,
1158 - post_id,
1159 - 'syndication_feed_id' AS meta_key,
1160 - link_id AS meta_value
1161 - FROM `{$wpdb->postmeta}`, `{$wpdb->links}`
1162 - WHERE
1163 - meta_key='syndication_feed'
1164 - AND meta_value=link_rss
1165 - AND link_category = {$cat_id}
1166 - ");
1167 -
1168 - // Now attach them to their posts
1169 - $wpdb->query("INSERT INTO `{$wpdb->postmeta}` SELECT * FROM tmp_custom_values");
1170 -
1171 - // And clean up after ourselves.
1172 - $wpdb->query("DROP TABLE tmp_custom_values");
1173 -
1174 - // Now fix the guids to avoid duplicate posts
1175 - echo "<ul>";
1176 - foreach ($this->feeds as $syndicatedLink) :
1177 - $feed = $syndicatedLink->settings;
1178 - echo "<li>Fixing post meta-data for <cite>".$feed['link/name']."</cite> &#8230; "; flush();
1179 - $rss = @fetch_rss($feed['link/uri']);
1180 - if (is_array($rss->items)) :
1181 - foreach ($rss->items as $item) :
1182 - $post = new SyndicatedPost($item, $syndicatedLink);
1183 - $guid = $wpdb->escape($post->guid()); // new GUID algorithm
1184 - $link = $wpdb->escape($item['link']);
1185 -
1186 - $wpdb->query("
1187 - UPDATE `{$wpdb->posts}` SET guid='{$guid}' WHERE guid='{$link}'
1188 - ");
1189 - endforeach;
1190 - endif;
1191 - echo "<strong>complete.</strong></li>\n";
1192 - endforeach;
1193 - echo "</ul>\n";
1194 -
1195 1338 // Mark the upgrade as successful.
1196 1339 update_option('feedwordpress_version', FEEDWORDPRESS_VERSION);
1197 1340 endswitch;
1198 1341 echo "<p>Upgrade complete. FeedWordPress is now ready to use again.</p>";
@@ -1197,8 +1340,27 @@
1197 1340 endswitch;
1198 1341 echo "<p>Upgrade complete. FeedWordPress is now ready to use again.</p>";
1199 1342 } /* FeedWordPress::upgrade_database() */
1200 1343
1344 + function has_guid_index () {
1345 + global $wpdb;
1346 +
1347 + $found = false; // Guilty until proven innocent.
1348 +
1349 + $results = $wpdb->get_results("
1350 + SHOW INDEXES FROM {$wpdb->posts}
1351 + ");
1352 + if ($results) :
1353 + foreach ($results as $index) :
1354 + if (isset($index->Column_name)
1355 + and ('guid' == $index->Column_name)) :
1356 + $found = true;
1357 + endif;
1358 + endforeach;
1359 + endif;
1360 + return $found;
1361 + } /* FeedWordPress::has_guid_index () */
1362 +
1201 1363 function create_guid_index () {
1202 1364 global $wpdb;
1203 1365
1204 1366 $wpdb->query("
@@ -1205,29 +1367,72 @@
1205 1367 CREATE INDEX {$wpdb->posts}_guid_idx ON {$wpdb->posts}(guid)
1206 1368 ");
1207 1369 } /* FeedWordPress::create_guid_index () */
1208 1370
1371 + function remove_guid_index () {
1372 + global $wpdb;
1373 +
1374 + $wpdb->query("
1375 + DROP INDEX {$wpdb->posts}_guid_idx ON {$wpdb->posts}
1376 + ");
1377 + }
1378 +
1379 + /*static*/ function fetch ($url) {
1380 + require_once (ABSPATH . WPINC . '/class-feed.php');
1381 + $feed = new SimplePie();
1382 + $feed->set_feed_url($url);
1383 + $feed->set_cache_class('WP_Feed_Cache');
1384 + $feed->set_file_class('WP_SimplePie_File');
1385 + $feed->set_cache_duration(FeedWordPress::cache_duration());
1386 + $feed->init();
1387 + $feed->handle_content_type();
1388 +
1389 + if ($feed->error()) :
1390 + $ret = new WP_Error('simplepie-error', $feed->error());
1391 + else :
1392 + $ret = $feed;
1393 + endif;
1394 + return $ret;
1395 + } /* FeedWordPress::fetch () */
1396 +
1209 1397 function clear_cache () {
1210 1398 global $wpdb;
1211 1399
1212 - // MagpieRSS stores its cached feeds in options table rows with
1213 - // name = `rss_{md5 of url}` and timestamps for cached feeds in
1214 - // table rows with name = `rss_{md5 of url}_ts`. The md5 is
1215 - // always 32 characters in length, so the total option_name is
1216 - // always over 32 characters.
1217 - $wpdb->query("
1400 + // The WordPress SimplePie module stores its cached feeds as
1401 + // transient records in the options table. The data itself is
1402 + // stored in `_transient_feed_{md5 of url}` and the last-modified
1403 + // timestamp in `_transient_feed_mod_{md5 of url}`. Timeouts for
1404 + // these records are stored in `_transient_timeout_feed_{md5}`.
1405 + // Since the md5 is always 32 characters in length, the
1406 + // option_name is always over 32 characters.
1407 + $ret = $wpdb->query("
1218 1408 DELETE FROM {$wpdb->options}
1219 - WHERE LOCATE('rss_', option_name) AND LENGTH(option_name) > 32
1409 + WHERE option_name LIKE '_transient%_feed_%' AND LENGTH(option_name) > 32
1220 1410 ");
1411 + return (int) ($ret / 4); // Each transient has 4 rows: the data, the modified timestamp; and the timeouts for each
1221 1412 } /* FeedWordPress::clear_cache () */
1222 1413
1223 - function magpie_version () {
1224 - if (!defined('MAGPIE_VERSION')) : $magpie_version = $GLOBALS['wp_version'].'-default';
1225 - else : $magpie_version = MAGPIE_VERSION;
1414 + function cache_duration () {
1415 + $duration = NULL;
1416 + if (defined('FEEDWORDPRESS_CACHE_AGE')) :
1417 + $duration = FEEDWORDPRESS_CACHE_AGE;
1226 1418 endif;
1227 - return $magpie_version;
1419 + return $duration;
1228 1420 }
1421 + function cache_lifetime ($duration) {
1422 + // Check for explicit setting of a lifetime duration
1423 + if (defined('FEEDWORDPRESS_CACHE_LIFETIME')) :
1424 + $duration = FEEDWORDPRESS_CACHE_LIFETIME;
1229 1425
1426 + // Fall back to the cache freshness duration
1427 + elseif (defined('FEEDWORDPRESS_CACHE_AGE')) :
1428 + $duration = FEEDWORDPRESS_CACHE_AGE;
1429 + endif;
1430 +
1431 + // Fall back to WordPress default
1432 + return $duration;
1433 + } /* FeedWordPress::cache_lifetime () */
1434 +
1230 1435 # Utility functions for handling text settings
1231 1436 function negative ($f, $setting) {
1232 1437 $nego = array ('n', 'no', 'f', 'false');
1233 1438 return (isset($f[$setting]) and in_array(strtolower($f[$setting]), $nego));
@@ -1242,17 +1447,12 @@
1242 1447 # Internal debugging functions
1243 1448 function critical_bug ($varname, $var, $line) {
1244 1449 global $wp_version;
1245 1450
1246 - if (defined('MAGPIE_VERSION')) : $mv = MAGPIE_VERSION;
1247 - else : $mv = 'WordPress '.$wp_version.' default.';
1248 - endif;
1249 -
1250 1451 echo '<p>There may be a bug in FeedWordPress. Please <a href="'.FEEDWORDPRESS_AUTHOR_CONTACT.'">contact the author</a> and paste the following information into your e-mail:</p>';
1251 1452 echo "\n<plaintext>";
1252 1453 echo "Triggered at line # ".$line."\n";
1253 1454 echo "FeedWordPress version: ".FEEDWORDPRESS_VERSION."\n";
1254 - echo "MagpieRSS version: {$mv}\n";
1255 1455 echo "WordPress version: {$wp_version}\n";
1256 1456 echo "PHP version: ".phpversion()."\n";
1257 1457 echo "\n";
1258 1458 echo $varname.": "; var_dump($var); echo "\n";
@@ -1263,10 +1463,55 @@
1263 1463 if (FEEDWORDPRESS_DEBUG) : // halt only when we are doing debugging
1264 1464 FeedWordPress::critical_bug($varname, $var, $line);
1265 1465 endif;
1266 1466 }
1467 +
1468 + function val ($v, $no_newlines = false) {
1469 + ob_start();
1470 + var_dump($v);
1471 + $out = ob_get_contents(); ob_end_clean();
1472 +
1473 + if ($no_newlines) :
1474 + $out = preg_replace('/\s+/', " ", $out);
1475 + endif;
1476 + return $out;
1477 + } /* FeedWordPress:val () */
1478 +
1479 + function diagnostic ($level, $out) {
1480 + global $feedwordpress_admin_footer;
1481 +
1482 + $output = get_option('feedwordpress_diagnostics_output', array());
1483 + $show = get_option('feedwordpress_diagnostics_show', array());
1484 +
1485 + $diagnostic_nesting = count(explode(":", $level));
1486 +
1487 + if (in_array($level, $show)) :
1488 + foreach ($output as $method) :
1489 + switch ($method) :
1490 + case 'echo' :
1491 + echo "<div><pre><strong>Diag".str_repeat('====', $diagnostic_nesting-1).'|</strong> '.esc_html($out)."</pre></div>";
1492 + break;
1493 + case 'admin_footer' :
1494 + $feedwordpress_admin_footer[] = $out;
1495 + break;
1496 + case 'error_log' :
1497 + error_log('[feedwordpress]' . $out);
1498 + break;
1499 + endswitch;
1500 + endforeach;
1501 + endif;
1502 + } /* FeedWordPress::diagnostic () */
1503 +
1504 + function admin_footer () {
1505 + global $feedwordpress_admin_footer;
1506 + foreach ($feedwordpress_admin_footer as $line) :
1507 + echo '<div><pre>'.esc_html($line).'</pre></div>';
1508 + endforeach;
1509 + } /* FeedWordPress::admin_footer () */
1267 1510 } // class FeedWordPress
1268 1511
1512 +$feedwordpress_admin_footer = array();
1513 +
1269 1514 require_once(dirname(__FILE__) . '/syndicatedpost.class.php');
1270 1515 require_once(dirname(__FILE__) . '/syndicatedlink.class.php');
1271 1516
1272 1517 ################################################################################
@@ -1278,9 +1523,9 @@
1278 1523 return $args;
1279 1524 }
1280 1525
1281 1526 function feedwordpress_pong ($args) {
1282 - $feedwordpress =& new FeedWordPress;
1527 + $feedwordpress = new FeedWordPress;
1283 1528 $delta = @$feedwordpress->update($args[1]);
1284 1529 if (is_null($delta)):
1285 1530 return array('flerror' => true, 'message' => "Sorry. I don't syndicate <$args[1]>.");
1286 1531 else:
@@ -1291,13 +1536,9 @@
1291 1536 return array('flerror' => false, 'message' => "Thanks for the ping.".implode(' and', $mesg));
1292 1537 endif;
1293 1538 }
1294 1539
1295 -# The upgraded MagpieRSS also uses this class. So if we have it loaded
1296 -# in, don't load it again.
1297 -if (!class_exists('Relative_URI')) {
1298 - require_once(dirname(__FILE__) . '/relative_uri.class.php');
1299 -}
1540 +require_once(dirname(__FILE__) . '/relative_uri.class.php');
1300 1541
1301 1542 // take your best guess at the realname and e-mail, given a string
1302 1543 define('FWP_REGEX_EMAIL_ADDY', '([^@"(<\s]+@[^"@(<\s]+\.[^"@(<\s]+)');
1303 1544 define('FWP_REGEX_EMAIL_NAME', '("([^"]*)"|([^"<(]+\S))');