PluginProbe
FeedWordPress / 2014.0805
FeedWordPress v2014.0805
trunk 0.8 0.9 0.91 0.95 0.96 0.97 0.98 0.981 0.99 0.991 0.992 0.993 2008.1030 2008.1101 2008.1105 2008.1214 2009.0612 2009.0613 2009.0618 2009.0707 2009.1111 2009.1112 2010.0127 2010.0528 All 65 releases
← All changes | feeds-page.php +478 -726 trunk2014.0805 View file →
@@ -1,34 +1,12 @@
1 1 <?php
2 -require_once dirname(__FILE__) . '/admin-ui.php';
3 -require_once dirname(__FILE__) . '/magpiemocklink.class.php';
4 -require_once dirname(__FILE__) . '/feedfinder.class.php';
5 -require_once dirname(__FILE__) . '/updatedpostscontrol.class.php';
2 +require_once(dirname(__FILE__) . '/admin-ui.php');
3 +require_once(dirname(__FILE__) . '/magpiemocklink.class.php');
4 +require_once(dirname(__FILE__) . '/feedfinder.class.php');
5 +require_once(dirname(__FILE__) . '/updatedpostscontrol.class.php');
6 6
7 -/**
8 - * List of feeds for FWP
9 - *
10 - * @extends FeedWordPressAdminPage
11 - * @global $post_source
12 - */
13 7 class FeedWordPressFeedsPage extends FeedWordPressAdminPage {
14 - /**
15 - * List of possible HTTP status messages.
16 - *
17 - * @var array
18 - *
19 - * @note Added a few more, renamed a few to stick to contemporary standard. (gwyneth 20230918)
20 - */
21 - var $HTTPStatusMessages = array(
22 - 100 => 'Continue',
23 - 101 => 'Switching Protocols',
24 - 102 => 'Processing', // WebDAV; RFC 2518
25 - 103 => 'Early Hints', // RFC 8297
26 - 110 => 'Response is Stale', // Obsoleted in 2022 by RFC 9111 (caching-related)
27 - 111 => 'Revalidation Failed', // Obsoleted in 2022 by RFC 9111 (caching-related)
28 - 112 => 'Disconnected Operation', // Obsoleted in 2022 by RFC 9111 (caching-related)
29 - 113 => 'Heuristic Expiration', // Obsoleted in 2022 by RFC 9111 (caching-related)
30 - 199 => 'Miscellaneous Warning', // Obsoleted in 2022 by RFC 9111 (caching-related)
8 + var $HTTPStatusMessages = array (
31 9 200 => 'OK. FeedWordPress had no problems retrieving the content at this URL but the content does not seem to be a feed, and does not seem to include links to any feeds.',
32 10 201 => 'Created',
33 11 202 => 'Accepted',
34 12 203 => 'Non-Authoritative information',
@@ -34,23 +12,15 @@
34 12 203 => 'Non-Authoritative information',
35 13 204 => 'No Content',
36 14 205 => 'Reset Content',
37 15 206 => 'Partial Content',
38 - 207 => 'Multi-Status', // WebDAV; RFC 4918
39 - 208 => 'Already Reported', // WebDAV; RFC 5842
40 - 214 => 'Transformation Applied', // Obsoleted in 2022 by RFC 9111 (caching-related)
41 - 218 => 'This is fine', // Non-standard; used by the Apache HTTP Serve)
42 - 226 => 'IM Used', // RFC 3229
43 - 299 => 'Miscellaneous Persistent Warning', // Obsoleted in 2022 by RFC 9111 (caching-related)
44 16 300 => 'Multiple Choices',
45 17 301 => 'Moved Permanently',
46 - 302 => 'Found', // Previously known as 'Moved temporarily'
18 + 302 => 'Found',
47 19 303 => 'See Other',
48 20 304 => 'Not Modified',
49 21 305 => 'Use Proxy',
50 - 306 => 'Switch Proxy',
51 22 307 => 'Temporary Redirect',
52 - 308 => 'Permanent Redirect',
53 23 400 => 'Bad Request',
54 24 401 => 'Unauthorized. This URL probably needs a username and password for you to access it.',
55 25 402 => 'Payment Required',
56 26 403 => 'Forbidden. The URL is not made available for the machine that FeedWordPress is running on.',
@@ -62,38 +32,13 @@
62 32 409 => 'Conflict',
63 33 410 => 'Gone. This URL is no longer available on this server and no forwarding address is known.',
64 34 411 => 'Length Required',
65 35 412 => 'Precondition Failed',
66 - 413 => 'Payload Too Large', // Previously known as 'Request Entity Too Large'
67 - 414 => 'URI Too Long', // Previously known as 'Request URI Too Long'
36 + 413 => 'Request Entity Too Large',
37 + 414 => 'Request URI Too Long',
68 38 415 => 'Unsupported Media Type',
69 - 416 => 'Range Not Satisfiable', // Previously known as 'Requested Range Not Satisfiable'
39 + 416 => 'Requested Range Not Satisfiable',
70 40 417 => 'Expectation Failed',
71 - 418 => 'I\'m a teapot', // RFC 2324, RFC 7168
72 - 419 => 'Page Expired', // Non-standard; used by the Laravel Framework
73 - 420 => 'Enhance Your Calm', // Non-standard; used by version 1.0 of the Twitter API
74 - 421 => 'Misdirected Request',
75 - 422 => 'Unprocessable Entity',
76 - 423 => 'Locked', // WebDAV; RFC 4918
77 - 424 => 'Failed Dependency', // WebDAV; RFC 4918
78 - 425 => 'Too Early', // RFC 8470
79 - 426 => 'Upgrade Required',
80 - 428 => 'Precondition Required', // RFC 6585
81 - 429 => 'Too Many Requests', // RFC 6585
82 - 431 => 'Request Header Fields Too Large', // RFC 6585
83 - 440 => 'Login Time-out', // Non-standard; used by Microsoft on IIS
84 - 444 => 'No Response', // Non-standard; used internally by the nginx web server
85 - 449 => 'Retry With', // Non-standard; used by Microsoft on IIS
86 - 450 => 'Blocked by Windows Parental Controls', // Non-standard; used by Microsoft
87 - 451 => 'Unavailable For Legal Reasons', // RFC 7725; also: used by Microsoft IIS for a redirect
88 - 460 => 'Too Soon', // Non-standard; used by Amazon on AWS
89 - 463 => 'Too Many IP Addresses', // Non-standard; used by Amazon on AWS
90 - 464 => 'Incompatible Protocol Version', // Non-standard; used by Amazon on AWS
91 - 494 => 'Request Header Too Large', // Non-standard; used by the nginx web server
92 - 495 => 'SSL Certificate Error', // Non-standard; used by the nginx web server
93 - 496 => 'SSL Certificate Required', // Non-standard; used by the nginx web server
94 - 498 => 'Invalid Token', // Non-standard; used by Esri on their ArcGIS for Server product
95 - 499 => 'Token Required', // Non-standard; used by Esri on their ArcGIS for Server product; also used as 'Client Closed Request' by the nginx web server
96 41 500 => 'Internal Server Error. Something unexpected went wrong with the configuration of the server that hosts this URL. You might try again later to see if this issue has been resolved.',
97 42 501 => 'Not Implemented',
98 43 502 => 'Bad Gateway',
99 44 503 => 'Service Unavailable. The server is currently unable to handle the request due to a temporary overloading or maintenance of the server that hosts this URL. This is probably a temporary condition and you should try again later to see if the issue has been resolved.',
@@ -98,44 +43,12 @@
98 43 502 => 'Bad Gateway',
99 44 503 => 'Service Unavailable. The server is currently unable to handle the request due to a temporary overloading or maintenance of the server that hosts this URL. This is probably a temporary condition and you should try again later to see if the issue has been resolved.',
100 45 504 => 'Gateway Timeout',
101 46 505 => 'HTTP Version Not Supported',
102 - 506 => 'Variant Also Negotiates', // RFC 2295
103 - 507 => 'Insufficient Storage', // WebDAV; RFC 4918
104 - 508 => 'Loop Detected', // WebDAV; RFC 5842
105 - 509 => 'Bandwidth Limit Exceeded', // Non-standard; used by the Apache Web Server as well as cPanel
106 - 510 => 'Not Extended', // RFC 2774
107 - 511 => 'Network Authentication Required', // RFC 6585
108 - 520 => 'Web Server Returned an Unknown Error', // Non-Standard; used by Cloudflare
109 - 521 => 'Web Server Is Down', // Non-Standard; used by Cloudflare
110 - 522 => 'Connection Timed Out', // Non-Standard; used by Cloudflare
111 - 523 => 'Origin Is Unreachable', // Non-Standard; used by Cloudflare
112 - 524 => 'A Timeout Occurred', // Non-Standard; used by Cloudflare
113 - 525 => 'SSL Handshake Failed', // Non-Standard; used by Cloudflare
114 - 526 => 'Invalid SSL Certificate', // Non-Standard; used by Cloudflare
115 - 527 => 'Railgun Error', // Non-Standard; used by Cloudflare
116 - 529 => 'Site is overloaded', // Non-standard; used by Qualys on its SSLLabs server testing API
117 - 530 => 'Site is frozen', // Non-standard; used by the Pantheon Systems web platform
118 - 561 => 'Unauthorized', // Non-standard; used by Amazon on AWS
119 - 598 => 'Network Read Timeout Error', // Non-standard; informal convention used by some HTTP procoes
120 - 599 => 'Network Connect Timeout Error', // Non-standard; informal convention used by some HTTP procoes
121 47 );
122 -
123 - /**
124 - * List of updated posts.
125 - *
126 - * @var mixed
127 - */
128 48 var $updatedPosts = NULL;
129 49
130 - /**
131 - * List of special settings.
132 - *
133 - * Regular expression syntax is OK here.
134 - *
135 - * @var Array
136 - */
137 - var $special_settings = array(
50 + var $special_settings = array ( /* Regular expression syntax is OK here */
138 51 'cats',
139 52 'cat_split',
140 53 'fetch timeout',
141 54 'freeze updates',
@@ -168,16 +81,15 @@
168 81 /**
169 82 * Constructs the Feeds page object
170 83 *
171 84 * @param mixed $link An object of class {@link SyndicatedLink} if created for one feed's settings, NULL if created for global default settings
172 - * @uses UpdatedPostsControl
173 85 */
174 - public function __construct( $link = -1 ) {
175 - if ( is_numeric( $link ) and -1 == $link ) :
176 - $link = $this->submitted_link();
86 + function FeedWordPressFeedsPage ($link = -1) {
87 + if (is_numeric($link) and -1 == $link) :
88 + $link = FeedWordPressAdminPage::submitted_link();
177 89 endif;
178 90
179 - parent::__construct( 'feedwordpressfeeds', $link );
91 + FeedWordPressAdminPage::FeedWordPressAdminPage('feedwordpressfeeds', $link);
180 92
181 93 $this->dispatch = 'feedwordpress_admin_page_feeds';
182 94 $this->pagenames = array(
183 95 'default' => 'Feeds',
@@ -184,45 +96,39 @@
184 96 'settings-update' => 'Syndicated feed',
185 97 'open-sheet' => 'Feed and Update',
186 98 );
187 99 $this->filename = __FILE__;
188 - $this->updatedPosts = new UpdatedPostsControl( $this );
189 -
190 - $this->special_settings = apply_filters( 'syndicated_feed_special_settings', $this->special_settings, $this );
100 + $this->updatedPosts = new UpdatedPostsControl($this);
101 +
102 + $this->special_settings = apply_filters('syndicated_feed_special_settings', $this->special_settings, $this);
191 103 } /* FeedWordPressFeedsPage constructor */
192 104
193 - /**
194 - * Prints out the feeds page.
195 - *
196 - * @return bool TRUE to continue printing out, FALSE to stop.
197 - * @uses FeedWordPress::param()
198 - */
199 - function display() {
105 + function display () {
106 + global $fwp_post;
200 107 global $post_source;
201 108
202 109 $this->boxes_by_methods = array(
203 - 'feed_information_box' => __( 'Feed Information' ),
204 - 'global_feeds_box' => __( 'Update Scheduling' ),
205 - 'updated_posts_box' => __( 'Updated Posts' ),
206 - 'custom_settings_box' => __( 'Custom Feed Settings (for use in templates)' ),
207 - 'advanced_settings_box' => __( 'Advanced Settings' ),
110 + 'feed_information_box' => __('Feed Information'),
111 + 'global_feeds_box' => __('Update Scheduling'),
112 + 'updated_posts_box' => __('Updated Posts'),
113 + 'custom_settings_box' => __('Custom Feed Settings (for use in templates)'),
114 + 'advanced_settings_box' => __('Advanced Settings'),
208 115 );
209 116 if ($this->for_default_settings()) :
210 - unset( $this->boxes_by_methods['custom_settings_box'] );
211 - endif;
212 -
117 + unset($this->boxes_by_methods['custom_settings_box']);
118 + endif;
119 +
213 120 // Allow overriding of normal source for FeedFinder, which may
214 121 // be called from multiple points.
215 - if ( isset( $post_source ) and ! is_null( $post_source ) ) :
122 + if (isset($post_source) and !is_null($post_source)) :
216 123 $source = $post_source;
217 124 else :
218 125 $source = $this->dispatch;
219 126 endif;
220 127
221 - $feedfinder = FeedWordPress::param( 'feedfinder' );
222 - $action = FeedWordPress::param( 'action' );
223 - if ( $feedfinder || in_array( $action, array( 'feedfinder', FWP_SYNDICATE_NEW ) ) ) :
224 -
128 + if (isset($_REQUEST['feedfinder'])
129 + or (isset($_REQUEST['action']) and $_REQUEST['action']=='feedfinder')
130 + or (isset($_REQUEST['action']) and $_REQUEST['action']==FWP_SYNDICATE_NEW)) :
225 131 // If this is a POST, validate source and user credentials
226 132 FeedWordPressCompatibility::validate_http_request(/*action=*/ $source, /*capability=*/ 'manage_links');
227 133
228 134 return $this->display_feedfinder(); // re-route to Feed Finder page
@@ -231,55 +137,37 @@
231 137 parent::display();
232 138 return false; // Don't continue
233 139 } /* FeedWordPressFeedsPage::display() */
234 140
235 - /**
236 - * Interface with JavaScript calls.
237 - *
238 - */
239 - function ajax_interface_js() {
240 - parent::ajax_interface_js();
141 + function ajax_interface_js () {
142 + FeedWordPressAdminPage::ajax_interface_js();
241 143 ?>
242 - jQuery( document ).ready( function () {
243 - contextual_appearance( 'automatic-updates-selector', 'cron-job-explanation', null, 'no' );
244 - contextual_appearance( 'time-limit', 'time-limit-box', null, 'yes' );
245 - contextual_appearance( 'use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true );
246 - jQuery( '#use-default-update-window-yes, #use-default-update-window-no' ).click( function () {
247 - contextual_appearance( 'use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true );
144 +
145 + jQuery(document).ready( function () {
146 + contextual_appearance('automatic-updates-selector', 'cron-job-explanation', null, 'no');
147 + contextual_appearance('time-limit', 'time-limit-box', null, 'yes');
148 + contextual_appearance('use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true);
149 + jQuery('#use-default-update-window-yes, #use-default-update-window-no').click( function () {
150 + contextual_appearance('use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true);
248 151 } );
249 152
250 - var els = [ 'name', 'description', 'url' ];
251 - for ( var i = 0; i < els.length; i++ ) {
153 + var els = ['name', 'description', 'url'];
154 + for (var i = 0; i < els.length; i++) {
252 155 contextual_appearance(
253 - /*item=*/ 'basics-hardcode-' + els[i],
254 - /*appear=*/ 'basics-' + els[i] + '-view',
255 - /*disappear=*/ 'basics-' + els[i] + '-edit',
256 - /*value=*/ 'no',
156 + /*item=*/ 'basics-hardcode-'+els[i],
157 + /*appear=*/ 'basics-'+els[i]+'-view',
158 + /*disappear=*/ 'basics-'+els[i]+'-edit',
159 + /*value=*/ 'no',
257 160 /*visibleStyle=*/ 'block',
258 - /*checkbox=*/ true
161 + /*checkbox=*/ true
259 162 );
260 163 } /* for */
164 + } );
261 165
262 - // Let's make the interface for the PAUSE/RESUME a bit better
263 - jQuery( '<tr id="reveal-pause-resume"><th></th><td><button id="pause-resume-reveal-button">&mdash; PAUSE or RESUME UPDATES &mdash;</button></td></tr>' ).insertBefore( '#pause-resume' );
264 - jQuery( '#pause-resume' ).hide();
265 - jQuery( '#pause-resume-reveal-button' ).click( function( ev ) {
266 - ev.preventDefault();
267 -
268 - jQuery( '#pause-resume' ).toggle();
269 - return false;
270 - });
271 - } );
272 166 <?php
273 - } /* FeedWordPressFeedsPage::ajax_interface_js() */
274 -
275 - /**
276 - * Displays updated feeds.
277 - *
278 - * @param object $page Current page object (?).
279 - * @param mixed|null $box A box inside this object.
280 - */
281 - /*static*/ function updated_posts_box( $page, $box = NULL ) {
167 + }
168 +
169 + /*static*/ function updated_posts_box ($page, $box = NULL) {
282 170 ?>
283 171 <table class="edit-form">
284 172 <?php $page->updatedPosts->display(); ?>
285 173 </table>
@@ -285,148 +173,106 @@
285 173 </table>
286 174 <?php
287 175 } /* FeedWordPressFeedsPage::updated_posts_box() */
288 176
289 - /**
290 - * Displays form to deal with global feeds.
291 - *
292 - * @param object $page Current page object (?).
293 - * @param mixed|null $box A box inside this object.
294 - *
295 - * @uses FeedWordPress::automatic_update_hook()
296 - */
297 - /*static*/ function global_feeds_box( $page, $box = NULL ) {
177 + /*static*/ function global_feeds_box ($page, $box = NULL) {
298 178 global $feedwordpress;
299 - $automatic_updates = $feedwordpress->automatic_update_hook( array( 'setting only' => true ) );
300 - $update_time_limit = (int) get_option( 'feedwordpress_update_time_limit' );
179 + $automatic_updates = $feedwordpress->automatic_update_hook(array('setting only' => true));
180 + $update_time_limit = (int) get_option('feedwordpress_update_time_limit');
301 181
302 182 // Hey, ho, let's go...
303 183 ?>
304 184
305 - <table class="edit-form"
306 - <?php if ( $page->for_default_settings() ) : ?>
185 + <table class="edit-form">
186 + <?php if ($page->for_default_settings()) : ?>
307 187
308 188 <tr>
309 - <th scope="row"><?php esc_html_e( 'Update Method:' ); ?></th>
189 + <th scope="row">Updates:</th>
310 190 <td><select id="automatic-updates-selector" name="automatic_updates" size="1" onchange="contextual_appearance('automatic-updates-selector', 'cron-job-explanation', null, 'no');">
311 - <option value="shutdown"<?php fwp_selected_flag( 'shutdown' == $automatic_updates ); ?>><?php esc_html_e( 'automatically check for updates after pages load' ); ?></option>
312 - <option value="init"<?php fwp_selected_flag( 'init' == $automatic_updates ); ?>><?php esc_html_e( 'automatically check for updates before pages load' ); ?></option>
313 - <option value="no"<?php fwp_selected_flag( ! $automatic_updates ); ?>><?php esc_html_e( 'cron job or manual updates' ); ?></option>
191 + <option value="shutdown"<?php echo ($automatic_updates=='shutdown')?' selected="selected"':''; ?>>automatically check for updates after pages load</option>
192 + <option value="init"<?php echo ($automatic_updates=='init')?' selected="selected"':''; ?>>automatically check for updates before pages load</option>
193 + <option value="no"<?php echo (!$automatic_updates)?' selected="selected"':''; ?>>cron job or manual updates</option>
314 194 </select>
315 195 <div id="cron-job-explanation" class="setting-description">
316 196 <p><?php
317 - /* Do we have shell_exec() available from here, or is it disabled for security reasons?
318 - * If it's available, use it to execute `which` to try to get a realistic path to curl,
319 - * or to wget. If everything fails or shell_exec() isn't available, then just make
320 - * up something for the sake of example.
321 - */
322 - /** var string|null Path to either cURL or wget executables. */
323 - $curlOrWgetPath = NULL;
324 -
325 - /** var bool True if this WP installation can call shell commands. */
326 - $shellExecAvailable = ( is_callable( 'shell_exec' ) && false === stripos( ini_get( 'disable_functions' ), 'shell_exec') );
327 -
328 - if ( $shellExecAvailable ) :
329 - $curlOrWgetPath = `which curl`; $opts = '--silent %s';
197 + $path = `which curl`; $opts = '--silent %s';
198 + if (is_null($path) or strlen(trim($path))==0) :
199 + $path = `which wget`; $opts = '-q -O - %s';
200 + if (is_null($path) or strlen(trim($path))==0) :
201 + $path = '/usr/bin/curl'; $opts = '--silent %s';
202 + endif;
330 203 endif;
331 -
332 - if ( $shellExecAvailable and ( is_null( $curlOrWgetPath ) or strlen( trim( $curlOrWgetPath ) ) == 0 ) ) :
333 - $curlOrWgetPath = `which wget`; $opts = '-q -O - %s';
334 - endif;
335 -
336 - if ( is_null( $curlOrWgetPath ) or strlen( trim( $curlOrWgetPath ) ) == 0 ) :
337 - $curlOrWgetPath = '/usr/bin/curl'; $opts = '--silent %s';
338 - endif;
339 -
340 - $curlOrWgetPath = preg_replace( '/\n+$/', '', $curlOrWgetPath );
341 -
342 - /** var string Constructed shell command line to call cURL/wget for updating FeedWordPress feeds. */
343 - $cmdline = $curlOrWgetPath . ' ' . sprintf( $opts, get_bloginfo( 'url' ) . '?update_feedwordpress=1' );
344 -
345 - ?><?php esc_html_e( 'If you want to use a cron job, you can perform scheduled updates by sending regularly-scheduled requests to ' ); ?><a href="<?php bloginfo('url'); ?>?update_feedwordpress=1"><code><?php bloginfo('url'); ?>?update_feedwordpress=1</code></a>
346 - <?php esc_html_e( 'For example, inserting the following line in your crontab:' ); ?></p>
204 + $path = preg_replace('/\n+$/', '', $path);
205 + $crontab = `crontab -l`;
206 +
207 + $cmdline = $path . ' ' . sprintf($opts, get_bloginfo('url').'?update_feedwordpress=1');
208 +
209 + ?>If you want to use a cron job,
210 + you can perform scheduled updates by sending regularly-scheduled
211 + requests to <a href="<?php bloginfo('url'); ?>?update_feedwordpress=1"><code><?php bloginfo('url') ?>?update_feedwordpress=1</code></a>
212 + For example, inserting the following line in your crontab:</p>
347 213 <pre style="font-size: 0.80em"><code>*/10 * * * * <?php print esc_html($cmdline); ?></code></pre>
348 - <p class="setting-description"><?php esc_html_e( 'will check in every 10 minutes and check for updates on any feeds that are ready to be polled for updates.' ); ?></p>
214 + <p class="setting-description">will check in every 10 minutes
215 + and check for updates on any feeds that are ready to be polled for updates.</p>
349 216 </div>
350 217 </td>
351 218 </tr>
352 -
219 +
353 220 <?php else : /* Feed-specific settings */ ?>
354 221
355 222 <tr>
356 - <th scope="row"><?php esc_html_e( 'Last update' ) ?>:</th>
223 + <th scope="row"><?php _e('Last update') ?>:</th>
357 224 <td><?php
358 - if ( isset( $page->link->settings['update/last'] ) ) :
359 - echo esc_html( fwp_time_elapsed( $page->link->settings['update/last'] ) . " " );
225 + if (isset($page->link->settings['update/last'])) :
226 + echo fwp_time_elapsed($page->link->settings['update/last'])." ";
360 227 else :
361 - esc_html_e( " none yet" );
228 + echo " none yet";
362 229 endif;
363 230 ?></td></tr>
364 231
365 - <tr><th><?php esc_html_e( 'Next update' ) ?>:</th>
232 + <tr><th><?php _e('Next update') ?>:</th>
366 233 <td><?php
367 - $holdem = ( isset( $page->link->settings['update/hold'] ) ? $page->link->settings['update/hold'] : 'scheduled' );
234 + $holdem = (isset($page->link->settings['update/hold']) ? $page->link->settings['update/hold'] : 'scheduled');
368 235 ?>
369 236 <select name="update_schedule">
370 - <option value="scheduled"<?php echo ( 'scheduled' == $holdem ) ? ' selected="selected"' : ''; ?>><?php esc_html_e( 'update on schedule' ); ?> <?php
237 + <option value="scheduled"<?php echo ($holdem=='scheduled')?' selected="selected"':''; ?>>update on schedule <?php
371 238 echo " (";
372 - if ( isset( $page->link->settings['update/ttl'] ) and is_numeric( $page->link->settings['update/ttl'] ) ) :
373 - if ( isset( $page->link->settings['update/timed'] ) and 'automatically' == $page->link->settings['update/timed'] ) :
374 - esc_html_e( 'next: ');
375 - $next = $page->link->settings['update/last'] + ( (int) $page->link->settings['update/ttl'] * 60 );
376 - // Note: strftime() is deprecated; use date() instead. (gwyneth 20230918)
377 - if ( strftime( '%x', time() ) != strftime( '%x', $next) ) :
378 - echo esc_html( strftime( '%x', $next ) . ' ' );
239 + if (isset($page->link->settings['update/ttl']) and is_numeric($page->link->settings['update/ttl'])) :
240 + if (isset($page->link->settings['update/timed']) and $page->link->settings['update/timed']=='automatically') :
241 + echo 'next: ';
242 + $next = $page->link->settings['update/last'] + ((int) $page->link->settings['update/ttl'] * 60);
243 + if (strftime('%x', time()) != strftime('%x', $next)) :
244 + echo strftime('%x', $next)." ";
379 245 endif;
380 - echo esc_html( strftime( '%X', $page->link->settings['update/last'] + ( (int) $page->link->settings['update/ttl'] * 60 ) ) );
246 + echo strftime('%X', $page->link->settings['update/last']+((int) $page->link->settings['update/ttl']*60));
381 247 else :
382 - echo esc_html__( "every " ) . esc_html( $page->link->settings['update/ttl'] ) . esc_html__( " minute" )
383 - . ( ( 1 != $page->link->settings['update/ttl'] ) ? esc_html__( "s" ) : "" );
248 + echo "every ".$page->link->settings['update/ttl']." minute".(($page->link->settings['update/ttl']!=1)?"s":"");
384 249 endif;
385 250 else:
386 - esc_html_e( "next scheduled update" );
251 + echo "next scheduled update";
387 252 endif;
388 253 echo ")";
389 254 ?></option>
390 - <option value="next"<?php echo ( 'next' == $holdem ) ? ' selected="selected"' : ''; ?>><?php esc_html_e( 'update ASAP' ); ?></option>
391 - <option value="ping"<?php echo ( 'ping' == $holdem ) ? ' selected="selected"' : ''; ?>><?php esc_html_e( 'update only when pinged' ); ?></option>
255 + <option value="next"<?php echo ($holdem=='next')?' selected="selected"':''; ?>>update ASAP</option>
256 + <option value="ping"<?php echo ($holdem=='ping')?' selected="selected"':''; ?>>update only when pinged</option>
392 257 </select></td></tr>
393 -
258 +
394 259 <?php endif; ?>
395 -
396 - <tr id="pause-resume">
397 - <th scope="row"><?php esc_html_e( 'Pause/Resume:'); ?></th>
398 - <td><?php
399 - $this->setting_radio_control(
400 - 'update/pause',
401 - 'update_pause',
402 - /*options=*/ array(
403 - 'no' => __( '<strong>UPDATE:</strong> import new posts as normal' ),
404 - 'yes' => __( '<strong>PAUSE:</strong> do not import new posts until I unpause updates' ),
405 - ),
406 - /*params=*/ array(
407 - 'setting-default' => NULL,
408 - 'global-setting-default' => 'no',
409 - 'default-input-value' => 'default',
410 - ),
411 - );
412 - ?></td>
413 - </tr>
414 -
260 +
415 261 <tr>
416 - <th scope="row"><?php esc_html_e( 'Update scheduling:') ?></th>
417 - <td><p style="margin-top:0px"><?php esc_html_e( 'How long should FeedWordPress wait between updates before it considers this feed ready to be polled for updates again?' ); ?></p>
262 + <th scope="row"><?php print __('Update scheduling:') ?></th>
263 + <td><p style="margin-top:0px">How long should FeedWordPress wait between updates before it considers this feed ready to be polled for updates again?</p>
418 264 <?php
265 +
419 266 $this->setting_radio_control(
420 - 'update/window',
421 - 'update_window',
422 - array( $this, 'update_window_edit_box' ),
267 + 'update/window', 'update_window',
268 + array($this, 'update_window_edit_box'),
423 269 array(
424 270 'global-setting-default' => DEFAULT_UPDATE_PERIOD,
425 - 'default-input-name' => 'use_default_update_window',
426 - 'default-input-id' => 'use-default-update-window-yes',
427 - 'default-input-id-no' => 'use-default-update-window-no',
428 - 'labels' => array($this, 'update_window_currently' ),
271 + 'default-input-name' => 'use_default_update_window',
272 + 'default-input-id' => 'use-default-update-window-yes',
273 + 'default-input-id-no' => 'use-default-update-window-no',
274 + 'labels' => array($this, 'update_window_currently'),
429 275 )
430 276 );
431 277 ?></td>
432 278 </tr>
@@ -431,20 +277,20 @@
431 277 ?></td>
432 278 </tr>
433 279
434 280 <tr>
435 - <th scope="row"><?php esc_html_e( 'Minimum Interval:'); ?></th>
436 - <td><p style="margin-top:0px"><?php esc_html_e( 'Some feeds include standard elements that
281 + <th scope="row"><?php print __('Minimum Interval:'); ?></th>
282 + <td><p style="margin-top:0px">Some feeds include standard elements that
437 283 request a specific update schedule. If the interval requested by the
438 - feed provider is <em>longer</em> than FeedWordPress&rsquo;s normal scheduling,
284 + feed provider is <em>longer</em> than FeedWordPress's normal scheduling,
439 285 FeedWordPress will always respect their request to slow down. But what
440 - should it do if the update interval is <em>shorter</em> than the schedule set above?' ); ?></p>
286 + should it do if the update interval is <em>shorter</em> than the schedule set above?</p>
441 287 <?php
442 288 $this->setting_radio_control(
443 289 'update/minimum', 'update_minimum',
444 290 /*options=*/ array(
445 - 'no' => __( 'Speed up and accept the interval from the feed provider' ),
446 - 'yes' => __( 'Keep pace and use the longer scheduling from FeedWordPress' ),
291 + 'no' => 'Speed up and accept the interval from the feed provider',
292 + 'yes' => 'Keep pace and use the longer scheduling from FeedWordPress',
447 293 ),
448 294 /*params=*/ array(
449 295 'setting-default' => NULL,
450 296 'global-setting-default' => 'no',
@@ -453,114 +299,76 @@
453 299 );
454 300 ?>
455 301 </td>
456 302 </tr>
457 -
303 +
458 304 <?php if ($this->for_default_settings()) : ?>
459 -
305 +
460 306 <tr>
461 - <th scope="row"><?php esc_html_e( 'Time limit on updates' ); ?>:</th>
462 - <td><select id="time-limit" name="update_time_limit" size="1" onchange="contextual_appearance( 'time-limit', 'time-limit-box', null, 'yes' );">
463 - <option value="no"<?php fwp_selected_flag( $update_time_limit <= 0 ); ?>><?php esc_html_e( 'no time limit on updates' ); ?></option>
464 - <option value="yes"<?php fwp_selected_flag( $update_time_limit > 0 ); ?>><?php esc_html_e( 'limit updates to no more than...' ); ?></option>
307 + <th scope="row"><?php print __('Time limit on updates'); ?>:</th>
308 + <td><select id="time-limit" name="update_time_limit" size="1" onchange="contextual_appearance('time-limit', 'time-limit-box', null, 'yes');">
309 + <option value="no"<?php echo ($update_time_limit>0)?'':' selected="selected"'; ?>>no time limit on updates</option>
310 + <option value="yes"<?php echo ($update_time_limit>0)?' selected="selected"':''; ?>>limit updates to no more than...</option>
465 311 </select>
466 - <span id="time-limit-box"><label><input type="text" name="time_limit_seconds" value="<?php print esc_attr( $update_time_limit ); ?>" size="5" /> <?php esc_html_e( 'seconds' ); ?></label></span>
312 + <span id="time-limit-box"><label><input type="text" name="time_limit_seconds" value="<?php print $update_time_limit; ?>" size="5" /> seconds</label></span>
467 313 </tr>
468 314
469 315 <?php endif; ?>
470 -
316 +
471 317 </table>
472 -
318 +
473 319 <?php
474 320 } /* FeedWordPressFeedsPage::global_feeds_box() */
475 321
476 - /**
477 - * Updates the window edit box.
478 - *
479 - * @param int $updateWindow Minutes between polling.
480 - * @param bool $defaulted Unused.
481 - * @param array $params Unused.
482 - */
483 - function update_window_edit_box( $updateWindow, $defaulted, $params ) {
484 - if ( ! is_numeric( $updateWindow) ) :
322 + function update_window_edit_box ($updateWindow, $defaulted, $params) {
323 + if (!is_numeric($updateWindow)) :
485 324 $updateWindow = DEFAULT_UPDATE_PERIOD;
486 325 endif;
487 326 ?>
488 - <p><?php esc_html_e( 'Wait' ); ?> <input type="text" name="update_window" value="<?php print esc_attr( $updateWindow ); ?>" size="4" /> <?php esc_html_e( 'minutes between polling.' ); ?></p>
327 + <p>Wait <input type="text" name="update_window" value="<?php print $updateWindow; ?>" size="4" /> minutes between polling.</p>
489 328 <div class="setting-description" id="update-scheduling-note">
490 - <p<?php if ( $updateWindow < 50 ) : ?> style="color: white; background-color: #703030; padding: 1.0em;"<?php endif; ?>><?php esc_html_e( '<strong>Recommendation.</strong> Unless you are positive that you have the webmaster&rsquo;s permission, you generally should not set FeedWordPress to poll feeds more frequently than once every 60 minutes. Many webmasters consider more frequent automated polling to be abusive, and may complain to your web host, or ban your IP address, as retaliation for hammering their servers too hard.' ); ?></p>
491 - <p><?php esc_html_e( '<strong>Note.</strong> This is a default setting that FeedWordPress uses to schedule updates when the feed does not provide any scheduling requests. If this feed does provide update scheduling information (through elements such as <code>&lt;rss:ttl&gt;</code> or <code>&lt;sy:updateFrequency&gt;</code>), FeedWordPress will respect the feed&rsquo;s request.' ); ?></p>
329 + <p<?php if ($updateWindow<50) : ?> style="color: white; background-color: #703030; padding: 1.0em;"<?php endif; ?>><strong>Recommendation.</strong> Unless you are positive that you have the webmaster's permission, you generally should not set FeedWordPress to poll feeds more frequently than once every 60 minutes. Many webmasters consider more frequent automated polling to be abusive, and may complain to your web host, or ban your IP address, as retaliation for hammering their servers too hard.</p>
330 + <p><strong>Note.</strong> This is a default setting that FeedWordPress uses to schedule updates when the feed does not provide any scheduling requests. If this feed does provide update scheduling information (through elements such as <code>&lt;rss:ttl&gt;</code> or <code>&lt;sy:updateFrequency&gt;</code>), FeedWordPress will respect the feed's request.</p>
492 331 </div>
493 332 <?php
494 - } /* FeedWordPressFeedsPage::update_window_edit_box() */
495 -
496 - /**
497 - * Auxiliary function to update the window with current polling waiting period.
498 - *
499 - * @param int $updateWindow Minutes between polling.
500 - * @param bool $defaulted Unused.
501 - * @param array $params Unused.
502 - */
503 - function update_window_currently( $updateWindow, $defaulted, $params ) {
333 + } /* FeedWordPressFeedsPage::update_window_edit_box () */
334 +
335 + function update_window_currently ($updateWindow, $defaulted, $params) {
504 336 $updateWindow = (int) $updateWindow;
505 - if ( 1 == $updateWindow ) :
506 - $caption = __( 'wait %d minute between polling' );
337 + if (1==$updateWindow) :
338 + $caption = 'wait %d minute between polling';
507 339 else :
508 - $caption = __( 'wait %d minutes between polling' );
340 + $caption = 'wait %d minutes between polling';
509 341 endif;
510 - return sprintf( $caption, $updateWindow );
511 - } /* FeedWordPressFeedsPage::update_window_currently() */
342 + return sprintf(__($caption), $updateWindow);
343 + } /* FeedWordPressFeedsPage::update_window_currently () */
344 +
345 + function fetch_timeout_setting ($setting, $defaulted, $params) {
346 + $timeout = intval($this->setting('fetch timeout', FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT));
512 347
513 - /**
514 - * Fetches the timeout setting.
515 - *
516 - * Nothing is returned, this just emits the HTML.
517 - *
518 - * @param int $setting Unused.
519 - * @param bool $defaulted Unused.
520 - * @param array $params Unused.
521 - */
522 - function fetch_timeout_setting( $setting, $defaulted, $params ) {
523 - /** var int Fetch feed timeout in seconds. */
524 - $timeout = intval( $this->setting( 'fetch timeout', FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT ) );
525 -
526 - if ( $this->for_feed_settings() ) :
527 - $article = __( 'this' );
348 + if ($this->for_feed_settings()) :
349 + $article = 'this';
528 350 else :
529 - $article = __( 'a' );
351 + $article = 'a';
530 352 endif;
531 353 ?>
532 - <p><?php esc_html_e( 'Wait no more than' ); ?> <input name="fetch_timeout" type="number" min="0" size="3" value="<?php print esc_attr( $timeout ); ?>" />
533 - <?php esc_html_e( 'second(s) when trying to fetch '); print esc_html( $article ); esc_html_e(' feed to check for updates. '); ?></p>
534 - <p><?php esc_html_e( 'If ' ); print esc_html( $article ); esc_html_e(' source&rsquo;s web server does not respond before time runs
535 - out, FeedWordPress will skip over the source and try again during the next update cycle.' ); ?></p>
354 + <p>Wait no more than
355 + than <input name="fetch_timeout" type="number" min="0" size="3" value="<?php print $timeout; ?>" />
356 + second(s) when trying to fetch <?php print $article; ?> feed to check for updates.</p>
357 + <p>If <?php print $article; ?> source's web server does not respond before time runs
358 + out, FeedWordPress will skip over the source and try again during
359 + the next update cycle.</p>
536 360 <?php
537 - } /* FeedWordPressFeedsPage::fetch_timeout_setting() */
538 -
539 - /**
540 - * Properly formats the feed timeout setting, with plurals if required.
541 - *
542 - * Nothing is returned, this just emits the HTML.
543 - *
544 - * @param int $setting Value for the feed timeout, in seconds.
545 - * @param bool $defaulted Unused.
546 - * @param array $params Unused.
547 - */
548 - function fetch_timeout_setting_value( $setting, $defaulted, $params ) {
549 - print number_format( intval( $setting) ) . " " . ( ( 1 == $setting ) ? "second" : "seconds" );
550 361 }
551 -
552 - /**
553 - * Displays the advanced settings box on the FWP dashboard page.
554 - *
555 - * @param FeedWordPressFeedsPage $page A page object, unused.
556 - * @param mixed|null $box A box inside this object, unused.
557 - */
558 - function advanced_settings_box( $page, $box = NULL ) {
362 + function fetch_timeout_setting_value ($setting, $defaulted, $params) {
363 + print number_format(intval($setting)) . " " . (($setting==1) ? "second" : "seconds");
364 + }
365 +
366 + function advanced_settings_box ($page, $box = NULL) {
559 367 ?>
560 368 <table class="edit-form">
561 369 <tr>
562 - <th><?php esc_html_e( 'Fetch Timeout:' ); ?></th>
370 + <th>Fetch Timeout:</th>
563 371 <td>
564 372 <?php
565 373 $this->setting_radio_control(
566 374 'fetch timeout', 'fetch_timeout',
@@ -575,31 +383,29 @@
575 383 ?>
576 384 </td>
577 385 </tr>
578 386 <tr>
579 - <th><?php esc_html_e( 'Feed Update Type:' ); ?></th>
387 + <th>Feed Update Type:</th>
580 388 <td><?php
581 - $this->setting_radio_control( 'update_incremental', 'update_incremental',
389 + $this->setting_radio_control('update_incremental', 'update_incremental',
582 390 /*options=*/ array(
583 - 'incremental' => __( '**Incremental.** When items no longer appear on the feed, keep them in the WordPress posts table.' ),
584 - 'complete' => __( '**Complete.** When items no longer appear on the feed, they are obsolete; retire them from the WordPress posts table.' ),
391 + 'incremental' => '<strong>Incremental.</strong> When items no longer appear on the feed, keep them in the WordPress posts table.',
392 + 'complete' => '<strong>Complete.</strong> When items no longer appear on the feed, they are obsolete; retire them from the WordPress posts table.',
585 393 ),
586 394 /*params=*/ array(
587 395 'setting-default' => NULL,
588 396 'global-setting-default' => 'incremental',
589 - 'default-input-value' => 'default',
397 + 'default-input-value' => 'default',
590 398 )
591 399 ); ?></td>
592 400 </tr>
593 401 <tr>
594 - <th><?php esc_html_e( 'Allow Feeds to Delete Posts:' ); ?></th>
402 + <th>Allow Feeds to Delete Posts:</th>
595 403 <td><?php
596 - $this->setting_radio_control(
597 - 'tombstones',
598 - 'tombstones',
404 + $this->setting_radio_control('tombstones', 'tombstones',
599 405 /*options=*/ array(
600 - 'yes' => __( 'Yes. If a feed indicates that one of its posts has been deleted, delete the local copy syndicated to this website.' ),
601 - 'no' => __( 'No. Even if a feed indicates that one of its posts has been deleted, retain the local copy on this website.' ),
406 + 'yes' => 'Yes. If a feed indicates that one of its posts has been deleted, delete the local copy syndicated to this website.',
407 + 'no' => 'No. Even if a feed indicates that one of its posts has been deleted, retain the local copy on this website.',
602 408 ),
603 409 /*params=*/ array(
604 410 'setting-default' => NULL,
605 411 'global-setting-default' => 'yes',
@@ -608,61 +414,48 @@
608 414 ); ?></td>
609 415 </tr>
610 416 </table>
611 417 <?php
612 - } /* FeedWordPressFeedsPage::advanced_settings_box() */
613 -
614 - /**
615 - * Shows a box for authentication credentials for a feed.
616 - *
617 - * @param array $params Array of parameters to parse.
618 - */
619 - function display_authentication_credentials_box( $params = array() ) {
418 + } /* FeedWordPressFeedsPage::advanced_settings_box () */
419 +
420 + function display_authentication_credentials_box ($params = array()) {
620 421 static $count = 0;
621 422
622 - $params = wp_parse_args(
623 - $params,
624 - array(
625 - 'username' => NULL,
626 - 'password' => NULL,
627 - 'method' => '-',
628 - ),
629 - );
630 -
423 + $params = wp_parse_args($params, array(
424 + 'username' => NULL,
425 + 'password' => NULL,
426 + 'method' => '-',
427 + ));
428 +
631 429 // Equivalents
632 - if ( is_null( $params['method'] ) ) : $params['method'] = '-'; endif;
633 -
430 + if (is_null($params['method'])) : $params['method'] = '-'; endif;
431 +
634 432 $count++;
635 - /** var string Constructed slug for each feed credential. */
636 - $slug = ( $count > 1 ? '-' . $count : '' );
637 -
433 + $slug = ($count > 1 ? '-'.$count : '');
434 +
638 435 global $feedwordpress;
639 436 $authMethods = apply_filters(
640 437 'feedwordpress_http_auth_methods',
641 - $feedwordpress->httpauth->methods_available(),
438 + $feedwordpress->httpauth->methods_available()
642 439 );
643 440
644 - $linkRssAuthId = sanitize_html_class( 'link-rss-authentication' . $slug );
645 - $linkRssCredentialsId = sanitize_html_class( 'link-rss-authentication-credentials' . $slug );
646 - $linkRssAuthMethodId = sanitize_html_class( 'link-rss-authentication-method' . $slug );
647 -
648 - if ( count( $authMethods ) > 1 ) : /* More than '-' */
441 + if (count($authMethods) > 1) : /* More than '-' */
649 442 ?>
650 - <div class="link-rss-authentication" id="<?php print esc_attr( $linkRssAuthId ); ?>">
443 + <div class="link-rss-authentication" id="link-rss-authentication<?php print $slug; ?>">
651 444 <table>
652 445 <tbody>
653 - <tr class="link-rss-authentication-credentials" id="<?php print esc_attr( $linkRssCredentialsId ); ?>">
654 - <td><label><?php esc_html_e( 'user:' ); ?> <input type="text" name="link_rss_username"
655 - value="<?php print esc_attr( $params['username'] ); ?>" size="16"
446 + <tr class="link-rss-authentication-credentials" id="link-rss-authentication-credentials<?php print $slug; ?>">
447 + <td><label>user: <input type="text" name="link_rss_username"
448 + value="<?php print esc_attr($params['username']); ?>" size="16"
656 449 placeholder="username to access this feed" /></label></td>
657 - <td><label><?php esc_html_e( 'pass:' ); ?> <input type="text" name="link_rss_password"
658 - value="<?php print esc_attr( $params['password'] ); ?>" size="16"
659 - placeholder=<?php esc_html_e( 'password to access this feed' ); ?> /></label></td>
660 - <td class="link-rss-authentication-method" id="<?php print esc_attr( $linkRssAuthMethodId ); ?>"><label><?php esc_html_e( 'method' ); ?>: <select class="link-rss-auth-method" id="link-rss-auth-method" name="link_rss_auth_method" size="1">
661 -<?php foreach ( $authMethods as $value => $label ) : ?>
662 - <option value="<?php print esc_attr( $value ); ?>"<?php
663 - fwp_selected_flag( $value == $params['method'] );
664 - ?>><?php print esc_html( $label ); ?></option>
450 + <td><label>pass: <input type="text" name="link_rss_password"
451 + value="<?php print esc_attr($params['password']); ?>" size="16"
452 + placeholder="password to access this feed" /></label></td>
453 + <td class="link-rss-authentication-method" id="link-rss-authentication-method<?php print $slug; ?>"><label>method: <select class="link-rss-auth-method" id="link-rss-auth-method" name="link_rss_auth_method" size="1">
454 +<?php foreach ($authMethods as $value => $label) : ?>
455 + <option value="<?php print esc_attr($value); ?>"<?php
456 + if ($value == $params['method']) : ?> selected="selected"<?php
457 + endif; ?>><?php print esc_html($label); ?></option>
665 458 <?php endforeach; ?>
666 459 </select></label></td>
667 460 </tr>
668 461 </tbody>
@@ -667,136 +460,128 @@
667 460 </tr>
668 461 </tbody>
669 462 </table>
670 463 </div>
671 -
464 +
672 465 <script type="text/javascript">
673 - jQuery('<td><a class="add-remove remove-it" id="link-rss-userpass-remove<?php print esc_attr( $slug ); ?>" href="#"><span class="x">(X)</span> <?php esc_html_e( 'Remove' ); ?></a></td>')
674 - .appendTo('#<?php print esc_attr( $linkRssCredentialsId ); ?>' )
466 + jQuery('<td><a class="add-remove remove-it" id="link-rss-userpass-remove<?php print $slug; ?>" href="#"><span class="x">(X)</span> Remove</a></td>')
467 + .appendTo('#link-rss-authentication-credentials<?php print $slug; ?>')
675 468 .click( feedAuthenticationMethodUnPress );
676 - jQuery( '#link-rss-auth-method<?php print esc_attr( $slug ); ?>' ).change( feedAuthenticationMethod );
677 - feedAuthenticationMethod( {
678 - init: true,
679 - node: jQuery( '#<?php print esc_attr( $linkRssAuthId ); ?>' )
680 - } );
469 + jQuery('#link-rss-auth-method<?php print $slug; ?>').change( feedAuthenticationMethod );
470 + feedAuthenticationMethod({
471 + init: true,
472 + node: jQuery('#link-rss-authentication<?php print $slug; ?>') });
681 473 </script>
682 -
474 +
683 475 <?php
684 476 endif;
685 - } /* FeedWordPressFeedsPage::display_authentication_credentials_box() */
686 -
687 - /**
688 - * Displays a box with information about a feed.
689 - *
690 - * @param object $page Current page object (?).
691 - * @param mixed|null $box A box inside this object.
692 - *
693 - * @uses get_categories()
694 - * @uses get_category()
695 - * @uses get_option()
696 - * @uses maybe_unserialize()
697 - * @uses FeedWordPress::link_category_id()
698 - */
699 - function feed_information_box( $page, $box = NULL ) {
700 - $link_rss_params = maybe_unserialize( $page->setting( 'query parameters', '' ) );
701 - if ( ! is_array( $link_rss_params ) ) :
477 + }
478 +
479 + function feed_information_box ($page, $box = NULL) {
480 + global $wpdb;
481 + $link_rss_params = maybe_unserialize($page->setting('query parameters', ''));
482 + if (!is_array($link_rss_params)) :
702 483 $link_rss_params = array();
703 484 endif;
704 -
705 - if ( $page->for_feed_settings() ) :
706 - $info['name'] = esc_html( $page->link->link->link_name );
707 - $info['description'] = esc_html( $page->link->link->link_description );
708 - $info['url'] = esc_html( $page->link->link->link_url );
485 +
486 + if ($page->for_feed_settings()) :
487 + $info['name'] = esc_html($page->link->link->link_name);
488 + $info['description'] = esc_html($page->link->link->link_description);
489 + $info['url'] = esc_html($page->link->link->link_url);
709 490 $rss_url = $page->link->link->link_rss;
710 491
711 - $hardcode['name'] = $page->link->hardcode( 'name' );
712 - $hardcode['description'] = $page->link->hardcode( 'description' );
713 - $hardcode['url'] = $page->link->hardcode( 'url' );
492 + $hardcode['name'] = $page->link->hardcode('name');
493 + $hardcode['description'] = $page->link->hardcode('description');
494 + $hardcode['url'] = $page->link->hardcode('url');
714 495 else :
715 496 $cat_id = FeedWordPress::link_category_id();
716 497
717 498 $params = array();
718 - $params['taxonomy'] = 'link_category';
499 + if (FeedWordPressCompatibility::test_version(FWP_SCHEMA_USES_ARGS_TAXONOMY)) :
500 + $params['taxonomy'] = 'link_category';
501 + else :
502 + $params['type'] = 'link';
503 + endif;
719 504 $params['hide_empty'] = false;
720 - $results = get_categories( $params );
721 -
722 - /** var bool Guarantee that the Contributors category will be in the drop-down chooser, even if it is empty. */
505 + $results = get_categories($params);
506 +
507 + // Guarantee that the Contributors category will be in the drop-down chooser, even if it is empty.
723 508 $found_link_category_id = false;
724 - foreach ( $results as $row ) :
509 + foreach ($results as $row) :
725 510 // Normalize case
726 - if ( ! isset( $row->cat_id ) ) : $row->cat_id = $row->cat_ID; endif;
511 + if (!isset($row->cat_id)) : $row->cat_id = $row->cat_ID; endif;
727 512
728 - if ( $row->cat_id == $cat_id) : $found_link_category_id = true; endif;
513 + if ($row->cat_id == $cat_id) : $found_link_category_id = true; endif;
729 514 endforeach;
730 -
731 - if ( ! $found_link_category_id ) :
732 - $results[] = get_category( $cat_id );
515 +
516 + if (!$found_link_category_id) :
517 + $results[] = get_category($cat_id);
733 518 endif;
734 -
519 +
735 520 $info = array();
736 521 $rss_url = null;
737 522
738 - $hardcode['name'] = get_option( 'feedwordpress_hardcode_name' );
739 - $hardcode['description'] = get_option( 'feedwordpress_hardcode_description' );
740 - $hardcode['url'] = get_option( 'feedwordpress_hardcode_url' );
523 + $hardcode['name'] = get_option('feedwordpress_hardcode_name');
524 + $hardcode['description'] = get_option('feedwordpress_hardcode_description');
525 + $hardcode['url'] = get_option('feedwordpress_hardcode_url');
741 526 endif;
742 527
743 - /** @var bool Hide authentication (unused). */
744 528 $hideAuth = false;
745 529
746 - $username = $this->setting( 'http username', NULL );
530 + $username = $this->setting('http username', NULL);
747 531
748 - if ( is_null( $username ) ) :
532 + if (is_null($username)) :
749 533 $username = '';
750 534 $hideAuth = true;
751 535 endif;
752 -
753 - $password = $this->setting( 'http password', NULL );
754 - if ( is_null( $password ) ) :
536 +
537 + $password = $this->setting('http password', NULL);
538 + if (is_null($password)) :
755 539 $password = '';
756 540 endif;
541 +
542 + $auth = $this->setting('http auth method', NULL);
757 543
758 - $auth = $this->setting( 'http auth method', NULL );
544 + global $feedwordpress;
759 545
760 - if ( is_null( $auth ) or ( strlen( $auth ) == 0 ) ) :
546 + if (is_null($auth) or (strlen($auth)==0)) :
761 547 $auth = '-';
762 548 $hideAuth = true;
763 549 endif;
764 550
765 551 // Hey ho, let's go
766 -
552 +
767 553 ?>
768 554 <table class="edit-form">
769 555
770 - <?php if ( $page->for_feed_settings() ) : ?>
556 + <?php if ($page->for_feed_settings()) : ?>
771 557
772 558 <tr>
773 - <th scope="row"><?php esc_html_e( 'Feed URL:' ) ?></th>
774 - <td><a href="<?php echo esc_html( $rss_url ); ?>"><?php echo esc_html( $rss_url ); ?></a>
775 - (<a href="<?php echo esc_url( FEEDVALIDATOR_URI ); ?>?url=<?php echo urlencode( $rss_url ); ?>"
776 - title="<?php esc_html_e( 'Check feed' ); ?> &lt;<?php echo esc_html( $rss_url ); ?>&gt; <?php esc_html_e( 'for validity' ); ?>">validate</a>)
559 + <th scope="row"><?php _e('Feed URL:') ?></th>
560 + <td><a href="<?php echo esc_html($rss_url); ?>"><?php echo esc_html($rss_url); ?></a>
561 + (<a href="<?php echo FEEDVALIDATOR_URI; ?>?url=<?php echo urlencode($rss_url); ?>"
562 + title="Check feed &lt;<?php echo esc_html($rss_url); ?>&gt; for validity">validate</a>)
777 563 <input type="submit" name="feedfinder" value="switch &rarr;" style="font-size:smaller" />
778 -
779 - <?php $this->display_authentication_credentials_box( array(
780 - 'username' => $username,
781 - 'password' => $password,
782 - 'method' => $auth,
783 - )
784 - );
785 - ?>
564 +
565 + <?php $this->display_authentication_credentials_box(array(
566 + 'username' => $username,
567 + 'password' => $password,
568 + 'method' => $auth,
569 + )); ?>
570 +
786 571 <table id="link-rss-params">
787 572 <tbody>
788 573 <?php
789 - $link_rss_params['new'] = array( '', '' );
574 + $link_rss_params['new'] = array('', '');
790 575 $i = 0;
791 - foreach ( $link_rss_params as $index => $pair ) :
576 + foreach ($link_rss_params as $index => $pair) :
792 577 ?>
793 - <tr class="link-rss-params-row" id="link-rss-params-<?php print esc_attr($index); ?>">
794 - <td><label><?php esc_html_e( 'Parameter' ); ?>: <input type="text" class="link_params_key"
795 - name="link_rss_params_key[<?php print esc_attr( $index ); ?>]" value="<?php print esc_html( $pair[0] ); ?>"
578 + <tr class="link-rss-params-row" id="link-rss-params-<?php print $index; ?>">
579 + <td><label>Parameter: <input type="text" class="link_params_key"
580 + name="link_rss_params_key[<?php print $index; ?>]" value="<?php print esc_html($pair[0]); ?>"
796 581 size="5" style="width: 5em" placeholder="name" /></label></td>
797 582 <td class="link-rss-params-value-cell"><label class="link_params_value_label">= <input type="text" class="link_params_value"
798 - name="link_rss_params_value[<?php print esc_attr( $index ); ?>]" value="<?php print esc_html( $pair[1] ); ?>"
583 + name="link_rss_params_value[<?php print $index; ?>]" value="<?php print esc_html($pair[1]); ?>"
799 584 size="8" placeholder="value" /></label></td>
800 585 </tr>
801 586 <?php
802 587 $i++;
@@ -803,49 +588,44 @@
803 588 endforeach;
804 589 ?>
805 590 </tbody>
806 591 </table>
807 -
808 - <div><input type="hidden" id="link-rss-params-num" name="link_rss_params_num" value="<?php print esc_attr($i); ?>" /></div>
809 -
810 - <script>
811 - function linkParamsRowRemove( element ) {
812 - jQuery( element ).closest( 'tr' ).fadeOut(
813 - 'slow',
814 - function () {
815 - jQuery( this ).remove();
816 - }
817 - );
592 +
593 + <div><input type="hidden" id="link-rss-params-num" name="link_rss_params_num" value="<?php print $i; ?>" /></div>
594 +
595 + <script type="text/javascript">
596 + function linkParamsRowRemove (element) {
597 + jQuery(element).closest('tr').fadeOut('slow', function () {
598 + jQuery(this).remove();
599 + } );
818 600 }
819 601
820 - jQuery('<td><a href="#" class="add-remove link-rss-params-remove"><span class="x">(X)</span> <?php esc_html_e( 'Remove' ); ?></a></td>' ).insertAfter( '.link-rss-params-value-cell' );
602 + jQuery('<td><a href="#" class="add-remove link-rss-params-remove"><span class="x">(X)</span> Remove</a></td>').insertAfter('.link-rss-params-value-cell');
821 603
822 - jQuery( '#link-rss-params-new' ).hide();
823 - jQuery( '<a class="add-remove" id="link-rss-params-add" href="#"><span class="dashicons dashicons-plus fwp-no-underline"></span> <?php esc_html_e( 'Add a query parameter' ); ?></a>').insertAfter( '#link-rss-params' );
824 - jQuery( '#link-rss-params-add' ).click( function () {
825 - var next = jQuery( '#link-rss-params-num' ).val();
826 - var newRow = jQuery( '#link-rss-params-new' ).clone().attr( 'id', 'link-rss-params-' + next );
827 - newRow.find( '.link_params_key' ).attr( 'name', 'link_rss_params_key[' + next + ']' );
828 - newRow.find( '.link_params_value' ).attr( 'name', 'link_rss_params_value[' + next + ']' );
604 + jQuery('#link-rss-params-new').hide();
605 + jQuery('<a class="add-remove" id="link-rss-params-add" href="#">+ Add a query parameter</a>').insertAfter('#link-rss-params');
606 + jQuery('#link-rss-params-add').click( function () {
607 + var next = jQuery('#link-rss-params-num').val();
608 + var newRow = jQuery('#link-rss-params-new').clone().attr('id', 'link-rss-params-'+next);
609 + newRow.find('.link_params_key').attr('name', 'link_rss_params_key['+next+']');
610 + newRow.find('.link_params_value').attr('name', 'link_rss_params_value['+next+']');
611 +
612 + newRow.find('.link-rss-params-remove').click( function () {
613 + linkParamsRowRemove(this);
614 + return false;
615 + } );
829 616
830 - newRow.find( '.link-rss-params-remove' ).click(
831 - function () {
832 - linkParamsRowRemove( this );
833 - return false;
834 - }
835 - );
836 -
837 - newRow.appendTo( '#link-rss-params' );
617 + newRow.appendTo('#link-rss-params');
838 618 newRow.show();
839 -
619 +
840 620 // Update counter for next row.
841 621 next++;
842 - jQuery( '#link-rss-params-num' ).val( next );
622 + jQuery('#link-rss-params-num').val(next);
843 623
844 624 return false;
845 625 } );
846 - jQuery( '.link-rss-params-remove' ).click( function () {
847 - linkParamsRowRemove( this );
626 + jQuery('.link-rss-params-remove').click( function () {
627 + linkParamsRowRemove(this);
848 628 return false;
849 629 } );
850 630 </script>
851 631 </td>
@@ -852,38 +632,34 @@
852 632 </tr>
853 633
854 634 <?php
855 635 $rows = array(
856 - "name" => __('Link Name'),
636 + "name" => __('Link Name'),
857 637 "description" => __('Short Description'),
858 - "url" => __('Homepage'),
638 + "url" => __('Homepage'),
859 639 );
860 - foreach ( $rows as $what => $label ) :
861 - $hardcode_name = sanitize_html_class( sprintf( 'hardcode_%s', $what ) );
862 - $hardcode_id = sanitize_html_class( sprintf( 'basics-hardcode-%s', $what ) );
863 - $hardcode_view_id = sanitize_html_class( sprintf( 'basics-%s-view', $what ) );
864 - $hardcode_edit_id = sanitize_html_class( sprintf( 'basics-%s-edit', $what ) );
640 + foreach ($rows as $what => $label) :
865 641 ?>
866 642 <tr>
867 - <th scope="row"><?php print esc_html( $label ); ?></th>
643 + <th scope="row"><?php print $label ?></th>
868 644 <td>
869 - <div id="<?php print esc_attr( $hardcode_edit_id ); ?>"><input type="text" name="link<?php print esc_attr( $what ); ?>"
870 - value="<?php echo esc_attr( $info[$what] ); ?>" style="width: 95%" /></div>
871 - <div id="<?php print esc_attr( $hardcode_view_id ); ?>">
872 - <?php if ( 'url' == $what ) : ?><a href="<?php print esc_url( $info[$what] ); ?>"><?php else : ?><strong><?php endif; ?>
873 - <?php print ( strlen( trim( $info[$what] ) ) > 0 ) ? esc_attr( $info[$what] ) : esc_attr__( '(none provided)' ); ?>
874 - <?php if ( 'url' == $what ) : ?></a><?php else : ?></strong><?php endif; ?></div>
875 -
645 + <div id="basics-<?php print $what; ?>-edit"><input type="text" name="link<?php print $what; ?>"
646 + value="<?php echo $info[$what]; ?>" style="width: 95%" /></div>
647 + <div id="basics-<?php print $what; ?>-view">
648 + <?php if ($what=='url') : ?><a href="<?php print $info[$what]; ?>"><?php else : ?><strong><?php endif; ?>
649 + <?php print (strlen(trim($info[$what])) > 0) ? $info[$what] : '(none provided)'; ?>
650 + <?php if ($what=='url') : ?></a><?php else : ?></strong><?php endif; ?></div>
651 +
876 652 <div>
877 - <label><input id="<?php print esc_attr( $hardcode_id ); ?>"
878 - type="radio" name="<?php print esc_attr( $hardcode_name ); ?>" value="no"
879 - <?php echo ( ('yes' == $hardcode[$what] ) ? '' : ' checked="checked"');?>
880 - onchange="contextual_appearance( 'basics-hardcode-<?php print esc_attr( $what ); ?>', '<?php print esc_attr( $hardcode_view_id ); ?>', '<?php print esc_attr( $hardcode_edit_id ); ?>', 'no', 'block', /*checkbox=*/ true )"
881 - /> <?php esc_html_e( 'Update automatically from feed' ); ?></label>
882 - <label><input type="radio" name="<?php print esc_attr( $hardcode_name ); ?>" value="yes"
883 - <?php echo ( ( 'yes' != $hardcode[$what] ) ? '' : ' checked="checked"' );?>
884 - onchange="contextual_appearance('<?php print esc_attr( $hardcode_id ); ?>', '<?php print esc_attr( $hardcode_view_id ); ?>', '<?php print esc_attr( $hardcode_edit_id ); ?>', 'no', 'block', /*checkbox=*/ true)"
885 - /> <?php esc_html_e( 'Edit manually' ); ?></label>
653 + <label><input id="basics-hardcode-<?php print $what; ?>"
654 + type="radio" name="hardcode_<?php print $what; ?>" value="no"
655 + <?php echo (($hardcode[$what]=='yes')?'':' checked="checked"');?>
656 + onchange="contextual_appearance('basics-hardcode-<?php print $what; ?>', 'basics-<?php print $what; ?>-view', 'basics-<?php print $what; ?>-edit', 'no', 'block', /*checkbox=*/ true)"
657 + /> Update automatically from feed</label>
658 + <label><input type="radio" name="hardcode_<?php print $what; ?>" value="yes"
659 + <?php echo (($hardcode[$what]!='yes')?'':' checked="checked"');?>
660 + onchange="contextual_appearance('basics-hardcode-<?php print $what; ?>', 'basics-<?php print $what; ?>-view', 'basics-<?php print $what; ?>-edit', 'no', 'block', /*checkbox=*/ true)"
661 + /> Edit manually</label>
886 662 </div>
887 663 </td>
888 664 </tr>
889 665 <?php
@@ -892,41 +668,41 @@
892 668
893 669 <?php else : ?>
894 670
895 671 <tr>
896 - <th scope="row"><?php esc_html_e( 'Syndicated Link category:' ); ?></th>
672 + <th scope="row">Syndicated Link category:</th>
897 673 <td><p><select name="syndication_category" size="1">
898 674 <?php
899 - foreach ( $results as $row ) :
675 + foreach ($results as $row) :
900 676 // Normalize case
901 - if ( ! isset( $row->cat_id ) ) : $row->cat_id = $row->cat_ID; endif;
677 + if (!isset($row->cat_id)) : $row->cat_id = $row->cat_ID; endif;
902 678
903 - echo "\n\t" . '<option value="' . esc_attr( $row->cat_id ) . '"';
904 - if ( $row->cat_id == $cat_id) :
905 - echo ' selected="selected"';
679 + echo "\n\t<option value=\"$row->cat_id\"";
680 + if ($row->cat_id == $cat_id) :
681 + echo " selected='selected'";
906 682 endif;
907 - echo '>' . esc_attr( $row->cat_id ) . ': ' . esc_html( $row->cat_name );
908 - echo '</option>' . "\n";
683 + echo ">$row->cat_id: ".esc_html($row->cat_name);
684 + echo "</option>\n";
909 685 endforeach;
910 686 ?></select></p>
911 - <p class="setting-description"><?php esc_html_e( 'FeedWordPress will syndicate the
912 - links placed under this link category.' ); ?></p>
687 + <p class="setting-description">FeedWordPress will syndicate the
688 + links placed under this link category.</p>
913 689 </td>
914 690 </tr>
915 -
691 +
916 692 <tr>
917 - <th scope="row"><?php esc_html_e( 'Link Names:' ); ?></th>
918 - <td><label><input type="checkbox" name="hardcode_name" value="no"<?php echo ( ( 'yes' == $hardcode['name'] )? '' : ' checked="checked"' );?>/> <?php esc_html_e( 'Update contributor titles automatically when the feed title changes' ); ?></label></td>
693 + <th scope="row">Link Names:</th>
694 + <td><label><input type="checkbox" name="hardcode_name" value="no"<?php echo (($hardcode['name']=='yes')?'':' checked="checked"');?>/> Update contributor titles automatically when the feed title changes</label></td>
919 695 </tr>
920 -
696 +
921 697 <tr>
922 - <th scope="row"><?php esc_html_e( 'Short descriptions:' ); ?></th>
923 - <td><label><input type="checkbox" name="hardcode_description" value="no"<?php echo ( ( 'yes' == $hardcode['description'] ) ? '' : ' checked="checked"' );?>/> <?php esc_html_e( 'Update contributor descriptions automatically when the feed tagline changes' ); ?></label></td>
698 + <th scope="row">Short descriptions:</th>
699 + <td><label><input type="checkbox" name="hardcode_description" value="no"<?php echo (($hardcode['description']=='yes')?'':' checked="checked"');?>/> Update contributor descriptions automatically when the feed tagline changes</label></td>
924 700 </tr>
925 -
701 +
926 702 <tr>
927 - <th scope="row"><?php esc_html_e( 'Homepages:' ); ?></th>
928 - <td><label><input type="checkbox" name="hardcode_url" value="no"<?php echo ( ( 'yes' == $hardcode['url'] ) ? '' : ' checked="checked"' );?>/> <?php esc_html_e( 'Update contributor homepages automatically when the feed link changes' ); ?></label></td>
703 + <th scope="row">Homepages:</th>
704 + <td><label><input type="checkbox" name="hardcode_url" value="no"<?php echo (($hardcode['url']=='yes')?'':' checked="checked"');?>/> Update contributor homepages automatically when the feed link changes</label></td>
929 705 </tr>
930 706
931 707 <?php endif; ?>
932 708
@@ -933,16 +709,16 @@
933 709 </table>
934 710 <?php
935 711 } /* FeedWordPressFeedsPage::feed_information_box() */
936 712
937 -
938 - function custom_settings_box( $page, $box = NULL ) {
713 + function custom_settings_box ($page, $box = NULL) {
939 714 $postsSettings = $this->admin_page_href('posts-page.php', array(), $page->link);
940 715 ?>
941 716 <p class="setting-description">These custom settings are special fields for the <strong>feed</strong> you are
942 717 syndicating, to be retrieved in templates using the <code>get_feed_meta()</code> function. They do not create
943 718 custom fields on syndicated <strong>posts</strong>. If you want to create custom fields that are applied to each
944 - individual post from this feed, set up the settings in <a href="<?php print esc_url($postsSettings); ?>">Syndicated Posts</a>.</p>
719 + individual post from this feed, set up the settings in <a href="<?php print $postsSettings; ?>">Syndicated Posts</a>.</p>
720 +
945 721 <div id="postcustomstuff">
946 722 <table id="meta-list" cellpadding="3">
947 723 <tr>
948 724 <th>Key</th>
@@ -948,19 +724,19 @@
948 724 <th>Key</th>
949 725 <th>Value</th>
950 726 <th>Action</th>
951 727 </tr>
952 -
728 +
953 729 <?php
954 730 $i = 0;
955 731 foreach ($page->link->settings as $key => $value) :
956 - if ( !preg_match("\007^((".implode(')|(', $page->special_settings)."))$\007i", $key)) :
732 + if (!preg_match("\007^((".implode(')|(', $page->special_settings)."))$\007i", $key)) :
957 733 ?>
958 734 <tr style="vertical-align:top">
959 - <th width="30%" scope="row"><input type="hidden" name="notes[<?php echo esc_attr($i); ?>][key0]" value="<?php echo esc_html($key); ?>" />
960 - <input id="notes-<?php echo esc_attr($i); ?>-key" name="notes[<?php echo esc_attr($i); ?>][key1]" value="<?php echo esc_html($key); ?>" /></th>
961 - <td width="60%"><textarea rows="2" cols="40" id="notes-<?php echo esc_attr($i); ?>-value" name="notes[<?php echo esc_attr($i); ?>][value]"><?php echo esc_html($value); ?></textarea></td>
962 - <td width="10%"><select name="notes[<?php echo esc_attr($i); ?>][action]">
735 + <th width="30%" scope="row"><input type="hidden" name="notes[<?php echo $i; ?>][key0]" value="<?php echo esc_html($key); ?>" />
736 + <input id="notes-<?php echo $i; ?>-key" name="notes[<?php echo $i; ?>][key1]" value="<?php echo esc_html($key); ?>" /></th>
737 + <td width="60%"><textarea rows="2" cols="40" id="notes-<?php echo $i; ?>-value" name="notes[<?php echo $i; ?>][value]"><?php echo esc_html($value); ?></textarea></td>
738 + <td width="10%"><select name="notes[<?php echo $i; ?>][action]">
963 739 <option value="update">save changes</option>
964 740 <option value="delete">delete this setting</option>
965 741 </select></td>
966 742 </tr>
@@ -969,11 +745,11 @@
969 745 endif;
970 746 endforeach;
971 747 ?>
972 748 <tr>
973 - <th scope="row"><input type="text" size="10" name="notes[<?php echo esc_attr( $i ); ?>][key1]" value="" /></th>
974 - <td><textarea name="notes[<?php echo esc_attr( $i ); ?>][value]" rows="2" cols="40"></textarea></td>
975 - <td><em>add new setting...</em><input type="hidden" name="notes[<?php echo esc_attr( $i ); ?>][action]" value="update" /></td>
749 + <th scope="row"><input type="text" size="10" name="notes[<?php echo $i; ?>][key1]" value="" /></th>
750 + <td><textarea name="notes[<?php echo $i; ?>][value]" rows="2" cols="40"></textarea></td>
751 + <td><em>add new setting...</em><input type="hidden" name="notes[<?php echo $i; ?>][action]" value="update" /></td>
976 752 </tr>
977 753 </table>
978 754 </div> <!-- id="postcustomstuff" -->
979 755 <?php
@@ -983,9 +759,9 @@
983 759 $ret = NULL;
984 760 if (is_wp_error($err)) :
985 761 if ($err->get_error_code()=='http_request_failed') :
986 762 $data = $err->get_error_data('http_request_failed');
987 -
763 +
988 764 if (is_array($data) and isset($data['status'])) :
989 765 if (401==$data['status']) :
990 766 $ret = $data['uri'];
991 767 endif;
@@ -993,15 +769,17 @@
993 769 endif;
994 770 endif;
995 771 return $ret;
996 772 }
997 -
773 +
998 774 function display_feedfinder () {
999 - $lookup = FeedWordPress::param( 'lookup' );
1000 -
1001 - $auth = FeedWordPress::param( 'link_rss_auth_method' );
1002 - $username = FeedWordPress::param( 'link_rss_username' );
1003 - $password = FeedWordPress::param( 'link_rss_password' );
775 + global $wpdb;
776 +
777 + $lookup = (isset($_REQUEST['lookup']) ? $_REQUEST['lookup'] : NULL);
778 +
779 + $auth = MyPHP::request('link_rss_auth_method');
780 + $username = MyPHP::request('link_rss_username');
781 + $password = MyPHP::request('link_rss_password');
1004 782 $credentials = array(
1005 783 "authentication" => $auth,
1006 784 "username" => $username,
1007 785 "password" => $password,
@@ -1018,21 +796,21 @@
1018 796 $lookup = $this->link->link->link_url;
1019 797 $auth = $this->link->setting('http auth method');
1020 798 $username = $this->link->setting('http username');
1021 799 $password = $this->link->setting('http password');
1022 -
800 +
1023 801 // Guarantee that you at least have the option to
1024 802 // stick with what works.
1025 803 $current = $this->link->link->link_rss;
1026 804 $feeds[] = $current;
1027 805 endif;
1028 - $name = $this->link->link->link_name;
806 + $name = esc_html($this->link->link->link_name);
1029 807 else: // Or a new subscription to add?
1030 - $name = "Subscribe to ".feedwordpress_display_url($lookup);
808 + $name = "Subscribe to <code>".esc_html(feedwordpress_display_url($lookup))."</code>";
1031 809 endif;
1032 810 ?>
1033 811 <div class="wrap" id="feed-finder">
1034 - <h2>Feed Finder: <?php echo esc_html($name); ?></h2>
812 + <h2>Feed Finder: <?php echo $name; ?></h2>
1035 813
1036 814 <?php
1037 815 if ($feedSwitch) :
1038 816 $this->display_alt_feed_box($lookup);
@@ -1038,23 +816,23 @@
1038 816 $this->display_alt_feed_box($lookup);
1039 817 endif;
1040 818
1041 819 $finder = array();
1042 - if ( !is_null($current)) :
820 + if (!is_null($current)) :
1043 821 $finder[$current] = new FeedFinder($current);
1044 822 endif;
1045 823 $finder[$lookup] = new FeedFinder($lookup);
1046 -
824 +
1047 825 foreach ($finder as $url => $ff) :
1048 826 $feeds = array_merge($feeds, $ff->find(
1049 827 /*url=*/ NULL,
1050 828 /*params=*/ $credentials));
1051 829 endforeach;
1052 -
830 +
1053 831 $feeds = array_values( // Renumber from 0..(N-1)
1054 832 $feeds
1055 833 );
1056 -
834 +
1057 835 // Allow for some simple FeedFinder results filtering
1058 836 $feeds = apply_filters(
1059 837 'feedwordpress_feedfinder_results',
1060 838 $feeds,
@@ -1066,9 +844,9 @@
1066 844 "finder" => $finder,
1067 845 ),
1068 846 $this
1069 847 );
1070 -
848 +
1071 849 if (count($feeds) > 0):
1072 850 if ($feedSwitch) :
1073 851 ?>
1074 852 <h3>Feeds Found</h3>
@@ -1076,9 +854,9 @@
1076 854 endif;
1077 855
1078 856 if (count($feeds) > 1) :
1079 857 $option_template = 'Option %d: ';
1080 - $form_class = 'multi';
858 + $form_class = ' class="multi"';
1081 859 ?>
1082 860 <p><strong>This web page provides at least <?php print count($feeds); ?> different feeds.</strong> These feeds may provide the same information
1083 861 in different formats, or may track different items. (You can check the Feed Information and the
1084 862 Sample Item for each feed to get an idea of what the feed provides.) Please select the feed that you'd like to subscribe to.</p>
@@ -1088,15 +866,15 @@
1088 866 $form_class = '';
1089 867 endif;
1090 868
1091 869 global $fwp_credentials;
1092 -
870 +
1093 871 foreach ($feeds as $key => $f):
1094 872 $ofc = $fwp_credentials;
1095 873 $fwp_credentials = $credentials; // Set
1096 874 $pie = FeedWordPress::fetch($f, array("cache" => false));
1097 875 $fwp_credentials = $ofc; // Re-Set
1098 -
876 +
1099 877 $rss = (is_wp_error($pie) ? $pie : new MagpieFromSimplePie($pie));
1100 878
1101 879 if ($this->url_for_401($pie)) :
1102 880 $this->display_alt_feed_box($lookup, array(
@@ -1106,9 +884,9 @@
1106 884 "password" => $password
1107 885 ));
1108 886 continue;
1109 887 endif;
1110 -
888 +
1111 889 if ($rss and !is_wp_error($rss)):
1112 890 $feed_link = (isset($rss->channel['link'])?$rss->channel['link']:'');
1113 891 $feed_title = (isset($rss->channel['title'])?$rss->channel['title']:$feed_link);
1114 892 $feed_type = ($rss->feed_type ? $rss->feed_type : 'Unknown');
@@ -1122,14 +900,14 @@
1122 900 $feed_version_template = '';
1123 901 $feed_version = '';
1124 902 endif;
1125 903 ?>
1126 - <form <?php fwp_form_class_attr($form_class); ?> action="<?php print esc_url( $this->form_action( 'syndication.php' ) ); ?>" method="post">
904 + <form<?php print $form_class; ?> action="<?php print $this->form_action('syndication.php'); ?>" method="post">
1127 905 <div class="inside"><?php FeedWordPressCompatibility::stamp_nonce('feedwordpress_switchfeed'); ?>
1128 906
1129 907 <?php
1130 908 $classes = array('feed-found'); $currentFeed = '';
1131 - if ( !is_null($current) and $current==$f) :
909 + if (!is_null($current) and $current==$f) :
1132 910 $classes[] = 'current';
1133 911 $currentFeed = ' (currently subscribed)';
1134 912 endif;
1135 913 if ($key%2) :
@@ -1135,10 +913,10 @@
1135 913 if ($key%2) :
1136 914 $classes[] = 'alt';
1137 915 endif;
1138 916 ?>
1139 - <fieldset class="<?php print esc_attr( implode(" ", $classes) ); ?>">
1140 - <legend><?php print esc_html( sprintf( $option_template, ( $key + 1 ) ) ); print esc_html($feed_type) . " "; print esc_html( sprintf( $feed_version_template, $feed_version ) ); ?> feed<?php print esc_html( $currentFeed ); ?></legend>
917 + <fieldset class="<?php print implode(" ", $classes); ?>">
918 + <legend><?php printf($option_template, ($key+1)); print $feed_type." "; printf($feed_version_template, $feed_version); ?> feed<?php print $currentFeed; ?></legend>
1141 919
1142 920 <?php
1143 921 $this->stamp_link_id();
1144 922
@@ -1144,9 +922,9 @@
1144 922
1145 923 // No feed specified = add new feed; we
1146 924 // need to pass along a starting title
1147 925 // and homepage URL for the new Link.
1148 - if ( ! $this->for_feed_settings()):
926 + if (!$this->for_feed_settings()):
1149 927 ?>
1150 928 <input type="hidden" name="feed_title" value="<?php echo esc_html($feed_title); ?>" />
1151 929 <input type="hidden" name="feed_link" value="<?php echo esc_html($feed_link); ?>" />
1152 930 <?php
@@ -1158,11 +936,11 @@
1158 936
1159 937 <div>
1160 938 <div class="feed-sample">
1161 939 <?php
1162 - $link = null;
1163 - $post = null;
1164 - if ( !is_wp_error($rss) && !empty($rss->items) && is_array($rss->items) ):
940 + $link = NULL;
941 + $post = NULL;
942 + if (!is_wp_error($rss) and count($rss->items) > 0):
1165 943 // Prepare to display Sample Item
1166 944 $link = new MagpieMockLink(array('simplepie' => $pie, 'magpie' => $rss), $f);
1167 945 $post = new SyndicatedPost(array('simplepie' => $rss->originals[0], 'magpie' => $rss->items[0]), $link);
1168 946 ?>
@@ -1167,13 +945,13 @@
1167 945 $post = new SyndicatedPost(array('simplepie' => $rss->originals[0], 'magpie' => $rss->items[0]), $link);
1168 946 ?>
1169 947 <h3>Sample Item</h3>
1170 948 <ul>
1171 - <li><strong>Title:</strong> <a href="<?php echo esc_url( $post->post['meta']['syndication_permalink'] ); ?>"><?php echo esc_html( $post->post['post_title'] ); ?></a></li>
1172 - <li><strong>Date:</strong> <?php print esc_html( date('d-M-y g:i:s a', $post->published() ) ); ?></li>
949 + <li><strong>Title:</strong> <a href="<?php echo $post->post['meta']['syndication_permalink']; ?>"><?php echo $post->post['post_title']; ?></a></li>
950 + <li><strong>Date:</strong> <?php print date('d-M-y g:i:s a', $post->published()); ?></li>
1173 951 </ul>
1174 952 <div class="entry">
1175 - <?php print wp_kses( $post->post['post_content'], 'post' ); ?>
953 + <?php print $post->post['post_content']; ?>
1176 954 </div>
1177 955 <?php
1178 956 do_action('feedwordpress_feed_finder_sample_item', $f, $post, $link);
1179 957 else:
@@ -1181,9 +959,9 @@
1181 959 print '<div class="feed-problem">';
1182 960 print "<h3>Problem:</h3>\n";
1183 961 print "<p>FeedWordPress encountered the following error
1184 962 when trying to retrieve this feed:</p>";
1185 - print '<p style="margin: 1.0em 3.0em"><code>' . esc_html( $rss->get_error_message() ) . '</code></p>';
963 + print '<p style="margin: 1.0em 3.0em"><code>'.$rss->get_error_message().'</code></p>';
1186 964 print "<p>If you think this is a temporary problem, you can still force FeedWordPress to add the subscription. FeedWordPress will not be able to find any syndicated posts until this problem is resolved.</p>";
1187 965 print "</div>";
1188 966 endif;
1189 967 ?>
@@ -1192,16 +970,16 @@
1192 970 <?php
1193 971 endif;
1194 972 ?>
1195 973 </div>
1196 -
974 +
1197 975 <div>
1198 976 <h3>Feed Information</h3>
1199 977 <ul>
1200 - <li><strong>Homepage:</strong> <a href="<?php echo esc_url( $feed_link ); ?>"><?php echo is_null( $feed_title )?'<em>Unknown</em>': esc_html( $feed_title ); ?></a></li>
1201 - <li><strong>Feed URL:</strong> <a title="<?php echo esc_html( $f ); ?>" href="<?php echo esc_url( $f ); ?>"><?php echo esc_html( feedwordpress_display_url($f, 40, 10) ); ?></a> (<a title="Check feed &lt;<?php echo esc_html( $f ); ?>&gt; for validity" href="http://feedvalidator.org/check.cgi?url=<?php echo urlencode( $f ); ?>">validate</a>)</li>
1202 - <li><strong>Encoding:</strong> <?php echo isset($rss->encoding) ? esc_html($rss->encoding) : "<em>Unknown</em>"; ?></li>
1203 - <li><strong>Description:</strong> <?php echo isset($rss->channel['description']) ? esc_html($rss->channel['description']) : "<em>Unknown</em>"; ?></li>
978 + <li><strong>Homepage:</strong> <a href="<?php echo $feed_link; ?>"><?php echo is_null($feed_title)?'<em>Unknown</em>':$feed_title; ?></a></li>
979 + <li><strong>Feed URL:</strong> <a title="<?php echo esc_html($f); ?>" href="<?php echo esc_html($f); ?>"><?php echo esc_html(feedwordpress_display_url($f, 40, 10)); ?></a> (<a title="Check feed &lt;<?php echo esc_html($f); ?>&gt; for validity" href="http://feedvalidator.org/check.cgi?url=<?php echo urlencode($f); ?>">validate</a>)</li>
980 + <li><strong>Encoding:</strong> <?php echo isset($rss->encoding)?esc_html($rss->encoding):"<em>Unknown</em>"; ?></li>
981 + <li><strong>Description:</strong> <?php echo isset($rss->channel['description'])?esc_html($rss->channel['description']):"<em>Unknown</em>"; ?></li>
1204 982 </ul>
1205 983 <?php $this->display_authentication_credentials_box(array(
1206 984 'username' => $username,
1207 985 'password' => $password,
@@ -1220,58 +998,53 @@
1220 998 unset($post);
1221 999 endforeach;
1222 1000 else:
1223 1001 foreach ($finder as $url => $ff) :
1224 - print '<h3>Searched for feeds at '. esc_html( $url ) . '</h3>' . "\n";
1225 - print '<p><strong>' . esc_html__( 'Error' ) . ':</strong> ' . esc_html__( 'FeedWordPress couldn\'t find any feeds at' ).' <code><a href="' . esc_url( $lookup ) . '">' . esc_html( $lookup ) . '</a></code>';
1226 - print '. ' . esc_html__( 'Try another URL' ) . '.</p>';
1227 -
1002 + $url = esc_html($url);
1003 + print "<h3>Searched for feeds at ${url}</h3>\n";
1004 + print "<p><strong>".__('Error').":</strong> ".__("FeedWordPress couldn't find any feeds at").' <code><a href="'.htmlspecialchars($lookup).'">'.htmlspecialchars($lookup).'</a></code>';
1005 + print ". ".__('Try another URL').".</p>";
1006 +
1228 1007 // Diagnostics
1229 1008 print "<div class=\"updated\" style=\"margin-left: 3.0em; margin-right: 3.0em;\">\n";
1230 - print '<h3>' . esc_html__( 'Diagnostic information' ) . '</h3>' . "\n";
1231 - if ( !is_null($ff->error()) and strlen($ff->error()) > 0) :
1232 - print '<h4>'. esc_html__( 'HTTP request failure' ) . '</h4>' . "\n";
1233 - print '<p>' . esc_html( $ff->error() ) ."</p>\n";
1009 + print "<h3>".__('Diagnostic information')."</h3>\n";
1010 + if (!is_null($ff->error()) and strlen($ff->error()) > 0) :
1011 + print "<h4>".__('HTTP request failure')."</h4>\n";
1012 + print "<p>".$ff->error()."</p>\n";
1234 1013 else :
1235 - print '<h4>' . esc_html__( 'HTTP request completed' ) . '</h4>' . "\n";
1236 - print '<p><strong>Status ' . esc_html( $ff->status() ) . ':</strong> '. esc_html( $this->HTTPStatusMessages[ (int) $ff->status() ] ) ."</p>\n";
1014 + print "<h4>".__('HTTP request completed')."</h4>\n";
1015 + print "<p><strong>Status ".$ff->status().":</strong> ".$this->HTTPStatusMessages[(int) $ff->status()]."</p>\n";
1237 1016 endif;
1238 1017
1239 1018 // Do some more diagnostics if the API for it is available.
1240 - // Note to @radgeek: consider using a hook instead: https://developer.wordpress.org/reference/hooks/http_api_transports/ (gwyneth 20230920)
1241 - if ( function_exists( '_wp_http_get_object' ) ) :
1019 + if (function_exists('_wp_http_get_object')) :
1242 1020 $httpObject = _wp_http_get_object();
1243 -
1244 - /*
1245 - // _getTransport() was totally deprecated (gwyneth 20230920)
1021 +
1246 1022 if (is_callable(array($httpObject, '_getTransport'))) :
1247 -
1248 1023 $transports = $httpObject->_getTransport();
1249 -
1024 +
1250 1025 print "<h4>".__('HTTP Transports available').":</h4>\n";
1251 1026 print "<ol>\n";
1252 1027 print "<li>".implode("</li>\n<li>", array_map('get_class', $transports))."</li>\n";
1253 1028 print "</ol>\n";
1254 - else
1255 - */
1256 - if ( is_callable( array( $httpObject, '_get_first_available_transport' ) ) ) :
1029 + elseif (is_callable(array($httpObject, '_get_first_available_transport'))) :
1257 1030 $transport = $httpObject->_get_first_available_transport(
1258 1031 array(),
1259 1032 $url
1260 1033 );
1261 -
1262 - print "<h4>" . esc_html__("HTTP Transport") . ":</h4>\n";
1034 +
1035 + print "<h4>".__("HTTP Transport").":</h4>\n";
1263 1036 print "<ol>\n";
1264 - print "<li>" . esc_html( MyPHP::val($transport) ) . "</li>\n";
1037 + print "<li>".MyPHP::val($transport)."</li>\n";
1265 1038 print "</ol>\n";
1266 1039 endif;
1267 -
1040 +
1268 1041 print "</div>\n";
1269 1042 endif;
1270 1043 endforeach;
1271 1044 endif;
1272 -
1273 - if ( ! $feedSwitch) :
1045 +
1046 + if (!$feedSwitch) :
1274 1047 $this->display_alt_feed_box($lookup, /*alt=*/ true);
1275 1048 endif;
1276 1049 ?>
1277 1050 </div> <!-- class="wrap" -->
@@ -1278,14 +1051,15 @@
1278 1051 <?php
1279 1052 return false; // Don't continue
1280 1053 } /* FeedWordPressFeedsPage::display_feedfinder() */
1281 1054
1282 - function display_alt_feed_box ($lookup, $params = false)
1283 - {
1055 + function display_alt_feed_box ($lookup, $params = false) {
1056 + global $fwp_post;
1057 +
1284 1058 if (is_bool($params)) :
1285 1059 $params = array("alt" => $params);
1286 1060 endif;
1287 -
1061 +
1288 1062 $params = wp_parse_args($params, array( // Defaults
1289 1063 "alt" => false,
1290 1064 "err" => NULL,
1291 1065 "auth" => NULL,
@@ -1292,16 +1066,16 @@
1292 1066 "password" => NULL,
1293 1067 "username" => NULL,
1294 1068 ));
1295 1069 $alt = $params['alt'];
1296 -
1070 +
1297 1071 ?>
1298 - <form action="<?php print esc_url( $this->form_action('syndication.php') ); ?>" method="post">
1072 + <form action="<?php print $this->form_action('syndication.php'); ?>" method="post">
1299 1073 <div class="inside"><?php
1300 1074 FeedWordPressCompatibility::stamp_nonce('feedwordpress_feeds');
1301 1075 ?>
1302 1076 <fieldset class="alt"
1303 - <?php if ( ! $alt): ?>style="margin: 1.0em 3.0em; font-size: smaller;"<?php endif; ?>>
1077 + <?php if (!$alt): ?>style="margin: 1.0em 3.0em; font-size: smaller;"<?php endif; ?>>
1304 1078 <legend><?php if ($alt) : ?>Alternative feeds<?php else: ?>Find feeds<?php endif; ?></legend>
1305 1079 <?php if ($alt) : ?><h3>Use a different feed</h3><?php endif; ?>
1306 1080 <?php if (is_wp_error($params['err'])) :
1307 1081 ?>
@@ -1338,39 +1112,32 @@
1338 1112 will try to automatically detect any feeds associated with a
1339 1113 website.</p>
1340 1114 </div> <!-- class="inside" -->
1341 1115 </fieldset></form>
1342 -
1116 +
1343 1117 <?php
1344 1118 } /* FeedWordPressFeedsPage::display_alt_feed_box() */
1345 -
1346 - function save_settings () {
1119 +
1120 + function save_settings ($post) {
1347 1121 if ($this->for_feed_settings()) :
1348 - $params_key = FeedWordPress::post( 'link_rss_params_key', array() );
1349 -
1350 - if ( is_array( $params_key ) && count($params_key) > 0 ) :
1351 - $params_values = FeedWordPress::post( 'link_rss_params_value', array() );
1122 +
1123 + if (isset($post['link_rss_params_key'])) :
1352 1124 $qp = array();
1353 - foreach ( $params_key as $index => $key ) :
1125 + foreach ($post['link_rss_params_key'] as $index => $key) :
1354 1126 if (strlen($key) > 0) :
1355 -
1356 - if ( isset( $params_values[ $index ] ) ) :
1357 -
1358 - $params_value = $params_values[ $index ];
1359 - if ( strlen($params_value) > 0 ) :
1360 - $qp[] = array( $key, $params_value );
1361 - endif;
1127 + if (isset($post['link_rss_params_value'][$index])
1128 + and strlen($post['link_rss_params_value'][$index])) :
1129 + $value = $post['link_rss_params_value'][$index];
1130 + $qp[] = array($key, $value);
1362 1131 endif;
1363 1132 endif;
1364 1133 endforeach;
1365 1134 $this->update_setting('query parameters', serialize($qp));
1366 -
1367 1135 endif;
1368 -
1136 +
1369 1137 // custom feed settings first
1370 - $param_notes = FeedWordPress::post( 'notes', array() );
1371 - foreach ( $param_notes as $mn ) :
1372 - $mn['key0'] = ( isset($mn['key0']) ? trim($mn['key0']) : null );
1138 + foreach ($post['notes'] as $mn) :
1139 + $mn['key0'] = (isset($mn['key0']) ? trim($mn['key0']) : NULL);
1373 1140 $mn['key1'] = trim($mn['key1']);
1374 1141 if (preg_match("\007^(("
1375 1142 .implode(')|(',$this->special_settings)
1376 1143 ."))$\007i",
@@ -1380,138 +1147,123 @@
1380 1147
1381 1148 if (strlen($mn['key0']) > 0) :
1382 1149 unset($this->link->settings[$mn['key0']]); // out with the old
1383 1150 endif;
1384 -
1151 +
1385 1152 if (($mn['action']=='update') and (strlen($mn['key1']) > 0)) :
1386 1153 $this->link->settings[$mn['key1']] = $mn['value']; // in with the new
1387 1154 endif;
1388 1155 endforeach;
1389 -
1156 +
1390 1157 // now stuff through the web form
1391 1158 // hardcoded feed info
1392 -
1159 +
1393 1160 foreach (array('name', 'description', 'url') as $what) :
1394 1161 // We have a checkbox for "No," so if it's unchecked, mark as "Yes."
1395 - $this->link->settings["hardcode {$what}"] = FeedWordPress::post( "hardcode_{$what}", 'yes' );
1162 + $this->link->settings["hardcode {$what}"] = (isset($post["hardcode_{$what}"]) ? $post["hardcode_{$what}"] : 'yes');
1396 1163 if (FeedWordPress::affirmative($this->link->settings, "hardcode {$what}")) :
1397 - $this->link->link->{'link_'.$what} = FeedWordPress::post( 'link' . $what );
1164 + $this->link->link->{'link_'.$what} = $post['link'.$what];
1398 1165 endif;
1399 1166 endforeach;
1400 -
1167 +
1401 1168 // Update scheduling
1402 - $update_schedule = FeedWordPress::post( 'update_schedule' );
1403 - if ( ! is_null( $update_schedule ) ) :
1404 - $this->link->settings['update/hold'] = $update_schedule;
1169 + if (isset($post['update_schedule'])) :
1170 + $this->link->settings['update/hold'] = $post['update_schedule'];
1405 1171 endif;
1406 1172
1407 - $use_default_update_window = FeedWordPress::post( 'use_default_update_window' );
1408 - $update_window = FeedWordPress::post( 'update_window' );
1409 - if ( FeedWordPress::affirmative( $use_default_update_window ) ) :
1173 + if (isset($post['use_default_update_window']) and strtolower($post['use_default_update_window'])=='yes') :
1410 1174 unset($this->link->settings['update/window']);
1411 - elseif ( ! is_null( $update_window ) ) :
1412 - $update_window = intval( $update_window );
1413 - if ( $update_window > 0 ) :
1414 - $this->link->settings['update/window'] = $update_window;
1175 + elseif (isset($post['update_window'])):
1176 + if ((int) $post['update_window'] > 0) :
1177 + $this->link->settings['update/window'] = (int) $post['update_window'];
1415 1178 endif;
1416 1179 endif;
1417 -
1180 +
1418 1181 else :
1419 1182 // Global
1420 - update_option('feedwordpress_cat_id', FeedWordPress::post( 'syndication_category' ) );
1421 -
1422 - $automatic_updates = FeedWordPress::post( 'automatic_updates' );
1423 - if ( ! in_array( $automatic_updates, array( 'init', 'shutdown' ) ) ) :
1424 - $automatic_updates = null;
1183 + update_option('feedwordpress_cat_id', $post['syndication_category']);
1184 +
1185 + if (!isset($post['automatic_updates']) or !in_array($post['automatic_updates'], array('init', 'shutdown'))) :
1186 + $automatic_updates = NULL;
1187 + else :
1188 + $automatic_updates = $post['automatic_updates'];
1425 1189 endif;
1426 1190 update_option('feedwordpress_automatic_updates', $automatic_updates);
1427 1191
1428 - $update_window = FeedWordPress::post( 'update_window' );
1429 - if ( ! is_null( $update_window ) ) :
1430 - $update_window = intval( $update_window );
1431 - if ( $update_window > 0 ) :
1432 - update_option( 'feedwordpress_update_window', $update_window );
1192 + if (isset($post['update_window'])):
1193 + if ((int) $post['update_window'] > 0) :
1194 + update_option('feedwordpress_update_window', (int) $post['update_window']);
1433 1195 endif;
1434 1196 endif;
1435 1197
1436 - $update_time_limit = FeedWordPress::post( 'update_time_limit' );
1437 - $time_limit_seconds = 0;
1438 - if ( FeedWordPress::affirmative( $update_time_limit ) ) :
1439 - $time_limit_seconds = intval( FeedWordPress::post( 'time_limit_seconds' ) );
1440 - endif;
1441 - update_option( 'feedwordpress_update_time_limit', $time_limit_seconds );
1198 + update_option('feedwordpress_update_time_limit', ($post['update_time_limit']=='yes')?(int) $post['time_limit_seconds']:0);
1442 1199
1443 1200 foreach (array('name', 'description', 'url') as $what) :
1444 1201 // We have a checkbox for "No," so if it's unchecked, mark as "Yes."
1445 - $hardcode = FeedWordPress::post( "hardcode_{$what}", 'yes' );
1446 - update_option( "feedwordpress_hardcode_{$what}", $hardcode );
1202 + $hardcode = (isset($post["hardcode_{$what}"]) ? $post["hardcode_{$what}"] : 'yes');
1203 + update_option("feedwordpress_hardcode_{$what}", $hardcode);
1447 1204 endforeach;
1448 -
1205 +
1449 1206 endif;
1450 -
1451 - $update_pause = FeedWordPress::post( 'update_pause' );
1452 - if ( ! is_null( $update_pause ) ) :
1453 - $this->update_setting( 'update/pause', $update_pause );
1454 - endif;
1455 -
1456 - $fetch_timeout = FeedWordPress::post( 'fetch_timeout' );
1457 - if ( ! is_null( $fetch_timeout ) ) :
1458 - $fetch_timeout_default = FeedWordPress::post( 'fetch_timeout_default' );
1459 - if ( FeedWordPress::affirmative( $fetch_timeout_default ) ) :
1460 - $fetch_timeout = null;
1207 +
1208 + if (isset($post['fetch_timeout'])) :
1209 + if (isset($post['fetch_timeout_default']) and $post['fetch_timeout_default']=='yes') :
1210 + $timeout = NULL;
1211 + else :
1212 + $timeout = $post['fetch_timeout'];
1461 1213 endif;
1462 1214
1463 - if ( is_int( $fetch_timeout ) ) :
1464 - $fetch_timeout = intval( $fetch_timeout );
1215 + if (is_int($timeout)) :
1216 + $timeout = intval($timeout);
1465 1217 endif;
1466 - $this->update_setting( 'fetch timeout', $fetch_timeout );
1218 + $this->update_setting('fetch timeout', $timeout);
1467 1219 endif;
1468 -
1469 - $update_incremental = FeedWordPress::post( 'update_incremental' );
1470 - if ( ! is_null( $update_incremental ) ) :
1471 - $this->update_setting( 'update_incremental', $update_incremental );
1220 +
1221 + if (isset($post['update_incremental'])) :
1222 + $this->update_setting('update_incremental', $post['update_incremental']);
1472 1223 endif;
1473 1224
1474 - $tombstones = FeedWordPress::post( 'tombstones' );
1475 - if ( ! is_null( $tombstones ) ) :
1476 - $this->update_setting('tombstones', $tombstones );
1225 + if (isset($post['tombstones'])) :
1226 + $this->update_setting('tombstones', $post['tombstones']);
1477 1227 endif;
1478 1228
1479 - $update_minimum = FeedWordPress::post( 'update_minimum' );
1480 - if ( ! is_null( $update_minimum ) ) :
1481 - $this->update_setting( 'update/minimum', $update_minimum );
1229 + if (isset($post['update_minimum'])) :
1230 + $this->update_setting('update/minimum', $post['update_minimum']);
1482 1231 endif;
1483 1232
1484 - $link_rss_auth_method = FeedWordPress::post( 'link_rss_auth_method' );
1485 1233 if (
1486 - ! $link_rss_auth_method
1487 - || '-' == $link_rss_auth_method
1234 + isset($post['link_rss_auth_method'])
1235 + and $post['link_rss_auth_method']
1236 + and ('-' != $post['link_rss_auth_method'])
1488 1237 ) :
1489 - $link_rss_auth_method = null;
1238 + $this->update_setting('http auth method', $post['link_rss_auth_method']);
1239 + else :
1240 + $this->update_setting('http auth method', NULL);
1490 1241 endif;
1491 - $this->update_setting( 'http auth method', $link_rss_auth_method );
1492 -
1493 - $link_rss_username = FeedWordPress::post( 'link_rss_username' );
1242 +
1494 1243 if (
1495 - ! $link_rss_username
1496 - || is_null( $link_rss_auth_method )
1244 + isset($post['link_rss_username'])
1245 + and (strlen($post['link_rss_username']) > 0)
1246 + and ('-' != $post['link_rss_auth_method'])
1497 1247 ) :
1498 - $link_rss_username = null;
1248 + $this->update_setting('http username', $post['link_rss_username']);
1249 + else :
1250 + $this->update_setting('http username', NULL);
1499 1251 endif;
1500 - $this->update_setting( 'http username', $link_rss_username );
1501 1252
1502 - $link_rss_password = FeedWordPress::post( 'link_rss_password' );
1503 1253 if (
1504 - strlen( $link_rss_password ) == 0
1505 - || is_null( $link_rss_auth_method )
1254 + isset($post['link_rss_password'])
1255 + and (strlen($post['link_rss_password']) > 0)
1256 + and ('-' != $post['link_rss_auth_method'])
1506 1257 ) :
1507 - $link_rss_password = null;
1258 + $this->update_setting('http password', $post['link_rss_password']);
1259 + else :
1260 + $this->update_setting('http password', NULL);
1508 1261 endif;
1509 - $this->update_setting( 'http password', $link_rss_password );
1262 +
1263 + $this->updatedPosts->accept_POST($post);
1510 1264
1511 - $this->updatedPosts->accept_POST();
1512 -
1513 - parent::save_settings();
1265 + parent::save_settings($post);
1514 1266 } /* FeedWordPressFeedsPage::save_settings() */
1515 1267
1516 1268 } /* class FeedWordPressFeedsPage */
1517 1269