| @@ -1,34 +1,12 @@ | ||
| 1 | 1 | <?php |
| 2 | -require_once dirname(__FILE__) . '/admin-ui.php'; | |
| 3 | -require_once dirname(__FILE__) . '/magpiemocklink.class.php'; | |
| 4 | -require_once dirname(__FILE__) . '/feedfinder.class.php'; | |
| 5 | -require_once dirname(__FILE__) . '/updatedpostscontrol.class.php'; | |
| 2 | +require_once(dirname(__FILE__) . '/admin-ui.php'); | |
| 3 | +require_once(dirname(__FILE__) . '/magpiemocklink.class.php'); | |
| 4 | +require_once(dirname(__FILE__) . '/feedfinder.class.php'); | |
| 5 | +require_once(dirname(__FILE__) . '/updatedpostscontrol.class.php'); | |
| 6 | 6 | |
| 7 | -/** | |
| 8 | - * List of feeds for FWP | |
| 9 | - * | |
| 10 | - * @extends FeedWordPressAdminPage | |
| 11 | - * @global $post_source | |
| 12 | - */ | |
| 13 | 7 | class FeedWordPressFeedsPage extends FeedWordPressAdminPage { |
| 14 | - /** | |
| 15 | - * List of possible HTTP status messages. | |
| 16 | - * | |
| 17 | - * @var array | |
| 18 | - * | |
| 19 | - * @note Added a few more, renamed a few to stick to contemporary standard. (gwyneth 20230918) | |
| 20 | - */ | |
| 21 | - var $HTTPStatusMessages = array( | |
| 22 | - 100 => 'Continue', | |
| 23 | - 101 => 'Switching Protocols', | |
| 24 | - 102 => 'Processing', // WebDAV; RFC 2518 | |
| 25 | - 103 => 'Early Hints', // RFC 8297 | |
| 26 | - 110 => 'Response is Stale', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 27 | - 111 => 'Revalidation Failed', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 28 | - 112 => 'Disconnected Operation', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 29 | - 113 => 'Heuristic Expiration', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 30 | - 199 => 'Miscellaneous Warning', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 8 | + var $HTTPStatusMessages = array ( | |
| 31 | 9 | 200 => 'OK. FeedWordPress had no problems retrieving the content at this URL but the content does not seem to be a feed, and does not seem to include links to any feeds.', |
| 32 | 10 | 201 => 'Created', |
| 33 | 11 | 202 => 'Accepted', |
| 34 | 12 | 203 => 'Non-Authoritative information', |
| @@ -34,23 +12,15 @@ | ||
| 34 | 12 | 203 => 'Non-Authoritative information', |
| 35 | 13 | 204 => 'No Content', |
| 36 | 14 | 205 => 'Reset Content', |
| 37 | 15 | 206 => 'Partial Content', |
| 38 | - 207 => 'Multi-Status', // WebDAV; RFC 4918 | |
| 39 | - 208 => 'Already Reported', // WebDAV; RFC 5842 | |
| 40 | - 214 => 'Transformation Applied', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 41 | - 218 => 'This is fine', // Non-standard; used by the Apache HTTP Serve) | |
| 42 | - 226 => 'IM Used', // RFC 3229 | |
| 43 | - 299 => 'Miscellaneous Persistent Warning', // Obsoleted in 2022 by RFC 9111 (caching-related) | |
| 44 | 16 | 300 => 'Multiple Choices', |
| 45 | 17 | 301 => 'Moved Permanently', |
| 46 | - 302 => 'Found', // Previously known as 'Moved temporarily' | |
| 18 | + 302 => 'Found', | |
| 47 | 19 | 303 => 'See Other', |
| 48 | 20 | 304 => 'Not Modified', |
| 49 | 21 | 305 => 'Use Proxy', |
| 50 | - 306 => 'Switch Proxy', | |
| 51 | 22 | 307 => 'Temporary Redirect', |
| 52 | - 308 => 'Permanent Redirect', | |
| 53 | 23 | 400 => 'Bad Request', |
| 54 | 24 | 401 => 'Unauthorized. This URL probably needs a username and password for you to access it.', |
| 55 | 25 | 402 => 'Payment Required', |
| 56 | 26 | 403 => 'Forbidden. The URL is not made available for the machine that FeedWordPress is running on.', |
| @@ -62,38 +32,13 @@ | ||
| 62 | 32 | 409 => 'Conflict', |
| 63 | 33 | 410 => 'Gone. This URL is no longer available on this server and no forwarding address is known.', |
| 64 | 34 | 411 => 'Length Required', |
| 65 | 35 | 412 => 'Precondition Failed', |
| 66 | - 413 => 'Payload Too Large', // Previously known as 'Request Entity Too Large' | |
| 67 | - 414 => 'URI Too Long', // Previously known as 'Request URI Too Long' | |
| 36 | + 413 => 'Request Entity Too Large', | |
| 37 | + 414 => 'Request URI Too Long', | |
| 68 | 38 | 415 => 'Unsupported Media Type', |
| 69 | - 416 => 'Range Not Satisfiable', // Previously known as 'Requested Range Not Satisfiable' | |
| 39 | + 416 => 'Requested Range Not Satisfiable', | |
| 70 | 40 | 417 => 'Expectation Failed', |
| 71 | - 418 => 'I\'m a teapot', // RFC 2324, RFC 7168 | |
| 72 | - 419 => 'Page Expired', // Non-standard; used by the Laravel Framework | |
| 73 | - 420 => 'Enhance Your Calm', // Non-standard; used by version 1.0 of the Twitter API | |
| 74 | - 421 => 'Misdirected Request', | |
| 75 | - 422 => 'Unprocessable Entity', | |
| 76 | - 423 => 'Locked', // WebDAV; RFC 4918 | |
| 77 | - 424 => 'Failed Dependency', // WebDAV; RFC 4918 | |
| 78 | - 425 => 'Too Early', // RFC 8470 | |
| 79 | - 426 => 'Upgrade Required', | |
| 80 | - 428 => 'Precondition Required', // RFC 6585 | |
| 81 | - 429 => 'Too Many Requests', // RFC 6585 | |
| 82 | - 431 => 'Request Header Fields Too Large', // RFC 6585 | |
| 83 | - 440 => 'Login Time-out', // Non-standard; used by Microsoft on IIS | |
| 84 | - 444 => 'No Response', // Non-standard; used internally by the nginx web server | |
| 85 | - 449 => 'Retry With', // Non-standard; used by Microsoft on IIS | |
| 86 | - 450 => 'Blocked by Windows Parental Controls', // Non-standard; used by Microsoft | |
| 87 | - 451 => 'Unavailable For Legal Reasons', // RFC 7725; also: used by Microsoft IIS for a redirect | |
| 88 | - 460 => 'Too Soon', // Non-standard; used by Amazon on AWS | |
| 89 | - 463 => 'Too Many IP Addresses', // Non-standard; used by Amazon on AWS | |
| 90 | - 464 => 'Incompatible Protocol Version', // Non-standard; used by Amazon on AWS | |
| 91 | - 494 => 'Request Header Too Large', // Non-standard; used by the nginx web server | |
| 92 | - 495 => 'SSL Certificate Error', // Non-standard; used by the nginx web server | |
| 93 | - 496 => 'SSL Certificate Required', // Non-standard; used by the nginx web server | |
| 94 | - 498 => 'Invalid Token', // Non-standard; used by Esri on their ArcGIS for Server product | |
| 95 | - 499 => 'Token Required', // Non-standard; used by Esri on their ArcGIS for Server product; also used as 'Client Closed Request' by the nginx web server | |
| 96 | 41 | 500 => 'Internal Server Error. Something unexpected went wrong with the configuration of the server that hosts this URL. You might try again later to see if this issue has been resolved.', |
| 97 | 42 | 501 => 'Not Implemented', |
| 98 | 43 | 502 => 'Bad Gateway', |
| 99 | 44 | 503 => 'Service Unavailable. The server is currently unable to handle the request due to a temporary overloading or maintenance of the server that hosts this URL. This is probably a temporary condition and you should try again later to see if the issue has been resolved.', |
| @@ -98,44 +43,12 @@ | ||
| 98 | 43 | 502 => 'Bad Gateway', |
| 99 | 44 | 503 => 'Service Unavailable. The server is currently unable to handle the request due to a temporary overloading or maintenance of the server that hosts this URL. This is probably a temporary condition and you should try again later to see if the issue has been resolved.', |
| 100 | 45 | 504 => 'Gateway Timeout', |
| 101 | 46 | 505 => 'HTTP Version Not Supported', |
| 102 | - 506 => 'Variant Also Negotiates', // RFC 2295 | |
| 103 | - 507 => 'Insufficient Storage', // WebDAV; RFC 4918 | |
| 104 | - 508 => 'Loop Detected', // WebDAV; RFC 5842 | |
| 105 | - 509 => 'Bandwidth Limit Exceeded', // Non-standard; used by the Apache Web Server as well as cPanel | |
| 106 | - 510 => 'Not Extended', // RFC 2774 | |
| 107 | - 511 => 'Network Authentication Required', // RFC 6585 | |
| 108 | - 520 => 'Web Server Returned an Unknown Error', // Non-Standard; used by Cloudflare | |
| 109 | - 521 => 'Web Server Is Down', // Non-Standard; used by Cloudflare | |
| 110 | - 522 => 'Connection Timed Out', // Non-Standard; used by Cloudflare | |
| 111 | - 523 => 'Origin Is Unreachable', // Non-Standard; used by Cloudflare | |
| 112 | - 524 => 'A Timeout Occurred', // Non-Standard; used by Cloudflare | |
| 113 | - 525 => 'SSL Handshake Failed', // Non-Standard; used by Cloudflare | |
| 114 | - 526 => 'Invalid SSL Certificate', // Non-Standard; used by Cloudflare | |
| 115 | - 527 => 'Railgun Error', // Non-Standard; used by Cloudflare | |
| 116 | - 529 => 'Site is overloaded', // Non-standard; used by Qualys on its SSLLabs server testing API | |
| 117 | - 530 => 'Site is frozen', // Non-standard; used by the Pantheon Systems web platform | |
| 118 | - 561 => 'Unauthorized', // Non-standard; used by Amazon on AWS | |
| 119 | - 598 => 'Network Read Timeout Error', // Non-standard; informal convention used by some HTTP procoes | |
| 120 | - 599 => 'Network Connect Timeout Error', // Non-standard; informal convention used by some HTTP procoes | |
| 121 | 47 | ); |
| 122 | - | |
| 123 | - /** | |
| 124 | - * List of updated posts. | |
| 125 | - * | |
| 126 | - * @var mixed | |
| 127 | - */ | |
| 128 | 48 | var $updatedPosts = NULL; |
| 129 | 49 | |
| 130 | - /** | |
| 131 | - * List of special settings. | |
| 132 | - * | |
| 133 | - * Regular expression syntax is OK here. | |
| 134 | - * | |
| 135 | - * @var Array | |
| 136 | - */ | |
| 137 | - var $special_settings = array( | |
| 50 | + var $special_settings = array ( /* Regular expression syntax is OK here */ | |
| 138 | 51 | 'cats', |
| 139 | 52 | 'cat_split', |
| 140 | 53 | 'fetch timeout', |
| 141 | 54 | 'freeze updates', |
| @@ -168,16 +81,15 @@ | ||
| 168 | 81 | /** |
| 169 | 82 | * Constructs the Feeds page object |
| 170 | 83 | * |
| 171 | 84 | * @param mixed $link An object of class {@link SyndicatedLink} if created for one feed's settings, NULL if created for global default settings |
| 172 | - * @uses UpdatedPostsControl | |
| 173 | 85 | */ |
| 174 | 86 | public function __construct( $link = -1 ) { |
| 175 | - if ( is_numeric( $link ) and -1 == $link ) : | |
| 87 | + if (is_numeric($link) and -1 == $link) : | |
| 176 | 88 | $link = $this->submitted_link(); |
| 177 | 89 | endif; |
| 178 | 90 | |
| 179 | - parent::__construct( 'feedwordpressfeeds', $link ); | |
| 91 | + parent::__construct('feedwordpressfeeds', $link); | |
| 180 | 92 | |
| 181 | 93 | $this->dispatch = 'feedwordpress_admin_page_feeds'; |
| 182 | 94 | $this->pagenames = array( |
| 183 | 95 | 'default' => 'Feeds', |
| @@ -184,45 +96,39 @@ | ||
| 184 | 96 | 'settings-update' => 'Syndicated feed', |
| 185 | 97 | 'open-sheet' => 'Feed and Update', |
| 186 | 98 | ); |
| 187 | 99 | $this->filename = __FILE__; |
| 188 | - $this->updatedPosts = new UpdatedPostsControl( $this ); | |
| 189 | - | |
| 190 | - $this->special_settings = apply_filters( 'syndicated_feed_special_settings', $this->special_settings, $this ); | |
| 100 | + $this->updatedPosts = new UpdatedPostsControl($this); | |
| 101 | + | |
| 102 | + $this->special_settings = apply_filters('syndicated_feed_special_settings', $this->special_settings, $this); | |
| 191 | 103 | } /* FeedWordPressFeedsPage constructor */ |
| 192 | 104 | |
| 193 | - /** | |
| 194 | - * Prints out the feeds page. | |
| 195 | - * | |
| 196 | - * @return bool TRUE to continue printing out, FALSE to stop. | |
| 197 | - * @uses FeedWordPress::param() | |
| 198 | - */ | |
| 199 | - function display() { | |
| 105 | + function display () { | |
| 106 | + global $fwp_post; | |
| 200 | 107 | global $post_source; |
| 201 | 108 | |
| 202 | 109 | $this->boxes_by_methods = array( |
| 203 | - 'feed_information_box' => __( 'Feed Information' ), | |
| 204 | - 'global_feeds_box' => __( 'Update Scheduling' ), | |
| 205 | - 'updated_posts_box' => __( 'Updated Posts' ), | |
| 206 | - 'custom_settings_box' => __( 'Custom Feed Settings (for use in templates)' ), | |
| 207 | - 'advanced_settings_box' => __( 'Advanced Settings' ), | |
| 110 | + 'feed_information_box' => __('Feed Information'), | |
| 111 | + 'global_feeds_box' => __('Update Scheduling'), | |
| 112 | + 'updated_posts_box' => __('Updated Posts'), | |
| 113 | + 'custom_settings_box' => __('Custom Feed Settings (for use in templates)'), | |
| 114 | + 'advanced_settings_box' => __('Advanced Settings'), | |
| 208 | 115 | ); |
| 209 | 116 | if ($this->for_default_settings()) : |
| 210 | - unset( $this->boxes_by_methods['custom_settings_box'] ); | |
| 211 | - endif; | |
| 212 | - | |
| 117 | + unset($this->boxes_by_methods['custom_settings_box']); | |
| 118 | + endif; | |
| 119 | + | |
| 213 | 120 | // Allow overriding of normal source for FeedFinder, which may |
| 214 | 121 | // be called from multiple points. |
| 215 | - if ( isset( $post_source ) and ! is_null( $post_source ) ) : | |
| 122 | + if (isset($post_source) and !is_null($post_source)) : | |
| 216 | 123 | $source = $post_source; |
| 217 | 124 | else : |
| 218 | 125 | $source = $this->dispatch; |
| 219 | 126 | endif; |
| 220 | 127 | |
| 221 | - $feedfinder = FeedWordPress::param( 'feedfinder' ); | |
| 222 | - $action = FeedWordPress::param( 'action' ); | |
| 223 | - if ( $feedfinder || in_array( $action, array( 'feedfinder', FWP_SYNDICATE_NEW ) ) ) : | |
| 224 | - | |
| 128 | + if (isset($_REQUEST['feedfinder']) | |
| 129 | + or (isset($_REQUEST['action']) and $_REQUEST['action']=='feedfinder') | |
| 130 | + or (isset($_REQUEST['action']) and $_REQUEST['action']==FWP_SYNDICATE_NEW)) : | |
| 225 | 131 | // If this is a POST, validate source and user credentials |
| 226 | 132 | FeedWordPressCompatibility::validate_http_request(/*action=*/ $source, /*capability=*/ 'manage_links'); |
| 227 | 133 | |
| 228 | 134 | return $this->display_feedfinder(); // re-route to Feed Finder page |
| @@ -231,55 +137,37 @@ | ||
| 231 | 137 | parent::display(); |
| 232 | 138 | return false; // Don't continue |
| 233 | 139 | } /* FeedWordPressFeedsPage::display() */ |
| 234 | 140 | |
| 235 | - /** | |
| 236 | - * Interface with JavaScript calls. | |
| 237 | - * | |
| 238 | - */ | |
| 239 | - function ajax_interface_js() { | |
| 141 | + function ajax_interface_js () { | |
| 240 | 142 | parent::ajax_interface_js(); |
| 241 | 143 | ?> |
| 242 | - jQuery( document ).ready( function () { | |
| 243 | - contextual_appearance( 'automatic-updates-selector', 'cron-job-explanation', null, 'no' ); | |
| 244 | - contextual_appearance( 'time-limit', 'time-limit-box', null, 'yes' ); | |
| 245 | - contextual_appearance( 'use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true ); | |
| 246 | - jQuery( '#use-default-update-window-yes, #use-default-update-window-no' ).click( function () { | |
| 247 | - contextual_appearance( 'use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true ); | |
| 144 | + | |
| 145 | + jQuery(document).ready( function () { | |
| 146 | + contextual_appearance('automatic-updates-selector', 'cron-job-explanation', null, 'no'); | |
| 147 | + contextual_appearance('time-limit', 'time-limit-box', null, 'yes'); | |
| 148 | + contextual_appearance('use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true); | |
| 149 | + jQuery('#use-default-update-window-yes, #use-default-update-window-no').click( function () { | |
| 150 | + contextual_appearance('use-default-update-window-no', 'update-scheduling-note', null, null, 'block', true); | |
| 248 | 151 | } ); |
| 249 | 152 | |
| 250 | - var els = [ 'name', 'description', 'url' ]; | |
| 251 | - for ( var i = 0; i < els.length; i++ ) { | |
| 153 | + var els = ['name', 'description', 'url']; | |
| 154 | + for (var i = 0; i < els.length; i++) { | |
| 252 | 155 | contextual_appearance( |
| 253 | - /*item=*/ 'basics-hardcode-' + els[i], | |
| 254 | - /*appear=*/ 'basics-' + els[i] + '-view', | |
| 255 | - /*disappear=*/ 'basics-' + els[i] + '-edit', | |
| 256 | - /*value=*/ 'no', | |
| 156 | + /*item=*/ 'basics-hardcode-'+els[i], | |
| 157 | + /*appear=*/ 'basics-'+els[i]+'-view', | |
| 158 | + /*disappear=*/ 'basics-'+els[i]+'-edit', | |
| 159 | + /*value=*/ 'no', | |
| 257 | 160 | /*visibleStyle=*/ 'block', |
| 258 | - /*checkbox=*/ true | |
| 161 | + /*checkbox=*/ true | |
| 259 | 162 | ); |
| 260 | 163 | } /* for */ |
| 164 | + } ); | |
| 261 | 165 | |
| 262 | - // Let's make the interface for the PAUSE/RESUME a bit better | |
| 263 | - jQuery( '<tr id="reveal-pause-resume"><th></th><td><button id="pause-resume-reveal-button">— PAUSE or RESUME UPDATES —</button></td></tr>' ).insertBefore( '#pause-resume' ); | |
| 264 | - jQuery( '#pause-resume' ).hide(); | |
| 265 | - jQuery( '#pause-resume-reveal-button' ).click( function( ev ) { | |
| 266 | - ev.preventDefault(); | |
| 267 | - | |
| 268 | - jQuery( '#pause-resume' ).toggle(); | |
| 269 | - return false; | |
| 270 | - }); | |
| 271 | - } ); | |
| 272 | 166 | <?php |
| 273 | - } /* FeedWordPressFeedsPage::ajax_interface_js() */ | |
| 274 | - | |
| 275 | - /** | |
| 276 | - * Displays updated feeds. | |
| 277 | - * | |
| 278 | - * @param object $page Current page object (?). | |
| 279 | - * @param mixed|null $box A box inside this object. | |
| 280 | - */ | |
| 281 | - /*static*/ function updated_posts_box( $page, $box = NULL ) { | |
| 167 | + } | |
| 168 | + | |
| 169 | + /*static*/ function updated_posts_box ($page, $box = NULL) { | |
| 282 | 170 | ?> |
| 283 | 171 | <table class="edit-form"> |
| 284 | 172 | <?php $page->updatedPosts->display(); ?> |
| 285 | 173 | </table> |
| @@ -285,148 +173,116 @@ | ||
| 285 | 173 | </table> |
| 286 | 174 | <?php |
| 287 | 175 | } /* FeedWordPressFeedsPage::updated_posts_box() */ |
| 288 | 176 | |
| 289 | - /** | |
| 290 | - * Displays form to deal with global feeds. | |
| 291 | - * | |
| 292 | - * @param object $page Current page object (?). | |
| 293 | - * @param mixed|null $box A box inside this object. | |
| 294 | - * | |
| 295 | - * @uses FeedWordPress::automatic_update_hook() | |
| 296 | - */ | |
| 297 | - /*static*/ function global_feeds_box( $page, $box = NULL ) { | |
| 177 | + /*static*/ function global_feeds_box ($page, $box = NULL) { | |
| 298 | 178 | global $feedwordpress; |
| 299 | - $automatic_updates = $feedwordpress->automatic_update_hook( array( 'setting only' => true ) ); | |
| 300 | - $update_time_limit = (int) get_option( 'feedwordpress_update_time_limit' ); | |
| 179 | + $automatic_updates = $feedwordpress->automatic_update_hook(array('setting only' => true)); | |
| 180 | + $update_time_limit = (int) get_option('feedwordpress_update_time_limit'); | |
| 301 | 181 | |
| 302 | 182 | // Hey, ho, let's go... |
| 303 | 183 | ?> |
| 304 | 184 | |
| 305 | - <table class="edit-form" | |
| 306 | - <?php if ( $page->for_default_settings() ) : ?> | |
| 185 | + <table class="edit-form"> | |
| 186 | + <?php if ($page->for_default_settings()) : ?> | |
| 307 | 187 | |
| 308 | 188 | <tr> |
| 309 | - <th scope="row"><?php esc_html_e( 'Update Method:' ); ?></th> | |
| 189 | + <th scope="row">Updates:</th> | |
| 310 | 190 | <td><select id="automatic-updates-selector" name="automatic_updates" size="1" onchange="contextual_appearance('automatic-updates-selector', 'cron-job-explanation', null, 'no');"> |
| 311 | - <option value="shutdown"<?php fwp_selected_flag( 'shutdown' == $automatic_updates ); ?>><?php esc_html_e( 'automatically check for updates after pages load' ); ?></option> | |
| 312 | - <option value="init"<?php fwp_selected_flag( 'init' == $automatic_updates ); ?>><?php esc_html_e( 'automatically check for updates before pages load' ); ?></option> | |
| 313 | - <option value="no"<?php fwp_selected_flag( ! $automatic_updates ); ?>><?php esc_html_e( 'cron job or manual updates' ); ?></option> | |
| 191 | + <option value="shutdown"<?php echo ($automatic_updates=='shutdown')?' selected="selected"':''; ?>>automatically check for updates after pages load</option> | |
| 192 | + <option value="init"<?php echo ($automatic_updates=='init')?' selected="selected"':''; ?>>automatically check for updates before pages load</option> | |
| 193 | + <option value="no"<?php echo (!$automatic_updates)?' selected="selected"':''; ?>>cron job or manual updates</option> | |
| 314 | 194 | </select> |
| 315 | 195 | <div id="cron-job-explanation" class="setting-description"> |
| 316 | 196 | <p><?php |
| 317 | - /* Do we have shell_exec() available from here, or is it disabled for security reasons? | |
| 318 | - * If it's available, use it to execute `which` to try to get a realistic path to curl, | |
| 319 | - * or to wget. If everything fails or shell_exec() isn't available, then just make | |
| 320 | - * up something for the sake of example. | |
| 321 | - */ | |
| 322 | - /** var string|null Path to either cURL or wget executables. */ | |
| 323 | - $curlOrWgetPath = NULL; | |
| 197 | + // Do we have shell_exec() available from here, or is it disabled for security reasons? | |
| 198 | + // If it's available, use it to execute `which` to try to get a realistic path to curl, | |
| 199 | + // or to wget. If everything fails or shell_exec() isn't available, then just make | |
| 200 | + // up something for the sake of example. | |
| 201 | + $shellExecAvailable = (is_callable('shell_exec') && false === stripos(ini_get('disable_functions'), 'shell_exec')); | |
| 324 | 202 | |
| 325 | - /** var bool True if this WP installation can call shell commands. */ | |
| 326 | - $shellExecAvailable = ( is_callable( 'shell_exec' ) && false === stripos( ini_get( 'disable_functions' ), 'shell_exec') ); | |
| 327 | - | |
| 328 | - if ( $shellExecAvailable ) : | |
| 329 | - $curlOrWgetPath = `which curl`; $opts = '--silent %s'; | |
| 203 | + if ($shellExecAvailable) : | |
| 204 | + $path = `which curl`; $opts = '--silent %s'; | |
| 330 | 205 | endif; |
| 331 | 206 | |
| 332 | - if ( $shellExecAvailable and ( is_null( $curlOrWgetPath ) or strlen( trim( $curlOrWgetPath ) ) == 0 ) ) : | |
| 333 | - $curlOrWgetPath = `which wget`; $opts = '-q -O - %s'; | |
| 207 | + if ($shellExecAvailable and (is_null($path) or strlen(trim($path))==0)) : | |
| 208 | + $path = `which wget`; $opts = '-q -O - %s'; | |
| 334 | 209 | endif; |
| 335 | 210 | |
| 336 | - if ( is_null( $curlOrWgetPath ) or strlen( trim( $curlOrWgetPath ) ) == 0 ) : | |
| 337 | - $curlOrWgetPath = '/usr/bin/curl'; $opts = '--silent %s'; | |
| 211 | + if (is_null($path) or strlen(trim($path))==0) : | |
| 212 | + $path = '/usr/bin/curl'; $opts = '--silent %s'; | |
| 338 | 213 | endif; |
| 339 | 214 | |
| 340 | - $curlOrWgetPath = preg_replace( '/\n+$/', '', $curlOrWgetPath ); | |
| 341 | - | |
| 342 | - /** var string Constructed shell command line to call cURL/wget for updating FeedWordPress feeds. */ | |
| 343 | - $cmdline = $curlOrWgetPath . ' ' . sprintf( $opts, get_bloginfo( 'url' ) . '?update_feedwordpress=1' ); | |
| 344 | - | |
| 345 | - ?><?php esc_html_e( 'If you want to use a cron job, you can perform scheduled updates by sending regularly-scheduled requests to ' ); ?><a href="<?php bloginfo('url'); ?>?update_feedwordpress=1"><code><?php bloginfo('url'); ?>?update_feedwordpress=1</code></a> | |
| 346 | - <?php esc_html_e( 'For example, inserting the following line in your crontab:' ); ?></p> | |
| 215 | + $path = preg_replace('/\n+$/', '', $path); | |
| 216 | + | |
| 217 | + $cmdline = $path . ' ' . sprintf($opts, get_bloginfo('url').'?update_feedwordpress=1'); | |
| 218 | + | |
| 219 | + ?>If you want to use a cron job, | |
| 220 | + you can perform scheduled updates by sending regularly-scheduled | |
| 221 | + requests to <a href="<?php bloginfo('url'); ?>?update_feedwordpress=1"><code><?php bloginfo('url') ?>?update_feedwordpress=1</code></a> | |
| 222 | + For example, inserting the following line in your crontab:</p> | |
| 347 | 223 | <pre style="font-size: 0.80em"><code>*/10 * * * * <?php print esc_html($cmdline); ?></code></pre> |
| 348 | - <p class="setting-description"><?php esc_html_e( 'will check in every 10 minutes and check for updates on any feeds that are ready to be polled for updates.' ); ?></p> | |
| 224 | + <p class="setting-description">will check in every 10 minutes | |
| 225 | + and check for updates on any feeds that are ready to be polled for updates.</p> | |
| 349 | 226 | </div> |
| 350 | 227 | </td> |
| 351 | 228 | </tr> |
| 352 | - | |
| 229 | + | |
| 353 | 230 | <?php else : /* Feed-specific settings */ ?> |
| 354 | 231 | |
| 355 | 232 | <tr> |
| 356 | - <th scope="row"><?php esc_html_e( 'Last update' ) ?>:</th> | |
| 233 | + <th scope="row"><?php _e('Last update') ?>:</th> | |
| 357 | 234 | <td><?php |
| 358 | - if ( isset( $page->link->settings['update/last'] ) ) : | |
| 359 | - echo esc_html( fwp_time_elapsed( $page->link->settings['update/last'] ) . " " ); | |
| 235 | + if (isset($page->link->settings['update/last'])) : | |
| 236 | + echo fwp_time_elapsed($page->link->settings['update/last'])." "; | |
| 360 | 237 | else : |
| 361 | - esc_html_e( " none yet" ); | |
| 238 | + echo " none yet"; | |
| 362 | 239 | endif; |
| 363 | 240 | ?></td></tr> |
| 364 | 241 | |
| 365 | - <tr><th><?php esc_html_e( 'Next update' ) ?>:</th> | |
| 242 | + <tr><th><?php _e('Next update') ?>:</th> | |
| 366 | 243 | <td><?php |
| 367 | - $holdem = ( isset( $page->link->settings['update/hold'] ) ? $page->link->settings['update/hold'] : 'scheduled' ); | |
| 244 | + $holdem = (isset($page->link->settings['update/hold']) ? $page->link->settings['update/hold'] : 'scheduled'); | |
| 368 | 245 | ?> |
| 369 | 246 | <select name="update_schedule"> |
| 370 | - <option value="scheduled"<?php echo ( 'scheduled' == $holdem ) ? ' selected="selected"' : ''; ?>><?php esc_html_e( 'update on schedule' ); ?> <?php | |
| 247 | + <option value="scheduled"<?php echo ($holdem=='scheduled')?' selected="selected"':''; ?>>update on schedule <?php | |
| 371 | 248 | echo " ("; |
| 372 | - if ( isset( $page->link->settings['update/ttl'] ) and is_numeric( $page->link->settings['update/ttl'] ) ) : | |
| 373 | - if ( isset( $page->link->settings['update/timed'] ) and 'automatically' == $page->link->settings['update/timed'] ) : | |
| 374 | - esc_html_e( 'next: '); | |
| 375 | - $next = $page->link->settings['update/last'] + ( (int) $page->link->settings['update/ttl'] * 60 ); | |
| 376 | - // Note: strftime() is deprecated; use date() instead. (gwyneth 20230918) | |
| 377 | - if ( strftime( '%x', time() ) != strftime( '%x', $next) ) : | |
| 378 | - echo esc_html( strftime( '%x', $next ) . ' ' ); | |
| 249 | + if (isset($page->link->settings['update/ttl']) and is_numeric($page->link->settings['update/ttl'])) : | |
| 250 | + if (isset($page->link->settings['update/timed']) and $page->link->settings['update/timed']=='automatically') : | |
| 251 | + echo 'next: '; | |
| 252 | + $next = $page->link->settings['update/last'] + ((int) $page->link->settings['update/ttl'] * 60); | |
| 253 | + if (strftime('%x', time()) != strftime('%x', $next)) : | |
| 254 | + echo strftime('%x', $next)." "; | |
| 379 | 255 | endif; |
| 380 | - echo esc_html( strftime( '%X', $page->link->settings['update/last'] + ( (int) $page->link->settings['update/ttl'] * 60 ) ) ); | |
| 256 | + echo strftime('%X', $page->link->settings['update/last']+((int) $page->link->settings['update/ttl']*60)); | |
| 381 | 257 | else : |
| 382 | - echo esc_html__( "every " ) . esc_html( $page->link->settings['update/ttl'] ) . esc_html__( " minute" ) | |
| 383 | - . ( ( 1 != $page->link->settings['update/ttl'] ) ? esc_html__( "s" ) : "" ); | |
| 258 | + echo "every ".$page->link->settings['update/ttl']." minute".(($page->link->settings['update/ttl']!=1)?"s":""); | |
| 384 | 259 | endif; |
| 385 | 260 | else: |
| 386 | - esc_html_e( "next scheduled update" ); | |
| 261 | + echo "next scheduled update"; | |
| 387 | 262 | endif; |
| 388 | 263 | echo ")"; |
| 389 | 264 | ?></option> |
| 390 | - <option value="next"<?php echo ( 'next' == $holdem ) ? ' selected="selected"' : ''; ?>><?php esc_html_e( 'update ASAP' ); ?></option> | |
| 391 | - <option value="ping"<?php echo ( 'ping' == $holdem ) ? ' selected="selected"' : ''; ?>><?php esc_html_e( 'update only when pinged' ); ?></option> | |
| 265 | + <option value="next"<?php echo ($holdem=='next')?' selected="selected"':''; ?>>update ASAP</option> | |
| 266 | + <option value="ping"<?php echo ($holdem=='ping')?' selected="selected"':''; ?>>update only when pinged</option> | |
| 392 | 267 | </select></td></tr> |
| 393 | - | |
| 268 | + | |
| 394 | 269 | <?php endif; ?> |
| 395 | - | |
| 396 | - <tr id="pause-resume"> | |
| 397 | - <th scope="row"><?php esc_html_e( 'Pause/Resume:'); ?></th> | |
| 398 | - <td><?php | |
| 399 | - $this->setting_radio_control( | |
| 400 | - 'update/pause', | |
| 401 | - 'update_pause', | |
| 402 | - /*options=*/ array( | |
| 403 | - 'no' => __( '<strong>UPDATE:</strong> import new posts as normal' ), | |
| 404 | - 'yes' => __( '<strong>PAUSE:</strong> do not import new posts until I unpause updates' ), | |
| 405 | - ), | |
| 406 | - /*params=*/ array( | |
| 407 | - 'setting-default' => NULL, | |
| 408 | - 'global-setting-default' => 'no', | |
| 409 | - 'default-input-value' => 'default', | |
| 410 | - ), | |
| 411 | - ); | |
| 412 | - ?></td> | |
| 413 | - </tr> | |
| 414 | - | |
| 270 | + | |
| 415 | 271 | <tr> |
| 416 | - <th scope="row"><?php esc_html_e( 'Update scheduling:') ?></th> | |
| 417 | - <td><p style="margin-top:0px"><?php esc_html_e( 'How long should FeedWordPress wait between updates before it considers this feed ready to be polled for updates again?' ); ?></p> | |
| 272 | + <th scope="row"><?php print __('Update scheduling:') ?></th> | |
| 273 | + <td><p style="margin-top:0px">How long should FeedWordPress wait between updates before it considers this feed ready to be polled for updates again?</p> | |
| 418 | 274 | <?php |
| 275 | + | |
| 419 | 276 | $this->setting_radio_control( |
| 420 | - 'update/window', | |
| 421 | - 'update_window', | |
| 422 | - array( $this, 'update_window_edit_box' ), | |
| 277 | + 'update/window', 'update_window', | |
| 278 | + array($this, 'update_window_edit_box'), | |
| 423 | 279 | array( |
| 424 | 280 | 'global-setting-default' => DEFAULT_UPDATE_PERIOD, |
| 425 | - 'default-input-name' => 'use_default_update_window', | |
| 426 | - 'default-input-id' => 'use-default-update-window-yes', | |
| 427 | - 'default-input-id-no' => 'use-default-update-window-no', | |
| 428 | - 'labels' => array($this, 'update_window_currently' ), | |
| 281 | + 'default-input-name' => 'use_default_update_window', | |
| 282 | + 'default-input-id' => 'use-default-update-window-yes', | |
| 283 | + 'default-input-id-no' => 'use-default-update-window-no', | |
| 284 | + 'labels' => array($this, 'update_window_currently'), | |
| 429 | 285 | ) |
| 430 | 286 | ); |
| 431 | 287 | ?></td> |
| 432 | 288 | </tr> |
| @@ -431,20 +287,20 @@ | ||
| 431 | 287 | ?></td> |
| 432 | 288 | </tr> |
| 433 | 289 | |
| 434 | 290 | <tr> |
| 435 | - <th scope="row"><?php esc_html_e( 'Minimum Interval:'); ?></th> | |
| 436 | - <td><p style="margin-top:0px"><?php esc_html_e( 'Some feeds include standard elements that | |
| 291 | + <th scope="row"><?php print __('Minimum Interval:'); ?></th> | |
| 292 | + <td><p style="margin-top:0px">Some feeds include standard elements that | |
| 437 | 293 | request a specific update schedule. If the interval requested by the |
| 438 | - feed provider is <em>longer</em> than FeedWordPress’s normal scheduling, | |
| 294 | + feed provider is <em>longer</em> than FeedWordPress's normal scheduling, | |
| 439 | 295 | FeedWordPress will always respect their request to slow down. But what |
| 440 | - should it do if the update interval is <em>shorter</em> than the schedule set above?' ); ?></p> | |
| 296 | + should it do if the update interval is <em>shorter</em> than the schedule set above?</p> | |
| 441 | 297 | <?php |
| 442 | 298 | $this->setting_radio_control( |
| 443 | 299 | 'update/minimum', 'update_minimum', |
| 444 | 300 | /*options=*/ array( |
| 445 | - 'no' => __( 'Speed up and accept the interval from the feed provider' ), | |
| 446 | - 'yes' => __( 'Keep pace and use the longer scheduling from FeedWordPress' ), | |
| 301 | + 'no' => 'Speed up and accept the interval from the feed provider', | |
| 302 | + 'yes' => 'Keep pace and use the longer scheduling from FeedWordPress', | |
| 447 | 303 | ), |
| 448 | 304 | /*params=*/ array( |
| 449 | 305 | 'setting-default' => NULL, |
| 450 | 306 | 'global-setting-default' => 'no', |
| @@ -453,114 +309,76 @@ | ||
| 453 | 309 | ); |
| 454 | 310 | ?> |
| 455 | 311 | </td> |
| 456 | 312 | </tr> |
| 457 | - | |
| 313 | + | |
| 458 | 314 | <?php if ($this->for_default_settings()) : ?> |
| 459 | - | |
| 315 | + | |
| 460 | 316 | <tr> |
| 461 | - <th scope="row"><?php esc_html_e( 'Time limit on updates' ); ?>:</th> | |
| 462 | - <td><select id="time-limit" name="update_time_limit" size="1" onchange="contextual_appearance( 'time-limit', 'time-limit-box', null, 'yes' );"> | |
| 463 | - <option value="no"<?php fwp_selected_flag( $update_time_limit <= 0 ); ?>><?php esc_html_e( 'no time limit on updates' ); ?></option> | |
| 464 | - <option value="yes"<?php fwp_selected_flag( $update_time_limit > 0 ); ?>><?php esc_html_e( 'limit updates to no more than...' ); ?></option> | |
| 317 | + <th scope="row"><?php print __('Time limit on updates'); ?>:</th> | |
| 318 | + <td><select id="time-limit" name="update_time_limit" size="1" onchange="contextual_appearance('time-limit', 'time-limit-box', null, 'yes');"> | |
| 319 | + <option value="no"<?php echo ($update_time_limit>0)?'':' selected="selected"'; ?>>no time limit on updates</option> | |
| 320 | + <option value="yes"<?php echo ($update_time_limit>0)?' selected="selected"':''; ?>>limit updates to no more than...</option> | |
| 465 | 321 | </select> |
| 466 | - <span id="time-limit-box"><label><input type="text" name="time_limit_seconds" value="<?php print esc_attr( $update_time_limit ); ?>" size="5" /> <?php esc_html_e( 'seconds' ); ?></label></span> | |
| 322 | + <span id="time-limit-box"><label><input type="text" name="time_limit_seconds" value="<?php print $update_time_limit; ?>" size="5" /> seconds</label></span> | |
| 467 | 323 | </tr> |
| 468 | 324 | |
| 469 | 325 | <?php endif; ?> |
| 470 | - | |
| 326 | + | |
| 471 | 327 | </table> |
| 472 | - | |
| 328 | + | |
| 473 | 329 | <?php |
| 474 | 330 | } /* FeedWordPressFeedsPage::global_feeds_box() */ |
| 475 | 331 | |
| 476 | - /** | |
| 477 | - * Updates the window edit box. | |
| 478 | - * | |
| 479 | - * @param int $updateWindow Minutes between polling. | |
| 480 | - * @param bool $defaulted Unused. | |
| 481 | - * @param array $params Unused. | |
| 482 | - */ | |
| 483 | - function update_window_edit_box( $updateWindow, $defaulted, $params ) { | |
| 484 | - if ( ! is_numeric( $updateWindow) ) : | |
| 332 | + function update_window_edit_box ($updateWindow, $defaulted, $params) { | |
| 333 | + if (!is_numeric($updateWindow)) : | |
| 485 | 334 | $updateWindow = DEFAULT_UPDATE_PERIOD; |
| 486 | 335 | endif; |
| 487 | 336 | ?> |
| 488 | - <p><?php esc_html_e( 'Wait' ); ?> <input type="text" name="update_window" value="<?php print esc_attr( $updateWindow ); ?>" size="4" /> <?php esc_html_e( 'minutes between polling.' ); ?></p> | |
| 337 | + <p>Wait <input type="text" name="update_window" value="<?php print $updateWindow; ?>" size="4" /> minutes between polling.</p> | |
| 489 | 338 | <div class="setting-description" id="update-scheduling-note"> |
| 490 | - <p<?php if ( $updateWindow < 50 ) : ?> style="color: white; background-color: #703030; padding: 1.0em;"<?php endif; ?>><?php esc_html_e( '<strong>Recommendation.</strong> Unless you are positive that you have the webmaster’s permission, you generally should not set FeedWordPress to poll feeds more frequently than once every 60 minutes. Many webmasters consider more frequent automated polling to be abusive, and may complain to your web host, or ban your IP address, as retaliation for hammering their servers too hard.' ); ?></p> | |
| 491 | - <p><?php esc_html_e( '<strong>Note.</strong> This is a default setting that FeedWordPress uses to schedule updates when the feed does not provide any scheduling requests. If this feed does provide update scheduling information (through elements such as <code><rss:ttl></code> or <code><sy:updateFrequency></code>), FeedWordPress will respect the feed’s request.' ); ?></p> | |
| 339 | + <p<?php if ($updateWindow<50) : ?> style="color: white; background-color: #703030; padding: 1.0em;"<?php endif; ?>><strong>Recommendation.</strong> Unless you are positive that you have the webmaster's permission, you generally should not set FeedWordPress to poll feeds more frequently than once every 60 minutes. Many webmasters consider more frequent automated polling to be abusive, and may complain to your web host, or ban your IP address, as retaliation for hammering their servers too hard.</p> | |
| 340 | + <p><strong>Note.</strong> This is a default setting that FeedWordPress uses to schedule updates when the feed does not provide any scheduling requests. If this feed does provide update scheduling information (through elements such as <code><rss:ttl></code> or <code><sy:updateFrequency></code>), FeedWordPress will respect the feed's request.</p> | |
| 492 | 341 | </div> |
| 493 | 342 | <?php |
| 494 | - } /* FeedWordPressFeedsPage::update_window_edit_box() */ | |
| 495 | - | |
| 496 | - /** | |
| 497 | - * Auxiliary function to update the window with current polling waiting period. | |
| 498 | - * | |
| 499 | - * @param int $updateWindow Minutes between polling. | |
| 500 | - * @param bool $defaulted Unused. | |
| 501 | - * @param array $params Unused. | |
| 502 | - */ | |
| 503 | - function update_window_currently( $updateWindow, $defaulted, $params ) { | |
| 343 | + } /* FeedWordPressFeedsPage::update_window_edit_box () */ | |
| 344 | + | |
| 345 | + function update_window_currently ($updateWindow, $defaulted, $params) { | |
| 504 | 346 | $updateWindow = (int) $updateWindow; |
| 505 | - if ( 1 == $updateWindow ) : | |
| 506 | - $caption = __( 'wait %d minute between polling' ); | |
| 347 | + if (1==$updateWindow) : | |
| 348 | + $caption = 'wait %d minute between polling'; | |
| 507 | 349 | else : |
| 508 | - $caption = __( 'wait %d minutes between polling' ); | |
| 350 | + $caption = 'wait %d minutes between polling'; | |
| 509 | 351 | endif; |
| 510 | - return sprintf( $caption, $updateWindow ); | |
| 511 | - } /* FeedWordPressFeedsPage::update_window_currently() */ | |
| 352 | + return sprintf(__($caption), $updateWindow); | |
| 353 | + } /* FeedWordPressFeedsPage::update_window_currently () */ | |
| 354 | + | |
| 355 | + function fetch_timeout_setting ($setting, $defaulted, $params) { | |
| 356 | + $timeout = intval($this->setting('fetch timeout', FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT)); | |
| 512 | 357 | |
| 513 | - /** | |
| 514 | - * Fetches the timeout setting. | |
| 515 | - * | |
| 516 | - * Nothing is returned, this just emits the HTML. | |
| 517 | - * | |
| 518 | - * @param int $setting Unused. | |
| 519 | - * @param bool $defaulted Unused. | |
| 520 | - * @param array $params Unused. | |
| 521 | - */ | |
| 522 | - function fetch_timeout_setting( $setting, $defaulted, $params ) { | |
| 523 | - /** var int Fetch feed timeout in seconds. */ | |
| 524 | - $timeout = intval( $this->setting( 'fetch timeout', FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT ) ); | |
| 525 | - | |
| 526 | - if ( $this->for_feed_settings() ) : | |
| 527 | - $article = __( 'this' ); | |
| 358 | + if ($this->for_feed_settings()) : | |
| 359 | + $article = 'this'; | |
| 528 | 360 | else : |
| 529 | - $article = __( 'a' ); | |
| 361 | + $article = 'a'; | |
| 530 | 362 | endif; |
| 531 | 363 | ?> |
| 532 | - <p><?php esc_html_e( 'Wait no more than' ); ?> <input name="fetch_timeout" type="number" min="0" size="3" value="<?php print esc_attr( $timeout ); ?>" /> | |
| 533 | - <?php esc_html_e( 'second(s) when trying to fetch '); print esc_html( $article ); esc_html_e(' feed to check for updates. '); ?></p> | |
| 534 | - <p><?php esc_html_e( 'If ' ); print esc_html( $article ); esc_html_e(' source’s web server does not respond before time runs | |
| 535 | - out, FeedWordPress will skip over the source and try again during the next update cycle.' ); ?></p> | |
| 364 | + <p>Wait no more than | |
| 365 | + than <input name="fetch_timeout" type="number" min="0" size="3" value="<?php print $timeout; ?>" /> | |
| 366 | + second(s) when trying to fetch <?php print $article; ?> feed to check for updates.</p> | |
| 367 | + <p>If <?php print $article; ?> source's web server does not respond before time runs | |
| 368 | + out, FeedWordPress will skip over the source and try again during | |
| 369 | + the next update cycle.</p> | |
| 536 | 370 | <?php |
| 537 | - } /* FeedWordPressFeedsPage::fetch_timeout_setting() */ | |
| 538 | - | |
| 539 | - /** | |
| 540 | - * Properly formats the feed timeout setting, with plurals if required. | |
| 541 | - * | |
| 542 | - * Nothing is returned, this just emits the HTML. | |
| 543 | - * | |
| 544 | - * @param int $setting Value for the feed timeout, in seconds. | |
| 545 | - * @param bool $defaulted Unused. | |
| 546 | - * @param array $params Unused. | |
| 547 | - */ | |
| 548 | - function fetch_timeout_setting_value( $setting, $defaulted, $params ) { | |
| 549 | - print number_format( intval( $setting) ) . " " . ( ( 1 == $setting ) ? "second" : "seconds" ); | |
| 550 | 371 | } |
| 551 | - | |
| 552 | - /** | |
| 553 | - * Displays the advanced settings box on the FWP dashboard page. | |
| 554 | - * | |
| 555 | - * @param FeedWordPressFeedsPage $page A page object, unused. | |
| 556 | - * @param mixed|null $box A box inside this object, unused. | |
| 557 | - */ | |
| 558 | - function advanced_settings_box( $page, $box = NULL ) { | |
| 372 | + function fetch_timeout_setting_value ($setting, $defaulted, $params) { | |
| 373 | + print number_format(intval($setting)) . " " . (($setting==1) ? "second" : "seconds"); | |
| 374 | + } | |
| 375 | + | |
| 376 | + function advanced_settings_box ($page, $box = NULL) { | |
| 559 | 377 | ?> |
| 560 | 378 | <table class="edit-form"> |
| 561 | 379 | <tr> |
| 562 | - <th><?php esc_html_e( 'Fetch Timeout:' ); ?></th> | |
| 380 | + <th>Fetch Timeout:</th> | |
| 563 | 381 | <td> |
| 564 | 382 | <?php |
| 565 | 383 | $this->setting_radio_control( |
| 566 | 384 | 'fetch timeout', 'fetch_timeout', |
| @@ -575,31 +393,29 @@ | ||
| 575 | 393 | ?> |
| 576 | 394 | </td> |
| 577 | 395 | </tr> |
| 578 | 396 | <tr> |
| 579 | - <th><?php esc_html_e( 'Feed Update Type:' ); ?></th> | |
| 397 | + <th>Feed Update Type:</th> | |
| 580 | 398 | <td><?php |
| 581 | - $this->setting_radio_control( 'update_incremental', 'update_incremental', | |
| 399 | + $this->setting_radio_control('update_incremental', 'update_incremental', | |
| 582 | 400 | /*options=*/ array( |
| 583 | - 'incremental' => __( '**Incremental.** When items no longer appear on the feed, keep them in the WordPress posts table.' ), | |
| 584 | - 'complete' => __( '**Complete.** When items no longer appear on the feed, they are obsolete; retire them from the WordPress posts table.' ), | |
| 401 | + 'incremental' => '<strong>Incremental.</strong> When items no longer appear on the feed, keep them in the WordPress posts table.', | |
| 402 | + 'complete' => '<strong>Complete.</strong> When items no longer appear on the feed, they are obsolete; retire them from the WordPress posts table.', | |
| 585 | 403 | ), |
| 586 | 404 | /*params=*/ array( |
| 587 | 405 | 'setting-default' => NULL, |
| 588 | 406 | 'global-setting-default' => 'incremental', |
| 589 | - 'default-input-value' => 'default', | |
| 407 | + 'default-input-value' => 'default', | |
| 590 | 408 | ) |
| 591 | 409 | ); ?></td> |
| 592 | 410 | </tr> |
| 593 | 411 | <tr> |
| 594 | - <th><?php esc_html_e( 'Allow Feeds to Delete Posts:' ); ?></th> | |
| 412 | + <th>Allow Feeds to Delete Posts:</th> | |
| 595 | 413 | <td><?php |
| 596 | - $this->setting_radio_control( | |
| 597 | - 'tombstones', | |
| 598 | - 'tombstones', | |
| 414 | + $this->setting_radio_control('tombstones', 'tombstones', | |
| 599 | 415 | /*options=*/ array( |
| 600 | - 'yes' => __( 'Yes. If a feed indicates that one of its posts has been deleted, delete the local copy syndicated to this website.' ), | |
| 601 | - 'no' => __( 'No. Even if a feed indicates that one of its posts has been deleted, retain the local copy on this website.' ), | |
| 416 | + 'yes' => 'Yes. If a feed indicates that one of its posts has been deleted, delete the local copy syndicated to this website.', | |
| 417 | + 'no' => 'No. Even if a feed indicates that one of its posts has been deleted, retain the local copy on this website.', | |
| 602 | 418 | ), |
| 603 | 419 | /*params=*/ array( |
| 604 | 420 | 'setting-default' => NULL, |
| 605 | 421 | 'global-setting-default' => 'yes', |
| @@ -608,61 +424,48 @@ | ||
| 608 | 424 | ); ?></td> |
| 609 | 425 | </tr> |
| 610 | 426 | </table> |
| 611 | 427 | <?php |
| 612 | - } /* FeedWordPressFeedsPage::advanced_settings_box() */ | |
| 613 | - | |
| 614 | - /** | |
| 615 | - * Shows a box for authentication credentials for a feed. | |
| 616 | - * | |
| 617 | - * @param array $params Array of parameters to parse. | |
| 618 | - */ | |
| 619 | - function display_authentication_credentials_box( $params = array() ) { | |
| 428 | + } /* FeedWordPressFeedsPage::advanced_settings_box () */ | |
| 429 | + | |
| 430 | + function display_authentication_credentials_box ($params = array()) { | |
| 620 | 431 | static $count = 0; |
| 621 | 432 | |
| 622 | - $params = wp_parse_args( | |
| 623 | - $params, | |
| 624 | - array( | |
| 625 | - 'username' => NULL, | |
| 626 | - 'password' => NULL, | |
| 627 | - 'method' => '-', | |
| 628 | - ), | |
| 629 | - ); | |
| 630 | - | |
| 433 | + $params = wp_parse_args($params, array( | |
| 434 | + 'username' => NULL, | |
| 435 | + 'password' => NULL, | |
| 436 | + 'method' => '-', | |
| 437 | + )); | |
| 438 | + | |
| 631 | 439 | // Equivalents |
| 632 | - if ( is_null( $params['method'] ) ) : $params['method'] = '-'; endif; | |
| 633 | - | |
| 440 | + if (is_null($params['method'])) : $params['method'] = '-'; endif; | |
| 441 | + | |
| 634 | 442 | $count++; |
| 635 | - /** var string Constructed slug for each feed credential. */ | |
| 636 | - $slug = ( $count > 1 ? '-' . $count : '' ); | |
| 637 | - | |
| 443 | + $slug = ($count > 1 ? '-'.$count : ''); | |
| 444 | + | |
| 638 | 445 | global $feedwordpress; |
| 639 | 446 | $authMethods = apply_filters( |
| 640 | 447 | 'feedwordpress_http_auth_methods', |
| 641 | - $feedwordpress->httpauth->methods_available(), | |
| 448 | + $feedwordpress->httpauth->methods_available() | |
| 642 | 449 | ); |
| 643 | 450 | |
| 644 | - $linkRssAuthId = sanitize_html_class( 'link-rss-authentication' . $slug ); | |
| 645 | - $linkRssCredentialsId = sanitize_html_class( 'link-rss-authentication-credentials' . $slug ); | |
| 646 | - $linkRssAuthMethodId = sanitize_html_class( 'link-rss-authentication-method' . $slug ); | |
| 647 | - | |
| 648 | - if ( count( $authMethods ) > 1 ) : /* More than '-' */ | |
| 451 | + if (count($authMethods) > 1) : /* More than '-' */ | |
| 649 | 452 | ?> |
| 650 | - <div class="link-rss-authentication" id="<?php print esc_attr( $linkRssAuthId ); ?>"> | |
| 453 | + <div class="link-rss-authentication" id="link-rss-authentication<?php print $slug; ?>"> | |
| 651 | 454 | <table> |
| 652 | 455 | <tbody> |
| 653 | - <tr class="link-rss-authentication-credentials" id="<?php print esc_attr( $linkRssCredentialsId ); ?>"> | |
| 654 | - <td><label><?php esc_html_e( 'user:' ); ?> <input type="text" name="link_rss_username" | |
| 655 | - value="<?php print esc_attr( $params['username'] ); ?>" size="16" | |
| 456 | + <tr class="link-rss-authentication-credentials" id="link-rss-authentication-credentials<?php print $slug; ?>"> | |
| 457 | + <td><label>user: <input type="text" name="link_rss_username" | |
| 458 | + value="<?php print esc_attr($params['username']); ?>" size="16" | |
| 656 | 459 | placeholder="username to access this feed" /></label></td> |
| 657 | - <td><label><?php esc_html_e( 'pass:' ); ?> <input type="text" name="link_rss_password" | |
| 658 | - value="<?php print esc_attr( $params['password'] ); ?>" size="16" | |
| 659 | - placeholder=<?php esc_html_e( 'password to access this feed' ); ?> /></label></td> | |
| 660 | - <td class="link-rss-authentication-method" id="<?php print esc_attr( $linkRssAuthMethodId ); ?>"><label><?php esc_html_e( 'method' ); ?>: <select class="link-rss-auth-method" id="link-rss-auth-method" name="link_rss_auth_method" size="1"> | |
| 661 | -<?php foreach ( $authMethods as $value => $label ) : ?> | |
| 662 | - <option value="<?php print esc_attr( $value ); ?>"<?php | |
| 663 | - fwp_selected_flag( $value == $params['method'] ); | |
| 664 | - ?>><?php print esc_html( $label ); ?></option> | |
| 460 | + <td><label>pass: <input type="text" name="link_rss_password" | |
| 461 | + value="<?php print esc_attr($params['password']); ?>" size="16" | |
| 462 | + placeholder="password to access this feed" /></label></td> | |
| 463 | + <td class="link-rss-authentication-method" id="link-rss-authentication-method<?php print $slug; ?>"><label>method: <select class="link-rss-auth-method" id="link-rss-auth-method" name="link_rss_auth_method" size="1"> | |
| 464 | +<?php foreach ($authMethods as $value => $label) : ?> | |
| 465 | + <option value="<?php print esc_attr($value); ?>"<?php | |
| 466 | + if ($value == $params['method']) : ?> selected="selected"<?php | |
| 467 | + endif; ?>><?php print esc_html($label); ?></option> | |
| 665 | 468 | <?php endforeach; ?> |
| 666 | 469 | </select></label></td> |
| 667 | 470 | </tr> |
| 668 | 471 | </tbody> |
| @@ -667,136 +470,128 @@ | ||
| 667 | 470 | </tr> |
| 668 | 471 | </tbody> |
| 669 | 472 | </table> |
| 670 | 473 | </div> |
| 671 | - | |
| 474 | + | |
| 672 | 475 | <script type="text/javascript"> |
| 673 | - jQuery('<td><a class="add-remove remove-it" id="link-rss-userpass-remove<?php print esc_attr( $slug ); ?>" href="#"><span class="x">(X)</span> <?php esc_html_e( 'Remove' ); ?></a></td>') | |
| 674 | - .appendTo('#<?php print esc_attr( $linkRssCredentialsId ); ?>' ) | |
| 476 | + jQuery('<td><a class="add-remove remove-it" id="link-rss-userpass-remove<?php print $slug; ?>" href="#"><span class="x">(X)</span> Remove</a></td>') | |
| 477 | + .appendTo('#link-rss-authentication-credentials<?php print $slug; ?>') | |
| 675 | 478 | .click( feedAuthenticationMethodUnPress ); |
| 676 | - jQuery( '#link-rss-auth-method<?php print esc_attr( $slug ); ?>' ).change( feedAuthenticationMethod ); | |
| 677 | - feedAuthenticationMethod( { | |
| 678 | - init: true, | |
| 679 | - node: jQuery( '#<?php print esc_attr( $linkRssAuthId ); ?>' ) | |
| 680 | - } ); | |
| 479 | + jQuery('#link-rss-auth-method<?php print $slug; ?>').change( feedAuthenticationMethod ); | |
| 480 | + feedAuthenticationMethod({ | |
| 481 | + init: true, | |
| 482 | + node: jQuery('#link-rss-authentication<?php print $slug; ?>') }); | |
| 681 | 483 | </script> |
| 682 | - | |
| 484 | + | |
| 683 | 485 | <?php |
| 684 | 486 | endif; |
| 685 | - } /* FeedWordPressFeedsPage::display_authentication_credentials_box() */ | |
| 686 | - | |
| 687 | - /** | |
| 688 | - * Displays a box with information about a feed. | |
| 689 | - * | |
| 690 | - * @param object $page Current page object (?). | |
| 691 | - * @param mixed|null $box A box inside this object. | |
| 692 | - * | |
| 693 | - * @uses get_categories() | |
| 694 | - * @uses get_category() | |
| 695 | - * @uses get_option() | |
| 696 | - * @uses maybe_unserialize() | |
| 697 | - * @uses FeedWordPress::link_category_id() | |
| 698 | - */ | |
| 699 | - function feed_information_box( $page, $box = NULL ) { | |
| 700 | - $link_rss_params = maybe_unserialize( $page->setting( 'query parameters', '' ) ); | |
| 701 | - if ( ! is_array( $link_rss_params ) ) : | |
| 487 | + } | |
| 488 | + | |
| 489 | + function feed_information_box ($page, $box = NULL) { | |
| 490 | + global $wpdb; | |
| 491 | + $link_rss_params = maybe_unserialize($page->setting('query parameters', '')); | |
| 492 | + if (!is_array($link_rss_params)) : | |
| 702 | 493 | $link_rss_params = array(); |
| 703 | 494 | endif; |
| 704 | - | |
| 705 | - if ( $page->for_feed_settings() ) : | |
| 706 | - $info['name'] = esc_html( $page->link->link->link_name ); | |
| 707 | - $info['description'] = esc_html( $page->link->link->link_description ); | |
| 708 | - $info['url'] = esc_html( $page->link->link->link_url ); | |
| 495 | + | |
| 496 | + if ($page->for_feed_settings()) : | |
| 497 | + $info['name'] = esc_html($page->link->link->link_name); | |
| 498 | + $info['description'] = esc_html($page->link->link->link_description); | |
| 499 | + $info['url'] = esc_html($page->link->link->link_url); | |
| 709 | 500 | $rss_url = $page->link->link->link_rss; |
| 710 | 501 | |
| 711 | - $hardcode['name'] = $page->link->hardcode( 'name' ); | |
| 712 | - $hardcode['description'] = $page->link->hardcode( 'description' ); | |
| 713 | - $hardcode['url'] = $page->link->hardcode( 'url' ); | |
| 502 | + $hardcode['name'] = $page->link->hardcode('name'); | |
| 503 | + $hardcode['description'] = $page->link->hardcode('description'); | |
| 504 | + $hardcode['url'] = $page->link->hardcode('url'); | |
| 714 | 505 | else : |
| 715 | 506 | $cat_id = FeedWordPress::link_category_id(); |
| 716 | 507 | |
| 717 | 508 | $params = array(); |
| 718 | - $params['taxonomy'] = 'link_category'; | |
| 509 | + if (FeedWordPressCompatibility::test_version(FWP_SCHEMA_USES_ARGS_TAXONOMY)) : | |
| 510 | + $params['taxonomy'] = 'link_category'; | |
| 511 | + else : | |
| 512 | + $params['type'] = 'link'; | |
| 513 | + endif; | |
| 719 | 514 | $params['hide_empty'] = false; |
| 720 | - $results = get_categories( $params ); | |
| 721 | - | |
| 722 | - /** var bool Guarantee that the Contributors category will be in the drop-down chooser, even if it is empty. */ | |
| 515 | + $results = get_categories($params); | |
| 516 | + | |
| 517 | + // Guarantee that the Contributors category will be in the drop-down chooser, even if it is empty. | |
| 723 | 518 | $found_link_category_id = false; |
| 724 | - foreach ( $results as $row ) : | |
| 519 | + foreach ($results as $row) : | |
| 725 | 520 | // Normalize case |
| 726 | - if ( ! isset( $row->cat_id ) ) : $row->cat_id = $row->cat_ID; endif; | |
| 521 | + if (!isset($row->cat_id)) : $row->cat_id = $row->cat_ID; endif; | |
| 727 | 522 | |
| 728 | - if ( $row->cat_id == $cat_id) : $found_link_category_id = true; endif; | |
| 523 | + if ($row->cat_id == $cat_id) : $found_link_category_id = true; endif; | |
| 729 | 524 | endforeach; |
| 730 | - | |
| 731 | - if ( ! $found_link_category_id ) : | |
| 732 | - $results[] = get_category( $cat_id ); | |
| 525 | + | |
| 526 | + if (!$found_link_category_id) : | |
| 527 | + $results[] = get_category($cat_id); | |
| 733 | 528 | endif; |
| 734 | - | |
| 529 | + | |
| 735 | 530 | $info = array(); |
| 736 | 531 | $rss_url = null; |
| 737 | 532 | |
| 738 | - $hardcode['name'] = get_option( 'feedwordpress_hardcode_name' ); | |
| 739 | - $hardcode['description'] = get_option( 'feedwordpress_hardcode_description' ); | |
| 740 | - $hardcode['url'] = get_option( 'feedwordpress_hardcode_url' ); | |
| 533 | + $hardcode['name'] = get_option('feedwordpress_hardcode_name'); | |
| 534 | + $hardcode['description'] = get_option('feedwordpress_hardcode_description'); | |
| 535 | + $hardcode['url'] = get_option('feedwordpress_hardcode_url'); | |
| 741 | 536 | endif; |
| 742 | 537 | |
| 743 | - /** @var bool Hide authentication (unused). */ | |
| 744 | 538 | $hideAuth = false; |
| 745 | 539 | |
| 746 | - $username = $this->setting( 'http username', NULL ); | |
| 540 | + $username = $this->setting('http username', NULL); | |
| 747 | 541 | |
| 748 | - if ( is_null( $username ) ) : | |
| 542 | + if (is_null($username)) : | |
| 749 | 543 | $username = ''; |
| 750 | 544 | $hideAuth = true; |
| 751 | 545 | endif; |
| 752 | - | |
| 753 | - $password = $this->setting( 'http password', NULL ); | |
| 754 | - if ( is_null( $password ) ) : | |
| 546 | + | |
| 547 | + $password = $this->setting('http password', NULL); | |
| 548 | + if (is_null($password)) : | |
| 755 | 549 | $password = ''; |
| 756 | 550 | endif; |
| 551 | + | |
| 552 | + $auth = $this->setting('http auth method', NULL); | |
| 757 | 553 | |
| 758 | - $auth = $this->setting( 'http auth method', NULL ); | |
| 554 | + global $feedwordpress; | |
| 759 | 555 | |
| 760 | - if ( is_null( $auth ) or ( strlen( $auth ) == 0 ) ) : | |
| 556 | + if (is_null($auth) or (strlen($auth)==0)) : | |
| 761 | 557 | $auth = '-'; |
| 762 | 558 | $hideAuth = true; |
| 763 | 559 | endif; |
| 764 | 560 | |
| 765 | 561 | // Hey ho, let's go |
| 766 | - | |
| 562 | + | |
| 767 | 563 | ?> |
| 768 | 564 | <table class="edit-form"> |
| 769 | 565 | |
| 770 | - <?php if ( $page->for_feed_settings() ) : ?> | |
| 566 | + <?php if ($page->for_feed_settings()) : ?> | |
| 771 | 567 | |
| 772 | 568 | <tr> |
| 773 | - <th scope="row"><?php esc_html_e( 'Feed URL:' ) ?></th> | |
| 774 | - <td><a href="<?php echo esc_html( $rss_url ); ?>"><?php echo esc_html( $rss_url ); ?></a> | |
| 775 | - (<a href="<?php echo esc_url( FEEDVALIDATOR_URI ); ?>?url=<?php echo urlencode( $rss_url ); ?>" | |
| 776 | - title="<?php esc_html_e( 'Check feed' ); ?> <<?php echo esc_html( $rss_url ); ?>> <?php esc_html_e( 'for validity' ); ?>">validate</a>) | |
| 569 | + <th scope="row"><?php _e('Feed URL:') ?></th> | |
| 570 | + <td><a href="<?php echo esc_html($rss_url); ?>"><?php echo esc_html($rss_url); ?></a> | |
| 571 | + (<a href="<?php echo FEEDVALIDATOR_URI; ?>?url=<?php echo urlencode($rss_url); ?>" | |
| 572 | + title="Check feed <<?php echo esc_html($rss_url); ?>> for validity">validate</a>) | |
| 777 | 573 | <input type="submit" name="feedfinder" value="switch →" style="font-size:smaller" /> |
| 778 | - | |
| 779 | - <?php $this->display_authentication_credentials_box( array( | |
| 780 | - 'username' => $username, | |
| 781 | - 'password' => $password, | |
| 782 | - 'method' => $auth, | |
| 783 | - ) | |
| 784 | - ); | |
| 785 | - ?> | |
| 574 | + | |
| 575 | + <?php $this->display_authentication_credentials_box(array( | |
| 576 | + 'username' => $username, | |
| 577 | + 'password' => $password, | |
| 578 | + 'method' => $auth, | |
| 579 | + )); ?> | |
| 580 | + | |
| 786 | 581 | <table id="link-rss-params"> |
| 787 | 582 | <tbody> |
| 788 | 583 | <?php |
| 789 | - $link_rss_params['new'] = array( '', '' ); | |
| 584 | + $link_rss_params['new'] = array('', ''); | |
| 790 | 585 | $i = 0; |
| 791 | - foreach ( $link_rss_params as $index => $pair ) : | |
| 586 | + foreach ($link_rss_params as $index => $pair) : | |
| 792 | 587 | ?> |
| 793 | - <tr class="link-rss-params-row" id="link-rss-params-<?php print esc_attr($index); ?>"> | |
| 794 | - <td><label><?php esc_html_e( 'Parameter' ); ?>: <input type="text" class="link_params_key" | |
| 795 | - name="link_rss_params_key[<?php print esc_attr( $index ); ?>]" value="<?php print esc_html( $pair[0] ); ?>" | |
| 588 | + <tr class="link-rss-params-row" id="link-rss-params-<?php print $index; ?>"> | |
| 589 | + <td><label>Parameter: <input type="text" class="link_params_key" | |
| 590 | + name="link_rss_params_key[<?php print $index; ?>]" value="<?php print esc_html($pair[0]); ?>" | |
| 796 | 591 | size="5" style="width: 5em" placeholder="name" /></label></td> |
| 797 | 592 | <td class="link-rss-params-value-cell"><label class="link_params_value_label">= <input type="text" class="link_params_value" |
| 798 | - name="link_rss_params_value[<?php print esc_attr( $index ); ?>]" value="<?php print esc_html( $pair[1] ); ?>" | |
| 593 | + name="link_rss_params_value[<?php print $index; ?>]" value="<?php print esc_html($pair[1]); ?>" | |
| 799 | 594 | size="8" placeholder="value" /></label></td> |
| 800 | 595 | </tr> |
| 801 | 596 | <?php |
| 802 | 597 | $i++; |
| @@ -803,49 +598,44 @@ | ||
| 803 | 598 | endforeach; |
| 804 | 599 | ?> |
| 805 | 600 | </tbody> |
| 806 | 601 | </table> |
| 807 | - | |
| 808 | - <div><input type="hidden" id="link-rss-params-num" name="link_rss_params_num" value="<?php print esc_attr($i); ?>" /></div> | |
| 809 | - | |
| 810 | - <script> | |
| 811 | - function linkParamsRowRemove( element ) { | |
| 812 | - jQuery( element ).closest( 'tr' ).fadeOut( | |
| 813 | - 'slow', | |
| 814 | - function () { | |
| 815 | - jQuery( this ).remove(); | |
| 816 | - } | |
| 817 | - ); | |
| 602 | + | |
| 603 | + <div><input type="hidden" id="link-rss-params-num" name="link_rss_params_num" value="<?php print $i; ?>" /></div> | |
| 604 | + | |
| 605 | + <script type="text/javascript"> | |
| 606 | + function linkParamsRowRemove (element) { | |
| 607 | + jQuery(element).closest('tr').fadeOut('slow', function () { | |
| 608 | + jQuery(this).remove(); | |
| 609 | + } ); | |
| 818 | 610 | } |
| 819 | 611 | |
| 820 | - jQuery('<td><a href="#" class="add-remove link-rss-params-remove"><span class="x">(X)</span> <?php esc_html_e( 'Remove' ); ?></a></td>' ).insertAfter( '.link-rss-params-value-cell' ); | |
| 612 | + jQuery('<td><a href="#" class="add-remove link-rss-params-remove"><span class="x">(X)</span> Remove</a></td>').insertAfter('.link-rss-params-value-cell'); | |
| 821 | 613 | |
| 822 | - jQuery( '#link-rss-params-new' ).hide(); | |
| 823 | - jQuery( '<a class="add-remove" id="link-rss-params-add" href="#"><span class="dashicons dashicons-plus fwp-no-underline"></span> <?php esc_html_e( 'Add a query parameter' ); ?></a>').insertAfter( '#link-rss-params' ); | |
| 824 | - jQuery( '#link-rss-params-add' ).click( function () { | |
| 825 | - var next = jQuery( '#link-rss-params-num' ).val(); | |
| 826 | - var newRow = jQuery( '#link-rss-params-new' ).clone().attr( 'id', 'link-rss-params-' + next ); | |
| 827 | - newRow.find( '.link_params_key' ).attr( 'name', 'link_rss_params_key[' + next + ']' ); | |
| 828 | - newRow.find( '.link_params_value' ).attr( 'name', 'link_rss_params_value[' + next + ']' ); | |
| 614 | + jQuery('#link-rss-params-new').hide(); | |
| 615 | + jQuery('<a class="add-remove" id="link-rss-params-add" href="#">+ Add a query parameter</a>').insertAfter('#link-rss-params'); | |
| 616 | + jQuery('#link-rss-params-add').click( function () { | |
| 617 | + var next = jQuery('#link-rss-params-num').val(); | |
| 618 | + var newRow = jQuery('#link-rss-params-new').clone().attr('id', 'link-rss-params-'+next); | |
| 619 | + newRow.find('.link_params_key').attr('name', 'link_rss_params_key['+next+']'); | |
| 620 | + newRow.find('.link_params_value').attr('name', 'link_rss_params_value['+next+']'); | |
| 621 | + | |
| 622 | + newRow.find('.link-rss-params-remove').click( function () { | |
| 623 | + linkParamsRowRemove(this); | |
| 624 | + return false; | |
| 625 | + } ); | |
| 829 | 626 | |
| 830 | - newRow.find( '.link-rss-params-remove' ).click( | |
| 831 | - function () { | |
| 832 | - linkParamsRowRemove( this ); | |
| 833 | - return false; | |
| 834 | - } | |
| 835 | - ); | |
| 836 | - | |
| 837 | - newRow.appendTo( '#link-rss-params' ); | |
| 627 | + newRow.appendTo('#link-rss-params'); | |
| 838 | 628 | newRow.show(); |
| 839 | - | |
| 629 | + | |
| 840 | 630 | // Update counter for next row. |
| 841 | 631 | next++; |
| 842 | - jQuery( '#link-rss-params-num' ).val( next ); | |
| 632 | + jQuery('#link-rss-params-num').val(next); | |
| 843 | 633 | |
| 844 | 634 | return false; |
| 845 | 635 | } ); |
| 846 | - jQuery( '.link-rss-params-remove' ).click( function () { | |
| 847 | - linkParamsRowRemove( this ); | |
| 636 | + jQuery('.link-rss-params-remove').click( function () { | |
| 637 | + linkParamsRowRemove(this); | |
| 848 | 638 | return false; |
| 849 | 639 | } ); |
| 850 | 640 | </script> |
| 851 | 641 | </td> |
| @@ -852,38 +642,34 @@ | ||
| 852 | 642 | </tr> |
| 853 | 643 | |
| 854 | 644 | <?php |
| 855 | 645 | $rows = array( |
| 856 | - "name" => __('Link Name'), | |
| 646 | + "name" => __('Link Name'), | |
| 857 | 647 | "description" => __('Short Description'), |
| 858 | - "url" => __('Homepage'), | |
| 648 | + "url" => __('Homepage'), | |
| 859 | 649 | ); |
| 860 | - foreach ( $rows as $what => $label ) : | |
| 861 | - $hardcode_name = sanitize_html_class( sprintf( 'hardcode_%s', $what ) ); | |
| 862 | - $hardcode_id = sanitize_html_class( sprintf( 'basics-hardcode-%s', $what ) ); | |
| 863 | - $hardcode_view_id = sanitize_html_class( sprintf( 'basics-%s-view', $what ) ); | |
| 864 | - $hardcode_edit_id = sanitize_html_class( sprintf( 'basics-%s-edit', $what ) ); | |
| 650 | + foreach ($rows as $what => $label) : | |
| 865 | 651 | ?> |
| 866 | 652 | <tr> |
| 867 | - <th scope="row"><?php print esc_html( $label ); ?></th> | |
| 653 | + <th scope="row"><?php print $label ?></th> | |
| 868 | 654 | <td> |
| 869 | - <div id="<?php print esc_attr( $hardcode_edit_id ); ?>"><input type="text" name="link<?php print esc_attr( $what ); ?>" | |
| 870 | - value="<?php echo esc_attr( $info[$what] ); ?>" style="width: 95%" /></div> | |
| 871 | - <div id="<?php print esc_attr( $hardcode_view_id ); ?>"> | |
| 872 | - <?php if ( 'url' == $what ) : ?><a href="<?php print esc_url( $info[$what] ); ?>"><?php else : ?><strong><?php endif; ?> | |
| 873 | - <?php print ( strlen( trim( $info[$what] ) ) > 0 ) ? esc_attr( $info[$what] ) : esc_attr__( '(none provided)' ); ?> | |
| 874 | - <?php if ( 'url' == $what ) : ?></a><?php else : ?></strong><?php endif; ?></div> | |
| 875 | - | |
| 655 | + <div id="basics-<?php print $what; ?>-edit"><input type="text" name="link<?php print $what; ?>" | |
| 656 | + value="<?php echo $info[$what]; ?>" style="width: 95%" /></div> | |
| 657 | + <div id="basics-<?php print $what; ?>-view"> | |
| 658 | + <?php if ($what=='url') : ?><a href="<?php print $info[$what]; ?>"><?php else : ?><strong><?php endif; ?> | |
| 659 | + <?php print (strlen(trim($info[$what])) > 0) ? $info[$what] : '(none provided)'; ?> | |
| 660 | + <?php if ($what=='url') : ?></a><?php else : ?></strong><?php endif; ?></div> | |
| 661 | + | |
| 876 | 662 | <div> |
| 877 | - <label><input id="<?php print esc_attr( $hardcode_id ); ?>" | |
| 878 | - type="radio" name="<?php print esc_attr( $hardcode_name ); ?>" value="no" | |
| 879 | - <?php echo ( ('yes' == $hardcode[$what] ) ? '' : ' checked="checked"');?> | |
| 880 | - onchange="contextual_appearance( 'basics-hardcode-<?php print esc_attr( $what ); ?>', '<?php print esc_attr( $hardcode_view_id ); ?>', '<?php print esc_attr( $hardcode_edit_id ); ?>', 'no', 'block', /*checkbox=*/ true )" | |
| 881 | - /> <?php esc_html_e( 'Update automatically from feed' ); ?></label> | |
| 882 | - <label><input type="radio" name="<?php print esc_attr( $hardcode_name ); ?>" value="yes" | |
| 883 | - <?php echo ( ( 'yes' != $hardcode[$what] ) ? '' : ' checked="checked"' );?> | |
| 884 | - onchange="contextual_appearance('<?php print esc_attr( $hardcode_id ); ?>', '<?php print esc_attr( $hardcode_view_id ); ?>', '<?php print esc_attr( $hardcode_edit_id ); ?>', 'no', 'block', /*checkbox=*/ true)" | |
| 885 | - /> <?php esc_html_e( 'Edit manually' ); ?></label> | |
| 663 | + <label><input id="basics-hardcode-<?php print $what; ?>" | |
| 664 | + type="radio" name="hardcode_<?php print $what; ?>" value="no" | |
| 665 | + <?php echo (($hardcode[$what]=='yes')?'':' checked="checked"');?> | |
| 666 | + onchange="contextual_appearance('basics-hardcode-<?php print $what; ?>', 'basics-<?php print $what; ?>-view', 'basics-<?php print $what; ?>-edit', 'no', 'block', /*checkbox=*/ true)" | |
| 667 | + /> Update automatically from feed</label> | |
| 668 | + <label><input type="radio" name="hardcode_<?php print $what; ?>" value="yes" | |
| 669 | + <?php echo (($hardcode[$what]!='yes')?'':' checked="checked"');?> | |
| 670 | + onchange="contextual_appearance('basics-hardcode-<?php print $what; ?>', 'basics-<?php print $what; ?>-view', 'basics-<?php print $what; ?>-edit', 'no', 'block', /*checkbox=*/ true)" | |
| 671 | + /> Edit manually</label> | |
| 886 | 672 | </div> |
| 887 | 673 | </td> |
| 888 | 674 | </tr> |
| 889 | 675 | <?php |
| @@ -892,41 +678,41 @@ | ||
| 892 | 678 | |
| 893 | 679 | <?php else : ?> |
| 894 | 680 | |
| 895 | 681 | <tr> |
| 896 | - <th scope="row"><?php esc_html_e( 'Syndicated Link category:' ); ?></th> | |
| 682 | + <th scope="row">Syndicated Link category:</th> | |
| 897 | 683 | <td><p><select name="syndication_category" size="1"> |
| 898 | 684 | <?php |
| 899 | - foreach ( $results as $row ) : | |
| 685 | + foreach ($results as $row) : | |
| 900 | 686 | // Normalize case |
| 901 | - if ( ! isset( $row->cat_id ) ) : $row->cat_id = $row->cat_ID; endif; | |
| 687 | + if (!isset($row->cat_id)) : $row->cat_id = $row->cat_ID; endif; | |
| 902 | 688 | |
| 903 | - echo "\n\t" . '<option value="' . esc_attr( $row->cat_id ) . '"'; | |
| 904 | - if ( $row->cat_id == $cat_id) : | |
| 905 | - echo ' selected="selected"'; | |
| 689 | + echo "\n\t<option value=\"$row->cat_id\""; | |
| 690 | + if ($row->cat_id == $cat_id) : | |
| 691 | + echo " selected='selected'"; | |
| 906 | 692 | endif; |
| 907 | - echo '>' . esc_attr( $row->cat_id ) . ': ' . esc_html( $row->cat_name ); | |
| 908 | - echo '</option>' . "\n"; | |
| 693 | + echo ">$row->cat_id: ".esc_html($row->cat_name); | |
| 694 | + echo "</option>\n"; | |
| 909 | 695 | endforeach; |
| 910 | 696 | ?></select></p> |
| 911 | - <p class="setting-description"><?php esc_html_e( 'FeedWordPress will syndicate the | |
| 912 | - links placed under this link category.' ); ?></p> | |
| 697 | + <p class="setting-description">FeedWordPress will syndicate the | |
| 698 | + links placed under this link category.</p> | |
| 913 | 699 | </td> |
| 914 | 700 | </tr> |
| 915 | - | |
| 701 | + | |
| 916 | 702 | <tr> |
| 917 | - <th scope="row"><?php esc_html_e( 'Link Names:' ); ?></th> | |
| 918 | - <td><label><input type="checkbox" name="hardcode_name" value="no"<?php echo ( ( 'yes' == $hardcode['name'] )? '' : ' checked="checked"' );?>/> <?php esc_html_e( 'Update contributor titles automatically when the feed title changes' ); ?></label></td> | |
| 703 | + <th scope="row">Link Names:</th> | |
| 704 | + <td><label><input type="checkbox" name="hardcode_name" value="no"<?php echo (($hardcode['name']=='yes')?'':' checked="checked"');?>/> Update contributor titles automatically when the feed title changes</label></td> | |
| 919 | 705 | </tr> |
| 920 | - | |
| 706 | + | |
| 921 | 707 | <tr> |
| 922 | - <th scope="row"><?php esc_html_e( 'Short descriptions:' ); ?></th> | |
| 923 | - <td><label><input type="checkbox" name="hardcode_description" value="no"<?php echo ( ( 'yes' == $hardcode['description'] ) ? '' : ' checked="checked"' );?>/> <?php esc_html_e( 'Update contributor descriptions automatically when the feed tagline changes' ); ?></label></td> | |
| 708 | + <th scope="row">Short descriptions:</th> | |
| 709 | + <td><label><input type="checkbox" name="hardcode_description" value="no"<?php echo (($hardcode['description']=='yes')?'':' checked="checked"');?>/> Update contributor descriptions automatically when the feed tagline changes</label></td> | |
| 924 | 710 | </tr> |
| 925 | - | |
| 711 | + | |
| 926 | 712 | <tr> |
| 927 | - <th scope="row"><?php esc_html_e( 'Homepages:' ); ?></th> | |
| 928 | - <td><label><input type="checkbox" name="hardcode_url" value="no"<?php echo ( ( 'yes' == $hardcode['url'] ) ? '' : ' checked="checked"' );?>/> <?php esc_html_e( 'Update contributor homepages automatically when the feed link changes' ); ?></label></td> | |
| 713 | + <th scope="row">Homepages:</th> | |
| 714 | + <td><label><input type="checkbox" name="hardcode_url" value="no"<?php echo (($hardcode['url']=='yes')?'':' checked="checked"');?>/> Update contributor homepages automatically when the feed link changes</label></td> | |
| 929 | 715 | </tr> |
| 930 | 716 | |
| 931 | 717 | <?php endif; ?> |
| 932 | 718 | |
| @@ -933,16 +719,16 @@ | ||
| 933 | 719 | </table> |
| 934 | 720 | <?php |
| 935 | 721 | } /* FeedWordPressFeedsPage::feed_information_box() */ |
| 936 | 722 | |
| 937 | - | |
| 938 | - function custom_settings_box( $page, $box = NULL ) { | |
| 723 | + function custom_settings_box ($page, $box = NULL) { | |
| 939 | 724 | $postsSettings = $this->admin_page_href('posts-page.php', array(), $page->link); |
| 940 | 725 | ?> |
| 941 | 726 | <p class="setting-description">These custom settings are special fields for the <strong>feed</strong> you are |
| 942 | 727 | syndicating, to be retrieved in templates using the <code>get_feed_meta()</code> function. They do not create |
| 943 | 728 | custom fields on syndicated <strong>posts</strong>. If you want to create custom fields that are applied to each |
| 944 | - individual post from this feed, set up the settings in <a href="<?php print esc_url($postsSettings); ?>">Syndicated Posts</a>.</p> | |
| 729 | + individual post from this feed, set up the settings in <a href="<?php print $postsSettings; ?>">Syndicated Posts</a>.</p> | |
| 730 | + | |
| 945 | 731 | <div id="postcustomstuff"> |
| 946 | 732 | <table id="meta-list" cellpadding="3"> |
| 947 | 733 | <tr> |
| 948 | 734 | <th>Key</th> |
| @@ -948,19 +734,19 @@ | ||
| 948 | 734 | <th>Key</th> |
| 949 | 735 | <th>Value</th> |
| 950 | 736 | <th>Action</th> |
| 951 | 737 | </tr> |
| 952 | - | |
| 738 | + | |
| 953 | 739 | <?php |
| 954 | 740 | $i = 0; |
| 955 | 741 | foreach ($page->link->settings as $key => $value) : |
| 956 | - if ( !preg_match("\007^((".implode(')|(', $page->special_settings)."))$\007i", $key)) : | |
| 742 | + if (!preg_match("\007^((".implode(')|(', $page->special_settings)."))$\007i", $key)) : | |
| 957 | 743 | ?> |
| 958 | 744 | <tr style="vertical-align:top"> |
| 959 | - <th width="30%" scope="row"><input type="hidden" name="notes[<?php echo esc_attr($i); ?>][key0]" value="<?php echo esc_html($key); ?>" /> | |
| 960 | - <input id="notes-<?php echo esc_attr($i); ?>-key" name="notes[<?php echo esc_attr($i); ?>][key1]" value="<?php echo esc_html($key); ?>" /></th> | |
| 961 | - <td width="60%"><textarea rows="2" cols="40" id="notes-<?php echo esc_attr($i); ?>-value" name="notes[<?php echo esc_attr($i); ?>][value]"><?php echo esc_html($value); ?></textarea></td> | |
| 962 | - <td width="10%"><select name="notes[<?php echo esc_attr($i); ?>][action]"> | |
| 745 | + <th width="30%" scope="row"><input type="hidden" name="notes[<?php echo $i; ?>][key0]" value="<?php echo esc_html($key); ?>" /> | |
| 746 | + <input id="notes-<?php echo $i; ?>-key" name="notes[<?php echo $i; ?>][key1]" value="<?php echo esc_html($key); ?>" /></th> | |
| 747 | + <td width="60%"><textarea rows="2" cols="40" id="notes-<?php echo $i; ?>-value" name="notes[<?php echo $i; ?>][value]"><?php echo esc_html($value); ?></textarea></td> | |
| 748 | + <td width="10%"><select name="notes[<?php echo $i; ?>][action]"> | |
| 963 | 749 | <option value="update">save changes</option> |
| 964 | 750 | <option value="delete">delete this setting</option> |
| 965 | 751 | </select></td> |
| 966 | 752 | </tr> |
| @@ -969,11 +755,11 @@ | ||
| 969 | 755 | endif; |
| 970 | 756 | endforeach; |
| 971 | 757 | ?> |
| 972 | 758 | <tr> |
| 973 | - <th scope="row"><input type="text" size="10" name="notes[<?php echo esc_attr( $i ); ?>][key1]" value="" /></th> | |
| 974 | - <td><textarea name="notes[<?php echo esc_attr( $i ); ?>][value]" rows="2" cols="40"></textarea></td> | |
| 975 | - <td><em>add new setting...</em><input type="hidden" name="notes[<?php echo esc_attr( $i ); ?>][action]" value="update" /></td> | |
| 759 | + <th scope="row"><input type="text" size="10" name="notes[<?php echo $i; ?>][key1]" value="" /></th> | |
| 760 | + <td><textarea name="notes[<?php echo $i; ?>][value]" rows="2" cols="40"></textarea></td> | |
| 761 | + <td><em>add new setting...</em><input type="hidden" name="notes[<?php echo $i; ?>][action]" value="update" /></td> | |
| 976 | 762 | </tr> |
| 977 | 763 | </table> |
| 978 | 764 | </div> <!-- id="postcustomstuff" --> |
| 979 | 765 | <?php |
| @@ -983,9 +769,9 @@ | ||
| 983 | 769 | $ret = NULL; |
| 984 | 770 | if (is_wp_error($err)) : |
| 985 | 771 | if ($err->get_error_code()=='http_request_failed') : |
| 986 | 772 | $data = $err->get_error_data('http_request_failed'); |
| 987 | - | |
| 773 | + | |
| 988 | 774 | if (is_array($data) and isset($data['status'])) : |
| 989 | 775 | if (401==$data['status']) : |
| 990 | 776 | $ret = $data['uri']; |
| 991 | 777 | endif; |
| @@ -993,15 +779,17 @@ | ||
| 993 | 779 | endif; |
| 994 | 780 | endif; |
| 995 | 781 | return $ret; |
| 996 | 782 | } |
| 997 | - | |
| 783 | + | |
| 998 | 784 | function display_feedfinder () { |
| 999 | - $lookup = FeedWordPress::param( 'lookup' ); | |
| 1000 | - | |
| 1001 | - $auth = FeedWordPress::param( 'link_rss_auth_method' ); | |
| 1002 | - $username = FeedWordPress::param( 'link_rss_username' ); | |
| 1003 | - $password = FeedWordPress::param( 'link_rss_password' ); | |
| 785 | + global $wpdb; | |
| 786 | + | |
| 787 | + $lookup = (isset($_REQUEST['lookup']) ? $_REQUEST['lookup'] : NULL); | |
| 788 | + | |
| 789 | + $auth = MyPHP::request('link_rss_auth_method'); | |
| 790 | + $username = MyPHP::request('link_rss_username'); | |
| 791 | + $password = MyPHP::request('link_rss_password'); | |
| 1004 | 792 | $credentials = array( |
| 1005 | 793 | "authentication" => $auth, |
| 1006 | 794 | "username" => $username, |
| 1007 | 795 | "password" => $password, |
| @@ -1018,21 +806,21 @@ | ||
| 1018 | 806 | $lookup = $this->link->link->link_url; |
| 1019 | 807 | $auth = $this->link->setting('http auth method'); |
| 1020 | 808 | $username = $this->link->setting('http username'); |
| 1021 | 809 | $password = $this->link->setting('http password'); |
| 1022 | - | |
| 810 | + | |
| 1023 | 811 | // Guarantee that you at least have the option to |
| 1024 | 812 | // stick with what works. |
| 1025 | 813 | $current = $this->link->link->link_rss; |
| 1026 | 814 | $feeds[] = $current; |
| 1027 | 815 | endif; |
| 1028 | - $name = $this->link->link->link_name; | |
| 816 | + $name = esc_html($this->link->link->link_name); | |
| 1029 | 817 | else: // Or a new subscription to add? |
| 1030 | - $name = "Subscribe to ".feedwordpress_display_url($lookup); | |
| 818 | + $name = "Subscribe to <code>".esc_html(feedwordpress_display_url($lookup))."</code>"; | |
| 1031 | 819 | endif; |
| 1032 | 820 | ?> |
| 1033 | 821 | <div class="wrap" id="feed-finder"> |
| 1034 | - <h2>Feed Finder: <?php echo esc_html($name); ?></h2> | |
| 822 | + <h2>Feed Finder: <?php echo $name; ?></h2> | |
| 1035 | 823 | |
| 1036 | 824 | <?php |
| 1037 | 825 | if ($feedSwitch) : |
| 1038 | 826 | $this->display_alt_feed_box($lookup); |
| @@ -1038,23 +826,23 @@ | ||
| 1038 | 826 | $this->display_alt_feed_box($lookup); |
| 1039 | 827 | endif; |
| 1040 | 828 | |
| 1041 | 829 | $finder = array(); |
| 1042 | - if ( !is_null($current)) : | |
| 830 | + if (!is_null($current)) : | |
| 1043 | 831 | $finder[$current] = new FeedFinder($current); |
| 1044 | 832 | endif; |
| 1045 | 833 | $finder[$lookup] = new FeedFinder($lookup); |
| 1046 | - | |
| 834 | + | |
| 1047 | 835 | foreach ($finder as $url => $ff) : |
| 1048 | 836 | $feeds = array_merge($feeds, $ff->find( |
| 1049 | 837 | /*url=*/ NULL, |
| 1050 | 838 | /*params=*/ $credentials)); |
| 1051 | 839 | endforeach; |
| 1052 | - | |
| 840 | + | |
| 1053 | 841 | $feeds = array_values( // Renumber from 0..(N-1) |
| 1054 | 842 | $feeds |
| 1055 | 843 | ); |
| 1056 | - | |
| 844 | + | |
| 1057 | 845 | // Allow for some simple FeedFinder results filtering |
| 1058 | 846 | $feeds = apply_filters( |
| 1059 | 847 | 'feedwordpress_feedfinder_results', |
| 1060 | 848 | $feeds, |
| @@ -1066,9 +854,9 @@ | ||
| 1066 | 854 | "finder" => $finder, |
| 1067 | 855 | ), |
| 1068 | 856 | $this |
| 1069 | 857 | ); |
| 1070 | - | |
| 858 | + | |
| 1071 | 859 | if (count($feeds) > 0): |
| 1072 | 860 | if ($feedSwitch) : |
| 1073 | 861 | ?> |
| 1074 | 862 | <h3>Feeds Found</h3> |
| @@ -1076,9 +864,9 @@ | ||
| 1076 | 864 | endif; |
| 1077 | 865 | |
| 1078 | 866 | if (count($feeds) > 1) : |
| 1079 | 867 | $option_template = 'Option %d: '; |
| 1080 | - $form_class = 'multi'; | |
| 868 | + $form_class = ' class="multi"'; | |
| 1081 | 869 | ?> |
| 1082 | 870 | <p><strong>This web page provides at least <?php print count($feeds); ?> different feeds.</strong> These feeds may provide the same information |
| 1083 | 871 | in different formats, or may track different items. (You can check the Feed Information and the |
| 1084 | 872 | Sample Item for each feed to get an idea of what the feed provides.) Please select the feed that you'd like to subscribe to.</p> |
| @@ -1088,15 +876,15 @@ | ||
| 1088 | 876 | $form_class = ''; |
| 1089 | 877 | endif; |
| 1090 | 878 | |
| 1091 | 879 | global $fwp_credentials; |
| 1092 | - | |
| 880 | + | |
| 1093 | 881 | foreach ($feeds as $key => $f): |
| 1094 | 882 | $ofc = $fwp_credentials; |
| 1095 | 883 | $fwp_credentials = $credentials; // Set |
| 1096 | 884 | $pie = FeedWordPress::fetch($f, array("cache" => false)); |
| 1097 | 885 | $fwp_credentials = $ofc; // Re-Set |
| 1098 | - | |
| 886 | + | |
| 1099 | 887 | $rss = (is_wp_error($pie) ? $pie : new MagpieFromSimplePie($pie)); |
| 1100 | 888 | |
| 1101 | 889 | if ($this->url_for_401($pie)) : |
| 1102 | 890 | $this->display_alt_feed_box($lookup, array( |
| @@ -1106,9 +894,9 @@ | ||
| 1106 | 894 | "password" => $password |
| 1107 | 895 | )); |
| 1108 | 896 | continue; |
| 1109 | 897 | endif; |
| 1110 | - | |
| 898 | + | |
| 1111 | 899 | if ($rss and !is_wp_error($rss)): |
| 1112 | 900 | $feed_link = (isset($rss->channel['link'])?$rss->channel['link']:''); |
| 1113 | 901 | $feed_title = (isset($rss->channel['title'])?$rss->channel['title']:$feed_link); |
| 1114 | 902 | $feed_type = ($rss->feed_type ? $rss->feed_type : 'Unknown'); |
| @@ -1122,14 +910,14 @@ | ||
| 1122 | 910 | $feed_version_template = ''; |
| 1123 | 911 | $feed_version = ''; |
| 1124 | 912 | endif; |
| 1125 | 913 | ?> |
| 1126 | - <form <?php fwp_form_class_attr($form_class); ?> action="<?php print esc_url( $this->form_action( 'syndication.php' ) ); ?>" method="post"> | |
| 914 | + <form<?php print $form_class; ?> action="<?php print $this->form_action('syndication.php'); ?>" method="post"> | |
| 1127 | 915 | <div class="inside"><?php FeedWordPressCompatibility::stamp_nonce('feedwordpress_switchfeed'); ?> |
| 1128 | 916 | |
| 1129 | 917 | <?php |
| 1130 | 918 | $classes = array('feed-found'); $currentFeed = ''; |
| 1131 | - if ( !is_null($current) and $current==$f) : | |
| 919 | + if (!is_null($current) and $current==$f) : | |
| 1132 | 920 | $classes[] = 'current'; |
| 1133 | 921 | $currentFeed = ' (currently subscribed)'; |
| 1134 | 922 | endif; |
| 1135 | 923 | if ($key%2) : |
| @@ -1135,10 +923,10 @@ | ||
| 1135 | 923 | if ($key%2) : |
| 1136 | 924 | $classes[] = 'alt'; |
| 1137 | 925 | endif; |
| 1138 | 926 | ?> |
| 1139 | - <fieldset class="<?php print esc_attr( implode(" ", $classes) ); ?>"> | |
| 1140 | - <legend><?php print esc_html( sprintf( $option_template, ( $key + 1 ) ) ); print esc_html($feed_type) . " "; print esc_html( sprintf( $feed_version_template, $feed_version ) ); ?> feed<?php print esc_html( $currentFeed ); ?></legend> | |
| 927 | + <fieldset class="<?php print implode(" ", $classes); ?>"> | |
| 928 | + <legend><?php printf($option_template, ($key+1)); print $feed_type." "; printf($feed_version_template, $feed_version); ?> feed<?php print $currentFeed; ?></legend> | |
| 1141 | 929 | |
| 1142 | 930 | <?php |
| 1143 | 931 | $this->stamp_link_id(); |
| 1144 | 932 | |
| @@ -1144,9 +932,9 @@ | ||
| 1144 | 932 | |
| 1145 | 933 | // No feed specified = add new feed; we |
| 1146 | 934 | // need to pass along a starting title |
| 1147 | 935 | // and homepage URL for the new Link. |
| 1148 | - if ( ! $this->for_feed_settings()): | |
| 936 | + if (!$this->for_feed_settings()): | |
| 1149 | 937 | ?> |
| 1150 | 938 | <input type="hidden" name="feed_title" value="<?php echo esc_html($feed_title); ?>" /> |
| 1151 | 939 | <input type="hidden" name="feed_link" value="<?php echo esc_html($feed_link); ?>" /> |
| 1152 | 940 | <?php |
| @@ -1158,11 +946,11 @@ | ||
| 1158 | 946 | |
| 1159 | 947 | <div> |
| 1160 | 948 | <div class="feed-sample"> |
| 1161 | 949 | <?php |
| 1162 | - $link = null; | |
| 1163 | - $post = null; | |
| 1164 | - if ( !is_wp_error($rss) && !empty($rss->items) && is_array($rss->items) ): | |
| 950 | + $link = NULL; | |
| 951 | + $post = NULL; | |
| 952 | + if (!is_wp_error($rss) and count($rss->items) > 0): | |
| 1165 | 953 | // Prepare to display Sample Item |
| 1166 | 954 | $link = new MagpieMockLink(array('simplepie' => $pie, 'magpie' => $rss), $f); |
| 1167 | 955 | $post = new SyndicatedPost(array('simplepie' => $rss->originals[0], 'magpie' => $rss->items[0]), $link); |
| 1168 | 956 | ?> |
| @@ -1167,13 +955,13 @@ | ||
| 1167 | 955 | $post = new SyndicatedPost(array('simplepie' => $rss->originals[0], 'magpie' => $rss->items[0]), $link); |
| 1168 | 956 | ?> |
| 1169 | 957 | <h3>Sample Item</h3> |
| 1170 | 958 | <ul> |
| 1171 | - <li><strong>Title:</strong> <a href="<?php echo esc_url( $post->post['meta']['syndication_permalink'] ); ?>"><?php echo esc_html( $post->post['post_title'] ); ?></a></li> | |
| 1172 | - <li><strong>Date:</strong> <?php print esc_html( date('d-M-y g:i:s a', $post->published() ) ); ?></li> | |
| 959 | + <li><strong>Title:</strong> <a href="<?php echo $post->post['meta']['syndication_permalink']; ?>"><?php echo $post->post['post_title']; ?></a></li> | |
| 960 | + <li><strong>Date:</strong> <?php print date('d-M-y g:i:s a', $post->published()); ?></li> | |
| 1173 | 961 | </ul> |
| 1174 | 962 | <div class="entry"> |
| 1175 | - <?php print wp_kses( $post->post['post_content'], 'post' ); ?> | |
| 963 | + <?php print $post->post['post_content']; ?> | |
| 1176 | 964 | </div> |
| 1177 | 965 | <?php |
| 1178 | 966 | do_action('feedwordpress_feed_finder_sample_item', $f, $post, $link); |
| 1179 | 967 | else: |
| @@ -1181,9 +969,9 @@ | ||
| 1181 | 969 | print '<div class="feed-problem">'; |
| 1182 | 970 | print "<h3>Problem:</h3>\n"; |
| 1183 | 971 | print "<p>FeedWordPress encountered the following error |
| 1184 | 972 | when trying to retrieve this feed:</p>"; |
| 1185 | - print '<p style="margin: 1.0em 3.0em"><code>' . esc_html( $rss->get_error_message() ) . '</code></p>'; | |
| 973 | + print '<p style="margin: 1.0em 3.0em"><code>'.$rss->get_error_message().'</code></p>'; | |
| 1186 | 974 | print "<p>If you think this is a temporary problem, you can still force FeedWordPress to add the subscription. FeedWordPress will not be able to find any syndicated posts until this problem is resolved.</p>"; |
| 1187 | 975 | print "</div>"; |
| 1188 | 976 | endif; |
| 1189 | 977 | ?> |
| @@ -1192,16 +980,16 @@ | ||
| 1192 | 980 | <?php |
| 1193 | 981 | endif; |
| 1194 | 982 | ?> |
| 1195 | 983 | </div> |
| 1196 | - | |
| 984 | + | |
| 1197 | 985 | <div> |
| 1198 | 986 | <h3>Feed Information</h3> |
| 1199 | 987 | <ul> |
| 1200 | - <li><strong>Homepage:</strong> <a href="<?php echo esc_url( $feed_link ); ?>"><?php echo is_null( $feed_title )?'<em>Unknown</em>': esc_html( $feed_title ); ?></a></li> | |
| 1201 | - <li><strong>Feed URL:</strong> <a title="<?php echo esc_html( $f ); ?>" href="<?php echo esc_url( $f ); ?>"><?php echo esc_html( feedwordpress_display_url($f, 40, 10) ); ?></a> (<a title="Check feed <<?php echo esc_html( $f ); ?>> for validity" href="http://feedvalidator.org/check.cgi?url=<?php echo urlencode( $f ); ?>">validate</a>)</li> | |
| 1202 | - <li><strong>Encoding:</strong> <?php echo isset($rss->encoding) ? esc_html($rss->encoding) : "<em>Unknown</em>"; ?></li> | |
| 1203 | - <li><strong>Description:</strong> <?php echo isset($rss->channel['description']) ? esc_html($rss->channel['description']) : "<em>Unknown</em>"; ?></li> | |
| 988 | + <li><strong>Homepage:</strong> <a href="<?php echo $feed_link; ?>"><?php echo is_null($feed_title)?'<em>Unknown</em>':$feed_title; ?></a></li> | |
| 989 | + <li><strong>Feed URL:</strong> <a title="<?php echo esc_html($f); ?>" href="<?php echo esc_html($f); ?>"><?php echo esc_html(feedwordpress_display_url($f, 40, 10)); ?></a> (<a title="Check feed <<?php echo esc_html($f); ?>> for validity" href="http://feedvalidator.org/check.cgi?url=<?php echo urlencode($f); ?>">validate</a>)</li> | |
| 990 | + <li><strong>Encoding:</strong> <?php echo isset($rss->encoding)?esc_html($rss->encoding):"<em>Unknown</em>"; ?></li> | |
| 991 | + <li><strong>Description:</strong> <?php echo isset($rss->channel['description'])?esc_html($rss->channel['description']):"<em>Unknown</em>"; ?></li> | |
| 1204 | 992 | </ul> |
| 1205 | 993 | <?php $this->display_authentication_credentials_box(array( |
| 1206 | 994 | 'username' => $username, |
| 1207 | 995 | 'password' => $password, |
| @@ -1220,58 +1008,53 @@ | ||
| 1220 | 1008 | unset($post); |
| 1221 | 1009 | endforeach; |
| 1222 | 1010 | else: |
| 1223 | 1011 | foreach ($finder as $url => $ff) : |
| 1224 | - print '<h3>Searched for feeds at '. esc_html( $url ) . '</h3>' . "\n"; | |
| 1225 | - print '<p><strong>' . esc_html__( 'Error' ) . ':</strong> ' . esc_html__( 'FeedWordPress couldn\'t find any feeds at' ).' <code><a href="' . esc_url( $lookup ) . '">' . esc_html( $lookup ) . '</a></code>'; | |
| 1226 | - print '. ' . esc_html__( 'Try another URL' ) . '.</p>'; | |
| 1227 | - | |
| 1012 | + $url = esc_html($url); | |
| 1013 | + print "<h3>Searched for feeds at ${url}</h3>\n"; | |
| 1014 | + print "<p><strong>".__('Error').":</strong> ".__("FeedWordPress couldn't find any feeds at").' <code><a href="'.htmlspecialchars($lookup).'">'.htmlspecialchars($lookup).'</a></code>'; | |
| 1015 | + print ". ".__('Try another URL').".</p>"; | |
| 1016 | + | |
| 1228 | 1017 | // Diagnostics |
| 1229 | 1018 | print "<div class=\"updated\" style=\"margin-left: 3.0em; margin-right: 3.0em;\">\n"; |
| 1230 | - print '<h3>' . esc_html__( 'Diagnostic information' ) . '</h3>' . "\n"; | |
| 1231 | - if ( !is_null($ff->error()) and strlen($ff->error()) > 0) : | |
| 1232 | - print '<h4>'. esc_html__( 'HTTP request failure' ) . '</h4>' . "\n"; | |
| 1233 | - print '<p>' . esc_html( $ff->error() ) ."</p>\n"; | |
| 1019 | + print "<h3>".__('Diagnostic information')."</h3>\n"; | |
| 1020 | + if (!is_null($ff->error()) and strlen($ff->error()) > 0) : | |
| 1021 | + print "<h4>".__('HTTP request failure')."</h4>\n"; | |
| 1022 | + print "<p>".$ff->error()."</p>\n"; | |
| 1234 | 1023 | else : |
| 1235 | - print '<h4>' . esc_html__( 'HTTP request completed' ) . '</h4>' . "\n"; | |
| 1236 | - print '<p><strong>Status ' . esc_html( $ff->status() ) . ':</strong> '. esc_html( $this->HTTPStatusMessages[ (int) $ff->status() ] ) ."</p>\n"; | |
| 1024 | + print "<h4>".__('HTTP request completed')."</h4>\n"; | |
| 1025 | + print "<p><strong>Status ".$ff->status().":</strong> ".$this->HTTPStatusMessages[(int) $ff->status()]."</p>\n"; | |
| 1237 | 1026 | endif; |
| 1238 | 1027 | |
| 1239 | 1028 | // Do some more diagnostics if the API for it is available. |
| 1240 | - // Note to @radgeek: consider using a hook instead: https://developer.wordpress.org/reference/hooks/http_api_transports/ (gwyneth 20230920) | |
| 1241 | - if ( function_exists( '_wp_http_get_object' ) ) : | |
| 1029 | + if (function_exists('_wp_http_get_object')) : | |
| 1242 | 1030 | $httpObject = _wp_http_get_object(); |
| 1243 | - | |
| 1244 | - /* | |
| 1245 | - // _getTransport() was totally deprecated (gwyneth 20230920) | |
| 1031 | + | |
| 1246 | 1032 | if (is_callable(array($httpObject, '_getTransport'))) : |
| 1247 | - | |
| 1248 | 1033 | $transports = $httpObject->_getTransport(); |
| 1249 | - | |
| 1034 | + | |
| 1250 | 1035 | print "<h4>".__('HTTP Transports available').":</h4>\n"; |
| 1251 | 1036 | print "<ol>\n"; |
| 1252 | 1037 | print "<li>".implode("</li>\n<li>", array_map('get_class', $transports))."</li>\n"; |
| 1253 | 1038 | print "</ol>\n"; |
| 1254 | - else | |
| 1255 | - */ | |
| 1256 | - if ( is_callable( array( $httpObject, '_get_first_available_transport' ) ) ) : | |
| 1039 | + elseif (is_callable(array($httpObject, '_get_first_available_transport'))) : | |
| 1257 | 1040 | $transport = $httpObject->_get_first_available_transport( |
| 1258 | 1041 | array(), |
| 1259 | 1042 | $url |
| 1260 | 1043 | ); |
| 1261 | - | |
| 1262 | - print "<h4>" . esc_html__("HTTP Transport") . ":</h4>\n"; | |
| 1044 | + | |
| 1045 | + print "<h4>".__("HTTP Transport").":</h4>\n"; | |
| 1263 | 1046 | print "<ol>\n"; |
| 1264 | - print "<li>" . esc_html( MyPHP::val($transport) ) . "</li>\n"; | |
| 1047 | + print "<li>".MyPHP::val($transport)."</li>\n"; | |
| 1265 | 1048 | print "</ol>\n"; |
| 1266 | 1049 | endif; |
| 1267 | - | |
| 1050 | + | |
| 1268 | 1051 | print "</div>\n"; |
| 1269 | 1052 | endif; |
| 1270 | 1053 | endforeach; |
| 1271 | 1054 | endif; |
| 1272 | - | |
| 1273 | - if ( ! $feedSwitch) : | |
| 1055 | + | |
| 1056 | + if (!$feedSwitch) : | |
| 1274 | 1057 | $this->display_alt_feed_box($lookup, /*alt=*/ true); |
| 1275 | 1058 | endif; |
| 1276 | 1059 | ?> |
| 1277 | 1060 | </div> <!-- class="wrap" --> |
| @@ -1278,14 +1061,15 @@ | ||
| 1278 | 1061 | <?php |
| 1279 | 1062 | return false; // Don't continue |
| 1280 | 1063 | } /* FeedWordPressFeedsPage::display_feedfinder() */ |
| 1281 | 1064 | |
| 1282 | - function display_alt_feed_box ($lookup, $params = false) | |
| 1283 | - { | |
| 1065 | + function display_alt_feed_box ($lookup, $params = false) { | |
| 1066 | + global $fwp_post; | |
| 1067 | + | |
| 1284 | 1068 | if (is_bool($params)) : |
| 1285 | 1069 | $params = array("alt" => $params); |
| 1286 | 1070 | endif; |
| 1287 | - | |
| 1071 | + | |
| 1288 | 1072 | $params = wp_parse_args($params, array( // Defaults |
| 1289 | 1073 | "alt" => false, |
| 1290 | 1074 | "err" => NULL, |
| 1291 | 1075 | "auth" => NULL, |
| @@ -1292,16 +1076,16 @@ | ||
| 1292 | 1076 | "password" => NULL, |
| 1293 | 1077 | "username" => NULL, |
| 1294 | 1078 | )); |
| 1295 | 1079 | $alt = $params['alt']; |
| 1296 | - | |
| 1080 | + | |
| 1297 | 1081 | ?> |
| 1298 | - <form action="<?php print esc_url( $this->form_action('syndication.php') ); ?>" method="post"> | |
| 1082 | + <form action="<?php print $this->form_action('syndication.php'); ?>" method="post"> | |
| 1299 | 1083 | <div class="inside"><?php |
| 1300 | 1084 | FeedWordPressCompatibility::stamp_nonce('feedwordpress_feeds'); |
| 1301 | 1085 | ?> |
| 1302 | 1086 | <fieldset class="alt" |
| 1303 | - <?php if ( ! $alt): ?>style="margin: 1.0em 3.0em; font-size: smaller;"<?php endif; ?>> | |
| 1087 | + <?php if (!$alt): ?>style="margin: 1.0em 3.0em; font-size: smaller;"<?php endif; ?>> | |
| 1304 | 1088 | <legend><?php if ($alt) : ?>Alternative feeds<?php else: ?>Find feeds<?php endif; ?></legend> |
| 1305 | 1089 | <?php if ($alt) : ?><h3>Use a different feed</h3><?php endif; ?> |
| 1306 | 1090 | <?php if (is_wp_error($params['err'])) : |
| 1307 | 1091 | ?> |
| @@ -1338,39 +1122,32 @@ | ||
| 1338 | 1122 | will try to automatically detect any feeds associated with a |
| 1339 | 1123 | website.</p> |
| 1340 | 1124 | </div> <!-- class="inside" --> |
| 1341 | 1125 | </fieldset></form> |
| 1342 | - | |
| 1126 | + | |
| 1343 | 1127 | <?php |
| 1344 | 1128 | } /* FeedWordPressFeedsPage::display_alt_feed_box() */ |
| 1345 | - | |
| 1346 | - function save_settings () { | |
| 1129 | + | |
| 1130 | + function save_settings ($post) { | |
| 1347 | 1131 | if ($this->for_feed_settings()) : |
| 1348 | - $params_key = FeedWordPress::post( 'link_rss_params_key', array() ); | |
| 1349 | - | |
| 1350 | - if ( is_array( $params_key ) && count($params_key) > 0 ) : | |
| 1351 | - $params_values = FeedWordPress::post( 'link_rss_params_value', array() ); | |
| 1132 | + | |
| 1133 | + if (isset($post['link_rss_params_key'])) : | |
| 1352 | 1134 | $qp = array(); |
| 1353 | - foreach ( $params_key as $index => $key ) : | |
| 1135 | + foreach ($post['link_rss_params_key'] as $index => $key) : | |
| 1354 | 1136 | if (strlen($key) > 0) : |
| 1355 | - | |
| 1356 | - if ( isset( $params_values[ $index ] ) ) : | |
| 1357 | - | |
| 1358 | - $params_value = $params_values[ $index ]; | |
| 1359 | - if ( strlen($params_value) > 0 ) : | |
| 1360 | - $qp[] = array( $key, $params_value ); | |
| 1361 | - endif; | |
| 1137 | + if (isset($post['link_rss_params_value'][$index]) | |
| 1138 | + and strlen($post['link_rss_params_value'][$index])) : | |
| 1139 | + $value = $post['link_rss_params_value'][$index]; | |
| 1140 | + $qp[] = array($key, $value); | |
| 1362 | 1141 | endif; |
| 1363 | 1142 | endif; |
| 1364 | 1143 | endforeach; |
| 1365 | 1144 | $this->update_setting('query parameters', serialize($qp)); |
| 1366 | - | |
| 1367 | 1145 | endif; |
| 1368 | - | |
| 1146 | + | |
| 1369 | 1147 | // custom feed settings first |
| 1370 | - $param_notes = FeedWordPress::post( 'notes', array() ); | |
| 1371 | - foreach ( $param_notes as $mn ) : | |
| 1372 | - $mn['key0'] = ( isset($mn['key0']) ? trim($mn['key0']) : null ); | |
| 1148 | + foreach ($post['notes'] as $mn) : | |
| 1149 | + $mn['key0'] = (isset($mn['key0']) ? trim($mn['key0']) : NULL); | |
| 1373 | 1150 | $mn['key1'] = trim($mn['key1']); |
| 1374 | 1151 | if (preg_match("\007^((" |
| 1375 | 1152 | .implode(')|(',$this->special_settings) |
| 1376 | 1153 | ."))$\007i", |
| @@ -1380,138 +1157,123 @@ | ||
| 1380 | 1157 | |
| 1381 | 1158 | if (strlen($mn['key0']) > 0) : |
| 1382 | 1159 | unset($this->link->settings[$mn['key0']]); // out with the old |
| 1383 | 1160 | endif; |
| 1384 | - | |
| 1161 | + | |
| 1385 | 1162 | if (($mn['action']=='update') and (strlen($mn['key1']) > 0)) : |
| 1386 | 1163 | $this->link->settings[$mn['key1']] = $mn['value']; // in with the new |
| 1387 | 1164 | endif; |
| 1388 | 1165 | endforeach; |
| 1389 | - | |
| 1166 | + | |
| 1390 | 1167 | // now stuff through the web form |
| 1391 | 1168 | // hardcoded feed info |
| 1392 | - | |
| 1169 | + | |
| 1393 | 1170 | foreach (array('name', 'description', 'url') as $what) : |
| 1394 | 1171 | // We have a checkbox for "No," so if it's unchecked, mark as "Yes." |
| 1395 | - $this->link->settings["hardcode {$what}"] = FeedWordPress::post( "hardcode_{$what}", 'yes' ); | |
| 1172 | + $this->link->settings["hardcode {$what}"] = (isset($post["hardcode_{$what}"]) ? $post["hardcode_{$what}"] : 'yes'); | |
| 1396 | 1173 | if (FeedWordPress::affirmative($this->link->settings, "hardcode {$what}")) : |
| 1397 | - $this->link->link->{'link_'.$what} = FeedWordPress::post( 'link' . $what ); | |
| 1174 | + $this->link->link->{'link_'.$what} = $post['link'.$what]; | |
| 1398 | 1175 | endif; |
| 1399 | 1176 | endforeach; |
| 1400 | - | |
| 1177 | + | |
| 1401 | 1178 | // Update scheduling |
| 1402 | - $update_schedule = FeedWordPress::post( 'update_schedule' ); | |
| 1403 | - if ( ! is_null( $update_schedule ) ) : | |
| 1404 | - $this->link->settings['update/hold'] = $update_schedule; | |
| 1179 | + if (isset($post['update_schedule'])) : | |
| 1180 | + $this->link->settings['update/hold'] = $post['update_schedule']; | |
| 1405 | 1181 | endif; |
| 1406 | 1182 | |
| 1407 | - $use_default_update_window = FeedWordPress::post( 'use_default_update_window' ); | |
| 1408 | - $update_window = FeedWordPress::post( 'update_window' ); | |
| 1409 | - if ( FeedWordPress::affirmative( $use_default_update_window ) ) : | |
| 1183 | + if (isset($post['use_default_update_window']) and strtolower($post['use_default_update_window'])=='yes') : | |
| 1410 | 1184 | unset($this->link->settings['update/window']); |
| 1411 | - elseif ( ! is_null( $update_window ) ) : | |
| 1412 | - $update_window = intval( $update_window ); | |
| 1413 | - if ( $update_window > 0 ) : | |
| 1414 | - $this->link->settings['update/window'] = $update_window; | |
| 1185 | + elseif (isset($post['update_window'])): | |
| 1186 | + if ((int) $post['update_window'] > 0) : | |
| 1187 | + $this->link->settings['update/window'] = (int) $post['update_window']; | |
| 1415 | 1188 | endif; |
| 1416 | 1189 | endif; |
| 1417 | - | |
| 1190 | + | |
| 1418 | 1191 | else : |
| 1419 | 1192 | // Global |
| 1420 | - update_option('feedwordpress_cat_id', FeedWordPress::post( 'syndication_category' ) ); | |
| 1421 | - | |
| 1422 | - $automatic_updates = FeedWordPress::post( 'automatic_updates' ); | |
| 1423 | - if ( ! in_array( $automatic_updates, array( 'init', 'shutdown' ) ) ) : | |
| 1424 | - $automatic_updates = null; | |
| 1193 | + update_option('feedwordpress_cat_id', $post['syndication_category']); | |
| 1194 | + | |
| 1195 | + if (!isset($post['automatic_updates']) or !in_array($post['automatic_updates'], array('init', 'shutdown'))) : | |
| 1196 | + $automatic_updates = NULL; | |
| 1197 | + else : | |
| 1198 | + $automatic_updates = $post['automatic_updates']; | |
| 1425 | 1199 | endif; |
| 1426 | 1200 | update_option('feedwordpress_automatic_updates', $automatic_updates); |
| 1427 | 1201 | |
| 1428 | - $update_window = FeedWordPress::post( 'update_window' ); | |
| 1429 | - if ( ! is_null( $update_window ) ) : | |
| 1430 | - $update_window = intval( $update_window ); | |
| 1431 | - if ( $update_window > 0 ) : | |
| 1432 | - update_option( 'feedwordpress_update_window', $update_window ); | |
| 1202 | + if (isset($post['update_window'])): | |
| 1203 | + if ((int) $post['update_window'] > 0) : | |
| 1204 | + update_option('feedwordpress_update_window', (int) $post['update_window']); | |
| 1433 | 1205 | endif; |
| 1434 | 1206 | endif; |
| 1435 | 1207 | |
| 1436 | - $update_time_limit = FeedWordPress::post( 'update_time_limit' ); | |
| 1437 | - $time_limit_seconds = 0; | |
| 1438 | - if ( FeedWordPress::affirmative( $update_time_limit ) ) : | |
| 1439 | - $time_limit_seconds = intval( FeedWordPress::post( 'time_limit_seconds' ) ); | |
| 1440 | - endif; | |
| 1441 | - update_option( 'feedwordpress_update_time_limit', $time_limit_seconds ); | |
| 1208 | + update_option('feedwordpress_update_time_limit', ($post['update_time_limit']=='yes')?(int) $post['time_limit_seconds']:0); | |
| 1442 | 1209 | |
| 1443 | 1210 | foreach (array('name', 'description', 'url') as $what) : |
| 1444 | 1211 | // We have a checkbox for "No," so if it's unchecked, mark as "Yes." |
| 1445 | - $hardcode = FeedWordPress::post( "hardcode_{$what}", 'yes' ); | |
| 1446 | - update_option( "feedwordpress_hardcode_{$what}", $hardcode ); | |
| 1212 | + $hardcode = (isset($post["hardcode_{$what}"]) ? $post["hardcode_{$what}"] : 'yes'); | |
| 1213 | + update_option("feedwordpress_hardcode_{$what}", $hardcode); | |
| 1447 | 1214 | endforeach; |
| 1448 | - | |
| 1215 | + | |
| 1449 | 1216 | endif; |
| 1450 | - | |
| 1451 | - $update_pause = FeedWordPress::post( 'update_pause' ); | |
| 1452 | - if ( ! is_null( $update_pause ) ) : | |
| 1453 | - $this->update_setting( 'update/pause', $update_pause ); | |
| 1454 | - endif; | |
| 1455 | - | |
| 1456 | - $fetch_timeout = FeedWordPress::post( 'fetch_timeout' ); | |
| 1457 | - if ( ! is_null( $fetch_timeout ) ) : | |
| 1458 | - $fetch_timeout_default = FeedWordPress::post( 'fetch_timeout_default' ); | |
| 1459 | - if ( FeedWordPress::affirmative( $fetch_timeout_default ) ) : | |
| 1460 | - $fetch_timeout = null; | |
| 1217 | + | |
| 1218 | + if (isset($post['fetch_timeout'])) : | |
| 1219 | + if (isset($post['fetch_timeout_default']) and $post['fetch_timeout_default']=='yes') : | |
| 1220 | + $timeout = NULL; | |
| 1221 | + else : | |
| 1222 | + $timeout = $post['fetch_timeout']; | |
| 1461 | 1223 | endif; |
| 1462 | 1224 | |
| 1463 | - if ( is_int( $fetch_timeout ) ) : | |
| 1464 | - $fetch_timeout = intval( $fetch_timeout ); | |
| 1225 | + if (is_int($timeout)) : | |
| 1226 | + $timeout = intval($timeout); | |
| 1465 | 1227 | endif; |
| 1466 | - $this->update_setting( 'fetch timeout', $fetch_timeout ); | |
| 1228 | + $this->update_setting('fetch timeout', $timeout); | |
| 1467 | 1229 | endif; |
| 1468 | - | |
| 1469 | - $update_incremental = FeedWordPress::post( 'update_incremental' ); | |
| 1470 | - if ( ! is_null( $update_incremental ) ) : | |
| 1471 | - $this->update_setting( 'update_incremental', $update_incremental ); | |
| 1230 | + | |
| 1231 | + if (isset($post['update_incremental'])) : | |
| 1232 | + $this->update_setting('update_incremental', $post['update_incremental']); | |
| 1472 | 1233 | endif; |
| 1473 | 1234 | |
| 1474 | - $tombstones = FeedWordPress::post( 'tombstones' ); | |
| 1475 | - if ( ! is_null( $tombstones ) ) : | |
| 1476 | - $this->update_setting('tombstones', $tombstones ); | |
| 1235 | + if (isset($post['tombstones'])) : | |
| 1236 | + $this->update_setting('tombstones', $post['tombstones']); | |
| 1477 | 1237 | endif; |
| 1478 | 1238 | |
| 1479 | - $update_minimum = FeedWordPress::post( 'update_minimum' ); | |
| 1480 | - if ( ! is_null( $update_minimum ) ) : | |
| 1481 | - $this->update_setting( 'update/minimum', $update_minimum ); | |
| 1239 | + if (isset($post['update_minimum'])) : | |
| 1240 | + $this->update_setting('update/minimum', $post['update_minimum']); | |
| 1482 | 1241 | endif; |
| 1483 | 1242 | |
| 1484 | - $link_rss_auth_method = FeedWordPress::post( 'link_rss_auth_method' ); | |
| 1485 | 1243 | if ( |
| 1486 | - ! $link_rss_auth_method | |
| 1487 | - || '-' == $link_rss_auth_method | |
| 1244 | + isset($post['link_rss_auth_method']) | |
| 1245 | + and $post['link_rss_auth_method'] | |
| 1246 | + and ('-' != $post['link_rss_auth_method']) | |
| 1488 | 1247 | ) : |
| 1489 | - $link_rss_auth_method = null; | |
| 1248 | + $this->update_setting('http auth method', $post['link_rss_auth_method']); | |
| 1249 | + else : | |
| 1250 | + $this->update_setting('http auth method', NULL); | |
| 1490 | 1251 | endif; |
| 1491 | - $this->update_setting( 'http auth method', $link_rss_auth_method ); | |
| 1492 | - | |
| 1493 | - $link_rss_username = FeedWordPress::post( 'link_rss_username' ); | |
| 1252 | + | |
| 1494 | 1253 | if ( |
| 1495 | - ! $link_rss_username | |
| 1496 | - || is_null( $link_rss_auth_method ) | |
| 1254 | + isset($post['link_rss_username']) | |
| 1255 | + and (strlen($post['link_rss_username']) > 0) | |
| 1256 | + and ('-' != $post['link_rss_auth_method']) | |
| 1497 | 1257 | ) : |
| 1498 | - $link_rss_username = null; | |
| 1258 | + $this->update_setting('http username', $post['link_rss_username']); | |
| 1259 | + else : | |
| 1260 | + $this->update_setting('http username', NULL); | |
| 1499 | 1261 | endif; |
| 1500 | - $this->update_setting( 'http username', $link_rss_username ); | |
| 1501 | 1262 | |
| 1502 | - $link_rss_password = FeedWordPress::post( 'link_rss_password' ); | |
| 1503 | 1263 | if ( |
| 1504 | - strlen( $link_rss_password ) == 0 | |
| 1505 | - || is_null( $link_rss_auth_method ) | |
| 1264 | + isset($post['link_rss_password']) | |
| 1265 | + and (strlen($post['link_rss_password']) > 0) | |
| 1266 | + and ('-' != $post['link_rss_auth_method']) | |
| 1506 | 1267 | ) : |
| 1507 | - $link_rss_password = null; | |
| 1268 | + $this->update_setting('http password', $post['link_rss_password']); | |
| 1269 | + else : | |
| 1270 | + $this->update_setting('http password', NULL); | |
| 1508 | 1271 | endif; |
| 1509 | - $this->update_setting( 'http password', $link_rss_password ); | |
| 1272 | + | |
| 1273 | + $this->updatedPosts->accept_POST($post); | |
| 1510 | 1274 | |
| 1511 | - $this->updatedPosts->accept_POST(); | |
| 1512 | - | |
| 1513 | - parent::save_settings(); | |
| 1275 | + parent::save_settings($post); | |
| 1514 | 1276 | } /* FeedWordPressFeedsPage::save_settings() */ |
| 1515 | 1277 | |
| 1516 | 1278 | } /* class FeedWordPressFeedsPage */ |
| 1517 | 1279 | |
