← All changes | feedwordpress.php +972 -832 trunk → 2020.0118 View file →

		@@ -1,18 +1,18 @@
1	1	<?php
2	2	/*
3	3	Plugin Name: FeedWordPress
4		-Plugin URI: https://fwpplugin.com/
	4	+Plugin URI: http://feedwordpress.radgeek.com/
5	5	Description: simple and flexible Atom/RSS syndication for WordPress
6		-Version: 2026.0517
	6	+Version: 2020.0118
7	7	Author: C. Johnson
8		-Author URI: https://fwpplugin.com/contact/
	8	+Author URI: https://feedwordpress.radgeek.com/contact/
9	9	License: GPL
10	10	*/
11	11
12	12	/**
13	13	* @package FeedWordPress
14		- * @version 2026.0517
	14	+ * @version 2020.0118
15	15	*/
16	16
17	17	# This plugin uses code derived from:
18	18	# - wp-rss-aggregate.php by Kellan Elliot-McCrea <kellan@protest.net>
		@@ -21,10 +21,9 @@
21	21	# - Ultra-Liberal Feed Finder by Mark Pilgrim <mark@diveintomark.org>
22	22	# - WordPress Blog Tool and Publishing Platform <http://wordpress.org/>
23	23	# - Github contributors @Flynsarmy, @BandonRandon, @david-robinson-practiceweb,
24	24	# @daidais, @thegreatmichael, @stedaniels, @alexiskulash, @quassy, @zoul0813,
25		-# @timmmmyboy, @vobornik, @inanimatt, @tristanleboss, @martinburchell,
26		-# @bigalownz, @oppiansteve, @GwynethLlewelyn, and @glg222
	25	+# @timmmmyboy, @vobornik, and @inanimatt
27	26	# according to the terms of the GNU General Public License.
28	27
29	28	####################################################################################
30	29	## CONSTANTS & DEFAULTS ############################################################
		@@ -29,55 +28,47 @@
29	28	####################################################################################
30	29	## CONSTANTS & DEFAULTS ############################################################
31	30	####################################################################################
32	31
33		-define ('FEEDWORDPRESS_VERSION', '2026.0517');
34		-define ('FEEDWORDPRESS_AUTHOR_CONTACT', 'https://fwpplugin.com/contact' );
	32	+define ('FEEDWORDPRESS_VERSION', '2020.0118');
	33	+define ('FEEDWORDPRESS_AUTHOR_CONTACT', 'http://feedwordpress.radgeek.com/contact');
35	34
36		-if ( ! defined( 'FEEDWORDPRESS_BLEG' ) ) :
37		- define ( 'FEEDWORDPRESS_BLEG', true );
	35	+if (!defined('FEEDWORDPRESS_BLEG')) :
	36	+ define ('FEEDWORDPRESS_BLEG', true);
38	37	endif;
	38	+define('FEEDWORDPRESS_BLEG_BTC', '15EsQ9QMZtLytsaVYZUaUCmrkSMaxZBTso');
	39	+define('FEEDWORDPRESS_BLEG_PAYPAL', '22PAJZZCK5Z3W');
39	40
40		-define( 'FEEDWORDPRESS_BLEG_BTC_pre_2020', '15EsQ9QMZtLytsaVYZUaUCmrkSMaxZBTso' );
41		-define( 'FEEDWORDPRESS_BLEG_BTC_2020', '1NB1ebYVb68Har4WijmE8gKnZ47NptCqtB' ); // 2020.0201
42		-define( 'FEEDWORDPRESS_BLEG_BTC', '1HCDdeGcR66EPxkPT2rbdTd1ezh27pmjPR' ); // 2021.0713
43		-define( 'FEEDWORDPRESS_BLEG_PAYPAL', '22PAJZZCK5Z3W' );
44		-
45	41	// Defaults
46		-define( 'DEFAULT_SYNDICATION_CATEGORY', 'Contributors' );
47		-define( 'DEFAULT_UPDATE_PERIOD', 60 ); // value in minutes
48		-define( 'FEEDWORDPRESS_DEFAULT_CHECKIN_INTERVAL', DEFAULT_UPDATE_PERIOD / 10 );
	42	+define ('DEFAULT_SYNDICATION_CATEGORY', 'Contributors');
	43	+define ('DEFAULT_UPDATE_PERIOD', 60); // value in minutes
	44	+define ('FEEDWORDPRESS_DEFAULT_CHECKIN_INTERVAL', DEFAULT_UPDATE_PERIOD/10);
49	45
50		-// Dependencies: modules packaged with FeedWordPress plugin.
51		-/** @var string Path to parent directory */
52		-$dir = dirname( __FILE__ );
53		-require_once "{$dir}/externals/myphp/myphp.class.php";
54		-
55		-/** @var bool|string Set to either true or 'yes' if debugging is set. */
56		-$feedwordpress_debug = FeedWordPress::param( 'feedwordpress_debug', get_option( 'feedwordpress_debug' ) );
57		-
58		-if ( is_string( $feedwordpress_debug ) ) :
59		- $feedwordpress_debug = ( $feedwordpress_debug == 'yes' );
	46	+if (isset($_REQUEST['feedwordpress_debug'])) :
	47	+ $feedwordpress_debug = $_REQUEST['feedwordpress_debug'];
	48	+else :
	49	+ $feedwordpress_debug = get_option('feedwordpress_debug');
	50	+ if (is_string($feedwordpress_debug)) :
	51	+ $feedwordpress_debug = ($feedwordpress_debug == 'yes');
	52	+ endif;
60	53	endif;
61		-
62		-define ( 'FEEDWORDPRESS_DEBUG', $feedwordpress_debug );
	54	+define ('FEEDWORDPRESS_DEBUG', $feedwordpress_debug);
63	55	$feedwordpress_compatibility = true;
64		-define ( 'FEEDWORDPRESS_COMPATIBILITY', $feedwordpress_compatibility );
	56	+define ('FEEDWORDPRESS_COMPATIBILITY', $feedwordpress_compatibility);
65	57
66		-define ( 'FEEDWORDPRESS_CAT_SEPARATOR_PATTERN', '/[:\n]/' );
67		-define ( 'FEEDWORDPRESS_CAT_SEPARATOR', "\n" );
	58	+define ('FEEDWORDPRESS_CAT_SEPARATOR_PATTERN', '/[:\n]/');
	59	+define ('FEEDWORDPRESS_CAT_SEPARATOR', "\n");
68	60
69		-// define ('FEEDVALIDATOR_URI', 'http://feedvalidator.org/check.cgi'); // Link dead (gwyneth 20210617)
70		-define ( 'FEEDVALIDATOR_URI', 'https://validator.w3.org/feed/check.cgi' ); // Falling back to the W3C validator link
	61	+define ('FEEDVALIDATOR_URI', 'http://feedvalidator.org/check.cgi');
71	62
72		-define ( 'FEEDWORDPRESS_FRESHNESS_INTERVAL', 10 * 60 ); // Every ten minutes
	63	+define ('FEEDWORDPRESS_FRESHNESS_INTERVAL', 10*60); // Every ten minutes
73	64
74		-define( 'FEEDWORDPRESS_BOILERPLATE_DEFAULT_HOOK_ORDER', 11000 ); // at the tail end of the filtering process
	65	+define('FEEDWORDPRESS_BOILERPLATE_DEFAULT_HOOK_ORDER', 11000); // at the tail end of the filtering process
75	66
76		-if ( FEEDWORDPRESS_DEBUG ) :
	67	+if (FEEDWORDPRESS_DEBUG) :
77	68	// Help us to pick out errors, if any.
78		- ini_set( 'error_reporting', E_ALL & ~E_NOTICE );
79		- ini_set( 'display_errors', true );
	69	+ ini_set('error_reporting', E_ALL & ~E_NOTICE);
	70	+ ini_set('display_errors', true);
80	71
81	72	// When testing we don't want cache issues to interfere. But this is
82	73	// a VERY BAD SETTING for a production server. Webmasters will eat your
83	74	// face for breakfast if you use it, and the baby Jesus will cry. So
		@@ -82,17 +73,17 @@
82	73	// a VERY BAD SETTING for a production server. Webmasters will eat your
83	74	// face for breakfast if you use it, and the baby Jesus will cry. So
84	75	// make sure FEEDWORDPRESS_DEBUG is FALSE for any site that will be
85	76	// used for more than testing purposes!
86		- define( 'FEEDWORDPRESS_CACHE_AGE', 1 );
87		- define( 'FEEDWORDPRESS_CACHE_LIFETIME', 1 );
88		- define( 'FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT', 60 );
	77	+ define('FEEDWORDPRESS_CACHE_AGE', 1);
	78	+ define('FEEDWORDPRESS_CACHE_LIFETIME', 1);
	79	+ define('FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT', 60);
89	80	else :
90	81	// Hold onto data all day for conditional GET purposes,
91	82	// but consider it stale after 1 min (requiring a conditional GET)
92		- define( 'FEEDWORDPRESS_CACHE_LIFETIME', 24 * 60 * 60 ); // aka one day.
93		- define( 'FEEDWORDPRESS_CACHE_AGE', 1 * 60 );
94		- define( 'FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT', 20 );
	83	+ define('FEEDWORDPRESS_CACHE_LIFETIME', 24*60*60);
	84	+ define('FEEDWORDPRESS_CACHE_AGE', 1*60);
	85	+ define('FEEDWORDPRESS_FETCH_TIMEOUT_DEFAULT', 20);
95	86	endif;
96	87
97	88	####################################################################################
98	89	## CORE DEPENDENCIES & PLUGIN MODULES ##############################################
		@@ -97,27 +88,29 @@
97	88	####################################################################################
98	89	## CORE DEPENDENCIES & PLUGIN MODULES ##############################################
99	90	####################################################################################
100	91
101		-/** @var array<string> Dependencies: modules packaged with WordPress core */
	92	+// Dependencies: modules packaged with WordPress core
102	93	$wpCoreDependencies = array(
103		- "class:SimplePie" => "class-simplepie",
104		- "class:WP_SimplePie_File" => "class-wp-simplepie-file",
105		- "class:WP_SimplePie_Sanitize_KSES" => "class-wp-simplepie-sanitize-kses",
106		- "function:wp_insert_user" => "registration",
	94	+"class:SimplePie" => "class-simplepie",
	95	+"class:WP_Feed_Cache" => "class-wp-feed-cache",
	96	+"class:WP_Feed_Cache_Transient" => "class-wp-feed-cache-transient",
	97	+"class:WP_SimplePie_File" => "class-wp-simplepie-file",
	98	+"class:WP_SimplePie_Sanitize_KSES" => "class-wp-simplepie-sanitize-kses",
	99	+"function:wp_insert_user" => "registration",
107	100	);
108	101
109	102	// Ensure that we have SimplePie loaded up and ready to go
110	103	// along with the WordPress auxiliary classes.
111	104	$unmetCoreDependencies = array();
112		-foreach ( $wpCoreDependencies as $unit => $fileSlug ) :
113		- list( $unitType, $unitName ) = explode( ":", $unit, 2 );
114		-
115		- $dependencyMet = ( ('class' == $unitType ) ? class_exists( $unitName ) : function_exists( $unitName ) );
116		- if ( ! $dependencyMet ) :
117		- $phpFileName = ABSPATH . WPINC . "/{$fileSlug}.php";
118		- if ( file_exists( $phpFileName ) ) :
119		- require_once $phpFileName;
	105	+foreach ($wpCoreDependencies as $unit => $fileSlug) :
	106	+ list($unitType, $unitName) = explode(":", $unit, 2);
	107	+
	108	+ $dependencyMet = (('class'==$unitType) ? class_exists($unitName) : function_exists($unitName));
	109	+ if (!$dependencyMet) :
	110	+ $phpFileName = ABSPATH . WPINC . "/${fileSlug}.php";
	111	+ if (file_exists($phpFileName)) :
	112	+ require_once($phpFileName);
120	113	else :
121	114	$unmetCoreDependencies[] = $unitName;
122	115	endif;
123	116	endif;
		@@ -123,48 +116,61 @@
123	116	endif;
124	117	endforeach;
125	118
126	119	// Fallback garbage-pail module used in WP < 4.7 which may meet our dependencies
127		-if ( count( $unmetCoreDependencies ) > 0 ) :
128		- require_once ABSPATH . WPINC . "/class-feed.php";
	120	+if (count($unmetCoreDependencies) > 0) :
	121	+ require_once(ABSPATH . WPINC . "/class-feed.php");
129	122	endif;
130	123
131		-// Dependencies: modules packaged with FeedWordPress plugin
132		-$dir = dirname( __FILE__ );
133		-require_once "{$dir}/feedwordpressadminpage.class.php";
134		-require_once "{$dir}/feedwordpresssettingsui.class.php";
135		-require_once "{$dir}/feedwordpressdiagnostic.class.php";
136		-require_once "{$dir}/admin-ui.php";
137		-require_once "{$dir}/template-functions.php";
138		-require_once "{$dir}/feedwordpresssyndicationpage.class.php";
139		-require_once "{$dir}/compatability.php"; // Legacy API
140		-require_once "{$dir}/syndicatedpost.class.php";
141		-require_once "{$dir}/syndicatedlink.class.php";
142		-require_once "{$dir}/feedwordpresshtml.class.php";
143		-require_once "{$dir}/inspectpostmeta.class.php";
144		-require_once "{$dir}/syndicationdataqueries.class.php";
145		-require_once "{$dir}/extend/SimplePie/feedwordpie.class.php";
146		-require_once "{$dir}/extend/SimplePie/feedwordpie_cache.class.php";
147		-require_once "{$dir}/extend/SimplePie/feedwordpie_item.class.php";
148		-require_once "{$dir}/extend/SimplePie/feedwordpie_file.class.php";
149		-require_once "{$dir}/extend/SimplePie/feedwordpie_parser.class.php";
150		-require_once "{$dir}/extend/SimplePie/feedwordpie_content_type_sniffer.class.php";
151		-require_once "{$dir}/feedwordpressrpc.class.php";
152		-require_once "{$dir}/feedwordpresshttpauthenticator.class.php";
153		-require_once "{$dir}/feedwordpresslocalpost.class.php";
	124	+// Dependences: modules packaged with FeedWordPress plugin
	125	+$dir = dirname(__FILE__);
	126	+require_once("${dir}/externals/myphp/myphp.class.php");
	127	+require_once("${dir}/feedwordpressadminpage.class.php");
	128	+require_once("${dir}/feedwordpresssettingsui.class.php");
	129	+require_once("${dir}/feedwordpressdiagnostic.class.php");
	130	+require_once("${dir}/admin-ui.php");
	131	+require_once("${dir}/template-functions.php");
	132	+require_once("${dir}/feedwordpresssyndicationpage.class.php");
	133	+require_once("${dir}/compatability.php"); // Legacy API
	134	+require_once("${dir}/syndicatedpost.class.php");
	135	+require_once("${dir}/syndicatedlink.class.php");
	136	+require_once("${dir}/feedwordpresshtml.class.php");
	137	+require_once("${dir}/feedwordpress-content-type-sniffer.class.php");
	138	+require_once("${dir}/inspectpostmeta.class.php");
	139	+require_once("${dir}/syndicationdataqueries.class.php");
	140	+require_once("${dir}/feedwordpie.class.php");
	141	+require_once("${dir}/feedwordpie_item.class.php");
	142	+require_once("${dir}/feedwordpress_file.class.php");
	143	+require_once("${dir}/feedwordpress_parser.class.php");
	144	+require_once("${dir}/feedwordpressrpc.class.php");
	145	+require_once("${dir}/feedwordpresshttpauthenticator.class.php");
	146	+require_once("${dir}/feedwordpresslocalpost.class.php");
154	147
155	148	####################################################################################
156	149	## GLOBAL PARAMETERS ###############################################################
157	150	####################################################################################
158	151
	152	+// $fwp_post used to be a global variable used to make it easier to cope
	153	+// with the frustrating sometime presence of "Magic Quotes" in earlier
	154	+// versions of PHP (<http://php.net/manual/en/security.magicquotes.php>).
	155	+// Magic quotes were DEPRECATED as of PHP 5.3.0, and REMOVED as of PHP
	156	+// 5.4.0, so for the time being $fwp_post just gets a copy of $_POST.
	157	+global $fwp_post;
	158	+
	159	+if (is_array($_POST)) :
	160	+ $fwp_post = $_POST;
	161	+else:
	162	+ $fwp_post = null;
	163	+endif;
	164	+
159	165	// Get the path relative to the plugins directory in which FWP is stored
160	166	preg_match (
161		- '|'.preg_quote( WP_PLUGIN_DIR ) . '/(.+)$|',
162		- dirname( __FILE__ ),
	167	+ '|'.preg_quote(WP_PLUGIN_DIR).'/(.+)$|',
	168	+ dirname(__FILE__),
163	169	$ref
164	170	);
165	171
166		-if ( isset( $ref[1] ) ) :
	172	+if (isset($ref[1])) :
167	173	$fwp_path = $ref[1];
168	174	else : // Something went wrong. Let's just guess.
169	175	$fwp_path = 'feedwordpress';
170	176	endif;
		@@ -173,38 +179,133 @@
173	179	## FEEDWORDPRESS: INITIALIZE OBJECT AND FILTERS ####################################
174	180	####################################################################################
175	181
176	182	$feedwordpress = new FeedWordPress;
177		-if ( ! $feedwordpress->needs_upgrade() ) : // only work if the conditions are safe!
178		- $feedwordpress->add_filters();
	183	+if (!$feedwordpress->needs_upgrade()) : // only work if the conditions are safe!
179	184
	185	+ # Syndicated items are generally received in output-ready (X)HTML and
	186	+ # should not be folded, crumpled, mutilated, or spindled by WordPress
	187	+ # formatting filters. But we don't want to interfere with filters for
	188	+ # any locally-authored posts, either.
	189	+ #
	190	+ # What WordPress should really have is a way for upstream filters to
	191	+ # stop downstream filters from running at all. Since it doesn't, and
	192	+ # since a downstream filter can't access the original copy of the text
	193	+ # that is being filtered, what we will do here is (1) save a copy of the
	194	+ # original text upstream, before any other filters run, and then (2)
	195	+ # retrieve that copy downstream, after all the other filters run, *if*
	196	+ # this is a syndicated post
	197	+
	198	+ add_filter('the_content', 'feedwordpress_preserve_syndicated_content', -10000);
	199	+ add_filter('the_content', 'feedwordpress_restore_syndicated_content', 10000);
	200	+
	201	+ add_action('atom_entry', 'feedwordpress_item_feed_data');
	202	+
	203	+ # Filter in original permalinks if the user wants that
	204	+ add_filter('post_link', 'syndication_permalink', /*priority=*/ 1, /*arguments=*/ 3);
	205	+ add_filter('post_type_link', 'syndication_permalink', /*priority=*/ 1, /*arguments=*/ 4);
	206	+
	207	+ # When foreign URLs are used for permalinks in feeds or display
	208	+ # contexts, they need to be escaped properly.
	209	+ add_filter('the_permalink', 'syndication_permalink_escaped');
	210	+ add_filter('the_permalink_rss', 'syndication_permalink_escaped');
	211	+
	212	+ add_filter('post_comments_feed_link', 'syndication_comments_feed_link');
	213	+
	214	+ # WTF? By default, wp_insert_link runs incoming link_url and link_rss
	215	+ # URIs through default filters that include `wp_kses()`. But `wp_kses()`
	216	+ # just happens to escape any occurrence of & to &amp; -- which just
	217	+ # happens to fuck up any URI with a & to separate GET parameters.
	218	+ remove_filter('pre_link_rss', 'wp_filter_kses');
	219	+ remove_filter('pre_link_url', 'wp_filter_kses');
	220	+
	221	+ # Boilerplate functionality: hook in to title, excerpt, and content to add boilerplate text
	222	+ $hookOrder = get_option('feedwordpress_boilerplate_hook_order', FEEDWORDPRESS_BOILERPLATE_DEFAULT_HOOK_ORDER);
	223	+ add_filter(
	224	+ /*hook=*/ 'the_title',
	225	+ /*function=*/ 'add_boilerplate_title',
	226	+ /*priority=*/ $hookOrder,
	227	+ /*arguments=*/ 2
	228	+ );
	229	+ add_filter(
	230	+ /*hook=*/ 'get_the_excerpt',
	231	+ /*function=*/ 'add_boilerplate_excerpt',
	232	+ /*priority=*/ $hookOrder,
	233	+ /*arguments=*/ 1
	234	+ );
	235	+ add_filter(
	236	+ /*hook=*/ 'the_content',
	237	+ /*function=*/ 'add_boilerplate_content',
	238	+ /*priority=*/ $hookOrder,
	239	+ /*arguments=*/ 1
	240	+ );
	241	+ add_filter(
	242	+ /*hook=*/ 'the_content_rss',
	243	+ /*function=*/ 'add_boilerplate_content',
	244	+ /*priority=*/ $hookOrder,
	245	+ /*arguments=*/ 1
	246	+ );
	247	+
	248	+ # Admin menu
	249	+ add_action('admin_init', array($feedwordpress, 'admin_init'));
	250	+ add_action('admin_menu', 'fwp_add_pages');
	251	+ add_action('admin_notices', 'fwp_check_debug');
	252	+
	253	+ add_action('admin_menu', 'feedwordpress_add_post_edit_controls');
	254	+ add_action('save_post', 'feedwordpress_save_post_edit_controls');
	255	+
	256	+ add_action('admin_footer', array($feedwordpress, 'admin_footer'));
	257	+
180	258	# Inbound XML-RPC update methods
181	259	$feedwordpressRPC = new FeedWordPressRPC;
182	260
183	261	# Outbound XML-RPC ping reform
184		- remove_action( 'publish_post', 'generic_ping' ); // WP 1.5.x
185		- remove_action( 'do_pings', 'do_all_pings', 10, 1 ); // WP 2.1, 2.2
186		- remove_action( 'publish_post', '_publish_post_hook', 5, 1 ); // WP 2.3
	262	+ remove_action('publish_post', 'generic_ping'); // WP 1.5.x
	263	+ remove_action('do_pings', 'do_all_pings', 10, 1); // WP 2.1, 2.2
	264	+ remove_action('publish_post', '_publish_post_hook', 5, 1); // WP 2.3
187	265
188		- add_action( 'publish_post', 'fwp_publish_post_hook', 5, 1 );
189		- add_action( 'do_pings', 'fwp_do_pings', 10, 1 );
190		- add_action( 'feedwordpress_update', 'fwp_hold_pings' );
191		- add_action( 'feedwordpress_update_complete', 'fwp_release_pings' );
	266	+ add_action('publish_post', 'fwp_publish_post_hook', 5, 1);
	267	+ add_action('do_pings', 'fwp_do_pings', 10, 1);
	268	+ add_action('feedwordpress_update', 'fwp_hold_pings');
	269	+ add_action('feedwordpress_update_complete', 'fwp_release_pings');
192	270
	271	+ add_action('syndicated_feed_error', array('FeedWordPressDiagnostic', 'feed_error'), 100, 3);
	272	+
	273	+ add_action('wp_footer', 'debug_out_feedwordpress_footer', -100);
	274	+ add_action('admin_footer', 'debug_out_feedwordpress_footer', -100);
	275	+
	276	+ # Cron-less auto-update. Hooray!
	277	+ $autoUpdateHook = $feedwordpress->automatic_update_hook();
	278	+ if (!is_null($autoUpdateHook)) :
	279	+ add_action($autoUpdateHook, array($feedwordpress, 'auto_update'));
	280	+ endif;
	281	+
	282	+ add_action('init', array($feedwordpress, 'init'));
	283	+ add_action('wp_loaded', array($feedwordpress, 'wp_loaded'));
	284	+
	285	+ add_action('shutdown', array($feedwordpress, 'email_diagnostic_log'));
	286	+ add_action('shutdown', array($feedwordpress, 'feedwordpress_cleanup'));
	287	+ add_action('wp_dashboard_setup', array($feedwordpress, 'dashboard_setup'));
	288	+
	289	+ # Default sanitizers
	290	+ add_filter('syndicated_item_content', array('SyndicatedPost', 'resolve_relative_uris'), 0, 2);
	291	+ add_filter('syndicated_item_content', array('SyndicatedPost', 'sanitize_content'), 0, 2);
	292	+
	293	+ add_action('plugins_loaded', array($feedwordpress, 'admin_api'));
	294	+ add_action('all_admin_notices', array($feedwordpress, 'all_admin_notices'));
	295	+
	296	+ // Use our the cache settings that we want.
	297	+ add_filter('wp_feed_cache_transient_lifetime', array('FeedWordPress', 'cache_lifetime'));
	298	+
	299	+
193	300	else :
194	301	# Hook in the menus, which will just point to the upgrade interface
195		- add_action( 'admin_menu', array( $feedwordpress, 'add_pages' ) );
196		-endif; // if ( !FeedWordPress::needs_upgrade())
	302	+ add_action('admin_menu', 'fwp_add_pages');
	303	+endif; // if (!FeedWordPress::needs_upgrade())
197	304
198		-register_deactivation_hook( __FILE__, 'feedwordpress_deactivate' );
199		-
200		-/**
201		- * Hook to deactivate FeedWordPress.
202		- *
203		- * @return int|false @see wp_clear_scheduled_hook()
204		- */
205		-function feedwordpress_deactivate() {
206		- wp_clear_scheduled_hook( 'fwp_scheduled_update_checkin' );
	305	+register_deactivation_hook(__FILE__, 'feedwordpress_deactivate');
	306	+function feedwordpress_deactivate () {
	307	+ wp_clear_scheduled_hook('fwp_scheduled_update_checkin');
207	308	} /* feedwordpress_deactivate () */
208	309
209	310	################################################################################
210	311	## LOGGING FUNCTIONS: log status updates to error_log if you want it ###########
		@@ -209,39 +310,26 @@
209	310	################################################################################
210	311	## LOGGING FUNCTIONS: log status updates to error_log if you want it ###########
211	312	################################################################################
212	313
213		-/**
214		- * Divides bytes into units of higher magnitude (e.g KB, MB, etc).
215		- *
216		- * @param int|string $quantity Quantity in bytes to be displayed. Can be a string that only includes numeric digits.
217		- *
218		- * @return string Formatted string with quantity and unit.
219		- *
220		- * @deprecated use the WordPress built-in `size_format()` function instead! (gwyneth 20230918)
221		- */
222		-function debug_out_human_readable_bytes( $quantity ) {
223		- if ( ! is_numeric( $quantity ) ) :
224		- return __( "(wrong quantity)" );
225		- endif;
226		- $quantity = intval( $quantity );
	314	+function debug_out_human_readable_bytes ($quantity) {
	315	+ $quantity = (int) $quantity;
227	316	$magnitude = 'B';
228		- /** @var array Two-letter abbreviations of the units in increasing magnitude. */
229		- $orders = array( 'KB', 'MB', 'GB', 'TB' );
230		- while ( ( $quantity > ( 1024 * 100 ) ) and ( count( $orders ) > 0 ) ) :
231		- $quantity = floor( $quantity / 1024 );
232		- $magnitude = array_shift( $orders );
	317	+ $orders = array('KB', 'MB', 'GB', 'TB');
	318	+ while (($quantity > (1024*100)) and (count($orders) > 0)) :
	319	+ $quantity = floor($quantity / 1024);
	320	+ $magnitude = array_shift($orders);
233	321	endwhile;
234		- return "{$quantity} {$magnitude}";
	322	+ return "${quantity} ${magnitude}";
235	323	}
236	324
237		-function debug_out_feedwordpress_footer() {
238		- if ( FeedWordPressDiagnostic::is_on('memory_usage') ) :
239		- if ( function_exists('memory_get_usage') ) :
240		- FeedWordPress::diagnostic( 'memory_usage', "Memory: Current usage: " . size_format( memory_get_usage() ) );
	325	+function debug_out_feedwordpress_footer () {
	326	+ if (FeedWordPressDiagnostic::is_on('memory_usage')) :
	327	+ if (function_exists('memory_get_usage')) :
	328	+ FeedWordPress::diagnostic ('memory_usage', "Memory: Current usage: ".debug_out_human_readable_bytes(memory_get_usage()));
241	329	endif;
242		- if ( function_exists('memory_get_peak_usage') ) :
243		- FeedWordPress::diagnostic('memory_usage', "Memory: Peak usage: " . size_format( memory_get_peak_usage() ) );
	330	+ if (function_exists('memory_get_peak_usage')) :
	331	+ FeedWordPress::diagnostic ('memory_usage', "Memory: Peak usage: ".debug_out_human_readable_bytes(memory_get_peak_usage()));
244	332	endif;
245	333	endif;
246	334	} /* debug_out_feedwordpress_footer() */
247	335
		@@ -248,19 +336,19 @@
248	336	################################################################################
249	337	## FILTERS: syndication-aware handling of post data for templates and feeds ####
250	338	################################################################################
251	339
252		-$feedwordpress_the_syndicated_content = null;
253		-$feedwordpress_the_original_permalink = null;
	340	+$feedwordpress_the_syndicated_content = NULL;
	341	+$feedwordpress_the_original_permalink = NULL;
254	342
255	343	function feedwordpress_preserve_syndicated_content ($text) {
256	344	global $feedwordpress_the_syndicated_content;
257	345
258	346	$p = new FeedWordPressLocalPost;
259		- if ( ! $p->is_exposed_to_formatting_filters()) :
	347	+ if (!$p->is_exposed_to_formatting_filters()) :
260	348	$feedwordpress_the_syndicated_content = $text;
261	349	else :
262		- $feedwordpress_the_syndicated_content = null;
	350	+ $feedwordpress_the_syndicated_content = NULL;
263	351	endif;
264	352	return $text;
265	353	}
266	354
		@@ -278,21 +366,21 @@
278	366	// In a post context....
279	367	if (is_syndicated()) :
280	368	?>
281	369	<source>
282		- <title><?php print esc_html( get_syndication_source() ); ?></title>
283		- <link rel="alternate" type="text/html" href="<?php print esc_url( get_syndication_source_link() ); ?>" />
284		- <link rel="self" href="<?php print esc_url( get_syndication_feed() ); ?>" />
	370	+ <title><?php print htmlspecialchars(get_syndication_source()); ?></title>
	371	+ <link rel="alternate" type="text/html" href="<?php print htmlspecialchars(get_syndication_source_link()); ?>" />
	372	+ <link rel="self" href="<?php print htmlspecialchars(get_syndication_feed()); ?>" />
285	373	<?php
286	374	$id = get_syndication_feed_guid();
287		- if ( strlen( $id ) > 0 ) :
	375	+ if (strlen($id) > 0) :
288	376	?>
289		- <id><?php print esc_xml( $id ); ?></id>
	377	+ <id><?php print htmlspecialchars($id); ?></id>
290	378	<?php
291	379	endif;
292	380	$updated = get_feed_meta('feed/updated');
293		- if ( strlen( $updated ) > 0 ) : ?>
294		- <updated><?php print esc_xml( $updated ); ?></updated>
	381	+ if (strlen($updated) > 0) : ?>
	382	+ <updated><?php print $updated; ?></updated>
295	383	<?php
296	384	endif;
297	385	?>
298	386	</source>
		@@ -306,11 +394,8 @@
306	394	* Syndication => Posts & Links. Saves the old internal permalink in a global
307	395	* variable for later use.
308	396	*
309	397	* @param string $permalink The internal permalink
310		- * @param mixed|null $post Post object
311		- * @param bool $leavename Unused
312		- * @param bool $sample Unused
313	398	* @return string The new permalink. Same as the old if the post is not
314	399	* syndicated, or if FWP is set to use internal permalinks, or if the post
315	400	* was syndicated, but didn't have a proper permalink recorded.
316	401	*
		@@ -320,9 +405,9 @@
320	405	* @uses url_to_postid()
321	406	* @global $id
322	407	* @global $feedwordpress_the_original_permalink
323	408	*/
324		-function syndication_permalink($permalink = '', $post = null, $leavename = false, $sample = false ) {
	409	+function syndication_permalink ($permalink = '', $post = null, $leavename = false, $sample = false) {
325	410	global $id;
326	411	global $feedwordpress_the_original_permalink;
327	412
328	413	// Save the local permalink in case we need to retrieve it later.
		@@ -386,9 +471,9 @@
386	471	* @uses is_syndicated()
387	472	* @uses FeedWordPress::munge_permalinks()
388	473	*/
389	474	function syndication_comments_feed_link ($link) {
390		- global $feedwordpress_the_original_permalink;
	475	+ global $feedwordpress_the_original_permalink, $id;
391	476
392	477	if (is_syndicated() and FeedWordPress::munge_permalinks()) :
393	478	// If the source post provided a comment feed URL using
394	479	// wfw:commentRss or atom:link/@rel="replies" we can make use of
		@@ -393,9 +478,9 @@
393	478	// If the source post provided a comment feed URL using
394	479	// wfw:commentRss or atom:link/@rel="replies" we can make use of
395	480	// that value here.
396	481	$source = get_syndication_feed_object();
397		- $replacement = null;
	482	+ $replacement = NULL;
398	483
399	484	if (is_object($source) && $source->setting('munge comments feed links', 'munge_comments_feed_links', 'yes') != 'no') :
400	485	$commentFeeds = get_post_custom_values('wfw:commentRSS');
401	486	if (
		@@ -435,24 +520,441 @@
435	520	// comments feed link is never munged by FWP.
436	521	endif;
437	522	endif;
438	523
439		- if ( !is_null($replacement)) : $link = $replacement; endif;
	524	+ if (!is_null($replacement)) : $link = $replacement; endif;
440	525	endif;
441	526	return $link;
442	527	} /* function syndication_comments_feed_link() */
443	528
444		- require_once("{$dir}/feedwordpress.pings.functions.php");
	529	+################################################################################
	530	+## ADMIN MENU ADD-ONS: register Dashboard management pages #####################
	531	+################################################################################
445	532
446		- require_once("{$dir}/feedwordpress.wp-admin.post-edit.functions.php");
	533	+function fwp_add_pages () {
	534	+ global $feedwordpress;
447	535
	536	+ $menu_cap = FeedWordPress::menu_cap();
	537	+ $settings_cap = FeedWordPress::menu_cap(/*sub=*/ true);
	538	+ $syndicationMenu = FeedWordPress::path('syndication.php');
	539	+
	540	+ add_menu_page(
	541	+ 'Syndicated Sites', 'Syndication',
	542	+ $menu_cap,
	543	+ $syndicationMenu,
	544	+ NULL,
	545	+ plugins_url( '/'.FeedWordPress::path('feedwordpress-tiny.png') )
	546	+ );
	547	+
	548	+ do_action('feedwordpress_admin_menu_pre_feeds', $menu_cap, $settings_cap);
	549	+ add_submenu_page(
	550	+ $syndicationMenu, 'Syndicated Sites', 'Syndicated Sites',
	551	+ $settings_cap, $syndicationMenu
	552	+ );
	553	+
	554	+ do_action('feedwordpress_admin_menu_pre_feeds', $menu_cap, $settings_cap);
	555	+ add_submenu_page(
	556	+ $syndicationMenu, 'Syndicated Feeds & Updates', 'Feeds & Updates',
	557	+ $settings_cap, FeedWordPress::path('feeds-page.php')
	558	+ );
	559	+
	560	+ do_action('feedwordpress_admin_menu_pre_posts', $menu_cap, $settings_cap);
	561	+ add_submenu_page(
	562	+ $syndicationMenu, 'Syndicated Posts & Links', 'Posts & Links',
	563	+ $settings_cap, FeedWordPress::path('posts-page.php')
	564	+ );
	565	+
	566	+ do_action('feedwordpress_admin_menu_pre_authors', $menu_cap, $settings_cap);
	567	+ add_submenu_page(
	568	+ $syndicationMenu, 'Syndicated Authors', 'Authors',
	569	+ $settings_cap, FeedWordPress::path('authors-page.php')
	570	+ );
	571	+
	572	+ do_action('feedwordpress_admin_menu_pre_categories', $menu_cap, $settings_cap);
	573	+ add_submenu_page(
	574	+ $syndicationMenu, 'Categories & Tags', 'Categories & Tags',
	575	+ $settings_cap, FeedWordPress::path('categories-page.php')
	576	+ );
	577	+
	578	+ do_action('feedwordpress_admin_menu_pre_performance', $menu_cap, $settings_cap);
	579	+ add_submenu_page(
	580	+ $syndicationMenu, 'FeedWordPress Performance', 'Performance',
	581	+ $settings_cap, FeedWordPress::path('performance-page.php')
	582	+ );
	583	+
	584	+ do_action('feedwordpress_admin_menu_pre_diagnostics', $menu_cap, $settings_cap);
	585	+ add_submenu_page(
	586	+ $syndicationMenu, 'FeedWordPress Diagnostics', 'Diagnostics',
	587	+ $settings_cap, FeedWordPress::path('diagnostics-page.php')
	588	+ );
	589	+
	590	+ add_filter('page_row_actions', array($feedwordpress, 'row_actions'), 10, 2);
	591	+ add_filter('post_row_actions', array($feedwordpress, 'row_actions'), 10, 2);
	592	+} /* function fwp_add_pages () */
	593	+
	594	+function fwp_check_debug () {
	595	+ // This is a horrible fucking kludge that I have to do because the
	596	+ // admin notice code is triggered before the code that updates the
	597	+ // setting.
	598	+ if (isset($_POST['feedwordpress_debug'])) :
	599	+ $feedwordpress_debug = $_POST['feedwordpress_debug'];
	600	+ else :
	601	+ $feedwordpress_debug = get_option('feedwordpress_debug');
	602	+ endif;
	603	+ if ($feedwordpress_debug==='yes') :
	604	+?>
	605	+ <div class="error">
	606	+<p><strong>FeedWordPress warning.</strong> Debugging mode is <strong>ON</strong>.
	607	+While it remains on, FeedWordPress displays many diagnostic error messages,
	608	+warnings, and notices that are ordinarily suppressed, and also turns off all
	609	+caching of feeds. Use with caution: this setting is absolutely inappropriate
	610	+for a production server.</p>
	611	+ </div>
	612	+<?php
	613	+ endif;
	614	+} /* function fwp_check_debug () */
	615	+
448	616	################################################################################
	617	+## fwp_hold_pings() and fwp_release_pings(): Outbound XML-RPC ping reform ####
	618	+## ... 'coz it's rude to send 500 pings the first time your aggregator runs ####
	619	+################################################################################
	620	+
	621	+$fwp_held_ping = NULL; // NULL: not holding pings yet
	622	+
	623	+function fwp_hold_pings () {
	624	+ global $fwp_held_ping;
	625	+ if (is_null($fwp_held_ping)):
	626	+ $fwp_held_ping = 0; // 0: ready to hold pings; none yet received
	627	+ endif;
	628	+}
	629	+
	630	+function fwp_release_pings () {
	631	+ global $fwp_held_ping;
	632	+ if ($fwp_held_ping):
	633	+ if (function_exists('wp_schedule_single_event')) :
	634	+ wp_schedule_single_event(time(), 'do_pings');
	635	+ else :
	636	+ generic_ping($fwp_held_ping);
	637	+ endif;
	638	+ endif;
	639	+ $fwp_held_ping = NULL; // NULL: not holding pings anymore
	640	+}
	641	+
	642	+function fwp_do_pings () {
	643	+ if (!is_null($fwp_held_ping) and $post_id) : // Defer until we're done updating
	644	+ $fwp_held_ping = $post_id;
	645	+ elseif (function_exists('do_all_pings')) :
	646	+ do_all_pings();
	647	+ else :
	648	+ generic_ping($fwp_held_ping);
	649	+ endif;
	650	+}
	651	+
	652	+function fwp_publish_post_hook ($post_id) {
	653	+ global $fwp_held_ping;
	654	+
	655	+ if (!is_null($fwp_held_ping)) : // Syndicated post. Don't mark with _pingme
	656	+ if ( defined('XMLRPC_REQUEST') )
	657	+ do_action('xmlrpc_publish_post', $post_id);
	658	+ if ( defined('APP_REQUEST') )
	659	+ do_action('app_publish_post', $post_id);
	660	+
	661	+ if ( defined('WP_IMPORTING') )
	662	+ return;
	663	+
	664	+ // Defer sending out pings until we finish updating
	665	+ $fwp_held_ping = $post_id;
	666	+ else :
	667	+ if (function_exists('_publish_post_hook')) : // WordPress 2.3
	668	+ _publish_post_hook($post_id);
	669	+ endif;
	670	+ endif;
	671	+}
	672	+
	673	+ function feedwordpress_add_post_edit_controls () {
	674	+ global $feedwordpress;
	675	+ global $inspectPostMeta;
	676	+
	677	+ // Put in Manual Editing checkbox
	678	+ add_action('add_meta_boxes', 'feedwordpress_post_add_meta_boxes', 10, 2);
	679	+
	680	+ add_filter('user_can_richedit', array($feedwordpress, 'user_can_richedit'), 1000, 1);
	681	+
	682	+ if (FeedWordPressDiagnostic::is_on('syndicated_posts:static_meta_data')) :
	683	+ $inspectPostMeta = new InspectPostMeta;
	684	+ endif;
	685	+ } // function feedwordpress_add_post_edit_controls ()
	686	+
	687	+ function feedwordpress_post_add_meta_boxes ($post_type, $post) {
	688	+ add_meta_box(
	689	+ 'feedwordpress-post-controls',
	690	+ __('Syndication'),
	691	+ 'feedwordpress_post_edit_controls',
	692	+ $post_type,
	693	+ 'side',
	694	+ 'high'
	695	+ );
	696	+ }
	697	+
	698	+ function feedwordpress_post_edit_controls () {
	699	+ global $post;
	700	+
	701	+ $frozen_values = get_post_custom_values('_syndication_freeze_updates', $post->ID);
	702	+ $frozen_post = ($frozen_values !== null and count($frozen_values) > 0 and 'yes' == $frozen_values[0]);
	703	+
	704	+ if (is_syndicated($post->ID)) :
	705	+ ?>
	706	+ <p>This is a syndicated post, which originally appeared at
	707	+ <cite><?php print esc_html(get_syndication_source(NULL, $post->ID)); ?></cite>.
	708	+ <a href="<?php print esc_html(get_syndication_permalink($post->ID)); ?>">View original post</a>.</p>
	709	+
	710	+ <?php do_action('feedwordpress_post_edit_controls_pre', $post); ?>
	711	+
	712	+ <p><input type="hidden" name="feedwordpress_noncename" id="feedwordpress_noncename" value="<?php print wp_create_nonce(plugin_basename(__FILE__)); ?>" />
	713	+ <label><input type="checkbox" name="freeze_updates" value="yes" <?php if ($frozen_post) : ?>checked="checked"<?php endif; ?> /> <strong>Manual editing.</strong>
	714	+ If set, FeedWordPress will not overwrite the changes you make manually
	715	+ to this post, if the syndicated content is updated on the
	716	+ feed.</label></p>
	717	+
	718	+ <?php do_action('feedwordpress_post_edit_controls', $post); ?>
	719	+
	720	+ <?php
	721	+ else :
	722	+ ?>
	723	+ <p>This post was created locally at this website.</p>
	724	+ <?php
	725	+ endif;
	726	+ } /* function feedwordpress_post_edit_controls () */
	727	+
	728	+ function feedwordpress_save_post_edit_controls ( $post_id ) {
	729	+ global $post;
	730	+ if (!isset($_POST['feedwordpress_noncename']) or !wp_verify_nonce($_POST['feedwordpress_noncename'], plugin_basename(__FILE__))) :
	731	+ return $post_id;
	732	+ endif;
	733	+
	734	+ // Verify if this is an auto save routine. If it is our form has
	735	+ // not been submitted, so we don't want to do anything.
	736	+ if ( defined('DOING_AUTOSAVE') and DOING_AUTOSAVE ) :
	737	+ return $post_id;
	738	+ endif;
	739	+
	740	+ // The data in $_POST is for applying only to the post actually
	741	+ // in the edit window, i.e. $post
	742	+ if ($post_id != $post->ID) :
	743	+ return $post_id;
	744	+ endif;
	745	+
	746	+ // Check permissions
	747	+ $cap[0] = 'edit_post';
	748	+ $cap[1] = 'edit_' . $_POST['post_type'];
	749	+ if (
	750	+ !current_user_can( $cap[0], $post_id )
	751	+ and !current_user_can( $cap[1], $post_id )
	752	+ ) :
	753	+ return $post_id;
	754	+ endif;
	755	+
	756	+ // OK, we're golden. Now let's save some data.
	757	+ if (isset($_POST['freeze_updates'])) :
	758	+
	759	+ update_post_meta($post_id, '_syndication_freeze_updates', $_POST['freeze_updates']);
	760	+ $ret = $_POST['freeze_updates'];
	761	+
	762	+ // If you make manual edits through the WordPress editing
	763	+ // UI then they should be run through normal WP formatting
	764	+ // filters.
	765	+ update_post_meta($post_id, '_feedwordpress_formatting_filters', 'yes');
	766	+
	767	+ else :
	768	+ delete_post_meta($post_id, '_syndication_freeze_updates');
	769	+ $ret = NULL;
	770	+ endif;
	771	+
	772	+ do_action('feedwordpress_save_edit_controls', $post_id);
	773	+
	774	+ return $ret;
	775	+ } // function feedwordpress_save_edit_controls
	776	+
	777	+################################################################################
449	778	## class FeedWordPressBoilerplateReformatter ###################################
450	779	################################################################################
451	780
452		-require_once("{$dir}/feedwordpressboilerplatereformatter.class.php");
453		-require_once("{$dir}/feedwordpressboilerplatereformatter.shortcode.functions.php");
	781	+class FeedWordPressBoilerplateReformatter {
	782	+ var $id, $element;
454	783
	784	+ public function __construct ($id = NULL, $element = 'post') {
	785	+ $this->id = $id;
	786	+ $this->element = $element;
	787	+ }
	788	+
	789	+ function shortcode_methods () {
	790	+ return array(
	791	+ 'source' => 'source_link',
	792	+ 'source-name' => 'source_name',
	793	+ 'source-url' => 'source_url',
	794	+ 'original-link' => 'original_link',
	795	+ 'original-url' => 'original_url',
	796	+ 'author' => 'source_author_link',
	797	+ 'author-name' => 'source_author',
	798	+ 'feed-setting' => 'source_setting',
	799	+ );
	800	+ }
	801	+ function do_shortcode ($template) {
	802	+ $codes = $this->shortcode_methods();
	803	+
	804	+ // Register shortcodes relative to this object/post ID/element.
	805	+ foreach ($codes as $code => $method) :
	806	+ add_shortcode($code, array($this, $method));
	807	+ endforeach;
	808	+
	809	+ $template = do_shortcode($template);
	810	+
	811	+ // Unregister shortcodes.
	812	+ foreach ($codes as $code => $method) :
	813	+ remove_shortcode($code);
	814	+ endforeach;
	815	+
	816	+ return $template;
	817	+ }
	818	+
	819	+ function source_name ($atts) {
	820	+ $param = shortcode_atts(array(
	821	+ 'original' => NULL,
	822	+ ), $atts);
	823	+ return get_syndication_source($param['original'], $this->id);
	824	+ }
	825	+ function source_url ($atts) {
	826	+ $param = shortcode_atts(array(
	827	+ 'original' => NULL,
	828	+ ), $atts);
	829	+ return get_syndication_source_link($param['original'], $this->id);
	830	+ }
	831	+ function source_link ($atts) {
	832	+ switch (strtolower($atts[0])) :
	833	+ case '-name' :
	834	+ $ret = $this->source_name($atts);
	835	+ break;
	836	+ case '-url' :
	837	+ $ret = $this->source_url($atts);
	838	+ break;
	839	+ default :
	840	+ $param = shortcode_atts(array(
	841	+ 'original' => NULL,
	842	+ ), $atts);
	843	+ if ('title' == $this->element) :
	844	+ $ret = $this->source_name($atts);
	845	+ else :
	846	+ $ret = '<a href="'.htmlspecialchars($this->source_url($atts)).'">'.htmlspecialchars($this->source_name($atts)).'</a>';
	847	+ endif;
	848	+ endswitch;
	849	+ return $ret;
	850	+ }
	851	+ function source_setting ($atts) {
	852	+ $param = shortcode_atts(array(
	853	+ 'key' => NULL,
	854	+ ), $atts);
	855	+ return get_feed_meta($param['key'], $this->id);
	856	+ }
	857	+ function original_link ($atts, $text) {
	858	+ $url = $this->original_url($atts);
	859	+ return '<a href="'.esc_url($url).'">'.do_shortcode($text).'</a>';
	860	+ }
	861	+ function original_url ($atts) {
	862	+ return get_syndication_permalink($this->id);
	863	+ }
	864	+ function source_author ($atts) {
	865	+ return get_the_author();
	866	+ }
	867	+ function source_author_link ($atts) {
	868	+ switch (strtolower($atts[0])) :
	869	+ case '-name' :
	870	+ $ret = $this->source_author($atts);
	871	+ break;
	872	+ default :
	873	+ global $authordata; // Janky.
	874	+ if ('title' == $this->element) :
	875	+ $ret = $this->source_author($atts);
	876	+ else :
	877	+ $ret = get_the_author();
	878	+ $url = get_author_posts_url((int) $authordata->ID, (int) $authordata->user_nicename);
	879	+ if ($url) :
	880	+ $ret = '<a href="'.$url.'" '
	881	+ .'title="Read other posts by '.esc_html($authordata->display_name).'">'
	882	+ .$ret
	883	+ .'</a>';
	884	+ endif;
	885	+ endif;
	886	+ endswitch;
	887	+ return $ret;
	888	+ }
	889	+}
	890	+
	891	+function add_boilerplate_reformat ($template, $element, $id = NULL) {
	892	+ if ('post' == $element and !preg_match('/< (p|div) ( \s [^>]+ )? >/xi', $template)) :
	893	+ $template = '<p class="syndicated-attribution">'.$template.'</p>';
	894	+ endif;
	895	+
	896	+ $ref = new FeedWordPressBoilerplateReformatter($id, $element);
	897	+ return $ref->do_shortcode($template);
	898	+}
	899	+
	900	+function add_boilerplate_simple ($element, $title, $id = NULL) {
	901	+ if (is_syndicated($id)) :
	902	+ $meta = get_feed_meta('boilerplate rules', $id);
	903	+ if ($meta and !is_array($meta)) : $meta = unserialize($meta); endif;
	904	+
	905	+ if (!is_array($meta) or empty($meta)) :
	906	+ $meta = get_option('feedwordpress_boilerplate');
	907	+ endif;
	908	+
	909	+ if (is_array($meta) and !empty($meta)) :
	910	+ foreach ($meta as $rule) :
	911	+ if ($element==$rule['element']) :
	912	+ $rule['template'] = add_boilerplate_reformat($rule['template'], $element, $id);
	913	+
	914	+ if ('before'==$rule['placement']) :
	915	+ $title = $rule['template'] . ' ' . $title;
	916	+ else :
	917	+ $title = $title . ' ' . $rule['template'];
	918	+ endif;
	919	+ endif;
	920	+ endforeach;
	921	+ endif;
	922	+ endif;
	923	+ return $title;
	924	+}
	925	+function add_boilerplate_title ($title, $id = NULL) {
	926	+ return add_boilerplate_simple('title', $title, $id);
	927	+}
	928	+function add_boilerplate_excerpt ($title, $id = NULL) {
	929	+ return add_boilerplate_simple('excerpt', $title, $id);
	930	+}
	931	+function add_boilerplate_content ($content) {
	932	+ if (is_syndicated()) :
	933	+ $meta = get_feed_meta('boilerplate rules');
	934	+ if ($meta and !is_array($meta)) : $meta = unserialize($meta); endif;
	935	+
	936	+ if (!is_array($meta) or empty($meta)) :
	937	+ $meta = get_option('feedwordpress_boilerplate');
	938	+ endif;
	939	+
	940	+ if (is_array($meta) and !empty($meta)) :
	941	+ foreach ($meta as $rule) :
	942	+ if ('post'==$rule['element']) :
	943	+ $rule['template'] = add_boilerplate_reformat($rule['template'], 'post');
	944	+
	945	+ if ('before'==$rule['placement']) :
	946	+ $content = $rule['template'] . "\n" . $content;
	947	+ else :
	948	+ $content = $content . "\n" . $rule['template'];
	949	+ endif;
	950	+ endif;
	951	+ endforeach;
	952	+ endif;
	953	+ endif;
	954	+ return $content;
	955	+}
	956	+
455	957	################################################################################
456	958	## class FeedWordPress #########################################################
457	959	################################################################################
458	960
		@@ -489,17 +991,15 @@
489	991	array('q', 'cite'),
490	992	array('script', 'src')
491	993	);
492	994
493		- var $feeds = null;
494		- var $feedurls = null;
495		- var $httpauth = null;
	995	+ var $feeds = NULL;
	996	+ var $feedurls = NULL;
	997	+ var $httpauth = NULL;
496	998
497	999	/**
498	1000	* FeedWordPress::__construct (): Construct FeedWordPress singleton object
499	1001	* and retrieves a list of feeds for later reference.
500		- *
501		- * @uses FeedWordPressHTTPAuthenticator
502	1002	*/
503	1003	public function __construct () {
504	1004	$this->feeds = array ();
505	1005	$this->feedurls = array();
		@@ -520,216 +1020,13 @@
520	1020	add_filter('cron_schedules', array($this, 'cron_schedules'), 10, 1);
521	1021
522	1022	// FeedWordPress-related event hooks
523	1023	add_filter('feedwordpress_update_complete', array($this, 'process_retirements'), 1000, 1);
524		-
	1024	+
525	1025	$this->httpauth = new FeedWordPressHTTPAuthenticator;
526	1026	} /* FeedWordPress::__construct () */
527	1027
528	1028	/**
529		- * FeedWordPress::add_filters() connects FeedWordPress to WordPress lifecycle
530		- * events by setting up action and filter hooks.
531		- *
532		- * @uses get_option()
533		- * @uses add_filter()
534		- * @uses add_action()
535		- * @uses remove_filter()
536		- */
537		- public function add_filters () {
538		- # Syndicated items are generally received in output-ready (X)HTML and
539		- # should not be folded, crumpled, mutilated, or spindled by WordPress
540		- # formatting filters. But we don't want to interfere with filters for
541		- # any locally-authored posts, either.
542		- #
543		- # What WordPress should really have is a way for upstream filters to
544		- # stop downstream filters from running at all. Since it doesn't, and
545		- # since a downstream filter can't access the original copy of the text
546		- # that is being filtered, what we will do here is (1) save a copy of the
547		- # original text upstream, before any other filters run, and then (2)
548		- # retrieve that copy downstream, after all the other filters run, *if*
549		- # this is a syndicated post
550		-
551		- add_filter('the_content', 'feedwordpress_preserve_syndicated_content', -10000);
552		- add_filter('the_content', 'feedwordpress_restore_syndicated_content', 10000);
553		-
554		- add_action('atom_entry', 'feedwordpress_item_feed_data');
555		-
556		- # Filter in original permalinks if the user wants that
557		- add_filter('post_link', 'syndication_permalink', /*priority=*/ 1, /*arguments=*/ 3);
558		- add_filter('post_type_link', 'syndication_permalink', /*priority=*/ 1, /*arguments=*/ 4);
559		-
560		- # When foreign URLs are used for permalinks in feeds or display
561		- # contexts, they need to be escaped properly.
562		- add_filter('the_permalink', 'syndication_permalink_escaped');
563		- add_filter('the_permalink_rss', 'syndication_permalink_escaped');
564		-
565		- add_filter('post_comments_feed_link', 'syndication_comments_feed_link');
566		-
567		- # WTF? By default, wp_insert_link runs incoming link_url and link_rss
568		- # URIs through default filters that include `wp_kses()`. But `wp_kses()`
569		- # just happens to escape any occurrence of & to &amp; -- which just
570		- # happens to fuck up any URI with a & to separate GET parameters.
571		- remove_filter('pre_link_rss', 'wp_filter_kses');
572		- remove_filter('pre_link_url', 'wp_filter_kses');
573		-
574		- # Boilerplate functionality: hook in to title, excerpt, and content to add boilerplate text
575		- $hookOrder = get_option('feedwordpress_boilerplate_hook_order', FEEDWORDPRESS_BOILERPLATE_DEFAULT_HOOK_ORDER);
576		- add_filter(
577		- /*hook=*/ 'the_title',
578		- /*function=*/ 'add_boilerplate_title',
579		- /*priority=*/ $hookOrder,
580		- /*arguments=*/ 2
581		- );
582		- add_filter(
583		- /*hook=*/ 'get_the_excerpt',
584		- /*function=*/ 'add_boilerplate_excerpt',
585		- /*priority=*/ $hookOrder,
586		- /*arguments=*/ 1
587		- );
588		- add_filter(
589		- /*hook=*/ 'the_content',
590		- /*function=*/ 'add_boilerplate_content',
591		- /*priority=*/ $hookOrder,
592		- /*arguments=*/ 1
593		- );
594		- add_filter(
595		- /*hook=*/ 'the_content_rss',
596		- /*function=*/ 'add_boilerplate_content',
597		- /*priority=*/ $hookOrder,
598		- /*arguments=*/ 1
599		- );
600		-
601		- # Admin menu
602		- add_action('admin_init', array($this, 'admin_init'));
603		- add_action('admin_menu', array($this, 'add_pages'));
604		- add_action('admin_notices', array($this, 'check_debug'));
605		-
606		- add_action('admin_menu', 'feedwordpress_add_post_edit_controls');
607		- add_action('save_post', 'feedwordpress_save_post_edit_controls');
608		-
609		- add_action('admin_footer', array($this, 'admin_footer'));
610		-
611		- add_action('syndicated_feed_error', array('FeedWordPressDiagnostic', 'feed_error'), 100, 3);
612		-
613		- add_action('wp_footer', 'debug_out_feedwordpress_footer', -100);
614		- add_action('admin_footer', 'debug_out_feedwordpress_footer', -100);
615		-
616		- # Cron-less auto-update. Hooray!
617		- $autoUpdateHook = $this->automatic_update_hook();
618		- if ( !is_null($autoUpdateHook)) :
619		- add_action($autoUpdateHook, array($this, 'auto_update'));
620		- endif;
621		-
622		- add_action('init', array($this, 'init'));
623		- add_action('wp_loaded', array($this, 'wp_loaded'));
624		-
625		- add_action('shutdown', array($this, 'email_diagnostic_log'));
626		- add_action('shutdown', array($this, 'feedwordpress_cleanup'));
627		- add_action('wp_dashboard_setup', array($this, 'dashboard_setup'));
628		-
629		- # Default sanitizers
630		- add_filter('syndicated_item_content', array('SyndicatedPost', 'resolve_relative_uris'), 0, 2);
631		- add_filter('syndicated_item_content', array('SyndicatedPost', 'sanitize_content'), 0, 2);
632		-
633		- add_action('plugins_loaded', array($this, 'admin_api'));
634		- add_action('all_admin_notices', array($this, 'all_admin_notices'));
635		-
636		- // Use the cache settings that we want, from a static method
637		- add_filter('wp_feed_cache_transient_lifetime', array(get_class($this), 'cache_lifetime'));
638		-
639		- } /* FeedWordPress::add_filters () */
640		-
641		- ################################################################################
642		- ## ADMIN MENU ADD-ONS: register Dashboard management pages #####################
643		- ################################################################################
644		-
645		- /**
646		- * FeedWordPress::add_pages(): set up WordPress admin interface pages thru
647		- * hooking in Syndication menu and submenus
648		- *
649		- * @uses FeedWordPress::menu_cap()
650		- * @uses FeedWordPress::path()
651		- * @uses add_menu_page()
652		- * @uses add_submenu_page()
653		- * @uses do_action()
654		- * @uses add_filter()
655		- */
656		- public function add_pages()
657		- {
658		- $menu_cap = FeedWordPress::menu_cap();
659		- $settings_cap = FeedWordPress::menu_cap( /*sub=*/ true );
660		- $syndicationMenu = FeedWordPress::path( 'syndication.php' );
661		-
662		- add_menu_page(
663		- /* page_title */ 'Syndicated Sites',
664		- /* menu_title */ 'Syndication',
665		- /* capability */ $menu_cap,
666		- /* menu_slug */ $syndicationMenu,
667		- /* function */ NULL,
668		- /* icon_url */ $this->plugin_dir_url( /* 'assets/images/feedwordpress-tiny.png' */ 'assets/images/icon.svg' )
669		- /* position */
670		- );
671		-
672		- do_action( 'feedwordpress_admin_menu_pre_feeds', $menu_cap, $settings_cap );
673		- add_submenu_page(
674		- /* parent_slug */ $syndicationMenu,
675		- /* page_title */ 'Syndicated Sites',
676		- /* menu_title */ 'Syndicated Sites',
677		- /* capability */ $settings_cap,
678		- /* menu_slug */ $syndicationMenu,
679		- /* function */
680		- );
681		-
682		- do_action('feedwordpress_admin_menu_pre_feeds', $menu_cap, $settings_cap);
683		- add_submenu_page(
684		- $syndicationMenu, 'Syndicated Feeds & Updates', 'Feeds & Updates',
685		- $settings_cap, FeedWordPress::path('feeds-page.php')
686		- );
687		-
688		- do_action('feedwordpress_admin_menu_pre_posts', $menu_cap, $settings_cap);
689		- add_submenu_page(
690		- $syndicationMenu, 'Syndicated Posts & Links', 'Posts & Links',
691		- $settings_cap, FeedWordPress::path('posts-page.php')
692		- );
693		-
694		- do_action('feedwordpress_admin_menu_pre_authors', $menu_cap, $settings_cap);
695		- add_submenu_page(
696		- $syndicationMenu, 'Syndicated Authors', 'Authors',
697		- $settings_cap, FeedWordPress::path('authors-page.php')
698		- );
699		-
700		- do_action('feedwordpress_admin_menu_pre_categories', $menu_cap, $settings_cap);
701		- add_submenu_page(
702		- $syndicationMenu, 'Categories & Tags', 'Categories & Tags',
703		- $settings_cap, FeedWordPress::path('categories-page.php')
704		- );
705		-
706		- do_action('feedwordpress_admin_menu_pre_performance', $menu_cap, $settings_cap);
707		- add_submenu_page(
708		- $syndicationMenu, 'FeedWordPress Performance', 'Performance',
709		- $settings_cap, FeedWordPress::path('performance-page.php')
710		- );
711		-
712		- do_action('feedwordpress_admin_menu_pre_diagnostics', $menu_cap, $settings_cap);
713		- add_submenu_page(
714		- $syndicationMenu, 'FeedWordPress Diagnostics', 'Diagnostics',
715		- $settings_cap, FeedWordPress::path('diagnostics-page.php')
716		- );
717		-
718		- add_filter('page_row_actions', array($this, 'row_actions'), 10, 2);
719		- add_filter('post_row_actions', array($this, 'row_actions'), 10, 2);
720		- } /* function FeedWordPress::add_pages () */
721		-
722		- public function check_debug() {
723		- // This is a horrible fucking kludge that I have to do because the
724		- // admin notice code is triggered before the code that updates the
725		- // setting.
726		- $feedwordpress_debug = FeedWordPress::param( 'feedwordpress_debug', get_option( 'feedwordpress_debug' ) );
727		-
728		- FeedWordPressSettingsUI::get_template_part( 'notice-debug-mode', $feedwordpress_debug, 'html' );
729		- } /* function FeedWordPress::check_debug () */
730		-
731		- /**
732	1029	* FeedWordPress::subscribed (): Check whether a feed is currently in the
733	1030	* subscription list for FeedWordPress.
734	1031	*
735	1032	* @param mixed $id Numeric ID of a WordPress link object or URL of a feed
		@@ -744,12 +1041,12 @@
744	1041	* given URL or numeric ID, if we have either an active subscription to
745	1042	* it; or a de-activated subscription.
746	1043	*
747	1044	* @param mixed $which Numeric ID for a WordPress link object or string URL for a feed
748		- * @return mixed SyndicatedLink object if subscription is found; null if not
	1045	+ * @return mixed SyndicatedLink object if subscription is found; NULL if not
749	1046	*/
750	1047	public function subscription ($which) {
751		- $sub = null;
	1048	+ $sub = NULL;
752	1049
753	1050	if (is_string($which) and isset($this->feedurls[$which])) :
754	1051	$which = $this->feedurls[$which];
755	1052	endif;
		@@ -765,9 +1062,9 @@
765	1062	$sub = get_bookmark($which);
766	1063	endif;
767	1064
768	1065	// Load 'er up if you haven't already.
769		- if ( !is_null($sub) and !($sub InstanceOf SyndicatedLink)) :
	1066	+ if (!is_null($sub) and !($sub InstanceOf SyndicatedLink)) :
770	1067	$link = new SyndicatedLink($sub);
771	1068	$this->feeds[$which] = $link;
772	1069	$sub = $link;
773	1070	endif;
		@@ -774,132 +1071,121 @@
774	1071
775	1072	return $sub;
776	1073	} /* FeedWordPress::subscription () */
777	1074
778		- /** function update (): polls for updates on one or more Contributor feeds
779		-
780		- @desc
	1075	+ # function update (): polls for updates on one or more Contributor feeds
	1076	+ #
781	1077	# Arguments:
782		-
783		- - $uri (string): Either the URI of the feed to poll, the URI of the
784		- (human-readable) website whose feed you want to poll, or null.
785		-
786		- If $uri is null, then FeedWordPress will poll any feeds that are
787		- ready for polling. It will not poll feeds that are marked as
788		- "Invisible" Links (signifying that the subscription has been
789		- de-activated), or feeds that are not yet stale according to their
790		- TTL setting (which is either set in the feed, or else set
791		- randomly within a window of 30 minutes - 2 hours).
792		-
	1078	+ # ----------
	1079	+ # * $uri (string): either the URI of the feed to poll, the URI of the
	1080	+ # (human-readable) website whose feed you want to poll, or NULL.
	1081	+ #
	1082	+ # If $uri is NULL, then FeedWordPress will poll any feeds that are
	1083	+ # ready for polling. It will not poll feeds that are marked as
	1084	+ # "Invisible" Links (signifying that the subscription has been
	1085	+ # de-activated), or feeds that are not yet stale according to their
	1086	+ # TTL setting (which is either set in the feed, or else set
	1087	+ # randomly within a window of 30 minutes - 2 hours).
	1088	+ #
793	1089	# Returns:
794		-
795		- - Normally returns an associative array, with 'new' => the number
796		- of new posts added during the update, and 'updated' => the number
797		- of old posts that were updated during the update. If both numbers
798		- are zero, there was no change since the last poll on that URI.
799		-
800		- - Returns null if URI it was passed was not a URI that this
801		- installation of FeedWordPress syndicates.
802		-
	1090	+ # --------
	1091	+ # * Normally returns an associative array, with 'new' => the number
	1092	+ # of new posts added during the update, and 'updated' => the number
	1093	+ # of old posts that were updated during the update. If both numbers
	1094	+ # are zero, there was no change since the last poll on that URI.
	1095	+ #
	1096	+ # * Returns NULL if URI it was passed was not a URI that this
	1097	+ # installation of FeedWordPress syndicates.
	1098	+ #
803	1099	# Effects:
	1100	+ # --------
	1101	+ # * One or more feeds are polled for updates
	1102	+ #
	1103	+ # * If the feed Link does not have a hardcoded name set, its Link
	1104	+ # Name is synchronized with the feed's title element
	1105	+ #
	1106	+ # * If the feed Link does not have a hardcoded URI set, its Link URI
	1107	+ # is synchronized with the feed's human-readable link element
	1108	+ #
	1109	+ # * If the feed Link does not have a hardcoded description set, its
	1110	+ # Link Description is synchronized with the feed's description,
	1111	+ # tagline, or subtitle element.
	1112	+ #
	1113	+ # * The time of polling is recorded in the feed's settings, and the
	1114	+ # TTL (time until the feed is next available for polling) is set
	1115	+ # either from the feed (if it is supplied in the ttl or syndication
	1116	+ # module elements) or else from a randomly-generated time window
	1117	+ # (between 30 minutes and 2 hours).
	1118	+ #
	1119	+ # * New posts from the polled feed are added to the WordPress store.
	1120	+ #
	1121	+ # * Updates to existing posts since the last poll are mirrored in the
	1122	+ # WordPress store.
	1123	+ #
	1124	+ public function update ($uri = null, $crash_ts = null) {
	1125	+ global $wpdb;
804	1126
805		- - One or more feeds are polled for updates
806		-
807		- - If the feed Link does not have a hardcoded name set, its Link
808		- Name is synchronized with the feed's title element
809		-
810		- - If the feed Link does not have a hardcoded URI set, its Link URI
811		- is synchronized with the feed's human-readable link element
812		-
813		- - If the feed Link does not have a hardcoded description set, its
814		- Link Description is synchronized with the feed's description,
815		- tagline, or subtitle element.
816		-
817		- - The time of polling is recorded in the feed's settings, and the
818		- TTL (time until the feed is next available for polling) is set
819		- either from the feed (if it is supplied in the ttl or syndication
820		- module elements) or else from a randomly-generated time window
821		- (between 30 minutes and 2 hours).
822		-
823		- - New posts from the polled feed are added to the WordPress store.
824		-
825		- - Updates to existing posts since the last poll are mirrored in the
826		- WordPress store.
827		-
828		- @param string|null $uri Either the URI of the feed to poll, the URI of the (human-readable) website whose feed you want to poll, or null.
829		- @param mixed|null $crash_ts Unknown purpose.
830		- @return array|null Associative array, with 'new' => # of new posts added during update, and 'updated' => # of old posts that were updated. If both are zero, there was no change since çast update.
831		- */
832		- public function update( $uri = null, $crash_ts = null ) {
833		- if ( FeedWordPress::needs_upgrade() ) : // Will make duplicate posts if we don't hold off
834		- return null;
	1127	+ if (FeedWordPress::needs_upgrade()) : // Will make duplicate posts if we don't hold off
	1128	+ return NULL;
835	1129	endif;
836	1130
837		- if ( ! is_null( $uri ) and $uri != '*' ) :
838		- $uri = trim( $uri );
	1131	+ if (!is_null($uri) and $uri != '*') :
	1132	+ $uri = trim($uri);
839	1133	else : // Update all
840		- if ( $this->update_hooked ) :
	1134	+ if ($this->update_hooked) :
841	1135	$diag = $this->update_hooked;
842	1136	else :
843		- $diag = 'Initiating a MANUAL check-in on the update schedule at ' . date( 'r', time() );
	1137	+ $diag = 'Initiating a MANUAL check-in on the update schedule at '.date('r', time());
844	1138	endif;
845		- $this->diagnostic( 'update_schedule:check', $diag );
	1139	+ $this->diagnostic('update_schedule:check', $diag);
846	1140
847		- update_option( 'feedwordpress_last_update_all', time() );
	1141	+ update_option('feedwordpress_last_update_all', time());
848	1142	endif;
849	1143
850		- do_action( 'feedwordpress_update', $uri );
	1144	+ do_action('feedwordpress_update', $uri);
851	1145
852		- if ( is_null( $crash_ts ) ) :
	1146	+ if (is_null($crash_ts)) :
853	1147	$crash_ts = $this->crash_ts();
854	1148	endif;
855	1149
856	1150	// Randomize order for load balancing purposes
857		- $feed_set = array_keys( $this->feeds );
858		- shuffle( $feed_set );
	1151	+ $feed_set = array_keys($this->feeds);
	1152	+ shuffle($feed_set);
859	1153
860		- $updateWindow = (int) get_option( 'feedwordpress_update_window', DEFAULT_UPDATE_PERIOD ) * 60 /* sec/min */;
861		- $interval = (int) get_option( 'feedwordpress_freshness', FEEDWORDPRESS_FRESHNESS_INTERVAL );
	1154	+ $updateWindow = (int) get_option('feedwordpress_update_window', DEFAULT_UPDATE_PERIOD) * 60 /* sec/min */;
	1155	+ $interval = (int) get_option('feedwordpress_freshness', FEEDWORDPRESS_FRESHNESS_INTERVAL);
862	1156	$portion = max(
863		- (int) ceil( count( $feed_set ) / ( $updateWindow / $interval ) ),
	1157	+ (int) ceil(count($feed_set) / ($updateWindow / $interval)),
864	1158	10
865	1159	);
866	1160
867		- $max_polls = apply_filters(
868		- 'feedwordpress_polls_per_update',
869		- get_option(
870		- 'feedwordpress_polls_per_update', $portion
871		- ),
872		- $uri
873		- );
	1161	+ $max_polls = apply_filters('feedwordpress_polls_per_update', get_option(
	1162	+ 'feedwordpress_polls_per_update', $portion
	1163	+ ), $uri);
874	1164
875		- $feed_set = apply_filters( 'feedwordpress_update_feeds', $feed_set, $uri );
	1165	+ $feed_set = apply_filters('feedwordpress_update_feeds', $feed_set, $uri);
876	1166
	1167	+
877	1168	// Loop through and check for new posts
878		- $delta = null;
879		- $remaining = $max_polls;
880		- foreach ( $feed_set as $feed_id) :
	1169	+ $delta = NULL; $remaining = $max_polls;
	1170	+ foreach ($feed_set as $feed_id) :
881	1171
882		- $feed = $this->subscription( $feed_id );
883		- // Try to catch a very unusual condition where the $feed comes as NULL (gwyneth 20230919)
884		- if ( ! empty( $feed ) ) :
885		- $this->diagnostic( 'update_schedule', "Feed " . $feed_id . " returned an empty feed" );
886		- endif;
	1172	+ $feed = $this->subscription($feed_id);
887	1173
888	1174	// Has this process overstayed its welcome?
889	1175	if (
890	1176	// Over time limit?
891		- ( ! is_null( $crash_ts ) and ( time() > $crash_ts ) )
	1177	+ (!is_null($crash_ts) and (time() > $crash_ts))
892	1178
893	1179	// Over feed count?
894		- or ( 0 == $remaining )
	1180	+ or ($remaining == 0)
895	1181	) :
896	1182	break;
897	1183	endif;
898	1184
899		- $pinged_that = ( is_null( $uri ) or ( $uri == '*' ) or in_array( $uri, array( $feed->uri(), $feed->homepage() ) ) );
	1185	+ $pinged_that = (is_null($uri) or ($uri=='*') or in_array($uri, array($feed->uri(), $feed->homepage())));
900	1186
901		- if ( ! is_null( $uri ) ) : // A site-specific ping always updates
	1187	+ if (!is_null($uri)) : // A site-specific ping always updates
902	1188	$timely = true;
903	1189	else :
904	1190	$timely = $feed->stale();
905	1191	endif;
		@@ -904,45 +1190,36 @@
904	1190	$timely = $feed->stale();
905	1191	endif;
906	1192
907	1193	// If at least one feed was hit for updating...
908		- if ( $pinged_that and is_null( $delta ) ) :
	1194	+ if ($pinged_that and is_null($delta)) :
909	1195	// ... don't return error condition
910		- $delta = array( 'new' => 0, 'updated' => 0, 'stored' => 0 );
	1196	+ $delta = array('new' => 0, 'updated' => 0, 'stored' => 0);
911	1197	endif;
912	1198
913		- if ( $pinged_that and $timely ) :
	1199	+ if ($pinged_that and $timely) :
914	1200	$remaining = $remaining - 1;
915	1201
916		- do_action( 'feedwordpress_check_feed', $feed->settings );
	1202	+ do_action('feedwordpress_check_feed', $feed->settings);
917	1203	$start_ts = time();
918		- $added = $feed->poll( $crash_ts );
919		- do_action( 'feedwordpress_check_feed_complete', $feed->settings, $added, time() - $start_ts );
	1204	+ $added = $feed->poll($crash_ts);
	1205	+ do_action('feedwordpress_check_feed_complete', $feed->settings, $added, time() - $start_ts);
920	1206
921		- if ( is_array( $added ) ) : // Success
922		- foreach ( $added as $key => $count ) :
923		- $delta[ $key ] += $added[ $key ];
	1207	+ if (is_array($added)) : // Success
	1208	+ foreach ($added as $key => $count) :
	1209	+ $delta[$key] += $added[$key];
924	1210	endforeach;
925	1211	endif;
926	1212	endif;
927	1213	endforeach;
928	1214
929		- do_action( 'feedwordpress_update_complete', $delta );
	1215	+ do_action('feedwordpress_update_complete', $delta);
930	1216	return $delta;
931	1217	} /* FeedWordPress::update () */
932	1218
933		- /**
934		- * Checks if we're over the update time limit.
935		- *
936		- * @todo is returning null advisable? (gwyneth 20230916)
937		- *
938		- * @param int|null $default Default value, called when the corresponding FWP option is not set.
939		- *
940		- * @return int|null
941		- */
942		- public function crash_ts( $default = null ) {
943		- $crash_dt = (int) get_option( 'feedwordpress_update_time_limit', 0 );
944		- if ( $crash_dt > 0 ) :
	1219	+ public function crash_ts ($default = NULL) {
	1220	+ $crash_dt = (int) get_option('feedwordpress_update_time_limit', 0);
	1221	+ if ($crash_dt > 0) :
945	1222	$crash_ts = time() + $crash_dt;
946	1223	else :
947	1224	$crash_ts = $default;
948	1225	endif;
		@@ -948,71 +1225,44 @@
948	1225	endif;
949	1226	return $crash_ts;
950	1227	} /* FeedWordPress::crash_ts () */
951	1228
952		-
953		- /**
954		- * Checks if we have a secret key set in the options; if not, generate one.
955		- *
956		- * @return string Secret key, either from options or auto-generated.
957		- *
958		- * @todo Only 6 characters? That is rather easy to guess... Also, uniqid() can return 13 or 23
959		- * characters, what's the point of using MD5 in this case? (gwyneth 20230916)
960		- */
961		- public function secret_key() {
962		- $secret = get_option( 'feedwordpress_secret_key', false );
963		- if ( ! $secret) : // Generate random key.
964		- $secret = substr( md5( uniqid( microtime() ) ), 0, 6 );
965		- update_option( 'feedwordpress_secret_key', $secret );
	1229	+ public function secret_key () {
	1230	+ $secret = get_option('feedwordpress_secret_key', false);
	1231	+ if (!$secret) : // Generate random key.
	1232	+ $secret = substr(md5(uniqid(microtime())), 0, 6);
	1233	+ update_option('feedwordpress_secret_key', $secret);
966	1234	endif;
967	1235	return $secret;
968	1236	} /* FeedWordPress::secret_key () */
969	1237
970		- /**
971		- * Returns true if we have set a secret FWP key.
972		- *
973		- * @return bool True if we have a secret key, false otherwise
974		- *
975		- * @uses MyPHP::request()
976		- */
977		- public function has_secret() {
978		- return ( MyPHP::request( 'feedwordpress_key' ) == $this->secret_key() );
	1238	+ public function has_secret () {
	1239	+ return (MyPHP::request('feedwordpress_key')==$this->secret_key());
979	1240	} /* FeedWordPress::has_secret () */
980	1241
981		- var $update_hooked = null;
982		-
983		- /**
984		- * Activates the hook for automatic plugin updates, if requested.
985		- *
986		- * @param Array $params Parameters to send to the hook.
987		- *
988		- * @return string Represents the hook's name. There is a slight chance that this is null, though. (gwyneth 20230916)
989		- *
990		- * @uses wp_parse_args()
991		- * @uses MyPHP::request()
992		- */
993		- public function automatic_update_hook( $params = array() ) {
994		- $params = wp_parse_args( $params, array( // Defaults
	1242	+ var $update_hooked = NULL;
	1243	+ public function automatic_update_hook ($params = array()) {
	1244	+ $params = wp_parse_args($params, array( // Defaults
995	1245	'setting only' => false,
996	1246	));
997		- $hook = get_option( 'feedwordpress_automatic_updates', null );
	1247	+ $hook = get_option('feedwordpress_automatic_updates', NULL);
998	1248	$method = 'FeedWordPress option';
999	1249
1000	1250	// Allow for forced behavior in testing.
1001	1251	if (
1002		- ! $params['setting only']
	1252	+ !$params['setting only']
1003	1253	and $this->has_secret()
1004		- and MyPHP::request( 'automatic_update' )
	1254	+ and MyPHP::request('automatic_update')
1005	1255	) :
1006		- $hook = MyPHP::request( 'automatic_update') ;
	1256	+ $hook = MyPHP::request('automatic_update');
1007	1257	$method = 'URL parameter';
1008	1258	endif;
1009	1259
1010	1260	$exact = $hook; // Before munging
1011	1261
1012		- if ( !! $hook) :
1013		- if ( $hook == 'init' or $hook == 'wp_loaded' ) : // Re-map init to wp_loaded
1014		- $hook = ( $params['setting only'] ? 'init' : 'wp_loaded' );
	1262	+ if (!!$hook) :
	1263	+ if ($hook == 'init' or $hook == 'wp_loaded') : // Re-map init to wp_loaded
	1264	+ $hook = ($params['setting only'] ? 'init' : 'wp_loaded');
1015	1265
1016	1266	// Constrain possible values. If it's not an init or wp_loaded, it's a shutdown
1017	1267	else :
1018	1268	$hook = 'shutdown';
		@@ -1018,10 +1268,10 @@
1018	1268	$hook = 'shutdown';
1019	1269	endif;
1020	1270	endif;
1021	1271
1022		- if ( $hook ) :
1023		- $this->update_hooked = "Initiating an AUTOMATIC CHECK FOR UPDATES ON PAGE LOAD " . $hook . " due to " . $method . " = " . trim( $this->val( $exact ) );
	1272	+ if ($hook) :
	1273	+ $this->update_hooked = "Initiating an AUTOMATIC CHECK FOR UPDATES ON PAGE LOAD ".$hook." due to ".$method." = ".trim($this->val($exact));
1024	1274	endif;
1025	1275
1026	1276	return $hook;
1027	1277	} /* FeedWordPress::automatic_update_hook () */
		@@ -1027,22 +1277,22 @@
1027	1277	} /* FeedWordPress::automatic_update_hook () */
1028	1278
1029	1279	public function last_update_all () {
1030	1280	$last = get_option('feedwordpress_last_update_all');
1031		- if ( $this->has_secret() and FeedWordPress::param('automatic_update') ) :
	1281	+ if ($this->has_secret() and MyPHP::request('automatic_update')) :
1032	1282	$last = 1; // A long, long time ago.
1033		- elseif ( $this->has_secret() and FeedWordPress::param('last_update_all') ) :
1034		- $last = FeedWordPress::param( 'last_update_all' );
	1283	+ elseif ($this->has_secret() and MyPHP::request('last_update_all')) :
	1284	+ $last = MyPHP::request('last_update_all');
1035	1285	endif;
1036	1286	return $last;
1037	1287	} /* FeedWordPress::last_update_all () */
1038	1288
1039	1289	public function force_update_all () {
1040		- return ($this->has_secret() and FeedWordPress::param( 'force_update_feeds' ));
	1290	+ return ($this->has_secret() and MyPHP::request('force_update_feeds'));
1041	1291	} /* FeedWordPress::force_update_all () */
1042	1292
1043	1293	public function stale () {
1044		- if ( !is_null($this->automatic_update_hook())) :
	1294	+ if (!is_null($this->automatic_update_hook())) :
1045	1295	// Do our best to avoid possible simultaneous
1046	1296	// updates by getting up-to-the-minute settings.
1047	1297
1048	1298	$last = $this->last_update_all();
		@@ -1074,14 +1324,12 @@
1074	1324	static function admin_init () {
1075	1325	// WordPress 3.5+ compat: the WP devs are in the midst of removing Links from the WordPress core. Eventually we'll have to deal
1076	1326	// with the possible disappearance of the wp_links table as a whole; but in the meantime, we just need to turn on the interface
1077	1327	// element to avoid problems with user capabilities that presume the presence of the Links Manager in the admin UI.
1078		- global $post_type;
1079		-
1080		- if ( !intval(get_option('link_manager_enabled', false))) :
	1328	+ if (!intval(get_option('link_manager_enabled', false))) :
1081	1329	update_option('link_manager_enabled', true);
1082	1330	endif;
1083		-
	1331	+
1084	1332	if (defined('FEEDWORDPRESS_PREPARE_TO_ZAP') and FEEDWORDPRESS_PREPARE_TO_ZAP) :
1085	1333	$post_id = FEEDWORDPRESS_PREPARE_TO_ZAP;
1086	1334	$sendback = wp_get_referer();
1087	1335	if (
		@@ -1088,9 +1336,9 @@
1088	1336	! $sendback
1089	1337	or strpos( $sendback, 'post.php' ) !== false
1090	1338	or strpos( $sendback, 'post-new.php' ) !== false
1091	1339	) :
1092		- if ( 'attachment' == $post_type ) : // where does this come from?? I put it as a global...(gwyneth 20230916)
	1340	+ if ( 'attachment' == $post_type ) :
1093	1341	$sendback = admin_url( 'upload.php' );
1094	1342	else :
1095	1343	$sendback = admin_url( 'edit.php' );
1096	1344	$sendback .= ( ! empty( $post_type ) ) ? '?post_type=' . $post_type : '';
		@@ -1099,9 +1347,9 @@
1099	1347	$sendback = esc_url( remove_query_arg( array('trashed', 'untrashed', 'deleted', 'zapped', 'unzapped', 'ids'), $sendback ) );
1100	1348	endif;
1101	1349
1102	1350	// Make sure we have a post corresponding to this ID.
1103		- $post = $post_type = $post_type_object = null; // whatever $post_type_object might be, it's not being used! (gwyneth 20230920)
	1351	+ $post = $post_type = $post_type_object = null;
1104	1352	if ( $post_id ) :
1105	1353	$post = get_post( $post_id );
1106	1354	endif;
1107	1355
		@@ -1107,32 +1355,28 @@
1107	1355
1108	1356	if ( $post ) :
1109	1357	$post_type = $post->post_type;
1110	1358	endif;
1111		- $p = get_post( $post_id );
	1359	+ $p = get_post($post_id);
1112	1360
1113	1361	if ( ! $post ) :
1114		- wp_die( esc_html__( 'The item you are trying to zap no longer exists.' ) );
	1362	+ wp_die( __( 'The item you are trying to zap no longer exists.' ) );
1115	1363	endif;
1116		-
	1364	+
1117	1365	if ( ! current_user_can( 'delete_post', $post_id ) ) :
1118		- wp_die( esc_html__( 'You are not allowed to zap this item.' ) );
	1366	+ wp_die( __( 'You are not allowed to zap this item.' ) );
1119	1367	endif;
1120		-
	1368	+
1121	1369	if ( $user_id = wp_check_post_lock( $post_id ) ) :
1122		- if ( is_numeric( $user_id ) and function_exists( 'get_userdata' ) ) :
1123		- $user = get_userdata( (int) $user_id );
1124		- wp_die( esc_html( sprintf( __( 'You cannot retire this item. %s is currently editing.' ), $user->display_name ) ) );
1125		- else :
1126		- wp_die( esc_html__( 'You cannot retire this item. Someone is currently editing.' ) );
1127		- endif;
	1370	+ $user = get_userdata( $user_id );
	1371	+ wp_die( sprintf( __( 'You cannot retire this item. %s is currently editing.' ), $user->display_name ) );
1128	1372	endif;
1129		-
1130		- if (FeedWordPress::param( 'fwp_post_delete' ) == 'zap') :
	1373	+
	1374	+ if (MyPHP::request('fwp_post_delete')=='zap') :
1131	1375	FeedWordPress::diagnostic('syndicated_posts', 'Zapping existing post # '.$p->ID.' "'.$p->post_title.'" due to user request.');
1132		-
	1376	+
1133	1377	$old_status = $post->post_status;
1134		-
	1378	+
1135	1379	set_post_field('post_status', 'fwpzapped', $post_id);
1136	1380	wp_transition_post_status('fwpzapped', $old_status, $post);
1137	1381
1138	1382	# Set up the post to have its content blanked on
		@@ -1138,17 +1382,17 @@
1138	1382	# Set up the post to have its content blanked on
1139	1383	# next update if you do not undo the zapping.
1140	1384	add_post_meta($post_id, '_feedwordpress_zapped_blank_me', 1, /*unique=*/ true);
1141	1385	add_post_meta($post_id, '_feedwordpress_zapped_blank_old_status', $old_status, /*unique=*/ true);
1142		-
	1386	+
1143	1387	wp_redirect( esc_url_raw( add_query_arg( array('zapped' => 1, 'ids' => $post_id), $sendback ) ) );
1144	1388
1145	1389	else :
1146	1390	$old_status = get_post_meta($post_id, '_feedwordpress_zapped_blank_old_status', /*single=*/ true);
1147		-
	1391	+
1148	1392	set_post_field('post_status', $old_status, $post_id);
1149	1393	wp_transition_post_status($old_status, 'fwpzapped', $post);
1150		-
	1394	+
1151	1395	# O.K., make sure this post does not get blanked
1152	1396	delete_post_meta($post_id, '_feedwordpress_zapped_blank_me');
1153	1397	delete_post_meta($post_id, '_feedwordpress_zapped_blank_old_status');
1154	1398
		@@ -1154,9 +1398,9 @@
1154	1398
1155	1399	wp_redirect( esc_url_raw( add_query_arg( array('unzapped' => 1, 'ids' => $post_id), $sendback ) ) );
1156	1400
1157	1401	endif;
1158		-
	1402	+
1159	1403	// Intercept, don't pass on.
1160	1404	exit;
1161	1405	endif;
1162	1406	} /* FeedWordPress::admin_init() */
		@@ -1167,13 +1411,13 @@
1167	1411	// actions link. So we create a magic parameter, and when this
1168	1412	// magic parameter is activated, the WordPress trashcan is
1169	1413	// temporarily de-activated.
1170	1414
1171		- if (FeedWordPress::param( 'fwp_post_delete' ) == 'nuke') :
	1415	+ if (MyPHP::request('fwp_post_delete')=='nuke') :
1172	1416	// Get post ID #
1173		- $post_id = FeedWordPress::param( 'post' );
1174		- if ( ! $post_id) :
1175		- $post_id = FeedWordPress::param( 'post_ID' );
	1417	+ $post_id = MyPHP::request('post');
	1418	+ if (!$post_id) :
	1419	+ $post_id = MyPHP::request('post_ID');
1176	1420	endif;
1177	1421
1178	1422	// Make sure we've got the right nonce and all that.
1179	1423	check_admin_referer('delete-post_' . $post_id);
		@@ -1179,47 +1423,50 @@
1179	1423	check_admin_referer('delete-post_' . $post_id);
1180	1424
1181	1425	// If so, disable the trashcan.
1182	1426	define('EMPTY_TRASH_DAYS', 0);
1183		- elseif ( FeedWordPress::param( 'fwp_post_delete' ) == 'zap' || FeedWordPress::param( 'fwp_post_delete' ) == 'unzap' ) :
	1427	+
	1428	+ elseif (MyPHP::request('fwp_post_delete')=='zap' OR MyPHP::request('fwp_post_delete') == 'unzap') :
1184	1429	// Get post ID #
1185		- $post_id = FeedWordPress::param( 'post' );
1186		- if ( ! $post_id) :
1187		- $post_id = FeedWordPress::param( 'post_ID' );
	1430	+ $post_id = MyPHP::request('post');
	1431	+ if (!$post_id) :
	1432	+ $post_id = MyPHP::request('post_ID');
1188	1433	endif;
1189		-
	1434	+
1190	1435	// Make sure we've got the right nonce and all that
1191	1436	check_admin_referer('delete-post_' . $post_id);
1192	1437
1193	1438	// If so, get ready to intercept the call a little
1194	1439	// further down the line.
	1440	+
1195	1441	define('FEEDWORDPRESS_PREPARE_TO_ZAP', $post_id);
1196		-
	1442	+
1197	1443	endif;
1198	1444
1199	1445	} /* FeedWordPress::admin_api () */
1200	1446
1201	1447	public function all_admin_notices () {
1202		- if (FeedWordPress::param( 'zapped' )) :
1203		- $n = intval( FeedWordPress::param( 'zapped' ) );
	1448	+ if (MyPHP::request('zapped')) :
	1449	+ $n = intval(MyPHP::request('zapped'));
1204	1450	?>
1205		-<div id="message" class="updated"><p><?php print esc_html( $n ); ?> syndicated item<?php print esc_html( $n != 1 ? 's' : '' ); ?> zapped. <strong>These items will not be re-syndicated.</strong> If this was a mistake, you must <strong>immediately</strong> Un-Zap them in the Zapped items section to avoid losing the data.</p></div>
	1451	+<div id="message" class="updated"><p><?php print $n; ?> syndicated item<?php print ($n!=1?'s':''); ?> zapped. <strong>These items will not be re-syndicated.</strong> If this was a mistake, you must <strong>immediately</strong> Un-Zap them in the Zapped items section to avoid losing the data.</p></div>
1206	1452	<?php
1207	1453	endif;
1208		- if ( FeedWordPress::param( 'unzapped' ) ) :
1209		- $n = intval( FeedWordPress::param( 'unzapped' ) );
	1454	+
	1455	+ if (MyPHP::request('unzapped')) :
	1456	+ $n = intval(MyPHP::request('unzapped'));
1210	1457	?>
1211		-<div id="message" class="updated"><p><?php print esc_html( $n ); ?> syndicated item<?php print esc_html( $n != 1 ? 's' : '' ) ?> un-zapped and restored to normal.</p></div>
	1458	+<div id="message" class="updated"><p><?php print $n; ?> syndicated item<?php print ($n!=1?'s':'') ?> un-zapped and restored to normal.</p></div>
1212	1459	<?php
1213	1460	endif;
1214	1461	} /* FeedWordPress::all_admin_notices () */
1215		-
	1462	+
1216	1463	public function process_retirements ($delta) {
1217	1464	update_option('feedwordpress_process_zaps', 1);
1218	1465
1219	1466	return $delta;
1220	1467	}
1221		-
	1468	+
1222	1469	public function feedwordpress_cleanup () {
1223	1470	if (get_option('feedwordpress_process_zaps', null)) :
1224	1471	$q = new WP_Query(array(
1225	1472	'fields' => '_synfrom',
		@@ -1227,34 +1474,34 @@
1227	1474	'ignore_sticky_posts' => true,
1228	1475	'meta_key' => '_feedwordpress_zapped_blank_me',
1229	1476	'meta_value' => 1,
1230	1477	));
1231		-
	1478	+
1232	1479	if ($q->have_posts()) :
1233	1480	foreach ($q->posts as $p) :
1234	1481
1235	1482	$post_id = $p->ID;
1236	1483	$revisions = wp_get_post_revisions($post_id, array("check_enabled" => false));
1237		-
	1484	+
1238	1485	# Now nuke the content of the post & its revisions
1239	1486	set_post_field('post_content', '', $post_id);
1240	1487	set_post_field('post_excerpt', '', $post_id);
1241		-
	1488	+
1242	1489	foreach ($revisions as $rev) :
1243	1490	set_post_field('post_content', '', $rev->ID);
1244	1491	set_post_field('post_excerpt', '', $rev->ID);
1245	1492	endforeach;
1246		-
	1493	+
1247	1494	# Un-tag it for blanking.
1248	1495	delete_post_meta($p->ID, '_feedwordpress_zapped_blank_me');
1249		-
	1496	+
1250	1497	# Don't remove old_status indicator. A later
1251	1498	# update from the feed may cause us to once
1252	1499	# again have some content so we can un-zap.
1253		-
	1500	+
1254	1501	endforeach;
1255	1502	endif;
1256		-
	1503	+
1257	1504	$q = new WP_Query(array(
1258	1505	'fields' => '_synfrom',
1259	1506	'post_status' => 'fwpzapped',
1260	1507	'ignore_sticky_posts' => true,
		@@ -1260,25 +1507,26 @@
1260	1507	'ignore_sticky_posts' => true,
1261	1508	'meta_key' => '_feedwordpress_zapped_blank_me',
1262	1509	'meta_value' => 2,
1263	1510	));
1264		-
	1511	+
1265	1512	if ($q->have_posts()) :
1266	1513	foreach ($q->posts as $p) :
1267	1514	update_post_meta($p->ID, '_feedwordpress_zapped_blank_me', 1);
1268	1515	endforeach;
1269	1516	endif;
1270		-
	1517	+
1271	1518	update_option('feedwordpress_process_zaps', 0);
1272	1519	endif;
1273	1520	} /* FeedWordPress::feedwordpress_cleanup () */
1274		-
	1521	+
1275	1522	public function init () {
	1523	+ global $fwp_path;
1276	1524
1277	1525	// If this is a FeedWordPress admin page, queue up scripts for AJAX
1278	1526	// functions that FWP uses. If it is a display page or a non-FWP admin
1279	1527	// page, don't.
1280		- wp_register_style('feedwordpress-elements', $this->plugin_dir_url( 'assets/css/feedwordpress-elements.css') );
	1528	+ wp_register_style('feedwordpress-elements', plugins_url( '/'.$fwp_path.'/feedwordpress-elements.css') );
1281	1529	if (FeedWordPressSettingsUI::is_admin()) :
1282	1530	// For JavaScript that needs to be generated dynamically
1283	1531	add_action('admin_print_scripts', array('FeedWordPressSettingsUI', 'admin_scripts'));
1284	1532
		@@ -1319,10 +1567,8 @@
1319	1567	add_action('wp_ajax_fwp_feeds', array($this, 'fwp_feeds'));
1320	1568	add_action('wp_ajax_fwp_feedcontents', array($this, 'fwp_feedcontents'));
1321	1569	add_action('wp_ajax_fwp_xpathtest', array($this, 'fwp_xpathtest'));
1322	1570
1323		- // Prepare for future translations... (gwyneth 20210714)
1324		- // add_action('init', array($this, 'load_textdomain');
1325	1571	} /* FeedWordPress::init() */
1326	1572
1327	1573	/**
1328	1574	* FeedWordPress::wp_loaded (): Once all plugin and theme modules have been
		@@ -1335,9 +1581,9 @@
1335	1581	public function wp_loaded () {
1336	1582	$this->clear_cache_magic_url();
1337	1583	$this->update_magic_url();
1338	1584	} /* FeedWordPress::wp_loaded () */
1339		-
	1585	+
1340	1586	/**
1341	1587	* FeedWordPress::cron_schedules(): Filter hook to add WP-Cron schedules
1342	1588	* that plugins like FeedWordPress can use to carry out scheduled events.
1343	1589	*
		@@ -1376,9 +1622,9 @@
1376	1622	exit;
1377	1623	} /* FeedWordPress::fwp_feeds () */
1378	1624
1379	1625	public function fwp_feedcontents () {
1380		- $feed_id = FeedWordPress::param( 'feed_id' );
	1626	+ $feed_id = MyPHP::request('feed_id');
1381	1627
1382	1628	// Let's load up some data from the feed . . .
1383	1629	$feed = $this->subscription($feed_id);
1384	1630	$posts = $feed->live_posts();
		@@ -1409,11 +1655,11 @@
1409	1655	die;
1410	1656	} /* FeedWordPress::fwp_feedcontents () */
1411	1657
1412	1658	public function fwp_xpathtest () {
1413		- $xpath = FeedWordPress::param( 'xpath' );
1414		- $feed_id = FeedWordPress::param( 'feed_id' );
1415		- $post_id = FeedWordPress::param( 'post_id' );
	1659	+ $xpath = MyPHP::request('xpath');
	1660	+ $feed_id = MyPHP::request('feed_id');
	1661	+ $post_id = MyPHP::request('post_id');
1416	1662
1417	1663	$expr = new FeedWordPressParsedPostMeta($xpath);
1418	1664
1419	1665	// Let's load up some data from the feed . . .
		@@ -1419,9 +1665,9 @@
1419	1665	// Let's load up some data from the feed . . .
1420	1666	$feed = $this->subscription($feed_id);
1421	1667	$posts = $feed->live_posts();
1422	1668
1423		- if ( !is_wp_error($posts)) :
	1669	+ if (!is_wp_error($posts)) :
1424	1670	if (strlen($post_id) == 0) :
1425	1671	$post = $posts[0];
1426	1672	else :
1427	1673	$post = null;
		@@ -1470,9 +1716,9 @@
1470	1716	or 'fwpzapped'==$wp_query->post->post_status
1471	1717	) :
1472	1718	do_action('feedwordpress_redirect_retired', $wp_query->post);
1473	1719
1474		- if ( !($template = get_404_template())) :
	1720	+ if (!($template = get_404_template())) :
1475	1721	$template = get_index_template();
1476	1722	endif;
1477	1723	if ($template = apply_filters('template_include', $template)) :
1478	1724	header("HTTP/1.1 410 Gone");
		@@ -1489,10 +1735,10 @@
1489	1735	$eraseLink = MyPHP::url($link, array("fwp_post_delete" => "nuke"));
1490	1736
1491	1737	$caption = apply_filters('feedwordpress_ui_erase_link_caption', __('Erase the record of this post (will be re-syndicated if it still appears on the feed).'));
1492	1738	$linktext = apply_filters('feedwordpress_ui_erase_link_text', __('Erase/Resyndicate'));
1493		-
1494		- $retireClass = null;
	1739	+
	1740	+ $retireClass = NULL;
1495	1741	if ($post->post_status == 'fwpzapped') :
1496	1742	if (count(get_post_meta($post->ID, '_feedwordpress_zapped_blank_me')) > 0) :
1497	1743	$retireCap = 'Un-Zap this syndicated post (so it will appear on the site again)';
1498	1744	$retireText = 'Un-Zap &amp; Restore';
		@@ -1500,17 +1746,17 @@
1500	1746	else :
1501	1747	// No Un-Zap link for posts that have
1502	1748	// been blanked. You'll just have to
1503	1749	// Erase and hope you can resyndicate...
1504		- $retireLink = null;
	1750	+ $retireLink = NULL;
1505	1751	endif;
1506	1752	else :
1507	1753	$retireCap = apply_filters('feedwordpress_ui_zap_link_caption', __('Zap this syndicated post (so it will not be re-syndicated if it still appears on the feed).'));
1508		- $retireText = apply_filters('feedwordpress_ui_zap_link_text', __('Zap/Don&rsquo;t Resyndicate'));
	1754	+ $retireText = apply_filters('feedwordpress_ui_zap_link_text', __('Zap/Don&#8217;t Resyndicate'));
1509	1755	$retireLink = MyPHP::url($link, array("fwp_post_delete" => "zap"));
1510	1756	$retireClass = 'submitdelete';
1511	1757	endif;
1512		-
	1758	+
1513	1759	$keys = array_keys($actions);
1514	1760	$links = array();
1515	1761	foreach ($keys as $key) :
1516	1762	$links[$key] = $actions[$key];
		@@ -1518,9 +1764,9 @@
1518	1764	if ('trash'==$key) :
1519	1765	#$links[$key] = "<a class='submitdelete' title='" . esc_attr( __( 'Move this item to the Trash (will NOT be re-syndicated)' ) ) . "' href='" . get_delete_post_link( $post->ID ) . "'>" . __( 'Trash' ) . "</a>";
1520	1766
1521	1767	// Placeholder.
1522		- if ( !is_null($retireLink)) :
	1768	+ if (!is_null($retireLink)) :
1523	1769	$links['zap trash'] = '';
1524	1770	endif;
1525	1771	$links['delete'] = '';
1526	1772	endif;
		@@ -1525,9 +1771,9 @@
1525	1771	$links['delete'] = '';
1526	1772	endif;
1527	1773	endforeach;
1528	1774
1529		- if ( !is_null($retireLink)) :
	1775	+ if (!is_null($retireLink)) :
1530	1776	$links['zap trash'] = '<a class="'.esc_attr($retireClass).'" title="'.esc_attr(__($retireCap)).'" href="' . $retireLink . '">' . __($retireText) . '</a>';
1531	1777	endif;
1532	1778	$links['delete'] = '<a class="submitdelete" title="'.esc_attr(__($caption)).'" href="' . $eraseLink . '">' . __($linktext) . '</a>';
1533	1779
		@@ -1535,26 +1781,19 @@
1535	1781	endif;
1536	1782	return $actions;
1537	1783	} /* FeedWordPress::row_actions () */
1538	1784
1539		- /**
1540		- * Sets up the FWP dashboard.
1541		- *
1542		- * @global $wp_meta_boxes
1543		- * @uses FeedWordPress::menu_cap
1544		- */
1545		- public function dashboard_setup() {
1546		- /** @var mixed User capability */
	1785	+ public function dashboard_setup () {
1547	1786	$see_it = FeedWordPress::menu_cap();
1548	1787
1549		- if ( current_user_can( $see_it ) ) :
	1788	+ if (current_user_can($see_it)) :
1550	1789	// Get the stylesheet
1551		- wp_enqueue_style( 'feedwordpress-elements' );
	1790	+ wp_enqueue_style('feedwordpress-elements');
1552	1791
1553		- $widget_id = 'feedwordpress_dashboard';
1554		- $widget_name = __( 'Syndicated Sources' );
1555		- $column = 'side';
1556		- $priority = 'core';
	1792	+ $widget_id = 'feedwordpress_dashboard';
	1793	+ $widget_name = __('Syndicated Sources');
	1794	+ $column = 'side';
	1795	+ $priority = 'core';
1557	1796
1558	1797	// I would love to use wp_add_dashboard_widget() here and save
1559	1798	// myself some trouble. But WP 3 does not yet have any way to
1560	1799	// push a dashboard widget onto the side, or to give it a default
		@@ -1561,40 +1800,41 @@
1561	1800	// location.
1562	1801	add_meta_box(
1563	1802	/*id=*/ $widget_id,
1564	1803	/*title=*/ $widget_name,
1565		- /*callback=*/ array( $this, 'dashboard' ),
1566		- /*screen=*/ 'dashboard',
	1804	+ /*callback=*/ array($this, 'dashboard'),
	1805	+ /*page=*/ 'dashboard',
1567	1806	/*context=*/ $column,
1568	1807	/*priority=*/ $priority
1569	1808	);
1570	1809	/*control_callback= array($this, 'dashboard_control') */
1571	1810
1572		- /* This is kind of rude, I know, but the dashboard widget isn't
1573		- * worth much if users don't know that it exists, and I don't
1574		- * know of any better way to reorder the boxen.
1575		- *
1576		- * Gleefully ripped off of codex.wordpress.org/Dashboard_Widgets_API
1577		- */
	1811	+ // This is kind of rude, I know, but the dashboard widget isn't
	1812	+ // worth much if users don't know that it exists, and I don't
	1813	+ // know of any better way to reorder the boxen.
	1814	+ //
	1815	+ // Gleefully ripped off of codex.wordpress.org/Dashboard_Widgets_API
1578	1816
1579		- /** @var mixed Globalizes the metaboxes array, this holds all the widgets for wp-admin. */
	1817	+ // Globalize the metaboxes array, this holds all the widgets for wp-admin
1580	1818	global $wp_meta_boxes;
1581	1819
1582		- /** @var mixed Get the regular dashboard widgets array
1583		- * (which has our new widget already but at the end). */
	1820	+ // Get the regular dashboard widgets array
	1821	+ // (which has our new widget already but at the end)
	1822	+
1584	1823	$normal_dashboard = $wp_meta_boxes['dashboard'][$column][$priority];
1585	1824
1586	1825	// Backup and delete our new dashbaord widget from the end of the array
1587		- if ( isset( $normal_dashboard[ $widget_id ] ) ) :
	1826	+ if (isset($normal_dashboard[$widget_id])) :
1588	1827	$backup = array();
1589		- $backup[ $widget_id ] = $normal_dashboard[ $widget_id ];
1590		- unset( $normal_dashboard[ $widget_id ] );
	1828	+ $backup[$widget_id] = $normal_dashboard[$widget_id];
	1829	+ unset($normal_dashboard[$widget_id]);
1591	1830
1592		- /** @var array Merge the two arrays together so our widget is at the beginning. */
1593		- $sorted_dashboard = array_merge( $backup, $normal_dashboard );
	1831	+ // Merge the two arrays together so our widget is at the
	1832	+ // beginning
	1833	+ $sorted_dashboard = array_merge($backup, $normal_dashboard);
1594	1834
1595		- // Save the sorted array back into the original €es
1596		- $wp_meta_boxes['dashboard'][ $column ][ $priority ] = $sorted_dashboard;
	1835	+ // Save the sorted array back into the original metaboxes
	1836	+ $wp_meta_boxes['dashboard'][$column][$priority] = $sorted_dashboard;
1597	1837	endif;
1598	1838	endif;
1599	1839	} /* FeedWordPress::dashboard_setup () */
1600	1840
		@@ -1606,9 +1846,9 @@
1606	1846	public function user_can_richedit ($rich_edit) {
1607	1847
1608	1848	$post = new FeedWordPressLocalPost;
1609	1849
1610		- if ( ! $post->is_exposed_to_formatting_filters()) :
	1850	+ if (!$post->is_exposed_to_formatting_filters()) :
1611	1851	// Disable visual editor and only allow operations
1612	1852	// directly on HTML if post is bypassing fmt filters
1613	1853	# $rich_edit = false;
1614	1854	endif;
		@@ -1623,9 +1863,9 @@
1623	1863	endif;
1624	1864	} /* FeedWordPress::clear_cache_magic_url() */
1625	1865
1626	1866	public function clear_cache_requested () {
1627		- return FeedWordPress::param( 'clear_cache' );
	1867	+ return MyPHP::request('clear_cache');
1628	1868	} /* FeedWordPress::clear_cache_requested() */
1629	1869
1630	1870	public function update_magic_url () {
1631	1871	global $wpdb;
		@@ -1632,19 +1872,20 @@
1632	1872
1633	1873	// Explicit update request in the HTTP request (e.g. from a cron job)
1634	1874	if (self::update_requested()) :
1635	1875	/*DBG*/ header("Content-Type: text/plain");
1636		- $this->update_hooked = "Initiating a CRON JOB CHECK-IN ON UPDATE SCHEDULE due to URL parameter = " . trim( $this->val( FeedWordPress::param('update_feedwordpress' ) ) );
	1876	+
	1877	+ $this->update_hooked = "Initiating a CRON JOB CHECK-IN ON UPDATE SCHEDULE due to URL parameter = ".trim($this->val($_REQUEST['update_feedwordpress']));
1637	1878
1638	1879	$this->update($this->update_requested_url());
1639	1880
1640		- if (FEEDWORDPRESS_DEBUG and is_array($wpdb->queries) and count($wpdb->queries) > 0) :
	1881	+ if (FEEDWORDPRESS_DEBUG and count($wpdb->queries) > 0) :
1641	1882	$mysqlTime = 0.0;
1642	1883	$byTime = array();
1643	1884	foreach ($wpdb->queries as $query) :
1644	1885	$time = $query[1] * 1000000.0;
1645	1886	$mysqlTime += $query[1];
1646		- if ( !isset($byTime[$time])) : $byTime[$time] = array(); endif;
	1887	+ if (!isset($byTime[$time])) : $byTime[$time] = array(); endif;
1647	1888	$byTime[$time][] = $query[0]. ' // STACK: ' . $query[2];
1648	1889	endforeach;
1649	1890	krsort($byTime);
1650	1891
		@@ -1649,12 +1890,12 @@
1649	1890	krsort($byTime);
1650	1891
1651	1892	foreach ($byTime as $time => $querySet) :
1652	1893	foreach ($querySet as $query) :
1653		- printf( '[%s ms] %s', esc_html( sprintf( '%4.4f', $time/1000.0 ) ), esc_html( $query ) ) . "\n";
	1894	+ print "[".(sprintf('%4.4f', $time/1000.0)) . "ms] $query\n";
1654	1895	endforeach;
1655	1896	endforeach;
1656		- echo esc_html( self::log_prefix()."$wpdb->num_queries queries. $mysqlTime seconds in MySQL. Total of " ); timer_stop(1); print " seconds.";
	1897	+ echo self::log_prefix()."$wpdb->num_queries queries. $mysqlTime seconds in MySQL. Total of "; timer_stop(1); print " seconds.";
1657	1898	endif;
1658	1899
1659	1900	debug_out_feedwordpress_footer();
1660	1901
		@@ -1664,20 +1905,17 @@
1664	1905	endif;
1665	1906	} /* FeedWordPress::update_magic_url () */
1666	1907
1667	1908	public static function update_requested () {
1668		- return FeedWordPress::param( 'update_feedwordpress' );
	1909	+ return MyPHP::request('update_feedwordpress');
1669	1910	} /* FeedWordPress::update_requested() */
1670		-
	1911	+
1671	1912	public function update_requested_url () {
1672	1913	$ret = null;
1673	1914
1674		- $uf = FeedWordPress::update_requested();
1675		- if (
1676		- ( '*' == $uf )
1677		- || ( preg_match( '|^[a-z]+://.*|i', $uf ) )
1678		- ) :
1679		- $ret = $uf;
	1915	+ if (($_REQUEST['update_feedwordpress']=='*')
	1916	+ or (preg_match('|^[a-z]+://.*|i', $_REQUEST['update_feedwordpress']))) :
	1917	+ $ret = $_REQUEST['update_feedwordpress'];
1680	1918	endif;
1681	1919
1682	1920	return $ret;
1683	1921	} /* FeedWordPress::update_requested_url() */
		@@ -1732,9 +1970,9 @@
1732	1970	*/
1733	1971	public static function syndicate_link ($name, $uri, $rss) {
1734	1972	// Get the category ID#
1735	1973	$cat_id = FeedWordPress::link_category_id();
1736		- if ( !is_wp_error($cat_id)) :
	1974	+ if (!is_wp_error($cat_id)) :
1737	1975	$link_category = array($cat_id);
1738	1976	else :
1739	1977	$link_category = array();
1740	1978	endif;
		@@ -1739,9 +1977,9 @@
1739	1977	$link_category = array();
1740	1978	endif;
1741	1979
1742	1980	// WordPress gets cranky if there's no homepage URI
1743		- if ( !is_string($uri) or strlen($uri)<1) : $uri = $rss; endif;
	1981	+ if (!is_string($uri) or strlen($uri)<1) : $uri = $rss; endif;
1744	1982
1745	1983	// Check if this feed URL is already being syndicated.
1746	1984	$link_id = wp_insert_link(/*linkdata=*/ array(
1747	1985	"link_id" => FeedWordPress::find_link($rss), // insert if nothing was found; else update
		@@ -1756,9 +1994,9 @@
1756	1994	} /* function FeedWordPress::syndicate_link() */
1757	1995
1758	1996	static function syndicated_status ($what, $default) {
1759	1997	$ret = get_option("feedwordpress_syndicated_{$what}_status");
1760		- if ( ! $ret) :
	1998	+ if (!$ret) :
1761	1999	$ret = $default;
1762	2000	endif;
1763	2001	return $ret;
1764	2002	} /* FeedWordPress::syndicated_status() */
		@@ -1786,11 +2024,11 @@
1786	2024	return $ret;
1787	2025
1788	2026	} /* FeedWordPress::null_email_set () */
1789	2027
1790		- public static function is_null_email( $email ) {
1791		- $ret = in_array( strtolower( trim( $email ) ), FeedWordPress::null_email_set() );
1792		- $ret = apply_filters( 'syndicated_item_author_is_null_email', $ret, $email );
	2028	+ public static function is_null_email ($email) {
	2029	+ $ret = in_array(strtolower(trim($email)), FeedWordPress::null_email_set());
	2030	+ $ret = apply_filters('syndicated_item_author_is_null_email', $ret, $email);
1793	2031	return $ret;
1794	2032	} /* FeedWordPress::is_null_email () */
1795	2033
1796	2034	public static function use_aggregator_source_data () {
		@@ -1810,9 +2048,9 @@
1810	2048	} /* FeedWordPress::munge_permalinks() */
1811	2049
1812	2050	public static function syndicated_links ($args = array()) {
1813	2051	$contributors = FeedWordPress::link_category_id();
1814		- if ( !is_wp_error($contributors)) :
	2052	+ if (!is_wp_error($contributors)) :
1815	2053	$links = get_bookmarks(array_merge(
1816	2054	array("category" => $contributors),
1817	2055	$args
1818	2056	));
		@@ -1823,12 +2061,14 @@
1823	2061	return $links;
1824	2062	} /* FeedWordPress::syndicated_links() */
1825	2063
1826	2064	public static function link_category_id () {
	2065	+ global $wpdb, $wp_db_version;
	2066	+
1827	2067	$cat_id = get_option('feedwordpress_cat_id');
1828	2068
1829	2069	// If we don't yet have the category ID stored, search by name
1830		- if ( ! $cat_id) :
	2070	+ if (!$cat_id) :
1831	2071	$cat_id = FeedWordPressCompatibility::link_category_id(DEFAULT_SYNDICATION_CATEGORY);
1832	2072
1833	2073	if ($cat_id) :
1834	2074	// We found it; let's stamp it.
		@@ -1841,11 +2081,11 @@
1841	2081	endif;
1842	2082
1843	2083	// If we could not find an appropriate link category,
1844	2084	// make a new one for ourselves.
1845		- if ( ! $cat_id) :
	2085	+ if (!$cat_id) :
1846	2086	$cat_id = FeedWordPressCompatibility::insert_link_category(DEFAULT_SYNDICATION_CATEGORY);
1847		- if ( !is_wp_error($cat_id)) :
	2087	+ if (!is_wp_error($cat_id)) :
1848	2088	// Stamp it
1849	2089	update_option('feedwordpress_cat_id', $cat_id);
1850	2090	endif;
1851	2091	endif;
		@@ -1854,9 +2094,11 @@
1854	2094	} /* FeedWordPress::link_category_id() */
1855	2095
1856	2096	# Upgrades and maintenance...
1857	2097	static function needs_upgrade () {
1858		- $fwp_db_version = get_option('feedwordpress_version', null);
	2098	+
	2099	+ global $wpdb;
	2100	+ $fwp_db_version = get_option('feedwordpress_version', NULL);
1859	2101	$ret = false; // innocent until proven guilty
1860	2102	if (is_null($fwp_db_version) or ($fwp_db_version < FEEDWORDPRESS_VERSION)) :
1861	2103
1862	2104	// This is an older version or a fresh install. Does it require a database
		@@ -1914,10 +2156,11 @@
1914	2156	endif;
1915	2157	return $ret;
1916	2158	} /* FeedWordPress::needs_upgrade () */
1917	2159
1918		- static function upgrade_database ($from = null)
1919		- {
	2160	+ static function upgrade_database ($from = NULL) {
	2161	+ global $wpdb;
	2162	+
1920	2163	if (is_null($from) or $from <= 0.96) : $from = 0.96; endif;
1921	2164
1922	2165	switch ($from) :
1923	2166	case 0.96:
		@@ -1985,9 +2228,9 @@
1985	2228	// Allow user to change default feed-fetch timeout with a global setting.
1986	2229	// Props Erigami Scholey-Fuller <http://www.piepalace.ca/blog/2010/11/feedwordpress-broke-my-heart.html>
1987	2230	$timeout = FeedWordPress::fetch_timeout();
1988	2231
1989		- if ( !is_array($params)) :
	2232	+ if (!is_array($params)) :
1990	2233	$force_feed = $params;
1991	2234	else : // Parameter array
1992	2235	$args = wp_parse_args(array(
1993	2236	'force_feed' => $force_feed,
		@@ -1998,17 +2241,17 @@
1998	2241	endif;
1999	2242	$timeout = intval($timeout);
2000	2243
2001	2244	$pie_class = apply_filters('feedwordpress_simplepie_class', 'FeedWordPie');
2002		- $cache_class = apply_filters('feedwordpress_cache_class', 'FeedWordPie_Cache');
2003		- $file_class = apply_filters('feedwordpress_file_class', 'FeedWordPie_File');
2004		- $parser_class = apply_filters('feedwordpress_parser_class', 'FeedWordPie_Parser');
	2245	+ $cache_class = apply_filters('feedwordpress_cache_class', 'WP_Feed_Cache');
	2246	+ $file_class = apply_filters('feedwordpress_file_class', 'FeedWordPress_File');
	2247	+ $parser_class = apply_filters('feedwordpress_parser_class', 'FeedWordPress_Parser');
2005	2248	$item_class = apply_filters('feedwordpress_item_class', 'FeedWordPie_Item');
2006		- $sniffer_class = apply_filters('feedwordpress_sniffer_class', 'FeedWordPie_Content_Type_Sniffer');
	2249	+ $sniffer_class = apply_filters('feedwordpress_sniffer_class', 'FeedWordPress_Content_Type_Sniffer');
2007	2250
2008	2251	$feed = new $pie_class;
2009	2252	$feed->set_feed_url($url);
2010		- $feed->registry->register('Cache', $cache_class);
	2253	+ $feed->set_cache_class($cache_class);
2011	2254	$feed->set_timeout($timeout);
2012	2255
2013	2256	$feed->set_content_type_sniffer_class($sniffer_class);
2014	2257	$feed->set_file_class($file_class);
		@@ -2056,10 +2299,10 @@
2056	2299	$params = wp_parse_args($params, array(
2057	2300	"cache" => true,
2058	2301	));
2059	2302
2060		- $duration = null;
2061		- if ( ! $params['cache']) :
	2303	+ $duration = NULL;
	2304	+ if (!$params['cache']) :
2062	2305	$duration = 0;
2063	2306	elseif (defined('FEEDWORDPRESS_CACHE_AGE')) :
2064	2307	$duration = FEEDWORDPRESS_CACHE_AGE;
2065	2308	endif;
		@@ -2080,70 +2323,39 @@
2080	2323	return $duration;
2081	2324	} /* FeedWordPress::cache_lifetime () */
2082	2325
2083	2326	# Utility functions for handling text settings
2084		- static function get_field( $f, $setting = null ) {
2085		-
2086		- $ret = $f;
2087		- if ( ! is_null( $setting ) ) :
2088		- $ret = null;
2089		- if ( array_key_exists( $setting, $f ) ) :
2090		- $ret = $f[ $setting ];
2091		- endif;
2092		- endif;
2093		- return $ret;
2094		-
2095		- } /* FeedWordPress::get_field () */
2096		-
2097		- static function negative ($f, $setting = null) {
	2327	+ static function negative ($f, $setting) {
2098	2328	$nego = array ('n', 'no', 'f', 'false');
2099		- $q = self::get_field( $f, $setting );
2100		- return in_array( strtolower( trim( $q ) ), $nego );
	2329	+ return (isset($f[$setting]) and in_array(strtolower($f[$setting]), $nego));
2101	2330	} /* FeedWordPress::negative () */
2102	2331
2103		- static function affirmative ($f, $setting = null) {
2104		- // Defining possible affirmative values
2105		- $affirmo = [ 'y', 'yes', 't', 'true', 1 ];
2106		-
2107		- // Get the field value (presumably from some form or other input)
2108		- $q = self::get_field( $f, $setting );
2109		-
2110		- // Ensure $q is treated properly even if it's null or not set
2111		- if ( null === $q ) {
2112		- return false; // Or you can return false or other fallback as needed
2113		- }
	2332	+ static function affirmative ($f, $setting) {
	2333	+ $affirmo = array ('y', 'yes', 't', 'true', 1);
	2334	+ return (isset($f[$setting]) and in_array(strtolower($f[$setting]), $affirmo));
	2335	+ } /* FeedWordPress::affirmative () */
2114	2336
2115		- // Check if the value, after trimming and converting to lowercase, is in the affirmative array
2116		- return in_array( strtolower( trim( $q ) ), $affirmo, true ); // The third argument `true` ensures strict type checking
2117		- } /* FeedWordPress::affirmative () */
	2337	+ # Internal debugging functions
2118	2338
2119		- /**
2120		- * Internal debugging functions.
2121		- *
2122		- * @todo radgeek needs to document this better. What levels exist, and
2123		- * how/where are they defined? (gwyneth 20230919)
2124		- *
2125		- * @global $feedwordpress_admin_footer
2126		- */
2127		- static function diagnostic( $level, $out, $persist = null, $since = null, $mostRecent = null ) {
	2339	+ static function diagnostic ($level, $out, $persist = NULL, $since = NULL, $mostRecent = NULL) {
2128	2340	global $feedwordpress_admin_footer;
2129	2341
2130		- $output = (array) get_option( 'feedwordpress_diagnostics_output', array() );
2131		- $dlog = get_option( 'feedwordpress_diagnostics_log', array() );
	2342	+ $output = get_option('feedwordpress_diagnostics_output', array());
	2343	+ $dlog = get_option('feedwordpress_diagnostics_log', array());
2132	2344
2133		- $diagnostic_nesting = count( explode( ":", $level ) );
	2345	+ $diagnostic_nesting = count(explode(":", $level));
2134	2346
2135	2347	if (FeedWordPressDiagnostic::is_on($level)) :
2136	2348	foreach ($output as $method) :
2137	2349	switch ($method) :
2138	2350	case 'echo' :
2139		- if ( !( self::update_requested() || wp_doing_ajax() ) ) :
2140		- echo "<div><pre><strong>Diag".esc_html( str_repeat('====', $diagnostic_nesting-1) ).'|</strong> '. esc_html( $out )."</pre></div>\n";
	2351	+ if (!self::update_requested()) :
	2352	+ echo "<div><pre><strong>Diag".str_repeat('====', $diagnostic_nesting-1).'|</strong> '.$out."</pre></div>\n";
2141	2353	endif;
2142	2354	break;
2143	2355	case 'echo_in_cronjob' :
2144	2356	if (self::update_requested()) :
2145		- echo esc_html( self::log_prefix() ) . ' ' . esc_html( $out ) . "\n";
	2357	+ echo self::log_prefix()." ".$out."\n";
2146	2358	endif;
2147	2359	break;
2148	2360	case 'admin_footer' :
2149	2361	$feedwordpress_admin_footer[] = $out;
		@@ -2148,9 +2360,9 @@
2148	2360	case 'admin_footer' :
2149	2361	$feedwordpress_admin_footer[] = $out;
2150	2362	break;
2151	2363	case 'error_log' :
2152		- error_log(self::log_prefix() . ' ' . $out);
	2364	+ error_log(self::log_prefix().' '.$out);
2153	2365	break;
2154	2366	case 'email' :
2155	2367
2156	2368	if (is_null($persist)) :
		@@ -2162,10 +2374,10 @@
2162	2374	$hook = md5($level."\n".$persist);
2163	2375	$line = array("Since" => $since, "Message" => $out, "Most Recent" => $mostRecent);
2164	2376	endif;
2165	2377
2166		- if ( !isset($dlog['mesg'])) : $dlog['mesg'] = array(); endif;
2167		- if ( !isset($dlog['mesg'][$sect])) : $dlog['mesg'][$sect] = array(); endif;
	2378	+ if (!isset($dlog['mesg'])) : $dlog['mesg'] = array(); endif;
	2379	+ if (!isset($dlog['mesg'][$sect])) : $dlog['mesg'][$sect] = array(); endif;
2168	2380
2169	2381	$dlog['mesg'][$sect][$hook] = $line;
2170	2382	endswitch;
2171	2383	endforeach;
		@@ -2170,14 +2382,14 @@
2170	2382	endswitch;
2171	2383	endforeach;
2172	2384	endif;
2173	2385
2174		- update_option( 'feedwordpress_diagnostics_log', $dlog );
2175		- } /* FeedWordPress::diagnostic() */
	2386	+ update_option('feedwordpress_diagnostics_log', $dlog);
	2387	+ } /* FeedWordPress::diagnostic () */
2176	2388
2177	2389	public function email_diagnostics_override () {
2178		- return ( $this->has_secret() and ! ! FeedWordPress::param( 'feedwordpress_email_diagnostics' ) );
2179		- } /* FeedWordPress::email_diagnostics_override() */
	2390	+ return ($this->has_secret() and isset($_REQUEST['feedwordpress_email_diagnostics']) and !!$_REQUEST['feedwordpress_email_diagnostics']);
	2391	+ } /* FeedWordPress::email_diagnostics_override () */
2180	2392
2181	2393	public function has_emailed_diagnostics ($dlog) {
2182	2394	$ret = false;
2183	2395	if ($this->email_diagnostics_override()
		@@ -2184,9 +2396,9 @@
2184	2396	or (isset($dlog['schedule']) and isset($dlog['schedule']['last']))) :
2185	2397	$ret = true;
2186	2398	endif;
2187	2399	return $ret;
2188		- } /* FeedWordPress::has_emailed_diagnostics() */
	2400	+ } /* FeedWordPress::has_emailed_diagnostics () */
2189	2401
2190	2402	public function ready_to_email_diagnostics ($dlog) {
2191	2403	$ret = false;
2192	2404	if ($this->email_diagnostics_override()
		@@ -2193,19 +2405,14 @@
2193	2405	or (time() > ($dlog['schedule']['last'] + $dlog['schedule']['freq']))) :
2194	2406	$ret = true;
2195	2407	endif;
2196	2408	return $ret;
2197		- } /* FeedWordPress::ready_to_email_diagnostics() */
	2409	+ } /* FeedWordPress::ready_to_email_diagnostics () */
2198	2410
2199		- /**
2200		- * Emails a diagnostic log to the WP administrator.
2201		- *
2202		- * @param Array $params See @wp_parse_args()
2203		- */
2204		- public function email_diagnostic_log( $params = array() ) {
2205		- $params = wp_parse_args( $params, array(
2206		- "force" => false,
2207		- ) );
	2411	+ public function email_diagnostic_log ($params = array()) {
	2412	+ $params = wp_parse_args($params, array(
	2413	+ "force" => false,
	2414	+ ));
2208	2415
2209	2416	$dlog = get_option('feedwordpress_diagnostics_log', array());
2210	2417
2211	2418	if ($this->has_emailed_diagnostics($dlog)) :
		@@ -2211,10 +2418,10 @@
2211	2418	if ($this->has_emailed_diagnostics($dlog)) :
2212	2419	if ($this->ready_to_email_diagnostics($dlog)) :
2213	2420	// No news is good news; only send if
2214	2421	// there are some messages to send.
2215		- $body = null;
2216		- if ( !isset($dlog['mesg'])) : $dlog['mesg'] = array(); endif;
	2422	+ $body = NULL;
	2423	+ if (!isset($dlog['mesg'])) : $dlog['mesg'] = array(); endif;
2217	2424
2218	2425	foreach ($dlog['mesg'] as $sect => $mesgs) :
2219	2426	if (count($mesgs) > 0) :
2220	2427	if (is_null($body)) : $body = ''; endif;
		@@ -2222,9 +2429,9 @@
2222	2429	$paradigm = reset($mesgs);
2223	2430	$body .= "<h2>".ucfirst($sect)." issues</h2>\n"
2224	2431	."<table>\n"
2225	2432	."<thead><tr>\n";
2226		- foreach ( $paradigm as $col => $value ) :
	2433	+ foreach ($paradigm as $col => $value) :
2227	2434	$body .= '<th scope="col">'.$col."</th>\n";
2228	2435	endforeach;
2229	2436	$body .= "</tr></thead>\n"
2230	2437	."<tbody>\n";
		@@ -2235,9 +2442,9 @@
2235	2442	if (is_numeric($cell)) :
2236	2443	$cell = date('j-M-y, h:i a', $cell);
2237	2444	endif;
2238	2445	$class = strtolower(preg_replace('/\s+/', '-', $col));
2239		- $body .= "<td class=\"$class\">{$cell}</td>";
	2446	+ $body .= "<td class=\"$class\">${cell}</td>";
2240	2447	endforeach;
2241	2448	$body .= "</tr>\n";
2242	2449	endforeach;
2243	2450
		@@ -2245,9 +2452,9 @@
2245	2452	endif;
2246	2453	endforeach;
2247	2454
2248	2455	$body = apply_filters('feedwordpress_diagnostic_email_body', $body, $dlog);
2249		- if ( !is_null($body)) :
	2456	+ if (!is_null($body)) :
2250	2457	$home = feedwordpress_display_url(get_bloginfo('url'));
2251	2458	$subj = apply_filters('feedwordpress_diagnostic_email_subject', $home . " syndication issues", $dlog);
2252	2459	$agent = 'FeedWordPress '.FEEDWORDPRESS_VERSION;
2253	2460	$body = <<<EOMAIL
		@@ -2281,16 +2488,10 @@
2281	2488	$recipients = array($ref[1]);
2282	2489
2283	2490	// userid
2284	2491	elseif (preg_match('/^user:(.*)$/', $ded, $ref)) :
2285		- if ( is_numeric( $ref[1] ) and function_exists( 'get_userdata' ) ) :
2286		- $userdata = get_userdata( (int) $ref[1]) ;
2287		- $recipients = array( $userdata->user_email );
2288		- else :
2289		- // get_userdata() might not have been loaded yet, so send
2290		- // to admins instead. (gwyneth 20230901)
2291		- $recipients = FeedWordPressDiagnostic::admin_emails();
2292		- endif;
	2492	+ $userdata = get_userdata((int) $ref[1]);
	2493	+ $recipients = array($userdata->user_email);
2293	2494
2294	2495	// admins
2295	2496	else :
2296	2497	$recipients = FeedWordPressDiagnostic::admin_emails();
		@@ -2296,12 +2497,12 @@
2296	2497	$recipients = FeedWordPressDiagnostic::admin_emails();
2297	2498	endif;
2298	2499
2299	2500	$mesgId = 'feedwordpress+'.time().'@'.$home;
2300		- $parentId = get_option('feedwordpress_diagnostics_email_root_message_id', null);
	2501	+ $parentId = get_option('feedwordpress_diagnostics_email_root_message_id', NULL);
2301	2502
2302	2503	$head = array("Message-ID: <$mesgId>");
2303		- if ( !is_null($parentId)) :
	2504	+ if (!is_null($parentId)) :
2304	2505	// We've already sent off a diagnostic message in the past. Let's do some
2305	2506	// magic to help with threading, in the hopes that all diagnostic messages
2306	2507	// get threaded together.
2307	2508	$head[] = "References: <$parentId>";
		@@ -2333,13 +2534,12 @@
2333	2534	'last' => time(),
2334	2535	);
2335	2536	endif;
2336	2537
2337		- update_option( 'feedwordpress_diagnostics_log', $dlog );
	2538	+ update_option('feedwordpress_diagnostics_log', $dlog);
2338	2539	} /* FeedWordPress::email_diagnostic_log () */
2339	2540
2340		-
2341		- static function allow_html_mail() {
	2541	+ static function allow_html_mail () {
2342	2542	return 'text/html';
2343	2543	} /* FeedWordPress::allow_html_mail () */
2344	2544
2345	2545	static function admin_footer () {
		@@ -2344,18 +2544,12 @@
2344	2544
2345	2545	static function admin_footer () {
2346	2546	global $feedwordpress_admin_footer;
2347	2547	foreach ($feedwordpress_admin_footer as $line) :
2348		- echo '<div><pre>' . esc_html( $line ) . '</pre></div>';
	2548	+ echo '<div><pre>'.$line.'</pre></div>';
2349	2549	endforeach;
2350	2550	} /* FeedWordPress::admin_footer () */
2351	2551
2352		- /**
2353		- * Returns the log prefix, optionally with a date.
2354		- *
2355		- * @param boolean $date If true, a date timestamp is added to the prefix.
2356		- * @return string Generated log prefix.
2357		- */
2358	2552	static function log_prefix ($date = false) {
2359	2553	$home = get_bloginfo('url');
2360	2554	$prefix = '['.feedwordpress_display_url($home).'] [feedwordpress] ';
2361	2555	if ($date) :
		@@ -2363,14 +2557,8 @@
2363	2557	endif;
2364	2558	return $prefix;
2365	2559	} /* FeedWordPress::log_prefix () */
2366	2560
2367		- /**
2368		- * Returns the menu capacity value.
2369		- *
2370		- * @param boolean $sub If true, we're on a menu sublevel.
2371		- * @return mixed Returns the capacity.
2372		- */
2373	2561	static function menu_cap ($sub = false) {
2374	2562	if ($sub) :
2375	2563	$cap = apply_filters('feedwordpress_menu_settings_capacity', 'manage_options');
2376	2564	else :
		@@ -2378,19 +2566,8 @@
2378	2566	endif;
2379	2567	return $cap;
2380	2568	} /* FeedWordPress::menu_cap () */
2381	2569
2382		- public function plugin_dir_path ($path = '') {
2383		- $dir = plugin_dir_path( __FILE__ );
2384		- $file_path = "{$dir}{$path}";
2385		- return apply_filters( "feedwordpress_plugin_dir_path", $file_path );
2386		- } /* FeedWordPress::plugin_dir_path () */
2387		-
2388		- public function plugin_dir_url ($path = '') {
2389		- $url_path = plugins_url( $path, __FILE__ );
2390		- return apply_filters( "feedwordpress_plugin_dir_url", $url_path );
2391		- } /* FeedWordPRess::plugin_dir_url () */
2392		-
2393	2570	static function path ($filename = '') {
2394	2571	global $fwp_path;
2395	2572
2396	2573	$path = $fwp_path;
		@@ -2396,9 +2573,8 @@
2396	2573	$path = $fwp_path;
2397	2574	if (strlen($filename) > 0) :
2398	2575	$path .= '/'.$filename;
2399	2576	endif;
2400		-
2401	2577	return $path;
2402	2578	} /* FeedWordPress::path () */
2403	2579
2404	2580	// -- DEPRCATED UTILITY FUNCTIONS -------------------------------------
		@@ -2407,51 +2583,26 @@
2407	2583	// but for the last several versions have been kept here for backward
2408	2584	// compatibility with add-ons, older code, etc. Maybe someday they
2409	2585	// will go away.
2410	2586	// -------------------------------------------------------------------
2411		- static function param( $key, $type = 'REQUEST', $default = null, $sanitizer = null ) {
2412		- return self::sanitized_parameter( MyPHP::param( $key, $default, $type ), $sanitizer );
	2587	+ static function param ($key, $type = 'REQUEST', $default = NULL) {
	2588	+ return MyPHP::param($key, $default, $type);
2413	2589	} /* FeedWordPress::param () */
2414	2590
2415		- static function post( $key, $default = null, $sanitizer = null ) {
2416		- return self::sanitized_parameter( MyPHP::post( $key, $default ), $sanitizer );
	2591	+ static function post ($key, $default = NULL) {
	2592	+ return MyPHP::post($key, $default);
2417	2593	} /* FeedWordPress::post () */
2418	2594
2419		- static function shallow_sanitize( $item, $sanitizer = null ) {
2420		- if ( $sanitizer == 'raw' ) :
2421		- $value = $item;
2422		- elseif ( $sanitizer == 'textarea' ) :
2423		- $value = sanitize_textarea_field( $item );
2424		- else :
2425		- $value = sanitize_text_field( $item );
2426		- endif;
2427		- return $value;
2428		- }
2429		-
2430		- static function sanitized_parameter( $value, $sanitizer = null ) {
2431		- if ( $sanitizer === 'raw' || is_scalar( $value ) ) :
2432		- $ret = self::shallow_sanitize( $value, $sanitizer );
2433		- elseif ( is_array( $value ) ) :
2434		- $ret = array();
2435		- foreach ( $value as $key => $item ) :
2436		- $ret[ $key ] = self::sanitized_parameter( $item, $sanitizer );
2437		- endforeach;
2438		- else :
2439		- $ret = null; // "Sanitized" objects or resources currently get nothing.
2440		- endif;
2441		- return $ret;
2442		- }
2443		-
2444	2595	static function val ($v, $no_newlines = false) {
2445	2596	return MyPHP::val($v, $no_newlines);
2446	2597	} /* FeedWordPress::val () */
2447	2598
2448		- static function critical_bug ($varname, $var, $line, $file = null) {
	2599	+ static function critical_bug ($varname, $var, $line, $file = NULL) {
2449	2600	FeedWordPressDiagnostic::critical_bug($varname, $var, $line, $file);
2450	2601	} /* FeedWordPress::critical_bug () */
2451	2602
2452		- static function noncritical_bug ($varname, $var, $line, $file = null) {
2453		- FeedWordPressDiagnostic::noncritical_bug($varname, $var, $line, $file);
	2603	+ static function noncritical_bug ($varname, $var, $line, $file = NULL) {
	2604	+ FeedWordPressDiagnostic::noncritical_bug($varname, $var, $line, $file);
2454	2605	} /* FeedWordPress::noncritical_bug () */
2455	2606
2456	2607	static function diagnostic_on ($level) {
2457	2608	return FeedWordPressDiagnostic::is_on($level);
		@@ -2461,40 +2612,29 @@
2461	2612
2462	2613	$feedwordpress_admin_footer = array();
2463	2614
2464	2615	// take your best guess at the realname and e-mail, given a string
2465		-define( 'FWP_REGEX_EMAIL_ADDY', '([^@"(<\s]+@[^"@(<\s]+\.[^"@(<\s]+)' );
2466		-define( 'FWP_REGEX_EMAIL_NAME', '("([^"]*)"|([^"<(]+\S))' );
2467		-define( 'FWP_REGEX_EMAIL_POSTFIX_NAME', '/^\s*' . FWP_REGEX_EMAIL_ADDY . '\s+\(' . FWP_REGEX_EMAIL_NAME . '\)\s*$/' );
2468		-define( 'FWP_REGEX_EMAIL_PREFIX_NAME', '/^\s*' . FWP_REGEX_EMAIL_NAME . '\s*<' . FWP_REGEX_EMAIL_ADDY . '>\s*$/' );
2469		-define( 'FWP_REGEX_EMAIL_JUST_ADDY', '/^\s*' . FWP_REGEX_EMAIL_ADDY . '\s*$/' );
2470		-define( 'FWP_REGEX_EMAIL_JUST_NAME', '/^\s*' . FWP_REGEX_EMAIL_NAME . '\s*$/' );
	2616	+define('FWP_REGEX_EMAIL_ADDY', '([^@"(<\s]+@[^"@(<\s]+\.[^"@(<\s]+)');
	2617	+define('FWP_REGEX_EMAIL_NAME', '("([^"]*)"|([^"<(]+\S))');
	2618	+define('FWP_REGEX_EMAIL_POSTFIX_NAME', '/^\s*'.FWP_REGEX_EMAIL_ADDY."\s+\(".FWP_REGEX_EMAIL_NAME.'\)\s*$/');
	2619	+define('FWP_REGEX_EMAIL_PREFIX_NAME', '/^\s*'.FWP_REGEX_EMAIL_NAME.'\s*<'.FWP_REGEX_EMAIL_ADDY.'>\s*$/');
	2620	+define('FWP_REGEX_EMAIL_JUST_ADDY', '/^\s*'.FWP_REGEX_EMAIL_ADDY.'\s*$/');
	2621	+define('FWP_REGEX_EMAIL_JUST_NAME', '/^\s*'.FWP_REGEX_EMAIL_NAME.'\s*$/');
2471	2622
2472		-/**
2473		- * Parses an email address that includes the real name as well.
2474		- *
2475		- * @param string $email Email address to parse.
2476		- *
2477		- * @return array Associative array with 'name' and 'email' as fields (each may be null).
2478		- */
2479		-function parse_email_with_realname( $email ) {
2480		- $ret = array(
2481		- 'name' => null,
2482		- 'email' => null
2483		- ); // avoid uninitialized variables for return values, this will generate a notice/warning - and one day, an error! (gwyneth 20210714)
2484		-
2485		- if ( preg_match( FWP_REGEX_EMAIL_POSTFIX_NAME, $email, $matches ) ) :
2486		- ( $ret['name'] = $matches[3] ) || ( $ret['name'] = $matches[2] );
	2623	+function parse_email_with_realname ($email) {
	2624	+ if (preg_match(FWP_REGEX_EMAIL_POSTFIX_NAME, $email, $matches)) :
	2625	+ ($ret['name'] = $matches[3]) or ($ret['name'] = $matches[2]);
2487	2626	$ret['email'] = $matches[1];
2488		- elseif ( preg_match( FWP_REGEX_EMAIL_PREFIX_NAME, $email, $matches ) ) :
2489		- ( $ret['name'] = $matches[2] ) || ( $ret['name'] = $matches[3] );
	2627	+ elseif (preg_match(FWP_REGEX_EMAIL_PREFIX_NAME, $email, $matches)) :
	2628	+ ($ret['name'] = $matches[2]) or ($ret['name'] = $matches[3]);
2490	2629	$ret['email'] = $matches[4];
2491		-
2492		- elseif ( preg_match( FWP_REGEX_EMAIL_JUST_ADDY, $email, $matches ) ) :
2493		- $ret['name'] = null;
2494		- $ret['email'] = $matches[1];
2495		- elseif ( preg_match( FWP_REGEX_EMAIL_JUST_NAME, $email, $matches ) ) :
2496		- $ret['email'] = null;
2497		- ( $ret['name'] = $matches[2] ) || ( $ret['name'] = $matches[3] );
	2630	+ elseif (preg_match(FWP_REGEX_EMAIL_JUST_ADDY, $email, $matches)) :
	2631	+ $ret['name'] = NULL; $ret['email'] = $matches[1];
	2632	+ elseif (preg_match(FWP_REGEX_EMAIL_JUST_NAME, $email, $matches)) :
	2633	+ $ret['email'] = NULL;
	2634	+ ($ret['name'] = $matches[2]) or ($ret['name'] = $matches[3]);
	2635	+ else :
	2636	+ $ret['name'] = NULL; $ret['email'] = NULL;
2498	2637	endif;
2499	2638	return $ret;
2500	2639	}
	2640	+