← All changes | app/Services/UserService.php +209 -2 2.0.15 → 2.2.0 View file →

		@@ -1,8 +1,9 @@
1	1	<?php
2	2
3	3	namespace FluentBoards\App\Services;
4	4
	5	+use Exception;
5	6	use FluentBoards\App\Models\Activity;
6	7	use FluentBoards\App\Models\Meta;
7	8	use FluentBoards\App\Models\Notification;
8	9	use FluentBoards\App\Models\Task;
		@@ -13,8 +14,214 @@
13	14
14	15
15	16	class UserService
16	17	{
	18	+ /** Save only the current member's public display name. */
	19	+ public function updateDisplayName($userId, $displayName)
	20	+ {
	21	+ $userId = absint($userId);
	22	+ $this->assertCanUpdateProfile($userId);
	23	+ $displayName = is_string($displayName) ? trim(sanitize_text_field($displayName)) : '';
	24	+ if ($displayName === '') {
	25	+ throw new Exception(__('Display name is required', 'fluent-boards'), 400);
	26	+ }
	27	+ // WordPress treats "0" as empty and replaces it with the login name.
	28	+ if ($displayName === '0') {
	29	+ throw new Exception(__('Display name cannot be "0"', 'fluent-boards'), 400);
	30	+ }
	31	+
	32	+ if (mb_strlen($displayName, 'UTF-8') > Constant::PROFILE_DISPLAY_NAME_MAX_LENGTH) {
	33	+ throw new Exception(__('Display name must be 250 characters or fewer', 'fluent-boards'), 400);
	34	+ }
	35	+
	36	+ $expectedName = null;
	37	+ // Validate the final, unslashed storage value after WordPress and plugin filters.
	38	+ $validateStorage = function ($data, $update, $targetUserId) use ($userId, &$expectedName) {
	39	+ if (!$update || (int) $targetUserId !== $userId) {
	40	+ return $data;
	41	+ }
	42	+ $expectedName = $data['display_name'] ?? null;
	43	+ if (!is_string($expectedName) || $expectedName === '') {
	44	+ throw new Exception(__('Display name is required', 'fluent-boards'), 400);
	45	+ }
	46	+ if (mb_strlen($expectedName, 'UTF-8') > Constant::PROFILE_DISPLAY_NAME_MAX_LENGTH) {
	47	+ throw new Exception(__('Display name must be 250 characters or fewer', 'fluent-boards'), 400);
	48	+ }
	49	+ return $data;
	50	+ };
	51	+ add_filter('wp_pre_insert_user_data', $validateStorage, PHP_INT_MAX, 3);
	52	+ try {
	53	+ $result = wp_update_user(['ID' => $userId, 'display_name' => wp_slash($displayName)]);
	54	+ } finally {
	55	+ remove_filter('wp_pre_insert_user_data', $validateStorage, PHP_INT_MAX);
	56	+ }
	57	+ if (is_wp_error($result)) {
	58	+ throw new Exception($result->get_error_message(), 400);
	59	+ }
	60	+
	61	+ // WordPress can return a user ID after a failed database update.
	62	+ clean_user_cache($userId);
	63	+ $user = get_userdata($userId);
	64	+ if (!$user) {
	65	+ throw new Exception(__('Could not load the updated profile', 'fluent-boards'), 400);
	66	+ }
	67	+ if ($expectedName === null || $user->display_name !== $expectedName) {
	68	+ throw new Exception(__('Could not save the display name. Please try again.', 'fluent-boards'), 400);
	69	+ }
	70	+ $displayName = $user->display_name;
	71	+ do_action('fluent_boards/profile_name_updated', $userId, $displayName);
	72	+ return ['display_name' => $displayName];
	73	+ }
	74	+
	75	+ /** Validate and store a custom avatar without requiring media-library access. */
	76	+ public function updateProfilePhoto($userId, $file)
	77	+ {
	78	+ $userId = absint($userId);
	79	+ $this->assertCanUpdateProfile($userId);
	80	+ if (!is_array($file) || !isset($file['error'], $file['size'], $file['tmp_name'], $file['name'])
	81	+ || $file['error'] !== UPLOAD_ERR_OK || !is_string($file['tmp_name']) || !is_string($file['name'])
	82	+ || !is_uploaded_file($file['tmp_name'])) {
	83	+ throw new Exception(__('No photo uploaded or upload error', 'fluent-boards'), 400);
	84	+ }
	85	+ if (filesize($file['tmp_name']) <= 0 || filesize($file['tmp_name']) > Constant::PROFILE_PHOTO_MAX_BYTES) {
	86	+ throw new Exception(__('Photo must be 2 MB or smaller', 'fluent-boards'), 400);
	87	+ }
	88	+
	89	+ $mimes = ['jpg|jpeg|jpe' => 'image/jpeg', 'png' => 'image/png', 'gif' => 'image/gif', 'webp' => 'image/webp'];
	90	+ // Inspect the file contents, not the browser MIME or filename alone.
	91	+ if (!in_array(wp_get_image_mime($file['tmp_name']), $mimes, true)) {
	92	+ throw new Exception(__('Choose a JPG, PNG, GIF or WebP image', 'fluent-boards'), 400);
	93	+ }
	94	+ $dimensions = wp_getimagesize($file['tmp_name']);
	95	+ if (!$dimensions || $dimensions[0] < 1 || $dimensions[1] < 1
	96	+ || max($dimensions[0], $dimensions[1]) > Constant::PROFILE_PHOTO_MAX_DIMENSION
	97	+ || $dimensions[0] * $dimensions[1] > Constant::PROFILE_PHOTO_MAX_PIXELS) {
	98	+ throw new Exception(__('Photo dimensions must not exceed 4096 pixels per side or 12 megapixels', 'fluent-boards'));
	99	+ }
	100	+ if (!function_exists('wp_handle_upload')) {
	101	+ require_once ABSPATH . 'wp-admin/includes/file.php';
	102	+ }
	103	+ $uploaded = wp_handle_upload($file, ['test_form' => false, 'mimes' => $mimes]);
	104	+ if (isset($uploaded['error'])) {
	105	+ throw new Exception($uploaded['error'], 400);
	106	+ }
	107	+
	108	+ $uploaded = $this->createProfileAvatar($uploaded);
	109	+ $this->replaceProfilePhoto($userId, $uploaded);
	110	+ $photoUrl = esc_url_raw($uploaded['url']);
	111	+ do_action('fluent_boards/profile_photo_updated', $userId, $photoUrl);
	112	+ return ['photo' => fluent_boards_user_avatar(wp_get_current_user()->user_email)];
	113	+ }
	114	+
	115	+ /** Re-encode a bounded avatar and discard the source before persisting profile changes. */
	116	+ private function createProfileAvatar(array $uploaded)
	117	+ {
	118	+ $directory = dirname($uploaded['file']);
	119	+ $filename = wp_unique_filename($directory, pathinfo($uploaded['file'], PATHINFO_FILENAME) . '-avatar.png');
	120	+ $avatarPath = $directory . '/' . $filename;
	121	+
	122	+ try {
	123	+ $editor = wp_get_image_editor($uploaded['file']);
	124	+ if (is_wp_error($editor)) {
	125	+ throw new Exception($editor->get_error_message());
	126	+ }
	127	+ $size = $editor->get_size();
	128	+ if (max($size['width'], $size['height']) > Constant::PROFILE_AVATAR_SIZE) {
	129	+ $resized = $editor->resize(Constant::PROFILE_AVATAR_SIZE, Constant::PROFILE_AVATAR_SIZE, false);
	130	+ if (is_wp_error($resized)) {
	131	+ throw new Exception($resized->get_error_message());
	132	+ }
	133	+ }
	134	+ $avatar = $editor->save($avatarPath, 'image/png');
	135	+ if (is_wp_error($avatar)) {
	136	+ throw new Exception($avatar->get_error_message());
	137	+ }
	138	+
	139	+ return [
	140	+ 'file' => $avatar['path'],
	141	+ 'url' => trailingslashit(dirname($uploaded['url'])) . wp_basename($avatar['path']),
	142	+ 'type' => $avatar['mime-type'],
	143	+ ];
	144	+ } catch (Exception $e) {
	145	+ wp_delete_file($avatarPath);
	146	+ throw $e;
	147	+ } finally {
	148	+ wp_delete_file($uploaded['file']);
	149	+ }
	150	+ }
	151	+
	152	+ /** Serialize replacement across requests sharing the same WordPress user table. */
	153	+ private function replaceProfilePhoto($userId, array $uploaded)
	154	+ {
	155	+ global $wpdb;
	156	+
	157	+ $lockName = Constant::USER_PROFILE_PHOTO_UPLOAD . ':' . md5(DB_NAME . ':' . $wpdb->users . ':' . $userId);
	158	+ if ((int) $wpdb->get_var($wpdb->prepare('SELECT GET_LOCK(%s, 5)', $lockName)) !== 1) {
	159	+ wp_delete_file($uploaded['file']);
	160	+ throw new Exception(__('The profile photo is being updated. Please try again.', 'fluent-boards'));
	161	+ }
	162	+
	163	+ try {
	164	+ // A waiting request may have cached metadata from before the previous upload.
	165	+ wp_cache_delete($userId, 'user_meta');
	166	+ $this->persistProfilePhoto($userId, $uploaded);
	167	+ } finally {
	168	+ $wpdb->get_var($wpdb->prepare('SELECT RELEASE_LOCK(%s)', $lockName));
	169	+ }
	170	+ }
	171	+
	172	+ /** Track uploads we own; legacy or externally supplied avatar URLs never authorize deletion. */
	173	+ private function persistProfilePhoto($userId, array $uploaded)
	174	+ {
	175	+ $previousUrl = get_user_meta($userId, Constant::USER_PROFILE_PHOTO, true);
	176	+ $previousUpload = get_user_meta($userId, Constant::USER_PROFILE_PHOTO_UPLOAD, true);
	177	+ $ownedUpload = [
	178	+ 'file' => $uploaded['file'],
	179	+ 'url' => esc_url_raw($uploaded['url']),
	180	+ 'blog_id' => get_current_blog_id(),
	181	+ ];
	182	+
	183	+ if (!update_user_meta($userId, Constant::USER_PROFILE_PHOTO_UPLOAD, $ownedUpload)) {
	184	+ wp_delete_file($uploaded['file']);
	185	+ throw new Exception(__('The profile photo could not be saved. Please try again.', 'fluent-boards'));
	186	+ }
	187	+ if (!update_user_meta($userId, Constant::USER_PROFILE_PHOTO, $ownedUpload['url'])) {
	188	+ if ($previousUpload) {
	189	+ update_user_meta($userId, Constant::USER_PROFILE_PHOTO_UPLOAD, $previousUpload);
	190	+ } else {
	191	+ delete_user_meta($userId, Constant::USER_PROFILE_PHOTO_UPLOAD);
	192	+ }
	193	+ wp_delete_file($uploaded['file']);
	194	+ throw new Exception(__('The profile photo could not be saved. Please try again.', 'fluent-boards'));
	195	+ }
	196	+
	197	+ // Only a matching, locally tracked upload can be retired after both writes succeed.
	198	+ if (!is_array($previousUpload)
	199	+ || ($previousUpload['url'] ?? null) !== $previousUrl
	200	+ || ($previousUpload['blog_id'] ?? null) !== get_current_blog_id()
	201	+ || !is_string($previousUpload['file'] ?? null)
	202	+ || $previousUpload['file'] === $ownedUpload['file']) {
	203	+ return;
	204	+ }
	205	+
	206	+ $uploads = wp_get_upload_dir();
	207	+ $previousFile = realpath($previousUpload['file']);
	208	+ $uploadsDirectory = realpath($uploads['basedir']);
	209	+ if (!$uploads['error'] && $previousFile && $uploadsDirectory
	210	+ && strpos(wp_normalize_path($previousFile), trailingslashit(wp_normalize_path($uploadsDirectory))) === 0
	211	+ && is_file($previousFile)) {
	212	+ wp_delete_file($previousFile);
	213	+ }
	214	+ }
	215	+
	216	+ /** Profile editing requires Fluent Boards membership and remains self-service for administrators. */
	217	+ private function assertCanUpdateProfile($userId)
	218	+ {
	219	+ if (!$userId || $userId !== get_current_user_id() || !PermissionManager::isFluentBoardsUser($userId)) {
	220	+ throw new Exception(__('You can only update your own profile', 'fluent-boards'), 403);
	221	+ }
	222	+ }
	223	+
17	224	public function allFluentBoardsUsers($boardId = null)
18	225	{
19	226	// Get the global admins first
20	227	$adminUserIds = Meta::query()->where('object_type', Constant::FLUENT_BOARD_ADMIN)
		@@ -246,10 +453,10 @@
246	453	$taskType = $requestData['taskType'] ?? null;
247	454	$boardIds = !empty($requestData['boardIds']) ? $requestData['boardIds'] : [];
248	455	$orderBy = $requestData['orderBy'] ?? 'created_at';
249	456	$order = strtoupper($requestData['order'] ?? 'ASC');
250		- $per_page = $requestData['per_page'] ?? 15;
251		- $page = $requestData['page'] ?? 1;
	457	+ $per_page = Sanitize::perPage($requestData['per_page'] ?? 15, 50);
	458	+ $page = max(1, (int) ($requestData['page'] ?? 1));
252	459	$user = User::find($user_id);
253	460
254	461	$loggedInUserId = get_current_user_id();
255	462