← All changes | app/Http/Requests/OrderRequest.php +85 -43 1.5.5 → 1.7.1 View file →

		@@ -1,9 +1,12 @@
1	1	<?php
2	2
3	3	namespace FluentCart\App\Http\Requests;
4	4
	5	+use FluentCart\App\Helpers\CartHelper;
	6	+use FluentCart\App\Helpers\Helper;
5	7	use FluentCart\Framework\Foundation\RequestGuard;
	8	+use FluentCart\Framework\Support\Arr;
6	9
7	10	class OrderRequest extends RequestGuard
8	11	{
9	12
		@@ -25,9 +28,13 @@
25	28	'discount_tax' => 'numeric',
26	29	'manual_discount_total' => 'numeric',
27	30	'coupon_discount_total' => 'numeric',
28	31	'shipping_tax' => 'numeric',
29		- 'shipping_total' => 'numeric',
	32	+ // min/max close the silent-corruption window: 1e19 passes `numeric`
	33	+ // but wraps to a negative BIGINT through a float-to-int cast, and a
	34	+ // negative shipping charge has no meaning. The bound matches the
	35	+ // Helper::roundCent() guard (float's exact-integer range).
	36	+ 'shipping_total' => 'numeric|min:0|max:9000000000000000',
30	37	'tax_total' => 'numeric',
31	38	'total_amount' => 'numeric',
32	39	'rate' => 'numeric',
33	40	'note' => 'nullable|sanitizeTextArea|maxLength:5000',
		@@ -45,9 +52,9 @@
45	52	"order_items.*.variation_id" => 'numeric|min:1',
46	53	"order_items.*.object_id" => 'numeric|min:1',
47	54	"order_items.*.fulfillment_type" => 'nullable|sanitizeText',
48	55	"order_items.*.payment_type" => 'nullable|sanitizeText|maxLength:100',
49		- "order_items.*.quantity" => 'numeric|min:1',
	56	+ "order_items.*.quantity" => 'numeric|min:1|max:' . CartHelper::maxQuantity(),
50	57	"order_items.*.post_title" => 'nullable|sanitizeText|maxLength:255',
51	58	"order_items.*.title" => 'nullable|sanitizeText|maxLength:255',
52	59	"order_items.*.price" => 'numeric',
53	60	"order_items.*.unit_price" => 'numeric',
		@@ -81,28 +88,57 @@
81	88	'tax_lines.*.tax_amount' => 'nullable|numeric|min:0',
82	89	'tax_lines.*.label' => 'nullable|sanitizeText',
83	90	'tax_lines.*.is_compound'=> 'nullable',
84	91
85		- 'applied_coupon' => 'nullable|array',
86		- "applied_coupon.*.id" => 'nullable|numeric|min:1',
87		- "applied_coupon.*.order_id" => 'nullable|numeric|min:1',
88		- "applied_coupon.*.coupon_id" => 'required|numeric|min:1',
89		- //"applied_coupon.*.title" => 'required|string|max:100',
90		- "applied_coupon.*.code" => 'required|sanitizeText|maxLength:100',
91		- //"applied_coupon.*.status" => 'required|string|max:100',
92		- //"applied_coupon.*.type" => 'required|string|max:100',
93		- "applied_coupon.*.amount" => 'nullable|numeric',
94		- "applied_coupon.*.discounted_amount" => 'required|numeric',
95		- "applied_coupon.*.discount" => 'nullable|numeric',
96		- "applied_coupon.*.stackable" => 'required|numeric',
97		- "applied_coupon.*.priority" => 'nullable|numeric',
98		- "applied_coupon.*.max_uses" => 'nullable|numeric',
99		- "applied_coupon.*.use_count" => 'nullable|numeric',
100		- "applied_coupon.*.max_per_customer" => 'nullable|numeric|min:1',
101		- "applied_coupon.*.min_purchase_amount" => 'nullable|numeric',
102		- "applied_coupon.*.max_discount_amount" => 'nullable|numeric',
103		- "applied_coupon.*.notes" => 'nullable|sanitizeTextArea|maxLength:100',
104		- 'trigger' => 'nullable|string',
	92	+ // `applied_coupon` is the admin order screen handing back, untouched, what
	93	+ // POST coupons/apply returned: a map KEYED BY COUPON CODE whose rows are
	94	+ // CouponServiceAdmin discount data (see ensureCouponExistInDiscountData()),
	95	+ // NOT fct_applied_coupons rows. AdminOrderProcessor::insertAppliedCoupons()
	96	+ // reads the code keys plus `id` and `discount` and builds its insert rows
	97	+ // from the Coupon model, so those two are the whole load-bearing contract;
	98	+ // everything else in the map is display metadata.
	99	+ //
	100	+ // The previous rules described fct_applied_coupons columns (coupon_id, code,
	101	+ // discounted_amount, stackable) that no caller has ever sent. They were inert
	102	+ // while the validator skipped absent wildcard children, and became a hard
	103	+ // 422 on every coupon order once it started materializing them.
	104	+ //
	105	+ // The per-row closure is the backstop, not decoration: whether the wildcard
	106	+ // rules below can fire at all depends on the validator materializing absent
	107	+ // children, so on its own `applied_coupon.*.id => required` is silently
	108	+ // unenforced on older framework builds. insertAppliedCoupons() subscripts
	109	+ // ['id'] unguarded, so an entry without one writes a null coupon_id.
	110	+ 'applied_coupon' => ['nullable', 'array', function ($attribute, $value) {
	111	+ if (!is_array($value)) {
	112	+ return null; // the `array` rule already reports this
	113	+ }
	114	+
	115	+ foreach ($value as $code => $row) {
	116	+ $couponId = is_array($row) ? Arr::get($row, 'id') : null;
	117	+
	118	+ if (!is_numeric($couponId) || (int) $couponId < 1) {
	119	+ return sprintf(
	120	+ /* translators: %1$s: the coupon code the admin applied to the order. */
	121	+ __('The applied coupon "%1$s" is missing its coupon id.', 'fluent-cart'),
	122	+ sanitize_text_field((string) $code)
	123	+ );
	124	+ }
	125	+ }
	126	+
	127	+ return null;
	128	+ }],
	129	+ "applied_coupon.*.id" => 'required|numeric|min:1',
	130	+ // Bounded for the same reason as shipping_total above: sanitize() routes this
	131	+ // through Helper::roundCent(), which throws outside float's exact-integer
	132	+ // range, and a negative coupon discount has no meaning.
	133	+ "applied_coupon.*.discount" => 'required|numeric|min:0|max:9000000000000000',
	134	+ "applied_coupon.*.title" => 'nullable|sanitizeText|maxLength:192',
	135	+ "applied_coupon.*.type" => 'nullable|sanitizeText|maxLength:100',
	136	+ "applied_coupon.*.amount" => 'nullable|numeric',
	137	+ "applied_coupon.*.actual_amount" => 'nullable|numeric',
	138	+ "applied_coupon.*.unit_amount" => 'nullable|numeric',
	139	+ "applied_coupon.*.actual_quantity" => 'nullable|numeric',
	140	+ 'trigger' => 'nullable|string',
105	141	];
106	142	}
107	143
108	144
		@@ -138,14 +174,24 @@
138	174	'discount_tax' => 'floatval',
139	175	'manual_discount_total' => 'floatval',
140	176	'coupon_discount_total' => 'floatval',
141	177	'shipping_tax' => 'floatval',
142		- 'shipping_total' => 'floatval',
	178	+ // Cents column: normalize at the boundary so every consumer of this request
	179	+ // receives a whole-cent int. floatval alone let a client-computed 19.99 * 100
	180	+ // arrive as 1998.9999999999998, which any later int cast would truncate.
	181	+ //
	182	+ // Wrapped in a closure, NOT passed as [Helper::class, 'roundCent']: an array
	183	+ // value in this map is a LIST of callbacks, iterated one by one
	184	+ // (vendor/wpfluent/framework/src/WPFluent/Support/Sanitizer.php:456-464), so the
	185	+ // array-callable form would try to call Helper() as a function.
	186	+ 'shipping_total' => function ($value) {
	187	+ return Helper::roundCent($value);
	188	+ },
143	189	'tax_total' => 'floatval',
144	190	'tax_behavior' => 'intval',
145	191	'total_amount' => 'floatval',
146	192	'rate' => 'sanitize_text_field',
147		- 'note' => 'sanitize_text_field',
	193	+ 'note' => 'sanitize_textarea_field',
148	194	'uuid' => 'sanitize_text_field',
149	195	'ip_address' => 'sanitize_text_field',
150	196	'billing_address_id' => 'intval',
151	197	'shipping_address_id' => 'intval',
		@@ -201,27 +247,23 @@
201	247	"tax_lines.*.is_compound"=> function ($value) {
202	248	return (bool) $value;
203	249	},
204	250
205		- "applied_coupon.*.id" => 'intval',
206		- "applied_coupon.*.order_id" => 'intval',
207		- "applied_coupon.*.coupon_id" => 'intval',
208		- "applied_coupon.*.title" => 'sanitize_text_field',
209		- "applied_coupon.*.discount" => 'intval',
210		- "applied_coupon.*.code" => 'sanitize_text_field',
211		- "applied_coupon.*.status" => 'sanitize_text_field',
212		- "applied_coupon.*.type" => 'sanitize_text_field',
213		- "applied_coupon.*.amount" => 'intval',
214		- "applied_coupon.*.discounted_amount" => 'intval',
215		- "applied_coupon.*.stackable" => 'intval',
216		- "applied_coupon.*.priority" => 'intval',
217		- "applied_coupon.*.max_uses" => 'intval',
218		- "applied_coupon.*.use_count" => 'intval',
219		- "applied_coupon.*.max_per_customer" => 'intval',
220		- "applied_coupon.*.min_purchase_amount" => 'intval',
221		- "applied_coupon.*.max_discount_amount" => 'intval',
222		- "applied_coupon.*.notes" => 'sanitize_text_field',
223		- 'trigger' => 'sanitize_text_field',
	251	+ // Mirrors rules(): the coupons/apply discount-data shape, keyed by coupon code.
	252	+ "applied_coupon.*.id" => 'intval',
	253	+ // Already cents (CouponServiceAdmin rounds the distributed discount to two
	254	+ // decimals in cents) — normalize the float artifact without scaling. A bare
	255	+ // intval() here truncates, so a 9.99 discount would persist a cent short.
	256	+ "applied_coupon.*.discount" => function ($value) {
	257	+ return Helper::roundCent($value);
	258	+ },
	259	+ "applied_coupon.*.title" => 'sanitize_text_field',
	260	+ "applied_coupon.*.type" => 'sanitize_text_field',
	261	+ "applied_coupon.*.amount" => 'intval',
	262	+ "applied_coupon.*.actual_amount" => 'floatval',
	263	+ "applied_coupon.*.unit_amount" => 'intval',
	264	+ "applied_coupon.*.actual_quantity" => 'intval',
	265	+ 'trigger' => 'sanitize_text_field',
224	266	];
225	267
226	268	}
227	269	}