← All changes | database/Migrations/AttachmentsMigrator.php +60 -9 1.4.6 → 2.4.5 View file →

		@@ -13,9 +13,9 @@
13	13	$charsetCollate = $wpdb->get_charset_collate();
14	14
15	15	$table = $wpdb->prefix . static::$tableName;
16	16
17		- if ($wpdb->get_var("SHOW TABLES LIKE '$table'") != $table) {
	17	+ if ($wpdb->get_var($wpdb->prepare("SHOW TABLES LIKE %s", $table)) != $table) {
18	18	$sql = "CREATE TABLE $table (
19	19	`id` BIGINT(20) UNSIGNED NOT NULL PRIMARY KEY AUTO_INCREMENT,
20	20	`ticket_id` BIGINT(20) UNSIGNED NULL,
21	21	`person_id` BIGINT(20) UNSIGNED NULL,
		@@ -29,18 +29,69 @@
29	29	`driver` VARCHAR(100) DEFAULT 'local',
30	30	`status` VARCHAR(100) NULL DEFAULT 'active',
31	31	`file_size` VARCHAR(100) NULL,
32	32	`created_at` TIMESTAMP NULL,
33		- `updated_at` TIMESTAMP NULL
	33	+ `updated_at` TIMESTAMP NULL,
	34	+ INDEX `idx_file_hash` (`file_hash`),
	35	+ INDEX `idx_ticket_id` (`ticket_id`),
	36	+ INDEX `idx_person_id` (`person_id`),
	37	+ INDEX `idx_conversation_id` (`conversation_id`),
	38	+ INDEX `idx_status` (`status`),
	39	+ INDEX `idx_created_at` (`created_at`)
34	40	) $charsetCollate;";
35		- dbDelta($sql);
	41	+ $created = dbDelta($sql);
	42	+ return $created;
36	43	} else {
37		- // @todo: We will remove this on final release
38		- // This is only for beta users
39		- $existing_columns = $wpdb->get_col("DESC {$table}", 0);
40		- if(!in_array('status', $existing_columns)) {
41		- $query = "ALTER TABLE {$table} ADD `status` VARCHAR(100) NULL DEFAULT 'active' AFTER `driver`";
42		- $wpdb->query($query);
	44	+ static::alterTable($table);
	45	+ }
	46	+
	47	+ return false;
	48	+ }
	49	+
	50	+ public static function alterTable($table)
	51	+ {
	52	+ global $wpdb;
	53	+
	54	+ // Our own table name, not user input. esc_sql() because %i needs WP 6.2+.
	55	+ $table = esc_sql($table);
	56	+
	57	+ // @todo: Beta-only migration, remove on final release.
	58	+ $existing_columns = $wpdb->get_col("DESC `{$table}`", 0); // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
	59	+ if (!in_array('status', $existing_columns)) {
	60	+ // phpcs:ignore PluginCheck.Security.DirectDB.UnescapedDBParameter,WordPress.DB.PreparedSQL.NotPrepared -- $table is sanitized via esc_sql(); column name is a hardcoded literal.
	61	+ $wpdb->query("ALTER TABLE `{$table}` ADD `status` VARCHAR(100) NULL DEFAULT 'active' AFTER `driver`");
	62	+ }
	63	+
	64	+ static::addMissingIndexes($table);
	65	+ }
	66	+
	67	+ public static function addMissingIndexes($table)
	68	+ {
	69	+ global $wpdb;
	70	+
	71	+ // Escaped again in case this is called directly.
	72	+ $table = esc_sql($table);
	73	+
	74	+ $existing_indexes = $wpdb->get_results("SHOW INDEX FROM `{$table}`"); // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
	75	+ $existing_index_names = [];
	76	+
	77	+ foreach ($existing_indexes as $index) {
	78	+ $existing_index_names[] = $index->Key_name;
	79	+ }
	80	+
	81	+ $indexes = [
	82	+ 'idx_ticket_id' => 'ticket_id',
	83	+ 'idx_person_id' => 'person_id',
	84	+ 'idx_conversation_id' => 'conversation_id',
	85	+ 'idx_status' => 'status',
	86	+ 'idx_created_at' => 'created_at',
	87	+ 'idx_file_hash' => 'file_hash',
	88	+ ];
	89	+
	90	+ foreach ($indexes as $index_name => $column_name) {
	91	+ if (!in_array($index_name, $existing_index_names)) {
	92	+ // phpcs:ignore PluginCheck.Security.DirectDB.UnescapedDBParameter,WordPress.DB.PreparedSQL.NotPrepared -- all identifiers are either esc_sql()'d or hardcoded literals.
	93	+ $wpdb->query("ALTER TABLE `{$table}` ADD INDEX `{$index_name}` (`{$column_name}`)");
43	94	}
44	95	}
45	96	}
46	97	}