| @@ -5,67 +5,45 @@ | ||
| 5 | 5 | |
| 6 | 6 | class FrmEntry { |
| 7 | 7 | |
| 8 | 8 | /** |
| 9 | - * @since 6.16.3 | |
| 10 | - * | |
| 11 | - * @var array | |
| 12 | - */ | |
| 13 | - private static $unique_id_match_checks = array(); | |
| 14 | - | |
| 15 | - /** | |
| 16 | 9 | * Create a new entry |
| 17 | 10 | * |
| 18 | 11 | * @param array $values |
| 19 | 12 | * |
| 20 | - * @return bool|int Entry ID. | |
| 13 | + * @return int | boolean $entry_id | |
| 21 | 14 | */ |
| 22 | 15 | public static function create( $values ) { |
| 23 | - return self::create_entry( $values, 'standard' ); | |
| 16 | + $entry_id = self::create_entry( $values, 'standard' ); | |
| 17 | + | |
| 18 | + return $entry_id; | |
| 24 | 19 | } |
| 25 | 20 | |
| 26 | 21 | /** |
| 27 | 22 | * Create a new entry with some differences depending on type |
| 28 | 23 | * |
| 29 | - * @param array $values | |
| 24 | + * @param array $values | |
| 30 | 25 | * @param string $type |
| 31 | 26 | * |
| 32 | - * @return bool|int Entry ID. | |
| 27 | + * @return int | boolean $entry_id | |
| 33 | 28 | */ |
| 34 | 29 | private static function create_entry( $values, $type ) { |
| 35 | 30 | $new_values = self::before_insert_entry_in_database( $values, $type ); |
| 36 | 31 | |
| 37 | 32 | // Don't check XML entries for duplicates |
| 38 | - if ( $type !== 'xml' && self::is_duplicate( $new_values, $values ) ) { | |
| 33 | + if ( $type != 'xml' && self::is_duplicate( $new_values, $values ) ) { | |
| 39 | 34 | return false; |
| 40 | 35 | } |
| 41 | 36 | |
| 42 | - return self::continue_to_create_entry( $values, $new_values ); | |
| 43 | - } | |
| 37 | + $entry_id = self::continue_to_create_entry( $values, $new_values ); | |
| 44 | 38 | |
| 45 | - /** | |
| 46 | - * Flag the memoized unique id check after a new entry is created. | |
| 47 | - * This prevents possibly DB requests and helps avoid issues when creating repeater entries. | |
| 48 | - * | |
| 49 | - * @since 6.16.3 | |
| 50 | - * | |
| 51 | - * @param string $unique_id | |
| 52 | - * | |
| 53 | - * @return void | |
| 54 | - */ | |
| 55 | - private static function flag_new_unique_key( $unique_id ) { | |
| 56 | - if ( ! isset( self::$unique_id_match_checks[ $unique_id ] ) ) { | |
| 57 | - self::$unique_id_match_checks[ $unique_id ] = false; | |
| 58 | - } | |
| 39 | + return $entry_id; | |
| 59 | 40 | } |
| 60 | 41 | |
| 61 | 42 | /** |
| 62 | 43 | * Check for duplicate entries created in the last minute |
| 63 | 44 | * |
| 64 | - * @param array $new_values New values. | |
| 65 | - * @param array $values Values. | |
| 66 | - * | |
| 67 | - * @return bool | |
| 45 | + * @return boolean | |
| 68 | 46 | */ |
| 69 | 47 | public static function is_duplicate( $new_values, $values ) { |
| 70 | 48 | $duplicate_entry_time = apply_filters( 'frm_time_to_check_duplicates', 60, $new_values ); |
| 71 | 49 | |
| @@ -72,50 +50,33 @@ | ||
| 72 | 50 | if ( false === self::is_duplicate_check_needed( $values, $duplicate_entry_time ) ) { |
| 73 | 51 | return false; |
| 74 | 52 | } |
| 75 | 53 | |
| 76 | - if ( self::maybe_check_for_unique_id_match( $values, $new_values['created_at'] ) ) { | |
| 77 | - return true; | |
| 78 | - } | |
| 79 | - | |
| 80 | 54 | $check_val = $new_values; |
| 81 | - $check_val['created_at >'] = gmdate( 'Y-m-d H:i:s', strtotime( $new_values['created_at'] ) - absint( $duplicate_entry_time ) ); | |
| 55 | + $check_val['created_at >'] = gmdate( 'Y-m-d H:i:s', ( strtotime( $new_values['created_at'] ) - absint( $duplicate_entry_time ) ) ); | |
| 82 | 56 | |
| 83 | - unset( $check_val['created_at'], $check_val['updated_at'], $check_val['is_draft'], $check_val['id'], $check_val['item_key'] ); | |
| 57 | + unset( $check_val['created_at'], $check_val['updated_at'] ); | |
| 58 | + unset( $check_val['is_draft'], $check_val['id'], $check_val['item_key'] ); | |
| 84 | 59 | |
| 85 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 86 | 60 | if ( $new_values['item_key'] == $new_values['name'] ) { |
| 87 | 61 | unset( $check_val['name'] ); |
| 88 | 62 | } |
| 89 | 63 | |
| 90 | - $check_val = apply_filters( 'frm_duplicate_check_val', $check_val ); | |
| 64 | + global $wpdb; | |
| 65 | + $entry_exists = FrmDb::get_col( $wpdb->prefix . 'frm_items', $check_val, 'id', array( 'order_by' => 'created_at DESC' ) ); | |
| 91 | 66 | |
| 92 | - if ( ! isset( $values['item_meta'] ) ) { | |
| 67 | + if ( ! $entry_exists || empty( $entry_exists ) || ! isset( $values['item_meta'] ) ) { | |
| 93 | 68 | return false; |
| 94 | 69 | } |
| 95 | 70 | |
| 96 | - $entry_exists = FrmDb::get_col( 'frm_items', $check_val, 'id', array( 'order_by' => 'created_at DESC' ) ); | |
| 97 | - | |
| 98 | - if ( ! $entry_exists ) { | |
| 99 | - return false; | |
| 100 | - } | |
| 101 | - | |
| 102 | - global $frm_vars; | |
| 103 | - $frm_vars['checking_duplicates'] = true; | |
| 104 | - $is_duplicate = false; | |
| 105 | - | |
| 71 | + $is_duplicate = false; | |
| 106 | 72 | foreach ( $entry_exists as $entry_exist ) { |
| 107 | 73 | $is_duplicate = true; |
| 108 | 74 | |
| 109 | - // Make sure it's a duplicate | |
| 75 | + // make sure it's a duplicate | |
| 110 | 76 | $metas = FrmEntryMeta::get_entry_meta_info( $entry_exist ); |
| 111 | 77 | $field_metas = array(); |
| 112 | - | |
| 113 | 78 | foreach ( $metas as $meta ) { |
| 114 | - if ( 0 === (int) $meta->field_id ) { | |
| 115 | - continue; | |
| 116 | - } | |
| 117 | - | |
| 118 | 79 | $field_metas[ $meta->field_id ] = $meta->meta_value; |
| 119 | 80 | } |
| 120 | 81 | |
| 121 | 82 | $filtered_vals = array_filter( $values['item_meta'] ); |
| @@ -122,13 +83,13 @@ | ||
| 122 | 83 | $filtered_vals = self::convert_values_to_their_saved_value( $filtered_vals, $entry_exist ); |
| 123 | 84 | $field_metas = array_filter( $field_metas ); |
| 124 | 85 | |
| 125 | 86 | // If prev entry is empty and current entry is not, they are not duplicates |
| 126 | - if ( ! $field_metas && $filtered_vals ) { | |
| 87 | + if ( empty( $field_metas ) && ! empty( $filtered_vals ) ) { | |
| 127 | 88 | return false; |
| 128 | 89 | } |
| 129 | 90 | |
| 130 | - // Compare serialized values and not arrays | |
| 91 | + // compare serialized values and not arrays | |
| 131 | 92 | $new_meta = array_map( 'maybe_serialize', $filtered_vals ); |
| 132 | 93 | |
| 133 | 94 | if ( $field_metas === $new_meta ) { |
| 134 | 95 | $is_duplicate = true; |
| @@ -141,12 +102,12 @@ | ||
| 141 | 102 | continue; |
| 142 | 103 | } |
| 143 | 104 | |
| 144 | 105 | $diff = array_diff_assoc( $field_metas, $new_meta ); |
| 145 | - | |
| 146 | - foreach ( $diff as $meta_value ) { | |
| 147 | - if ( $meta_value ) { | |
| 106 | + foreach ( $diff as $field_id => $meta_value ) { | |
| 107 | + if ( ! empty( $meta_value ) ) { | |
| 148 | 108 | $is_duplicate = false; |
| 109 | + continue; | |
| 149 | 110 | } |
| 150 | 111 | } |
| 151 | 112 | |
| 152 | 113 | if ( $is_duplicate ) { |
| @@ -151,103 +112,31 @@ | ||
| 151 | 112 | |
| 152 | 113 | if ( $is_duplicate ) { |
| 153 | 114 | break; |
| 154 | 115 | } |
| 155 | - }//end foreach | |
| 116 | + } | |
| 156 | 117 | |
| 157 | - $frm_vars['checking_duplicates'] = false; | |
| 158 | - | |
| 159 | 118 | return $is_duplicate; |
| 160 | 119 | } |
| 161 | 120 | |
| 162 | 121 | /** |
| 163 | - * @since 6.16.3 | |
| 164 | - * | |
| 165 | - * @param array $values POST request data. | |
| 166 | - * @param string $created_at The timestamp of the entry we are checking for. | |
| 167 | - * | |
| 168 | - * @return bool | |
| 169 | - */ | |
| 170 | - private static function maybe_check_for_unique_id_match( $values, $created_at ) { | |
| 171 | - if ( ! self::should_check_for_unique_id_match() ) { | |
| 172 | - return false; | |
| 173 | - } | |
| 174 | - | |
| 175 | - if ( empty( $values['unique_id'] ) ) { | |
| 176 | - return false; | |
| 177 | - } | |
| 178 | - | |
| 179 | - $unique_id = sanitize_key( $values['unique_id'] ); | |
| 180 | - | |
| 181 | - if ( ! $unique_id ) { | |
| 182 | - // Only continue if a unique ID was generated on form submit. | |
| 183 | - return false; | |
| 184 | - } | |
| 185 | - | |
| 186 | - if ( isset( self::$unique_id_match_checks[ $unique_id ] ) ) { | |
| 187 | - return self::$unique_id_match_checks[ $unique_id ]; | |
| 188 | - } | |
| 189 | - | |
| 190 | - $timestamp = strtotime( $created_at ); | |
| 191 | - | |
| 192 | - if ( false === $timestamp ) { | |
| 193 | - $timestamp = time(); | |
| 194 | - } | |
| 195 | - | |
| 196 | - self::$unique_id_match_checks[ $unique_id ] = (bool) FrmDb::get_var( | |
| 197 | - 'frm_item_metas', | |
| 198 | - array( | |
| 199 | - 'field_id' => 0, | |
| 200 | - 'meta_value' => serialize( compact( 'unique_id' ) ), | |
| 201 | - 'created_at >' => gmdate( 'Y-m-d H:i:s', $timestamp - MONTH_IN_SECONDS ), | |
| 202 | - ), | |
| 203 | - 'id' | |
| 204 | - ); | |
| 205 | - | |
| 206 | - return self::$unique_id_match_checks[ $unique_id ]; | |
| 207 | - } | |
| 208 | - | |
| 209 | - /** | |
| 210 | - * @since 6.16.3 | |
| 211 | - * | |
| 212 | - * @return bool | |
| 213 | - */ | |
| 214 | - private static function should_check_for_unique_id_match() { | |
| 215 | - /** | |
| 216 | - * Allow users to opt out of the DB query, in case it causes performance issues. | |
| 217 | - * | |
| 218 | - * @since 6.16.3 | |
| 219 | - * | |
| 220 | - * @param bool $should_extend | |
| 221 | - */ | |
| 222 | - $should_check = apply_filters( 'frm_check_for_unique_id_match', true ); | |
| 223 | - return (bool) $should_check; | |
| 224 | - } | |
| 225 | - | |
| 226 | - /** | |
| 227 | 122 | * Convert form data to the actual value that would be saved into the database. |
| 123 | + * This is important for the duplicate check as something like 'a:2:{s:5:"typed";s:0:"";s:6:"output";s:0:"";}' (a signature value) is actually an empty string and does not get saved. | |
| 228 | 124 | * |
| 229 | - * This is important for the duplicate check as something like 'a:2:{s:5:"typed";s:0:"";s:6:"output";s:0:"";}' | |
| 230 | - * (a signature value) is actually an empty string and does not get saved. | |
| 231 | - * | |
| 232 | 125 | * @param array $filter_vals |
| 233 | 126 | * @param int $entry_id |
| 234 | - * | |
| 235 | 127 | * @return array |
| 236 | 128 | */ |
| 237 | 129 | private static function convert_values_to_their_saved_value( $filter_vals, $entry_id ) { |
| 238 | 130 | $reduced = array(); |
| 239 | - | |
| 240 | 131 | foreach ( $filter_vals as $field_id => $value ) { |
| 241 | 132 | $field = FrmFieldFactory::get_field_object( $field_id ); |
| 242 | 133 | $reduced[ $field_id ] = $field->get_value_to_save( $value, array( 'entry_id' => $entry_id ) ); |
| 243 | 134 | $reduced[ $field_id ] = $field->set_value_before_save( $reduced[ $field_id ] ); |
| 244 | - | |
| 245 | - if ( '' === $reduced[ $field_id ] || array() === $reduced[ $field_id ] ) { | |
| 135 | + if ( '' === $reduced[ $field_id ] || ( is_array( $reduced[ $field_id ] ) && 0 === count( $reduced[ $field_id ] ) ) ) { | |
| 246 | 136 | unset( $reduced[ $field_id ] ); |
| 247 | 137 | } |
| 248 | 138 | } |
| 249 | - | |
| 250 | 139 | return $reduced; |
| 251 | 140 | } |
| 252 | 141 | |
| 253 | 142 | /** |
| @@ -255,15 +144,15 @@ | ||
| 255 | 144 | * |
| 256 | 145 | * @since 2.0.23 |
| 257 | 146 | * |
| 258 | 147 | * @param array $values |
| 259 | - * @param int $duplicate_entry_time | |
| 148 | + * @param int $duplicate_entry_time | |
| 260 | 149 | * |
| 261 | 150 | * @return bool |
| 262 | 151 | */ |
| 263 | 152 | private static function is_duplicate_check_needed( $values, $duplicate_entry_time ) { |
| 264 | 153 | // If time for checking duplicates is set to an empty value, don't check for duplicates |
| 265 | - if ( ! $duplicate_entry_time ) { | |
| 154 | + if ( empty( $duplicate_entry_time ) ) { | |
| 266 | 155 | return false; |
| 267 | 156 | } |
| 268 | 157 | |
| 269 | 158 | // If CSV is importing, don't check for duplicates |
| @@ -271,20 +160,20 @@ | ||
| 271 | 160 | return false; |
| 272 | 161 | } |
| 273 | 162 | |
| 274 | 163 | // If repeating field entries are getting created, don't check for duplicates |
| 275 | - return empty( $values['parent_form_id'] ); | |
| 164 | + if ( isset( $values['parent_form_id'] ) && $values['parent_form_id'] ) { | |
| 165 | + return false; | |
| 166 | + } | |
| 167 | + | |
| 168 | + return true; | |
| 276 | 169 | } |
| 277 | 170 | |
| 278 | - /** | |
| 279 | - * @param int|string $id | |
| 280 | - * | |
| 281 | - * @return false|int | |
| 282 | - */ | |
| 283 | 171 | public static function duplicate( $id ) { |
| 284 | 172 | global $wpdb; |
| 285 | 173 | |
| 286 | - $values = self::getOne( $id ); | |
| 174 | + $values = self::getOne( $id ); | |
| 175 | + | |
| 287 | 176 | $new_values = array(); |
| 288 | 177 | $new_values['item_key'] = FrmAppHelper::get_unique_key( '', $wpdb->prefix . 'frm_items', 'item_key' ); |
| 289 | 178 | $new_values['name'] = $values->name; |
| 290 | 179 | $new_values['is_draft'] = $values->is_draft; |
| @@ -294,9 +183,8 @@ | ||
| 294 | 183 | $new_values['created_at'] = current_time( 'mysql', 1 ); |
| 295 | 184 | $new_values['updated_at'] = $new_values['created_at']; |
| 296 | 185 | |
| 297 | 186 | $query_results = $wpdb->insert( $wpdb->prefix . 'frm_items', $new_values ); |
| 298 | - | |
| 299 | 187 | if ( ! $query_results ) { |
| 300 | 188 | return false; |
| 301 | 189 | } |
| 302 | 190 | |
| @@ -302,9 +190,8 @@ | ||
| 302 | 190 | |
| 303 | 191 | $entry_id = $wpdb->insert_id; |
| 304 | 192 | |
| 305 | 193 | global $frm_vars; |
| 306 | - | |
| 307 | 194 | if ( ! isset( $frm_vars['saved_entries'] ) ) { |
| 308 | 195 | $frm_vars['saved_entries'] = array(); |
| 309 | 196 | } |
| 310 | 197 | $frm_vars['saved_entries'][] = (int) $entry_id; |
| @@ -319,15 +206,17 @@ | ||
| 319 | 206 | |
| 320 | 207 | /** |
| 321 | 208 | * Update an entry (not via XML) |
| 322 | 209 | * |
| 323 | - * @param int $id | |
| 210 | + * @param int $id | |
| 324 | 211 | * @param array $values |
| 325 | 212 | * |
| 326 | - * @return bool|int Update results. | |
| 213 | + * @return boolean|int $update_results | |
| 327 | 214 | */ |
| 328 | 215 | public static function update( $id, $values ) { |
| 329 | - return self::update_entry( $id, $values, 'standard' ); | |
| 216 | + $update_results = self::update_entry( $id, $values, 'standard' ); | |
| 217 | + | |
| 218 | + return $update_results; | |
| 330 | 219 | } |
| 331 | 220 | |
| 332 | 221 | /** |
| 333 | 222 | * Update an entry with some differences depending on the update type |
| @@ -333,24 +222,23 @@ | ||
| 333 | 222 | * Update an entry with some differences depending on the update type |
| 334 | 223 | * |
| 335 | 224 | * @since 2.0.16 |
| 336 | 225 | * |
| 337 | - * @param int $id | |
| 338 | - * @param array $values | |
| 339 | - * @param string $update_type | |
| 226 | + * @param int $id | |
| 227 | + * @param array $values | |
| 340 | 228 | * |
| 341 | - * @return bool|int Query results. | |
| 229 | + * @return boolean|int $query_results | |
| 342 | 230 | */ |
| 343 | 231 | private static function update_entry( $id, $values, $update_type ) { |
| 344 | 232 | global $wpdb; |
| 345 | 233 | |
| 346 | 234 | $update = self::before_update_entry( $id, $values, $update_type ); |
| 347 | - | |
| 348 | 235 | if ( ! $update ) { |
| 349 | 236 | return false; |
| 350 | 237 | } |
| 351 | 238 | |
| 352 | - $new_values = self::package_entry_to_update( $id, $values ); | |
| 239 | + $new_values = self::package_entry_to_update( $id, $values ); | |
| 240 | + | |
| 353 | 241 | $query_results = $wpdb->update( $wpdb->prefix . 'frm_items', $new_values, compact( 'id' ) ); |
| 354 | 242 | |
| 355 | 243 | self::after_update_entry( $query_results, $id, $values, $new_values ); |
| 356 | 244 | |
| @@ -356,32 +244,19 @@ | ||
| 356 | 244 | |
| 357 | 245 | return $query_results; |
| 358 | 246 | } |
| 359 | 247 | |
| 360 | - /** | |
| 361 | - * Delete an entry. | |
| 362 | - * | |
| 363 | - * @param int|string $id | |
| 364 | - * | |
| 365 | - * @return bool True on success, false if nothing was deleted. | |
| 366 | - */ | |
| 367 | 248 | public static function destroy( $id ) { |
| 368 | 249 | global $wpdb; |
| 369 | 250 | $id = (int) $id; |
| 370 | 251 | |
| 371 | - // Item meta is required for conditional logic in actions with 'delete' events. | |
| 372 | - $entry = self::getOne( $id, true ); | |
| 252 | + $entry = self::getOne( $id ); | |
| 253 | + if ( ! $entry ) { | |
| 254 | + $result = false; | |
| 373 | 255 | |
| 374 | - if ( ! $entry ) { | |
| 375 | - return false; | |
| 256 | + return $result; | |
| 376 | 257 | } |
| 377 | 258 | |
| 378 | - /** | |
| 379 | - * Trigger an action to run custom logic before the entry is deleted. | |
| 380 | - * | |
| 381 | - * @param int $id The id of the entry that was destroyed. | |
| 382 | - * @param stdClass $entry The entry object. | |
| 383 | - */ | |
| 384 | 259 | do_action( 'frm_before_destroy_entry', $id, $entry ); |
| 385 | 260 | |
| 386 | 261 | $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_item_metas WHERE item_id=%d', $id ) ); |
| 387 | 262 | $result = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_items WHERE id=%d', $id ) ); |
| @@ -387,34 +262,15 @@ | ||
| 387 | 262 | $result = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_items WHERE id=%d', $id ) ); |
| 388 | 263 | |
| 389 | 264 | self::clear_cache(); |
| 390 | 265 | |
| 391 | - /** | |
| 392 | - * Trigger an action to run custom logic after the entry is deleted. | |
| 393 | - * Use this hook if you need to update caching after an entry is deleted. | |
| 394 | - * | |
| 395 | - * @since 5.4.1 | |
| 396 | - * | |
| 397 | - * @param int $id The id of the entry that was destroyed. | |
| 398 | - * @param stdClass $entry The entry object. | |
| 399 | - */ | |
| 400 | - do_action( 'frm_after_destroy_entry', $id, $entry ); | |
| 401 | - | |
| 402 | 266 | return $result; |
| 403 | 267 | } |
| 404 | 268 | |
| 405 | - /** | |
| 406 | - * @param int $id | |
| 407 | - * @param mixed $value | |
| 408 | - * @param int|string $form_id | |
| 409 | - * | |
| 410 | - * @return false|int | |
| 411 | - */ | |
| 412 | 269 | public static function update_form( $id, $value, $form_id ) { |
| 413 | 270 | global $wpdb; |
| 414 | 271 | $form_id = isset( $value ) ? $form_id : null; |
| 415 | 272 | $result = $wpdb->update( $wpdb->prefix . 'frm_items', array( 'form_id' => $form_id ), array( 'id' => $id ) ); |
| 416 | - | |
| 417 | 273 | if ( $result ) { |
| 418 | 274 | self::clear_cache(); |
| 419 | 275 | } |
| 420 | 276 | |
| @@ -425,10 +281,8 @@ | ||
| 425 | 281 | * Clear entry caching |
| 426 | 282 | * Called when an entry is changed |
| 427 | 283 | * |
| 428 | 284 | * @since 2.0.5 |
| 429 | - * | |
| 430 | - * @return void | |
| 431 | 285 | */ |
| 432 | 286 | public static function clear_cache() { |
| 433 | 287 | FrmDb::cache_delete_group( 'frm_entry' ); |
| 434 | 288 | FrmDb::cache_delete_group( 'frm_item' ); |
| @@ -440,42 +294,33 @@ | ||
| 440 | 294 | * After switching to the wp_loaded hook for processing entries, |
| 441 | 295 | * we can no longer use 'name', but check it as a fallback |
| 442 | 296 | * |
| 443 | 297 | * @since 2.0.11 |
| 444 | - * | |
| 445 | - * @param array $values | |
| 446 | - * @param array|string $default | |
| 447 | - * | |
| 448 | - * @return string | |
| 449 | 298 | */ |
| 450 | 299 | public static function get_new_entry_name( $values, $default = '' ) { |
| 451 | - $name = $values['item_name'] ?? $values['name'] ?? $default; | |
| 452 | - return is_array( $name ) ? reset( $name ) : $name; | |
| 300 | + $name = isset( $values['item_name'] ) ? $values['item_name'] : ( isset( $values['name'] ) ? $values['name'] : $default ); | |
| 301 | + if ( is_array( $name ) ) { | |
| 302 | + $name = reset( $name ); | |
| 303 | + } | |
| 304 | + | |
| 305 | + return $name; | |
| 453 | 306 | } |
| 454 | 307 | |
| 455 | 308 | /** |
| 456 | 309 | * If $entry is numeric, get the entry object |
| 457 | 310 | * |
| 311 | + * @param int|object $entry by reference | |
| 312 | + * | |
| 458 | 313 | * @since 2.0.9 |
| 459 | - * | |
| 460 | - * @param int|object|string $entry By reference. | |
| 461 | - * | |
| 462 | - * @return void | |
| 463 | 314 | */ |
| 464 | 315 | public static function maybe_get_entry( &$entry ) { |
| 465 | 316 | if ( $entry && is_numeric( $entry ) ) { |
| 466 | 317 | $entry = self::getOne( $entry ); |
| 467 | - } elseif ( ! $entry || 'false' === $entry ) { | |
| 318 | + } elseif ( empty( $entry ) || 'false' === $entry ) { | |
| 468 | 319 | $entry = false; |
| 469 | 320 | } |
| 470 | 321 | } |
| 471 | 322 | |
| 472 | - /** | |
| 473 | - * @param int|string $id | |
| 474 | - * @param bool $meta | |
| 475 | - * | |
| 476 | - * @return object|null | |
| 477 | - */ | |
| 478 | 323 | public static function getOne( $id, $meta = false ) { |
| 479 | 324 | global $wpdb; |
| 480 | 325 | |
| 481 | 326 | $query = "SELECT it.*, fr.name as form_name, fr.form_key as form_key FROM {$wpdb->prefix}frm_items it |
| @@ -480,11 +325,11 @@ | ||
| 480 | 325 | |
| 481 | 326 | $query = "SELECT it.*, fr.name as form_name, fr.form_key as form_key FROM {$wpdb->prefix}frm_items it |
| 482 | 327 | LEFT OUTER JOIN {$wpdb->prefix}frm_forms fr ON it.form_id=fr.id WHERE "; |
| 483 | 328 | |
| 484 | - $query .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s'; | |
| 329 | + $query .= is_numeric( $id ) ? 'it.id=%d' : 'it.item_key=%s'; | |
| 485 | 330 | $query_args = array( $id ); |
| 486 | - $query = $wpdb->prepare( $query, $query_args ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared | |
| 331 | + $query = $wpdb->prepare( $query, $query_args ); // WPCS: unprepared SQL ok. | |
| 487 | 332 | |
| 488 | 333 | if ( ! $meta ) { |
| 489 | 334 | $entry = FrmDb::check_cache( $id . '_nometa', 'frm_entry', $query, 'get_row' ); |
| 490 | 335 | self::prepare_entry( $entry ); |
| @@ -491,15 +336,14 @@ | ||
| 491 | 336 | return $entry; |
| 492 | 337 | } |
| 493 | 338 | |
| 494 | 339 | $entry = FrmDb::check_cache( $id, 'frm_entry' ); |
| 495 | - | |
| 496 | 340 | if ( $entry !== false ) { |
| 497 | 341 | self::prepare_entry( $entry ); |
| 498 | 342 | return $entry; |
| 499 | 343 | } |
| 500 | 344 | |
| 501 | - $entry = $wpdb->get_row( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared | |
| 345 | + $entry = $wpdb->get_row( $query ); // WPCS: unprepared SQL ok. | |
| 502 | 346 | $entry = self::get_meta( $entry ); |
| 503 | 347 | self::prepare_entry( $entry ); |
| 504 | 348 | |
| 505 | 349 | return $entry; |
| @@ -508,19 +352,16 @@ | ||
| 508 | 352 | /** |
| 509 | 353 | * @since 4.02.03 |
| 510 | 354 | * |
| 511 | 355 | * @param object $entry |
| 512 | - * | |
| 513 | - * @return void | |
| 514 | 356 | */ |
| 515 | 357 | private static function prepare_entry( &$entry ) { |
| 516 | - if ( ! $entry ) { | |
| 358 | + if ( empty( $entry ) ) { | |
| 517 | 359 | return; |
| 518 | 360 | } |
| 519 | 361 | |
| 520 | 362 | FrmAppHelper::unserialize_or_decode( $entry->description ); |
| 521 | - // TODO: Remove slashes on input only, not output. | |
| 522 | - $entry = wp_unslash( $entry ); | |
| 363 | + $entry = wp_unslash( $entry ); // TODO: Remove slashes on input only, not output. | |
| 523 | 364 | } |
| 524 | 365 | |
| 525 | 366 | /** |
| 526 | 367 | * @since 4.02.03 |
| @@ -525,10 +366,8 @@ | ||
| 525 | 366 | /** |
| 526 | 367 | * @since 4.02.03 |
| 527 | 368 | * |
| 528 | 369 | * @param array $entries |
| 529 | - * | |
| 530 | - * @return void | |
| 531 | 370 | */ |
| 532 | 371 | private static function prepare_entries( &$entries ) { |
| 533 | 372 | foreach ( $entries as $k => $entry ) { |
| 534 | 373 | self::prepare_entry( $entry ); |
| @@ -535,13 +374,8 @@ | ||
| 535 | 374 | $entries[ $k ] = $entry; |
| 536 | 375 | } |
| 537 | 376 | } |
| 538 | 377 | |
| 539 | - /** | |
| 540 | - * @param object|null $entry | |
| 541 | - * | |
| 542 | - * @return object|null | |
| 543 | - */ | |
| 544 | 378 | public static function get_meta( $entry ) { |
| 545 | 379 | if ( ! $entry ) { |
| 546 | 380 | return $entry; |
| 547 | 381 | } |
| @@ -552,21 +386,18 @@ | ||
| 552 | 386 | array( |
| 553 | 387 | 'item_id' => $entry->id, |
| 554 | 388 | 'field_id !' => 0, |
| 555 | 389 | ), |
| 556 | - 'field_id, meta_value, field_key, item_id, f.type' | |
| 390 | + 'field_id, meta_value, field_key, item_id' | |
| 557 | 391 | ); |
| 558 | 392 | |
| 559 | 393 | $entry->metas = array(); |
| 560 | 394 | |
| 561 | 395 | $include_key = apply_filters( 'frm_include_meta_keys', false, array( 'form_id' => $entry->form_id ) ); |
| 562 | - | |
| 563 | 396 | foreach ( $metas as $meta_val ) { |
| 564 | - FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type ); | |
| 565 | - | |
| 566 | - if ( (int) $meta_val->item_id === (int) $entry->id ) { | |
| 397 | + if ( $meta_val->item_id == $entry->id ) { | |
| 398 | + FrmAppHelper::unserialize_or_decode( $meta_val->meta_value ); | |
| 567 | 399 | $entry->metas[ $meta_val->field_id ] = $meta_val->meta_value; |
| 568 | - | |
| 569 | 400 | if ( $include_key ) { |
| 570 | 401 | $entry->metas[ $meta_val->field_key ] = $entry->metas[ $meta_val->field_id ]; |
| 571 | 402 | } |
| 572 | 403 | continue; |
| @@ -571,17 +402,18 @@ | ||
| 571 | 402 | } |
| 572 | 403 | continue; |
| 573 | 404 | } |
| 574 | 405 | |
| 575 | - // Include sub entries in an array | |
| 576 | - if ( ! isset( $entry->metas[ $meta_val->field_id ] ) ) { | |
| 406 | + // include sub entries in an array | |
| 407 | + if ( ! isset( $entry_metas[ $meta_val->field_id ] ) ) { | |
| 577 | 408 | $entry->metas[ $meta_val->field_id ] = array(); |
| 578 | 409 | } |
| 579 | 410 | |
| 411 | + FrmAppHelper::unserialize_or_decode( $meta_val->meta_value ); | |
| 580 | 412 | $entry->metas[ $meta_val->field_id ][] = $meta_val->meta_value; |
| 581 | 413 | |
| 582 | 414 | unset( $meta_val ); |
| 583 | - }//end foreach | |
| 415 | + } | |
| 584 | 416 | unset( $metas ); |
| 585 | 417 | |
| 586 | 418 | FrmDb::set_cache( $entry->id, $entry, 'frm_entry' ); |
| 587 | 419 | |
| @@ -589,60 +421,60 @@ | ||
| 589 | 421 | } |
| 590 | 422 | |
| 591 | 423 | /** |
| 592 | 424 | * @param string $id |
| 593 | - * | |
| 594 | - * @return bool | |
| 595 | 425 | */ |
| 596 | 426 | public static function exists( $id ) { |
| 427 | + global $wpdb; | |
| 428 | + | |
| 597 | 429 | if ( FrmDb::check_cache( $id, 'frm_entry' ) ) { |
| 598 | - return true; | |
| 430 | + $exists = true; | |
| 431 | + | |
| 432 | + return $exists; | |
| 599 | 433 | } |
| 600 | 434 | |
| 601 | - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'item_key' => $id ); | |
| 602 | - $id = FrmDb::get_var( 'frm_items', $where ); | |
| 435 | + if ( is_numeric( $id ) ) { | |
| 436 | + $where = array( 'id' => $id ); | |
| 437 | + } else { | |
| 438 | + $where = array( 'item_key' => $id ); | |
| 439 | + } | |
| 440 | + $id = FrmDb::get_var( $wpdb->prefix . 'frm_items', $where ); | |
| 603 | 441 | |
| 604 | - return $id && $id > 0; | |
| 442 | + return ( $id && $id > 0 ); | |
| 605 | 443 | } |
| 606 | 444 | |
| 607 | - /** | |
| 608 | - * @param array|string $where | |
| 609 | - * @param string $order_by | |
| 610 | - * @param string $limit | |
| 611 | - * @param bool $meta | |
| 612 | - * @param bool $inc_form | |
| 613 | - * | |
| 614 | - * @return array | |
| 615 | - */ | |
| 616 | 445 | public static function getAll( $where, $order_by = '', $limit = '', $meta = false, $inc_form = true ) { |
| 617 | 446 | global $wpdb; |
| 618 | 447 | |
| 619 | - $limit = FrmDb::esc_limit( $limit ); | |
| 448 | + $limit = FrmDb::esc_limit( $limit ); | |
| 449 | + | |
| 620 | 450 | $cache_key = FrmAppHelper::maybe_json_encode( $where ) . $order_by . $limit . $inc_form; |
| 621 | 451 | $entries = wp_cache_get( $cache_key, 'frm_entry' ); |
| 622 | 452 | |
| 623 | 453 | if ( false === $entries ) { |
| 624 | - $fields = 'it.id, it.item_key, it.name, it.ip, it.form_id, it.post_id, it.user_id, it.parent_item_id, it.updated_by, it.created_at, it.updated_at, it.is_draft, it.description'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 454 | + $fields = 'it.id, it.item_key, it.name, it.ip, it.form_id, it.post_id, it.user_id, it.parent_item_id, it.updated_by, it.created_at, it.updated_at, it.is_draft'; | |
| 625 | 455 | $table = $wpdb->prefix . 'frm_items it '; |
| 626 | 456 | |
| 627 | 457 | if ( $inc_form ) { |
| 628 | 458 | $fields = 'it.*, fr.name as form_name,fr.form_key as form_key'; |
| 629 | - $table .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id '; | |
| 459 | + $table .= 'LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id '; | |
| 630 | 460 | } |
| 631 | 461 | |
| 632 | 462 | if ( preg_match( '/ meta_([0-9]+)/', $order_by, $order_matches ) ) { |
| 633 | - $fields .= self::sort_by_field( $order_matches[1] ); | |
| 634 | - unset( $order_matches ); | |
| 463 | + // sort by a requested field | |
| 464 | + $field_id = (int) $order_matches[1]; | |
| 465 | + $fields .= ', (SELECT meta_value FROM ' . $wpdb->prefix . 'frm_item_metas WHERE field_id = ' . $field_id . ' AND item_id = it.id) as meta_' . $field_id; | |
| 466 | + unset( $order_matches, $field_id ); | |
| 635 | 467 | } |
| 636 | 468 | |
| 637 | - // Prepare the query | |
| 469 | + // prepare the query | |
| 638 | 470 | $query = 'SELECT ' . $fields . ' FROM ' . $table . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . $order_by . $limit; |
| 639 | 471 | |
| 640 | - $entries = $wpdb->get_results( $query, OBJECT_K ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared | |
| 472 | + $entries = $wpdb->get_results( $query, OBJECT_K ); // WPCS: unprepared SQL ok. | |
| 641 | 473 | unset( $query ); |
| 642 | 474 | |
| 643 | 475 | FrmDb::set_cache( $cache_key, $entries, 'frm_entry' ); |
| 644 | - }//end if | |
| 476 | + } | |
| 645 | 477 | |
| 646 | 478 | if ( ! $meta || ! $entries ) { |
| 647 | 479 | self::prepare_entries( $entries ); |
| 648 | 480 | return $entries; |
| @@ -653,21 +485,15 @@ | ||
| 653 | 485 | $where = array( 'it.form_id' => substr( $where, 11 ) ); |
| 654 | 486 | } |
| 655 | 487 | |
| 656 | 488 | $meta_where = array( 'field_id !' => 0 ); |
| 657 | - | |
| 658 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 659 | - if ( $limit == '' && is_array( $where ) && count( $where ) === 1 && isset( $where['it.form_id'] ) ) { | |
| 489 | + if ( $limit == '' && is_array( $where ) && count( $where ) == 1 && isset( $where['it.form_id'] ) ) { | |
| 660 | 490 | $meta_where['fi.form_id'] = $where['it.form_id']; |
| 661 | 491 | } else { |
| 662 | 492 | $meta_where['item_id'] = array_keys( $entries ); |
| 663 | 493 | } |
| 664 | 494 | |
| 665 | - $metas = FrmDb::get_results( | |
| 666 | - $wpdb->prefix . 'frm_item_metas it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id = fi.id', | |
| 667 | - $meta_where, | |
| 668 | - 'item_id, meta_value, field_id, field_key, form_id, fi.type' | |
| 669 | - ); | |
| 495 | + $metas = FrmDb::get_results( $wpdb->prefix . 'frm_item_metas it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON (it.field_id = fi.id)', $meta_where, 'item_id, meta_value, field_id, field_key, form_id' ); | |
| 670 | 496 | |
| 671 | 497 | unset( $meta_where ); |
| 672 | 498 | |
| 673 | 499 | if ( ! $metas ) { |
| @@ -683,9 +509,9 @@ | ||
| 683 | 509 | if ( ! isset( $entries[ $meta_val->item_id ]->metas ) ) { |
| 684 | 510 | $entries[ $meta_val->item_id ]->metas = array(); |
| 685 | 511 | } |
| 686 | 512 | |
| 687 | - FrmFieldsHelper::prepare_field_value( $meta_val->meta_value, $meta_val->type ); | |
| 513 | + FrmAppHelper::unserialize_or_decode( $meta_val->meta_value ); | |
| 688 | 514 | $entries[ $meta_val->item_id ]->metas[ $meta_val->field_id ] = $meta_val->meta_value; |
| 689 | 515 | unset( $m_key, $meta_val ); |
| 690 | 516 | } |
| 691 | 517 | |
| @@ -699,37 +525,15 @@ | ||
| 699 | 525 | self::prepare_entries( $entries ); |
| 700 | 526 | return $entries; |
| 701 | 527 | } |
| 702 | 528 | |
| 703 | - /** | |
| 704 | - * @param int|string $field_id | |
| 705 | - * | |
| 706 | - * @return string | |
| 707 | - */ | |
| 708 | - private static function sort_by_field( $field_id ) { | |
| 709 | - global $wpdb; | |
| 710 | - $field_id = (int) $field_id; | |
| 711 | - $field_options = FrmDb::get_var( 'frm_fields', array( 'id' => $field_id ), 'field_options' ); | |
| 712 | - FrmAppHelper::unserialize_or_decode( $field_options ); | |
| 713 | - | |
| 714 | - if ( empty( $field_options['post_field'] ) ) { | |
| 715 | - $sort = ', (SELECT meta_value FROM ' . $wpdb->prefix . 'frm_item_metas WHERE field_id = ' . $field_id . ' AND item_id = it.id) as meta_' . $field_id; | |
| 716 | - } else { | |
| 717 | - $sort = ''; | |
| 718 | - } | |
| 719 | - | |
| 720 | - return apply_filters( 'frm_handle_field_column_sort', $sort, $field_id, $field_options ); | |
| 721 | - } | |
| 722 | - | |
| 723 | 529 | // Pagination Methods |
| 724 | 530 | /** |
| 725 | - * @param array|int|string $where If int, use the form id. | |
| 726 | - * | |
| 727 | - * @return int|string | |
| 531 | + * @param int|array|string If int, use the form id. | |
| 728 | 532 | */ |
| 729 | 533 | public static function getRecordCount( $where = '' ) { |
| 730 | 534 | global $wpdb; |
| 731 | - $table_join = $wpdb->prefix . 'frm_items it JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id'; | |
| 535 | + $table_join = $wpdb->prefix . 'frm_items it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_forms fr ON it.form_id=fr.id'; | |
| 732 | 536 | |
| 733 | 537 | if ( is_numeric( $where ) ) { |
| 734 | 538 | $table_join = 'frm_items'; |
| 735 | 539 | $where = array( 'form_id' => $where ); |
| @@ -735,35 +539,29 @@ | ||
| 735 | 539 | $where = array( 'form_id' => $where ); |
| 736 | 540 | } |
| 737 | 541 | |
| 738 | 542 | if ( is_array( $where ) ) { |
| 739 | - return FrmDb::get_count( $table_join, $where ); | |
| 543 | + $count = FrmDb::get_count( $table_join, $where ); | |
| 544 | + } else { | |
| 545 | + $cache_key = 'count_' . FrmAppHelper::maybe_json_encode( $where ); | |
| 546 | + $query = 'SELECT COUNT(*) FROM ' . $table_join . FrmDb::prepend_and_or_where( ' WHERE ', $where ); | |
| 547 | + $count = FrmDb::check_cache( $cache_key, 'frm_entry', $query, 'get_var' ); | |
| 740 | 548 | } |
| 741 | 549 | |
| 742 | - $cache_key = 'count_' . FrmAppHelper::maybe_json_encode( $where ); | |
| 743 | - $query = 'SELECT COUNT(*) FROM ' . $table_join . FrmDb::prepend_and_or_where( ' WHERE ', $where ); | |
| 744 | - | |
| 745 | - return FrmDb::check_cache( $cache_key, 'frm_entry', $query, 'get_var' ); | |
| 550 | + return $count; | |
| 746 | 551 | } |
| 747 | 552 | |
| 748 | - /** | |
| 749 | - * @param int|string $p_size | |
| 750 | - * @param array|int|string $where | |
| 751 | - * | |
| 752 | - * @return int | |
| 753 | - */ | |
| 754 | 553 | public static function getPageCount( $p_size, $where = '' ) { |
| 755 | 554 | $p_size = (int) $p_size; |
| 756 | - | |
| 555 | + $count = 1; | |
| 757 | 556 | if ( $p_size ) { |
| 758 | 557 | if ( ! is_numeric( $where ) ) { |
| 759 | 558 | $where = self::getRecordCount( $where ); |
| 760 | 559 | } |
| 761 | - | |
| 762 | - return ceil( (int) $where / $p_size ); | |
| 560 | + $count = ceil( (int) $where / $p_size ); | |
| 763 | 561 | } |
| 764 | 562 | |
| 765 | - return 1; | |
| 563 | + return $count; | |
| 766 | 564 | } |
| 767 | 565 | |
| 768 | 566 | /** |
| 769 | 567 | * Prepare the data before inserting it into the database |
| @@ -769,21 +567,24 @@ | ||
| 769 | 567 | * Prepare the data before inserting it into the database |
| 770 | 568 | * |
| 771 | 569 | * @since 2.0.16 |
| 772 | 570 | * |
| 773 | - * @param array $values | |
| 571 | + * @param array $values | |
| 774 | 572 | * @param string $type |
| 775 | 573 | * |
| 776 | - * @return array New values. | |
| 574 | + * @return array $new_values | |
| 777 | 575 | */ |
| 778 | 576 | private static function before_insert_entry_in_database( &$values, $type ) { |
| 577 | + | |
| 779 | 578 | self::sanitize_entry_post( $values ); |
| 780 | 579 | |
| 781 | - if ( $type !== 'xml' ) { | |
| 580 | + if ( $type != 'xml' ) { | |
| 782 | 581 | $values = apply_filters( 'frm_pre_create_entry', $values ); |
| 783 | 582 | } |
| 784 | 583 | |
| 785 | - return self::package_entry_data( $values ); | |
| 584 | + $new_values = self::package_entry_data( $values ); | |
| 585 | + | |
| 586 | + return $new_values; | |
| 786 | 587 | } |
| 787 | 588 | |
| 788 | 589 | /** |
| 789 | 590 | * Create an entry and perform after create actions |
| @@ -792,13 +593,12 @@ | ||
| 792 | 593 | * |
| 793 | 594 | * @param array $values |
| 794 | 595 | * @param array $new_values |
| 795 | 596 | * |
| 796 | - * @return bool|int Entry ID. | |
| 597 | + * @return boolean|int $entry_id | |
| 797 | 598 | */ |
| 798 | 599 | private static function continue_to_create_entry( $values, $new_values ) { |
| 799 | 600 | $entry_id = self::insert_entry_into_database( $new_values ); |
| 800 | - | |
| 801 | 601 | if ( ! $entry_id ) { |
| 802 | 602 | return false; |
| 803 | 603 | } |
| 804 | 604 | |
| @@ -811,11 +611,9 @@ | ||
| 811 | 611 | * Sanitize the POST values before we use them |
| 812 | 612 | * |
| 813 | 613 | * @since 2.0 |
| 814 | 614 | * |
| 815 | - * @param array $values The POST values by reference. | |
| 816 | - * | |
| 817 | - * @return void | |
| 615 | + * @param array $values The POST values by reference | |
| 818 | 616 | */ |
| 819 | 617 | public static function sanitize_entry_post( &$values ) { |
| 820 | 618 | $sanitize_method = array( |
| 821 | 619 | 'form_id' => 'absint', |
| @@ -840,9 +638,9 @@ | ||
| 840 | 638 | * @since 2.0.16 |
| 841 | 639 | * |
| 842 | 640 | * @param array $values |
| 843 | 641 | * |
| 844 | - * @return array New values. | |
| 642 | + * @return array $new_values | |
| 845 | 643 | */ |
| 846 | 644 | private static function package_entry_data( &$values ) { |
| 847 | 645 | global $wpdb; |
| 848 | 646 | |
| @@ -852,9 +650,9 @@ | ||
| 852 | 650 | |
| 853 | 651 | $item_name = self::get_new_entry_name( $values, $values['item_key'] ); |
| 854 | 652 | $new_values = array( |
| 855 | 653 | 'item_key' => FrmAppHelper::get_unique_key( $values['item_key'], $wpdb->prefix . 'frm_items', 'item_key' ), |
| 856 | - 'name' => FrmAppHelper::truncate( $item_name, 255, 1, '', true ), | |
| 654 | + 'name' => FrmAppHelper::truncate( $item_name, 255, 1, '' ), | |
| 857 | 655 | 'ip' => self::get_ip( $values ), |
| 858 | 656 | 'is_draft' => self::get_is_draft_value( $values ), |
| 859 | 657 | 'form_id' => (int) self::get_entry_value( $values, 'form_id', null ), |
| 860 | 658 | 'post_id' => (int) self::get_entry_value( $values, 'post_id', 0 ), |
| @@ -864,22 +662,15 @@ | ||
| 864 | 662 | 'description' => self::get_entry_description( $values ), |
| 865 | 663 | 'user_id' => self::get_entry_user_id( $values ), |
| 866 | 664 | ); |
| 867 | 665 | |
| 868 | - $new_values['updated_by'] = $values['updated_by'] ?? $new_values['user_id']; | |
| 666 | + $new_values['updated_by'] = isset( $values['updated_by'] ) ? $values['updated_by'] : $new_values['user_id']; | |
| 869 | 667 | |
| 870 | 668 | return $new_values; |
| 871 | 669 | } |
| 872 | 670 | |
| 873 | - /** | |
| 874 | - * @param array $values | |
| 875 | - * @param string $name | |
| 876 | - * @param mixed $default | |
| 877 | - * | |
| 878 | - * @return mixed | |
| 879 | - */ | |
| 880 | 671 | private static function get_entry_value( $values, $name, $default ) { |
| 881 | - return $values[ $name ] ?? $default; | |
| 672 | + return isset( $values[ $name ] ) ? $values[ $name ] : $default; | |
| 882 | 673 | } |
| 883 | 674 | |
| 884 | 675 | /** |
| 885 | 676 | * Get the ip for a new entry. |
| @@ -896,11 +687,10 @@ | ||
| 896 | 687 | return ''; |
| 897 | 688 | } |
| 898 | 689 | |
| 899 | 690 | $ip = FrmAppHelper::get_ip_address(); |
| 900 | - | |
| 901 | 691 | if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) { |
| 902 | - return self::get_entry_value( $values, 'ip', $ip ); | |
| 692 | + $ip = self::get_entry_value( $values, 'ip', $ip ); | |
| 903 | 693 | } |
| 904 | 694 | |
| 905 | 695 | return $ip; |
| 906 | 696 | } |
| @@ -914,13 +704,9 @@ | ||
| 914 | 704 | * |
| 915 | 705 | * @return int |
| 916 | 706 | */ |
| 917 | 707 | private static function get_is_draft_value( $values ) { |
| 918 | - if ( isset( $values['frm_saving_draft'] ) && FrmEntriesHelper::DRAFT_ENTRY_STATUS === (int) $values['frm_saving_draft'] ) { | |
| 919 | - return FrmEntriesHelper::DRAFT_ENTRY_STATUS; | |
| 920 | - } | |
| 921 | - | |
| 922 | - return isset( $values['is_draft'] ) ? absint( $values['is_draft'] ) : FrmEntriesHelper::SUBMITTED_ENTRY_STATUS; | |
| 708 | + return ( ( isset( $values['frm_saving_draft'] ) && $values['frm_saving_draft'] == 1 ) || ( isset( $values['is_draft'] ) && $values['is_draft'] == 1 ) ) ? 1 : 0; | |
| 923 | 709 | } |
| 924 | 710 | |
| 925 | 711 | /** |
| 926 | 712 | * Get the created_at value for a new entry |
| @@ -944,9 +730,15 @@ | ||
| 944 | 730 | * |
| 945 | 731 | * @return string |
| 946 | 732 | */ |
| 947 | 733 | private static function get_updated_at( $values ) { |
| 948 | - return $values['updated_at'] ?? self::get_created_at( $values ); | |
| 734 | + if ( isset( $values['updated_at'] ) ) { | |
| 735 | + $updated_at = $values['updated_at']; | |
| 736 | + } else { | |
| 737 | + $updated_at = self::get_created_at( $values ); | |
| 738 | + } | |
| 739 | + | |
| 740 | + return $updated_at; | |
| 949 | 741 | } |
| 950 | 742 | |
| 951 | 743 | /** |
| 952 | 744 | * Get the description value for a new entry |
| @@ -957,18 +749,20 @@ | ||
| 957 | 749 | * |
| 958 | 750 | * @return string |
| 959 | 751 | */ |
| 960 | 752 | private static function get_entry_description( $values ) { |
| 961 | - if ( ! empty( $values['description'] ) ) { | |
| 962 | - return FrmAppHelper::maybe_json_encode( $values['description'] ); | |
| 753 | + if ( isset( $values['description'] ) && ! empty( $values['description'] ) ) { | |
| 754 | + $description = FrmAppHelper::maybe_json_encode( $values['description'] ); | |
| 755 | + } else { | |
| 756 | + $description = json_encode( | |
| 757 | + array( | |
| 758 | + 'browser' => FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ), | |
| 759 | + 'referrer' => FrmAppHelper::get_server_value( 'HTTP_REFERER' ), | |
| 760 | + ) | |
| 761 | + ); | |
| 963 | 762 | } |
| 964 | 763 | |
| 965 | - return json_encode( | |
| 966 | - array( | |
| 967 | - 'browser' => FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ), | |
| 968 | - 'referrer' => FrmAppHelper::get_server_value( 'HTTP_REFERER' ), | |
| 969 | - ) | |
| 970 | - ); | |
| 764 | + return $description; | |
| 971 | 765 | } |
| 972 | 766 | |
| 973 | 767 | /** |
| 974 | 768 | * Get the user_id value for a new entry |
| @@ -980,13 +774,15 @@ | ||
| 980 | 774 | * @return int |
| 981 | 775 | */ |
| 982 | 776 | private static function get_entry_user_id( $values ) { |
| 983 | 777 | if ( isset( $values['frm_user_id'] ) && ( is_numeric( $values['frm_user_id'] ) || FrmAppHelper::is_admin() ) ) { |
| 984 | - return $values['frm_user_id']; | |
| 778 | + $user_id = $values['frm_user_id']; | |
| 779 | + } else { | |
| 780 | + $current_user_id = get_current_user_id(); | |
| 781 | + $user_id = $current_user_id ? $current_user_id : 0; | |
| 985 | 782 | } |
| 986 | 783 | |
| 987 | - $current_user_id = get_current_user_id(); | |
| 988 | - return $current_user_id ? $current_user_id : 0; | |
| 784 | + return $user_id; | |
| 989 | 785 | } |
| 990 | 786 | |
| 991 | 787 | /** |
| 992 | 788 | * Insert new entry into the database |
| @@ -994,9 +790,9 @@ | ||
| 994 | 790 | * @since 2.0.16 |
| 995 | 791 | * |
| 996 | 792 | * @param array $new_values |
| 997 | 793 | * |
| 998 | - * @return bool|int Entry ID. | |
| 794 | + * @return int | boolean $entry_id | |
| 999 | 795 | */ |
| 1000 | 796 | private static function insert_entry_into_database( $new_values ) { |
| 1001 | 797 | global $wpdb; |
| 1002 | 798 | |
| @@ -1001,9 +797,15 @@ | ||
| 1001 | 797 | global $wpdb; |
| 1002 | 798 | |
| 1003 | 799 | $query_results = $wpdb->insert( $wpdb->prefix . 'frm_items', $new_values ); |
| 1004 | 800 | |
| 1005 | - return $query_results ? $wpdb->insert_id : false; | |
| 801 | + if ( ! $query_results ) { | |
| 802 | + $entry_id = false; | |
| 803 | + } else { | |
| 804 | + $entry_id = $wpdb->insert_id; | |
| 805 | + } | |
| 806 | + | |
| 807 | + return $entry_id; | |
| 1006 | 808 | } |
| 1007 | 809 | |
| 1008 | 810 | /** |
| 1009 | 811 | * Add the new entry to global $frm_vars |
| @@ -1009,11 +811,9 @@ | ||
| 1009 | 811 | * Add the new entry to global $frm_vars |
| 1010 | 812 | * |
| 1011 | 813 | * @since 2.0.16 |
| 1012 | 814 | * |
| 1013 | - * @param int|string $entry_id | |
| 1014 | - * | |
| 1015 | - * @return void | |
| 815 | + * @param int $entry_id | |
| 1016 | 816 | */ |
| 1017 | 817 | private static function add_new_entry_to_frm_vars( $entry_id ) { |
| 1018 | 818 | global $frm_vars; |
| 1019 | 819 | |
| @@ -1028,92 +828,31 @@ | ||
| 1028 | 828 | * Add entry metas, if there are any |
| 1029 | 829 | * |
| 1030 | 830 | * @since 2.0.16 |
| 1031 | 831 | * |
| 1032 | - * @param array $values | |
| 1033 | - * @param int|string $entry_id | |
| 1034 | - * | |
| 1035 | - * @return void | |
| 832 | + * @param array $values | |
| 833 | + * @param int $entry_id | |
| 1036 | 834 | */ |
| 1037 | 835 | private static function maybe_add_entry_metas( $values, $entry_id ) { |
| 1038 | 836 | if ( isset( $values['item_meta'] ) ) { |
| 1039 | 837 | FrmEntryMeta::update_entry_metas( $entry_id, $values['item_meta'] ); |
| 1040 | - self::maybe_add_unique_id_meta( $values, $entry_id ); | |
| 1041 | 838 | } |
| 1042 | - self::maybe_add_captcha_meta( (int) $values['form_id'], (int) $entry_id ); | |
| 1043 | 839 | } |
| 1044 | 840 | |
| 1045 | 841 | /** |
| 1046 | - * @since 6.16.3 | |
| 1047 | - * | |
| 1048 | - * @param array $values | |
| 1049 | - * @param int $entry_id | |
| 1050 | - * | |
| 1051 | - * @return void | |
| 1052 | - */ | |
| 1053 | - private static function maybe_add_unique_id_meta( $values, $entry_id ) { | |
| 1054 | - if ( ! empty( $values['parent_form_id'] ) || empty( $values['unique_id'] ) || ! self::should_check_for_unique_id_match() ) { | |
| 1055 | - return; | |
| 1056 | - } | |
| 1057 | - | |
| 1058 | - // This unique ID is inserted with JS on form submit. | |
| 1059 | - // It is used to check for duplicate entries. | |
| 1060 | - $unique_id = sanitize_key( $values['unique_id'] ); | |
| 1061 | - | |
| 1062 | - if ( ! $unique_id ) { | |
| 1063 | - return; | |
| 1064 | - } | |
| 1065 | - | |
| 1066 | - FrmEntryMeta::add_entry_meta( $entry_id, 0, '', compact( 'unique_id' ) ); | |
| 1067 | - self::flag_new_unique_key( $unique_id ); | |
| 1068 | - } | |
| 1069 | - | |
| 1070 | - /** | |
| 1071 | - * @since 5.0.15 | |
| 1072 | - * | |
| 1073 | - * @param int $form_id | |
| 1074 | - * @param int $entry_id | |
| 1075 | - * | |
| 1076 | - * @return void | |
| 1077 | - */ | |
| 1078 | - private static function maybe_add_captcha_meta( $form_id, $entry_id ) { | |
| 1079 | - global $frm_vars; | |
| 1080 | - | |
| 1081 | - if ( ! array_key_exists( 'captcha_scores', $frm_vars ) || ! array_key_exists( $form_id, $frm_vars['captcha_scores'] ) ) { | |
| 1082 | - return; | |
| 1083 | - } | |
| 1084 | - | |
| 1085 | - $captcha_score_meta = array( 'captcha_score' => $frm_vars['captcha_scores'][ $form_id ] ); | |
| 1086 | - FrmEntryMeta::add_entry_meta( $entry_id, 0, '', maybe_serialize( $captcha_score_meta ) ); | |
| 1087 | - } | |
| 1088 | - | |
| 1089 | - /** | |
| 1090 | 842 | * Trigger frm_after_create_entry hooks |
| 1091 | 843 | * |
| 1092 | 844 | * @since 2.0.16 |
| 1093 | 845 | * |
| 1094 | - * @param int $entry_id | |
| 1095 | - * @param array $values | |
| 846 | + * @param int $entry_id | |
| 1096 | 847 | * @param array $new_values |
| 1097 | - * | |
| 1098 | - * @return void | |
| 1099 | 848 | */ |
| 1100 | 849 | private static function after_entry_created_actions( $entry_id, $values, $new_values ) { |
| 1101 | - // This is a child entry. | |
| 1102 | - $is_child = isset( $values['parent_nonce'] ) && ! empty( $values['parent_form_id'] ) && wp_verify_nonce( $values['parent_nonce'], 'parent' ); | |
| 850 | + // this is a child entry | |
| 851 | + $is_child = isset( $values['parent_form_id'] ) && isset( $values['parent_nonce'] ) && ! empty( $values['parent_form_id'] ) && wp_verify_nonce( $values['parent_nonce'], 'parent' ); | |
| 1103 | 852 | |
| 1104 | 853 | do_action( 'frm_after_create_entry', $entry_id, $new_values['form_id'], compact( 'is_child' ) ); |
| 1105 | 854 | do_action( 'frm_after_create_entry_' . $new_values['form_id'], $entry_id, compact( 'is_child' ) ); |
| 1106 | - | |
| 1107 | - if ( ! empty( $values['form_key'] ) ) { | |
| 1108 | - /** | |
| 1109 | - * @since 6.30 | |
| 1110 | - * | |
| 1111 | - * @param int $entry_id | |
| 1112 | - * @param array $is_child | |
| 1113 | - */ | |
| 1114 | - do_action( 'frm_after_create_entry_' . $values['form_key'], $entry_id, compact( 'is_child' ) ); | |
| 1115 | - } | |
| 1116 | 855 | } |
| 1117 | 856 | |
| 1118 | 857 | /** |
| 1119 | 858 | * Actions to perform immediately after an entry is inserted in the frm_items database |
| @@ -1121,13 +860,12 @@ | ||
| 1121 | 860 | * @since 2.0.16 |
| 1122 | 861 | * |
| 1123 | 862 | * @param array $values |
| 1124 | 863 | * @param array $new_values |
| 1125 | - * @param int $entry_id | |
| 1126 | - * | |
| 1127 | - * @return void | |
| 864 | + * @param int $entry_id | |
| 1128 | 865 | */ |
| 1129 | 866 | private static function after_insert_entry_in_database( $values, $new_values, $entry_id ) { |
| 867 | + | |
| 1130 | 868 | self::add_new_entry_to_frm_vars( $entry_id ); |
| 1131 | 869 | |
| 1132 | 870 | self::maybe_add_entry_metas( $values, $entry_id ); |
| 1133 | 871 | |
| @@ -1140,13 +878,13 @@ | ||
| 1140 | 878 | * Perform some actions right before updating an entry |
| 1141 | 879 | * |
| 1142 | 880 | * @since 2.0.16 |
| 1143 | 881 | * |
| 1144 | - * @param int|string $id | |
| 1145 | - * @param array $values | |
| 1146 | - * @param string $update_type | |
| 882 | + * @param int $id | |
| 883 | + * @param array $values | |
| 884 | + * @param string $update_type | |
| 1147 | 885 | * |
| 1148 | - * @return bool Update. | |
| 886 | + * @return boolean $update | |
| 1149 | 887 | */ |
| 1150 | 888 | private static function before_update_entry( $id, &$values, $update_type ) { |
| 1151 | 889 | $update = true; |
| 1152 | 890 | |
| @@ -1151,14 +889,13 @@ | ||
| 1151 | 889 | $update = true; |
| 1152 | 890 | |
| 1153 | 891 | global $frm_vars; |
| 1154 | 892 | |
| 1155 | - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict | |
| 1156 | - if ( isset( $frm_vars['saved_entries'] ) && is_array( $frm_vars['saved_entries'] ) && in_array( (int) $id, $frm_vars['saved_entries'] ) ) { | |
| 893 | + if ( isset( $frm_vars['saved_entries'] ) && is_array( $frm_vars['saved_entries'] ) && in_array( (int) $id, (array) $frm_vars['saved_entries'] ) ) { | |
| 1157 | 894 | $update = false; |
| 1158 | 895 | } |
| 1159 | 896 | |
| 1160 | - if ( $update && $update_type !== 'xml' ) { | |
| 897 | + if ( $update && $update_type != 'xml' ) { | |
| 1161 | 898 | $values = apply_filters( 'frm_pre_update_entry', $values, $id ); |
| 1162 | 899 | } |
| 1163 | 900 | |
| 1164 | 901 | return $update; |
| @@ -1168,22 +905,22 @@ | ||
| 1168 | 905 | * Package the entry data for updating |
| 1169 | 906 | * |
| 1170 | 907 | * @since 2.0.16 |
| 1171 | 908 | * |
| 1172 | - * @param int $id | |
| 909 | + * @param int $id | |
| 1173 | 910 | * @param array $values |
| 1174 | 911 | * |
| 1175 | - * @return array New values. | |
| 912 | + * @return array $new_values | |
| 1176 | 913 | */ |
| 1177 | 914 | private static function package_entry_to_update( $id, $values ) { |
| 1178 | 915 | global $wpdb; |
| 1179 | 916 | |
| 1180 | 917 | $new_values = array( |
| 1181 | - 'name' => FrmAppHelper::truncate( self::get_new_entry_name( $values ), 255, 1, '', true ), | |
| 918 | + 'name' => self::get_new_entry_name( $values ), | |
| 1182 | 919 | 'form_id' => (int) self::get_entry_value( $values, 'form_id', null ), |
| 1183 | 920 | 'is_draft' => self::get_is_draft_value( $values ), |
| 1184 | 921 | 'updated_at' => current_time( 'mysql', 1 ), |
| 1185 | - 'updated_by' => $values['updated_by'] ?? get_current_user_id(), | |
| 922 | + 'updated_by' => isset( $values['updated_by'] ) ? $values['updated_by'] : get_current_user_id(), | |
| 1186 | 923 | ); |
| 1187 | 924 | |
| 1188 | 925 | if ( isset( $values['post_id'] ) ) { |
| 1189 | 926 | $new_values['post_id'] = (int) $values['post_id']; |
| @@ -1200,9 +937,11 @@ | ||
| 1200 | 937 | if ( isset( $values['frm_user_id'] ) && is_numeric( $values['frm_user_id'] ) ) { |
| 1201 | 938 | $new_values['user_id'] = $values['frm_user_id']; |
| 1202 | 939 | } |
| 1203 | 940 | |
| 1204 | - return apply_filters( 'frm_update_entry', $new_values, $id ); | |
| 941 | + $new_values = apply_filters( 'frm_update_entry', $new_values, $id ); | |
| 942 | + | |
| 943 | + return $new_values; | |
| 1205 | 944 | } |
| 1206 | 945 | |
| 1207 | 946 | /** |
| 1208 | 947 | * Perform some actions right after updating an entry |
| @@ -1208,14 +947,12 @@ | ||
| 1208 | 947 | * Perform some actions right after updating an entry |
| 1209 | 948 | * |
| 1210 | 949 | * @since 2.0.16 |
| 1211 | 950 | * |
| 1212 | - * @param bool|int $query_results | |
| 1213 | - * @param int|string $id | |
| 1214 | - * @param array $values | |
| 1215 | - * @param array $new_values | |
| 1216 | - * | |
| 1217 | - * @return void | |
| 951 | + * @param boolean|int $query_results | |
| 952 | + * @param int $id | |
| 953 | + * @param array $values | |
| 954 | + * @param array $new_values | |
| 1218 | 955 | */ |
| 1219 | 956 | private static function after_update_entry( $query_results, $id, $values, $new_values ) { |
| 1220 | 957 | if ( $query_results ) { |
| 1221 | 958 | self::clear_cache(); |
| @@ -1221,9 +958,8 @@ | ||
| 1221 | 958 | self::clear_cache(); |
| 1222 | 959 | } |
| 1223 | 960 | |
| 1224 | 961 | global $frm_vars; |
| 1225 | - | |
| 1226 | 962 | if ( ! isset( $frm_vars['saved_entries'] ) ) { |
| 1227 | 963 | $frm_vars['saved_entries'] = array(); |
| 1228 | 964 | } |
| 1229 | 965 | |
| @@ -1234,17 +970,8 @@ | ||
| 1234 | 970 | } |
| 1235 | 971 | |
| 1236 | 972 | do_action( 'frm_after_update_entry', $id, $new_values['form_id'] ); |
| 1237 | 973 | do_action( 'frm_after_update_entry_' . $new_values['form_id'], $id ); |
| 1238 | - | |
| 1239 | - if ( ! empty( $values['form_key'] ) ) { | |
| 1240 | - /** | |
| 1241 | - * @since 6.30 | |
| 1242 | - * | |
| 1243 | - * @param int $entry_id | |
| 1244 | - */ | |
| 1245 | - do_action( 'frm_after_update_entry_' . $values['form_key'], $id ); | |
| 1246 | - } | |
| 1247 | 974 | } |
| 1248 | 975 | |
| 1249 | 976 | /** |
| 1250 | 977 | * Create entry from an XML import |
| @@ -1253,12 +980,14 @@ | ||
| 1253 | 980 | * @since 2.0.16 |
| 1254 | 981 | * |
| 1255 | 982 | * @param array $values |
| 1256 | 983 | * |
| 1257 | - * @return bool|int Entry ID. | |
| 984 | + * @return int | boolean $entry_id | |
| 1258 | 985 | */ |
| 1259 | 986 | public static function create_entry_from_xml( $values ) { |
| 1260 | - return self::create_entry( $values, 'xml' ); | |
| 987 | + $entry_id = self::create_entry( $values, 'xml' ); | |
| 988 | + | |
| 989 | + return $entry_id; | |
| 1261 | 990 | } |
| 1262 | 991 | |
| 1263 | 992 | /** |
| 1264 | 993 | * Update entry from an XML import |
| @@ -1265,15 +994,17 @@ | ||
| 1265 | 994 | * Certain actions aren't necessary when importing (like saving sub entries and modifying other vals) |
| 1266 | 995 | * |
| 1267 | 996 | * @since 2.0.16 |
| 1268 | 997 | * |
| 1269 | - * @param int $id | |
| 998 | + * @param int $id | |
| 1270 | 999 | * @param array $values |
| 1271 | 1000 | * |
| 1272 | - * @return bool|int Updated. | |
| 1001 | + * @return int | boolean $updated | |
| 1273 | 1002 | */ |
| 1274 | 1003 | public static function update_entry_from_xml( $id, $values ) { |
| 1275 | - return self::update_entry( $id, $values, 'xml' ); | |
| 1004 | + $updated = self::update_entry( $id, $values, 'xml' ); | |
| 1005 | + | |
| 1006 | + return $updated; | |
| 1276 | 1007 | } |
| 1277 | 1008 | |
| 1278 | 1009 | /** |
| 1279 | 1010 | * @param string $key |
| @@ -1281,23 +1012,8 @@ | ||
| 1281 | 1012 | * @return int entry_id |
| 1282 | 1013 | */ |
| 1283 | 1014 | public static function get_id_by_key( $key ) { |
| 1284 | 1015 | $entry_id = FrmDb::get_var( 'frm_items', array( 'item_key' => sanitize_title( $key ) ) ); |
| 1016 | + | |
| 1285 | 1017 | return (int) $entry_id; |
| 1286 | - } | |
| 1287 | - | |
| 1288 | - /** | |
| 1289 | - * Get entries count. | |
| 1290 | - * | |
| 1291 | - * @since 6.8 | |
| 1292 | - * | |
| 1293 | - * @return int|string | |
| 1294 | - */ | |
| 1295 | - public static function get_entries_count() { | |
| 1296 | - $args = array( | |
| 1297 | - 'or' => 1, | |
| 1298 | - 'parent_form_id' => null, | |
| 1299 | - 'parent_form_id <' => 1, | |
| 1300 | - ); | |
| 1301 | - return self::getRecordCount( $args ); | |
| 1302 | 1018 | } |
| 1303 | 1019 | } |
