PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.0.08
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.0.08
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +183 -581 6.345.0.08 View file →
@@ -6,10 +6,9 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 - * @return bool|int id on success or false on failure.
10 + * @return int|boolean id on success or false on failure
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
15 14
@@ -16,35 +15,26 @@
16 15 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
17 16
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ),
19 + 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 - /**
38 - * Allows modifying form options before updating or creating.
39 - *
40 - * @since 5.4 Add the third param.
41 - *
42 - * @param array $options Form options.
43 - * @param array $values Form data.
44 - * @param bool $update Is form updating or creating. It's `true` if is updating.
45 - */
46 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, false );
36 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
47 37 $options = self::maybe_filter_form_options( $options );
48 38 $new_values['options'] = serialize( $options );
49 39
50 40 $wpdb->insert( $wpdb->prefix . 'frm_forms', $new_values );
@@ -60,33 +50,21 @@
60 50 /**
61 51 * @since 5.0.08
62 52 *
63 53 * @param array $options
64 - *
65 54 * @return array
66 55 */
67 56 private static function maybe_filter_form_options( $options ) {
68 - if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
69 - $options['submit_html'] = FrmAppHelper::kses_submit_button( $options['submit_html'] );
70 - }
71 - return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
57 + return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html', 'submit_html' ) );
72 58 }
73 59
74 60 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 - * @return bool|int ID on success or false on failure
61 + * @return int|boolean ID on success or false on failure
83 62 */
84 63 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 64 global $wpdb;
86 65
87 66 $values = self::getOne( $id, $blog_id );
88 -
89 67 if ( ! $values ) {
90 68 return false;
91 69 }
92 70
@@ -103,10 +81,10 @@
103 81 'is_template' => $template ? 1 : 0,
104 82 );
105 83
106 84 if ( $blog_id ) {
107 - $new_values['status'] = 'published';
108 - $new_options = $values->options;
85 + $new_values['status'] = 'published';
86 + $new_options = $values->options;
109 87 FrmAppHelper::unserialize_or_decode( $new_options );
110 88 $new_options['email_to'] = get_option( 'admin_email' );
111 89 $new_options['copy'] = false;
112 90 $new_values['options'] = $new_options;
@@ -126,9 +104,9 @@
126 104
127 105 $form_id = $wpdb->insert_id;
128 106 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 107
130 - // Update form settings after fields are created
108 + // update form settings after fields are created
131 109 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 110
133 111 return $form_id;
134 112 }
@@ -135,16 +113,10 @@
135 113
136 114 return false;
137 115 }
138 116
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 117 public static function after_duplicate( $form_id, $values ) {
146 - $new_opts = $values['options'];
118 + $new_opts = $values['options'];
147 119 FrmAppHelper::unserialize_or_decode( $new_opts );
148 120 $values['options'] = $new_opts;
149 121
150 122 if ( isset( $new_opts['success_msg'] ) ) {
@@ -152,105 +124,17 @@
152 124 }
153 125
154 126 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 127
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 128 if ( $new_opts != $values['options'] ) {
158 129 global $wpdb;
159 130 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 131 }
161 -
162 - self::switch_field_ids_in_fields( $form_id );
163 132 }
164 133
165 134 /**
166 - * Switches field ID in fields.
167 - *
168 - * @since 5.3
169 - *
170 - * @param int $form_id Form ID.
171 - *
172 - * @return void
135 + * @return int|boolean
173 136 */
174 - private static function switch_field_ids_in_fields( $form_id ) {
175 - global $wpdb;
176 -
177 - // Keys of fields that you want to check to replace field ID.
178 - $keys = array( 'default_value', 'field_options' );
179 - $sql_cols = 'fi.id';
180 -
181 - foreach ( $keys as $key ) {
182 - $sql_cols .= ',fi.' . $key;
183 - }
184 -
185 - $fields = FrmDb::get_results(
186 - "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id",
187 - array(
188 - 'or' => 1,
189 - 'fi.form_id' => $form_id,
190 - 'fr.parent_form_id' => $form_id,
191 - ),
192 - $sql_cols
193 - );
194 -
195 - if ( ! $fields || ! is_array( $fields ) ) {
196 - return;
197 - }
198 -
199 - foreach ( $fields as $field ) {
200 - self::switch_field_ids_in_field( (array) $field );
201 - }
202 - }
203 -
204 - /**
205 - * Switches field ID in a field.
206 - *
207 - * @since 5.3
208 - *
209 - * @param array $field Field array.
210 - *
211 - * @return void
212 - */
213 - private static function switch_field_ids_in_field( $field ) {
214 - $new_values = array();
215 -
216 - foreach ( $field as $key => $value ) {
217 - if ( 'id' === $key || ! $value ) {
218 - continue;
219 - }
220 -
221 - if ( ! is_string( $value ) && ! is_array( $value ) ) {
222 - continue;
223 - }
224 -
225 - if ( 'field_options' === $key ) {
226 - // Need to loop through field_options to prevent breaking serialized string when length changed.
227 - FrmAppHelper::unserialize_or_decode( $value );
228 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
229 - $new_val = serialize( $new_val );
230 - } else {
231 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
232 - }
233 -
234 - if ( $new_val !== $value ) {
235 - $new_values[ $key ] = $new_val;
236 - }
237 - }//end foreach
238 -
239 - if ( $new_values ) {
240 - FrmField::update( $field['id'], $new_values );
241 - }
242 - }
243 -
244 - /**
245 - * Update a form.
246 - *
247 - * @param int $id Form ID.
248 - * @param array $values Form values to update.
249 - * @param bool $create_link Whether this is being called from link creation.
250 - *
251 - * @return bool|int
252 - */
253 137 public static function update( $id, $values, $create_link = false ) {
254 138 global $wpdb;
255 139
256 140 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
@@ -263,23 +147,23 @@
263 147 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
264 148 }
265 149
266 150 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
267 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
268 151
152 + $new_values = self::set_update_options( array(), $values );
153 +
269 154 foreach ( $values as $value_key => $value ) {
270 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
271 - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value;
155 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
156 + $new_values[ $value_key ] = $value;
272 157 }
273 158 }
274 159
275 - if ( ! empty( $values['new_status'] ) ) {
160 + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) {
276 161 $new_values['status'] = $values['new_status'];
277 162 }
278 163
279 - if ( $new_values ) {
164 + if ( ! empty( $new_values ) ) {
280 165 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
281 -
282 166 if ( $query_results ) {
283 167 self::clear_form_cache();
284 168 }
285 169 } else {
@@ -295,37 +179,24 @@
295 179 return $query_results;
296 180 }
297 181
298 182 /**
299 - * @param array $new_values
300 - * @param array $values
301 - * @param array $args
302 - *
303 183 * @return array
304 184 */
305 - public static function set_update_options( $new_values, $values, $args = array() ) {
185 + public static function set_update_options( $new_values, $values ) {
306 186 if ( ! isset( $values['options'] ) ) {
307 187 return $new_values;
308 188 }
309 189
310 - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
190 + $options = isset( $values['options'] ) ? (array) $values['options'] : array();
311 191 FrmFormsHelper::fill_form_options( $options, $values );
312 192
313 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
314 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
315 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
316 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
193 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
194 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
195 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
196 + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
317 197
318 - /**
319 - * Allows modifying form options before updating or creating.
320 - *
321 - * @since 5.4 Added the third param.
322 - *
323 - * @param array $options Form options.
324 - * @param array $values Form data.
325 - * @param bool $update Is form updating or creating. It's `true` if is updating.
326 - */
327 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, true );
198 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
328 199 $options = self::maybe_filter_form_options( $options );
329 200 $new_values['options'] = serialize( $options );
330 201
331 202 return $new_values;
@@ -331,14 +202,11 @@
331 202 return $new_values;
332 203 }
333 204
334 205 /**
335 - * @param int $id Form ID.
336 - * @param array $values Form values array.
337 - *
338 206 * @return array
339 207 */
340 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
208 + public static function update_fields( $id, $values ) {
341 209
342 210 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
343 211 return $values;
344 212 }
@@ -343,10 +211,9 @@
343 211 return $values;
344 212 }
345 213
346 214 $all_fields = FrmField::get_all_for_form( $id );
347 -
348 - if ( ! $all_fields ) {
215 + if ( empty( $all_fields ) ) {
349 216 return $values;
350 217 }
351 218
352 219 if ( ! isset( $values['item_meta'] ) ) {
@@ -354,28 +221,28 @@
354 221 }
355 222
356 223 $field_array = array();
357 224 $existing_keys = array_keys( $values['item_meta'] );
358 -
359 225 foreach ( $all_fields as $fid ) {
360 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
361 226 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
362 227 $values['item_meta'][ $fid->id ] = '';
363 228 }
364 -
365 229 $field_array[ $fid->id ] = $fid;
366 230 }
367 231 unset( $all_fields );
368 232
369 233 foreach ( $values['item_meta'] as $field_id => $default_value ) {
370 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
234 + if ( isset( $field_array[ $field_id ] ) ) {
235 + $field = $field_array[ $field_id ];
236 + } else {
237 + $field = FrmField::getOne( $field_id );
238 + }
371 239
372 240 if ( ! $field ) {
373 241 continue;
374 242 }
375 243
376 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
377 -
244 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
378 245 if ( $is_settings_page ) {
379 246 self::get_settings_page_html( $values, $field );
380 247
381 248 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -382,20 +249,15 @@
382 249 continue;
383 250 }
384 251 }
385 252
386 - // Updating the form.
253 + //updating the form
387 254 $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field );
388 - // Don't check for POST html.
389 - unset( $update_options['custom_html'] );
255 + unset( $update_options['custom_html'] ); // don't check for POST html
390 256 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
391 257
392 - if ( ! is_array( $field->field_options ) ) {
393 - $field->field_options = array();
394 - }
395 -
396 258 foreach ( $update_options as $opt => $default ) {
397 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
259 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
398 260 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
399 261 }
400 262
401 263 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -404,104 +266,44 @@
404 266 'field_options' => $field->field_options,
405 267 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
406 268 );
407 269
408 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
409 - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
410 - if ( ! is_array( $option ) ) {
411 - continue;
412 - }
413 -
414 - foreach ( $option as $key => $item ) {
415 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
416 - }
417 - }
418 - }
419 -
420 270 self::prepare_field_update_values( $field, $values, $new_field );
421 - self::maybe_update_max_option( $field, $values, $new_field );
422 271
423 272 FrmField::update( $field_id, $new_field );
424 273
425 274 FrmField::delete_form_transient( $field->form_id );
426 - }//end foreach
275 + }
427 276 self::clear_form_cache();
428 277
429 278 return $values;
430 279 }
431 280
432 - /**
433 - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
434 - *
435 - * @since 6.7
436 - *
437 - * @param object $field
438 - * @param array $values
439 - * @param array $new_field
440 - *
441 - * @return void
442 - */
443 - private static function maybe_update_max_option( $field, $values, &$new_field ) {
444 - if ( $field->type !== 'textarea' ||
445 - empty( $values['field_options'][ 'type_' . $field->id ] ) ||
446 - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
447 - return;
448 - }
449 -
450 - $new_field['field_options']['max'] = '';
451 -
452 - /**
453 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
454 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
455 - */
456 - $_POST['field_options'][ 'max_' . $field->id ] = '';
457 - }
458 -
459 - /**
460 - * @param string $opt
461 - * @param mixed $value
462 - *
463 - * @return void
464 - */
465 281 private static function sanitize_field_opt( $opt, &$value ) {
466 - if ( ! is_string( $value ) ) {
467 - return;
282 + if ( is_string( $value ) ) {
283 + if ( $opt === 'calc' ) {
284 + $value = self::sanitize_calc( $value );
285 + } else {
286 + $value = FrmAppHelper::kses( $value, 'all' );
287 + }
288 + $value = trim( $value );
468 289 }
469 -
470 - /**
471 - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead.
472 - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized.
473 - *
474 - * @since 6.0
475 - *
476 - * @param bool $should_sanitize
477 - * @param string $opt
478 - */
479 - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt );
480 -
481 - if ( ! $should_sanitize ) {
482 - return;
483 - }
484 -
485 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
486 - $value = trim( $value );
487 290 }
488 291
489 292 /**
490 293 * @param string $value
491 - *
492 294 * @return string
493 295 */
494 296 private static function sanitize_calc( $value ) {
495 - if ( str_contains( $value, '<' ) ) {
297 + if ( false !== strpos( $value, '<' ) ) {
496 298 $value = self::normalize_calc_spaces( $value );
497 299 }
498 - // Allow <= and >=.
499 - $allow = array( '<= ', ' >=' );
300 + $allow = array( '<= ', ' >=' ); // Allow <= and >=
500 301 $temp = array( '< = ', ' > =' );
501 302 $value = str_replace( $allow, $temp, $value );
502 303 $value = strip_tags( $value );
503 - return str_replace( $temp, $allow, $value );
304 + $value = str_replace( $temp, $allow, $value );
305 + return $value;
504 306 }
505 307
506 308 /**
507 309 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -507,58 +309,41 @@
507 309 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
508 310 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
509 311 *
510 312 * @param string $calc
511 - *
512 313 * @return string
513 314 */
514 315 private static function normalize_calc_spaces( $calc ) {
515 316 // Check for a pattern with 5 parts
516 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
317 + // $1 \d the first comparison digit.
517 318 // $2 a space (optional).
518 319 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
519 320 // $4 another space (optional).
520 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
521 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
321 + // $5 \d the second comparison digit.
322 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
522 323 }
523 324
524 325 /**
525 326 * Updating the settings page
526 - *
527 - * @param array $values Form values array.
528 - * @param object $field Field object, passed by reference.
529 - *
530 - * @return void
531 327 */
532 328 private static function get_settings_page_html( $values, &$field ) {
533 329 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
534 330 $prev_opts = array();
535 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
331 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
536 332
537 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
538 - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
333 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
334 + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
539 335 $prev_opts = $field->field_options;
540 336 }
541 337
542 - if ( ! isset( $prev_opts ) ) {
543 - return;
338 + if ( isset( $prev_opts ) ) {
339 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
340 + if ( $prev_opts != $field->field_options ) {
341 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
342 + }
544 343 }
545 -
546 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
547 -
548 - // phpcs:ignore Universal.Operators.StrictComparisons
549 - if ( $prev_opts != $field->field_options ) {
550 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
551 - }
552 344 }
553 345
554 - /**
555 - * @param object $field
556 - * @param array $values
557 - * @param array $new_field
558 - *
559 - * @return void
560 - */
561 346 private static function prepare_field_update_values( $field, $values, &$new_field ) {
562 347 $field_cols = array(
563 348 'field_order' => 0,
564 349 'field_key' => '',
@@ -567,16 +352,12 @@
567 352 'description' => '',
568 353 'options' => '',
569 354 'name' => '',
570 355 );
571 -
572 356 foreach ( $field_cols as $col => $default ) {
573 - $default = $default === '' ? $field->{$col} : $default;
574 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
575 - }
357 + $default = ( $default === '' ) ? $field->{$col} : $default;
576 358
577 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
578 - $new_field['field_order'] = $field->field_order;
359 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
579 360 }
580 361
581 362 // Don't save the template option.
582 363 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -588,12 +369,9 @@
588 369 * Get a list of all form settings that should be translated
589 370 * on a multilingual site.
590 371 *
591 372 * @since 3.06.01
592 - *
593 - * @param object $form The form object.
594 - *
595 - * @return array
373 + * @param object $form - The form object
596 374 */
597 375 public static function translatable_strings( $form ) {
598 376 $strings = array(
599 377 'name',
@@ -600,12 +378,8 @@
600 378 'description',
601 379 'submit_value',
602 380 'submit_msg',
603 381 'success_msg',
604 - 'invalid_msg',
605 - 'failed_msg',
606 - 'login_msg',
607 - 'admin_permission',
608 382 );
609 383
610 384 return apply_filters( 'frm_form_strings', $strings, $form );
611 385 }
@@ -610,21 +384,19 @@
610 384 return apply_filters( 'frm_form_strings', $strings, $form );
611 385 }
612 386
613 387 /**
614 - * @param array|int $id
615 - * @param string $status
388 + * @param string $status
616 389 *
617 - * @return bool|int
390 + * @return int|boolean
618 391 */
619 392 public static function set_status( $id, $status ) {
620 - if ( 'trash' === $status ) {
393 + if ( 'trash' == $status ) {
621 394 return self::trash( $id );
622 395 }
623 396
624 397 $statuses = array( 'published', 'draft', 'trash' );
625 -
626 - if ( ! in_array( $status, $statuses, true ) ) {
398 + if ( ! in_array( $status, $statuses ) ) {
627 399 return false;
628 400 }
629 401
630 402 global $wpdb;
@@ -637,9 +409,9 @@
637 409 );
638 410 FrmDb::get_where_clause_and_values( $where );
639 411 array_unshift( $where['values'], $status );
640 412
641 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
413 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // WPCS: unprepared SQL ok.
642 414 } else {
643 415 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
644 416 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
645 417 }
@@ -651,11 +423,9 @@
651 423 return $query_results;
652 424 }
653 425
654 426 /**
655 - * @param int|string $id Form ID.
656 - *
657 - * @return bool|int
427 + * @return int|boolean
658 428 */
659 429 public static function trash( $id ) {
660 430 if ( ! EMPTY_TRASH_DAYS ) {
661 431 return self::destroy( $id );
@@ -661,17 +431,12 @@
661 431 return self::destroy( $id );
662 432 }
663 433
664 434 $form = self::getOne( $id );
665 -
666 435 if ( ! $form ) {
667 436 return false;
668 437 }
669 438
670 - if ( $form->status === 'trash' ) {
671 - return false;
672 - }
673 -
674 439 $options = $form->options;
675 440 $options['trash_time'] = time();
676 441
677 442 global $wpdb;
@@ -704,26 +469,21 @@
704 469 return $query_results;
705 470 }
706 471
707 472 /**
708 - * @param int|string $id Form ID.
709 - *
710 - * @return bool|int
473 + * @return int|boolean
711 474 */
712 475 public static function destroy( $id ) {
713 476 global $wpdb;
714 477
715 478 $form = self::getOne( $id );
716 -
717 479 if ( ! $form ) {
718 480 return false;
719 481 }
720 -
721 482 $id = $form->id;
722 483
723 484 // Disconnect the entries from this form
724 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
725 -
485 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
726 486 foreach ( $entries as $entry_id ) {
727 487 FrmEntry::destroy( $entry_id );
728 488 unset( $entry_id );
729 489 }
@@ -728,29 +488,23 @@
728 488 unset( $entry_id );
729 489 }
730 490
731 491 // Disconnect the fields from this form
732 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
492 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
733 493
734 494 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
495 + if ( $query_results ) {
496 + // Delete all form actions linked to this form
497 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
498 + $action_control->destroy( $id, 'all' );
735 499
736 - if ( ! $query_results ) {
737 - return $query_results;
500 + // Clear form caching
501 + self::clear_form_cache();
502 +
503 + do_action( 'frm_destroy_form', $id );
504 + do_action( 'frm_destroy_form_' . $id );
738 505 }
739 506
740 - // Delete all form actions linked to this form
741 - /**
742 - * @var FrmFormAction
743 - */
744 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
745 - $action_control->destroy( $id, 'all' );
746 -
747 - // Clear form caching
748 - self::clear_form_cache();
749 -
750 - do_action( 'frm_destroy_form', $id );
751 - do_action( 'frm_destroy_form_' . $id );
752 -
753 507 return $query_results;
754 508 }
755 509
756 510 /**
@@ -755,34 +509,29 @@
755 509
756 510 /**
757 511 * Delete trashed forms based on how long they have been trashed
758 512 *
759 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
760 - *
761 513 * @return int The number of forms deleted
762 514 */
763 515 public static function scheduled_delete( $delete_timestamp = '' ) {
764 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
516 + global $wpdb;
765 517
518 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' );
519 +
766 520 if ( ! $trash_forms ) {
767 - return 0;
521 + return;
768 522 }
769 523
770 - if ( ! $delete_timestamp ) {
524 + if ( empty( $delete_timestamp ) ) {
771 525 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
772 526 }
773 527
774 528 $count = 0;
775 -
776 529 foreach ( $trash_forms as $form ) {
777 530 FrmAppHelper::unserialize_or_decode( $form->options );
778 -
779 531 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
780 532 self::destroy( $form->id );
781 -
782 - if ( empty( $form->parent_form_id ) ) {
783 - ++$count;
784 - }
533 + $count ++;
785 534 }
786 535
787 536 unset( $form );
788 537 }
@@ -790,24 +539,23 @@
790 539 return $count;
791 540 }
792 541
793 542 /**
794 - * @param int|string $id Form ID or key.
795 - *
796 543 * @return string form name
797 544 */
798 545 public static function getName( $id ) {
799 546 $form = FrmDb::check_cache( $id, 'frm_form' );
547 + if ( $form ) {
548 + $r = stripslashes( $form->name );
800 549
801 - if ( $form ) {
802 - return stripslashes( $form->name );
550 + return $r;
803 551 }
804 552
805 553 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
806 554 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
555 + $r = stripslashes( $r );
807 556
808 - // An empty form name can result in a null value.
809 - return is_null( $r ) ? '' : stripslashes( $r );
557 + return $r;
810 558 }
811 559
812 560 /**
813 561 * @since 3.0
@@ -822,9 +570,9 @@
822 570
823 571 /**
824 572 * @since 3.0
825 573 *
826 - * @param int|string $id
574 + * @param int $id
827 575 *
828 576 * @return string form key
829 577 */
830 578 public static function get_key_by_id( $id ) {
@@ -829,57 +577,59 @@
829 577 */
830 578 public static function get_key_by_id( $id ) {
831 579 $id = (int) $id;
832 580 $cache = FrmDb::check_cache( $id, 'frm_form' );
833 -
834 581 if ( $cache ) {
835 582 return $cache->form_key;
836 583 }
837 584
838 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
585 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
586 +
587 + return $key;
839 588 }
840 589
841 590 /**
842 591 * If $form is numeric, get the form object
843 592 *
593 + * @param object|int $form
594 + *
844 595 * @since 2.0.9
845 - *
846 - * @param array|int|object $form
847 - *
848 - * @return void
849 596 */
850 597 public static function maybe_get_form( &$form ) {
851 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
598 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
852 599 $form = self::getOne( $form );
853 600 }
854 601 }
855 602
856 603 /**
857 - * @param int|string $id
858 - * @param false|int $blog_id
859 - *
860 - * @return stdClass|null
604 + * @return object form
861 605 */
862 606 public static function getOne( $id, $blog_id = false ) {
863 607 global $wpdb;
864 608
865 609 if ( $blog_id && is_multisite() ) {
866 - $prefix = $wpdb->get_blog_prefix( $blog_id );
610 + global $wpmuBaseTablePrefix;
611 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
612 +
867 613 $table_name = $prefix . 'frm_forms';
868 614 } else {
869 615 $table_name = $wpdb->prefix . 'frm_forms';
870 616 $cache = wp_cache_get( $id, 'frm_form' );
871 -
872 617 if ( $cache ) {
873 618 if ( isset( $cache->options ) ) {
874 619 FrmAppHelper::unserialize_or_decode( $cache->options );
875 620 }
876 621
877 - return self::prepare_form_row_data( $cache );
622 + return wp_unslash( $cache );
878 623 }
879 624 }
880 625
881 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
626 + if ( is_numeric( $id ) ) {
627 + $where = array( 'id' => $id );
628 + } else {
629 + $where = array( 'form_key' => $id );
630 + }
631 +
882 632 $results = FrmDb::get_row( $table_name, $where );
883 633
884 634 if ( isset( $results->options ) ) {
885 635 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -885,50 +635,18 @@
885 635 FrmDb::set_cache( $results->id, $results, 'frm_form' );
886 636 FrmAppHelper::unserialize_or_decode( $results->options );
887 637 }
888 638
889 - return self::prepare_form_row_data( $results );
639 + return apply_filters( 'frm_form_object', wp_unslash( $results ) );
890 640 }
891 641
892 642 /**
893 - * Make sure that if $row is an object, that $row->options is an array and not a string.
894 - *
895 - * @since 6.8.3
896 - *
897 - * @param stdClass|null $row The database row for a target form.
898 - *
899 - * @return stdClass|null
643 + * @return object|array of objects
900 644 */
901 - private static function prepare_form_row_data( $row ) {
902 - $row = wp_unslash( $row );
903 -
904 - if ( ! is_object( $row ) ) {
905 - return $row;
906 - }
907 -
908 - if ( ! is_array( $row->options ) ) {
909 - $row->options = FrmFormsHelper::get_default_opts();
910 - }
911 -
912 - /**
913 - * @since 4.03.02
914 - *
915 - * @param stdClass $row
916 - */
917 - return apply_filters( 'frm_form_object', $row );
918 - }
919 -
920 - /**
921 - * @param array|string $where Where conditions array or raw WHERE string.
922 - * @param string $order_by Order by clause.
923 - * @param int|string $limit Limit clause or number.
924 - *
925 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
926 - */
927 645 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
928 - if ( is_array( $where ) && $where ) {
929 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
930 - // Don't get trashed templates
646 + if ( is_array( $where ) && ! empty( $where ) ) {
647 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
648 + // don't get trashed templates
931 649 $where['status'] = array( null, '', 'published' );
932 650 }
933 651
934 652 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -934,11 +652,11 @@
934 652 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
935 653 } else {
936 654 global $wpdb;
937 655
938 - // The query has already been prepared if this is not an array.
939 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
940 - $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
656 + // the query has already been prepared if this is not an array
657 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
658 + $results = $wpdb->get_results( $query ); // WPCS: unprepared SQL ok.
941 659 }
942 660
943 661 if ( $results ) {
944 662 foreach ( $results as $result ) {
@@ -946,10 +664,10 @@
946 664 FrmAppHelper::unserialize_or_decode( $result->options );
947 665 }
948 666 }
949 667
950 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
951 - // Return the first form object if we are only getting one form
668 + if ( $limit == ' LIMIT 1' || $limit == 1 ) {
669 + // return the first form object if we are only getting one form
952 670 $results = reset( $results );
953 671 }
954 672
955 673 return wp_unslash( $results );
@@ -958,24 +676,20 @@
958 676 /**
959 677 * Get all published forms
960 678 *
961 679 * @since 2.0
962 - *
963 - * @param array $query
964 - * @param int $limit
965 - * @param string $inc_children
966 - *
967 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
680 + * @return array of forms
968 681 */
969 682 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
970 683 $query['is_template'] = 0;
971 684 $query['status'] = array( null, '', 'published' );
972 -
973 - if ( $inc_children === 'exclude' ) {
685 + if ( $inc_children == 'exclude' ) {
974 686 $query['parent_form_id'] = array( null, 0 );
975 687 }
976 688
977 - return self::getAll( $query, 'name', $limit );
689 + $forms = self::getAll( $query, 'name', $limit );
690 +
691 + return $forms;
978 692 }
979 693
980 694 /**
981 695 * @return object count of forms
@@ -980,16 +694,18 @@
980 694 /**
981 695 * @return object count of forms
982 696 */
983 697 public static function get_count() {
698 + global $wpdb;
699 +
984 700 $cache_key = 'frm_form_counts';
985 - $counts = wp_cache_get( $cache_key, 'frm_form' );
986 701
702 + $counts = wp_cache_get( $cache_key, 'frm_form' );
987 703 if ( false !== $counts ) {
988 704 return $counts;
989 705 }
990 706
991 - $results = FrmDb::get_results(
707 + $results = (array) FrmDb::get_results(
992 708 'frm_forms',
993 709 array(
994 710 'or' => 1,
995 711 'parent_form_id' => null,
@@ -1001,18 +717,20 @@
1001 717 $statuses = array( 'published', 'draft', 'template', 'trash' );
1002 718 $counts = array_fill_keys( $statuses, 0 );
1003 719
1004 720 foreach ( $results as $row ) {
1005 - if ( 'trash' === $row->status ) {
1006 - ++$counts['trash'];
1007 - } elseif ( $row->is_template ) {
1008 - ++$counts['template'];
721 + if ( 'trash' != $row->status ) {
722 + if ( $row->is_template ) {
723 + $counts['template'] ++;
724 + } else {
725 + $counts['published'] ++;
726 + }
1009 727 } else {
1010 - ++$counts['published'];
728 + $counts['trash'] ++;
1011 729 }
1012 730
1013 - if ( 'draft' === $row->status ) {
1014 - ++$counts['draft'];
731 + if ( 'draft' == $row->status ) {
732 + $counts['draft'] ++;
1015 733 }
1016 734
1017 735 unset( $row );
1018 736 }
@@ -1028,10 +746,8 @@
1028 746 * Called when a form is created, updated, duplicated, or deleted
1029 747 * or when the form status is changed
1030 748 *
1031 749 * @since 2.0.4
1032 - *
1033 - * @return void
1034 750 */
1035 751 public static function clear_form_cache() {
1036 752 FrmDb::cache_delete_group( 'frm_form' );
1037 753 }
@@ -1036,29 +752,23 @@
1036 752 FrmDb::cache_delete_group( 'frm_form' );
1037 753 }
1038 754
1039 755 /**
1040 - * @param array $values Form values to validate.
1041 - *
1042 756 * @return array of errors
1043 757 */
1044 758 public static function validate( $values ) {
1045 759 $errors = array();
760 +
1046 761 return apply_filters( 'frm_validate_form', $errors, $values );
1047 762 }
1048 763
1049 - /**
1050 - * @param object|null $form
1051 - *
1052 - * @return array
1053 - */
1054 764 public static function get_params( $form = null ) {
1055 765 global $frm_vars;
1056 766
1057 - if ( $form ) {
767 + if ( ! $form ) {
768 + $form = self::getAll( array(), 'name', 1 );
769 + } else {
1058 770 self::maybe_get_form( $form );
1059 - } else {
1060 - $form = self::getAll( array(), 'name', 1 );
1061 771 }
1062 772
1063 773 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1064 774 return $frm_vars['form_params'][ $form->id ];
@@ -1063,9 +773,9 @@
1063 773 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1064 774 return $frm_vars['form_params'][ $form->id ];
1065 775 }
1066 776
1067 - $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
777 + $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // WPCS: CSRF ok.
1068 778 $action = apply_filters( 'frm_show_new_entry_page', FrmAppHelper::get_param( $action_var, 'new', 'get', 'sanitize_title' ), $form );
1069 779
1070 780 $default_values = array(
1071 781 'id' => '',
@@ -1081,18 +791,16 @@
1081 791 );
1082 792
1083 793 $values = array();
1084 794 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1085 -
1086 795 if ( ! $values['posted_form_id'] ) {
1087 796 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1088 797 }
1089 798
1090 - // phpcs:ignore Universal.Operators.StrictComparisons
1091 799 if ( $form->id == $values['posted_form_id'] ) {
1092 - // If there are two forms on the same page, make sure not to submit both.
800 + //if there are two forms on the same page, make sure not to submit both
1093 801 foreach ( $default_values as $var => $default ) {
1094 - if ( $var === 'action' ) {
802 + if ( $var == 'action' ) {
1095 803 $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1096 804 } else {
1097 805 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1098 806 }
@@ -1104,10 +812,10 @@
1104 812 unset( $var, $default );
1105 813 }
1106 814 }
1107 815
1108 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
1109 - ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
816 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
817 + ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // WPCS: CSRF ok.
1110 818 ) {
1111 819 $values['action'] = 'new';
1112 820 }
1113 821
@@ -1113,11 +821,8 @@
1113 821
1114 822 return $values;
1115 823 }
1116 824
1117 - /**
1118 - * @return array
1119 - */
1120 825 public static function list_page_params() {
1121 826 $values = array();
1122 827 $defaults = array(
1123 828 'template' => 0,
@@ -1127,9 +832,8 @@
1127 832 'search' => '',
1128 833 'sort' => '',
1129 834 'sdir' => '',
1130 835 );
1131 -
1132 836 foreach ( $defaults as $var => $default ) {
1133 837 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1134 838 }
1135 839
@@ -1135,16 +839,10 @@
1135 839
1136 840 return $values;
1137 841 }
1138 842
1139 - /**
1140 - * @param int|object|string|null $form
1141 - *
1142 - * @return array
1143 - */
1144 843 public static function get_admin_params( $form = null ) {
1145 844 $form_id = $form;
1146 -
1147 845 if ( $form === null ) {
1148 846 $form_id = self::get_current_form_id();
1149 847 } elseif ( $form && is_object( $form ) ) {
1150 848 $form_id = $form->id;
@@ -1162,9 +860,8 @@
1162 860 'sdir' => '',
1163 861 'fid' => '',
1164 862 'keep_post' => '',
1165 863 );
1166 -
1167 864 foreach ( $defaults as $var => $default ) {
1168 865 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1169 866 }
1170 867
@@ -1170,55 +867,47 @@
1170 867
1171 868 return $values;
1172 869 }
1173 870
1174 - /**
1175 - * @param string $default_form
1176 - *
1177 - * @return int|string
1178 - */
1179 871 public static function get_current_form_id( $default_form = 'none' ) {
1180 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1181 - return $form ? $form->id : 0;
872 + if ( 'first' == $default_form ) {
873 + $form = self::get_current_form();
874 + } else {
875 + $form = self::maybe_get_current_form();
876 + }
877 + $form_id = $form ? $form->id : 0;
878 +
879 + return $form_id;
1182 880 }
1183 881
1184 - /**
1185 - * @param int|string $form_id
1186 - *
1187 - * @return false|int|object|string
1188 - */
1189 882 public static function maybe_get_current_form( $form_id = 0 ) {
1190 883 global $frm_vars;
1191 884
1192 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
885 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1193 886 return $frm_vars['current_form'];
1194 887 }
1195 888
1196 889 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
890 + if ( $form_id ) {
891 + $form_id = self::set_current_form( $form_id );
892 + }
1197 893
1198 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
894 + return $form_id;
1199 895 }
1200 896
1201 - /**
1202 - * @param int $form_id
1203 - *
1204 - * @return false|object
1205 - */
1206 897 public static function get_current_form( $form_id = 0 ) {
1207 898 $form = self::maybe_get_current_form( $form_id );
1208 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
899 + if ( is_numeric( $form ) ) {
900 + $form = self::set_current_form( $form );
901 + }
902 +
903 + return $form;
1209 904 }
1210 905
1211 - /**
1212 - * @param int $form_id
1213 - *
1214 - * @return false|object
1215 - */
1216 906 public static function set_current_form( $form_id ) {
1217 907 global $frm_vars;
1218 908
1219 909 $query = array();
1220 -
1221 910 if ( $form_id ) {
1222 911 $query['id'] = $form_id;
1223 912 }
1224 913
@@ -1226,19 +915,11 @@
1226 915
1227 916 return $frm_vars['current_form'];
1228 917 }
1229 918
1230 - /**
1231 - * @param object $form
1232 - * @param int|string $this_load
1233 - * @param bool $global_load
1234 - *
1235 - * @return bool
1236 - */
1237 919 public static function is_form_loaded( $form, $this_load, $global_load ) {
1238 920 global $frm_vars;
1239 921 $small_form = new stdClass();
1240 -
1241 922 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1242 923 $small_form->{$var} = $form->{$var};
1243 924 unset( $var );
1244 925 }
@@ -1244,14 +925,14 @@
1244 925 }
1245 926
1246 927 $frm_vars['forms_loaded'][] = $small_form;
1247 928
1248 - if ( $this_load && ! $global_load ) {
929 + if ( $this_load && empty( $global_load ) ) {
1249 930 $global_load = true;
1250 931 $frm_vars['load_css'] = true;
1251 932 }
1252 933
1253 - return empty( $frm_vars['css_loaded'] ) && $global_load;
934 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1254 935 }
1255 936
1256 937 /**
1257 938 * @since 4.06.03
@@ -1259,9 +940,9 @@
1259 940 * @param object $form
1260 941 *
1261 942 * @return bool
1262 943 */
1263 - public static function is_visible_to_user( $form ) {
944 + public static function &is_visible_to_user( $form ) {
1264 945 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1265 946 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1266 947 } else {
1267 948 $visible = true;
@@ -1266,39 +947,26 @@
1266 947 } else {
1267 948 $visible = true;
1268 949 }
1269 950
1270 - /**
1271 - * @since 6.25
1272 - *
1273 - * @param bool $visible
1274 - * @param object $form
1275 - */
1276 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
951 + return $visible;
1277 952 }
1278 953
1279 - /**
1280 - * @param object $form
1281 - *
1282 - * @return bool
1283 - */
1284 954 public static function show_submit( $form ) {
1285 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1286 - return apply_filters( 'frm_show_submit_button', $show, $form );
955 + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() );
956 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
957 +
958 + return $show;
1287 959 }
1288 960
1289 961 /**
1290 962 * @since 2.3
1291 - *
1292 - * @param array $atts Attributes including form, option, and default.
1293 - *
1294 - * @return mixed
1295 963 */
1296 964 public static function get_option( $atts ) {
1297 - $form = $atts['form'];
1298 - $default = $atts['default'] ?? '';
965 + $form = $atts['form'];
966 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1299 967
1300 - return $form->options[ $atts['option'] ] ?? $default;
968 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1301 969 }
1302 970
1303 971 /**
1304 972 * Get the link to edit this form.
@@ -1303,12 +971,9 @@
1303 971 /**
1304 972 * Get the link to edit this form.
1305 973 *
1306 974 * @since 4.0
1307 - *
1308 975 * @param int $form_id The id of the form.
1309 - *
1310 - * @return string
1311 976 */
1312 977 public static function get_edit_link( $form_id ) {
1313 978 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1314 979 }
@@ -1313,65 +978,9 @@
1313 978 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1314 979 }
1315 980
1316 981 /**
1317 - * Check if the "Submit this form with AJAX" setting is toggled on.
1318 - *
1319 - * @since 6.2
1320 - *
1321 - * @param stdClass $form
1322 - *
1323 - * @return bool
1324 - */
1325 - public static function is_ajax_on( $form ) {
1326 - return ! empty( $form->options['ajax_submit'] );
1327 - }
1328 -
1329 - /**
1330 - * Get the latest form available.
1331 - *
1332 - * @since 6.8
1333 - *
1334 - * @return object
1335 - */
1336 - public static function get_latest_form() {
1337 - $args = array(
1338 - array(
1339 - 'or' => 1,
1340 - 'parent_form_id' => null,
1341 - 'parent_form_id <' => 1,
1342 - ),
1343 - 'is_template' => 0,
1344 - 'status !' => 'trash',
1345 - );
1346 -
1347 - return self::getAll( $args, 'created_at desc', 1 );
1348 - }
1349 -
1350 - /**
1351 - * Count and return total forms.
1352 - *
1353 - * @since 6.8
1354 - *
1355 - * @return int
1356 - */
1357 - public static function get_forms_count() {
1358 - $args = array(
1359 - array(
1360 - 'or' => 1,
1361 - 'parent_form_id' => null,
1362 - 'parent_form_id <' => 1,
1363 - ),
1364 - 'is_template' => 0,
1365 - 'status !' => 'trash',
1366 - );
1367 -
1368 - return FrmDb::get_count( 'frm_forms', $args );
1369 - }
1370 -
1371 - /**
1372 - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1373 - *
982 + * @deprecated 3.0
1374 983 * @codeCoverageIgnore
1375 984 *
1376 985 * @param string $key
1377 986 *
@@ -1377,22 +986,15 @@
1377 986 *
1378 987 * @return int form id
1379 988 */
1380 989 public static function getIdByKey( $key ) {
1381 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
1382 - return self::get_id_by_key( $key );
990 + return FrmFormDeprecated::getIdByKey( $key );
1383 991 }
1384 992
1385 993 /**
1386 - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1387 - *
994 + * @deprecated 3.0
1388 995 * @codeCoverageIgnore
1389 - *
1390 - * @param int|string $id
1391 - *
1392 - * @return string
1393 996 */
1394 997 public static function getKeyById( $id ) {
1395 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );
1396 - return self::get_key_by_id( $id );
998 + return FrmFormDeprecated::getKeyById( $id );
1397 999 }
1398 1000 }