| @@ -6,10 +6,9 @@ | ||
| 6 | 6 | class FrmForm { |
| 7 | 7 | |
| 8 | 8 | /** |
| 9 | 9 | * @param array $values |
| 10 | - * | |
| 11 | - * @return bool|int id on success or false on failure. | |
| 10 | + * @return int|boolean id on success or false on failure | |
| 12 | 11 | */ |
| 13 | 12 | public static function create( $values ) { |
| 14 | 13 | global $wpdb; |
| 15 | 14 | |
| @@ -16,35 +15,26 @@ | ||
| 16 | 15 | $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) ); |
| 17 | 16 | |
| 18 | 17 | $new_values = array( |
| 19 | 18 | 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ), |
| 20 | - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ), | |
| 19 | + 'name' => $values['name'], | |
| 21 | 20 | 'description' => $values['description'], |
| 22 | - 'status' => $values['status'] ?? 'published', | |
| 23 | - 'logged_in' => $values['logged_in'] ?? 0, | |
| 21 | + 'status' => isset( $values['status'] ) ? $values['status'] : 'published', | |
| 22 | + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0, | |
| 24 | 23 | 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0, |
| 25 | 24 | 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0, |
| 26 | 25 | 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0, |
| 27 | - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ), | |
| 26 | + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ), | |
| 28 | 27 | ); |
| 29 | 28 | |
| 30 | 29 | $options = isset( $values['options'] ) ? (array) $values['options'] : array(); |
| 31 | 30 | FrmFormsHelper::fill_form_options( $options, $values ); |
| 32 | 31 | |
| 33 | - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' ); | |
| 34 | - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' ); | |
| 35 | - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' ); | |
| 32 | + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' ); | |
| 33 | + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' ); | |
| 34 | + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); | |
| 36 | 35 | |
| 37 | - /** | |
| 38 | - * Allows modifying form options before updating or creating. | |
| 39 | - * | |
| 40 | - * @since 5.4 Add the third param. | |
| 41 | - * | |
| 42 | - * @param array $options Form options. | |
| 43 | - * @param array $values Form data. | |
| 44 | - * @param bool $update Is form updating or creating. It's `true` if is updating. | |
| 45 | - */ | |
| 46 | - $options = apply_filters( 'frm_form_options_before_update', $options, $values, false ); | |
| 36 | + $options = apply_filters( 'frm_form_options_before_update', $options, $values ); | |
| 47 | 37 | $options = self::maybe_filter_form_options( $options ); |
| 48 | 38 | $new_values['options'] = serialize( $options ); |
| 49 | 39 | |
| 50 | 40 | $wpdb->insert( $wpdb->prefix . 'frm_forms', $new_values ); |
| @@ -60,33 +50,21 @@ | ||
| 60 | 50 | /** |
| 61 | 51 | * @since 5.0.08 |
| 62 | 52 | * |
| 63 | 53 | * @param array $options |
| 64 | - * | |
| 65 | 54 | * @return array |
| 66 | 55 | */ |
| 67 | 56 | private static function maybe_filter_form_options( $options ) { |
| 68 | - if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) { | |
| 69 | - $options['submit_html'] = FrmAppHelper::kses_submit_button( $options['submit_html'] ); | |
| 70 | - } | |
| 71 | - return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) ); | |
| 57 | + return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html', 'submit_html' ) ); | |
| 72 | 58 | } |
| 73 | 59 | |
| 74 | 60 | /** |
| 75 | - * Duplicate a form. | |
| 76 | - * | |
| 77 | - * @param int $id Form ID to duplicate. | |
| 78 | - * @param bool $template Whether the duplicated form is a template. | |
| 79 | - * @param bool $copy_keys Whether to copy the original form key. | |
| 80 | - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site. | |
| 81 | - * | |
| 82 | - * @return bool|int ID on success or false on failure | |
| 61 | + * @return int|boolean ID on success or false on failure | |
| 83 | 62 | */ |
| 84 | 63 | public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) { |
| 85 | 64 | global $wpdb; |
| 86 | 65 | |
| 87 | 66 | $values = self::getOne( $id, $blog_id ); |
| 88 | - | |
| 89 | 67 | if ( ! $values ) { |
| 90 | 68 | return false; |
| 91 | 69 | } |
| 92 | 70 | |
| @@ -103,10 +81,10 @@ | ||
| 103 | 81 | 'is_template' => $template ? 1 : 0, |
| 104 | 82 | ); |
| 105 | 83 | |
| 106 | 84 | if ( $blog_id ) { |
| 107 | - $new_values['status'] = 'published'; | |
| 108 | - $new_options = $values->options; | |
| 85 | + $new_values['status'] = 'published'; | |
| 86 | + $new_options = $values->options; | |
| 109 | 87 | FrmAppHelper::unserialize_or_decode( $new_options ); |
| 110 | 88 | $new_options['email_to'] = get_option( 'admin_email' ); |
| 111 | 89 | $new_options['copy'] = false; |
| 112 | 90 | $new_values['options'] = $new_options; |
| @@ -126,9 +104,9 @@ | ||
| 126 | 104 | |
| 127 | 105 | $form_id = $wpdb->insert_id; |
| 128 | 106 | FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id ); |
| 129 | 107 | |
| 130 | - // Update form settings after fields are created | |
| 108 | + // update form settings after fields are created | |
| 131 | 109 | do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) ); |
| 132 | 110 | |
| 133 | 111 | return $form_id; |
| 134 | 112 | } |
| @@ -135,16 +113,10 @@ | ||
| 135 | 113 | |
| 136 | 114 | return false; |
| 137 | 115 | } |
| 138 | 116 | |
| 139 | - /** | |
| 140 | - * @param int $form_id | |
| 141 | - * @param array $values | |
| 142 | - * | |
| 143 | - * @return void | |
| 144 | - */ | |
| 145 | 117 | public static function after_duplicate( $form_id, $values ) { |
| 146 | - $new_opts = $values['options']; | |
| 118 | + $new_opts = $values['options']; | |
| 147 | 119 | FrmAppHelper::unserialize_or_decode( $new_opts ); |
| 148 | 120 | $values['options'] = $new_opts; |
| 149 | 121 | |
| 150 | 122 | if ( isset( $new_opts['success_msg'] ) ) { |
| @@ -152,107 +124,17 @@ | ||
| 152 | 124 | } |
| 153 | 125 | |
| 154 | 126 | $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id ); |
| 155 | 127 | |
| 156 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 157 | 128 | if ( $new_opts != $values['options'] ) { |
| 158 | 129 | global $wpdb; |
| 159 | 130 | $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) ); |
| 160 | 131 | } |
| 161 | - | |
| 162 | - self::switch_field_ids_in_fields( $form_id ); | |
| 163 | 132 | } |
| 164 | 133 | |
| 165 | 134 | /** |
| 166 | - * Switches field ID in fields. | |
| 167 | - * | |
| 168 | - * @since 5.3 | |
| 169 | - * @since 6.35 The description column is checked too, so a field id in a description survives a | |
| 170 | - * duplicate or import when the field it points at is created afterwards. | |
| 171 | - * | |
| 172 | - * @param int $form_id Form ID. | |
| 173 | - * | |
| 174 | - * @return void | |
| 135 | + * @return int|boolean | |
| 175 | 136 | */ |
| 176 | - private static function switch_field_ids_in_fields( $form_id ) { | |
| 177 | - global $wpdb; | |
| 178 | - | |
| 179 | - // Keys of fields that you want to check to replace field ID. | |
| 180 | - $keys = array( 'default_value', 'description', 'field_options' ); | |
| 181 | - $sql_cols = 'fi.id'; | |
| 182 | - | |
| 183 | - foreach ( $keys as $key ) { | |
| 184 | - $sql_cols .= ',fi.' . $key; | |
| 185 | - } | |
| 186 | - | |
| 187 | - $fields = FrmDb::get_results( | |
| 188 | - "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id", | |
| 189 | - array( | |
| 190 | - 'or' => 1, | |
| 191 | - 'fi.form_id' => $form_id, | |
| 192 | - 'fr.parent_form_id' => $form_id, | |
| 193 | - ), | |
| 194 | - $sql_cols | |
| 195 | - ); | |
| 196 | - | |
| 197 | - if ( ! $fields || ! is_array( $fields ) ) { | |
| 198 | - return; | |
| 199 | - } | |
| 200 | - | |
| 201 | - foreach ( $fields as $field ) { | |
| 202 | - self::switch_field_ids_in_field( (array) $field ); | |
| 203 | - } | |
| 204 | - } | |
| 205 | - | |
| 206 | - /** | |
| 207 | - * Switches field ID in a field. | |
| 208 | - * | |
| 209 | - * @since 5.3 | |
| 210 | - * | |
| 211 | - * @param array $field Field array. | |
| 212 | - * | |
| 213 | - * @return void | |
| 214 | - */ | |
| 215 | - private static function switch_field_ids_in_field( $field ) { | |
| 216 | - $new_values = array(); | |
| 217 | - | |
| 218 | - foreach ( $field as $key => $value ) { | |
| 219 | - if ( 'id' === $key || ! $value ) { | |
| 220 | - continue; | |
| 221 | - } | |
| 222 | - | |
| 223 | - if ( ! is_string( $value ) && ! is_array( $value ) ) { | |
| 224 | - continue; | |
| 225 | - } | |
| 226 | - | |
| 227 | - if ( 'field_options' === $key ) { | |
| 228 | - // Need to loop through field_options to prevent breaking serialized string when length changed. | |
| 229 | - FrmAppHelper::unserialize_or_decode( $value ); | |
| 230 | - $new_val = FrmFieldsHelper::switch_field_ids( $value ); | |
| 231 | - $new_val = serialize( $new_val ); | |
| 232 | - } else { | |
| 233 | - $new_val = FrmFieldsHelper::switch_field_ids( $value ); | |
| 234 | - } | |
| 235 | - | |
| 236 | - if ( $new_val !== $value ) { | |
| 237 | - $new_values[ $key ] = $new_val; | |
| 238 | - } | |
| 239 | - }//end foreach | |
| 240 | - | |
| 241 | - if ( $new_values ) { | |
| 242 | - FrmField::update( $field['id'], $new_values ); | |
| 243 | - } | |
| 244 | - } | |
| 245 | - | |
| 246 | - /** | |
| 247 | - * Update a form. | |
| 248 | - * | |
| 249 | - * @param int $id Form ID. | |
| 250 | - * @param array $values Form values to update. | |
| 251 | - * @param bool $create_link Whether this is being called from link creation. | |
| 252 | - * | |
| 253 | - * @return bool|int | |
| 254 | - */ | |
| 255 | 137 | public static function update( $id, $values, $create_link = false ) { |
| 256 | 138 | global $wpdb; |
| 257 | 139 | |
| 258 | 140 | $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) ); |
| @@ -265,23 +147,23 @@ | ||
| 265 | 147 | $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id ); |
| 266 | 148 | } |
| 267 | 149 | |
| 268 | 150 | $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' ); |
| 269 | - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) ); | |
| 270 | 151 | |
| 152 | + $new_values = self::set_update_options( array(), $values ); | |
| 153 | + | |
| 271 | 154 | foreach ( $values as $value_key => $value ) { |
| 272 | - if ( $value_key && in_array( $value_key, $form_fields, true ) ) { | |
| 273 | - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value; | |
| 155 | + if ( $value_key && in_array( $value_key, $form_fields ) ) { | |
| 156 | + $new_values[ $value_key ] = $value; | |
| 274 | 157 | } |
| 275 | 158 | } |
| 276 | 159 | |
| 277 | - if ( ! empty( $values['new_status'] ) ) { | |
| 160 | + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) { | |
| 278 | 161 | $new_values['status'] = $values['new_status']; |
| 279 | 162 | } |
| 280 | 163 | |
| 281 | - if ( $new_values ) { | |
| 164 | + if ( ! empty( $new_values ) ) { | |
| 282 | 165 | $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) ); |
| 283 | - | |
| 284 | 166 | if ( $query_results ) { |
| 285 | 167 | self::clear_form_cache(); |
| 286 | 168 | } |
| 287 | 169 | } else { |
| @@ -297,37 +179,24 @@ | ||
| 297 | 179 | return $query_results; |
| 298 | 180 | } |
| 299 | 181 | |
| 300 | 182 | /** |
| 301 | - * @param array $new_values | |
| 302 | - * @param array $values | |
| 303 | - * @param array $args | |
| 304 | - * | |
| 305 | 183 | * @return array |
| 306 | 184 | */ |
| 307 | - public static function set_update_options( $new_values, $values, $args = array() ) { | |
| 185 | + public static function set_update_options( $new_values, $values ) { | |
| 308 | 186 | if ( ! isset( $values['options'] ) ) { |
| 309 | 187 | return $new_values; |
| 310 | 188 | } |
| 311 | 189 | |
| 312 | - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array(); | |
| 190 | + $options = isset( $values['options'] ) ? (array) $values['options'] : array(); | |
| 313 | 191 | FrmFormsHelper::fill_form_options( $options, $values ); |
| 314 | 192 | |
| 315 | - $options['custom_style'] = $values['options']['custom_style'] ?? 0; | |
| 316 | - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' ); | |
| 317 | - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' ); | |
| 318 | - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 193 | + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0; | |
| 194 | + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' ); | |
| 195 | + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' ); | |
| 196 | + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); | |
| 319 | 197 | |
| 320 | - /** | |
| 321 | - * Allows modifying form options before updating or creating. | |
| 322 | - * | |
| 323 | - * @since 5.4 Added the third param. | |
| 324 | - * | |
| 325 | - * @param array $options Form options. | |
| 326 | - * @param array $values Form data. | |
| 327 | - * @param bool $update Is form updating or creating. It's `true` if is updating. | |
| 328 | - */ | |
| 329 | - $options = apply_filters( 'frm_form_options_before_update', $options, $values, true ); | |
| 198 | + $options = apply_filters( 'frm_form_options_before_update', $options, $values ); | |
| 330 | 199 | $options = self::maybe_filter_form_options( $options ); |
| 331 | 200 | $new_values['options'] = serialize( $options ); |
| 332 | 201 | |
| 333 | 202 | return $new_values; |
| @@ -333,14 +202,11 @@ | ||
| 333 | 202 | return $new_values; |
| 334 | 203 | } |
| 335 | 204 | |
| 336 | 205 | /** |
| 337 | - * @param int $id Form ID. | |
| 338 | - * @param array $values Form values array. | |
| 339 | - * | |
| 340 | 206 | * @return array |
| 341 | 207 | */ |
| 342 | - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh | |
| 208 | + public static function update_fields( $id, $values ) { | |
| 343 | 209 | |
| 344 | 210 | if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) { |
| 345 | 211 | return $values; |
| 346 | 212 | } |
| @@ -345,10 +211,9 @@ | ||
| 345 | 211 | return $values; |
| 346 | 212 | } |
| 347 | 213 | |
| 348 | 214 | $all_fields = FrmField::get_all_for_form( $id ); |
| 349 | - | |
| 350 | - if ( ! $all_fields ) { | |
| 215 | + if ( empty( $all_fields ) ) { | |
| 351 | 216 | return $values; |
| 352 | 217 | } |
| 353 | 218 | |
| 354 | 219 | if ( ! isset( $values['item_meta'] ) ) { |
| @@ -356,28 +221,28 @@ | ||
| 356 | 221 | } |
| 357 | 222 | |
| 358 | 223 | $field_array = array(); |
| 359 | 224 | $existing_keys = array_keys( $values['item_meta'] ); |
| 360 | - | |
| 361 | 225 | foreach ( $all_fields as $fid ) { |
| 362 | - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 363 | 226 | if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) { |
| 364 | 227 | $values['item_meta'][ $fid->id ] = ''; |
| 365 | 228 | } |
| 366 | - | |
| 367 | 229 | $field_array[ $fid->id ] = $fid; |
| 368 | 230 | } |
| 369 | 231 | unset( $all_fields ); |
| 370 | 232 | |
| 371 | 233 | foreach ( $values['item_meta'] as $field_id => $default_value ) { |
| 372 | - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id ); | |
| 234 | + if ( isset( $field_array[ $field_id ] ) ) { | |
| 235 | + $field = $field_array[ $field_id ]; | |
| 236 | + } else { | |
| 237 | + $field = FrmField::getOne( $field_id ); | |
| 238 | + } | |
| 373 | 239 | |
| 374 | 240 | if ( ! $field ) { |
| 375 | 241 | continue; |
| 376 | 242 | } |
| 377 | 243 | |
| 378 | - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ); | |
| 379 | - | |
| 244 | + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) ); | |
| 380 | 245 | if ( $is_settings_page ) { |
| 381 | 246 | self::get_settings_page_html( $values, $field ); |
| 382 | 247 | |
| 383 | 248 | if ( ! defined( 'WP_IMPORTING' ) ) { |
| @@ -384,20 +249,15 @@ | ||
| 384 | 249 | continue; |
| 385 | 250 | } |
| 386 | 251 | } |
| 387 | 252 | |
| 388 | - // Updating the form. | |
| 253 | + //updating the form | |
| 389 | 254 | $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field ); |
| 390 | - // Don't check for POST html. | |
| 391 | - unset( $update_options['custom_html'] ); | |
| 255 | + unset( $update_options['custom_html'] ); // don't check for POST html | |
| 392 | 256 | $update_options = apply_filters( 'frm_field_options_to_update', $update_options ); |
| 393 | 257 | |
| 394 | - if ( ! is_array( $field->field_options ) ) { | |
| 395 | - $field->field_options = array(); | |
| 396 | - } | |
| 397 | - | |
| 398 | 258 | foreach ( $update_options as $opt => $default ) { |
| 399 | - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default; | |
| 259 | + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default; | |
| 400 | 260 | self::sanitize_field_opt( $opt, $field->field_options[ $opt ] ); |
| 401 | 261 | } |
| 402 | 262 | |
| 403 | 263 | $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values ); |
| @@ -406,104 +266,44 @@ | ||
| 406 | 266 | 'field_options' => $field->field_options, |
| 407 | 267 | 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '', |
| 408 | 268 | ); |
| 409 | 269 | |
| 410 | - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 411 | - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) { | |
| 412 | - if ( ! is_array( $option ) ) { | |
| 413 | - continue; | |
| 414 | - } | |
| 415 | - | |
| 416 | - foreach ( $option as $key => $item ) { | |
| 417 | - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' ); | |
| 418 | - } | |
| 419 | - } | |
| 420 | - } | |
| 421 | - | |
| 422 | 270 | self::prepare_field_update_values( $field, $values, $new_field ); |
| 423 | - self::maybe_update_max_option( $field, $values, $new_field ); | |
| 424 | 271 | |
| 425 | 272 | FrmField::update( $field_id, $new_field ); |
| 426 | 273 | |
| 427 | 274 | FrmField::delete_form_transient( $field->form_id ); |
| 428 | - }//end foreach | |
| 275 | + } | |
| 429 | 276 | self::clear_form_cache(); |
| 430 | 277 | |
| 431 | 278 | return $values; |
| 432 | 279 | } |
| 433 | 280 | |
| 434 | - /** | |
| 435 | - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc. | |
| 436 | - * | |
| 437 | - * @since 6.7 | |
| 438 | - * | |
| 439 | - * @param object $field | |
| 440 | - * @param array $values | |
| 441 | - * @param array $new_field | |
| 442 | - * | |
| 443 | - * @return void | |
| 444 | - */ | |
| 445 | - private static function maybe_update_max_option( $field, $values, &$new_field ) { | |
| 446 | - if ( $field->type !== 'textarea' || | |
| 447 | - empty( $values['field_options'][ 'type_' . $field->id ] ) || | |
| 448 | - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) { | |
| 449 | - return; | |
| 450 | - } | |
| 451 | - | |
| 452 | - $new_field['field_options']['max'] = ''; | |
| 453 | - | |
| 454 | - /** | |
| 455 | - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads. | |
| 456 | - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting. | |
| 457 | - */ | |
| 458 | - $_POST['field_options'][ 'max_' . $field->id ] = ''; | |
| 459 | - } | |
| 460 | - | |
| 461 | - /** | |
| 462 | - * @param string $opt | |
| 463 | - * @param mixed $value | |
| 464 | - * | |
| 465 | - * @return void | |
| 466 | - */ | |
| 467 | 281 | private static function sanitize_field_opt( $opt, &$value ) { |
| 468 | - if ( ! is_string( $value ) ) { | |
| 469 | - return; | |
| 282 | + if ( is_string( $value ) ) { | |
| 283 | + if ( $opt === 'calc' ) { | |
| 284 | + $value = self::sanitize_calc( $value ); | |
| 285 | + } else { | |
| 286 | + $value = FrmAppHelper::kses( $value, 'all' ); | |
| 287 | + } | |
| 288 | + $value = trim( $value ); | |
| 470 | 289 | } |
| 471 | - | |
| 472 | - /** | |
| 473 | - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead. | |
| 474 | - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized. | |
| 475 | - * | |
| 476 | - * @since 6.0 | |
| 477 | - * | |
| 478 | - * @param bool $should_sanitize | |
| 479 | - * @param string $opt | |
| 480 | - */ | |
| 481 | - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt ); | |
| 482 | - | |
| 483 | - if ( ! $should_sanitize ) { | |
| 484 | - return; | |
| 485 | - } | |
| 486 | - | |
| 487 | - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' ); | |
| 488 | - $value = trim( $value ); | |
| 489 | 290 | } |
| 490 | 291 | |
| 491 | 292 | /** |
| 492 | 293 | * @param string $value |
| 493 | - * | |
| 494 | 294 | * @return string |
| 495 | 295 | */ |
| 496 | 296 | private static function sanitize_calc( $value ) { |
| 497 | - if ( str_contains( $value, '<' ) ) { | |
| 297 | + if ( false !== strpos( $value, '<' ) ) { | |
| 498 | 298 | $value = self::normalize_calc_spaces( $value ); |
| 499 | 299 | } |
| 500 | - // Allow <= and >=. | |
| 501 | - $allow = array( '<= ', ' >=' ); | |
| 300 | + $allow = array( '<= ', ' >=' ); // Allow <= and >= | |
| 502 | 301 | $temp = array( '< = ', ' > =' ); |
| 503 | 302 | $value = str_replace( $allow, $temp, $value ); |
| 504 | 303 | $value = strip_tags( $value ); |
| 505 | - return str_replace( $temp, $allow, $value ); | |
| 304 | + $value = str_replace( $temp, $allow, $value ); | |
| 305 | + return $value; | |
| 506 | 306 | } |
| 507 | 307 | |
| 508 | 308 | /** |
| 509 | 309 | * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations. |
| @@ -509,58 +309,41 @@ | ||
| 509 | 309 | * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations. |
| 510 | 310 | * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called. |
| 511 | 311 | * |
| 512 | 312 | * @param string $calc |
| 513 | - * | |
| 514 | 313 | * @return string |
| 515 | 314 | */ |
| 516 | 315 | private static function normalize_calc_spaces( $calc ) { |
| 517 | 316 | // Check for a pattern with 5 parts |
| 518 | - // $1 \d|\] the first comparison digit or the end of a comparison shortcode. | |
| 317 | + // $1 \d the first comparison digit. | |
| 519 | 318 | // $2 a space (optional). |
| 520 | 319 | // $3 an equals sign (optional) that follows the < operator for <= comparisons. |
| 521 | 320 | // $4 another space (optional). |
| 522 | - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode. | |
| 523 | - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc ); | |
| 321 | + // $5 \d the second comparison digit. | |
| 322 | + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc ); | |
| 524 | 323 | } |
| 525 | 324 | |
| 526 | 325 | /** |
| 527 | 326 | * Updating the settings page |
| 528 | - * | |
| 529 | - * @param array $values Form values array. | |
| 530 | - * @param object $field Field object, passed by reference. | |
| 531 | - * | |
| 532 | - * @return void | |
| 533 | 327 | */ |
| 534 | 328 | private static function get_settings_page_html( $values, &$field ) { |
| 535 | 329 | if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) { |
| 536 | 330 | $prev_opts = array(); |
| 537 | - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type ); | |
| 331 | + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type ); | |
| 538 | 332 | |
| 539 | - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html; | |
| 540 | - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) { | |
| 333 | + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html; | |
| 334 | + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) { | |
| 541 | 335 | $prev_opts = $field->field_options; |
| 542 | 336 | } |
| 543 | 337 | |
| 544 | - if ( ! isset( $prev_opts ) ) { | |
| 545 | - return; | |
| 338 | + if ( isset( $prev_opts ) ) { | |
| 339 | + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values ); | |
| 340 | + if ( $prev_opts != $field->field_options ) { | |
| 341 | + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) ); | |
| 342 | + } | |
| 546 | 343 | } |
| 547 | - | |
| 548 | - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values ); | |
| 549 | - | |
| 550 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 551 | - if ( $prev_opts != $field->field_options ) { | |
| 552 | - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) ); | |
| 553 | - } | |
| 554 | 344 | } |
| 555 | 345 | |
| 556 | - /** | |
| 557 | - * @param object $field | |
| 558 | - * @param array $values | |
| 559 | - * @param array $new_field | |
| 560 | - * | |
| 561 | - * @return void | |
| 562 | - */ | |
| 563 | 346 | private static function prepare_field_update_values( $field, $values, &$new_field ) { |
| 564 | 347 | $field_cols = array( |
| 565 | 348 | 'field_order' => 0, |
| 566 | 349 | 'field_key' => '', |
| @@ -569,16 +352,12 @@ | ||
| 569 | 352 | 'description' => '', |
| 570 | 353 | 'options' => '', |
| 571 | 354 | 'name' => '', |
| 572 | 355 | ); |
| 573 | - | |
| 574 | 356 | foreach ( $field_cols as $col => $default ) { |
| 575 | - $default = $default === '' ? $field->{$col} : $default; | |
| 576 | - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default; | |
| 577 | - } | |
| 357 | + $default = ( $default === '' ) ? $field->{$col} : $default; | |
| 578 | 358 | |
| 579 | - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) { | |
| 580 | - $new_field['field_order'] = $field->field_order; | |
| 359 | + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default; | |
| 581 | 360 | } |
| 582 | 361 | |
| 583 | 362 | // Don't save the template option. |
| 584 | 363 | if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) { |
| @@ -590,12 +369,9 @@ | ||
| 590 | 369 | * Get a list of all form settings that should be translated |
| 591 | 370 | * on a multilingual site. |
| 592 | 371 | * |
| 593 | 372 | * @since 3.06.01 |
| 594 | - * | |
| 595 | - * @param object $form The form object. | |
| 596 | - * | |
| 597 | - * @return array | |
| 373 | + * @param object $form - The form object | |
| 598 | 374 | */ |
| 599 | 375 | public static function translatable_strings( $form ) { |
| 600 | 376 | $strings = array( |
| 601 | 377 | 'name', |
| @@ -602,12 +378,8 @@ | ||
| 602 | 378 | 'description', |
| 603 | 379 | 'submit_value', |
| 604 | 380 | 'submit_msg', |
| 605 | 381 | 'success_msg', |
| 606 | - 'invalid_msg', | |
| 607 | - 'failed_msg', | |
| 608 | - 'login_msg', | |
| 609 | - 'admin_permission', | |
| 610 | 382 | ); |
| 611 | 383 | |
| 612 | 384 | return apply_filters( 'frm_form_strings', $strings, $form ); |
| 613 | 385 | } |
| @@ -612,21 +384,19 @@ | ||
| 612 | 384 | return apply_filters( 'frm_form_strings', $strings, $form ); |
| 613 | 385 | } |
| 614 | 386 | |
| 615 | 387 | /** |
| 616 | - * @param array|int $id | |
| 617 | - * @param string $status | |
| 388 | + * @param string $status | |
| 618 | 389 | * |
| 619 | - * @return bool|int | |
| 390 | + * @return int|boolean | |
| 620 | 391 | */ |
| 621 | 392 | public static function set_status( $id, $status ) { |
| 622 | - if ( 'trash' === $status ) { | |
| 393 | + if ( 'trash' == $status ) { | |
| 623 | 394 | return self::trash( $id ); |
| 624 | 395 | } |
| 625 | 396 | |
| 626 | 397 | $statuses = array( 'published', 'draft', 'trash' ); |
| 627 | - | |
| 628 | - if ( ! in_array( $status, $statuses, true ) ) { | |
| 398 | + if ( ! in_array( $status, $statuses ) ) { | |
| 629 | 399 | return false; |
| 630 | 400 | } |
| 631 | 401 | |
| 632 | 402 | global $wpdb; |
| @@ -639,9 +409,9 @@ | ||
| 639 | 409 | ); |
| 640 | 410 | FrmDb::get_where_clause_and_values( $where ); |
| 641 | 411 | array_unshift( $where['values'], $status ); |
| 642 | 412 | |
| 643 | - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 413 | + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // WPCS: unprepared SQL ok. | |
| 644 | 414 | } else { |
| 645 | 415 | $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) ); |
| 646 | 416 | $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) ); |
| 647 | 417 | } |
| @@ -653,11 +423,9 @@ | ||
| 653 | 423 | return $query_results; |
| 654 | 424 | } |
| 655 | 425 | |
| 656 | 426 | /** |
| 657 | - * @param int|string $id Form ID. | |
| 658 | - * | |
| 659 | - * @return bool|int | |
| 427 | + * @return int|boolean | |
| 660 | 428 | */ |
| 661 | 429 | public static function trash( $id ) { |
| 662 | 430 | if ( ! EMPTY_TRASH_DAYS ) { |
| 663 | 431 | return self::destroy( $id ); |
| @@ -663,17 +431,12 @@ | ||
| 663 | 431 | return self::destroy( $id ); |
| 664 | 432 | } |
| 665 | 433 | |
| 666 | 434 | $form = self::getOne( $id ); |
| 667 | - | |
| 668 | 435 | if ( ! $form ) { |
| 669 | 436 | return false; |
| 670 | 437 | } |
| 671 | 438 | |
| 672 | - if ( $form->status === 'trash' ) { | |
| 673 | - return false; | |
| 674 | - } | |
| 675 | - | |
| 676 | 439 | $options = $form->options; |
| 677 | 440 | $options['trash_time'] = time(); |
| 678 | 441 | |
| 679 | 442 | global $wpdb; |
| @@ -706,26 +469,21 @@ | ||
| 706 | 469 | return $query_results; |
| 707 | 470 | } |
| 708 | 471 | |
| 709 | 472 | /** |
| 710 | - * @param int|string $id Form ID. | |
| 711 | - * | |
| 712 | - * @return bool|int | |
| 473 | + * @return int|boolean | |
| 713 | 474 | */ |
| 714 | 475 | public static function destroy( $id ) { |
| 715 | 476 | global $wpdb; |
| 716 | 477 | |
| 717 | 478 | $form = self::getOne( $id ); |
| 718 | - | |
| 719 | 479 | if ( ! $form ) { |
| 720 | 480 | return false; |
| 721 | 481 | } |
| 722 | - | |
| 723 | 482 | $id = $form->id; |
| 724 | 483 | |
| 725 | 484 | // Disconnect the entries from this form |
| 726 | - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) ); | |
| 727 | - | |
| 485 | + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) ); | |
| 728 | 486 | foreach ( $entries as $entry_id ) { |
| 729 | 487 | FrmEntry::destroy( $entry_id ); |
| 730 | 488 | unset( $entry_id ); |
| 731 | 489 | } |
| @@ -730,29 +488,23 @@ | ||
| 730 | 488 | unset( $entry_id ); |
| 731 | 489 | } |
| 732 | 490 | |
| 733 | 491 | // Disconnect the fields from this form |
| 734 | - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 492 | + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); | |
| 735 | 493 | |
| 736 | 494 | $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) ); |
| 495 | + if ( $query_results ) { | |
| 496 | + // Delete all form actions linked to this form | |
| 497 | + $action_control = FrmFormActionsController::get_form_actions( 'email' ); | |
| 498 | + $action_control->destroy( $id, 'all' ); | |
| 737 | 499 | |
| 738 | - if ( ! $query_results ) { | |
| 739 | - return $query_results; | |
| 500 | + // Clear form caching | |
| 501 | + self::clear_form_cache(); | |
| 502 | + | |
| 503 | + do_action( 'frm_destroy_form', $id ); | |
| 504 | + do_action( 'frm_destroy_form_' . $id ); | |
| 740 | 505 | } |
| 741 | 506 | |
| 742 | - // Delete all form actions linked to this form | |
| 743 | - /** | |
| 744 | - * @var FrmFormAction | |
| 745 | - */ | |
| 746 | - $action_control = FrmFormActionsController::get_form_actions( 'email' ); | |
| 747 | - $action_control->destroy( $id, 'all' ); | |
| 748 | - | |
| 749 | - // Clear form caching | |
| 750 | - self::clear_form_cache(); | |
| 751 | - | |
| 752 | - do_action( 'frm_destroy_form', $id ); | |
| 753 | - do_action( 'frm_destroy_form_' . $id ); | |
| 754 | - | |
| 755 | 507 | return $query_results; |
| 756 | 508 | } |
| 757 | 509 | |
| 758 | 510 | /** |
| @@ -757,34 +509,29 @@ | ||
| 757 | 509 | |
| 758 | 510 | /** |
| 759 | 511 | * Delete trashed forms based on how long they have been trashed |
| 760 | 512 | * |
| 761 | - * @param int|string $delete_timestamp Timestamp cutoff for deletion. | |
| 762 | - * | |
| 763 | 513 | * @return int The number of forms deleted |
| 764 | 514 | */ |
| 765 | 515 | public static function scheduled_delete( $delete_timestamp = '' ) { |
| 766 | - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' ); | |
| 516 | + global $wpdb; | |
| 767 | 517 | |
| 518 | + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' ); | |
| 519 | + | |
| 768 | 520 | if ( ! $trash_forms ) { |
| 769 | - return 0; | |
| 521 | + return; | |
| 770 | 522 | } |
| 771 | 523 | |
| 772 | - if ( ! $delete_timestamp ) { | |
| 524 | + if ( empty( $delete_timestamp ) ) { | |
| 773 | 525 | $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS ); |
| 774 | 526 | } |
| 775 | 527 | |
| 776 | 528 | $count = 0; |
| 777 | - | |
| 778 | 529 | foreach ( $trash_forms as $form ) { |
| 779 | 530 | FrmAppHelper::unserialize_or_decode( $form->options ); |
| 780 | - | |
| 781 | 531 | if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) { |
| 782 | 532 | self::destroy( $form->id ); |
| 783 | - | |
| 784 | - if ( empty( $form->parent_form_id ) ) { | |
| 785 | - ++$count; | |
| 786 | - } | |
| 533 | + $count ++; | |
| 787 | 534 | } |
| 788 | 535 | |
| 789 | 536 | unset( $form ); |
| 790 | 537 | } |
| @@ -792,24 +539,23 @@ | ||
| 792 | 539 | return $count; |
| 793 | 540 | } |
| 794 | 541 | |
| 795 | 542 | /** |
| 796 | - * @param int|string $id Form ID or key. | |
| 797 | - * | |
| 798 | 543 | * @return string form name |
| 799 | 544 | */ |
| 800 | 545 | public static function getName( $id ) { |
| 801 | 546 | $form = FrmDb::check_cache( $id, 'frm_form' ); |
| 547 | + if ( $form ) { | |
| 548 | + $r = stripslashes( $form->name ); | |
| 802 | 549 | |
| 803 | - if ( $form ) { | |
| 804 | - return stripslashes( $form->name ); | |
| 550 | + return $r; | |
| 805 | 551 | } |
| 806 | 552 | |
| 807 | 553 | $query_key = is_numeric( $id ) ? 'id' : 'form_key'; |
| 808 | 554 | $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' ); |
| 555 | + $r = stripslashes( $r ); | |
| 809 | 556 | |
| 810 | - // An empty form name can result in a null value. | |
| 811 | - return is_null( $r ) ? '' : stripslashes( $r ); | |
| 557 | + return $r; | |
| 812 | 558 | } |
| 813 | 559 | |
| 814 | 560 | /** |
| 815 | 561 | * @since 3.0 |
| @@ -824,9 +570,9 @@ | ||
| 824 | 570 | |
| 825 | 571 | /** |
| 826 | 572 | * @since 3.0 |
| 827 | 573 | * |
| 828 | - * @param int|string $id | |
| 574 | + * @param int $id | |
| 829 | 575 | * |
| 830 | 576 | * @return string form key |
| 831 | 577 | */ |
| 832 | 578 | public static function get_key_by_id( $id ) { |
| @@ -831,57 +577,59 @@ | ||
| 831 | 577 | */ |
| 832 | 578 | public static function get_key_by_id( $id ) { |
| 833 | 579 | $id = (int) $id; |
| 834 | 580 | $cache = FrmDb::check_cache( $id, 'frm_form' ); |
| 835 | - | |
| 836 | 581 | if ( $cache ) { |
| 837 | 582 | return $cache->form_key; |
| 838 | 583 | } |
| 839 | 584 | |
| 840 | - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' ); | |
| 585 | + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' ); | |
| 586 | + | |
| 587 | + return $key; | |
| 841 | 588 | } |
| 842 | 589 | |
| 843 | 590 | /** |
| 844 | 591 | * If $form is numeric, get the form object |
| 845 | 592 | * |
| 593 | + * @param object|int $form | |
| 594 | + * | |
| 846 | 595 | * @since 2.0.9 |
| 847 | - * | |
| 848 | - * @param array|int|object $form | |
| 849 | - * | |
| 850 | - * @return void | |
| 851 | 596 | */ |
| 852 | 597 | public static function maybe_get_form( &$form ) { |
| 853 | - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) { | |
| 598 | + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) { | |
| 854 | 599 | $form = self::getOne( $form ); |
| 855 | 600 | } |
| 856 | 601 | } |
| 857 | 602 | |
| 858 | 603 | /** |
| 859 | - * @param int|string $id | |
| 860 | - * @param false|int $blog_id | |
| 861 | - * | |
| 862 | - * @return stdClass|null | |
| 604 | + * @return object form | |
| 863 | 605 | */ |
| 864 | 606 | public static function getOne( $id, $blog_id = false ) { |
| 865 | 607 | global $wpdb; |
| 866 | 608 | |
| 867 | 609 | if ( $blog_id && is_multisite() ) { |
| 868 | - $prefix = $wpdb->get_blog_prefix( $blog_id ); | |
| 610 | + global $wpmuBaseTablePrefix; | |
| 611 | + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id ); | |
| 612 | + | |
| 869 | 613 | $table_name = $prefix . 'frm_forms'; |
| 870 | 614 | } else { |
| 871 | 615 | $table_name = $wpdb->prefix . 'frm_forms'; |
| 872 | 616 | $cache = wp_cache_get( $id, 'frm_form' ); |
| 873 | - | |
| 874 | 617 | if ( $cache ) { |
| 875 | 618 | if ( isset( $cache->options ) ) { |
| 876 | 619 | FrmAppHelper::unserialize_or_decode( $cache->options ); |
| 877 | 620 | } |
| 878 | 621 | |
| 879 | - return self::prepare_form_row_data( $cache ); | |
| 622 | + return wp_unslash( $cache ); | |
| 880 | 623 | } |
| 881 | 624 | } |
| 882 | 625 | |
| 883 | - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id ); | |
| 626 | + if ( is_numeric( $id ) ) { | |
| 627 | + $where = array( 'id' => $id ); | |
| 628 | + } else { | |
| 629 | + $where = array( 'form_key' => $id ); | |
| 630 | + } | |
| 631 | + | |
| 884 | 632 | $results = FrmDb::get_row( $table_name, $where ); |
| 885 | 633 | |
| 886 | 634 | if ( isset( $results->options ) ) { |
| 887 | 635 | FrmDb::set_cache( $results->id, $results, 'frm_form' ); |
| @@ -887,50 +635,18 @@ | ||
| 887 | 635 | FrmDb::set_cache( $results->id, $results, 'frm_form' ); |
| 888 | 636 | FrmAppHelper::unserialize_or_decode( $results->options ); |
| 889 | 637 | } |
| 890 | 638 | |
| 891 | - return self::prepare_form_row_data( $results ); | |
| 639 | + return apply_filters( 'frm_form_object', wp_unslash( $results ) ); | |
| 892 | 640 | } |
| 893 | 641 | |
| 894 | 642 | /** |
| 895 | - * Make sure that if $row is an object, that $row->options is an array and not a string. | |
| 896 | - * | |
| 897 | - * @since 6.8.3 | |
| 898 | - * | |
| 899 | - * @param stdClass|null $row The database row for a target form. | |
| 900 | - * | |
| 901 | - * @return stdClass|null | |
| 643 | + * @return object|array of objects | |
| 902 | 644 | */ |
| 903 | - private static function prepare_form_row_data( $row ) { | |
| 904 | - $row = wp_unslash( $row ); | |
| 905 | - | |
| 906 | - if ( ! is_object( $row ) ) { | |
| 907 | - return $row; | |
| 908 | - } | |
| 909 | - | |
| 910 | - if ( ! is_array( $row->options ) ) { | |
| 911 | - $row->options = FrmFormsHelper::get_default_opts(); | |
| 912 | - } | |
| 913 | - | |
| 914 | - /** | |
| 915 | - * @since 4.03.02 | |
| 916 | - * | |
| 917 | - * @param stdClass $row | |
| 918 | - */ | |
| 919 | - return apply_filters( 'frm_form_object', $row ); | |
| 920 | - } | |
| 921 | - | |
| 922 | - /** | |
| 923 | - * @param array|string $where Where conditions array or raw WHERE string. | |
| 924 | - * @param string $order_by Order by clause. | |
| 925 | - * @param int|string $limit Limit clause or number. | |
| 926 | - * | |
| 927 | - * @return array|object Array of objects. If $limit is 1, a single object is returned. | |
| 928 | - */ | |
| 929 | 645 | public static function getAll( $where = array(), $order_by = '', $limit = '' ) { |
| 930 | - if ( is_array( $where ) && $where ) { | |
| 931 | - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) { | |
| 932 | - // Don't get trashed templates | |
| 646 | + if ( is_array( $where ) && ! empty( $where ) ) { | |
| 647 | + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) { | |
| 648 | + // don't get trashed templates | |
| 933 | 649 | $where['status'] = array( null, '', 'published' ); |
| 934 | 650 | } |
| 935 | 651 | |
| 936 | 652 | $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) ); |
| @@ -936,11 +652,11 @@ | ||
| 936 | 652 | $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) ); |
| 937 | 653 | } else { |
| 938 | 654 | global $wpdb; |
| 939 | 655 | |
| 940 | - // The query has already been prepared if this is not an array. | |
| 941 | - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 942 | - $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared | |
| 656 | + // the query has already been prepared if this is not an array | |
| 657 | + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); | |
| 658 | + $results = $wpdb->get_results( $query ); // WPCS: unprepared SQL ok. | |
| 943 | 659 | } |
| 944 | 660 | |
| 945 | 661 | if ( $results ) { |
| 946 | 662 | foreach ( $results as $result ) { |
| @@ -948,10 +664,10 @@ | ||
| 948 | 664 | FrmAppHelper::unserialize_or_decode( $result->options ); |
| 949 | 665 | } |
| 950 | 666 | } |
| 951 | 667 | |
| 952 | - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) { | |
| 953 | - // Return the first form object if we are only getting one form | |
| 668 | + if ( $limit == ' LIMIT 1' || $limit == 1 ) { | |
| 669 | + // return the first form object if we are only getting one form | |
| 954 | 670 | $results = reset( $results ); |
| 955 | 671 | } |
| 956 | 672 | |
| 957 | 673 | return wp_unslash( $results ); |
| @@ -960,24 +676,20 @@ | ||
| 960 | 676 | /** |
| 961 | 677 | * Get all published forms |
| 962 | 678 | * |
| 963 | 679 | * @since 2.0 |
| 964 | - * | |
| 965 | - * @param array $query | |
| 966 | - * @param int $limit | |
| 967 | - * @param string $inc_children | |
| 968 | - * | |
| 969 | - * @return array|object Array of forms. A single form object is returned if $limit is set to 1. | |
| 680 | + * @return array of forms | |
| 970 | 681 | */ |
| 971 | 682 | public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) { |
| 972 | 683 | $query['is_template'] = 0; |
| 973 | 684 | $query['status'] = array( null, '', 'published' ); |
| 974 | - | |
| 975 | - if ( $inc_children === 'exclude' ) { | |
| 685 | + if ( $inc_children == 'exclude' ) { | |
| 976 | 686 | $query['parent_form_id'] = array( null, 0 ); |
| 977 | 687 | } |
| 978 | 688 | |
| 979 | - return self::getAll( $query, 'name', $limit ); | |
| 689 | + $forms = self::getAll( $query, 'name', $limit ); | |
| 690 | + | |
| 691 | + return $forms; | |
| 980 | 692 | } |
| 981 | 693 | |
| 982 | 694 | /** |
| 983 | 695 | * @return object count of forms |
| @@ -982,16 +694,18 @@ | ||
| 982 | 694 | /** |
| 983 | 695 | * @return object count of forms |
| 984 | 696 | */ |
| 985 | 697 | public static function get_count() { |
| 698 | + global $wpdb; | |
| 699 | + | |
| 986 | 700 | $cache_key = 'frm_form_counts'; |
| 987 | - $counts = wp_cache_get( $cache_key, 'frm_form' ); | |
| 988 | 701 | |
| 702 | + $counts = wp_cache_get( $cache_key, 'frm_form' ); | |
| 989 | 703 | if ( false !== $counts ) { |
| 990 | 704 | return $counts; |
| 991 | 705 | } |
| 992 | 706 | |
| 993 | - $results = FrmDb::get_results( | |
| 707 | + $results = (array) FrmDb::get_results( | |
| 994 | 708 | 'frm_forms', |
| 995 | 709 | array( |
| 996 | 710 | 'or' => 1, |
| 997 | 711 | 'parent_form_id' => null, |
| @@ -1003,18 +717,20 @@ | ||
| 1003 | 717 | $statuses = array( 'published', 'draft', 'template', 'trash' ); |
| 1004 | 718 | $counts = array_fill_keys( $statuses, 0 ); |
| 1005 | 719 | |
| 1006 | 720 | foreach ( $results as $row ) { |
| 1007 | - if ( 'trash' === $row->status ) { | |
| 1008 | - ++$counts['trash']; | |
| 1009 | - } elseif ( $row->is_template ) { | |
| 1010 | - ++$counts['template']; | |
| 721 | + if ( 'trash' != $row->status ) { | |
| 722 | + if ( $row->is_template ) { | |
| 723 | + $counts['template'] ++; | |
| 724 | + } else { | |
| 725 | + $counts['published'] ++; | |
| 726 | + } | |
| 1011 | 727 | } else { |
| 1012 | - ++$counts['published']; | |
| 728 | + $counts['trash'] ++; | |
| 1013 | 729 | } |
| 1014 | 730 | |
| 1015 | - if ( 'draft' === $row->status ) { | |
| 1016 | - ++$counts['draft']; | |
| 731 | + if ( 'draft' == $row->status ) { | |
| 732 | + $counts['draft'] ++; | |
| 1017 | 733 | } |
| 1018 | 734 | |
| 1019 | 735 | unset( $row ); |
| 1020 | 736 | } |
| @@ -1030,10 +746,8 @@ | ||
| 1030 | 746 | * Called when a form is created, updated, duplicated, or deleted |
| 1031 | 747 | * or when the form status is changed |
| 1032 | 748 | * |
| 1033 | 749 | * @since 2.0.4 |
| 1034 | - * | |
| 1035 | - * @return void | |
| 1036 | 750 | */ |
| 1037 | 751 | public static function clear_form_cache() { |
| 1038 | 752 | FrmDb::cache_delete_group( 'frm_form' ); |
| 1039 | 753 | } |
| @@ -1038,29 +752,23 @@ | ||
| 1038 | 752 | FrmDb::cache_delete_group( 'frm_form' ); |
| 1039 | 753 | } |
| 1040 | 754 | |
| 1041 | 755 | /** |
| 1042 | - * @param array $values Form values to validate. | |
| 1043 | - * | |
| 1044 | 756 | * @return array of errors |
| 1045 | 757 | */ |
| 1046 | 758 | public static function validate( $values ) { |
| 1047 | 759 | $errors = array(); |
| 760 | + | |
| 1048 | 761 | return apply_filters( 'frm_validate_form', $errors, $values ); |
| 1049 | 762 | } |
| 1050 | 763 | |
| 1051 | - /** | |
| 1052 | - * @param object|null $form | |
| 1053 | - * | |
| 1054 | - * @return array | |
| 1055 | - */ | |
| 1056 | 764 | public static function get_params( $form = null ) { |
| 1057 | 765 | global $frm_vars; |
| 1058 | 766 | |
| 1059 | - if ( $form ) { | |
| 767 | + if ( ! $form ) { | |
| 768 | + $form = self::getAll( array(), 'name', 1 ); | |
| 769 | + } else { | |
| 1060 | 770 | self::maybe_get_form( $form ); |
| 1061 | - } else { | |
| 1062 | - $form = self::getAll( array(), 'name', 1 ); | |
| 1063 | 771 | } |
| 1064 | 772 | |
| 1065 | 773 | if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) { |
| 1066 | 774 | return $frm_vars['form_params'][ $form->id ]; |
| @@ -1065,9 +773,9 @@ | ||
| 1065 | 773 | if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) { |
| 1066 | 774 | return $frm_vars['form_params'][ $form->id ]; |
| 1067 | 775 | } |
| 1068 | 776 | |
| 1069 | - $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing | |
| 777 | + $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // WPCS: CSRF ok. | |
| 1070 | 778 | $action = apply_filters( 'frm_show_new_entry_page', FrmAppHelper::get_param( $action_var, 'new', 'get', 'sanitize_title' ), $form ); |
| 1071 | 779 | |
| 1072 | 780 | $default_values = array( |
| 1073 | 781 | 'id' => '', |
| @@ -1083,18 +791,16 @@ | ||
| 1083 | 791 | ); |
| 1084 | 792 | |
| 1085 | 793 | $values = array(); |
| 1086 | 794 | $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' ); |
| 1087 | - | |
| 1088 | 795 | if ( ! $values['posted_form_id'] ) { |
| 1089 | 796 | $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' ); |
| 1090 | 797 | } |
| 1091 | 798 | |
| 1092 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 1093 | 799 | if ( $form->id == $values['posted_form_id'] ) { |
| 1094 | - // If there are two forms on the same page, make sure not to submit both. | |
| 800 | + //if there are two forms on the same page, make sure not to submit both | |
| 1095 | 801 | foreach ( $default_values as $var => $default ) { |
| 1096 | - if ( $var === 'action' ) { | |
| 802 | + if ( $var == 'action' ) { | |
| 1097 | 803 | $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' ); |
| 1098 | 804 | } else { |
| 1099 | 805 | $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
| 1100 | 806 | } |
| @@ -1106,10 +812,10 @@ | ||
| 1106 | 812 | unset( $var, $default ); |
| 1107 | 813 | } |
| 1108 | 814 | } |
| 1109 | 815 | |
| 1110 | - if ( in_array( $values['action'], array( 'create', 'update' ), true ) && | |
| 1111 | - ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing | |
| 816 | + if ( in_array( $values['action'], array( 'create', 'update' ) ) && | |
| 817 | + ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // WPCS: CSRF ok. | |
| 1112 | 818 | ) { |
| 1113 | 819 | $values['action'] = 'new'; |
| 1114 | 820 | } |
| 1115 | 821 | |
| @@ -1115,11 +821,8 @@ | ||
| 1115 | 821 | |
| 1116 | 822 | return $values; |
| 1117 | 823 | } |
| 1118 | 824 | |
| 1119 | - /** | |
| 1120 | - * @return array | |
| 1121 | - */ | |
| 1122 | 825 | public static function list_page_params() { |
| 1123 | 826 | $values = array(); |
| 1124 | 827 | $defaults = array( |
| 1125 | 828 | 'template' => 0, |
| @@ -1129,9 +832,8 @@ | ||
| 1129 | 832 | 'search' => '', |
| 1130 | 833 | 'sort' => '', |
| 1131 | 834 | 'sdir' => '', |
| 1132 | 835 | ); |
| 1133 | - | |
| 1134 | 836 | foreach ( $defaults as $var => $default ) { |
| 1135 | 837 | $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
| 1136 | 838 | } |
| 1137 | 839 | |
| @@ -1137,16 +839,10 @@ | ||
| 1137 | 839 | |
| 1138 | 840 | return $values; |
| 1139 | 841 | } |
| 1140 | 842 | |
| 1141 | - /** | |
| 1142 | - * @param int|object|string|null $form | |
| 1143 | - * | |
| 1144 | - * @return array | |
| 1145 | - */ | |
| 1146 | 843 | public static function get_admin_params( $form = null ) { |
| 1147 | 844 | $form_id = $form; |
| 1148 | - | |
| 1149 | 845 | if ( $form === null ) { |
| 1150 | 846 | $form_id = self::get_current_form_id(); |
| 1151 | 847 | } elseif ( $form && is_object( $form ) ) { |
| 1152 | 848 | $form_id = $form->id; |
| @@ -1164,9 +860,8 @@ | ||
| 1164 | 860 | 'sdir' => '', |
| 1165 | 861 | 'fid' => '', |
| 1166 | 862 | 'keep_post' => '', |
| 1167 | 863 | ); |
| 1168 | - | |
| 1169 | 864 | foreach ( $defaults as $var => $default ) { |
| 1170 | 865 | $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' ); |
| 1171 | 866 | } |
| 1172 | 867 | |
| @@ -1172,55 +867,47 @@ | ||
| 1172 | 867 | |
| 1173 | 868 | return $values; |
| 1174 | 869 | } |
| 1175 | 870 | |
| 1176 | - /** | |
| 1177 | - * @param string $default_form | |
| 1178 | - * | |
| 1179 | - * @return int|string | |
| 1180 | - */ | |
| 1181 | 871 | public static function get_current_form_id( $default_form = 'none' ) { |
| 1182 | - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form(); | |
| 1183 | - return $form ? $form->id : 0; | |
| 872 | + if ( 'first' == $default_form ) { | |
| 873 | + $form = self::get_current_form(); | |
| 874 | + } else { | |
| 875 | + $form = self::maybe_get_current_form(); | |
| 876 | + } | |
| 877 | + $form_id = $form ? $form->id : 0; | |
| 878 | + | |
| 879 | + return $form_id; | |
| 1184 | 880 | } |
| 1185 | 881 | |
| 1186 | - /** | |
| 1187 | - * @param int|string $form_id | |
| 1188 | - * | |
| 1189 | - * @return false|int|object|string | |
| 1190 | - */ | |
| 1191 | 882 | public static function maybe_get_current_form( $form_id = 0 ) { |
| 1192 | 883 | global $frm_vars; |
| 1193 | 884 | |
| 1194 | - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) { | |
| 885 | + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) { | |
| 1195 | 886 | return $frm_vars['current_form']; |
| 1196 | 887 | } |
| 1197 | 888 | |
| 1198 | 889 | $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' ); |
| 890 | + if ( $form_id ) { | |
| 891 | + $form_id = self::set_current_form( $form_id ); | |
| 892 | + } | |
| 1199 | 893 | |
| 1200 | - return $form_id ? self::set_current_form( $form_id ) : $form_id; | |
| 894 | + return $form_id; | |
| 1201 | 895 | } |
| 1202 | 896 | |
| 1203 | - /** | |
| 1204 | - * @param int $form_id | |
| 1205 | - * | |
| 1206 | - * @return false|object | |
| 1207 | - */ | |
| 1208 | 897 | public static function get_current_form( $form_id = 0 ) { |
| 1209 | 898 | $form = self::maybe_get_current_form( $form_id ); |
| 1210 | - return is_numeric( $form ) ? self::set_current_form( $form ) : $form; | |
| 899 | + if ( is_numeric( $form ) ) { | |
| 900 | + $form = self::set_current_form( $form ); | |
| 901 | + } | |
| 902 | + | |
| 903 | + return $form; | |
| 1211 | 904 | } |
| 1212 | 905 | |
| 1213 | - /** | |
| 1214 | - * @param int $form_id | |
| 1215 | - * | |
| 1216 | - * @return false|object | |
| 1217 | - */ | |
| 1218 | 906 | public static function set_current_form( $form_id ) { |
| 1219 | 907 | global $frm_vars; |
| 1220 | 908 | |
| 1221 | 909 | $query = array(); |
| 1222 | - | |
| 1223 | 910 | if ( $form_id ) { |
| 1224 | 911 | $query['id'] = $form_id; |
| 1225 | 912 | } |
| 1226 | 913 | |
| @@ -1228,19 +915,11 @@ | ||
| 1228 | 915 | |
| 1229 | 916 | return $frm_vars['current_form']; |
| 1230 | 917 | } |
| 1231 | 918 | |
| 1232 | - /** | |
| 1233 | - * @param object $form | |
| 1234 | - * @param int|string $this_load | |
| 1235 | - * @param bool $global_load | |
| 1236 | - * | |
| 1237 | - * @return bool | |
| 1238 | - */ | |
| 1239 | 919 | public static function is_form_loaded( $form, $this_load, $global_load ) { |
| 1240 | 920 | global $frm_vars; |
| 1241 | 921 | $small_form = new stdClass(); |
| 1242 | - | |
| 1243 | 922 | foreach ( array( 'id', 'form_key', 'name' ) as $var ) { |
| 1244 | 923 | $small_form->{$var} = $form->{$var}; |
| 1245 | 924 | unset( $var ); |
| 1246 | 925 | } |
| @@ -1246,14 +925,14 @@ | ||
| 1246 | 925 | } |
| 1247 | 926 | |
| 1248 | 927 | $frm_vars['forms_loaded'][] = $small_form; |
| 1249 | 928 | |
| 1250 | - if ( $this_load && ! $global_load ) { | |
| 929 | + if ( $this_load && empty( $global_load ) ) { | |
| 1251 | 930 | $global_load = true; |
| 1252 | 931 | $frm_vars['load_css'] = true; |
| 1253 | 932 | } |
| 1254 | 933 | |
| 1255 | - return empty( $frm_vars['css_loaded'] ) && $global_load; | |
| 934 | + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load ); | |
| 1256 | 935 | } |
| 1257 | 936 | |
| 1258 | 937 | /** |
| 1259 | 938 | * @since 4.06.03 |
| @@ -1261,9 +940,9 @@ | ||
| 1261 | 940 | * @param object $form |
| 1262 | 941 | * |
| 1263 | 942 | * @return bool |
| 1264 | 943 | */ |
| 1265 | - public static function is_visible_to_user( $form ) { | |
| 944 | + public static function &is_visible_to_user( $form ) { | |
| 1266 | 945 | if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) { |
| 1267 | 946 | $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] ); |
| 1268 | 947 | } else { |
| 1269 | 948 | $visible = true; |
| @@ -1268,39 +947,26 @@ | ||
| 1268 | 947 | } else { |
| 1269 | 948 | $visible = true; |
| 1270 | 949 | } |
| 1271 | 950 | |
| 1272 | - /** | |
| 1273 | - * @since 6.25 | |
| 1274 | - * | |
| 1275 | - * @param bool $visible | |
| 1276 | - * @param object $form | |
| 1277 | - */ | |
| 1278 | - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form ); | |
| 951 | + return $visible; | |
| 1279 | 952 | } |
| 1280 | 953 | |
| 1281 | - /** | |
| 1282 | - * @param object $form | |
| 1283 | - * | |
| 1284 | - * @return bool | |
| 1285 | - */ | |
| 1286 | 954 | public static function show_submit( $form ) { |
| 1287 | - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin(); | |
| 1288 | - return apply_filters( 'frm_show_submit_button', $show, $form ); | |
| 955 | + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() ); | |
| 956 | + $show = apply_filters( 'frm_show_submit_button', $show, $form ); | |
| 957 | + | |
| 958 | + return $show; | |
| 1289 | 959 | } |
| 1290 | 960 | |
| 1291 | 961 | /** |
| 1292 | 962 | * @since 2.3 |
| 1293 | - * | |
| 1294 | - * @param array $atts Attributes including form, option, and default. | |
| 1295 | - * | |
| 1296 | - * @return mixed | |
| 1297 | 963 | */ |
| 1298 | 964 | public static function get_option( $atts ) { |
| 1299 | - $form = $atts['form']; | |
| 1300 | - $default = $atts['default'] ?? ''; | |
| 965 | + $form = $atts['form']; | |
| 966 | + $default = isset( $atts['default'] ) ? $atts['default'] : ''; | |
| 1301 | 967 | |
| 1302 | - return $form->options[ $atts['option'] ] ?? $default; | |
| 968 | + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default; | |
| 1303 | 969 | } |
| 1304 | 970 | |
| 1305 | 971 | /** |
| 1306 | 972 | * Get the link to edit this form. |
| @@ -1305,12 +971,9 @@ | ||
| 1305 | 971 | /** |
| 1306 | 972 | * Get the link to edit this form. |
| 1307 | 973 | * |
| 1308 | 974 | * @since 4.0 |
| 1309 | - * | |
| 1310 | 975 | * @param int $form_id The id of the form. |
| 1311 | - * | |
| 1312 | - * @return string | |
| 1313 | 976 | */ |
| 1314 | 977 | public static function get_edit_link( $form_id ) { |
| 1315 | 978 | return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id ); |
| 1316 | 979 | } |
| @@ -1315,65 +978,9 @@ | ||
| 1315 | 978 | return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id ); |
| 1316 | 979 | } |
| 1317 | 980 | |
| 1318 | 981 | /** |
| 1319 | - * Check if the "Submit this form with AJAX" setting is toggled on. | |
| 1320 | - * | |
| 1321 | - * @since 6.2 | |
| 1322 | - * | |
| 1323 | - * @param stdClass $form | |
| 1324 | - * | |
| 1325 | - * @return bool | |
| 1326 | - */ | |
| 1327 | - public static function is_ajax_on( $form ) { | |
| 1328 | - return ! empty( $form->options['ajax_submit'] ); | |
| 1329 | - } | |
| 1330 | - | |
| 1331 | - /** | |
| 1332 | - * Get the latest form available. | |
| 1333 | - * | |
| 1334 | - * @since 6.8 | |
| 1335 | - * | |
| 1336 | - * @return object | |
| 1337 | - */ | |
| 1338 | - public static function get_latest_form() { | |
| 1339 | - $args = array( | |
| 1340 | - array( | |
| 1341 | - 'or' => 1, | |
| 1342 | - 'parent_form_id' => null, | |
| 1343 | - 'parent_form_id <' => 1, | |
| 1344 | - ), | |
| 1345 | - 'is_template' => 0, | |
| 1346 | - 'status !' => 'trash', | |
| 1347 | - ); | |
| 1348 | - | |
| 1349 | - return self::getAll( $args, 'created_at desc', 1 ); | |
| 1350 | - } | |
| 1351 | - | |
| 1352 | - /** | |
| 1353 | - * Count and return total forms. | |
| 1354 | - * | |
| 1355 | - * @since 6.8 | |
| 1356 | - * | |
| 1357 | - * @return int | |
| 1358 | - */ | |
| 1359 | - public static function get_forms_count() { | |
| 1360 | - $args = array( | |
| 1361 | - array( | |
| 1362 | - 'or' => 1, | |
| 1363 | - 'parent_form_id' => null, | |
| 1364 | - 'parent_form_id <' => 1, | |
| 1365 | - ), | |
| 1366 | - 'is_template' => 0, | |
| 1367 | - 'status !' => 'trash', | |
| 1368 | - ); | |
| 1369 | - | |
| 1370 | - return FrmDb::get_count( 'frm_forms', $args ); | |
| 1371 | - } | |
| 1372 | - | |
| 1373 | - /** | |
| 1374 | - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations). | |
| 1375 | - * | |
| 982 | + * @deprecated 3.0 | |
| 1376 | 983 | * @codeCoverageIgnore |
| 1377 | 984 | * |
| 1378 | 985 | * @param string $key |
| 1379 | 986 | * |
| @@ -1379,22 +986,15 @@ | ||
| 1379 | 986 | * |
| 1380 | 987 | * @return int form id |
| 1381 | 988 | */ |
| 1382 | 989 | public static function getIdByKey( $key ) { |
| 1383 | - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' ); | |
| 1384 | - return self::get_id_by_key( $key ); | |
| 990 | + return FrmFormDeprecated::getIdByKey( $key ); | |
| 1385 | 991 | } |
| 1386 | 992 | |
| 1387 | 993 | /** |
| 1388 | - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13. | |
| 1389 | - * | |
| 994 | + * @deprecated 3.0 | |
| 1390 | 995 | * @codeCoverageIgnore |
| 1391 | - * | |
| 1392 | - * @param int|string $id | |
| 1393 | - * | |
| 1394 | - * @return string | |
| 1395 | 996 | */ |
| 1396 | 997 | public static function getKeyById( $id ) { |
| 1397 | - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' ); | |
| 1398 | - return self::get_key_by_id( $id ); | |
| 998 | + return FrmFormDeprecated::getKeyById( $id ); | |
| 1399 | 999 | } |
| 1400 | 1000 | } |
