PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.0.14
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.0.14
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmFormActionsController.php +112 -344 6.275.0.14 View file →
@@ -3,17 +3,9 @@
3 3 die( 'You are not allowed to call this page directly.' );
4 4 }
5 5
6 6 class FrmFormActionsController {
7 -
8 - /**
9 - * @var string
10 - */
11 7 public static $action_post_type = 'frm_form_actions';
12 -
13 - /**
14 - * @var array|null
15 - */
16 8 public static $registered_actions;
17 9
18 10 /**
19 11 * Variables saved in the post:
@@ -46,47 +38,34 @@
46 38 self::register_actions();
47 39 do_action( 'frm_form_actions_init' );
48 40 }
49 41
50 - /**
51 - * @return void
52 - */
53 42 public static function register_actions() {
54 43 $action_classes = array(
55 - 'on_submit' => 'FrmOnSubmitAction',
56 - 'email' => 'FrmEmailAction',
57 - 'wppost' => 'FrmDefPostAction',
58 - 'register' => 'FrmDefRegAction',
59 - 'paypal' => 'FrmDefPayPalAction',
60 - 'payment' => 'FrmTransLiteAction',
61 - 'quiz' => 'FrmDefQuizAction',
62 - 'quiz_outcome' => 'FrmDefQuizOutcomeAction',
63 - 'mailchimp' => 'FrmDefMlcmpAction',
64 - 'api' => 'FrmDefApiAction',
65 - 'salesforce' => 'FrmDefSalesforceAction',
66 - 'activecampaign' => 'FrmDefActiveCampaignAction',
67 - 'constantcontact' => 'FrmDefConstContactAction',
68 - 'getresponse' => 'FrmDefGetResponseAction',
69 - 'hubspot' => 'FrmDefHubspotAction',
70 - 'zapier' => 'FrmDefZapierAction',
71 - 'n8n' => 'FrmDefN8NAction',
72 - 'twilio' => 'FrmDefTwilioAction',
73 - 'highrise' => 'FrmDefHighriseAction',
74 - 'mailpoet' => 'FrmDefMailpoetAction',
75 - 'aweber' => 'FrmDefAweberAction',
76 - 'convertkit' => 'FrmDefConvertKitAction',
77 - 'googlespreadsheet' => 'FrmDefGoogleSpreadsheetAction',
44 + 'email' => 'FrmEmailAction',
45 + 'wppost' => 'FrmDefPostAction',
46 + 'register' => 'FrmDefRegAction',
47 + 'paypal' => 'FrmDefPayPalAction',
48 + 'payment' => 'FrmDefHrsAction',
49 + 'mailchimp' => 'FrmDefMlcmpAction',
50 + 'api' => 'FrmDefApiAction',
51 +
52 + 'salesforce' => 'FrmDefSalesforceAction',
53 + 'activecampaign' => 'FrmDefActiveCampaignAction',
54 + 'constantcontact' => 'FrmDefConstContactAction',
55 + 'getresponse' => 'FrmDefGetResponseAction',
56 + 'hubspot' => 'FrmDefHubspotAction',
57 + 'zapier' => 'FrmDefZapierAction',
58 + 'twilio' => 'FrmDefTwilioAction',
59 + 'highrise' => 'FrmDefHighriseAction',
60 + 'mailpoet' => 'FrmDefMailpoetAction',
61 + 'aweber' => 'FrmDefAweberAction',
78 62 );
79 63
80 - if ( ! FrmAppHelper::show_new_feature( 'n8n' ) ) {
81 - unset( $action_classes['n8n'] );
82 - }
83 -
84 64 $action_classes = apply_filters( 'frm_registered_form_actions', $action_classes );
85 - $action_classes = self::maybe_unset_highrise( $action_classes );
86 65
87 - include_once FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/email_action.php';
88 - include_once FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/default_actions.php';
66 + include_once( FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/email_action.php' );
67 + include_once( FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/default_actions.php' );
89 68
90 69 foreach ( $action_classes as $action_class ) {
91 70 self::$registered_actions->register( $action_class );
92 71 }
@@ -92,37 +71,22 @@
92 71 }
93 72 }
94 73
95 74 /**
96 - * Remove the Highrise action if it is not registered.
97 - *
98 - * @since 6.23
99 - *
100 - * @param array $action_classes
101 - *
102 - * @return array
103 - */
104 - private static function maybe_unset_highrise( $action_classes ) {
105 - if ( 'FrmDefHighriseAction' === ( $action_classes['highrise'] ?? '' ) ) {
106 - unset( $action_classes['highrise'] );
107 - }
108 - return $action_classes;
109 - }
110 -
111 - /**
112 75 * @since 4.0
113 76 *
114 77 * @param array $values
115 78 */
116 79 public static function email_settings( $values ) {
117 - $form = FrmForm::getOne( $values['id'] );
118 - $groups = self::form_action_groups();
80 + $form = FrmForm::getOne( $values['id'] );
81 + $groups = self::form_action_groups();
82 +
119 83 $action_controls = self::get_form_actions();
120 84 self::maybe_add_action_to_group( $action_controls, $groups );
121 85
122 86 $allowed = self::active_actions( $action_controls );
123 87
124 - include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/settings.php';
88 + include( FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/settings.php' );
125 89 }
126 90
127 91 /**
128 92 * Add unknown actions to a group.
@@ -127,17 +91,11 @@
127 91 /**
128 92 * Add unknown actions to a group.
129 93 *
130 94 * @since 4.0
131 - *
132 - * @param array $action_controls
133 - * @param array $groups
134 - *
135 - * @return void
136 95 */
137 96 private static function maybe_add_action_to_group( $action_controls, &$groups ) {
138 97 $grouped = array();
139 -
140 98 foreach ( $groups as $group ) {
141 99 if ( isset( $group['actions'] ) ) {
142 100 $grouped = array_merge( $grouped, $group['actions'] );
143 101 }
@@ -143,14 +101,13 @@
143 101 }
144 102 }
145 103
146 104 foreach ( $action_controls as $action ) {
147 - if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped, true ) ) {
105 + if ( isset( $groups[ $action->id_base ] ) || in_array( $action->id_base, $grouped ) ) {
148 106 continue;
149 107 }
150 108
151 109 $this_group = $action->action_options['group'];
152 -
153 110 if ( ! isset( $groups[ $this_group ] ) ) {
154 111 $this_group = 'misc';
155 112 }
156 113
@@ -169,23 +126,21 @@
169 126 * @return array
170 127 */
171 128 public static function form_action_groups() {
172 129 $groups = array(
173 - 'misc' => array(
130 + 'misc' => array(
174 131 'name' => '',
175 - 'icon' => 'frmfont frm_shuffle_icon',
132 + 'icon' => 'frm_icon_font frm_shuffle_icon',
176 133 'actions' => array(
177 134 'email',
178 135 'wppost',
179 136 'register',
180 - 'quiz',
181 - 'quiz_outcome',
182 137 'twilio',
183 138 ),
184 139 ),
185 140 'payment' => array(
186 141 'name' => __( 'eCommerce', 'formidable' ),
187 - 'icon' => 'frmfont frm_credit_card_alt_icon',
142 + 'icon' => 'frm_icon_font frm_credit_card_alt_icon',
188 143 'actions' => array(
189 144 'paypal',
190 145 'payment',
191 146 ),
@@ -191,9 +146,9 @@
191 146 ),
192 147 ),
193 148 'marketing' => array(
194 149 'name' => __( 'Email Marketing', 'formidable' ),
195 - 'icon' => 'frmfont frm_mail_bulk_icon',
150 + 'icon' => 'frm_icon_font frm_mail_bulk_icon',
196 151 'actions' => array(
197 152 'mailchimp',
198 153 'activecampaign',
199 154 'constantcontact',
@@ -199,15 +154,18 @@
199 154 'constantcontact',
200 155 'getresponse',
201 156 'aweber',
202 157 'mailpoet',
203 - 'convertkit',
204 158 ),
205 159 ),
206 160 'crm' => array(
207 161 'name' => __( 'CRM', 'formidable' ),
208 - 'icon' => 'frmfont frm_address_card_icon',
209 - 'actions' => self::get_crm_actions(),
162 + 'icon' => 'frm_icon_font frm_address_card_icon',
163 + 'actions' => array(
164 + 'salesforce',
165 + 'hubspot',
166 + 'highrise',
167 + ),
210 168 ),
211 169 );
212 170
213 171 return apply_filters( 'frm_action_groups', $groups );
@@ -213,47 +171,21 @@
213 171 return apply_filters( 'frm_action_groups', $groups );
214 172 }
215 173
216 174 /**
217 - * Get the actions to include in the CRM section.
218 - *
219 - * @since 6.23
220 - *
221 - * @return array
222 - */
223 - private static function get_crm_actions() {
224 - $crm_actions = array(
225 - 'salesforce',
226 - 'hubspot',
227 - );
228 -
229 - // Only include Highrise when the add-on is active.
230 - // This is because Highrise is deprecated. We don't want to show it in Lite.
231 - if ( class_exists( 'FrmHrsSettings' ) ) {
232 - $crm_actions[] = 'highrise';
233 - }
234 -
235 - return $crm_actions;
236 - }
237 -
238 - /**
239 175 * Get the number of currently active form actions.
240 176 *
241 177 * @since 4.0
242 178 *
243 - * @param array $action_controls
244 - *
245 179 * @return array
246 180 */
247 181 private static function active_actions( $action_controls ) {
248 182 $allowed = array();
249 -
250 183 foreach ( $action_controls as $action_control ) {
251 - if ( ! empty( $action_control->action_options['active'] ) ) {
184 + if ( isset( $action_control->action_options['active'] ) && $action_control->action_options['active'] ) {
252 185 $allowed[] = $action_control->id_base;
253 186 }
254 187 }
255 -
256 188 return $allowed;
257 189 }
258 190
259 191 /**
@@ -259,30 +191,29 @@
259 191 /**
260 192 * For each add-on, add an li, class, and javascript function. If active, add an additional class.
261 193 *
262 194 * @since 4.0
263 - *
264 195 * @param object $action_control
265 196 * @param array $allowed
266 197 */
267 198 public static function show_action_icon_link( $action_control, $allowed ) {
268 - $data = array();
269 - $classes = ' frm_' . $action_control->id_base . '_action frm_single_action';
199 + $data = array();
200 + $classes = ' frm_' . $action_control->id_base . '_action frm_single_action';
201 +
270 202 $group_class = ' frm-group-' . $action_control->action_options['group'];
271 203
272 204 /* translators: %s: Name of form action */
273 205 $upgrade_label = sprintf( esc_html__( '%s form actions', 'formidable' ), $action_control->action_options['tooltip'] );
274 206
275 - $default_shown = array( 'wppost', 'register', 'payment', 'quiz', 'hubspot' );
207 + $default_shown = array( 'wppost', 'register', 'paypal', 'payment', 'hubspot' );
276 208 $default_shown = array_values( array_diff( $default_shown, $allowed ) );
277 - $default_position = array_search( $action_control->id_base, $default_shown, true );
209 + $default_position = array_search( $action_control->id_base, $default_shown );
278 210 $allowed_count = count( $allowed );
279 211
280 - if ( ! empty( $action_control->action_options['active'] ) ) {
212 + if ( isset( $action_control->action_options['active'] ) && $action_control->action_options['active'] ) {
281 213 $classes .= ' frm_active_action';
282 214 } else {
283 215 $classes .= ' frm_inactive_action';
284 -
285 216 if ( $default_position !== false && ( $allowed_count + $default_position ) < 6 ) {
286 217 $group_class .= ' frm-default-show';
287 218 }
288 219
@@ -289,9 +220,8 @@
289 220 $data['data-upgrade'] = $upgrade_label;
290 221 $data['data-medium'] = 'settings-' . $action_control->id_base;
291 222
292 223 $upgrading = FrmAddonsController::install_link( $action_control->action_options['plugin'] );
293 -
294 224 if ( isset( $upgrading['url'] ) ) {
295 225 $data['data-oneclick'] = json_encode( $upgrading );
296 226 }
297 227
@@ -298,21 +228,19 @@
298 228 if ( isset( $action_control->action_options['message'] ) ) {
299 229 $data['data-message'] = $action_control->action_options['message'];
300 230 }
301 231
302 - $requires = FrmFormsHelper::get_plan_required( $upgrading );
303 -
304 - if ( $requires && 'free' !== $requires ) {
232 + $requires = self::action_requires( $upgrading );
233 + if ( $requires ) {
305 234 $data['data-requires'] = $requires;
306 235 }
307 - }//end if
236 + }
308 237
309 238 // HTML to include on the icon.
310 239 $icon_atts = array();
311 -
312 - if ( $action_control->action_options['color'] !== 'var(--primary-700)' ) {
240 + if ( $action_control->action_options['color'] !== 'var(--primary-hover)' ) {
313 241 $icon_atts = array(
314 - 'style' => '--primary-700:' . $action_control->action_options['color'],
242 + 'style' => '--primary-hover:' . $action_control->action_options['color'],
315 243 );
316 244 }
317 245
318 246 include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/_action_icon.php';
@@ -318,16 +246,33 @@
318 246 include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/_action_icon.php';
319 247 }
320 248
321 249 /**
322 - * @param string $action
250 + * @since 5.0.06
323 251 *
324 - * @return array|FrmFormAction A single form action is returned when a specific $action value is requested.
252 + * @param array $upgrading
253 + * @return string|false
325 254 */
255 + private static function action_requires( $upgrading ) {
256 + if ( ! isset( $upgrading['categories'] ) || ! is_array( $upgrading['categories'] ) ) {
257 + return false;
258 + }
259 + $plans = array( 'Business', 'Elite', 'Basic' );
260 + $plus_plans = array( 'Creator', 'Personal', 'Plus' );
261 + foreach ( $upgrading['categories'] as $category ) {
262 + if ( in_array( $category, $plans, true ) ) {
263 + return $category;
264 + }
265 + if ( in_array( $category, $plus_plans, true ) ) {
266 + return 'Plus';
267 + }
268 + }
269 + return false;
270 + }
271 +
326 272 public static function get_form_actions( $action = 'all' ) {
327 273 $temp_actions = self::$registered_actions;
328 -
329 - if ( ! $temp_actions ) {
274 + if ( empty( $temp_actions ) ) {
330 275 self::actions_init();
331 276 $temp_actions = self::$registered_actions->actions;
332 277 } else {
333 278 $temp_actions = $temp_actions->actions;
@@ -335,9 +280,9 @@
335 280
336 281 $actions = array();
337 282
338 283 foreach ( $temp_actions as $a ) {
339 - if ( 'all' !== $action && $a->id_base === $action ) {
284 + if ( 'all' != $action && $a->id_base == $action ) {
340 285 return $a;
341 286 }
342 287
343 288 $actions[ $a->id_base ] = $a;
@@ -347,16 +292,11 @@
347 292 }
348 293
349 294 /**
350 295 * @since 2.0
351 - *
352 - * @param object $form
353 - * @param array $values
354 - *
355 - * @return void
356 296 */
357 297 public static function list_actions( $form, $values ) {
358 - if ( ! $form ) {
298 + if ( empty( $form ) ) {
359 299 return;
360 300 }
361 301
362 302 /**
@@ -370,11 +310,8 @@
370 310 'post_status' => 'all',
371 311 );
372 312 $form_actions = FrmFormAction::get_action_for_form( $form->id, 'all', $filters );
373 313
374 - /**
375 - * @var array
376 - */
377 314 $action_controls = self::get_form_actions();
378 315
379 316 $action_map = array();
380 317
@@ -381,10 +318,8 @@
381 318 foreach ( $action_controls as $key => $control ) {
382 319 $action_map[ $control->id_base ] = $key;
383 320 }
384 321
385 - self::maybe_show_limit_warning( $form->id, $form_actions );
386 -
387 322 foreach ( $form_actions as $action ) {
388 323 if ( ! isset( $action_map[ $action->post_excerpt ] ) ) {
389 324 // don't try and show settings if action no longer exists
390 325 continue;
@@ -393,60 +328,14 @@
393 328 self::action_control( $action, $form, $action->ID, $action_controls[ $action_map[ $action->post_excerpt ] ], $values );
394 329 }
395 330 }
396 331
397 - /**
398 - * Show a warning before the form actions list if there are 99 actions, and the limit is set to 99.
399 - * If it is filtered, the warning is still shown when applicable, just using the new limit.
400 - *
401 - * @since 6.17
402 - *
403 - * @param int|string $form_id
404 - * @param array $form_actions
405 - *
406 - * @return void
407 - */
408 - private static function maybe_show_limit_warning( $form_id, $form_actions ) {
409 - $count = count( $form_actions );
410 -
411 - if ( $count < 99 ) {
412 - return;
413 - }
414 -
415 - $limit = FrmFormAction::get_action_limit( $form_id );
416 -
417 - if ( $limit < 99 || $count < $limit ) {
418 - return;
419 - }
420 -
421 - $documentation_url = 'https://formidableforms.com/knowledgebase/frm_form_action_limit/#kb-increase-limit-of-form-actions';
422 -
423 - echo '<div class="frm_warning_style">';
424 - FrmAppHelper::icon_by_class( 'frmfont frm_alert_icon' );
425 - echo '&nbsp;';
426 - printf(
427 - // translators: %s: URL to documentation
428 - esc_html__( 'You have reached your form action limit. To increase this limit, you will require additional code. Visit our documentation at %s.', 'formidable' ),
429 - '<a href="' . esc_url( $documentation_url ) . '" target="_blank">' . esc_html( $documentation_url ) . '</a>'
430 - );
431 - echo '</div>';
432 - }
433 -
434 - /**
435 - * @param WP_Post $form_action
436 - * @param object $form
437 - * @param int $action_key Action ID.
438 - * @param FrmFormAction $action_control
439 - * @param array $values
440 - *
441 - * @return void
442 - */
443 332 public static function action_control( $form_action, $form, $action_key, $action_control, $values ) {
444 333 $action_control->_set( $action_key );
445 334
446 335 $use_logging = self::should_show_log_message( $form_action->post_excerpt );
447 336
448 - include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/form_action.php';
337 + include( FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/form_action.php' );
449 338 }
450 339
451 340 public static function add_form_action() {
452 341 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -456,21 +345,20 @@
456 345
457 346 $action_key = FrmAppHelper::get_param( 'list_id', '', 'post', 'absint' );
458 347 $action_type = FrmAppHelper::get_param( 'type', '', 'post', 'sanitize_text_field' );
459 348
460 - /**
461 - * @var FrmFormAction
462 - */
463 349 $action_control = self::get_form_actions( $action_type );
464 350 $action_control->_set( $action_key );
465 351
466 - $form_id = FrmAppHelper::get_param( 'form_id', '', 'post', 'absint' );
352 + $form_id = FrmAppHelper::get_param( 'form_id', '', 'post', 'absint' );
353 +
467 354 $form_action = $action_control->prepare_new( $form_id );
468 355 $use_logging = self::should_show_log_message( $action_type );
469 - $values = array();
470 - $form = self::fields_to_values( $form_id, $values );
471 356
472 - include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/form_action.php';
357 + $values = array();
358 + $form = self::fields_to_values( $form_id, $values );
359 +
360 + include( FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/form_action.php' );
473 361 wp_die();
474 362 }
475 363
476 364 public static function fill_action() {
@@ -476,43 +364,36 @@
476 364 public static function fill_action() {
477 365 FrmAppHelper::permission_check( 'frm_edit_forms' );
478 366 check_ajax_referer( 'frm_ajax', 'nonce' );
479 367
480 - $action_key = FrmAppHelper::get_param( 'action_id', '', 'post', 'absint' );
481 - $action_type = FrmAppHelper::get_param( 'action_type', '', 'post', 'sanitize_text_field' );
368 + $action_key = FrmAppHelper::get_param( 'action_id', '', 'post', 'absint' );
369 + $action_type = FrmAppHelper::get_param( 'action_type', '', 'post', 'sanitize_text_field' );
370 +
482 371 $action_control = self::get_form_actions( $action_type );
483 -
484 - if ( ! $action_control ) {
372 + if ( empty( $action_control ) ) {
485 373 wp_die();
486 374 }
487 375
488 376 $form_action = $action_control->get_single_action( $action_key );
489 - $values = array();
490 - $form = self::fields_to_values( $form_action->menu_order, $values );
377 +
378 + $values = array();
379 + $form = self::fields_to_values( $form_action->menu_order, $values );
380 +
491 381 $use_logging = self::should_show_log_message( $action_type );
492 382
493 - include FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/_action_inside.php';
383 + include( FrmAppHelper::plugin_path() . '/classes/views/frm-form-actions/_action_inside.php' );
494 384 wp_die();
495 385 }
496 386
497 387 /**
498 388 * @since 3.06.04
499 - *
500 - * @param string $action_type
501 - *
502 389 * @return bool
503 390 */
504 391 private static function should_show_log_message( $action_type ) {
505 392 $logging = array( 'api', 'salesforce', 'constantcontact', 'activecampaign' );
506 - return in_array( $action_type, $logging, true ) && ! function_exists( 'frm_log_autoloader' );
393 + return in_array( $action_type, $logging ) && ! function_exists( 'frm_log_autoloader' );
507 394 }
508 395
509 - /**
510 - * @param int|string $form_id
511 - * @param array $values
512 - *
513 - * @return object
514 - */
515 396 private static function fields_to_values( $form_id, array &$values ) {
516 397 $form = FrmForm::getOne( $form_id );
517 398
518 399 $values = array(
@@ -520,14 +401,12 @@
520 401 'id' => $form->id,
521 402 );
522 403
523 404 $fields = FrmField::get_all_for_form( $form->id );
524 -
525 405 foreach ( $fields as $k => $f ) {
526 406 $f = (array) $f;
527 407 $opts = (array) $f['field_options'];
528 408 $f = array_merge( $opts, $f );
529 -
530 409 if ( ! isset( $f['post_field'] ) ) {
531 410 $f['post_field'] = '';
532 411 }
533 412 $values['fields'][] = $f;
@@ -536,33 +415,13 @@
536 415
537 416 return $form;
538 417 }
539 418
540 - /**
541 - * @param int $form_id
542 - *
543 - * @return void
544 - */
545 419 public static function update_settings( $form_id ) {
546 420 FrmAppHelper::permission_check( 'frm_edit_forms' );
547 421 $process_form = FrmAppHelper::get_post_param( 'process_form', '', 'sanitize_text_field' );
548 -
549 422 if ( ! wp_verify_nonce( $process_form, 'process_form_nonce' ) ) {
550 - $frm_settings = FrmAppHelper::get_settings();
551 - $error_args = array(
552 - 'title' => __( 'Verification failed', 'formidable' ),
553 - 'body' => $frm_settings->admin_permission,
554 - 'cancel_url' => add_query_arg(
555 - array(
556 - 'page' => 'formidable',
557 - 'frm_action' => 'settings',
558 - 'id' => $form_id,
559 - ),
560 - admin_url( 'admin.php?' )
561 - ),
562 - );
563 - FrmAppController::show_error_modal( $error_args );
564 - return;
423 + wp_die( esc_html__( 'You do not have permission to do that', 'formidable' ) );
565 424 }
566 425
567 426 global $wpdb;
568 427
@@ -579,33 +438,24 @@
579 438 $new_actions = array();
580 439
581 440 foreach ( $registered_actions as $registered_action ) {
582 441 $action_ids = $registered_action->update_callback( $form_id );
583 -
584 - if ( $action_ids ) {
442 + if ( ! empty( $action_ids ) ) {
585 443 $new_actions[] = $action_ids;
586 444 }
587 445 }
588 446
589 447 // Only use array_merge if there are new actions.
590 - if ( $new_actions ) {
448 + if ( ! empty( $new_actions ) ) {
591 449 $new_actions = call_user_func_array( 'array_merge', $new_actions );
592 450 }
593 -
594 451 $old_actions = array_diff( $old_actions, $new_actions );
595 452
596 453 self::delete_missing_actions( $old_actions );
597 -
598 - FrmOnSubmitHelper::save_on_submit_settings( $form_id );
599 454 }
600 455
601 - /**
602 - * @param array $old_actions
603 - *
604 - * @return void
605 - */
606 456 public static function delete_missing_actions( $old_actions ) {
607 - if ( $old_actions ) {
457 + if ( ! empty( $old_actions ) ) {
608 458 foreach ( $old_actions as $old_id ) {
609 459 wp_delete_post( $old_id );
610 460 }
611 461 FrmDb::cache_delete_group( 'frm_actions' );
@@ -611,60 +461,35 @@
611 461 FrmDb::cache_delete_group( 'frm_actions' );
612 462 }
613 463 }
614 464
615 - /**
616 - * @param int|string $entry_id
617 - * @param int|string $form_id
618 - * @param array $args
619 - *
620 - * @return void
621 - */
622 465 public static function trigger_create_actions( $entry_id, $form_id, $args = array() ) {
623 466 $filter_args = $args;
624 467 $filter_args['entry_id'] = $entry_id;
625 468 $filter_args['form_id'] = $form_id;
626 469
627 - /**
628 - * @since 2.0.23
629 - * @since 6.11.2 $filter_args is now passed instead of $args. It includes additional ID data.
630 - *
631 - * @param string $event 'create' by default. Pro may filter this value to 'draft' instead.
632 - * @param array $filter_args
633 - */
634 - $event = apply_filters( 'frm_trigger_create_action', 'create', $filter_args );
470 + $event = apply_filters( 'frm_trigger_create_action', 'create', $args );
635 471
636 472 self::trigger_actions( $event, $form_id, $entry_id, 'all', $args );
637 473 }
638 474
639 475 /**
640 - * @param string $event
641 - * @param int|object|string $form
642 - * @param int|string $entry
643 - * @param string $type
644 - * @param array $args
645 - *
646 - * @return void
476 + * @param string $event
647 477 */
648 - public static function trigger_actions( $event, $form, $entry, $type = 'all', $args = array() ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
478 + public static function trigger_actions( $event, $form, $entry, $type = 'all', $args = array() ) {
649 479 $action_status = array(
650 480 'post_status' => 'publish',
651 481 );
652 - $form_actions = FrmFormAction::get_action_for_form( ( is_object( $form ) ? $form->id : $form ), $type, $action_status );
482 + $form_actions = FrmFormAction::get_action_for_form( ( is_object( $form ) ? $form->id : $form ), $type, $action_status );
653 483
654 - if ( ! $form_actions ) {
484 + if ( empty( $form_actions ) ) {
655 485 return;
656 486 }
657 487
658 488 FrmForm::maybe_get_form( $form );
659 489
660 - if ( ! is_object( $form ) ) {
661 - return;
662 - }
663 -
664 490 $link_settings = self::get_form_actions( $type );
665 -
666 - if ( 'all' !== $type ) {
491 + if ( 'all' != $type ) {
667 492 $link_settings = array( $type => $link_settings );
668 493 }
669 494
670 495 $stored_actions = array();
@@ -669,9 +494,9 @@
669 494
670 495 $stored_actions = array();
671 496 $action_priority = array();
672 497
673 - if ( in_array( $event, array( 'create', 'update' ), true ) && defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
498 + if ( in_array( $event, array( 'create', 'update' ) ) && defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
674 499 $this_event = 'import';
675 500 } else {
676 501 $this_event = $event;
677 502 }
@@ -676,11 +501,11 @@
676 501 $this_event = $event;
677 502 }
678 503
679 504 foreach ( $form_actions as $action ) {
680 - $skip_this_action = ! in_array( $this_event, $action->post_content['event'], true ) || FrmOnSubmitAction::$slug === $action->post_excerpt;
505 +
506 + $skip_this_action = ( ! in_array( $this_event, $action->post_content['event'] ) );
681 507 $skip_this_action = apply_filters( 'frm_skip_form_action', $skip_this_action, compact( 'action', 'entry', 'form', 'event' ) );
682 -
683 508 if ( $skip_this_action ) {
684 509 continue;
685 510 }
686 511
@@ -687,18 +512,17 @@
687 512 if ( ! is_object( $entry ) ) {
688 513 $entry = FrmEntry::getOne( $entry, true );
689 514 }
690 515
691 - if ( ! $entry || ( FrmEntriesHelper::DRAFT_ENTRY_STATUS === (int) $entry->is_draft && 'draft' !== $event ) ) {
516 + if ( empty( $entry ) || ( $entry->is_draft && $event != 'draft' ) ) {
692 517 continue;
693 518 }
694 519
695 - $child_entry = ( is_numeric( $form->parent_form_id ) && $form->parent_form_id ) || ( $entry && ( (int) $entry->form_id !== (int) $form->id || $entry->parent_item_id ) ) || ! empty( $args['is_child'] ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
520 + $child_entry = ( ( is_object( $form ) && is_numeric( $form->parent_form_id ) && $form->parent_form_id ) || ( $entry && ( $entry->form_id != $form->id || $entry->parent_item_id ) ) || ( isset( $args['is_child'] ) && $args['is_child'] ) );
696 521
697 522 if ( $child_entry ) {
698 523 // maybe trigger actions for sub forms
699 524 $trigger_children = apply_filters( 'frm_use_embedded_form_actions', false, compact( 'form', 'entry' ) );
700 -
701 525 if ( ! $trigger_children ) {
702 526 continue;
703 527 }
704 528 }
@@ -704,9 +528,8 @@
704 528 }
705 529
706 530 // Check conditional logic.
707 531 $stop = FrmFormAction::action_conditions_met( $action, $entry );
708 -
709 532 if ( $stop ) {
710 533 continue;
711 534 }
712 535
@@ -714,11 +537,11 @@
714 537 $stored_actions[ $action->ID ] = $action;
715 538 $action_priority[ $action->ID ] = $link_settings[ $action->post_excerpt ]->action_options['priority'];
716 539
717 540 unset( $action );
718 - }//end foreach
541 + }
719 542
720 - if ( $stored_actions ) {
543 + if ( ! empty( $stored_actions ) ) {
721 544 asort( $action_priority );
722 545
723 546 // Make sure hooks are loaded.
724 547 new FrmNotification();
@@ -724,49 +547,25 @@
724 547 new FrmNotification();
725 548
726 549 foreach ( $action_priority as $action_id => $priority ) {
727 550 $action = $stored_actions[ $action_id ];
551 + do_action( 'frm_trigger_' . $action->post_excerpt . '_action', $action, $entry, $form, $event );
552 + do_action( 'frm_trigger_' . $action->post_excerpt . '_' . $event . '_action', $action, $entry, $form );
728 553
729 - /**
730 - * Allows custom form action trigger.
731 - *
732 - * @since 6.10
733 - *
734 - * @param bool $skip Skip default trigger.
735 - * @param object $action Action object.
736 - * @param object $entry Entry object.
737 - * @param object $form Form object.
738 - * @param string $event Event ('create' or 'update').
739 - */
740 - if ( false === apply_filters( 'frm_custom_trigger_action', false, $action, $entry, $form, $event ) ) {
741 - do_action( 'frm_trigger_' . $action->post_excerpt . '_action', $action, $entry, $form, $event );
742 - do_action( 'frm_trigger_' . $action->post_excerpt . '_' . $event . '_action', $action, $entry, $form );
743 - }
744 -
745 554 // If post is created, get updated $entry object.
746 - if ( $action->post_excerpt === 'wppost' && $event === 'create' ) {
555 + if ( $action->post_excerpt == 'wppost' && $event == 'create' ) {
747 556 $entry = FrmEntry::getOne( $entry->id, true );
748 557 }
749 - }//end foreach
750 - }//end if
558 + }
559 + }
751 560 }
752 561
753 - /**
754 - * @param int|string $form_id
755 - * @param array $values
756 - * @param array $args
757 - *
758 - * @return void
759 - */
760 562 public static function duplicate_form_actions( $form_id, $values, $args = array() ) {
761 - if ( empty( $args['old_id'] ) ) {
563 + if ( ! isset( $args['old_id'] ) || empty( $args['old_id'] ) ) {
762 564 // Continue if we know which actions to copy.
763 565 return;
764 566 }
765 567
766 - /**
767 - * @var array
768 - */
769 568 $action_controls = self::get_form_actions();
770 569
771 570 foreach ( $action_controls as $action_control ) {
772 571 $action_control->duplicate_form_actions( $form_id, $args['old_id'] );
@@ -773,13 +572,8 @@
773 572 unset( $action_control );
774 573 }
775 574 }
776 575
777 - /**
778 - * @param string $where
779 - *
780 - * @return string
781 - */
782 576 public static function limit_by_type( $where ) {
783 577 global $frm_vars, $wpdb;
784 578
785 579 if ( ! isset( $frm_vars['action_type'] ) ) {
@@ -785,31 +579,15 @@
785 579 if ( ! isset( $frm_vars['action_type'] ) ) {
786 580 return $where;
787 581 }
788 582
789 - return $where . $wpdb->prepare( ' AND post_excerpt = %s ', $frm_vars['action_type'] );
790 - }
583 + $where .= $wpdb->prepare( ' AND post_excerpt = %s ', $frm_vars['action_type'] );
791 584
792 - /**
793 - * Prevent WPML from filtering form actions based on the active language.
794 - *
795 - * @since 6.20
796 - *
797 - * @param bool|null $null
798 - * @param string $post_type
799 - *
800 - * @return bool|null
801 - */
802 - public static function prevent_wpml_translations( $null, $post_type ) {
803 - return self::$action_post_type === $post_type ? false : $null;
585 + return $where;
804 586 }
805 587 }
806 588
807 589 class Frm_Form_Action_Factory {
808 -
809 - /**
810 - * @var array
811 - */
812 590 public $actions = array();
813 591
814 592 public function __construct() {
815 593 add_action( 'frm_form_actions_init', array( $this, '_register_actions' ), 100 );
@@ -814,22 +592,12 @@
814 592 public function __construct() {
815 593 add_action( 'frm_form_actions_init', array( $this, '_register_actions' ), 100 );
816 594 }
817 595
818 - /**
819 - * @param string $action_class
820 - *
821 - * @return void
822 - */
823 596 public function register( $action_class ) {
824 597 $this->actions[ $action_class ] = new $action_class();
825 598 }
826 599
827 - /**
828 - * @param string $action_class
829 - *
830 - * @return void
831 - */
832 600 public function unregister( $action_class ) {
833 601 if ( isset( $this->actions[ $action_class ] ) ) {
834 602 unset( $this->actions[ $action_class ] );
835 603 }