PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.0.14
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.0.14
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +170 -563 6.285.0.14 View file →
@@ -6,10 +6,9 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 - * @return bool|int id on success or false on failure.
10 + * @return int|boolean id on success or false on failure
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
15 14
@@ -18,33 +17,24 @@
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 19 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 - /**
38 - * Allows modifying form options before updating or creating.
39 - *
40 - * @since 5.4 Add the third param.
41 - *
42 - * @param array $options Form options.
43 - * @param array $values Form data.
44 - * @param bool $update Is form updating or creating. It's `true` if is updating.
45 - */
46 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, false );
36 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
47 37 $options = self::maybe_filter_form_options( $options );
48 38 $new_values['options'] = serialize( $options );
49 39
50 40 $wpdb->insert( $wpdb->prefix . 'frm_forms', $new_values );
@@ -60,9 +50,8 @@
60 50 /**
61 51 * @since 5.0.08
62 52 *
63 53 * @param array $options
64 - *
65 54 * @return array
66 55 */
67 56 private static function maybe_filter_form_options( $options ) {
68 57 if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
@@ -71,22 +60,14 @@
71 60 return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 61 }
73 62
74 63 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 - * @return bool|int ID on success or false on failure
64 + * @return int|boolean ID on success or false on failure
83 65 */
84 66 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 67 global $wpdb;
86 68
87 69 $values = self::getOne( $id, $blog_id );
88 -
89 70 if ( ! $values ) {
90 71 return false;
91 72 }
92 73
@@ -103,10 +84,10 @@
103 84 'is_template' => $template ? 1 : 0,
104 85 );
105 86
106 87 if ( $blog_id ) {
107 - $new_values['status'] = 'published';
108 - $new_options = $values->options;
88 + $new_values['status'] = 'published';
89 + $new_options = $values->options;
109 90 FrmAppHelper::unserialize_or_decode( $new_options );
110 91 $new_options['email_to'] = get_option( 'admin_email' );
111 92 $new_options['copy'] = false;
112 93 $new_values['options'] = $new_options;
@@ -126,9 +107,9 @@
126 107
127 108 $form_id = $wpdb->insert_id;
128 109 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 110
130 - // Update form settings after fields are created
111 + // update form settings after fields are created
131 112 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 113
133 114 return $form_id;
134 115 }
@@ -135,16 +116,10 @@
135 116
136 117 return false;
137 118 }
138 119
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 120 public static function after_duplicate( $form_id, $values ) {
146 - $new_opts = $values['options'];
121 + $new_opts = $values['options'];
147 122 FrmAppHelper::unserialize_or_decode( $new_opts );
148 123 $values['options'] = $new_opts;
149 124
150 125 if ( isset( $new_opts['success_msg'] ) ) {
@@ -152,105 +127,17 @@
152 127 }
153 128
154 129 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 130
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 131 if ( $new_opts != $values['options'] ) {
158 132 global $wpdb;
159 133 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 134 }
161 -
162 - self::switch_field_ids_in_fields( $form_id );
163 135 }
164 136
165 137 /**
166 - * Switches field ID in fields.
167 - *
168 - * @since 5.3
169 - *
170 - * @param int $form_id Form ID.
171 - *
172 - * @return void
138 + * @return int|boolean
173 139 */
174 - private static function switch_field_ids_in_fields( $form_id ) {
175 - global $wpdb;
176 -
177 - // Keys of fields that you want to check to replace field ID.
178 - $keys = array( 'default_value', 'field_options' );
179 - $sql_cols = 'fi.id';
180 -
181 - foreach ( $keys as $key ) {
182 - $sql_cols .= ',fi.' . $key;
183 - }
184 -
185 - $fields = FrmDb::get_results(
186 - "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id",
187 - array(
188 - 'or' => 1,
189 - 'fi.form_id' => $form_id,
190 - 'fr.parent_form_id' => $form_id,
191 - ),
192 - $sql_cols
193 - );
194 -
195 - if ( ! $fields || ! is_array( $fields ) ) {
196 - return;
197 - }
198 -
199 - foreach ( $fields as $field ) {
200 - self::switch_field_ids_in_field( (array) $field );
201 - }
202 - }
203 -
204 - /**
205 - * Switches field ID in a field.
206 - *
207 - * @since 5.3
208 - *
209 - * @param array $field Field array.
210 - *
211 - * @return void
212 - */
213 - private static function switch_field_ids_in_field( $field ) {
214 - $new_values = array();
215 -
216 - foreach ( $field as $key => $value ) {
217 - if ( 'id' === $key || ! $value ) {
218 - continue;
219 - }
220 -
221 - if ( ! is_string( $value ) && ! is_array( $value ) ) {
222 - continue;
223 - }
224 -
225 - if ( 'field_options' === $key ) {
226 - // Need to loop through field_options to prevent breaking serialized string when length changed.
227 - FrmAppHelper::unserialize_or_decode( $value );
228 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
229 - $new_val = serialize( $new_val );
230 - } else {
231 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
232 - }
233 -
234 - if ( $new_val !== $value ) {
235 - $new_values[ $key ] = $new_val;
236 - }
237 - }//end foreach
238 -
239 - if ( $new_values ) {
240 - FrmField::update( $field['id'], $new_values );
241 - }
242 - }
243 -
244 - /**
245 - * Update a form.
246 - *
247 - * @param int $id Form ID.
248 - * @param array $values Form values to update.
249 - * @param bool $create_link Whether this is being called from link creation.
250 - *
251 - * @return bool|int
252 - */
253 140 public static function update( $id, $values, $create_link = false ) {
254 141 global $wpdb;
255 142
256 143 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
@@ -263,23 +150,23 @@
263 150 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
264 151 }
265 152
266 153 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
267 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
268 154
155 + $new_values = self::set_update_options( array(), $values );
156 +
269 157 foreach ( $values as $value_key => $value ) {
270 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
158 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
271 159 $new_values[ $value_key ] = $value;
272 160 }
273 161 }
274 162
275 - if ( ! empty( $values['new_status'] ) ) {
163 + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) {
276 164 $new_values['status'] = $values['new_status'];
277 165 }
278 166
279 - if ( $new_values ) {
167 + if ( ! empty( $new_values ) ) {
280 168 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
281 -
282 169 if ( $query_results ) {
283 170 self::clear_form_cache();
284 171 }
285 172 } else {
@@ -295,37 +182,24 @@
295 182 return $query_results;
296 183 }
297 184
298 185 /**
299 - * @param array $new_values
300 - * @param array $values
301 - * @param array $args
302 - *
303 186 * @return array
304 187 */
305 - public static function set_update_options( $new_values, $values, $args = array() ) {
188 + public static function set_update_options( $new_values, $values ) {
306 189 if ( ! isset( $values['options'] ) ) {
307 190 return $new_values;
308 191 }
309 192
310 - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
193 + $options = isset( $values['options'] ) ? (array) $values['options'] : array();
311 194 FrmFormsHelper::fill_form_options( $options, $values );
312 195
313 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
314 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
315 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
316 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
196 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
197 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
198 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
199 + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
317 200
318 - /**
319 - * Allows modifying form options before updating or creating.
320 - *
321 - * @since 5.4 Added the third param.
322 - *
323 - * @param array $options Form options.
324 - * @param array $values Form data.
325 - * @param bool $update Is form updating or creating. It's `true` if is updating.
326 - */
327 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, true );
201 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
328 202 $options = self::maybe_filter_form_options( $options );
329 203 $new_values['options'] = serialize( $options );
330 204
331 205 return $new_values;
@@ -331,14 +205,11 @@
331 205 return $new_values;
332 206 }
333 207
334 208 /**
335 - * @param int $id Form ID.
336 - * @param array $values Form values array.
337 - *
338 209 * @return array
339 210 */
340 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
211 + public static function update_fields( $id, $values ) {
341 212
342 213 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
343 214 return $values;
344 215 }
@@ -343,10 +214,9 @@
343 214 return $values;
344 215 }
345 216
346 217 $all_fields = FrmField::get_all_for_form( $id );
347 -
348 - if ( ! $all_fields ) {
218 + if ( empty( $all_fields ) ) {
349 219 return $values;
350 220 }
351 221
352 222 if ( ! isset( $values['item_meta'] ) ) {
@@ -354,28 +224,28 @@
354 224 }
355 225
356 226 $field_array = array();
357 227 $existing_keys = array_keys( $values['item_meta'] );
358 -
359 228 foreach ( $all_fields as $fid ) {
360 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
361 229 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
362 230 $values['item_meta'][ $fid->id ] = '';
363 231 }
364 -
365 232 $field_array[ $fid->id ] = $fid;
366 233 }
367 234 unset( $all_fields );
368 235
369 236 foreach ( $values['item_meta'] as $field_id => $default_value ) {
370 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
237 + if ( isset( $field_array[ $field_id ] ) ) {
238 + $field = $field_array[ $field_id ];
239 + } else {
240 + $field = FrmField::getOne( $field_id );
241 + }
371 242
372 243 if ( ! $field ) {
373 244 continue;
374 245 }
375 246
376 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
377 -
247 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
378 248 if ( $is_settings_page ) {
379 249 self::get_settings_page_html( $values, $field );
380 250
381 251 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -382,20 +252,15 @@
382 252 continue;
383 253 }
384 254 }
385 255
386 - // Updating the form.
256 + //updating the form
387 257 $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field );
388 - // Don't check for POST html.
389 - unset( $update_options['custom_html'] );
258 + unset( $update_options['custom_html'] ); // don't check for POST html
390 259 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
391 260
392 - if ( ! is_array( $field->field_options ) ) {
393 - $field->field_options = array();
394 - }
395 -
396 261 foreach ( $update_options as $opt => $default ) {
397 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
262 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
398 263 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
399 264 }
400 265
401 266 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -404,100 +269,44 @@
404 269 'field_options' => $field->field_options,
405 270 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
406 271 );
407 272
408 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
409 - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
410 - if ( is_array( $option ) ) {
411 - foreach ( $option as $key => $item ) {
412 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
413 - }
414 - }
415 - }
416 - }
417 -
418 273 self::prepare_field_update_values( $field, $values, $new_field );
419 - self::maybe_update_max_option( $field, $values, $new_field );
420 274
421 275 FrmField::update( $field_id, $new_field );
422 276
423 277 FrmField::delete_form_transient( $field->form_id );
424 - }//end foreach
278 + }
425 279 self::clear_form_cache();
426 280
427 281 return $values;
428 282 }
429 283
430 - /**
431 - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
432 - *
433 - * @since 6.7
434 - *
435 - * @param object $field
436 - * @param array $values
437 - * @param array $new_field
438 - *
439 - * @return void
440 - */
441 - private static function maybe_update_max_option( $field, $values, &$new_field ) {
442 - if ( $field->type === 'textarea' &&
443 - ! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
444 - in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
445 - $new_field['field_options']['max'] = '';
446 -
447 - /**
448 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
449 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
450 - */
451 - $_POST['field_options'][ 'max_' . $field->id ] = '';
452 - }
453 - }
454 -
455 - /**
456 - * @param string $opt
457 - * @param mixed $value
458 - *
459 - * @return void
460 - */
461 284 private static function sanitize_field_opt( $opt, &$value ) {
462 - if ( ! is_string( $value ) ) {
463 - return;
285 + if ( is_string( $value ) ) {
286 + if ( $opt === 'calc' ) {
287 + $value = self::sanitize_calc( $value );
288 + } else {
289 + $value = FrmAppHelper::kses( $value, 'all' );
290 + }
291 + $value = trim( $value );
464 292 }
465 -
466 - /**
467 - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead.
468 - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized.
469 - *
470 - * @since 6.0
471 - *
472 - * @param bool $should_sanitize
473 - * @param string $opt
474 - */
475 - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt );
476 -
477 - if ( ! $should_sanitize ) {
478 - return;
479 - }
480 -
481 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
482 - $value = trim( $value );
483 293 }
484 294
485 295 /**
486 296 * @param string $value
487 - *
488 297 * @return string
489 298 */
490 299 private static function sanitize_calc( $value ) {
491 - if ( str_contains( $value, '<' ) ) {
300 + if ( false !== strpos( $value, '<' ) ) {
492 301 $value = self::normalize_calc_spaces( $value );
493 302 }
494 - // Allow <= and >=.
495 - $allow = array( '<= ', ' >=' );
303 + $allow = array( '<= ', ' >=' ); // Allow <= and >=
496 304 $temp = array( '< = ', ' > =' );
497 305 $value = str_replace( $allow, $temp, $value );
498 306 $value = strip_tags( $value );
499 - return str_replace( $temp, $allow, $value );
307 + $value = str_replace( $temp, $allow, $value );
308 + return $value;
500 309 }
501 310
502 311 /**
503 312 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -503,58 +312,41 @@
503 312 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
504 313 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
505 314 *
506 315 * @param string $calc
507 - *
508 316 * @return string
509 317 */
510 318 private static function normalize_calc_spaces( $calc ) {
511 319 // Check for a pattern with 5 parts
512 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
320 + // $1 \d the first comparison digit.
513 321 // $2 a space (optional).
514 322 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
515 323 // $4 another space (optional).
516 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
517 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
324 + // $5 \d the second comparison digit.
325 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
518 326 }
519 327
520 328 /**
521 329 * Updating the settings page
522 - *
523 - * @param array $values Form values array.
524 - * @param object $field Field object, passed by reference.
525 - *
526 - * @return void
527 330 */
528 331 private static function get_settings_page_html( $values, &$field ) {
529 332 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
530 333 $prev_opts = array();
531 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
334 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
532 335
533 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
534 - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
336 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
337 + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
535 338 $prev_opts = $field->field_options;
536 339 }
537 340
538 - if ( ! isset( $prev_opts ) ) {
539 - return;
341 + if ( isset( $prev_opts ) ) {
342 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
343 + if ( $prev_opts != $field->field_options ) {
344 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
345 + }
540 346 }
541 -
542 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
543 -
544 - // phpcs:ignore Universal.Operators.StrictComparisons
545 - if ( $prev_opts != $field->field_options ) {
546 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
547 - }
548 347 }
549 348
550 - /**
551 - * @param object $field
552 - * @param array $values
553 - * @param array $new_field
554 - *
555 - * @return void
556 - */
557 349 private static function prepare_field_update_values( $field, $values, &$new_field ) {
558 350 $field_cols = array(
559 351 'field_order' => 0,
560 352 'field_key' => '',
@@ -563,16 +355,12 @@
563 355 'description' => '',
564 356 'options' => '',
565 357 'name' => '',
566 358 );
567 -
568 359 foreach ( $field_cols as $col => $default ) {
569 - $default = $default === '' ? $field->{$col} : $default;
570 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
571 - }
360 + $default = ( $default === '' ) ? $field->{$col} : $default;
572 361
573 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
574 - $new_field['field_order'] = $field->field_order;
362 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
575 363 }
576 364
577 365 // Don't save the template option.
578 366 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -584,12 +372,9 @@
584 372 * Get a list of all form settings that should be translated
585 373 * on a multilingual site.
586 374 *
587 375 * @since 3.06.01
588 - *
589 - * @param object $form The form object.
590 - *
591 - * @return array
376 + * @param object $form - The form object
592 377 */
593 378 public static function translatable_strings( $form ) {
594 379 $strings = array(
595 380 'name',
@@ -596,12 +381,8 @@
596 381 'description',
597 382 'submit_value',
598 383 'submit_msg',
599 384 'success_msg',
600 - 'invalid_msg',
601 - 'failed_msg',
602 - 'login_msg',
603 - 'admin_permission',
604 385 );
605 386
606 387 return apply_filters( 'frm_form_strings', $strings, $form );
607 388 }
@@ -606,21 +387,19 @@
606 387 return apply_filters( 'frm_form_strings', $strings, $form );
607 388 }
608 389
609 390 /**
610 - * @param array|int $id
611 - * @param string $status
391 + * @param string $status
612 392 *
613 - * @return bool|int
393 + * @return int|boolean
614 394 */
615 395 public static function set_status( $id, $status ) {
616 - if ( 'trash' === $status ) {
396 + if ( 'trash' == $status ) {
617 397 return self::trash( $id );
618 398 }
619 399
620 400 $statuses = array( 'published', 'draft', 'trash' );
621 -
622 - if ( ! in_array( $status, $statuses, true ) ) {
401 + if ( ! in_array( $status, $statuses ) ) {
623 402 return false;
624 403 }
625 404
626 405 global $wpdb;
@@ -633,9 +412,9 @@
633 412 );
634 413 FrmDb::get_where_clause_and_values( $where );
635 414 array_unshift( $where['values'], $status );
636 415
637 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
416 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
638 417 } else {
639 418 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
640 419 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
641 420 }
@@ -647,11 +426,9 @@
647 426 return $query_results;
648 427 }
649 428
650 429 /**
651 - * @param int|string $id Form ID.
652 - *
653 - * @return bool|int
430 + * @return int|boolean
654 431 */
655 432 public static function trash( $id ) {
656 433 if ( ! EMPTY_TRASH_DAYS ) {
657 434 return self::destroy( $id );
@@ -657,17 +434,12 @@
657 434 return self::destroy( $id );
658 435 }
659 436
660 437 $form = self::getOne( $id );
661 -
662 438 if ( ! $form ) {
663 439 return false;
664 440 }
665 441
666 - if ( $form->status === 'trash' ) {
667 - return false;
668 - }
669 -
670 442 $options = $form->options;
671 443 $options['trash_time'] = time();
672 444
673 445 global $wpdb;
@@ -700,26 +472,21 @@
700 472 return $query_results;
701 473 }
702 474
703 475 /**
704 - * @param int|string $id Form ID.
705 - *
706 - * @return bool|int
476 + * @return int|boolean
707 477 */
708 478 public static function destroy( $id ) {
709 479 global $wpdb;
710 480
711 481 $form = self::getOne( $id );
712 -
713 482 if ( ! $form ) {
714 483 return false;
715 484 }
716 -
717 485 $id = $form->id;
718 486
719 487 // Disconnect the entries from this form
720 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
721 -
488 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
722 489 foreach ( $entries as $entry_id ) {
723 490 FrmEntry::destroy( $entry_id );
724 491 unset( $entry_id );
725 492 }
@@ -724,29 +491,23 @@
724 491 unset( $entry_id );
725 492 }
726 493
727 494 // Disconnect the fields from this form
728 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
495 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
729 496
730 497 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
498 + if ( $query_results ) {
499 + // Delete all form actions linked to this form
500 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
501 + $action_control->destroy( $id, 'all' );
731 502
732 - if ( ! $query_results ) {
733 - return $query_results;
503 + // Clear form caching
504 + self::clear_form_cache();
505 +
506 + do_action( 'frm_destroy_form', $id );
507 + do_action( 'frm_destroy_form_' . $id );
734 508 }
735 509
736 - // Delete all form actions linked to this form
737 - /**
738 - * @var FrmFormAction
739 - */
740 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
741 - $action_control->destroy( $id, 'all' );
742 -
743 - // Clear form caching
744 - self::clear_form_cache();
745 -
746 - do_action( 'frm_destroy_form', $id );
747 - do_action( 'frm_destroy_form_' . $id );
748 -
749 510 return $query_results;
750 511 }
751 512
752 513 /**
@@ -751,34 +512,29 @@
751 512
752 513 /**
753 514 * Delete trashed forms based on how long they have been trashed
754 515 *
755 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
756 - *
757 516 * @return int The number of forms deleted
758 517 */
759 518 public static function scheduled_delete( $delete_timestamp = '' ) {
760 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
519 + global $wpdb;
761 520
521 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' );
522 +
762 523 if ( ! $trash_forms ) {
763 524 return 0;
764 525 }
765 526
766 - if ( ! $delete_timestamp ) {
527 + if ( empty( $delete_timestamp ) ) {
767 528 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
768 529 }
769 530
770 531 $count = 0;
771 -
772 532 foreach ( $trash_forms as $form ) {
773 533 FrmAppHelper::unserialize_or_decode( $form->options );
774 -
775 534 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
776 535 self::destroy( $form->id );
777 -
778 - if ( empty( $form->parent_form_id ) ) {
779 - ++$count;
780 - }
536 + $count ++;
781 537 }
782 538
783 539 unset( $form );
784 540 }
@@ -786,24 +542,23 @@
786 542 return $count;
787 543 }
788 544
789 545 /**
790 - * @param int|string $id Form ID or key.
791 - *
792 546 * @return string form name
793 547 */
794 548 public static function getName( $id ) {
795 549 $form = FrmDb::check_cache( $id, 'frm_form' );
550 + if ( $form ) {
551 + $r = stripslashes( $form->name );
796 552
797 - if ( $form ) {
798 - return stripslashes( $form->name );
553 + return $r;
799 554 }
800 555
801 556 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
802 557 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
558 + $r = stripslashes( $r );
803 559
804 - // An empty form name can result in a null value.
805 - return is_null( $r ) ? '' : stripslashes( $r );
560 + return $r;
806 561 }
807 562
808 563 /**
809 564 * @since 3.0
@@ -818,9 +573,9 @@
818 573
819 574 /**
820 575 * @since 3.0
821 576 *
822 - * @param int|string $id
577 + * @param int $id
823 578 *
824 579 * @return string form key
825 580 */
826 581 public static function get_key_by_id( $id ) {
@@ -825,57 +580,59 @@
825 580 */
826 581 public static function get_key_by_id( $id ) {
827 582 $id = (int) $id;
828 583 $cache = FrmDb::check_cache( $id, 'frm_form' );
829 -
830 584 if ( $cache ) {
831 585 return $cache->form_key;
832 586 }
833 587
834 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
588 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
589 +
590 + return $key;
835 591 }
836 592
837 593 /**
838 594 * If $form is numeric, get the form object
839 595 *
596 + * @param object|int $form
597 + *
840 598 * @since 2.0.9
841 - *
842 - * @param array|int|object $form
843 - *
844 - * @return void
845 599 */
846 600 public static function maybe_get_form( &$form ) {
847 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
601 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
848 602 $form = self::getOne( $form );
849 603 }
850 604 }
851 605
852 606 /**
853 - * @param int|string $id
854 - * @param false|int $blog_id
855 - *
856 - * @return stdClass|null
607 + * @return object form
857 608 */
858 609 public static function getOne( $id, $blog_id = false ) {
859 610 global $wpdb;
860 611
861 612 if ( $blog_id && is_multisite() ) {
862 - $prefix = $wpdb->get_blog_prefix( $blog_id );
613 + global $wpmuBaseTablePrefix;
614 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
615 +
863 616 $table_name = $prefix . 'frm_forms';
864 617 } else {
865 618 $table_name = $wpdb->prefix . 'frm_forms';
866 619 $cache = wp_cache_get( $id, 'frm_form' );
867 -
868 620 if ( $cache ) {
869 621 if ( isset( $cache->options ) ) {
870 622 FrmAppHelper::unserialize_or_decode( $cache->options );
871 623 }
872 624
873 - return self::prepare_form_row_data( $cache );
625 + return wp_unslash( $cache );
874 626 }
875 627 }
876 628
877 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
629 + if ( is_numeric( $id ) ) {
630 + $where = array( 'id' => $id );
631 + } else {
632 + $where = array( 'form_key' => $id );
633 + }
634 +
878 635 $results = FrmDb::get_row( $table_name, $where );
879 636
880 637 if ( isset( $results->options ) ) {
881 638 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -881,50 +638,18 @@
881 638 FrmDb::set_cache( $results->id, $results, 'frm_form' );
882 639 FrmAppHelper::unserialize_or_decode( $results->options );
883 640 }
884 641
885 - return self::prepare_form_row_data( $results );
642 + return apply_filters( 'frm_form_object', wp_unslash( $results ) );
886 643 }
887 644
888 645 /**
889 - * Make sure that if $row is an object, that $row->options is an array and not a string.
890 - *
891 - * @since 6.8.3
892 - *
893 - * @param stdClass|null $row The database row for a target form.
894 - *
895 - * @return stdClass|null
646 + * @return object|array of objects
896 647 */
897 - private static function prepare_form_row_data( $row ) {
898 - $row = wp_unslash( $row );
899 -
900 - if ( ! is_object( $row ) ) {
901 - return $row;
902 - }
903 -
904 - if ( ! is_array( $row->options ) ) {
905 - $row->options = FrmFormsHelper::get_default_opts();
906 - }
907 -
908 - /**
909 - * @since 4.03.02
910 - *
911 - * @param stdClass $row
912 - */
913 - return apply_filters( 'frm_form_object', $row );
914 - }
915 -
916 - /**
917 - * @param array|string $where Where conditions array or raw WHERE string.
918 - * @param string $order_by Order by clause.
919 - * @param int|string $limit Limit clause or number.
920 - *
921 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
922 - */
923 648 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
924 - if ( is_array( $where ) && $where ) {
925 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
926 - // Don't get trashed templates
649 + if ( is_array( $where ) && ! empty( $where ) ) {
650 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
651 + // don't get trashed templates
927 652 $where['status'] = array( null, '', 'published' );
928 653 }
929 654
930 655 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -930,10 +655,10 @@
930 655 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
931 656 } else {
932 657 global $wpdb;
933 658
934 - // The query has already been prepared if this is not an array.
935 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
659 + // the query has already been prepared if this is not an array
660 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
936 661 $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
937 662 }
938 663
939 664 if ( $results ) {
@@ -942,10 +667,10 @@
942 667 FrmAppHelper::unserialize_or_decode( $result->options );
943 668 }
944 669 }
945 670
946 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
947 - // Return the first form object if we are only getting one form
671 + if ( $limit == ' LIMIT 1' || $limit == 1 ) {
672 + // return the first form object if we are only getting one form
948 673 $results = reset( $results );
949 674 }
950 675
951 676 return wp_unslash( $results );
@@ -954,24 +679,20 @@
954 679 /**
955 680 * Get all published forms
956 681 *
957 682 * @since 2.0
958 - *
959 - * @param array $query
960 - * @param int $limit
961 - * @param string $inc_children
962 - *
963 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
683 + * @return array of forms
964 684 */
965 685 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
966 686 $query['is_template'] = 0;
967 687 $query['status'] = array( null, '', 'published' );
968 -
969 - if ( $inc_children === 'exclude' ) {
688 + if ( $inc_children == 'exclude' ) {
970 689 $query['parent_form_id'] = array( null, 0 );
971 690 }
972 691
973 - return self::getAll( $query, 'name', $limit );
692 + $forms = self::getAll( $query, 'name', $limit );
693 +
694 + return $forms;
974 695 }
975 696
976 697 /**
977 698 * @return object count of forms
@@ -976,16 +697,18 @@
976 697 /**
977 698 * @return object count of forms
978 699 */
979 700 public static function get_count() {
701 + global $wpdb;
702 +
980 703 $cache_key = 'frm_form_counts';
981 - $counts = wp_cache_get( $cache_key, 'frm_form' );
982 704
705 + $counts = wp_cache_get( $cache_key, 'frm_form' );
983 706 if ( false !== $counts ) {
984 707 return $counts;
985 708 }
986 709
987 - $results = FrmDb::get_results(
710 + $results = (array) FrmDb::get_results(
988 711 'frm_forms',
989 712 array(
990 713 'or' => 1,
991 714 'parent_form_id' => null,
@@ -997,20 +720,20 @@
997 720 $statuses = array( 'published', 'draft', 'template', 'trash' );
998 721 $counts = array_fill_keys( $statuses, 0 );
999 722
1000 723 foreach ( $results as $row ) {
1001 - if ( 'trash' !== $row->status ) {
724 + if ( 'trash' != $row->status ) {
1002 725 if ( $row->is_template ) {
1003 - ++$counts['template'];
726 + $counts['template'] ++;
1004 727 } else {
1005 - ++$counts['published'];
728 + $counts['published'] ++;
1006 729 }
1007 730 } else {
1008 - ++$counts['trash'];
731 + $counts['trash'] ++;
1009 732 }
1010 733
1011 - if ( 'draft' === $row->status ) {
1012 - ++$counts['draft'];
734 + if ( 'draft' == $row->status ) {
735 + $counts['draft'] ++;
1013 736 }
1014 737
1015 738 unset( $row );
1016 739 }
@@ -1026,10 +749,8 @@
1026 749 * Called when a form is created, updated, duplicated, or deleted
1027 750 * or when the form status is changed
1028 751 *
1029 752 * @since 2.0.4
1030 - *
1031 - * @return void
1032 753 */
1033 754 public static function clear_form_cache() {
1034 755 FrmDb::cache_delete_group( 'frm_form' );
1035 756 }
@@ -1034,22 +755,16 @@
1034 755 FrmDb::cache_delete_group( 'frm_form' );
1035 756 }
1036 757
1037 758 /**
1038 - * @param array $values Form values to validate.
1039 - *
1040 759 * @return array of errors
1041 760 */
1042 761 public static function validate( $values ) {
1043 762 $errors = array();
763 +
1044 764 return apply_filters( 'frm_validate_form', $errors, $values );
1045 765 }
1046 766
1047 - /**
1048 - * @param object|null $form
1049 - *
1050 - * @return array
1051 - */
1052 767 public static function get_params( $form = null ) {
1053 768 global $frm_vars;
1054 769
1055 770 if ( ! $form ) {
@@ -1079,18 +794,16 @@
1079 794 );
1080 795
1081 796 $values = array();
1082 797 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1083 -
1084 798 if ( ! $values['posted_form_id'] ) {
1085 799 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1086 800 }
1087 801
1088 - // phpcs:ignore Universal.Operators.StrictComparisons
1089 802 if ( $form->id == $values['posted_form_id'] ) {
1090 - // If there are two forms on the same page, make sure not to submit both.
803 + //if there are two forms on the same page, make sure not to submit both
1091 804 foreach ( $default_values as $var => $default ) {
1092 - if ( $var === 'action' ) {
805 + if ( $var == 'action' ) {
1093 806 $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1094 807 } else {
1095 808 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1096 809 }
@@ -1102,9 +815,9 @@
1102 815 unset( $var, $default );
1103 816 }
1104 817 }
1105 818
1106 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
819 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
1107 820 ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
1108 821 ) {
1109 822 $values['action'] = 'new';
1110 823 }
@@ -1111,11 +824,8 @@
1111 824
1112 825 return $values;
1113 826 }
1114 827
1115 - /**
1116 - * @return array
1117 - */
1118 828 public static function list_page_params() {
1119 829 $values = array();
1120 830 $defaults = array(
1121 831 'template' => 0,
@@ -1125,9 +835,8 @@
1125 835 'search' => '',
1126 836 'sort' => '',
1127 837 'sdir' => '',
1128 838 );
1129 -
1130 839 foreach ( $defaults as $var => $default ) {
1131 840 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1132 841 }
1133 842
@@ -1133,16 +842,10 @@
1133 842
1134 843 return $values;
1135 844 }
1136 845
1137 - /**
1138 - * @param int|object|string|null $form
1139 - *
1140 - * @return array
1141 - */
1142 846 public static function get_admin_params( $form = null ) {
1143 847 $form_id = $form;
1144 -
1145 848 if ( $form === null ) {
1146 849 $form_id = self::get_current_form_id();
1147 850 } elseif ( $form && is_object( $form ) ) {
1148 851 $form_id = $form->id;
@@ -1160,9 +863,8 @@
1160 863 'sdir' => '',
1161 864 'fid' => '',
1162 865 'keep_post' => '',
1163 866 );
1164 -
1165 867 foreach ( $defaults as $var => $default ) {
1166 868 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1167 869 }
1168 870
@@ -1168,55 +870,47 @@
1168 870
1169 871 return $values;
1170 872 }
1171 873
1172 - /**
1173 - * @param string $default_form
1174 - *
1175 - * @return int|string
1176 - */
1177 874 public static function get_current_form_id( $default_form = 'none' ) {
1178 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1179 - return $form ? $form->id : 0;
875 + if ( 'first' == $default_form ) {
876 + $form = self::get_current_form();
877 + } else {
878 + $form = self::maybe_get_current_form();
879 + }
880 + $form_id = $form ? $form->id : 0;
881 +
882 + return $form_id;
1180 883 }
1181 884
1182 - /**
1183 - * @param int|string $form_id
1184 - *
1185 - * @return false|int|object|string
1186 - */
1187 885 public static function maybe_get_current_form( $form_id = 0 ) {
1188 886 global $frm_vars;
1189 887
1190 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
888 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1191 889 return $frm_vars['current_form'];
1192 890 }
1193 891
1194 892 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
893 + if ( $form_id ) {
894 + $form_id = self::set_current_form( $form_id );
895 + }
1195 896
1196 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
897 + return $form_id;
1197 898 }
1198 899
1199 - /**
1200 - * @param int $form_id
1201 - *
1202 - * @return false|object
1203 - */
1204 900 public static function get_current_form( $form_id = 0 ) {
1205 901 $form = self::maybe_get_current_form( $form_id );
1206 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
902 + if ( is_numeric( $form ) ) {
903 + $form = self::set_current_form( $form );
904 + }
905 +
906 + return $form;
1207 907 }
1208 908
1209 - /**
1210 - * @param int $form_id
1211 - *
1212 - * @return false|object
1213 - */
1214 909 public static function set_current_form( $form_id ) {
1215 910 global $frm_vars;
1216 911
1217 912 $query = array();
1218 -
1219 913 if ( $form_id ) {
1220 914 $query['id'] = $form_id;
1221 915 }
1222 916
@@ -1224,19 +918,11 @@
1224 918
1225 919 return $frm_vars['current_form'];
1226 920 }
1227 921
1228 - /**
1229 - * @param object $form
1230 - * @param int|string $this_load
1231 - * @param bool $global_load
1232 - *
1233 - * @return bool
1234 - */
1235 922 public static function is_form_loaded( $form, $this_load, $global_load ) {
1236 923 global $frm_vars;
1237 924 $small_form = new stdClass();
1238 -
1239 925 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1240 926 $small_form->{$var} = $form->{$var};
1241 927 unset( $var );
1242 928 }
@@ -1242,14 +928,14 @@
1242 928 }
1243 929
1244 930 $frm_vars['forms_loaded'][] = $small_form;
1245 931
1246 - if ( $this_load && ! $global_load ) {
932 + if ( $this_load && empty( $global_load ) ) {
1247 933 $global_load = true;
1248 934 $frm_vars['load_css'] = true;
1249 935 }
1250 936
1251 - return empty( $frm_vars['css_loaded'] ) && $global_load;
937 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1252 938 }
1253 939
1254 940 /**
1255 941 * @since 4.06.03
@@ -1257,9 +943,9 @@
1257 943 * @param object $form
1258 944 *
1259 945 * @return bool
1260 946 */
1261 - public static function is_visible_to_user( $form ) {
947 + public static function &is_visible_to_user( $form ) {
1262 948 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1263 949 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1264 950 } else {
1265 951 $visible = true;
@@ -1264,39 +950,26 @@
1264 950 } else {
1265 951 $visible = true;
1266 952 }
1267 953
1268 - /**
1269 - * @since 6.25
1270 - *
1271 - * @param bool $visible
1272 - * @param object $form
1273 - */
1274 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
954 + return $visible;
1275 955 }
1276 956
1277 - /**
1278 - * @param object $form
1279 - *
1280 - * @return bool
1281 - */
1282 957 public static function show_submit( $form ) {
1283 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1284 - return apply_filters( 'frm_show_submit_button', $show, $form );
958 + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() );
959 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
960 +
961 + return $show;
1285 962 }
1286 963
1287 964 /**
1288 965 * @since 2.3
1289 - *
1290 - * @param array $atts Attributes including form, option, and default.
1291 - *
1292 - * @return mixed
1293 966 */
1294 967 public static function get_option( $atts ) {
1295 - $form = $atts['form'];
1296 - $default = $atts['default'] ?? '';
968 + $form = $atts['form'];
969 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1297 970
1298 - return $form->options[ $atts['option'] ] ?? $default;
971 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1299 972 }
1300 973
1301 974 /**
1302 975 * Get the link to edit this form.
@@ -1301,12 +974,9 @@
1301 974 /**
1302 975 * Get the link to edit this form.
1303 976 *
1304 977 * @since 4.0
1305 - *
1306 978 * @param int $form_id The id of the form.
1307 - *
1308 - * @return string
1309 979 */
1310 980 public static function get_edit_link( $form_id ) {
1311 981 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1312 982 }
@@ -1311,65 +981,9 @@
1311 981 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1312 982 }
1313 983
1314 984 /**
1315 - * Check if the "Submit this form with AJAX" setting is toggled on.
1316 - *
1317 - * @since 6.2
1318 - *
1319 - * @param stdClass $form
1320 - *
1321 - * @return bool
1322 - */
1323 - public static function is_ajax_on( $form ) {
1324 - return ! empty( $form->options['ajax_submit'] );
1325 - }
1326 -
1327 - /**
1328 - * Get the latest form available.
1329 - *
1330 - * @since 6.8
1331 - *
1332 - * @return object
1333 - */
1334 - public static function get_latest_form() {
1335 - $args = array(
1336 - array(
1337 - 'or' => 1,
1338 - 'parent_form_id' => null,
1339 - 'parent_form_id <' => 1,
1340 - ),
1341 - 'is_template' => 0,
1342 - 'status !' => 'trash',
1343 - );
1344 -
1345 - return self::getAll( $args, 'created_at desc', 1 );
1346 - }
1347 -
1348 - /**
1349 - * Count and return total forms.
1350 - *
1351 - * @since 6.8
1352 - *
1353 - * @return int
1354 - */
1355 - public static function get_forms_count() {
1356 - $args = array(
1357 - array(
1358 - 'or' => 1,
1359 - 'parent_form_id' => null,
1360 - 'parent_form_id <' => 1,
1361 - ),
1362 - 'is_template' => 0,
1363 - 'status !' => 'trash',
1364 - );
1365 -
1366 - return FrmDb::get_count( 'frm_forms', $args );
1367 - }
1368 -
1369 - /**
1370 - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1371 - *
985 + * @deprecated 3.0
1372 986 * @codeCoverageIgnore
1373 987 *
1374 988 * @param string $key
1375 989 *
@@ -1375,22 +989,15 @@
1375 989 *
1376 990 * @return int form id
1377 991 */
1378 992 public static function getIdByKey( $key ) {
1379 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
1380 - return self::get_id_by_key( $key );
993 + return FrmFormDeprecated::getIdByKey( $key );
1381 994 }
1382 995
1383 996 /**
1384 - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1385 - *
997 + * @deprecated 3.0
1386 998 * @codeCoverageIgnore
1387 - *
1388 - * @param int|string $id
1389 - *
1390 - * @return string
1391 999 */
1392 1000 public static function getKeyById( $id ) {
1393 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );
1394 - return self::get_key_by_id( $id );
1001 + return FrmFormDeprecated::getKeyById( $id );
1395 1002 }
1396 1003 }