PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.0
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.0
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmMigrate.php +57 -346 6.32.15.0 View file →
@@ -3,27 +3,11 @@
3 3 die( 'You are not allowed to call this page directly.' );
4 4 }
5 5
6 6 class FrmMigrate {
7 -
8 - /**
9 - * @var string
10 - */
11 7 public $fields;
12 -
13 - /**
14 - * @var string
15 - */
16 8 public $forms;
17 -
18 - /**
19 - * @var string
20 - */
21 9 public $entries;
22 -
23 - /**
24 - * @var string
25 - */
26 10 public $entry_metas;
27 11
28 12 public function __construct() {
29 13 global $wpdb;
@@ -32,11 +16,8 @@
32 16 $this->entries = $wpdb->prefix . 'frm_items';
33 17 $this->entry_metas = $wpdb->prefix . 'frm_item_metas';
34 18 }
35 19
36 - /**
37 - * @return void
38 - */
39 20 public function upgrade() {
40 21 do_action( 'frm_before_install' );
41 22
42 23 global $wpdb, $frm_vars;
@@ -51,34 +32,25 @@
51 32 )
52 33 );
53 34
54 35 if ( $needs_upgrade ) {
55 - $this->maybe_delete_htaccess_file();
56 -
57 - // Update rewrite rules for views and other custom post types
36 + // update rewrite rules for views and other custom post types
58 37 flush_rewrite_rules();
59 38
60 - require_once ABSPATH . 'wp-admin/includes/upgrade.php';
39 + require_once( ABSPATH . 'wp-admin/includes/upgrade.php' );
61 40
62 41 $old_db_version = get_option( 'frm_db_version' );
63 42
64 43 $this->create_tables();
65 44 $this->migrate_data( $old_db_version );
66 - $this->check_that_tables_exist();
67 45
68 - // SAVE DB VERSION.
46 + /***** SAVE DB VERSION *****/
69 47 update_option( 'frm_db_version', FrmAppHelper::plugin_version() . '-' . FrmAppHelper::$db_version );
70 48
71 49 if ( ! $old_db_version ) {
72 50 $this->maybe_create_contact_form();
73 -
74 - if ( false === get_option( 'frm_first_activation' ) ) {
75 - update_option( 'frm_first_activation', time(), false );
76 - }
77 -
78 - $this->update_settings_for_new_install();
79 51 }
80 - }//end if
52 + }
81 53
82 54 do_action( 'frm_after_install' );
83 55
84 56 $frm_vars['doing_upgrade'] = false;
@@ -84,97 +56,24 @@
84 56 $frm_vars['doing_upgrade'] = false;
85 57
86 58 FrmAppHelper::save_combined_js();
87 59
88 - // Update the styling settings
89 - if ( ! function_exists( 'get_filesystem_method' ) ) {
90 - return;
60 + // update the styling settings
61 + if ( function_exists( 'get_filesystem_method' ) ) {
62 + $frm_style = new FrmStyle();
63 + $frm_style->update( 'default' );
91 64 }
92 -
93 - $frm_style = new FrmStyle();
94 - $frm_style->update( 'default' );
95 65 }
96 66
97 - /**
98 - * Check if the .htaccess file should be deleted based on server response.
99 - * If a server has AllowOverride FileInfo but not AllowOverride AuthConfig, JS and CSS files
100 - * will result in a 500 error.
101 - *
102 - * @since 6.27
103 - *
104 - * @return void
105 - */
106 - private function maybe_delete_htaccess_file() {
107 - $css_file_request = wp_remote_get( FrmAppHelper::plugin_url() . '/css/frm_fonts.css' );
108 -
109 - if ( 200 === wp_remote_retrieve_response_code( $css_file_request ) ) {
110 - return;
111 - }
112 -
113 - $htaccess_path = FrmAppHelper::plugin_path() . '/.htaccess';
114 -
115 - if ( file_exists( $htaccess_path ) ) {
116 - wp_delete_file( $htaccess_path );
117 - }
118 - }
119 -
120 - /**
121 - * Updates some settings for new installs.
122 - *
123 - * @since 6.23
124 - *
125 - * @return void
126 - */
127 - private function update_settings_for_new_install() {
128 - $settings = FrmAppHelper::get_settings();
129 -
130 - $settings->denylist_check = 1;
131 - $settings->installed_after_welcome_tour_update = 1;
132 - $settings->store();
133 - }
134 -
135 - /**
136 - * If we fail to create the database tables, add an inbox notice.
137 - * This informs the user that they need to correct the issue and try again.
138 - *
139 - * @since 6.19
140 - *
141 - * @return void
142 - */
143 - private function check_that_tables_exist() {
144 - // Check the DB that the table $this->forms exists.
67 + public function collation() {
145 68 global $wpdb;
146 - $exists = $wpdb->get_results( $wpdb->prepare( 'SHOW TABLES LIKE %s', $this->forms ) );
147 -
148 - if ( $exists ) {
149 - $inbox = new FrmInbox();
150 - $inbox->dismiss( 'failed-to-create-tables' );
151 - return;
69 + if ( ! $wpdb->has_cap( 'collation' ) ) {
70 + return '';
152 71 }
153 72
154 - $message = array(
155 - 'key' => 'failed-to-create-tables',
156 - 'subject' => 'Something went wrong setting up the database',
157 - 'message' => 'For steps to continue, see our <a href="https://formidableforms.com/knowledgebase/install-formidable-forms/#kb-missing-database-tables">documentation</a>. If you need assistance, we recommend that you reach out to your hosting provider. Then <a href="' . esc_url( admin_url( 'admin.php?page=formidable&frm_add_tables=1' ) ) . '">click here</a> to try again.', // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
158 - 'cta' => '<a href="https://formidableforms.com/knowledgebase/install-formidable-forms/#kb-missing-database-tables">Learn More</a>',
159 - 'type' => 'error',
160 - );
161 -
162 - $inbox = new FrmInbox();
163 - $inbox->add_message( $message );
73 + return $wpdb->get_charset_collate();
164 74 }
165 75
166 - /**
167 - * @return string
168 - */
169 - public function collation() {
170 - global $wpdb;
171 - return $wpdb->has_cap( 'collation' ) ? $wpdb->get_charset_collate() : '';
172 - }
173 -
174 - /**
175 - * @return void
176 - */
177 76 private function create_tables() {
178 77 $charset_collate = $this->collation();
179 78 $sql = array();
180 79
@@ -254,88 +153,16 @@
254 153 if ( function_exists( 'dbDelta' ) ) {
255 154 dbDelta( $q . $charset_collate . ';' );
256 155 } else {
257 156 global $wpdb;
258 - $wpdb->query( $q . $charset_collate ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
157 + $wpdb->query( $q . $charset_collate ); // WPCS: unprepared SQL ok.
259 158 }
260 159 unset( $q );
261 160 }
262 -
263 - $this->add_composite_indexes_for_entries();
264 161 }
265 162
266 - /**
267 - * These indexes help optimize database queries for entries.
268 - *
269 - * @since 6.6
270 - * @since 6.16.3 idx_form_id_is_draft was also added to frm_items.
271 - * @since 6.17 idx_form_id_type was also added to frm_fields.
272 - *
273 - * @return void
274 - */
275 - private function add_composite_indexes_for_entries() {
276 - global $wpdb;
277 -
278 - $table_name = "{$wpdb->prefix}frm_items";
279 - $index_name = 'idx_is_draft_created_at';
280 -
281 - if ( ! self::index_exists( $table_name, $index_name ) ) {
282 - $wpdb->query( "CREATE INDEX idx_is_draft_created_at ON `{$wpdb->prefix}frm_items` (is_draft, created_at)" );
283 - }
284 -
285 - $table_name = "{$wpdb->prefix}frm_item_metas";
286 - $index_name = 'idx_field_id_item_id';
287 -
288 - if ( ! self::index_exists( $table_name, $index_name ) ) {
289 - $wpdb->query( "CREATE INDEX idx_field_id_item_id ON `{$wpdb->prefix}frm_item_metas` (field_id, item_id)" );
290 - }
291 -
292 - $table_name = "{$wpdb->prefix}frm_items";
293 - $index_name = 'idx_form_id_is_draft';
294 -
295 - if ( ! self::index_exists( $table_name, $index_name ) ) {
296 - $wpdb->query( "CREATE INDEX idx_form_id_is_draft ON `{$wpdb->prefix}frm_items` (form_id, is_draft)" );
297 - }
298 -
299 - $table_name = "{$wpdb->prefix}frm_fields";
300 - $index_name = 'idx_form_id_type';
301 -
302 - if ( ! self::index_exists( $table_name, $index_name ) ) {
303 - $wpdb->query( "CREATE INDEX idx_form_id_type ON `{$wpdb->prefix}frm_fields` (form_id, type(30))" );
304 - }
305 - }
306 -
307 - /**
308 - * Check that an index exists in a database table before trying to add it (which results in an error).
309 - *
310 - * @since 6.6
311 - *
312 - * @param string $table_name
313 - * @param string $index_name
314 - *
315 - * @return bool
316 - */
317 - private static function index_exists( $table_name, $index_name ) {
318 - global $wpdb;
319 - $row = $wpdb->get_row(
320 - $wpdb->prepare(
321 - 'SELECT 1 FROM information_schema.statistics
322 - WHERE table_schema = database()
323 - AND table_name = %s
324 - AND index_name = %s
325 - LIMIT 1',
326 - array( $table_name, $index_name )
327 - )
328 - );
329 - return (bool) $row;
330 - }
331 -
332 - /**
333 - * @return void
334 - */
335 163 private function maybe_create_contact_form() {
336 164 $form_exists = FrmForm::get_id_by_key( 'contact-form' );
337 -
338 165 if ( ! $form_exists ) {
339 166 $this->add_default_template();
340 167 }
341 168 }
@@ -343,10 +170,8 @@
343 170 /**
344 171 * Create the default contact form
345 172 *
346 173 * @since 3.06
347 - *
348 - * @return void
349 174 */
350 175 private function add_default_template() {
351 176 if ( FrmXMLHelper::check_if_libxml_disable_entity_loader_exists() ) {
352 177 // XML import is not enabled on your server.
@@ -354,9 +179,10 @@
354 179 }
355 180
356 181 $set_err = libxml_use_internal_errors( true );
357 182 $loader = FrmXMLHelper::maybe_libxml_disable_entity_loader( true );
358 - $file = FrmAppHelper::plugin_path() . '/classes/views/xml/default-templates.xml';
183 +
184 + $file = FrmAppHelper::plugin_path() . '/classes/views/xml/default-templates.xml';
359 185 FrmXMLHelper::import_xml( $file );
360 186
361 187 libxml_use_internal_errors( $set_err );
362 188 FrmXMLHelper::maybe_libxml_disable_entity_loader( $loader );
@@ -363,41 +189,32 @@
363 189 }
364 190
365 191 /**
366 192 * @param int|string $old_db_version
367 - *
368 - * @return void
369 193 */
370 194 private function migrate_data( $old_db_version ) {
371 195 if ( ! $old_db_version ) {
372 196 $old_db_version = get_option( 'frm_db_version' );
373 197 }
374 -
375 - if ( str_contains( $old_db_version, '-' ) ) {
198 + if ( strpos( $old_db_version, '-' ) ) {
376 199 $last_upgrade = explode( '-', $old_db_version );
377 - $old_db_version = intval( end( $last_upgrade ) );
200 + $old_db_version = (int) $last_upgrade[1];
378 201 }
379 202
380 203 if ( ! is_numeric( $old_db_version ) ) {
381 - // Bail if we don't know the previous version
204 + // bail if we don't know the previous version
382 205 return;
383 206 }
384 207
385 - $migrations = array( 16, 11, 16, 17, 23, 25, 86, 90, 97, 98, 101, 104, 105 );
386 -
208 + $migrations = array( 16, 11, 16, 17, 23, 25, 86, 90, 97, 98 );
387 209 foreach ( $migrations as $migration ) {
388 - if ( FrmAppHelper::$db_version < $migration || $old_db_version >= $migration ) {
389 - continue;
210 + if ( FrmAppHelper::$db_version >= $migration && $old_db_version < $migration ) {
211 + $function_name = 'migrate_to_' . $migration;
212 + $this->$function_name();
390 213 }
391 -
392 - $function_name = 'migrate_to_' . $migration;
393 - $this->$function_name();
394 214 }
395 215 }
396 216
397 - /**
398 - * @return bool
399 - */
400 217 public function uninstall() {
401 218 if ( ! current_user_can( 'administrator' ) ) {
402 219 $frm_settings = FrmAppHelper::get_settings();
403 220 wp_die( esc_html( $frm_settings->admin_permission ) );
@@ -404,12 +221,12 @@
404 221 }
405 222
406 223 global $wpdb, $wp_roles;
407 224
408 - $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->fields ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
409 - $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->forms ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
410 - $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->entries ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
411 - $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->entry_metas ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
225 + $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->fields ); // WPCS: unprepared SQL ok.
226 + $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->forms ); // WPCS: unprepared SQL ok.
227 + $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->entries ); // WPCS: unprepared SQL ok.
228 + $wpdb->query( 'DROP TABLE IF EXISTS ' . $this->entry_metas ); // WPCS: unprepared SQL ok.
412 229
413 230 delete_option( 'frm_options' );
414 231 delete_option( 'frm_db_version' );
415 232 delete_option( 'frm_install_running' );
@@ -416,15 +233,13 @@
416 233 delete_option( 'frm_lite_settings_upgrade' );
417 234 delete_option( 'frm-usage-uuid' );
418 235 delete_option( 'frm_inbox' );
419 236 delete_option( 'frmpro_css' );
420 - delete_option( FrmOnboardingWizardController::REDIRECT_STATUS_OPTION );
421 - delete_option( FrmEmailSummaryHelper::$option_name );
237 + delete_option( 'frm_welcome_redirect' );
422 238
423 239 // Delete roles.
424 240 $frm_roles = FrmAppHelper::frm_capabilities();
425 241 $roles = get_editable_roles();
426 -
427 242 foreach ( $frm_roles as $frm_role => $frm_role_description ) {
428 243 foreach ( $roles as $role => $details ) {
429 244 $wp_roles->remove_cap( $role, $frm_role );
430 245 unset( $role, $details );
@@ -432,16 +247,15 @@
432 247 unset( $frm_role, $frm_role_description );
433 248 }
434 249 unset( $roles, $frm_roles );
435 250
436 - // Delete actions, views, and styles
251 + // delete actions, views, and styles
437 252
438 - // Prevent the post deletion from triggering entries to be deleted
253 + // prevent the post deletion from triggering entries to be deleted
439 254 remove_action( 'before_delete_post', 'FrmProDisplaysController::before_delete_post' );
440 255 remove_action( 'deleted_post', 'FrmProEntriesController::delete_entry' );
441 256
442 - $post_ids = $wpdb->get_col( $wpdb->prepare( 'SELECT ID FROM ' . $wpdb->posts . ' WHERE post_type in (%s, %s, %s)', FrmFormActionsController::$action_post_type, FrmStylesController::$post_type, 'frm_display' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
443 -
257 + $post_ids = $wpdb->get_col( $wpdb->prepare( 'SELECT ID FROM ' . $wpdb->posts . ' WHERE post_type in (%s, %s, %s)', FrmFormActionsController::$action_post_type, FrmStylesController::$post_type, 'frm_display' ) );
444 258 foreach ( $post_ids as $post_id ) {
445 259 // Delete's each post.
446 260 wp_delete_post( $post_id, true );
447 261 }
@@ -446,15 +260,15 @@
446 260 wp_delete_post( $post_id, true );
447 261 }
448 262 unset( $post_ids );
449 263
450 - // Delete transients
264 + // delete transients
451 265 delete_transient( 'frmpro_css' );
452 266 delete_transient( 'frm_options' );
453 267 delete_transient( 'frmpro_options' );
454 - delete_transient( FrmOnboardingWizardController::TRANSIENT_NAME );
268 + delete_transient( 'frm_activation_redirect' );
455 269
456 - $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->options . ' WHERE option_name LIKE %s OR option_name LIKE %s', '_transient_timeout_frm_form_fields_%', '_transient_frm_form_fields_%' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
270 + $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->options . ' WHERE option_name LIKE %s OR option_name LIKE %s', '_transient_timeout_frm_form_fields_%', '_transient_frm_form_fields_%' ) );
457 271
458 272 do_action( 'frm_after_uninstall' );
459 273
460 274 return true;
@@ -460,67 +274,11 @@
460 274 return true;
461 275 }
462 276
463 277 /**
464 - * In older versions of Lite, it's possible we've saved the wrong location ID.
465 - * So force it to get valid values again.
466 - *
467 - * @since 6.25
468 - *
469 - * @return void
470 - */
471 - private function migrate_to_104() {
472 - if ( FrmSquareLiteConnectHelper::get_merchant_id( 'test' ) ) {
473 - FrmSquareLiteConnectHelper::get_location_id( true, 'test' );
474 - }
475 -
476 - if ( FrmSquareLiteConnectHelper::get_merchant_id( 'live' ) ) {
477 - FrmSquareLiteConnectHelper::get_location_id( true, 'live' );
478 - }
479 - }
480 -
481 - /**
482 - * Add new wp_options row for custom setting.
483 - *
484 - * @since 6.26
485 - *
486 - * @return void
487 - */
488 - private function migrate_to_105() {
489 - if ( ! FrmAppHelper::pro_is_installed() ) {
490 - update_option( 'frm_show_pricing_fields_modal', 1, false );
491 - }
492 - }
493 -
494 - /**
495 - * Disables summary email for multisite (not the main site) if recipient setting isn't changed.
496 - *
497 - * @since 6.8
498 - *
499 - * @return void
500 - */
501 - private function migrate_to_101() {
502 - if ( ! is_multisite() || get_main_site_id() === get_current_blog_id() ) {
503 - return;
504 - }
505 -
506 - $frm_settings = FrmAppHelper::get_settings();
507 -
508 - if ( empty( $frm_settings->summary_emails ) || '[admin_email]' !== $frm_settings->summary_emails_recipients ) {
509 - // User changed it.
510 - return;
511 - }
512 -
513 - $frm_settings->summary_emails = 0;
514 - $frm_settings->store();
515 - }
516 -
517 - /**
518 278 * Clear frmpro_css transient.
519 279 *
520 280 * @since 4.10.02
521 - *
522 - * @return void
523 281 */
524 282 private function migrate_to_98() {
525 283 delete_transient( 'frmpro_css' );
526 284 }
@@ -528,10 +286,8 @@
528 286 /**
529 287 * Move default_blank and clear_on_focus to placeholder.
530 288 *
531 289 * @since 4.0
532 - *
533 - * @return void
534 290 */
535 291 private function migrate_to_97() {
536 292 $this->migrate_to_placeholder( 'clear_on_focus' );
537 293 $this->migrate_to_placeholder( 'default_blank' );
@@ -540,12 +296,8 @@
540 296 /**
541 297 * Move clear_on_focus or default_blank to placeholder.
542 298 *
543 299 * @since 4.0
544 - *
545 - * @param string $type Field option key to migrate.
546 - *
547 - * @return void
548 300 */
549 301 private function migrate_to_placeholder( $type = 'clear_on_focus' ) {
550 302 $query = array(
551 303 'field_options like' => '"' . $type . '";s:1:"1";',
@@ -556,10 +308,9 @@
556 308 foreach ( $fields as $field ) {
557 309 FrmAppHelper::unserialize_or_decode( $field->field_options );
558 310 FrmAppHelper::unserialize_or_decode( $field->options );
559 311 $update_values = FrmXMLHelper::migrate_field_placeholder( $field, $type );
560 -
561 - if ( ! $update_values ) {
312 + if ( empty( $update_values ) ) {
562 313 continue;
563 314 }
564 315
565 316 FrmField::update( $field->id, $update_values );
@@ -567,18 +318,14 @@
567 318 }
568 319 }
569 320
570 321 /**
571 - * Delete unneeded default templates
322 + * Delete uneeded default templates
572 323 *
573 324 * @since 3.06
574 - *
575 - * @return void
576 325 */
577 326 private function migrate_to_90() {
578 327 $form = FrmForm::getOne( 'contact' );
579 -
580 - // phpcs:ignore Universal.Operators.StrictComparisons
581 328 if ( $form && $form->default_template == 1 ) {
582 329 FrmForm::destroy( 'contact' );
583 330 }
584 331 }
@@ -586,17 +333,16 @@
586 333 /**
587 334 * Reverse migration 17 -- Divide by 9
588 335 *
589 336 * @since 3.0.05
590 - *
591 - * @return void
592 337 */
593 338 private function migrate_to_86() {
339 +
594 340 $fields = $this->get_fields_with_size();
595 341
596 - foreach ( $fields as $f ) {
342 + foreach ( (array) $fields as $f ) {
597 343 FrmAppHelper::unserialize_or_decode( $f->field_options );
598 - $size = $f->field_options['size'];
344 + $size = $f->field_options['size'];
599 345 $this->maybe_convert_migrated_size( $size );
600 346
601 347 if ( $size === $f->field_options['size'] ) {
602 348 continue;
@@ -606,12 +352,11 @@
606 352 FrmField::update( $f->id, array( 'field_options' => $f->field_options ) );
607 353 unset( $f );
608 354 }
609 355
610 - // Reverse the extra size changes in widgets
356 + // reverse the extra size changes in widgets
611 357 $widgets = get_option( 'widget_frm_show_form' );
612 -
613 - if ( ! $widgets ) {
358 + if ( empty( $widgets ) ) {
614 359 return;
615 360 }
616 361
617 362 $this->revert_widget_field_size();
@@ -616,11 +361,8 @@
616 361
617 362 $this->revert_widget_field_size();
618 363 }
619 364
620 - /**
621 - * @return array
622 - */
623 365 private function get_fields_with_size() {
624 366 $field_types = array(
625 367 'textarea',
626 368 'text',
@@ -648,20 +390,16 @@
648 390 /**
649 391 * Reverse the extra size changes in widgets
650 392 *
651 393 * @since 3.0.05
652 - *
653 - * @return void
654 394 */
655 395 private function revert_widget_field_size() {
656 396 $widgets = get_option( 'widget_frm_show_form' );
657 -
658 - if ( ! $widgets ) {
397 + if ( empty( $widgets ) ) {
659 398 return;
660 399 }
661 400
662 401 FrmAppHelper::unserialize_or_decode( $widgets );
663 -
664 402 foreach ( $widgets as $k => $widget ) {
665 403 if ( ! is_array( $widget ) || ! isset( $widget['size'] ) ) {
666 404 continue;
667 405 }
@@ -667,9 +405,8 @@
667 405 }
668 406
669 407 $this->maybe_convert_migrated_size( $widgets[ $k ]['size'] );
670 408 }
671 -
672 409 update_option( 'widget_frm_show_form', $widgets );
673 410 }
674 411
675 412 /**
@@ -675,28 +412,23 @@
675 412 /**
676 413 * Divide by 9 to reverse the multiplication
677 414 *
678 415 * @since 3.0.05
679 - *
680 - * @param string $size Size string to maybe convert, passed by reference.
681 - *
682 - * @return void
683 416 */
684 417 private function maybe_convert_migrated_size( &$size ) {
685 - $has_px_size = $size && str_contains( $size, 'px' );
686 -
418 + $has_px_size = ! empty( $size ) && strpos( $size, 'px' );
687 419 if ( ! $has_px_size ) {
688 420 return;
689 421 }
690 422
691 423 $int_size = str_replace( 'px', '', $size );
692 -
693 424 if ( ! is_numeric( $int_size ) || (int) $int_size < 900 ) {
694 425 return;
695 426 }
696 427
697 428 $pixel_conversion = 9;
698 - $size = round( (int) $int_size / $pixel_conversion );
429 +
430 + $size = round( (int) $int_size / $pixel_conversion );
699 431 }
700 432
701 433 /**
702 434 * Migrate old styling settings. If sites are using the old
@@ -702,22 +434,19 @@
702 434 * Migrate old styling settings. If sites are using the old
703 435 * default 400px field width, switch it to 100%
704 436 *
705 437 * @since 2.0.4
706 - *
707 - * @return void
708 438 */
709 439 private function migrate_to_25() {
710 - // Get the style that was created with the style migration
440 + // get the style that was created with the style migration
711 441 $frm_style = new FrmStyle();
712 442 $styles = $frm_style->get_all( 'post_date', 'ASC', 1 );
713 -
714 - if ( ! $styles ) {
443 + if ( empty( $styles ) ) {
715 444 return;
716 445 }
717 446
718 447 foreach ( $styles as $style ) {
719 - if ( $style->post_content['field_width'] === '400px' ) {
448 + if ( $style->post_content['field_width'] == '400px' ) {
720 449 $style->post_content['field_width'] = '100%';
721 450 $frm_style->save( (array) $style );
722 451
723 452 return;
@@ -729,24 +458,19 @@
729 458 * Check if the parent_form_id columns exists.
730 459 * If not, try and add it again
731 460 *
732 461 * @since 2.0.2
733 - *
734 - * @return void
735 462 */
736 463 private function migrate_to_23() {
737 464 global $wpdb;
738 - $exists = $wpdb->get_row( 'SHOW COLUMNS FROM ' . $this->forms . ' LIKE "parent_form_id"' ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
739 -
740 - if ( ! $exists ) {
741 - $wpdb->query( 'ALTER TABLE ' . $this->forms . ' ADD parent_form_id int(11) default 0' ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
465 + $exists = $wpdb->get_row( 'SHOW COLUMNS FROM ' . $this->forms . ' LIKE "parent_form_id"' ); // WPCS: unprepared SQL ok.
466 + if ( empty( $exists ) ) {
467 + $wpdb->query( 'ALTER TABLE ' . $this->forms . ' ADD parent_form_id int(11) default 0' ); // WPCS: unprepared SQL ok.
742 468 }
743 469 }
744 470
745 471 /**
746 472 * Change field size from character to pixel -- Multiply by 9
747 - *
748 - * @return void
749 473 */
750 474 private function migrate_to_17() {
751 475 $fields = $this->get_fields_with_size();
752 476
@@ -751,9 +475,8 @@
751 475 $fields = $this->get_fields_with_size();
752 476
753 477 foreach ( $fields as $f ) {
754 478 FrmAppHelper::unserialize_or_decode( $f->field_options );
755 -
756 479 if ( empty( $f->field_options['size'] ) || ! is_numeric( $f->field_options['size'] ) ) {
757 480 continue;
758 481 }
759 482
@@ -767,20 +490,16 @@
767 490 }
768 491
769 492 /**
770 493 * Change the characters in widgets to pixels
771 - *
772 - * @return void
773 494 */
774 495 private function adjust_widget_size() {
775 496 $widgets = get_option( 'widget_frm_show_form' );
776 -
777 - if ( ! $widgets ) {
497 + if ( empty( $widgets ) ) {
778 498 return;
779 499 }
780 500
781 501 FrmAppHelper::unserialize_or_decode( $widgets );
782 -
783 502 foreach ( $widgets as $k => $widget ) {
784 503 if ( ! is_array( $widget ) || ! isset( $widget['size'] ) ) {
785 504 continue;
786 505 }
@@ -785,21 +504,15 @@
785 504 continue;
786 505 }
787 506 $this->convert_character_to_px( $widgets[ $k ]['size'] );
788 507 }
789 -
790 508 update_option( 'widget_frm_show_form', $widgets );
791 509 }
792 510
793 - /**
794 - * @param string $size
795 - *
796 - * @return void
797 - */
798 511 private function convert_character_to_px( &$size ) {
799 512 $pixel_conversion = 9;
800 513
801 - $size = round( $pixel_conversion * (int) $size );
514 + $size = round( $pixel_conversion * (int) $size );
802 515 $size .= 'px';
803 516 }
804 517
805 518 /**
@@ -838,9 +551,9 @@
838 551 * post_excerpt: message
839 552 */
840 553 foreach ( $forms as $form ) {
841 554 if ( $form->is_template && $form->default_template ) {
842 - // Don't migrate the default templates since the email will be added anyway
555 + // don't migrate the default templates since the email will be added anyway
843 556 continue;
844 557 }
845 558
846 559 // Format form options
@@ -854,9 +567,10 @@
854 567
855 568 private function migrate_to_11() {
856 569 global $wpdb;
857 570
858 - $forms = FrmDb::get_results( $this->forms, array(), 'id, options' );
571 + $forms = FrmDb::get_results( $this->forms, array(), 'id, options' );
572 +
859 573 $sending = __( 'Sending', 'formidable' );
860 574 $img = FrmAppHelper::plugin_url() . '/images/ajax_loader.gif';
861 575 $old_default_html = <<<DEFAULT_HTML
862 576 <div class="frm_submit">
@@ -868,21 +582,18 @@
868 582 unset( $sending, $img );
869 583
870 584 $new_default_html = FrmFormsHelper::get_default_html( 'submit' );
871 585 $draft_link = FrmFormsHelper::get_draft_link();
872 -
873 586 foreach ( $forms as $form ) {
874 587 FrmAppHelper::unserialize_or_decode( $form->options );
875 -
876 - if ( empty( $form->options['submit_html'] ) ) {
588 + if ( ! isset( $form->options['submit_html'] ) || empty( $form->options['submit_html'] ) ) {
877 589 continue;
878 590 }
879 591
880 - // phpcs:ignore Universal.Operators.StrictComparisons
881 592 if ( $form->options['submit_html'] != $new_default_html && $form->options['submit_html'] == $old_default_html ) {
882 593 $form->options['submit_html'] = $new_default_html;
883 594 $wpdb->update( $this->forms, array( 'options' => serialize( $form->options ) ), array( 'id' => $form->id ) );
884 - } elseif ( ! str_contains( $form->options['submit_html'], 'save_draft' ) ) {
595 + } elseif ( ! strpos( $form->options['submit_html'], 'save_draft' ) ) {
885 596 $form->options['submit_html'] = preg_replace( '~\<\/div\>(?!.*\<\/div\>)~', $draft_link . "\r\n</div>", $form->options['submit_html'] );
886 597 $wpdb->update( $this->forms, array( 'options' => serialize( $form->options ) ), array( 'id' => $form->id ) );
887 598 }
888 599 unset( $form );