PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.0
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.0
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +185 -599 6.35 → 5.0 View file →
@@ -5,49 +5,38 @@
5 5
6 6 class FrmForm {
7 7
8 8 /**
9 - * @param array $values
10 - *
11 - * @return bool|int id on success or false on failure.
9 + * @return int|boolean id on success or false on failure
12 10 */
13 11 public static function create( $values ) {
14 12 global $wpdb;
15 13
16 - $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
17 -
18 14 $new_values = array(
19 15 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ),
16 + 'name' => $values['name'],
21 17 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
18 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
19 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 20 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 21 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 22 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
23 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 24 );
29 25
30 26 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 27 FrmFormsHelper::fill_form_options( $options, $values );
32 28
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
29 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
30 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
31 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 32
37 - /**
38 - * Allows modifying form options before updating or creating.
39 - *
40 - * @since 5.4 Add the third param.
41 - *
42 - * @param array $options Form options.
43 - * @param array $values Form data.
44 - * @param bool $update Is form updating or creating. It's `true` if is updating.
45 - */
46 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, false );
47 - $options = self::maybe_filter_form_options( $options );
33 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
48 34 $new_values['options'] = serialize( $options );
49 35
36 + //if(isset($values['id']) && is_numeric($values['id']))
37 + // $new_values['id'] = $values['id'];
38 +
50 39 $wpdb->insert( $wpdb->prefix . 'frm_forms', $new_values );
51 40
52 41 $id = $wpdb->insert_id;
53 42
@@ -57,36 +46,14 @@
57 46 return $id;
58 47 }
59 48
60 49 /**
61 - * @since 5.0.08
62 - *
63 - * @param array $options
64 - *
65 - * @return array
50 + * @return int|boolean ID on success or false on failure
66 51 */
67 - private static function maybe_filter_form_options( $options ) {
68 - if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
69 - $options['submit_html'] = FrmAppHelper::kses_submit_button( $options['submit_html'] );
70 - }
71 - return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 - }
73 -
74 - /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 - * @return bool|int ID on success or false on failure
83 - */
84 52 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 53 global $wpdb;
86 54
87 55 $values = self::getOne( $id, $blog_id );
88 -
89 56 if ( ! $values ) {
90 57 return false;
91 58 }
92 59
@@ -103,10 +70,10 @@
103 70 'is_template' => $template ? 1 : 0,
104 71 );
105 72
106 73 if ( $blog_id ) {
107 - $new_values['status'] = 'published';
108 - $new_options = $values->options;
74 + $new_values['status'] = 'published';
75 + $new_options = $values->options;
109 76 FrmAppHelper::unserialize_or_decode( $new_options );
110 77 $new_options['email_to'] = get_option( 'admin_email' );
111 78 $new_options['copy'] = false;
112 79 $new_values['options'] = $new_options;
@@ -126,9 +93,9 @@
126 93
127 94 $form_id = $wpdb->insert_id;
128 95 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 96
130 - // Update form settings after fields are created
97 + // update form settings after fields are created
131 98 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 99
133 100 return $form_id;
134 101 }
@@ -135,16 +102,10 @@
135 102
136 103 return false;
137 104 }
138 105
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 106 public static function after_duplicate( $form_id, $values ) {
146 - $new_opts = $values['options'];
107 + $new_opts = $values['options'];
147 108 FrmAppHelper::unserialize_or_decode( $new_opts );
148 109 $values['options'] = $new_opts;
149 110
150 111 if ( isset( $new_opts['success_msg'] ) ) {
@@ -152,112 +113,20 @@
152 113 }
153 114
154 115 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 116
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 117 if ( $new_opts != $values['options'] ) {
158 118 global $wpdb;
159 119 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 120 }
161 -
162 - self::switch_field_ids_in_fields( $form_id );
163 121 }
164 122
165 123 /**
166 - * Switches field ID in fields.
167 - *
168 - * @since 5.3
169 - * @since 6.35 The description column is checked too, so a field id in a description survives a
170 - * duplicate or import when the field it points at is created afterwards.
171 - *
172 - * @param int $form_id Form ID.
173 - *
174 - * @return void
124 + * @return int|boolean
175 125 */
176 - private static function switch_field_ids_in_fields( $form_id ) {
177 - global $wpdb;
178 -
179 - // Keys of fields that you want to check to replace field ID.
180 - $keys = array( 'default_value', 'description', 'field_options' );
181 - $sql_cols = 'fi.id';
182 -
183 - foreach ( $keys as $key ) {
184 - $sql_cols .= ',fi.' . $key;
185 - }
186 -
187 - $fields = FrmDb::get_results(
188 - "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id",
189 - array(
190 - 'or' => 1,
191 - 'fi.form_id' => $form_id,
192 - 'fr.parent_form_id' => $form_id,
193 - ),
194 - $sql_cols
195 - );
196 -
197 - if ( ! $fields || ! is_array( $fields ) ) {
198 - return;
199 - }
200 -
201 - foreach ( $fields as $field ) {
202 - self::switch_field_ids_in_field( (array) $field );
203 - }
204 - }
205 -
206 - /**
207 - * Switches field ID in a field.
208 - *
209 - * @since 5.3
210 - *
211 - * @param array $field Field array.
212 - *
213 - * @return void
214 - */
215 - private static function switch_field_ids_in_field( $field ) {
216 - $new_values = array();
217 -
218 - foreach ( $field as $key => $value ) {
219 - if ( 'id' === $key || ! $value ) {
220 - continue;
221 - }
222 -
223 - if ( ! is_string( $value ) && ! is_array( $value ) ) {
224 - continue;
225 - }
226 -
227 - if ( 'field_options' === $key ) {
228 - // Need to loop through field_options to prevent breaking serialized string when length changed.
229 - FrmAppHelper::unserialize_or_decode( $value );
230 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
231 - $new_val = serialize( $new_val );
232 - } else {
233 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
234 - }
235 -
236 - if ( $new_val !== $value ) {
237 - $new_values[ $key ] = $new_val;
238 - }
239 - }//end foreach
240 -
241 - if ( $new_values ) {
242 - FrmField::update( $field['id'], $new_values );
243 - }
244 - }
245 -
246 - /**
247 - * Update a form.
248 - *
249 - * @param int $id Form ID.
250 - * @param array $values Form values to update.
251 - * @param bool $create_link Whether this is being called from link creation.
252 - *
253 - * @return bool|int
254 - */
255 126 public static function update( $id, $values, $create_link = false ) {
256 127 global $wpdb;
257 128
258 - $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
259 -
260 129 if ( ! isset( $values['status'] ) && ( $create_link || isset( $values['options'] ) || isset( $values['item_meta'] ) || isset( $values['field_options'] ) ) ) {
261 130 $values['status'] = 'published';
262 131 }
263 132
@@ -265,23 +134,23 @@
265 134 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
266 135 }
267 136
268 137 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
269 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
270 138
139 + $new_values = self::set_update_options( array(), $values );
140 +
271 141 foreach ( $values as $value_key => $value ) {
272 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
273 - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value;
142 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
143 + $new_values[ $value_key ] = $value;
274 144 }
275 145 }
276 146
277 - if ( ! empty( $values['new_status'] ) ) {
147 + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) {
278 148 $new_values['status'] = $values['new_status'];
279 149 }
280 150
281 - if ( $new_values ) {
151 + if ( ! empty( $new_values ) ) {
282 152 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
283 -
284 153 if ( $query_results ) {
285 154 self::clear_form_cache();
286 155 }
287 156 } else {
@@ -297,38 +166,24 @@
297 166 return $query_results;
298 167 }
299 168
300 169 /**
301 - * @param array $new_values
302 - * @param array $values
303 - * @param array $args
304 - *
305 170 * @return array
306 171 */
307 - public static function set_update_options( $new_values, $values, $args = array() ) {
172 + public static function set_update_options( $new_values, $values ) {
308 173 if ( ! isset( $values['options'] ) ) {
309 174 return $new_values;
310 175 }
311 176
312 - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
177 + $options = isset( $values['options'] ) ? (array) $values['options'] : array();
313 178 FrmFormsHelper::fill_form_options( $options, $values );
314 179
315 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
316 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
317 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
318 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
180 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
181 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
182 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
183 + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
319 184
320 - /**
321 - * Allows modifying form options before updating or creating.
322 - *
323 - * @since 5.4 Added the third param.
324 - *
325 - * @param array $options Form options.
326 - * @param array $values Form data.
327 - * @param bool $update Is form updating or creating. It's `true` if is updating.
328 - */
329 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, true );
330 - $options = self::maybe_filter_form_options( $options );
185 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
331 186 $new_values['options'] = serialize( $options );
332 187
333 188 return $new_values;
334 189 }
@@ -333,14 +188,11 @@
333 188 return $new_values;
334 189 }
335 190
336 191 /**
337 - * @param int $id Form ID.
338 - * @param array $values Form values array.
339 - *
340 192 * @return array
341 193 */
342 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
194 + public static function update_fields( $id, $values ) {
343 195
344 196 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
345 197 return $values;
346 198 }
@@ -345,10 +197,9 @@
345 197 return $values;
346 198 }
347 199
348 200 $all_fields = FrmField::get_all_for_form( $id );
349 -
350 - if ( ! $all_fields ) {
201 + if ( empty( $all_fields ) ) {
351 202 return $values;
352 203 }
353 204
354 205 if ( ! isset( $values['item_meta'] ) ) {
@@ -356,28 +207,28 @@
356 207 }
357 208
358 209 $field_array = array();
359 210 $existing_keys = array_keys( $values['item_meta'] );
360 -
361 211 foreach ( $all_fields as $fid ) {
362 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
363 212 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
364 213 $values['item_meta'][ $fid->id ] = '';
365 214 }
366 -
367 215 $field_array[ $fid->id ] = $fid;
368 216 }
369 217 unset( $all_fields );
370 218
371 219 foreach ( $values['item_meta'] as $field_id => $default_value ) {
372 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
220 + if ( isset( $field_array[ $field_id ] ) ) {
221 + $field = $field_array[ $field_id ];
222 + } else {
223 + $field = FrmField::getOne( $field_id );
224 + }
373 225
374 226 if ( ! $field ) {
375 227 continue;
376 228 }
377 229
378 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
379 -
230 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
380 231 if ( $is_settings_page ) {
381 232 self::get_settings_page_html( $values, $field );
382 233
383 234 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -384,20 +235,15 @@
384 235 continue;
385 236 }
386 237 }
387 238
388 - // Updating the form.
239 + //updating the form
389 240 $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field );
390 - // Don't check for POST html.
391 - unset( $update_options['custom_html'] );
241 + unset( $update_options['custom_html'] ); // don't check for POST html
392 242 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
393 243
394 - if ( ! is_array( $field->field_options ) ) {
395 - $field->field_options = array();
396 - }
397 -
398 244 foreach ( $update_options as $opt => $default ) {
399 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
245 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
400 246 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
401 247 }
402 248
403 249 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -406,104 +252,44 @@
406 252 'field_options' => $field->field_options,
407 253 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
408 254 );
409 255
410 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
411 - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
412 - if ( ! is_array( $option ) ) {
413 - continue;
414 - }
415 -
416 - foreach ( $option as $key => $item ) {
417 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
418 - }
419 - }
420 - }
421 -
422 256 self::prepare_field_update_values( $field, $values, $new_field );
423 - self::maybe_update_max_option( $field, $values, $new_field );
424 257
425 258 FrmField::update( $field_id, $new_field );
426 259
427 260 FrmField::delete_form_transient( $field->form_id );
428 - }//end foreach
261 + }
429 262 self::clear_form_cache();
430 263
431 264 return $values;
432 265 }
433 266
434 - /**
435 - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
436 - *
437 - * @since 6.7
438 - *
439 - * @param object $field
440 - * @param array $values
441 - * @param array $new_field
442 - *
443 - * @return void
444 - */
445 - private static function maybe_update_max_option( $field, $values, &$new_field ) {
446 - if ( $field->type !== 'textarea' ||
447 - empty( $values['field_options'][ 'type_' . $field->id ] ) ||
448 - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
449 - return;
450 - }
451 -
452 - $new_field['field_options']['max'] = '';
453 -
454 - /**
455 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
456 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
457 - */
458 - $_POST['field_options'][ 'max_' . $field->id ] = '';
459 - }
460 -
461 - /**
462 - * @param string $opt
463 - * @param mixed $value
464 - *
465 - * @return void
466 - */
467 267 private static function sanitize_field_opt( $opt, &$value ) {
468 - if ( ! is_string( $value ) ) {
469 - return;
268 + if ( is_string( $value ) ) {
269 + if ( $opt === 'calc' ) {
270 + $value = self::sanitize_calc( $value );
271 + } else {
272 + $value = FrmAppHelper::kses( $value, 'all' );
273 + }
274 + $value = trim( $value );
470 275 }
471 -
472 - /**
473 - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead.
474 - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized.
475 - *
476 - * @since 6.0
477 - *
478 - * @param bool $should_sanitize
479 - * @param string $opt
480 - */
481 - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt );
482 -
483 - if ( ! $should_sanitize ) {
484 - return;
485 - }
486 -
487 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
488 - $value = trim( $value );
489 276 }
490 277
491 278 /**
492 279 * @param string $value
493 - *
494 280 * @return string
495 281 */
496 282 private static function sanitize_calc( $value ) {
497 - if ( str_contains( $value, '<' ) ) {
283 + if ( false !== strpos( $value, '<' ) ) {
498 284 $value = self::normalize_calc_spaces( $value );
499 285 }
500 - // Allow <= and >=.
501 - $allow = array( '<= ', ' >=' );
286 + $allow = array( '<= ', ' >=' ); // Allow <= and >=
502 287 $temp = array( '< = ', ' > =' );
503 288 $value = str_replace( $allow, $temp, $value );
504 289 $value = strip_tags( $value );
505 - return str_replace( $temp, $allow, $value );
290 + $value = str_replace( $temp, $allow, $value );
291 + return $value;
506 292 }
507 293
508 294 /**
509 295 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -509,58 +295,41 @@
509 295 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
510 296 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
511 297 *
512 298 * @param string $calc
513 - *
514 299 * @return string
515 300 */
516 301 private static function normalize_calc_spaces( $calc ) {
517 302 // Check for a pattern with 5 parts
518 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
303 + // $1 \d the first comparison digit.
519 304 // $2 a space (optional).
520 305 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
521 306 // $4 another space (optional).
522 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
523 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
307 + // $5 \d the second comparison digit.
308 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
524 309 }
525 310
526 311 /**
527 312 * Updating the settings page
528 - *
529 - * @param array $values Form values array.
530 - * @param object $field Field object, passed by reference.
531 - *
532 - * @return void
533 313 */
534 314 private static function get_settings_page_html( $values, &$field ) {
535 315 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
536 316 $prev_opts = array();
537 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
317 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
538 318
539 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
540 - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
319 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
320 + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
541 321 $prev_opts = $field->field_options;
542 322 }
543 323
544 - if ( ! isset( $prev_opts ) ) {
545 - return;
324 + if ( isset( $prev_opts ) ) {
325 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
326 + if ( $prev_opts != $field->field_options ) {
327 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
328 + }
546 329 }
547 -
548 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
549 -
550 - // phpcs:ignore Universal.Operators.StrictComparisons
551 - if ( $prev_opts != $field->field_options ) {
552 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
553 - }
554 330 }
555 331
556 - /**
557 - * @param object $field
558 - * @param array $values
559 - * @param array $new_field
560 - *
561 - * @return void
562 - */
563 332 private static function prepare_field_update_values( $field, $values, &$new_field ) {
564 333 $field_cols = array(
565 334 'field_order' => 0,
566 335 'field_key' => '',
@@ -569,16 +338,12 @@
569 338 'description' => '',
570 339 'options' => '',
571 340 'name' => '',
572 341 );
573 -
574 342 foreach ( $field_cols as $col => $default ) {
575 - $default = $default === '' ? $field->{$col} : $default;
576 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
577 - }
343 + $default = ( $default === '' ) ? $field->{$col} : $default;
578 344
579 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
580 - $new_field['field_order'] = $field->field_order;
345 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
581 346 }
582 347
583 348 // Don't save the template option.
584 349 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -590,12 +355,9 @@
590 355 * Get a list of all form settings that should be translated
591 356 * on a multilingual site.
592 357 *
593 358 * @since 3.06.01
594 - *
595 - * @param object $form The form object.
596 - *
597 - * @return array
359 + * @param object $form - The form object
598 360 */
599 361 public static function translatable_strings( $form ) {
600 362 $strings = array(
601 363 'name',
@@ -602,12 +364,8 @@
602 364 'description',
603 365 'submit_value',
604 366 'submit_msg',
605 367 'success_msg',
606 - 'invalid_msg',
607 - 'failed_msg',
608 - 'login_msg',
609 - 'admin_permission',
610 368 );
611 369
612 370 return apply_filters( 'frm_form_strings', $strings, $form );
613 371 }
@@ -612,21 +370,19 @@
612 370 return apply_filters( 'frm_form_strings', $strings, $form );
613 371 }
614 372
615 373 /**
616 - * @param array|int $id
617 - * @param string $status
374 + * @param string $status
618 375 *
619 - * @return bool|int
376 + * @return int|boolean
620 377 */
621 378 public static function set_status( $id, $status ) {
622 - if ( 'trash' === $status ) {
379 + if ( 'trash' == $status ) {
623 380 return self::trash( $id );
624 381 }
625 382
626 383 $statuses = array( 'published', 'draft', 'trash' );
627 -
628 - if ( ! in_array( $status, $statuses, true ) ) {
384 + if ( ! in_array( $status, $statuses ) ) {
629 385 return false;
630 386 }
631 387
632 388 global $wpdb;
@@ -639,9 +395,9 @@
639 395 );
640 396 FrmDb::get_where_clause_and_values( $where );
641 397 array_unshift( $where['values'], $status );
642 398
643 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
399 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // WPCS: unprepared SQL ok.
644 400 } else {
645 401 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
646 402 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
647 403 }
@@ -653,11 +409,9 @@
653 409 return $query_results;
654 410 }
655 411
656 412 /**
657 - * @param int|string $id Form ID.
658 - *
659 - * @return bool|int
413 + * @return int|boolean
660 414 */
661 415 public static function trash( $id ) {
662 416 if ( ! EMPTY_TRASH_DAYS ) {
663 417 return self::destroy( $id );
@@ -663,17 +417,12 @@
663 417 return self::destroy( $id );
664 418 }
665 419
666 420 $form = self::getOne( $id );
667 -
668 421 if ( ! $form ) {
669 422 return false;
670 423 }
671 424
672 - if ( $form->status === 'trash' ) {
673 - return false;
674 - }
675 -
676 425 $options = $form->options;
677 426 $options['trash_time'] = time();
678 427
679 428 global $wpdb;
@@ -706,26 +455,21 @@
706 455 return $query_results;
707 456 }
708 457
709 458 /**
710 - * @param int|string $id Form ID.
711 - *
712 - * @return bool|int
459 + * @return int|boolean
713 460 */
714 461 public static function destroy( $id ) {
715 462 global $wpdb;
716 463
717 464 $form = self::getOne( $id );
718 -
719 465 if ( ! $form ) {
720 466 return false;
721 467 }
722 -
723 468 $id = $form->id;
724 469
725 470 // Disconnect the entries from this form
726 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
727 -
471 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
728 472 foreach ( $entries as $entry_id ) {
729 473 FrmEntry::destroy( $entry_id );
730 474 unset( $entry_id );
731 475 }
@@ -730,29 +474,23 @@
730 474 unset( $entry_id );
731 475 }
732 476
733 477 // Disconnect the fields from this form
734 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
478 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
735 479
736 480 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
481 + if ( $query_results ) {
482 + // Delete all form actions linked to this form
483 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
484 + $action_control->destroy( $id, 'all' );
737 485
738 - if ( ! $query_results ) {
739 - return $query_results;
486 + // Clear form caching
487 + self::clear_form_cache();
488 +
489 + do_action( 'frm_destroy_form', $id );
490 + do_action( 'frm_destroy_form_' . $id );
740 491 }
741 492
742 - // Delete all form actions linked to this form
743 - /**
744 - * @var FrmFormAction
745 - */
746 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
747 - $action_control->destroy( $id, 'all' );
748 -
749 - // Clear form caching
750 - self::clear_form_cache();
751 -
752 - do_action( 'frm_destroy_form', $id );
753 - do_action( 'frm_destroy_form_' . $id );
754 -
755 493 return $query_results;
756 494 }
757 495
758 496 /**
@@ -757,34 +495,29 @@
757 495
758 496 /**
759 497 * Delete trashed forms based on how long they have been trashed
760 498 *
761 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
762 - *
763 499 * @return int The number of forms deleted
764 500 */
765 501 public static function scheduled_delete( $delete_timestamp = '' ) {
766 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
502 + global $wpdb;
767 503
504 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' );
505 +
768 506 if ( ! $trash_forms ) {
769 - return 0;
507 + return;
770 508 }
771 509
772 - if ( ! $delete_timestamp ) {
510 + if ( empty( $delete_timestamp ) ) {
773 511 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
774 512 }
775 513
776 514 $count = 0;
777 -
778 515 foreach ( $trash_forms as $form ) {
779 516 FrmAppHelper::unserialize_or_decode( $form->options );
780 -
781 517 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
782 518 self::destroy( $form->id );
783 -
784 - if ( empty( $form->parent_form_id ) ) {
785 - ++$count;
786 - }
519 + $count ++;
787 520 }
788 521
789 522 unset( $form );
790 523 }
@@ -792,24 +525,23 @@
792 525 return $count;
793 526 }
794 527
795 528 /**
796 - * @param int|string $id Form ID or key.
797 - *
798 529 * @return string form name
799 530 */
800 531 public static function getName( $id ) {
801 532 $form = FrmDb::check_cache( $id, 'frm_form' );
533 + if ( $form ) {
534 + $r = stripslashes( $form->name );
802 535
803 - if ( $form ) {
804 - return stripslashes( $form->name );
536 + return $r;
805 537 }
806 538
807 539 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
808 540 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
541 + $r = stripslashes( $r );
809 542
810 - // An empty form name can result in a null value.
811 - return is_null( $r ) ? '' : stripslashes( $r );
543 + return $r;
812 544 }
813 545
814 546 /**
815 547 * @since 3.0
@@ -824,9 +556,9 @@
824 556
825 557 /**
826 558 * @since 3.0
827 559 *
828 - * @param int|string $id
560 + * @param int $id
829 561 *
830 562 * @return string form key
831 563 */
832 564 public static function get_key_by_id( $id ) {
@@ -831,57 +563,59 @@
831 563 */
832 564 public static function get_key_by_id( $id ) {
833 565 $id = (int) $id;
834 566 $cache = FrmDb::check_cache( $id, 'frm_form' );
835 -
836 567 if ( $cache ) {
837 568 return $cache->form_key;
838 569 }
839 570
840 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
571 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
572 +
573 + return $key;
841 574 }
842 575
843 576 /**
844 577 * If $form is numeric, get the form object
845 578 *
579 + * @param object|int $form
580 + *
846 581 * @since 2.0.9
847 - *
848 - * @param array|int|object $form
849 - *
850 - * @return void
851 582 */
852 583 public static function maybe_get_form( &$form ) {
853 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
584 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
854 585 $form = self::getOne( $form );
855 586 }
856 587 }
857 588
858 589 /**
859 - * @param int|string $id
860 - * @param false|int $blog_id
861 - *
862 - * @return stdClass|null
590 + * @return object form
863 591 */
864 592 public static function getOne( $id, $blog_id = false ) {
865 593 global $wpdb;
866 594
867 595 if ( $blog_id && is_multisite() ) {
868 - $prefix = $wpdb->get_blog_prefix( $blog_id );
596 + global $wpmuBaseTablePrefix;
597 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
598 +
869 599 $table_name = $prefix . 'frm_forms';
870 600 } else {
871 601 $table_name = $wpdb->prefix . 'frm_forms';
872 602 $cache = wp_cache_get( $id, 'frm_form' );
873 -
874 603 if ( $cache ) {
875 604 if ( isset( $cache->options ) ) {
876 605 FrmAppHelper::unserialize_or_decode( $cache->options );
877 606 }
878 607
879 - return self::prepare_form_row_data( $cache );
608 + return wp_unslash( $cache );
880 609 }
881 610 }
882 611
883 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
612 + if ( is_numeric( $id ) ) {
613 + $where = array( 'id' => $id );
614 + } else {
615 + $where = array( 'form_key' => $id );
616 + }
617 +
884 618 $results = FrmDb::get_row( $table_name, $where );
885 619
886 620 if ( isset( $results->options ) ) {
887 621 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -887,50 +621,18 @@
887 621 FrmDb::set_cache( $results->id, $results, 'frm_form' );
888 622 FrmAppHelper::unserialize_or_decode( $results->options );
889 623 }
890 624
891 - return self::prepare_form_row_data( $results );
625 + return apply_filters( 'frm_form_object', wp_unslash( $results ) );
892 626 }
893 627
894 628 /**
895 - * Make sure that if $row is an object, that $row->options is an array and not a string.
896 - *
897 - * @since 6.8.3
898 - *
899 - * @param stdClass|null $row The database row for a target form.
900 - *
901 - * @return stdClass|null
629 + * @return object|array of objects
902 630 */
903 - private static function prepare_form_row_data( $row ) {
904 - $row = wp_unslash( $row );
905 -
906 - if ( ! is_object( $row ) ) {
907 - return $row;
908 - }
909 -
910 - if ( ! is_array( $row->options ) ) {
911 - $row->options = FrmFormsHelper::get_default_opts();
912 - }
913 -
914 - /**
915 - * @since 4.03.02
916 - *
917 - * @param stdClass $row
918 - */
919 - return apply_filters( 'frm_form_object', $row );
920 - }
921 -
922 - /**
923 - * @param array|string $where Where conditions array or raw WHERE string.
924 - * @param string $order_by Order by clause.
925 - * @param int|string $limit Limit clause or number.
926 - *
927 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
928 - */
929 631 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
930 - if ( is_array( $where ) && $where ) {
931 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
932 - // Don't get trashed templates
632 + if ( is_array( $where ) && ! empty( $where ) ) {
633 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
634 + // don't get trashed templates
933 635 $where['status'] = array( null, '', 'published' );
934 636 }
935 637
936 638 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -936,11 +638,11 @@
936 638 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
937 639 } else {
938 640 global $wpdb;
939 641
940 - // The query has already been prepared if this is not an array.
941 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
942 - $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
642 + // the query has already been prepared if this is not an array
643 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
644 + $results = $wpdb->get_results( $query ); // WPCS: unprepared SQL ok.
943 645 }
944 646
945 647 if ( $results ) {
946 648 foreach ( $results as $result ) {
@@ -948,10 +650,10 @@
948 650 FrmAppHelper::unserialize_or_decode( $result->options );
949 651 }
950 652 }
951 653
952 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
953 - // Return the first form object if we are only getting one form
654 + if ( $limit == ' LIMIT 1' || $limit == 1 ) {
655 + // return the first form object if we are only getting one form
954 656 $results = reset( $results );
955 657 }
956 658
957 659 return wp_unslash( $results );
@@ -960,24 +662,20 @@
960 662 /**
961 663 * Get all published forms
962 664 *
963 665 * @since 2.0
964 - *
965 - * @param array $query
966 - * @param int $limit
967 - * @param string $inc_children
968 - *
969 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
666 + * @return array of forms
970 667 */
971 668 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
972 669 $query['is_template'] = 0;
973 670 $query['status'] = array( null, '', 'published' );
974 -
975 - if ( $inc_children === 'exclude' ) {
671 + if ( $inc_children == 'exclude' ) {
976 672 $query['parent_form_id'] = array( null, 0 );
977 673 }
978 674
979 - return self::getAll( $query, 'name', $limit );
675 + $forms = self::getAll( $query, 'name', $limit );
676 +
677 + return $forms;
980 678 }
981 679
982 680 /**
983 681 * @return object count of forms
@@ -982,16 +680,18 @@
982 680 /**
983 681 * @return object count of forms
984 682 */
985 683 public static function get_count() {
684 + global $wpdb;
685 +
986 686 $cache_key = 'frm_form_counts';
987 - $counts = wp_cache_get( $cache_key, 'frm_form' );
988 687
688 + $counts = wp_cache_get( $cache_key, 'frm_form' );
989 689 if ( false !== $counts ) {
990 690 return $counts;
991 691 }
992 692
993 - $results = FrmDb::get_results(
693 + $results = (array) FrmDb::get_results(
994 694 'frm_forms',
995 695 array(
996 696 'or' => 1,
997 697 'parent_form_id' => null,
@@ -1003,18 +703,20 @@
1003 703 $statuses = array( 'published', 'draft', 'template', 'trash' );
1004 704 $counts = array_fill_keys( $statuses, 0 );
1005 705
1006 706 foreach ( $results as $row ) {
1007 - if ( 'trash' === $row->status ) {
1008 - ++$counts['trash'];
1009 - } elseif ( $row->is_template ) {
1010 - ++$counts['template'];
707 + if ( 'trash' != $row->status ) {
708 + if ( $row->is_template ) {
709 + $counts['template'] ++;
710 + } else {
711 + $counts['published'] ++;
712 + }
1011 713 } else {
1012 - ++$counts['published'];
714 + $counts['trash'] ++;
1013 715 }
1014 716
1015 - if ( 'draft' === $row->status ) {
1016 - ++$counts['draft'];
717 + if ( 'draft' == $row->status ) {
718 + $counts['draft'] ++;
1017 719 }
1018 720
1019 721 unset( $row );
1020 722 }
@@ -1030,10 +732,8 @@
1030 732 * Called when a form is created, updated, duplicated, or deleted
1031 733 * or when the form status is changed
1032 734 *
1033 735 * @since 2.0.4
1034 - *
1035 - * @return void
1036 736 */
1037 737 public static function clear_form_cache() {
1038 738 FrmDb::cache_delete_group( 'frm_form' );
1039 739 }
@@ -1038,29 +738,23 @@
1038 738 FrmDb::cache_delete_group( 'frm_form' );
1039 739 }
1040 740
1041 741 /**
1042 - * @param array $values Form values to validate.
1043 - *
1044 742 * @return array of errors
1045 743 */
1046 744 public static function validate( $values ) {
1047 745 $errors = array();
746 +
1048 747 return apply_filters( 'frm_validate_form', $errors, $values );
1049 748 }
1050 749
1051 - /**
1052 - * @param object|null $form
1053 - *
1054 - * @return array
1055 - */
1056 750 public static function get_params( $form = null ) {
1057 751 global $frm_vars;
1058 752
1059 - if ( $form ) {
753 + if ( ! $form ) {
754 + $form = self::getAll( array(), 'name', 1 );
755 + } else {
1060 756 self::maybe_get_form( $form );
1061 - } else {
1062 - $form = self::getAll( array(), 'name', 1 );
1063 757 }
1064 758
1065 759 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1066 760 return $frm_vars['form_params'][ $form->id ];
@@ -1065,9 +759,9 @@
1065 759 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1066 760 return $frm_vars['form_params'][ $form->id ];
1067 761 }
1068 762
1069 - $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
763 + $action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // WPCS: CSRF ok.
1070 764 $action = apply_filters( 'frm_show_new_entry_page', FrmAppHelper::get_param( $action_var, 'new', 'get', 'sanitize_title' ), $form );
1071 765
1072 766 $default_values = array(
1073 767 'id' => '',
@@ -1083,18 +777,16 @@
1083 777 );
1084 778
1085 779 $values = array();
1086 780 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1087 -
1088 781 if ( ! $values['posted_form_id'] ) {
1089 782 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1090 783 }
1091 784
1092 - // phpcs:ignore Universal.Operators.StrictComparisons
1093 785 if ( $form->id == $values['posted_form_id'] ) {
1094 - // If there are two forms on the same page, make sure not to submit both.
786 + //if there are two forms on the same page, make sure not to submit both
1095 787 foreach ( $default_values as $var => $default ) {
1096 - if ( $var === 'action' ) {
788 + if ( $var == 'action' ) {
1097 789 $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1098 790 } else {
1099 791 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1100 792 }
@@ -1106,10 +798,10 @@
1106 798 unset( $var, $default );
1107 799 }
1108 800 }
1109 801
1110 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
1111 - ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
802 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
803 + ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // WPCS: CSRF ok.
1112 804 ) {
1113 805 $values['action'] = 'new';
1114 806 }
1115 807
@@ -1115,11 +807,8 @@
1115 807
1116 808 return $values;
1117 809 }
1118 810
1119 - /**
1120 - * @return array
1121 - */
1122 811 public static function list_page_params() {
1123 812 $values = array();
1124 813 $defaults = array(
1125 814 'template' => 0,
@@ -1129,9 +818,8 @@
1129 818 'search' => '',
1130 819 'sort' => '',
1131 820 'sdir' => '',
1132 821 );
1133 -
1134 822 foreach ( $defaults as $var => $default ) {
1135 823 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1136 824 }
1137 825
@@ -1137,16 +825,10 @@
1137 825
1138 826 return $values;
1139 827 }
1140 828
1141 - /**
1142 - * @param int|object|string|null $form
1143 - *
1144 - * @return array
1145 - */
1146 829 public static function get_admin_params( $form = null ) {
1147 830 $form_id = $form;
1148 -
1149 831 if ( $form === null ) {
1150 832 $form_id = self::get_current_form_id();
1151 833 } elseif ( $form && is_object( $form ) ) {
1152 834 $form_id = $form->id;
@@ -1164,9 +846,8 @@
1164 846 'sdir' => '',
1165 847 'fid' => '',
1166 848 'keep_post' => '',
1167 849 );
1168 -
1169 850 foreach ( $defaults as $var => $default ) {
1170 851 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1171 852 }
1172 853
@@ -1172,55 +853,47 @@
1172 853
1173 854 return $values;
1174 855 }
1175 856
1176 - /**
1177 - * @param string $default_form
1178 - *
1179 - * @return int|string
1180 - */
1181 857 public static function get_current_form_id( $default_form = 'none' ) {
1182 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1183 - return $form ? $form->id : 0;
858 + if ( 'first' == $default_form ) {
859 + $form = self::get_current_form();
860 + } else {
861 + $form = self::maybe_get_current_form();
862 + }
863 + $form_id = $form ? $form->id : 0;
864 +
865 + return $form_id;
1184 866 }
1185 867
1186 - /**
1187 - * @param int|string $form_id
1188 - *
1189 - * @return false|int|object|string
1190 - */
1191 868 public static function maybe_get_current_form( $form_id = 0 ) {
1192 869 global $frm_vars;
1193 870
1194 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
871 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1195 872 return $frm_vars['current_form'];
1196 873 }
1197 874
1198 875 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
876 + if ( $form_id ) {
877 + $form_id = self::set_current_form( $form_id );
878 + }
1199 879
1200 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
880 + return $form_id;
1201 881 }
1202 882
1203 - /**
1204 - * @param int $form_id
1205 - *
1206 - * @return false|object
1207 - */
1208 883 public static function get_current_form( $form_id = 0 ) {
1209 884 $form = self::maybe_get_current_form( $form_id );
1210 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
885 + if ( is_numeric( $form ) ) {
886 + $form = self::set_current_form( $form );
887 + }
888 +
889 + return $form;
1211 890 }
1212 891
1213 - /**
1214 - * @param int $form_id
1215 - *
1216 - * @return false|object
1217 - */
1218 892 public static function set_current_form( $form_id ) {
1219 893 global $frm_vars;
1220 894
1221 895 $query = array();
1222 -
1223 896 if ( $form_id ) {
1224 897 $query['id'] = $form_id;
1225 898 }
1226 899
@@ -1228,19 +901,11 @@
1228 901
1229 902 return $frm_vars['current_form'];
1230 903 }
1231 904
1232 - /**
1233 - * @param object $form
1234 - * @param int|string $this_load
1235 - * @param bool $global_load
1236 - *
1237 - * @return bool
1238 - */
1239 905 public static function is_form_loaded( $form, $this_load, $global_load ) {
1240 906 global $frm_vars;
1241 907 $small_form = new stdClass();
1242 -
1243 908 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1244 909 $small_form->{$var} = $form->{$var};
1245 910 unset( $var );
1246 911 }
@@ -1246,14 +911,14 @@
1246 911 }
1247 912
1248 913 $frm_vars['forms_loaded'][] = $small_form;
1249 914
1250 - if ( $this_load && ! $global_load ) {
915 + if ( $this_load && empty( $global_load ) ) {
1251 916 $global_load = true;
1252 917 $frm_vars['load_css'] = true;
1253 918 }
1254 919
1255 - return empty( $frm_vars['css_loaded'] ) && $global_load;
920 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1256 921 }
1257 922
1258 923 /**
1259 924 * @since 4.06.03
@@ -1261,9 +926,9 @@
1261 926 * @param object $form
1262 927 *
1263 928 * @return bool
1264 929 */
1265 - public static function is_visible_to_user( $form ) {
930 + public static function &is_visible_to_user( $form ) {
1266 931 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1267 932 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1268 933 } else {
1269 934 $visible = true;
@@ -1268,39 +933,26 @@
1268 933 } else {
1269 934 $visible = true;
1270 935 }
1271 936
1272 - /**
1273 - * @since 6.25
1274 - *
1275 - * @param bool $visible
1276 - * @param object $form
1277 - */
1278 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
937 + return $visible;
1279 938 }
1280 939
1281 - /**
1282 - * @param object $form
1283 - *
1284 - * @return bool
1285 - */
1286 940 public static function show_submit( $form ) {
1287 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1288 - return apply_filters( 'frm_show_submit_button', $show, $form );
941 + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() );
942 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
943 +
944 + return $show;
1289 945 }
1290 946
1291 947 /**
1292 948 * @since 2.3
1293 - *
1294 - * @param array $atts Attributes including form, option, and default.
1295 - *
1296 - * @return mixed
1297 949 */
1298 950 public static function get_option( $atts ) {
1299 - $form = $atts['form'];
1300 - $default = $atts['default'] ?? '';
951 + $form = $atts['form'];
952 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1301 953
1302 - return $form->options[ $atts['option'] ] ?? $default;
954 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1303 955 }
1304 956
1305 957 /**
1306 958 * Get the link to edit this form.
@@ -1305,12 +957,9 @@
1305 957 /**
1306 958 * Get the link to edit this form.
1307 959 *
1308 960 * @since 4.0
1309 - *
1310 961 * @param int $form_id The id of the form.
1311 - *
1312 - * @return string
1313 962 */
1314 963 public static function get_edit_link( $form_id ) {
1315 964 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1316 965 }
@@ -1315,65 +964,9 @@
1315 964 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1316 965 }
1317 966
1318 967 /**
1319 - * Check if the "Submit this form with AJAX" setting is toggled on.
1320 - *
1321 - * @since 6.2
1322 - *
1323 - * @param stdClass $form
1324 - *
1325 - * @return bool
1326 - */
1327 - public static function is_ajax_on( $form ) {
1328 - return ! empty( $form->options['ajax_submit'] );
1329 - }
1330 -
1331 - /**
1332 - * Get the latest form available.
1333 - *
1334 - * @since 6.8
1335 - *
1336 - * @return object
1337 - */
1338 - public static function get_latest_form() {
1339 - $args = array(
1340 - array(
1341 - 'or' => 1,
1342 - 'parent_form_id' => null,
1343 - 'parent_form_id <' => 1,
1344 - ),
1345 - 'is_template' => 0,
1346 - 'status !' => 'trash',
1347 - );
1348 -
1349 - return self::getAll( $args, 'created_at desc', 1 );
1350 - }
1351 -
1352 - /**
1353 - * Count and return total forms.
1354 - *
1355 - * @since 6.8
1356 - *
1357 - * @return int
1358 - */
1359 - public static function get_forms_count() {
1360 - $args = array(
1361 - array(
1362 - 'or' => 1,
1363 - 'parent_form_id' => null,
1364 - 'parent_form_id <' => 1,
1365 - ),
1366 - 'is_template' => 0,
1367 - 'status !' => 'trash',
1368 - );
1369 -
1370 - return FrmDb::get_count( 'frm_forms', $args );
1371 - }
1372 -
1373 - /**
1374 - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1375 - *
968 + * @deprecated 3.0
1376 969 * @codeCoverageIgnore
1377 970 *
1378 971 * @param string $key
1379 972 *
@@ -1379,22 +972,15 @@
1379 972 *
1380 973 * @return int form id
1381 974 */
1382 975 public static function getIdByKey( $key ) {
1383 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
1384 - return self::get_id_by_key( $key );
976 + return FrmFormDeprecated::getIdByKey( $key );
1385 977 }
1386 978
1387 979 /**
1388 - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1389 - *
980 + * @deprecated 3.0
1390 981 * @codeCoverageIgnore
1391 - *
1392 - * @param int|string $id
1393 - *
1394 - * @return string
1395 982 */
1396 983 public static function getKeyById( $id ) {
1397 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );
1398 - return self::get_key_by_id( $id );
984 + return FrmFormDeprecated::getKeyById( $id );
1399 985 }
1400 986 }