PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.3
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.3
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +178 -496 6.285.3 View file →
@@ -6,10 +6,9 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 - * @return bool|int id on success or false on failure.
10 + * @return int|boolean id on success or false on failure
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
15 14
@@ -18,33 +17,24 @@
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 19 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 - /**
38 - * Allows modifying form options before updating or creating.
39 - *
40 - * @since 5.4 Add the third param.
41 - *
42 - * @param array $options Form options.
43 - * @param array $values Form data.
44 - * @param bool $update Is form updating or creating. It's `true` if is updating.
45 - */
46 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, false );
36 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
47 37 $options = self::maybe_filter_form_options( $options );
48 38 $new_values['options'] = serialize( $options );
49 39
50 40 $wpdb->insert( $wpdb->prefix . 'frm_forms', $new_values );
@@ -60,9 +50,8 @@
60 50 /**
61 51 * @since 5.0.08
62 52 *
63 53 * @param array $options
64 - *
65 54 * @return array
66 55 */
67 56 private static function maybe_filter_form_options( $options ) {
68 57 if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
@@ -71,22 +60,14 @@
71 60 return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 61 }
73 62
74 63 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 - * @return bool|int ID on success or false on failure
64 + * @return int|boolean ID on success or false on failure
83 65 */
84 66 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 67 global $wpdb;
86 68
87 69 $values = self::getOne( $id, $blog_id );
88 -
89 70 if ( ! $values ) {
90 71 return false;
91 72 }
92 73
@@ -103,10 +84,10 @@
103 84 'is_template' => $template ? 1 : 0,
104 85 );
105 86
106 87 if ( $blog_id ) {
107 - $new_values['status'] = 'published';
108 - $new_options = $values->options;
88 + $new_values['status'] = 'published';
89 + $new_options = $values->options;
109 90 FrmAppHelper::unserialize_or_decode( $new_options );
110 91 $new_options['email_to'] = get_option( 'admin_email' );
111 92 $new_options['copy'] = false;
112 93 $new_values['options'] = $new_options;
@@ -126,9 +107,9 @@
126 107
127 108 $form_id = $wpdb->insert_id;
128 109 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 110
130 - // Update form settings after fields are created
111 + // update form settings after fields are created
131 112 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 113
133 114 return $form_id;
134 115 }
@@ -135,16 +116,10 @@
135 116
136 117 return false;
137 118 }
138 119
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 120 public static function after_duplicate( $form_id, $values ) {
146 - $new_opts = $values['options'];
121 + $new_opts = $values['options'];
147 122 FrmAppHelper::unserialize_or_decode( $new_opts );
148 123 $values['options'] = $new_opts;
149 124
150 125 if ( isset( $new_opts['success_msg'] ) ) {
@@ -152,9 +127,8 @@
152 127 }
153 128
154 129 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 130
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 131 if ( $new_opts != $values['options'] ) {
158 132 global $wpdb;
159 133 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 134 }
@@ -167,10 +141,8 @@
167 141 *
168 142 * @since 5.3
169 143 *
170 144 * @param int $form_id Form ID.
171 - *
172 - * @return void
173 145 */
174 146 private static function switch_field_ids_in_fields( $form_id ) {
175 147 global $wpdb;
176 148
@@ -176,11 +148,10 @@
176 148
177 149 // Keys of fields that you want to check to replace field ID.
178 150 $keys = array( 'default_value', 'field_options' );
179 151 $sql_cols = 'fi.id';
180 -
181 152 foreach ( $keys as $key ) {
182 - $sql_cols .= ',fi.' . $key;
153 + $sql_cols .= ( ',fi.' . $key );
183 154 }
184 155
185 156 $fields = FrmDb::get_results(
186 157 "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id",
@@ -206,14 +177,11 @@
206 177 *
207 178 * @since 5.3
208 179 *
209 180 * @param array $field Field array.
210 - *
211 - * @return void
212 181 */
213 182 private static function switch_field_ids_in_field( $field ) {
214 183 $new_values = array();
215 -
216 184 foreach ( $field as $key => $value ) {
217 185 if ( 'id' === $key || ! $value ) {
218 186 continue;
219 187 }
@@ -221,35 +189,21 @@
221 189 if ( ! is_string( $value ) && ! is_array( $value ) ) {
222 190 continue;
223 191 }
224 192
225 - if ( 'field_options' === $key ) {
226 - // Need to loop through field_options to prevent breaking serialized string when length changed.
227 - FrmAppHelper::unserialize_or_decode( $value );
228 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
229 - $new_val = serialize( $new_val );
230 - } else {
231 - $new_val = FrmFieldsHelper::switch_field_ids( $value );
232 - }
233 -
193 + $new_val = FrmFieldsHelper::switch_field_ids( $value );
234 194 if ( $new_val !== $value ) {
235 195 $new_values[ $key ] = $new_val;
236 196 }
237 - }//end foreach
197 + }
238 198
239 - if ( $new_values ) {
199 + if ( ! empty( $new_values ) ) {
240 200 FrmField::update( $field['id'], $new_values );
241 201 }
242 202 }
243 203
244 204 /**
245 - * Update a form.
246 - *
247 - * @param int $id Form ID.
248 - * @param array $values Form values to update.
249 - * @param bool $create_link Whether this is being called from link creation.
250 - *
251 - * @return bool|int
205 + * @return int|boolean
252 206 */
253 207 public static function update( $id, $values, $create_link = false ) {
254 208 global $wpdb;
255 209
@@ -263,23 +217,23 @@
263 217 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
264 218 }
265 219
266 220 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
267 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
268 221
222 + $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
223 +
269 224 foreach ( $values as $value_key => $value ) {
270 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
225 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
271 226 $new_values[ $value_key ] = $value;
272 227 }
273 228 }
274 229
275 - if ( ! empty( $values['new_status'] ) ) {
230 + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) {
276 231 $new_values['status'] = $values['new_status'];
277 232 }
278 233
279 - if ( $new_values ) {
234 + if ( ! empty( $new_values ) ) {
280 235 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
281 -
282 236 if ( $query_results ) {
283 237 self::clear_form_cache();
284 238 }
285 239 } else {
@@ -298,9 +252,8 @@
298 252 /**
299 253 * @param array $new_values
300 254 * @param array $values
301 255 * @param array $args
302 - *
303 256 * @return array
304 257 */
305 258 public static function set_update_options( $new_values, $values, $args = array() ) {
306 259 if ( ! isset( $values['options'] ) ) {
@@ -306,26 +259,22 @@
306 259 if ( ! isset( $values['options'] ) ) {
307 260 return $new_values;
308 261 }
309 262
310 - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
263 + $options = isset( $values['options'] ) ? (array) $values['options'] : array();
311 264 FrmFormsHelper::fill_form_options( $options, $values );
312 265
313 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
314 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
315 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
316 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
266 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
267 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
268 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
269 + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
317 270
318 - /**
319 - * Allows modifying form options before updating or creating.
320 - *
321 - * @since 5.4 Added the third param.
322 - *
323 - * @param array $options Form options.
324 - * @param array $values Form data.
325 - * @param bool $update Is form updating or creating. It's `true` if is updating.
326 - */
327 - $options = apply_filters( 'frm_form_options_before_update', $options, $values, true );
271 + if ( ! empty( $options['success_url'] ) && ! empty( $args['form_id'] ) ) {
272 + $options['success_url'] = FrmFormsHelper::maybe_add_sanitize_url_attr( $options['success_url'], (int) $args['form_id'] );
273 + $values['options']['success_url'] = $options['success_url'];
274 + }
275 +
276 + $options = apply_filters( 'frm_form_options_before_update', $options, $values );
328 277 $options = self::maybe_filter_form_options( $options );
329 278 $new_values['options'] = serialize( $options );
330 279
331 280 return $new_values;
@@ -331,14 +280,11 @@
331 280 return $new_values;
332 281 }
333 282
334 283 /**
335 - * @param int $id Form ID.
336 - * @param array $values Form values array.
337 - *
338 284 * @return array
339 285 */
340 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
286 + public static function update_fields( $id, $values ) {
341 287
342 288 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
343 289 return $values;
344 290 }
@@ -343,10 +289,9 @@
343 289 return $values;
344 290 }
345 291
346 292 $all_fields = FrmField::get_all_for_form( $id );
347 -
348 - if ( ! $all_fields ) {
293 + if ( empty( $all_fields ) ) {
349 294 return $values;
350 295 }
351 296
352 297 if ( ! isset( $values['item_meta'] ) ) {
@@ -354,28 +299,28 @@
354 299 }
355 300
356 301 $field_array = array();
357 302 $existing_keys = array_keys( $values['item_meta'] );
358 -
359 303 foreach ( $all_fields as $fid ) {
360 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
361 304 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
362 305 $values['item_meta'][ $fid->id ] = '';
363 306 }
364 -
365 307 $field_array[ $fid->id ] = $fid;
366 308 }
367 309 unset( $all_fields );
368 310
369 311 foreach ( $values['item_meta'] as $field_id => $default_value ) {
370 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
312 + if ( isset( $field_array[ $field_id ] ) ) {
313 + $field = $field_array[ $field_id ];
314 + } else {
315 + $field = FrmField::getOne( $field_id );
316 + }
371 317
372 318 if ( ! $field ) {
373 319 continue;
374 320 }
375 321
376 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
377 -
322 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
378 323 if ( $is_settings_page ) {
379 324 self::get_settings_page_html( $values, $field );
380 325
381 326 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -382,20 +327,15 @@
382 327 continue;
383 328 }
384 329 }
385 330
386 - // Updating the form.
331 + //updating the form
387 332 $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field );
388 - // Don't check for POST html.
389 - unset( $update_options['custom_html'] );
333 + unset( $update_options['custom_html'] ); // don't check for POST html
390 334 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
391 335
392 - if ( ! is_array( $field->field_options ) ) {
393 - $field->field_options = array();
394 - }
395 -
396 336 foreach ( $update_options as $opt => $default ) {
397 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
337 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
398 338 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
399 339 }
400 340
401 341 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -404,100 +344,44 @@
404 344 'field_options' => $field->field_options,
405 345 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
406 346 );
407 347
408 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
409 - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
410 - if ( is_array( $option ) ) {
411 - foreach ( $option as $key => $item ) {
412 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
413 - }
414 - }
415 - }
416 - }
417 -
418 348 self::prepare_field_update_values( $field, $values, $new_field );
419 - self::maybe_update_max_option( $field, $values, $new_field );
420 349
421 350 FrmField::update( $field_id, $new_field );
422 351
423 352 FrmField::delete_form_transient( $field->form_id );
424 - }//end foreach
353 + }
425 354 self::clear_form_cache();
426 355
427 356 return $values;
428 357 }
429 358
430 - /**
431 - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
432 - *
433 - * @since 6.7
434 - *
435 - * @param object $field
436 - * @param array $values
437 - * @param array $new_field
438 - *
439 - * @return void
440 - */
441 - private static function maybe_update_max_option( $field, $values, &$new_field ) {
442 - if ( $field->type === 'textarea' &&
443 - ! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
444 - in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
445 - $new_field['field_options']['max'] = '';
446 -
447 - /**
448 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
449 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
450 - */
451 - $_POST['field_options'][ 'max_' . $field->id ] = '';
452 - }
453 - }
454 -
455 - /**
456 - * @param string $opt
457 - * @param mixed $value
458 - *
459 - * @return void
460 - */
461 359 private static function sanitize_field_opt( $opt, &$value ) {
462 - if ( ! is_string( $value ) ) {
463 - return;
360 + if ( is_string( $value ) ) {
361 + if ( $opt === 'calc' ) {
362 + $value = self::sanitize_calc( $value );
363 + } else {
364 + $value = FrmAppHelper::kses( $value, 'all' );
365 + }
366 + $value = trim( $value );
464 367 }
465 -
466 - /**
467 - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead.
468 - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized.
469 - *
470 - * @since 6.0
471 - *
472 - * @param bool $should_sanitize
473 - * @param string $opt
474 - */
475 - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt );
476 -
477 - if ( ! $should_sanitize ) {
478 - return;
479 - }
480 -
481 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
482 - $value = trim( $value );
483 368 }
484 369
485 370 /**
486 371 * @param string $value
487 - *
488 372 * @return string
489 373 */
490 374 private static function sanitize_calc( $value ) {
491 - if ( str_contains( $value, '<' ) ) {
375 + if ( false !== strpos( $value, '<' ) ) {
492 376 $value = self::normalize_calc_spaces( $value );
493 377 }
494 - // Allow <= and >=.
495 - $allow = array( '<= ', ' >=' );
378 + $allow = array( '<= ', ' >=' ); // Allow <= and >=
496 379 $temp = array( '< = ', ' > =' );
497 380 $value = str_replace( $allow, $temp, $value );
498 381 $value = strip_tags( $value );
499 - return str_replace( $temp, $allow, $value );
382 + $value = str_replace( $temp, $allow, $value );
383 + return $value;
500 384 }
501 385
502 386 /**
503 387 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -503,58 +387,41 @@
503 387 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
504 388 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
505 389 *
506 390 * @param string $calc
507 - *
508 391 * @return string
509 392 */
510 393 private static function normalize_calc_spaces( $calc ) {
511 394 // Check for a pattern with 5 parts
512 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
395 + // $1 \d the first comparison digit.
513 396 // $2 a space (optional).
514 397 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
515 398 // $4 another space (optional).
516 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
517 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
399 + // $5 \d the second comparison digit.
400 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
518 401 }
519 402
520 403 /**
521 404 * Updating the settings page
522 - *
523 - * @param array $values Form values array.
524 - * @param object $field Field object, passed by reference.
525 - *
526 - * @return void
527 405 */
528 406 private static function get_settings_page_html( $values, &$field ) {
529 407 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
530 408 $prev_opts = array();
531 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
409 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
532 410
533 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
534 - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
411 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
412 + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
535 413 $prev_opts = $field->field_options;
536 414 }
537 415
538 - if ( ! isset( $prev_opts ) ) {
539 - return;
416 + if ( isset( $prev_opts ) ) {
417 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
418 + if ( $prev_opts != $field->field_options ) {
419 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
420 + }
540 421 }
541 -
542 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
543 -
544 - // phpcs:ignore Universal.Operators.StrictComparisons
545 - if ( $prev_opts != $field->field_options ) {
546 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
547 - }
548 422 }
549 423
550 - /**
551 - * @param object $field
552 - * @param array $values
553 - * @param array $new_field
554 - *
555 - * @return void
556 - */
557 424 private static function prepare_field_update_values( $field, $values, &$new_field ) {
558 425 $field_cols = array(
559 426 'field_order' => 0,
560 427 'field_key' => '',
@@ -563,16 +430,12 @@
563 430 'description' => '',
564 431 'options' => '',
565 432 'name' => '',
566 433 );
567 -
568 434 foreach ( $field_cols as $col => $default ) {
569 - $default = $default === '' ? $field->{$col} : $default;
570 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
571 - }
435 + $default = ( $default === '' ) ? $field->{$col} : $default;
572 436
573 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
574 - $new_field['field_order'] = $field->field_order;
437 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
575 438 }
576 439
577 440 // Don't save the template option.
578 441 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -584,12 +447,9 @@
584 447 * Get a list of all form settings that should be translated
585 448 * on a multilingual site.
586 449 *
587 450 * @since 3.06.01
588 - *
589 - * @param object $form The form object.
590 - *
591 - * @return array
451 + * @param object $form - The form object
592 452 */
593 453 public static function translatable_strings( $form ) {
594 454 $strings = array(
595 455 'name',
@@ -596,12 +456,8 @@
596 456 'description',
597 457 'submit_value',
598 458 'submit_msg',
599 459 'success_msg',
600 - 'invalid_msg',
601 - 'failed_msg',
602 - 'login_msg',
603 - 'admin_permission',
604 460 );
605 461
606 462 return apply_filters( 'frm_form_strings', $strings, $form );
607 463 }
@@ -606,21 +462,19 @@
606 462 return apply_filters( 'frm_form_strings', $strings, $form );
607 463 }
608 464
609 465 /**
610 - * @param array|int $id
611 - * @param string $status
466 + * @param string $status
612 467 *
613 - * @return bool|int
468 + * @return int|boolean
614 469 */
615 470 public static function set_status( $id, $status ) {
616 - if ( 'trash' === $status ) {
471 + if ( 'trash' == $status ) {
617 472 return self::trash( $id );
618 473 }
619 474
620 475 $statuses = array( 'published', 'draft', 'trash' );
621 -
622 - if ( ! in_array( $status, $statuses, true ) ) {
476 + if ( ! in_array( $status, $statuses ) ) {
623 477 return false;
624 478 }
625 479
626 480 global $wpdb;
@@ -633,9 +487,9 @@
633 487 );
634 488 FrmDb::get_where_clause_and_values( $where );
635 489 array_unshift( $where['values'], $status );
636 490
637 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
491 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
638 492 } else {
639 493 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
640 494 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
641 495 }
@@ -647,11 +501,9 @@
647 501 return $query_results;
648 502 }
649 503
650 504 /**
651 - * @param int|string $id Form ID.
652 - *
653 - * @return bool|int
505 + * @return int|boolean
654 506 */
655 507 public static function trash( $id ) {
656 508 if ( ! EMPTY_TRASH_DAYS ) {
657 509 return self::destroy( $id );
@@ -657,17 +509,12 @@
657 509 return self::destroy( $id );
658 510 }
659 511
660 512 $form = self::getOne( $id );
661 -
662 513 if ( ! $form ) {
663 514 return false;
664 515 }
665 516
666 - if ( $form->status === 'trash' ) {
667 - return false;
668 - }
669 -
670 517 $options = $form->options;
671 518 $options['trash_time'] = time();
672 519
673 520 global $wpdb;
@@ -700,26 +547,21 @@
700 547 return $query_results;
701 548 }
702 549
703 550 /**
704 - * @param int|string $id Form ID.
705 - *
706 - * @return bool|int
551 + * @return int|boolean
707 552 */
708 553 public static function destroy( $id ) {
709 554 global $wpdb;
710 555
711 556 $form = self::getOne( $id );
712 -
713 557 if ( ! $form ) {
714 558 return false;
715 559 }
716 -
717 560 $id = $form->id;
718 561
719 562 // Disconnect the entries from this form
720 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
721 -
563 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
722 564 foreach ( $entries as $entry_id ) {
723 565 FrmEntry::destroy( $entry_id );
724 566 unset( $entry_id );
725 567 }
@@ -724,29 +566,23 @@
724 566 unset( $entry_id );
725 567 }
726 568
727 569 // Disconnect the fields from this form
728 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
570 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
729 571
730 572 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
573 + if ( $query_results ) {
574 + // Delete all form actions linked to this form
575 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
576 + $action_control->destroy( $id, 'all' );
731 577
732 - if ( ! $query_results ) {
733 - return $query_results;
578 + // Clear form caching
579 + self::clear_form_cache();
580 +
581 + do_action( 'frm_destroy_form', $id );
582 + do_action( 'frm_destroy_form_' . $id );
734 583 }
735 584
736 - // Delete all form actions linked to this form
737 - /**
738 - * @var FrmFormAction
739 - */
740 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
741 - $action_control->destroy( $id, 'all' );
742 -
743 - // Clear form caching
744 - self::clear_form_cache();
745 -
746 - do_action( 'frm_destroy_form', $id );
747 - do_action( 'frm_destroy_form_' . $id );
748 -
749 585 return $query_results;
750 586 }
751 587
752 588 /**
@@ -751,34 +587,29 @@
751 587
752 588 /**
753 589 * Delete trashed forms based on how long they have been trashed
754 590 *
755 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
756 - *
757 591 * @return int The number of forms deleted
758 592 */
759 593 public static function scheduled_delete( $delete_timestamp = '' ) {
760 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
594 + global $wpdb;
761 595
596 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' );
597 +
762 598 if ( ! $trash_forms ) {
763 599 return 0;
764 600 }
765 601
766 - if ( ! $delete_timestamp ) {
602 + if ( empty( $delete_timestamp ) ) {
767 603 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
768 604 }
769 605
770 606 $count = 0;
771 -
772 607 foreach ( $trash_forms as $form ) {
773 608 FrmAppHelper::unserialize_or_decode( $form->options );
774 -
775 609 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
776 610 self::destroy( $form->id );
777 -
778 - if ( empty( $form->parent_form_id ) ) {
779 - ++$count;
780 - }
611 + $count ++;
781 612 }
782 613
783 614 unset( $form );
784 615 }
@@ -786,24 +617,23 @@
786 617 return $count;
787 618 }
788 619
789 620 /**
790 - * @param int|string $id Form ID or key.
791 - *
792 621 * @return string form name
793 622 */
794 623 public static function getName( $id ) {
795 624 $form = FrmDb::check_cache( $id, 'frm_form' );
625 + if ( $form ) {
626 + $r = stripslashes( $form->name );
796 627
797 - if ( $form ) {
798 - return stripslashes( $form->name );
628 + return $r;
799 629 }
800 630
801 631 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
802 632 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
633 + $r = stripslashes( $r );
803 634
804 - // An empty form name can result in a null value.
805 - return is_null( $r ) ? '' : stripslashes( $r );
635 + return $r;
806 636 }
807 637
808 638 /**
809 639 * @since 3.0
@@ -818,9 +648,9 @@
818 648
819 649 /**
820 650 * @since 3.0
821 651 *
822 - * @param int|string $id
652 + * @param int $id
823 653 *
824 654 * @return string form key
825 655 */
826 656 public static function get_key_by_id( $id ) {
@@ -825,57 +655,59 @@
825 655 */
826 656 public static function get_key_by_id( $id ) {
827 657 $id = (int) $id;
828 658 $cache = FrmDb::check_cache( $id, 'frm_form' );
829 -
830 659 if ( $cache ) {
831 660 return $cache->form_key;
832 661 }
833 662
834 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
663 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
664 +
665 + return $key;
835 666 }
836 667
837 668 /**
838 669 * If $form is numeric, get the form object
839 670 *
671 + * @param object|int $form
672 + *
840 673 * @since 2.0.9
841 - *
842 - * @param array|int|object $form
843 - *
844 - * @return void
845 674 */
846 675 public static function maybe_get_form( &$form ) {
847 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
676 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
848 677 $form = self::getOne( $form );
849 678 }
850 679 }
851 680
852 681 /**
853 - * @param int|string $id
854 - * @param false|int $blog_id
855 - *
856 - * @return stdClass|null
682 + * @return object form
857 683 */
858 684 public static function getOne( $id, $blog_id = false ) {
859 685 global $wpdb;
860 686
861 687 if ( $blog_id && is_multisite() ) {
862 - $prefix = $wpdb->get_blog_prefix( $blog_id );
688 + global $wpmuBaseTablePrefix;
689 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
690 +
863 691 $table_name = $prefix . 'frm_forms';
864 692 } else {
865 693 $table_name = $wpdb->prefix . 'frm_forms';
866 694 $cache = wp_cache_get( $id, 'frm_form' );
867 -
868 695 if ( $cache ) {
869 696 if ( isset( $cache->options ) ) {
870 697 FrmAppHelper::unserialize_or_decode( $cache->options );
871 698 }
872 699
873 - return self::prepare_form_row_data( $cache );
700 + return wp_unslash( $cache );
874 701 }
875 702 }
876 703
877 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
704 + if ( is_numeric( $id ) ) {
705 + $where = array( 'id' => $id );
706 + } else {
707 + $where = array( 'form_key' => $id );
708 + }
709 +
878 710 $results = FrmDb::get_row( $table_name, $where );
879 711
880 712 if ( isset( $results->options ) ) {
881 713 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -881,50 +713,18 @@
881 713 FrmDb::set_cache( $results->id, $results, 'frm_form' );
882 714 FrmAppHelper::unserialize_or_decode( $results->options );
883 715 }
884 716
885 - return self::prepare_form_row_data( $results );
717 + return apply_filters( 'frm_form_object', wp_unslash( $results ) );
886 718 }
887 719
888 720 /**
889 - * Make sure that if $row is an object, that $row->options is an array and not a string.
890 - *
891 - * @since 6.8.3
892 - *
893 - * @param stdClass|null $row The database row for a target form.
894 - *
895 - * @return stdClass|null
721 + * @return object|array of objects
896 722 */
897 - private static function prepare_form_row_data( $row ) {
898 - $row = wp_unslash( $row );
899 -
900 - if ( ! is_object( $row ) ) {
901 - return $row;
902 - }
903 -
904 - if ( ! is_array( $row->options ) ) {
905 - $row->options = FrmFormsHelper::get_default_opts();
906 - }
907 -
908 - /**
909 - * @since 4.03.02
910 - *
911 - * @param stdClass $row
912 - */
913 - return apply_filters( 'frm_form_object', $row );
914 - }
915 -
916 - /**
917 - * @param array|string $where Where conditions array or raw WHERE string.
918 - * @param string $order_by Order by clause.
919 - * @param int|string $limit Limit clause or number.
920 - *
921 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
922 - */
923 723 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
924 - if ( is_array( $where ) && $where ) {
925 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
926 - // Don't get trashed templates
724 + if ( is_array( $where ) && ! empty( $where ) ) {
725 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
726 + // don't get trashed templates
927 727 $where['status'] = array( null, '', 'published' );
928 728 }
929 729
930 730 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -930,10 +730,10 @@
930 730 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
931 731 } else {
932 732 global $wpdb;
933 733
934 - // The query has already been prepared if this is not an array.
935 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
734 + // the query has already been prepared if this is not an array
735 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
936 736 $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
937 737 }
938 738
939 739 if ( $results ) {
@@ -942,10 +742,10 @@
942 742 FrmAppHelper::unserialize_or_decode( $result->options );
943 743 }
944 744 }
945 745
946 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
947 - // Return the first form object if we are only getting one form
746 + if ( $limit == ' LIMIT 1' || $limit == 1 ) {
747 + // return the first form object if we are only getting one form
948 748 $results = reset( $results );
949 749 }
950 750
951 751 return wp_unslash( $results );
@@ -954,24 +754,20 @@
954 754 /**
955 755 * Get all published forms
956 756 *
957 757 * @since 2.0
958 - *
959 - * @param array $query
960 - * @param int $limit
961 - * @param string $inc_children
962 - *
963 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
758 + * @return array of forms
964 759 */
965 760 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
966 761 $query['is_template'] = 0;
967 762 $query['status'] = array( null, '', 'published' );
968 -
969 - if ( $inc_children === 'exclude' ) {
763 + if ( $inc_children == 'exclude' ) {
970 764 $query['parent_form_id'] = array( null, 0 );
971 765 }
972 766
973 - return self::getAll( $query, 'name', $limit );
767 + $forms = self::getAll( $query, 'name', $limit );
768 +
769 + return $forms;
974 770 }
975 771
976 772 /**
977 773 * @return object count of forms
@@ -976,16 +772,18 @@
976 772 /**
977 773 * @return object count of forms
978 774 */
979 775 public static function get_count() {
776 + global $wpdb;
777 +
980 778 $cache_key = 'frm_form_counts';
981 - $counts = wp_cache_get( $cache_key, 'frm_form' );
982 779
780 + $counts = wp_cache_get( $cache_key, 'frm_form' );
983 781 if ( false !== $counts ) {
984 782 return $counts;
985 783 }
986 784
987 - $results = FrmDb::get_results(
785 + $results = (array) FrmDb::get_results(
988 786 'frm_forms',
989 787 array(
990 788 'or' => 1,
991 789 'parent_form_id' => null,
@@ -997,20 +795,20 @@
997 795 $statuses = array( 'published', 'draft', 'template', 'trash' );
998 796 $counts = array_fill_keys( $statuses, 0 );
999 797
1000 798 foreach ( $results as $row ) {
1001 - if ( 'trash' !== $row->status ) {
799 + if ( 'trash' != $row->status ) {
1002 800 if ( $row->is_template ) {
1003 - ++$counts['template'];
801 + $counts['template'] ++;
1004 802 } else {
1005 - ++$counts['published'];
803 + $counts['published'] ++;
1006 804 }
1007 805 } else {
1008 - ++$counts['trash'];
806 + $counts['trash'] ++;
1009 807 }
1010 808
1011 - if ( 'draft' === $row->status ) {
1012 - ++$counts['draft'];
809 + if ( 'draft' == $row->status ) {
810 + $counts['draft'] ++;
1013 811 }
1014 812
1015 813 unset( $row );
1016 814 }
@@ -1026,10 +824,8 @@
1026 824 * Called when a form is created, updated, duplicated, or deleted
1027 825 * or when the form status is changed
1028 826 *
1029 827 * @since 2.0.4
1030 - *
1031 - * @return void
1032 828 */
1033 829 public static function clear_form_cache() {
1034 830 FrmDb::cache_delete_group( 'frm_form' );
1035 831 }
@@ -1034,22 +830,16 @@
1034 830 FrmDb::cache_delete_group( 'frm_form' );
1035 831 }
1036 832
1037 833 /**
1038 - * @param array $values Form values to validate.
1039 - *
1040 834 * @return array of errors
1041 835 */
1042 836 public static function validate( $values ) {
1043 837 $errors = array();
838 +
1044 839 return apply_filters( 'frm_validate_form', $errors, $values );
1045 840 }
1046 841
1047 - /**
1048 - * @param object|null $form
1049 - *
1050 - * @return array
1051 - */
1052 842 public static function get_params( $form = null ) {
1053 843 global $frm_vars;
1054 844
1055 845 if ( ! $form ) {
@@ -1079,18 +869,16 @@
1079 869 );
1080 870
1081 871 $values = array();
1082 872 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1083 -
1084 873 if ( ! $values['posted_form_id'] ) {
1085 874 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1086 875 }
1087 876
1088 - // phpcs:ignore Universal.Operators.StrictComparisons
1089 877 if ( $form->id == $values['posted_form_id'] ) {
1090 - // If there are two forms on the same page, make sure not to submit both.
878 + //if there are two forms on the same page, make sure not to submit both
1091 879 foreach ( $default_values as $var => $default ) {
1092 - if ( $var === 'action' ) {
880 + if ( $var == 'action' ) {
1093 881 $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1094 882 } else {
1095 883 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1096 884 }
@@ -1102,9 +890,9 @@
1102 890 unset( $var, $default );
1103 891 }
1104 892 }
1105 893
1106 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
894 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
1107 895 ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
1108 896 ) {
1109 897 $values['action'] = 'new';
1110 898 }
@@ -1111,11 +899,8 @@
1111 899
1112 900 return $values;
1113 901 }
1114 902
1115 - /**
1116 - * @return array
1117 - */
1118 903 public static function list_page_params() {
1119 904 $values = array();
1120 905 $defaults = array(
1121 906 'template' => 0,
@@ -1125,9 +910,8 @@
1125 910 'search' => '',
1126 911 'sort' => '',
1127 912 'sdir' => '',
1128 913 );
1129 -
1130 914 foreach ( $defaults as $var => $default ) {
1131 915 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1132 916 }
1133 917
@@ -1133,16 +917,10 @@
1133 917
1134 918 return $values;
1135 919 }
1136 920
1137 - /**
1138 - * @param int|object|string|null $form
1139 - *
1140 - * @return array
1141 - */
1142 921 public static function get_admin_params( $form = null ) {
1143 922 $form_id = $form;
1144 -
1145 923 if ( $form === null ) {
1146 924 $form_id = self::get_current_form_id();
1147 925 } elseif ( $form && is_object( $form ) ) {
1148 926 $form_id = $form->id;
@@ -1160,9 +938,8 @@
1160 938 'sdir' => '',
1161 939 'fid' => '',
1162 940 'keep_post' => '',
1163 941 );
1164 -
1165 942 foreach ( $defaults as $var => $default ) {
1166 943 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1167 944 }
1168 945
@@ -1168,55 +945,47 @@
1168 945
1169 946 return $values;
1170 947 }
1171 948
1172 - /**
1173 - * @param string $default_form
1174 - *
1175 - * @return int|string
1176 - */
1177 949 public static function get_current_form_id( $default_form = 'none' ) {
1178 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1179 - return $form ? $form->id : 0;
950 + if ( 'first' == $default_form ) {
951 + $form = self::get_current_form();
952 + } else {
953 + $form = self::maybe_get_current_form();
954 + }
955 + $form_id = $form ? $form->id : 0;
956 +
957 + return $form_id;
1180 958 }
1181 959
1182 - /**
1183 - * @param int|string $form_id
1184 - *
1185 - * @return false|int|object|string
1186 - */
1187 960 public static function maybe_get_current_form( $form_id = 0 ) {
1188 961 global $frm_vars;
1189 962
1190 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
963 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1191 964 return $frm_vars['current_form'];
1192 965 }
1193 966
1194 967 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
968 + if ( $form_id ) {
969 + $form_id = self::set_current_form( $form_id );
970 + }
1195 971
1196 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
972 + return $form_id;
1197 973 }
1198 974
1199 - /**
1200 - * @param int $form_id
1201 - *
1202 - * @return false|object
1203 - */
1204 975 public static function get_current_form( $form_id = 0 ) {
1205 976 $form = self::maybe_get_current_form( $form_id );
1206 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
977 + if ( is_numeric( $form ) ) {
978 + $form = self::set_current_form( $form );
979 + }
980 +
981 + return $form;
1207 982 }
1208 983
1209 - /**
1210 - * @param int $form_id
1211 - *
1212 - * @return false|object
1213 - */
1214 984 public static function set_current_form( $form_id ) {
1215 985 global $frm_vars;
1216 986
1217 987 $query = array();
1218 -
1219 988 if ( $form_id ) {
1220 989 $query['id'] = $form_id;
1221 990 }
1222 991
@@ -1224,19 +993,11 @@
1224 993
1225 994 return $frm_vars['current_form'];
1226 995 }
1227 996
1228 - /**
1229 - * @param object $form
1230 - * @param int|string $this_load
1231 - * @param bool $global_load
1232 - *
1233 - * @return bool
1234 - */
1235 997 public static function is_form_loaded( $form, $this_load, $global_load ) {
1236 998 global $frm_vars;
1237 999 $small_form = new stdClass();
1238 -
1239 1000 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1240 1001 $small_form->{$var} = $form->{$var};
1241 1002 unset( $var );
1242 1003 }
@@ -1242,14 +1003,14 @@
1242 1003 }
1243 1004
1244 1005 $frm_vars['forms_loaded'][] = $small_form;
1245 1006
1246 - if ( $this_load && ! $global_load ) {
1007 + if ( $this_load && empty( $global_load ) ) {
1247 1008 $global_load = true;
1248 1009 $frm_vars['load_css'] = true;
1249 1010 }
1250 1011
1251 - return empty( $frm_vars['css_loaded'] ) && $global_load;
1012 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1252 1013 }
1253 1014
1254 1015 /**
1255 1016 * @since 4.06.03
@@ -1257,9 +1018,9 @@
1257 1018 * @param object $form
1258 1019 *
1259 1020 * @return bool
1260 1021 */
1261 - public static function is_visible_to_user( $form ) {
1022 + public static function &is_visible_to_user( $form ) {
1262 1023 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1263 1024 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1264 1025 } else {
1265 1026 $visible = true;
@@ -1264,39 +1025,26 @@
1264 1025 } else {
1265 1026 $visible = true;
1266 1027 }
1267 1028
1268 - /**
1269 - * @since 6.25
1270 - *
1271 - * @param bool $visible
1272 - * @param object $form
1273 - */
1274 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
1029 + return $visible;
1275 1030 }
1276 1031
1277 - /**
1278 - * @param object $form
1279 - *
1280 - * @return bool
1281 - */
1282 1032 public static function show_submit( $form ) {
1283 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1284 - return apply_filters( 'frm_show_submit_button', $show, $form );
1033 + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() );
1034 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
1035 +
1036 + return $show;
1285 1037 }
1286 1038
1287 1039 /**
1288 1040 * @since 2.3
1289 - *
1290 - * @param array $atts Attributes including form, option, and default.
1291 - *
1292 - * @return mixed
1293 1041 */
1294 1042 public static function get_option( $atts ) {
1295 - $form = $atts['form'];
1296 - $default = $atts['default'] ?? '';
1043 + $form = $atts['form'];
1044 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1297 1045
1298 - return $form->options[ $atts['option'] ] ?? $default;
1046 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1299 1047 }
1300 1048
1301 1049 /**
1302 1050 * Get the link to edit this form.
@@ -1301,12 +1049,9 @@
1301 1049 /**
1302 1050 * Get the link to edit this form.
1303 1051 *
1304 1052 * @since 4.0
1305 - *
1306 1053 * @param int $form_id The id of the form.
1307 - *
1308 - * @return string
1309 1054 */
1310 1055 public static function get_edit_link( $form_id ) {
1311 1056 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1312 1057 }
@@ -1311,65 +1056,9 @@
1311 1056 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1312 1057 }
1313 1058
1314 1059 /**
1315 - * Check if the "Submit this form with AJAX" setting is toggled on.
1316 - *
1317 - * @since 6.2
1318 - *
1319 - * @param stdClass $form
1320 - *
1321 - * @return bool
1322 - */
1323 - public static function is_ajax_on( $form ) {
1324 - return ! empty( $form->options['ajax_submit'] );
1325 - }
1326 -
1327 - /**
1328 - * Get the latest form available.
1329 - *
1330 - * @since 6.8
1331 - *
1332 - * @return object
1333 - */
1334 - public static function get_latest_form() {
1335 - $args = array(
1336 - array(
1337 - 'or' => 1,
1338 - 'parent_form_id' => null,
1339 - 'parent_form_id <' => 1,
1340 - ),
1341 - 'is_template' => 0,
1342 - 'status !' => 'trash',
1343 - );
1344 -
1345 - return self::getAll( $args, 'created_at desc', 1 );
1346 - }
1347 -
1348 - /**
1349 - * Count and return total forms.
1350 - *
1351 - * @since 6.8
1352 - *
1353 - * @return int
1354 - */
1355 - public static function get_forms_count() {
1356 - $args = array(
1357 - array(
1358 - 'or' => 1,
1359 - 'parent_form_id' => null,
1360 - 'parent_form_id <' => 1,
1361 - ),
1362 - 'is_template' => 0,
1363 - 'status !' => 'trash',
1364 - );
1365 -
1366 - return FrmDb::get_count( 'frm_forms', $args );
1367 - }
1368 -
1369 - /**
1370 - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1371 - *
1060 + * @deprecated 3.0
1372 1061 * @codeCoverageIgnore
1373 1062 *
1374 1063 * @param string $key
1375 1064 *
@@ -1375,22 +1064,15 @@
1375 1064 *
1376 1065 * @return int form id
1377 1066 */
1378 1067 public static function getIdByKey( $key ) {
1379 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
1380 - return self::get_id_by_key( $key );
1068 + return FrmFormDeprecated::getIdByKey( $key );
1381 1069 }
1382 1070
1383 1071 /**
1384 - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1385 - *
1072 + * @deprecated 3.0
1386 1073 * @codeCoverageIgnore
1387 - *
1388 - * @param int|string $id
1389 - *
1390 - * @return string
1391 1074 */
1392 1075 public static function getKeyById( $id ) {
1393 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );
1394 - return self::get_key_by_id( $id );
1076 + return FrmFormDeprecated::getKeyById( $id );
1395 1077 }
1396 1078 }