PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.4.3
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.4.3
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +183 -473 6.305.4.3 View file →
@@ -6,10 +6,9 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 - * @return bool|int id on success or false on failure.
10 + * @return int|boolean id on success or false on failure
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
15 14
@@ -16,24 +15,24 @@
16 15 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
17 16
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ),
19 + 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 36 /**
38 37 * Allows modifying form options before updating or creating.
39 38 *
@@ -60,9 +59,8 @@
60 59 /**
61 60 * @since 5.0.08
62 61 *
63 62 * @param array $options
64 - *
65 63 * @return array
66 64 */
67 65 private static function maybe_filter_form_options( $options ) {
68 66 if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
@@ -71,22 +69,14 @@
71 69 return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 70 }
73 71
74 72 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 - * @return bool|int ID on success or false on failure
73 + * @return int|boolean ID on success or false on failure
83 74 */
84 75 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 76 global $wpdb;
86 77
87 78 $values = self::getOne( $id, $blog_id );
88 -
89 79 if ( ! $values ) {
90 80 return false;
91 81 }
92 82
@@ -103,10 +93,10 @@
103 93 'is_template' => $template ? 1 : 0,
104 94 );
105 95
106 96 if ( $blog_id ) {
107 - $new_values['status'] = 'published';
108 - $new_options = $values->options;
97 + $new_values['status'] = 'published';
98 + $new_options = $values->options;
109 99 FrmAppHelper::unserialize_or_decode( $new_options );
110 100 $new_options['email_to'] = get_option( 'admin_email' );
111 101 $new_options['copy'] = false;
112 102 $new_values['options'] = $new_options;
@@ -126,9 +116,9 @@
126 116
127 117 $form_id = $wpdb->insert_id;
128 118 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 119
130 - // Update form settings after fields are created
120 + // update form settings after fields are created
131 121 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 122
133 123 return $form_id;
134 124 }
@@ -135,16 +125,10 @@
135 125
136 126 return false;
137 127 }
138 128
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 129 public static function after_duplicate( $form_id, $values ) {
146 - $new_opts = $values['options'];
130 + $new_opts = $values['options'];
147 131 FrmAppHelper::unserialize_or_decode( $new_opts );
148 132 $values['options'] = $new_opts;
149 133
150 134 if ( isset( $new_opts['success_msg'] ) ) {
@@ -152,9 +136,8 @@
152 136 }
153 137
154 138 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 139
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 140 if ( $new_opts != $values['options'] ) {
158 141 global $wpdb;
159 142 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 143 }
@@ -167,10 +150,8 @@
167 150 *
168 151 * @since 5.3
169 152 *
170 153 * @param int $form_id Form ID.
171 - *
172 - * @return void
173 154 */
174 155 private static function switch_field_ids_in_fields( $form_id ) {
175 156 global $wpdb;
176 157
@@ -176,11 +157,10 @@
176 157
177 158 // Keys of fields that you want to check to replace field ID.
178 159 $keys = array( 'default_value', 'field_options' );
179 160 $sql_cols = 'fi.id';
180 -
181 161 foreach ( $keys as $key ) {
182 - $sql_cols .= ',fi.' . $key;
162 + $sql_cols .= ( ',fi.' . $key );
183 163 }
184 164
185 165 $fields = FrmDb::get_results(
186 166 "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id",
@@ -206,14 +186,11 @@
206 186 *
207 187 * @since 5.3
208 188 *
209 189 * @param array $field Field array.
210 - *
211 - * @return void
212 190 */
213 191 private static function switch_field_ids_in_field( $field ) {
214 192 $new_values = array();
215 -
216 193 foreach ( $field as $key => $value ) {
217 194 if ( 'id' === $key || ! $value ) {
218 195 continue;
219 196 }
@@ -233,23 +210,17 @@
233 210
234 211 if ( $new_val !== $value ) {
235 212 $new_values[ $key ] = $new_val;
236 213 }
237 - }//end foreach
214 + }
238 215
239 - if ( $new_values ) {
216 + if ( ! empty( $new_values ) ) {
240 217 FrmField::update( $field['id'], $new_values );
241 218 }
242 219 }
243 220
244 221 /**
245 - * Update a form.
246 - *
247 - * @param int $id Form ID.
248 - * @param array $values Form values to update.
249 - * @param bool $create_link Whether this is being called from link creation.
250 - *
251 - * @return bool|int
222 + * @return int|boolean
252 223 */
253 224 public static function update( $id, $values, $create_link = false ) {
254 225 global $wpdb;
255 226
@@ -263,23 +234,23 @@
263 234 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
264 235 }
265 236
266 237 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
267 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
268 238
239 + $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
240 +
269 241 foreach ( $values as $value_key => $value ) {
270 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
271 - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value;
242 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
243 + $new_values[ $value_key ] = $value;
272 244 }
273 245 }
274 246
275 - if ( ! empty( $values['new_status'] ) ) {
247 + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) {
276 248 $new_values['status'] = $values['new_status'];
277 249 }
278 250
279 - if ( $new_values ) {
251 + if ( ! empty( $new_values ) ) {
280 252 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
281 -
282 253 if ( $query_results ) {
283 254 self::clear_form_cache();
284 255 }
285 256 } else {
@@ -298,9 +269,8 @@
298 269 /**
299 270 * @param array $new_values
300 271 * @param array $values
301 272 * @param array $args
302 - *
303 273 * @return array
304 274 */
305 275 public static function set_update_options( $new_values, $values, $args = array() ) {
306 276 if ( ! isset( $values['options'] ) ) {
@@ -306,16 +276,21 @@
306 276 if ( ! isset( $values['options'] ) ) {
307 277 return $new_values;
308 278 }
309 279
310 - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
280 + $options = isset( $values['options'] ) ? (array) $values['options'] : array();
311 281 FrmFormsHelper::fill_form_options( $options, $values );
312 282
313 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
314 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
315 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
316 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
283 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
284 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
285 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
286 + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
317 287
288 + if ( ! empty( $options['success_url'] ) && ! empty( $args['form_id'] ) ) {
289 + $options['success_url'] = FrmFormsHelper::maybe_add_sanitize_url_attr( $options['success_url'], (int) $args['form_id'] );
290 + $values['options']['success_url'] = $options['success_url'];
291 + }
292 +
318 293 /**
319 294 * Allows modifying form options before updating or creating.
320 295 *
321 296 * @since 5.4 Added the third param.
@@ -331,14 +306,11 @@
331 306 return $new_values;
332 307 }
333 308
334 309 /**
335 - * @param int $id Form ID.
336 - * @param array $values Form values array.
337 - *
338 310 * @return array
339 311 */
340 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
312 + public static function update_fields( $id, $values ) {
341 313
342 314 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
343 315 return $values;
344 316 }
@@ -343,10 +315,9 @@
343 315 return $values;
344 316 }
345 317
346 318 $all_fields = FrmField::get_all_for_form( $id );
347 -
348 - if ( ! $all_fields ) {
319 + if ( empty( $all_fields ) ) {
349 320 return $values;
350 321 }
351 322
352 323 if ( ! isset( $values['item_meta'] ) ) {
@@ -354,28 +325,28 @@
354 325 }
355 326
356 327 $field_array = array();
357 328 $existing_keys = array_keys( $values['item_meta'] );
358 -
359 329 foreach ( $all_fields as $fid ) {
360 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
361 330 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
362 331 $values['item_meta'][ $fid->id ] = '';
363 332 }
364 -
365 333 $field_array[ $fid->id ] = $fid;
366 334 }
367 335 unset( $all_fields );
368 336
369 337 foreach ( $values['item_meta'] as $field_id => $default_value ) {
370 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
338 + if ( isset( $field_array[ $field_id ] ) ) {
339 + $field = $field_array[ $field_id ];
340 + } else {
341 + $field = FrmField::getOne( $field_id );
342 + }
371 343
372 344 if ( ! $field ) {
373 345 continue;
374 346 }
375 347
376 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
377 -
348 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
378 349 if ( $is_settings_page ) {
379 350 self::get_settings_page_html( $values, $field );
380 351
381 352 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -382,20 +353,15 @@
382 353 continue;
383 354 }
384 355 }
385 356
386 - // Updating the form.
357 + //updating the form
387 358 $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field );
388 - // Don't check for POST html.
389 - unset( $update_options['custom_html'] );
359 + unset( $update_options['custom_html'] ); // don't check for POST html
390 360 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
391 361
392 - if ( ! is_array( $field->field_options ) ) {
393 - $field->field_options = array();
394 - }
395 -
396 362 foreach ( $update_options as $opt => $default ) {
397 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
363 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
398 364 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
399 365 }
400 366
401 367 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -404,104 +370,44 @@
404 370 'field_options' => $field->field_options,
405 371 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
406 372 );
407 373
408 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
409 - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
410 - if ( ! is_array( $option ) ) {
411 - continue;
412 - }
413 -
414 - foreach ( $option as $key => $item ) {
415 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
416 - }
417 - }
418 - }
419 -
420 374 self::prepare_field_update_values( $field, $values, $new_field );
421 - self::maybe_update_max_option( $field, $values, $new_field );
422 375
423 376 FrmField::update( $field_id, $new_field );
424 377
425 378 FrmField::delete_form_transient( $field->form_id );
426 - }//end foreach
379 + }
427 380 self::clear_form_cache();
428 381
429 382 return $values;
430 383 }
431 384
432 - /**
433 - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
434 - *
435 - * @since 6.7
436 - *
437 - * @param object $field
438 - * @param array $values
439 - * @param array $new_field
440 - *
441 - * @return void
442 - */
443 - private static function maybe_update_max_option( $field, $values, &$new_field ) {
444 - if ( $field->type !== 'textarea' ||
445 - empty( $values['field_options'][ 'type_' . $field->id ] ) ||
446 - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
447 - return;
448 - }
449 -
450 - $new_field['field_options']['max'] = '';
451 -
452 - /**
453 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
454 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
455 - */
456 - $_POST['field_options'][ 'max_' . $field->id ] = '';
457 - }
458 -
459 - /**
460 - * @param string $opt
461 - * @param mixed $value
462 - *
463 - * @return void
464 - */
465 385 private static function sanitize_field_opt( $opt, &$value ) {
466 - if ( ! is_string( $value ) ) {
467 - return;
386 + if ( is_string( $value ) ) {
387 + if ( $opt === 'calc' ) {
388 + $value = self::sanitize_calc( $value );
389 + } else {
390 + $value = FrmAppHelper::kses( $value, 'all' );
391 + }
392 + $value = trim( $value );
468 393 }
469 -
470 - /**
471 - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead.
472 - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized.
473 - *
474 - * @since 6.0
475 - *
476 - * @param bool $should_sanitize
477 - * @param string $opt
478 - */
479 - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt );
480 -
481 - if ( ! $should_sanitize ) {
482 - return;
483 - }
484 -
485 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
486 - $value = trim( $value );
487 394 }
488 395
489 396 /**
490 397 * @param string $value
491 - *
492 398 * @return string
493 399 */
494 400 private static function sanitize_calc( $value ) {
495 - if ( str_contains( $value, '<' ) ) {
401 + if ( false !== strpos( $value, '<' ) ) {
496 402 $value = self::normalize_calc_spaces( $value );
497 403 }
498 - // Allow <= and >=.
499 - $allow = array( '<= ', ' >=' );
404 + $allow = array( '<= ', ' >=' ); // Allow <= and >=
500 405 $temp = array( '< = ', ' > =' );
501 406 $value = str_replace( $allow, $temp, $value );
502 407 $value = strip_tags( $value );
503 - return str_replace( $temp, $allow, $value );
408 + $value = str_replace( $temp, $allow, $value );
409 + return $value;
504 410 }
505 411
506 412 /**
507 413 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -507,58 +413,41 @@
507 413 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
508 414 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
509 415 *
510 416 * @param string $calc
511 - *
512 417 * @return string
513 418 */
514 419 private static function normalize_calc_spaces( $calc ) {
515 420 // Check for a pattern with 5 parts
516 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
421 + // $1 \d the first comparison digit.
517 422 // $2 a space (optional).
518 423 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
519 424 // $4 another space (optional).
520 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
521 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
425 + // $5 \d the second comparison digit.
426 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
522 427 }
523 428
524 429 /**
525 430 * Updating the settings page
526 - *
527 - * @param array $values Form values array.
528 - * @param object $field Field object, passed by reference.
529 - *
530 - * @return void
531 431 */
532 432 private static function get_settings_page_html( $values, &$field ) {
533 433 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
534 434 $prev_opts = array();
535 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
435 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
536 436
537 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
538 - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
437 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
438 + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
539 439 $prev_opts = $field->field_options;
540 440 }
541 441
542 - if ( ! isset( $prev_opts ) ) {
543 - return;
442 + if ( isset( $prev_opts ) ) {
443 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
444 + if ( $prev_opts != $field->field_options ) {
445 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
446 + }
544 447 }
545 -
546 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
547 -
548 - // phpcs:ignore Universal.Operators.StrictComparisons
549 - if ( $prev_opts != $field->field_options ) {
550 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
551 - }
552 448 }
553 449
554 - /**
555 - * @param object $field
556 - * @param array $values
557 - * @param array $new_field
558 - *
559 - * @return void
560 - */
561 450 private static function prepare_field_update_values( $field, $values, &$new_field ) {
562 451 $field_cols = array(
563 452 'field_order' => 0,
564 453 'field_key' => '',
@@ -567,16 +456,12 @@
567 456 'description' => '',
568 457 'options' => '',
569 458 'name' => '',
570 459 );
571 -
572 460 foreach ( $field_cols as $col => $default ) {
573 - $default = $default === '' ? $field->{$col} : $default;
574 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
575 - }
461 + $default = ( $default === '' ) ? $field->{$col} : $default;
576 462
577 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
578 - $new_field['field_order'] = $field->field_order;
463 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
579 464 }
580 465
581 466 // Don't save the template option.
582 467 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -588,12 +473,9 @@
588 473 * Get a list of all form settings that should be translated
589 474 * on a multilingual site.
590 475 *
591 476 * @since 3.06.01
592 - *
593 - * @param object $form The form object.
594 - *
595 - * @return array
477 + * @param object $form - The form object
596 478 */
597 479 public static function translatable_strings( $form ) {
598 480 $strings = array(
599 481 'name',
@@ -610,21 +492,19 @@
610 492 return apply_filters( 'frm_form_strings', $strings, $form );
611 493 }
612 494
613 495 /**
614 - * @param array|int $id
615 - * @param string $status
496 + * @param string $status
616 497 *
617 - * @return bool|int
498 + * @return int|boolean
618 499 */
619 500 public static function set_status( $id, $status ) {
620 - if ( 'trash' === $status ) {
501 + if ( 'trash' == $status ) {
621 502 return self::trash( $id );
622 503 }
623 504
624 505 $statuses = array( 'published', 'draft', 'trash' );
625 -
626 - if ( ! in_array( $status, $statuses, true ) ) {
506 + if ( ! in_array( $status, $statuses ) ) {
627 507 return false;
628 508 }
629 509
630 510 global $wpdb;
@@ -637,9 +517,9 @@
637 517 );
638 518 FrmDb::get_where_clause_and_values( $where );
639 519 array_unshift( $where['values'], $status );
640 520
641 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
521 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
642 522 } else {
643 523 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
644 524 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
645 525 }
@@ -651,11 +531,9 @@
651 531 return $query_results;
652 532 }
653 533
654 534 /**
655 - * @param int|string $id Form ID.
656 - *
657 - * @return bool|int
535 + * @return int|boolean
658 536 */
659 537 public static function trash( $id ) {
660 538 if ( ! EMPTY_TRASH_DAYS ) {
661 539 return self::destroy( $id );
@@ -661,17 +539,12 @@
661 539 return self::destroy( $id );
662 540 }
663 541
664 542 $form = self::getOne( $id );
665 -
666 543 if ( ! $form ) {
667 544 return false;
668 545 }
669 546
670 - if ( $form->status === 'trash' ) {
671 - return false;
672 - }
673 -
674 547 $options = $form->options;
675 548 $options['trash_time'] = time();
676 549
677 550 global $wpdb;
@@ -704,26 +577,21 @@
704 577 return $query_results;
705 578 }
706 579
707 580 /**
708 - * @param int|string $id Form ID.
709 - *
710 - * @return bool|int
581 + * @return int|boolean
711 582 */
712 583 public static function destroy( $id ) {
713 584 global $wpdb;
714 585
715 586 $form = self::getOne( $id );
716 -
717 587 if ( ! $form ) {
718 588 return false;
719 589 }
720 -
721 590 $id = $form->id;
722 591
723 592 // Disconnect the entries from this form
724 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
725 -
593 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
726 594 foreach ( $entries as $entry_id ) {
727 595 FrmEntry::destroy( $entry_id );
728 596 unset( $entry_id );
729 597 }
@@ -728,29 +596,23 @@
728 596 unset( $entry_id );
729 597 }
730 598
731 599 // Disconnect the fields from this form
732 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
600 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
733 601
734 602 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
603 + if ( $query_results ) {
604 + // Delete all form actions linked to this form
605 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
606 + $action_control->destroy( $id, 'all' );
735 607
736 - if ( ! $query_results ) {
737 - return $query_results;
608 + // Clear form caching
609 + self::clear_form_cache();
610 +
611 + do_action( 'frm_destroy_form', $id );
612 + do_action( 'frm_destroy_form_' . $id );
738 613 }
739 614
740 - // Delete all form actions linked to this form
741 - /**
742 - * @var FrmFormAction
743 - */
744 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
745 - $action_control->destroy( $id, 'all' );
746 -
747 - // Clear form caching
748 - self::clear_form_cache();
749 -
750 - do_action( 'frm_destroy_form', $id );
751 - do_action( 'frm_destroy_form_' . $id );
752 -
753 615 return $query_results;
754 616 }
755 617
756 618 /**
@@ -755,34 +617,29 @@
755 617
756 618 /**
757 619 * Delete trashed forms based on how long they have been trashed
758 620 *
759 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
760 - *
761 621 * @return int The number of forms deleted
762 622 */
763 623 public static function scheduled_delete( $delete_timestamp = '' ) {
764 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
624 + global $wpdb;
765 625
626 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' );
627 +
766 628 if ( ! $trash_forms ) {
767 629 return 0;
768 630 }
769 631
770 - if ( ! $delete_timestamp ) {
632 + if ( empty( $delete_timestamp ) ) {
771 633 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
772 634 }
773 635
774 636 $count = 0;
775 -
776 637 foreach ( $trash_forms as $form ) {
777 638 FrmAppHelper::unserialize_or_decode( $form->options );
778 -
779 639 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
780 640 self::destroy( $form->id );
781 -
782 - if ( empty( $form->parent_form_id ) ) {
783 - ++$count;
784 - }
641 + $count ++;
785 642 }
786 643
787 644 unset( $form );
788 645 }
@@ -790,24 +647,23 @@
790 647 return $count;
791 648 }
792 649
793 650 /**
794 - * @param int|string $id Form ID or key.
795 - *
796 651 * @return string form name
797 652 */
798 653 public static function getName( $id ) {
799 654 $form = FrmDb::check_cache( $id, 'frm_form' );
655 + if ( $form ) {
656 + $r = stripslashes( $form->name );
800 657
801 - if ( $form ) {
802 - return stripslashes( $form->name );
658 + return $r;
803 659 }
804 660
805 661 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
806 662 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
663 + $r = stripslashes( $r );
807 664
808 - // An empty form name can result in a null value.
809 - return is_null( $r ) ? '' : stripslashes( $r );
665 + return $r;
810 666 }
811 667
812 668 /**
813 669 * @since 3.0
@@ -822,9 +678,9 @@
822 678
823 679 /**
824 680 * @since 3.0
825 681 *
826 - * @param int|string $id
682 + * @param int $id
827 683 *
828 684 * @return string form key
829 685 */
830 686 public static function get_key_by_id( $id ) {
@@ -829,57 +685,59 @@
829 685 */
830 686 public static function get_key_by_id( $id ) {
831 687 $id = (int) $id;
832 688 $cache = FrmDb::check_cache( $id, 'frm_form' );
833 -
834 689 if ( $cache ) {
835 690 return $cache->form_key;
836 691 }
837 692
838 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
693 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
694 +
695 + return $key;
839 696 }
840 697
841 698 /**
842 699 * If $form is numeric, get the form object
843 700 *
701 + * @param object|int $form
702 + *
844 703 * @since 2.0.9
845 - *
846 - * @param array|int|object $form
847 - *
848 - * @return void
849 704 */
850 705 public static function maybe_get_form( &$form ) {
851 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
706 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
852 707 $form = self::getOne( $form );
853 708 }
854 709 }
855 710
856 711 /**
857 - * @param int|string $id
858 - * @param false|int $blog_id
859 - *
860 - * @return stdClass|null
712 + * @return object form
861 713 */
862 714 public static function getOne( $id, $blog_id = false ) {
863 715 global $wpdb;
864 716
865 717 if ( $blog_id && is_multisite() ) {
866 - $prefix = $wpdb->get_blog_prefix( $blog_id );
718 + global $wpmuBaseTablePrefix;
719 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
720 +
867 721 $table_name = $prefix . 'frm_forms';
868 722 } else {
869 723 $table_name = $wpdb->prefix . 'frm_forms';
870 724 $cache = wp_cache_get( $id, 'frm_form' );
871 -
872 725 if ( $cache ) {
873 726 if ( isset( $cache->options ) ) {
874 727 FrmAppHelper::unserialize_or_decode( $cache->options );
875 728 }
876 729
877 - return self::prepare_form_row_data( $cache );
730 + return wp_unslash( $cache );
878 731 }
879 732 }
880 733
881 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
734 + if ( is_numeric( $id ) ) {
735 + $where = array( 'id' => $id );
736 + } else {
737 + $where = array( 'form_key' => $id );
738 + }
739 +
882 740 $results = FrmDb::get_row( $table_name, $where );
883 741
884 742 if ( isset( $results->options ) ) {
885 743 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -885,50 +743,18 @@
885 743 FrmDb::set_cache( $results->id, $results, 'frm_form' );
886 744 FrmAppHelper::unserialize_or_decode( $results->options );
887 745 }
888 746
889 - return self::prepare_form_row_data( $results );
747 + return apply_filters( 'frm_form_object', wp_unslash( $results ) );
890 748 }
891 749
892 750 /**
893 - * Make sure that if $row is an object, that $row->options is an array and not a string.
894 - *
895 - * @since 6.8.3
896 - *
897 - * @param stdClass|null $row The database row for a target form.
898 - *
899 - * @return stdClass|null
751 + * @return object|array of objects
900 752 */
901 - private static function prepare_form_row_data( $row ) {
902 - $row = wp_unslash( $row );
903 -
904 - if ( ! is_object( $row ) ) {
905 - return $row;
906 - }
907 -
908 - if ( ! is_array( $row->options ) ) {
909 - $row->options = FrmFormsHelper::get_default_opts();
910 - }
911 -
912 - /**
913 - * @since 4.03.02
914 - *
915 - * @param stdClass $row
916 - */
917 - return apply_filters( 'frm_form_object', $row );
918 - }
919 -
920 - /**
921 - * @param array|string $where Where conditions array or raw WHERE string.
922 - * @param string $order_by Order by clause.
923 - * @param int|string $limit Limit clause or number.
924 - *
925 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
926 - */
927 753 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
928 - if ( is_array( $where ) && $where ) {
929 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
930 - // Don't get trashed templates
754 + if ( is_array( $where ) && ! empty( $where ) ) {
755 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
756 + // don't get trashed templates
931 757 $where['status'] = array( null, '', 'published' );
932 758 }
933 759
934 760 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -934,10 +760,10 @@
934 760 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
935 761 } else {
936 762 global $wpdb;
937 763
938 - // The query has already been prepared if this is not an array.
939 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
764 + // the query has already been prepared if this is not an array
765 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
940 766 $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
941 767 }
942 768
943 769 if ( $results ) {
@@ -946,10 +772,10 @@
946 772 FrmAppHelper::unserialize_or_decode( $result->options );
947 773 }
948 774 }
949 775
950 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
951 - // Return the first form object if we are only getting one form
776 + if ( $limit == ' LIMIT 1' || $limit == 1 ) {
777 + // return the first form object if we are only getting one form
952 778 $results = reset( $results );
953 779 }
954 780
955 781 return wp_unslash( $results );
@@ -958,24 +784,20 @@
958 784 /**
959 785 * Get all published forms
960 786 *
961 787 * @since 2.0
962 - *
963 - * @param array $query
964 - * @param int $limit
965 - * @param string $inc_children
966 - *
967 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
788 + * @return array of forms
968 789 */
969 790 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
970 791 $query['is_template'] = 0;
971 792 $query['status'] = array( null, '', 'published' );
972 -
973 - if ( $inc_children === 'exclude' ) {
793 + if ( $inc_children == 'exclude' ) {
974 794 $query['parent_form_id'] = array( null, 0 );
975 795 }
976 796
977 - return self::getAll( $query, 'name', $limit );
797 + $forms = self::getAll( $query, 'name', $limit );
798 +
799 + return $forms;
978 800 }
979 801
980 802 /**
981 803 * @return object count of forms
@@ -980,16 +802,18 @@
980 802 /**
981 803 * @return object count of forms
982 804 */
983 805 public static function get_count() {
806 + global $wpdb;
807 +
984 808 $cache_key = 'frm_form_counts';
985 - $counts = wp_cache_get( $cache_key, 'frm_form' );
986 809
810 + $counts = wp_cache_get( $cache_key, 'frm_form' );
987 811 if ( false !== $counts ) {
988 812 return $counts;
989 813 }
990 814
991 - $results = FrmDb::get_results(
815 + $results = (array) FrmDb::get_results(
992 816 'frm_forms',
993 817 array(
994 818 'or' => 1,
995 819 'parent_form_id' => null,
@@ -1001,18 +825,20 @@
1001 825 $statuses = array( 'published', 'draft', 'template', 'trash' );
1002 826 $counts = array_fill_keys( $statuses, 0 );
1003 827
1004 828 foreach ( $results as $row ) {
1005 - if ( 'trash' === $row->status ) {
1006 - ++$counts['trash'];
1007 - } elseif ( $row->is_template ) {
1008 - ++$counts['template'];
829 + if ( 'trash' != $row->status ) {
830 + if ( $row->is_template ) {
831 + $counts['template'] ++;
832 + } else {
833 + $counts['published'] ++;
834 + }
1009 835 } else {
1010 - ++$counts['published'];
836 + $counts['trash'] ++;
1011 837 }
1012 838
1013 - if ( 'draft' === $row->status ) {
1014 - ++$counts['draft'];
839 + if ( 'draft' == $row->status ) {
840 + $counts['draft'] ++;
1015 841 }
1016 842
1017 843 unset( $row );
1018 844 }
@@ -1028,10 +854,8 @@
1028 854 * Called when a form is created, updated, duplicated, or deleted
1029 855 * or when the form status is changed
1030 856 *
1031 857 * @since 2.0.4
1032 - *
1033 - * @return void
1034 858 */
1035 859 public static function clear_form_cache() {
1036 860 FrmDb::cache_delete_group( 'frm_form' );
1037 861 }
@@ -1036,29 +860,23 @@
1036 860 FrmDb::cache_delete_group( 'frm_form' );
1037 861 }
1038 862
1039 863 /**
1040 - * @param array $values Form values to validate.
1041 - *
1042 864 * @return array of errors
1043 865 */
1044 866 public static function validate( $values ) {
1045 867 $errors = array();
868 +
1046 869 return apply_filters( 'frm_validate_form', $errors, $values );
1047 870 }
1048 871
1049 - /**
1050 - * @param object|null $form
1051 - *
1052 - * @return array
1053 - */
1054 872 public static function get_params( $form = null ) {
1055 873 global $frm_vars;
1056 874
1057 - if ( $form ) {
875 + if ( ! $form ) {
876 + $form = self::getAll( array(), 'name', 1 );
877 + } else {
1058 878 self::maybe_get_form( $form );
1059 - } else {
1060 - $form = self::getAll( array(), 'name', 1 );
1061 879 }
1062 880
1063 881 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1064 882 return $frm_vars['form_params'][ $form->id ];
@@ -1081,18 +899,16 @@
1081 899 );
1082 900
1083 901 $values = array();
1084 902 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1085 -
1086 903 if ( ! $values['posted_form_id'] ) {
1087 904 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1088 905 }
1089 906
1090 - // phpcs:ignore Universal.Operators.StrictComparisons
1091 907 if ( $form->id == $values['posted_form_id'] ) {
1092 - // If there are two forms on the same page, make sure not to submit both.
908 + //if there are two forms on the same page, make sure not to submit both
1093 909 foreach ( $default_values as $var => $default ) {
1094 - if ( $var === 'action' ) {
910 + if ( $var == 'action' ) {
1095 911 $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1096 912 } else {
1097 913 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1098 914 }
@@ -1104,9 +920,9 @@
1104 920 unset( $var, $default );
1105 921 }
1106 922 }
1107 923
1108 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
924 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
1109 925 ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
1110 926 ) {
1111 927 $values['action'] = 'new';
1112 928 }
@@ -1113,11 +929,8 @@
1113 929
1114 930 return $values;
1115 931 }
1116 932
1117 - /**
1118 - * @return array
1119 - */
1120 933 public static function list_page_params() {
1121 934 $values = array();
1122 935 $defaults = array(
1123 936 'template' => 0,
@@ -1127,9 +940,8 @@
1127 940 'search' => '',
1128 941 'sort' => '',
1129 942 'sdir' => '',
1130 943 );
1131 -
1132 944 foreach ( $defaults as $var => $default ) {
1133 945 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1134 946 }
1135 947
@@ -1135,16 +947,10 @@
1135 947
1136 948 return $values;
1137 949 }
1138 950
1139 - /**
1140 - * @param int|object|string|null $form
1141 - *
1142 - * @return array
1143 - */
1144 951 public static function get_admin_params( $form = null ) {
1145 952 $form_id = $form;
1146 -
1147 953 if ( $form === null ) {
1148 954 $form_id = self::get_current_form_id();
1149 955 } elseif ( $form && is_object( $form ) ) {
1150 956 $form_id = $form->id;
@@ -1162,9 +968,8 @@
1162 968 'sdir' => '',
1163 969 'fid' => '',
1164 970 'keep_post' => '',
1165 971 );
1166 -
1167 972 foreach ( $defaults as $var => $default ) {
1168 973 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1169 974 }
1170 975
@@ -1170,55 +975,47 @@
1170 975
1171 976 return $values;
1172 977 }
1173 978
1174 - /**
1175 - * @param string $default_form
1176 - *
1177 - * @return int|string
1178 - */
1179 979 public static function get_current_form_id( $default_form = 'none' ) {
1180 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1181 - return $form ? $form->id : 0;
980 + if ( 'first' == $default_form ) {
981 + $form = self::get_current_form();
982 + } else {
983 + $form = self::maybe_get_current_form();
984 + }
985 + $form_id = $form ? $form->id : 0;
986 +
987 + return $form_id;
1182 988 }
1183 989
1184 - /**
1185 - * @param int|string $form_id
1186 - *
1187 - * @return false|int|object|string
1188 - */
1189 990 public static function maybe_get_current_form( $form_id = 0 ) {
1190 991 global $frm_vars;
1191 992
1192 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
993 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1193 994 return $frm_vars['current_form'];
1194 995 }
1195 996
1196 997 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
998 + if ( $form_id ) {
999 + $form_id = self::set_current_form( $form_id );
1000 + }
1197 1001
1198 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
1002 + return $form_id;
1199 1003 }
1200 1004
1201 - /**
1202 - * @param int $form_id
1203 - *
1204 - * @return false|object
1205 - */
1206 1005 public static function get_current_form( $form_id = 0 ) {
1207 1006 $form = self::maybe_get_current_form( $form_id );
1208 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
1007 + if ( is_numeric( $form ) ) {
1008 + $form = self::set_current_form( $form );
1009 + }
1010 +
1011 + return $form;
1209 1012 }
1210 1013
1211 - /**
1212 - * @param int $form_id
1213 - *
1214 - * @return false|object
1215 - */
1216 1014 public static function set_current_form( $form_id ) {
1217 1015 global $frm_vars;
1218 1016
1219 1017 $query = array();
1220 -
1221 1018 if ( $form_id ) {
1222 1019 $query['id'] = $form_id;
1223 1020 }
1224 1021
@@ -1226,19 +1023,11 @@
1226 1023
1227 1024 return $frm_vars['current_form'];
1228 1025 }
1229 1026
1230 - /**
1231 - * @param object $form
1232 - * @param int|string $this_load
1233 - * @param bool $global_load
1234 - *
1235 - * @return bool
1236 - */
1237 1027 public static function is_form_loaded( $form, $this_load, $global_load ) {
1238 1028 global $frm_vars;
1239 1029 $small_form = new stdClass();
1240 -
1241 1030 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1242 1031 $small_form->{$var} = $form->{$var};
1243 1032 unset( $var );
1244 1033 }
@@ -1244,14 +1033,14 @@
1244 1033 }
1245 1034
1246 1035 $frm_vars['forms_loaded'][] = $small_form;
1247 1036
1248 - if ( $this_load && ! $global_load ) {
1037 + if ( $this_load && empty( $global_load ) ) {
1249 1038 $global_load = true;
1250 1039 $frm_vars['load_css'] = true;
1251 1040 }
1252 1041
1253 - return empty( $frm_vars['css_loaded'] ) && $global_load;
1042 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1254 1043 }
1255 1044
1256 1045 /**
1257 1046 * @since 4.06.03
@@ -1259,9 +1048,9 @@
1259 1048 * @param object $form
1260 1049 *
1261 1050 * @return bool
1262 1051 */
1263 - public static function is_visible_to_user( $form ) {
1052 + public static function &is_visible_to_user( $form ) {
1264 1053 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1265 1054 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1266 1055 } else {
1267 1056 $visible = true;
@@ -1266,39 +1055,26 @@
1266 1055 } else {
1267 1056 $visible = true;
1268 1057 }
1269 1058
1270 - /**
1271 - * @since 6.25
1272 - *
1273 - * @param bool $visible
1274 - * @param object $form
1275 - */
1276 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
1059 + return $visible;
1277 1060 }
1278 1061
1279 - /**
1280 - * @param object $form
1281 - *
1282 - * @return bool
1283 - */
1284 1062 public static function show_submit( $form ) {
1285 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1286 - return apply_filters( 'frm_show_submit_button', $show, $form );
1063 + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() );
1064 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
1065 +
1066 + return $show;
1287 1067 }
1288 1068
1289 1069 /**
1290 1070 * @since 2.3
1291 - *
1292 - * @param array $atts Attributes including form, option, and default.
1293 - *
1294 - * @return mixed
1295 1071 */
1296 1072 public static function get_option( $atts ) {
1297 - $form = $atts['form'];
1298 - $default = $atts['default'] ?? '';
1073 + $form = $atts['form'];
1074 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1299 1075
1300 - return $form->options[ $atts['option'] ] ?? $default;
1076 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1301 1077 }
1302 1078
1303 1079 /**
1304 1080 * Get the link to edit this form.
@@ -1303,12 +1079,9 @@
1303 1079 /**
1304 1080 * Get the link to edit this form.
1305 1081 *
1306 1082 * @since 4.0
1307 - *
1308 1083 * @param int $form_id The id of the form.
1309 - *
1310 - * @return string
1311 1084 */
1312 1085 public static function get_edit_link( $form_id ) {
1313 1086 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1314 1087 }
@@ -1313,65 +1086,9 @@
1313 1086 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1314 1087 }
1315 1088
1316 1089 /**
1317 - * Check if the "Submit this form with AJAX" setting is toggled on.
1318 - *
1319 - * @since 6.2
1320 - *
1321 - * @param stdClass $form
1322 - *
1323 - * @return bool
1324 - */
1325 - public static function is_ajax_on( $form ) {
1326 - return ! empty( $form->options['ajax_submit'] );
1327 - }
1328 -
1329 - /**
1330 - * Get the latest form available.
1331 - *
1332 - * @since 6.8
1333 - *
1334 - * @return object
1335 - */
1336 - public static function get_latest_form() {
1337 - $args = array(
1338 - array(
1339 - 'or' => 1,
1340 - 'parent_form_id' => null,
1341 - 'parent_form_id <' => 1,
1342 - ),
1343 - 'is_template' => 0,
1344 - 'status !' => 'trash',
1345 - );
1346 -
1347 - return self::getAll( $args, 'created_at desc', 1 );
1348 - }
1349 -
1350 - /**
1351 - * Count and return total forms.
1352 - *
1353 - * @since 6.8
1354 - *
1355 - * @return int
1356 - */
1357 - public static function get_forms_count() {
1358 - $args = array(
1359 - array(
1360 - 'or' => 1,
1361 - 'parent_form_id' => null,
1362 - 'parent_form_id <' => 1,
1363 - ),
1364 - 'is_template' => 0,
1365 - 'status !' => 'trash',
1366 - );
1367 -
1368 - return FrmDb::get_count( 'frm_forms', $args );
1369 - }
1370 -
1371 - /**
1372 - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1373 - *
1090 + * @deprecated 3.0
1374 1091 * @codeCoverageIgnore
1375 1092 *
1376 1093 * @param string $key
1377 1094 *
@@ -1377,22 +1094,15 @@
1377 1094 *
1378 1095 * @return int form id
1379 1096 */
1380 1097 public static function getIdByKey( $key ) {
1381 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
1382 - return self::get_id_by_key( $key );
1098 + return FrmFormDeprecated::getIdByKey( $key );
1383 1099 }
1384 1100
1385 1101 /**
1386 - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1387 - *
1102 + * @deprecated 3.0
1388 1103 * @codeCoverageIgnore
1389 - *
1390 - * @param int|string $id
1391 - *
1392 - * @return string
1393 1104 */
1394 1105 public static function getKeyById( $id ) {
1395 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );
1396 - return self::get_key_by_id( $id );
1106 + return FrmFormDeprecated::getKeyById( $id );
1397 1107 }
1398 1108 }