| @@ -3,27 +3,11 @@ | ||
| 3 | 3 | die( 'You are not allowed to call this page directly.' ); |
| 4 | 4 | } |
| 5 | 5 | |
| 6 | 6 | class FrmMigrate { |
| 7 | - | |
| 8 | - /** | |
| 9 | - * @var string | |
| 10 | - */ | |
| 11 | 7 | public $fields; |
| 12 | - | |
| 13 | - /** | |
| 14 | - * @var string | |
| 15 | - */ | |
| 16 | 8 | public $forms; |
| 17 | - | |
| 18 | - /** | |
| 19 | - * @var string | |
| 20 | - */ | |
| 21 | 9 | public $entries; |
| 22 | - | |
| 23 | - /** | |
| 24 | - * @var string | |
| 25 | - */ | |
| 26 | 10 | public $entry_metas; |
| 27 | 11 | |
| 28 | 12 | public function __construct() { |
| 29 | 13 | global $wpdb; |
| @@ -32,11 +16,8 @@ | ||
| 32 | 16 | $this->entries = $wpdb->prefix . 'frm_items'; |
| 33 | 17 | $this->entry_metas = $wpdb->prefix . 'frm_item_metas'; |
| 34 | 18 | } |
| 35 | 19 | |
| 36 | - /** | |
| 37 | - * @return void | |
| 38 | - */ | |
| 39 | 20 | public function upgrade() { |
| 40 | 21 | do_action( 'frm_before_install' ); |
| 41 | 22 | |
| 42 | 23 | global $wpdb, $frm_vars; |
| @@ -51,34 +32,25 @@ | ||
| 51 | 32 | ) |
| 52 | 33 | ); |
| 53 | 34 | |
| 54 | 35 | if ( $needs_upgrade ) { |
| 55 | - $this->maybe_delete_htaccess_file(); | |
| 56 | - | |
| 57 | - // Update rewrite rules for views and other custom post types | |
| 36 | + // update rewrite rules for views and other custom post types | |
| 58 | 37 | flush_rewrite_rules(); |
| 59 | 38 | |
| 60 | - require_once ABSPATH . 'wp-admin/includes/upgrade.php'; | |
| 39 | + require_once( ABSPATH . 'wp-admin/includes/upgrade.php' ); | |
| 61 | 40 | |
| 62 | 41 | $old_db_version = get_option( 'frm_db_version' ); |
| 63 | 42 | |
| 64 | 43 | $this->create_tables(); |
| 65 | 44 | $this->migrate_data( $old_db_version ); |
| 66 | - $this->check_that_tables_exist(); | |
| 67 | 45 | |
| 68 | - // SAVE DB VERSION. | |
| 46 | + /***** SAVE DB VERSION *****/ | |
| 69 | 47 | update_option( 'frm_db_version', FrmAppHelper::plugin_version() . '-' . FrmAppHelper::$db_version ); |
| 70 | 48 | |
| 71 | 49 | if ( ! $old_db_version ) { |
| 72 | 50 | $this->maybe_create_contact_form(); |
| 73 | - | |
| 74 | - if ( false === get_option( 'frm_first_activation' ) ) { | |
| 75 | - update_option( 'frm_first_activation', time(), false ); | |
| 76 | - } | |
| 77 | - | |
| 78 | - $this->update_settings_for_new_install(); | |
| 79 | 51 | } |
| 80 | - }//end if | |
| 52 | + } | |
| 81 | 53 | |
| 82 | 54 | do_action( 'frm_after_install' ); |
| 83 | 55 | |
| 84 | 56 | $frm_vars['doing_upgrade'] = false; |
| @@ -84,97 +56,24 @@ | ||
| 84 | 56 | $frm_vars['doing_upgrade'] = false; |
| 85 | 57 | |
| 86 | 58 | FrmAppHelper::save_combined_js(); |
| 87 | 59 | |
| 88 | - // Update the styling settings | |
| 89 | - if ( ! function_exists( 'get_filesystem_method' ) ) { | |
| 90 | - return; | |
| 60 | + // update the styling settings | |
| 61 | + if ( function_exists( 'get_filesystem_method' ) ) { | |
| 62 | + $frm_style = new FrmStyle(); | |
| 63 | + $frm_style->update( 'default' ); | |
| 91 | 64 | } |
| 92 | - | |
| 93 | - $frm_style = new FrmStyle(); | |
| 94 | - $frm_style->update( 'default' ); | |
| 95 | 65 | } |
| 96 | 66 | |
| 97 | - /** | |
| 98 | - * Check if the .htaccess file should be deleted based on server response. | |
| 99 | - * If a server has AllowOverride FileInfo but not AllowOverride AuthConfig, JS and CSS files | |
| 100 | - * will result in a 500 error. | |
| 101 | - * | |
| 102 | - * @since 6.27 | |
| 103 | - * | |
| 104 | - * @return void | |
| 105 | - */ | |
| 106 | - private function maybe_delete_htaccess_file() { | |
| 107 | - $css_file_request = wp_remote_get( FrmAppHelper::plugin_url() . '/css/frm_fonts.css' ); | |
| 108 | - | |
| 109 | - if ( 200 === wp_remote_retrieve_response_code( $css_file_request ) ) { | |
| 110 | - return; | |
| 111 | - } | |
| 112 | - | |
| 113 | - $htaccess_path = FrmAppHelper::plugin_path() . '/.htaccess'; | |
| 114 | - | |
| 115 | - if ( file_exists( $htaccess_path ) ) { | |
| 116 | - wp_delete_file( $htaccess_path ); | |
| 117 | - } | |
| 118 | - } | |
| 119 | - | |
| 120 | - /** | |
| 121 | - * Updates some settings for new installs. | |
| 122 | - * | |
| 123 | - * @since 6.23 | |
| 124 | - * | |
| 125 | - * @return void | |
| 126 | - */ | |
| 127 | - private function update_settings_for_new_install() { | |
| 128 | - $settings = FrmAppHelper::get_settings(); | |
| 129 | - | |
| 130 | - $settings->denylist_check = 1; | |
| 131 | - $settings->installed_after_welcome_tour_update = 1; | |
| 132 | - $settings->store(); | |
| 133 | - } | |
| 134 | - | |
| 135 | - /** | |
| 136 | - * If we fail to create the database tables, add an inbox notice. | |
| 137 | - * This informs the user that they need to correct the issue and try again. | |
| 138 | - * | |
| 139 | - * @since 6.19 | |
| 140 | - * | |
| 141 | - * @return void | |
| 142 | - */ | |
| 143 | - private function check_that_tables_exist() { | |
| 144 | - // Check the DB that the table $this->forms exists. | |
| 67 | + public function collation() { | |
| 145 | 68 | global $wpdb; |
| 146 | - $exists = $wpdb->get_results( $wpdb->prepare( 'SHOW TABLES LIKE %s', $this->forms ) ); | |
| 147 | - | |
| 148 | - if ( $exists ) { | |
| 149 | - $inbox = new FrmInbox(); | |
| 150 | - $inbox->dismiss( 'failed-to-create-tables' ); | |
| 151 | - return; | |
| 69 | + if ( ! $wpdb->has_cap( 'collation' ) ) { | |
| 70 | + return ''; | |
| 152 | 71 | } |
| 153 | 72 | |
| 154 | - $message = array( | |
| 155 | - 'key' => 'failed-to-create-tables', | |
| 156 | - 'subject' => 'Something went wrong setting up the database', | |
| 157 | - 'message' => 'For steps to continue, see our <a href="https://formidableforms.com/knowledgebase/install-formidable-forms/#kb-missing-database-tables">documentation</a>. If you need assistance, we recommend that you reach out to your hosting provider. Then <a href="' . esc_url( admin_url( 'admin.php?page=formidable&frm_add_tables=1' ) ) . '">click here</a> to try again.', // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 158 | - 'cta' => '<a href="https://formidableforms.com/knowledgebase/install-formidable-forms/#kb-missing-database-tables">Learn More</a>', | |
| 159 | - 'type' => 'error', | |
| 160 | - ); | |
| 161 | - | |
| 162 | - $inbox = new FrmInbox(); | |
| 163 | - $inbox->add_message( $message ); | |
| 73 | + return $wpdb->get_charset_collate(); | |
| 164 | 74 | } |
| 165 | 75 | |
| 166 | - /** | |
| 167 | - * @return string | |
| 168 | - */ | |
| 169 | - public function collation() { | |
| 170 | - global $wpdb; | |
| 171 | - return $wpdb->has_cap( 'collation' ) ? $wpdb->get_charset_collate() : ''; | |
| 172 | - } | |
| 173 | - | |
| 174 | - /** | |
| 175 | - * @return void | |
| 176 | - */ | |
| 177 | 76 | private function create_tables() { |
| 178 | 77 | $charset_collate = $this->collation(); |
| 179 | 78 | $sql = array(); |
| 180 | 79 | |
| @@ -258,84 +157,12 @@ | ||
| 258 | 157 | $wpdb->query( $q . $charset_collate ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared |
| 259 | 158 | } |
| 260 | 159 | unset( $q ); |
| 261 | 160 | } |
| 262 | - | |
| 263 | - $this->add_composite_indexes_for_entries(); | |
| 264 | 161 | } |
| 265 | 162 | |
| 266 | - /** | |
| 267 | - * These indexes help optimize database queries for entries. | |
| 268 | - * | |
| 269 | - * @since 6.6 | |
| 270 | - * @since 6.16.3 idx_form_id_is_draft was also added to frm_items. | |
| 271 | - * @since 6.17 idx_form_id_type was also added to frm_fields. | |
| 272 | - * | |
| 273 | - * @return void | |
| 274 | - */ | |
| 275 | - private function add_composite_indexes_for_entries() { | |
| 276 | - global $wpdb; | |
| 277 | - | |
| 278 | - $table_name = "{$wpdb->prefix}frm_items"; | |
| 279 | - $index_name = 'idx_is_draft_created_at'; | |
| 280 | - | |
| 281 | - if ( ! self::index_exists( $table_name, $index_name ) ) { | |
| 282 | - $wpdb->query( "CREATE INDEX idx_is_draft_created_at ON `{$wpdb->prefix}frm_items` (is_draft, created_at)" ); | |
| 283 | - } | |
| 284 | - | |
| 285 | - $table_name = "{$wpdb->prefix}frm_item_metas"; | |
| 286 | - $index_name = 'idx_field_id_item_id'; | |
| 287 | - | |
| 288 | - if ( ! self::index_exists( $table_name, $index_name ) ) { | |
| 289 | - $wpdb->query( "CREATE INDEX idx_field_id_item_id ON `{$wpdb->prefix}frm_item_metas` (field_id, item_id)" ); | |
| 290 | - } | |
| 291 | - | |
| 292 | - $table_name = "{$wpdb->prefix}frm_items"; | |
| 293 | - $index_name = 'idx_form_id_is_draft'; | |
| 294 | - | |
| 295 | - if ( ! self::index_exists( $table_name, $index_name ) ) { | |
| 296 | - $wpdb->query( "CREATE INDEX idx_form_id_is_draft ON `{$wpdb->prefix}frm_items` (form_id, is_draft)" ); | |
| 297 | - } | |
| 298 | - | |
| 299 | - $table_name = "{$wpdb->prefix}frm_fields"; | |
| 300 | - $index_name = 'idx_form_id_type'; | |
| 301 | - | |
| 302 | - if ( ! self::index_exists( $table_name, $index_name ) ) { | |
| 303 | - $wpdb->query( "CREATE INDEX idx_form_id_type ON `{$wpdb->prefix}frm_fields` (form_id, type(30))" ); | |
| 304 | - } | |
| 305 | - } | |
| 306 | - | |
| 307 | - /** | |
| 308 | - * Check that an index exists in a database table before trying to add it (which results in an error). | |
| 309 | - * | |
| 310 | - * @since 6.6 | |
| 311 | - * | |
| 312 | - * @param string $table_name | |
| 313 | - * @param string $index_name | |
| 314 | - * | |
| 315 | - * @return bool | |
| 316 | - */ | |
| 317 | - private static function index_exists( $table_name, $index_name ) { | |
| 318 | - global $wpdb; | |
| 319 | - $row = $wpdb->get_row( | |
| 320 | - $wpdb->prepare( | |
| 321 | - 'SELECT 1 FROM information_schema.statistics | |
| 322 | - WHERE table_schema = database() | |
| 323 | - AND table_name = %s | |
| 324 | - AND index_name = %s | |
| 325 | - LIMIT 1', | |
| 326 | - array( $table_name, $index_name ) | |
| 327 | - ) | |
| 328 | - ); | |
| 329 | - return (bool) $row; | |
| 330 | - } | |
| 331 | - | |
| 332 | - /** | |
| 333 | - * @return void | |
| 334 | - */ | |
| 335 | 163 | private function maybe_create_contact_form() { |
| 336 | 164 | $form_exists = FrmForm::get_id_by_key( 'contact-form' ); |
| 337 | - | |
| 338 | 165 | if ( ! $form_exists ) { |
| 339 | 166 | $this->add_default_template(); |
| 340 | 167 | } |
| 341 | 168 | } |
| @@ -343,10 +170,8 @@ | ||
| 343 | 170 | /** |
| 344 | 171 | * Create the default contact form |
| 345 | 172 | * |
| 346 | 173 | * @since 3.06 |
| 347 | - * | |
| 348 | - * @return void | |
| 349 | 174 | */ |
| 350 | 175 | private function add_default_template() { |
| 351 | 176 | if ( FrmXMLHelper::check_if_libxml_disable_entity_loader_exists() ) { |
| 352 | 177 | // XML import is not enabled on your server. |
| @@ -354,9 +179,10 @@ | ||
| 354 | 179 | } |
| 355 | 180 | |
| 356 | 181 | $set_err = libxml_use_internal_errors( true ); |
| 357 | 182 | $loader = FrmXMLHelper::maybe_libxml_disable_entity_loader( true ); |
| 358 | - $file = FrmAppHelper::plugin_path() . '/classes/views/xml/default-templates.xml'; | |
| 183 | + | |
| 184 | + $file = FrmAppHelper::plugin_path() . '/classes/views/xml/default-templates.xml'; | |
| 359 | 185 | FrmXMLHelper::import_xml( $file ); |
| 360 | 186 | |
| 361 | 187 | libxml_use_internal_errors( $set_err ); |
| 362 | 188 | FrmXMLHelper::maybe_libxml_disable_entity_loader( $loader ); |
| @@ -363,41 +189,32 @@ | ||
| 363 | 189 | } |
| 364 | 190 | |
| 365 | 191 | /** |
| 366 | 192 | * @param int|string $old_db_version |
| 367 | - * | |
| 368 | - * @return void | |
| 369 | 193 | */ |
| 370 | 194 | private function migrate_data( $old_db_version ) { |
| 371 | 195 | if ( ! $old_db_version ) { |
| 372 | 196 | $old_db_version = get_option( 'frm_db_version' ); |
| 373 | 197 | } |
| 374 | - | |
| 375 | - if ( str_contains( $old_db_version, '-' ) ) { | |
| 198 | + if ( strpos( $old_db_version, '-' ) ) { | |
| 376 | 199 | $last_upgrade = explode( '-', $old_db_version ); |
| 377 | 200 | $old_db_version = (int) $last_upgrade[1]; |
| 378 | 201 | } |
| 379 | 202 | |
| 380 | 203 | if ( ! is_numeric( $old_db_version ) ) { |
| 381 | - // Bail if we don't know the previous version | |
| 204 | + // bail if we don't know the previous version | |
| 382 | 205 | return; |
| 383 | 206 | } |
| 384 | 207 | |
| 385 | - $migrations = array( 16, 11, 16, 17, 23, 25, 86, 90, 97, 98, 101, 104 ); | |
| 386 | - | |
| 208 | + $migrations = array( 16, 11, 16, 17, 23, 25, 86, 90, 97, 98 ); | |
| 387 | 209 | foreach ( $migrations as $migration ) { |
| 388 | - if ( FrmAppHelper::$db_version < $migration || $old_db_version >= $migration ) { | |
| 389 | - continue; | |
| 210 | + if ( FrmAppHelper::$db_version >= $migration && $old_db_version < $migration ) { | |
| 211 | + $function_name = 'migrate_to_' . $migration; | |
| 212 | + $this->$function_name(); | |
| 390 | 213 | } |
| 391 | - | |
| 392 | - $function_name = 'migrate_to_' . $migration; | |
| 393 | - $this->$function_name(); | |
| 394 | 214 | } |
| 395 | 215 | } |
| 396 | 216 | |
| 397 | - /** | |
| 398 | - * @return bool | |
| 399 | - */ | |
| 400 | 217 | public function uninstall() { |
| 401 | 218 | if ( ! current_user_can( 'administrator' ) ) { |
| 402 | 219 | $frm_settings = FrmAppHelper::get_settings(); |
| 403 | 220 | wp_die( esc_html( $frm_settings->admin_permission ) ); |
| @@ -416,15 +233,13 @@ | ||
| 416 | 233 | delete_option( 'frm_lite_settings_upgrade' ); |
| 417 | 234 | delete_option( 'frm-usage-uuid' ); |
| 418 | 235 | delete_option( 'frm_inbox' ); |
| 419 | 236 | delete_option( 'frmpro_css' ); |
| 420 | - delete_option( FrmOnboardingWizardController::REDIRECT_STATUS_OPTION ); | |
| 421 | - delete_option( FrmEmailSummaryHelper::$option_name ); | |
| 237 | + delete_option( 'frm_welcome_redirect' ); | |
| 422 | 238 | |
| 423 | 239 | // Delete roles. |
| 424 | 240 | $frm_roles = FrmAppHelper::frm_capabilities(); |
| 425 | 241 | $roles = get_editable_roles(); |
| 426 | - | |
| 427 | 242 | foreach ( $frm_roles as $frm_role => $frm_role_description ) { |
| 428 | 243 | foreach ( $roles as $role => $details ) { |
| 429 | 244 | $wp_roles->remove_cap( $role, $frm_role ); |
| 430 | 245 | unset( $role, $details ); |
| @@ -432,16 +247,15 @@ | ||
| 432 | 247 | unset( $frm_role, $frm_role_description ); |
| 433 | 248 | } |
| 434 | 249 | unset( $roles, $frm_roles ); |
| 435 | 250 | |
| 436 | - // Delete actions, views, and styles | |
| 251 | + // delete actions, views, and styles | |
| 437 | 252 | |
| 438 | - // Prevent the post deletion from triggering entries to be deleted | |
| 253 | + // prevent the post deletion from triggering entries to be deleted | |
| 439 | 254 | remove_action( 'before_delete_post', 'FrmProDisplaysController::before_delete_post' ); |
| 440 | 255 | remove_action( 'deleted_post', 'FrmProEntriesController::delete_entry' ); |
| 441 | 256 | |
| 442 | - $post_ids = $wpdb->get_col( $wpdb->prepare( 'SELECT ID FROM ' . $wpdb->posts . ' WHERE post_type in (%s, %s, %s)', FrmFormActionsController::$action_post_type, FrmStylesController::$post_type, 'frm_display' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 443 | - | |
| 257 | + $post_ids = $wpdb->get_col( $wpdb->prepare( 'SELECT ID FROM ' . $wpdb->posts . ' WHERE post_type in (%s, %s, %s)', FrmFormActionsController::$action_post_type, FrmStylesController::$post_type, 'frm_display' ) ); | |
| 444 | 258 | foreach ( $post_ids as $post_id ) { |
| 445 | 259 | // Delete's each post. |
| 446 | 260 | wp_delete_post( $post_id, true ); |
| 447 | 261 | } |
| @@ -446,15 +260,15 @@ | ||
| 446 | 260 | wp_delete_post( $post_id, true ); |
| 447 | 261 | } |
| 448 | 262 | unset( $post_ids ); |
| 449 | 263 | |
| 450 | - // Delete transients | |
| 264 | + // delete transients | |
| 451 | 265 | delete_transient( 'frmpro_css' ); |
| 452 | 266 | delete_transient( 'frm_options' ); |
| 453 | 267 | delete_transient( 'frmpro_options' ); |
| 454 | - delete_transient( FrmOnboardingWizardController::TRANSIENT_NAME ); | |
| 268 | + delete_transient( 'frm_activation_redirect' ); | |
| 455 | 269 | |
| 456 | - $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->options . ' WHERE option_name LIKE %s OR option_name LIKE %s', '_transient_timeout_frm_form_fields_%', '_transient_frm_form_fields_%' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 270 | + $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->options . ' WHERE option_name LIKE %s OR option_name LIKE %s', '_transient_timeout_frm_form_fields_%', '_transient_frm_form_fields_%' ) ); | |
| 457 | 271 | |
| 458 | 272 | do_action( 'frm_after_uninstall' ); |
| 459 | 273 | |
| 460 | 274 | return true; |
| @@ -460,54 +274,11 @@ | ||
| 460 | 274 | return true; |
| 461 | 275 | } |
| 462 | 276 | |
| 463 | 277 | /** |
| 464 | - * In older versions of Lite, it's possible we've saved the wrong location ID. | |
| 465 | - * So force it to get valid values again. | |
| 466 | - * | |
| 467 | - * @since 6.25 | |
| 468 | - * | |
| 469 | - * @return void | |
| 470 | - */ | |
| 471 | - private function migrate_to_104() { | |
| 472 | - if ( FrmSquareLiteConnectHelper::get_merchant_id( 'test' ) ) { | |
| 473 | - FrmSquareLiteConnectHelper::get_location_id( true, 'test' ); | |
| 474 | - } | |
| 475 | - | |
| 476 | - if ( FrmSquareLiteConnectHelper::get_merchant_id( 'live' ) ) { | |
| 477 | - FrmSquareLiteConnectHelper::get_location_id( true, 'live' ); | |
| 478 | - } | |
| 479 | - } | |
| 480 | - | |
| 481 | - /** | |
| 482 | - * Disables summary email for multisite (not the main site) if recipient setting isn't changed. | |
| 483 | - * | |
| 484 | - * @since 6.8 | |
| 485 | - * | |
| 486 | - * @return void | |
| 487 | - */ | |
| 488 | - private function migrate_to_101() { | |
| 489 | - if ( ! is_multisite() || get_main_site_id() === get_current_blog_id() ) { | |
| 490 | - return; | |
| 491 | - } | |
| 492 | - | |
| 493 | - $frm_settings = FrmAppHelper::get_settings(); | |
| 494 | - | |
| 495 | - if ( empty( $frm_settings->summary_emails ) || '[admin_email]' !== $frm_settings->summary_emails_recipients ) { | |
| 496 | - // User changed it. | |
| 497 | - return; | |
| 498 | - } | |
| 499 | - | |
| 500 | - $frm_settings->summary_emails = 0; | |
| 501 | - $frm_settings->store(); | |
| 502 | - } | |
| 503 | - | |
| 504 | - /** | |
| 505 | 278 | * Clear frmpro_css transient. |
| 506 | 279 | * |
| 507 | 280 | * @since 4.10.02 |
| 508 | - * | |
| 509 | - * @return void | |
| 510 | 281 | */ |
| 511 | 282 | private function migrate_to_98() { |
| 512 | 283 | delete_transient( 'frmpro_css' ); |
| 513 | 284 | } |
| @@ -515,10 +286,8 @@ | ||
| 515 | 286 | /** |
| 516 | 287 | * Move default_blank and clear_on_focus to placeholder. |
| 517 | 288 | * |
| 518 | 289 | * @since 4.0 |
| 519 | - * | |
| 520 | - * @return void | |
| 521 | 290 | */ |
| 522 | 291 | private function migrate_to_97() { |
| 523 | 292 | $this->migrate_to_placeholder( 'clear_on_focus' ); |
| 524 | 293 | $this->migrate_to_placeholder( 'default_blank' ); |
| @@ -527,12 +296,8 @@ | ||
| 527 | 296 | /** |
| 528 | 297 | * Move clear_on_focus or default_blank to placeholder. |
| 529 | 298 | * |
| 530 | 299 | * @since 4.0 |
| 531 | - * | |
| 532 | - * @param string $type Field option key to migrate. | |
| 533 | - * | |
| 534 | - * @return void | |
| 535 | 300 | */ |
| 536 | 301 | private function migrate_to_placeholder( $type = 'clear_on_focus' ) { |
| 537 | 302 | $query = array( |
| 538 | 303 | 'field_options like' => '"' . $type . '";s:1:"1";', |
| @@ -543,10 +308,9 @@ | ||
| 543 | 308 | foreach ( $fields as $field ) { |
| 544 | 309 | FrmAppHelper::unserialize_or_decode( $field->field_options ); |
| 545 | 310 | FrmAppHelper::unserialize_or_decode( $field->options ); |
| 546 | 311 | $update_values = FrmXMLHelper::migrate_field_placeholder( $field, $type ); |
| 547 | - | |
| 548 | - if ( ! $update_values ) { | |
| 312 | + if ( empty( $update_values ) ) { | |
| 549 | 313 | continue; |
| 550 | 314 | } |
| 551 | 315 | |
| 552 | 316 | FrmField::update( $field->id, $update_values ); |
| @@ -554,18 +318,14 @@ | ||
| 554 | 318 | } |
| 555 | 319 | } |
| 556 | 320 | |
| 557 | 321 | /** |
| 558 | - * Delete unneeded default templates | |
| 322 | + * Delete uneeded default templates | |
| 559 | 323 | * |
| 560 | 324 | * @since 3.06 |
| 561 | - * | |
| 562 | - * @return void | |
| 563 | 325 | */ |
| 564 | 326 | private function migrate_to_90() { |
| 565 | 327 | $form = FrmForm::getOne( 'contact' ); |
| 566 | - | |
| 567 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 568 | 328 | if ( $form && $form->default_template == 1 ) { |
| 569 | 329 | FrmForm::destroy( 'contact' ); |
| 570 | 330 | } |
| 571 | 331 | } |
| @@ -573,17 +333,16 @@ | ||
| 573 | 333 | /** |
| 574 | 334 | * Reverse migration 17 -- Divide by 9 |
| 575 | 335 | * |
| 576 | 336 | * @since 3.0.05 |
| 577 | - * | |
| 578 | - * @return void | |
| 579 | 337 | */ |
| 580 | 338 | private function migrate_to_86() { |
| 339 | + | |
| 581 | 340 | $fields = $this->get_fields_with_size(); |
| 582 | 341 | |
| 583 | - foreach ( $fields as $f ) { | |
| 342 | + foreach ( (array) $fields as $f ) { | |
| 584 | 343 | FrmAppHelper::unserialize_or_decode( $f->field_options ); |
| 585 | - $size = $f->field_options['size']; | |
| 344 | + $size = $f->field_options['size']; | |
| 586 | 345 | $this->maybe_convert_migrated_size( $size ); |
| 587 | 346 | |
| 588 | 347 | if ( $size === $f->field_options['size'] ) { |
| 589 | 348 | continue; |
| @@ -593,12 +352,11 @@ | ||
| 593 | 352 | FrmField::update( $f->id, array( 'field_options' => $f->field_options ) ); |
| 594 | 353 | unset( $f ); |
| 595 | 354 | } |
| 596 | 355 | |
| 597 | - // Reverse the extra size changes in widgets | |
| 356 | + // reverse the extra size changes in widgets | |
| 598 | 357 | $widgets = get_option( 'widget_frm_show_form' ); |
| 599 | - | |
| 600 | - if ( ! $widgets ) { | |
| 358 | + if ( empty( $widgets ) ) { | |
| 601 | 359 | return; |
| 602 | 360 | } |
| 603 | 361 | |
| 604 | 362 | $this->revert_widget_field_size(); |
| @@ -603,11 +361,8 @@ | ||
| 603 | 361 | |
| 604 | 362 | $this->revert_widget_field_size(); |
| 605 | 363 | } |
| 606 | 364 | |
| 607 | - /** | |
| 608 | - * @return array | |
| 609 | - */ | |
| 610 | 365 | private function get_fields_with_size() { |
| 611 | 366 | $field_types = array( |
| 612 | 367 | 'textarea', |
| 613 | 368 | 'text', |
| @@ -635,20 +390,16 @@ | ||
| 635 | 390 | /** |
| 636 | 391 | * Reverse the extra size changes in widgets |
| 637 | 392 | * |
| 638 | 393 | * @since 3.0.05 |
| 639 | - * | |
| 640 | - * @return void | |
| 641 | 394 | */ |
| 642 | 395 | private function revert_widget_field_size() { |
| 643 | 396 | $widgets = get_option( 'widget_frm_show_form' ); |
| 644 | - | |
| 645 | - if ( ! $widgets ) { | |
| 397 | + if ( empty( $widgets ) ) { | |
| 646 | 398 | return; |
| 647 | 399 | } |
| 648 | 400 | |
| 649 | 401 | FrmAppHelper::unserialize_or_decode( $widgets ); |
| 650 | - | |
| 651 | 402 | foreach ( $widgets as $k => $widget ) { |
| 652 | 403 | if ( ! is_array( $widget ) || ! isset( $widget['size'] ) ) { |
| 653 | 404 | continue; |
| 654 | 405 | } |
| @@ -654,9 +405,8 @@ | ||
| 654 | 405 | } |
| 655 | 406 | |
| 656 | 407 | $this->maybe_convert_migrated_size( $widgets[ $k ]['size'] ); |
| 657 | 408 | } |
| 658 | - | |
| 659 | 409 | update_option( 'widget_frm_show_form', $widgets ); |
| 660 | 410 | } |
| 661 | 411 | |
| 662 | 412 | /** |
| @@ -662,28 +412,23 @@ | ||
| 662 | 412 | /** |
| 663 | 413 | * Divide by 9 to reverse the multiplication |
| 664 | 414 | * |
| 665 | 415 | * @since 3.0.05 |
| 666 | - * | |
| 667 | - * @param string $size Size string to maybe convert, passed by reference. | |
| 668 | - * | |
| 669 | - * @return void | |
| 670 | 416 | */ |
| 671 | 417 | private function maybe_convert_migrated_size( &$size ) { |
| 672 | - $has_px_size = $size && str_contains( $size, 'px' ); | |
| 673 | - | |
| 418 | + $has_px_size = ! empty( $size ) && strpos( $size, 'px' ); | |
| 674 | 419 | if ( ! $has_px_size ) { |
| 675 | 420 | return; |
| 676 | 421 | } |
| 677 | 422 | |
| 678 | 423 | $int_size = str_replace( 'px', '', $size ); |
| 679 | - | |
| 680 | 424 | if ( ! is_numeric( $int_size ) || (int) $int_size < 900 ) { |
| 681 | 425 | return; |
| 682 | 426 | } |
| 683 | 427 | |
| 684 | 428 | $pixel_conversion = 9; |
| 685 | - $size = round( (int) $int_size / $pixel_conversion ); | |
| 429 | + | |
| 430 | + $size = round( (int) $int_size / $pixel_conversion ); | |
| 686 | 431 | } |
| 687 | 432 | |
| 688 | 433 | /** |
| 689 | 434 | * Migrate old styling settings. If sites are using the old |
| @@ -689,22 +434,19 @@ | ||
| 689 | 434 | * Migrate old styling settings. If sites are using the old |
| 690 | 435 | * default 400px field width, switch it to 100% |
| 691 | 436 | * |
| 692 | 437 | * @since 2.0.4 |
| 693 | - * | |
| 694 | - * @return void | |
| 695 | 438 | */ |
| 696 | 439 | private function migrate_to_25() { |
| 697 | - // Get the style that was created with the style migration | |
| 440 | + // get the style that was created with the style migration | |
| 698 | 441 | $frm_style = new FrmStyle(); |
| 699 | 442 | $styles = $frm_style->get_all( 'post_date', 'ASC', 1 ); |
| 700 | - | |
| 701 | - if ( ! $styles ) { | |
| 443 | + if ( empty( $styles ) ) { | |
| 702 | 444 | return; |
| 703 | 445 | } |
| 704 | 446 | |
| 705 | 447 | foreach ( $styles as $style ) { |
| 706 | - if ( $style->post_content['field_width'] === '400px' ) { | |
| 448 | + if ( $style->post_content['field_width'] == '400px' ) { | |
| 707 | 449 | $style->post_content['field_width'] = '100%'; |
| 708 | 450 | $frm_style->save( (array) $style ); |
| 709 | 451 | |
| 710 | 452 | return; |
| @@ -716,16 +458,13 @@ | ||
| 716 | 458 | * Check if the parent_form_id columns exists. |
| 717 | 459 | * If not, try and add it again |
| 718 | 460 | * |
| 719 | 461 | * @since 2.0.2 |
| 720 | - * | |
| 721 | - * @return void | |
| 722 | 462 | */ |
| 723 | 463 | private function migrate_to_23() { |
| 724 | 464 | global $wpdb; |
| 725 | 465 | $exists = $wpdb->get_row( 'SHOW COLUMNS FROM ' . $this->forms . ' LIKE "parent_form_id"' ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared |
| 726 | - | |
| 727 | - if ( ! $exists ) { | |
| 466 | + if ( empty( $exists ) ) { | |
| 728 | 467 | $wpdb->query( 'ALTER TABLE ' . $this->forms . ' ADD parent_form_id int(11) default 0' ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared |
| 729 | 468 | } |
| 730 | 469 | } |
| 731 | 470 | |
| @@ -730,10 +469,8 @@ | ||
| 730 | 469 | } |
| 731 | 470 | |
| 732 | 471 | /** |
| 733 | 472 | * Change field size from character to pixel -- Multiply by 9 |
| 734 | - * | |
| 735 | - * @return void | |
| 736 | 473 | */ |
| 737 | 474 | private function migrate_to_17() { |
| 738 | 475 | $fields = $this->get_fields_with_size(); |
| 739 | 476 | |
| @@ -738,9 +475,8 @@ | ||
| 738 | 475 | $fields = $this->get_fields_with_size(); |
| 739 | 476 | |
| 740 | 477 | foreach ( $fields as $f ) { |
| 741 | 478 | FrmAppHelper::unserialize_or_decode( $f->field_options ); |
| 742 | - | |
| 743 | 479 | if ( empty( $f->field_options['size'] ) || ! is_numeric( $f->field_options['size'] ) ) { |
| 744 | 480 | continue; |
| 745 | 481 | } |
| 746 | 482 | |
| @@ -754,20 +490,16 @@ | ||
| 754 | 490 | } |
| 755 | 491 | |
| 756 | 492 | /** |
| 757 | 493 | * Change the characters in widgets to pixels |
| 758 | - * | |
| 759 | - * @return void | |
| 760 | 494 | */ |
| 761 | 495 | private function adjust_widget_size() { |
| 762 | 496 | $widgets = get_option( 'widget_frm_show_form' ); |
| 763 | - | |
| 764 | - if ( ! $widgets ) { | |
| 497 | + if ( empty( $widgets ) ) { | |
| 765 | 498 | return; |
| 766 | 499 | } |
| 767 | 500 | |
| 768 | 501 | FrmAppHelper::unserialize_or_decode( $widgets ); |
| 769 | - | |
| 770 | 502 | foreach ( $widgets as $k => $widget ) { |
| 771 | 503 | if ( ! is_array( $widget ) || ! isset( $widget['size'] ) ) { |
| 772 | 504 | continue; |
| 773 | 505 | } |
| @@ -772,21 +504,15 @@ | ||
| 772 | 504 | continue; |
| 773 | 505 | } |
| 774 | 506 | $this->convert_character_to_px( $widgets[ $k ]['size'] ); |
| 775 | 507 | } |
| 776 | - | |
| 777 | 508 | update_option( 'widget_frm_show_form', $widgets ); |
| 778 | 509 | } |
| 779 | 510 | |
| 780 | - /** | |
| 781 | - * @param string $size | |
| 782 | - * | |
| 783 | - * @return void | |
| 784 | - */ | |
| 785 | 511 | private function convert_character_to_px( &$size ) { |
| 786 | 512 | $pixel_conversion = 9; |
| 787 | 513 | |
| 788 | - $size = round( $pixel_conversion * (int) $size ); | |
| 514 | + $size = round( $pixel_conversion * (int) $size ); | |
| 789 | 515 | $size .= 'px'; |
| 790 | 516 | } |
| 791 | 517 | |
| 792 | 518 | /** |
| @@ -825,9 +551,9 @@ | ||
| 825 | 551 | * post_excerpt: message |
| 826 | 552 | */ |
| 827 | 553 | foreach ( $forms as $form ) { |
| 828 | 554 | if ( $form->is_template && $form->default_template ) { |
| 829 | - // Don't migrate the default templates since the email will be added anyway | |
| 555 | + // don't migrate the default templates since the email will be added anyway | |
| 830 | 556 | continue; |
| 831 | 557 | } |
| 832 | 558 | |
| 833 | 559 | // Format form options |
| @@ -841,9 +567,10 @@ | ||
| 841 | 567 | |
| 842 | 568 | private function migrate_to_11() { |
| 843 | 569 | global $wpdb; |
| 844 | 570 | |
| 845 | - $forms = FrmDb::get_results( $this->forms, array(), 'id, options' ); | |
| 571 | + $forms = FrmDb::get_results( $this->forms, array(), 'id, options' ); | |
| 572 | + | |
| 846 | 573 | $sending = __( 'Sending', 'formidable' ); |
| 847 | 574 | $img = FrmAppHelper::plugin_url() . '/images/ajax_loader.gif'; |
| 848 | 575 | $old_default_html = <<<DEFAULT_HTML |
| 849 | 576 | <div class="frm_submit"> |
| @@ -855,21 +582,18 @@ | ||
| 855 | 582 | unset( $sending, $img ); |
| 856 | 583 | |
| 857 | 584 | $new_default_html = FrmFormsHelper::get_default_html( 'submit' ); |
| 858 | 585 | $draft_link = FrmFormsHelper::get_draft_link(); |
| 859 | - | |
| 860 | 586 | foreach ( $forms as $form ) { |
| 861 | 587 | FrmAppHelper::unserialize_or_decode( $form->options ); |
| 862 | - | |
| 863 | - if ( empty( $form->options['submit_html'] ) ) { | |
| 588 | + if ( ! isset( $form->options['submit_html'] ) || empty( $form->options['submit_html'] ) ) { | |
| 864 | 589 | continue; |
| 865 | 590 | } |
| 866 | 591 | |
| 867 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 868 | 592 | if ( $form->options['submit_html'] != $new_default_html && $form->options['submit_html'] == $old_default_html ) { |
| 869 | 593 | $form->options['submit_html'] = $new_default_html; |
| 870 | 594 | $wpdb->update( $this->forms, array( 'options' => serialize( $form->options ) ), array( 'id' => $form->id ) ); |
| 871 | - } elseif ( ! str_contains( $form->options['submit_html'], 'save_draft' ) ) { | |
| 595 | + } elseif ( ! strpos( $form->options['submit_html'], 'save_draft' ) ) { | |
| 872 | 596 | $form->options['submit_html'] = preg_replace( '~\<\/div\>(?!.*\<\/div\>)~', $draft_link . "\r\n</div>", $form->options['submit_html'] ); |
| 873 | 597 | $wpdb->update( $this->forms, array( 'options' => serialize( $form->options ) ), array( 'id' => $form->id ) ); |
| 874 | 598 | } |
| 875 | 599 | unset( $form ); |
