PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.4
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.4
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmXMLController.php +88 -228 6.355.4 View file →
@@ -4,28 +4,23 @@
4 4 }
5 5
6 6 class FrmXMLController {
7 7
8 - /**
9 - * @return void
10 - */
11 8 public static function menu() {
12 - add_submenu_page( 'formidable', 'Formidable | ' . __( 'Import/Export', 'formidable' ), __( 'Import/Export', 'formidable' ), 'frm_edit_forms', 'formidable-import', 'FrmXMLController::route' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
9 + add_submenu_page( 'formidable', 'Formidable | ' . __( 'Import/Export', 'formidable' ), __( 'Import/Export', 'formidable' ), 'frm_edit_forms', 'formidable-import', 'FrmXMLController::route' );
13 10 }
14 11
15 - /**
16 - * @return void
17 - */
18 12 public static function add_default_templates() {
19 13 if ( FrmXMLHelper::check_if_libxml_disable_entity_loader_exists() ) {
20 - // XML import is not enabled on your server.
14 + // XML import is not enabled on your server
21 15 return;
22 16 }
23 17
24 18 $set_err = libxml_use_internal_errors( true );
25 19 $loader = FrmXMLHelper::maybe_libxml_disable_entity_loader( true );
26 - $files = apply_filters( 'frm_default_templates_files', array() );
27 20
21 + $files = apply_filters( 'frm_default_templates_files', array() );
22 +
28 23 foreach ( (array) $files as $file ) {
29 24 FrmXMLHelper::import_xml( $file );
30 25 unset( $file );
31 26 }
@@ -39,35 +34,18 @@
39 34 /**
40 35 * Use the template link to install the XML template
41 36 *
42 37 * @since 3.06
43 - *
44 - * @return void
45 38 */
46 39 public static function install_template() {
47 40 FrmAppHelper::permission_check( 'frm_edit_forms' );
48 41 check_ajax_referer( 'frm_ajax', 'nonce' );
49 42
50 - if ( ! function_exists( 'simplexml_load_string' ) ) {
51 - $response = array(
52 - 'message' => __( 'Your server is missing the Simple XML extension. This is required to install a template.', 'formidable' ),
53 - );
54 - echo wp_json_encode( $response );
55 - wp_die();
56 - }
43 + $url = FrmAppHelper::get_param( 'xml', '', 'post', 'esc_url_raw' );
57 44
58 45 $form = self::get_posted_form();
59 - $url = FrmAppHelper::get_param( 'xml', '', 'post', 'esc_url_raw' );
60 46 self::override_url( $form, $url );
61 47
62 - if ( ! self::validate_xml_url( $url ) ) {
63 - $response = array(
64 - 'message' => __( 'The template you are trying to install could not be validated.', 'formidable' ),
65 - );
66 - echo wp_json_encode( $response );
67 - wp_die();
68 - }
69 -
70 48 $response = wp_remote_get( $url );
71 49 $body = wp_remote_retrieve_body( $response );
72 50 $xml = simplexml_load_string( $body );
73 51
@@ -72,9 +50,9 @@
72 50 $xml = simplexml_load_string( $body );
73 51
74 52 if ( ! $xml ) {
75 53 $response = array(
76 - 'message' => __( 'There was an error reading the form template.', 'formidable' ),
54 + 'message' => __( 'There was an error reading the form template', 'formidable' ),
77 55 );
78 56 echo wp_json_encode( $response );
79 57 wp_die();
80 58 }
@@ -81,70 +59,59 @@
81 59
82 60 self::set_new_form_name( $xml );
83 61
84 62 $imported = FrmXMLHelper::import_xml_now( $xml, true );
85 -
86 63 if ( ! empty( $imported['form_status'] ) ) {
87 64 // Get the last form id in case there are child forms.
88 - $form_id = array_key_last( $imported['form_status'] );
65 + end( $imported['form_status'] );
66 + $form_id = key( $imported['form_status'] );
89 67 $response = array(
90 68 'id' => $form_id,
91 - 'redirect' => FrmForm::get_edit_link( $form_id ) . '&new_template=true',
69 + 'redirect' => FrmForm::get_edit_link( $form_id ),
92 70 'success' => 1,
93 71 );
94 -
95 72 if ( ! empty( $imported['imported']['posts'] ) ) {
96 73 // Return the link to the last page created.
97 74 $pages = $imported['posts'];
98 75 }
99 76
100 - if ( $form ) {
77 + if ( ! empty( $form ) ) {
101 78 // Create selected pages with the correct shortcodes.
102 79 $pages = self::create_pages_for_import( $form );
103 80 }
104 81
105 - if ( ! empty( $pages ) ) {
106 - $post_id = end( $pages );
82 + if ( isset( $pages ) && ! empty( $pages ) ) {
83 + $post_id = end( $pages );
107 84 $response['redirect'] = get_permalink( $post_id );
108 85 }
109 86 } else {
110 - $message = $imported['error'] ?? __( 'There was an error importing form', 'formidable' );
87 + if ( isset( $imported['error'] ) ) {
88 + $message = $imported['error'];
89 + } else {
90 + $message = __( 'There was an error importing form', 'formidable' );
91 + }
111 92 $response = array(
112 93 'message' => $message,
113 94 );
114 - }//end if
115 95
116 - /**
117 - * @since 6.18 Added `url` to the $args.
118 - */
119 - $response = apply_filters( 'frm_xml_response', $response, compact( 'form', 'imported', 'url' ) );
96 + }
120 97
98 + $response = apply_filters( 'frm_xml_response', $response, compact( 'form', 'imported' ) );
99 +
121 100 echo wp_json_encode( $response );
122 101 wp_die();
123 102 }
124 103
125 104 /**
126 - * Make sure that the XML file we're trying to load is in fact an XML file, and that it's coming from our S3 bucket.
127 - * This is to make sure that the URL can't be exploited for a SSRF attack.
128 - *
129 - * @since 5.5.5
130 - *
131 - * @param string $url
132 - *
133 - * @return bool True on success, False on error.
134 - */
135 - private static function validate_xml_url( $url ) {
136 - return FrmAppHelper::validate_url_is_in_s3_bucket( $url, 'xml' );
137 - }
138 -
139 - /**
140 105 * @since 4.06.02
141 - *
142 - * @return mixed
143 106 */
144 107 private static function get_posted_form() {
145 108 $form = FrmAppHelper::get_param( 'form', '', 'post', 'wp_unslash' );
146 - return $form ? json_decode( $form, true ) : $form;
109 + if ( empty( $form ) ) {
110 + return $form;
111 + }
112 + $form = json_decode( $form, true );
113 + return $form;
147 114 }
148 115
149 116 /**
150 117 * Get a different URL depending on the selection in the form.
@@ -149,24 +116,17 @@
149 116 /**
150 117 * Get a different URL depending on the selection in the form.
151 118 *
152 119 * @since 4.06.02
153 - *
154 - * @param array $form The posted form values.
155 - * @param string $url The URL to override.
156 - *
157 - * @return void
158 120 */
159 121 private static function override_url( $form, &$url ) {
160 122 $selected_form = self::get_selected_in_form( $form, 'form' );
161 -
162 - if ( ! $selected_form ) {
123 + if ( empty( $selected_form ) ) {
163 124 return;
164 125 }
165 126
166 - $selected_xml = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
167 -
168 - if ( ! $selected_xml || ! str_starts_with( $selected_xml, 'http' ) ) {
127 + $selected_xml = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
128 + if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
169 129 return;
170 130 }
171 131
172 132 $url = $selected_xml;
@@ -173,16 +133,11 @@
173 133 }
174 134
175 135 /**
176 136 * @since 4.06.02
177 - *
178 - * @param array $form
179 - * @param string $value
180 - *
181 - * @return array|string
182 137 */
183 138 private static function get_selected_in_form( $form, $value = 'form' ) {
184 - if ( $form && ! empty( $form[ $value ] ) ) {
139 + if ( ! empty( $form ) && isset( $form[ $value ] ) && ! empty( $form[ $value ] ) ) {
185 140 return $form[ $value ];
186 141 }
187 142
188 143 return '';
@@ -192,21 +147,21 @@
192 147 * @since 4.06.02
193 148 *
194 149 * @param array $form The posted form values.
195 150 *
196 - * @return array|null The array of created pages.
151 + * @return array The array of created pages.
197 152 */
198 153 private static function create_pages_for_import( $form ) {
199 - if ( empty( $form['pages'] ) ) {
200 - return null;
154 + if ( ! isset( $form['pages'] ) || empty( $form['pages'] ) ) {
155 + return;
201 156 }
202 157
203 - $form_key = self::get_selected_in_form( $form, 'form' );
158 + $form_key = self::get_selected_in_form( $form, 'form' );
204 159 $view_keys = self::get_selected_in_form( $form, 'view' );
205 - $page_ids = array();
206 160
161 + $page_ids = array();
207 162 foreach ( (array) $form['pages'] as $for => $name ) {
208 - if ( ! $name ) {
163 + if ( empty( $name ) ) {
209 164 // Don't create a page if no title is given.
210 165 continue;
211 166 }
212 167
@@ -213,9 +168,9 @@
213 168 if ( $for === 'view' ) {
214 169 $item_key = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
215 170 $shortcode = '[display-frm-data id=%1$s filter=limited]';
216 171 } elseif ( $for === 'form' ) {
217 - $item_key = $form_key;
172 + $item_key = $form_key;
218 173 $shortcode = '[formidable id=%1$s]';
219 174 } else {
220 175 $item_key = self::get_selected_in_form( $form, 'form' );
221 176 $shortcode = '[' . esc_html( $for ) . ' id=%1$s]';
@@ -232,9 +187,9 @@
232 187 'post_type' => 'page',
233 188 'post_content' => sprintf( $shortcode, $item_key ),
234 189 )
235 190 );
236 - }//end foreach
191 + }
237 192
238 193 return $page_ids;
239 194 }
240 195
@@ -245,9 +200,8 @@
245 200 *
246 201 * @since 3.06
247 202 *
248 203 * @param object $xml The values included in the XML.
249 - *
250 204 * @return void
251 205 */
252 206 private static function set_new_form_name( &$xml ) {
253 207 if ( ! isset( $xml->form ) ) {
@@ -255,9 +209,8 @@
255 209 }
256 210
257 211 $name = FrmAppHelper::get_param( 'name', '', 'post', 'sanitize_text_field' );
258 212 $description = FrmAppHelper::get_param( 'desc', '', 'post', 'sanitize_textarea_field' );
259 -
260 213 if ( ! $name && ! $description ) {
261 214 return;
262 215 }
263 216
@@ -262,9 +215,8 @@
262 215 }
263 216
264 217 // Get the main form ID.
265 218 $set_name = 0;
266 -
267 219 foreach ( $xml->form as $form ) {
268 220 if ( empty( $form->parent_form_id ) ) {
269 221 $set_name = (int) $form->id;
270 222 }
@@ -282,11 +234,8 @@
282 234 $form->form_key = FrmAppHelper::get_unique_key( $sanitized_form_name, 'frm_forms', 'form_key' );
283 235 }
284 236 }
285 237
286 - /**
287 - * @return void
288 - */
289 238 public static function route() {
290 239 $action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
291 240 $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
292 241 FrmAppHelper::include_svg();
@@ -291,22 +240,16 @@
291 240 $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
292 241 FrmAppHelper::include_svg();
293 242
294 243 if ( 'import_xml' === $action ) {
295 - self::import_xml();
244 + return self::import_xml();
296 245 } elseif ( 'export_xml' === $action ) {
297 - self::export_xml();
246 + return self::export_xml();
298 247 } elseif ( apply_filters( 'frm_xml_route', true, $action ) ) {
299 - self::form();
248 + return self::form();
300 249 }
301 250 }
302 251
303 - /**
304 - * @param string[] $errors
305 - * @param string $message
306 - *
307 - * @return void
308 - */
309 252 public static function form( $errors = array(), $message = '' ) {
310 253 $where = array(
311 254 'status' => array( null, '', 'published' ),
312 255 );
@@ -331,19 +274,16 @@
331 274 ),
332 275 );
333 276 $export_format = apply_filters( 'frm_export_formats', $export_format );
334 277
335 - include FrmAppHelper::plugin_path() . '/classes/views/xml/import_form.php';
278 + include( FrmAppHelper::plugin_path() . '/classes/views/xml/import_form.php' );
336 279 }
337 280
338 - /**
339 - * @return void
340 - */
341 281 public static function import_xml() {
342 - $errors = array();
343 - $message = '';
282 + $errors = array();
283 + $message = '';
284 +
344 285 $permission_error = FrmAppHelper::permission_nonce_error( 'frm_edit_forms', 'import-xml', 'import-xml-nonce' );
345 -
346 286 if ( false !== $permission_error ) {
347 287 $errors[] = $permission_error;
348 288 self::form( $errors );
349 289
@@ -349,11 +289,9 @@
349 289
350 290 return;
351 291 }
352 292
353 - // phpcs:ignore WordPress.Security.NonceVerification.Missing, SlevomatCodingStandard.Files.LineLength.LineTooLong
354 - $has_file = ! empty( $_FILES['frm_import_file'] ) && ! empty( $_FILES['frm_import_file']['name'] ) && ! empty( $_FILES['frm_import_file']['size'] ) && (int) $_FILES['frm_import_file']['size'] > 0;
355 -
293 + $has_file = isset( $_FILES ) && isset( $_FILES['frm_import_file'] ) && ! empty( $_FILES['frm_import_file']['name'] ) && ! empty( $_FILES['frm_import_file']['size'] ) && (int) $_FILES['frm_import_file']['size'] > 0;
356 294 if ( ! $has_file ) {
357 295 $errors[] = __( 'Oops, you didn\'t select a file.', 'formidable' );
358 296 self::form( $errors );
359 297
@@ -359,9 +297,9 @@
359 297
360 298 return;
361 299 }
362 300
363 - // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
301 + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
364 302 $file = isset( $_FILES['frm_import_file']['tmp_name'] ) ? sanitize_option( 'upload_path', $_FILES['frm_import_file']['tmp_name'] ) : '';
365 303
366 304 if ( ! is_uploaded_file( $file ) ) {
367 305 unset( $file );
@@ -370,8 +308,10 @@
370 308
371 309 return;
372 310 }
373 311
312 + //add_filter('upload_mimes', 'FrmXMLController::allow_mime');
313 +
374 314 $export_format = array(
375 315 'xml' => array(
376 316 'name' => 'XML',
377 317 'support' => 'forms',
@@ -379,14 +319,13 @@
379 319 ),
380 320 );
381 321 $export_format = apply_filters( 'frm_export_formats', $export_format );
382 322
383 - // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash, WordPress.Security.NonceVerification.Missing
323 + // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
384 324 $file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
385 325 $file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
386 -
387 326 if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
388 - // Allow other file types to be imported
327 + // allow other file types to be imported
389 328 do_action( 'frm_before_import_' . $file_type );
390 329
391 330 return;
392 331 }
@@ -400,9 +339,10 @@
400 339 }
401 340
402 341 $set_err = libxml_use_internal_errors( true );
403 342 $loader = FrmXMLHelper::maybe_libxml_disable_entity_loader( true );
404 - $result = FrmXMLHelper::import_xml( $file );
343 +
344 + $result = FrmXMLHelper::import_xml( $file );
405 345 FrmXMLHelper::parse_message( $result, $message, $errors );
406 346
407 347 unset( $file );
408 348
@@ -411,15 +351,11 @@
411 351
412 352 self::form( $errors, $message );
413 353 }
414 354
415 - /**
416 - * @return void
417 - */
418 355 public static function export_xml() {
419 356 $error = FrmAppHelper::permission_nonce_error( 'frm_edit_forms', 'export-xml', 'export-xml-nonce' );
420 -
421 - if ( $error ) {
357 + if ( ! empty( $error ) ) {
422 358 wp_die( esc_html( $error ) );
423 359 }
424 360
425 361 $ids = FrmAppHelper::get_post_param( 'frm_export_forms', array(), 'sanitize_text_field' );
@@ -426,9 +362,9 @@
426 362 $type = FrmAppHelper::get_post_param( 'type', array(), 'sanitize_text_field' );
427 363 $format = FrmAppHelper::get_post_param( 'format', 'xml', 'sanitize_title' );
428 364
429 365 if ( ! headers_sent() && ! $type ) {
430 - wp_safe_redirect( esc_url_raw( admin_url( 'admin.php?page=formidable-import' ) ) );
366 + wp_redirect( esc_url_raw( admin_url( 'admin.php?page=formidable-import' ) ) );
431 367 die();
432 368 }
433 369
434 370 if ( 'xml' === $format ) {
@@ -441,28 +377,13 @@
441 377
442 378 wp_die();
443 379 }
444 380
445 - /**
446 - * @param array<string>|string $type
447 - * @param array $args
448 - *
449 - * @psalm-param array{ids?: mixed} $args
450 - *
451 - * @return void
452 - */
453 - public static function generate_xml( $type, $args = array() ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
381 + public static function generate_xml( $type, $args = array() ) {
454 382 global $wpdb;
455 383
456 384 self::prepare_types_array( $type );
457 385
458 - if ( ! is_array( $type ) ) {
459 - // This shouldn't be possible.
460 - // It is cast to array in prepare_types_array.
461 - // This is just for static analysis.
462 - return;
463 - }
464 -
465 386 $tables = array(
466 387 'items' => $wpdb->prefix . 'frm_items',
467 388 'forms' => $wpdb->prefix . 'frm_forms',
468 389 'posts' => $wpdb->posts,
@@ -475,9 +396,9 @@
475 396 );
476 397 $args = wp_parse_args( $args, $defaults );
477 398
478 399 // Make sure ids are numeric.
479 - if ( is_array( $args['ids'] ) && $args['ids'] ) {
400 + if ( is_array( $args['ids'] ) && ! empty( $args['ids'] ) ) {
480 401 $args['ids'] = array_filter( $args['ids'], 'is_numeric' );
481 402 }
482 403
483 404 $records = array();
@@ -482,17 +403,18 @@
482 403
483 404 $records = array();
484 405
485 406 foreach ( $type as $tb_type ) {
486 - $where = array();
487 - $join = '';
488 - $table = $tables[ $tb_type ];
407 + $where = array();
408 + $join = '';
409 + $table = $tables[ $tb_type ];
410 +
489 411 $select = $table . '.id';
490 412 $query_vars = array();
491 413
492 414 switch ( $tb_type ) {
493 415 case 'forms':
494 - // Add forms.
416 + //add forms
495 417 if ( $args['ids'] ) {
496 418 $where[] = array(
497 419 'or' => 1,
498 420 $table . '.id' => $args['ids'],
@@ -504,9 +426,8 @@
504 426 break;
505 427 case 'actions':
506 428 $select = $table . '.ID';
507 429 $where['post_type'] = FrmFormActionsController::$action_post_type;
508 -
509 430 if ( ! empty( $args['ids'] ) ) {
510 431 $where['menu_order'] = $args['ids'];
511 432 }
512 433 break;
@@ -521,12 +442,10 @@
521 442 $frm_style = new FrmStyle();
522 443 $default_style = $frm_style->get_default_style();
523 444 $form_ids = $args['ids'];
524 445 $style_ids = array();
525 -
526 446 foreach ( $form_ids as $form_id ) {
527 447 $form_data = FrmForm::getOne( $form_id );
528 -
529 448 // For forms that have not been updated while running 2.0, check if custom_style is set.
530 449 if ( isset( $form_data->options['custom_style'] ) ) {
531 450 if ( 1 === absint( $form_data->options['custom_style'] ) ) {
532 451 $style_ids[] = $default_style->ID;
@@ -535,14 +454,13 @@
535 454 }
536 455 }
537 456 unset( $form_id, $form_data );
538 457 }
539 -
540 458 $select = $table . '.ID';
541 459 $where['post_type'] = 'frm_styles';
542 460
543 461 // Only export selected styles.
544 - if ( $style_ids ) {
462 + if ( ! empty( $style_ids ) ) {
545 463 $where['ID'] = $style_ids;
546 464 }
547 465 break;
548 466 default:
@@ -554,15 +472,15 @@
554 472 $where['pm.meta_value >'] = 1;
555 473 } else {
556 474 $where['pm.meta_value'] = $args['ids'];
557 475 }
558 - }//end switch
476 + }
559 477
560 478 $records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
561 479 unset( $tb_type );
562 - }//end foreach
480 + }
563 481
564 - $filename = self::get_file_name( $args, $records );
482 + $filename = self::get_file_name( $args, $type, $records );
565 483
566 484 header( 'Content-Description: File Transfer' );
567 485 header( 'Content-Disposition: attachment; filename=' . $filename );
568 486 header( 'Content-Type: text/xml; charset=' . get_option( 'blog_charset' ), true );
@@ -570,47 +488,17 @@
570 488 echo '<?xml version="1.0" encoding="' . esc_attr( get_bloginfo( 'charset' ) ) . "\" ?>\n";
571 489 include FrmAppHelper::plugin_path() . '/classes/views/xml/xml.php';
572 490 }
573 491
574 - /**
575 - * Returns an array that has parent term slugs for the terms provided.
576 - *
577 - * @since 6.8.3
578 - *
579 - * @param array $terms
580 - *
581 - * @return array
582 - */
583 - public static function get_parent_terms_slugs( $terms ) {
584 - $parent_term_ids = array_filter( array_unique( wp_list_pluck( $terms, 'parent' ) ) );
585 - $parent_slugs = array();
586 -
587 - if ( ! $parent_term_ids ) {
588 - return $parent_slugs;
589 - }
590 -
591 - $results = FrmDb::get_results( 'terms', array( 'term_id' => $parent_term_ids ), 'term_id, slug' );
592 -
593 - return wp_list_pluck( $results, 'slug', 'term_id' );
594 - }
595 -
596 - /**
597 - * Prepare the types array.
598 - *
599 - * @param array<string>|string $type
600 - *
601 - * @return void
602 - */
603 492 private static function prepare_types_array( &$type ) {
604 493 $type = (array) $type;
605 -
606 - if ( ! in_array( 'forms', $type, true ) && ( in_array( 'items', $type, true ) || in_array( 'posts', $type, true ) ) ) {
607 - // Make sure the form is included if there are entries
494 + if ( ! in_array( 'forms', $type ) && ( in_array( 'items', $type ) || in_array( 'posts', $type ) ) ) {
495 + // make sure the form is included if there are entries
608 496 $type[] = 'forms';
609 497 }
610 498
611 - if ( in_array( 'forms', $type, true ) ) {
612 - // Include actions with forms
499 + if ( in_array( 'forms', $type ) ) {
500 + // include actions with forms
613 501 $type[] = 'actions';
614 502 }
615 503 }
616 504
@@ -619,28 +507,24 @@
619 507 * Use the nme of the form if only one form is exported.
620 508 *
621 509 * @since 3.06
622 510 *
623 - * @param array $args
511 + * @param array $type
624 512 * @param array $records
625 - *
626 513 * @return string
627 514 */
628 - private static function get_file_name( $args, $records ) {
629 - $has_one_form = ! empty( $records['forms'] ) && count( $args['ids'] ) === 1;
630 -
515 + private static function get_file_name( $args, $type, $records ) {
516 + $has_one_form = isset( $records['forms'] ) && ! empty( $records['forms'] ) && count( $args['ids'] ) === 1;
631 517 if ( $has_one_form ) {
632 - // One form is being exported
518 + // one form is being exported
633 519 $selected_form_id = reset( $args['ids'] );
634 520 $filename = 'form-' . $selected_form_id . '.xml';
635 521
636 522 foreach ( $records['forms'] as $form_id ) {
637 523 $filename = 'form-' . $form_id . '.xml';
638 -
639 524 if ( $selected_form_id === $form_id ) {
640 525 $form = FrmForm::getOne( $form_id );
641 - $filename = $form->name !== '' ? $form->name : $form->form_key;
642 - $filename = sanitize_title( $filename ) . '-form.xml';
526 + $filename = sanitize_title( $form->name ) . '-form.xml';
643 527 break;
644 528 }
645 529 }
646 530 } else {
@@ -645,14 +529,13 @@
645 529 }
646 530 } else {
647 531 $sitename = sanitize_key( get_bloginfo( 'name' ) );
648 532
649 - if ( $sitename ) {
533 + if ( ! empty( $sitename ) ) {
650 534 $sitename .= '.';
651 535 }
652 -
653 536 $filename = $sitename . 'formidable.' . gmdate( 'Y-m-d' ) . '.xml';
654 - }//end if
537 + }
655 538
656 539 /**
657 540 * @since 5.3
658 541 *
@@ -660,17 +543,11 @@
660 543 */
661 544 return apply_filters( 'frm_xml_filename', $filename );
662 545 }
663 546
664 - /**
665 - * @param array $atts
666 - *
667 - * @return void
668 - */
669 547 public static function generate_csv( $atts ) {
670 548 $form_ids = $atts['ids'];
671 -
672 - if ( ! $form_ids ) {
549 + if ( empty( $form_ids ) ) {
673 550 wp_die( esc_html__( 'Please select a form', 'formidable' ) );
674 551 }
675 552 self::csv( reset( $form_ids ) );
676 553 }
@@ -678,14 +555,8 @@
678 555 /**
679 556 * Export to CSV
680 557 *
681 558 * @since 2.0.19
682 - *
683 - * @param false|int|string $form_id
684 - * @param string $search
685 - * @param string $fid
686 - *
687 - * @return void
688 559 */
689 560 public static function csv( $form_id = false, $search = '', $fid = '' ) {
690 561 FrmAppHelper::permission_check( 'frm_view_entries' );
691 562
@@ -690,19 +561,14 @@
690 561 FrmAppHelper::permission_check( 'frm_view_entries' );
691 562
692 563 if ( ! $form_id ) {
693 564 $form_id = FrmAppHelper::get_param( 'form', '', 'get', 'sanitize_text_field' );
694 - $search = FrmAppHelper::get_param( isset( $_REQUEST['s'] ) ? 's' : 'search', '', 'get', 'sanitize_text_field' );
565 + $search = FrmAppHelper::get_param( ( isset( $_REQUEST['s'] ) ? 's' : 'search' ), '', 'get', 'sanitize_text_field' );
695 566 $fid = FrmAppHelper::get_param( 'fid', '', 'get', 'sanitize_text_field' );
696 567 }
697 568
698 - // Remove time limit to execute this function.
699 - if ( function_exists( 'set_time_limit' ) ) {
700 - set_time_limit( 0 );
701 - }
702 -
569 + set_time_limit( 0 ); //Remove time limit to execute this function
703 570 $mem_limit = str_replace( 'M', '', ini_get( 'memory_limit' ) );
704 -
705 571 if ( (int) $mem_limit < 256 ) {
706 572 wp_raise_memory_limit();
707 573 }
708 574
@@ -716,11 +582,11 @@
716 582 }
717 583
718 584 $form_id = $form->id;
719 585 $form_cols = self::get_fields_for_csv_export( $form_id, $form );
720 - $item_id = FrmAppHelper::get_param( 'item_id', 0, 'get', 'sanitize_text_field' );
721 586
722 - if ( $item_id ) {
587 + $item_id = FrmAppHelper::get_param( 'item_id', 0, 'get', 'sanitize_text_field' );
588 + if ( ! empty( $item_id ) ) {
723 589 $item_id = explode( ',', $item_id );
724 590 }
725 591
726 592 $query = array(
@@ -741,12 +607,12 @@
741 607
742 608 $entry_ids = FrmDb::get_col( $wpdb->prefix . 'frm_items it', $query );
743 609 unset( $query );
744 610
745 - if ( $entry_ids ) {
611 + if ( empty( $entry_ids ) ) {
612 + esc_html_e( 'There are no entries for that form.', 'formidable' );
613 + } else {
746 614 FrmCSVExportHelper::generate_csv( compact( 'form', 'entry_ids', 'form_cols' ) );
747 - } else {
748 - esc_html_e( 'There are no entries for that form.', 'formidable' );
749 615 }
750 616
751 617 wp_die();
752 618 }
@@ -756,17 +622,16 @@
756 622 *
757 623 * @since 2.0.19
758 624 * @since 5.0.16 function went from private to public.
759 625 *
760 - * @param int $form_id
626 + * @param int $form_id
761 627 * @param object $form
762 628 *
763 - * @return array CSV fields.
629 + * @return array $csv_fields
764 630 */
765 631 public static function get_fields_for_csv_export( $form_id, $form ) {
766 632 $csv_fields = FrmField::get_all_for_form( $form_id, '', 'include', 'include' );
767 633 $no_export_fields = FrmField::no_save_fields();
768 -
769 634 foreach ( $csv_fields as $k => $f ) {
770 635 if ( in_array( $f->type, $no_export_fields, true ) ) {
771 636 unset( $csv_fields[ $k ] );
772 637 }
@@ -774,21 +639,16 @@
774 639
775 640 return apply_filters( 'frm_fields_for_csv_export', $csv_fields, compact( 'form' ) );
776 641 }
777 642
778 - /**
779 - * @param array $mimes
780 - *
781 - * @return array
782 - */
783 643 public static function allow_mime( $mimes ) {
784 644 if ( ! isset( $mimes['csv'] ) ) {
785 - // Allow csv files
645 + // allow csv files
786 646 $mimes['csv'] = 'text/csv';
787 647 }
788 648
789 649 if ( ! isset( $mimes['xml'] ) ) {
790 - // Allow xml
650 + // allow xml
791 651 $mimes['xml'] = 'text/xml';
792 652 }
793 653
794 654 return $mimes;