PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 5.5.3
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v5.5.3
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +184 -476 6.355.5.3 View file →
@@ -6,10 +6,9 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 - * @return bool|int id on success or false on failure.
10 + * @return int|boolean id on success or false on failure
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
15 14
@@ -16,24 +15,24 @@
16 15 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
17 16
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ),
19 + 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 36 /**
38 37 * Allows modifying form options before updating or creating.
39 38 *
@@ -60,9 +59,8 @@
60 59 /**
61 60 * @since 5.0.08
62 61 *
63 62 * @param array $options
64 - *
65 63 * @return array
66 64 */
67 65 private static function maybe_filter_form_options( $options ) {
68 66 if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
@@ -71,22 +69,14 @@
71 69 return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 70 }
73 71
74 72 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 - * @return bool|int ID on success or false on failure
73 + * @return int|boolean ID on success or false on failure
83 74 */
84 75 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 76 global $wpdb;
86 77
87 78 $values = self::getOne( $id, $blog_id );
88 -
89 79 if ( ! $values ) {
90 80 return false;
91 81 }
92 82
@@ -103,10 +93,10 @@
103 93 'is_template' => $template ? 1 : 0,
104 94 );
105 95
106 96 if ( $blog_id ) {
107 - $new_values['status'] = 'published';
108 - $new_options = $values->options;
97 + $new_values['status'] = 'published';
98 + $new_options = $values->options;
109 99 FrmAppHelper::unserialize_or_decode( $new_options );
110 100 $new_options['email_to'] = get_option( 'admin_email' );
111 101 $new_options['copy'] = false;
112 102 $new_values['options'] = $new_options;
@@ -126,9 +116,9 @@
126 116
127 117 $form_id = $wpdb->insert_id;
128 118 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 119
130 - // Update form settings after fields are created
120 + // update form settings after fields are created
131 121 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 122
133 123 return $form_id;
134 124 }
@@ -135,16 +125,10 @@
135 125
136 126 return false;
137 127 }
138 128
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 129 public static function after_duplicate( $form_id, $values ) {
146 - $new_opts = $values['options'];
130 + $new_opts = $values['options'];
147 131 FrmAppHelper::unserialize_or_decode( $new_opts );
148 132 $values['options'] = $new_opts;
149 133
150 134 if ( isset( $new_opts['success_msg'] ) ) {
@@ -152,9 +136,8 @@
152 136 }
153 137
154 138 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 139
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 140 if ( $new_opts != $values['options'] ) {
158 141 global $wpdb;
159 142 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 143 }
@@ -165,24 +148,19 @@
165 148 /**
166 149 * Switches field ID in fields.
167 150 *
168 151 * @since 5.3
169 - * @since 6.35 The description column is checked too, so a field id in a description survives a
170 - * duplicate or import when the field it points at is created afterwards.
171 152 *
172 153 * @param int $form_id Form ID.
173 - *
174 - * @return void
175 154 */
176 155 private static function switch_field_ids_in_fields( $form_id ) {
177 156 global $wpdb;
178 157
179 158 // Keys of fields that you want to check to replace field ID.
180 - $keys = array( 'default_value', 'description', 'field_options' );
159 + $keys = array( 'default_value', 'field_options' );
181 160 $sql_cols = 'fi.id';
182 -
183 161 foreach ( $keys as $key ) {
184 - $sql_cols .= ',fi.' . $key;
162 + $sql_cols .= ( ',fi.' . $key );
185 163 }
186 164
187 165 $fields = FrmDb::get_results(
188 166 "{$wpdb->prefix}frm_fields AS fi LEFT OUTER JOIN {$wpdb->prefix}frm_forms AS fr ON fi.form_id = fr.id",
@@ -208,14 +186,11 @@
208 186 *
209 187 * @since 5.3
210 188 *
211 189 * @param array $field Field array.
212 - *
213 - * @return void
214 190 */
215 191 private static function switch_field_ids_in_field( $field ) {
216 192 $new_values = array();
217 -
218 193 foreach ( $field as $key => $value ) {
219 194 if ( 'id' === $key || ! $value ) {
220 195 continue;
221 196 }
@@ -235,23 +210,17 @@
235 210
236 211 if ( $new_val !== $value ) {
237 212 $new_values[ $key ] = $new_val;
238 213 }
239 - }//end foreach
214 + }
240 215
241 - if ( $new_values ) {
216 + if ( ! empty( $new_values ) ) {
242 217 FrmField::update( $field['id'], $new_values );
243 218 }
244 219 }
245 220
246 221 /**
247 - * Update a form.
248 - *
249 - * @param int $id Form ID.
250 - * @param array $values Form values to update.
251 - * @param bool $create_link Whether this is being called from link creation.
252 - *
253 - * @return bool|int
222 + * @return int|boolean
254 223 */
255 224 public static function update( $id, $values, $create_link = false ) {
256 225 global $wpdb;
257 226
@@ -265,23 +234,23 @@
265 234 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
266 235 }
267 236
268 237 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
269 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
270 238
239 + $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
240 +
271 241 foreach ( $values as $value_key => $value ) {
272 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
273 - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value;
242 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
243 + $new_values[ $value_key ] = $value;
274 244 }
275 245 }
276 246
277 - if ( ! empty( $values['new_status'] ) ) {
247 + if ( isset( $values['new_status'] ) && ! empty( $values['new_status'] ) ) {
278 248 $new_values['status'] = $values['new_status'];
279 249 }
280 250
281 - if ( $new_values ) {
251 + if ( ! empty( $new_values ) ) {
282 252 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
283 -
284 253 if ( $query_results ) {
285 254 self::clear_form_cache();
286 255 }
287 256 } else {
@@ -300,9 +269,8 @@
300 269 /**
301 270 * @param array $new_values
302 271 * @param array $values
303 272 * @param array $args
304 - *
305 273 * @return array
306 274 */
307 275 public static function set_update_options( $new_values, $values, $args = array() ) {
308 276 if ( ! isset( $values['options'] ) ) {
@@ -308,16 +276,21 @@
308 276 if ( ! isset( $values['options'] ) ) {
309 277 return $new_values;
310 278 }
311 279
312 - $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
280 + $options = isset( $values['options'] ) ? (array) $values['options'] : array();
313 281 FrmFormsHelper::fill_form_options( $options, $values );
314 282
315 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
316 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
317 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
318 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
283 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
284 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
285 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
286 + $options['submit_html'] = ( isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
319 287
288 + if ( ! empty( $options['success_url'] ) && ! empty( $args['form_id'] ) ) {
289 + $options['success_url'] = FrmFormsHelper::maybe_add_sanitize_url_attr( $options['success_url'], (int) $args['form_id'] );
290 + $values['options']['success_url'] = $options['success_url'];
291 + }
292 +
320 293 /**
321 294 * Allows modifying form options before updating or creating.
322 295 *
323 296 * @since 5.4 Added the third param.
@@ -333,14 +306,11 @@
333 306 return $new_values;
334 307 }
335 308
336 309 /**
337 - * @param int $id Form ID.
338 - * @param array $values Form values array.
339 - *
340 310 * @return array
341 311 */
342 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
312 + public static function update_fields( $id, $values ) {
343 313
344 314 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
345 315 return $values;
346 316 }
@@ -345,10 +315,9 @@
345 315 return $values;
346 316 }
347 317
348 318 $all_fields = FrmField::get_all_for_form( $id );
349 -
350 - if ( ! $all_fields ) {
319 + if ( empty( $all_fields ) ) {
351 320 return $values;
352 321 }
353 322
354 323 if ( ! isset( $values['item_meta'] ) ) {
@@ -356,28 +325,28 @@
356 325 }
357 326
358 327 $field_array = array();
359 328 $existing_keys = array_keys( $values['item_meta'] );
360 -
361 329 foreach ( $all_fields as $fid ) {
362 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
363 330 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
364 331 $values['item_meta'][ $fid->id ] = '';
365 332 }
366 -
367 333 $field_array[ $fid->id ] = $fid;
368 334 }
369 335 unset( $all_fields );
370 336
371 337 foreach ( $values['item_meta'] as $field_id => $default_value ) {
372 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
338 + if ( isset( $field_array[ $field_id ] ) ) {
339 + $field = $field_array[ $field_id ];
340 + } else {
341 + $field = FrmField::getOne( $field_id );
342 + }
373 343
374 344 if ( ! $field ) {
375 345 continue;
376 346 }
377 347
378 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
379 -
348 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
380 349 if ( $is_settings_page ) {
381 350 self::get_settings_page_html( $values, $field );
382 351
383 352 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -384,20 +353,15 @@
384 353 continue;
385 354 }
386 355 }
387 356
388 - // Updating the form.
357 + //updating the form
389 358 $update_options = FrmFieldsHelper::get_default_field_options_from_field( $field );
390 - // Don't check for POST html.
391 - unset( $update_options['custom_html'] );
359 + unset( $update_options['custom_html'] ); // don't check for POST html
392 360 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
393 361
394 - if ( ! is_array( $field->field_options ) ) {
395 - $field->field_options = array();
396 - }
397 -
398 362 foreach ( $update_options as $opt => $default ) {
399 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
363 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
400 364 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
401 365 }
402 366
403 367 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -406,104 +370,44 @@
406 370 'field_options' => $field->field_options,
407 371 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
408 372 );
409 373
410 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
411 - foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
412 - if ( ! is_array( $option ) ) {
413 - continue;
414 - }
415 -
416 - foreach ( $option as $key => $item ) {
417 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
418 - }
419 - }
420 - }
421 -
422 374 self::prepare_field_update_values( $field, $values, $new_field );
423 - self::maybe_update_max_option( $field, $values, $new_field );
424 375
425 376 FrmField::update( $field_id, $new_field );
426 377
427 378 FrmField::delete_form_transient( $field->form_id );
428 - }//end foreach
379 + }
429 380 self::clear_form_cache();
430 381
431 382 return $values;
432 383 }
433 384
434 - /**
435 - * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
436 - *
437 - * @since 6.7
438 - *
439 - * @param object $field
440 - * @param array $values
441 - * @param array $new_field
442 - *
443 - * @return void
444 - */
445 - private static function maybe_update_max_option( $field, $values, &$new_field ) {
446 - if ( $field->type !== 'textarea' ||
447 - empty( $values['field_options'][ 'type_' . $field->id ] ) ||
448 - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
449 - return;
450 - }
451 -
452 - $new_field['field_options']['max'] = '';
453 -
454 - /**
455 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
456 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
457 - */
458 - $_POST['field_options'][ 'max_' . $field->id ] = '';
459 - }
460 -
461 - /**
462 - * @param string $opt
463 - * @param mixed $value
464 - *
465 - * @return void
466 - */
467 385 private static function sanitize_field_opt( $opt, &$value ) {
468 - if ( ! is_string( $value ) ) {
469 - return;
386 + if ( is_string( $value ) ) {
387 + if ( $opt === 'calc' ) {
388 + $value = self::sanitize_calc( $value );
389 + } else {
390 + $value = FrmAppHelper::kses( $value, 'all' );
391 + }
392 + $value = trim( $value );
470 393 }
471 -
472 - /**
473 - * Allow the option to turn off sanitization for a field. This way a custom rule can be used instead.
474 - * Make sure to add custom sanitization using the frm_update_field_options filter as the data will no longer be sanitized.
475 - *
476 - * @since 6.0
477 - *
478 - * @param bool $should_sanitize
479 - * @param string $opt
480 - */
481 - $should_sanitize = apply_filters( 'frm_should_sanitize_field_opt_string', true, $opt );
482 -
483 - if ( ! $should_sanitize ) {
484 - return;
485 - }
486 -
487 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
488 - $value = trim( $value );
489 394 }
490 395
491 396 /**
492 397 * @param string $value
493 - *
494 398 * @return string
495 399 */
496 400 private static function sanitize_calc( $value ) {
497 - if ( str_contains( $value, '<' ) ) {
401 + if ( false !== strpos( $value, '<' ) ) {
498 402 $value = self::normalize_calc_spaces( $value );
499 403 }
500 - // Allow <= and >=.
501 - $allow = array( '<= ', ' >=' );
404 + $allow = array( '<= ', ' >=' ); // Allow <= and >=
502 405 $temp = array( '< = ', ' > =' );
503 406 $value = str_replace( $allow, $temp, $value );
504 407 $value = strip_tags( $value );
505 - return str_replace( $temp, $allow, $value );
408 + $value = str_replace( $temp, $allow, $value );
409 + return $value;
506 410 }
507 411
508 412 /**
509 413 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -509,58 +413,41 @@
509 413 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
510 414 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
511 415 *
512 416 * @param string $calc
513 - *
514 417 * @return string
515 418 */
516 419 private static function normalize_calc_spaces( $calc ) {
517 420 // Check for a pattern with 5 parts
518 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
421 + // $1 \d the first comparison digit.
519 422 // $2 a space (optional).
520 423 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
521 424 // $4 another space (optional).
522 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
523 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
425 + // $5 \d the second comparison digit.
426 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
524 427 }
525 428
526 429 /**
527 430 * Updating the settings page
528 - *
529 - * @param array $values Form values array.
530 - * @param object $field Field object, passed by reference.
531 - *
532 - * @return void
533 431 */
534 432 private static function get_settings_page_html( $values, &$field ) {
535 433 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
536 434 $prev_opts = array();
537 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
435 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
538 436
539 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
540 - } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
437 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
438 + } elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
541 439 $prev_opts = $field->field_options;
542 440 }
543 441
544 - if ( ! isset( $prev_opts ) ) {
545 - return;
442 + if ( isset( $prev_opts ) ) {
443 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
444 + if ( $prev_opts != $field->field_options ) {
445 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
446 + }
546 447 }
547 -
548 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
549 -
550 - // phpcs:ignore Universal.Operators.StrictComparisons
551 - if ( $prev_opts != $field->field_options ) {
552 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
553 - }
554 448 }
555 449
556 - /**
557 - * @param object $field
558 - * @param array $values
559 - * @param array $new_field
560 - *
561 - * @return void
562 - */
563 450 private static function prepare_field_update_values( $field, $values, &$new_field ) {
564 451 $field_cols = array(
565 452 'field_order' => 0,
566 453 'field_key' => '',
@@ -569,16 +456,12 @@
569 456 'description' => '',
570 457 'options' => '',
571 458 'name' => '',
572 459 );
573 -
574 460 foreach ( $field_cols as $col => $default ) {
575 - $default = $default === '' ? $field->{$col} : $default;
576 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
577 - }
461 + $default = ( $default === '' ) ? $field->{$col} : $default;
578 462
579 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
580 - $new_field['field_order'] = $field->field_order;
463 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
581 464 }
582 465
583 466 // Don't save the template option.
584 467 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -590,12 +473,9 @@
590 473 * Get a list of all form settings that should be translated
591 474 * on a multilingual site.
592 475 *
593 476 * @since 3.06.01
594 - *
595 - * @param object $form The form object.
596 - *
597 - * @return array
477 + * @param object $form - The form object
598 478 */
599 479 public static function translatable_strings( $form ) {
600 480 $strings = array(
601 481 'name',
@@ -612,21 +492,19 @@
612 492 return apply_filters( 'frm_form_strings', $strings, $form );
613 493 }
614 494
615 495 /**
616 - * @param array|int $id
617 - * @param string $status
496 + * @param string $status
618 497 *
619 - * @return bool|int
498 + * @return int|boolean
620 499 */
621 500 public static function set_status( $id, $status ) {
622 - if ( 'trash' === $status ) {
501 + if ( 'trash' == $status ) {
623 502 return self::trash( $id );
624 503 }
625 504
626 505 $statuses = array( 'published', 'draft', 'trash' );
627 -
628 - if ( ! in_array( $status, $statuses, true ) ) {
506 + if ( ! in_array( $status, $statuses ) ) {
629 507 return false;
630 508 }
631 509
632 510 global $wpdb;
@@ -639,9 +517,9 @@
639 517 );
640 518 FrmDb::get_where_clause_and_values( $where );
641 519 array_unshift( $where['values'], $status );
642 520
643 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
521 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
644 522 } else {
645 523 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
646 524 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
647 525 }
@@ -653,11 +531,9 @@
653 531 return $query_results;
654 532 }
655 533
656 534 /**
657 - * @param int|string $id Form ID.
658 - *
659 - * @return bool|int
535 + * @return int|boolean
660 536 */
661 537 public static function trash( $id ) {
662 538 if ( ! EMPTY_TRASH_DAYS ) {
663 539 return self::destroy( $id );
@@ -663,17 +539,12 @@
663 539 return self::destroy( $id );
664 540 }
665 541
666 542 $form = self::getOne( $id );
667 -
668 543 if ( ! $form ) {
669 544 return false;
670 545 }
671 546
672 - if ( $form->status === 'trash' ) {
673 - return false;
674 - }
675 -
676 547 $options = $form->options;
677 548 $options['trash_time'] = time();
678 549
679 550 global $wpdb;
@@ -706,26 +577,21 @@
706 577 return $query_results;
707 578 }
708 579
709 580 /**
710 - * @param int|string $id Form ID.
711 - *
712 - * @return bool|int
581 + * @return int|boolean
713 582 */
714 583 public static function destroy( $id ) {
715 584 global $wpdb;
716 585
717 586 $form = self::getOne( $id );
718 -
719 587 if ( ! $form ) {
720 588 return false;
721 589 }
722 -
723 590 $id = $form->id;
724 591
725 592 // Disconnect the entries from this form
726 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
727 -
593 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
728 594 foreach ( $entries as $entry_id ) {
729 595 FrmEntry::destroy( $entry_id );
730 596 unset( $entry_id );
731 597 }
@@ -730,29 +596,23 @@
730 596 unset( $entry_id );
731 597 }
732 598
733 599 // Disconnect the fields from this form
734 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
600 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
735 601
736 602 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
603 + if ( $query_results ) {
604 + // Delete all form actions linked to this form
605 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
606 + $action_control->destroy( $id, 'all' );
737 607
738 - if ( ! $query_results ) {
739 - return $query_results;
608 + // Clear form caching
609 + self::clear_form_cache();
610 +
611 + do_action( 'frm_destroy_form', $id );
612 + do_action( 'frm_destroy_form_' . $id );
740 613 }
741 614
742 - // Delete all form actions linked to this form
743 - /**
744 - * @var FrmFormAction
745 - */
746 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
747 - $action_control->destroy( $id, 'all' );
748 -
749 - // Clear form caching
750 - self::clear_form_cache();
751 -
752 - do_action( 'frm_destroy_form', $id );
753 - do_action( 'frm_destroy_form_' . $id );
754 -
755 615 return $query_results;
756 616 }
757 617
758 618 /**
@@ -757,34 +617,29 @@
757 617
758 618 /**
759 619 * Delete trashed forms based on how long they have been trashed
760 620 *
761 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
762 - *
763 621 * @return int The number of forms deleted
764 622 */
765 623 public static function scheduled_delete( $delete_timestamp = '' ) {
766 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
624 + global $wpdb;
767 625
626 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, options' );
627 +
768 628 if ( ! $trash_forms ) {
769 629 return 0;
770 630 }
771 631
772 - if ( ! $delete_timestamp ) {
632 + if ( empty( $delete_timestamp ) ) {
773 633 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
774 634 }
775 635
776 636 $count = 0;
777 -
778 637 foreach ( $trash_forms as $form ) {
779 638 FrmAppHelper::unserialize_or_decode( $form->options );
780 -
781 639 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
782 640 self::destroy( $form->id );
783 -
784 - if ( empty( $form->parent_form_id ) ) {
785 - ++$count;
786 - }
641 + $count ++;
787 642 }
788 643
789 644 unset( $form );
790 645 }
@@ -792,24 +647,23 @@
792 647 return $count;
793 648 }
794 649
795 650 /**
796 - * @param int|string $id Form ID or key.
797 - *
798 651 * @return string form name
799 652 */
800 653 public static function getName( $id ) {
801 654 $form = FrmDb::check_cache( $id, 'frm_form' );
655 + if ( $form ) {
656 + $r = stripslashes( $form->name );
802 657
803 - if ( $form ) {
804 - return stripslashes( $form->name );
658 + return $r;
805 659 }
806 660
807 661 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
808 662 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
663 + $r = stripslashes( $r );
809 664
810 - // An empty form name can result in a null value.
811 - return is_null( $r ) ? '' : stripslashes( $r );
665 + return $r;
812 666 }
813 667
814 668 /**
815 669 * @since 3.0
@@ -824,9 +678,9 @@
824 678
825 679 /**
826 680 * @since 3.0
827 681 *
828 - * @param int|string $id
682 + * @param int $id
829 683 *
830 684 * @return string form key
831 685 */
832 686 public static function get_key_by_id( $id ) {
@@ -831,57 +685,59 @@
831 685 */
832 686 public static function get_key_by_id( $id ) {
833 687 $id = (int) $id;
834 688 $cache = FrmDb::check_cache( $id, 'frm_form' );
835 -
836 689 if ( $cache ) {
837 690 return $cache->form_key;
838 691 }
839 692
840 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
693 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
694 +
695 + return $key;
841 696 }
842 697
843 698 /**
844 699 * If $form is numeric, get the form object
845 700 *
701 + * @param object|int $form
702 + *
846 703 * @since 2.0.9
847 - *
848 - * @param array|int|object $form
849 - *
850 - * @return void
851 704 */
852 705 public static function maybe_get_form( &$form ) {
853 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
706 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
854 707 $form = self::getOne( $form );
855 708 }
856 709 }
857 710
858 711 /**
859 - * @param int|string $id
860 - * @param false|int $blog_id
861 - *
862 - * @return stdClass|null
712 + * @return object form
863 713 */
864 714 public static function getOne( $id, $blog_id = false ) {
865 715 global $wpdb;
866 716
867 717 if ( $blog_id && is_multisite() ) {
868 - $prefix = $wpdb->get_blog_prefix( $blog_id );
718 + global $wpmuBaseTablePrefix;
719 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
720 +
869 721 $table_name = $prefix . 'frm_forms';
870 722 } else {
871 723 $table_name = $wpdb->prefix . 'frm_forms';
872 724 $cache = wp_cache_get( $id, 'frm_form' );
873 -
874 725 if ( $cache ) {
875 726 if ( isset( $cache->options ) ) {
876 727 FrmAppHelper::unserialize_or_decode( $cache->options );
877 728 }
878 729
879 - return self::prepare_form_row_data( $cache );
730 + return wp_unslash( $cache );
880 731 }
881 732 }
882 733
883 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
734 + if ( is_numeric( $id ) ) {
735 + $where = array( 'id' => $id );
736 + } else {
737 + $where = array( 'form_key' => $id );
738 + }
739 +
884 740 $results = FrmDb::get_row( $table_name, $where );
885 741
886 742 if ( isset( $results->options ) ) {
887 743 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -887,50 +743,18 @@
887 743 FrmDb::set_cache( $results->id, $results, 'frm_form' );
888 744 FrmAppHelper::unserialize_or_decode( $results->options );
889 745 }
890 746
891 - return self::prepare_form_row_data( $results );
747 + return apply_filters( 'frm_form_object', wp_unslash( $results ) );
892 748 }
893 749
894 750 /**
895 - * Make sure that if $row is an object, that $row->options is an array and not a string.
896 - *
897 - * @since 6.8.3
898 - *
899 - * @param stdClass|null $row The database row for a target form.
900 - *
901 - * @return stdClass|null
751 + * @return object|array of objects
902 752 */
903 - private static function prepare_form_row_data( $row ) {
904 - $row = wp_unslash( $row );
905 -
906 - if ( ! is_object( $row ) ) {
907 - return $row;
908 - }
909 -
910 - if ( ! is_array( $row->options ) ) {
911 - $row->options = FrmFormsHelper::get_default_opts();
912 - }
913 -
914 - /**
915 - * @since 4.03.02
916 - *
917 - * @param stdClass $row
918 - */
919 - return apply_filters( 'frm_form_object', $row );
920 - }
921 -
922 - /**
923 - * @param array|string $where Where conditions array or raw WHERE string.
924 - * @param string $order_by Order by clause.
925 - * @param int|string $limit Limit clause or number.
926 - *
927 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
928 - */
929 753 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
930 - if ( is_array( $where ) && $where ) {
931 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
932 - // Don't get trashed templates
754 + if ( is_array( $where ) && ! empty( $where ) ) {
755 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
756 + // don't get trashed templates
933 757 $where['status'] = array( null, '', 'published' );
934 758 }
935 759
936 760 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -936,10 +760,10 @@
936 760 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
937 761 } else {
938 762 global $wpdb;
939 763
940 - // The query has already been prepared if this is not an array.
941 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
764 + // the query has already been prepared if this is not an array
765 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
942 766 $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
943 767 }
944 768
945 769 if ( $results ) {
@@ -948,10 +772,10 @@
948 772 FrmAppHelper::unserialize_or_decode( $result->options );
949 773 }
950 774 }
951 775
952 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
953 - // Return the first form object if we are only getting one form
776 + if ( $limit == ' LIMIT 1' || $limit == 1 ) {
777 + // return the first form object if we are only getting one form
954 778 $results = reset( $results );
955 779 }
956 780
957 781 return wp_unslash( $results );
@@ -960,24 +784,20 @@
960 784 /**
961 785 * Get all published forms
962 786 *
963 787 * @since 2.0
964 - *
965 - * @param array $query
966 - * @param int $limit
967 - * @param string $inc_children
968 - *
969 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
788 + * @return array of forms
970 789 */
971 790 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
972 791 $query['is_template'] = 0;
973 792 $query['status'] = array( null, '', 'published' );
974 -
975 - if ( $inc_children === 'exclude' ) {
793 + if ( $inc_children == 'exclude' ) {
976 794 $query['parent_form_id'] = array( null, 0 );
977 795 }
978 796
979 - return self::getAll( $query, 'name', $limit );
797 + $forms = self::getAll( $query, 'name', $limit );
798 +
799 + return $forms;
980 800 }
981 801
982 802 /**
983 803 * @return object count of forms
@@ -982,16 +802,18 @@
982 802 /**
983 803 * @return object count of forms
984 804 */
985 805 public static function get_count() {
806 + global $wpdb;
807 +
986 808 $cache_key = 'frm_form_counts';
987 - $counts = wp_cache_get( $cache_key, 'frm_form' );
988 809
810 + $counts = wp_cache_get( $cache_key, 'frm_form' );
989 811 if ( false !== $counts ) {
990 812 return $counts;
991 813 }
992 814
993 - $results = FrmDb::get_results(
815 + $results = (array) FrmDb::get_results(
994 816 'frm_forms',
995 817 array(
996 818 'or' => 1,
997 819 'parent_form_id' => null,
@@ -1003,18 +825,20 @@
1003 825 $statuses = array( 'published', 'draft', 'template', 'trash' );
1004 826 $counts = array_fill_keys( $statuses, 0 );
1005 827
1006 828 foreach ( $results as $row ) {
1007 - if ( 'trash' === $row->status ) {
1008 - ++$counts['trash'];
1009 - } elseif ( $row->is_template ) {
1010 - ++$counts['template'];
829 + if ( 'trash' != $row->status ) {
830 + if ( $row->is_template ) {
831 + $counts['template'] ++;
832 + } else {
833 + $counts['published'] ++;
834 + }
1011 835 } else {
1012 - ++$counts['published'];
836 + $counts['trash'] ++;
1013 837 }
1014 838
1015 - if ( 'draft' === $row->status ) {
1016 - ++$counts['draft'];
839 + if ( 'draft' == $row->status ) {
840 + $counts['draft'] ++;
1017 841 }
1018 842
1019 843 unset( $row );
1020 844 }
@@ -1030,10 +854,8 @@
1030 854 * Called when a form is created, updated, duplicated, or deleted
1031 855 * or when the form status is changed
1032 856 *
1033 857 * @since 2.0.4
1034 - *
1035 - * @return void
1036 858 */
1037 859 public static function clear_form_cache() {
1038 860 FrmDb::cache_delete_group( 'frm_form' );
1039 861 }
@@ -1038,29 +860,23 @@
1038 860 FrmDb::cache_delete_group( 'frm_form' );
1039 861 }
1040 862
1041 863 /**
1042 - * @param array $values Form values to validate.
1043 - *
1044 864 * @return array of errors
1045 865 */
1046 866 public static function validate( $values ) {
1047 867 $errors = array();
868 +
1048 869 return apply_filters( 'frm_validate_form', $errors, $values );
1049 870 }
1050 871
1051 - /**
1052 - * @param object|null $form
1053 - *
1054 - * @return array
1055 - */
1056 872 public static function get_params( $form = null ) {
1057 873 global $frm_vars;
1058 874
1059 - if ( $form ) {
875 + if ( ! $form ) {
876 + $form = self::getAll( array(), 'name', 1 );
877 + } else {
1060 878 self::maybe_get_form( $form );
1061 - } else {
1062 - $form = self::getAll( array(), 'name', 1 );
1063 879 }
1064 880
1065 881 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1066 882 return $frm_vars['form_params'][ $form->id ];
@@ -1083,18 +899,16 @@
1083 899 );
1084 900
1085 901 $values = array();
1086 902 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1087 -
1088 903 if ( ! $values['posted_form_id'] ) {
1089 904 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1090 905 }
1091 906
1092 - // phpcs:ignore Universal.Operators.StrictComparisons
1093 907 if ( $form->id == $values['posted_form_id'] ) {
1094 - // If there are two forms on the same page, make sure not to submit both.
908 + //if there are two forms on the same page, make sure not to submit both
1095 909 foreach ( $default_values as $var => $default ) {
1096 - if ( $var === 'action' ) {
910 + if ( $var == 'action' ) {
1097 911 $values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
1098 912 } else {
1099 913 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1100 914 }
@@ -1106,9 +920,9 @@
1106 920 unset( $var, $default );
1107 921 }
1108 922 }
1109 923
1110 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
924 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
1111 925 ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
1112 926 ) {
1113 927 $values['action'] = 'new';
1114 928 }
@@ -1115,11 +929,8 @@
1115 929
1116 930 return $values;
1117 931 }
1118 932
1119 - /**
1120 - * @return array
1121 - */
1122 933 public static function list_page_params() {
1123 934 $values = array();
1124 935 $defaults = array(
1125 936 'template' => 0,
@@ -1129,9 +940,8 @@
1129 940 'search' => '',
1130 941 'sort' => '',
1131 942 'sdir' => '',
1132 943 );
1133 -
1134 944 foreach ( $defaults as $var => $default ) {
1135 945 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1136 946 }
1137 947
@@ -1137,16 +947,10 @@
1137 947
1138 948 return $values;
1139 949 }
1140 950
1141 - /**
1142 - * @param int|object|string|null $form
1143 - *
1144 - * @return array
1145 - */
1146 951 public static function get_admin_params( $form = null ) {
1147 952 $form_id = $form;
1148 -
1149 953 if ( $form === null ) {
1150 954 $form_id = self::get_current_form_id();
1151 955 } elseif ( $form && is_object( $form ) ) {
1152 956 $form_id = $form->id;
@@ -1164,9 +968,8 @@
1164 968 'sdir' => '',
1165 969 'fid' => '',
1166 970 'keep_post' => '',
1167 971 );
1168 -
1169 972 foreach ( $defaults as $var => $default ) {
1170 973 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1171 974 }
1172 975
@@ -1172,55 +975,47 @@
1172 975
1173 976 return $values;
1174 977 }
1175 978
1176 - /**
1177 - * @param string $default_form
1178 - *
1179 - * @return int|string
1180 - */
1181 979 public static function get_current_form_id( $default_form = 'none' ) {
1182 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1183 - return $form ? $form->id : 0;
980 + if ( 'first' == $default_form ) {
981 + $form = self::get_current_form();
982 + } else {
983 + $form = self::maybe_get_current_form();
984 + }
985 + $form_id = $form ? $form->id : 0;
986 +
987 + return $form_id;
1184 988 }
1185 989
1186 - /**
1187 - * @param int|string $form_id
1188 - *
1189 - * @return false|int|object|string
1190 - */
1191 990 public static function maybe_get_current_form( $form_id = 0 ) {
1192 991 global $frm_vars;
1193 992
1194 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
993 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1195 994 return $frm_vars['current_form'];
1196 995 }
1197 996
1198 997 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
998 + if ( $form_id ) {
999 + $form_id = self::set_current_form( $form_id );
1000 + }
1199 1001
1200 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
1002 + return $form_id;
1201 1003 }
1202 1004
1203 - /**
1204 - * @param int $form_id
1205 - *
1206 - * @return false|object
1207 - */
1208 1005 public static function get_current_form( $form_id = 0 ) {
1209 1006 $form = self::maybe_get_current_form( $form_id );
1210 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
1007 + if ( is_numeric( $form ) ) {
1008 + $form = self::set_current_form( $form );
1009 + }
1010 +
1011 + return $form;
1211 1012 }
1212 1013
1213 - /**
1214 - * @param int $form_id
1215 - *
1216 - * @return false|object
1217 - */
1218 1014 public static function set_current_form( $form_id ) {
1219 1015 global $frm_vars;
1220 1016
1221 1017 $query = array();
1222 -
1223 1018 if ( $form_id ) {
1224 1019 $query['id'] = $form_id;
1225 1020 }
1226 1021
@@ -1228,19 +1023,11 @@
1228 1023
1229 1024 return $frm_vars['current_form'];
1230 1025 }
1231 1026
1232 - /**
1233 - * @param object $form
1234 - * @param int|string $this_load
1235 - * @param bool $global_load
1236 - *
1237 - * @return bool
1238 - */
1239 1027 public static function is_form_loaded( $form, $this_load, $global_load ) {
1240 1028 global $frm_vars;
1241 1029 $small_form = new stdClass();
1242 -
1243 1030 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1244 1031 $small_form->{$var} = $form->{$var};
1245 1032 unset( $var );
1246 1033 }
@@ -1246,14 +1033,14 @@
1246 1033 }
1247 1034
1248 1035 $frm_vars['forms_loaded'][] = $small_form;
1249 1036
1250 - if ( $this_load && ! $global_load ) {
1037 + if ( $this_load && empty( $global_load ) ) {
1251 1038 $global_load = true;
1252 1039 $frm_vars['load_css'] = true;
1253 1040 }
1254 1041
1255 - return empty( $frm_vars['css_loaded'] ) && $global_load;
1042 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1256 1043 }
1257 1044
1258 1045 /**
1259 1046 * @since 4.06.03
@@ -1261,9 +1048,9 @@
1261 1048 * @param object $form
1262 1049 *
1263 1050 * @return bool
1264 1051 */
1265 - public static function is_visible_to_user( $form ) {
1052 + public static function &is_visible_to_user( $form ) {
1266 1053 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1267 1054 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1268 1055 } else {
1269 1056 $visible = true;
@@ -1268,39 +1055,26 @@
1268 1055 } else {
1269 1056 $visible = true;
1270 1057 }
1271 1058
1272 - /**
1273 - * @since 6.25
1274 - *
1275 - * @param bool $visible
1276 - * @param object $form
1277 - */
1278 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
1059 + return $visible;
1279 1060 }
1280 1061
1281 - /**
1282 - * @param object $form
1283 - *
1284 - * @return bool
1285 - */
1286 1062 public static function show_submit( $form ) {
1287 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1288 - return apply_filters( 'frm_show_submit_button', $show, $form );
1063 + $show = ( ! $form->is_template && $form->status == 'published' && ! FrmAppHelper::is_admin() );
1064 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
1065 +
1066 + return $show;
1289 1067 }
1290 1068
1291 1069 /**
1292 1070 * @since 2.3
1293 - *
1294 - * @param array $atts Attributes including form, option, and default.
1295 - *
1296 - * @return mixed
1297 1071 */
1298 1072 public static function get_option( $atts ) {
1299 - $form = $atts['form'];
1300 - $default = $atts['default'] ?? '';
1073 + $form = $atts['form'];
1074 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1301 1075
1302 - return $form->options[ $atts['option'] ] ?? $default;
1076 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1303 1077 }
1304 1078
1305 1079 /**
1306 1080 * Get the link to edit this form.
@@ -1305,12 +1079,9 @@
1305 1079 /**
1306 1080 * Get the link to edit this form.
1307 1081 *
1308 1082 * @since 4.0
1309 - *
1310 1083 * @param int $form_id The id of the form.
1311 - *
1312 - * @return string
1313 1084 */
1314 1085 public static function get_edit_link( $form_id ) {
1315 1086 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1316 1087 }
@@ -1315,65 +1086,9 @@
1315 1086 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1316 1087 }
1317 1088
1318 1089 /**
1319 - * Check if the "Submit this form with AJAX" setting is toggled on.
1320 - *
1321 - * @since 6.2
1322 - *
1323 - * @param stdClass $form
1324 - *
1325 - * @return bool
1326 - */
1327 - public static function is_ajax_on( $form ) {
1328 - return ! empty( $form->options['ajax_submit'] );
1329 - }
1330 -
1331 - /**
1332 - * Get the latest form available.
1333 - *
1334 - * @since 6.8
1335 - *
1336 - * @return object
1337 - */
1338 - public static function get_latest_form() {
1339 - $args = array(
1340 - array(
1341 - 'or' => 1,
1342 - 'parent_form_id' => null,
1343 - 'parent_form_id <' => 1,
1344 - ),
1345 - 'is_template' => 0,
1346 - 'status !' => 'trash',
1347 - );
1348 -
1349 - return self::getAll( $args, 'created_at desc', 1 );
1350 - }
1351 -
1352 - /**
1353 - * Count and return total forms.
1354 - *
1355 - * @since 6.8
1356 - *
1357 - * @return int
1358 - */
1359 - public static function get_forms_count() {
1360 - $args = array(
1361 - array(
1362 - 'or' => 1,
1363 - 'parent_form_id' => null,
1364 - 'parent_form_id <' => 1,
1365 - ),
1366 - 'is_template' => 0,
1367 - 'status !' => 'trash',
1368 - );
1369 -
1370 - return FrmDb::get_count( 'frm_forms', $args );
1371 - }
1372 -
1373 - /**
1374 - * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1375 - *
1090 + * @deprecated 3.0
1376 1091 * @codeCoverageIgnore
1377 1092 *
1378 1093 * @param string $key
1379 1094 *
@@ -1379,22 +1094,15 @@
1379 1094 *
1380 1095 * @return int form id
1381 1096 */
1382 1097 public static function getIdByKey( $key ) {
1383 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
1384 - return self::get_id_by_key( $key );
1098 + return FrmFormDeprecated::getIdByKey( $key );
1385 1099 }
1386 1100
1387 1101 /**
1388 - * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1389 - *
1102 + * @deprecated 3.0
1390 1103 * @codeCoverageIgnore
1391 - *
1392 - * @param int|string $id
1393 - *
1394 - * @return string
1395 1104 */
1396 1105 public static function getKeyById( $id ) {
1397 - _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );
1398 - return self::get_key_by_id( $id );
1106 + return FrmFormDeprecated::getKeyById( $id );
1399 1107 }
1400 1108 }