← All changes | classes/controllers/FrmAddonsController.php +2 -73 6.3 → 6.1 View file →

		@@ -37,11 +37,8 @@
37	37	exit;
38	38	}
39	39	}
40	40
41		- /**
42		- * @return void
43		- */
44	41	public static function list_addons() {
45	42	FrmAppHelper::include_svg();
46	43	$installed_addons = apply_filters( 'frm_installed_addons', array() );
47	44	$license_type = '';
		@@ -72,11 +69,8 @@
72	69
73	70	include( FrmAppHelper::plugin_path() . '/classes/views/addons/list.php' );
74	71	}
75	72
76		- /**
77		- * @return void
78		- */
79	73	public static function license_settings() {
80	74	$plugins = apply_filters( 'frm_installed_addons', array() );
81	75	if ( empty( $plugins ) ) {
82	76	esc_html_e( 'There are no plugins on your site that require a license', 'formidable' );
		@@ -88,11 +82,8 @@
88	82
89	83	include( FrmAppHelper::plugin_path() . '/classes/views/addons/settings.php' );
90	84	}
91	85
92		- /**
93		- * @return array
94		- */
95	86	protected static function get_api_addons() {
96	87	$api = new FrmFormApi();
97	88	$addons = $api->get_api_info();
98	89
		@@ -251,11 +242,8 @@
251	242	}
252	243
253	244	/**
254	245	* @since 4.08
255		- *
256		- * @param array $addons
257		- * @return array
258	246	*/
259	247	protected static function get_pro_from_addons( $addons ) {
260	248	return isset( $addons['93790'] ) ? $addons['93790'] : array();
261	249	}
		@@ -297,10 +285,8 @@
297	285	}
298	286
299	287	/**
300	288	* @since 4.08
301		- *
302		- * @return array|false
303	289	*/
304	290	protected static function get_primary_license_info() {
305	291	$installed_addons = apply_filters( 'frm_installed_addons', array() );
306	292	if ( empty( $installed_addons ) || ! isset( $installed_addons['formidable_pro'] ) ) {
		@@ -544,11 +530,8 @@
544	530
545	531	return $plugin;
546	532	}
547	533
548		- /**
549		- * @return void
550		- */
551	534	protected static function prepare_addons( &$addons ) {
552	535	$activate_url = '';
553	536	if ( current_user_can( 'activate_plugins' ) ) {
554	537	$activate_url = add_query_arg( array( 'action' => 'activate' ), admin_url( 'plugins.php' ) );
		@@ -606,11 +589,8 @@
606	589	$addons[ $id ] = $addon;
607	590	}
608	591	}
609	592
610		- /**
611		- * @return bool
612		- */
613	593	private static function is_plugin_active( $file_name, $slug ) {
614	594	if ( 'formidable-views/formidable-views.php' === $file_name ) {
615	595	return self::get_active_views_version() === $slug;
616	596	}
		@@ -629,10 +609,8 @@
629	609	}
630	610
631	611	/**
632	612	* @since 3.04.02
633		- *
634		- * @return void
635	613	*/
636	614	protected static function prepare_addon_link( &$link ) {
637	615	$site_url = 'https://formidableforms.com/';
638	616	if ( strpos( $link, 'http' ) !== 0 ) {
		@@ -651,10 +629,8 @@
651	629	* Add the status to the addon array. Status options are:
652	630	* installed, active, not installed
653	631	*
654	632	* @since 3.04.02
655		- *
656		- * @return void
657	633	*/
658	634	protected static function set_addon_status( &$addon ) {
659	635	if ( ! empty( $addon['activate_url'] ) ) {
660	636	$addon['status'] = array(
		@@ -673,11 +649,8 @@
673	649	);
674	650	}
675	651	}
676	652
677		- /**
678		- * @return void
679		- */
680	653	public static function upgrade_to_pro() {
681	654	FrmAppHelper::include_svg();
682	655
683	656	$link_parts = array(
		@@ -887,10 +860,8 @@
887	860	/**
888	861	* Install Pro after connection with Formidable.
889	862	*
890	863	* @since 4.02.05
891		- *
892		- * @return void
893	864	*/
894	865	public static function connect_pro() {
895	866	FrmAppHelper::permission_check( 'install_plugins' );
896	867	check_ajax_referer( 'frm_ajax', 'nonce' );
		@@ -962,10 +933,8 @@
962	933	}
963	934
964	935	/**
965	936	* @since 3.04.02
966		- *
967		- * @return void
968	937	*/
969	938	protected static function maybe_show_cred_form() {
970	939	if ( ! function_exists( 'request_filesystem_credentials' ) ) {
971	940	include_once( ABSPATH . 'wp-admin/includes/file.php' );
		@@ -1002,24 +971,8 @@
1002	971	ob_end_clean();
1003	972	}
1004	973
1005	974	/**
1006		- * Checks if an addon download url is allowed.
1007		- *
1008		- * @since 6.2
1009		- *
1010		- * @param string $download_url
1011		- *
1012		- * @return bool
1013		- */
1014		- public static function url_is_allowed( $download_url ) {
1015		- return (
1016		- FrmAppHelper::validate_url_is_in_s3_bucket( $download_url, 'zip' ) ||
1017		- ( strpos( $download_url, 'https://downloads.wordpress.org/plugin' ) === 0 && substr_compare( $download_url, '.zip', -4 ) === 0 )
1018		- );
1019		- }
1020		-
1021		- /**
1022	975	* We do not need any extra credentials if we have gotten this far,
1023	976	* so let's install the plugin.
1024	977	*
1025	978	* @since 3.04.02
		@@ -1028,9 +981,9 @@
1028	981	require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
1029	982
1030	983	$download_url = self::get_current_plugin();
1031	984
1032		- if ( ! self::url_is_allowed( $download_url ) ) {
	985	+ if ( ! FrmAppHelper::validate_url_is_in_s3_bucket( $download_url, 'zip' ) ) {
1033	986	return array(
1034	987	'message' => 'Plugin URL is not valid',
1035	988	'success' => false,
1036	989	);
		@@ -1054,10 +1007,8 @@
1054	1007	}
1055	1008
1056	1009	/**
1057	1010	* @since 3.06.03
1058		- *
1059		- * @return void
1060	1011	*/
1061	1012	public static function ajax_activate_addon() {
1062	1013
1063	1014	self::install_addon_permissions();
		@@ -1071,9 +1022,9 @@
1071	1022	wp_die();
1072	1023	}
1073	1024
1074	1025	/**
1075		- * @return array
	1026	+ * @return array|string
1076	1027	*/
1077	1028	private static function get_addon_activation_response() {
1078	1029	$activating_page = self::get_activating_page();
1079	1030
		@@ -1105,9 +1056,8 @@
1105	1056	}
1106	1057
1107	1058	/**
1108	1059	* @since 3.04.02
1109		- *
1110	1060	* @param string $installed The plugin folder name with file name
1111	1061	*/
1112	1062	protected static function maybe_activate_addon( $installed ) {
1113	1063	if ( ! $installed ) {
		@@ -1133,10 +1083,8 @@
1133	1083	/**
1134	1084	* Run security checks before installing
1135	1085	*
1136	1086	* @since 3.04.02
1137		- *
1138		- * @return void
1139	1087	*/
1140	1088	protected static function install_addon_permissions() {
1141	1089	check_ajax_referer( 'frm_ajax', 'nonce' );
1142	1090
		@@ -1147,10 +1095,8 @@
1147	1095	}
1148	1096
1149	1097	/**
1150	1098	* @since 4.08
1151		- *
1152		- * @return string
1153	1099	*/
1154	1100	public static function connect_link() {
1155	1101	$auth = get_option( 'frm_connect_token' );
1156	1102	if ( empty( $auth ) ) {
		@@ -1260,9 +1206,8 @@
1260	1206	/**
1261	1207	* Render a conditional action button for an add on
1262	1208	*
1263	1209	* @since 4.09.01
1264		- *
1265	1210	* @param array $addon
1266	1211	* @param string|false $license_type
1267	1212	* @param string $plan_required
1268	1213	* @param string $upgrade_link
		@@ -1276,12 +1221,8 @@
1276	1221	}
1277	1222
1278	1223	/**
1279	1224	* @since 4.09.01
1280		- *
1281		- * @param array|false $addon
1282		- *
1283		- * @return void
1284	1225	*/
1285	1226	protected static function addon_upgrade_link( $addon, $upgrade_link ) {
1286	1227	if ( $addon ) {
1287	1228	$upgrade_link .= '&utm_content=' . $addon['slug'];
		@@ -1299,10 +1240,8 @@
1299	1240	}
1300	1241
1301	1242	/**
1302	1243	* @since 3.04.02
1303		- *
1304		- * @return void
1305	1244	*/
1306	1245	public static function ajax_install_addon() {
1307	1246	self::install_addon_permissions();
1308	1247
		@@ -1317,12 +1256,9 @@
1317	1256	}
1318	1257
1319	1258	/**
1320	1259	* @since 4.06.02
1321		- *
1322	1260	* @deprecated 4.09.01
1323		- *
1324		- * @return void
1325	1261	*/
1326	1262	public static function ajax_multiple_addons() {
1327	1263	FrmDeprecated::ajax_multiple_addons();
1328	1264	}
		@@ -1369,14 +1305,10 @@
1369	1305	}
1370	1306
1371	1307	/**
1372	1308	* @since 3.04.03
1373		- *
1374	1309	* @deprecated 3.06
1375		- *
1376	1310	* @codeCoverageIgnore
1377		- *
1378		- * @return void
1379	1311	*/
1380	1312	public static function reset_cached_addons( $license = '' ) {
1381	1313	FrmDeprecated::reset_cached_addons( $license );
1382	1314	}
		@@ -1410,12 +1342,9 @@
1410	1342	}
1411	1343
1412	1344	/**
1413	1345	* @deprecated 3.04.03
1414		- *
1415	1346	* @codeCoverageIgnore
1416		- *
1417		- * @return void
1418	1347	*/
1419	1348	public static function get_licenses() {
1420	1349	FrmDeprecated::get_licenses();
1421	1350	}