PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.13
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.13
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +165 -308 6.356.13 View file →
@@ -6,9 +6,8 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 10 * @return bool|int id on success or false on failure.
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
@@ -16,24 +15,24 @@
16 15 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
17 16
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ),
19 + 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 36 /**
38 37 * Allows modifying form options before updating or creating.
39 38 *
@@ -60,9 +59,8 @@
60 59 /**
61 60 * @since 5.0.08
62 61 *
63 62 * @param array $options
64 - *
65 63 * @return array
66 64 */
67 65 private static function maybe_filter_form_options( $options ) {
68 66 if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
@@ -71,15 +69,8 @@
71 69 return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 70 }
73 71
74 72 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 73 * @return bool|int ID on success or false on failure
83 74 */
84 75 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 76 global $wpdb;
@@ -84,9 +75,8 @@
84 75 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 76 global $wpdb;
86 77
87 78 $values = self::getOne( $id, $blog_id );
88 -
89 79 if ( ! $values ) {
90 80 return false;
91 81 }
92 82
@@ -126,9 +116,9 @@
126 116
127 117 $form_id = $wpdb->insert_id;
128 118 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 119
130 - // Update form settings after fields are created
120 + // update form settings after fields are created
131 121 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 122
133 123 return $form_id;
134 124 }
@@ -135,14 +125,8 @@
135 125
136 126 return false;
137 127 }
138 128
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 129 public static function after_duplicate( $form_id, $values ) {
146 130 $new_opts = $values['options'];
147 131 FrmAppHelper::unserialize_or_decode( $new_opts );
148 132 $values['options'] = $new_opts;
@@ -152,9 +136,8 @@
152 136 }
153 137
154 138 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 139
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 140 if ( $new_opts != $values['options'] ) {
158 141 global $wpdb;
159 142 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 143 }
@@ -165,22 +148,17 @@
165 148 /**
166 149 * Switches field ID in fields.
167 150 *
168 151 * @since 5.3
169 - * @since 6.35 The description column is checked too, so a field id in a description survives a
170 - * duplicate or import when the field it points at is created afterwards.
171 152 *
172 153 * @param int $form_id Form ID.
173 - *
174 - * @return void
175 154 */
176 155 private static function switch_field_ids_in_fields( $form_id ) {
177 156 global $wpdb;
178 157
179 158 // Keys of fields that you want to check to replace field ID.
180 - $keys = array( 'default_value', 'description', 'field_options' );
159 + $keys = array( 'default_value', 'field_options' );
181 160 $sql_cols = 'fi.id';
182 -
183 161 foreach ( $keys as $key ) {
184 162 $sql_cols .= ',fi.' . $key;
185 163 }
186 164
@@ -208,14 +186,11 @@
208 186 *
209 187 * @since 5.3
210 188 *
211 189 * @param array $field Field array.
212 - *
213 - * @return void
214 190 */
215 191 private static function switch_field_ids_in_field( $field ) {
216 192 $new_values = array();
217 -
218 193 foreach ( $field as $key => $value ) {
219 194 if ( 'id' === $key || ! $value ) {
220 195 continue;
221 196 }
@@ -237,20 +212,14 @@
237 212 $new_values[ $key ] = $new_val;
238 213 }
239 214 }//end foreach
240 215
241 - if ( $new_values ) {
216 + if ( ! empty( $new_values ) ) {
242 217 FrmField::update( $field['id'], $new_values );
243 218 }
244 219 }
245 220
246 221 /**
247 - * Update a form.
248 - *
249 - * @param int $id Form ID.
250 - * @param array $values Form values to update.
251 - * @param bool $create_link Whether this is being called from link creation.
252 - *
253 222 * @return bool|int
254 223 */
255 224 public static function update( $id, $values, $create_link = false ) {
256 225 global $wpdb;
@@ -265,13 +234,14 @@
265 234 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
266 235 }
267 236
268 237 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
269 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
270 238
239 + $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
240 +
271 241 foreach ( $values as $value_key => $value ) {
272 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
273 - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value;
242 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
243 + $new_values[ $value_key ] = $value;
274 244 }
275 245 }
276 246
277 247 if ( ! empty( $values['new_status'] ) ) {
@@ -277,11 +247,10 @@
277 247 if ( ! empty( $values['new_status'] ) ) {
278 248 $new_values['status'] = $values['new_status'];
279 249 }
280 250
281 - if ( $new_values ) {
251 + if ( ! empty( $new_values ) ) {
282 252 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
283 -
284 253 if ( $query_results ) {
285 254 self::clear_form_cache();
286 255 }
287 256 } else {
@@ -300,9 +269,8 @@
300 269 /**
301 270 * @param array $new_values
302 271 * @param array $values
303 272 * @param array $args
304 - *
305 273 * @return array
306 274 */
307 275 public static function set_update_options( $new_values, $values, $args = array() ) {
308 276 if ( ! isset( $values['options'] ) ) {
@@ -311,12 +279,12 @@
311 279
312 280 $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
313 281 FrmFormsHelper::fill_form_options( $options, $values );
314 282
315 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
316 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
317 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
318 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
283 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
284 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
285 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
286 + $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
319 287
320 288 /**
321 289 * Allows modifying form options before updating or creating.
322 290 *
@@ -333,14 +301,11 @@
333 301 return $new_values;
334 302 }
335 303
336 304 /**
337 - * @param int $id Form ID.
338 - * @param array $values Form values array.
339 - *
340 305 * @return array
341 306 */
342 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
307 + public static function update_fields( $id, $values ) {
343 308
344 309 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
345 310 return $values;
346 311 }
@@ -345,10 +310,9 @@
345 310 return $values;
346 311 }
347 312
348 313 $all_fields = FrmField::get_all_for_form( $id );
349 -
350 - if ( ! $all_fields ) {
314 + if ( empty( $all_fields ) ) {
351 315 return $values;
352 316 }
353 317
354 318 if ( ! isset( $values['item_meta'] ) ) {
@@ -356,28 +320,28 @@
356 320 }
357 321
358 322 $field_array = array();
359 323 $existing_keys = array_keys( $values['item_meta'] );
360 -
361 324 foreach ( $all_fields as $fid ) {
362 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
363 325 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
364 326 $values['item_meta'][ $fid->id ] = '';
365 327 }
366 -
367 328 $field_array[ $fid->id ] = $fid;
368 329 }
369 330 unset( $all_fields );
370 331
371 332 foreach ( $values['item_meta'] as $field_id => $default_value ) {
372 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
333 + if ( isset( $field_array[ $field_id ] ) ) {
334 + $field = $field_array[ $field_id ];
335 + } else {
336 + $field = FrmField::getOne( $field_id );
337 + }
373 338
374 339 if ( ! $field ) {
375 340 continue;
376 341 }
377 342
378 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
379 -
343 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
380 344 if ( $is_settings_page ) {
381 345 self::get_settings_page_html( $values, $field );
382 346
383 347 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -390,14 +354,10 @@
390 354 // Don't check for POST html.
391 355 unset( $update_options['custom_html'] );
392 356 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
393 357
394 - if ( ! is_array( $field->field_options ) ) {
395 - $field->field_options = array();
396 - }
397 -
398 358 foreach ( $update_options as $opt => $default ) {
399 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
359 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
400 360 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
401 361 }
402 362
403 363 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -406,17 +366,15 @@
406 366 'field_options' => $field->field_options,
407 367 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
408 368 );
409 369
410 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
370 + if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
411 371 foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
412 - if ( ! is_array( $option ) ) {
413 - continue;
372 + if ( is_array( $option ) ) {
373 + foreach ( $option as $key => $item ) {
374 + $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
375 + }
414 376 }
415 -
416 - foreach ( $option as $key => $item ) {
417 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
418 - }
419 377 }
420 378 }
421 379
422 380 self::prepare_field_update_values( $field, $values, $new_field );
@@ -435,34 +393,31 @@
435 393 * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
436 394 *
437 395 * @since 6.7
438 396 *
439 - * @param object $field
440 - * @param array $values
441 - * @param array $new_field
442 - *
397 + * @param array $field
398 + * @param array $values
399 + * @param array $new_field
443 400 * @return void
444 401 */
445 402 private static function maybe_update_max_option( $field, $values, &$new_field ) {
446 - if ( $field->type !== 'textarea' ||
447 - empty( $values['field_options'][ 'type_' . $field->id ] ) ||
448 - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
449 - return;
450 - }
403 + if ( $field->type === 'textarea' &&
404 + ! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
405 + in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
451 406
452 - $new_field['field_options']['max'] = '';
407 + $new_field['field_options']['max'] = '';
453 408
454 - /**
455 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
456 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
457 - */
458 - $_POST['field_options'][ 'max_' . $field->id ] = '';
409 + /**
410 + * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
411 + * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
412 + */
413 + $_POST['field_options'][ 'max_' . $field->id ] = '';
414 + }
459 415 }
460 416
461 417 /**
462 418 * @param string $opt
463 419 * @param mixed $value
464 - *
465 420 * @return void
466 421 */
467 422 private static function sanitize_field_opt( $opt, &$value ) {
468 423 if ( ! is_string( $value ) ) {
@@ -483,19 +438,23 @@
483 438 if ( ! $should_sanitize ) {
484 439 return;
485 440 }
486 441
487 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
442 + if ( $opt === 'calc' ) {
443 + $value = self::sanitize_calc( $value );
444 + } else {
445 + $value = FrmAppHelper::kses( $value, 'all' );
446 + }
447 +
488 448 $value = trim( $value );
489 449 }
490 450
491 451 /**
492 452 * @param string $value
493 - *
494 453 * @return string
495 454 */
496 455 private static function sanitize_calc( $value ) {
497 - if ( str_contains( $value, '<' ) ) {
456 + if ( false !== strpos( $value, '<' ) ) {
498 457 $value = self::normalize_calc_spaces( $value );
499 458 }
500 459 // Allow <= and >=.
501 460 $allow = array( '<= ', ' >=' );
@@ -501,9 +460,10 @@
501 460 $allow = array( '<= ', ' >=' );
502 461 $temp = array( '< = ', ' > =' );
503 462 $value = str_replace( $allow, $temp, $value );
504 463 $value = strip_tags( $value );
505 - return str_replace( $temp, $allow, $value );
464 + $value = str_replace( $temp, $allow, $value );
465 + return $value;
506 466 }
507 467
508 468 /**
509 469 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -509,58 +469,41 @@
509 469 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
510 470 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
511 471 *
512 472 * @param string $calc
513 - *
514 473 * @return string
515 474 */
516 475 private static function normalize_calc_spaces( $calc ) {
517 476 // Check for a pattern with 5 parts
518 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
477 + // $1 \d the first comparison digit.
519 478 // $2 a space (optional).
520 479 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
521 480 // $4 another space (optional).
522 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
523 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
481 + // $5 \d the second comparison digit.
482 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
524 483 }
525 484
526 485 /**
527 486 * Updating the settings page
528 - *
529 - * @param array $values Form values array.
530 - * @param object $field Field object, passed by reference.
531 - *
532 - * @return void
533 487 */
534 488 private static function get_settings_page_html( $values, &$field ) {
535 489 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
536 490 $prev_opts = array();
537 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
491 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
538 492
539 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
493 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
540 494 } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
541 495 $prev_opts = $field->field_options;
542 496 }
543 497
544 - if ( ! isset( $prev_opts ) ) {
545 - return;
498 + if ( isset( $prev_opts ) ) {
499 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
500 + if ( $prev_opts != $field->field_options ) {
501 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
502 + }
546 503 }
547 -
548 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
549 -
550 - // phpcs:ignore Universal.Operators.StrictComparisons
551 - if ( $prev_opts != $field->field_options ) {
552 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
553 - }
554 504 }
555 505
556 - /**
557 - * @param object $field
558 - * @param array $values
559 - * @param array $new_field
560 - *
561 - * @return void
562 - */
563 506 private static function prepare_field_update_values( $field, $values, &$new_field ) {
564 507 $field_cols = array(
565 508 'field_order' => 0,
566 509 'field_key' => '',
@@ -569,16 +512,12 @@
569 512 'description' => '',
570 513 'options' => '',
571 514 'name' => '',
572 515 );
573 -
574 516 foreach ( $field_cols as $col => $default ) {
575 - $default = $default === '' ? $field->{$col} : $default;
576 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
577 - }
517 + $default = $default === '' ? $field->{$col} : $default;
578 518
579 - if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
580 - $new_field['field_order'] = $field->field_order;
519 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
581 520 }
582 521
583 522 // Don't save the template option.
584 523 if ( is_array( $new_field['options'] ) && isset( $new_field['options']['000'] ) ) {
@@ -590,12 +529,9 @@
590 529 * Get a list of all form settings that should be translated
591 530 * on a multilingual site.
592 531 *
593 532 * @since 3.06.01
594 - *
595 533 * @param object $form The form object.
596 - *
597 - * @return array
598 534 */
599 535 public static function translatable_strings( $form ) {
600 536 $strings = array(
601 537 'name',
@@ -612,20 +548,19 @@
612 548 return apply_filters( 'frm_form_strings', $strings, $form );
613 549 }
614 550
615 551 /**
616 - * @param array|int $id
617 - * @param string $status
552 + * @param int $id
553 + * @param string $status
618 554 *
619 555 * @return bool|int
620 556 */
621 557 public static function set_status( $id, $status ) {
622 - if ( 'trash' === $status ) {
558 + if ( 'trash' == $status ) {
623 559 return self::trash( $id );
624 560 }
625 561
626 562 $statuses = array( 'published', 'draft', 'trash' );
627 -
628 563 if ( ! in_array( $status, $statuses, true ) ) {
629 564 return false;
630 565 }
631 566
@@ -639,9 +574,9 @@
639 574 );
640 575 FrmDb::get_where_clause_and_values( $where );
641 576 array_unshift( $where['values'], $status );
642 577
643 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
578 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
644 579 } else {
645 580 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
646 581 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
647 582 }
@@ -653,10 +588,8 @@
653 588 return $query_results;
654 589 }
655 590
656 591 /**
657 - * @param int|string $id Form ID.
658 - *
659 592 * @return bool|int
660 593 */
661 594 public static function trash( $id ) {
662 595 if ( ! EMPTY_TRASH_DAYS ) {
@@ -663,17 +596,12 @@
663 596 return self::destroy( $id );
664 597 }
665 598
666 599 $form = self::getOne( $id );
667 -
668 600 if ( ! $form ) {
669 601 return false;
670 602 }
671 603
672 - if ( $form->status === 'trash' ) {
673 - return false;
674 - }
675 -
676 604 $options = $form->options;
677 605 $options['trash_time'] = time();
678 606
679 607 global $wpdb;
@@ -706,10 +634,8 @@
706 634 return $query_results;
707 635 }
708 636
709 637 /**
710 - * @param int|string $id Form ID.
711 - *
712 638 * @return bool|int
713 639 */
714 640 public static function destroy( $id ) {
715 641 global $wpdb;
@@ -714,18 +640,15 @@
714 640 public static function destroy( $id ) {
715 641 global $wpdb;
716 642
717 643 $form = self::getOne( $id );
718 -
719 644 if ( ! $form ) {
720 645 return false;
721 646 }
722 -
723 647 $id = $form->id;
724 648
725 649 // Disconnect the entries from this form
726 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
727 -
650 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
728 651 foreach ( $entries as $entry_id ) {
729 652 FrmEntry::destroy( $entry_id );
730 653 unset( $entry_id );
731 654 }
@@ -730,29 +653,23 @@
730 653 unset( $entry_id );
731 654 }
732 655
733 656 // Disconnect the fields from this form
734 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
657 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
735 658
736 659 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
660 + if ( $query_results ) {
661 + // Delete all form actions linked to this form
662 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
663 + $action_control->destroy( $id, 'all' );
737 664
738 - if ( ! $query_results ) {
739 - return $query_results;
665 + // Clear form caching
666 + self::clear_form_cache();
667 +
668 + do_action( 'frm_destroy_form', $id );
669 + do_action( 'frm_destroy_form_' . $id );
740 670 }
741 671
742 - // Delete all form actions linked to this form
743 - /**
744 - * @var FrmFormAction
745 - */
746 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
747 - $action_control->destroy( $id, 'all' );
748 -
749 - // Clear form caching
750 - self::clear_form_cache();
751 -
752 - do_action( 'frm_destroy_form', $id );
753 - do_action( 'frm_destroy_form_' . $id );
754 -
755 672 return $query_results;
756 673 }
757 674
758 675 /**
@@ -757,31 +674,28 @@
757 674
758 675 /**
759 676 * Delete trashed forms based on how long they have been trashed
760 677 *
761 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
762 - *
763 678 * @return int The number of forms deleted
764 679 */
765 680 public static function scheduled_delete( $delete_timestamp = '' ) {
766 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
681 + global $wpdb;
767 682
683 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
684 +
768 685 if ( ! $trash_forms ) {
769 686 return 0;
770 687 }
771 688
772 - if ( ! $delete_timestamp ) {
689 + if ( empty( $delete_timestamp ) ) {
773 690 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
774 691 }
775 692
776 693 $count = 0;
777 -
778 694 foreach ( $trash_forms as $form ) {
779 695 FrmAppHelper::unserialize_or_decode( $form->options );
780 -
781 696 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
782 697 self::destroy( $form->id );
783 -
784 698 if ( empty( $form->parent_form_id ) ) {
785 699 ++$count;
786 700 }
787 701 }
@@ -792,17 +706,16 @@
792 706 return $count;
793 707 }
794 708
795 709 /**
796 - * @param int|string $id Form ID or key.
797 - *
798 710 * @return string form name
799 711 */
800 712 public static function getName( $id ) {
801 713 $form = FrmDb::check_cache( $id, 'frm_form' );
714 + if ( $form ) {
715 + $r = stripslashes( $form->name );
802 716
803 - if ( $form ) {
804 - return stripslashes( $form->name );
717 + return $r;
805 718 }
806 719
807 720 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
808 721 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
@@ -807,9 +720,11 @@
807 720 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
808 721 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
809 722
810 723 // An empty form name can result in a null value.
811 - return is_null( $r ) ? '' : stripslashes( $r );
724 + $r = is_null( $r ) ? '' : stripslashes( $r );
725 +
726 + return $r;
812 727 }
813 728
814 729 /**
815 730 * @since 3.0
@@ -824,9 +739,9 @@
824 739
825 740 /**
826 741 * @since 3.0
827 742 *
828 - * @param int|string $id
743 + * @param int $id
829 744 *
830 745 * @return string form key
831 746 */
832 747 public static function get_key_by_id( $id ) {
@@ -831,14 +746,15 @@
831 746 */
832 747 public static function get_key_by_id( $id ) {
833 748 $id = (int) $id;
834 749 $cache = FrmDb::check_cache( $id, 'frm_form' );
835 -
836 750 if ( $cache ) {
837 751 return $cache->form_key;
838 752 }
839 753
840 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
754 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
755 +
756 + return $key;
841 757 }
842 758
843 759 /**
844 760 * If $form is numeric, get the form object
@@ -843,15 +759,12 @@
843 759 /**
844 760 * If $form is numeric, get the form object
845 761 *
846 762 * @since 2.0.9
847 - *
848 - * @param array|int|object $form
849 - *
850 - * @return void
763 + * @param int|object $form
851 764 */
852 765 public static function maybe_get_form( &$form ) {
853 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
766 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
854 767 $form = self::getOne( $form );
855 768 }
856 769 }
857 770
@@ -857,9 +770,8 @@
857 770
858 771 /**
859 772 * @param int|string $id
860 773 * @param false|int $blog_id
861 - *
862 774 * @return stdClass|null
863 775 */
864 776 public static function getOne( $id, $blog_id = false ) {
865 777 global $wpdb;
@@ -864,24 +776,29 @@
864 776 public static function getOne( $id, $blog_id = false ) {
865 777 global $wpdb;
866 778
867 779 if ( $blog_id && is_multisite() ) {
868 - $prefix = $wpdb->get_blog_prefix( $blog_id );
780 + global $wpmuBaseTablePrefix;
781 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
782 +
869 783 $table_name = $prefix . 'frm_forms';
870 784 } else {
871 785 $table_name = $wpdb->prefix . 'frm_forms';
872 786 $cache = wp_cache_get( $id, 'frm_form' );
873 -
874 787 if ( $cache ) {
875 788 if ( isset( $cache->options ) ) {
876 789 FrmAppHelper::unserialize_or_decode( $cache->options );
877 790 }
878 -
879 791 return self::prepare_form_row_data( $cache );
880 792 }
881 793 }
882 794
883 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
795 + if ( is_numeric( $id ) ) {
796 + $where = array( 'id' => $id );
797 + } else {
798 + $where = array( 'form_key' => $id );
799 + }
800 +
884 801 $results = FrmDb::get_row( $table_name, $where );
885 802
886 803 if ( isset( $results->options ) ) {
887 804 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -896,14 +813,12 @@
896 813 *
897 814 * @since 6.8.3
898 815 *
899 816 * @param stdClass|null $row The database row for a target form.
900 - *
901 817 * @return stdClass|null
902 818 */
903 819 private static function prepare_form_row_data( $row ) {
904 820 $row = wp_unslash( $row );
905 -
906 821 if ( ! is_object( $row ) ) {
907 822 return $row;
908 823 }
909 824
@@ -919,18 +834,14 @@
919 834 return apply_filters( 'frm_form_object', $row );
920 835 }
921 836
922 837 /**
923 - * @param array|string $where Where conditions array or raw WHERE string.
924 - * @param string $order_by Order by clause.
925 - * @param int|string $limit Limit clause or number.
926 - *
927 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
838 + * @return array|object of objects
928 839 */
929 840 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
930 - if ( is_array( $where ) && $where ) {
931 - if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
932 - // Don't get trashed templates
841 + if ( is_array( $where ) && ! empty( $where ) ) {
842 + if ( isset( $where['is_template'] ) && $where['is_template'] && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
843 + // don't get trashed templates
933 844 $where['status'] = array( null, '', 'published' );
934 845 }
935 846
936 847 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -937,9 +848,9 @@
937 848 } else {
938 849 global $wpdb;
939 850
940 851 // The query has already been prepared if this is not an array.
941 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
852 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
942 853 $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
943 854 }
944 855
945 856 if ( $results ) {
@@ -948,10 +859,10 @@
948 859 FrmAppHelper::unserialize_or_decode( $result->options );
949 860 }
950 861 }
951 862
952 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
953 - // Return the first form object if we are only getting one form
863 + if ( $limit === ' LIMIT 1' || $limit == 1 ) {
864 + // return the first form object if we are only getting one form
954 865 $results = reset( $results );
955 866 }
956 867
957 868 return wp_unslash( $results );
@@ -964,20 +875,20 @@
964 875 *
965 876 * @param array $query
966 877 * @param int $limit
967 878 * @param string $inc_children
968 - *
969 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
879 + * @return array|object of forms A single form object would be passed if $limit was set to 1.
970 880 */
971 881 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
972 882 $query['is_template'] = 0;
973 883 $query['status'] = array( null, '', 'published' );
974 -
975 884 if ( $inc_children === 'exclude' ) {
976 885 $query['parent_form_id'] = array( null, 0 );
977 886 }
978 887
979 - return self::getAll( $query, 'name', $limit );
888 + $forms = self::getAll( $query, 'name', $limit );
889 +
890 + return $forms;
980 891 }
981 892
982 893 /**
983 894 * @return object count of forms
@@ -982,16 +893,18 @@
982 893 /**
983 894 * @return object count of forms
984 895 */
985 896 public static function get_count() {
897 + global $wpdb;
898 +
986 899 $cache_key = 'frm_form_counts';
987 - $counts = wp_cache_get( $cache_key, 'frm_form' );
988 900
901 + $counts = wp_cache_get( $cache_key, 'frm_form' );
989 902 if ( false !== $counts ) {
990 903 return $counts;
991 904 }
992 905
993 - $results = FrmDb::get_results(
906 + $results = (array) FrmDb::get_results(
994 907 'frm_forms',
995 908 array(
996 909 'or' => 1,
997 910 'parent_form_id' => null,
@@ -1003,17 +916,19 @@
1003 916 $statuses = array( 'published', 'draft', 'template', 'trash' );
1004 917 $counts = array_fill_keys( $statuses, 0 );
1005 918
1006 919 foreach ( $results as $row ) {
1007 - if ( 'trash' === $row->status ) {
920 + if ( 'trash' != $row->status ) {
921 + if ( $row->is_template ) {
922 + ++$counts['template'];
923 + } else {
924 + ++$counts['published'];
925 + }
926 + } else {
1008 927 ++$counts['trash'];
1009 - } elseif ( $row->is_template ) {
1010 - ++$counts['template'];
1011 - } else {
1012 - ++$counts['published'];
1013 928 }
1014 929
1015 - if ( 'draft' === $row->status ) {
930 + if ( 'draft' == $row->status ) {
1016 931 ++$counts['draft'];
1017 932 }
1018 933
1019 934 unset( $row );
@@ -1030,10 +945,8 @@
1030 945 * Called when a form is created, updated, duplicated, or deleted
1031 946 * or when the form status is changed
1032 947 *
1033 948 * @since 2.0.4
1034 - *
1035 - * @return void
1036 949 */
1037 950 public static function clear_form_cache() {
1038 951 FrmDb::cache_delete_group( 'frm_form' );
1039 952 }
@@ -1038,29 +951,23 @@
1038 951 FrmDb::cache_delete_group( 'frm_form' );
1039 952 }
1040 953
1041 954 /**
1042 - * @param array $values Form values to validate.
1043 - *
1044 955 * @return array of errors
1045 956 */
1046 957 public static function validate( $values ) {
1047 958 $errors = array();
959 +
1048 960 return apply_filters( 'frm_validate_form', $errors, $values );
1049 961 }
1050 962
1051 - /**
1052 - * @param object|null $form
1053 - *
1054 - * @return array
1055 - */
1056 963 public static function get_params( $form = null ) {
1057 964 global $frm_vars;
1058 965
1059 - if ( $form ) {
966 + if ( ! $form ) {
967 + $form = self::getAll( array(), 'name', 1 );
968 + } else {
1060 969 self::maybe_get_form( $form );
1061 - } else {
1062 - $form = self::getAll( array(), 'name', 1 );
1063 970 }
1064 971
1065 972 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1066 973 return $frm_vars['form_params'][ $form->id ];
@@ -1083,14 +990,12 @@
1083 990 );
1084 991
1085 992 $values = array();
1086 993 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1087 -
1088 994 if ( ! $values['posted_form_id'] ) {
1089 995 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1090 996 }
1091 997
1092 - // phpcs:ignore Universal.Operators.StrictComparisons
1093 998 if ( $form->id == $values['posted_form_id'] ) {
1094 999 // If there are two forms on the same page, make sure not to submit both.
1095 1000 foreach ( $default_values as $var => $default ) {
1096 1001 if ( $var === 'action' ) {
@@ -1106,9 +1011,9 @@
1106 1011 unset( $var, $default );
1107 1012 }
1108 1013 }
1109 1014
1110 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
1015 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
1111 1016 ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
1112 1017 ) {
1113 1018 $values['action'] = 'new';
1114 1019 }
@@ -1115,11 +1020,8 @@
1115 1020
1116 1021 return $values;
1117 1022 }
1118 1023
1119 - /**
1120 - * @return array
1121 - */
1122 1024 public static function list_page_params() {
1123 1025 $values = array();
1124 1026 $defaults = array(
1125 1027 'template' => 0,
@@ -1129,9 +1031,8 @@
1129 1031 'search' => '',
1130 1032 'sort' => '',
1131 1033 'sdir' => '',
1132 1034 );
1133 -
1134 1035 foreach ( $defaults as $var => $default ) {
1135 1036 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1136 1037 }
1137 1038
@@ -1137,16 +1038,10 @@
1137 1038
1138 1039 return $values;
1139 1040 }
1140 1041
1141 - /**
1142 - * @param int|object|string|null $form
1143 - *
1144 - * @return array
1145 - */
1146 1042 public static function get_admin_params( $form = null ) {
1147 1043 $form_id = $form;
1148 -
1149 1044 if ( $form === null ) {
1150 1045 $form_id = self::get_current_form_id();
1151 1046 } elseif ( $form && is_object( $form ) ) {
1152 1047 $form_id = $form->id;
@@ -1164,9 +1059,8 @@
1164 1059 'sdir' => '',
1165 1060 'fid' => '',
1166 1061 'keep_post' => '',
1167 1062 );
1168 -
1169 1063 foreach ( $defaults as $var => $default ) {
1170 1064 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1171 1065 }
1172 1066
@@ -1172,55 +1066,47 @@
1172 1066
1173 1067 return $values;
1174 1068 }
1175 1069
1176 - /**
1177 - * @param string $default_form
1178 - *
1179 - * @return int|string
1180 - */
1181 1070 public static function get_current_form_id( $default_form = 'none' ) {
1182 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1183 - return $form ? $form->id : 0;
1071 + if ( 'first' === $default_form ) {
1072 + $form = self::get_current_form();
1073 + } else {
1074 + $form = self::maybe_get_current_form();
1075 + }
1076 + $form_id = $form ? $form->id : 0;
1077 +
1078 + return $form_id;
1184 1079 }
1185 1080
1186 - /**
1187 - * @param int|string $form_id
1188 - *
1189 - * @return false|int|object|string
1190 - */
1191 1081 public static function maybe_get_current_form( $form_id = 0 ) {
1192 1082 global $frm_vars;
1193 1083
1194 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
1084 + if ( isset( $frm_vars['current_form'] ) && $frm_vars['current_form'] && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1195 1085 return $frm_vars['current_form'];
1196 1086 }
1197 1087
1198 1088 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
1089 + if ( $form_id ) {
1090 + $form_id = self::set_current_form( $form_id );
1091 + }
1199 1092
1200 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
1093 + return $form_id;
1201 1094 }
1202 1095
1203 - /**
1204 - * @param int $form_id
1205 - *
1206 - * @return false|object
1207 - */
1208 1096 public static function get_current_form( $form_id = 0 ) {
1209 1097 $form = self::maybe_get_current_form( $form_id );
1210 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
1098 + if ( is_numeric( $form ) ) {
1099 + $form = self::set_current_form( $form );
1100 + }
1101 +
1102 + return $form;
1211 1103 }
1212 1104
1213 - /**
1214 - * @param int $form_id
1215 - *
1216 - * @return false|object
1217 - */
1218 1105 public static function set_current_form( $form_id ) {
1219 1106 global $frm_vars;
1220 1107
1221 1108 $query = array();
1222 -
1223 1109 if ( $form_id ) {
1224 1110 $query['id'] = $form_id;
1225 1111 }
1226 1112
@@ -1228,19 +1114,11 @@
1228 1114
1229 1115 return $frm_vars['current_form'];
1230 1116 }
1231 1117
1232 - /**
1233 - * @param object $form
1234 - * @param int|string $this_load
1235 - * @param bool $global_load
1236 - *
1237 - * @return bool
1238 - */
1239 1118 public static function is_form_loaded( $form, $this_load, $global_load ) {
1240 1119 global $frm_vars;
1241 1120 $small_form = new stdClass();
1242 -
1243 1121 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1244 1122 $small_form->{$var} = $form->{$var};
1245 1123 unset( $var );
1246 1124 }
@@ -1246,14 +1124,14 @@
1246 1124 }
1247 1125
1248 1126 $frm_vars['forms_loaded'][] = $small_form;
1249 1127
1250 - if ( $this_load && ! $global_load ) {
1128 + if ( $this_load && empty( $global_load ) ) {
1251 1129 $global_load = true;
1252 1130 $frm_vars['load_css'] = true;
1253 1131 }
1254 1132
1255 - return empty( $frm_vars['css_loaded'] ) && $global_load;
1133 + return ( ( ! isset( $frm_vars['css_loaded'] ) || ! $frm_vars['css_loaded'] ) && $global_load );
1256 1134 }
1257 1135
1258 1136 /**
1259 1137 * @since 4.06.03
@@ -1261,9 +1139,9 @@
1261 1139 * @param object $form
1262 1140 *
1263 1141 * @return bool
1264 1142 */
1265 - public static function is_visible_to_user( $form ) {
1143 + public static function &is_visible_to_user( $form ) {
1266 1144 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1267 1145 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1268 1146 } else {
1269 1147 $visible = true;
@@ -1268,39 +1146,26 @@
1268 1146 } else {
1269 1147 $visible = true;
1270 1148 }
1271 1149
1272 - /**
1273 - * @since 6.25
1274 - *
1275 - * @param bool $visible
1276 - * @param object $form
1277 - */
1278 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
1150 + return $visible;
1279 1151 }
1280 1152
1281 - /**
1282 - * @param object $form
1283 - *
1284 - * @return bool
1285 - */
1286 1153 public static function show_submit( $form ) {
1287 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1288 - return apply_filters( 'frm_show_submit_button', $show, $form );
1154 + $show = ( ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin() );
1155 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
1156 +
1157 + return $show;
1289 1158 }
1290 1159
1291 1160 /**
1292 1161 * @since 2.3
1293 - *
1294 - * @param array $atts Attributes including form, option, and default.
1295 - *
1296 - * @return mixed
1297 1162 */
1298 1163 public static function get_option( $atts ) {
1299 1164 $form = $atts['form'];
1300 - $default = $atts['default'] ?? '';
1165 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1301 1166
1302 - return $form->options[ $atts['option'] ] ?? $default;
1167 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1303 1168 }
1304 1169
1305 1170 /**
1306 1171 * Get the link to edit this form.
@@ -1305,12 +1170,9 @@
1305 1170 /**
1306 1171 * Get the link to edit this form.
1307 1172 *
1308 1173 * @since 4.0
1309 - *
1310 1174 * @param int $form_id The id of the form.
1311 - *
1312 - * @return string
1313 1175 */
1314 1176 public static function get_edit_link( $form_id ) {
1315 1177 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1316 1178 }
@@ -1320,9 +1182,8 @@
1320 1182 *
1321 1183 * @since 6.2
1322 1184 *
1323 1185 * @param stdClass $form
1324 - *
1325 1186 * @return bool
1326 1187 */
1327 1188 public static function is_ajax_on( $form ) {
1328 1189 return ! empty( $form->options['ajax_submit'] );
@@ -1331,12 +1192,12 @@
1331 1192 /**
1332 1193 * Get the latest form available.
1333 1194 *
1334 1195 * @since 6.8
1335 - *
1336 1196 * @return object
1337 1197 */
1338 1198 public static function get_latest_form() {
1199 +
1339 1200 $args = array(
1340 1201 array(
1341 1202 'or' => 1,
1342 1203 'parent_form_id' => null,
@@ -1352,12 +1213,12 @@
1352 1213 /**
1353 1214 * Count and return total forms.
1354 1215 *
1355 1216 * @since 6.8
1356 - *
1357 1217 * @return int
1358 1218 */
1359 1219 public static function get_forms_count() {
1220 +
1360 1221 $args = array(
1361 1222 array(
1362 1223 'or' => 1,
1363 1224 'parent_form_id' => null,
@@ -1371,13 +1232,11 @@
1371 1232 }
1372 1233
1373 1234 /**
1374 1235 * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1375 - *
1376 1236 * @codeCoverageIgnore
1377 1237 *
1378 1238 * @param string $key
1379 - *
1380 1239 * @return int form id
1381 1240 */
1382 1241 public static function getIdByKey( $key ) {
1383 1242 _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
@@ -1385,13 +1244,11 @@
1385 1244 }
1386 1245
1387 1246 /**
1388 1247 * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1389 - *
1390 1248 * @codeCoverageIgnore
1391 1249 *
1392 1250 * @param int|string $id
1393 - *
1394 1251 * @return string
1395 1252 */
1396 1253 public static function getKeyById( $id ) {
1397 1254 _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );