| @@ -9,9 +9,8 @@ | ||
| 9 | 9 | * @param int $entry_id |
| 10 | 10 | * @param int $field_id |
| 11 | 11 | * @param string $meta_key usually set to '' as this parameter is no longer used. |
| 12 | 12 | * @param mixed $meta_value |
| 13 | - * | |
| 14 | 13 | * @return int |
| 15 | 14 | */ |
| 16 | 15 | public static function add_entry_meta( $entry_id, $field_id, $meta_key, $meta_value ) { |
| 17 | 16 | global $wpdb; |
| @@ -16,9 +15,9 @@ | ||
| 16 | 15 | public static function add_entry_meta( $entry_id, $field_id, $meta_key, $meta_value ) { |
| 17 | 16 | global $wpdb; |
| 18 | 17 | |
| 19 | 18 | if ( FrmAppHelper::is_empty_value( $meta_value ) ) { |
| 20 | - // Don't save blank fields | |
| 19 | + // don't save blank fields | |
| 21 | 20 | return 0; |
| 22 | 21 | } |
| 23 | 22 | |
| 24 | 23 | $new_values = array( |
| @@ -28,18 +27,21 @@ | ||
| 28 | 27 | 'created_at' => current_time( 'mysql', 1 ), |
| 29 | 28 | ); |
| 30 | 29 | |
| 31 | 30 | self::set_value_before_save( $new_values ); |
| 32 | - $new_values = apply_filters( 'frm_add_entry_meta', $new_values ); | |
| 31 | + $new_values = apply_filters( 'frm_add_entry_meta', $new_values ); | |
| 32 | + | |
| 33 | 33 | $query_results = $wpdb->insert( $wpdb->prefix . 'frm_item_metas', $new_values ); |
| 34 | 34 | |
| 35 | 35 | if ( $query_results ) { |
| 36 | 36 | self::clear_cache(); |
| 37 | 37 | wp_cache_delete( $entry_id, 'frm_entry' ); |
| 38 | - return $wpdb->insert_id; | |
| 38 | + $id = $wpdb->insert_id; | |
| 39 | + } else { | |
| 40 | + $id = 0; | |
| 39 | 41 | } |
| 40 | 42 | |
| 41 | - return 0; | |
| 43 | + return $id; | |
| 42 | 44 | } |
| 43 | 45 | |
| 44 | 46 | /** |
| 45 | 47 | * @param int $entry_id |
| @@ -46,9 +48,9 @@ | ||
| 46 | 48 | * @param int $field_id |
| 47 | 49 | * @param string $meta_key Deprecated. |
| 48 | 50 | * @param array|string $meta_value |
| 49 | 51 | * |
| 50 | - * @return bool|int | |
| 52 | + * @return bool|false|int | |
| 51 | 53 | */ |
| 52 | 54 | public static function update_entry_meta( $entry_id, $field_id, $meta_key, $meta_value ) { |
| 53 | 55 | if ( ! $field_id ) { |
| 54 | 56 | return false; |
| @@ -67,9 +69,8 @@ | ||
| 67 | 69 | |
| 68 | 70 | if ( is_array( $values['meta_value'] ) ) { |
| 69 | 71 | $values['meta_value'] = array_filter( $values['meta_value'], 'FrmAppHelper::is_not_empty_value' ); |
| 70 | 72 | } |
| 71 | - | |
| 72 | 73 | $meta_value = maybe_serialize( $values['meta_value'] ); |
| 73 | 74 | |
| 74 | 75 | wp_cache_delete( $entry_id, 'frm_entry' ); |
| 75 | 76 | self::clear_cache(); |
| @@ -78,31 +79,20 @@ | ||
| 78 | 79 | } |
| 79 | 80 | |
| 80 | 81 | /** |
| 81 | 82 | * @since 3.0 |
| 82 | - * | |
| 83 | - * @param array $values | |
| 84 | - * | |
| 85 | - * @return void | |
| 86 | 83 | */ |
| 87 | 84 | private static function set_value_before_save( &$values ) { |
| 88 | 85 | $field = FrmField::getOne( $values['field_id'] ); |
| 86 | + if ( $field ) { | |
| 87 | + $field_obj = FrmFieldFactory::get_field_object( $field ); | |
| 89 | 88 | |
| 90 | - if ( ! $field ) { | |
| 91 | - return; | |
| 89 | + $values['meta_value'] = $field_obj->set_value_before_save( $values['meta_value'] ); | |
| 92 | 90 | } |
| 93 | - | |
| 94 | - $field_obj = FrmFieldFactory::get_field_object( $field ); | |
| 95 | - $values['meta_value'] = $field_obj->set_value_before_save( $values['meta_value'] ); | |
| 96 | 91 | } |
| 97 | 92 | |
| 98 | 93 | /** |
| 99 | 94 | * @since 3.0 |
| 100 | - * | |
| 101 | - * @param array $atts | |
| 102 | - * @param mixed $value | |
| 103 | - * | |
| 104 | - * @return void | |
| 105 | 95 | */ |
| 106 | 96 | private static function get_value_to_save( $atts, &$value ) { |
| 107 | 97 | if ( is_object( $atts['field'] ) ) { |
| 108 | 98 | $field_obj = FrmFieldFactory::get_field_object( $atts['field'] ); |
| @@ -120,9 +110,8 @@ | ||
| 120 | 110 | |
| 121 | 111 | /** |
| 122 | 112 | * @param int|string $entry_id |
| 123 | 113 | * @param array $values Either indexed by field ID or field key. |
| 124 | - * | |
| 125 | 114 | * @return void |
| 126 | 115 | */ |
| 127 | 116 | public static function update_entry_metas( $entry_id, $values ) { |
| 128 | 117 | global $wpdb; |
| @@ -136,9 +125,8 @@ | ||
| 136 | 125 | 'field_id' |
| 137 | 126 | ); |
| 138 | 127 | |
| 139 | 128 | $values_indexed_by_field_id = array(); |
| 140 | - | |
| 141 | 129 | foreach ( $values as $field_id_or_key => $meta_value ) { |
| 142 | 130 | $field_id = $field_id_or_key; |
| 143 | 131 | $field = null; |
| 144 | 132 | |
| @@ -153,24 +141,24 @@ | ||
| 153 | 141 | $values_indexed_by_field_id[ $field_id ] = $meta_value; |
| 154 | 142 | |
| 155 | 143 | self::get_value_to_save( compact( 'field', 'field_id', 'entry_id' ), $meta_value ); |
| 156 | 144 | |
| 157 | - if ( ! $previous_field_ids || ! in_array( $field_id, $previous_field_ids, true ) ) { | |
| 158 | - // If value does not exist, then create it | |
| 159 | - self::add_entry_meta( $entry_id, $field_id, '', $meta_value ); | |
| 160 | - continue; | |
| 161 | - } | |
| 145 | + if ( $previous_field_ids && in_array( $field_id, $previous_field_ids ) ) { | |
| 162 | 146 | |
| 163 | - if ( $meta_value === array() || ( ! is_array( $meta_value ) && trim( $meta_value ) === '' ) ) { | |
| 164 | - // Remove blank fields. | |
| 165 | - unset( $values_indexed_by_field_id[ $field_id ] ); | |
| 147 | + if ( ( is_array( $meta_value ) && empty( $meta_value ) ) || ( ! is_array( $meta_value ) && trim( $meta_value ) == '' ) ) { | |
| 148 | + // Remove blank fields. | |
| 149 | + unset( $values_indexed_by_field_id[ $field_id ] ); | |
| 150 | + } else { | |
| 151 | + // if value exists, then update it | |
| 152 | + self::update_entry_meta( $entry_id, $field_id, '', $meta_value ); | |
| 153 | + } | |
| 166 | 154 | } else { |
| 167 | - // If value exists, then update it | |
| 168 | - self::update_entry_meta( $entry_id, $field_id, '', $meta_value ); | |
| 155 | + // if value does not exist, then create it | |
| 156 | + self::add_entry_meta( $entry_id, $field_id, '', $meta_value ); | |
| 169 | 157 | } |
| 170 | 158 | }//end foreach |
| 171 | 159 | |
| 172 | - if ( ! $previous_field_ids ) { | |
| 160 | + if ( empty( $previous_field_ids ) ) { | |
| 173 | 161 | return; |
| 174 | 162 | } |
| 175 | 163 | |
| 176 | 164 | $field_ids_to_remove = array_diff( $previous_field_ids, array_keys( $values_indexed_by_field_id ) ); |
| @@ -178,9 +166,9 @@ | ||
| 178 | 166 | if ( ! $field_ids_to_remove ) { |
| 179 | 167 | return; |
| 180 | 168 | } |
| 181 | 169 | |
| 182 | - // Prepare the query | |
| 170 | + // prepare the query | |
| 183 | 171 | $where = array( |
| 184 | 172 | 'item_id' => $entry_id, |
| 185 | 173 | 'field_id' => $field_ids_to_remove, |
| 186 | 174 | ); |
| @@ -186,18 +174,12 @@ | ||
| 186 | 174 | ); |
| 187 | 175 | FrmDb::get_where_clause_and_values( $where ); |
| 188 | 176 | |
| 189 | 177 | // Delete any leftovers |
| 190 | - $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_item_metas ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 178 | + $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_item_metas ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared | |
| 191 | 179 | self::clear_cache(); |
| 192 | 180 | } |
| 193 | 181 | |
| 194 | - /** | |
| 195 | - * @param int $old_id | |
| 196 | - * @param int $new_id | |
| 197 | - * | |
| 198 | - * @return void | |
| 199 | - */ | |
| 200 | 182 | public static function duplicate_entry_metas( $old_id, $new_id ) { |
| 201 | 183 | $metas = self::get_entry_meta_info( $old_id ); |
| 202 | 184 | |
| 203 | 185 | /** |
| @@ -207,9 +189,8 @@ | ||
| 207 | 189 | * |
| 208 | 190 | * @param array $metas The list of entry meta values. |
| 209 | 191 | */ |
| 210 | 192 | $metas = apply_filters( 'frm_before_duplicate_entry_values', $metas ); |
| 211 | - | |
| 212 | 193 | foreach ( $metas as $meta ) { |
| 213 | 194 | self::add_entry_meta( $new_id, $meta->field_id, '', $meta->meta_value ); |
| 214 | 195 | unset( $meta ); |
| 215 | 196 | } |
| @@ -215,14 +196,8 @@ | ||
| 215 | 196 | } |
| 216 | 197 | self::clear_cache(); |
| 217 | 198 | } |
| 218 | 199 | |
| 219 | - /** | |
| 220 | - * @param int $entry_id | |
| 221 | - * @param int $field_id | |
| 222 | - * | |
| 223 | - * @return false|int | |
| 224 | - */ | |
| 225 | 200 | public static function delete_entry_meta( $entry_id, $field_id ) { |
| 226 | 201 | global $wpdb; |
| 227 | 202 | self::clear_cache(); |
| 228 | 203 | |
| @@ -233,10 +208,8 @@ | ||
| 233 | 208 | * Clear entry meta caching |
| 234 | 209 | * Called when a meta is added or changed |
| 235 | 210 | * |
| 236 | 211 | * @since 2.0.5 |
| 237 | - * | |
| 238 | - * @return void | |
| 239 | 212 | */ |
| 240 | 213 | public static function clear_cache() { |
| 241 | 214 | FrmDb::cache_delete_group( 'frm_entry_meta' ); |
| 242 | 215 | FrmDb::cache_delete_group( 'frm_item_meta' ); |
| @@ -246,24 +219,17 @@ | ||
| 246 | 219 | * @since 2.0.9 |
| 247 | 220 | * |
| 248 | 221 | * @param stdClass $entry |
| 249 | 222 | * @param int|string $field_id |
| 250 | - * | |
| 251 | 223 | * @return mixed |
| 252 | 224 | */ |
| 253 | 225 | public static function get_meta_value( $entry, $field_id ) { |
| 254 | 226 | if ( isset( $entry->metas ) ) { |
| 255 | - return $entry->metas[ $field_id ] ?? false; | |
| 227 | + return isset( $entry->metas[ $field_id ] ) ? $entry->metas[ $field_id ] : false; | |
| 256 | 228 | } |
| 257 | 229 | return self::get_entry_meta_by_field( $entry->id, $field_id ); |
| 258 | 230 | } |
| 259 | 231 | |
| 260 | - /** | |
| 261 | - * @param int|object|string $entry_id | |
| 262 | - * @param int|string $field_id This function supports field keys as field id. | |
| 263 | - * | |
| 264 | - * @return mixed | |
| 265 | - */ | |
| 266 | 232 | public static function get_entry_meta_by_field( $entry_id, $field_id ) { |
| 267 | 233 | global $wpdb; |
| 268 | 234 | |
| 269 | 235 | if ( is_object( $entry_id ) ) { |
| @@ -276,38 +242,31 @@ | ||
| 276 | 242 | } |
| 277 | 243 | |
| 278 | 244 | if ( $cached && isset( $cached->metas ) && isset( $cached->metas[ $field_id ] ) ) { |
| 279 | 245 | $result = $cached->metas[ $field_id ]; |
| 246 | + | |
| 280 | 247 | return wp_unslash( $result ); |
| 281 | 248 | } |
| 282 | 249 | |
| 283 | 250 | $get_table = $wpdb->prefix . 'frm_item_metas'; |
| 284 | 251 | $query = array( 'item_id' => $entry_id ); |
| 285 | - | |
| 286 | 252 | if ( is_numeric( $field_id ) ) { |
| 287 | - // Query by field ID. | |
| 288 | 253 | $query['field_id'] = $field_id; |
| 289 | 254 | } else { |
| 290 | - // Query by field key. | |
| 291 | - $get_table .= ' it JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id'; | |
| 255 | + $get_table .= ' it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id'; | |
| 292 | 256 | $query['fi.field_key'] = $field_id; |
| 293 | 257 | } |
| 294 | 258 | |
| 295 | - $result = FrmDb::get_var( $get_table, $query, 'meta_value' ); | |
| 259 | + $result = FrmDb::get_var( $get_table, $query, 'meta_value' ); | |
| 260 | + | |
| 296 | 261 | $field_type = FrmField::get_type( $field_id ); |
| 297 | 262 | FrmFieldsHelper::prepare_field_value( $result, $field_type ); |
| 298 | 263 | |
| 299 | - return wp_unslash( $result ); | |
| 264 | + $result = wp_unslash( $result ); | |
| 265 | + | |
| 266 | + return $result; | |
| 300 | 267 | } |
| 301 | 268 | |
| 302 | - /** | |
| 303 | - * @param int|string $field_id | |
| 304 | - * @param string $order | |
| 305 | - * @param string $limit | |
| 306 | - * @param array $args | |
| 307 | - * | |
| 308 | - * @return array | |
| 309 | - */ | |
| 310 | 269 | public static function get_entry_metas_for_field( $field_id, $order = '', $limit = '', $args = array() ) { |
| 311 | 270 | $defaults = array( |
| 312 | 271 | 'value' => false, |
| 313 | 272 | 'unique' => false, |
| @@ -314,11 +273,13 @@ | ||
| 314 | 273 | 'stripslashes' => true, |
| 315 | 274 | 'is_draft' => false, |
| 316 | 275 | ); |
| 317 | 276 | $args = wp_parse_args( $args, $defaults ); |
| 318 | - $query = array(); | |
| 277 | + | |
| 278 | + $query = array(); | |
| 319 | 279 | self::meta_field_query( $field_id, $order, $limit, $args, $query ); |
| 320 | - $query = implode( ' ', $query ); | |
| 280 | + $query = implode( ' ', $query ); | |
| 281 | + | |
| 321 | 282 | $cache_key = 'entry_metas_for_field_' . $field_id . $order . $limit . FrmAppHelper::maybe_json_encode( $args ); |
| 322 | 283 | $values = FrmDb::check_cache( $cache_key, 'frm_entry', $query, 'get_col' ); |
| 323 | 284 | |
| 324 | 285 | if ( ! $args['stripslashes'] ) { |
| @@ -339,10 +300,8 @@ | ||
| 339 | 300 | * @param string $order |
| 340 | 301 | * @param string $limit |
| 341 | 302 | * @param array $args |
| 342 | 303 | * @param array $query |
| 343 | - * | |
| 344 | - * @return void | |
| 345 | 304 | */ |
| 346 | 305 | private static function meta_field_query( $field_id, $order, $limit, $args, array &$query ) { |
| 347 | 306 | global $wpdb; |
| 348 | 307 | $query[] = 'SELECT'; |
| @@ -365,17 +324,11 @@ | ||
| 365 | 324 | |
| 366 | 325 | if ( $args['value'] ) { |
| 367 | 326 | $query[] = $wpdb->prepare( ' AND meta_value=%s', $args['value'] ); |
| 368 | 327 | } |
| 369 | - | |
| 370 | 328 | $query[] = $order . $limit; |
| 371 | 329 | } |
| 372 | 330 | |
| 373 | - /** | |
| 374 | - * @param int|string $entry_id | |
| 375 | - * | |
| 376 | - * @return array | |
| 377 | - */ | |
| 378 | 331 | public static function get_entry_meta_info( $entry_id ) { |
| 379 | 332 | return FrmDb::get_results( 'frm_item_metas', array( 'item_id' => $entry_id ) ); |
| 380 | 333 | } |
| 381 | 334 | |
| @@ -383,22 +336,19 @@ | ||
| 383 | 336 | * @param array $where |
| 384 | 337 | * @param string $order_by |
| 385 | 338 | * @param string $limit |
| 386 | 339 | * @param bool $stripslashes |
| 387 | - * | |
| 388 | - * @return mixed | |
| 340 | + * @return array | |
| 389 | 341 | */ |
| 390 | 342 | public static function getAll( $where = array(), $order_by = '', $limit = '', $stripslashes = false ) { |
| 391 | 343 | global $wpdb; |
| 392 | - // phpcs:disable Generic.WhiteSpace.ScopeIndent | |
| 393 | 344 | $query = 'SELECT it.*, fi.type as field_type, fi.field_key as field_key, |
| 394 | 345 | fi.required as required, fi.form_id as field_form_id, fi.name as field_name, fi.options as fi_options |
| 395 | 346 | FROM ' . $wpdb->prefix . 'frm_item_metas it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id' . |
| 396 | 347 | FrmDb::prepend_and_or_where( ' WHERE ', $where ) . $order_by . $limit; |
| 397 | - // phpcs:enable Generic.WhiteSpace.ScopeIndent | |
| 398 | 348 | |
| 399 | 349 | $cache_key = 'all_' . FrmAppHelper::maybe_json_encode( $where ) . $order_by . $limit; |
| 400 | - $results = FrmDb::check_cache( $cache_key, 'frm_entry', $query, $limit === ' LIMIT 1' ? 'get_row' : 'get_results' ); | |
| 350 | + $results = FrmDb::check_cache( $cache_key, 'frm_entry', $query, ( $limit == ' LIMIT 1' ? 'get_row' : 'get_results' ) ); | |
| 401 | 351 | |
| 402 | 352 | if ( ! $results || ! $stripslashes ) { |
| 403 | 353 | return $results; |
| 404 | 354 | } |
| @@ -411,17 +361,8 @@ | ||
| 411 | 361 | |
| 412 | 362 | return $results; |
| 413 | 363 | } |
| 414 | 364 | |
| 415 | - /** | |
| 416 | - * @param array|string $where | |
| 417 | - * @param string $order_by | |
| 418 | - * @param string $limit | |
| 419 | - * @param bool $unique | |
| 420 | - * @param array $args | |
| 421 | - * | |
| 422 | - * @return array|string|null | |
| 423 | - */ | |
| 424 | 365 | public static function getEntryIds( $where = array(), $order_by = '', $limit = '', $unique = true, $args = array() ) { |
| 425 | 366 | $defaults = array( |
| 426 | 367 | 'is_draft' => false, |
| 427 | 368 | 'user_id' => '', |
| @@ -427,11 +368,13 @@ | ||
| 427 | 368 | 'user_id' => '', |
| 428 | 369 | 'group_by' => '', |
| 429 | 370 | ); |
| 430 | 371 | $args = wp_parse_args( $args, $defaults ); |
| 431 | - $query = array(); | |
| 372 | + | |
| 373 | + $query = array(); | |
| 432 | 374 | self::get_ids_query( $where, $order_by, $limit, $unique, $args, $query ); |
| 433 | - $query = implode( ' ', $query ); | |
| 375 | + $query = implode( ' ', $query ); | |
| 376 | + | |
| 434 | 377 | $cache_key = 'ids_' . FrmAppHelper::maybe_json_encode( $where ) . $order_by . 'l' . $limit . 'u' . $unique . FrmAppHelper::maybe_json_encode( $args ); |
| 435 | 378 | $type = 'get_' . ( ' LIMIT 1' === $limit ? 'var' : 'col' ); |
| 436 | 379 | return FrmDb::check_cache( $cache_key, 'frm_entry', $query, $type ); |
| 437 | 380 | } |
| @@ -441,9 +384,8 @@ | ||
| 441 | 384 | * If a child entry id is matched, its parent will be returned in its place |
| 442 | 385 | * |
| 443 | 386 | * @param array $query |
| 444 | 387 | * @param array $args |
| 445 | - * | |
| 446 | 388 | * @return array |
| 447 | 389 | */ |
| 448 | 390 | public static function get_top_level_entry_ids( $query, $args ) { |
| 449 | 391 | $args['return_parent_id_if_0_return_id'] = true; |
| @@ -450,54 +392,13 @@ | ||
| 450 | 392 | return self::getEntryIds( $query, '', '', true, $args ); |
| 451 | 393 | } |
| 452 | 394 | |
| 453 | 395 | /** |
| 454 | - * Returns true if the where clause refers to a field table column that is not form_id. It also updates | |
| 455 | - * the where clause to refer to the entry table for form_id if fields table should not be joined. | |
| 456 | - * | |
| 457 | - * @since 6.16.1 | |
| 458 | - * | |
| 459 | 396 | * @param array|string $where |
| 460 | - * | |
| 461 | - * @return bool | |
| 462 | - */ | |
| 463 | - private static function should_join_fields_table( &$where ) { | |
| 464 | - if ( is_string( $where ) ) { | |
| 465 | - if ( preg_match( '/\bfi\.(?!form_id)\w+/i', $where ) ) { | |
| 466 | - return true; | |
| 467 | - } | |
| 468 | - | |
| 469 | - $where = str_ireplace( 'fi.form_id', 'e.form_id', $where ); | |
| 470 | - return false; | |
| 471 | - } | |
| 472 | - | |
| 473 | - $where_fields = array_keys( $where ); | |
| 474 | - | |
| 475 | - foreach ( $where_fields as $where_field ) { | |
| 476 | - if ( str_starts_with( $where_field, 'fi.' ) && 'fi.form_id' !== $where_field ) { | |
| 477 | - return true; | |
| 478 | - } | |
| 479 | - } | |
| 480 | - | |
| 481 | - if ( isset( $where['fi.form_id'] ) ) { | |
| 482 | - $where['e.form_id'] = $where['fi.form_id']; | |
| 483 | - unset( $where['fi.form_id'] ); | |
| 484 | - } | |
| 485 | - | |
| 486 | - return false; | |
| 487 | - } | |
| 488 | - | |
| 489 | - /** | |
| 490 | - * @param array|string $where | |
| 491 | 397 | * @param string $order_by |
| 492 | 398 | * @param string $limit |
| 493 | - * @param bool $unique | |
| 494 | - * @param array $args | |
| 495 | - * @param array $query | |
| 496 | - * | |
| 497 | - * @return void | |
| 498 | 399 | */ |
| 499 | - private static function get_ids_query( $where, $order_by, $limit, $unique, $args, array &$query ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 400 | + private static function get_ids_query( $where, $order_by, $limit, $unique, $args, array &$query ) { | |
| 500 | 401 | global $wpdb; |
| 501 | 402 | $query[] = 'SELECT'; |
| 502 | 403 | $defaults = array( |
| 503 | 404 | 'return_parent_id' => false, |
| @@ -516,27 +417,23 @@ | ||
| 516 | 417 | } else { |
| 517 | 418 | $query[] = 'it.item_id'; |
| 518 | 419 | } |
| 519 | 420 | |
| 520 | - $from = 'FROM ' . $wpdb->prefix . 'frm_item_metas it'; | |
| 521 | - $should_join_fields_table__where = self::should_join_fields_table( $where ); | |
| 522 | - $should_join_fields_table__order_by = self::should_join_fields_table( $order_by ); | |
| 421 | + $query[] = 'FROM ' . $wpdb->prefix . 'frm_item_metas it LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id'; | |
| 523 | 422 | |
| 524 | - if ( $should_join_fields_table__where || $should_join_fields_table__order_by ) { | |
| 525 | - $from .= ' LEFT OUTER JOIN ' . $wpdb->prefix . 'frm_fields fi ON it.field_id=fi.id'; | |
| 526 | - } | |
| 527 | - | |
| 528 | - $query[] = $from; | |
| 529 | 423 | $query[] = 'INNER JOIN ' . $wpdb->prefix . 'frm_items e ON (e.id=it.item_id)'; |
| 530 | - | |
| 531 | 424 | if ( is_array( $where ) ) { |
| 532 | 425 | if ( ! $args['is_draft'] ) { |
| 533 | 426 | $where['e.is_draft'] = 0; |
| 534 | 427 | } elseif ( is_numeric( $args['is_draft'] ) ) { |
| 535 | - $where['e.is_draft'] = class_exists( 'FrmAbandonmentHooksController', false ) ? absint( $args['is_draft'] ) : 1; | |
| 428 | + if ( class_exists( 'FrmAbandonmentHooksController', false ) ) { | |
| 429 | + $where['e.is_draft'] = absint( $args['is_draft'] ); | |
| 430 | + } else { | |
| 431 | + $where['e.is_draft'] = 1; | |
| 432 | + } | |
| 536 | 433 | } elseif ( 'both' === $args['is_draft'] && class_exists( 'FrmAbandonmentHooksController', false ) ) { |
| 537 | 434 | $where['e.is_draft'] = array( 0, 1 ); |
| 538 | - } elseif ( str_contains( $args['is_draft'], ',' ) ) { | |
| 435 | + } elseif ( false !== strpos( $args['is_draft'], ',' ) ) { | |
| 539 | 436 | $is_draft = array_reduce( |
| 540 | 437 | explode( ',', $args['is_draft'] ), |
| 541 | 438 | function ( $total, $current ) { |
| 542 | 439 | if ( is_numeric( $current ) ) { |
| @@ -545,9 +442,8 @@ | ||
| 545 | 442 | return $total; |
| 546 | 443 | }, |
| 547 | 444 | array() |
| 548 | 445 | ); |
| 549 | - | |
| 550 | 446 | if ( $is_draft ) { |
| 551 | 447 | $where['e.is_draft'] = $is_draft; |
| 552 | 448 | } |
| 553 | 449 | }//end if |
| @@ -554,9 +450,8 @@ | ||
| 554 | 450 | |
| 555 | 451 | if ( ! empty( $args['user_id'] ) ) { |
| 556 | 452 | $where['e.user_id'] = $args['user_id']; |
| 557 | 453 | } |
| 558 | - | |
| 559 | 454 | $query[] = FrmDb::prepend_and_or_where( ' WHERE ', $where ) . $order_by . $limit; |
| 560 | 455 | |
| 561 | 456 | if ( $args['group_by'] ) { |
| 562 | 457 | $query[] = ' GROUP BY ' . sanitize_text_field( $args['group_by'] ); |
| @@ -566,12 +461,11 @@ | ||
| 566 | 461 | }//end if |
| 567 | 462 | |
| 568 | 463 | $draft_where = ''; |
| 569 | 464 | $user_where = ''; |
| 570 | - | |
| 571 | 465 | if ( ! $args['is_draft'] ) { |
| 572 | 466 | $draft_where = $wpdb->prepare( ' AND e.is_draft=%d', 0 ); |
| 573 | - } elseif ( $args['is_draft'] == 1 ) { // phpcs:ignore Universal.Operators.StrictComparisons | |
| 467 | + } elseif ( $args['is_draft'] == 1 ) { | |
| 574 | 468 | $draft_where = $wpdb->prepare( ' AND e.is_draft=%d', 1 ); |
| 575 | 469 | } |
| 576 | 470 | |
| 577 | 471 | if ( ! empty( $args['user_id'] ) ) { |
| @@ -577,10 +471,10 @@ | ||
| 577 | 471 | if ( ! empty( $args['user_id'] ) ) { |
| 578 | 472 | $user_where = $wpdb->prepare( ' AND e.user_id=%d', $args['user_id'] ); |
| 579 | 473 | } |
| 580 | 474 | |
| 581 | - if ( str_contains( $where, ' GROUP BY ' ) ) { | |
| 582 | - // Don't inject WHERE filtering after GROUP BY | |
| 475 | + if ( strpos( $where, ' GROUP BY ' ) ) { | |
| 476 | + // don't inject WHERE filtering after GROUP BY | |
| 583 | 477 | $parts = explode( ' GROUP BY ', $where ); |
| 584 | 478 | $where = $parts[0]; |
| 585 | 479 | $where .= $draft_where . $user_where; |
| 586 | 480 | $where .= ' GROUP BY ' . $parts[1]; |
| @@ -591,30 +485,20 @@ | ||
| 591 | 485 | // The query has already been prepared |
| 592 | 486 | $query[] = FrmDb::prepend_and_or_where( ' WHERE ', $where ) . $order_by . $limit; |
| 593 | 487 | } |
| 594 | 488 | |
| 595 | - /** | |
| 596 | - * @param array|string $search | |
| 597 | - * @param int|string $field_id | |
| 598 | - * @param string $operator | |
| 599 | - * | |
| 600 | - * @return array | |
| 601 | - */ | |
| 602 | 489 | public static function search_entry_metas( $search, $field_id, $operator ) { |
| 603 | 490 | $cache_key = 'search_' . FrmAppHelper::maybe_json_encode( $search ) . $field_id . $operator; |
| 604 | 491 | $results = wp_cache_get( $cache_key, 'frm_entry' ); |
| 605 | - | |
| 606 | 492 | if ( false !== $results ) { |
| 607 | 493 | return $results; |
| 608 | 494 | } |
| 609 | 495 | |
| 610 | 496 | global $wpdb; |
| 611 | - | |
| 612 | 497 | if ( is_array( $search ) ) { |
| 613 | 498 | $where = ''; |
| 614 | - | |
| 615 | 499 | foreach ( $search as $field => $value ) { |
| 616 | - if ( $value <= 0 || ! in_array( $field, array( 'year', 'month', 'day' ), true ) ) { | |
| 500 | + if ( $value <= 0 || ! in_array( $field, array( 'year', 'month', 'day' ) ) ) { | |
| 617 | 501 | continue; |
| 618 | 502 | } |
| 619 | 503 | |
| 620 | 504 | switch ( $field ) { |
| @@ -626,12 +510,10 @@ | ||
| 626 | 510 | break; |
| 627 | 511 | case 'day': |
| 628 | 512 | $value = '%' . $value . '%'; |
| 629 | 513 | } |
| 630 | - | |
| 631 | 514 | $where .= $wpdb->prepare( ' meta_value ' . $operator . ' %s and', $value ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared |
| 632 | 515 | } |
| 633 | - | |
| 634 | 516 | $where .= $wpdb->prepare( ' field_id=%d', $field_id ); |
| 635 | 517 | $query = 'SELECT DISTINCT item_id FROM ' . $wpdb->prefix . 'frm_item_metas' . FrmDb::prepend_and_or_where( ' WHERE ', $where ); |
| 636 | 518 | } else { |
| 637 | 519 | if ( $operator === 'LIKE' ) { |
| @@ -636,10 +518,9 @@ | ||
| 636 | 518 | } else { |
| 637 | 519 | if ( $operator === 'LIKE' ) { |
| 638 | 520 | $search = '%' . $search . '%'; |
| 639 | 521 | } |
| 640 | - | |
| 641 | - $query = $wpdb->prepare( "SELECT DISTINCT item_id FROM {$wpdb->prefix}frm_item_metas WHERE meta_value {$operator} %s and field_id = %d", $search, $field_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 522 | + $query = $wpdb->prepare( "SELECT DISTINCT item_id FROM {$wpdb->prefix}frm_item_metas WHERE meta_value {$operator} %s and field_id = %d", $search, $field_id ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared | |
| 642 | 523 | }//end if |
| 643 | 524 | |
| 644 | 525 | $results = $wpdb->get_col( $query, 0 ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared |
| 645 | 526 | FrmDb::set_cache( $cache_key, $results, 'frm_entry' ); |
