PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.19
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.19
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmAppController.php +172 -364 6.306.19 View file →
@@ -9,9 +9,8 @@
9 9 * @return void
10 10 */
11 11 public static function menu() {
12 12 FrmAppHelper::maybe_add_permissions();
13 -
14 13 if ( ! current_user_can( 'frm_view_forms' ) ) {
15 14 return;
16 15 }
17 16
@@ -32,10 +31,8 @@
32 31 }
33 32
34 33 /**
35 34 * @since 3.05
36 - *
37 - * @return string
38 35 */
39 36 private static function menu_icon() {
40 37 $icon = FrmAppHelper::svg_logo(
41 38 array(
@@ -49,12 +46,8 @@
49 46 }
50 47
51 48 /**
52 49 * @since 3.0
53 - *
54 - * @param string $classes
55 - *
56 - * @return string
57 50 */
58 51 public static function add_admin_class( $classes ) {
59 52 if ( self::is_white_page() ) {
60 53 $classes .= ' frm-white-body ';
@@ -60,20 +53,17 @@
60 53 $classes .= ' frm-white-body ';
61 54 $classes .= self::get_os();
62 55
63 56 $page = str_replace( 'formidable-', '', FrmAppHelper::simple_get( 'page', 'sanitize_title' ) );
64 -
65 - if ( ! $page || $page === 'formidable' ) {
57 + if ( empty( $page ) || $page === 'formidable' ) {
66 58 $action = FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
67 -
68 - if ( in_array( $action, array( 'settings', 'edit', 'list' ), true ) ) {
59 + if ( in_array( $action, array( 'settings', 'edit', 'list' ) ) ) {
69 60 $page .= $action;
70 61 } else {
71 62 $page = $action;
72 63 }
73 64 }
74 -
75 - if ( $page ) {
65 + if ( ! empty( $page ) ) {
76 66 $classes .= ' frm-admin-page-' . $page;
77 67 }
78 68 }
79 69
@@ -81,17 +71,16 @@
81 71 $classes .= ' frm-grey-body ';
82 72 }
83 73
84 74 if ( FrmAppHelper::is_full_screen() ) {
85 - $add_class = '';
86 -
87 - if ( self::get_full_screen_setting() ) {
75 + $full_screen_on = self::get_full_screen_setting();
76 + $add_class = '';
77 + if ( $full_screen_on ) {
88 78 $add_class = ' frm-full-screen is-fullscreen-mode';
89 79
90 80 // Load the CSS for .is-fullscreen-mode.
91 81 wp_enqueue_style( 'wp-edit-post' );
92 82 }
93 -
94 83 $classes .= apply_filters( 'frm_admin_full_screen_class', $add_class );
95 84 }
96 85
97 86 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -114,10 +103,10 @@
114 103 */
115 104 private static function get_full_screen_setting() {
116 105 global $wpdb;
117 106 $meta_key = $wpdb->get_blog_prefix() . 'persisted_preferences';
118 - $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
119 107
108 + $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
120 109 if ( $prefs && isset( $prefs['core/edit-post']['fullscreenMode'] ) ) {
121 110 return $prefs['core/edit-post']['fullscreenMode'];
122 111 }
123 112
@@ -131,24 +120,20 @@
131 120 */
132 121 private static function get_os() {
133 122 $agent = strtolower( FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ) );
134 123 $os = '';
135 -
136 - if ( str_contains( $agent, 'mac' ) ) {
124 + if ( strpos( $agent, 'mac' ) !== false ) {
137 125 $os = ' osx';
138 - } elseif ( str_contains( $agent, 'linux' ) ) {
126 + } elseif ( strpos( $agent, 'linux' ) !== false ) {
139 127 $os = ' linux';
140 - } elseif ( str_contains( $agent, 'windows' ) ) {
128 + } elseif ( strpos( $agent, 'windows' ) !== false ) {
141 129 $os = ' windows';
142 130 }
143 -
144 131 return $os;
145 132 }
146 133
147 134 /**
148 135 * @since 3.0
149 - *
150 - * @return bool
151 136 */
152 137 private static function is_white_page() {
153 138 $white_pages = array(
154 139 'formidable',
@@ -164,10 +149,17 @@
164 149 FrmFormTemplatesController::PAGE_SLUG,
165 150 FrmOnboardingWizardController::PAGE_SLUG,
166 151 );
167 152
168 - if ( self::is_white_payments_page() ) {
169 - $white_pages[] = 'formidable-payments';
153 + if ( ! class_exists( 'FrmTransHooksController', false ) && ! FrmTransLiteAppHelper::should_fallback_to_paypal() ) {
154 + // Only consider the payments page as a "white page" when the Payments submodule is off.
155 + // Otherwise this causes a lot of styling issues when the Stripe add-on (or Authorize.Net) is active.
156 +
157 + // Add an extra check to avoid white page styling on the PayPal "edit" action.
158 + // We fallback to the PayPal add on for the "edit" action since Stripe Lite does not have an edit view.
159 + if ( ! in_array( FrmAppHelper::simple_get( 'action' ), array( 'edit', 'new' ), true ) || ! is_callable( 'FrmPaymentsController::route' ) ) {
160 + $white_pages[] = 'formidable-payments';
161 + }
170 162 }
171 163
172 164 $is_white_page = self::is_page_in_list( $white_pages ) || self::is_grey_page() || FrmAppHelper::is_view_builder_page();
173 165
@@ -177,25 +169,11 @@
177 169 * @since 5.3
178 170 *
179 171 * @param bool $is_white_page
180 172 */
181 - return apply_filters( 'frm_is_white_page', $is_white_page );
182 - }
173 + $is_white_page = apply_filters( 'frm_is_white_page', $is_white_page );
183 174
184 - /**
185 - * Check if the payments page should be styled as a white page.
186 - * Fallback to the Stripe, Authorize.Net, or PayPal add on for the "edit" action since
187 - * Stripe Lite does not have an edit view. Also fallback for bulk deleting, since that
188 - * isn't built into Lite. The pages we fall back to should not be styled as white pages.
189 - *
190 - * @since 6.27
191 - *
192 - * @return bool
193 - */
194 - private static function is_white_payments_page() {
195 - $action = FrmAppHelper::simple_get( 'action', 'sanitize_title' );
196 - $on_edit_page = in_array( $action, array( 'edit', 'new' ), true );
197 - return ! $on_edit_page && 'bulk_delete' !== $action;
175 + return $is_white_page;
198 176 }
199 177
200 178 /**
201 179 * Add a grey bg instead of white.
@@ -218,9 +196,8 @@
218 196 *
219 197 * @since 6.8
220 198 *
221 199 * @param bool $is_grey_page
222 - *
223 200 * @return bool
224 201 */
225 202 return apply_filters( 'frm_is_grey_page', $is_grey_page );
226 203 }
@@ -228,9 +205,8 @@
228 205 /**
229 206 * @since 6.8
230 207 *
231 208 * @param array $pages A list of page names to check.
232 - *
233 209 * @return bool
234 210 */
235 211 private static function is_page_in_list( $pages ) {
236 212 $get_page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
@@ -254,15 +230,13 @@
254 230 * @return void
255 231 */
256 232 public static function get_form_nav( $form, $show_nav = false, $title = 'show' ) {
257 233 $show_nav = FrmAppHelper::get_param( 'show_nav', $show_nav, 'get', 'absint' );
258 -
259 - if ( ! $show_nav || ! $form ) {
234 + if ( empty( $show_nav ) || ! $form ) {
260 235 return;
261 236 }
262 237
263 238 FrmForm::maybe_get_form( $form );
264 -
265 239 if ( ! is_object( $form ) ) {
266 240 return;
267 241 }
268 242
@@ -276,21 +250,21 @@
276 250 /**
277 251 * @return string
278 252 */
279 253 private static function get_current_page() {
254 + $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
255 + $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
256 + $current_page = isset( $_GET['page'] ) ? $page : $post_type;
257 +
280 258 if ( FrmAppHelper::is_view_builder_page() ) {
281 - return 'frm_display';
259 + $current_page = 'frm_display';
282 260 }
283 261
284 - $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
285 - $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
286 -
287 - return isset( $_GET['page'] ) ? $page : $post_type;
262 + return $current_page;
288 263 }
289 264
290 265 /**
291 266 * @param object $form
292 - *
293 267 * @return array
294 268 */
295 269 private static function get_form_nav_items( $form ) {
296 270 $id = $form->parent_form_id ? $form->parent_form_id : $form->id;
@@ -366,9 +340,8 @@
366 340 /**
367 341 * Adds a settings link to the plugins page
368 342 *
369 343 * @param array $links
370 - *
371 344 * @return array
372 345 */
373 346 public static function settings_link( $links ) {
374 347 $settings = array();
@@ -377,9 +350,8 @@
377 350 if ( FrmAddonsController::is_license_expired() ) {
378 351 $label = __( 'Renew', 'formidable' );
379 352 } else {
380 353 $label = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_text' );
381 -
382 354 if ( ! $label ) {
383 355 $label = __( 'Upgrade to Pro', 'formidable' );
384 356 }
385 357 }
@@ -384,19 +356,16 @@
384 356 }
385 357 }
386 358
387 359 $upgrade_link = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_link' );
388 -
389 - if ( $upgrade_link ) {
390 - $upgrade_link = FrmAppHelper::maybe_add_missing_utm( $upgrade_link, array( 'medium' => 'plugin-row' ) );
391 - } else {
360 + if ( ! $upgrade_link ) {
392 361 $upgrade_link = FrmAppHelper::admin_upgrade_link( 'plugin-row' );
393 362 }
394 363
395 364 $settings[] = '<a href="' . esc_url( $upgrade_link ) . '" target="_blank" rel="noopener"><b style="color:#1da867;font-weight:700;">' . esc_html( $label ) . '</b></a>';
396 - }//end if
365 + }
397 366
398 - $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . esc_html__( 'Build a Form', 'formidable' ) . '</a>';
367 + $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . __( 'Build a Form', 'formidable' ) . '</a>';
399 368
400 369 return array_merge( $settings, $links );
401 370 }
402 371
@@ -404,9 +373,9 @@
404 373 * @return void
405 374 */
406 375 public static function pro_get_started_headline() {
407 376 self::review_request();
408 - FrmAppHelper::min_pro_version_notice( '6.20' );
377 + FrmAppHelper::min_pro_version_notice( '6.0' );
409 378 }
410 379
411 380 /**
412 381 * Add admin notices as needed for reviews
@@ -481,9 +450,8 @@
481 450 *
482 451 * @param string $form_key
483 452 * @param string $title
484 453 * @param string $description
485 - *
486 454 * @return void
487 455 */
488 456 public static function api_email_form( $form_key, $title = '', $description = '' ) {
489 457 $user = wp_get_current_user();
@@ -516,9 +484,9 @@
516 484 * @return void
517 485 */
518 486 public static function remove_upsells() {
519 487 remove_action( 'frm_before_settings', 'FrmSettingsController::license_box' );
520 - remove_action( 'frm_after_settings_tabs', 'FrmSettingsController::settings_cta' );
488 + remove_action( 'frm_after_settings', 'FrmSettingsController::settings_cta' );
521 489 remove_action( 'frm_after_field_options', 'FrmFormsController::logic_tip' );
522 490 }
523 491
524 492 /**
@@ -530,14 +498,12 @@
530 498 * @return void
531 499 */
532 500 public static function install_js_fallback() {
533 501 FrmAppHelper::load_admin_wide_js();
534 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
535 502 ?>
536 503 <div id="frm_install_message"></div>
537 504 <script>jQuery(document).ready( frm_install_now );</script>
538 505 <?php
539 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
540 506 }
541 507
542 508 /**
543 509 * Check if the database is outdated
@@ -542,9 +508,8 @@
542 508 /**
543 509 * Check if the database is outdated
544 510 *
545 511 * @since 2.0.1
546 - *
547 512 * @return bool
548 513 */
549 514 public static function needs_update() {
550 515 $needs_upgrade = self::compare_for_update(
@@ -555,9 +520,9 @@
555 520 )
556 521 );
557 522
558 523 if ( ! $needs_upgrade ) {
559 - return apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
524 + $needs_upgrade = apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
560 525 }
561 526
562 527 return $needs_upgrade;
563 528 }
@@ -567,27 +532,23 @@
567 532 *
568 533 * @since 3.0.04
569 534 *
570 535 * @param array $atts
571 - *
572 536 * @return bool
573 537 */
574 538 public static function compare_for_update( $atts ) {
575 539 $db_version = get_option( $atts['option'] );
576 540
577 - if ( ! str_contains( $db_version, '-' ) ) {
578 - return true;
541 + if ( strpos( $db_version, '-' ) === false ) {
542 + $needs_upgrade = true;
543 + } else {
544 + $last_upgrade = explode( '-', $db_version );
545 + $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
546 + $new_version = version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
547 + $needs_upgrade = $needs_db_upgrade || $new_version;
579 548 }
580 549
581 - $last_upgrade = explode( '-', $db_version );
582 - $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
583 -
584 - if ( $needs_db_upgrade ) {
585 - return true;
586 - }
587 -
588 - // New plugin version.
589 - return version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
550 + return $needs_upgrade;
590 551 }
591 552
592 553 /**
593 554 * Check for database update and trigger js loading
@@ -615,15 +576,17 @@
615 576 }
616 577
617 578 if ( 'formidable-pro-upgrade' === FrmAppHelper::get_param( 'page' ) && ! FrmAppHelper::pro_is_installed() && current_user_can( 'frm_view_forms' ) ) {
618 579 $redirect = FrmSalesApi::get_best_sale_value( 'menu_cta_link' );
619 - $utm = array(
620 - 'campaign' => 'upgrade',
621 - 'content' => 'submenu-upgrade',
622 - );
580 + if ( ! $redirect ) {
581 + $redirect = FrmAppHelper::admin_upgrade_link(
582 + array(
583 + 'medium' => 'upgrade',
584 + 'content' => 'submenu-upgrade',
585 + )
586 + );
587 + }
623 588
624 - $redirect = $redirect ? FrmAppHelper::maybe_add_missing_utm( $redirect, $utm ) : FrmAppHelper::admin_upgrade_link( $utm );
625 -
626 589 wp_redirect( $redirect );
627 590 die();
628 591 }
629 592
@@ -634,32 +597,29 @@
634 597 self::network_upgrade_site();
635 598 }
636 599
637 600 if ( ! FrmAppHelper::doing_ajax() ) {
638 - // Don't continue during ajax calls
601 + // don't continue during ajax calls
639 602 self::admin_js();
640 603 }
641 604
642 605 self::trigger_page_load_hooks();
643 606
644 - if ( ! FrmAppHelper::is_admin_page( 'formidable' ) ) {
645 - return;
646 - }
607 + if ( FrmAppHelper::is_admin_page( 'formidable' ) ) {
608 + // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
609 + // This provides backward compatibility for old addons that use legacy modal templates.
610 + $action = FrmAppHelper::get_param( 'frm_action' );
611 + $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
612 + if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
613 + $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
614 + $url_param = $application_id ? '&applicationId=' . $application_id : '';
647 615
648 - // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
649 - // This provides backward compatibility for old addons that use legacy modal templates.
650 - $action = FrmAppHelper::get_param( 'frm_action' );
651 - $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
616 + wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
617 + exit;
618 + }
652 619
653 - if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
654 - $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
655 - $url_param = $application_id ? '&applicationId=' . $application_id : '';
656 -
657 - wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
658 - exit;
620 + FrmInbox::maybe_disable_screen_options();
659 621 }
660 -
661 - FrmInbox::maybe_disable_screen_options();
662 622 }
663 623
664 624 /**
665 625 * Get the current page and check for a possible function to trigger.
@@ -670,10 +630,9 @@
670 630 * @return void
671 631 */
672 632 private static function trigger_page_load_hooks() {
673 633 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
674 -
675 - if ( ! str_starts_with( $page, 'formidable-' ) ) {
634 + if ( strpos( $page, 'formidable-' ) !== 0 ) {
676 635 // Only trigger hooks on Formidable pages.
677 636 return;
678 637 }
679 638
@@ -679,9 +638,8 @@
679 638
680 639 $page = str_replace( array( 'formidable-', '-' ), array( '', ' ' ), $page );
681 640 $page = str_replace( ' ', '', ucwords( $page ) );
682 641 $class = 'Frm' . $page . 'Controller';
683 -
684 642 if ( class_exists( $class ) && method_exists( $class, 'load_page' ) ) {
685 643 call_user_func( array( $class, 'load_page' ) );
686 644 }
687 645 }
@@ -689,14 +647,13 @@
689 647 /**
690 648 * @return void
691 649 */
692 650 public static function admin_js() {
693 - $plugin_url = FrmAppHelper::plugin_url();
694 - $version = FrmAppHelper::plugin_version();
695 - $is_pro_min_v6_28 = FrmAppHelper::pro_is_installed() && FrmAppHelper::meets_min_pro_version( '6.28' );
696 - $frm_components_dependencies = $is_pro_min_v6_28 ? array( 'formidable_admin', 'formidable-pro-web-components' ) : array( 'formidable_admin' );
651 + $plugin_url = FrmAppHelper::plugin_url();
652 + $version = FrmAppHelper::plugin_version();
697 653
698 654 FrmAppHelper::load_admin_wide_js();
655 +
699 656 // Register component assets early to ensure they can be enqueued later in controllers.
700 657 wp_register_style( 'formidable-animations', $plugin_url . '/css/admin/animations.css', array(), $version );
701 658
702 659 if ( class_exists( 'FrmOverlayController' ) ) {
@@ -712,10 +669,10 @@
712 669 wp_register_style( 'formidable-grids', $plugin_url . '/css/frm_grids.css', array(), $version );
713 670
714 671 wp_register_script( 'formidable_dom', $plugin_url . '/js/admin/dom.js', array( 'jquery', 'jquery-ui-dialog', 'wp-i18n' ), $version, true );
715 672 wp_register_script( 'formidable_embed', $plugin_url . '/js/admin/embed.js', array( 'formidable_dom', 'jquery-ui-autocomplete' ), $version, true );
716 - self::register_popper2();
717 - wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '5.0.2', true );
673 + self::register_popper1();
674 + wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '4.6.1', true );
718 675
719 676 $settings_js_vars = array(
720 677 'currencies' => FrmCurrencyHelper::get_currencies(),
721 678 );
@@ -720,25 +677,51 @@
720 677 'currencies' => FrmCurrencyHelper::get_currencies(),
721 678 );
722 679 wp_register_script( 'formidable_settings', $plugin_url . '/js/admin/settings.js', array(), $version, true );
723 680 wp_localize_script( 'formidable_settings', 'frmSettings', $settings_js_vars );
724 - wp_register_script( 'formidable-web-components', $plugin_url . '/js/formidable-web-components.js', $frm_components_dependencies, $version, true );
725 681
726 682 if ( self::should_show_floating_links() ) {
727 683 self::enqueue_floating_links( $plugin_url, $version );
728 684 }
729 685
730 - wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', self::get_admin_js_dependencies(), $version, true );
686 + $dependencies = array(
687 + 'formidable_admin_global',
688 + 'jquery',
689 + 'jquery-ui-core',
690 + 'jquery-ui-draggable',
691 + 'jquery-ui-sortable',
692 + 'bootstrap_tooltip',
693 + 'bootstrap-multiselect',
694 + 'wp-i18n',
695 + // Required in WP versions older than 5.7
696 + 'wp-hooks',
697 + 'formidable_dom',
698 + 'formidable_embed',
699 + );
731 700
701 + if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
702 + // We only need to load the color picker when editing styles.
703 + $dependencies[] = 'wp-color-picker';
704 + }
705 +
706 + wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', $dependencies, $version, true );
707 +
732 708 if ( FrmAppHelper::on_form_listing_page() ) {
733 709 // For the existing page dropdown in the Form embed modal.
734 710 wp_enqueue_script( 'jquery-ui-autocomplete' );
735 711 }
736 712
737 - wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '2.0', true );
713 + wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '1.1.1', true );
738 714
739 715 if ( ! class_exists( 'FrmTransHooksController', false ) ) {
740 - FrmTransLiteAppController::hide_gateway_fields_in_builder();
716 + /**
717 + * Gateway fields are included for add-on compatibility but we do not want it to be visible.
718 + * They do however need to be visible when the payments submodule is active.
719 + */
720 + wp_add_inline_style(
721 + 'formidable-admin',
722 + '#frm_builder_page li[data-ftype="gateway"] { display: none; }'
723 + );
741 724 }
742 725
743 726 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
744 727 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
@@ -743,15 +726,13 @@
743 726 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
744 727 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
745 728
746 729 global $pagenow;
730 + if ( strpos( $page, 'formidable' ) === 0 || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
747 731
748 - if ( str_starts_with( $page, 'formidable' ) || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
749 - self::enqueue_global_settings_scripts( $page );
750 -
751 732 wp_enqueue_script( 'admin-widgets' );
752 733 wp_enqueue_style( 'widgets' );
753 - self::maybe_deregister_popper1();
734 + self::maybe_deregister_popper2();
754 735 wp_enqueue_script( 'formidable_admin' );
755 736 wp_set_script_translations( 'formidable_admin', 'formidable' );
756 737 wp_enqueue_script( 'formidable_embed' );
757 738 wp_set_script_translations( 'formidable_embed', 'formidable' );
@@ -758,9 +739,8 @@
758 739 FrmAppHelper::localize_script( 'admin' );
759 740
760 741 wp_enqueue_style( 'formidable-animations' );
761 742 wp_enqueue_style( 'formidable-admin' );
762 -
763 743 if ( 'formidable-styles' !== $page && 'formidable-styles2' !== $page ) {
764 744 wp_enqueue_style( 'formidable-grids' );
765 745 self::maybe_enqueue_dropzone_css( $page );
766 746 } else {
@@ -783,13 +763,11 @@
783 763 if ( isset( $_REQUEST['post_type'] ) ) {
784 764 $post_type = sanitize_title( wp_unslash( $_REQUEST['post_type'] ) );
785 765 } elseif ( isset( $_REQUEST['post'] ) && absint( $_REQUEST['post'] ) ) {
786 766 $post = get_post( absint( wp_unslash( $_REQUEST['post'] ) ) );
787 -
788 767 if ( ! $post ) {
789 768 return;
790 769 }
791 -
792 770 $post_type = $post->post_type;
793 771 } else {
794 772 return;
795 773 }
@@ -802,86 +780,16 @@
802 780 if ( 'formidable-addons' === $page ) {
803 781 wp_register_script( 'formidable_addons', $plugin_url . '/js/admin/addons.js', array( 'formidable_admin', 'wp-dom-ready' ), $version, true );
804 782 wp_enqueue_script( 'formidable_addons' );
805 783 }
806 -
807 - self::enqueue_builder_assets( $plugin_url, $version );
808 784 }
809 785
810 786 /**
811 - * @since 6.27
812 - *
813 - * @return array
814 - */
815 - private static function get_admin_js_dependencies() {
816 - $dependencies = array(
817 - 'formidable_admin_global',
818 - 'jquery',
819 - 'jquery-ui-core',
820 - 'jquery-ui-draggable',
821 - 'jquery-ui-sortable',
822 - 'bootstrap_tooltip',
823 - 'bootstrap-multiselect',
824 - 'wp-i18n',
825 - // Required in WP versions older than 5.7
826 - 'wp-hooks',
827 - 'formidable_dom',
828 - 'formidable_embed',
829 - );
830 -
831 - if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
832 - // We only need to load the color picker when editing styles.
833 - $dependencies[] = 'wp-color-picker';
834 - }
835 -
836 - return $dependencies;
837 - }
838 -
839 - /**
840 - * Enqueue the Form Builder assets.
841 - *
842 - * @since 6.24
843 - *
844 - * @param string $plugin_url The plugin URL.
845 - * @param string $version The plugin version.
846 - *
847 - * @return void
848 - */
849 - private static function enqueue_builder_assets( $plugin_url, $version ) {
850 - wp_register_style( 'formidable-settings-components', $plugin_url . '/css/admin/frm-settings-components.css', array( 'formidable-admin', 'formidable-grids' ), $version );
851 - wp_register_script( 'formidable-settings-components', $plugin_url . '/js/formidable-settings-components.js', array( 'formidable_admin' ), $version, true );
852 -
853 - if ( ! FrmAppHelper::is_form_builder_page() ) {
854 - return;
855 - }
856 -
857 - wp_enqueue_style( 'formidable-settings-components' );
858 - wp_enqueue_script( 'formidable-settings-components' );
859 - }
860 -
861 - /**
862 - * Enqueues global settings scripts.
863 - *
864 - * @param string $page The `page` param in URL.
865 - *
866 - * @return void
867 - */
868 - private static function enqueue_global_settings_scripts( $page ) {
869 - if ( 'formidable-settings' !== $page ) {
870 - return;
871 - }
872 -
873 - wp_enqueue_style( 'wp-color-picker' );
874 - wp_enqueue_script( 'formidable_settings' );
875 - }
876 -
877 - /**
878 787 * Avoid loading dropzone CSS on the form list page. It isn't required there.
879 788 *
880 789 * @since 6.11
881 790 *
882 791 * @param string $page
883 - *
884 792 * @return void
885 793 */
886 794 private static function maybe_enqueue_dropzone_css( $page ) {
887 795 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -888,9 +796,8 @@
888 796 return;
889 797 }
890 798
891 799 $should_avoid_loading_dropzone = 'formidable' === $page && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
892 -
893 800 if ( ! $should_avoid_loading_dropzone ) {
894 801 wp_enqueue_style( 'formidable-dropzone' );
895 802 }
896 803 }
@@ -907,18 +814,12 @@
907 814 if ( ! FrmAppHelper::is_formidable_branding() ) {
908 815 return false;
909 816 }
910 817
911 - $should_show = FrmAppHelper::is_formidable_admin() && ! FrmAppHelper::is_style_editor_page() && ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
912 -
913 - /**
914 - * Filters whether the floating links should be displayed.
915 - *
916 - * @since 6.25.1
917 - *
918 - * @param bool $should_show Whether the floating links should be shown.
919 - */
920 - return apply_filters( 'frm_should_show_floating_links', $should_show );
818 + return FrmAppHelper::is_formidable_admin() &&
819 + ! FrmAppHelper::is_style_editor_page() &&
820 + ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) &&
821 + ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
921 822 }
922 823
923 824 /**
924 825 * @since 6.3.2
@@ -945,9 +846,9 @@
945 846 */
946 847 private static function enqueue_legacy_views_assets() {
947 848 wp_enqueue_style( 'formidable-grids' );
948 849 wp_enqueue_script( 'jquery-ui-draggable' );
949 - self::maybe_deregister_popper1();
850 + self::maybe_deregister_popper2();
950 851 wp_enqueue_script( 'formidable_admin' );
951 852 wp_add_inline_style(
952 853 'formidable-admin',
953 854 '
@@ -970,21 +871,20 @@
970 871 }
971 872 '
972 873 );
973 874 wp_enqueue_style( 'formidable-admin' );
974 - wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
975 875 FrmAppHelper::localize_script( 'admin' );
976 876 self::include_info_overlay();
977 877 }
978 878
979 879 /**
980 - * Unregister Popper if the registered version is outdated.
880 + * Fix a Duplicator Pro conflict because it uses Popper 2. See issue #3459.
981 881 *
982 - * @since 6.26
882 + * @since 5.2.02.01
983 883 *
984 884 * @return void
985 885 */
986 - private static function maybe_deregister_popper1() {
886 + private static function maybe_deregister_popper2() {
987 887 global $wp_scripts;
988 888
989 889 if ( ! array_key_exists( 'popper', $wp_scripts->registered ) ) {
990 890 return;
@@ -990,29 +890,26 @@
990 890 return;
991 891 }
992 892
993 893 $popper = $wp_scripts->registered['popper'];
994 -
995 - if ( ! version_compare( $popper->ver, '2.0', '<' ) ) {
996 - return;
894 + if ( version_compare( $popper->ver, '2.0', '>=' ) ) {
895 + wp_deregister_script( 'popper' );
896 + self::register_popper1();
997 897 }
998 -
999 - wp_deregister_script( 'popper' );
1000 - self::register_popper2();
1001 898 }
1002 899
1003 900 /**
1004 - * Register Popper required for Bootstrap 5.
901 + * Register Popper required for Bootstrap 4.
1005 902 *
1006 - * @since 6.26
903 + * @since 5.2.02.01
1007 904 *
1008 905 * @return void
1009 906 */
1010 - private static function register_popper2() {
907 + private static function register_popper1() {
1011 908 if ( ! self::should_register_popper() ) {
1012 909 return;
1013 910 }
1014 - wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array(), '2.11.8', true );
911 + wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array( 'jquery' ), '1.16.0', true );
1015 912 }
1016 913
1017 914 /**
1018 915 * Only register popper on Formidable pages.
@@ -1025,9 +922,8 @@
1025 922 private static function should_register_popper() {
1026 923 global $pagenow;
1027 924
1028 925 $post_id = FrmAppHelper::simple_get( 'post', 'absint' );
1029 -
1030 926 if ( 'post.php' === $pagenow && $post_id && 'frm_display' === get_post_type( $post_id ) ) {
1031 927 return true;
1032 928 }
1033 929
@@ -1032,16 +928,14 @@
1032 928 }
1033 929
1034 930 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1035 931 $is_views_post_type = 'frm_display' === $post_type;
1036 -
1037 932 if ( in_array( $pagenow, array( 'post-new.php', 'edit.php' ), true ) && $is_views_post_type ) {
1038 933 return true;
1039 934 }
1040 935
1041 936 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
1042 -
1043 - if ( str_starts_with( $page, 'formidable' ) ) {
937 + if ( strpos( $page, 'formidable' ) === 0 ) {
1044 938 return true;
1045 939 }
1046 940
1047 941 return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && FrmAppHelper::simple_get( 'taxonomy' ) === 'frm_application';
@@ -1055,15 +949,13 @@
1055 949 * @return void
1056 950 */
1057 951 private static function maybe_force_formidable_block_on_gutenberg_page() {
1058 952 global $pagenow;
1059 -
1060 953 if ( 'post.php' !== $pagenow ) {
1061 954 return;
1062 955 }
1063 956
1064 957 $form_id = FrmAppHelper::simple_get( 'frmForm', 'absint' );
1065 -
1066 958 if ( ! $form_id ) {
1067 959 return;
1068 960 }
1069 961
@@ -1111,9 +1003,9 @@
1111 1003 public static function create_rest_routes() {
1112 1004 $args = array(
1113 1005 'methods' => 'GET',
1114 1006 'callback' => 'FrmAppController::api_install',
1115 - 'permission_callback' => self::class . '::can_update_db',
1007 + 'permission_callback' => __CLASS__ . '::can_update_db',
1116 1008 );
1117 1009
1118 1010 register_rest_route( 'frm-admin/v1', '/install', $args );
1119 1011
@@ -1130,10 +1022,8 @@
1130 1022 * Make sure the install is only being run when we tell it to.
1131 1023 * We don't want to run manually by people calling the API.
1132 1024 *
1133 1025 * @since 4.06.02
1134 - *
1135 - * @return bool
1136 1026 */
1137 1027 public static function can_update_db() {
1138 1028 return get_transient( 'frm_updating_api' );
1139 1029 }
@@ -1163,9 +1053,9 @@
1163 1053 $response = rest_do_request( $request );
1164 1054 }
1165 1055
1166 1056 if ( $response->is_error() ) {
1167 - // If the remove post fails, use javascript instead
1057 + // if the remove post fails, use javascript instead
1168 1058 add_action( 'admin_notices', 'FrmAppController::install_js_fallback' );
1169 1059 }
1170 1060 }
1171 1061
@@ -1175,17 +1065,14 @@
1175 1065 *
1176 1066 * @return void
1177 1067 */
1178 1068 private static function maybe_add_wp_site_health() {
1179 - if ( class_exists( 'WP_Site_Health' ) ) {
1180 - return;
1069 + if ( ! class_exists( 'WP_Site_Health' ) ) {
1070 + $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1071 + if ( file_exists( $wp_site_health_path ) ) {
1072 + require_once $wp_site_health_path;
1073 + }
1181 1074 }
1182 -
1183 - $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1184 -
1185 - if ( file_exists( $wp_site_health_path ) ) {
1186 - require_once $wp_site_health_path;
1187 - }
1188 1075 }
1189 1076
1190 1077 /**
1191 1078 * @since 3.0
@@ -1193,14 +1080,12 @@
1193 1080 * @return true
1194 1081 */
1195 1082 public static function api_install() {
1196 1083 delete_transient( 'frm_updating_api' );
1197 -
1198 1084 if ( self::needs_update() ) {
1199 1085 $running = get_option( 'frm_install_running' );
1200 -
1201 1086 if ( false === $running || $running < strtotime( '-5 minutes' ) ) {
1202 - update_option( 'frm_install_running', time(), false );
1087 + update_option( 'frm_install_running', time(), 'no' );
1203 1088 self::install();
1204 1089 delete_option( 'frm_install_running' );
1205 1090 }
1206 1091 }
@@ -1248,13 +1133,8 @@
1248 1133
1249 1134 wp_die();
1250 1135 }
1251 1136
1252 - /**
1253 - * @param array $tables
1254 - *
1255 - * @return array
1256 - */
1257 1137 public static function drop_tables( $tables ) {
1258 1138 global $wpdb;
1259 1139 $tables[] = $wpdb->prefix . 'frm_fields';
1260 1140 $tables[] = $wpdb->prefix . 'frm_forms';
@@ -1302,15 +1182,14 @@
1302 1182
1303 1183 FrmTransLiteAppController::maybe_schedule_cron();
1304 1184 }
1305 1185
1306 - /**
1307 - * @param string $text
1308 - *
1309 - * @return string
1310 - */
1311 1186 public static function set_footer_text( $text ) {
1312 - return FrmAppHelper::is_formidable_admin() ? '' : $text;
1187 + if ( FrmAppHelper::is_formidable_admin() ) {
1188 + $text = '';
1189 + }
1190 +
1191 + return $text;
1313 1192 }
1314 1193
1315 1194 /**
1316 1195 * Add admin footer links.
@@ -1319,10 +1198,8 @@
1319 1198 *
1320 1199 * @return void
1321 1200 */
1322 1201 public static function add_admin_footer_links() {
1323 - FrmFormsController::include_device_too_small_message();
1324 -
1325 1202 if ( self::should_show_footer_links() ) {
1326 1203 include FrmAppHelper::plugin_path() . '/classes/views/shared/admin-footer-links.php';
1327 1204 }
1328 1205 }
@@ -1337,9 +1214,8 @@
1337 1214 private static function should_show_footer_links() {
1338 1215 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1339 1216 $is_formidable_page = FrmAppHelper::is_formidable_admin() || 'frm_logs' === $post_type;
1340 1217 $show_footer_links = $is_formidable_page;
1341 -
1342 1218 if ( FrmAppHelper::is_full_screen() || ! FrmAppHelper::is_formidable_branding() ) {
1343 1219 $show_footer_links = false;
1344 1220 }
1345 1221
@@ -1348,9 +1224,8 @@
1348 1224 *
1349 1225 * @since 6.7
1350 1226 *
1351 1227 * @param bool $show_footer_links
1352 - *
1353 1228 * @return bool
1354 1229 */
1355 1230 return apply_filters( 'frm_show_footer_links', $show_footer_links );
1356 1231 }
@@ -1377,9 +1252,8 @@
1377 1252 'icon' => 'frm_lock_simple',
1378 1253 );
1379 1254
1380 1255 $error_args = wp_parse_args( $error_args, $defaults );
1381 -
1382 1256 if ( ! isset( $error_args['cancel_text'] ) && ! empty( $error_args['cancel_url'] ) ) {
1383 1257 $error_args['cancel_text'] = __( 'Cancel', 'formidable' );
1384 1258 }
1385 1259
@@ -1396,9 +1270,8 @@
1396 1270 * @since 6.4
1397 1271 *
1398 1272 * @param string $plugin_url URL of the plugin.
1399 1273 * @param string $version Current version of the plugin.
1400 - *
1401 1274 * @return void
1402 1275 */
1403 1276 private static function enqueue_floating_links( $plugin_url, $version ) {
1404 1277 if ( ! $plugin_url || ! $version ) {
@@ -1418,20 +1291,10 @@
1418 1291 if ( function_exists( 'wp_set_script_translations' ) ) {
1419 1292 wp_set_script_translations( 's11-floating-links-config', 's11-' );
1420 1293 }
1421 1294
1422 - $upgrade_utm = array(
1423 - 'campaign' => 'floating-links',
1424 - 'content' => 'floating-links-upgrade',
1425 - );
1426 - $docs_utm = array(
1427 - 'campaign' => 'floating-links',
1428 - 'content' => 'floating-links-docs',
1429 - );
1430 1295 $floating_links_data = array(
1431 - 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1432 - 'upgradeUrl' => FrmAppHelper::admin_upgrade_link( $upgrade_utm ),
1433 - 'documentationUrl' => FrmAppHelper::admin_upgrade_link( $docs_utm, 'knowledgebase/' ),
1296 + 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1434 1297 );
1435 1298 wp_localize_script( 's11-floating-links-config', 's11FloatingLinksData', $floating_links_data );
1436 1299
1437 1300 /**
@@ -1449,9 +1312,8 @@
1449 1312 * @return bool
1450 1313 */
1451 1314 private static function in_our_pages() {
1452 1315 global $current_screen, $pagenow;
1453 -
1454 1316 if ( FrmAppHelper::is_formidable_admin() ) {
1455 1317 return true;
1456 1318 }
1457 1319
@@ -1458,9 +1320,13 @@
1458 1320 if ( ! empty( $current_screen->post_type ) && 'frm_logs' === $current_screen->post_type ) {
1459 1321 return true;
1460 1322 }
1461 1323
1462 - return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' );
1324 + if ( in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' ) ) {
1325 + return true;
1326 + }
1327 +
1328 + return false;
1463 1329 }
1464 1330
1465 1331 /**
1466 1332 * Handles actions related to the current screen.
@@ -1496,9 +1362,8 @@
1496 1362 foreach ( $actions as $action ) {
1497 1363 if ( empty( $wp_filter[ $action ]->callbacks ) ) {
1498 1364 continue;
1499 1365 }
1500 -
1501 1366 foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
1502 1367 foreach ( $callbacks as $callback_name => $callback ) {
1503 1368 if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
1504 1369 continue;
@@ -1514,18 +1379,14 @@
1514 1379 *
1515 1380 * @return void
1516 1381 */
1517 1382 private static function remember_custom_sort() {
1518 - $meta_key = self::get_sort_pref_user_meta_key();
1519 -
1520 - if ( false === $meta_key ) {
1383 + $screen = get_current_screen();
1384 + if ( ! $screen ) {
1521 1385 return;
1522 1386 }
1523 1387
1524 - $is_form_list = FrmAppHelper::is_admin_list_page();
1525 - $is_entry_list = FrmAppHelper::is_admin_list_page( 'formidable-entries' );
1526 -
1527 - if ( ! $is_form_list && ! $is_entry_list ) {
1388 + if ( ! FrmAppHelper::is_admin_list_page() && ! FrmAppHelper::is_admin_list_page( 'formidable-entries' ) ) {
1528 1389 return;
1529 1390 }
1530 1391
1531 1392 $orderby = FrmAppHelper::get_param( 'orderby' );
@@ -1533,37 +1394,29 @@
1533 1394 if ( ! $orderby ) {
1534 1395 return;
1535 1396 }
1536 1397
1537 - $user_id = get_current_user_id();
1538 - $order = FrmAppHelper::get_param( 'order' );
1539 - $new_sort = array(
1398 + $user_id = get_current_user_id();
1399 + $meta_key = 'frm_preferred_list_sort_' . $screen->id;
1400 + $order = FrmAppHelper::get_param( 'order' );
1401 +
1402 + $new_sort = array(
1540 1403 'orderby' => $orderby,
1541 1404 'order' => $order,
1542 1405 );
1543 - $previous_meta = get_user_meta( $user_id, $meta_key, true );
1544 - $current_sort = $previous_meta;
1545 - $form_id = $is_entry_list ? FrmAppHelper::simple_get( 'form', 'absint' ) : 0;
1546 1406
1547 - if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[ $form_id ] ) ) {
1548 - $current_sort = $current_sort[ $form_id ];
1549 - }
1407 + $current_sort = get_user_meta( $user_id, $meta_key, true );
1550 1408
1551 - if ( $new_sort === $current_sort ) {
1552 - return;
1409 + if ( $new_sort !== $current_sort ) {
1410 + update_user_meta(
1411 + $user_id,
1412 + $meta_key,
1413 + array(
1414 + 'orderby' => $orderby,
1415 + 'order' => $order,
1416 + )
1417 + );
1553 1418 }
1554 -
1555 - $new_meta = $new_sort;
1556 -
1557 - if ( $is_entry_list && $form_id && is_int( $form_id ) ) {
1558 - // Index meta by form ID.
1559 - $temp_meta = is_array( $previous_meta ) ? $previous_meta : array();
1560 - $temp_meta[ $form_id ] = $new_meta;
1561 - $new_meta = $temp_meta;
1562 - unset( $temp_meta );
1563 - }
1564 -
1565 - update_user_meta( $user_id, $meta_key, $new_meta );
1566 1419 }
1567 1420
1568 1421 /**
1569 1422 * Retrieve and apply any saved sorting preferences for the current screen.
@@ -1569,52 +1422,32 @@
1569 1422 * Retrieve and apply any saved sorting preferences for the current screen.
1570 1423 *
1571 1424 * @since 6.19
1572 1425 *
1573 - * @param string $orderby Reference to the current 'orderby' parameter.
1574 - * @param string $order Reference to the current 'order' parameter.
1575 - *
1426 + * @param string &$orderby Reference to the current 'orderby' parameter.
1427 + * @param string &$order Reference to the current 'order' parameter.
1576 1428 * @return void
1577 1429 */
1578 1430 public static function apply_saved_sort_preference( &$orderby, &$order ) {
1579 - $meta_key = self::get_sort_pref_user_meta_key();
1580 -
1581 - if ( false === $meta_key ) {
1431 + if ( ! function_exists( 'get_current_screen' ) ) {
1582 1432 return;
1583 1433 }
1584 1434
1585 - $preferred_list_sort = get_user_meta( get_current_user_id(), $meta_key, true );
1586 - $form_id = FrmAppHelper::simple_get( 'form', 'absint' );
1587 -
1588 - if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[ $form_id ] ) ) {
1589 - $preferred_list_sort = $preferred_list_sort[ $form_id ];
1590 - }
1591 -
1592 - if ( ! is_array( $preferred_list_sort ) || empty( $preferred_list_sort['orderby'] ) ) {
1435 + $screen = get_current_screen();
1436 + if ( ! $screen ) {
1593 1437 return;
1594 1438 }
1595 1439
1596 - $orderby = $preferred_list_sort['orderby'];
1440 + $user_id = get_current_user_id();
1441 + $preferred_list_sort = get_user_meta( $user_id, 'frm_preferred_list_sort_' . $screen->id, true );
1597 1442
1598 - if ( ! empty( $preferred_list_sort['order'] ) ) {
1599 - $order = $preferred_list_sort['order'];
1600 - }
1601 - }
1443 + if ( is_array( $preferred_list_sort ) && ! empty( $preferred_list_sort['orderby'] ) ) {
1444 + $orderby = $preferred_list_sort['orderby'];
1602 1445
1603 - /**
1604 - * Get a simple user meta key that only includes the screen ID.
1605 - *
1606 - * @since 6.25.1
1607 - *
1608 - * @return false|string
1609 - */
1610 - private static function get_sort_pref_user_meta_key() {
1611 - if ( ! function_exists( 'get_current_screen' ) ) {
1612 - return false;
1446 + if ( ! empty( $preferred_list_sort['order'] ) ) {
1447 + $order = $preferred_list_sort['order'];
1448 + }
1613 1449 }
1614 -
1615 - $screen = get_current_screen();
1616 - return $screen ? 'frm_preferred_list_sort_' . $screen->id : false;
1617 1450 }
1618 1451
1619 1452 /**
1620 1453 * Validate that the callback name is ours not from third-party.
@@ -1634,9 +1467,12 @@
1634 1467 *
1635 1468 * @return bool
1636 1469 */
1637 1470 private static function is_our_callback_array( $callback ) {
1638 - return ! empty( $callback['function'] ) && is_array( $callback['function'] ) && ! empty( $callback['function'][0] ) && self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1471 + return ! empty( $callback['function'] ) &&
1472 + is_array( $callback['function'] ) &&
1473 + ! empty( $callback['function'][0] ) &&
1474 + self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] );
1639 1475 }
1640 1476
1641 1477 /**
1642 1478 * In some cases, the DB tables may fail to install.
@@ -1647,9 +1483,10 @@
1647 1483 */
1648 1484 private static function add_missing_tables() {
1649 1485 FrmAppHelper::permission_check( 'frm_view_forms' );
1650 1486
1651 - $error = FrmInbox::check_for_error();
1487 + $inbox = new FrmInbox();
1488 + $error = $inbox->check_for_error();
1652 1489
1653 1490 if ( ! $error || 'failed-to-create-tables' !== $error['key'] ) {
1654 1491 // Confirm the inbox item with this CTA exists.
1655 1492 wp_safe_redirect( admin_url( 'admin.php?page=formidable' ) );
@@ -1667,35 +1504,6 @@
1667 1504
1668 1505 delete_option( 'frm_db_version' );
1669 1506 wp_safe_redirect( admin_url( 'admin.php?page=formidable' ) );
1670 1507 exit;
1671 - }
1672 -
1673 - /**
1674 - * Handles the small screen proceed action.
1675 - *
1676 - * @since 6.21
1677 - *
1678 - * @return void
1679 - */
1680 - public static function small_screen_proceed() {
1681 - FrmAppHelper::permission_check( 'frm_view_forms' );
1682 - check_ajax_referer( 'frm_ajax', 'nonce' );
1683 - update_user_option( get_current_user_id(), 'frm_ignore_small_screen_warning', true );
1684 - wp_send_json_success();
1685 - }
1686 -
1687 - /**
1688 - * Enqueue the components scripts.
1689 - *
1690 - * @since 6.28
1691 - *
1692 - * @return void
1693 - */
1694 - public static function enqueue_components_scripts() {
1695 - if ( is_callable( array( 'FrmProFormsController', 'enqueue_pro_web_components_script' ) ) ) {
1696 - FrmProFormsController::enqueue_pro_web_components_script();
1697 - }
1698 -
1699 - wp_enqueue_script( 'formidable-web-components' );
1700 1508 }
1701 1509 }