PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.19
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.19
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmFormsController.php +259 -700 6.32.16.19 View file →
@@ -26,13 +26,11 @@
26 26 private static $formidable_tinymce_button;
27 27
28 28 public static function menu() {
29 29 $menu_label = __( 'Forms', 'formidable' );
30 -
31 30 if ( ! FrmAppHelper::pro_is_installed() ) {
32 31 $menu_label .= ' (Lite)';
33 32 }
34 -
35 33 add_submenu_page( 'formidable', 'Formidable | ' . $menu_label, $menu_label, 'frm_view_forms', 'formidable', 'FrmFormsController::route' );
36 34
37 35 self::maybe_load_listing_hooks();
38 36 }
@@ -47,15 +45,8 @@
47 45 add_filter( 'manage_toplevel_page_formidable_columns', 'FrmFormsController::get_columns', 0 );
48 46 add_filter( 'manage_toplevel_page_formidable_sortable_columns', 'FrmFormsController::get_sortable_columns' );
49 47 }
50 48
51 - /**
52 - * Runs on admin head of the formidable forms page.
53 - *
54 - * @since 6.32 This adds screen options.
55 - *
56 - * @return void
57 - */
58 49 public static function head() {
59 50 if ( wp_is_mobile() ) {
60 51 wp_enqueue_script( 'jquery-touch-punch' );
61 52 }
@@ -73,12 +64,12 @@
73 64 */
74 65 public static function logic_tip() {
75 66 $images_url = FrmAppHelper::plugin_url() . '/images/';
76 67 $data_message = __( 'Only show the fields you need and create branching forms. Upgrade to get conditional logic and question branching.', 'formidable' );
77 - $data_message .= ' <img src="' . esc_url( $images_url ) . '/survey-logic.png" srcset="' . esc_url( $images_url ) . 'survey-logic@2x.png 2x" alt="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '"/>'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
78 - echo '<a href="javascript:void(0)" class="frm_noallow frm_show_upgrade frm_add_logic_link frm-collapsed frm-flex-justify" data-upgrade="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '" data-message="' . esc_attr( $data_message ) . '" data-medium="builder" data-content="logic">'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
68 + $data_message .= ' <img src="' . esc_url( $images_url ) . '/survey-logic.png" srcset="' . esc_url( $images_url ) . 'survey-logic@2x.png 2x" alt="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '"/>';
69 + echo '<a href="javascript:void(0)" class="frm_noallow frm_show_upgrade frm_add_logic_link frm-collapsed frm-flex-justify" data-upgrade="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '" data-message="' . esc_attr( $data_message ) . '" data-medium="builder" data-content="logic">';
79 70 esc_html_e( 'Conditional Logic', 'formidable' );
80 - FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown8_icon', array( 'aria-hidden' => 'true' ) );
71 + FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
81 72 echo '</a>';
82 73 }
83 74
84 75 /**
@@ -85,15 +76,12 @@
85 76 * By default, Divi processes form shortcodes on the edit post page.
86 77 * Now that won't do.
87 78 *
88 79 * @since 3.01
89 - *
90 - * @param array $shortcodes List of shortcodes to process.
91 - *
92 - * @return array
93 80 */
94 81 public static function prevent_divi_conflict( $shortcodes ) {
95 82 $shortcodes[] = 'formidable';
83 +
96 84 return $shortcodes;
97 85 }
98 86
99 87 /**
@@ -104,14 +92,12 @@
104 92
105 93 $message = '';
106 94 $params = FrmForm::list_page_params();
107 95 $errors = self::process_bulk_form_actions( array() );
108 -
109 96 if ( isset( $errors['message'] ) ) {
110 97 $message = $errors['message'];
111 98 unset( $errors['message'] );
112 99 }
113 -
114 100 $errors = apply_filters( 'frm_admin_list_form_action', $errors );
115 101
116 102 self::display_forms_list( $params, $message, $errors );
117 103 }
@@ -121,14 +107,12 @@
121 107 *
122 108 * @since 2.02.11
123 109 *
124 110 * @param int|object $form
125 - *
126 111 * @return void
127 112 */
128 113 private static function create_default_email_action( $form ) {
129 114 FrmForm::maybe_get_form( $form );
130 -
131 115 if ( ! is_object( $form ) ) {
132 116 return;
133 117 }
134 118
@@ -133,17 +117,15 @@
133 117 }
134 118
135 119 $create_email = apply_filters( 'frm_create_default_email_action', true, $form );
136 120
137 - if ( ! $create_email ) {
138 - return;
121 + if ( $create_email ) {
122 + /**
123 + * @var FrmFormAction
124 + */
125 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
126 + $action_control->create( $form->id );
139 127 }
140 -
141 - /**
142 - * @var FrmFormAction
143 - */
144 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
145 - $action_control->create( $form->id );
146 128 }
147 129
148 130 /**
149 131 * Create the default On submit action
@@ -150,14 +132,12 @@
150 132 *
151 133 * @since 6.0.0
152 134 *
153 135 * @param int|object $form Form object or ID.
154 - *
155 136 * @return void
156 137 */
157 138 private static function create_default_on_submit_action( $form ) {
158 139 FrmForm::maybe_get_form( $form );
159 -
160 140 if ( ! is_object( $form ) ) {
161 141 return;
162 142 }
163 143
@@ -170,17 +150,15 @@
170 150 * @param object $form Form object.
171 151 */
172 152 $create = apply_filters( 'frm_create_default_on_submit_action', true, $form );
173 153
174 - if ( ! $create ) {
175 - return;
154 + if ( $create ) {
155 + /**
156 + * @var FrmFormAction
157 + */
158 + $action_control = FrmFormActionsController::get_form_actions( FrmOnSubmitAction::$slug );
159 + $action_control->create( $form->id );
176 160 }
177 -
178 - /**
179 - * @var FrmFormAction
180 - */
181 - $action_control = FrmFormActionsController::get_form_actions( FrmOnSubmitAction::$slug );
182 - $action_control->create( $form->id );
183 161 }
184 162
185 163 /**
186 164 * Creates submit button field.
@@ -187,14 +165,12 @@
187 165 *
188 166 * @since 6.9
189 167 *
190 168 * @param int|object $form Form ID or object.
191 - *
192 169 * @return void
193 170 */
194 171 private static function create_submit_button_field( $form ) {
195 172 FrmForm::maybe_get_form( $form );
196 -
197 173 if ( ! is_object( $form ) ) {
198 174 return;
199 175 }
200 176
@@ -217,10 +193,8 @@
217 193 );
218 194 }
219 195
220 196 /**
221 - * @param array|false $values
222 - *
223 197 * @return void
224 198 */
225 199 public static function edit( $values = false ) {
226 200 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -232,9 +206,8 @@
232 206
233 207 /**
234 208 * @param mixed $id
235 209 * @param string $message
236 - *
237 210 * @return void
238 211 */
239 212 public static function settings( $id = false, $message = '' ) {
240 213 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -262,9 +235,10 @@
262 235 FrmAppController::show_error_modal( $error_args );
263 236 return;
264 237 }
265 238
266 - $id = FrmAppHelper::get_param( 'id', '', 'get', 'absint' );
239 + $id = FrmAppHelper::get_param( 'id', '', 'get', 'absint' );
240 +
267 241 $errors = FrmForm::validate( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
268 242 $warnings = FrmFormsHelper::check_for_warnings( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
269 243
270 244 if ( count( $errors ) > 0 ) {
@@ -273,14 +247,13 @@
273 247 }
274 248
275 249 do_action( 'frm_before_update_form_settings', $id );
276 250
277 - $antispam_was_on = self::antispam_was_on( $id ); // phpcs:ignore Formidable.CodeAnalysis.InlineSingleUseVariable
251 + $antispam_was_on = self::antispam_was_on( $id );
278 252
279 253 FrmForm::update( $id, $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
280 254
281 255 $antispam_is_on = ! empty( $_POST['options']['antispam'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
282 -
283 256 if ( $antispam_is_on !== $antispam_was_on ) {
284 257 FrmAntiSpam::clear_caches();
285 258 }
286 259
@@ -290,9 +263,8 @@
290 263 }
291 264
292 265 /**
293 266 * @param int $form_id
294 - *
295 267 * @return bool
296 268 */
297 269 private static function antispam_was_on( $form_id ) {
298 270 $form = FrmForm::getOne( $form_id );
@@ -299,14 +271,12 @@
299 271 return ! empty( $form->options['antispam'] );
300 272 }
301 273
302 274 /**
303 - * @param array $values
304 - *
305 275 * @return void
306 276 */
307 277 public static function update( $values = array() ) {
308 - if ( ! $values ) {
278 + if ( empty( $values ) ) {
309 279 $values = $_POST; // phpcs:ignore WordPress.Security.NonceVerification.Missing
310 280 }
311 281
312 282 // Set radio button and checkbox meta equal to "other" value.
@@ -315,9 +285,8 @@
315 285 }
316 286
317 287 $errors = FrmForm::validate( $values );
318 288 $permission_error = FrmAppHelper::permission_nonce_error( 'frm_edit_forms', 'frm_save_form', 'frm_save_form_nonce' );
319 -
320 289 if ( $permission_error !== false ) {
321 290 $errors['form'] = $permission_error;
322 291 }
323 292
@@ -336,9 +305,9 @@
336 305 if ( self::is_too_long( $values ) ) {
337 306 $message .= '<br/> ' . sprintf(
338 307 /* translators: %1$s: Start link HTML, %2$s: end link HTML */
339 308 __( 'However, your form is very long and may be %1$sreaching server limits%2$s.', 'formidable' ),
340 - '<a href="' . esc_url( self::get_form_too_long_docs_url() ) . '" target="_blank" rel="noopener">',
309 + '<a href="https://formidableforms.com/knowledgebase/i-have-a-long-form-why-did-the-options-at-the-end-of-the-form-stop-saving/?utm_source=WordPress&utm_medium=builder&utm_campaign=liteplugin" target="_blank" rel="noopener">',
341 310 '</a>'
342 311 );
343 312 }
344 313
@@ -349,32 +318,17 @@
349 318 self::get_edit_vars( $id, array(), $message );
350 319 }
351 320
352 321 /**
353 - * @since 6.25.1
354 - *
355 - * @return string
356 - */
357 - private static function get_form_too_long_docs_url() {
358 - $utm = array(
359 - 'campaign' => 'builder',
360 - 'content' => 'form-too-long',
361 - );
362 - return FrmAppHelper::admin_upgrade_link( $utm, 'knowledgebase/i-have-a-long-form-why-did-the-options-at-the-end-of-the-form-stop-saving/' );
363 - }
364 -
365 - /**
366 322 * Remove the draft flag from any new fields from this current session.
367 323 *
368 324 * @since 6.8
369 325 *
370 326 * @param int $form_id
371 - *
372 327 * @return void
373 328 */
374 329 private static function maybe_remove_draft_option_from_fields( $form_id ) {
375 330 $draft_field_ids_csv = FrmAppHelper::get_post_param( 'draft_fields', '', 'sanitize_text_field' );
376 -
377 331 if ( ! $draft_field_ids_csv ) {
378 332 // If the draft_fields input is empty there are no new fields in the session.
379 333 return;
380 334 }
@@ -379,9 +333,8 @@
379 333 return;
380 334 }
381 335
382 336 $draft_field_ids = array_filter( explode( ',', $draft_field_ids_csv ), 'is_numeric' );
383 -
384 337 if ( ! $draft_field_ids ) {
385 338 // Exit early if the draft fields input is invalid. It should be a CSV of integer values.
386 339 return;
387 340 }
@@ -386,9 +339,8 @@
386 339 return;
387 340 }
388 341
389 342 $draft_field_rows = FrmFieldsHelper::get_draft_field_results( $form_id, $draft_field_ids );
390 -
391 343 foreach ( $draft_field_rows as $row ) {
392 344 $row->field_options['draft'] = 0;
393 345 FrmField::update( $row->id, array( 'field_options' => $row->field_options ) );
394 346 }
@@ -400,10 +352,8 @@
400 352 * were likely not saved either.
401 353 *
402 354 * @since 3.06.01
403 355 *
404 - * @param array $values
405 - *
406 356 * @return bool
407 357 */
408 358 private static function is_too_long( $values ) {
409 359 return empty( $values['frm_end'] );
@@ -439,17 +389,13 @@
439 389 * @return string|null
440 390 */
441 391 public static function page_preview() {
442 392 $params = FrmForm::list_page_params();
443 -
444 - if ( ! $params['form'] || is_numeric( $params['form'] ) ) {
393 + if ( ! $params['form'] ) {
445 394 return null;
446 395 }
447 396
448 - self::maybe_block_preview( $params['form'] );
449 -
450 397 $form = FrmForm::getOne( $params['form'] );
451 -
452 398 if ( ! $form ) {
453 399 return null;
454 400 }
455 401
@@ -461,19 +407,9 @@
461 407 *
462 408 * @return void
463 409 */
464 410 public static function show_page_preview() {
465 - $preview = self::page_preview();
466 -
467 - if ( is_null( $preview ) ) {
468 - wp_die(
469 - '<h1>' . esc_html__( 'Form key is invalid', 'formidable' ) . '</h1>',
470 - '<p>' . esc_html__( 'Form key is invalid', 'formidable' ) . '</p>',
471 - 404
472 - );
473 - }
474 -
475 - echo $preview; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
411 + echo self::page_preview(); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
476 412 }
477 413
478 414 /**
479 415 * @return void
@@ -484,19 +420,9 @@
484 420
485 421 global $frm_vars;
486 422 $frm_vars['preview'] = true;
487 423
488 - // print_emoji_styles is deprecated.
489 - remove_action( 'wp_print_styles', 'print_emoji_styles' );
490 -
491 - if ( FrmTestModeController::should_add_test_mode_container() ) {
492 - do_action( 'frm_test_mode_init' );
493 - add_action( 'wp_enqueue_scripts', 'FrmTestModeController::register_and_enqueue_required_scripts' );
494 - add_filter( 'frm_filter_final_form', 'FrmTestModeController::maybe_add_test_mode_container', 99 );
495 - }
496 -
497 424 $include_theme = FrmAppHelper::get_param( 'theme', '', 'get', 'absint' );
498 -
499 425 if ( $include_theme ) {
500 426 self::set_preview_query();
501 427 self::load_theme_preview();
502 428 } else {
@@ -519,9 +445,8 @@
519 445 'post_type' => 'page',
520 446 );
521 447
522 448 $page_for_posts = get_option( 'page_for_posts' );
523 -
524 449 if ( is_numeric( $page_for_posts ) ) {
525 450 // Avoid querying for the "Posts Page" or "Blog Page" so we don't display 10 forms.
526 451 $page_query['post__not_in'] = array( $page_for_posts );
527 452 }
@@ -526,15 +451,13 @@
526 451 $page_query['post__not_in'] = array( $page_for_posts );
527 452 }
528 453
529 454 $random_page = get_posts( $page_query );
530 -
531 455 if ( ! $random_page ) {
532 456 return;
533 457 }
534 458
535 459 $random_page = reset( $random_page );
536 -
537 460 if ( ! is_a( $random_page, 'WP_Post' ) ) {
538 461 // The return type can also be int.
539 462 return;
540 463 }
@@ -556,9 +479,8 @@
556 479 *
557 480 * @since 5.5.2
558 481 *
559 482 * @param WP_Post $page The page object.
560 - *
561 483 * @return void
562 484 */
563 485 private static function set_post_global( $page ) {
564 486 global $post;
@@ -577,16 +499,14 @@
577 499 add_action( 'loop_no_results', 'FrmFormsController::show_page_preview' );
578 500 add_filter( 'is_active_sidebar', '__return_false' );
579 501 FrmStylesController::enqueue_css( 'enqueue', true );
580 502
581 - if ( false !== get_template_part( 'page' ) ) {
582 - return;
503 + if ( false === get_template_part( 'page' ) ) {
504 + if ( function_exists( 'wp_is_block_theme' ) && wp_is_block_theme() ) {
505 + add_filter( 'body_class', 'FrmFormsController::preview_block_theme_body_classnames' );
506 + }
507 + self::fallback_when_page_template_part_is_not_supported_by_theme();
583 508 }
584 -
585 - if ( function_exists( 'wp_is_block_theme' ) && wp_is_block_theme() ) {
586 - add_filter( 'body_class', 'FrmFormsController::preview_block_theme_body_classnames' );
587 - }
588 - self::fallback_when_page_template_part_is_not_supported_by_theme();
589 509 }
590 510
591 511 /**
592 512 * Add padding to the body for block themes.
@@ -593,9 +513,8 @@
593 513 *
594 514 * @since 6.5.2
595 515 *
596 516 * @param array $classes The body classes list.
597 - *
598 517 * @return array
599 518 */
600 519 public static function preview_block_theme_body_classnames( $classes ) {
601 520 $classes[] = 'has-global-padding';
@@ -608,27 +527,21 @@
608 527 *
609 528 * @return void
610 529 */
611 530 private static function fallback_when_page_template_part_is_not_supported_by_theme() {
612 - if ( ! have_posts() ) {
613 - return;
614 - }
531 + if ( have_posts() ) {
532 + the_post();
533 + self::get_template( 'header' );
615 534
616 - the_post();
617 - self::get_template( 'header' );
535 + // add some generic class names to the container to add some natural padding to the content.
536 + // .entry-content catches the WordPress TwentyTwenty theme.
537 + // .container catches Customizr content.
538 + echo '<div class="container entry-content">';
539 + the_content();
540 + echo '</div>';
618 541
619 - // Add some generic class names to the container to add some natural padding to the content.
620 - // .entry-content catches the WordPress TwentyTwenty theme.
621 - // .container catches Customizr content.
622 - echo '<div class="container entry-content">';
623 - the_content();
624 - echo '</div>';
625 -
626 - // Prevent extra unexpected forms in the footer.
627 - // For some reason this happens in the Twenty Twenty Five theme.
628 - add_filter( 'frm_filter_final_form', '__return_empty_string' );
629 -
630 - self::get_template( 'footer' );
542 + self::get_template( 'footer' );
543 + }
631 544 }
632 545
633 546 /**
634 547 * Calls core function to get a template part if it doesn't cause deprecation warnings. Otherwise skips the deprecation function call
@@ -634,11 +547,9 @@
634 547 * Calls core function to get a template part if it doesn't cause deprecation warnings. Otherwise skips the deprecation function call
635 548 * and renders required html fragments calling required functions.
636 549 *
637 550 * @since 6.7.1
638 - *
639 551 * @param string $template
640 - *
641 552 * @return void
642 553 */
643 554 private static function get_template( $template ) {
644 555 if ( self::should_try_getting_template( $template ) ) {
@@ -659,11 +570,9 @@
659 570 /**
660 571 * Returns true if calling a template function doesn't trigger deprecation warnings.
661 572 *
662 573 * @since 6.7.1
663 - *
664 574 * @param string $template
665 - *
666 575 * @return bool
667 576 */
668 577 private static function should_try_getting_template( $template ) {
669 578 $stylesheet_path = get_stylesheet_directory();
@@ -677,15 +586,15 @@
677 586 /**
678 587 * Set the page title for the theme preview page
679 588 *
680 589 * @since 3.0
681 - *
682 - * @param string $title
683 - *
684 - * @return string
685 590 */
686 591 public static function preview_page_title( $title ) {
687 - return in_the_loop() ? self::preview_title( $title ) : $title;
592 + if ( in_the_loop() ) {
593 + $title = self::preview_title( $title );
594 + }
595 +
596 + return $title;
688 597 }
689 598
690 599 /**
691 600 * Set the page title for the theme preview page.
@@ -692,9 +601,8 @@
692 601 *
693 602 * @since 3.0
694 603 *
695 604 * @param string $title
696 - *
697 605 * @return string
698 606 */
699 607 public static function preview_title( $title ) {
700 608 return __( 'Form Preview', 'formidable' );
@@ -705,9 +613,8 @@
705 613 *
706 614 * @since 3.0
707 615 *
708 616 * @param string $content
709 - *
710 617 * @return string
711 618 */
712 619 public static function preview_content( $content ) {
713 620 if ( in_the_loop() ) {
@@ -722,39 +629,23 @@
722 629 /**
723 630 * @since 3.0
724 631 */
725 632 private static function load_direct_preview() {
633 + header( 'Content-Type: text/html; charset=' . get_option( 'blog_charset' ) );
634 +
635 + // print_emoji_styles is deprecated.
636 + remove_action( 'wp_print_styles', 'print_emoji_styles' );
637 +
726 638 $key = FrmAppHelper::simple_get( 'form', 'sanitize_title' );
727 -
728 - // phpcs:ignore Universal.Operators.StrictComparisons
729 639 if ( $key == '' ) {
730 640 $key = FrmAppHelper::get_post_param( 'form', '', 'sanitize_title' );
731 641 }
732 642
733 - if ( ! $key ) {
734 - $error = __( 'Form key is missing', 'formidable' );
735 - wp_die(
736 - '<h1>' . esc_html( $error ) . '</h1>',
737 - '<p>' . esc_html( $error ) . '</p>',
738 - 404
739 - );
740 - }
741 -
742 - self::maybe_block_preview( $key );
743 -
744 643 $form = FrmForm::getAll( array( 'form_key' => $key ), '', 1 );
745 -
746 - if ( ! $form ) {
747 - $error = __( 'Form does not exist', 'formidable' );
748 - wp_die(
749 - '<h1>' . esc_html( $error ) . '</h1>',
750 - '<p>' . esc_html( $error ) . '</p>',
751 - 404
752 - );
644 + if ( empty( $form ) ) {
645 + $form = FrmForm::getAll( array(), '', 1 );
753 646 }
754 647
755 - header( 'Content-Type: text/html; charset=' . get_option( 'blog_charset' ) );
756 -
757 648 self::fix_deprecated_null_param_warning();
758 649
759 650 require FrmAppHelper::plugin_path() . '/classes/views/frm-entries/direct.php';
760 651 }
@@ -759,33 +650,8 @@
759 650 require FrmAppHelper::plugin_path() . '/classes/views/frm-entries/direct.php';
760 651 }
761 652
762 653 /**
763 - * Block the form preview for the contact form by default if the user cannot view forms.
764 - * This is to prevent the contact form being exploited.
765 - * Since this form is added by default and every site uses the same key, it is too easy
766 - * to guess this form.
767 - *
768 - * @since 6.20
769 - *
770 - * @param string $form_key Form key.
771 - *
772 - * @return void
773 - */
774 - public static function maybe_block_preview( $form_key ) {
775 - if ( ! FrmFormsHelper::should_block_preview( $form_key ) ) {
776 - return;
777 - }
778 -
779 - $error = __( 'You do not have permission to view this form', 'formidable' );
780 - wp_die(
781 - '<h1>' . esc_html( $error ) . '</h1>',
782 - '<p>' . esc_html( $error ) . '</p>',
783 - 403
784 - );
785 - }
786 -
787 - /**
788 654 * Some themes have a null $src value.
789 655 * This function adds a filter to ensure that $src is not null.
790 656 * WP will call str_starts_with with the null value triggering a deprecated message otherwise.
791 657 *
@@ -797,13 +663,15 @@
797 663 add_filter(
798 664 'script_loader_src',
799 665 /**
800 666 * @param string|null $src
801 - *
802 667 * @return string
803 668 */
804 669 function ( $src ) {
805 - return is_null( $src ) ? '' : $src;
670 + if ( is_null( $src ) ) {
671 + $src = '';
672 + }
673 + return $src;
806 674 }
807 675 );
808 676 }
809 677
@@ -812,9 +680,8 @@
812 680 }
813 681
814 682 /**
815 683 * @param array $ids
816 - *
817 684 * @return string
818 685 */
819 686 public static function bulk_untrash( $ids ) {
820 687 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -826,9 +693,11 @@
826 693 return '';
827 694 }
828 695
829 696 /* translators: %1$s: Number of forms */
830 - return sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
697 + $message = sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
698 +
699 + return $message;
831 700 }
832 701
833 702 /**
834 703 * @since 3.06
@@ -873,9 +742,8 @@
873 742 // Check nonce url.
874 743 check_admin_referer( $status . '_form_' . $params['id'] );
875 744
876 745 $count = 0;
877 -
878 746 if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
879 747 ++$count;
880 748 }
881 749
@@ -889,9 +757,9 @@
889 757 /* translators: %1$s: Number of forms */
890 758 $available_status['untrash']['message'] = sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
891 759
892 760 /* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
893 - $available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
761 + $available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
894 762
895 763 $message = $available_status[ $status ]['message'];
896 764
897 765 self::display_forms_list( $params, $message );
@@ -898,9 +766,8 @@
898 766 }
899 767
900 768 /**
901 769 * @param array $ids
902 - *
903 770 * @return string
904 771 */
905 772 public static function bulk_trash( $ids ) {
906 773 FrmAppHelper::permission_check( 'frm_delete_forms' );
@@ -905,9 +772,8 @@
905 772 public static function bulk_trash( $ids ) {
906 773 FrmAppHelper::permission_check( 'frm_delete_forms' );
907 774
908 775 $count = 0;
909 -
910 776 foreach ( $ids as $id ) {
911 777 if ( FrmForm::trash( $id ) ) {
912 778 ++$count;
913 779 }
@@ -922,16 +788,17 @@
922 788 'param' => 'form_type',
923 789 'type' => 'request',
924 790 )
925 791 );
926 -
927 - return sprintf(
792 + $message = sprintf(
928 793 /* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
929 794 _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
930 795 $count,
931 - '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=list&action=bulk_untrash&form_type=' . $current_page . '&item-action=' . implode( ',', $ids ), 'bulk-toplevel_page_formidable' ) ) . '">', // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
796 + '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=list&action=bulk_untrash&form_type=' . $current_page . '&item-action=' . implode( ',', $ids ), 'bulk-toplevel_page_formidable' ) ) . '">',
932 797 '</a>'
933 798 );
799 +
800 + return $message;
934 801 }
935 802
936 803 public static function destroy() {
937 804 FrmAppHelper::permission_check( 'frm_delete_forms' );
@@ -941,9 +808,8 @@
941 808 // Check nonce url.
942 809 check_admin_referer( 'destroy_form_' . $params['id'] );
943 810
944 811 $count = 0;
945 -
946 812 if ( FrmForm::destroy( $params['id'] ) ) {
947 813 ++$count;
948 814 }
949 815
@@ -954,9 +820,8 @@
954 820 }
955 821
956 822 /**
957 823 * @param array $ids
958 - *
959 824 * @return string
960 825 */
961 826 public static function bulk_destroy( $ids ) {
962 827 FrmAppHelper::permission_check( 'frm_delete_forms' );
@@ -961,12 +826,10 @@
961 826 public static function bulk_destroy( $ids ) {
962 827 FrmAppHelper::permission_check( 'frm_delete_forms' );
963 828
964 829 $count = 0;
965 -
966 830 foreach ( $ids as $id ) {
967 831 $d = FrmForm::destroy( $id );
968 -
969 832 if ( $d ) {
970 833 ++$count;
971 834 }
972 835 }
@@ -984,18 +847,19 @@
984 847 */
985 848 public static function delete_all() {
986 849 // Check nonce url.
987 850 $permission_error = FrmAppHelper::permission_nonce_error( 'frm_delete_forms', '_wpnonce', 'bulk-toplevel_page_formidable' );
988 -
989 851 if ( $permission_error !== false ) {
990 852 self::display_forms_list( array(), '', array( $permission_error ) );
853 +
991 854 return;
992 855 }
993 856
994 857 $count = FrmForm::scheduled_delete( time() );
995 858 $url = remove_query_arg( array( 'delete_all' ) );
996 - $url .= '&message=forms_permanently_deleted&forms_deleted=' . $count;
997 859
860 + $url .= '&message=forms_permanently_deleted&forms_deleted=' . $count;
861 +
998 862 wp_safe_redirect( $url );
999 863 die();
1000 864 }
1001 865
@@ -1069,22 +933,21 @@
1069 933 *
1070 934 * @return void
1071 935 */
1072 936 public static function insert_form_button() {
1073 - if ( ! current_user_can( 'frm_view_forms' ) ) {
1074 - return;
937 + if ( current_user_can( 'frm_view_forms' ) ) {
938 + // Store the result in memory and re-use it when this function is called multiple times.
939 + // This helps speed up the form builder when there are a lot of HTML fields, where this
940 + // button is inserted once per HTML field.
941 + // In a form with 66 HTML fields, this saves 0.5 seconds on page load time, tested locally.
942 + if ( ! isset( self::$formidable_tinymce_button ) ) {
943 + FrmAppHelper::load_admin_wide_js();
944 + $menu_name = FrmAppHelper::get_menu_name();
945 + $icon = apply_filters( 'frm_media_icon', FrmAppHelper::svg_logo() );
946 + self::$formidable_tinymce_button = '<a href="#TB_inline?width=50&height=50&inlineId=frm_insert_form" class="thickbox button add_media frm_insert_form" title="' . esc_attr__( 'Add forms and content', 'formidable' ) . '">' . FrmAppHelper::kses( $icon, 'all' ) . ' ' . esc_html( $menu_name ) . '</a>';
947 + }
948 + echo self::$formidable_tinymce_button; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
1075 949 }
1076 -
1077 - // Store the result in memory and re-use it when this function is called multiple times.
1078 - // This helps speed up the form builder when there are a lot of HTML fields, where this
1079 - // Button is inserted once per HTML field.
1080 - // In a form with 66 HTML fields, this saves 0.5 seconds on page load time, tested locally.
1081 - if ( ! isset( self::$formidable_tinymce_button ) ) {
1082 - FrmAppHelper::load_admin_wide_js();
1083 - $icon = apply_filters( 'frm_media_icon', FrmAppHelper::svg_logo() );
1084 - self::$formidable_tinymce_button = '<a href="#TB_inline?width=50&height=50&inlineId=frm_insert_form" class="thickbox button add_media frm_insert_form" title="' . esc_attr__( 'Add forms and content', 'formidable' ) . '">' . FrmAppHelper::kses( $icon, 'all' ) . ' ' . esc_html( FrmAppHelper::get_menu_name() ) . '</a>'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1085 - }
1086 - echo self::$formidable_tinymce_button; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
1087 950 }
1088 951
1089 952 /**
1090 953 * @return void
@@ -1105,21 +968,17 @@
1105 968 $shortcodes = apply_filters( 'frm_popup_shortcodes', $shortcodes );
1106 969
1107 970 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/insert_form_popup.php';
1108 971
1109 - if ( ! FrmAppHelper::is_form_builder_page() || class_exists( '_WP_Editors', false ) ) {
1110 - return;
972 + if ( FrmAppHelper::is_form_builder_page() && ! class_exists( '_WP_Editors', false ) ) {
973 + // initialize a wysiwyg so we have usable settings defined in tinyMCEPreInit.mceInit
974 + require ABSPATH . WPINC . '/class-wp-editor.php';
975 + ?>
976 + <div class="frm_hidden">
977 + <?php wp_editor( '', 'frm_description_placeholder', array() ); ?>
978 + </div>
979 + <?php
1111 980 }
1112 -
1113 - // Initialize a wysiwyg so we have usable settings defined in tinyMCEPreInit.mceInit
1114 - require ABSPATH . WPINC . '/class-wp-editor.php';
1115 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
1116 - ?>
1117 - <div class="frm_hidden">
1118 - <?php wp_editor( '', 'frm_description_placeholder', array() ); ?>
1119 - </div>
1120 - <?php
1121 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
1122 981 }
1123 982
1124 983 /**
1125 984 * Check the page being loaded, determine if this is a page that should include the form popup.
@@ -1131,9 +990,8 @@
1131 990 private static function should_insert_form_popup() {
1132 991 if ( FrmAppHelper::is_form_builder_page() ) {
1133 992 return true;
1134 993 }
1135 -
1136 994 $page = basename( FrmAppHelper::get_server_value( 'PHP_SELF' ) );
1137 995 return in_array( $page, array( 'post.php', 'page.php', 'page-new.php', 'post-new.php' ), true );
1138 996 }
1139 997
@@ -1141,10 +999,9 @@
1141 999 FrmAppHelper::permission_check( 'frm_view_forms' );
1142 1000 check_ajax_referer( 'frm_ajax', 'nonce' );
1143 1001
1144 1002 $shortcode = FrmAppHelper::get_post_param( 'shortcode', '', 'sanitize_text_field' );
1145 -
1146 - if ( ! $shortcode ) {
1003 + if ( empty( $shortcode ) ) {
1147 1004 wp_die();
1148 1005 }
1149 1006
1150 1007 echo '<div id="sc-opts-' . esc_attr( $shortcode ) . '" class="frm_shortcode_option">';
@@ -1169,13 +1026,12 @@
1169 1026 'label' => __( 'Minimize form HTML', 'formidable' ),
1170 1027 ),
1171 1028 );
1172 1029 }
1173 -
1174 1030 $opts = apply_filters( 'frm_sc_popup_opts', $opts, $shortcode );
1175 1031
1176 1032 if ( isset( $opts['form_id'] ) && is_string( $opts['form_id'] ) ) {
1177 - // Allow other shortcodes to use the required form id option
1033 + // allow other shortcodes to use the required form id option
1178 1034 $form_id = $opts['form_id'];
1179 1035 unset( $opts['form_id'] );
1180 1036 }
1181 1037
@@ -1191,9 +1047,8 @@
1191 1047 *
1192 1048 * @param array $params
1193 1049 * @param string $message
1194 1050 * @param array $errors
1195 - *
1196 1051 * @return void
1197 1052 */
1198 1053 public static function display_forms_list( $params = array(), $message = '', $errors = array() ) {
1199 1054 FrmAppHelper::permission_check( 'frm_view_forms' );
@@ -1210,21 +1065,21 @@
1210 1065 * @param string $table_class Class name for List Helper.
1211 1066 */
1212 1067 $table_class = apply_filters( 'frm_forms_list_class', 'FrmFormsListHelper' );
1213 1068 $wp_list_table = new $table_class( compact( 'params' ) );
1214 - $pagenum = $wp_list_table->get_pagenum();
1215 1069
1070 + $pagenum = $wp_list_table->get_pagenum();
1071 +
1216 1072 $wp_list_table->prepare_items();
1217 1073
1218 1074 $total_pages = $wp_list_table->get_pagination_arg( 'total_pages' );
1219 -
1220 1075 if ( $pagenum > $total_pages && $total_pages > 0 ) {
1221 - wp_safe_redirect( esc_url_raw( add_query_arg( 'paged', $total_pages ) ) );
1076 + wp_redirect( esc_url_raw( add_query_arg( 'paged', $total_pages ) ) );
1222 1077 die();
1223 1078 }
1224 1079
1225 - $error = FrmInbox::check_for_error();
1226 -
1080 + $inbox = new FrmInbox();
1081 + $error = $inbox->check_for_error();
1227 1082 if ( $error ) {
1228 1083 $show_messages = array( $error['subject'] . '. ' . $error['message'] );
1229 1084 }
1230 1085
@@ -1232,34 +1087,19 @@
1232 1087 }
1233 1088
1234 1089 /**
1235 1090 * @param array<string,string> $columns
1236 - *
1237 1091 * @return array<string,string>
1238 1092 */
1239 1093 public static function get_columns( $columns ) {
1240 - $columns['cb'] = '<input type="checkbox" />';
1241 - $columns['name'] = esc_html__( 'Form Title', 'formidable' );
1242 - $columns['entries'] = esc_html__( 'Entries', 'formidable' );
1243 - $columns['views'] = esc_html__( 'Views', 'formidable' );
1244 - $columns['id'] = 'ID';
1245 - $columns['form_key'] = esc_html__( 'Key', 'formidable' );
1246 -
1247 - if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) && has_filter( 'frm_form_list_actions' ) ) {
1248 - // If there is any filters added, keep this column.
1249 - $columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
1250 - }
1251 -
1094 + $columns['cb'] = '<input type="checkbox" />';
1095 + $columns['name'] = esc_html__( 'Form Title', 'formidable' );
1096 + $columns['entries'] = esc_html__( 'Entries', 'formidable' );
1097 + $columns['id'] = 'ID';
1098 + $columns['form_key'] = esc_html__( 'Key', 'formidable' );
1099 + $columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
1252 1100 $columns['created_at'] = esc_html__( 'Date', 'formidable' );
1253 1101
1254 - if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) ) {
1255 - $columns['embeds'] = esc_html__( 'Embeds', 'formidable' );
1256 - $columns['settings'] = '<div class="frm-forms-list-settings-btn-wrapper"><a href="#" class="frm-forms-list-settings-btn">';
1257 - $columns['settings'] .= FrmAppHelper::icon_by_class( 'frmfont frm_settings_icon', array( 'echo' => false ) );
1258 - $columns['settings'] .= '<span class="screen-reader-text">' . esc_html__( 'List settings', 'formidable' ) . '</span>';
1259 - $columns['settings'] .= '</a></div>';
1260 - }
1261 -
1262 1102 add_screen_option(
1263 1103 'per_page',
1264 1104 array(
1265 1105 'label' => __( 'Forms', 'formidable' ),
@@ -1285,9 +1125,8 @@
1285 1125 }
1286 1126
1287 1127 /**
1288 1128 * @param mixed $hidden_columns
1289 - *
1290 1129 * @return array
1291 1130 */
1292 1131 public static function hidden_columns( $hidden_columns ) {
1293 1132 if ( ! is_array( $hidden_columns ) ) {
@@ -1308,18 +1147,11 @@
1308 1147
1309 1148 return $hidden_columns;
1310 1149 }
1311 1150
1312 - /**
1313 - * @param mixed $save
1314 - * @param string $option
1315 - * @param int|string $value
1316 - *
1317 - * @return mixed
1318 - */
1319 1151 public static function save_per_page( $save, $option, $value ) {
1320 1152 if ( $option === 'formidable_page_formidable_per_page' ) {
1321 - return (int) $value;
1153 + $save = (int) $value;
1322 1154 }
1323 1155
1324 1156 return $save;
1325 1157 }
@@ -1328,9 +1160,8 @@
1328 1160 * @param int|string $id
1329 1161 * @param array $errors
1330 1162 * @param string $message
1331 1163 * @param bool $create_link
1332 - *
1333 1164 * @return void
1334 1165 */
1335 1166 private static function get_edit_vars( $id, $errors = array(), $message = '', $create_link = false ) {
1336 1167 global $frm_vars;
@@ -1345,9 +1176,8 @@
1345 1176 'page' => 'formidable',
1346 1177 )
1347 1178 ),
1348 1179 );
1349 -
1350 1180 if ( ! $form ) {
1351 1181 FrmAppController::show_error_modal( $error_args );
1352 1182 return;
1353 1183 }
@@ -1369,14 +1199,15 @@
1369 1199 }
1370 1200
1371 1201 if ( $form->parent_form_id ) {
1372 1202 /* translators: %1$s: Start link HTML, %2$s: End link HTML */
1373 - wp_die( sprintf( esc_html__( 'You are trying to edit a child form. Please edit from %1$shere%2$s', 'formidable' ), '<a href="' . esc_url( FrmForm::get_edit_link( $form->parent_form_id ) ) . '">', '</a>' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1203 + wp_die( sprintf( esc_html__( 'You are trying to edit a child form. Please edit from %1$shere%2$s', 'formidable' ), '<a href="' . esc_url( FrmForm::get_edit_link( $form->parent_form_id ) ) . '">', '</a>' ) );
1374 1204 }
1375 1205
1376 1206 $frm_field_selection = FrmField::field_selection();
1377 - $fields = FrmField::get_all_for_form( $form->id );
1378 1207
1208 + $fields = FrmField::get_all_for_form( $form->id );
1209 +
1379 1210 // Automatically add end section fields if they don't exist (2.0 migration).
1380 1211 $reset_fields = false;
1381 1212 FrmFormsHelper::auto_add_end_section_fields( $form, $fields, $reset_fields );
1382 1213 FrmSubmitHelper::maybe_create_submit_field( $form, $fields, $reset_fields );
@@ -1400,10 +1231,9 @@
1400 1231 */
1401 1232 $values['fields'] = apply_filters( 'frm_fields_in_form_builder', $fields, compact( 'form' ) );
1402 1233
1403 1234 $edit_message = __( 'Form was successfully updated.', 'formidable' );
1404 -
1405 - if ( $form->is_template && $message === $edit_message ) {
1235 + if ( $form->is_template && $message == $edit_message ) {
1406 1236 $message = __( 'Template was successfully updated.', 'formidable' );
1407 1237 }
1408 1238
1409 1239 self::maybe_update_form_builder_message( $message );
@@ -1418,12 +1248,11 @@
1418 1248 }
1419 1249
1420 1250 /**
1421 1251 * @param array $fields
1422 - *
1423 1252 * @return array
1424 1253 */
1425 - public static function update_form_builder_fields( $fields ) {
1254 + public static function update_form_builder_fields( $fields, $form ) {
1426 1255 foreach ( $fields as $field ) {
1427 1256 $field->do_not_include_icons = true;
1428 1257 }
1429 1258 return $fields;
@@ -1428,13 +1257,8 @@
1428 1257 }
1429 1258 return $fields;
1430 1259 }
1431 1260
1432 - /**
1433 - * @param string $message
1434 - *
1435 - * @return void
1436 - */
1437 1261 public static function maybe_update_form_builder_message( &$message ) {
1438 1262 if ( 'form_duplicated' === FrmAppHelper::simple_get( 'message' ) ) {
1439 1263 $message = __( 'Form was Successfully Copied', 'formidable' );
1440 1264 }
@@ -1443,9 +1267,8 @@
1443 1267 /**
1444 1268 * @param int|string $id
1445 1269 * @param array $errors
1446 1270 * @param array|string $args
1447 - *
1448 1271 * @return void
1449 1272 */
1450 1273 public static function get_settings_vars( $id, $errors = array(), $args = array() ) {
1451 1274 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -1467,12 +1290,13 @@
1467 1290 );
1468 1291 $args = array_merge( $defaults, $args );
1469 1292 $message = $args['message'];
1470 1293 $warnings = $args['warnings'];
1471 - $form = FrmForm::getOne( $id );
1472 - $fields = FrmField::get_all_for_form( $id );
1473 - $values = FrmAppHelper::setup_edit_vars( $form, 'forms', $fields, true );
1474 1294
1295 + $form = FrmForm::getOne( $id );
1296 + $fields = FrmField::get_all_for_form( $id );
1297 + $values = FrmAppHelper::setup_edit_vars( $form, 'forms', $fields, true );
1298 +
1475 1299 /**
1476 1300 * Allows changing fields in the form settings.
1477 1301 *
1478 1302 * @since 5.0.04
@@ -1512,12 +1336,8 @@
1512 1336 }
1513 1337
1514 1338 /**
1515 1339 * @since 4.0
1516 - *
1517 - * @param array $atts
1518 - *
1519 - * @return void
1520 1340 */
1521 1341 public static function form_publish_button( $atts ) {
1522 1342 $values = $atts['values'];
1523 1343 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/_publish_box.php';
@@ -1528,9 +1348,8 @@
1528 1348 *
1529 1349 * @since 4.0
1530 1350 *
1531 1351 * @param array $values
1532 - *
1533 1352 * @return array
1534 1353 */
1535 1354 private static function get_settings_tabs( $values ) {
1536 1355 $sections = array(
@@ -1536,20 +1355,20 @@
1536 1355 $sections = array(
1537 1356 'advanced' => array(
1538 1357 'name' => __( 'General', 'formidable' ),
1539 1358 'title' => __( 'General Form Settings', 'formidable' ),
1540 - 'function' => array( self::class, 'advanced_settings' ),
1541 - 'icon' => 'frmfont frm_small_settings_icon',
1359 + 'function' => array( __CLASS__, 'advanced_settings' ),
1360 + 'icon' => 'frm_icon_font frm_settings_icon',
1542 1361 ),
1543 1362 'email' => array(
1544 1363 'name' => __( 'Actions & Notifications', 'formidable' ),
1545 1364 'function' => array( 'FrmFormActionsController', 'email_settings' ),
1546 1365 'id' => 'frm_notification_settings',
1547 - 'icon' => 'frmfont frm_notification_check_icon',
1366 + 'icon' => 'frm_icon_font frm_mail_bulk_icon',
1548 1367 ),
1549 1368 'permissions' => array(
1550 1369 'name' => __( 'Form Permissions', 'formidable' ),
1551 - 'icon' => 'frmfont frm_lock_closed2_icon',
1370 + 'icon' => 'frm_icon_font frm_lock_closed_icon',
1552 1371 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1553 1372 'data' => array(
1554 1373 'medium' => 'permissions',
1555 1374 'upgrade' => __( 'Form Permissions', 'formidable' ),
@@ -1554,37 +1373,35 @@
1554 1373 'medium' => 'permissions',
1555 1374 'upgrade' => __( 'Form Permissions', 'formidable' ),
1556 1375 'message' => __( 'Allow editing, protect forms and files, limit entries, and save drafts. Upgrade to get form and entry permissions.', 'formidable' ),
1557 1376 'screenshot' => 'permissions.png',
1558 - 'learn-more' => FrmAppHelper::get_doc_url( 'general-form-settings/#kb-form-permissions', 'form-permissions-settings' ),
1559 1377 ),
1560 1378 ),
1561 1379 'scheduling' => array(
1562 1380 'name' => __( 'Form Scheduling', 'formidable' ),
1563 - 'icon' => 'frmfont frm_schedule_icon',
1381 + 'icon' => 'frm_icon_font frm_calendar_icon',
1564 1382 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1565 1383 'data' => array(
1566 1384 'medium' => 'scheduling',
1567 1385 'upgrade' => __( 'Form scheduling settings', 'formidable' ),
1568 1386 'screenshot' => 'scheduling.png',
1569 - 'learn-more' => FrmAppHelper::get_doc_url( 'general-form-settings/#kb-form-scheduling', 'form-scheduling-settings' ),
1570 1387 ),
1571 1388 ),
1572 1389 'buttons' => array(
1573 1390 'name' => __( 'Buttons', 'formidable' ),
1574 - 'class' => self::class,
1391 + 'class' => __CLASS__,
1575 1392 'function' => 'buttons_settings',
1576 - 'icon' => 'frmfont frm-buttons-style',
1393 + 'icon' => 'frm_icon_font frm_button_icon',
1577 1394 ),
1578 1395 'landing' => array(
1579 1396 'name' => __( 'Form Landing Page', 'formidable' ),
1580 - 'icon' => 'frmfont frm_cross_device_icon',
1397 + 'icon' => 'frm_icon_font frm_file_text_icon',
1581 1398 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1582 1399 'data' => FrmAppHelper::get_landing_page_upgrade_data_params(),
1583 1400 ),
1584 1401 'chat' => array(
1585 1402 'name' => __( 'Conversational Forms', 'formidable' ),
1586 - 'icon' => 'frmfont frm_chat_bubbles_icon',
1403 + 'icon' => 'frm_icon_font frm_chat_forms_icon',
1587 1404 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1588 1405 'data' => FrmAppHelper::get_upgrade_data_params(
1589 1406 'chat',
1590 1407 array(
@@ -1590,15 +1407,14 @@
1590 1407 array(
1591 1408 'upgrade' => __( 'Conversational Forms', 'formidable' ),
1592 1409 'message' => __( 'Ask one question at a time for automated conversations.', 'formidable' ),
1593 1410 'screenshot' => 'chat.png',
1594 - 'learn-more' => FrmAppHelper::get_doc_url( 'conversational-forms', 'conversational-forms-settings', false ),
1595 1411 )
1596 1412 ),
1597 1413 ),
1598 1414 'abandonment' => array(
1599 1415 'name' => __( 'Form Abandonment', 'formidable' ),
1600 - 'icon' => 'frmfont frm_abandoned_icon',
1416 + 'icon' => 'frm_icon_font frm_abandoned_icon',
1601 1417 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1602 1418 'data' => FrmAppHelper::get_upgrade_data_params(
1603 1419 'abandonment',
1604 1420 array(
@@ -1604,17 +1420,16 @@
1604 1420 array(
1605 1421 'upgrade' => __( 'Form abandonment settings', 'formidable' ),
1606 1422 'message' => __( 'Unlock the power of data capture to boost lead generation and master the art of form optimization.', 'formidable' ),
1607 1423 'screenshot' => 'abandonment.png',
1608 - 'learn-more' => FrmAppHelper::get_doc_url( 'features/form-abandonment-wordpress-plugin', 'form-abandonment-settings', false ),
1609 1424 )
1610 1425 ),
1611 1426 ),
1612 1427 'html' => array(
1613 1428 'name' => __( 'Customize HTML', 'formidable' ),
1614 - 'class' => self::class,
1429 + 'class' => __CLASS__,
1615 1430 'function' => 'html_settings',
1616 - 'icon' => 'frmfont frm_code2_icon',
1431 + 'icon' => 'frm_icon_font frm_code_icon',
1617 1432 ),
1618 1433 );
1619 1434
1620 1435 if ( ! has_action( 'frm_add_form_style_tab_options' ) && ! has_action( 'frm_add_form_button_options' ) ) {
@@ -1620,8 +1435,14 @@
1620 1435 if ( ! has_action( 'frm_add_form_style_tab_options' ) && ! has_action( 'frm_add_form_button_options' ) ) {
1621 1436 unset( $sections['buttons'] );
1622 1437 }
1623 1438
1439 + foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
1440 + if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
1441 + unset( $sections[ $feature ] );
1442 + }
1443 + }
1444 +
1624 1445 $sections = apply_filters( 'frm_add_form_settings_section', $sections, $values );
1625 1446
1626 1447 foreach ( $sections as $key => $section ) {
1627 1448 $defaults = array(
@@ -1626,9 +1447,9 @@
1626 1447 foreach ( $sections as $key => $section ) {
1627 1448 $defaults = array(
1628 1449 'html_class' => '',
1629 1450 'name' => ucfirst( $key ),
1630 - 'icon' => 'frmfont frm_settings_icon',
1451 + 'icon' => 'frm_icon_font frm_settings_icon',
1631 1452 );
1632 1453
1633 1454 $section = array_merge( $defaults, $section );
1634 1455
@@ -1634,9 +1455,8 @@
1634 1455
1635 1456 if ( ! isset( $section['anchor'] ) ) {
1636 1457 $section['anchor'] = $key;
1637 1458 }
1638 -
1639 1459 $section['anchor'] .= '_settings';
1640 1460
1641 1461 if ( ! isset( $section['title'] ) ) {
1642 1462 $section['title'] = $section['name'];
@@ -1655,19 +1475,18 @@
1655 1475 /**
1656 1476 * @since 4.0
1657 1477 *
1658 1478 * @param array $values
1659 - *
1660 1479 * @return void
1661 1480 */
1662 1481 public static function advanced_settings( $values ) {
1663 1482 $first_h3 = 'frm_first_h3';
1483 +
1664 1484 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-advanced.php';
1665 1485 }
1666 1486
1667 1487 /**
1668 1488 * @param array $values
1669 - *
1670 1489 * @return void
1671 1490 */
1672 1491 public static function render_spam_settings( $values ) {
1673 1492 if ( function_exists( 'akismet_http_post' ) ) {
@@ -1672,9 +1491,9 @@
1672 1491 public static function render_spam_settings( $values ) {
1673 1492 if ( function_exists( 'akismet_http_post' ) ) {
1674 1493 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/akismet.php';
1675 1494 }
1676 - include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/stopforumspam.php';
1495 + include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/honeypot.php';
1677 1496 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/antispam.php';
1678 1497 }
1679 1498
1680 1499 /**
@@ -1680,9 +1499,8 @@
1680 1499 /**
1681 1500 * @since 4.0
1682 1501 *
1683 1502 * @param array $values
1684 - *
1685 1503 * @return void
1686 1504 */
1687 1505 public static function buttons_settings( $values ) {
1688 1506 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-buttons.php';
@@ -1691,9 +1509,8 @@
1691 1509 /**
1692 1510 * @since 4.0
1693 1511 *
1694 1512 * @param array $values
1695 - *
1696 1513 * @return void
1697 1514 */
1698 1515 public static function html_settings( $values ) {
1699 1516 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-html.php';
@@ -1704,9 +1521,8 @@
1704 1521 *
1705 1522 * @since 2.03.08
1706 1523 *
1707 1524 * @param array|bool $values
1708 - *
1709 1525 * @return void
1710 1526 */
1711 1527 private static function clean_submit_html( &$values ) {
1712 1528 if ( is_array( $values ) && isset( $values['submit_html'] ) ) {
@@ -1729,17 +1545,13 @@
1729 1545 return $classes;
1730 1546 }
1731 1547
1732 1548 /**
1733 - * @since 6.27 Added $template_path parameter.
1734 - *
1735 1549 * @param int|string $form_id
1736 1550 * @param string $class
1737 - * @param string $template_path The path to a template file to use instead of the default.
1738 - *
1739 1551 * @return void
1740 1552 */
1741 - public static function mb_tags_box( $form_id, $class = '', $template_path = 'default' ) {
1553 + public static function mb_tags_box( $form_id, $class = '' ) {
1742 1554 $fields = FrmField::get_all_for_form( $form_id, '', 'include' );
1743 1555
1744 1556 /**
1745 1557 * Allows modifying the list of fields in the tags box.
@@ -1748,30 +1560,23 @@
1748 1560 *
1749 1561 * @param array $fields The list of fields.
1750 1562 * @param array $args The arguments. Contains `form_id`.
1751 1563 */
1752 - $fields = apply_filters( 'frm_fields_in_tags_box', $fields, compact( 'form_id' ) );
1753 - $linked_forms = array();
1754 - $col = 'one';
1755 - $settings_tab = FrmAppHelper::is_admin_page( 'formidable' );
1564 + $fields = apply_filters( 'frm_fields_in_tags_box', $fields, compact( 'form_id' ) );
1565 + $linked_forms = array();
1566 + $col = 'one';
1567 + $settings_tab = FrmAppHelper::is_admin_page( 'formidable' );
1568 +
1756 1569 $cond_shortcodes = apply_filters( 'frm_conditional_shortcodes', array() );
1757 1570 $entry_shortcodes = self::get_shortcode_helpers( $settings_tab );
1571 +
1758 1572 $advanced_helpers = self::advanced_helpers( compact( 'fields', 'form_id' ) );
1759 1573
1760 - if ( 'default' === $template_path || ! file_exists( $template_path ) ) {
1761 - include FrmAppHelper::plugin_path() . '/classes/views/shared/mb_adv_info.php';
1762 - return;
1763 - }
1764 -
1765 - include $template_path;
1574 + include FrmAppHelper::plugin_path() . '/classes/views/shared/mb_adv_info.php';
1766 1575 }
1767 1576
1768 1577 /**
1769 1578 * @since 3.04.01
1770 - *
1771 - * @param array $atts
1772 - *
1773 - * @return array
1774 1579 */
1775 1580 private static function advanced_helpers( $atts ) {
1776 1581 $advanced_helpers = array(
1777 1582 'default' => array(
@@ -1780,12 +1585,10 @@
1780 1585 ),
1781 1586 );
1782 1587
1783 1588 $user_fields = self::user_shortcodes();
1784 -
1785 1589 if ( $user_fields ) {
1786 1590 $user_helpers = array();
1787 -
1788 1591 foreach ( $user_fields as $uk => $uf ) {
1789 1592 $user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1790 1593 unset( $uk, $uf );
1791 1594 }
@@ -1810,10 +1613,8 @@
1810 1613 * Get an array of the options to display in the advanced tab
1811 1614 * of the customization panel
1812 1615 *
1813 1616 * @since 2.0.6
1814 - *
1815 - * @return array
1816 1617 */
1817 1618 private static function get_advanced_shortcodes() {
1818 1619 $adv_shortcodes = array(
1819 1620 'x sep=", "' => array(
@@ -1830,18 +1631,17 @@
1830 1631 'label' => __( 'No Auto P', 'formidable' ),
1831 1632 'title' => __( 'Do not automatically add any paragraphs or line breaks', 'formidable' ),
1832 1633 ),
1833 1634 );
1635 + $adv_shortcodes = apply_filters( 'frm_advanced_shortcodes', $adv_shortcodes );
1834 1636
1835 1637 // __( 'Leave blank instead of defaulting to User Login', 'formidable' ) : blank=1
1836 1638
1837 - return apply_filters( 'frm_advanced_shortcodes', $adv_shortcodes );
1639 + return $adv_shortcodes;
1838 1640 }
1839 1641
1840 1642 /**
1841 1643 * @since 3.04.01
1842 - *
1843 - * @return array
1844 1644 */
1845 1645 private static function user_shortcodes() {
1846 1646 $options = array(
1847 1647 'ID' => __( 'User ID', 'formidable' ),
@@ -1860,12 +1660,8 @@
1860 1660 /**
1861 1661 * Get an array of the helper shortcodes to display in the customization panel
1862 1662 *
1863 1663 * @since 2.0.6
1864 - *
1865 - * @param bool $settings_tab
1866 - *
1867 - * @return array
1868 1664 */
1869 1665 private static function get_shortcode_helpers( $settings_tab ) {
1870 1666 $entry_shortcodes = array(
1871 1667 'id' => __( 'Entry ID', 'formidable' ),
@@ -1880,9 +1676,8 @@
1880 1676 'form_name' => __( 'Form Name', 'formidable' ),
1881 1677 );
1882 1678
1883 1679 $entry_shortcodes = array_merge( FrmShortcodeHelper::get_contextual_shortcode_values(), $entry_shortcodes );
1884 -
1885 1680 if ( ! FrmAppHelper::pro_is_installed() ) {
1886 1681 unset( $entry_shortcodes['post_id'] );
1887 1682 }
1888 1683
@@ -1890,13 +1685,12 @@
1890 1685 * Use this hook to add or remove buttons in the helpers section
1891 1686 * in the customization panel
1892 1687 *
1893 1688 * @since 2.0.6
1894 - *
1895 - * @param array $entry_shortcodes
1896 - * @param bool $settings_tab
1897 1689 */
1898 - return apply_filters( 'frm_helper_shortcodes', $entry_shortcodes, $settings_tab );
1690 + $entry_shortcodes = apply_filters( 'frm_helper_shortcodes', $entry_shortcodes, $settings_tab );
1691 +
1692 + return $entry_shortcodes;
1899 1693 }
1900 1694
1901 1695 /**
1902 1696 * Insert the form class setting into the form.
@@ -1901,9 +1695,8 @@
1901 1695 /**
1902 1696 * Insert the form class setting into the form.
1903 1697 *
1904 1698 * @param stdClass $form
1905 - *
1906 1699 * @return void
1907 1700 */
1908 1701 public static function form_classes( $form ) {
1909 1702 if ( isset( $form->options['form_class'] ) ) {
@@ -1914,9 +1707,9 @@
1914 1707 echo ' frm_js_validate ';
1915 1708 self::add_js_validate_form_to_global_vars( $form );
1916 1709 }
1917 1710
1918 - if ( FrmForm::is_ajax_on( $form ) ) {
1711 + if ( ! FrmFormsHelper::should_use_pro_for_ajax_submit() && FrmForm::is_ajax_on( $form ) ) {
1919 1712 echo ' frm_ajax_submit ';
1920 1713 }
1921 1714 }
1922 1715
@@ -1926,9 +1719,8 @@
1926 1719 * @param stdClass $form
1927 1720 */
1928 1721 public static function add_js_validate_form_to_global_vars( $form ) {
1929 1722 global $frm_vars;
1930 -
1931 1723 if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1932 1724 $frm_vars['js_validate_forms'] = array();
1933 1725 }
1934 1726 $frm_vars['js_validate_forms'][ $form->id ] = $form;
@@ -1951,9 +1743,8 @@
1951 1743 /**
1952 1744 * @param string $content
1953 1745 * @param int|stdClass|string $form
1954 1746 * @param false|int|stdClass|string $entry
1955 - *
1956 1747 * @return string
1957 1748 */
1958 1749 public static function filter_content( $content, $form, $entry = false ) {
1959 1750 $content = self::replace_form_name_shortcodes( $content, $form );
@@ -1958,9 +1749,8 @@
1958 1749 public static function filter_content( $content, $form, $entry = false ) {
1959 1750 $content = self::replace_form_name_shortcodes( $content, $form );
1960 1751
1961 1752 self::get_entry_by_param( $entry );
1962 -
1963 1753 if ( ! $entry ) {
1964 1754 return $content;
1965 1755 }
1966 1756
@@ -1976,10 +1766,11 @@
1976 1766 $form = $entry->parent_entry->form_id;
1977 1767 }
1978 1768
1979 1769 $shortcodes = FrmFieldsHelper::get_shortcodes( $content, $form );
1770 + $content = apply_filters( 'frm_replace_content_shortcodes', $content, $entry, $shortcodes );
1980 1771
1981 - return apply_filters( 'frm_replace_content_shortcodes', $content, $entry, $shortcodes );
1772 + return $content;
1982 1773 }
1983 1774
1984 1775 /**
1985 1776 * Replace any [form_name] shortcodes in a string.
@@ -1987,9 +1778,8 @@
1987 1778 * @since 5.5
1988 1779 *
1989 1780 * @param array|string $string
1990 1781 * @param int|stdClass|string $form
1991 - *
1992 1782 * @return array|string
1993 1783 */
1994 1784 public static function replace_form_name_shortcodes( $string, $form ) {
1995 1785 if ( ! is_string( $string ) ) {
@@ -1995,9 +1785,9 @@
1995 1785 if ( ! is_string( $string ) ) {
1996 1786 return $string;
1997 1787 }
1998 1788
1999 - if ( ! str_contains( $string, '[form_name]' ) ) {
1789 + if ( false === strpos( $string, '[form_name]' ) ) {
2000 1790 return $string;
2001 1791 }
2002 1792
2003 1793 if ( ! is_object( $form ) ) {
@@ -2009,30 +1799,20 @@
2009 1799 }
2010 1800
2011 1801 /**
2012 1802 * @param false|int|stdClass|string $entry
2013 - *
2014 1803 * @return void
2015 1804 */
2016 1805 private static function get_entry_by_param( &$entry ) {
2017 - if ( $entry && is_object( $entry ) ) {
2018 - return;
2019 - }
1806 + if ( ! $entry || ! is_object( $entry ) ) {
1807 + if ( ! $entry || ! is_numeric( $entry ) ) {
1808 + $entry = FrmAppHelper::get_post_param( 'id', false, 'sanitize_title' );
1809 + }
2020 1810
2021 - if ( ! $entry || ! is_numeric( $entry ) ) {
2022 - $entry = FrmAppHelper::get_post_param( 'id', false, 'sanitize_title' );
1811 + FrmEntry::maybe_get_entry( $entry );
2023 1812 }
2024 -
2025 - FrmEntry::maybe_get_entry( $entry );
2026 1813 }
2027 1814
2028 - /**
2029 - * @param string $content
2030 - * @param false|object $entry
2031 - * @param array $shortcodes
2032 - *
2033 - * @return string
2034 - */
2035 1815 public static function replace_content_shortcodes( $content, $entry, $shortcodes ) {
2036 1816 return FrmFieldsHelper::replace_content_shortcodes( $content, $entry, $shortcodes );
2037 1817 }
2038 1818
@@ -2037,9 +1817,8 @@
2037 1817 }
2038 1818
2039 1819 /**
2040 1820 * @param array $errors
2041 - *
2042 1821 * @return array
2043 1822 */
2044 1823 public static function process_bulk_form_actions( $errors ) {
2045 1824 if ( ! $_REQUEST ) {
@@ -2046,30 +1825,29 @@
2046 1825 return $errors;
2047 1826 }
2048 1827
2049 1828 $bulkaction = FrmAppHelper::get_param( 'action', '', 'get', 'sanitize_text_field' );
2050 -
2051 - // phpcs:ignore Universal.Operators.StrictComparisons
2052 1829 if ( $bulkaction == - 1 ) {
2053 1830 $bulkaction = FrmAppHelper::get_param( 'action2', '', 'get', 'sanitize_title' );
2054 1831 }
2055 1832
2056 - if ( $bulkaction && str_starts_with( $bulkaction, 'bulk_' ) ) {
1833 + if ( ! empty( $bulkaction ) && strpos( $bulkaction, 'bulk_' ) === 0 ) {
2057 1834 FrmAppHelper::remove_get_action();
1835 +
2058 1836 $bulkaction = str_replace( 'bulk_', '', $bulkaction );
2059 1837 }
2060 1838
2061 1839 $ids = FrmAppHelper::get_param( 'item-action', '', 'get', 'sanitize_text_field' );
1840 + if ( empty( $ids ) ) {
1841 + $errors[] = __( 'No forms were specified', 'formidable' );
2062 1842
2063 - if ( ! $ids ) {
2064 - $errors[] = __( 'No forms were specified', 'formidable' );
2065 1843 return $errors;
2066 1844 }
2067 1845
2068 1846 $permission_error = FrmAppHelper::permission_nonce_error( '', '_wpnonce', 'bulk-toplevel_page_formidable' );
2069 -
2070 1847 if ( $permission_error !== false ) {
2071 1848 $errors[] = $permission_error;
1849 +
2072 1850 return $errors;
2073 1851 }
2074 1852
2075 1853 if ( ! is_array( $ids ) ) {
@@ -2093,24 +1871,9 @@
2093 1871
2094 1872 return $errors;
2095 1873 }
2096 1874
2097 - /**
2098 - * Includes html that shows a message when the device is too small to use Formidable Forms admin pages.
2099 - *
2100 - * @since 6.20
2101 - *
2102 - * @return void
2103 - */
2104 - public static function include_device_too_small_message() {
2105 - if ( ! FrmAppHelper::is_formidable_admin() ) {
2106 - return;
2107 - }
2108 -
2109 - include FrmAppHelper::plugin_path() . '/classes/views/shared/small-device-message.php';
2110 - }
2111 -
2112 - public static function route() { // phpcs:ignore Generic.Metrics.CyclomaticComplexity.MaxExceeded
1875 + public static function route() {
2113 1876 $action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
2114 1877 $vars = array();
2115 1878 FrmAppHelper::include_svg();
2116 1879
@@ -2120,28 +1883,25 @@
2120 1883 // Javascript needs to be allowed in some field settings.
2121 1884 // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
2122 1885 $json_vars = htmlspecialchars_decode( nl2br( str_replace( '&quot;', '"', wp_unslash( $_POST['frm_compact_fields'] ) ) ) );
2123 1886 $json_vars = json_decode( $json_vars, true );
1887 + if ( empty( $json_vars ) ) {
1888 + // json decoding failed so we should return an error message.
1889 + $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
1890 + if ( 'edit' === $action ) {
1891 + $action = 'update';
1892 + }
2124 1893
2125 - if ( $json_vars ) {
1894 + add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
1895 + } else {
2126 1896 $vars = FrmAppHelper::json_to_array( $json_vars );
2127 1897 $action = $vars[ $action ];
2128 1898 unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2129 1899 $_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2130 1900 $_POST = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2131 - } else {
2132 - // Json decoding failed so we should return an error message.
2133 - $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
2134 -
2135 - if ( 'edit' === $action ) {
2136 - $action = 'update';
2137 - }
2138 -
2139 - add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
2140 1901 }
2141 1902 } else {
2142 1903 $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
2143 -
2144 1904 if ( isset( $_REQUEST['delete_all'] ) ) {
2145 1905 // Override the action for this page.
2146 1906 $action = 'delete_all';
2147 1907 }
@@ -2161,38 +1921,34 @@
2161 1921 case 'update_settings':
2162 1922 return self::$action( $vars );
2163 1923 case 'lite-reports':
2164 1924 self::no_reports( $vars );
2165 - return null;
1925 + return;
2166 1926 case 'views':
2167 1927 self::no_views( $vars );
2168 - return null;
1928 + return;
2169 1929 default:
2170 1930 do_action( 'frm_form_action_' . $action );
2171 -
2172 1931 if ( apply_filters( 'frm_form_stop_action_' . $action, false ) ) {
2173 - return null;
1932 + return;
2174 1933 }
2175 1934
2176 1935 $action = FrmAppHelper::get_param( 'action', '', 'get', 'sanitize_text_field' );
2177 -
2178 - // phpcs:ignore Universal.Operators.StrictComparisons
2179 1936 if ( $action == - 1 ) {
2180 1937 $action = FrmAppHelper::get_param( 'action2', '', 'get', 'sanitize_title' );
2181 1938 }
2182 1939
2183 - if ( str_starts_with( $action, 'bulk_' ) ) {
1940 + if ( strpos( $action, 'bulk_' ) === 0 ) {
2184 1941 FrmAppHelper::remove_get_action();
2185 1942
2186 1943 self::list_form();
2187 - return null;
1944 + return;
2188 1945 }
2189 1946
2190 1947 $message = FrmAppHelper::get_param( 'message' );
2191 -
2192 1948 if ( 'form_duplicate_error' === $message ) {
2193 1949 self::display_forms_list( array(), '', array( __( 'There was a problem duplicating the form', 'formidable' ) ) );
2194 - return null;
1950 + return;
2195 1951 }
2196 1952
2197 1953 if ( 'forms_permanently_deleted' === $message ) {
2198 1954 $count = FrmAppHelper::get_param( 'forms_deleted', 0, 'get', 'absint' );
@@ -2198,14 +1954,14 @@
2198 1954 $count = FrmAppHelper::get_param( 'forms_deleted', 0, 'get', 'absint' );
2199 1955 /* translators: %1$s: Number of forms */
2200 1956 $message = sprintf( _n( '%1$s form permanently deleted.', '%1$s forms permanently deleted.', $count, 'formidable' ), $count );
2201 1957 self::display_forms_list( array(), $message, '' );
2202 - return null;
1958 + return;
2203 1959 }
2204 1960
2205 1961 self::display_forms_list();
2206 1962
2207 - return null;
1963 + return;
2208 1964 }//end switch
2209 1965 }
2210 1966
2211 1967 /**
@@ -2224,44 +1980,19 @@
2224 1980
2225 1981 // Get posted data
2226 1982 $form_id = FrmAppHelper::get_post_param( 'form_id', '', 'absint' );
2227 1983 $name = FrmAppHelper::get_post_param( 'form_name', '', 'sanitize_text_field' );
2228 - $form = FrmForm::getOne( $form_id );
2229 1984
2230 - if ( ! $form ) {
2231 - wp_send_json_error( __( 'Form not found', 'formidable' ) );
2232 - }
1985 + // Update the form name and form key.
1986 + $form_key = FrmAppHelper::get_unique_key( sanitize_title( $name ), 'frm_forms', 'form_key' );
1987 + FrmForm::update( $form_id, compact( 'name', 'form_key' ) );
2233 1988
2234 - if ( $name === $form->name ) {
2235 - // Nothing to change so exit early.
2236 - $form_key = $form->form_key;
2237 - wp_send_json_success( compact( 'form_key' ) );
2238 - }
2239 -
2240 - $to_update = array(
2241 - 'name' => $name,
2242 - );
2243 -
2244 - if ( '' === $name ) {
2245 - $form_key = $form->form_key;
2246 - } else {
2247 - // Only update form_key if name is not empty.
2248 - $form_key = FrmAppHelper::get_unique_key( sanitize_title( $name ), 'frm_forms', 'form_key' );
2249 - $to_update['form_key'] = $form_key;
2250 - }
2251 -
2252 - FrmForm::update( $form_id, $to_update );
2253 -
2254 1989 wp_send_json_success( compact( 'form_key' ) );
2255 1990 }
2256 1991
2257 - /**
2258 - * @param array $errors
2259 - *
2260 - * @return array
2261 - */
2262 1992 public static function json_error( $errors ) {
2263 1993 $errors['json'] = __( 'Abnormal HTML characters prevented your form from saving correctly', 'formidable' );
1994 +
2264 1995 return $errors;
2265 1996 }
2266 1997
2267 1998 /**
@@ -2268,10 +1999,8 @@
2268 1999 * Add education about views.
2269 2000 *
2270 2001 * @since 4.07
2271 2002 *
2272 - * @param array $values
2273 - *
2274 2003 * @return void
2275 2004 */
2276 2005 public static function no_views( $values = array() ) {
2277 2006 FrmAppHelper::include_svg();
@@ -2285,10 +2014,8 @@
2285 2014 * Add education about reports.
2286 2015 *
2287 2016 * @since 4.07
2288 2017 *
2289 - * @param array $values
2290 - *
2291 2018 * @return void
2292 2019 */
2293 2020 public static function no_reports( $values = array() ) {
2294 2021 $id = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
@@ -2314,9 +2041,10 @@
2314 2041 /**
2315 2042 * @since 4.05.02
2316 2043 */
2317 2044 private static function move_menu_to_footer() {
2318 - if ( empty( FrmAppHelper::get_settings()->admin_bar ) ) {
2045 + $settings = FrmAppHelper::get_settings();
2046 + if ( empty( $settings->admin_bar ) ) {
2319 2047 remove_action( 'wp_body_open', 'wp_admin_bar_render', 0 );
2320 2048 }
2321 2049 }
2322 2050
@@ -2321,15 +2049,13 @@
2321 2049 }
2322 2050
2323 2051 public static function admin_bar_configure() {
2324 2052 global $frm_vars;
2325 -
2326 2053 if ( empty( $frm_vars['forms_loaded'] ) ) {
2327 2054 return;
2328 2055 }
2329 2056
2330 2057 $actions = array();
2331 -
2332 2058 foreach ( $frm_vars['forms_loaded'] as $form ) {
2333 2059 if ( is_object( $form ) ) {
2334 2060 $actions[ $form->id ] = $form->name;
2335 2061 }
@@ -2335,9 +2061,9 @@
2335 2061 }
2336 2062 unset( $form );
2337 2063 }
2338 2064
2339 - if ( ! $actions ) {
2065 + if ( empty( $actions ) ) {
2340 2066 return;
2341 2067 }
2342 2068
2343 2069 self::add_menu_to_admin_bar();
@@ -2363,12 +2089,8 @@
2363 2089 }
2364 2090
2365 2091 /**
2366 2092 * @since 2.05.07
2367 - *
2368 - * @param array $actions
2369 - *
2370 - * @return void
2371 2093 */
2372 2094 private static function add_forms_to_admin_bar( $actions ) {
2373 2095 global $wp_admin_bar;
2374 2096
@@ -2374,13 +2096,14 @@
2374 2096
2375 2097 asort( $actions );
2376 2098
2377 2099 foreach ( $actions as $form_id => $name ) {
2100 +
2378 2101 $wp_admin_bar->add_node(
2379 2102 array(
2380 2103 'parent' => 'frm-forms',
2381 2104 'id' => 'edit_form_' . $form_id,
2382 - 'title' => $name ? $name : FrmFormsHelper::get_no_title_text(),
2105 + 'title' => empty( $name ) ? FrmFormsHelper::get_no_title_text() : $name,
2383 2106 'href' => FrmForm::get_edit_link( $form_id ),
2384 2107 )
2385 2108 );
2386 2109 }
@@ -2389,14 +2112,12 @@
2389 2112 /**
2390 2113 * The formidable shortcode
2391 2114 *
2392 2115 * @param array $atts The params from the shortcode.
2393 - *
2394 2116 * @return string
2395 2117 */
2396 2118 public static function get_form_shortcode( $atts ) {
2397 2119 global $frm_vars;
2398 -
2399 2120 if ( ! empty( $frm_vars['skip_shortcode'] ) ) {
2400 2121 $sc = '[formidable';
2401 2122 $sc .= FrmAppHelper::array_to_html_params( $atts );
2402 2123 return $sc . ']';
@@ -2425,9 +2146,8 @@
2425 2146 * @since 5.2.01
2426 2147 *
2427 2148 * @param false|int|string $id
2428 2149 * @param false|string $key
2429 - *
2430 2150 * @return false|stdClass
2431 2151 */
2432 2152 private static function maybe_get_form_by_id_or_key( $id, $key ) {
2433 2153 if ( ! $id ) {
@@ -2441,9 +2161,8 @@
2441 2161 * @param false|string $key
2442 2162 * @param bool|int|string $title may be 'auto', true, false, 'true', 'false', 'yes', '1', 1, '0', 0.
2443 2163 * @param bool|int|string $description may be 'auto', true, false, 'true', 'false', 'yes', '1', 1, '0', 0.
2444 2164 * @param array $atts
2445 - *
2446 2165 * @return string
2447 2166 */
2448 2167 public static function show_form( $id = '', $key = '', $title = false, $description = false, $atts = array() ) {
2449 2168 $form = self::maybe_get_form_by_id_or_key( $id, $key );
@@ -2464,13 +2183,14 @@
2464 2183
2465 2184 add_action( 'frm_load_form_hooks', 'FrmHooksController::trigger_load_form_hooks' );
2466 2185 FrmAppHelper::trigger_hook_load( 'form', $form );
2467 2186
2468 - $form = apply_filters( 'frm_pre_display_form', $form );
2187 + $form = apply_filters( 'frm_pre_display_form', $form );
2188 +
2469 2189 $frm_settings = FrmAppHelper::get_settings( array( 'current_form' => $form->id ) );
2470 2190
2471 2191 if ( self::is_viewable_draft_form( $form ) ) {
2472 - // Don't show a draft form on a page
2192 + // don't show a draft form on a page
2473 2193 $form = __( 'Please select a valid form', 'formidable' );
2474 2194 } elseif ( ! FrmForm::is_visible_to_user( $form ) ) {
2475 2195 $form = do_shortcode( $frm_settings->login_msg );
2476 2196 } else {
@@ -2490,18 +2210,16 @@
2490 2210 }
2491 2211
2492 2212 /**
2493 2213 * @param false|int|string $id
2494 - *
2495 2214 * @return false|stdClass
2496 2215 */
2497 2216 private static function maybe_get_form_to_show( $id ) {
2498 2217 $form = false;
2499 2218
2500 - if ( $id ) {
2219 + if ( ! empty( $id ) ) {
2501 2220 // Form id or key is set.
2502 2221 $form = FrmForm::getOne( $id );
2503 -
2504 2222 if ( ! $form || $form->parent_form_id || $form->status === 'trash' ) {
2505 2223 $form = false;
2506 2224 }
2507 2225 }
@@ -2508,25 +2226,12 @@
2508 2226
2509 2227 return $form;
2510 2228 }
2511 2229
2512 - /**
2513 - * @param object $form
2514 - *
2515 - * @return bool
2516 - */
2517 2230 private static function is_viewable_draft_form( $form ) {
2518 2231 return $form->status === 'draft' && current_user_can( 'frm_edit_forms' ) && ! FrmAppHelper::is_preview_page();
2519 2232 }
2520 2233
2521 - /**
2522 - * @param object $form
2523 - * @param bool $title
2524 - * @param bool $description
2525 - * @param array $atts
2526 - *
2527 - * @return string
2528 - */
2529 2234 public static function get_form( $form, $title, $description, $atts = array() ) {
2530 2235 ob_start();
2531 2236
2532 2237 do_action( 'frm_before_get_form', $atts );
@@ -2533,9 +2238,10 @@
2533 2238
2534 2239 self::get_form_contents( $form, $title, $description, $atts );
2535 2240 self::enqueue_scripts( FrmForm::get_params( $form ) );
2536 2241
2537 - $contents = ob_get_clean();
2242 + $contents = ob_get_contents();
2243 + ob_end_clean();
2538 2244
2539 2245 self::maybe_minimize_form( $atts, $contents );
2540 2246
2541 2247 return $contents;
@@ -2540,25 +2246,12 @@
2540 2246
2541 2247 return $contents;
2542 2248 }
2543 2249
2544 - /**
2545 - * @param array $params
2546 - *
2547 - * @return void
2548 - */
2549 2250 public static function enqueue_scripts( $params ) {
2550 2251 do_action( 'frm_enqueue_form_scripts', $params );
2551 2252 }
2552 2253
2553 - /**
2554 - * @param object $form
2555 - * @param bool $title
2556 - * @param bool $description
2557 - * @param array $atts
2558 - *
2559 - * @return void
2560 - */
2561 2254 public static function get_form_contents( $form, $title, $description, $atts ) {
2562 2255 $params = FrmForm::get_params( $form );
2563 2256 $errors = self::get_saved_errors( $form, $params );
2564 2257 $fields = FrmFieldsHelper::get_form_fields( $form->id, $errors );
@@ -2565,10 +2258,9 @@
2565 2258 $reset = false;
2566 2259 $pass_args = compact( 'form', 'fields', 'errors', 'title', 'description', 'reset' );
2567 2260
2568 2261 $pass_args['action'] = $params['action'];
2569 - // phpcs:ignore WordPress.Security.NonceVerification.Missing, Universal.Operators.StrictComparisons
2570 - $handle_process_here = $params['action'] === 'create' && $params['posted_form_id'] == $form->id && $_POST;
2262 + $handle_process_here = $params['action'] === 'create' && $params['posted_form_id'] == $form->id && $_POST; // phpcs:ignore WordPress.Security.NonceVerification.Missing
2571 2263
2572 2264 if ( ! $handle_process_here ) {
2573 2265 FrmFormState::set_initial_value( 'title', $title );
2574 2266 FrmFormState::set_initial_value( 'description', $description );
@@ -2573,15 +2265,16 @@
2573 2265 FrmFormState::set_initial_value( 'title', $title );
2574 2266 FrmFormState::set_initial_value( 'description', $description );
2575 2267
2576 2268 do_action( 'frm_display_form_action', $params, $fields, $form, $title, $description );
2577 -
2578 2269 if ( apply_filters( 'frm_continue_to_new', true, $form->id, $params['action'] ) ) {
2579 2270 self::show_form_after_submit( $pass_args );
2580 2271 }
2581 - } elseif ( $errors ) {
2272 + } elseif ( ! empty( $errors ) ) {
2582 2273 self::show_form_after_submit( $pass_args );
2274 +
2583 2275 } else {
2276 +
2584 2277 do_action( 'frm_validate_form_creation', $params, $fields, $form, $title, $description );
2585 2278
2586 2279 if ( apply_filters( 'frm_continue_to_create', true, $form->id ) ) {
2587 2280 $entry_id = self::just_created_entry( $form->id );
@@ -2604,19 +2297,13 @@
2604 2297 /**
2605 2298 * If the form was processed earlier (init), get the generated errors
2606 2299 *
2607 2300 * @since 2.05
2608 - *
2609 - * @param object $form
2610 - * @param array $params
2611 - *
2612 - * @return array
2613 2301 */
2614 2302 private static function get_saved_errors( $form, $params ) {
2615 2303 global $frm_vars;
2616 2304
2617 - // phpcs:ignore WordPress.Security.NonceVerification.Missing, Universal.Operators.StrictComparisons
2618 - if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
2305 + if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2619 2306 $errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2620 2307 } else {
2621 2308 $errors = array();
2622 2309 }
@@ -2633,16 +2320,13 @@
2633 2320 }
2634 2321
2635 2322 /**
2636 2323 * @since 2.2.7
2637 - *
2638 - * @param int|string $form_id
2639 - *
2640 - * @return int
2641 2324 */
2642 2325 public static function just_created_entry( $form_id ) {
2643 2326 global $frm_vars;
2644 - return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2327 +
2328 + return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2645 2329 }
2646 2330
2647 2331 /**
2648 2332 * Gets confirmation method.
@@ -2655,9 +2339,8 @@
2655 2339 *
2656 2340 * @type object $form Form object.
2657 2341 * @type int $entry_id Entry ID.
2658 2342 * }
2659 - *
2660 2343 * @return array|string
2661 2344 */
2662 2345 private static function get_confirmation_method( $atts ) {
2663 2346 $action = FrmOnSubmitHelper::current_event( $atts );
@@ -2665,9 +2348,8 @@
2665 2348 $method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
2666 2349
2667 2350 if ( ! empty( $atts['entry_id'] ) ) {
2668 2351 $met_actions = self::get_met_on_submit_actions( $atts, $action );
2669 -
2670 2352 if ( $met_actions ) {
2671 2353 $method = $met_actions;
2672 2354 }
2673 2355 }
@@ -2674,21 +2356,14 @@
2674 2356
2675 2357 $method = apply_filters( 'frm_success_filter', $method, $atts['form'], $action );
2676 2358
2677 2359 if ( $method !== 'message' && ( ! $atts['entry_id'] || ! is_numeric( $atts['entry_id'] ) ) ) {
2678 - return 'message';
2360 + $method = 'message';
2679 2361 }
2680 2362
2681 2363 return $method;
2682 2364 }
2683 2365
2684 - /**
2685 - * @param object $form
2686 - * @param array $params
2687 - * @param array $args
2688 - *
2689 - * @return void
2690 - */
2691 2366 public static function maybe_trigger_redirect( $form, $params, $args ) {
2692 2367 if ( ! isset( $params['id'] ) ) {
2693 2368 global $frm_vars;
2694 2369 $params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
@@ -2715,12 +2390,14 @@
2715 2390 * @param array $params See {@see FrmFormsController::maybe_trigger_redirect()}.
2716 2391 * @param array $args See {@see FrmFormsController::maybe_trigger_redirect()}.
2717 2392 */
2718 2393 public static function maybe_trigger_redirect_with_action( $conf_method, $form, $params, $args ) {
2719 - if ( is_array( $conf_method ) && 1 === count( $conf_method ) && 'redirect' === FrmOnSubmitHelper::get_action_type( $conf_method[0] ) && empty( $conf_method[0]->post_content['redirect_delay'] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2720 - $event = FrmOnSubmitHelper::current_event( $params );
2721 - FrmOnSubmitHelper::populate_on_submit_data( $form->options, $conf_method[0], $event );
2722 - $conf_method = 'redirect';
2394 + if ( is_array( $conf_method ) && 1 === count( $conf_method ) ) {
2395 + if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $conf_method[0] ) && empty( $conf_method[0]->post_content['redirect_delay'] ) ) {
2396 + $event = FrmOnSubmitHelper::current_event( $params );
2397 + FrmOnSubmitHelper::populate_on_submit_data( $form->options, $conf_method[0], $event );
2398 + $conf_method = 'redirect';
2399 + }
2723 2400 }
2724 2401
2725 2402 if ( 'redirect' === $conf_method ) {
2726 2403 self::trigger_redirect( $form, $params, $args );
@@ -2726,15 +2403,8 @@
2726 2403 self::trigger_redirect( $form, $params, $args );
2727 2404 }
2728 2405 }
2729 2406
2730 - /**
2731 - * @param object $form
2732 - * @param array $params
2733 - * @param array $args
2734 - *
2735 - * @return void
2736 - */
2737 2407 public static function trigger_redirect( $form, $params, $args ) {
2738 2408 $success_args = array(
2739 2409 'action' => $params['action'],
2740 2410 'conf_method' => 'redirect',
@@ -2793,9 +2463,8 @@
2793 2463 * @since 6.0
2794 2464 *
2795 2465 * @param array $args See {@see FrmFormsController::run_success_action()}.
2796 2466 * @param string $event Form event. Default is `create`.
2797 - *
2798 2467 * @return array Array of actions that meet the conditional logics.
2799 2468 */
2800 2469 public static function get_met_on_submit_actions( $args, $event = 'create' ) {
2801 2470 if ( ! FrmOnSubmitHelper::form_has_migrated( $args['form'] ) ) {
@@ -2822,11 +2491,13 @@
2822 2491 }
2823 2492
2824 2493 $action_type = FrmOnSubmitHelper::get_action_type( $action );
2825 2494
2826 - if ( 'redirect' === $action_type && $has_redirect ) {
2827 - // Do not process because we run the first redirect action only.
2828 - continue;
2495 + if ( 'redirect' === $action_type ) {
2496 + if ( $has_redirect ) {
2497 + // Do not process because we run the first redirect action only.
2498 + continue;
2499 + }
2829 2500 }
2830 2501
2831 2502 if ( ! self::is_valid_on_submit_action( $action, $args, $event ) ) {
2832 2503 continue;
@@ -2851,10 +2522,10 @@
2851 2522 * @param array $args See {@see FrmFormsController::run_success_action()}. `$args['event']` is also added.
2852 2523 */
2853 2524 $met_actions = apply_filters( 'frm_get_met_on_submit_actions', $met_actions, $args );
2854 2525
2855 - if ( ! $met_actions ) {
2856 - return array( FrmOnSubmitHelper::get_fallback_action( $event ) );
2526 + if ( empty( $met_actions ) ) {
2527 + $met_actions = array( FrmOnSubmitHelper::get_fallback_action( $event ) );
2857 2528 }
2858 2529
2859 2530 return $met_actions;
2860 2531 }
@@ -2866,9 +2537,8 @@
2866 2537 *
2867 2538 * @param object $action Form action object.
2868 2539 * @param array $args See {@see FrmFormsController::run_success_action()}.
2869 2540 * @param string $event Form event. Default is `create`.
2870 - *
2871 2541 * @return bool
2872 2542 */
2873 2543 private static function is_valid_on_submit_action( $action, $args, $event = 'create' ) {
2874 2544 $action_type = FrmOnSubmitHelper::get_action_type( $action );
@@ -2890,9 +2560,8 @@
2890 2560 return false;
2891 2561 }
2892 2562
2893 2563 $page = get_post( $action->post_content['success_page_id'] );
2894 -
2895 2564 if ( ! $page || 'trash' === $page->post_status ) {
2896 2565 return false;
2897 2566 }
2898 2567 }
@@ -2914,9 +2583,8 @@
2914 2583 'entry_id' => $args['entry_id'],
2915 2584 'action' => FrmOnSubmitHelper::current_event( $args ),
2916 2585 )
2917 2586 );
2918 -
2919 2587 if ( ! is_array( $args['conf_method'] ) ) {
2920 2588 self::run_success_action( $args );
2921 2589 return;
2922 2590 }
@@ -2943,9 +2611,8 @@
2943 2611 * @param array $args See {@see FrmFormsController::run_success_action()}.
2944 2612 */
2945 2613 public static function run_multi_on_submit_actions( $args ) {
2946 2614 $redirect_action = null;
2947 -
2948 2615 foreach ( $args['conf_method'] as $action ) {
2949 2616 if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $action ) ) {
2950 2617 // We catch the redirect action to run it last.
2951 2618 $redirect_action = $action;
@@ -2956,15 +2623,13 @@
2956 2623
2957 2624 unset( $action );
2958 2625 }
2959 2626
2960 - if ( ! $redirect_action ) {
2961 - return;
2627 + if ( $redirect_action ) {
2628 + // Show script to delay the redirection.
2629 + $args['force_delay_redirect'] = true;
2630 + self::run_single_on_submit_action( $args, $redirect_action );
2962 2631 }
2963 -
2964 - // Show script to delay the redirection.
2965 - $args['force_delay_redirect'] = true;
2966 - self::run_single_on_submit_action( $args, $redirect_action );
2967 2632 }
2968 2633
2969 2634 /**
2970 2635 * Runs single On Submit action.
@@ -2985,9 +2650,8 @@
2985 2650 * @since 6.0
2986 2651 *
2987 2652 * @param array $args See {@see FrmFormsController::run_success_action()}.
2988 2653 * @param object $action On Submit action object.
2989 - *
2990 2654 * @return array
2991 2655 */
2992 2656 private static function get_run_success_action_args( $args, $action ) {
2993 2657 $new_args = $args;
@@ -2993,9 +2657,10 @@
2993 2657 $new_args = $args;
2994 2658
2995 2659 FrmOnSubmitHelper::populate_on_submit_data( $new_args['form']->options, $action, $args['action'] );
2996 2660
2997 - $opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2661 + $opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2662 +
2998 2663 $new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2999 2664
3000 2665 /**
3001 2666 * Filters the run success action args.
@@ -3010,18 +2675,12 @@
3010 2675 }
3011 2676
3012 2677 /**
3013 2678 * @since 3.0
3014 - *
3015 - * @param array $args
3016 - *
3017 - * @return void
3018 2679 */
3019 2680 private static function load_page_after_submit( $args ) {
3020 2681 global $post;
3021 2682 $opt = $args['success_opt'];
3022 -
3023 - // phpcs:ignore Universal.Operators.StrictComparisons
3024 2683 if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
3025 2684 $page = get_post( $args['form']->options[ $opt . '_page_id' ] );
3026 2685 $old_post = $post;
3027 2686 $post = $page;
@@ -3045,9 +2704,8 @@
3045 2704 }
3046 2705
3047 2706 /**
3048 2707 * @since 3.0
3049 - *
3050 2708 * @param array $args See {@see FrmFormsController::run_success_action()}.
3051 2709 */
3052 2710 private static function redirect_after_submit( $args ) {
3053 2711 add_filter( 'frm_use_wpautop', '__return_false' );
@@ -3061,10 +2719,11 @@
3061 2719 FrmEntriesController::delete_entry_before_redirect( $success_url, $args['form'], $args );
3062 2720
3063 2721 add_filter( 'frm_redirect_url', 'FrmEntriesController::prepare_redirect_url' );
3064 2722 $success_url = apply_filters( 'frm_redirect_url', $success_url, $args['form'], $args );
3065 - $doing_ajax = FrmAppHelper::doing_ajax();
3066 2723
2724 + $doing_ajax = FrmAppHelper::doing_ajax();
2725 +
3067 2726 if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) {
3068 2727 // Is AJAX submit and there is just one Redirect action runs.
3069 2728 echo json_encode( self::get_ajax_redirect_response_data( $args + compact( 'success_url' ) ) );
3070 2729 wp_die();
@@ -3113,9 +2772,8 @@
3113 2772 *
3114 2773 * @since 6.3.1
3115 2774 *
3116 2775 * @param array $args See {@see FrmFormsController::run_success_action()}.
3117 - *
3118 2776 * @return array
3119 2777 */
3120 2778 private static function get_ajax_redirect_response_data( $args ) {
3121 2779 $response_data = array(
@@ -3138,9 +2796,8 @@
3138 2796 $args['message'] = FrmOnSubmitHelper::get_default_new_tab_msg();
3139 2797
3140 2798 $args['form']->options['success_msg'] = $args['message'];
3141 2799 $args['form']->options['edit_msg'] = $args['message'];
3142 -
3143 2800 if ( ! isset( $args['fields'] ) ) {
3144 2801 $args['fields'] = FrmField::get_all_for_form( $args['form']->id );
3145 2802 }
3146 2803
@@ -3192,15 +2849,13 @@
3192 2849 add_filter( 'frm_use_wpautop', '__return_true' );
3193 2850
3194 2851 echo FrmAppHelper::maybe_kses( $redirect_msg ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
3195 2852 echo '<script>';
3196 -
3197 2853 if ( empty( $args['doing_ajax'] ) ) {
3198 2854 // Not AJAX submit, delay JS until window.load.
3199 2855 echo 'window.onload=function(){';
3200 2856 }
3201 2857 echo 'setTimeout(function(){' . $redirect_js . '}, ' . intval( $delay_time ) . ');'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
3202 -
3203 2858 if ( empty( $args['doing_ajax'] ) ) {
3204 2859 echo '};';
3205 2860 }
3206 2861 echo '</script>';
@@ -3213,16 +2868,13 @@
3213 2868 * @param string $success_msg
3214 2869 * @param array $args
3215 2870 */
3216 2871 private static function get_redirect_message( $success_url, $success_msg, $args ) {
3217 - $success_msg = apply_filters( 'frm_content', $success_msg, $args['form'], $args['entry_id'] );
3218 - $success_msg = do_shortcode( FrmAppHelper::use_wpautop( $success_msg ) );
3219 -
3220 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
3221 - $redirect_msg = '<div class="' . esc_attr( FrmFormsHelper::get_form_style_class( $args['form'] ) ) . '"><div class="frm-redirect-msg" role="status">' . $success_msg . '<br/>' . // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2872 + $success_msg = apply_filters( 'frm_content', $success_msg, $args['form'], $args['entry_id'] );
2873 + $success_msg = do_shortcode( FrmAppHelper::use_wpautop( $success_msg ) );
2874 + $redirect_msg = '<div class="' . esc_attr( FrmFormsHelper::get_form_style_class( $args['form'] ) ) . '"><div class="frm-redirect-msg" role="status">' . $success_msg . '<br/>' .
3222 2875 self::get_redirect_fallback_message( $success_url, $args ) .
3223 2876 '</div></div>';
3224 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
3225 2877
3226 2878 $redirect_args = array(
3227 2879 'entry_id' => $args['entry_id'],
3228 2880 'form_id' => $args['form']->id,
@@ -3238,14 +2890,12 @@
3238 2890 * @since 6.3.1
3239 2891 *
3240 2892 * @param string $success_url Redirect URL.
3241 2893 * @param array $args Contains `form` object.
3242 - *
3243 2894 * @return string
3244 2895 */
3245 2896 private static function get_redirect_fallback_message( $success_url, $args ) {
3246 2897 $target = '';
3247 -
3248 2898 if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
3249 2899 $target = ' target="_blank"';
3250 2900 }
3251 2901
@@ -3260,12 +2910,8 @@
3260 2910 /**
3261 2911 * Prepare to show the success message and empty form after submit
3262 2912 *
3263 2913 * @since 2.05
3264 - *
3265 - * @param array $atts
3266 - *
3267 - * @return void
3268 2914 */
3269 2915 public static function show_message_after_save( $atts ) {
3270 2916 $atts['message'] = self::prepare_submit_message( $atts['form'], $atts['entry_id'], $atts );
3271 2917
@@ -3271,9 +2917,8 @@
3271 2917
3272 2918 if ( ! isset( $atts['form']->options['show_form'] ) || $atts['form']->options['show_form'] ) {
3273 2919 if ( isset( $atts['action'] ) && 'update' === $atts['action'] && is_callable( array( 'FrmProEntriesController', 'show_front_end_form_with_entry' ) ) ) {
3274 2920 $entry = FrmEntry::getOne( $atts['entry_id'] );
3275 -
3276 2921 if ( $entry ) {
3277 2922 // This is copied from the Pro plugin.
3278 2923 $atts['conf_message'] = FrmProEntriesController::confirmation( 'message', $atts['form'], $atts['form']->options, $entry->id, $atts );
3279 2924 $atts['show_form'] = FrmProEntriesController::is_form_displayed_after_edit( $atts['form'] );
@@ -3290,12 +2935,8 @@
3290 2935 /**
3291 2936 * Show an empty form
3292 2937 *
3293 2938 * @since 2.05
3294 - *
3295 - * @param array $args
3296 - *
3297 - * @return void
3298 2939 */
3299 2940 private static function show_form_after_submit( $args ) {
3300 2941 self::fill_atts_for_form_display( $args );
3301 2942
@@ -3314,11 +2955,12 @@
3314 2955 }
3315 2956 unset( $args );
3316 2957
3317 2958 $include_form_tag = apply_filters( 'frm_include_form_tag', true, $form );
3318 - $frm_settings = FrmAppHelper::get_settings();
3319 - $submit = $form->options['submit_value'] ?? $frm_settings->submit_value;
3320 2959
2960 + $frm_settings = FrmAppHelper::get_settings();
2961 + $submit = isset( $form->options['submit_value'] ) ? $form->options['submit_value'] : $frm_settings->submit_value;
2962 +
3321 2963 global $frm_vars;
3322 2964 self::maybe_load_css( $form, $values['custom_style'], $frm_vars['load_css'] );
3323 2965
3324 2966 $message_placement = self::message_placement( $form, $message );
@@ -3326,36 +2968,25 @@
3326 2968 include FrmAppHelper::plugin_path() . '/classes/views/frm-entries/new.php';
3327 2969 }
3328 2970
3329 2971 /**
3330 - * Gets message placement.
3331 - *
3332 2972 * @since 4.05.02
3333 - * @since 6.26 This method changed from `private` to `public`.
3334 - *
3335 - * @param object $form Form object.
3336 - * @param string $message The message.
3337 - *
3338 - * @return string Accepts 'before', 'after', or 'submit'.
2973 + * @return string - 'before', 'after', or 'submit'
3339 2974 */
3340 - public static function message_placement( $form, $message ) {
2975 + private static function message_placement( $form, $message ) {
3341 2976 $place = 'before';
3342 2977
3343 2978 if ( $message && isset( $form->options['form_class'] ) ) {
3344 - if ( str_contains( $form->options['form_class'], 'frm_below_success' ) ) {
2979 + if ( strpos( $form->options['form_class'], 'frm_below_success' ) !== false ) {
3345 2980 $place = 'after';
3346 - } elseif ( str_contains( $form->options['form_class'], 'frm_inline_success' ) ) {
2981 + } elseif ( strpos( $form->options['form_class'], 'frm_inline_success' ) !== false ) {
3347 2982 $place = 'submit';
3348 2983 }
3349 2984 }
3350 2985
3351 2986 /**
3352 - * Filter the message placement.
3353 - *
3354 2987 * @since 4.05.02
3355 - *
3356 - * @param string $place Accepts 'before', 'after', or 'submit'.
3357 - * @param array $args Args.
2988 + * @return string - 'before' or 'after'
3358 2989 */
3359 2990 return apply_filters( 'frm_message_placement', $place, compact( 'form', 'message' ) );
3360 2991 }
3361 2992
@@ -3362,12 +2993,8 @@
3362 2993 /**
3363 2994 * Get all the values needed on the new.php entry page
3364 2995 *
3365 2996 * @since 2.05
3366 - *
3367 - * @param array $args
3368 - *
3369 - * @return void
3370 2997 */
3371 2998 private static function fill_atts_for_form_display( &$args ) {
3372 2999 if ( ! isset( $args['title'] ) && isset( $args['show_title'] ) ) {
3373 3000 $args['title'] = $args['show_title'];
@@ -3392,12 +3019,8 @@
3392 3019 /**
3393 3020 * Show the success message without the form
3394 3021 *
3395 3022 * @since 2.05
3396 - *
3397 - * @param array $atts
3398 - *
3399 - * @return void
3400 3023 */
3401 3024 private static function show_lone_success_message( $atts ) {
3402 3025 global $frm_vars;
3403 3026 $values = FrmEntriesHelper::setup_new_vars( $atts['fields'], $atts['form'], true );
@@ -3403,12 +3026,13 @@
3403 3026 $values = FrmEntriesHelper::setup_new_vars( $atts['fields'], $atts['form'], true );
3404 3027 self::maybe_load_css( $atts['form'], $values['custom_style'], $frm_vars['load_css'] );
3405 3028
3406 3029 $include_extra_container = 'frm_forms' . FrmFormsHelper::get_form_style_class( $values );
3407 - $errors = array();
3408 - $form = $atts['form'];
3409 - $message = $atts['message'];
3410 3030
3031 + $errors = array();
3032 + $form = $atts['form'];
3033 + $message = $atts['message'];
3034 +
3411 3035 include FrmAppHelper::plugin_path() . '/classes/views/frm-entries/errors.php';
3412 3036 }
3413 3037
3414 3038 /**
@@ -3416,20 +3040,19 @@
3416 3040 *
3417 3041 * @since 2.05
3418 3042 * @since 6.0.x Added the third parameter.
3419 3043 *
3420 - * @param object $form Form object.
3421 - * @param int|string $entry_id Entry ID.
3422 - * @param array $args See {@see FrmFormsController::run_success_action()}.
3423 - *
3044 + * @param object $form Form object.
3045 + * @param int $entry_id Entry ID.
3046 + * @param array $args See {@see FrmFormsController::run_success_action()}.
3424 3047 * @return string
3425 3048 */
3426 3049 private static function prepare_submit_message( $form, $entry_id, $args = array() ) {
3427 3050 $frm_settings = FrmAppHelper::get_settings( array( 'current_form' => $form->id ) );
3428 - $opt = $args['success_opt'] ?? 'success';
3051 + $opt = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
3429 3052
3430 3053 if ( $entry_id && is_numeric( $entry_id ) ) {
3431 - $message = $form->options[ $opt . '_msg' ] ?? $frm_settings->success_msg;
3054 + $message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
3432 3055 $class = 'frm_message';
3433 3056 } else {
3434 3057 $message = $frm_settings->failed_msg;
3435 3058 $class = FrmFormsHelper::form_error_class();
@@ -3446,9 +3069,9 @@
3446 3069 public static function front_head() {
3447 3070 $version = FrmAppHelper::plugin_version();
3448 3071 $suffix = FrmAppHelper::js_suffix();
3449 3072
3450 - if ( $suffix && self::has_combo_js_file() ) {
3073 + if ( ! empty( $suffix ) && self::has_combo_js_file() ) {
3451 3074 wp_register_script( 'formidable', FrmAppHelper::plugin_url() . '/js/frm.min.js', array( 'jquery' ), $version, true );
3452 3075 } else {
3453 3076 wp_register_script( 'formidable', FrmAppHelper::plugin_url() . "/js/formidable{$suffix}.js", array( 'jquery' ), $version, true );
3454 3077 }
@@ -3455,9 +3078,9 @@
3455 3078
3456 3079 add_filter( 'script_loader_tag', 'FrmFormsController::defer_script_loading', 10, 2 );
3457 3080
3458 3081 if ( FrmAppHelper::is_admin() ) {
3459 - // Don't load this in back-end
3082 + // don't load this in back-end
3460 3083 return;
3461 3084 }
3462 3085
3463 3086 FrmAppHelper::localize_script( 'front' );
@@ -3470,15 +3093,8 @@
3470 3093 public static function has_combo_js_file() {
3471 3094 return is_readable( FrmAppHelper::plugin_path() . '/js/frm.min.js' );
3472 3095 }
3473 3096
3474 - /**
3475 - * @param object $form
3476 - * @param int|string $this_load
3477 - * @param bool $global_load
3478 - *
3479 - * @return void
3480 - */
3481 3097 public static function maybe_load_css( $form, $this_load, $global_load ) {
3482 3098 $load_css = FrmForm::is_form_loaded( $form, $this_load, $global_load );
3483 3099
3484 3100 if ( ! $load_css ) {
@@ -3508,9 +3124,8 @@
3508 3124 return;
3509 3125 }
3510 3126
3511 3127 global $wp_styles;
3512 -
3513 3128 if ( is_array( $wp_styles->queue ) && in_array( 'formidable', $wp_styles->queue, true ) ) {
3514 3129 wp_print_styles( 'formidable' );
3515 3130 }
3516 3131 }
@@ -3525,57 +3140,32 @@
3525 3140 private static function should_load_late() {
3526 3141 return ! function_exists( 'aioseo' );
3527 3142 }
3528 3143
3529 - /**
3530 - * @param string $tag
3531 - * @param string $handle
3532 - *
3533 - * @return string
3534 - */
3535 3144 public static function defer_script_loading( $tag, $handle ) {
3536 - if ( 'captcha-api' === $handle && ! str_contains( $tag, 'defer' ) ) {
3537 - return str_replace( ' src', ' defer="defer" async="async" src', $tag );
3145 + if ( 'captcha-api' == $handle && ! strpos( $tag, 'defer' ) ) {
3146 + $tag = str_replace( ' src', ' defer="defer" async="async" src', $tag );
3538 3147 }
3539 3148
3540 3149 return $tag;
3541 3150 }
3542 3151
3543 - /**
3544 - * @param string $location
3545 - *
3546 - * @return void
3547 - */
3548 3152 public static function footer_js( $location = 'footer' ) {
3549 3153 global $frm_vars;
3550 3154
3551 3155 FrmStylesController::enqueue_css();
3552 3156
3553 - if ( FrmAppHelper::is_admin() || $location === 'header' || empty( $frm_vars['forms_loaded'] ) ) {
3554 - return;
3157 + if ( ! FrmAppHelper::is_admin() && $location !== 'header' && ! empty( $frm_vars['forms_loaded'] ) ) {
3158 + // load formidable js
3159 + wp_enqueue_script( 'formidable' );
3555 3160 }
3556 -
3557 - // Load formidable js
3558 - wp_enqueue_script( 'formidable' );
3559 -
3560 - FrmHoneypot::maybe_print_honeypot_js();
3561 -
3562 - if ( ! method_exists( 'FrmProFormsHelper', 'load_currency_js' ) ) {
3563 - // Load currency JS if Pro is not installed.
3564 - FrmFormsHelper::load_currency_js();
3565 - }
3566 3161 }
3567 3162
3568 3163 /**
3569 3164 * @since 2.0.8
3570 - *
3571 - * @param array $atts
3572 - * @param string $content
3573 - *
3574 - * @return void
3575 3165 */
3576 3166 private static function maybe_minimize_form( $atts, &$content ) {
3577 - // Check if minimizing is turned on
3167 + // check if minimizing is turned on
3578 3168 if ( self::is_minification_on( $atts ) ) {
3579 3169 $content = str_replace( array( "\r\n", "\r", "\n", "\t", ' ' ), '', $content );
3580 3170 }
3581 3171 }
@@ -3581,11 +3171,8 @@
3581 3171 }
3582 3172
3583 3173 /**
3584 3174 * @since 2.0.8
3585 - *
3586 - * @param array $atts
3587 - *
3588 3175 * @return bool
3589 3176 */
3590 3177 private static function is_minification_on( $atts ) {
3591 3178 return ! empty( $atts['minimize'] );
@@ -3597,13 +3184,11 @@
3597 3184 * @return void
3598 3185 */
3599 3186 public static function landing_page_preview_option() {
3600 3187 $dir = apply_filters( 'frm_landing_page_preview_option', false );
3601 -
3602 3188 if ( false === $dir || ! file_exists( $dir . 'landing-page-preview-option.php' ) ) {
3603 3189 $dir = self::get_form_views_path();
3604 3190 }
3605 -
3606 3191 include $dir . 'landing-page-preview-option.php';
3607 3192 }
3608 3193
3609 3194 /**
@@ -3629,15 +3214,13 @@
3629 3214
3630 3215 check_ajax_referer( 'frm_ajax', 'nonce' );
3631 3216
3632 3217 $type = FrmAppHelper::get_post_param( 'type', '', 'sanitize_text_field' );
3633 -
3634 3218 if ( ! $type || ! in_array( $type, array( 'form', 'view' ), true ) ) {
3635 3219 die( 0 );
3636 3220 }
3637 3221
3638 3222 $object_id = FrmAppHelper::get_post_param( 'object_id', '', 'absint' );
3639 -
3640 3223 if ( ! $object_id ) {
3641 3224 die( 0 );
3642 3225 }
3643 3226
@@ -3649,15 +3232,13 @@
3649 3232 $postarr['post_content'] = apply_filters( 'frm_create_page_with_' . $type . '_shortcode_content', '', $object_id );
3650 3233 }
3651 3234
3652 3235 $name = FrmAppHelper::get_post_param( 'name', '', 'sanitize_text_field' );
3653 -
3654 3236 if ( $name ) {
3655 3237 $postarr['post_title'] = $name;
3656 3238 }
3657 3239
3658 3240 $success = wp_insert_post( $postarr );
3659 -
3660 3241 if ( ! is_numeric( $success ) || ! $success ) {
3661 3242 die( 0 );
3662 3243 }
3663 3244
@@ -3671,9 +3252,8 @@
3671 3252 /**
3672 3253 * @since 5.3
3673 3254 *
3674 3255 * @param int $form_id
3675 - *
3676 3256 * @return string
3677 3257 */
3678 3258 private static function get_page_shortcode_content_for_form( $form_id ) {
3679 3259 $shortcode = '[formidable id="' . $form_id . '"]';
@@ -3693,9 +3273,9 @@
3693 3273 }
3694 3274
3695 3275 check_ajax_referer( 'frm_ajax', 'nonce' );
3696 3276
3697 - $html = FrmAppHelper::clip(
3277 + $html = FrmAppHelper::clip(
3698 3278 function () {
3699 3279 FrmAppHelper::maybe_autocomplete_pages_options(
3700 3280 array(
3701 3281 'field_name' => 'frm_page_dropdown',
@@ -3704,55 +3284,34 @@
3704 3284 )
3705 3285 );
3706 3286 }
3707 3287 );
3288 + $post_type_object = get_post_type_object( 'page' );
3708 3289 wp_send_json(
3709 3290 array(
3710 3291 'html' => $html,
3711 - 'edit_page_url' => admin_url( sprintf( get_post_type_object( 'page' )->_edit_link . '&action=edit', 0 ) ),
3292 + 'edit_page_url' => admin_url( sprintf( $post_type_object->_edit_link . '&action=edit', 0 ) ),
3712 3293 )
3713 3294 );
3714 3295 }
3715 3296
3716 3297 /**
3717 - * Prints necessary templates for the forms list page.
3718 - *
3719 - * @since 6.32
3720 - *
3721 - * @return void
3298 + * @deprecated 4.0
3722 3299 */
3723 - public static function print_forms_list_templates() {
3724 - if ( ! FrmAppHelper::on_form_listing_page() ) {
3725 - return;
3726 - }
3727 -
3728 - $screen = get_current_screen();
3729 -
3730 - if ( ! $screen ) {
3731 - return;
3732 - }
3733 -
3734 - $columns = get_column_headers( $screen );
3735 - $hidden = get_hidden_columns( $screen );
3736 - $skip_cols = array( 'cb', 'name', 'settings' );
3737 - $per_page = get_user_option( 'formidable_page_formidable_per_page' );
3738 - $show_screen_options = $screen->show_screen_options();
3739 -
3740 - if ( $per_page < 1 ) {
3741 - $per_page = 20;
3742 - }
3743 -
3744 - include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/forms-list-settings.php';
3300 + public static function create( $values = array() ) {
3301 + _deprecated_function( __METHOD__, '4.0', 'FrmFormsController::update' );
3302 + self::update( $values );
3745 3303 }
3746 3304
3747 3305 /**
3748 - * @deprecated 4.0
3306 + * Education for premium features.
3749 3307 *
3750 - * @param array $values
3308 + * @since 4.05
3309 + * @deprecated 6.16.3
3751 3310 *
3752 3311 * @return void
3753 3312 */
3754 - public static function create( $values = array() ) {
3755 - _deprecated_function( __METHOD__, '4.0', 'FrmFormsController::update' );
3756 - self::update( $values );
3313 + public static function add_form_style_tab_options() {
3314 + _deprecated_function( __METHOD__, '6.16.3' );
3315 + include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/add_form_style_options.php';
3757 3316 }
3758 3317 }