← All changes | classes/controllers/FrmFormsController.php +253 -582 6.29 → 6.20 View file →

		@@ -26,13 +26,11 @@
26	26	private static $formidable_tinymce_button;
27	27
28	28	public static function menu() {
29	29	$menu_label = __( 'Forms', 'formidable' );
30		-
31	30	if ( ! FrmAppHelper::pro_is_installed() ) {
32	31	$menu_label .= ' (Lite)';
33	32	}
34		-
35	33	add_submenu_page( 'formidable', 'Formidable | ' . $menu_label, $menu_label, 'frm_view_forms', 'formidable', 'FrmFormsController::route' );
36	34
37	35	self::maybe_load_listing_hooks();
38	36	}
		@@ -66,12 +64,12 @@
66	64	*/
67	65	public static function logic_tip() {
68	66	$images_url = FrmAppHelper::plugin_url() . '/images/';
69	67	$data_message = __( 'Only show the fields you need and create branching forms. Upgrade to get conditional logic and question branching.', 'formidable' );
70		- $data_message .= ' <img src="' . esc_url( $images_url ) . '/survey-logic.png" srcset="' . esc_url( $images_url ) . 'survey-logic@2x.png 2x" alt="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '"/>'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
71		- echo '<a href="javascript:void(0)" class="frm_noallow frm_show_upgrade frm_add_logic_link frm-collapsed frm-flex-justify" data-upgrade="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '" data-message="' . esc_attr( $data_message ) . '" data-medium="builder" data-content="logic">'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
	68	+ $data_message .= ' <img src="' . esc_url( $images_url ) . '/survey-logic.png" srcset="' . esc_url( $images_url ) . 'survey-logic@2x.png 2x" alt="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '"/>';
	69	+ echo '<a href="javascript:void(0)" class="frm_noallow frm_show_upgrade frm_add_logic_link frm-collapsed frm-flex-justify" data-upgrade="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '" data-message="' . esc_attr( $data_message ) . '" data-medium="builder" data-content="logic">';
72	70	esc_html_e( 'Conditional Logic', 'formidable' );
73		- FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown8_icon', array( 'aria-hidden' => 'true' ) );
	71	+ FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
74	72	echo '</a>';
75	73	}
76	74
77	75	/**
		@@ -78,15 +76,12 @@
78	76	* By default, Divi processes form shortcodes on the edit post page.
79	77	* Now that won't do.
80	78	*
81	79	* @since 3.01
82		- *
83		- * @param array $shortcodes List of shortcodes to process.
84		- *
85		- * @return array
86	80	*/
87	81	public static function prevent_divi_conflict( $shortcodes ) {
88	82	$shortcodes[] = 'formidable';
	83	+
89	84	return $shortcodes;
90	85	}
91	86
92	87	/**
		@@ -97,14 +92,12 @@
97	92
98	93	$message = '';
99	94	$params = FrmForm::list_page_params();
100	95	$errors = self::process_bulk_form_actions( array() );
101		-
102	96	if ( isset( $errors['message'] ) ) {
103	97	$message = $errors['message'];
104	98	unset( $errors['message'] );
105	99	}
106		-
107	100	$errors = apply_filters( 'frm_admin_list_form_action', $errors );
108	101
109	102	self::display_forms_list( $params, $message, $errors );
110	103	}
		@@ -114,14 +107,12 @@
114	107	*
115	108	* @since 2.02.11
116	109	*
117	110	* @param int|object $form
118		- *
119	111	* @return void
120	112	*/
121	113	private static function create_default_email_action( $form ) {
122	114	FrmForm::maybe_get_form( $form );
123		-
124	115	if ( ! is_object( $form ) ) {
125	116	return;
126	117	}
127	118
		@@ -126,17 +117,15 @@
126	117	}
127	118
128	119	$create_email = apply_filters( 'frm_create_default_email_action', true, $form );
129	120
130		- if ( ! $create_email ) {
131		- return;
	121	+ if ( $create_email ) {
	122	+ /**
	123	+ * @var FrmFormAction
	124	+ */
	125	+ $action_control = FrmFormActionsController::get_form_actions( 'email' );
	126	+ $action_control->create( $form->id );
132	127	}
133		-
134		- /**
135		- * @var FrmFormAction
136		- */
137		- $action_control = FrmFormActionsController::get_form_actions( 'email' );
138		- $action_control->create( $form->id );
139	128	}
140	129
141	130	/**
142	131	* Create the default On submit action
		@@ -143,14 +132,12 @@
143	132	*
144	133	* @since 6.0.0
145	134	*
146	135	* @param int|object $form Form object or ID.
147		- *
148	136	* @return void
149	137	*/
150	138	private static function create_default_on_submit_action( $form ) {
151	139	FrmForm::maybe_get_form( $form );
152		-
153	140	if ( ! is_object( $form ) ) {
154	141	return;
155	142	}
156	143
		@@ -163,17 +150,15 @@
163	150	* @param object $form Form object.
164	151	*/
165	152	$create = apply_filters( 'frm_create_default_on_submit_action', true, $form );
166	153
167		- if ( ! $create ) {
168		- return;
	154	+ if ( $create ) {
	155	+ /**
	156	+ * @var FrmFormAction
	157	+ */
	158	+ $action_control = FrmFormActionsController::get_form_actions( FrmOnSubmitAction::$slug );
	159	+ $action_control->create( $form->id );
169	160	}
170		-
171		- /**
172		- * @var FrmFormAction
173		- */
174		- $action_control = FrmFormActionsController::get_form_actions( FrmOnSubmitAction::$slug );
175		- $action_control->create( $form->id );
176	161	}
177	162
178	163	/**
179	164	* Creates submit button field.
		@@ -180,14 +165,12 @@
180	165	*
181	166	* @since 6.9
182	167	*
183	168	* @param int|object $form Form ID or object.
184		- *
185	169	* @return void
186	170	*/
187	171	private static function create_submit_button_field( $form ) {
188	172	FrmForm::maybe_get_form( $form );
189		-
190	173	if ( ! is_object( $form ) ) {
191	174	return;
192	175	}
193	176
		@@ -210,10 +193,8 @@
210	193	);
211	194	}
212	195
213	196	/**
214		- * @param array|false $values
215		- *
216	197	* @return void
217	198	*/
218	199	public static function edit( $values = false ) {
219	200	FrmAppHelper::permission_check( 'frm_edit_forms' );
		@@ -225,9 +206,8 @@
225	206
226	207	/**
227	208	* @param mixed $id
228	209	* @param string $message
229		- *
230	210	* @return void
231	211	*/
232	212	public static function settings( $id = false, $message = '' ) {
233	213	FrmAppHelper::permission_check( 'frm_edit_forms' );
		@@ -255,9 +235,10 @@
255	235	FrmAppController::show_error_modal( $error_args );
256	236	return;
257	237	}
258	238
259		- $id = FrmAppHelper::get_param( 'id', '', 'get', 'absint' );
	239	+ $id = FrmAppHelper::get_param( 'id', '', 'get', 'absint' );
	240	+
260	241	$errors = FrmForm::validate( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
261	242	$warnings = FrmFormsHelper::check_for_warnings( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
262	243
263	244	if ( count( $errors ) > 0 ) {
		@@ -271,9 +252,8 @@
271	252
272	253	FrmForm::update( $id, $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
273	254
274	255	$antispam_is_on = ! empty( $_POST['options']['antispam'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
275		-
276	256	if ( $antispam_is_on !== $antispam_was_on ) {
277	257	FrmAntiSpam::clear_caches();
278	258	}
279	259
		@@ -283,9 +263,8 @@
283	263	}
284	264
285	265	/**
286	266	* @param int $form_id
287		- *
288	267	* @return bool
289	268	*/
290	269	private static function antispam_was_on( $form_id ) {
291	270	$form = FrmForm::getOne( $form_id );
		@@ -292,14 +271,12 @@
292	271	return ! empty( $form->options['antispam'] );
293	272	}
294	273
295	274	/**
296		- * @param array $values
297		- *
298	275	* @return void
299	276	*/
300	277	public static function update( $values = array() ) {
301		- if ( ! $values ) {
	278	+ if ( empty( $values ) ) {
302	279	$values = $_POST; // phpcs:ignore WordPress.Security.NonceVerification.Missing
303	280	}
304	281
305	282	// Set radio button and checkbox meta equal to "other" value.
		@@ -308,9 +285,8 @@
308	285	}
309	286
310	287	$errors = FrmForm::validate( $values );
311	288	$permission_error = FrmAppHelper::permission_nonce_error( 'frm_edit_forms', 'frm_save_form', 'frm_save_form_nonce' );
312		-
313	289	if ( $permission_error !== false ) {
314	290	$errors['form'] = $permission_error;
315	291	}
316	292
		@@ -329,9 +305,9 @@
329	305	if ( self::is_too_long( $values ) ) {
330	306	$message .= '<br/> ' . sprintf(
331	307	/* translators: %1$s: Start link HTML, %2$s: end link HTML */
332	308	__( 'However, your form is very long and may be %1$sreaching server limits%2$s.', 'formidable' ),
333		- '<a href="' . esc_url( self::get_form_too_long_docs_url() ) . '" target="_blank" rel="noopener">',
	309	+ '<a href="https://formidableforms.com/knowledgebase/i-have-a-long-form-why-did-the-options-at-the-end-of-the-form-stop-saving/?utm_source=WordPress&utm_medium=builder&utm_campaign=liteplugin" target="_blank" rel="noopener">',
334	310	'</a>'
335	311	);
336	312	}
337	313
		@@ -342,32 +318,17 @@
342	318	self::get_edit_vars( $id, array(), $message );
343	319	}
344	320
345	321	/**
346		- * @since 6.25.1
347		- *
348		- * @return string
349		- */
350		- private static function get_form_too_long_docs_url() {
351		- $utm = array(
352		- 'campaign' => 'builder',
353		- 'content' => 'form-too-long',
354		- );
355		- return FrmAppHelper::admin_upgrade_link( $utm, 'knowledgebase/i-have-a-long-form-why-did-the-options-at-the-end-of-the-form-stop-saving/' );
356		- }
357		-
358		- /**
359	322	* Remove the draft flag from any new fields from this current session.
360	323	*
361	324	* @since 6.8
362	325	*
363	326	* @param int $form_id
364		- *
365	327	* @return void
366	328	*/
367	329	private static function maybe_remove_draft_option_from_fields( $form_id ) {
368	330	$draft_field_ids_csv = FrmAppHelper::get_post_param( 'draft_fields', '', 'sanitize_text_field' );
369		-
370	331	if ( ! $draft_field_ids_csv ) {
371	332	// If the draft_fields input is empty there are no new fields in the session.
372	333	return;
373	334	}
		@@ -372,9 +333,8 @@
372	333	return;
373	334	}
374	335
375	336	$draft_field_ids = array_filter( explode( ',', $draft_field_ids_csv ), 'is_numeric' );
376		-
377	337	if ( ! $draft_field_ids ) {
378	338	// Exit early if the draft fields input is invalid. It should be a CSV of integer values.
379	339	return;
380	340	}
		@@ -379,9 +339,8 @@
379	339	return;
380	340	}
381	341
382	342	$draft_field_rows = FrmFieldsHelper::get_draft_field_results( $form_id, $draft_field_ids );
383		-
384	343	foreach ( $draft_field_rows as $row ) {
385	344	$row->field_options['draft'] = 0;
386	345	FrmField::update( $row->id, array( 'field_options' => $row->field_options ) );
387	346	}
		@@ -393,10 +352,8 @@
393	352	* were likely not saved either.
394	353	*
395	354	* @since 3.06.01
396	355	*
397		- * @param array $values
398		- *
399	356	* @return bool
400	357	*/
401	358	private static function is_too_long( $values ) {
402	359	return empty( $values['frm_end'] );
		@@ -432,9 +389,8 @@
432	389	* @return string|null
433	390	*/
434	391	public static function page_preview() {
435	392	$params = FrmForm::list_page_params();
436		-
437	393	if ( ! $params['form'] || is_numeric( $params['form'] ) ) {
438	394	return null;
439	395	}
440	396
		@@ -440,9 +396,8 @@
440	396
441	397	self::maybe_block_preview( $params['form'] );
442	398
443	399	$form = FrmForm::getOne( $params['form'] );
444		-
445	400	if ( ! $form ) {
446	401	return null;
447	402	}
448	403
		@@ -455,9 +410,8 @@
455	410	* @return void
456	411	*/
457	412	public static function show_page_preview() {
458	413	$preview = self::page_preview();
459		-
460	414	if ( is_null( $preview ) ) {
461	415	wp_die(
462	416	'<h1>' . esc_html__( 'Form key is invalid', 'formidable' ) . '</h1>',
463	417	'<p>' . esc_html__( 'Form key is invalid', 'formidable' ) . '</p>',
		@@ -480,16 +434,9 @@
480	434
481	435	// print_emoji_styles is deprecated.
482	436	remove_action( 'wp_print_styles', 'print_emoji_styles' );
483	437
484		- if ( FrmTestModeController::should_add_test_mode_container() ) {
485		- do_action( 'frm_test_mode_init' );
486		- add_action( 'wp_enqueue_scripts', 'FrmTestModeController::register_and_enqueue_required_scripts' );
487		- add_filter( 'frm_filter_final_form', 'FrmTestModeController::maybe_add_test_mode_container', 99 );
488		- }
489		-
490	438	$include_theme = FrmAppHelper::get_param( 'theme', '', 'get', 'absint' );
491		-
492	439	if ( $include_theme ) {
493	440	self::set_preview_query();
494	441	self::load_theme_preview();
495	442	} else {
		@@ -512,9 +459,8 @@
512	459	'post_type' => 'page',
513	460	);
514	461
515	462	$page_for_posts = get_option( 'page_for_posts' );
516		-
517	463	if ( is_numeric( $page_for_posts ) ) {
518	464	// Avoid querying for the "Posts Page" or "Blog Page" so we don't display 10 forms.
519	465	$page_query['post__not_in'] = array( $page_for_posts );
520	466	}
		@@ -519,15 +465,13 @@
519	465	$page_query['post__not_in'] = array( $page_for_posts );
520	466	}
521	467
522	468	$random_page = get_posts( $page_query );
523		-
524	469	if ( ! $random_page ) {
525	470	return;
526	471	}
527	472
528	473	$random_page = reset( $random_page );
529		-
530	474	if ( ! is_a( $random_page, 'WP_Post' ) ) {
531	475	// The return type can also be int.
532	476	return;
533	477	}
		@@ -549,9 +493,8 @@
549	493	*
550	494	* @since 5.5.2
551	495	*
552	496	* @param WP_Post $page The page object.
553		- *
554	497	* @return void
555	498	*/
556	499	private static function set_post_global( $page ) {
557	500	global $post;
		@@ -570,16 +513,14 @@
570	513	add_action( 'loop_no_results', 'FrmFormsController::show_page_preview' );
571	514	add_filter( 'is_active_sidebar', '__return_false' );
572	515	FrmStylesController::enqueue_css( 'enqueue', true );
573	516
574		- if ( false !== get_template_part( 'page' ) ) {
575		- return;
	517	+ if ( false === get_template_part( 'page' ) ) {
	518	+ if ( function_exists( 'wp_is_block_theme' ) && wp_is_block_theme() ) {
	519	+ add_filter( 'body_class', 'FrmFormsController::preview_block_theme_body_classnames' );
	520	+ }
	521	+ self::fallback_when_page_template_part_is_not_supported_by_theme();
576	522	}
577		-
578		- if ( function_exists( 'wp_is_block_theme' ) && wp_is_block_theme() ) {
579		- add_filter( 'body_class', 'FrmFormsController::preview_block_theme_body_classnames' );
580		- }
581		- self::fallback_when_page_template_part_is_not_supported_by_theme();
582	523	}
583	524
584	525	/**
585	526	* Add padding to the body for block themes.
		@@ -586,9 +527,8 @@
586	527	*
587	528	* @since 6.5.2
588	529	*
589	530	* @param array $classes The body classes list.
590		- *
591	531	* @return array
592	532	*/
593	533	public static function preview_block_theme_body_classnames( $classes ) {
594	534	$classes[] = 'has-global-padding';
		@@ -601,27 +541,21 @@
601	541	*
602	542	* @return void
603	543	*/
604	544	private static function fallback_when_page_template_part_is_not_supported_by_theme() {
605		- if ( ! have_posts() ) {
606		- return;
607		- }
	545	+ if ( have_posts() ) {
	546	+ the_post();
	547	+ self::get_template( 'header' );
608	548
609		- the_post();
610		- self::get_template( 'header' );
	549	+ // add some generic class names to the container to add some natural padding to the content.
	550	+ // .entry-content catches the WordPress TwentyTwenty theme.
	551	+ // .container catches Customizr content.
	552	+ echo '<div class="container entry-content">';
	553	+ the_content();
	554	+ echo '</div>';
611	555
612		- // Add some generic class names to the container to add some natural padding to the content.
613		- // .entry-content catches the WordPress TwentyTwenty theme.
614		- // .container catches Customizr content.
615		- echo '<div class="container entry-content">';
616		- the_content();
617		- echo '</div>';
618		-
619		- // Prevent extra unexpected forms in the footer.
620		- // For some reason this happens in the Twenty Twenty Five theme.
621		- add_filter( 'frm_filter_final_form', '__return_empty_string' );
622		-
623		- self::get_template( 'footer' );
	556	+ self::get_template( 'footer' );
	557	+ }
624	558	}
625	559
626	560	/**
627	561	* Calls core function to get a template part if it doesn't cause deprecation warnings. Otherwise skips the deprecation function call
		@@ -627,11 +561,9 @@
627	561	* Calls core function to get a template part if it doesn't cause deprecation warnings. Otherwise skips the deprecation function call
628	562	* and renders required html fragments calling required functions.
629	563	*
630	564	* @since 6.7.1
631		- *
632	565	* @param string $template
633		- *
634	566	* @return void
635	567	*/
636	568	private static function get_template( $template ) {
637	569	if ( self::should_try_getting_template( $template ) ) {
		@@ -652,11 +584,9 @@
652	584	/**
653	585	* Returns true if calling a template function doesn't trigger deprecation warnings.
654	586	*
655	587	* @since 6.7.1
656		- *
657	588	* @param string $template
658		- *
659	589	* @return bool
660	590	*/
661	591	private static function should_try_getting_template( $template ) {
662	592	$stylesheet_path = get_stylesheet_directory();
		@@ -670,15 +600,15 @@
670	600	/**
671	601	* Set the page title for the theme preview page
672	602	*
673	603	* @since 3.0
674		- *
675		- * @param string $title
676		- *
677		- * @return string
678	604	*/
679	605	public static function preview_page_title( $title ) {
680		- return in_the_loop() ? self::preview_title( $title ) : $title;
	606	+ if ( in_the_loop() ) {
	607	+ $title = self::preview_title( $title );
	608	+ }
	609	+
	610	+ return $title;
681	611	}
682	612
683	613	/**
684	614	* Set the page title for the theme preview page.
		@@ -685,9 +615,8 @@
685	615	*
686	616	* @since 3.0
687	617	*
688	618	* @param string $title
689		- *
690	619	* @return string
691	620	*/
692	621	public static function preview_title( $title ) {
693	622	return __( 'Form Preview', 'formidable' );
		@@ -698,9 +627,8 @@
698	627	*
699	628	* @since 3.0
700	629	*
701	630	* @param string $content
702		- *
703	631	* @return string
704	632	*/
705	633	public static function preview_content( $content ) {
706	634	if ( in_the_loop() ) {
		@@ -716,10 +644,8 @@
716	644	* @since 3.0
717	645	*/
718	646	private static function load_direct_preview() {
719	647	$key = FrmAppHelper::simple_get( 'form', 'sanitize_title' );
720		-
721		- // phpcs:ignore Universal.Operators.StrictComparisons
722	648	if ( $key == '' ) {
723	649	$key = FrmAppHelper::get_post_param( 'form', '', 'sanitize_title' );
724	650	}
725	651
		@@ -734,9 +660,8 @@
734	660
735	661	self::maybe_block_preview( $key );
736	662
737	663	$form = FrmForm::getAll( array( 'form_key' => $key ), '', 1 );
738		-
739	664	if ( ! $form ) {
740	665	$error = __( 'Form does not exist', 'formidable' );
741	666	wp_die(
742	667	'<h1>' . esc_html( $error ) . '</h1>',
		@@ -760,22 +685,19 @@
760	685	*
761	686	* @since 6.20
762	687	*
763	688	* @param string $form_key Form key.
764		- *
765	689	* @return void
766	690	*/
767	691	public static function maybe_block_preview( $form_key ) {
768		- if ( ! FrmFormsHelper::should_block_preview( $form_key ) ) {
769		- return;
	692	+ if ( FrmFormsHelper::should_block_preview( $form_key ) ) {
	693	+ $error = __( 'You do not have permission to view this form', 'formidable' );
	694	+ wp_die(
	695	+ '<h1>' . esc_html( $error ) . '</h1>',
	696	+ '<p>' . esc_html( $error ) . '</p>',
	697	+ 403
	698	+ );
770	699	}
771		-
772		- $error = __( 'You do not have permission to view this form', 'formidable' );
773		- wp_die(
774		- '<h1>' . esc_html( $error ) . '</h1>',
775		- '<p>' . esc_html( $error ) . '</p>',
776		- 403
777		- );
778	700	}
779	701
780	702	/**
781	703	* Some themes have a null $src value.
		@@ -790,13 +712,15 @@
790	712	add_filter(
791	713	'script_loader_src',
792	714	/**
793	715	* @param string|null $src
794		- *
795	716	* @return string
796	717	*/
797	718	function ( $src ) {
798		- return is_null( $src ) ? '' : $src;
	719	+ if ( is_null( $src ) ) {
	720	+ $src = '';
	721	+ }
	722	+ return $src;
799	723	}
800	724	);
801	725	}
802	726
		@@ -805,9 +729,8 @@
805	729	}
806	730
807	731	/**
808	732	* @param array $ids
809		- *
810	733	* @return string
811	734	*/
812	735	public static function bulk_untrash( $ids ) {
813	736	FrmAppHelper::permission_check( 'frm_edit_forms' );
		@@ -819,9 +742,11 @@
819	742	return '';
820	743	}
821	744
822	745	/* translators: %1$s: Number of forms */
823		- return sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
	746	+ $message = sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
	747	+
	748	+ return $message;
824	749	}
825	750
826	751	/**
827	752	* @since 3.06
		@@ -866,9 +791,8 @@
866	791	// Check nonce url.
867	792	check_admin_referer( $status . '_form_' . $params['id'] );
868	793
869	794	$count = 0;
870		-
871	795	if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
872	796	++$count;
873	797	}
874	798
		@@ -882,9 +806,9 @@
882	806	/* translators: %1$s: Number of forms */
883	807	$available_status['untrash']['message'] = sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
884	808
885	809	/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
886		- $available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
	810	+ $available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
887	811
888	812	$message = $available_status[ $status ]['message'];
889	813
890	814	self::display_forms_list( $params, $message );
		@@ -891,9 +815,8 @@
891	815	}
892	816
893	817	/**
894	818	* @param array $ids
895		- *
896	819	* @return string
897	820	*/
898	821	public static function bulk_trash( $ids ) {
899	822	FrmAppHelper::permission_check( 'frm_delete_forms' );
		@@ -898,9 +821,8 @@
898	821	public static function bulk_trash( $ids ) {
899	822	FrmAppHelper::permission_check( 'frm_delete_forms' );
900	823
901	824	$count = 0;
902		-
903	825	foreach ( $ids as $id ) {
904	826	if ( FrmForm::trash( $id ) ) {
905	827	++$count;
906	828	}
		@@ -915,16 +837,17 @@
915	837	'param' => 'form_type',
916	838	'type' => 'request',
917	839	)
918	840	);
919		-
920		- return sprintf(
	841	+ $message = sprintf(
921	842	/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
922	843	_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
923	844	$count,
924		- '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=list&action=bulk_untrash&form_type=' . $current_page . '&item-action=' . implode( ',', $ids ), 'bulk-toplevel_page_formidable' ) ) . '">', // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
	845	+ '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=list&action=bulk_untrash&form_type=' . $current_page . '&item-action=' . implode( ',', $ids ), 'bulk-toplevel_page_formidable' ) ) . '">',
925	846	'</a>'
926	847	);
	848	+
	849	+ return $message;
927	850	}
928	851
929	852	public static function destroy() {
930	853	FrmAppHelper::permission_check( 'frm_delete_forms' );
		@@ -934,9 +857,8 @@
934	857	// Check nonce url.
935	858	check_admin_referer( 'destroy_form_' . $params['id'] );
936	859
937	860	$count = 0;
938		-
939	861	if ( FrmForm::destroy( $params['id'] ) ) {
940	862	++$count;
941	863	}
942	864
		@@ -947,9 +869,8 @@
947	869	}
948	870
949	871	/**
950	872	* @param array $ids
951		- *
952	873	* @return string
953	874	*/
954	875	public static function bulk_destroy( $ids ) {
955	876	FrmAppHelper::permission_check( 'frm_delete_forms' );
		@@ -954,12 +875,10 @@
954	875	public static function bulk_destroy( $ids ) {
955	876	FrmAppHelper::permission_check( 'frm_delete_forms' );
956	877
957	878	$count = 0;
958		-
959	879	foreach ( $ids as $id ) {
960	880	$d = FrmForm::destroy( $id );
961		-
962	881	if ( $d ) {
963	882	++$count;
964	883	}
965	884	}
		@@ -977,18 +896,19 @@
977	896	*/
978	897	public static function delete_all() {
979	898	// Check nonce url.
980	899	$permission_error = FrmAppHelper::permission_nonce_error( 'frm_delete_forms', '_wpnonce', 'bulk-toplevel_page_formidable' );
981		-
982	900	if ( $permission_error !== false ) {
983	901	self::display_forms_list( array(), '', array( $permission_error ) );
	902	+
984	903	return;
985	904	}
986	905
987	906	$count = FrmForm::scheduled_delete( time() );
988	907	$url = remove_query_arg( array( 'delete_all' ) );
989		- $url .= '&message=forms_permanently_deleted&forms_deleted=' . $count;
990	908
	909	+ $url .= '&message=forms_permanently_deleted&forms_deleted=' . $count;
	910	+
991	911	wp_safe_redirect( $url );
992	912	die();
993	913	}
994	914
		@@ -1062,23 +982,21 @@
1062	982	*
1063	983	* @return void
1064	984	*/
1065	985	public static function insert_form_button() {
1066		- if ( ! current_user_can( 'frm_view_forms' ) ) {
1067		- return;
	986	+ if ( current_user_can( 'frm_view_forms' ) ) {
	987	+ // Store the result in memory and re-use it when this function is called multiple times.
	988	+ // This helps speed up the form builder when there are a lot of HTML fields, where this
	989	+ // button is inserted once per HTML field.
	990	+ // In a form with 66 HTML fields, this saves 0.5 seconds on page load time, tested locally.
	991	+ if ( ! isset( self::$formidable_tinymce_button ) ) {
	992	+ FrmAppHelper::load_admin_wide_js();
	993	+ $menu_name = FrmAppHelper::get_menu_name();
	994	+ $icon = apply_filters( 'frm_media_icon', FrmAppHelper::svg_logo() );
	995	+ self::$formidable_tinymce_button = '<a href="#TB_inline?width=50&height=50&inlineId=frm_insert_form" class="thickbox button add_media frm_insert_form" title="' . esc_attr__( 'Add forms and content', 'formidable' ) . '">' . FrmAppHelper::kses( $icon, 'all' ) . ' ' . esc_html( $menu_name ) . '</a>';
	996	+ }
	997	+ echo self::$formidable_tinymce_button; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
1068	998	}
1069		-
1070		- // Store the result in memory and re-use it when this function is called multiple times.
1071		- // This helps speed up the form builder when there are a lot of HTML fields, where this
1072		- // Button is inserted once per HTML field.
1073		- // In a form with 66 HTML fields, this saves 0.5 seconds on page load time, tested locally.
1074		- if ( ! isset( self::$formidable_tinymce_button ) ) {
1075		- FrmAppHelper::load_admin_wide_js();
1076		- $menu_name = FrmAppHelper::get_menu_name();
1077		- $icon = apply_filters( 'frm_media_icon', FrmAppHelper::svg_logo() );
1078		- self::$formidable_tinymce_button = '<a href="#TB_inline?width=50&height=50&inlineId=frm_insert_form" class="thickbox button add_media frm_insert_form" title="' . esc_attr__( 'Add forms and content', 'formidable' ) . '">' . FrmAppHelper::kses( $icon, 'all' ) . ' ' . esc_html( $menu_name ) . '</a>'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1079		- }
1080		- echo self::$formidable_tinymce_button; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
1081	999	}
1082	1000
1083	1001	/**
1084	1002	* @return void
		@@ -1099,21 +1017,17 @@
1099	1017	$shortcodes = apply_filters( 'frm_popup_shortcodes', $shortcodes );
1100	1018
1101	1019	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/insert_form_popup.php';
1102	1020
1103		- if ( ! FrmAppHelper::is_form_builder_page() || class_exists( '_WP_Editors', false ) ) {
1104		- return;
	1021	+ if ( FrmAppHelper::is_form_builder_page() && ! class_exists( '_WP_Editors', false ) ) {
	1022	+ // initialize a wysiwyg so we have usable settings defined in tinyMCEPreInit.mceInit
	1023	+ require ABSPATH . WPINC . '/class-wp-editor.php';
	1024	+ ?>
	1025	+ <div class="frm_hidden">
	1026	+ <?php wp_editor( '', 'frm_description_placeholder', array() ); ?>
	1027	+ </div>
	1028	+ <?php
1105	1029	}
1106		-
1107		- // Initialize a wysiwyg so we have usable settings defined in tinyMCEPreInit.mceInit
1108		- require ABSPATH . WPINC . '/class-wp-editor.php';
1109		- // phpcs:disable Generic.WhiteSpace.ScopeIndent
1110		- ?>
1111		- <div class="frm_hidden">
1112		- <?php wp_editor( '', 'frm_description_placeholder', array() ); ?>
1113		- </div>
1114		- <?php
1115		- // phpcs:enable Generic.WhiteSpace.ScopeIndent
1116	1030	}
1117	1031
1118	1032	/**
1119	1033	* Check the page being loaded, determine if this is a page that should include the form popup.
		@@ -1125,9 +1039,8 @@
1125	1039	private static function should_insert_form_popup() {
1126	1040	if ( FrmAppHelper::is_form_builder_page() ) {
1127	1041	return true;
1128	1042	}
1129		-
1130	1043	$page = basename( FrmAppHelper::get_server_value( 'PHP_SELF' ) );
1131	1044	return in_array( $page, array( 'post.php', 'page.php', 'page-new.php', 'post-new.php' ), true );
1132	1045	}
1133	1046
		@@ -1135,10 +1048,9 @@
1135	1048	FrmAppHelper::permission_check( 'frm_view_forms' );
1136	1049	check_ajax_referer( 'frm_ajax', 'nonce' );
1137	1050
1138	1051	$shortcode = FrmAppHelper::get_post_param( 'shortcode', '', 'sanitize_text_field' );
1139		-
1140		- if ( ! $shortcode ) {
	1052	+ if ( empty( $shortcode ) ) {
1141	1053	wp_die();
1142	1054	}
1143	1055
1144	1056	echo '<div id="sc-opts-' . esc_attr( $shortcode ) . '" class="frm_shortcode_option">';
		@@ -1163,13 +1075,12 @@
1163	1075	'label' => __( 'Minimize form HTML', 'formidable' ),
1164	1076	),
1165	1077	);
1166	1078	}
1167		-
1168	1079	$opts = apply_filters( 'frm_sc_popup_opts', $opts, $shortcode );
1169	1080
1170	1081	if ( isset( $opts['form_id'] ) && is_string( $opts['form_id'] ) ) {
1171		- // Allow other shortcodes to use the required form id option
	1082	+ // allow other shortcodes to use the required form id option
1172	1083	$form_id = $opts['form_id'];
1173	1084	unset( $opts['form_id'] );
1174	1085	}
1175	1086
		@@ -1185,9 +1096,8 @@
1185	1096	*
1186	1097	* @param array $params
1187	1098	* @param string $message
1188	1099	* @param array $errors
1189		- *
1190	1100	* @return void
1191	1101	*/
1192	1102	public static function display_forms_list( $params = array(), $message = '', $errors = array() ) {
1193	1103	FrmAppHelper::permission_check( 'frm_view_forms' );
		@@ -1204,21 +1114,21 @@
1204	1114	* @param string $table_class Class name for List Helper.
1205	1115	*/
1206	1116	$table_class = apply_filters( 'frm_forms_list_class', 'FrmFormsListHelper' );
1207	1117	$wp_list_table = new $table_class( compact( 'params' ) );
1208		- $pagenum = $wp_list_table->get_pagenum();
1209	1118
	1119	+ $pagenum = $wp_list_table->get_pagenum();
	1120	+
1210	1121	$wp_list_table->prepare_items();
1211	1122
1212	1123	$total_pages = $wp_list_table->get_pagination_arg( 'total_pages' );
1213		-
1214	1124	if ( $pagenum > $total_pages && $total_pages > 0 ) {
1215		- wp_safe_redirect( esc_url_raw( add_query_arg( 'paged', $total_pages ) ) );
	1125	+ wp_redirect( esc_url_raw( add_query_arg( 'paged', $total_pages ) ) );
1216	1126	die();
1217	1127	}
1218	1128
1219		- $error = FrmInbox::check_for_error();
1220		-
	1129	+ $inbox = new FrmInbox();
	1130	+ $error = $inbox->check_for_error();
1221	1131	if ( $error ) {
1222	1132	$show_messages = array( $error['subject'] . '. ' . $error['message'] );
1223	1133	}
1224	1134
		@@ -1226,22 +1136,17 @@
1226	1136	}
1227	1137
1228	1138	/**
1229	1139	* @param array<string,string> $columns
1230		- *
1231	1140	* @return array<string,string>
1232	1141	*/
1233	1142	public static function get_columns( $columns ) {
1234		- $columns['cb'] = '<input type="checkbox" />';
1235		- $columns['name'] = esc_html__( 'Form Title', 'formidable' );
1236		- $columns['entries'] = esc_html__( 'Entries', 'formidable' );
1237		- $columns['id'] = 'ID';
1238		- $columns['form_key'] = esc_html__( 'Key', 'formidable' );
1239		-
1240		- if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) ) {
1241		- $columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
1242		- }
1243		-
	1143	+ $columns['cb'] = '<input type="checkbox" />';
	1144	+ $columns['name'] = esc_html__( 'Form Title', 'formidable' );
	1145	+ $columns['entries'] = esc_html__( 'Entries', 'formidable' );
	1146	+ $columns['id'] = 'ID';
	1147	+ $columns['form_key'] = esc_html__( 'Key', 'formidable' );
	1148	+ $columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
1244	1149	$columns['created_at'] = esc_html__( 'Date', 'formidable' );
1245	1150
1246	1151	add_screen_option(
1247	1152	'per_page',
		@@ -1269,9 +1174,8 @@
1269	1174	}
1270	1175
1271	1176	/**
1272	1177	* @param mixed $hidden_columns
1273		- *
1274	1178	* @return array
1275	1179	*/
1276	1180	public static function hidden_columns( $hidden_columns ) {
1277	1181	if ( ! is_array( $hidden_columns ) ) {
		@@ -1292,18 +1196,11 @@
1292	1196
1293	1197	return $hidden_columns;
1294	1198	}
1295	1199
1296		- /**
1297		- * @param mixed $save
1298		- * @param string $option
1299		- * @param int|string $value
1300		- *
1301		- * @return mixed
1302		- */
1303	1200	public static function save_per_page( $save, $option, $value ) {
1304	1201	if ( $option === 'formidable_page_formidable_per_page' ) {
1305		- return (int) $value;
	1202	+ $save = (int) $value;
1306	1203	}
1307	1204
1308	1205	return $save;
1309	1206	}
		@@ -1312,9 +1209,8 @@
1312	1209	* @param int|string $id
1313	1210	* @param array $errors
1314	1211	* @param string $message
1315	1212	* @param bool $create_link
1316		- *
1317	1213	* @return void
1318	1214	*/
1319	1215	private static function get_edit_vars( $id, $errors = array(), $message = '', $create_link = false ) {
1320	1216	global $frm_vars;
		@@ -1329,9 +1225,8 @@
1329	1225	'page' => 'formidable',
1330	1226	)
1331	1227	),
1332	1228	);
1333		-
1334	1229	if ( ! $form ) {
1335	1230	FrmAppController::show_error_modal( $error_args );
1336	1231	return;
1337	1232	}
		@@ -1353,14 +1248,15 @@
1353	1248	}
1354	1249
1355	1250	if ( $form->parent_form_id ) {
1356	1251	/* translators: %1$s: Start link HTML, %2$s: End link HTML */
1357		- wp_die( sprintf( esc_html__( 'You are trying to edit a child form. Please edit from %1$shere%2$s', 'formidable' ), '<a href="' . esc_url( FrmForm::get_edit_link( $form->parent_form_id ) ) . '">', '</a>' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
	1252	+ wp_die( sprintf( esc_html__( 'You are trying to edit a child form. Please edit from %1$shere%2$s', 'formidable' ), '<a href="' . esc_url( FrmForm::get_edit_link( $form->parent_form_id ) ) . '">', '</a>' ) );
1358	1253	}
1359	1254
1360	1255	$frm_field_selection = FrmField::field_selection();
1361		- $fields = FrmField::get_all_for_form( $form->id );
1362	1256
	1257	+ $fields = FrmField::get_all_for_form( $form->id );
	1258	+
1363	1259	// Automatically add end section fields if they don't exist (2.0 migration).
1364	1260	$reset_fields = false;
1365	1261	FrmFormsHelper::auto_add_end_section_fields( $form, $fields, $reset_fields );
1366	1262	FrmSubmitHelper::maybe_create_submit_field( $form, $fields, $reset_fields );
		@@ -1384,10 +1280,9 @@
1384	1280	*/
1385	1281	$values['fields'] = apply_filters( 'frm_fields_in_form_builder', $fields, compact( 'form' ) );
1386	1282
1387	1283	$edit_message = __( 'Form was successfully updated.', 'formidable' );
1388		-
1389		- if ( $form->is_template && $message === $edit_message ) {
	1284	+ if ( $form->is_template && $message == $edit_message ) {
1390	1285	$message = __( 'Template was successfully updated.', 'formidable' );
1391	1286	}
1392	1287
1393	1288	self::maybe_update_form_builder_message( $message );
		@@ -1402,12 +1297,11 @@
1402	1297	}
1403	1298
1404	1299	/**
1405	1300	* @param array $fields
1406		- *
1407	1301	* @return array
1408	1302	*/
1409		- public static function update_form_builder_fields( $fields ) {
	1303	+ public static function update_form_builder_fields( $fields, $form ) {
1410	1304	foreach ( $fields as $field ) {
1411	1305	$field->do_not_include_icons = true;
1412	1306	}
1413	1307	return $fields;
		@@ -1412,13 +1306,8 @@
1412	1306	}
1413	1307	return $fields;
1414	1308	}
1415	1309
1416		- /**
1417		- * @param string $message
1418		- *
1419		- * @return void
1420		- */
1421	1310	public static function maybe_update_form_builder_message( &$message ) {
1422	1311	if ( 'form_duplicated' === FrmAppHelper::simple_get( 'message' ) ) {
1423	1312	$message = __( 'Form was Successfully Copied', 'formidable' );
1424	1313	}
		@@ -1427,9 +1316,8 @@
1427	1316	/**
1428	1317	* @param int|string $id
1429	1318	* @param array $errors
1430	1319	* @param array|string $args
1431		- *
1432	1320	* @return void
1433	1321	*/
1434	1322	public static function get_settings_vars( $id, $errors = array(), $args = array() ) {
1435	1323	FrmAppHelper::permission_check( 'frm_edit_forms' );
		@@ -1451,12 +1339,13 @@
1451	1339	);
1452	1340	$args = array_merge( $defaults, $args );
1453	1341	$message = $args['message'];
1454	1342	$warnings = $args['warnings'];
1455		- $form = FrmForm::getOne( $id );
1456		- $fields = FrmField::get_all_for_form( $id );
1457		- $values = FrmAppHelper::setup_edit_vars( $form, 'forms', $fields, true );
1458	1343
	1344	+ $form = FrmForm::getOne( $id );
	1345	+ $fields = FrmField::get_all_for_form( $id );
	1346	+ $values = FrmAppHelper::setup_edit_vars( $form, 'forms', $fields, true );
	1347	+
1459	1348	/**
1460	1349	* Allows changing fields in the form settings.
1461	1350	*
1462	1351	* @since 5.0.04
		@@ -1496,12 +1385,8 @@
1496	1385	}
1497	1386
1498	1387	/**
1499	1388	* @since 4.0
1500		- *
1501		- * @param array $atts
1502		- *
1503		- * @return void
1504	1389	*/
1505	1390	public static function form_publish_button( $atts ) {
1506	1391	$values = $atts['values'];
1507	1392	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/_publish_box.php';
		@@ -1512,9 +1397,8 @@
1512	1397	*
1513	1398	* @since 4.0
1514	1399	*
1515	1400	* @param array $values
1516		- *
1517	1401	* @return array
1518	1402	*/
1519	1403	private static function get_settings_tabs( $values ) {
1520	1404	$sections = array(
		@@ -1520,20 +1404,20 @@
1520	1404	$sections = array(
1521	1405	'advanced' => array(
1522	1406	'name' => __( 'General', 'formidable' ),
1523	1407	'title' => __( 'General Form Settings', 'formidable' ),
1524		- 'function' => array( self::class, 'advanced_settings' ),
1525		- 'icon' => 'frmfont frm_settings_icon',
	1408	+ 'function' => array( __CLASS__, 'advanced_settings' ),
	1409	+ 'icon' => 'frm_icon_font frm_settings_icon',
1526	1410	),
1527	1411	'email' => array(
1528	1412	'name' => __( 'Actions & Notifications', 'formidable' ),
1529	1413	'function' => array( 'FrmFormActionsController', 'email_settings' ),
1530	1414	'id' => 'frm_notification_settings',
1531		- 'icon' => 'frmfont frm_mail_bulk_icon',
	1415	+ 'icon' => 'frm_icon_font frm_mail_bulk_icon',
1532	1416	),
1533	1417	'permissions' => array(
1534	1418	'name' => __( 'Form Permissions', 'formidable' ),
1535		- 'icon' => 'frmfont frm_lock_closed_icon',
	1419	+ 'icon' => 'frm_icon_font frm_lock_closed_icon',
1536	1420	'html_class' => 'frm_show_upgrade_tab frm_noallow',
1537	1421	'data' => array(
1538	1422	'medium' => 'permissions',
1539	1423	'upgrade' => __( 'Form Permissions', 'formidable' ),
		@@ -1538,37 +1422,35 @@
1538	1422	'medium' => 'permissions',
1539	1423	'upgrade' => __( 'Form Permissions', 'formidable' ),
1540	1424	'message' => __( 'Allow editing, protect forms and files, limit entries, and save drafts. Upgrade to get form and entry permissions.', 'formidable' ),
1541	1425	'screenshot' => 'permissions.png',
1542		- 'learn-more' => FrmAppHelper::get_doc_url( 'general-form-settings/#kb-form-permissions', 'form-permissions-settings' ),
1543	1426	),
1544	1427	),
1545	1428	'scheduling' => array(
1546	1429	'name' => __( 'Form Scheduling', 'formidable' ),
1547		- 'icon' => 'frmfont frm_calendar_icon',
	1430	+ 'icon' => 'frm_icon_font frm_calendar_icon',
1548	1431	'html_class' => 'frm_show_upgrade_tab frm_noallow',
1549	1432	'data' => array(
1550	1433	'medium' => 'scheduling',
1551	1434	'upgrade' => __( 'Form scheduling settings', 'formidable' ),
1552	1435	'screenshot' => 'scheduling.png',
1553		- 'learn-more' => FrmAppHelper::get_doc_url( 'general-form-settings/#kb-form-scheduling', 'form-scheduling-settings' ),
1554	1436	),
1555	1437	),
1556	1438	'buttons' => array(
1557	1439	'name' => __( 'Buttons', 'formidable' ),
1558		- 'class' => self::class,
	1440	+ 'class' => __CLASS__,
1559	1441	'function' => 'buttons_settings',
1560		- 'icon' => 'frmfont frm_button_icon',
	1442	+ 'icon' => 'frm_icon_font frm_button_icon',
1561	1443	),
1562	1444	'landing' => array(
1563	1445	'name' => __( 'Form Landing Page', 'formidable' ),
1564		- 'icon' => 'frmfont frm_file_text_icon',
	1446	+ 'icon' => 'frm_icon_font frm_file_text_icon',
1565	1447	'html_class' => 'frm_show_upgrade_tab frm_noallow',
1566	1448	'data' => FrmAppHelper::get_landing_page_upgrade_data_params(),
1567	1449	),
1568	1450	'chat' => array(
1569	1451	'name' => __( 'Conversational Forms', 'formidable' ),
1570		- 'icon' => 'frmfont frm_chat_forms_icon',
	1452	+ 'icon' => 'frm_icon_font frm_chat_forms_icon',
1571	1453	'html_class' => 'frm_show_upgrade_tab frm_noallow',
1572	1454	'data' => FrmAppHelper::get_upgrade_data_params(
1573	1455	'chat',
1574	1456	array(
		@@ -1574,15 +1456,14 @@
1574	1456	array(
1575	1457	'upgrade' => __( 'Conversational Forms', 'formidable' ),
1576	1458	'message' => __( 'Ask one question at a time for automated conversations.', 'formidable' ),
1577	1459	'screenshot' => 'chat.png',
1578		- 'learn-more' => FrmAppHelper::get_doc_url( 'conversational-forms', 'conversational-forms-settings', false ),
1579	1460	)
1580	1461	),
1581	1462	),
1582	1463	'abandonment' => array(
1583	1464	'name' => __( 'Form Abandonment', 'formidable' ),
1584		- 'icon' => 'frmfont frm_abandoned_icon',
	1465	+ 'icon' => 'frm_icon_font frm_abandoned_icon',
1585	1466	'html_class' => 'frm_show_upgrade_tab frm_noallow',
1586	1467	'data' => FrmAppHelper::get_upgrade_data_params(
1587	1468	'abandonment',
1588	1469	array(
		@@ -1588,17 +1469,16 @@
1588	1469	array(
1589	1470	'upgrade' => __( 'Form abandonment settings', 'formidable' ),
1590	1471	'message' => __( 'Unlock the power of data capture to boost lead generation and master the art of form optimization.', 'formidable' ),
1591	1472	'screenshot' => 'abandonment.png',
1592		- 'learn-more' => FrmAppHelper::get_doc_url( 'features/form-abandonment-wordpress-plugin', 'form-abandonment-settings', false ),
1593	1473	)
1594	1474	),
1595	1475	),
1596	1476	'html' => array(
1597	1477	'name' => __( 'Customize HTML', 'formidable' ),
1598		- 'class' => self::class,
	1478	+ 'class' => __CLASS__,
1599	1479	'function' => 'html_settings',
1600		- 'icon' => 'frmfont frm_code_icon',
	1480	+ 'icon' => 'frm_icon_font frm_code_icon',
1601	1481	),
1602	1482	);
1603	1483
1604	1484	if ( ! has_action( 'frm_add_form_style_tab_options' ) && ! has_action( 'frm_add_form_button_options' ) ) {
		@@ -1604,8 +1484,14 @@
1604	1484	if ( ! has_action( 'frm_add_form_style_tab_options' ) && ! has_action( 'frm_add_form_button_options' ) ) {
1605	1485	unset( $sections['buttons'] );
1606	1486	}
1607	1487
	1488	+ foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
	1489	+ if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
	1490	+ unset( $sections[ $feature ] );
	1491	+ }
	1492	+ }
	1493	+
1608	1494	$sections = apply_filters( 'frm_add_form_settings_section', $sections, $values );
1609	1495
1610	1496	foreach ( $sections as $key => $section ) {
1611	1497	$defaults = array(
		@@ -1610,9 +1496,9 @@
1610	1496	foreach ( $sections as $key => $section ) {
1611	1497	$defaults = array(
1612	1498	'html_class' => '',
1613	1499	'name' => ucfirst( $key ),
1614		- 'icon' => 'frmfont frm_settings_icon',
	1500	+ 'icon' => 'frm_icon_font frm_settings_icon',
1615	1501	);
1616	1502
1617	1503	$section = array_merge( $defaults, $section );
1618	1504
		@@ -1618,9 +1504,8 @@
1618	1504
1619	1505	if ( ! isset( $section['anchor'] ) ) {
1620	1506	$section['anchor'] = $key;
1621	1507	}
1622		-
1623	1508	$section['anchor'] .= '_settings';
1624	1509
1625	1510	if ( ! isset( $section['title'] ) ) {
1626	1511	$section['title'] = $section['name'];
		@@ -1639,19 +1524,18 @@
1639	1524	/**
1640	1525	* @since 4.0
1641	1526	*
1642	1527	* @param array $values
1643		- *
1644	1528	* @return void
1645	1529	*/
1646	1530	public static function advanced_settings( $values ) {
1647	1531	$first_h3 = 'frm_first_h3';
	1532	+
1648	1533	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-advanced.php';
1649	1534	}
1650	1535
1651	1536	/**
1652	1537	* @param array $values
1653		- *
1654	1538	* @return void
1655	1539	*/
1656	1540	public static function render_spam_settings( $values ) {
1657	1541	if ( function_exists( 'akismet_http_post' ) ) {
		@@ -1656,9 +1540,9 @@
1656	1540	public static function render_spam_settings( $values ) {
1657	1541	if ( function_exists( 'akismet_http_post' ) ) {
1658	1542	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/akismet.php';
1659	1543	}
1660		- include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/stopforumspam.php';
	1544	+ include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/honeypot.php';
1661	1545	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/antispam.php';
1662	1546	}
1663	1547
1664	1548	/**
		@@ -1664,9 +1548,8 @@
1664	1548	/**
1665	1549	* @since 4.0
1666	1550	*
1667	1551	* @param array $values
1668		- *
1669	1552	* @return void
1670	1553	*/
1671	1554	public static function buttons_settings( $values ) {
1672	1555	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-buttons.php';
		@@ -1675,9 +1558,8 @@
1675	1558	/**
1676	1559	* @since 4.0
1677	1560	*
1678	1561	* @param array $values
1679		- *
1680	1562	* @return void
1681	1563	*/
1682	1564	public static function html_settings( $values ) {
1683	1565	include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-html.php';
		@@ -1688,9 +1570,8 @@
1688	1570	*
1689	1571	* @since 2.03.08
1690	1572	*
1691	1573	* @param array|bool $values
1692		- *
1693	1574	* @return void
1694	1575	*/
1695	1576	private static function clean_submit_html( &$values ) {
1696	1577	if ( is_array( $values ) && isset( $values['submit_html'] ) ) {
		@@ -1713,17 +1594,13 @@
1713	1594	return $classes;
1714	1595	}
1715	1596
1716	1597	/**
1717		- * @since 6.27 Added $template_path parameter.
1718		- *
1719	1598	* @param int|string $form_id
1720	1599	* @param string $class
1721		- * @param string $template_path The path to a template file to use instead of the default.
1722		- *
1723	1600	* @return void
1724	1601	*/
1725		- public static function mb_tags_box( $form_id, $class = '', $template_path = 'default' ) {
	1602	+ public static function mb_tags_box( $form_id, $class = '' ) {
1726	1603	$fields = FrmField::get_all_for_form( $form_id, '', 'include' );
1727	1604
1728	1605	/**
1729	1606	* Allows modifying the list of fields in the tags box.
		@@ -1732,30 +1609,23 @@
1732	1609	*
1733	1610	* @param array $fields The list of fields.
1734	1611	* @param array $args The arguments. Contains `form_id`.
1735	1612	*/
1736		- $fields = apply_filters( 'frm_fields_in_tags_box', $fields, compact( 'form_id' ) );
1737		- $linked_forms = array();
1738		- $col = 'one';
1739		- $settings_tab = FrmAppHelper::is_admin_page( 'formidable' );
	1613	+ $fields = apply_filters( 'frm_fields_in_tags_box', $fields, compact( 'form_id' ) );
	1614	+ $linked_forms = array();
	1615	+ $col = 'one';
	1616	+ $settings_tab = FrmAppHelper::is_admin_page( 'formidable' );
	1617	+
1740	1618	$cond_shortcodes = apply_filters( 'frm_conditional_shortcodes', array() );
1741	1619	$entry_shortcodes = self::get_shortcode_helpers( $settings_tab );
	1620	+
1742	1621	$advanced_helpers = self::advanced_helpers( compact( 'fields', 'form_id' ) );
1743	1622
1744		- if ( 'default' === $template_path || ! file_exists( $template_path ) ) {
1745		- include FrmAppHelper::plugin_path() . '/classes/views/shared/mb_adv_info.php';
1746		- return;
1747		- }
1748		-
1749		- include $template_path;
	1623	+ include FrmAppHelper::plugin_path() . '/classes/views/shared/mb_adv_info.php';
1750	1624	}
1751	1625
1752	1626	/**
1753	1627	* @since 3.04.01
1754		- *
1755		- * @param array $atts
1756		- *
1757		- * @return array
1758	1628	*/
1759	1629	private static function advanced_helpers( $atts ) {
1760	1630	$advanced_helpers = array(
1761	1631	'default' => array(
		@@ -1764,12 +1634,10 @@
1764	1634	),
1765	1635	);
1766	1636
1767	1637	$user_fields = self::user_shortcodes();
1768		-
1769	1638	if ( $user_fields ) {
1770	1639	$user_helpers = array();
1771		-
1772	1640	foreach ( $user_fields as $uk => $uf ) {
1773	1641	$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1774	1642	unset( $uk, $uf );
1775	1643	}
		@@ -1794,10 +1662,8 @@
1794	1662	* Get an array of the options to display in the advanced tab
1795	1663	* of the customization panel
1796	1664	*
1797	1665	* @since 2.0.6
1798		- *
1799		- * @return array
1800	1666	*/
1801	1667	private static function get_advanced_shortcodes() {
1802	1668	$adv_shortcodes = array(
1803	1669	'x sep=", "' => array(
		@@ -1814,18 +1680,17 @@
1814	1680	'label' => __( 'No Auto P', 'formidable' ),
1815	1681	'title' => __( 'Do not automatically add any paragraphs or line breaks', 'formidable' ),
1816	1682	),
1817	1683	);
	1684	+ $adv_shortcodes = apply_filters( 'frm_advanced_shortcodes', $adv_shortcodes );
1818	1685
1819	1686	// __( 'Leave blank instead of defaulting to User Login', 'formidable' ) : blank=1
1820	1687
1821		- return apply_filters( 'frm_advanced_shortcodes', $adv_shortcodes );
	1688	+ return $adv_shortcodes;
1822	1689	}
1823	1690
1824	1691	/**
1825	1692	* @since 3.04.01
1826		- *
1827		- * @return array
1828	1693	*/
1829	1694	private static function user_shortcodes() {
1830	1695	$options = array(
1831	1696	'ID' => __( 'User ID', 'formidable' ),
		@@ -1844,12 +1709,8 @@
1844	1709	/**
1845	1710	* Get an array of the helper shortcodes to display in the customization panel
1846	1711	*
1847	1712	* @since 2.0.6
1848		- *
1849		- * @param bool $settings_tab
1850		- *
1851		- * @return array
1852	1713	*/
1853	1714	private static function get_shortcode_helpers( $settings_tab ) {
1854	1715	$entry_shortcodes = array(
1855	1716	'id' => __( 'Entry ID', 'formidable' ),
		@@ -1864,9 +1725,8 @@
1864	1725	'form_name' => __( 'Form Name', 'formidable' ),
1865	1726	);
1866	1727
1867	1728	$entry_shortcodes = array_merge( FrmShortcodeHelper::get_contextual_shortcode_values(), $entry_shortcodes );
1868		-
1869	1729	if ( ! FrmAppHelper::pro_is_installed() ) {
1870	1730	unset( $entry_shortcodes['post_id'] );
1871	1731	}
1872	1732
		@@ -1874,13 +1734,12 @@
1874	1734	* Use this hook to add or remove buttons in the helpers section
1875	1735	* in the customization panel
1876	1736	*
1877	1737	* @since 2.0.6
1878		- *
1879		- * @param array $entry_shortcodes
1880		- * @param bool $settings_tab
1881	1738	*/
1882		- return apply_filters( 'frm_helper_shortcodes', $entry_shortcodes, $settings_tab );
	1739	+ $entry_shortcodes = apply_filters( 'frm_helper_shortcodes', $entry_shortcodes, $settings_tab );
	1740	+
	1741	+ return $entry_shortcodes;
1883	1742	}
1884	1743
1885	1744	/**
1886	1745	* Insert the form class setting into the form.
		@@ -1885,9 +1744,8 @@
1885	1744	/**
1886	1745	* Insert the form class setting into the form.
1887	1746	*
1888	1747	* @param stdClass $form
1889		- *
1890	1748	* @return void
1891	1749	*/
1892	1750	public static function form_classes( $form ) {
1893	1751	if ( isset( $form->options['form_class'] ) ) {
		@@ -1910,9 +1768,8 @@
1910	1768	* @param stdClass $form
1911	1769	*/
1912	1770	public static function add_js_validate_form_to_global_vars( $form ) {
1913	1771	global $frm_vars;
1914		-
1915	1772	if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1916	1773	$frm_vars['js_validate_forms'] = array();
1917	1774	}
1918	1775	$frm_vars['js_validate_forms'][ $form->id ] = $form;
		@@ -1935,9 +1792,8 @@
1935	1792	/**
1936	1793	* @param string $content
1937	1794	* @param int|stdClass|string $form
1938	1795	* @param false|int|stdClass|string $entry
1939		- *
1940	1796	* @return string
1941	1797	*/
1942	1798	public static function filter_content( $content, $form, $entry = false ) {
1943	1799	$content = self::replace_form_name_shortcodes( $content, $form );
		@@ -1942,9 +1798,8 @@
1942	1798	public static function filter_content( $content, $form, $entry = false ) {
1943	1799	$content = self::replace_form_name_shortcodes( $content, $form );
1944	1800
1945	1801	self::get_entry_by_param( $entry );
1946		-
1947	1802	if ( ! $entry ) {
1948	1803	return $content;
1949	1804	}
1950	1805
		@@ -1960,10 +1815,11 @@
1960	1815	$form = $entry->parent_entry->form_id;
1961	1816	}
1962	1817
1963	1818	$shortcodes = FrmFieldsHelper::get_shortcodes( $content, $form );
	1819	+ $content = apply_filters( 'frm_replace_content_shortcodes', $content, $entry, $shortcodes );
1964	1820
1965		- return apply_filters( 'frm_replace_content_shortcodes', $content, $entry, $shortcodes );
	1821	+ return $content;
1966	1822	}
1967	1823
1968	1824	/**
1969	1825	* Replace any [form_name] shortcodes in a string.
		@@ -1971,9 +1827,8 @@
1971	1827	* @since 5.5
1972	1828	*
1973	1829	* @param array|string $string
1974	1830	* @param int|stdClass|string $form
1975		- *
1976	1831	* @return array|string
1977	1832	*/
1978	1833	public static function replace_form_name_shortcodes( $string, $form ) {
1979	1834	if ( ! is_string( $string ) ) {
		@@ -1979,9 +1834,9 @@
1979	1834	if ( ! is_string( $string ) ) {
1980	1835	return $string;
1981	1836	}
1982	1837
1983		- if ( ! str_contains( $string, '[form_name]' ) ) {
	1838	+ if ( false === strpos( $string, '[form_name]' ) ) {
1984	1839	return $string;
1985	1840	}
1986	1841
1987	1842	if ( ! is_object( $form ) ) {
		@@ -1993,30 +1848,20 @@
1993	1848	}
1994	1849
1995	1850	/**
1996	1851	* @param false|int|stdClass|string $entry
1997		- *
1998	1852	* @return void
1999	1853	*/
2000	1854	private static function get_entry_by_param( &$entry ) {
2001		- if ( $entry && is_object( $entry ) ) {
2002		- return;
2003		- }
	1855	+ if ( ! $entry || ! is_object( $entry ) ) {
	1856	+ if ( ! $entry || ! is_numeric( $entry ) ) {
	1857	+ $entry = FrmAppHelper::get_post_param( 'id', false, 'sanitize_title' );
	1858	+ }
2004	1859
2005		- if ( ! $entry || ! is_numeric( $entry ) ) {
2006		- $entry = FrmAppHelper::get_post_param( 'id', false, 'sanitize_title' );
	1860	+ FrmEntry::maybe_get_entry( $entry );
2007	1861	}
2008		-
2009		- FrmEntry::maybe_get_entry( $entry );
2010	1862	}
2011	1863
2012		- /**
2013		- * @param string $content
2014		- * @param false|object $entry
2015		- * @param array $shortcodes
2016		- *
2017		- * @return string
2018		- */
2019	1864	public static function replace_content_shortcodes( $content, $entry, $shortcodes ) {
2020	1865	return FrmFieldsHelper::replace_content_shortcodes( $content, $entry, $shortcodes );
2021	1866	}
2022	1867
		@@ -2021,9 +1866,8 @@
2021	1866	}
2022	1867
2023	1868	/**
2024	1869	* @param array $errors
2025		- *
2026	1870	* @return array
2027	1871	*/
2028	1872	public static function process_bulk_form_actions( $errors ) {
2029	1873	if ( ! $_REQUEST ) {
		@@ -2030,30 +1874,29 @@
2030	1874	return $errors;
2031	1875	}
2032	1876
2033	1877	$bulkaction = FrmAppHelper::get_param( 'action', '', 'get', 'sanitize_text_field' );
2034		-
2035		- // phpcs:ignore Universal.Operators.StrictComparisons
2036	1878	if ( $bulkaction == - 1 ) {
2037	1879	$bulkaction = FrmAppHelper::get_param( 'action2', '', 'get', 'sanitize_title' );
2038	1880	}
2039	1881
2040		- if ( $bulkaction && str_starts_with( $bulkaction, 'bulk_' ) ) {
	1882	+ if ( ! empty( $bulkaction ) && strpos( $bulkaction, 'bulk_' ) === 0 ) {
2041	1883	FrmAppHelper::remove_get_action();
	1884	+
2042	1885	$bulkaction = str_replace( 'bulk_', '', $bulkaction );
2043	1886	}
2044	1887
2045	1888	$ids = FrmAppHelper::get_param( 'item-action', '', 'get', 'sanitize_text_field' );
	1889	+ if ( empty( $ids ) ) {
	1890	+ $errors[] = __( 'No forms were specified', 'formidable' );
2046	1891
2047		- if ( ! $ids ) {
2048		- $errors[] = __( 'No forms were specified', 'formidable' );
2049	1892	return $errors;
2050	1893	}
2051	1894
2052	1895	$permission_error = FrmAppHelper::permission_nonce_error( '', '_wpnonce', 'bulk-toplevel_page_formidable' );
2053		-
2054	1896	if ( $permission_error !== false ) {
2055	1897	$errors[] = $permission_error;
	1898	+
2056	1899	return $errors;
2057	1900	}
2058	1901
2059	1902	if ( ! is_array( $ids ) ) {
		@@ -2081,9 +1924,8 @@
2081	1924	/**
2082	1925	* Includes html that shows a message when the device is too small to use Formidable Forms admin pages.
2083	1926	*
2084	1927	* @since 6.20
2085		- *
2086	1928	* @return void
2087	1929	*/
2088	1930	public static function include_device_too_small_message() {
2089	1931	if ( ! FrmAppHelper::is_formidable_admin() ) {
		@@ -2092,13 +1934,12 @@
2092	1934
2093	1935	include FrmAppHelper::plugin_path() . '/classes/views/shared/small-device-message.php';
2094	1936	}
2095	1937
2096		- public static function route() { // phpcs:ignore Generic.Metrics.CyclomaticComplexity.MaxExceeded
	1938	+ public static function route() {
2097	1939	$action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
2098	1940	$vars = array();
2099	1941	FrmAppHelper::include_svg();
2100		-
2101	1942	if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2102	1943	FrmAppHelper::permission_check( 'frm_edit_forms' );
2103	1944
2104	1945	// Javascript needs to be allowed in some field settings.
		@@ -2104,28 +1945,25 @@
2104	1945	// Javascript needs to be allowed in some field settings.
2105	1946	// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
2106	1947	$json_vars = htmlspecialchars_decode( nl2br( str_replace( '&quot;', '"', wp_unslash( $_POST['frm_compact_fields'] ) ) ) );
2107	1948	$json_vars = json_decode( $json_vars, true );
	1949	+ if ( empty( $json_vars ) ) {
	1950	+ // json decoding failed so we should return an error message.
	1951	+ $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
	1952	+ if ( 'edit' === $action ) {
	1953	+ $action = 'update';
	1954	+ }
2108	1955
2109		- if ( $json_vars ) {
	1956	+ add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
	1957	+ } else {
2110	1958	$vars = FrmAppHelper::json_to_array( $json_vars );
2111	1959	$action = $vars[ $action ];
2112	1960	unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2113	1961	$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2114	1962	$_POST = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2115		- } else {
2116		- // Json decoding failed so we should return an error message.
2117		- $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
2118		-
2119		- if ( 'edit' === $action ) {
2120		- $action = 'update';
2121		- }
2122		-
2123		- add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
2124	1963	}
2125	1964	} else {
2126	1965	$action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
2127		-
2128	1966	if ( isset( $_REQUEST['delete_all'] ) ) {
2129	1967	// Override the action for this page.
2130	1968	$action = 'delete_all';
2131	1969	}
		@@ -2145,38 +1983,34 @@
2145	1983	case 'update_settings':
2146	1984	return self::$action( $vars );
2147	1985	case 'lite-reports':
2148	1986	self::no_reports( $vars );
2149		- return null;
	1987	+ return;
2150	1988	case 'views':
2151	1989	self::no_views( $vars );
2152		- return null;
	1990	+ return;
2153	1991	default:
2154	1992	do_action( 'frm_form_action_' . $action );
2155		-
2156	1993	if ( apply_filters( 'frm_form_stop_action_' . $action, false ) ) {
2157		- return null;
	1994	+ return;
2158	1995	}
2159	1996
2160	1997	$action = FrmAppHelper::get_param( 'action', '', 'get', 'sanitize_text_field' );
2161		-
2162		- // phpcs:ignore Universal.Operators.StrictComparisons
2163	1998	if ( $action == - 1 ) {
2164	1999	$action = FrmAppHelper::get_param( 'action2', '', 'get', 'sanitize_title' );
2165	2000	}
2166	2001
2167		- if ( str_starts_with( $action, 'bulk_' ) ) {
	2002	+ if ( strpos( $action, 'bulk_' ) === 0 ) {
2168	2003	FrmAppHelper::remove_get_action();
2169	2004
2170	2005	self::list_form();
2171		- return null;
	2006	+ return;
2172	2007	}
2173	2008
2174	2009	$message = FrmAppHelper::get_param( 'message' );
2175		-
2176	2010	if ( 'form_duplicate_error' === $message ) {
2177	2011	self::display_forms_list( array(), '', array( __( 'There was a problem duplicating the form', 'formidable' ) ) );
2178		- return null;
	2012	+ return;
2179	2013	}
2180	2014
2181	2015	if ( 'forms_permanently_deleted' === $message ) {
2182	2016	$count = FrmAppHelper::get_param( 'forms_deleted', 0, 'get', 'absint' );
		@@ -2182,14 +2016,14 @@
2182	2016	$count = FrmAppHelper::get_param( 'forms_deleted', 0, 'get', 'absint' );
2183	2017	/* translators: %1$s: Number of forms */
2184	2018	$message = sprintf( _n( '%1$s form permanently deleted.', '%1$s forms permanently deleted.', $count, 'formidable' ), $count );
2185	2019	self::display_forms_list( array(), $message, '' );
2186		- return null;
	2020	+ return;
2187	2021	}
2188	2022
2189	2023	self::display_forms_list();
2190	2024
2191		- return null;
	2025	+ return;
2192	2026	}//end switch
2193	2027	}
2194	2028
2195	2029	/**
		@@ -2208,43 +2042,19 @@
2208	2042
2209	2043	// Get posted data
2210	2044	$form_id = FrmAppHelper::get_post_param( 'form_id', '', 'absint' );
2211	2045	$name = FrmAppHelper::get_post_param( 'form_name', '', 'sanitize_text_field' );
2212		- $form = FrmForm::getOne( $form_id );
2213	2046
2214		- if ( ! $form ) {
2215		- wp_send_json_error( __( 'Form not found', 'formidable' ) );
2216		- }
	2047	+ // Update the form name and form key.
	2048	+ $form_key = FrmAppHelper::get_unique_key( sanitize_title( $name ), 'frm_forms', 'form_key' );
	2049	+ FrmForm::update( $form_id, compact( 'name', 'form_key' ) );
2217	2050
2218		- if ( $name === $form->name ) {
2219		- // Nothing to change so exit early.
2220		- wp_send_json_success();
2221		- }
2222		-
2223		- $to_update = array(
2224		- 'name' => $name,
2225		- );
2226		-
2227		- if ( '' === $name ) {
2228		- $form_key = $form->form_key;
2229		- } else {
2230		- // Only update form_key if name is not empty.
2231		- $form_key = FrmAppHelper::get_unique_key( sanitize_title( $name ), 'frm_forms', 'form_key' );
2232		- $to_update['form_key'] = $form_key;
2233		- }
2234		-
2235		- FrmForm::update( $form_id, $to_update );
2236		-
2237	2051	wp_send_json_success( compact( 'form_key' ) );
2238	2052	}
2239	2053
2240		- /**
2241		- * @param array $errors
2242		- *
2243		- * @return array
2244		- */
2245	2054	public static function json_error( $errors ) {
2246	2055	$errors['json'] = __( 'Abnormal HTML characters prevented your form from saving correctly', 'formidable' );
	2056	+
2247	2057	return $errors;
2248	2058	}
2249	2059
2250	2060	/**
		@@ -2251,10 +2061,8 @@
2251	2061	* Add education about views.
2252	2062	*
2253	2063	* @since 4.07
2254	2064	*
2255		- * @param array $values
2256		- *
2257	2065	* @return void
2258	2066	*/
2259	2067	public static function no_views( $values = array() ) {
2260	2068	FrmAppHelper::include_svg();
		@@ -2268,10 +2076,8 @@
2268	2076	* Add education about reports.
2269	2077	*
2270	2078	* @since 4.07
2271	2079	*
2272		- * @param array $values
2273		- *
2274	2080	* @return void
2275	2081	*/
2276	2082	public static function no_reports( $values = array() ) {
2277	2083	$id = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
		@@ -2298,9 +2104,8 @@
2298	2104	* @since 4.05.02
2299	2105	*/
2300	2106	private static function move_menu_to_footer() {
2301	2107	$settings = FrmAppHelper::get_settings();
2302		-
2303	2108	if ( empty( $settings->admin_bar ) ) {
2304	2109	remove_action( 'wp_body_open', 'wp_admin_bar_render', 0 );
2305	2110	}
2306	2111	}
		@@ -2306,15 +2111,13 @@
2306	2111	}
2307	2112
2308	2113	public static function admin_bar_configure() {
2309	2114	global $frm_vars;
2310		-
2311	2115	if ( empty( $frm_vars['forms_loaded'] ) ) {
2312	2116	return;
2313	2117	}
2314	2118
2315	2119	$actions = array();
2316		-
2317	2120	foreach ( $frm_vars['forms_loaded'] as $form ) {
2318	2121	if ( is_object( $form ) ) {
2319	2122	$actions[ $form->id ] = $form->name;
2320	2123	}
		@@ -2320,9 +2123,9 @@
2320	2123	}
2321	2124	unset( $form );
2322	2125	}
2323	2126
2324		- if ( ! $actions ) {
	2127	+ if ( empty( $actions ) ) {
2325	2128	return;
2326	2129	}
2327	2130
2328	2131	self::add_menu_to_admin_bar();
		@@ -2348,12 +2151,8 @@
2348	2151	}
2349	2152
2350	2153	/**
2351	2154	* @since 2.05.07
2352		- *
2353		- * @param array $actions
2354		- *
2355		- * @return void
2356	2155	*/
2357	2156	private static function add_forms_to_admin_bar( $actions ) {
2358	2157	global $wp_admin_bar;
2359	2158
		@@ -2359,13 +2158,14 @@
2359	2158
2360	2159	asort( $actions );
2361	2160
2362	2161	foreach ( $actions as $form_id => $name ) {
	2162	+
2363	2163	$wp_admin_bar->add_node(
2364	2164	array(
2365	2165	'parent' => 'frm-forms',
2366	2166	'id' => 'edit_form_' . $form_id,
2367		- 'title' => $name ? $name : FrmFormsHelper::get_no_title_text(),
	2167	+ 'title' => empty( $name ) ? FrmFormsHelper::get_no_title_text() : $name,
2368	2168	'href' => FrmForm::get_edit_link( $form_id ),
2369	2169	)
2370	2170	);
2371	2171	}
		@@ -2374,14 +2174,12 @@
2374	2174	/**
2375	2175	* The formidable shortcode
2376	2176	*
2377	2177	* @param array $atts The params from the shortcode.
2378		- *
2379	2178	* @return string
2380	2179	*/
2381	2180	public static function get_form_shortcode( $atts ) {
2382	2181	global $frm_vars;
2383		-
2384	2182	if ( ! empty( $frm_vars['skip_shortcode'] ) ) {
2385	2183	$sc = '[formidable';
2386	2184	$sc .= FrmAppHelper::array_to_html_params( $atts );
2387	2185	return $sc . ']';
		@@ -2410,9 +2208,8 @@
2410	2208	* @since 5.2.01
2411	2209	*
2412	2210	* @param false|int|string $id
2413	2211	* @param false|string $key
2414		- *
2415	2212	* @return false|stdClass
2416	2213	*/
2417	2214	private static function maybe_get_form_by_id_or_key( $id, $key ) {
2418	2215	if ( ! $id ) {
		@@ -2426,9 +2223,8 @@
2426	2223	* @param false|string $key
2427	2224	* @param bool|int|string $title may be 'auto', true, false, 'true', 'false', 'yes', '1', 1, '0', 0.
2428	2225	* @param bool|int|string $description may be 'auto', true, false, 'true', 'false', 'yes', '1', 1, '0', 0.
2429	2226	* @param array $atts
2430		- *
2431	2227	* @return string
2432	2228	*/
2433	2229	public static function show_form( $id = '', $key = '', $title = false, $description = false, $atts = array() ) {
2434	2230	$form = self::maybe_get_form_by_id_or_key( $id, $key );
		@@ -2449,13 +2245,14 @@
2449	2245
2450	2246	add_action( 'frm_load_form_hooks', 'FrmHooksController::trigger_load_form_hooks' );
2451	2247	FrmAppHelper::trigger_hook_load( 'form', $form );
2452	2248
2453		- $form = apply_filters( 'frm_pre_display_form', $form );
	2249	+ $form = apply_filters( 'frm_pre_display_form', $form );
	2250	+
2454	2251	$frm_settings = FrmAppHelper::get_settings( array( 'current_form' => $form->id ) );
2455	2252
2456	2253	if ( self::is_viewable_draft_form( $form ) ) {
2457		- // Don't show a draft form on a page
	2254	+ // don't show a draft form on a page
2458	2255	$form = __( 'Please select a valid form', 'formidable' );
2459	2256	} elseif ( ! FrmForm::is_visible_to_user( $form ) ) {
2460	2257	$form = do_shortcode( $frm_settings->login_msg );
2461	2258	} else {
		@@ -2475,18 +2272,16 @@
2475	2272	}
2476	2273
2477	2274	/**
2478	2275	* @param false|int|string $id
2479		- *
2480	2276	* @return false|stdClass
2481	2277	*/
2482	2278	private static function maybe_get_form_to_show( $id ) {
2483	2279	$form = false;
2484	2280
2485		- if ( $id ) {
	2281	+ if ( ! empty( $id ) ) {
2486	2282	// Form id or key is set.
2487	2283	$form = FrmForm::getOne( $id );
2488		-
2489	2284	if ( ! $form || $form->parent_form_id || $form->status === 'trash' ) {
2490	2285	$form = false;
2491	2286	}
2492	2287	}
		@@ -2493,25 +2288,12 @@
2493	2288
2494	2289	return $form;
2495	2290	}
2496	2291
2497		- /**
2498		- * @param object $form
2499		- *
2500		- * @return bool
2501		- */
2502	2292	private static function is_viewable_draft_form( $form ) {
2503	2293	return $form->status === 'draft' && current_user_can( 'frm_edit_forms' ) && ! FrmAppHelper::is_preview_page();
2504	2294	}
2505	2295
2506		- /**
2507		- * @param object $form
2508		- * @param bool $title
2509		- * @param bool $description
2510		- * @param array $atts
2511		- *
2512		- * @return string
2513		- */
2514	2296	public static function get_form( $form, $title, $description, $atts = array() ) {
2515	2297	ob_start();
2516	2298
2517	2299	do_action( 'frm_before_get_form', $atts );
		@@ -2518,9 +2300,10 @@
2518	2300
2519	2301	self::get_form_contents( $form, $title, $description, $atts );
2520	2302	self::enqueue_scripts( FrmForm::get_params( $form ) );
2521	2303
2522		- $contents = ob_get_clean();
	2304	+ $contents = ob_get_contents();
	2305	+ ob_end_clean();
2523	2306
2524	2307	self::maybe_minimize_form( $atts, $contents );
2525	2308
2526	2309	return $contents;
		@@ -2525,25 +2308,12 @@
2525	2308
2526	2309	return $contents;
2527	2310	}
2528	2311
2529		- /**
2530		- * @param array $params
2531		- *
2532		- * @return void
2533		- */
2534	2312	public static function enqueue_scripts( $params ) {
2535	2313	do_action( 'frm_enqueue_form_scripts', $params );
2536	2314	}
2537	2315
2538		- /**
2539		- * @param object $form
2540		- * @param bool $title
2541		- * @param bool $description
2542		- * @param array $atts
2543		- *
2544		- * @return void
2545		- */
2546	2316	public static function get_form_contents( $form, $title, $description, $atts ) {
2547	2317	$params = FrmForm::get_params( $form );
2548	2318	$errors = self::get_saved_errors( $form, $params );
2549	2319	$fields = FrmFieldsHelper::get_form_fields( $form->id, $errors );
		@@ -2550,10 +2320,9 @@
2550	2320	$reset = false;
2551	2321	$pass_args = compact( 'form', 'fields', 'errors', 'title', 'description', 'reset' );
2552	2322
2553	2323	$pass_args['action'] = $params['action'];
2554		- // phpcs:ignore WordPress.Security.NonceVerification.Missing, Universal.Operators.StrictComparisons
2555		- $handle_process_here = $params['action'] === 'create' && $params['posted_form_id'] == $form->id && $_POST;
	2324	+ $handle_process_here = $params['action'] === 'create' && $params['posted_form_id'] == $form->id && $_POST; // phpcs:ignore WordPress.Security.NonceVerification.Missing
2556	2325
2557	2326	if ( ! $handle_process_here ) {
2558	2327	FrmFormState::set_initial_value( 'title', $title );
2559	2328	FrmFormState::set_initial_value( 'description', $description );
		@@ -2558,15 +2327,16 @@
2558	2327	FrmFormState::set_initial_value( 'title', $title );
2559	2328	FrmFormState::set_initial_value( 'description', $description );
2560	2329
2561	2330	do_action( 'frm_display_form_action', $params, $fields, $form, $title, $description );
2562		-
2563	2331	if ( apply_filters( 'frm_continue_to_new', true, $form->id, $params['action'] ) ) {
2564	2332	self::show_form_after_submit( $pass_args );
2565	2333	}
2566		- } elseif ( $errors ) {
	2334	+ } elseif ( ! empty( $errors ) ) {
2567	2335	self::show_form_after_submit( $pass_args );
	2336	+
2568	2337	} else {
	2338	+
2569	2339	do_action( 'frm_validate_form_creation', $params, $fields, $form, $title, $description );
2570	2340
2571	2341	if ( apply_filters( 'frm_continue_to_create', true, $form->id ) ) {
2572	2342	$entry_id = self::just_created_entry( $form->id );
		@@ -2589,19 +2359,13 @@
2589	2359	/**
2590	2360	* If the form was processed earlier (init), get the generated errors
2591	2361	*
2592	2362	* @since 2.05
2593		- *
2594		- * @param object $form
2595		- * @param array $params
2596		- *
2597		- * @return array
2598	2363	*/
2599	2364	private static function get_saved_errors( $form, $params ) {
2600	2365	global $frm_vars;
2601	2366
2602		- // phpcs:ignore WordPress.Security.NonceVerification.Missing, Universal.Operators.StrictComparisons
2603		- if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
	2367	+ if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2604	2368	$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2605	2369	} else {
2606	2370	$errors = array();
2607	2371	}
		@@ -2618,16 +2382,13 @@
2618	2382	}
2619	2383
2620	2384	/**
2621	2385	* @since 2.2.7
2622		- *
2623		- * @param int|string $form_id
2624		- *
2625		- * @return int
2626	2386	*/
2627	2387	public static function just_created_entry( $form_id ) {
2628	2388	global $frm_vars;
2629		- return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
	2389	+
	2390	+ return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2630	2391	}
2631	2392
2632	2393	/**
2633	2394	* Gets confirmation method.
		@@ -2640,9 +2401,8 @@
2640	2401	*
2641	2402	* @type object $form Form object.
2642	2403	* @type int $entry_id Entry ID.
2643	2404	* }
2644		- *
2645	2405	* @return array|string
2646	2406	*/
2647	2407	private static function get_confirmation_method( $atts ) {
2648	2408	$action = FrmOnSubmitHelper::current_event( $atts );
		@@ -2650,9 +2410,8 @@
2650	2410	$method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
2651	2411
2652	2412	if ( ! empty( $atts['entry_id'] ) ) {
2653	2413	$met_actions = self::get_met_on_submit_actions( $atts, $action );
2654		-
2655	2414	if ( $met_actions ) {
2656	2415	$method = $met_actions;
2657	2416	}
2658	2417	}
		@@ -2659,21 +2418,14 @@
2659	2418
2660	2419	$method = apply_filters( 'frm_success_filter', $method, $atts['form'], $action );
2661	2420
2662	2421	if ( $method !== 'message' && ( ! $atts['entry_id'] || ! is_numeric( $atts['entry_id'] ) ) ) {
2663		- return 'message';
	2422	+ $method = 'message';
2664	2423	}
2665	2424
2666	2425	return $method;
2667	2426	}
2668	2427
2669		- /**
2670		- * @param object $form
2671		- * @param array $params
2672		- * @param array $args
2673		- *
2674		- * @return void
2675		- */
2676	2428	public static function maybe_trigger_redirect( $form, $params, $args ) {
2677	2429	if ( ! isset( $params['id'] ) ) {
2678	2430	global $frm_vars;
2679	2431	$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
		@@ -2700,12 +2452,14 @@
2700	2452	* @param array $params See {@see FrmFormsController::maybe_trigger_redirect()}.
2701	2453	* @param array $args See {@see FrmFormsController::maybe_trigger_redirect()}.
2702	2454	*/
2703	2455	public static function maybe_trigger_redirect_with_action( $conf_method, $form, $params, $args ) {
2704		- if ( is_array( $conf_method ) && 1 === count( $conf_method ) && 'redirect' === FrmOnSubmitHelper::get_action_type( $conf_method[0] ) && empty( $conf_method[0]->post_content['redirect_delay'] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2705		- $event = FrmOnSubmitHelper::current_event( $params );
2706		- FrmOnSubmitHelper::populate_on_submit_data( $form->options, $conf_method[0], $event );
2707		- $conf_method = 'redirect';
	2456	+ if ( is_array( $conf_method ) && 1 === count( $conf_method ) ) {
	2457	+ if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $conf_method[0] ) && empty( $conf_method[0]->post_content['redirect_delay'] ) ) {
	2458	+ $event = FrmOnSubmitHelper::current_event( $params );
	2459	+ FrmOnSubmitHelper::populate_on_submit_data( $form->options, $conf_method[0], $event );
	2460	+ $conf_method = 'redirect';
	2461	+ }
2708	2462	}
2709	2463
2710	2464	if ( 'redirect' === $conf_method ) {
2711	2465	self::trigger_redirect( $form, $params, $args );
		@@ -2711,15 +2465,8 @@
2711	2465	self::trigger_redirect( $form, $params, $args );
2712	2466	}
2713	2467	}
2714	2468
2715		- /**
2716		- * @param object $form
2717		- * @param array $params
2718		- * @param array $args
2719		- *
2720		- * @return void
2721		- */
2722	2469	public static function trigger_redirect( $form, $params, $args ) {
2723	2470	$success_args = array(
2724	2471	'action' => $params['action'],
2725	2472	'conf_method' => 'redirect',
		@@ -2778,9 +2525,8 @@
2778	2525	* @since 6.0
2779	2526	*
2780	2527	* @param array $args See {@see FrmFormsController::run_success_action()}.
2781	2528	* @param string $event Form event. Default is `create`.
2782		- *
2783	2529	* @return array Array of actions that meet the conditional logics.
2784	2530	*/
2785	2531	public static function get_met_on_submit_actions( $args, $event = 'create' ) {
2786	2532	if ( ! FrmOnSubmitHelper::form_has_migrated( $args['form'] ) ) {
		@@ -2807,11 +2553,13 @@
2807	2553	}
2808	2554
2809	2555	$action_type = FrmOnSubmitHelper::get_action_type( $action );
2810	2556
2811		- if ( 'redirect' === $action_type && $has_redirect ) {
2812		- // Do not process because we run the first redirect action only.
2813		- continue;
	2557	+ if ( 'redirect' === $action_type ) {
	2558	+ if ( $has_redirect ) {
	2559	+ // Do not process because we run the first redirect action only.
	2560	+ continue;
	2561	+ }
2814	2562	}
2815	2563
2816	2564	if ( ! self::is_valid_on_submit_action( $action, $args, $event ) ) {
2817	2565	continue;
		@@ -2836,10 +2584,10 @@
2836	2584	* @param array $args See {@see FrmFormsController::run_success_action()}. `$args['event']` is also added.
2837	2585	*/
2838	2586	$met_actions = apply_filters( 'frm_get_met_on_submit_actions', $met_actions, $args );
2839	2587
2840		- if ( ! $met_actions ) {
2841		- return array( FrmOnSubmitHelper::get_fallback_action( $event ) );
	2588	+ if ( empty( $met_actions ) ) {
	2589	+ $met_actions = array( FrmOnSubmitHelper::get_fallback_action( $event ) );
2842	2590	}
2843	2591
2844	2592	return $met_actions;
2845	2593	}
		@@ -2851,9 +2599,8 @@
2851	2599	*
2852	2600	* @param object $action Form action object.
2853	2601	* @param array $args See {@see FrmFormsController::run_success_action()}.
2854	2602	* @param string $event Form event. Default is `create`.
2855		- *
2856	2603	* @return bool
2857	2604	*/
2858	2605	private static function is_valid_on_submit_action( $action, $args, $event = 'create' ) {
2859	2606	$action_type = FrmOnSubmitHelper::get_action_type( $action );
		@@ -2875,9 +2622,8 @@
2875	2622	return false;
2876	2623	}
2877	2624
2878	2625	$page = get_post( $action->post_content['success_page_id'] );
2879		-
2880	2626	if ( ! $page || 'trash' === $page->post_status ) {
2881	2627	return false;
2882	2628	}
2883	2629	}
		@@ -2899,9 +2645,8 @@
2899	2645	'entry_id' => $args['entry_id'],
2900	2646	'action' => FrmOnSubmitHelper::current_event( $args ),
2901	2647	)
2902	2648	);
2903		-
2904	2649	if ( ! is_array( $args['conf_method'] ) ) {
2905	2650	self::run_success_action( $args );
2906	2651	return;
2907	2652	}
		@@ -2928,9 +2673,8 @@
2928	2673	* @param array $args See {@see FrmFormsController::run_success_action()}.
2929	2674	*/
2930	2675	public static function run_multi_on_submit_actions( $args ) {
2931	2676	$redirect_action = null;
2932		-
2933	2677	foreach ( $args['conf_method'] as $action ) {
2934	2678	if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $action ) ) {
2935	2679	// We catch the redirect action to run it last.
2936	2680	$redirect_action = $action;
		@@ -2941,15 +2685,13 @@
2941	2685
2942	2686	unset( $action );
2943	2687	}
2944	2688
2945		- if ( ! $redirect_action ) {
2946		- return;
	2689	+ if ( $redirect_action ) {
	2690	+ // Show script to delay the redirection.
	2691	+ $args['force_delay_redirect'] = true;
	2692	+ self::run_single_on_submit_action( $args, $redirect_action );
2947	2693	}
2948		-
2949		- // Show script to delay the redirection.
2950		- $args['force_delay_redirect'] = true;
2951		- self::run_single_on_submit_action( $args, $redirect_action );
2952	2694	}
2953	2695
2954	2696	/**
2955	2697	* Runs single On Submit action.
		@@ -2970,9 +2712,8 @@
2970	2712	* @since 6.0
2971	2713	*
2972	2714	* @param array $args See {@see FrmFormsController::run_success_action()}.
2973	2715	* @param object $action On Submit action object.
2974		- *
2975	2716	* @return array
2976	2717	*/
2977	2718	private static function get_run_success_action_args( $args, $action ) {
2978	2719	$new_args = $args;
		@@ -2978,9 +2719,10 @@
2978	2719	$new_args = $args;
2979	2720
2980	2721	FrmOnSubmitHelper::populate_on_submit_data( $new_args['form']->options, $action, $args['action'] );
2981	2722
2982		- $opt = 'update' === $args['action'] ? 'edit_' : 'success_';
	2723	+ $opt = 'update' === $args['action'] ? 'edit_' : 'success_';
	2724	+
2983	2725	$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2984	2726
2985	2727	/**
2986	2728	* Filters the run success action args.
		@@ -2995,18 +2737,12 @@
2995	2737	}
2996	2738
2997	2739	/**
2998	2740	* @since 3.0
2999		- *
3000		- * @param array $args
3001		- *
3002		- * @return void
3003	2741	*/
3004	2742	private static function load_page_after_submit( $args ) {
3005	2743	global $post;
3006	2744	$opt = $args['success_opt'];
3007		-
3008		- // phpcs:ignore Universal.Operators.StrictComparisons
3009	2745	if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
3010	2746	$page = get_post( $args['form']->options[ $opt . '_page_id' ] );
3011	2747	$old_post = $post;
3012	2748	$post = $page;
		@@ -3030,9 +2766,8 @@
3030	2766	}
3031	2767
3032	2768	/**
3033	2769	* @since 3.0
3034		- *
3035	2770	* @param array $args See {@see FrmFormsController::run_success_action()}.
3036	2771	*/
3037	2772	private static function redirect_after_submit( $args ) {
3038	2773	add_filter( 'frm_use_wpautop', '__return_false' );
		@@ -3046,10 +2781,11 @@
3046	2781	FrmEntriesController::delete_entry_before_redirect( $success_url, $args['form'], $args );
3047	2782
3048	2783	add_filter( 'frm_redirect_url', 'FrmEntriesController::prepare_redirect_url' );
3049	2784	$success_url = apply_filters( 'frm_redirect_url', $success_url, $args['form'], $args );
3050		- $doing_ajax = FrmAppHelper::doing_ajax();
3051	2785
	2786	+ $doing_ajax = FrmAppHelper::doing_ajax();
	2787	+
3052	2788	if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) {
3053	2789	// Is AJAX submit and there is just one Redirect action runs.
3054	2790	echo json_encode( self::get_ajax_redirect_response_data( $args + compact( 'success_url' ) ) );
3055	2791	wp_die();
		@@ -3098,9 +2834,8 @@
3098	2834	*
3099	2835	* @since 6.3.1
3100	2836	*
3101	2837	* @param array $args See {@see FrmFormsController::run_success_action()}.
3102		- *
3103	2838	* @return array
3104	2839	*/
3105	2840	private static function get_ajax_redirect_response_data( $args ) {
3106	2841	$response_data = array(
		@@ -3123,9 +2858,8 @@
3123	2858	$args['message'] = FrmOnSubmitHelper::get_default_new_tab_msg();
3124	2859
3125	2860	$args['form']->options['success_msg'] = $args['message'];
3126	2861	$args['form']->options['edit_msg'] = $args['message'];
3127		-
3128	2862	if ( ! isset( $args['fields'] ) ) {
3129	2863	$args['fields'] = FrmField::get_all_for_form( $args['form']->id );
3130	2864	}
3131	2865
		@@ -3177,15 +2911,13 @@
3177	2911	add_filter( 'frm_use_wpautop', '__return_true' );
3178	2912
3179	2913	echo FrmAppHelper::maybe_kses( $redirect_msg ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
3180	2914	echo '<script>';
3181		-
3182	2915	if ( empty( $args['doing_ajax'] ) ) {
3183	2916	// Not AJAX submit, delay JS until window.load.
3184	2917	echo 'window.onload=function(){';
3185	2918	}
3186	2919	echo 'setTimeout(function(){' . $redirect_js . '}, ' . intval( $delay_time ) . ');'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
3187		-
3188	2920	if ( empty( $args['doing_ajax'] ) ) {
3189	2921	echo '};';
3190	2922	}
3191	2923	echo '</script>';
		@@ -3198,16 +2930,13 @@
3198	2930	* @param string $success_msg
3199	2931	* @param array $args
3200	2932	*/
3201	2933	private static function get_redirect_message( $success_url, $success_msg, $args ) {
3202		- $success_msg = apply_filters( 'frm_content', $success_msg, $args['form'], $args['entry_id'] );
3203		- $success_msg = do_shortcode( FrmAppHelper::use_wpautop( $success_msg ) );
3204		-
3205		- // phpcs:disable Generic.WhiteSpace.ScopeIndent
3206		- $redirect_msg = '<div class="' . esc_attr( FrmFormsHelper::get_form_style_class( $args['form'] ) ) . '"><div class="frm-redirect-msg" role="status">' . $success_msg . '<br/>' . // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
	2934	+ $success_msg = apply_filters( 'frm_content', $success_msg, $args['form'], $args['entry_id'] );
	2935	+ $success_msg = do_shortcode( FrmAppHelper::use_wpautop( $success_msg ) );
	2936	+ $redirect_msg = '<div class="' . esc_attr( FrmFormsHelper::get_form_style_class( $args['form'] ) ) . '"><div class="frm-redirect-msg" role="status">' . $success_msg . '<br/>' .
3207	2937	self::get_redirect_fallback_message( $success_url, $args ) .
3208	2938	'</div></div>';
3209		- // phpcs:enable Generic.WhiteSpace.ScopeIndent
3210	2939
3211	2940	$redirect_args = array(
3212	2941	'entry_id' => $args['entry_id'],
3213	2942	'form_id' => $args['form']->id,
		@@ -3223,14 +2952,12 @@
3223	2952	* @since 6.3.1
3224	2953	*
3225	2954	* @param string $success_url Redirect URL.
3226	2955	* @param array $args Contains `form` object.
3227		- *
3228	2956	* @return string
3229	2957	*/
3230	2958	private static function get_redirect_fallback_message( $success_url, $args ) {
3231	2959	$target = '';
3232		-
3233	2960	if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
3234	2961	$target = ' target="_blank"';
3235	2962	}
3236	2963
		@@ -3245,12 +2972,8 @@
3245	2972	/**
3246	2973	* Prepare to show the success message and empty form after submit
3247	2974	*
3248	2975	* @since 2.05
3249		- *
3250		- * @param array $atts
3251		- *
3252		- * @return void
3253	2976	*/
3254	2977	public static function show_message_after_save( $atts ) {
3255	2978	$atts['message'] = self::prepare_submit_message( $atts['form'], $atts['entry_id'], $atts );
3256	2979
		@@ -3256,9 +2979,8 @@
3256	2979
3257	2980	if ( ! isset( $atts['form']->options['show_form'] ) || $atts['form']->options['show_form'] ) {
3258	2981	if ( isset( $atts['action'] ) && 'update' === $atts['action'] && is_callable( array( 'FrmProEntriesController', 'show_front_end_form_with_entry' ) ) ) {
3259	2982	$entry = FrmEntry::getOne( $atts['entry_id'] );
3260		-
3261	2983	if ( $entry ) {
3262	2984	// This is copied from the Pro plugin.
3263	2985	$atts['conf_message'] = FrmProEntriesController::confirmation( 'message', $atts['form'], $atts['form']->options, $entry->id, $atts );
3264	2986	$atts['show_form'] = FrmProEntriesController::is_form_displayed_after_edit( $atts['form'] );
		@@ -3275,12 +2997,8 @@
3275	2997	/**
3276	2998	* Show an empty form
3277	2999	*
3278	3000	* @since 2.05
3279		- *
3280		- * @param array $args
3281		- *
3282		- * @return void
3283	3001	*/
3284	3002	private static function show_form_after_submit( $args ) {
3285	3003	self::fill_atts_for_form_display( $args );
3286	3004
		@@ -3299,11 +3017,12 @@
3299	3017	}
3300	3018	unset( $args );
3301	3019
3302	3020	$include_form_tag = apply_filters( 'frm_include_form_tag', true, $form );
3303		- $frm_settings = FrmAppHelper::get_settings();
3304		- $submit = $form->options['submit_value'] ?? $frm_settings->submit_value;
3305	3021
	3022	+ $frm_settings = FrmAppHelper::get_settings();
	3023	+ $submit = isset( $form->options['submit_value'] ) ? $form->options['submit_value'] : $frm_settings->submit_value;
	3024	+
3306	3025	global $frm_vars;
3307	3026	self::maybe_load_css( $form, $values['custom_style'], $frm_vars['load_css'] );
3308	3027
3309	3028	$message_placement = self::message_placement( $form, $message );
		@@ -3311,36 +3030,25 @@
3311	3030	include FrmAppHelper::plugin_path() . '/classes/views/frm-entries/new.php';
3312	3031	}
3313	3032
3314	3033	/**
3315		- * Gets message placement.
3316		- *
3317	3034	* @since 4.05.02
3318		- * @since 6.26 This method changed from `private` to `public`.
3319		- *
3320		- * @param object $form Form object.
3321		- * @param string $message The message.
3322		- *
3323		- * @return string Accepts 'before', 'after', or 'submit'.
	3035	+ * @return string - 'before', 'after', or 'submit'
3324	3036	*/
3325		- public static function message_placement( $form, $message ) {
	3037	+ private static function message_placement( $form, $message ) {
3326	3038	$place = 'before';
3327	3039
3328	3040	if ( $message && isset( $form->options['form_class'] ) ) {
3329		- if ( str_contains( $form->options['form_class'], 'frm_below_success' ) ) {
	3041	+ if ( strpos( $form->options['form_class'], 'frm_below_success' ) !== false ) {
3330	3042	$place = 'after';
3331		- } elseif ( str_contains( $form->options['form_class'], 'frm_inline_success' ) ) {
	3043	+ } elseif ( strpos( $form->options['form_class'], 'frm_inline_success' ) !== false ) {
3332	3044	$place = 'submit';
3333	3045	}
3334	3046	}
3335	3047
3336	3048	/**
3337		- * Filter the message placement.
3338		- *
3339	3049	* @since 4.05.02
3340		- *
3341		- * @param string $place Accepts 'before', 'after', or 'submit'.
3342		- * @param array $args Args.
	3050	+ * @return string - 'before' or 'after'
3343	3051	*/
3344	3052	return apply_filters( 'frm_message_placement', $place, compact( 'form', 'message' ) );
3345	3053	}
3346	3054
		@@ -3347,12 +3055,8 @@
3347	3055	/**
3348	3056	* Get all the values needed on the new.php entry page
3349	3057	*
3350	3058	* @since 2.05
3351		- *
3352		- * @param array $args
3353		- *
3354		- * @return void
3355	3059	*/
3356	3060	private static function fill_atts_for_form_display( &$args ) {
3357	3061	if ( ! isset( $args['title'] ) && isset( $args['show_title'] ) ) {
3358	3062	$args['title'] = $args['show_title'];
		@@ -3377,12 +3081,8 @@
3377	3081	/**
3378	3082	* Show the success message without the form
3379	3083	*
3380	3084	* @since 2.05
3381		- *
3382		- * @param array $atts
3383		- *
3384		- * @return void
3385	3085	*/
3386	3086	private static function show_lone_success_message( $atts ) {
3387	3087	global $frm_vars;
3388	3088	$values = FrmEntriesHelper::setup_new_vars( $atts['fields'], $atts['form'], true );
		@@ -3388,12 +3088,13 @@
3388	3088	$values = FrmEntriesHelper::setup_new_vars( $atts['fields'], $atts['form'], true );
3389	3089	self::maybe_load_css( $atts['form'], $values['custom_style'], $frm_vars['load_css'] );
3390	3090
3391	3091	$include_extra_container = 'frm_forms' . FrmFormsHelper::get_form_style_class( $values );
3392		- $errors = array();
3393		- $form = $atts['form'];
3394		- $message = $atts['message'];
3395	3092
	3093	+ $errors = array();
	3094	+ $form = $atts['form'];
	3095	+ $message = $atts['message'];
	3096	+
3396	3097	include FrmAppHelper::plugin_path() . '/classes/views/frm-entries/errors.php';
3397	3098	}
3398	3099
3399	3100	/**
		@@ -3401,20 +3102,19 @@
3401	3102	*
3402	3103	* @since 2.05
3403	3104	* @since 6.0.x Added the third parameter.
3404	3105	*
3405		- * @param object $form Form object.
3406		- * @param int|string $entry_id Entry ID.
3407		- * @param array $args See {@see FrmFormsController::run_success_action()}.
3408		- *
	3106	+ * @param object $form Form object.
	3107	+ * @param int $entry_id Entry ID.
	3108	+ * @param array $args See {@see FrmFormsController::run_success_action()}.
3409	3109	* @return string
3410	3110	*/
3411	3111	private static function prepare_submit_message( $form, $entry_id, $args = array() ) {
3412	3112	$frm_settings = FrmAppHelper::get_settings( array( 'current_form' => $form->id ) );
3413		- $opt = $args['success_opt'] ?? 'success';
	3113	+ $opt = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
3414	3114
3415	3115	if ( $entry_id && is_numeric( $entry_id ) ) {
3416		- $message = $form->options[ $opt . '_msg' ] ?? $frm_settings->success_msg;
	3116	+ $message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
3417	3117	$class = 'frm_message';
3418	3118	} else {
3419	3119	$message = $frm_settings->failed_msg;
3420	3120	$class = FrmFormsHelper::form_error_class();
		@@ -3431,9 +3131,9 @@
3431	3131	public static function front_head() {
3432	3132	$version = FrmAppHelper::plugin_version();
3433	3133	$suffix = FrmAppHelper::js_suffix();
3434	3134
3435		- if ( $suffix && self::has_combo_js_file() ) {
	3135	+ if ( ! empty( $suffix ) && self::has_combo_js_file() ) {
3436	3136	wp_register_script( 'formidable', FrmAppHelper::plugin_url() . '/js/frm.min.js', array( 'jquery' ), $version, true );
3437	3137	} else {
3438	3138	wp_register_script( 'formidable', FrmAppHelper::plugin_url() . "/js/formidable{$suffix}.js", array( 'jquery' ), $version, true );
3439	3139	}
		@@ -3440,9 +3140,9 @@
3440	3140
3441	3141	add_filter( 'script_loader_tag', 'FrmFormsController::defer_script_loading', 10, 2 );
3442	3142
3443	3143	if ( FrmAppHelper::is_admin() ) {
3444		- // Don't load this in back-end
	3144	+ // don't load this in back-end
3445	3145	return;
3446	3146	}
3447	3147
3448	3148	FrmAppHelper::localize_script( 'front' );
		@@ -3455,15 +3155,8 @@
3455	3155	public static function has_combo_js_file() {
3456	3156	return is_readable( FrmAppHelper::plugin_path() . '/js/frm.min.js' );
3457	3157	}
3458	3158
3459		- /**
3460		- * @param object $form
3461		- * @param int|string $this_load
3462		- * @param bool $global_load
3463		- *
3464		- * @return void
3465		- */
3466	3159	public static function maybe_load_css( $form, $this_load, $global_load ) {
3467	3160	$load_css = FrmForm::is_form_loaded( $form, $this_load, $global_load );
3468	3161
3469	3162	if ( ! $load_css ) {
		@@ -3493,9 +3186,8 @@
3493	3186	return;
3494	3187	}
3495	3188
3496	3189	global $wp_styles;
3497		-
3498	3190	if ( is_array( $wp_styles->queue ) && in_array( 'formidable', $wp_styles->queue, true ) ) {
3499	3191	wp_print_styles( 'formidable' );
3500	3192	}
3501	3193	}
		@@ -3510,52 +3202,32 @@
3510	3202	private static function should_load_late() {
3511	3203	return ! function_exists( 'aioseo' );
3512	3204	}
3513	3205
3514		- /**
3515		- * @param string $tag
3516		- * @param string $handle
3517		- *
3518		- * @return string
3519		- */
3520	3206	public static function defer_script_loading( $tag, $handle ) {
3521		- if ( 'captcha-api' === $handle && ! str_contains( $tag, 'defer' ) ) {
3522		- return str_replace( ' src', ' defer="defer" async="async" src', $tag );
	3207	+ if ( 'captcha-api' == $handle && ! strpos( $tag, 'defer' ) ) {
	3208	+ $tag = str_replace( ' src', ' defer="defer" async="async" src', $tag );
3523	3209	}
3524	3210
3525	3211	return $tag;
3526	3212	}
3527	3213
3528		- /**
3529		- * @param string $location
3530		- *
3531		- * @return void
3532		- */
3533	3214	public static function footer_js( $location = 'footer' ) {
3534	3215	global $frm_vars;
3535	3216
3536	3217	FrmStylesController::enqueue_css();
3537	3218
3538		- if ( FrmAppHelper::is_admin() || $location === 'header' || empty( $frm_vars['forms_loaded'] ) ) {
3539		- return;
	3219	+ if ( ! FrmAppHelper::is_admin() && $location !== 'header' && ! empty( $frm_vars['forms_loaded'] ) ) {
	3220	+ // load formidable js
	3221	+ wp_enqueue_script( 'formidable' );
3540	3222	}
3541		-
3542		- // Load formidable js
3543		- wp_enqueue_script( 'formidable' );
3544		-
3545		- FrmHoneypot::maybe_print_honeypot_js();
3546	3223	}
3547	3224
3548	3225	/**
3549	3226	* @since 2.0.8
3550		- *
3551		- * @param array $atts
3552		- * @param string $content
3553		- *
3554		- * @return void
3555	3227	*/
3556	3228	private static function maybe_minimize_form( $atts, &$content ) {
3557		- // Check if minimizing is turned on
	3229	+ // check if minimizing is turned on
3558	3230	if ( self::is_minification_on( $atts ) ) {
3559	3231	$content = str_replace( array( "\r\n", "\r", "\n", "\t", ' ' ), '', $content );
3560	3232	}
3561	3233	}
		@@ -3561,11 +3233,8 @@
3561	3233	}
3562	3234
3563	3235	/**
3564	3236	* @since 2.0.8
3565		- *
3566		- * @param array $atts
3567		- *
3568	3237	* @return bool
3569	3238	*/
3570	3239	private static function is_minification_on( $atts ) {
3571	3240	return ! empty( $atts['minimize'] );
		@@ -3577,13 +3246,11 @@
3577	3246	* @return void
3578	3247	*/
3579	3248	public static function landing_page_preview_option() {
3580	3249	$dir = apply_filters( 'frm_landing_page_preview_option', false );
3581		-
3582	3250	if ( false === $dir || ! file_exists( $dir . 'landing-page-preview-option.php' ) ) {
3583	3251	$dir = self::get_form_views_path();
3584	3252	}
3585		-
3586	3253	include $dir . 'landing-page-preview-option.php';
3587	3254	}
3588	3255
3589	3256	/**
		@@ -3609,15 +3276,13 @@
3609	3276
3610	3277	check_ajax_referer( 'frm_ajax', 'nonce' );
3611	3278
3612	3279	$type = FrmAppHelper::get_post_param( 'type', '', 'sanitize_text_field' );
3613		-
3614	3280	if ( ! $type || ! in_array( $type, array( 'form', 'view' ), true ) ) {
3615	3281	die( 0 );
3616	3282	}
3617	3283
3618	3284	$object_id = FrmAppHelper::get_post_param( 'object_id', '', 'absint' );
3619		-
3620	3285	if ( ! $object_id ) {
3621	3286	die( 0 );
3622	3287	}
3623	3288
		@@ -3629,15 +3294,13 @@
3629	3294	$postarr['post_content'] = apply_filters( 'frm_create_page_with_' . $type . '_shortcode_content', '', $object_id );
3630	3295	}
3631	3296
3632	3297	$name = FrmAppHelper::get_post_param( 'name', '', 'sanitize_text_field' );
3633		-
3634	3298	if ( $name ) {
3635	3299	$postarr['post_title'] = $name;
3636	3300	}
3637	3301
3638	3302	$success = wp_insert_post( $postarr );
3639		-
3640	3303	if ( ! is_numeric( $success ) || ! $success ) {
3641	3304	die( 0 );
3642	3305	}
3643	3306
		@@ -3651,9 +3314,8 @@
3651	3314	/**
3652	3315	* @since 5.3
3653	3316	*
3654	3317	* @param int $form_id
3655		- *
3656	3318	* @return string
3657	3319	*/
3658	3320	private static function get_page_shortcode_content_for_form( $form_id ) {
3659	3321	$shortcode = '[formidable id="' . $form_id . '"]';
		@@ -3695,14 +3357,23 @@
3695	3357	}
3696	3358
3697	3359	/**
3698	3360	* @deprecated 4.0
	3361	+ */
	3362	+ public static function create( $values = array() ) {
	3363	+ _deprecated_function( __METHOD__, '4.0', 'FrmFormsController::update' );
	3364	+ self::update( $values );
	3365	+ }
	3366	+
	3367	+ /**
	3368	+ * Education for premium features.
3699	3369	*
3700		- * @param array $values
	3370	+ * @since 4.05
	3371	+ * @deprecated 6.16.3
3701	3372	*
3702	3373	* @return void
3703	3374	*/
3704		- public static function create( $values = array() ) {
3705		- _deprecated_function( __METHOD__, '4.0', 'FrmFormsController::update' );
3706		- self::update( $values );
	3375	+ public static function add_form_style_tab_options() {
	3376	+ _deprecated_function( __METHOD__, '6.16.3' );
	3377	+ include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/add_form_style_options.php';
3707	3378	}
3708	3379	}