PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.20
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.20
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmFormsController.php +259 -589 6.306.20 View file →
@@ -26,13 +26,11 @@
26 26 private static $formidable_tinymce_button;
27 27
28 28 public static function menu() {
29 29 $menu_label = __( 'Forms', 'formidable' );
30 -
31 30 if ( ! FrmAppHelper::pro_is_installed() ) {
32 31 $menu_label .= ' (Lite)';
33 32 }
34 -
35 33 add_submenu_page( 'formidable', 'Formidable | ' . $menu_label, $menu_label, 'frm_view_forms', 'formidable', 'FrmFormsController::route' );
36 34
37 35 self::maybe_load_listing_hooks();
38 36 }
@@ -66,12 +64,12 @@
66 64 */
67 65 public static function logic_tip() {
68 66 $images_url = FrmAppHelper::plugin_url() . '/images/';
69 67 $data_message = __( 'Only show the fields you need and create branching forms. Upgrade to get conditional logic and question branching.', 'formidable' );
70 - $data_message .= ' <img src="' . esc_url( $images_url ) . '/survey-logic.png" srcset="' . esc_url( $images_url ) . 'survey-logic@2x.png 2x" alt="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '"/>'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
71 - echo '<a href="javascript:void(0)" class="frm_noallow frm_show_upgrade frm_add_logic_link frm-collapsed frm-flex-justify" data-upgrade="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '" data-message="' . esc_attr( $data_message ) . '" data-medium="builder" data-content="logic">'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
68 + $data_message .= ' <img src="' . esc_url( $images_url ) . '/survey-logic.png" srcset="' . esc_url( $images_url ) . 'survey-logic@2x.png 2x" alt="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '"/>';
69 + echo '<a href="javascript:void(0)" class="frm_noallow frm_show_upgrade frm_add_logic_link frm-collapsed frm-flex-justify" data-upgrade="' . esc_attr__( 'Conditional Logic options', 'formidable' ) . '" data-message="' . esc_attr( $data_message ) . '" data-medium="builder" data-content="logic">';
72 70 esc_html_e( 'Conditional Logic', 'formidable' );
73 - FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown8_icon', array( 'aria-hidden' => 'true' ) );
71 + FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
74 72 echo '</a>';
75 73 }
76 74
77 75 /**
@@ -78,15 +76,12 @@
78 76 * By default, Divi processes form shortcodes on the edit post page.
79 77 * Now that won't do.
80 78 *
81 79 * @since 3.01
82 - *
83 - * @param array $shortcodes List of shortcodes to process.
84 - *
85 - * @return array
86 80 */
87 81 public static function prevent_divi_conflict( $shortcodes ) {
88 82 $shortcodes[] = 'formidable';
83 +
89 84 return $shortcodes;
90 85 }
91 86
92 87 /**
@@ -97,14 +92,12 @@
97 92
98 93 $message = '';
99 94 $params = FrmForm::list_page_params();
100 95 $errors = self::process_bulk_form_actions( array() );
101 -
102 96 if ( isset( $errors['message'] ) ) {
103 97 $message = $errors['message'];
104 98 unset( $errors['message'] );
105 99 }
106 -
107 100 $errors = apply_filters( 'frm_admin_list_form_action', $errors );
108 101
109 102 self::display_forms_list( $params, $message, $errors );
110 103 }
@@ -114,14 +107,12 @@
114 107 *
115 108 * @since 2.02.11
116 109 *
117 110 * @param int|object $form
118 - *
119 111 * @return void
120 112 */
121 113 private static function create_default_email_action( $form ) {
122 114 FrmForm::maybe_get_form( $form );
123 -
124 115 if ( ! is_object( $form ) ) {
125 116 return;
126 117 }
127 118
@@ -126,17 +117,15 @@
126 117 }
127 118
128 119 $create_email = apply_filters( 'frm_create_default_email_action', true, $form );
129 120
130 - if ( ! $create_email ) {
131 - return;
121 + if ( $create_email ) {
122 + /**
123 + * @var FrmFormAction
124 + */
125 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
126 + $action_control->create( $form->id );
132 127 }
133 -
134 - /**
135 - * @var FrmFormAction
136 - */
137 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
138 - $action_control->create( $form->id );
139 128 }
140 129
141 130 /**
142 131 * Create the default On submit action
@@ -143,14 +132,12 @@
143 132 *
144 133 * @since 6.0.0
145 134 *
146 135 * @param int|object $form Form object or ID.
147 - *
148 136 * @return void
149 137 */
150 138 private static function create_default_on_submit_action( $form ) {
151 139 FrmForm::maybe_get_form( $form );
152 -
153 140 if ( ! is_object( $form ) ) {
154 141 return;
155 142 }
156 143
@@ -163,17 +150,15 @@
163 150 * @param object $form Form object.
164 151 */
165 152 $create = apply_filters( 'frm_create_default_on_submit_action', true, $form );
166 153
167 - if ( ! $create ) {
168 - return;
154 + if ( $create ) {
155 + /**
156 + * @var FrmFormAction
157 + */
158 + $action_control = FrmFormActionsController::get_form_actions( FrmOnSubmitAction::$slug );
159 + $action_control->create( $form->id );
169 160 }
170 -
171 - /**
172 - * @var FrmFormAction
173 - */
174 - $action_control = FrmFormActionsController::get_form_actions( FrmOnSubmitAction::$slug );
175 - $action_control->create( $form->id );
176 161 }
177 162
178 163 /**
179 164 * Creates submit button field.
@@ -180,14 +165,12 @@
180 165 *
181 166 * @since 6.9
182 167 *
183 168 * @param int|object $form Form ID or object.
184 - *
185 169 * @return void
186 170 */
187 171 private static function create_submit_button_field( $form ) {
188 172 FrmForm::maybe_get_form( $form );
189 -
190 173 if ( ! is_object( $form ) ) {
191 174 return;
192 175 }
193 176
@@ -210,10 +193,8 @@
210 193 );
211 194 }
212 195
213 196 /**
214 - * @param array|false $values
215 - *
216 197 * @return void
217 198 */
218 199 public static function edit( $values = false ) {
219 200 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -225,9 +206,8 @@
225 206
226 207 /**
227 208 * @param mixed $id
228 209 * @param string $message
229 - *
230 210 * @return void
231 211 */
232 212 public static function settings( $id = false, $message = '' ) {
233 213 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -255,9 +235,10 @@
255 235 FrmAppController::show_error_modal( $error_args );
256 236 return;
257 237 }
258 238
259 - $id = FrmAppHelper::get_param( 'id', '', 'get', 'absint' );
239 + $id = FrmAppHelper::get_param( 'id', '', 'get', 'absint' );
240 +
260 241 $errors = FrmForm::validate( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
261 242 $warnings = FrmFormsHelper::check_for_warnings( $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
262 243
263 244 if ( count( $errors ) > 0 ) {
@@ -266,14 +247,13 @@
266 247 }
267 248
268 249 do_action( 'frm_before_update_form_settings', $id );
269 250
270 - $antispam_was_on = self::antispam_was_on( $id ); // phpcs:ignore Formidable.CodeAnalysis.InlineSingleUseVariable
251 + $antispam_was_on = self::antispam_was_on( $id );
271 252
272 253 FrmForm::update( $id, $_POST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
273 254
274 255 $antispam_is_on = ! empty( $_POST['options']['antispam'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
275 -
276 256 if ( $antispam_is_on !== $antispam_was_on ) {
277 257 FrmAntiSpam::clear_caches();
278 258 }
279 259
@@ -283,9 +263,8 @@
283 263 }
284 264
285 265 /**
286 266 * @param int $form_id
287 - *
288 267 * @return bool
289 268 */
290 269 private static function antispam_was_on( $form_id ) {
291 270 $form = FrmForm::getOne( $form_id );
@@ -292,14 +271,12 @@
292 271 return ! empty( $form->options['antispam'] );
293 272 }
294 273
295 274 /**
296 - * @param array $values
297 - *
298 275 * @return void
299 276 */
300 277 public static function update( $values = array() ) {
301 - if ( ! $values ) {
278 + if ( empty( $values ) ) {
302 279 $values = $_POST; // phpcs:ignore WordPress.Security.NonceVerification.Missing
303 280 }
304 281
305 282 // Set radio button and checkbox meta equal to "other" value.
@@ -308,9 +285,8 @@
308 285 }
309 286
310 287 $errors = FrmForm::validate( $values );
311 288 $permission_error = FrmAppHelper::permission_nonce_error( 'frm_edit_forms', 'frm_save_form', 'frm_save_form_nonce' );
312 -
313 289 if ( $permission_error !== false ) {
314 290 $errors['form'] = $permission_error;
315 291 }
316 292
@@ -329,9 +305,9 @@
329 305 if ( self::is_too_long( $values ) ) {
330 306 $message .= '<br/> ' . sprintf(
331 307 /* translators: %1$s: Start link HTML, %2$s: end link HTML */
332 308 __( 'However, your form is very long and may be %1$sreaching server limits%2$s.', 'formidable' ),
333 - '<a href="' . esc_url( self::get_form_too_long_docs_url() ) . '" target="_blank" rel="noopener">',
309 + '<a href="https://formidableforms.com/knowledgebase/i-have-a-long-form-why-did-the-options-at-the-end-of-the-form-stop-saving/?utm_source=WordPress&utm_medium=builder&utm_campaign=liteplugin" target="_blank" rel="noopener">',
334 310 '</a>'
335 311 );
336 312 }
337 313
@@ -342,32 +318,17 @@
342 318 self::get_edit_vars( $id, array(), $message );
343 319 }
344 320
345 321 /**
346 - * @since 6.25.1
347 - *
348 - * @return string
349 - */
350 - private static function get_form_too_long_docs_url() {
351 - $utm = array(
352 - 'campaign' => 'builder',
353 - 'content' => 'form-too-long',
354 - );
355 - return FrmAppHelper::admin_upgrade_link( $utm, 'knowledgebase/i-have-a-long-form-why-did-the-options-at-the-end-of-the-form-stop-saving/' );
356 - }
357 -
358 - /**
359 322 * Remove the draft flag from any new fields from this current session.
360 323 *
361 324 * @since 6.8
362 325 *
363 326 * @param int $form_id
364 - *
365 327 * @return void
366 328 */
367 329 private static function maybe_remove_draft_option_from_fields( $form_id ) {
368 330 $draft_field_ids_csv = FrmAppHelper::get_post_param( 'draft_fields', '', 'sanitize_text_field' );
369 -
370 331 if ( ! $draft_field_ids_csv ) {
371 332 // If the draft_fields input is empty there are no new fields in the session.
372 333 return;
373 334 }
@@ -372,9 +333,8 @@
372 333 return;
373 334 }
374 335
375 336 $draft_field_ids = array_filter( explode( ',', $draft_field_ids_csv ), 'is_numeric' );
376 -
377 337 if ( ! $draft_field_ids ) {
378 338 // Exit early if the draft fields input is invalid. It should be a CSV of integer values.
379 339 return;
380 340 }
@@ -379,9 +339,8 @@
379 339 return;
380 340 }
381 341
382 342 $draft_field_rows = FrmFieldsHelper::get_draft_field_results( $form_id, $draft_field_ids );
383 -
384 343 foreach ( $draft_field_rows as $row ) {
385 344 $row->field_options['draft'] = 0;
386 345 FrmField::update( $row->id, array( 'field_options' => $row->field_options ) );
387 346 }
@@ -393,10 +352,8 @@
393 352 * were likely not saved either.
394 353 *
395 354 * @since 3.06.01
396 355 *
397 - * @param array $values
398 - *
399 356 * @return bool
400 357 */
401 358 private static function is_too_long( $values ) {
402 359 return empty( $values['frm_end'] );
@@ -432,9 +389,8 @@
432 389 * @return string|null
433 390 */
434 391 public static function page_preview() {
435 392 $params = FrmForm::list_page_params();
436 -
437 393 if ( ! $params['form'] || is_numeric( $params['form'] ) ) {
438 394 return null;
439 395 }
440 396
@@ -440,9 +396,8 @@
440 396
441 397 self::maybe_block_preview( $params['form'] );
442 398
443 399 $form = FrmForm::getOne( $params['form'] );
444 -
445 400 if ( ! $form ) {
446 401 return null;
447 402 }
448 403
@@ -455,9 +410,8 @@
455 410 * @return void
456 411 */
457 412 public static function show_page_preview() {
458 413 $preview = self::page_preview();
459 -
460 414 if ( is_null( $preview ) ) {
461 415 wp_die(
462 416 '<h1>' . esc_html__( 'Form key is invalid', 'formidable' ) . '</h1>',
463 417 '<p>' . esc_html__( 'Form key is invalid', 'formidable' ) . '</p>',
@@ -480,16 +434,9 @@
480 434
481 435 // print_emoji_styles is deprecated.
482 436 remove_action( 'wp_print_styles', 'print_emoji_styles' );
483 437
484 - if ( FrmTestModeController::should_add_test_mode_container() ) {
485 - do_action( 'frm_test_mode_init' );
486 - add_action( 'wp_enqueue_scripts', 'FrmTestModeController::register_and_enqueue_required_scripts' );
487 - add_filter( 'frm_filter_final_form', 'FrmTestModeController::maybe_add_test_mode_container', 99 );
488 - }
489 -
490 438 $include_theme = FrmAppHelper::get_param( 'theme', '', 'get', 'absint' );
491 -
492 439 if ( $include_theme ) {
493 440 self::set_preview_query();
494 441 self::load_theme_preview();
495 442 } else {
@@ -512,9 +459,8 @@
512 459 'post_type' => 'page',
513 460 );
514 461
515 462 $page_for_posts = get_option( 'page_for_posts' );
516 -
517 463 if ( is_numeric( $page_for_posts ) ) {
518 464 // Avoid querying for the "Posts Page" or "Blog Page" so we don't display 10 forms.
519 465 $page_query['post__not_in'] = array( $page_for_posts );
520 466 }
@@ -519,15 +465,13 @@
519 465 $page_query['post__not_in'] = array( $page_for_posts );
520 466 }
521 467
522 468 $random_page = get_posts( $page_query );
523 -
524 469 if ( ! $random_page ) {
525 470 return;
526 471 }
527 472
528 473 $random_page = reset( $random_page );
529 -
530 474 if ( ! is_a( $random_page, 'WP_Post' ) ) {
531 475 // The return type can also be int.
532 476 return;
533 477 }
@@ -549,9 +493,8 @@
549 493 *
550 494 * @since 5.5.2
551 495 *
552 496 * @param WP_Post $page The page object.
553 - *
554 497 * @return void
555 498 */
556 499 private static function set_post_global( $page ) {
557 500 global $post;
@@ -570,16 +513,14 @@
570 513 add_action( 'loop_no_results', 'FrmFormsController::show_page_preview' );
571 514 add_filter( 'is_active_sidebar', '__return_false' );
572 515 FrmStylesController::enqueue_css( 'enqueue', true );
573 516
574 - if ( false !== get_template_part( 'page' ) ) {
575 - return;
517 + if ( false === get_template_part( 'page' ) ) {
518 + if ( function_exists( 'wp_is_block_theme' ) && wp_is_block_theme() ) {
519 + add_filter( 'body_class', 'FrmFormsController::preview_block_theme_body_classnames' );
520 + }
521 + self::fallback_when_page_template_part_is_not_supported_by_theme();
576 522 }
577 -
578 - if ( function_exists( 'wp_is_block_theme' ) && wp_is_block_theme() ) {
579 - add_filter( 'body_class', 'FrmFormsController::preview_block_theme_body_classnames' );
580 - }
581 - self::fallback_when_page_template_part_is_not_supported_by_theme();
582 523 }
583 524
584 525 /**
585 526 * Add padding to the body for block themes.
@@ -586,9 +527,8 @@
586 527 *
587 528 * @since 6.5.2
588 529 *
589 530 * @param array $classes The body classes list.
590 - *
591 531 * @return array
592 532 */
593 533 public static function preview_block_theme_body_classnames( $classes ) {
594 534 $classes[] = 'has-global-padding';
@@ -601,27 +541,21 @@
601 541 *
602 542 * @return void
603 543 */
604 544 private static function fallback_when_page_template_part_is_not_supported_by_theme() {
605 - if ( ! have_posts() ) {
606 - return;
607 - }
545 + if ( have_posts() ) {
546 + the_post();
547 + self::get_template( 'header' );
608 548
609 - the_post();
610 - self::get_template( 'header' );
549 + // add some generic class names to the container to add some natural padding to the content.
550 + // .entry-content catches the WordPress TwentyTwenty theme.
551 + // .container catches Customizr content.
552 + echo '<div class="container entry-content">';
553 + the_content();
554 + echo '</div>';
611 555
612 - // Add some generic class names to the container to add some natural padding to the content.
613 - // .entry-content catches the WordPress TwentyTwenty theme.
614 - // .container catches Customizr content.
615 - echo '<div class="container entry-content">';
616 - the_content();
617 - echo '</div>';
618 -
619 - // Prevent extra unexpected forms in the footer.
620 - // For some reason this happens in the Twenty Twenty Five theme.
621 - add_filter( 'frm_filter_final_form', '__return_empty_string' );
622 -
623 - self::get_template( 'footer' );
556 + self::get_template( 'footer' );
557 + }
624 558 }
625 559
626 560 /**
627 561 * Calls core function to get a template part if it doesn't cause deprecation warnings. Otherwise skips the deprecation function call
@@ -627,11 +561,9 @@
627 561 * Calls core function to get a template part if it doesn't cause deprecation warnings. Otherwise skips the deprecation function call
628 562 * and renders required html fragments calling required functions.
629 563 *
630 564 * @since 6.7.1
631 - *
632 565 * @param string $template
633 - *
634 566 * @return void
635 567 */
636 568 private static function get_template( $template ) {
637 569 if ( self::should_try_getting_template( $template ) ) {
@@ -652,11 +584,9 @@
652 584 /**
653 585 * Returns true if calling a template function doesn't trigger deprecation warnings.
654 586 *
655 587 * @since 6.7.1
656 - *
657 588 * @param string $template
658 - *
659 589 * @return bool
660 590 */
661 591 private static function should_try_getting_template( $template ) {
662 592 $stylesheet_path = get_stylesheet_directory();
@@ -670,15 +600,15 @@
670 600 /**
671 601 * Set the page title for the theme preview page
672 602 *
673 603 * @since 3.0
674 - *
675 - * @param string $title
676 - *
677 - * @return string
678 604 */
679 605 public static function preview_page_title( $title ) {
680 - return in_the_loop() ? self::preview_title( $title ) : $title;
606 + if ( in_the_loop() ) {
607 + $title = self::preview_title( $title );
608 + }
609 +
610 + return $title;
681 611 }
682 612
683 613 /**
684 614 * Set the page title for the theme preview page.
@@ -685,9 +615,8 @@
685 615 *
686 616 * @since 3.0
687 617 *
688 618 * @param string $title
689 - *
690 619 * @return string
691 620 */
692 621 public static function preview_title( $title ) {
693 622 return __( 'Form Preview', 'formidable' );
@@ -698,9 +627,8 @@
698 627 *
699 628 * @since 3.0
700 629 *
701 630 * @param string $content
702 - *
703 631 * @return string
704 632 */
705 633 public static function preview_content( $content ) {
706 634 if ( in_the_loop() ) {
@@ -716,10 +644,8 @@
716 644 * @since 3.0
717 645 */
718 646 private static function load_direct_preview() {
719 647 $key = FrmAppHelper::simple_get( 'form', 'sanitize_title' );
720 -
721 - // phpcs:ignore Universal.Operators.StrictComparisons
722 648 if ( $key == '' ) {
723 649 $key = FrmAppHelper::get_post_param( 'form', '', 'sanitize_title' );
724 650 }
725 651
@@ -734,9 +660,8 @@
734 660
735 661 self::maybe_block_preview( $key );
736 662
737 663 $form = FrmForm::getAll( array( 'form_key' => $key ), '', 1 );
738 -
739 664 if ( ! $form ) {
740 665 $error = __( 'Form does not exist', 'formidable' );
741 666 wp_die(
742 667 '<h1>' . esc_html( $error ) . '</h1>',
@@ -760,22 +685,19 @@
760 685 *
761 686 * @since 6.20
762 687 *
763 688 * @param string $form_key Form key.
764 - *
765 689 * @return void
766 690 */
767 691 public static function maybe_block_preview( $form_key ) {
768 - if ( ! FrmFormsHelper::should_block_preview( $form_key ) ) {
769 - return;
692 + if ( FrmFormsHelper::should_block_preview( $form_key ) ) {
693 + $error = __( 'You do not have permission to view this form', 'formidable' );
694 + wp_die(
695 + '<h1>' . esc_html( $error ) . '</h1>',
696 + '<p>' . esc_html( $error ) . '</p>',
697 + 403
698 + );
770 699 }
771 -
772 - $error = __( 'You do not have permission to view this form', 'formidable' );
773 - wp_die(
774 - '<h1>' . esc_html( $error ) . '</h1>',
775 - '<p>' . esc_html( $error ) . '</p>',
776 - 403
777 - );
778 700 }
779 701
780 702 /**
781 703 * Some themes have a null $src value.
@@ -790,13 +712,15 @@
790 712 add_filter(
791 713 'script_loader_src',
792 714 /**
793 715 * @param string|null $src
794 - *
795 716 * @return string
796 717 */
797 718 function ( $src ) {
798 - return is_null( $src ) ? '' : $src;
719 + if ( is_null( $src ) ) {
720 + $src = '';
721 + }
722 + return $src;
799 723 }
800 724 );
801 725 }
802 726
@@ -805,9 +729,8 @@
805 729 }
806 730
807 731 /**
808 732 * @param array $ids
809 - *
810 733 * @return string
811 734 */
812 735 public static function bulk_untrash( $ids ) {
813 736 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -819,9 +742,11 @@
819 742 return '';
820 743 }
821 744
822 745 /* translators: %1$s: Number of forms */
823 - return sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
746 + $message = sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
747 +
748 + return $message;
824 749 }
825 750
826 751 /**
827 752 * @since 3.06
@@ -866,9 +791,8 @@
866 791 // Check nonce url.
867 792 check_admin_referer( $status . '_form_' . $params['id'] );
868 793
869 794 $count = 0;
870 -
871 795 if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
872 796 ++$count;
873 797 }
874 798
@@ -882,9 +806,9 @@
882 806 /* translators: %1$s: Number of forms */
883 807 $available_status['untrash']['message'] = sprintf( _n( '%1$s form restored from the Trash.', '%1$s forms restored from the Trash.', $count, 'formidable' ), $count );
884 808
885 809 /* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
886 - $available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
810 + $available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
887 811
888 812 $message = $available_status[ $status ]['message'];
889 813
890 814 self::display_forms_list( $params, $message );
@@ -891,9 +815,8 @@
891 815 }
892 816
893 817 /**
894 818 * @param array $ids
895 - *
896 819 * @return string
897 820 */
898 821 public static function bulk_trash( $ids ) {
899 822 FrmAppHelper::permission_check( 'frm_delete_forms' );
@@ -898,9 +821,8 @@
898 821 public static function bulk_trash( $ids ) {
899 822 FrmAppHelper::permission_check( 'frm_delete_forms' );
900 823
901 824 $count = 0;
902 -
903 825 foreach ( $ids as $id ) {
904 826 if ( FrmForm::trash( $id ) ) {
905 827 ++$count;
906 828 }
@@ -915,16 +837,17 @@
915 837 'param' => 'form_type',
916 838 'type' => 'request',
917 839 )
918 840 );
919 -
920 - return sprintf(
841 + $message = sprintf(
921 842 /* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
922 843 _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
923 844 $count,
924 - '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=list&action=bulk_untrash&form_type=' . $current_page . '&item-action=' . implode( ',', $ids ), 'bulk-toplevel_page_formidable' ) ) . '">', // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
845 + '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=list&action=bulk_untrash&form_type=' . $current_page . '&item-action=' . implode( ',', $ids ), 'bulk-toplevel_page_formidable' ) ) . '">',
925 846 '</a>'
926 847 );
848 +
849 + return $message;
927 850 }
928 851
929 852 public static function destroy() {
930 853 FrmAppHelper::permission_check( 'frm_delete_forms' );
@@ -934,9 +857,8 @@
934 857 // Check nonce url.
935 858 check_admin_referer( 'destroy_form_' . $params['id'] );
936 859
937 860 $count = 0;
938 -
939 861 if ( FrmForm::destroy( $params['id'] ) ) {
940 862 ++$count;
941 863 }
942 864
@@ -947,9 +869,8 @@
947 869 }
948 870
949 871 /**
950 872 * @param array $ids
951 - *
952 873 * @return string
953 874 */
954 875 public static function bulk_destroy( $ids ) {
955 876 FrmAppHelper::permission_check( 'frm_delete_forms' );
@@ -954,12 +875,10 @@
954 875 public static function bulk_destroy( $ids ) {
955 876 FrmAppHelper::permission_check( 'frm_delete_forms' );
956 877
957 878 $count = 0;
958 -
959 879 foreach ( $ids as $id ) {
960 880 $d = FrmForm::destroy( $id );
961 -
962 881 if ( $d ) {
963 882 ++$count;
964 883 }
965 884 }
@@ -977,18 +896,19 @@
977 896 */
978 897 public static function delete_all() {
979 898 // Check nonce url.
980 899 $permission_error = FrmAppHelper::permission_nonce_error( 'frm_delete_forms', '_wpnonce', 'bulk-toplevel_page_formidable' );
981 -
982 900 if ( $permission_error !== false ) {
983 901 self::display_forms_list( array(), '', array( $permission_error ) );
902 +
984 903 return;
985 904 }
986 905
987 906 $count = FrmForm::scheduled_delete( time() );
988 907 $url = remove_query_arg( array( 'delete_all' ) );
989 - $url .= '&message=forms_permanently_deleted&forms_deleted=' . $count;
990 908
909 + $url .= '&message=forms_permanently_deleted&forms_deleted=' . $count;
910 +
991 911 wp_safe_redirect( $url );
992 912 die();
993 913 }
994 914
@@ -1062,22 +982,21 @@
1062 982 *
1063 983 * @return void
1064 984 */
1065 985 public static function insert_form_button() {
1066 - if ( ! current_user_can( 'frm_view_forms' ) ) {
1067 - return;
986 + if ( current_user_can( 'frm_view_forms' ) ) {
987 + // Store the result in memory and re-use it when this function is called multiple times.
988 + // This helps speed up the form builder when there are a lot of HTML fields, where this
989 + // button is inserted once per HTML field.
990 + // In a form with 66 HTML fields, this saves 0.5 seconds on page load time, tested locally.
991 + if ( ! isset( self::$formidable_tinymce_button ) ) {
992 + FrmAppHelper::load_admin_wide_js();
993 + $menu_name = FrmAppHelper::get_menu_name();
994 + $icon = apply_filters( 'frm_media_icon', FrmAppHelper::svg_logo() );
995 + self::$formidable_tinymce_button = '<a href="#TB_inline?width=50&height=50&inlineId=frm_insert_form" class="thickbox button add_media frm_insert_form" title="' . esc_attr__( 'Add forms and content', 'formidable' ) . '">' . FrmAppHelper::kses( $icon, 'all' ) . ' ' . esc_html( $menu_name ) . '</a>';
996 + }
997 + echo self::$formidable_tinymce_button; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
1068 998 }
1069 -
1070 - // Store the result in memory and re-use it when this function is called multiple times.
1071 - // This helps speed up the form builder when there are a lot of HTML fields, where this
1072 - // Button is inserted once per HTML field.
1073 - // In a form with 66 HTML fields, this saves 0.5 seconds on page load time, tested locally.
1074 - if ( ! isset( self::$formidable_tinymce_button ) ) {
1075 - FrmAppHelper::load_admin_wide_js();
1076 - $icon = apply_filters( 'frm_media_icon', FrmAppHelper::svg_logo() );
1077 - self::$formidable_tinymce_button = '<a href="#TB_inline?width=50&height=50&inlineId=frm_insert_form" class="thickbox button add_media frm_insert_form" title="' . esc_attr__( 'Add forms and content', 'formidable' ) . '">' . FrmAppHelper::kses( $icon, 'all' ) . ' ' . esc_html( FrmAppHelper::get_menu_name() ) . '</a>'; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1078 - }
1079 - echo self::$formidable_tinymce_button; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
1080 999 }
1081 1000
1082 1001 /**
1083 1002 * @return void
@@ -1098,21 +1017,17 @@
1098 1017 $shortcodes = apply_filters( 'frm_popup_shortcodes', $shortcodes );
1099 1018
1100 1019 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/insert_form_popup.php';
1101 1020
1102 - if ( ! FrmAppHelper::is_form_builder_page() || class_exists( '_WP_Editors', false ) ) {
1103 - return;
1021 + if ( FrmAppHelper::is_form_builder_page() && ! class_exists( '_WP_Editors', false ) ) {
1022 + // initialize a wysiwyg so we have usable settings defined in tinyMCEPreInit.mceInit
1023 + require ABSPATH . WPINC . '/class-wp-editor.php';
1024 + ?>
1025 + <div class="frm_hidden">
1026 + <?php wp_editor( '', 'frm_description_placeholder', array() ); ?>
1027 + </div>
1028 + <?php
1104 1029 }
1105 -
1106 - // Initialize a wysiwyg so we have usable settings defined in tinyMCEPreInit.mceInit
1107 - require ABSPATH . WPINC . '/class-wp-editor.php';
1108 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
1109 - ?>
1110 - <div class="frm_hidden">
1111 - <?php wp_editor( '', 'frm_description_placeholder', array() ); ?>
1112 - </div>
1113 - <?php
1114 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
1115 1030 }
1116 1031
1117 1032 /**
1118 1033 * Check the page being loaded, determine if this is a page that should include the form popup.
@@ -1124,9 +1039,8 @@
1124 1039 private static function should_insert_form_popup() {
1125 1040 if ( FrmAppHelper::is_form_builder_page() ) {
1126 1041 return true;
1127 1042 }
1128 -
1129 1043 $page = basename( FrmAppHelper::get_server_value( 'PHP_SELF' ) );
1130 1044 return in_array( $page, array( 'post.php', 'page.php', 'page-new.php', 'post-new.php' ), true );
1131 1045 }
1132 1046
@@ -1134,10 +1048,9 @@
1134 1048 FrmAppHelper::permission_check( 'frm_view_forms' );
1135 1049 check_ajax_referer( 'frm_ajax', 'nonce' );
1136 1050
1137 1051 $shortcode = FrmAppHelper::get_post_param( 'shortcode', '', 'sanitize_text_field' );
1138 -
1139 - if ( ! $shortcode ) {
1052 + if ( empty( $shortcode ) ) {
1140 1053 wp_die();
1141 1054 }
1142 1055
1143 1056 echo '<div id="sc-opts-' . esc_attr( $shortcode ) . '" class="frm_shortcode_option">';
@@ -1162,13 +1075,12 @@
1162 1075 'label' => __( 'Minimize form HTML', 'formidable' ),
1163 1076 ),
1164 1077 );
1165 1078 }
1166 -
1167 1079 $opts = apply_filters( 'frm_sc_popup_opts', $opts, $shortcode );
1168 1080
1169 1081 if ( isset( $opts['form_id'] ) && is_string( $opts['form_id'] ) ) {
1170 - // Allow other shortcodes to use the required form id option
1082 + // allow other shortcodes to use the required form id option
1171 1083 $form_id = $opts['form_id'];
1172 1084 unset( $opts['form_id'] );
1173 1085 }
1174 1086
@@ -1184,9 +1096,8 @@
1184 1096 *
1185 1097 * @param array $params
1186 1098 * @param string $message
1187 1099 * @param array $errors
1188 - *
1189 1100 * @return void
1190 1101 */
1191 1102 public static function display_forms_list( $params = array(), $message = '', $errors = array() ) {
1192 1103 FrmAppHelper::permission_check( 'frm_view_forms' );
@@ -1203,21 +1114,21 @@
1203 1114 * @param string $table_class Class name for List Helper.
1204 1115 */
1205 1116 $table_class = apply_filters( 'frm_forms_list_class', 'FrmFormsListHelper' );
1206 1117 $wp_list_table = new $table_class( compact( 'params' ) );
1207 - $pagenum = $wp_list_table->get_pagenum();
1208 1118
1119 + $pagenum = $wp_list_table->get_pagenum();
1120 +
1209 1121 $wp_list_table->prepare_items();
1210 1122
1211 1123 $total_pages = $wp_list_table->get_pagination_arg( 'total_pages' );
1212 -
1213 1124 if ( $pagenum > $total_pages && $total_pages > 0 ) {
1214 - wp_safe_redirect( esc_url_raw( add_query_arg( 'paged', $total_pages ) ) );
1125 + wp_redirect( esc_url_raw( add_query_arg( 'paged', $total_pages ) ) );
1215 1126 die();
1216 1127 }
1217 1128
1218 - $error = FrmInbox::check_for_error();
1219 -
1129 + $inbox = new FrmInbox();
1130 + $error = $inbox->check_for_error();
1220 1131 if ( $error ) {
1221 1132 $show_messages = array( $error['subject'] . '. ' . $error['message'] );
1222 1133 }
1223 1134
@@ -1225,22 +1136,17 @@
1225 1136 }
1226 1137
1227 1138 /**
1228 1139 * @param array<string,string> $columns
1229 - *
1230 1140 * @return array<string,string>
1231 1141 */
1232 1142 public static function get_columns( $columns ) {
1233 - $columns['cb'] = '<input type="checkbox" />';
1234 - $columns['name'] = esc_html__( 'Form Title', 'formidable' );
1235 - $columns['entries'] = esc_html__( 'Entries', 'formidable' );
1236 - $columns['id'] = 'ID';
1237 - $columns['form_key'] = esc_html__( 'Key', 'formidable' );
1238 -
1239 - if ( 'trash' !== FrmAppHelper::simple_get( 'form_type' ) ) {
1240 - $columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
1241 - }
1242 -
1143 + $columns['cb'] = '<input type="checkbox" />';
1144 + $columns['name'] = esc_html__( 'Form Title', 'formidable' );
1145 + $columns['entries'] = esc_html__( 'Entries', 'formidable' );
1146 + $columns['id'] = 'ID';
1147 + $columns['form_key'] = esc_html__( 'Key', 'formidable' );
1148 + $columns['shortcode'] = esc_html__( 'Actions', 'formidable' );
1243 1149 $columns['created_at'] = esc_html__( 'Date', 'formidable' );
1244 1150
1245 1151 add_screen_option(
1246 1152 'per_page',
@@ -1268,9 +1174,8 @@
1268 1174 }
1269 1175
1270 1176 /**
1271 1177 * @param mixed $hidden_columns
1272 - *
1273 1178 * @return array
1274 1179 */
1275 1180 public static function hidden_columns( $hidden_columns ) {
1276 1181 if ( ! is_array( $hidden_columns ) ) {
@@ -1291,18 +1196,11 @@
1291 1196
1292 1197 return $hidden_columns;
1293 1198 }
1294 1199
1295 - /**
1296 - * @param mixed $save
1297 - * @param string $option
1298 - * @param int|string $value
1299 - *
1300 - * @return mixed
1301 - */
1302 1200 public static function save_per_page( $save, $option, $value ) {
1303 1201 if ( $option === 'formidable_page_formidable_per_page' ) {
1304 - return (int) $value;
1202 + $save = (int) $value;
1305 1203 }
1306 1204
1307 1205 return $save;
1308 1206 }
@@ -1311,9 +1209,8 @@
1311 1209 * @param int|string $id
1312 1210 * @param array $errors
1313 1211 * @param string $message
1314 1212 * @param bool $create_link
1315 - *
1316 1213 * @return void
1317 1214 */
1318 1215 private static function get_edit_vars( $id, $errors = array(), $message = '', $create_link = false ) {
1319 1216 global $frm_vars;
@@ -1328,9 +1225,8 @@
1328 1225 'page' => 'formidable',
1329 1226 )
1330 1227 ),
1331 1228 );
1332 -
1333 1229 if ( ! $form ) {
1334 1230 FrmAppController::show_error_modal( $error_args );
1335 1231 return;
1336 1232 }
@@ -1352,14 +1248,15 @@
1352 1248 }
1353 1249
1354 1250 if ( $form->parent_form_id ) {
1355 1251 /* translators: %1$s: Start link HTML, %2$s: End link HTML */
1356 - wp_die( sprintf( esc_html__( 'You are trying to edit a child form. Please edit from %1$shere%2$s', 'formidable' ), '<a href="' . esc_url( FrmForm::get_edit_link( $form->parent_form_id ) ) . '">', '</a>' ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1252 + wp_die( sprintf( esc_html__( 'You are trying to edit a child form. Please edit from %1$shere%2$s', 'formidable' ), '<a href="' . esc_url( FrmForm::get_edit_link( $form->parent_form_id ) ) . '">', '</a>' ) );
1357 1253 }
1358 1254
1359 1255 $frm_field_selection = FrmField::field_selection();
1360 - $fields = FrmField::get_all_for_form( $form->id );
1361 1256
1257 + $fields = FrmField::get_all_for_form( $form->id );
1258 +
1362 1259 // Automatically add end section fields if they don't exist (2.0 migration).
1363 1260 $reset_fields = false;
1364 1261 FrmFormsHelper::auto_add_end_section_fields( $form, $fields, $reset_fields );
1365 1262 FrmSubmitHelper::maybe_create_submit_field( $form, $fields, $reset_fields );
@@ -1383,10 +1280,9 @@
1383 1280 */
1384 1281 $values['fields'] = apply_filters( 'frm_fields_in_form_builder', $fields, compact( 'form' ) );
1385 1282
1386 1283 $edit_message = __( 'Form was successfully updated.', 'formidable' );
1387 -
1388 - if ( $form->is_template && $message === $edit_message ) {
1284 + if ( $form->is_template && $message == $edit_message ) {
1389 1285 $message = __( 'Template was successfully updated.', 'formidable' );
1390 1286 }
1391 1287
1392 1288 self::maybe_update_form_builder_message( $message );
@@ -1401,12 +1297,11 @@
1401 1297 }
1402 1298
1403 1299 /**
1404 1300 * @param array $fields
1405 - *
1406 1301 * @return array
1407 1302 */
1408 - public static function update_form_builder_fields( $fields ) {
1303 + public static function update_form_builder_fields( $fields, $form ) {
1409 1304 foreach ( $fields as $field ) {
1410 1305 $field->do_not_include_icons = true;
1411 1306 }
1412 1307 return $fields;
@@ -1411,13 +1306,8 @@
1411 1306 }
1412 1307 return $fields;
1413 1308 }
1414 1309
1415 - /**
1416 - * @param string $message
1417 - *
1418 - * @return void
1419 - */
1420 1310 public static function maybe_update_form_builder_message( &$message ) {
1421 1311 if ( 'form_duplicated' === FrmAppHelper::simple_get( 'message' ) ) {
1422 1312 $message = __( 'Form was Successfully Copied', 'formidable' );
1423 1313 }
@@ -1426,9 +1316,8 @@
1426 1316 /**
1427 1317 * @param int|string $id
1428 1318 * @param array $errors
1429 1319 * @param array|string $args
1430 - *
1431 1320 * @return void
1432 1321 */
1433 1322 public static function get_settings_vars( $id, $errors = array(), $args = array() ) {
1434 1323 FrmAppHelper::permission_check( 'frm_edit_forms' );
@@ -1450,12 +1339,13 @@
1450 1339 );
1451 1340 $args = array_merge( $defaults, $args );
1452 1341 $message = $args['message'];
1453 1342 $warnings = $args['warnings'];
1454 - $form = FrmForm::getOne( $id );
1455 - $fields = FrmField::get_all_for_form( $id );
1456 - $values = FrmAppHelper::setup_edit_vars( $form, 'forms', $fields, true );
1457 1343
1344 + $form = FrmForm::getOne( $id );
1345 + $fields = FrmField::get_all_for_form( $id );
1346 + $values = FrmAppHelper::setup_edit_vars( $form, 'forms', $fields, true );
1347 +
1458 1348 /**
1459 1349 * Allows changing fields in the form settings.
1460 1350 *
1461 1351 * @since 5.0.04
@@ -1495,12 +1385,8 @@
1495 1385 }
1496 1386
1497 1387 /**
1498 1388 * @since 4.0
1499 - *
1500 - * @param array $atts
1501 - *
1502 - * @return void
1503 1389 */
1504 1390 public static function form_publish_button( $atts ) {
1505 1391 $values = $atts['values'];
1506 1392 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/_publish_box.php';
@@ -1511,9 +1397,8 @@
1511 1397 *
1512 1398 * @since 4.0
1513 1399 *
1514 1400 * @param array $values
1515 - *
1516 1401 * @return array
1517 1402 */
1518 1403 private static function get_settings_tabs( $values ) {
1519 1404 $sections = array(
@@ -1519,20 +1404,20 @@
1519 1404 $sections = array(
1520 1405 'advanced' => array(
1521 1406 'name' => __( 'General', 'formidable' ),
1522 1407 'title' => __( 'General Form Settings', 'formidable' ),
1523 - 'function' => array( self::class, 'advanced_settings' ),
1524 - 'icon' => 'frmfont frm_settings_icon',
1408 + 'function' => array( __CLASS__, 'advanced_settings' ),
1409 + 'icon' => 'frm_icon_font frm_settings_icon',
1525 1410 ),
1526 1411 'email' => array(
1527 1412 'name' => __( 'Actions & Notifications', 'formidable' ),
1528 1413 'function' => array( 'FrmFormActionsController', 'email_settings' ),
1529 1414 'id' => 'frm_notification_settings',
1530 - 'icon' => 'frmfont frm_mail_bulk_icon',
1415 + 'icon' => 'frm_icon_font frm_mail_bulk_icon',
1531 1416 ),
1532 1417 'permissions' => array(
1533 1418 'name' => __( 'Form Permissions', 'formidable' ),
1534 - 'icon' => 'frmfont frm_lock_closed_icon',
1419 + 'icon' => 'frm_icon_font frm_lock_closed_icon',
1535 1420 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1536 1421 'data' => array(
1537 1422 'medium' => 'permissions',
1538 1423 'upgrade' => __( 'Form Permissions', 'formidable' ),
@@ -1537,37 +1422,35 @@
1537 1422 'medium' => 'permissions',
1538 1423 'upgrade' => __( 'Form Permissions', 'formidable' ),
1539 1424 'message' => __( 'Allow editing, protect forms and files, limit entries, and save drafts. Upgrade to get form and entry permissions.', 'formidable' ),
1540 1425 'screenshot' => 'permissions.png',
1541 - 'learn-more' => FrmAppHelper::get_doc_url( 'general-form-settings/#kb-form-permissions', 'form-permissions-settings' ),
1542 1426 ),
1543 1427 ),
1544 1428 'scheduling' => array(
1545 1429 'name' => __( 'Form Scheduling', 'formidable' ),
1546 - 'icon' => 'frmfont frm_calendar_icon',
1430 + 'icon' => 'frm_icon_font frm_calendar_icon',
1547 1431 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1548 1432 'data' => array(
1549 1433 'medium' => 'scheduling',
1550 1434 'upgrade' => __( 'Form scheduling settings', 'formidable' ),
1551 1435 'screenshot' => 'scheduling.png',
1552 - 'learn-more' => FrmAppHelper::get_doc_url( 'general-form-settings/#kb-form-scheduling', 'form-scheduling-settings' ),
1553 1436 ),
1554 1437 ),
1555 1438 'buttons' => array(
1556 1439 'name' => __( 'Buttons', 'formidable' ),
1557 - 'class' => self::class,
1440 + 'class' => __CLASS__,
1558 1441 'function' => 'buttons_settings',
1559 - 'icon' => 'frmfont frm_button_icon',
1442 + 'icon' => 'frm_icon_font frm_button_icon',
1560 1443 ),
1561 1444 'landing' => array(
1562 1445 'name' => __( 'Form Landing Page', 'formidable' ),
1563 - 'icon' => 'frmfont frm_file_text_icon',
1446 + 'icon' => 'frm_icon_font frm_file_text_icon',
1564 1447 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1565 1448 'data' => FrmAppHelper::get_landing_page_upgrade_data_params(),
1566 1449 ),
1567 1450 'chat' => array(
1568 1451 'name' => __( 'Conversational Forms', 'formidable' ),
1569 - 'icon' => 'frmfont frm_chat_forms_icon',
1452 + 'icon' => 'frm_icon_font frm_chat_forms_icon',
1570 1453 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1571 1454 'data' => FrmAppHelper::get_upgrade_data_params(
1572 1455 'chat',
1573 1456 array(
@@ -1573,15 +1456,14 @@
1573 1456 array(
1574 1457 'upgrade' => __( 'Conversational Forms', 'formidable' ),
1575 1458 'message' => __( 'Ask one question at a time for automated conversations.', 'formidable' ),
1576 1459 'screenshot' => 'chat.png',
1577 - 'learn-more' => FrmAppHelper::get_doc_url( 'conversational-forms', 'conversational-forms-settings', false ),
1578 1460 )
1579 1461 ),
1580 1462 ),
1581 1463 'abandonment' => array(
1582 1464 'name' => __( 'Form Abandonment', 'formidable' ),
1583 - 'icon' => 'frmfont frm_abandoned_icon',
1465 + 'icon' => 'frm_icon_font frm_abandoned_icon',
1584 1466 'html_class' => 'frm_show_upgrade_tab frm_noallow',
1585 1467 'data' => FrmAppHelper::get_upgrade_data_params(
1586 1468 'abandonment',
1587 1469 array(
@@ -1587,17 +1469,16 @@
1587 1469 array(
1588 1470 'upgrade' => __( 'Form abandonment settings', 'formidable' ),
1589 1471 'message' => __( 'Unlock the power of data capture to boost lead generation and master the art of form optimization.', 'formidable' ),
1590 1472 'screenshot' => 'abandonment.png',
1591 - 'learn-more' => FrmAppHelper::get_doc_url( 'features/form-abandonment-wordpress-plugin', 'form-abandonment-settings', false ),
1592 1473 )
1593 1474 ),
1594 1475 ),
1595 1476 'html' => array(
1596 1477 'name' => __( 'Customize HTML', 'formidable' ),
1597 - 'class' => self::class,
1478 + 'class' => __CLASS__,
1598 1479 'function' => 'html_settings',
1599 - 'icon' => 'frmfont frm_code_icon',
1480 + 'icon' => 'frm_icon_font frm_code_icon',
1600 1481 ),
1601 1482 );
1602 1483
1603 1484 if ( ! has_action( 'frm_add_form_style_tab_options' ) && ! has_action( 'frm_add_form_button_options' ) ) {
@@ -1603,8 +1484,14 @@
1603 1484 if ( ! has_action( 'frm_add_form_style_tab_options' ) && ! has_action( 'frm_add_form_button_options' ) ) {
1604 1485 unset( $sections['buttons'] );
1605 1486 }
1606 1487
1488 + foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
1489 + if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
1490 + unset( $sections[ $feature ] );
1491 + }
1492 + }
1493 +
1607 1494 $sections = apply_filters( 'frm_add_form_settings_section', $sections, $values );
1608 1495
1609 1496 foreach ( $sections as $key => $section ) {
1610 1497 $defaults = array(
@@ -1609,9 +1496,9 @@
1609 1496 foreach ( $sections as $key => $section ) {
1610 1497 $defaults = array(
1611 1498 'html_class' => '',
1612 1499 'name' => ucfirst( $key ),
1613 - 'icon' => 'frmfont frm_settings_icon',
1500 + 'icon' => 'frm_icon_font frm_settings_icon',
1614 1501 );
1615 1502
1616 1503 $section = array_merge( $defaults, $section );
1617 1504
@@ -1617,9 +1504,8 @@
1617 1504
1618 1505 if ( ! isset( $section['anchor'] ) ) {
1619 1506 $section['anchor'] = $key;
1620 1507 }
1621 -
1622 1508 $section['anchor'] .= '_settings';
1623 1509
1624 1510 if ( ! isset( $section['title'] ) ) {
1625 1511 $section['title'] = $section['name'];
@@ -1638,19 +1524,18 @@
1638 1524 /**
1639 1525 * @since 4.0
1640 1526 *
1641 1527 * @param array $values
1642 - *
1643 1528 * @return void
1644 1529 */
1645 1530 public static function advanced_settings( $values ) {
1646 1531 $first_h3 = 'frm_first_h3';
1532 +
1647 1533 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-advanced.php';
1648 1534 }
1649 1535
1650 1536 /**
1651 1537 * @param array $values
1652 - *
1653 1538 * @return void
1654 1539 */
1655 1540 public static function render_spam_settings( $values ) {
1656 1541 if ( function_exists( 'akismet_http_post' ) ) {
@@ -1655,9 +1540,9 @@
1655 1540 public static function render_spam_settings( $values ) {
1656 1541 if ( function_exists( 'akismet_http_post' ) ) {
1657 1542 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/akismet.php';
1658 1543 }
1659 - include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/stopforumspam.php';
1544 + include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/honeypot.php';
1660 1545 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/spam-settings/antispam.php';
1661 1546 }
1662 1547
1663 1548 /**
@@ -1663,9 +1548,8 @@
1663 1548 /**
1664 1549 * @since 4.0
1665 1550 *
1666 1551 * @param array $values
1667 - *
1668 1552 * @return void
1669 1553 */
1670 1554 public static function buttons_settings( $values ) {
1671 1555 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-buttons.php';
@@ -1674,9 +1558,8 @@
1674 1558 /**
1675 1559 * @since 4.0
1676 1560 *
1677 1561 * @param array $values
1678 - *
1679 1562 * @return void
1680 1563 */
1681 1564 public static function html_settings( $values ) {
1682 1565 include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/settings-html.php';
@@ -1687,9 +1570,8 @@
1687 1570 *
1688 1571 * @since 2.03.08
1689 1572 *
1690 1573 * @param array|bool $values
1691 - *
1692 1574 * @return void
1693 1575 */
1694 1576 private static function clean_submit_html( &$values ) {
1695 1577 if ( is_array( $values ) && isset( $values['submit_html'] ) ) {
@@ -1712,17 +1594,13 @@
1712 1594 return $classes;
1713 1595 }
1714 1596
1715 1597 /**
1716 - * @since 6.27 Added $template_path parameter.
1717 - *
1718 1598 * @param int|string $form_id
1719 1599 * @param string $class
1720 - * @param string $template_path The path to a template file to use instead of the default.
1721 - *
1722 1600 * @return void
1723 1601 */
1724 - public static function mb_tags_box( $form_id, $class = '', $template_path = 'default' ) {
1602 + public static function mb_tags_box( $form_id, $class = '' ) {
1725 1603 $fields = FrmField::get_all_for_form( $form_id, '', 'include' );
1726 1604
1727 1605 /**
1728 1606 * Allows modifying the list of fields in the tags box.
@@ -1731,30 +1609,23 @@
1731 1609 *
1732 1610 * @param array $fields The list of fields.
1733 1611 * @param array $args The arguments. Contains `form_id`.
1734 1612 */
1735 - $fields = apply_filters( 'frm_fields_in_tags_box', $fields, compact( 'form_id' ) );
1736 - $linked_forms = array();
1737 - $col = 'one';
1738 - $settings_tab = FrmAppHelper::is_admin_page( 'formidable' );
1613 + $fields = apply_filters( 'frm_fields_in_tags_box', $fields, compact( 'form_id' ) );
1614 + $linked_forms = array();
1615 + $col = 'one';
1616 + $settings_tab = FrmAppHelper::is_admin_page( 'formidable' );
1617 +
1739 1618 $cond_shortcodes = apply_filters( 'frm_conditional_shortcodes', array() );
1740 1619 $entry_shortcodes = self::get_shortcode_helpers( $settings_tab );
1620 +
1741 1621 $advanced_helpers = self::advanced_helpers( compact( 'fields', 'form_id' ) );
1742 1622
1743 - if ( 'default' === $template_path || ! file_exists( $template_path ) ) {
1744 - include FrmAppHelper::plugin_path() . '/classes/views/shared/mb_adv_info.php';
1745 - return;
1746 - }
1747 -
1748 - include $template_path;
1623 + include FrmAppHelper::plugin_path() . '/classes/views/shared/mb_adv_info.php';
1749 1624 }
1750 1625
1751 1626 /**
1752 1627 * @since 3.04.01
1753 - *
1754 - * @param array $atts
1755 - *
1756 - * @return array
1757 1628 */
1758 1629 private static function advanced_helpers( $atts ) {
1759 1630 $advanced_helpers = array(
1760 1631 'default' => array(
@@ -1763,12 +1634,10 @@
1763 1634 ),
1764 1635 );
1765 1636
1766 1637 $user_fields = self::user_shortcodes();
1767 -
1768 1638 if ( $user_fields ) {
1769 1639 $user_helpers = array();
1770 -
1771 1640 foreach ( $user_fields as $uk => $uf ) {
1772 1641 $user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
1773 1642 unset( $uk, $uf );
1774 1643 }
@@ -1793,10 +1662,8 @@
1793 1662 * Get an array of the options to display in the advanced tab
1794 1663 * of the customization panel
1795 1664 *
1796 1665 * @since 2.0.6
1797 - *
1798 - * @return array
1799 1666 */
1800 1667 private static function get_advanced_shortcodes() {
1801 1668 $adv_shortcodes = array(
1802 1669 'x sep=", "' => array(
@@ -1813,18 +1680,17 @@
1813 1680 'label' => __( 'No Auto P', 'formidable' ),
1814 1681 'title' => __( 'Do not automatically add any paragraphs or line breaks', 'formidable' ),
1815 1682 ),
1816 1683 );
1684 + $adv_shortcodes = apply_filters( 'frm_advanced_shortcodes', $adv_shortcodes );
1817 1685
1818 1686 // __( 'Leave blank instead of defaulting to User Login', 'formidable' ) : blank=1
1819 1687
1820 - return apply_filters( 'frm_advanced_shortcodes', $adv_shortcodes );
1688 + return $adv_shortcodes;
1821 1689 }
1822 1690
1823 1691 /**
1824 1692 * @since 3.04.01
1825 - *
1826 - * @return array
1827 1693 */
1828 1694 private static function user_shortcodes() {
1829 1695 $options = array(
1830 1696 'ID' => __( 'User ID', 'formidable' ),
@@ -1843,12 +1709,8 @@
1843 1709 /**
1844 1710 * Get an array of the helper shortcodes to display in the customization panel
1845 1711 *
1846 1712 * @since 2.0.6
1847 - *
1848 - * @param bool $settings_tab
1849 - *
1850 - * @return array
1851 1713 */
1852 1714 private static function get_shortcode_helpers( $settings_tab ) {
1853 1715 $entry_shortcodes = array(
1854 1716 'id' => __( 'Entry ID', 'formidable' ),
@@ -1863,9 +1725,8 @@
1863 1725 'form_name' => __( 'Form Name', 'formidable' ),
1864 1726 );
1865 1727
1866 1728 $entry_shortcodes = array_merge( FrmShortcodeHelper::get_contextual_shortcode_values(), $entry_shortcodes );
1867 -
1868 1729 if ( ! FrmAppHelper::pro_is_installed() ) {
1869 1730 unset( $entry_shortcodes['post_id'] );
1870 1731 }
1871 1732
@@ -1873,13 +1734,12 @@
1873 1734 * Use this hook to add or remove buttons in the helpers section
1874 1735 * in the customization panel
1875 1736 *
1876 1737 * @since 2.0.6
1877 - *
1878 - * @param array $entry_shortcodes
1879 - * @param bool $settings_tab
1880 1738 */
1881 - return apply_filters( 'frm_helper_shortcodes', $entry_shortcodes, $settings_tab );
1739 + $entry_shortcodes = apply_filters( 'frm_helper_shortcodes', $entry_shortcodes, $settings_tab );
1740 +
1741 + return $entry_shortcodes;
1882 1742 }
1883 1743
1884 1744 /**
1885 1745 * Insert the form class setting into the form.
@@ -1884,9 +1744,8 @@
1884 1744 /**
1885 1745 * Insert the form class setting into the form.
1886 1746 *
1887 1747 * @param stdClass $form
1888 - *
1889 1748 * @return void
1890 1749 */
1891 1750 public static function form_classes( $form ) {
1892 1751 if ( isset( $form->options['form_class'] ) ) {
@@ -1909,9 +1768,8 @@
1909 1768 * @param stdClass $form
1910 1769 */
1911 1770 public static function add_js_validate_form_to_global_vars( $form ) {
1912 1771 global $frm_vars;
1913 -
1914 1772 if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
1915 1773 $frm_vars['js_validate_forms'] = array();
1916 1774 }
1917 1775 $frm_vars['js_validate_forms'][ $form->id ] = $form;
@@ -1934,9 +1792,8 @@
1934 1792 /**
1935 1793 * @param string $content
1936 1794 * @param int|stdClass|string $form
1937 1795 * @param false|int|stdClass|string $entry
1938 - *
1939 1796 * @return string
1940 1797 */
1941 1798 public static function filter_content( $content, $form, $entry = false ) {
1942 1799 $content = self::replace_form_name_shortcodes( $content, $form );
@@ -1941,9 +1798,8 @@
1941 1798 public static function filter_content( $content, $form, $entry = false ) {
1942 1799 $content = self::replace_form_name_shortcodes( $content, $form );
1943 1800
1944 1801 self::get_entry_by_param( $entry );
1945 -
1946 1802 if ( ! $entry ) {
1947 1803 return $content;
1948 1804 }
1949 1805
@@ -1959,10 +1815,11 @@
1959 1815 $form = $entry->parent_entry->form_id;
1960 1816 }
1961 1817
1962 1818 $shortcodes = FrmFieldsHelper::get_shortcodes( $content, $form );
1819 + $content = apply_filters( 'frm_replace_content_shortcodes', $content, $entry, $shortcodes );
1963 1820
1964 - return apply_filters( 'frm_replace_content_shortcodes', $content, $entry, $shortcodes );
1821 + return $content;
1965 1822 }
1966 1823
1967 1824 /**
1968 1825 * Replace any [form_name] shortcodes in a string.
@@ -1970,9 +1827,8 @@
1970 1827 * @since 5.5
1971 1828 *
1972 1829 * @param array|string $string
1973 1830 * @param int|stdClass|string $form
1974 - *
1975 1831 * @return array|string
1976 1832 */
1977 1833 public static function replace_form_name_shortcodes( $string, $form ) {
1978 1834 if ( ! is_string( $string ) ) {
@@ -1978,9 +1834,9 @@
1978 1834 if ( ! is_string( $string ) ) {
1979 1835 return $string;
1980 1836 }
1981 1837
1982 - if ( ! str_contains( $string, '[form_name]' ) ) {
1838 + if ( false === strpos( $string, '[form_name]' ) ) {
1983 1839 return $string;
1984 1840 }
1985 1841
1986 1842 if ( ! is_object( $form ) ) {
@@ -1992,30 +1848,20 @@
1992 1848 }
1993 1849
1994 1850 /**
1995 1851 * @param false|int|stdClass|string $entry
1996 - *
1997 1852 * @return void
1998 1853 */
1999 1854 private static function get_entry_by_param( &$entry ) {
2000 - if ( $entry && is_object( $entry ) ) {
2001 - return;
2002 - }
1855 + if ( ! $entry || ! is_object( $entry ) ) {
1856 + if ( ! $entry || ! is_numeric( $entry ) ) {
1857 + $entry = FrmAppHelper::get_post_param( 'id', false, 'sanitize_title' );
1858 + }
2003 1859
2004 - if ( ! $entry || ! is_numeric( $entry ) ) {
2005 - $entry = FrmAppHelper::get_post_param( 'id', false, 'sanitize_title' );
1860 + FrmEntry::maybe_get_entry( $entry );
2006 1861 }
2007 -
2008 - FrmEntry::maybe_get_entry( $entry );
2009 1862 }
2010 1863
2011 - /**
2012 - * @param string $content
2013 - * @param false|object $entry
2014 - * @param array $shortcodes
2015 - *
2016 - * @return string
2017 - */
2018 1864 public static function replace_content_shortcodes( $content, $entry, $shortcodes ) {
2019 1865 return FrmFieldsHelper::replace_content_shortcodes( $content, $entry, $shortcodes );
2020 1866 }
2021 1867
@@ -2020,9 +1866,8 @@
2020 1866 }
2021 1867
2022 1868 /**
2023 1869 * @param array $errors
2024 - *
2025 1870 * @return array
2026 1871 */
2027 1872 public static function process_bulk_form_actions( $errors ) {
2028 1873 if ( ! $_REQUEST ) {
@@ -2029,30 +1874,29 @@
2029 1874 return $errors;
2030 1875 }
2031 1876
2032 1877 $bulkaction = FrmAppHelper::get_param( 'action', '', 'get', 'sanitize_text_field' );
2033 -
2034 - // phpcs:ignore Universal.Operators.StrictComparisons
2035 1878 if ( $bulkaction == - 1 ) {
2036 1879 $bulkaction = FrmAppHelper::get_param( 'action2', '', 'get', 'sanitize_title' );
2037 1880 }
2038 1881
2039 - if ( $bulkaction && str_starts_with( $bulkaction, 'bulk_' ) ) {
1882 + if ( ! empty( $bulkaction ) && strpos( $bulkaction, 'bulk_' ) === 0 ) {
2040 1883 FrmAppHelper::remove_get_action();
1884 +
2041 1885 $bulkaction = str_replace( 'bulk_', '', $bulkaction );
2042 1886 }
2043 1887
2044 1888 $ids = FrmAppHelper::get_param( 'item-action', '', 'get', 'sanitize_text_field' );
1889 + if ( empty( $ids ) ) {
1890 + $errors[] = __( 'No forms were specified', 'formidable' );
2045 1891
2046 - if ( ! $ids ) {
2047 - $errors[] = __( 'No forms were specified', 'formidable' );
2048 1892 return $errors;
2049 1893 }
2050 1894
2051 1895 $permission_error = FrmAppHelper::permission_nonce_error( '', '_wpnonce', 'bulk-toplevel_page_formidable' );
2052 -
2053 1896 if ( $permission_error !== false ) {
2054 1897 $errors[] = $permission_error;
1898 +
2055 1899 return $errors;
2056 1900 }
2057 1901
2058 1902 if ( ! is_array( $ids ) ) {
@@ -2080,9 +1924,8 @@
2080 1924 /**
2081 1925 * Includes html that shows a message when the device is too small to use Formidable Forms admin pages.
2082 1926 *
2083 1927 * @since 6.20
2084 - *
2085 1928 * @return void
2086 1929 */
2087 1930 public static function include_device_too_small_message() {
2088 1931 if ( ! FrmAppHelper::is_formidable_admin() ) {
@@ -2091,13 +1934,12 @@
2091 1934
2092 1935 include FrmAppHelper::plugin_path() . '/classes/views/shared/small-device-message.php';
2093 1936 }
2094 1937
2095 - public static function route() { // phpcs:ignore Generic.Metrics.CyclomaticComplexity.MaxExceeded
1938 + public static function route() {
2096 1939 $action = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action';
2097 1940 $vars = array();
2098 1941 FrmAppHelper::include_svg();
2099 -
2100 1942 if ( isset( $_POST['frm_compact_fields'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2101 1943 FrmAppHelper::permission_check( 'frm_edit_forms' );
2102 1944
2103 1945 // Javascript needs to be allowed in some field settings.
@@ -2103,28 +1945,25 @@
2103 1945 // Javascript needs to be allowed in some field settings.
2104 1946 // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
2105 1947 $json_vars = htmlspecialchars_decode( nl2br( str_replace( '&quot;', '"', wp_unslash( $_POST['frm_compact_fields'] ) ) ) );
2106 1948 $json_vars = json_decode( $json_vars, true );
1949 + if ( empty( $json_vars ) ) {
1950 + // json decoding failed so we should return an error message.
1951 + $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
1952 + if ( 'edit' === $action ) {
1953 + $action = 'update';
1954 + }
2107 1955
2108 - if ( $json_vars ) {
1956 + add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
1957 + } else {
2109 1958 $vars = FrmAppHelper::json_to_array( $json_vars );
2110 1959 $action = $vars[ $action ];
2111 1960 unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2112 1961 $_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2113 1962 $_POST = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
2114 - } else {
2115 - // Json decoding failed so we should return an error message.
2116 - $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
2117 -
2118 - if ( 'edit' === $action ) {
2119 - $action = 'update';
2120 - }
2121 -
2122 - add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
2123 1963 }
2124 1964 } else {
2125 1965 $action = FrmAppHelper::get_param( $action, '', 'get', 'sanitize_title' );
2126 -
2127 1966 if ( isset( $_REQUEST['delete_all'] ) ) {
2128 1967 // Override the action for this page.
2129 1968 $action = 'delete_all';
2130 1969 }
@@ -2144,38 +1983,34 @@
2144 1983 case 'update_settings':
2145 1984 return self::$action( $vars );
2146 1985 case 'lite-reports':
2147 1986 self::no_reports( $vars );
2148 - return null;
1987 + return;
2149 1988 case 'views':
2150 1989 self::no_views( $vars );
2151 - return null;
1990 + return;
2152 1991 default:
2153 1992 do_action( 'frm_form_action_' . $action );
2154 -
2155 1993 if ( apply_filters( 'frm_form_stop_action_' . $action, false ) ) {
2156 - return null;
1994 + return;
2157 1995 }
2158 1996
2159 1997 $action = FrmAppHelper::get_param( 'action', '', 'get', 'sanitize_text_field' );
2160 -
2161 - // phpcs:ignore Universal.Operators.StrictComparisons
2162 1998 if ( $action == - 1 ) {
2163 1999 $action = FrmAppHelper::get_param( 'action2', '', 'get', 'sanitize_title' );
2164 2000 }
2165 2001
2166 - if ( str_starts_with( $action, 'bulk_' ) ) {
2002 + if ( strpos( $action, 'bulk_' ) === 0 ) {
2167 2003 FrmAppHelper::remove_get_action();
2168 2004
2169 2005 self::list_form();
2170 - return null;
2006 + return;
2171 2007 }
2172 2008
2173 2009 $message = FrmAppHelper::get_param( 'message' );
2174 -
2175 2010 if ( 'form_duplicate_error' === $message ) {
2176 2011 self::display_forms_list( array(), '', array( __( 'There was a problem duplicating the form', 'formidable' ) ) );
2177 - return null;
2012 + return;
2178 2013 }
2179 2014
2180 2015 if ( 'forms_permanently_deleted' === $message ) {
2181 2016 $count = FrmAppHelper::get_param( 'forms_deleted', 0, 'get', 'absint' );
@@ -2181,14 +2016,14 @@
2181 2016 $count = FrmAppHelper::get_param( 'forms_deleted', 0, 'get', 'absint' );
2182 2017 /* translators: %1$s: Number of forms */
2183 2018 $message = sprintf( _n( '%1$s form permanently deleted.', '%1$s forms permanently deleted.', $count, 'formidable' ), $count );
2184 2019 self::display_forms_list( array(), $message, '' );
2185 - return null;
2020 + return;
2186 2021 }
2187 2022
2188 2023 self::display_forms_list();
2189 2024
2190 - return null;
2025 + return;
2191 2026 }//end switch
2192 2027 }
2193 2028
2194 2029 /**
@@ -2207,43 +2042,19 @@
2207 2042
2208 2043 // Get posted data
2209 2044 $form_id = FrmAppHelper::get_post_param( 'form_id', '', 'absint' );
2210 2045 $name = FrmAppHelper::get_post_param( 'form_name', '', 'sanitize_text_field' );
2211 - $form = FrmForm::getOne( $form_id );
2212 2046
2213 - if ( ! $form ) {
2214 - wp_send_json_error( __( 'Form not found', 'formidable' ) );
2215 - }
2047 + // Update the form name and form key.
2048 + $form_key = FrmAppHelper::get_unique_key( sanitize_title( $name ), 'frm_forms', 'form_key' );
2049 + FrmForm::update( $form_id, compact( 'name', 'form_key' ) );
2216 2050
2217 - if ( $name === $form->name ) {
2218 - // Nothing to change so exit early.
2219 - wp_send_json_success();
2220 - }
2221 -
2222 - $to_update = array(
2223 - 'name' => $name,
2224 - );
2225 -
2226 - if ( '' === $name ) {
2227 - $form_key = $form->form_key;
2228 - } else {
2229 - // Only update form_key if name is not empty.
2230 - $form_key = FrmAppHelper::get_unique_key( sanitize_title( $name ), 'frm_forms', 'form_key' );
2231 - $to_update['form_key'] = $form_key;
2232 - }
2233 -
2234 - FrmForm::update( $form_id, $to_update );
2235 -
2236 2051 wp_send_json_success( compact( 'form_key' ) );
2237 2052 }
2238 2053
2239 - /**
2240 - * @param array $errors
2241 - *
2242 - * @return array
2243 - */
2244 2054 public static function json_error( $errors ) {
2245 2055 $errors['json'] = __( 'Abnormal HTML characters prevented your form from saving correctly', 'formidable' );
2056 +
2246 2057 return $errors;
2247 2058 }
2248 2059
2249 2060 /**
@@ -2250,10 +2061,8 @@
2250 2061 * Add education about views.
2251 2062 *
2252 2063 * @since 4.07
2253 2064 *
2254 - * @param array $values
2255 - *
2256 2065 * @return void
2257 2066 */
2258 2067 public static function no_views( $values = array() ) {
2259 2068 FrmAppHelper::include_svg();
@@ -2267,10 +2076,8 @@
2267 2076 * Add education about reports.
2268 2077 *
2269 2078 * @since 4.07
2270 2079 *
2271 - * @param array $values
2272 - *
2273 2080 * @return void
2274 2081 */
2275 2082 public static function no_reports( $values = array() ) {
2276 2083 $id = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
@@ -2296,9 +2103,10 @@
2296 2103 /**
2297 2104 * @since 4.05.02
2298 2105 */
2299 2106 private static function move_menu_to_footer() {
2300 - if ( empty( FrmAppHelper::get_settings()->admin_bar ) ) {
2107 + $settings = FrmAppHelper::get_settings();
2108 + if ( empty( $settings->admin_bar ) ) {
2301 2109 remove_action( 'wp_body_open', 'wp_admin_bar_render', 0 );
2302 2110 }
2303 2111 }
2304 2112
@@ -2303,15 +2111,13 @@
2303 2111 }
2304 2112
2305 2113 public static function admin_bar_configure() {
2306 2114 global $frm_vars;
2307 -
2308 2115 if ( empty( $frm_vars['forms_loaded'] ) ) {
2309 2116 return;
2310 2117 }
2311 2118
2312 2119 $actions = array();
2313 -
2314 2120 foreach ( $frm_vars['forms_loaded'] as $form ) {
2315 2121 if ( is_object( $form ) ) {
2316 2122 $actions[ $form->id ] = $form->name;
2317 2123 }
@@ -2317,9 +2123,9 @@
2317 2123 }
2318 2124 unset( $form );
2319 2125 }
2320 2126
2321 - if ( ! $actions ) {
2127 + if ( empty( $actions ) ) {
2322 2128 return;
2323 2129 }
2324 2130
2325 2131 self::add_menu_to_admin_bar();
@@ -2345,12 +2151,8 @@
2345 2151 }
2346 2152
2347 2153 /**
2348 2154 * @since 2.05.07
2349 - *
2350 - * @param array $actions
2351 - *
2352 - * @return void
2353 2155 */
2354 2156 private static function add_forms_to_admin_bar( $actions ) {
2355 2157 global $wp_admin_bar;
2356 2158
@@ -2356,13 +2158,14 @@
2356 2158
2357 2159 asort( $actions );
2358 2160
2359 2161 foreach ( $actions as $form_id => $name ) {
2162 +
2360 2163 $wp_admin_bar->add_node(
2361 2164 array(
2362 2165 'parent' => 'frm-forms',
2363 2166 'id' => 'edit_form_' . $form_id,
2364 - 'title' => $name ? $name : FrmFormsHelper::get_no_title_text(),
2167 + 'title' => empty( $name ) ? FrmFormsHelper::get_no_title_text() : $name,
2365 2168 'href' => FrmForm::get_edit_link( $form_id ),
2366 2169 )
2367 2170 );
2368 2171 }
@@ -2371,14 +2174,12 @@
2371 2174 /**
2372 2175 * The formidable shortcode
2373 2176 *
2374 2177 * @param array $atts The params from the shortcode.
2375 - *
2376 2178 * @return string
2377 2179 */
2378 2180 public static function get_form_shortcode( $atts ) {
2379 2181 global $frm_vars;
2380 -
2381 2182 if ( ! empty( $frm_vars['skip_shortcode'] ) ) {
2382 2183 $sc = '[formidable';
2383 2184 $sc .= FrmAppHelper::array_to_html_params( $atts );
2384 2185 return $sc . ']';
@@ -2407,9 +2208,8 @@
2407 2208 * @since 5.2.01
2408 2209 *
2409 2210 * @param false|int|string $id
2410 2211 * @param false|string $key
2411 - *
2412 2212 * @return false|stdClass
2413 2213 */
2414 2214 private static function maybe_get_form_by_id_or_key( $id, $key ) {
2415 2215 if ( ! $id ) {
@@ -2423,9 +2223,8 @@
2423 2223 * @param false|string $key
2424 2224 * @param bool|int|string $title may be 'auto', true, false, 'true', 'false', 'yes', '1', 1, '0', 0.
2425 2225 * @param bool|int|string $description may be 'auto', true, false, 'true', 'false', 'yes', '1', 1, '0', 0.
2426 2226 * @param array $atts
2427 - *
2428 2227 * @return string
2429 2228 */
2430 2229 public static function show_form( $id = '', $key = '', $title = false, $description = false, $atts = array() ) {
2431 2230 $form = self::maybe_get_form_by_id_or_key( $id, $key );
@@ -2446,13 +2245,14 @@
2446 2245
2447 2246 add_action( 'frm_load_form_hooks', 'FrmHooksController::trigger_load_form_hooks' );
2448 2247 FrmAppHelper::trigger_hook_load( 'form', $form );
2449 2248
2450 - $form = apply_filters( 'frm_pre_display_form', $form );
2249 + $form = apply_filters( 'frm_pre_display_form', $form );
2250 +
2451 2251 $frm_settings = FrmAppHelper::get_settings( array( 'current_form' => $form->id ) );
2452 2252
2453 2253 if ( self::is_viewable_draft_form( $form ) ) {
2454 - // Don't show a draft form on a page
2254 + // don't show a draft form on a page
2455 2255 $form = __( 'Please select a valid form', 'formidable' );
2456 2256 } elseif ( ! FrmForm::is_visible_to_user( $form ) ) {
2457 2257 $form = do_shortcode( $frm_settings->login_msg );
2458 2258 } else {
@@ -2472,18 +2272,16 @@
2472 2272 }
2473 2273
2474 2274 /**
2475 2275 * @param false|int|string $id
2476 - *
2477 2276 * @return false|stdClass
2478 2277 */
2479 2278 private static function maybe_get_form_to_show( $id ) {
2480 2279 $form = false;
2481 2280
2482 - if ( $id ) {
2281 + if ( ! empty( $id ) ) {
2483 2282 // Form id or key is set.
2484 2283 $form = FrmForm::getOne( $id );
2485 -
2486 2284 if ( ! $form || $form->parent_form_id || $form->status === 'trash' ) {
2487 2285 $form = false;
2488 2286 }
2489 2287 }
@@ -2490,25 +2288,12 @@
2490 2288
2491 2289 return $form;
2492 2290 }
2493 2291
2494 - /**
2495 - * @param object $form
2496 - *
2497 - * @return bool
2498 - */
2499 2292 private static function is_viewable_draft_form( $form ) {
2500 2293 return $form->status === 'draft' && current_user_can( 'frm_edit_forms' ) && ! FrmAppHelper::is_preview_page();
2501 2294 }
2502 2295
2503 - /**
2504 - * @param object $form
2505 - * @param bool $title
2506 - * @param bool $description
2507 - * @param array $atts
2508 - *
2509 - * @return string
2510 - */
2511 2296 public static function get_form( $form, $title, $description, $atts = array() ) {
2512 2297 ob_start();
2513 2298
2514 2299 do_action( 'frm_before_get_form', $atts );
@@ -2515,9 +2300,10 @@
2515 2300
2516 2301 self::get_form_contents( $form, $title, $description, $atts );
2517 2302 self::enqueue_scripts( FrmForm::get_params( $form ) );
2518 2303
2519 - $contents = ob_get_clean();
2304 + $contents = ob_get_contents();
2305 + ob_end_clean();
2520 2306
2521 2307 self::maybe_minimize_form( $atts, $contents );
2522 2308
2523 2309 return $contents;
@@ -2522,25 +2308,12 @@
2522 2308
2523 2309 return $contents;
2524 2310 }
2525 2311
2526 - /**
2527 - * @param array $params
2528 - *
2529 - * @return void
2530 - */
2531 2312 public static function enqueue_scripts( $params ) {
2532 2313 do_action( 'frm_enqueue_form_scripts', $params );
2533 2314 }
2534 2315
2535 - /**
2536 - * @param object $form
2537 - * @param bool $title
2538 - * @param bool $description
2539 - * @param array $atts
2540 - *
2541 - * @return void
2542 - */
2543 2316 public static function get_form_contents( $form, $title, $description, $atts ) {
2544 2317 $params = FrmForm::get_params( $form );
2545 2318 $errors = self::get_saved_errors( $form, $params );
2546 2319 $fields = FrmFieldsHelper::get_form_fields( $form->id, $errors );
@@ -2547,10 +2320,9 @@
2547 2320 $reset = false;
2548 2321 $pass_args = compact( 'form', 'fields', 'errors', 'title', 'description', 'reset' );
2549 2322
2550 2323 $pass_args['action'] = $params['action'];
2551 - // phpcs:ignore WordPress.Security.NonceVerification.Missing, Universal.Operators.StrictComparisons
2552 - $handle_process_here = $params['action'] === 'create' && $params['posted_form_id'] == $form->id && $_POST;
2324 + $handle_process_here = $params['action'] === 'create' && $params['posted_form_id'] == $form->id && $_POST; // phpcs:ignore WordPress.Security.NonceVerification.Missing
2553 2325
2554 2326 if ( ! $handle_process_here ) {
2555 2327 FrmFormState::set_initial_value( 'title', $title );
2556 2328 FrmFormState::set_initial_value( 'description', $description );
@@ -2555,15 +2327,16 @@
2555 2327 FrmFormState::set_initial_value( 'title', $title );
2556 2328 FrmFormState::set_initial_value( 'description', $description );
2557 2329
2558 2330 do_action( 'frm_display_form_action', $params, $fields, $form, $title, $description );
2559 -
2560 2331 if ( apply_filters( 'frm_continue_to_new', true, $form->id, $params['action'] ) ) {
2561 2332 self::show_form_after_submit( $pass_args );
2562 2333 }
2563 - } elseif ( $errors ) {
2334 + } elseif ( ! empty( $errors ) ) {
2564 2335 self::show_form_after_submit( $pass_args );
2336 +
2565 2337 } else {
2338 +
2566 2339 do_action( 'frm_validate_form_creation', $params, $fields, $form, $title, $description );
2567 2340
2568 2341 if ( apply_filters( 'frm_continue_to_create', true, $form->id ) ) {
2569 2342 $entry_id = self::just_created_entry( $form->id );
@@ -2586,19 +2359,13 @@
2586 2359 /**
2587 2360 * If the form was processed earlier (init), get the generated errors
2588 2361 *
2589 2362 * @since 2.05
2590 - *
2591 - * @param object $form
2592 - * @param array $params
2593 - *
2594 - * @return array
2595 2363 */
2596 2364 private static function get_saved_errors( $form, $params ) {
2597 2365 global $frm_vars;
2598 2366
2599 - // phpcs:ignore WordPress.Security.NonceVerification.Missing, Universal.Operators.StrictComparisons
2600 - if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) {
2367 + if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
2601 2368 $errors = $frm_vars['created_entries'][ $form->id ]['errors'];
2602 2369 } else {
2603 2370 $errors = array();
2604 2371 }
@@ -2615,16 +2382,13 @@
2615 2382 }
2616 2383
2617 2384 /**
2618 2385 * @since 2.2.7
2619 - *
2620 - * @param int|string $form_id
2621 - *
2622 - * @return int
2623 2386 */
2624 2387 public static function just_created_entry( $form_id ) {
2625 2388 global $frm_vars;
2626 - return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0; // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2389 +
2390 + return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
2627 2391 }
2628 2392
2629 2393 /**
2630 2394 * Gets confirmation method.
@@ -2637,9 +2401,8 @@
2637 2401 *
2638 2402 * @type object $form Form object.
2639 2403 * @type int $entry_id Entry ID.
2640 2404 * }
2641 - *
2642 2405 * @return array|string
2643 2406 */
2644 2407 private static function get_confirmation_method( $atts ) {
2645 2408 $action = FrmOnSubmitHelper::current_event( $atts );
@@ -2647,9 +2410,8 @@
2647 2410 $method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
2648 2411
2649 2412 if ( ! empty( $atts['entry_id'] ) ) {
2650 2413 $met_actions = self::get_met_on_submit_actions( $atts, $action );
2651 -
2652 2414 if ( $met_actions ) {
2653 2415 $method = $met_actions;
2654 2416 }
2655 2417 }
@@ -2656,21 +2418,14 @@
2656 2418
2657 2419 $method = apply_filters( 'frm_success_filter', $method, $atts['form'], $action );
2658 2420
2659 2421 if ( $method !== 'message' && ( ! $atts['entry_id'] || ! is_numeric( $atts['entry_id'] ) ) ) {
2660 - return 'message';
2422 + $method = 'message';
2661 2423 }
2662 2424
2663 2425 return $method;
2664 2426 }
2665 2427
2666 - /**
2667 - * @param object $form
2668 - * @param array $params
2669 - * @param array $args
2670 - *
2671 - * @return void
2672 - */
2673 2428 public static function maybe_trigger_redirect( $form, $params, $args ) {
2674 2429 if ( ! isset( $params['id'] ) ) {
2675 2430 global $frm_vars;
2676 2431 $params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
@@ -2697,12 +2452,14 @@
2697 2452 * @param array $params See {@see FrmFormsController::maybe_trigger_redirect()}.
2698 2453 * @param array $args See {@see FrmFormsController::maybe_trigger_redirect()}.
2699 2454 */
2700 2455 public static function maybe_trigger_redirect_with_action( $conf_method, $form, $params, $args ) {
2701 - if ( is_array( $conf_method ) && 1 === count( $conf_method ) && 'redirect' === FrmOnSubmitHelper::get_action_type( $conf_method[0] ) && empty( $conf_method[0]->post_content['redirect_delay'] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2702 - $event = FrmOnSubmitHelper::current_event( $params );
2703 - FrmOnSubmitHelper::populate_on_submit_data( $form->options, $conf_method[0], $event );
2704 - $conf_method = 'redirect';
2456 + if ( is_array( $conf_method ) && 1 === count( $conf_method ) ) {
2457 + if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $conf_method[0] ) && empty( $conf_method[0]->post_content['redirect_delay'] ) ) {
2458 + $event = FrmOnSubmitHelper::current_event( $params );
2459 + FrmOnSubmitHelper::populate_on_submit_data( $form->options, $conf_method[0], $event );
2460 + $conf_method = 'redirect';
2461 + }
2705 2462 }
2706 2463
2707 2464 if ( 'redirect' === $conf_method ) {
2708 2465 self::trigger_redirect( $form, $params, $args );
@@ -2708,15 +2465,8 @@
2708 2465 self::trigger_redirect( $form, $params, $args );
2709 2466 }
2710 2467 }
2711 2468
2712 - /**
2713 - * @param object $form
2714 - * @param array $params
2715 - * @param array $args
2716 - *
2717 - * @return void
2718 - */
2719 2469 public static function trigger_redirect( $form, $params, $args ) {
2720 2470 $success_args = array(
2721 2471 'action' => $params['action'],
2722 2472 'conf_method' => 'redirect',
@@ -2775,9 +2525,8 @@
2775 2525 * @since 6.0
2776 2526 *
2777 2527 * @param array $args See {@see FrmFormsController::run_success_action()}.
2778 2528 * @param string $event Form event. Default is `create`.
2779 - *
2780 2529 * @return array Array of actions that meet the conditional logics.
2781 2530 */
2782 2531 public static function get_met_on_submit_actions( $args, $event = 'create' ) {
2783 2532 if ( ! FrmOnSubmitHelper::form_has_migrated( $args['form'] ) ) {
@@ -2804,11 +2553,13 @@
2804 2553 }
2805 2554
2806 2555 $action_type = FrmOnSubmitHelper::get_action_type( $action );
2807 2556
2808 - if ( 'redirect' === $action_type && $has_redirect ) {
2809 - // Do not process because we run the first redirect action only.
2810 - continue;
2557 + if ( 'redirect' === $action_type ) {
2558 + if ( $has_redirect ) {
2559 + // Do not process because we run the first redirect action only.
2560 + continue;
2561 + }
2811 2562 }
2812 2563
2813 2564 if ( ! self::is_valid_on_submit_action( $action, $args, $event ) ) {
2814 2565 continue;
@@ -2833,10 +2584,10 @@
2833 2584 * @param array $args See {@see FrmFormsController::run_success_action()}. `$args['event']` is also added.
2834 2585 */
2835 2586 $met_actions = apply_filters( 'frm_get_met_on_submit_actions', $met_actions, $args );
2836 2587
2837 - if ( ! $met_actions ) {
2838 - return array( FrmOnSubmitHelper::get_fallback_action( $event ) );
2588 + if ( empty( $met_actions ) ) {
2589 + $met_actions = array( FrmOnSubmitHelper::get_fallback_action( $event ) );
2839 2590 }
2840 2591
2841 2592 return $met_actions;
2842 2593 }
@@ -2848,9 +2599,8 @@
2848 2599 *
2849 2600 * @param object $action Form action object.
2850 2601 * @param array $args See {@see FrmFormsController::run_success_action()}.
2851 2602 * @param string $event Form event. Default is `create`.
2852 - *
2853 2603 * @return bool
2854 2604 */
2855 2605 private static function is_valid_on_submit_action( $action, $args, $event = 'create' ) {
2856 2606 $action_type = FrmOnSubmitHelper::get_action_type( $action );
@@ -2872,9 +2622,8 @@
2872 2622 return false;
2873 2623 }
2874 2624
2875 2625 $page = get_post( $action->post_content['success_page_id'] );
2876 -
2877 2626 if ( ! $page || 'trash' === $page->post_status ) {
2878 2627 return false;
2879 2628 }
2880 2629 }
@@ -2896,9 +2645,8 @@
2896 2645 'entry_id' => $args['entry_id'],
2897 2646 'action' => FrmOnSubmitHelper::current_event( $args ),
2898 2647 )
2899 2648 );
2900 -
2901 2649 if ( ! is_array( $args['conf_method'] ) ) {
2902 2650 self::run_success_action( $args );
2903 2651 return;
2904 2652 }
@@ -2925,9 +2673,8 @@
2925 2673 * @param array $args See {@see FrmFormsController::run_success_action()}.
2926 2674 */
2927 2675 public static function run_multi_on_submit_actions( $args ) {
2928 2676 $redirect_action = null;
2929 -
2930 2677 foreach ( $args['conf_method'] as $action ) {
2931 2678 if ( 'redirect' === FrmOnSubmitHelper::get_action_type( $action ) ) {
2932 2679 // We catch the redirect action to run it last.
2933 2680 $redirect_action = $action;
@@ -2938,15 +2685,13 @@
2938 2685
2939 2686 unset( $action );
2940 2687 }
2941 2688
2942 - if ( ! $redirect_action ) {
2943 - return;
2689 + if ( $redirect_action ) {
2690 + // Show script to delay the redirection.
2691 + $args['force_delay_redirect'] = true;
2692 + self::run_single_on_submit_action( $args, $redirect_action );
2944 2693 }
2945 -
2946 - // Show script to delay the redirection.
2947 - $args['force_delay_redirect'] = true;
2948 - self::run_single_on_submit_action( $args, $redirect_action );
2949 2694 }
2950 2695
2951 2696 /**
2952 2697 * Runs single On Submit action.
@@ -2967,9 +2712,8 @@
2967 2712 * @since 6.0
2968 2713 *
2969 2714 * @param array $args See {@see FrmFormsController::run_success_action()}.
2970 2715 * @param object $action On Submit action object.
2971 - *
2972 2716 * @return array
2973 2717 */
2974 2718 private static function get_run_success_action_args( $args, $action ) {
2975 2719 $new_args = $args;
@@ -2975,9 +2719,10 @@
2975 2719 $new_args = $args;
2976 2720
2977 2721 FrmOnSubmitHelper::populate_on_submit_data( $new_args['form']->options, $action, $args['action'] );
2978 2722
2979 - $opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2723 + $opt = 'update' === $args['action'] ? 'edit_' : 'success_';
2724 +
2980 2725 $new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
2981 2726
2982 2727 /**
2983 2728 * Filters the run success action args.
@@ -2992,18 +2737,12 @@
2992 2737 }
2993 2738
2994 2739 /**
2995 2740 * @since 3.0
2996 - *
2997 - * @param array $args
2998 - *
2999 - * @return void
3000 2741 */
3001 2742 private static function load_page_after_submit( $args ) {
3002 2743 global $post;
3003 2744 $opt = $args['success_opt'];
3004 -
3005 - // phpcs:ignore Universal.Operators.StrictComparisons
3006 2745 if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
3007 2746 $page = get_post( $args['form']->options[ $opt . '_page_id' ] );
3008 2747 $old_post = $post;
3009 2748 $post = $page;
@@ -3027,9 +2766,8 @@
3027 2766 }
3028 2767
3029 2768 /**
3030 2769 * @since 3.0
3031 - *
3032 2770 * @param array $args See {@see FrmFormsController::run_success_action()}.
3033 2771 */
3034 2772 private static function redirect_after_submit( $args ) {
3035 2773 add_filter( 'frm_use_wpautop', '__return_false' );
@@ -3043,10 +2781,11 @@
3043 2781 FrmEntriesController::delete_entry_before_redirect( $success_url, $args['form'], $args );
3044 2782
3045 2783 add_filter( 'frm_redirect_url', 'FrmEntriesController::prepare_redirect_url' );
3046 2784 $success_url = apply_filters( 'frm_redirect_url', $success_url, $args['form'], $args );
3047 - $doing_ajax = FrmAppHelper::doing_ajax();
3048 2785
2786 + $doing_ajax = FrmAppHelper::doing_ajax();
2787 +
3049 2788 if ( ! empty( $args['ajax'] ) && $doing_ajax && empty( $args['force_delay_redirect'] ) ) {
3050 2789 // Is AJAX submit and there is just one Redirect action runs.
3051 2790 echo json_encode( self::get_ajax_redirect_response_data( $args + compact( 'success_url' ) ) );
3052 2791 wp_die();
@@ -3095,9 +2834,8 @@
3095 2834 *
3096 2835 * @since 6.3.1
3097 2836 *
3098 2837 * @param array $args See {@see FrmFormsController::run_success_action()}.
3099 - *
3100 2838 * @return array
3101 2839 */
3102 2840 private static function get_ajax_redirect_response_data( $args ) {
3103 2841 $response_data = array(
@@ -3120,9 +2858,8 @@
3120 2858 $args['message'] = FrmOnSubmitHelper::get_default_new_tab_msg();
3121 2859
3122 2860 $args['form']->options['success_msg'] = $args['message'];
3123 2861 $args['form']->options['edit_msg'] = $args['message'];
3124 -
3125 2862 if ( ! isset( $args['fields'] ) ) {
3126 2863 $args['fields'] = FrmField::get_all_for_form( $args['form']->id );
3127 2864 }
3128 2865
@@ -3174,15 +2911,13 @@
3174 2911 add_filter( 'frm_use_wpautop', '__return_true' );
3175 2912
3176 2913 echo FrmAppHelper::maybe_kses( $redirect_msg ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
3177 2914 echo '<script>';
3178 -
3179 2915 if ( empty( $args['doing_ajax'] ) ) {
3180 2916 // Not AJAX submit, delay JS until window.load.
3181 2917 echo 'window.onload=function(){';
3182 2918 }
3183 2919 echo 'setTimeout(function(){' . $redirect_js . '}, ' . intval( $delay_time ) . ');'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
3184 -
3185 2920 if ( empty( $args['doing_ajax'] ) ) {
3186 2921 echo '};';
3187 2922 }
3188 2923 echo '</script>';
@@ -3195,16 +2930,13 @@
3195 2930 * @param string $success_msg
3196 2931 * @param array $args
3197 2932 */
3198 2933 private static function get_redirect_message( $success_url, $success_msg, $args ) {
3199 - $success_msg = apply_filters( 'frm_content', $success_msg, $args['form'], $args['entry_id'] );
3200 - $success_msg = do_shortcode( FrmAppHelper::use_wpautop( $success_msg ) );
3201 -
3202 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
3203 - $redirect_msg = '<div class="' . esc_attr( FrmFormsHelper::get_form_style_class( $args['form'] ) ) . '"><div class="frm-redirect-msg" role="status">' . $success_msg . '<br/>' . // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
2934 + $success_msg = apply_filters( 'frm_content', $success_msg, $args['form'], $args['entry_id'] );
2935 + $success_msg = do_shortcode( FrmAppHelper::use_wpautop( $success_msg ) );
2936 + $redirect_msg = '<div class="' . esc_attr( FrmFormsHelper::get_form_style_class( $args['form'] ) ) . '"><div class="frm-redirect-msg" role="status">' . $success_msg . '<br/>' .
3204 2937 self::get_redirect_fallback_message( $success_url, $args ) .
3205 2938 '</div></div>';
3206 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
3207 2939
3208 2940 $redirect_args = array(
3209 2941 'entry_id' => $args['entry_id'],
3210 2942 'form_id' => $args['form']->id,
@@ -3220,14 +2952,12 @@
3220 2952 * @since 6.3.1
3221 2953 *
3222 2954 * @param string $success_url Redirect URL.
3223 2955 * @param array $args Contains `form` object.
3224 - *
3225 2956 * @return string
3226 2957 */
3227 2958 private static function get_redirect_fallback_message( $success_url, $args ) {
3228 2959 $target = '';
3229 -
3230 2960 if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
3231 2961 $target = ' target="_blank"';
3232 2962 }
3233 2963
@@ -3242,12 +2972,8 @@
3242 2972 /**
3243 2973 * Prepare to show the success message and empty form after submit
3244 2974 *
3245 2975 * @since 2.05
3246 - *
3247 - * @param array $atts
3248 - *
3249 - * @return void
3250 2976 */
3251 2977 public static function show_message_after_save( $atts ) {
3252 2978 $atts['message'] = self::prepare_submit_message( $atts['form'], $atts['entry_id'], $atts );
3253 2979
@@ -3253,9 +2979,8 @@
3253 2979
3254 2980 if ( ! isset( $atts['form']->options['show_form'] ) || $atts['form']->options['show_form'] ) {
3255 2981 if ( isset( $atts['action'] ) && 'update' === $atts['action'] && is_callable( array( 'FrmProEntriesController', 'show_front_end_form_with_entry' ) ) ) {
3256 2982 $entry = FrmEntry::getOne( $atts['entry_id'] );
3257 -
3258 2983 if ( $entry ) {
3259 2984 // This is copied from the Pro plugin.
3260 2985 $atts['conf_message'] = FrmProEntriesController::confirmation( 'message', $atts['form'], $atts['form']->options, $entry->id, $atts );
3261 2986 $atts['show_form'] = FrmProEntriesController::is_form_displayed_after_edit( $atts['form'] );
@@ -3272,12 +2997,8 @@
3272 2997 /**
3273 2998 * Show an empty form
3274 2999 *
3275 3000 * @since 2.05
3276 - *
3277 - * @param array $args
3278 - *
3279 - * @return void
3280 3001 */
3281 3002 private static function show_form_after_submit( $args ) {
3282 3003 self::fill_atts_for_form_display( $args );
3283 3004
@@ -3296,11 +3017,12 @@
3296 3017 }
3297 3018 unset( $args );
3298 3019
3299 3020 $include_form_tag = apply_filters( 'frm_include_form_tag', true, $form );
3300 - $frm_settings = FrmAppHelper::get_settings();
3301 - $submit = $form->options['submit_value'] ?? $frm_settings->submit_value;
3302 3021
3022 + $frm_settings = FrmAppHelper::get_settings();
3023 + $submit = isset( $form->options['submit_value'] ) ? $form->options['submit_value'] : $frm_settings->submit_value;
3024 +
3303 3025 global $frm_vars;
3304 3026 self::maybe_load_css( $form, $values['custom_style'], $frm_vars['load_css'] );
3305 3027
3306 3028 $message_placement = self::message_placement( $form, $message );
@@ -3308,36 +3030,25 @@
3308 3030 include FrmAppHelper::plugin_path() . '/classes/views/frm-entries/new.php';
3309 3031 }
3310 3032
3311 3033 /**
3312 - * Gets message placement.
3313 - *
3314 3034 * @since 4.05.02
3315 - * @since 6.26 This method changed from `private` to `public`.
3316 - *
3317 - * @param object $form Form object.
3318 - * @param string $message The message.
3319 - *
3320 - * @return string Accepts 'before', 'after', or 'submit'.
3035 + * @return string - 'before', 'after', or 'submit'
3321 3036 */
3322 - public static function message_placement( $form, $message ) {
3037 + private static function message_placement( $form, $message ) {
3323 3038 $place = 'before';
3324 3039
3325 3040 if ( $message && isset( $form->options['form_class'] ) ) {
3326 - if ( str_contains( $form->options['form_class'], 'frm_below_success' ) ) {
3041 + if ( strpos( $form->options['form_class'], 'frm_below_success' ) !== false ) {
3327 3042 $place = 'after';
3328 - } elseif ( str_contains( $form->options['form_class'], 'frm_inline_success' ) ) {
3043 + } elseif ( strpos( $form->options['form_class'], 'frm_inline_success' ) !== false ) {
3329 3044 $place = 'submit';
3330 3045 }
3331 3046 }
3332 3047
3333 3048 /**
3334 - * Filter the message placement.
3335 - *
3336 3049 * @since 4.05.02
3337 - *
3338 - * @param string $place Accepts 'before', 'after', or 'submit'.
3339 - * @param array $args Args.
3050 + * @return string - 'before' or 'after'
3340 3051 */
3341 3052 return apply_filters( 'frm_message_placement', $place, compact( 'form', 'message' ) );
3342 3053 }
3343 3054
@@ -3344,12 +3055,8 @@
3344 3055 /**
3345 3056 * Get all the values needed on the new.php entry page
3346 3057 *
3347 3058 * @since 2.05
3348 - *
3349 - * @param array $args
3350 - *
3351 - * @return void
3352 3059 */
3353 3060 private static function fill_atts_for_form_display( &$args ) {
3354 3061 if ( ! isset( $args['title'] ) && isset( $args['show_title'] ) ) {
3355 3062 $args['title'] = $args['show_title'];
@@ -3374,12 +3081,8 @@
3374 3081 /**
3375 3082 * Show the success message without the form
3376 3083 *
3377 3084 * @since 2.05
3378 - *
3379 - * @param array $atts
3380 - *
3381 - * @return void
3382 3085 */
3383 3086 private static function show_lone_success_message( $atts ) {
3384 3087 global $frm_vars;
3385 3088 $values = FrmEntriesHelper::setup_new_vars( $atts['fields'], $atts['form'], true );
@@ -3385,12 +3088,13 @@
3385 3088 $values = FrmEntriesHelper::setup_new_vars( $atts['fields'], $atts['form'], true );
3386 3089 self::maybe_load_css( $atts['form'], $values['custom_style'], $frm_vars['load_css'] );
3387 3090
3388 3091 $include_extra_container = 'frm_forms' . FrmFormsHelper::get_form_style_class( $values );
3389 - $errors = array();
3390 - $form = $atts['form'];
3391 - $message = $atts['message'];
3392 3092
3093 + $errors = array();
3094 + $form = $atts['form'];
3095 + $message = $atts['message'];
3096 +
3393 3097 include FrmAppHelper::plugin_path() . '/classes/views/frm-entries/errors.php';
3394 3098 }
3395 3099
3396 3100 /**
@@ -3398,20 +3102,19 @@
3398 3102 *
3399 3103 * @since 2.05
3400 3104 * @since 6.0.x Added the third parameter.
3401 3105 *
3402 - * @param object $form Form object.
3403 - * @param int|string $entry_id Entry ID.
3404 - * @param array $args See {@see FrmFormsController::run_success_action()}.
3405 - *
3106 + * @param object $form Form object.
3107 + * @param int $entry_id Entry ID.
3108 + * @param array $args See {@see FrmFormsController::run_success_action()}.
3406 3109 * @return string
3407 3110 */
3408 3111 private static function prepare_submit_message( $form, $entry_id, $args = array() ) {
3409 3112 $frm_settings = FrmAppHelper::get_settings( array( 'current_form' => $form->id ) );
3410 - $opt = $args['success_opt'] ?? 'success';
3113 + $opt = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
3411 3114
3412 3115 if ( $entry_id && is_numeric( $entry_id ) ) {
3413 - $message = $form->options[ $opt . '_msg' ] ?? $frm_settings->success_msg;
3116 + $message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
3414 3117 $class = 'frm_message';
3415 3118 } else {
3416 3119 $message = $frm_settings->failed_msg;
3417 3120 $class = FrmFormsHelper::form_error_class();
@@ -3428,9 +3131,9 @@
3428 3131 public static function front_head() {
3429 3132 $version = FrmAppHelper::plugin_version();
3430 3133 $suffix = FrmAppHelper::js_suffix();
3431 3134
3432 - if ( $suffix && self::has_combo_js_file() ) {
3135 + if ( ! empty( $suffix ) && self::has_combo_js_file() ) {
3433 3136 wp_register_script( 'formidable', FrmAppHelper::plugin_url() . '/js/frm.min.js', array( 'jquery' ), $version, true );
3434 3137 } else {
3435 3138 wp_register_script( 'formidable', FrmAppHelper::plugin_url() . "/js/formidable{$suffix}.js", array( 'jquery' ), $version, true );
3436 3139 }
@@ -3437,9 +3140,9 @@
3437 3140
3438 3141 add_filter( 'script_loader_tag', 'FrmFormsController::defer_script_loading', 10, 2 );
3439 3142
3440 3143 if ( FrmAppHelper::is_admin() ) {
3441 - // Don't load this in back-end
3144 + // don't load this in back-end
3442 3145 return;
3443 3146 }
3444 3147
3445 3148 FrmAppHelper::localize_script( 'front' );
@@ -3452,15 +3155,8 @@
3452 3155 public static function has_combo_js_file() {
3453 3156 return is_readable( FrmAppHelper::plugin_path() . '/js/frm.min.js' );
3454 3157 }
3455 3158
3456 - /**
3457 - * @param object $form
3458 - * @param int|string $this_load
3459 - * @param bool $global_load
3460 - *
3461 - * @return void
3462 - */
3463 3159 public static function maybe_load_css( $form, $this_load, $global_load ) {
3464 3160 $load_css = FrmForm::is_form_loaded( $form, $this_load, $global_load );
3465 3161
3466 3162 if ( ! $load_css ) {
@@ -3490,9 +3186,8 @@
3490 3186 return;
3491 3187 }
3492 3188
3493 3189 global $wp_styles;
3494 -
3495 3190 if ( is_array( $wp_styles->queue ) && in_array( 'formidable', $wp_styles->queue, true ) ) {
3496 3191 wp_print_styles( 'formidable' );
3497 3192 }
3498 3193 }
@@ -3507,57 +3202,32 @@
3507 3202 private static function should_load_late() {
3508 3203 return ! function_exists( 'aioseo' );
3509 3204 }
3510 3205
3511 - /**
3512 - * @param string $tag
3513 - * @param string $handle
3514 - *
3515 - * @return string
3516 - */
3517 3206 public static function defer_script_loading( $tag, $handle ) {
3518 - if ( 'captcha-api' === $handle && ! str_contains( $tag, 'defer' ) ) {
3519 - return str_replace( ' src', ' defer="defer" async="async" src', $tag );
3207 + if ( 'captcha-api' == $handle && ! strpos( $tag, 'defer' ) ) {
3208 + $tag = str_replace( ' src', ' defer="defer" async="async" src', $tag );
3520 3209 }
3521 3210
3522 3211 return $tag;
3523 3212 }
3524 3213
3525 - /**
3526 - * @param string $location
3527 - *
3528 - * @return void
3529 - */
3530 3214 public static function footer_js( $location = 'footer' ) {
3531 3215 global $frm_vars;
3532 3216
3533 3217 FrmStylesController::enqueue_css();
3534 3218
3535 - if ( FrmAppHelper::is_admin() || $location === 'header' || empty( $frm_vars['forms_loaded'] ) ) {
3536 - return;
3219 + if ( ! FrmAppHelper::is_admin() && $location !== 'header' && ! empty( $frm_vars['forms_loaded'] ) ) {
3220 + // load formidable js
3221 + wp_enqueue_script( 'formidable' );
3537 3222 }
3538 -
3539 - // Load formidable js
3540 - wp_enqueue_script( 'formidable' );
3541 -
3542 - FrmHoneypot::maybe_print_honeypot_js();
3543 -
3544 - if ( ! method_exists( 'FrmProFormsHelper', 'load_currency_js' ) ) {
3545 - // Load currency JS if Pro is not installed.
3546 - FrmFormsHelper::load_currency_js();
3547 - }
3548 3223 }
3549 3224
3550 3225 /**
3551 3226 * @since 2.0.8
3552 - *
3553 - * @param array $atts
3554 - * @param string $content
3555 - *
3556 - * @return void
3557 3227 */
3558 3228 private static function maybe_minimize_form( $atts, &$content ) {
3559 - // Check if minimizing is turned on
3229 + // check if minimizing is turned on
3560 3230 if ( self::is_minification_on( $atts ) ) {
3561 3231 $content = str_replace( array( "\r\n", "\r", "\n", "\t", ' ' ), '', $content );
3562 3232 }
3563 3233 }
@@ -3563,11 +3233,8 @@
3563 3233 }
3564 3234
3565 3235 /**
3566 3236 * @since 2.0.8
3567 - *
3568 - * @param array $atts
3569 - *
3570 3237 * @return bool
3571 3238 */
3572 3239 private static function is_minification_on( $atts ) {
3573 3240 return ! empty( $atts['minimize'] );
@@ -3579,13 +3246,11 @@
3579 3246 * @return void
3580 3247 */
3581 3248 public static function landing_page_preview_option() {
3582 3249 $dir = apply_filters( 'frm_landing_page_preview_option', false );
3583 -
3584 3250 if ( false === $dir || ! file_exists( $dir . 'landing-page-preview-option.php' ) ) {
3585 3251 $dir = self::get_form_views_path();
3586 3252 }
3587 -
3588 3253 include $dir . 'landing-page-preview-option.php';
3589 3254 }
3590 3255
3591 3256 /**
@@ -3611,15 +3276,13 @@
3611 3276
3612 3277 check_ajax_referer( 'frm_ajax', 'nonce' );
3613 3278
3614 3279 $type = FrmAppHelper::get_post_param( 'type', '', 'sanitize_text_field' );
3615 -
3616 3280 if ( ! $type || ! in_array( $type, array( 'form', 'view' ), true ) ) {
3617 3281 die( 0 );
3618 3282 }
3619 3283
3620 3284 $object_id = FrmAppHelper::get_post_param( 'object_id', '', 'absint' );
3621 -
3622 3285 if ( ! $object_id ) {
3623 3286 die( 0 );
3624 3287 }
3625 3288
@@ -3631,15 +3294,13 @@
3631 3294 $postarr['post_content'] = apply_filters( 'frm_create_page_with_' . $type . '_shortcode_content', '', $object_id );
3632 3295 }
3633 3296
3634 3297 $name = FrmAppHelper::get_post_param( 'name', '', 'sanitize_text_field' );
3635 -
3636 3298 if ( $name ) {
3637 3299 $postarr['post_title'] = $name;
3638 3300 }
3639 3301
3640 3302 $success = wp_insert_post( $postarr );
3641 -
3642 3303 if ( ! is_numeric( $success ) || ! $success ) {
3643 3304 die( 0 );
3644 3305 }
3645 3306
@@ -3653,9 +3314,8 @@
3653 3314 /**
3654 3315 * @since 5.3
3655 3316 *
3656 3317 * @param int $form_id
3657 - *
3658 3318 * @return string
3659 3319 */
3660 3320 private static function get_page_shortcode_content_for_form( $form_id ) {
3661 3321 $shortcode = '[formidable id="' . $form_id . '"]';
@@ -3675,9 +3335,9 @@
3675 3335 }
3676 3336
3677 3337 check_ajax_referer( 'frm_ajax', 'nonce' );
3678 3338
3679 - $html = FrmAppHelper::clip(
3339 + $html = FrmAppHelper::clip(
3680 3340 function () {
3681 3341 FrmAppHelper::maybe_autocomplete_pages_options(
3682 3342 array(
3683 3343 'field_name' => 'frm_page_dropdown',
@@ -3686,12 +3346,13 @@
3686 3346 )
3687 3347 );
3688 3348 }
3689 3349 );
3350 + $post_type_object = get_post_type_object( 'page' );
3690 3351 wp_send_json(
3691 3352 array(
3692 3353 'html' => $html,
3693 - 'edit_page_url' => admin_url( sprintf( get_post_type_object( 'page' )->_edit_link . '&action=edit', 0 ) ),
3354 + 'edit_page_url' => admin_url( sprintf( $post_type_object->_edit_link . '&action=edit', 0 ) ),
3694 3355 )
3695 3356 );
3696 3357 }
3697 3358
@@ -3696,14 +3357,23 @@
3696 3357 }
3697 3358
3698 3359 /**
3699 3360 * @deprecated 4.0
3361 + */
3362 + public static function create( $values = array() ) {
3363 + _deprecated_function( __METHOD__, '4.0', 'FrmFormsController::update' );
3364 + self::update( $values );
3365 + }
3366 +
3367 + /**
3368 + * Education for premium features.
3700 3369 *
3701 - * @param array $values
3370 + * @since 4.05
3371 + * @deprecated 6.16.3
3702 3372 *
3703 3373 * @return void
3704 3374 */
3705 - public static function create( $values = array() ) {
3706 - _deprecated_function( __METHOD__, '4.0', 'FrmFormsController::update' );
3707 - self::update( $values );
3375 + public static function add_form_style_tab_options() {
3376 + _deprecated_function( __METHOD__, '6.16.3' );
3377 + include FrmAppHelper::plugin_path() . '/classes/views/frm-forms/add_form_style_options.php';
3708 3378 }
3709 3379 }