PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.20
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.20
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/models/FrmForm.php +164 -295 6.346.20 View file →
@@ -6,9 +6,8 @@
6 6 class FrmForm {
7 7
8 8 /**
9 9 * @param array $values
10 - *
11 10 * @return bool|int id on success or false on failure.
12 11 */
13 12 public static function create( $values ) {
14 13 global $wpdb;
@@ -16,24 +15,24 @@
16 15 $values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
17 16
18 17 $new_values = array(
19 18 'form_key' => FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key' ),
20 - 'name' => FrmAppHelper::truncate( $values['name'], 255, 1, '', true ),
19 + 'name' => $values['name'],
21 20 'description' => $values['description'],
22 - 'status' => $values['status'] ?? 'published',
23 - 'logged_in' => $values['logged_in'] ?? 0,
21 + 'status' => isset( $values['status'] ) ? $values['status'] : 'published',
22 + 'logged_in' => isset( $values['logged_in'] ) ? $values['logged_in'] : 0,
24 23 'is_template' => isset( $values['is_template'] ) ? (int) $values['is_template'] : 0,
25 24 'parent_form_id' => isset( $values['parent_form_id'] ) ? absint( $values['parent_form_id'] ) : 0,
26 25 'editable' => isset( $values['editable'] ) ? (int) $values['editable'] : 0,
27 - 'created_at' => $values['created_at'] ?? current_time( 'mysql', 1 ),
26 + 'created_at' => isset( $values['created_at'] ) ? $values['created_at'] : current_time( 'mysql', 1 ),
28 27 );
29 28
30 29 $options = isset( $values['options'] ) ? (array) $values['options'] : array();
31 30 FrmFormsHelper::fill_form_options( $options, $values );
32 31
33 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
34 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
35 - $options['submit_html'] = $values['options']['submit_html'] ?? FrmFormsHelper::get_default_html( 'submit' );
32 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
33 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
34 + $options['submit_html'] = isset( $values['options']['submit_html'] ) ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
36 35
37 36 /**
38 37 * Allows modifying form options before updating or creating.
39 38 *
@@ -60,9 +59,8 @@
60 59 /**
61 60 * @since 5.0.08
62 61 *
63 62 * @param array $options
64 - *
65 63 * @return array
66 64 */
67 65 private static function maybe_filter_form_options( $options ) {
68 66 if ( ! FrmAppHelper::allow_unfiltered_html() && ! empty( $options['submit_html'] ) ) {
@@ -71,15 +69,8 @@
71 69 return FrmAppHelper::maybe_filter_array( $options, array( 'submit_value', 'success_msg', 'before_html', 'after_html' ) );
72 70 }
73 71
74 72 /**
75 - * Duplicate a form.
76 - *
77 - * @param int $id Form ID to duplicate.
78 - * @param bool $template Whether the duplicated form is a template.
79 - * @param bool $copy_keys Whether to copy the original form key.
80 - * @param false|int $blog_id Blog ID when duplicating across sites, or false for current site.
81 - *
82 73 * @return bool|int ID on success or false on failure
83 74 */
84 75 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 76 global $wpdb;
@@ -84,9 +75,8 @@
84 75 public static function duplicate( $id, $template = false, $copy_keys = false, $blog_id = false ) {
85 76 global $wpdb;
86 77
87 78 $values = self::getOne( $id, $blog_id );
88 -
89 79 if ( ! $values ) {
90 80 return false;
91 81 }
92 82
@@ -126,9 +116,9 @@
126 116
127 117 $form_id = $wpdb->insert_id;
128 118 FrmField::duplicate( $id, $form_id, $copy_keys, $blog_id );
129 119
130 - // Update form settings after fields are created
120 + // update form settings after fields are created
131 121 do_action( 'frm_after_duplicate_form', $form_id, $new_values, array( 'old_id' => $id ) );
132 122
133 123 return $form_id;
134 124 }
@@ -135,14 +125,8 @@
135 125
136 126 return false;
137 127 }
138 128
139 - /**
140 - * @param int $form_id
141 - * @param array $values
142 - *
143 - * @return void
144 - */
145 129 public static function after_duplicate( $form_id, $values ) {
146 130 $new_opts = $values['options'];
147 131 FrmAppHelper::unserialize_or_decode( $new_opts );
148 132 $values['options'] = $new_opts;
@@ -152,9 +136,8 @@
152 136 }
153 137
154 138 $new_opts = apply_filters( 'frm_after_duplicate_form_values', $new_opts, $form_id );
155 139
156 - // phpcs:ignore Universal.Operators.StrictComparisons
157 140 if ( $new_opts != $values['options'] ) {
158 141 global $wpdb;
159 142 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'options' => maybe_serialize( $new_opts ) ), array( 'id' => $form_id ) );
160 143 }
@@ -167,10 +150,8 @@
167 150 *
168 151 * @since 5.3
169 152 *
170 153 * @param int $form_id Form ID.
171 - *
172 - * @return void
173 154 */
174 155 private static function switch_field_ids_in_fields( $form_id ) {
175 156 global $wpdb;
176 157
@@ -176,9 +157,8 @@
176 157
177 158 // Keys of fields that you want to check to replace field ID.
178 159 $keys = array( 'default_value', 'field_options' );
179 160 $sql_cols = 'fi.id';
180 -
181 161 foreach ( $keys as $key ) {
182 162 $sql_cols .= ',fi.' . $key;
183 163 }
184 164
@@ -206,14 +186,11 @@
206 186 *
207 187 * @since 5.3
208 188 *
209 189 * @param array $field Field array.
210 - *
211 - * @return void
212 190 */
213 191 private static function switch_field_ids_in_field( $field ) {
214 192 $new_values = array();
215 -
216 193 foreach ( $field as $key => $value ) {
217 194 if ( 'id' === $key || ! $value ) {
218 195 continue;
219 196 }
@@ -235,20 +212,14 @@
235 212 $new_values[ $key ] = $new_val;
236 213 }
237 214 }//end foreach
238 215
239 - if ( $new_values ) {
216 + if ( ! empty( $new_values ) ) {
240 217 FrmField::update( $field['id'], $new_values );
241 218 }
242 219 }
243 220
244 221 /**
245 - * Update a form.
246 - *
247 - * @param int $id Form ID.
248 - * @param array $values Form values to update.
249 - * @param bool $create_link Whether this is being called from link creation.
250 - *
251 222 * @return bool|int
252 223 */
253 224 public static function update( $id, $values, $create_link = false ) {
254 225 global $wpdb;
@@ -263,13 +234,14 @@
263 234 $values['form_key'] = FrmAppHelper::get_unique_key( $values['form_key'], $wpdb->prefix . 'frm_forms', 'form_key', $id );
264 235 }
265 236
266 237 $form_fields = array( 'form_key', 'name', 'description', 'status', 'parent_form_id' );
267 - $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
268 238
239 + $new_values = self::set_update_options( array(), $values, array( 'form_id' => $id ) );
240 +
269 241 foreach ( $values as $value_key => $value ) {
270 - if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
271 - $new_values[ $value_key ] = 'name' === $value_key ? FrmAppHelper::truncate( $value, 255, 1, '', true ) : $value;
242 + if ( $value_key && in_array( $value_key, $form_fields ) ) {
243 + $new_values[ $value_key ] = $value;
272 244 }
273 245 }
274 246
275 247 if ( ! empty( $values['new_status'] ) ) {
@@ -275,11 +247,10 @@
275 247 if ( ! empty( $values['new_status'] ) ) {
276 248 $new_values['status'] = $values['new_status'];
277 249 }
278 250
279 - if ( $new_values ) {
251 + if ( ! empty( $new_values ) ) {
280 252 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', $new_values, array( 'id' => $id ) );
281 -
282 253 if ( $query_results ) {
283 254 self::clear_form_cache();
284 255 }
285 256 } else {
@@ -298,9 +269,8 @@
298 269 /**
299 270 * @param array $new_values
300 271 * @param array $values
301 272 * @param array $args
302 - *
303 273 * @return array
304 274 */
305 275 public static function set_update_options( $new_values, $values, $args = array() ) {
306 276 if ( ! isset( $values['options'] ) ) {
@@ -309,12 +279,12 @@
309 279
310 280 $options = ! empty( $values['options'] ) ? (array) $values['options'] : array();
311 281 FrmFormsHelper::fill_form_options( $options, $values );
312 282
313 - $options['custom_style'] = $values['options']['custom_style'] ?? 0;
314 - $options['before_html'] = $values['options']['before_html'] ?? FrmFormsHelper::get_default_html( 'before' );
315 - $options['after_html'] = $values['options']['after_html'] ?? FrmFormsHelper::get_default_html( 'after' );
316 - $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
283 + $options['custom_style'] = isset( $values['options']['custom_style'] ) ? $values['options']['custom_style'] : 0;
284 + $options['before_html'] = isset( $values['options']['before_html'] ) ? $values['options']['before_html'] : FrmFormsHelper::get_default_html( 'before' );
285 + $options['after_html'] = isset( $values['options']['after_html'] ) ? $values['options']['after_html'] : FrmFormsHelper::get_default_html( 'after' );
286 + $options['submit_html'] = isset( $values['options']['submit_html'] ) && '' !== $values['options']['submit_html'] ? $values['options']['submit_html'] : FrmFormsHelper::get_default_html( 'submit' );
317 287
318 288 /**
319 289 * Allows modifying form options before updating or creating.
320 290 *
@@ -331,14 +301,11 @@
331 301 return $new_values;
332 302 }
333 303
334 304 /**
335 - * @param int $id Form ID.
336 - * @param array $values Form values array.
337 - *
338 305 * @return array
339 306 */
340 - public static function update_fields( $id, $values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh
307 + public static function update_fields( $id, $values ) {
341 308
342 309 if ( ! isset( $values['item_meta'] ) && ! isset( $values['field_options'] ) ) {
343 310 return $values;
344 311 }
@@ -343,10 +310,9 @@
343 310 return $values;
344 311 }
345 312
346 313 $all_fields = FrmField::get_all_for_form( $id );
347 -
348 - if ( ! $all_fields ) {
314 + if ( empty( $all_fields ) ) {
349 315 return $values;
350 316 }
351 317
352 318 if ( ! isset( $values['item_meta'] ) ) {
@@ -354,28 +320,28 @@
354 320 }
355 321
356 322 $field_array = array();
357 323 $existing_keys = array_keys( $values['item_meta'] );
358 -
359 324 foreach ( $all_fields as $fid ) {
360 - // phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict, SlevomatCodingStandard.Files.LineLength.LineTooLong
361 325 if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
362 326 $values['item_meta'][ $fid->id ] = '';
363 327 }
364 -
365 328 $field_array[ $fid->id ] = $fid;
366 329 }
367 330 unset( $all_fields );
368 331
369 332 foreach ( $values['item_meta'] as $field_id => $default_value ) {
370 - $field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
333 + if ( isset( $field_array[ $field_id ] ) ) {
334 + $field = $field_array[ $field_id ];
335 + } else {
336 + $field = FrmField::getOne( $field_id );
337 + }
371 338
372 339 if ( ! $field ) {
373 340 continue;
374 341 }
375 342
376 - $is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
377 -
343 + $is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
378 344 if ( $is_settings_page ) {
379 345 self::get_settings_page_html( $values, $field );
380 346
381 347 if ( ! defined( 'WP_IMPORTING' ) ) {
@@ -388,14 +354,10 @@
388 354 // Don't check for POST html.
389 355 unset( $update_options['custom_html'] );
390 356 $update_options = apply_filters( 'frm_field_options_to_update', $update_options );
391 357
392 - if ( ! is_array( $field->field_options ) ) {
393 - $field->field_options = array();
394 - }
395 -
396 358 foreach ( $update_options as $opt => $default ) {
397 - $field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
359 + $field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
398 360 self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
399 361 }
400 362
401 363 $field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
@@ -404,17 +366,15 @@
404 366 'field_options' => $field->field_options,
405 367 'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
406 368 );
407 369
408 - if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
370 + if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
409 371 foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
410 - if ( ! is_array( $option ) ) {
411 - continue;
372 + if ( is_array( $option ) ) {
373 + foreach ( $option as $key => $item ) {
374 + $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
375 + }
412 376 }
413 -
414 - foreach ( $option as $key => $item ) {
415 - $values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
416 - }
417 377 }
418 378 }
419 379
420 380 self::prepare_field_update_values( $field, $values, $new_field );
@@ -433,34 +393,31 @@
433 393 * Resets the 'max' option of a field when changing paragraph field type to other field types like text, email etc.
434 394 *
435 395 * @since 6.7
436 396 *
437 - * @param object $field
438 - * @param array $values
439 - * @param array $new_field
440 - *
397 + * @param array $field
398 + * @param array $values
399 + * @param array $new_field
441 400 * @return void
442 401 */
443 402 private static function maybe_update_max_option( $field, $values, &$new_field ) {
444 - if ( $field->type !== 'textarea' ||
445 - empty( $values['field_options'][ 'type_' . $field->id ] ) ||
446 - ! in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
447 - return;
448 - }
403 + if ( $field->type === 'textarea' &&
404 + ! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
405 + in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
449 406
450 - $new_field['field_options']['max'] = '';
407 + $new_field['field_options']['max'] = '';
451 408
452 - /**
453 - * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
454 - * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
455 - */
456 - $_POST['field_options'][ 'max_' . $field->id ] = '';
409 + /**
410 + * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
411 + * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
412 + */
413 + $_POST['field_options'][ 'max_' . $field->id ] = '';
414 + }
457 415 }
458 416
459 417 /**
460 418 * @param string $opt
461 419 * @param mixed $value
462 - *
463 420 * @return void
464 421 */
465 422 private static function sanitize_field_opt( $opt, &$value ) {
466 423 if ( ! is_string( $value ) ) {
@@ -481,19 +438,23 @@
481 438 if ( ! $should_sanitize ) {
482 439 return;
483 440 }
484 441
485 - $value = $opt === 'calc' ? self::sanitize_calc( $value ) : FrmAppHelper::kses( $value, 'all' );
442 + if ( $opt === 'calc' ) {
443 + $value = self::sanitize_calc( $value );
444 + } else {
445 + $value = FrmAppHelper::kses( $value, 'all' );
446 + }
447 +
486 448 $value = trim( $value );
487 449 }
488 450
489 451 /**
490 452 * @param string $value
491 - *
492 453 * @return string
493 454 */
494 455 private static function sanitize_calc( $value ) {
495 - if ( str_contains( $value, '<' ) ) {
456 + if ( false !== strpos( $value, '<' ) ) {
496 457 $value = self::normalize_calc_spaces( $value );
497 458 }
498 459 // Allow <= and >=.
499 460 $allow = array( '<= ', ' >=' );
@@ -499,9 +460,10 @@
499 460 $allow = array( '<= ', ' >=' );
500 461 $temp = array( '< = ', ' > =' );
501 462 $value = str_replace( $allow, $temp, $value );
502 463 $value = strip_tags( $value );
503 - return str_replace( $temp, $allow, $value );
464 + $value = str_replace( $temp, $allow, $value );
465 + return $value;
504 466 }
505 467
506 468 /**
507 469 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
@@ -507,58 +469,41 @@
507 469 * Format a comparison like 5<10 to 5 < 10. Also works on 5< 10, 5 <10, 5<=10 variations.
508 470 * This is to avoid an issue with unspaced calculations being recognized as HTML that gets removed when strip_tags is called.
509 471 *
510 472 * @param string $calc
511 - *
512 473 * @return string
513 474 */
514 475 private static function normalize_calc_spaces( $calc ) {
515 476 // Check for a pattern with 5 parts
516 - // $1 \d|\] the first comparison digit or the end of a comparison shortcode.
477 + // $1 \d the first comparison digit.
517 478 // $2 a space (optional).
518 479 // $3 an equals sign (optional) that follows the < operator for <= comparisons.
519 480 // $4 another space (optional).
520 - // $5 \d|\[ the second comparison digit or the start of a comparison shortcode.
521 - return preg_replace( '/(\d|\])( ){0,1}<(=){0,1}( ){0,1}(\d|\[)/', '$1 <$3 $5', $calc );
481 + // $5 \d the second comparison digit.
482 + return preg_replace( '/(\d)( ){0,1}<(=){0,1}( ){0,1}(\d)/', '$1 <$3 $5', $calc );
522 483 }
523 484
524 485 /**
525 486 * Updating the settings page
526 - *
527 - * @param array $values Form values array.
528 - * @param object $field Field object, passed by reference.
529 - *
530 - * @return void
531 487 */
532 488 private static function get_settings_page_html( $values, &$field ) {
533 489 if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
534 490 $prev_opts = array();
535 - $fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
491 + $fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
536 492
537 - $field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
493 + $field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
538 494 } elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
539 495 $prev_opts = $field->field_options;
540 496 }
541 497
542 - if ( ! isset( $prev_opts ) ) {
543 - return;
498 + if ( isset( $prev_opts ) ) {
499 + $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
500 + if ( $prev_opts != $field->field_options ) {
501 + FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
502 + }
544 503 }
545 -
546 - $field->field_options = apply_filters( 'frm_update_form_field_options', $field->field_options, $field, $values );
547 -
548 - // phpcs:ignore Universal.Operators.StrictComparisons
549 - if ( $prev_opts != $field->field_options ) {
550 - FrmField::update( $field->id, array( 'field_options' => $field->field_options ) );
551 - }
552 504 }
553 505
554 - /**
555 - * @param object $field
556 - * @param array $values
557 - * @param array $new_field
558 - *
559 - * @return void
560 - */
561 506 private static function prepare_field_update_values( $field, $values, &$new_field ) {
562 507 $field_cols = array(
563 508 'field_order' => 0,
564 509 'field_key' => '',
@@ -567,12 +512,11 @@
567 512 'description' => '',
568 513 'options' => '',
569 514 'name' => '',
570 515 );
571 -
572 516 foreach ( $field_cols as $col => $default ) {
573 517 $default = $default === '' ? $field->{$col} : $default;
574 - $new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
518 + $new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
575 519 }
576 520
577 521 if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
578 522 $new_field['field_order'] = $field->field_order;
@@ -588,12 +532,9 @@
588 532 * Get a list of all form settings that should be translated
589 533 * on a multilingual site.
590 534 *
591 535 * @since 3.06.01
592 - *
593 536 * @param object $form The form object.
594 - *
595 - * @return array
596 537 */
597 538 public static function translatable_strings( $form ) {
598 539 $strings = array(
599 540 'name',
@@ -610,20 +551,19 @@
610 551 return apply_filters( 'frm_form_strings', $strings, $form );
611 552 }
612 553
613 554 /**
614 - * @param array|int $id
615 - * @param string $status
555 + * @param int $id
556 + * @param string $status
616 557 *
617 558 * @return bool|int
618 559 */
619 560 public static function set_status( $id, $status ) {
620 - if ( 'trash' === $status ) {
561 + if ( 'trash' == $status ) {
621 562 return self::trash( $id );
622 563 }
623 564
624 565 $statuses = array( 'published', 'draft', 'trash' );
625 -
626 566 if ( ! in_array( $status, $statuses, true ) ) {
627 567 return false;
628 568 }
629 569
@@ -637,9 +577,9 @@
637 577 );
638 578 FrmDb::get_where_clause_and_values( $where );
639 579 array_unshift( $where['values'], $status );
640 580
641 - $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, SlevomatCodingStandard.Files.LineLength.LineTooLong
581 + $query_results = $wpdb->query( $wpdb->prepare( 'UPDATE ' . $wpdb->prefix . 'frm_forms SET status = %s ' . $where['where'], $where['values'] ) ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
642 582 } else {
643 583 $query_results = $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'id' => $id ) );
644 584 $wpdb->update( $wpdb->prefix . 'frm_forms', array( 'status' => $status ), array( 'parent_form_id' => $id ) );
645 585 }
@@ -651,10 +591,8 @@
651 591 return $query_results;
652 592 }
653 593
654 594 /**
655 - * @param int|string $id Form ID.
656 - *
657 595 * @return bool|int
658 596 */
659 597 public static function trash( $id ) {
660 598 if ( ! EMPTY_TRASH_DAYS ) {
@@ -661,9 +599,8 @@
661 599 return self::destroy( $id );
662 600 }
663 601
664 602 $form = self::getOne( $id );
665 -
666 603 if ( ! $form ) {
667 604 return false;
668 605 }
669 606
@@ -704,10 +641,8 @@
704 641 return $query_results;
705 642 }
706 643
707 644 /**
708 - * @param int|string $id Form ID.
709 - *
710 645 * @return bool|int
711 646 */
712 647 public static function destroy( $id ) {
713 648 global $wpdb;
@@ -712,18 +647,15 @@
712 647 public static function destroy( $id ) {
713 648 global $wpdb;
714 649
715 650 $form = self::getOne( $id );
716 -
717 651 if ( ! $form ) {
718 652 return false;
719 653 }
720 -
721 654 $id = $form->id;
722 655
723 656 // Disconnect the entries from this form
724 - $entries = FrmDb::get_col( 'frm_items', array( 'form_id' => $id ) );
725 -
657 + $entries = FrmDb::get_col( $wpdb->prefix . 'frm_items', array( 'form_id' => $id ) );
726 658 foreach ( $entries as $entry_id ) {
727 659 FrmEntry::destroy( $entry_id );
728 660 unset( $entry_id );
729 661 }
@@ -728,29 +660,26 @@
728 660 unset( $entry_id );
729 661 }
730 662
731 663 // Disconnect the fields from this form
732 - $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
664 + $wpdb->query( $wpdb->prepare( 'DELETE fi FROM ' . $wpdb->prefix . 'frm_fields AS fi LEFT JOIN ' . $wpdb->prefix . 'frm_forms fr ON (fi.form_id = fr.id) WHERE fi.form_id=%d OR parent_form_id=%d', $id, $id ) );
733 665
734 666 $query_results = $wpdb->query( $wpdb->prepare( 'DELETE FROM ' . $wpdb->prefix . 'frm_forms WHERE id=%d OR parent_form_id=%d', $id, $id ) );
667 + if ( $query_results ) {
668 + // Delete all form actions linked to this form
669 + /**
670 + * @var FrmFormAction
671 + */
672 + $action_control = FrmFormActionsController::get_form_actions( 'email' );
673 + $action_control->destroy( $id, 'all' );
735 674
736 - if ( ! $query_results ) {
737 - return $query_results;
675 + // Clear form caching
676 + self::clear_form_cache();
677 +
678 + do_action( 'frm_destroy_form', $id );
679 + do_action( 'frm_destroy_form_' . $id );
738 680 }
739 681
740 - // Delete all form actions linked to this form
741 - /**
742 - * @var FrmFormAction
743 - */
744 - $action_control = FrmFormActionsController::get_form_actions( 'email' );
745 - $action_control->destroy( $id, 'all' );
746 -
747 - // Clear form caching
748 - self::clear_form_cache();
749 -
750 - do_action( 'frm_destroy_form', $id );
751 - do_action( 'frm_destroy_form_' . $id );
752 -
753 682 return $query_results;
754 683 }
755 684
756 685 /**
@@ -755,31 +684,28 @@
755 684
756 685 /**
757 686 * Delete trashed forms based on how long they have been trashed
758 687 *
759 - * @param int|string $delete_timestamp Timestamp cutoff for deletion.
760 - *
761 688 * @return int The number of forms deleted
762 689 */
763 690 public static function scheduled_delete( $delete_timestamp = '' ) {
764 - $trash_forms = FrmDb::get_results( 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
691 + global $wpdb;
765 692
693 + $trash_forms = FrmDb::get_results( $wpdb->prefix . 'frm_forms', array( 'status' => 'trash' ), 'id, parent_form_id, options' );
694 +
766 695 if ( ! $trash_forms ) {
767 696 return 0;
768 697 }
769 698
770 - if ( ! $delete_timestamp ) {
699 + if ( empty( $delete_timestamp ) ) {
771 700 $delete_timestamp = time() - ( DAY_IN_SECONDS * EMPTY_TRASH_DAYS );
772 701 }
773 702
774 703 $count = 0;
775 -
776 704 foreach ( $trash_forms as $form ) {
777 705 FrmAppHelper::unserialize_or_decode( $form->options );
778 -
779 706 if ( ! isset( $form->options['trash_time'] ) || $form->options['trash_time'] < $delete_timestamp ) {
780 707 self::destroy( $form->id );
781 -
782 708 if ( empty( $form->parent_form_id ) ) {
783 709 ++$count;
784 710 }
785 711 }
@@ -790,17 +716,16 @@
790 716 return $count;
791 717 }
792 718
793 719 /**
794 - * @param int|string $id Form ID or key.
795 - *
796 720 * @return string form name
797 721 */
798 722 public static function getName( $id ) {
799 723 $form = FrmDb::check_cache( $id, 'frm_form' );
724 + if ( $form ) {
725 + $r = stripslashes( $form->name );
800 726
801 - if ( $form ) {
802 - return stripslashes( $form->name );
727 + return $r;
803 728 }
804 729
805 730 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
806 731 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
@@ -805,9 +730,11 @@
805 730 $query_key = is_numeric( $id ) ? 'id' : 'form_key';
806 731 $r = FrmDb::get_var( 'frm_forms', array( $query_key => $id ), 'name' );
807 732
808 733 // An empty form name can result in a null value.
809 - return is_null( $r ) ? '' : stripslashes( $r );
734 + $r = is_null( $r ) ? '' : stripslashes( $r );
735 +
736 + return $r;
810 737 }
811 738
812 739 /**
813 740 * @since 3.0
@@ -822,9 +749,9 @@
822 749
823 750 /**
824 751 * @since 3.0
825 752 *
826 - * @param int|string $id
753 + * @param int $id
827 754 *
828 755 * @return string form key
829 756 */
830 757 public static function get_key_by_id( $id ) {
@@ -829,14 +756,15 @@
829 756 */
830 757 public static function get_key_by_id( $id ) {
831 758 $id = (int) $id;
832 759 $cache = FrmDb::check_cache( $id, 'frm_form' );
833 -
834 760 if ( $cache ) {
835 761 return $cache->form_key;
836 762 }
837 763
838 - return FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
764 + $key = FrmDb::get_var( 'frm_forms', array( 'id' => $id ), 'form_key' );
765 +
766 + return $key;
839 767 }
840 768
841 769 /**
842 770 * If $form is numeric, get the form object
@@ -841,15 +769,12 @@
841 769 /**
842 770 * If $form is numeric, get the form object
843 771 *
844 772 * @since 2.0.9
845 - *
846 - * @param array|int|object $form
847 - *
848 - * @return void
773 + * @param int|object $form
849 774 */
850 775 public static function maybe_get_form( &$form ) {
851 - if ( ! is_object( $form ) && ! is_array( $form ) && $form ) {
776 + if ( ! is_object( $form ) && ! is_array( $form ) && ! empty( $form ) ) {
852 777 $form = self::getOne( $form );
853 778 }
854 779 }
855 780
@@ -855,9 +780,8 @@
855 780
856 781 /**
857 782 * @param int|string $id
858 783 * @param false|int $blog_id
859 - *
860 784 * @return stdClass|null
861 785 */
862 786 public static function getOne( $id, $blog_id = false ) {
863 787 global $wpdb;
@@ -862,24 +786,29 @@
862 786 public static function getOne( $id, $blog_id = false ) {
863 787 global $wpdb;
864 788
865 789 if ( $blog_id && is_multisite() ) {
866 - $prefix = $wpdb->get_blog_prefix( $blog_id );
790 + global $wpmuBaseTablePrefix;
791 + $prefix = $wpmuBaseTablePrefix ? $wpmuBaseTablePrefix . $blog_id . '_' : $wpdb->get_blog_prefix( $blog_id );
792 +
867 793 $table_name = $prefix . 'frm_forms';
868 794 } else {
869 795 $table_name = $wpdb->prefix . 'frm_forms';
870 796 $cache = wp_cache_get( $id, 'frm_form' );
871 -
872 797 if ( $cache ) {
873 798 if ( isset( $cache->options ) ) {
874 799 FrmAppHelper::unserialize_or_decode( $cache->options );
875 800 }
876 -
877 801 return self::prepare_form_row_data( $cache );
878 802 }
879 803 }
880 804
881 - $where = is_numeric( $id ) ? array( 'id' => $id ) : array( 'form_key' => $id );
805 + if ( is_numeric( $id ) ) {
806 + $where = array( 'id' => $id );
807 + } else {
808 + $where = array( 'form_key' => $id );
809 + }
810 +
882 811 $results = FrmDb::get_row( $table_name, $where );
883 812
884 813 if ( isset( $results->options ) ) {
885 814 FrmDb::set_cache( $results->id, $results, 'frm_form' );
@@ -894,14 +823,12 @@
894 823 *
895 824 * @since 6.8.3
896 825 *
897 826 * @param stdClass|null $row The database row for a target form.
898 - *
899 827 * @return stdClass|null
900 828 */
901 829 private static function prepare_form_row_data( $row ) {
902 830 $row = wp_unslash( $row );
903 -
904 831 if ( ! is_object( $row ) ) {
905 832 return $row;
906 833 }
907 834
@@ -917,18 +844,14 @@
917 844 return apply_filters( 'frm_form_object', $row );
918 845 }
919 846
920 847 /**
921 - * @param array|string $where Where conditions array or raw WHERE string.
922 - * @param string $order_by Order by clause.
923 - * @param int|string $limit Limit clause or number.
924 - *
925 - * @return array|object Array of objects. If $limit is 1, a single object is returned.
848 + * @return array|object of objects
926 849 */
927 850 public static function getAll( $where = array(), $order_by = '', $limit = '' ) {
928 - if ( is_array( $where ) && $where ) {
851 + if ( is_array( $where ) && ! empty( $where ) ) {
929 852 if ( ! empty( $where['is_template'] ) && ! isset( $where['status'] ) && ! isset( $where['status !'] ) ) {
930 - // Don't get trashed templates
853 + // don't get trashed templates
931 854 $where['status'] = array( null, '', 'published' );
932 855 }
933 856
934 857 $results = FrmDb::get_results( 'frm_forms', $where, '*', compact( 'order_by', 'limit' ) );
@@ -935,9 +858,9 @@
935 858 } else {
936 859 global $wpdb;
937 860
938 861 // The query has already been prepared if this is not an array.
939 - $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
862 + $query = 'SELECT * FROM ' . $wpdb->prefix . 'frm_forms' . FrmDb::prepend_and_or_where( ' WHERE ', $where ) . FrmDb::esc_order( $order_by ) . FrmDb::esc_limit( $limit );
940 863 $results = $wpdb->get_results( $query ); // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
941 864 }
942 865
943 866 if ( $results ) {
@@ -946,10 +869,10 @@
946 869 FrmAppHelper::unserialize_or_decode( $result->options );
947 870 }
948 871 }
949 872
950 - if ( $limit === ' LIMIT 1' || (int) $limit === 1 ) {
951 - // Return the first form object if we are only getting one form
873 + if ( $limit === ' LIMIT 1' || $limit == 1 ) {
874 + // return the first form object if we are only getting one form
952 875 $results = reset( $results );
953 876 }
954 877
955 878 return wp_unslash( $results );
@@ -962,20 +885,20 @@
962 885 *
963 886 * @param array $query
964 887 * @param int $limit
965 888 * @param string $inc_children
966 - *
967 - * @return array|object Array of forms. A single form object is returned if $limit is set to 1.
889 + * @return array|object of forms A single form object would be passed if $limit was set to 1.
968 890 */
969 891 public static function get_published_forms( $query = array(), $limit = 999, $inc_children = 'exclude' ) {
970 892 $query['is_template'] = 0;
971 893 $query['status'] = array( null, '', 'published' );
972 -
973 894 if ( $inc_children === 'exclude' ) {
974 895 $query['parent_form_id'] = array( null, 0 );
975 896 }
976 897
977 - return self::getAll( $query, 'name', $limit );
898 + $forms = self::getAll( $query, 'name', $limit );
899 +
900 + return $forms;
978 901 }
979 902
980 903 /**
981 904 * @return object count of forms
@@ -980,16 +903,18 @@
980 903 /**
981 904 * @return object count of forms
982 905 */
983 906 public static function get_count() {
907 + global $wpdb;
908 +
984 909 $cache_key = 'frm_form_counts';
985 - $counts = wp_cache_get( $cache_key, 'frm_form' );
986 910
911 + $counts = wp_cache_get( $cache_key, 'frm_form' );
987 912 if ( false !== $counts ) {
988 913 return $counts;
989 914 }
990 915
991 - $results = FrmDb::get_results(
916 + $results = (array) FrmDb::get_results(
992 917 'frm_forms',
993 918 array(
994 919 'or' => 1,
995 920 'parent_form_id' => null,
@@ -1001,17 +926,19 @@
1001 926 $statuses = array( 'published', 'draft', 'template', 'trash' );
1002 927 $counts = array_fill_keys( $statuses, 0 );
1003 928
1004 929 foreach ( $results as $row ) {
1005 - if ( 'trash' === $row->status ) {
930 + if ( 'trash' != $row->status ) {
931 + if ( $row->is_template ) {
932 + ++$counts['template'];
933 + } else {
934 + ++$counts['published'];
935 + }
936 + } else {
1006 937 ++$counts['trash'];
1007 - } elseif ( $row->is_template ) {
1008 - ++$counts['template'];
1009 - } else {
1010 - ++$counts['published'];
1011 938 }
1012 939
1013 - if ( 'draft' === $row->status ) {
940 + if ( 'draft' == $row->status ) {
1014 941 ++$counts['draft'];
1015 942 }
1016 943
1017 944 unset( $row );
@@ -1028,10 +955,8 @@
1028 955 * Called when a form is created, updated, duplicated, or deleted
1029 956 * or when the form status is changed
1030 957 *
1031 958 * @since 2.0.4
1032 - *
1033 - * @return void
1034 959 */
1035 960 public static function clear_form_cache() {
1036 961 FrmDb::cache_delete_group( 'frm_form' );
1037 962 }
@@ -1036,29 +961,23 @@
1036 961 FrmDb::cache_delete_group( 'frm_form' );
1037 962 }
1038 963
1039 964 /**
1040 - * @param array $values Form values to validate.
1041 - *
1042 965 * @return array of errors
1043 966 */
1044 967 public static function validate( $values ) {
1045 968 $errors = array();
969 +
1046 970 return apply_filters( 'frm_validate_form', $errors, $values );
1047 971 }
1048 972
1049 - /**
1050 - * @param object|null $form
1051 - *
1052 - * @return array
1053 - */
1054 973 public static function get_params( $form = null ) {
1055 974 global $frm_vars;
1056 975
1057 - if ( $form ) {
976 + if ( ! $form ) {
977 + $form = self::getAll( array(), 'name', 1 );
978 + } else {
1058 979 self::maybe_get_form( $form );
1059 - } else {
1060 - $form = self::getAll( array(), 'name', 1 );
1061 980 }
1062 981
1063 982 if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
1064 983 return $frm_vars['form_params'][ $form->id ];
@@ -1081,14 +1000,12 @@
1081 1000 );
1082 1001
1083 1002 $values = array();
1084 1003 $values['posted_form_id'] = FrmAppHelper::get_param( 'form_id', '', 'get', 'absint' );
1085 -
1086 1004 if ( ! $values['posted_form_id'] ) {
1087 1005 $values['posted_form_id'] = FrmAppHelper::get_param( 'form', '', 'get', 'absint' );
1088 1006 }
1089 1007
1090 - // phpcs:ignore Universal.Operators.StrictComparisons
1091 1008 if ( $form->id == $values['posted_form_id'] ) {
1092 1009 // If there are two forms on the same page, make sure not to submit both.
1093 1010 foreach ( $default_values as $var => $default ) {
1094 1011 if ( $var === 'action' ) {
@@ -1104,9 +1021,9 @@
1104 1021 unset( $var, $default );
1105 1022 }
1106 1023 }
1107 1024
1108 - if ( in_array( $values['action'], array( 'create', 'update' ), true ) &&
1025 + if ( in_array( $values['action'], array( 'create', 'update' ) ) &&
1109 1026 ( ! $_POST || ( ! isset( $_POST['action'] ) && ! isset( $_POST['frm_action'] ) ) ) // phpcs:ignore WordPress.Security.NonceVerification.Missing
1110 1027 ) {
1111 1028 $values['action'] = 'new';
1112 1029 }
@@ -1113,11 +1030,8 @@
1113 1030
1114 1031 return $values;
1115 1032 }
1116 1033
1117 - /**
1118 - * @return array
1119 - */
1120 1034 public static function list_page_params() {
1121 1035 $values = array();
1122 1036 $defaults = array(
1123 1037 'template' => 0,
@@ -1127,9 +1041,8 @@
1127 1041 'search' => '',
1128 1042 'sort' => '',
1129 1043 'sdir' => '',
1130 1044 );
1131 -
1132 1045 foreach ( $defaults as $var => $default ) {
1133 1046 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1134 1047 }
1135 1048
@@ -1135,16 +1048,10 @@
1135 1048
1136 1049 return $values;
1137 1050 }
1138 1051
1139 - /**
1140 - * @param int|object|string|null $form
1141 - *
1142 - * @return array
1143 - */
1144 1052 public static function get_admin_params( $form = null ) {
1145 1053 $form_id = $form;
1146 -
1147 1054 if ( $form === null ) {
1148 1055 $form_id = self::get_current_form_id();
1149 1056 } elseif ( $form && is_object( $form ) ) {
1150 1057 $form_id = $form->id;
@@ -1162,9 +1069,8 @@
1162 1069 'sdir' => '',
1163 1070 'fid' => '',
1164 1071 'keep_post' => '',
1165 1072 );
1166 -
1167 1073 foreach ( $defaults as $var => $default ) {
1168 1074 $values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
1169 1075 }
1170 1076
@@ -1170,55 +1076,47 @@
1170 1076
1171 1077 return $values;
1172 1078 }
1173 1079
1174 - /**
1175 - * @param string $default_form
1176 - *
1177 - * @return int|string
1178 - */
1179 1080 public static function get_current_form_id( $default_form = 'none' ) {
1180 - $form = 'first' === $default_form ? self::get_current_form() : self::maybe_get_current_form();
1181 - return $form ? $form->id : 0;
1081 + if ( 'first' === $default_form ) {
1082 + $form = self::get_current_form();
1083 + } else {
1084 + $form = self::maybe_get_current_form();
1085 + }
1086 + $form_id = $form ? $form->id : 0;
1087 +
1088 + return $form_id;
1182 1089 }
1183 1090
1184 - /**
1185 - * @param int|string $form_id
1186 - *
1187 - * @return false|int|object|string
1188 - */
1189 1091 public static function maybe_get_current_form( $form_id = 0 ) {
1190 1092 global $frm_vars;
1191 1093
1192 - if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || (int) $form_id === (int) $frm_vars['current_form']->id ) ) {
1094 + if ( ! empty( $frm_vars['current_form'] ) && ( ! $form_id || $form_id == $frm_vars['current_form']->id ) ) {
1193 1095 return $frm_vars['current_form'];
1194 1096 }
1195 1097
1196 1098 $form_id = FrmAppHelper::get_param( 'form', $form_id, 'get', 'absint' );
1099 + if ( $form_id ) {
1100 + $form_id = self::set_current_form( $form_id );
1101 + }
1197 1102
1198 - return $form_id ? self::set_current_form( $form_id ) : $form_id;
1103 + return $form_id;
1199 1104 }
1200 1105
1201 - /**
1202 - * @param int $form_id
1203 - *
1204 - * @return false|object
1205 - */
1206 1106 public static function get_current_form( $form_id = 0 ) {
1207 1107 $form = self::maybe_get_current_form( $form_id );
1208 - return is_numeric( $form ) ? self::set_current_form( $form ) : $form;
1108 + if ( is_numeric( $form ) ) {
1109 + $form = self::set_current_form( $form );
1110 + }
1111 +
1112 + return $form;
1209 1113 }
1210 1114
1211 - /**
1212 - * @param int $form_id
1213 - *
1214 - * @return false|object
1215 - */
1216 1115 public static function set_current_form( $form_id ) {
1217 1116 global $frm_vars;
1218 1117
1219 1118 $query = array();
1220 -
1221 1119 if ( $form_id ) {
1222 1120 $query['id'] = $form_id;
1223 1121 }
1224 1122
@@ -1226,19 +1124,11 @@
1226 1124
1227 1125 return $frm_vars['current_form'];
1228 1126 }
1229 1127
1230 - /**
1231 - * @param object $form
1232 - * @param int|string $this_load
1233 - * @param bool $global_load
1234 - *
1235 - * @return bool
1236 - */
1237 1128 public static function is_form_loaded( $form, $this_load, $global_load ) {
1238 1129 global $frm_vars;
1239 1130 $small_form = new stdClass();
1240 -
1241 1131 foreach ( array( 'id', 'form_key', 'name' ) as $var ) {
1242 1132 $small_form->{$var} = $form->{$var};
1243 1133 unset( $var );
1244 1134 }
@@ -1244,9 +1134,9 @@
1244 1134 }
1245 1135
1246 1136 $frm_vars['forms_loaded'][] = $small_form;
1247 1137
1248 - if ( $this_load && ! $global_load ) {
1138 + if ( $this_load && empty( $global_load ) ) {
1249 1139 $global_load = true;
1250 1140 $frm_vars['load_css'] = true;
1251 1141 }
1252 1142
@@ -1259,9 +1149,9 @@
1259 1149 * @param object $form
1260 1150 *
1261 1151 * @return bool
1262 1152 */
1263 - public static function is_visible_to_user( $form ) {
1153 + public static function &is_visible_to_user( $form ) {
1264 1154 if ( $form->logged_in && isset( $form->options['logged_in_role'] ) ) {
1265 1155 $visible = FrmAppHelper::user_has_permission( $form->options['logged_in_role'] );
1266 1156 } else {
1267 1157 $visible = true;
@@ -1266,39 +1156,26 @@
1266 1156 } else {
1267 1157 $visible = true;
1268 1158 }
1269 1159
1270 - /**
1271 - * @since 6.25
1272 - *
1273 - * @param bool $visible
1274 - * @param object $form
1275 - */
1276 - return (bool) apply_filters( 'frm_form_is_visible', $visible, $form );
1160 + return $visible;
1277 1161 }
1278 1162
1279 - /**
1280 - * @param object $form
1281 - *
1282 - * @return bool
1283 - */
1284 1163 public static function show_submit( $form ) {
1285 - $show = ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin();
1286 - return apply_filters( 'frm_show_submit_button', $show, $form );
1164 + $show = ( ! $form->is_template && $form->status === 'published' && ! FrmAppHelper::is_admin() );
1165 + $show = apply_filters( 'frm_show_submit_button', $show, $form );
1166 +
1167 + return $show;
1287 1168 }
1288 1169
1289 1170 /**
1290 1171 * @since 2.3
1291 - *
1292 - * @param array $atts Attributes including form, option, and default.
1293 - *
1294 - * @return mixed
1295 1172 */
1296 1173 public static function get_option( $atts ) {
1297 1174 $form = $atts['form'];
1298 - $default = $atts['default'] ?? '';
1175 + $default = isset( $atts['default'] ) ? $atts['default'] : '';
1299 1176
1300 - return $form->options[ $atts['option'] ] ?? $default;
1177 + return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
1301 1178 }
1302 1179
1303 1180 /**
1304 1181 * Get the link to edit this form.
@@ -1303,12 +1180,9 @@
1303 1180 /**
1304 1181 * Get the link to edit this form.
1305 1182 *
1306 1183 * @since 4.0
1307 - *
1308 1184 * @param int $form_id The id of the form.
1309 - *
1310 - * @return string
1311 1185 */
1312 1186 public static function get_edit_link( $form_id ) {
1313 1187 return admin_url( 'admin.php?page=formidable&frm_action=edit&id=' . $form_id );
1314 1188 }
@@ -1318,9 +1192,8 @@
1318 1192 *
1319 1193 * @since 6.2
1320 1194 *
1321 1195 * @param stdClass $form
1322 - *
1323 1196 * @return bool
1324 1197 */
1325 1198 public static function is_ajax_on( $form ) {
1326 1199 return ! empty( $form->options['ajax_submit'] );
@@ -1329,12 +1202,12 @@
1329 1202 /**
1330 1203 * Get the latest form available.
1331 1204 *
1332 1205 * @since 6.8
1333 - *
1334 1206 * @return object
1335 1207 */
1336 1208 public static function get_latest_form() {
1209 +
1337 1210 $args = array(
1338 1211 array(
1339 1212 'or' => 1,
1340 1213 'parent_form_id' => null,
@@ -1350,12 +1223,12 @@
1350 1223 /**
1351 1224 * Count and return total forms.
1352 1225 *
1353 1226 * @since 6.8
1354 - *
1355 1227 * @return int
1356 1228 */
1357 1229 public static function get_forms_count() {
1230 +
1358 1231 $args = array(
1359 1232 array(
1360 1233 'or' => 1,
1361 1234 'parent_form_id' => null,
@@ -1369,13 +1242,11 @@
1369 1242 }
1370 1243
1371 1244 /**
1372 1245 * @deprecated 2.03.05 This is still referenced in a few add ons (API, locations).
1373 - *
1374 1246 * @codeCoverageIgnore
1375 1247 *
1376 1248 * @param string $key
1377 - *
1378 1249 * @return int form id
1379 1250 */
1380 1251 public static function getIdByKey( $key ) {
1381 1252 _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_id_by_key' );
@@ -1383,13 +1254,11 @@
1383 1254 }
1384 1255
1385 1256 /**
1386 1257 * @deprecated 2.03.05 This is still referenced in the API add on as of v1.13.
1387 - *
1388 1258 * @codeCoverageIgnore
1389 1259 *
1390 1260 * @param int|string $id
1391 - *
1392 1261 * @return string
1393 1262 */
1394 1263 public static function getKeyById( $id ) {
1395 1264 _deprecated_function( __FUNCTION__, '2.03.05', 'FrmForm::get_key_by_id' );