PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.21.1
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.21.1
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmAppController.php +171 -366 6.316.21.1 View file →
@@ -9,9 +9,8 @@
9 9 * @return void
10 10 */
11 11 public static function menu() {
12 12 FrmAppHelper::maybe_add_permissions();
13 -
14 13 if ( ! current_user_can( 'frm_view_forms' ) ) {
15 14 return;
16 15 }
17 16
@@ -32,10 +31,8 @@
32 31 }
33 32
34 33 /**
35 34 * @since 3.05
36 - *
37 - * @return string
38 35 */
39 36 private static function menu_icon() {
40 37 $icon = FrmAppHelper::svg_logo(
41 38 array(
@@ -49,12 +46,8 @@
49 46 }
50 47
51 48 /**
52 49 * @since 3.0
53 - *
54 - * @param string $classes
55 - *
56 - * @return string
57 50 */
58 51 public static function add_admin_class( $classes ) {
59 52 if ( self::is_white_page() ) {
60 53 $classes .= ' frm-white-body ';
@@ -60,20 +53,17 @@
60 53 $classes .= ' frm-white-body ';
61 54 $classes .= self::get_os();
62 55
63 56 $page = str_replace( 'formidable-', '', FrmAppHelper::simple_get( 'page', 'sanitize_title' ) );
64 -
65 - if ( ! $page || $page === 'formidable' ) {
57 + if ( empty( $page ) || $page === 'formidable' ) {
66 58 $action = FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
67 -
68 - if ( in_array( $action, array( 'settings', 'edit', 'list' ), true ) ) {
59 + if ( in_array( $action, array( 'settings', 'edit', 'list' ) ) ) {
69 60 $page .= $action;
70 61 } else {
71 62 $page = $action;
72 63 }
73 64 }
74 -
75 - if ( $page ) {
65 + if ( ! empty( $page ) ) {
76 66 $classes .= ' frm-admin-page-' . $page;
77 67 }
78 68 }
79 69
@@ -81,17 +71,16 @@
81 71 $classes .= ' frm-grey-body ';
82 72 }
83 73
84 74 if ( FrmAppHelper::is_full_screen() ) {
85 - $add_class = '';
86 -
87 - if ( self::get_full_screen_setting() ) {
75 + $full_screen_on = self::get_full_screen_setting();
76 + $add_class = '';
77 + if ( $full_screen_on ) {
88 78 $add_class = ' frm-full-screen is-fullscreen-mode';
89 79
90 80 // Load the CSS for .is-fullscreen-mode.
91 81 wp_enqueue_style( 'wp-edit-post' );
92 82 }
93 -
94 83 $classes .= apply_filters( 'frm_admin_full_screen_class', $add_class );
95 84 }
96 85
97 86 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -114,10 +103,10 @@
114 103 */
115 104 private static function get_full_screen_setting() {
116 105 global $wpdb;
117 106 $meta_key = $wpdb->get_blog_prefix() . 'persisted_preferences';
118 - $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
119 107
108 + $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
120 109 if ( $prefs && isset( $prefs['core/edit-post']['fullscreenMode'] ) ) {
121 110 return $prefs['core/edit-post']['fullscreenMode'];
122 111 }
123 112
@@ -131,24 +120,20 @@
131 120 */
132 121 private static function get_os() {
133 122 $agent = strtolower( FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ) );
134 123 $os = '';
135 -
136 - if ( str_contains( $agent, 'mac' ) ) {
124 + if ( strpos( $agent, 'mac' ) !== false ) {
137 125 $os = ' osx';
138 - } elseif ( str_contains( $agent, 'linux' ) ) {
126 + } elseif ( strpos( $agent, 'linux' ) !== false ) {
139 127 $os = ' linux';
140 - } elseif ( str_contains( $agent, 'windows' ) ) {
128 + } elseif ( strpos( $agent, 'windows' ) !== false ) {
141 129 $os = ' windows';
142 130 }
143 -
144 131 return $os;
145 132 }
146 133
147 134 /**
148 135 * @since 3.0
149 - *
150 - * @return bool
151 136 */
152 137 private static function is_white_page() {
153 138 $white_pages = array(
154 139 'formidable',
@@ -164,10 +149,17 @@
164 149 FrmFormTemplatesController::PAGE_SLUG,
165 150 FrmOnboardingWizardController::PAGE_SLUG,
166 151 );
167 152
168 - if ( self::is_white_payments_page() ) {
169 - $white_pages[] = 'formidable-payments';
153 + if ( ! class_exists( 'FrmTransHooksController', false ) && ! FrmTransLiteAppHelper::should_fallback_to_paypal() ) {
154 + // Only consider the payments page as a "white page" when the Payments submodule is off.
155 + // Otherwise this causes a lot of styling issues when the Stripe add-on (or Authorize.Net) is active.
156 +
157 + // Add an extra check to avoid white page styling on the PayPal "edit" action.
158 + // We fallback to the PayPal add on for the "edit" action since Stripe Lite does not have an edit view.
159 + if ( ! in_array( FrmAppHelper::simple_get( 'action' ), array( 'edit', 'new' ), true ) || ! is_callable( 'FrmPaymentsController::route' ) ) {
160 + $white_pages[] = 'formidable-payments';
161 + }
170 162 }
171 163
172 164 $is_white_page = self::is_page_in_list( $white_pages ) || self::is_grey_page() || FrmAppHelper::is_view_builder_page();
173 165
@@ -177,25 +169,11 @@
177 169 * @since 5.3
178 170 *
179 171 * @param bool $is_white_page
180 172 */
181 - return apply_filters( 'frm_is_white_page', $is_white_page );
182 - }
173 + $is_white_page = apply_filters( 'frm_is_white_page', $is_white_page );
183 174
184 - /**
185 - * Check if the payments page should be styled as a white page.
186 - * Fallback to the Stripe, Authorize.Net, or PayPal add on for the "edit" action since
187 - * Stripe Lite does not have an edit view. Also fallback for bulk deleting, since that
188 - * isn't built into Lite. The pages we fall back to should not be styled as white pages.
189 - *
190 - * @since 6.27
191 - *
192 - * @return bool
193 - */
194 - private static function is_white_payments_page() {
195 - $action = FrmAppHelper::simple_get( 'action', 'sanitize_title' );
196 - $on_edit_page = in_array( $action, array( 'edit', 'new' ), true );
197 - return ! $on_edit_page && 'bulk_delete' !== $action;
175 + return $is_white_page;
198 176 }
199 177
200 178 /**
201 179 * Add a grey bg instead of white.
@@ -218,9 +196,8 @@
218 196 *
219 197 * @since 6.8
220 198 *
221 199 * @param bool $is_grey_page
222 - *
223 200 * @return bool
224 201 */
225 202 return apply_filters( 'frm_is_grey_page', $is_grey_page );
226 203 }
@@ -228,9 +205,8 @@
228 205 /**
229 206 * @since 6.8
230 207 *
231 208 * @param array $pages A list of page names to check.
232 - *
233 209 * @return bool
234 210 */
235 211 private static function is_page_in_list( $pages ) {
236 212 $get_page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
@@ -254,15 +230,13 @@
254 230 * @return void
255 231 */
256 232 public static function get_form_nav( $form, $show_nav = false, $title = 'show' ) {
257 233 $show_nav = FrmAppHelper::get_param( 'show_nav', $show_nav, 'get', 'absint' );
258 -
259 - if ( ! $show_nav || ! $form ) {
234 + if ( empty( $show_nav ) || ! $form ) {
260 235 return;
261 236 }
262 237
263 238 FrmForm::maybe_get_form( $form );
264 -
265 239 if ( ! is_object( $form ) ) {
266 240 return;
267 241 }
268 242
@@ -276,21 +250,21 @@
276 250 /**
277 251 * @return string
278 252 */
279 253 private static function get_current_page() {
254 + $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
255 + $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
256 + $current_page = isset( $_GET['page'] ) ? $page : $post_type;
257 +
280 258 if ( FrmAppHelper::is_view_builder_page() ) {
281 - return 'frm_display';
259 + $current_page = 'frm_display';
282 260 }
283 261
284 - $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
285 - $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
286 -
287 - return isset( $_GET['page'] ) ? $page : $post_type;
262 + return $current_page;
288 263 }
289 264
290 265 /**
291 266 * @param object $form
292 - *
293 267 * @return array
294 268 */
295 269 private static function get_form_nav_items( $form ) {
296 270 $id = $form->parent_form_id ? $form->parent_form_id : $form->id;
@@ -366,9 +340,8 @@
366 340 /**
367 341 * Adds a settings link to the plugins page
368 342 *
369 343 * @param array $links
370 - *
371 344 * @return array
372 345 */
373 346 public static function settings_link( $links ) {
374 347 $settings = array();
@@ -377,9 +350,8 @@
377 350 if ( FrmAddonsController::is_license_expired() ) {
378 351 $label = __( 'Renew', 'formidable' );
379 352 } else {
380 353 $label = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_text' );
381 -
382 354 if ( ! $label ) {
383 355 $label = __( 'Upgrade to Pro', 'formidable' );
384 356 }
385 357 }
@@ -384,9 +356,8 @@
384 356 }
385 357 }
386 358
387 359 $upgrade_link = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_link' );
388 -
389 360 if ( $upgrade_link ) {
390 361 $upgrade_link = FrmAppHelper::maybe_add_missing_utm( $upgrade_link, array( 'medium' => 'plugin-row' ) );
391 362 } else {
392 363 $upgrade_link = FrmAppHelper::admin_upgrade_link( 'plugin-row' );
@@ -392,11 +363,11 @@
392 363 $upgrade_link = FrmAppHelper::admin_upgrade_link( 'plugin-row' );
393 364 }
394 365
395 366 $settings[] = '<a href="' . esc_url( $upgrade_link ) . '" target="_blank" rel="noopener"><b style="color:#1da867;font-weight:700;">' . esc_html( $label ) . '</b></a>';
396 - }//end if
367 + }
397 368
398 - $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . esc_html__( 'Build a Form', 'formidable' ) . '</a>';
369 + $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . __( 'Build a Form', 'formidable' ) . '</a>';
399 370
400 371 return array_merge( $settings, $links );
401 372 }
402 373
@@ -404,9 +375,9 @@
404 375 * @return void
405 376 */
406 377 public static function pro_get_started_headline() {
407 378 self::review_request();
408 - FrmAppHelper::min_pro_version_notice( '6.20' );
379 + FrmAppHelper::min_pro_version_notice( '6.0' );
409 380 }
410 381
411 382 /**
412 383 * Add admin notices as needed for reviews
@@ -481,9 +452,8 @@
481 452 *
482 453 * @param string $form_key
483 454 * @param string $title
484 455 * @param string $description
485 - *
486 456 * @return void
487 457 */
488 458 public static function api_email_form( $form_key, $title = '', $description = '' ) {
489 459 $user = wp_get_current_user();
@@ -516,9 +486,9 @@
516 486 * @return void
517 487 */
518 488 public static function remove_upsells() {
519 489 remove_action( 'frm_before_settings', 'FrmSettingsController::license_box' );
520 - remove_action( 'frm_after_settings_tabs', 'FrmSettingsController::settings_cta' );
490 + remove_action( 'frm_after_settings', 'FrmSettingsController::settings_cta' );
521 491 remove_action( 'frm_after_field_options', 'FrmFormsController::logic_tip' );
522 492 }
523 493
524 494 /**
@@ -530,14 +500,12 @@
530 500 * @return void
531 501 */
532 502 public static function install_js_fallback() {
533 503 FrmAppHelper::load_admin_wide_js();
534 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
535 504 ?>
536 505 <div id="frm_install_message"></div>
537 506 <script>jQuery(document).ready( frm_install_now );</script>
538 507 <?php
539 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
540 508 }
541 509
542 510 /**
543 511 * Check if the database is outdated
@@ -542,9 +510,8 @@
542 510 /**
543 511 * Check if the database is outdated
544 512 *
545 513 * @since 2.0.1
546 - *
547 514 * @return bool
548 515 */
549 516 public static function needs_update() {
550 517 $needs_upgrade = self::compare_for_update(
@@ -555,9 +522,9 @@
555 522 )
556 523 );
557 524
558 525 if ( ! $needs_upgrade ) {
559 - return apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
526 + $needs_upgrade = apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
560 527 }
561 528
562 529 return $needs_upgrade;
563 530 }
@@ -567,27 +534,23 @@
567 534 *
568 535 * @since 3.0.04
569 536 *
570 537 * @param array $atts
571 - *
572 538 * @return bool
573 539 */
574 540 public static function compare_for_update( $atts ) {
575 541 $db_version = get_option( $atts['option'] );
576 542
577 - if ( ! str_contains( $db_version, '-' ) ) {
578 - return true;
543 + if ( strpos( $db_version, '-' ) === false ) {
544 + $needs_upgrade = true;
545 + } else {
546 + $last_upgrade = explode( '-', $db_version );
547 + $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
548 + $new_version = version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
549 + $needs_upgrade = $needs_db_upgrade || $new_version;
579 550 }
580 551
581 - $last_upgrade = explode( '-', $db_version );
582 - $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
583 -
584 - if ( $needs_db_upgrade ) {
585 - return true;
586 - }
587 -
588 - // New plugin version.
589 - return version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
552 + return $needs_upgrade;
590 553 }
591 554
592 555 /**
593 556 * Check for database update and trigger js loading
@@ -616,13 +579,17 @@
616 579
617 580 if ( 'formidable-pro-upgrade' === FrmAppHelper::get_param( 'page' ) && ! FrmAppHelper::pro_is_installed() && current_user_can( 'frm_view_forms' ) ) {
618 581 $redirect = FrmSalesApi::get_best_sale_value( 'menu_cta_link' );
619 582 $utm = array(
620 - 'campaign' => 'upgrade',
621 - 'content' => 'submenu-upgrade',
583 + 'medium' => 'upgrade',
584 + 'content' => 'submenu-upgrade',
622 585 );
623 586
624 - $redirect = $redirect ? FrmAppHelper::maybe_add_missing_utm( $redirect, $utm ) : FrmAppHelper::admin_upgrade_link( $utm );
587 + if ( $redirect ) {
588 + $redirect = FrmAppHelper::maybe_add_missing_utm( $redirect, $utm );
589 + } else {
590 + $redirect = FrmAppHelper::admin_upgrade_link( $utm );
591 + }
625 592
626 593 wp_redirect( $redirect );
627 594 die();
628 595 }
@@ -634,32 +601,29 @@
634 601 self::network_upgrade_site();
635 602 }
636 603
637 604 if ( ! FrmAppHelper::doing_ajax() ) {
638 - // Don't continue during ajax calls
605 + // don't continue during ajax calls
639 606 self::admin_js();
640 607 }
641 608
642 609 self::trigger_page_load_hooks();
643 610
644 - if ( ! FrmAppHelper::is_admin_page( 'formidable' ) ) {
645 - return;
646 - }
611 + if ( FrmAppHelper::is_admin_page( 'formidable' ) ) {
612 + // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
613 + // This provides backward compatibility for old addons that use legacy modal templates.
614 + $action = FrmAppHelper::get_param( 'frm_action' );
615 + $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
616 + if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
617 + $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
618 + $url_param = $application_id ? '&applicationId=' . $application_id : '';
647 619
648 - // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
649 - // This provides backward compatibility for old addons that use legacy modal templates.
650 - $action = FrmAppHelper::get_param( 'frm_action' );
651 - $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
620 + wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
621 + exit;
622 + }
652 623
653 - if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
654 - $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
655 - $url_param = $application_id ? '&applicationId=' . $application_id : '';
656 -
657 - wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
658 - exit;
624 + FrmInbox::maybe_disable_screen_options();
659 625 }
660 -
661 - FrmInbox::maybe_disable_screen_options();
662 626 }
663 627
664 628 /**
665 629 * Get the current page and check for a possible function to trigger.
@@ -670,10 +634,9 @@
670 634 * @return void
671 635 */
672 636 private static function trigger_page_load_hooks() {
673 637 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
674 -
675 - if ( ! str_starts_with( $page, 'formidable-' ) ) {
638 + if ( strpos( $page, 'formidable-' ) !== 0 ) {
676 639 // Only trigger hooks on Formidable pages.
677 640 return;
678 641 }
679 642
@@ -679,9 +642,8 @@
679 642
680 643 $page = str_replace( array( 'formidable-', '-' ), array( '', ' ' ), $page );
681 644 $page = str_replace( ' ', '', ucwords( $page ) );
682 645 $class = 'Frm' . $page . 'Controller';
683 -
684 646 if ( class_exists( $class ) && method_exists( $class, 'load_page' ) ) {
685 647 call_user_func( array( $class, 'load_page' ) );
686 648 }
687 649 }
@@ -689,14 +651,13 @@
689 651 /**
690 652 * @return void
691 653 */
692 654 public static function admin_js() {
693 - $plugin_url = FrmAppHelper::plugin_url();
694 - $version = FrmAppHelper::plugin_version();
695 - $is_pro_min_v6_28 = FrmAppHelper::pro_is_installed() && FrmAppHelper::meets_min_pro_version( '6.28' );
696 - $frm_components_dependencies = $is_pro_min_v6_28 ? array( 'formidable_admin', 'formidable-pro-web-components' ) : array( 'formidable_admin' );
655 + $plugin_url = FrmAppHelper::plugin_url();
656 + $version = FrmAppHelper::plugin_version();
697 657
698 658 FrmAppHelper::load_admin_wide_js();
659 +
699 660 // Register component assets early to ensure they can be enqueued later in controllers.
700 661 wp_register_style( 'formidable-animations', $plugin_url . '/css/admin/animations.css', array(), $version );
701 662
702 663 if ( class_exists( 'FrmOverlayController' ) ) {
@@ -712,10 +673,10 @@
712 673 wp_register_style( 'formidable-grids', $plugin_url . '/css/frm_grids.css', array(), $version );
713 674
714 675 wp_register_script( 'formidable_dom', $plugin_url . '/js/admin/dom.js', array( 'jquery', 'jquery-ui-dialog', 'wp-i18n' ), $version, true );
715 676 wp_register_script( 'formidable_embed', $plugin_url . '/js/admin/embed.js', array( 'formidable_dom', 'jquery-ui-autocomplete' ), $version, true );
716 - self::register_popper2();
717 - wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '5.0.2', true );
677 + self::register_popper1();
678 + wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '4.6.1', true );
718 679
719 680 $settings_js_vars = array(
720 681 'currencies' => FrmCurrencyHelper::get_currencies(),
721 682 );
@@ -720,25 +681,51 @@
720 681 'currencies' => FrmCurrencyHelper::get_currencies(),
721 682 );
722 683 wp_register_script( 'formidable_settings', $plugin_url . '/js/admin/settings.js', array(), $version, true );
723 684 wp_localize_script( 'formidable_settings', 'frmSettings', $settings_js_vars );
724 - wp_register_script( 'formidable-web-components', $plugin_url . '/js/formidable-web-components.js', $frm_components_dependencies, $version, true );
725 685
726 686 if ( self::should_show_floating_links() ) {
727 687 self::enqueue_floating_links( $plugin_url, $version );
728 688 }
729 689
730 - wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', self::get_admin_js_dependencies(), $version, true );
690 + $dependencies = array(
691 + 'formidable_admin_global',
692 + 'jquery',
693 + 'jquery-ui-core',
694 + 'jquery-ui-draggable',
695 + 'jquery-ui-sortable',
696 + 'bootstrap_tooltip',
697 + 'bootstrap-multiselect',
698 + 'wp-i18n',
699 + // Required in WP versions older than 5.7
700 + 'wp-hooks',
701 + 'formidable_dom',
702 + 'formidable_embed',
703 + );
731 704
705 + if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
706 + // We only need to load the color picker when editing styles.
707 + $dependencies[] = 'wp-color-picker';
708 + }
709 +
710 + wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', $dependencies, $version, true );
711 +
732 712 if ( FrmAppHelper::on_form_listing_page() ) {
733 713 // For the existing page dropdown in the Form embed modal.
734 714 wp_enqueue_script( 'jquery-ui-autocomplete' );
735 715 }
736 716
737 - wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '2.0', true );
717 + wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '1.1.1', true );
738 718
739 719 if ( ! class_exists( 'FrmTransHooksController', false ) ) {
740 - FrmTransLiteAppController::hide_gateway_fields_in_builder();
720 + /**
721 + * Gateway fields are included for add-on compatibility but we do not want it to be visible.
722 + * They do however need to be visible when the payments submodule is active.
723 + */
724 + wp_add_inline_style(
725 + 'formidable-admin',
726 + '#frm_builder_page li[data-ftype="gateway"] { display: none; }'
727 + );
741 728 }
742 729
743 730 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
744 731 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
@@ -743,15 +730,12 @@
743 730 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
744 731 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
745 732
746 733 global $pagenow;
747 -
748 - if ( str_starts_with( $page, 'formidable' ) || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
749 - self::enqueue_global_settings_scripts( $page );
750 -
734 + if ( strpos( $page, 'formidable' ) === 0 || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
751 735 wp_enqueue_script( 'admin-widgets' );
752 736 wp_enqueue_style( 'widgets' );
753 - self::maybe_deregister_popper1();
737 + self::maybe_deregister_popper2();
754 738 wp_enqueue_script( 'formidable_admin' );
755 739 wp_set_script_translations( 'formidable_admin', 'formidable' );
756 740 wp_enqueue_script( 'formidable_embed' );
757 741 wp_set_script_translations( 'formidable_embed', 'formidable' );
@@ -758,9 +742,8 @@
758 742 FrmAppHelper::localize_script( 'admin' );
759 743
760 744 wp_enqueue_style( 'formidable-animations' );
761 745 wp_enqueue_style( 'formidable-admin' );
762 -
763 746 if ( 'formidable-styles' !== $page && 'formidable-styles2' !== $page ) {
764 747 wp_enqueue_style( 'formidable-grids' );
765 748 self::maybe_enqueue_dropzone_css( $page );
766 749 } else {
@@ -776,9 +759,8 @@
776 759 wp_enqueue_script( 'formidable_entries' );
777 760 }
778 761
779 762 do_action( 'frm_enqueue_builder_scripts' );
780 - self::maybe_enqueue_legacy_paypal_assets();
781 763 self::include_upgrade_overlay();
782 764 self::include_info_overlay();
783 765 } elseif ( FrmAppHelper::is_view_builder_page() ) {
784 766 if ( isset( $_REQUEST['post_type'] ) ) {
@@ -784,13 +766,11 @@
784 766 if ( isset( $_REQUEST['post_type'] ) ) {
785 767 $post_type = sanitize_title( wp_unslash( $_REQUEST['post_type'] ) );
786 768 } elseif ( isset( $_REQUEST['post'] ) && absint( $_REQUEST['post'] ) ) {
787 769 $post = get_post( absint( wp_unslash( $_REQUEST['post'] ) ) );
788 -
789 770 if ( ! $post ) {
790 771 return;
791 772 }
792 -
793 773 $post_type = $post->post_type;
794 774 } else {
795 775 return;
796 776 }
@@ -803,86 +783,16 @@
803 783 if ( 'formidable-addons' === $page ) {
804 784 wp_register_script( 'formidable_addons', $plugin_url . '/js/admin/addons.js', array( 'formidable_admin', 'wp-dom-ready' ), $version, true );
805 785 wp_enqueue_script( 'formidable_addons' );
806 786 }
807 -
808 - self::enqueue_builder_assets( $plugin_url, $version );
809 787 }
810 788
811 789 /**
812 - * @since 6.27
813 - *
814 - * @return array
815 - */
816 - private static function get_admin_js_dependencies() {
817 - $dependencies = array(
818 - 'formidable_admin_global',
819 - 'jquery',
820 - 'jquery-ui-core',
821 - 'jquery-ui-draggable',
822 - 'jquery-ui-sortable',
823 - 'bootstrap_tooltip',
824 - 'bootstrap-multiselect',
825 - 'wp-i18n',
826 - // Required in WP versions older than 5.7
827 - 'wp-hooks',
828 - 'formidable_dom',
829 - 'formidable_embed',
830 - );
831 -
832 - if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
833 - // We only need to load the color picker when editing styles.
834 - $dependencies[] = 'wp-color-picker';
835 - }
836 -
837 - return $dependencies;
838 - }
839 -
840 - /**
841 - * Enqueue the Form Builder assets.
842 - *
843 - * @since 6.24
844 - *
845 - * @param string $plugin_url The plugin URL.
846 - * @param string $version The plugin version.
847 - *
848 - * @return void
849 - */
850 - private static function enqueue_builder_assets( $plugin_url, $version ) {
851 - wp_register_style( 'formidable-settings-components', $plugin_url . '/css/admin/frm-settings-components.css', array( 'formidable-admin', 'formidable-grids' ), $version );
852 - wp_register_script( 'formidable-settings-components', $plugin_url . '/js/formidable-settings-components.js', array( 'formidable_admin' ), $version, true );
853 -
854 - if ( ! FrmAppHelper::is_form_builder_page() ) {
855 - return;
856 - }
857 -
858 - wp_enqueue_style( 'formidable-settings-components' );
859 - wp_enqueue_script( 'formidable-settings-components' );
860 - }
861 -
862 - /**
863 - * Enqueues global settings scripts.
864 - *
865 - * @param string $page The `page` param in URL.
866 - *
867 - * @return void
868 - */
869 - private static function enqueue_global_settings_scripts( $page ) {
870 - if ( 'formidable-settings' !== $page ) {
871 - return;
872 - }
873 -
874 - wp_enqueue_style( 'wp-color-picker' );
875 - wp_enqueue_script( 'formidable_settings' );
876 - }
877 -
878 - /**
879 790 * Avoid loading dropzone CSS on the form list page. It isn't required there.
880 791 *
881 792 * @since 6.11
882 793 *
883 794 * @param string $page
884 - *
885 795 * @return void
886 796 */
887 797 private static function maybe_enqueue_dropzone_css( $page ) {
888 798 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -889,9 +799,8 @@
889 799 return;
890 800 }
891 801
892 802 $should_avoid_loading_dropzone = 'formidable' === $page && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
893 -
894 803 if ( ! $should_avoid_loading_dropzone ) {
895 804 wp_enqueue_style( 'formidable-dropzone' );
896 805 }
897 806 }
@@ -908,18 +817,12 @@
908 817 if ( ! FrmAppHelper::is_formidable_branding() ) {
909 818 return false;
910 819 }
911 820
912 - $should_show = FrmAppHelper::is_formidable_admin() && ! FrmAppHelper::is_style_editor_page() && ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
913 -
914 - /**
915 - * Filters whether the floating links should be displayed.
916 - *
917 - * @since 6.25.1
918 - *
919 - * @param bool $should_show Whether the floating links should be shown.
920 - */
921 - return apply_filters( 'frm_should_show_floating_links', $should_show );
821 + return FrmAppHelper::is_formidable_admin() &&
822 + ! FrmAppHelper::is_style_editor_page() &&
823 + ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) &&
824 + ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
922 825 }
923 826
924 827 /**
925 828 * @since 6.3.2
@@ -937,29 +840,8 @@
937 840 FrmUsageController::load_scripts();
938 841 }
939 842
940 843 /**
941 - * Enqueue legacy PayPal action settings styles when the PayPal add-on is active.
942 - *
943 - * @since 6.31
944 - *
945 - * @return void
946 - */
947 - private static function maybe_enqueue_legacy_paypal_assets() {
948 - if ( ! FrmAppHelper::is_form_builder_page() || ! class_exists( 'FrmPaymentsController' ) ) {
949 - return;
950 - }
951 -
952 - wp_register_style(
953 - 'formidable-legacy-paypal',
954 - FrmAppHelper::plugin_url() . '/css/admin/frm-legacy-paypal.css',
955 - array( 'formidable-admin' ),
956 - FrmAppHelper::plugin_version()
957 - );
958 - wp_enqueue_style( 'formidable-legacy-paypal' );
959 - }
960 -
961 - /**
962 844 * Enqueue required assets for the Legacy Views editor (Views v4.x).
963 845 *
964 846 * @since 6.1.2
965 847 *
@@ -967,9 +849,9 @@
967 849 */
968 850 private static function enqueue_legacy_views_assets() {
969 851 wp_enqueue_style( 'formidable-grids' );
970 852 wp_enqueue_script( 'jquery-ui-draggable' );
971 - self::maybe_deregister_popper1();
853 + self::maybe_deregister_popper2();
972 854 wp_enqueue_script( 'formidable_admin' );
973 855 wp_add_inline_style(
974 856 'formidable-admin',
975 857 '
@@ -992,21 +874,21 @@
992 874 }
993 875 '
994 876 );
995 877 wp_enqueue_style( 'formidable-admin' );
996 - wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
878 + wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() );
997 879 FrmAppHelper::localize_script( 'admin' );
998 880 self::include_info_overlay();
999 881 }
1000 882
1001 883 /**
1002 - * Unregister Popper if the registered version is outdated.
884 + * Fix a Duplicator Pro conflict because it uses Popper 2. See issue #3459.
1003 885 *
1004 - * @since 6.26
886 + * @since 5.2.02.01
1005 887 *
1006 888 * @return void
1007 889 */
1008 - private static function maybe_deregister_popper1() {
890 + private static function maybe_deregister_popper2() {
1009 891 global $wp_scripts;
1010 892
1011 893 if ( ! array_key_exists( 'popper', $wp_scripts->registered ) ) {
1012 894 return;
@@ -1012,29 +894,26 @@
1012 894 return;
1013 895 }
1014 896
1015 897 $popper = $wp_scripts->registered['popper'];
1016 -
1017 - if ( ! version_compare( $popper->ver, '2.0', '<' ) ) {
1018 - return;
898 + if ( version_compare( $popper->ver, '2.0', '>=' ) ) {
899 + wp_deregister_script( 'popper' );
900 + self::register_popper1();
1019 901 }
1020 -
1021 - wp_deregister_script( 'popper' );
1022 - self::register_popper2();
1023 902 }
1024 903
1025 904 /**
1026 - * Register Popper required for Bootstrap 5.
905 + * Register Popper required for Bootstrap 4.
1027 906 *
1028 - * @since 6.26
907 + * @since 5.2.02.01
1029 908 *
1030 909 * @return void
1031 910 */
1032 - private static function register_popper2() {
911 + private static function register_popper1() {
1033 912 if ( ! self::should_register_popper() ) {
1034 913 return;
1035 914 }
1036 - wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array(), '2.11.8', true );
915 + wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array( 'jquery' ), '1.16.0', true );
1037 916 }
1038 917
1039 918 /**
1040 919 * Only register popper on Formidable pages.
@@ -1047,9 +926,8 @@
1047 926 private static function should_register_popper() {
1048 927 global $pagenow;
1049 928
1050 929 $post_id = FrmAppHelper::simple_get( 'post', 'absint' );
1051 -
1052 930 if ( 'post.php' === $pagenow && $post_id && 'frm_display' === get_post_type( $post_id ) ) {
1053 931 return true;
1054 932 }
1055 933
@@ -1054,16 +932,14 @@
1054 932 }
1055 933
1056 934 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1057 935 $is_views_post_type = 'frm_display' === $post_type;
1058 -
1059 936 if ( in_array( $pagenow, array( 'post-new.php', 'edit.php' ), true ) && $is_views_post_type ) {
1060 937 return true;
1061 938 }
1062 939
1063 940 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
1064 -
1065 - if ( str_starts_with( $page, 'formidable' ) ) {
941 + if ( strpos( $page, 'formidable' ) === 0 ) {
1066 942 return true;
1067 943 }
1068 944
1069 945 return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && FrmAppHelper::simple_get( 'taxonomy' ) === 'frm_application';
@@ -1077,15 +953,13 @@
1077 953 * @return void
1078 954 */
1079 955 private static function maybe_force_formidable_block_on_gutenberg_page() {
1080 956 global $pagenow;
1081 -
1082 957 if ( 'post.php' !== $pagenow ) {
1083 958 return;
1084 959 }
1085 960
1086 961 $form_id = FrmAppHelper::simple_get( 'frmForm', 'absint' );
1087 -
1088 962 if ( ! $form_id ) {
1089 963 return;
1090 964 }
1091 965
@@ -1133,9 +1007,9 @@
1133 1007 public static function create_rest_routes() {
1134 1008 $args = array(
1135 1009 'methods' => 'GET',
1136 1010 'callback' => 'FrmAppController::api_install',
1137 - 'permission_callback' => self::class . '::can_update_db',
1011 + 'permission_callback' => __CLASS__ . '::can_update_db',
1138 1012 );
1139 1013
1140 1014 register_rest_route( 'frm-admin/v1', '/install', $args );
1141 1015
@@ -1152,10 +1026,8 @@
1152 1026 * Make sure the install is only being run when we tell it to.
1153 1027 * We don't want to run manually by people calling the API.
1154 1028 *
1155 1029 * @since 4.06.02
1156 - *
1157 - * @return bool
1158 1030 */
1159 1031 public static function can_update_db() {
1160 1032 return get_transient( 'frm_updating_api' );
1161 1033 }
@@ -1185,9 +1057,9 @@
1185 1057 $response = rest_do_request( $request );
1186 1058 }
1187 1059
1188 1060 if ( $response->is_error() ) {
1189 - // If the remove post fails, use javascript instead
1061 + // if the remove post fails, use javascript instead
1190 1062 add_action( 'admin_notices', 'FrmAppController::install_js_fallback' );
1191 1063 }
1192 1064 }
1193 1065
@@ -1197,17 +1069,14 @@
1197 1069 *
1198 1070 * @return void
1199 1071 */
1200 1072 private static function maybe_add_wp_site_health() {
1201 - if ( class_exists( 'WP_Site_Health' ) ) {
1202 - return;
1073 + if ( ! class_exists( 'WP_Site_Health' ) ) {
1074 + $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1075 + if ( file_exists( $wp_site_health_path ) ) {
1076 + require_once $wp_site_health_path;
1077 + }
1203 1078 }
1204 -
1205 - $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1206 -
1207 - if ( file_exists( $wp_site_health_path ) ) {
1208 - require_once $wp_site_health_path;
1209 - }
1210 1079 }
1211 1080
1212 1081 /**
1213 1082 * @since 3.0
@@ -1215,14 +1084,12 @@
1215 1084 * @return true
1216 1085 */
1217 1086 public static function api_install() {
1218 1087 delete_transient( 'frm_updating_api' );
1219 -
1220 1088 if ( self::needs_update() ) {
1221 1089 $running = get_option( 'frm_install_running' );
1222 -
1223 1090 if ( false === $running || $running < strtotime( '-5 minutes' ) ) {
1224 - update_option( 'frm_install_running', time(), false );
1091 + update_option( 'frm_install_running', time(), 'no' );
1225 1092 self::install();
1226 1093 delete_option( 'frm_install_running' );
1227 1094 }
1228 1095 }
@@ -1270,13 +1137,8 @@
1270 1137
1271 1138 wp_die();
1272 1139 }
1273 1140
1274 - /**
1275 - * @param array $tables
1276 - *
1277 - * @return array
1278 - */
1279 1141 public static function drop_tables( $tables ) {
1280 1142 global $wpdb;
1281 1143 $tables[] = $wpdb->prefix . 'frm_fields';
1282 1144 $tables[] = $wpdb->prefix . 'frm_forms';
@@ -1324,15 +1186,14 @@
1324 1186
1325 1187 FrmTransLiteAppController::maybe_schedule_cron();
1326 1188 }
1327 1189
1328 - /**
1329 - * @param string $text
1330 - *
1331 - * @return string
1332 - */
1333 1190 public static function set_footer_text( $text ) {
1334 - return FrmAppHelper::is_formidable_admin() ? '' : $text;
1191 + if ( FrmAppHelper::is_formidable_admin() ) {
1192 + $text = '';
1193 + }
1194 +
1195 + return $text;
1335 1196 }
1336 1197
1337 1198 /**
1338 1199 * Add admin footer links.
@@ -1342,9 +1203,8 @@
1342 1203 * @return void
1343 1204 */
1344 1205 public static function add_admin_footer_links() {
1345 1206 FrmFormsController::include_device_too_small_message();
1346 -
1347 1207 if ( self::should_show_footer_links() ) {
1348 1208 include FrmAppHelper::plugin_path() . '/classes/views/shared/admin-footer-links.php';
1349 1209 }
1350 1210 }
@@ -1359,9 +1219,8 @@
1359 1219 private static function should_show_footer_links() {
1360 1220 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1361 1221 $is_formidable_page = FrmAppHelper::is_formidable_admin() || 'frm_logs' === $post_type;
1362 1222 $show_footer_links = $is_formidable_page;
1363 -
1364 1223 if ( FrmAppHelper::is_full_screen() || ! FrmAppHelper::is_formidable_branding() ) {
1365 1224 $show_footer_links = false;
1366 1225 }
1367 1226
@@ -1370,9 +1229,8 @@
1370 1229 *
1371 1230 * @since 6.7
1372 1231 *
1373 1232 * @param bool $show_footer_links
1374 - *
1375 1233 * @return bool
1376 1234 */
1377 1235 return apply_filters( 'frm_show_footer_links', $show_footer_links );
1378 1236 }
@@ -1399,9 +1257,8 @@
1399 1257 'icon' => 'frm_lock_simple',
1400 1258 );
1401 1259
1402 1260 $error_args = wp_parse_args( $error_args, $defaults );
1403 -
1404 1261 if ( ! isset( $error_args['cancel_text'] ) && ! empty( $error_args['cancel_url'] ) ) {
1405 1262 $error_args['cancel_text'] = __( 'Cancel', 'formidable' );
1406 1263 }
1407 1264
@@ -1418,9 +1275,8 @@
1418 1275 * @since 6.4
1419 1276 *
1420 1277 * @param string $plugin_url URL of the plugin.
1421 1278 * @param string $version Current version of the plugin.
1422 - *
1423 1279 * @return void
1424 1280 */
1425 1281 private static function enqueue_floating_links( $plugin_url, $version ) {
1426 1282 if ( ! $plugin_url || ! $version ) {
@@ -1440,20 +1296,10 @@
1440 1296 if ( function_exists( 'wp_set_script_translations' ) ) {
1441 1297 wp_set_script_translations( 's11-floating-links-config', 's11-' );
1442 1298 }
1443 1299
1444 - $upgrade_utm = array(
1445 - 'campaign' => 'floating-links',
1446 - 'content' => 'floating-links-upgrade',
1447 - );
1448 - $docs_utm = array(
1449 - 'campaign' => 'floating-links',
1450 - 'content' => 'floating-links-docs',
1451 - );
1452 1300 $floating_links_data = array(
1453 - 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1454 - 'upgradeUrl' => FrmAppHelper::admin_upgrade_link( $upgrade_utm ),
1455 - 'documentationUrl' => FrmAppHelper::admin_upgrade_link( $docs_utm, 'knowledgebase/' ),
1301 + 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1456 1302 );
1457 1303 wp_localize_script( 's11-floating-links-config', 's11FloatingLinksData', $floating_links_data );
1458 1304
1459 1305 /**
@@ -1471,9 +1317,8 @@
1471 1317 * @return bool
1472 1318 */
1473 1319 private static function in_our_pages() {
1474 1320 global $current_screen, $pagenow;
1475 -
1476 1321 if ( FrmAppHelper::is_formidable_admin() ) {
1477 1322 return true;
1478 1323 }
1479 1324
@@ -1480,9 +1325,13 @@
1480 1325 if ( ! empty( $current_screen->post_type ) && 'frm_logs' === $current_screen->post_type ) {
1481 1326 return true;
1482 1327 }
1483 1328
1484 - return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' );
1329 + if ( in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' ) ) {
1330 + return true;
1331 + }
1332 +
1333 + return false;
1485 1334 }
1486 1335
1487 1336 /**
1488 1337 * Handles actions related to the current screen.
@@ -1518,9 +1367,8 @@
1518 1367 foreach ( $actions as $action ) {
1519 1368 if ( empty( $wp_filter[ $action ]->callbacks ) ) {
1520 1369 continue;
1521 1370 }
1522 -
1523 1371 foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
1524 1372 foreach ( $callbacks as $callback_name => $callback ) {
1525 1373 if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
1526 1374 continue;
@@ -1536,18 +1384,14 @@
1536 1384 *
1537 1385 * @return void
1538 1386 */
1539 1387 private static function remember_custom_sort() {
1540 - $meta_key = self::get_sort_pref_user_meta_key();
1541 -
1542 - if ( false === $meta_key ) {
1388 + $screen = get_current_screen();
1389 + if ( ! $screen ) {
1543 1390 return;
1544 1391 }
1545 1392
1546 - $is_form_list = FrmAppHelper::is_admin_list_page();
1547 - $is_entry_list = FrmAppHelper::is_admin_list_page( 'formidable-entries' );
1548 -
1549 - if ( ! $is_form_list && ! $is_entry_list ) {
1393 + if ( ! FrmAppHelper::is_admin_list_page() && ! FrmAppHelper::is_admin_list_page( 'formidable-entries' ) ) {
1550 1394 return;
1551 1395 }
1552 1396
1553 1397 $orderby = FrmAppHelper::get_param( 'orderby' );
@@ -1555,37 +1399,29 @@
1555 1399 if ( ! $orderby ) {
1556 1400 return;
1557 1401 }
1558 1402
1559 - $user_id = get_current_user_id();
1560 - $order = FrmAppHelper::get_param( 'order' );
1561 - $new_sort = array(
1403 + $user_id = get_current_user_id();
1404 + $meta_key = 'frm_preferred_list_sort_' . $screen->id;
1405 + $order = FrmAppHelper::get_param( 'order' );
1406 +
1407 + $new_sort = array(
1562 1408 'orderby' => $orderby,
1563 1409 'order' => $order,
1564 1410 );
1565 - $previous_meta = get_user_meta( $user_id, $meta_key, true );
1566 - $current_sort = $previous_meta;
1567 - $form_id = $is_entry_list ? FrmAppHelper::simple_get( 'form', 'absint' ) : 0;
1568 1411
1569 - if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[ $form_id ] ) ) {
1570 - $current_sort = $current_sort[ $form_id ];
1571 - }
1412 + $current_sort = get_user_meta( $user_id, $meta_key, true );
1572 1413
1573 - if ( $new_sort === $current_sort ) {
1574 - return;
1414 + if ( $new_sort !== $current_sort ) {
1415 + update_user_meta(
1416 + $user_id,
1417 + $meta_key,
1418 + array(
1419 + 'orderby' => $orderby,
1420 + 'order' => $order,
1421 + )
1422 + );
1575 1423 }
1576 -
1577 - $new_meta = $new_sort;
1578 -
1579 - if ( $is_entry_list && $form_id && is_int( $form_id ) ) {
1580 - // Index meta by form ID.
1581 - $temp_meta = is_array( $previous_meta ) ? $previous_meta : array();
1582 - $temp_meta[ $form_id ] = $new_meta;
1583 - $new_meta = $temp_meta;
1584 - unset( $temp_meta );
1585 - }
1586 -
1587 - update_user_meta( $user_id, $meta_key, $new_meta );
1588 1424 }
1589 1425
1590 1426 /**
1591 1427 * Retrieve and apply any saved sorting preferences for the current screen.
@@ -1591,52 +1427,32 @@
1591 1427 * Retrieve and apply any saved sorting preferences for the current screen.
1592 1428 *
1593 1429 * @since 6.19
1594 1430 *
1595 - * @param string $orderby Reference to the current 'orderby' parameter.
1596 - * @param string $order Reference to the current 'order' parameter.
1597 - *
1431 + * @param string &$orderby Reference to the current 'orderby' parameter.
1432 + * @param string &$order Reference to the current 'order' parameter.
1598 1433 * @return void
1599 1434 */
1600 1435 public static function apply_saved_sort_preference( &$orderby, &$order ) {
1601 - $meta_key = self::get_sort_pref_user_meta_key();
1602 -
1603 - if ( false === $meta_key ) {
1436 + if ( ! function_exists( 'get_current_screen' ) ) {
1604 1437 return;
1605 1438 }
1606 1439
1607 - $preferred_list_sort = get_user_meta( get_current_user_id(), $meta_key, true );
1608 - $form_id = FrmAppHelper::simple_get( 'form', 'absint' );
1609 -
1610 - if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[ $form_id ] ) ) {
1611 - $preferred_list_sort = $preferred_list_sort[ $form_id ];
1612 - }
1613 -
1614 - if ( ! is_array( $preferred_list_sort ) || empty( $preferred_list_sort['orderby'] ) ) {
1440 + $screen = get_current_screen();
1441 + if ( ! $screen ) {
1615 1442 return;
1616 1443 }
1617 1444
1618 - $orderby = $preferred_list_sort['orderby'];
1445 + $user_id = get_current_user_id();
1446 + $preferred_list_sort = get_user_meta( $user_id, 'frm_preferred_list_sort_' . $screen->id, true );
1619 1447
1620 - if ( ! empty( $preferred_list_sort['order'] ) ) {
1621 - $order = $preferred_list_sort['order'];
1622 - }
1623 - }
1448 + if ( is_array( $preferred_list_sort ) && ! empty( $preferred_list_sort['orderby'] ) ) {
1449 + $orderby = $preferred_list_sort['orderby'];
1624 1450
1625 - /**
1626 - * Get a simple user meta key that only includes the screen ID.
1627 - *
1628 - * @since 6.25.1
1629 - *
1630 - * @return false|string
1631 - */
1632 - private static function get_sort_pref_user_meta_key() {
1633 - if ( ! function_exists( 'get_current_screen' ) ) {
1634 - return false;
1451 + if ( ! empty( $preferred_list_sort['order'] ) ) {
1452 + $order = $preferred_list_sort['order'];
1453 + }
1635 1454 }
1636 -
1637 - $screen = get_current_screen();
1638 - return $screen ? 'frm_preferred_list_sort_' . $screen->id : false;
1639 1455 }
1640 1456
1641 1457 /**
1642 1458 * Validate that the callback name is ours not from third-party.
@@ -1656,9 +1472,12 @@
1656 1472 *
1657 1473 * @return bool
1658 1474 */
1659 1475 private static function is_our_callback_array( $callback ) {
1660 - return ! empty( $callback['function'] ) && is_array( $callback['function'] ) && ! empty( $callback['function'][0] ) && self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1476 + return ! empty( $callback['function'] ) &&
1477 + is_array( $callback['function'] ) &&
1478 + ! empty( $callback['function'][0] ) &&
1479 + self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] );
1661 1480 }
1662 1481
1663 1482 /**
1664 1483 * In some cases, the DB tables may fail to install.
@@ -1669,9 +1488,10 @@
1669 1488 */
1670 1489 private static function add_missing_tables() {
1671 1490 FrmAppHelper::permission_check( 'frm_view_forms' );
1672 1491
1673 - $error = FrmInbox::check_for_error();
1492 + $inbox = new FrmInbox();
1493 + $error = $inbox->check_for_error();
1674 1494
1675 1495 if ( ! $error || 'failed-to-create-tables' !== $error['key'] ) {
1676 1496 // Confirm the inbox item with this CTA exists.
1677 1497 wp_safe_redirect( admin_url( 'admin.php?page=formidable' ) );
@@ -1703,21 +1523,6 @@
1703 1523 FrmAppHelper::permission_check( 'frm_view_forms' );
1704 1524 check_ajax_referer( 'frm_ajax', 'nonce' );
1705 1525 update_user_option( get_current_user_id(), 'frm_ignore_small_screen_warning', true );
1706 1526 wp_send_json_success();
1707 - }
1708 -
1709 - /**
1710 - * Enqueue the components scripts.
1711 - *
1712 - * @since 6.28
1713 - *
1714 - * @return void
1715 - */
1716 - public static function enqueue_components_scripts() {
1717 - if ( is_callable( array( 'FrmProFormsController', 'enqueue_pro_web_components_script' ) ) ) {
1718 - FrmProFormsController::enqueue_pro_web_components_script();
1719 - }
1720 -
1721 - wp_enqueue_script( 'formidable-web-components' );
1722 1527 }
1723 1528 }