PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.24.1
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.24.1
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmAppController.php +175 -370 6.346.24.1 View file →
@@ -9,9 +9,8 @@
9 9 * @return void
10 10 */
11 11 public static function menu() {
12 12 FrmAppHelper::maybe_add_permissions();
13 -
14 13 if ( ! current_user_can( 'frm_view_forms' ) ) {
15 14 return;
16 15 }
17 16
@@ -32,10 +31,8 @@
32 31 }
33 32
34 33 /**
35 34 * @since 3.05
36 - *
37 - * @return string
38 35 */
39 36 private static function menu_icon() {
40 37 $icon = FrmAppHelper::svg_logo(
41 38 array(
@@ -49,12 +46,8 @@
49 46 }
50 47
51 48 /**
52 49 * @since 3.0
53 - *
54 - * @param string $classes
55 - *
56 - * @return string
57 50 */
58 51 public static function add_admin_class( $classes ) {
59 52 if ( self::is_white_page() ) {
60 53 $classes .= ' frm-white-body ';
@@ -60,20 +53,17 @@
60 53 $classes .= ' frm-white-body ';
61 54 $classes .= self::get_os();
62 55
63 56 $page = str_replace( 'formidable-', '', FrmAppHelper::simple_get( 'page', 'sanitize_title' ) );
64 -
65 - if ( ! $page || $page === 'formidable' ) {
57 + if ( empty( $page ) || $page === 'formidable' ) {
66 58 $action = FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
67 -
68 - if ( in_array( $action, array( 'settings', 'edit', 'list' ), true ) ) {
59 + if ( in_array( $action, array( 'settings', 'edit', 'list' ) ) ) {
69 60 $page .= $action;
70 61 } else {
71 62 $page = $action;
72 63 }
73 64 }
74 -
75 - if ( $page ) {
65 + if ( ! empty( $page ) ) {
76 66 $classes .= ' frm-admin-page-' . $page;
77 67 }
78 68 }
79 69
@@ -81,17 +71,16 @@
81 71 $classes .= ' frm-grey-body ';
82 72 }
83 73
84 74 if ( FrmAppHelper::is_full_screen() ) {
85 - $add_class = '';
86 -
87 - if ( self::get_full_screen_setting() ) {
75 + $full_screen_on = self::get_full_screen_setting();
76 + $add_class = '';
77 + if ( $full_screen_on ) {
88 78 $add_class = ' frm-full-screen is-fullscreen-mode';
89 79
90 80 // Load the CSS for .is-fullscreen-mode.
91 81 wp_enqueue_style( 'wp-edit-post' );
92 82 }
93 -
94 83 $classes .= apply_filters( 'frm_admin_full_screen_class', $add_class );
95 84 }
96 85
97 86 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -114,10 +103,10 @@
114 103 */
115 104 private static function get_full_screen_setting() {
116 105 global $wpdb;
117 106 $meta_key = $wpdb->get_blog_prefix() . 'persisted_preferences';
118 - $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
119 107
108 + $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
120 109 if ( $prefs && isset( $prefs['core/edit-post']['fullscreenMode'] ) ) {
121 110 return $prefs['core/edit-post']['fullscreenMode'];
122 111 }
123 112
@@ -131,24 +120,20 @@
131 120 */
132 121 private static function get_os() {
133 122 $agent = strtolower( FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ) );
134 123 $os = '';
135 -
136 - if ( str_contains( $agent, 'mac' ) ) {
124 + if ( strpos( $agent, 'mac' ) !== false ) {
137 125 $os = ' osx';
138 - } elseif ( str_contains( $agent, 'linux' ) ) {
126 + } elseif ( strpos( $agent, 'linux' ) !== false ) {
139 127 $os = ' linux';
140 - } elseif ( str_contains( $agent, 'windows' ) ) {
128 + } elseif ( strpos( $agent, 'windows' ) !== false ) {
141 129 $os = ' windows';
142 130 }
143 -
144 131 return $os;
145 132 }
146 133
147 134 /**
148 135 * @since 3.0
149 - *
150 - * @return bool
151 136 */
152 137 private static function is_white_page() {
153 138 $white_pages = array(
154 139 'formidable',
@@ -164,10 +149,17 @@
164 149 FrmFormTemplatesController::PAGE_SLUG,
165 150 FrmOnboardingWizardController::PAGE_SLUG,
166 151 );
167 152
168 - if ( self::is_white_payments_page() ) {
169 - $white_pages[] = 'formidable-payments';
153 + if ( ! class_exists( 'FrmTransHooksController', false ) && ! FrmTransLiteAppHelper::should_fallback_to_paypal() ) {
154 + // Only consider the payments page as a "white page" when the Payments submodule is off.
155 + // Otherwise this causes a lot of styling issues when the Stripe add-on (or Authorize.Net) is active.
156 +
157 + // Add an extra check to avoid white page styling on the PayPal "edit" action.
158 + // We fallback to the PayPal add on for the "edit" action since Stripe Lite does not have an edit view.
159 + if ( ! in_array( FrmAppHelper::simple_get( 'action' ), array( 'edit', 'new' ), true ) || ! is_callable( 'FrmPaymentsController::route' ) ) {
160 + $white_pages[] = 'formidable-payments';
161 + }
170 162 }
171 163
172 164 $is_white_page = self::is_page_in_list( $white_pages ) || self::is_grey_page() || FrmAppHelper::is_view_builder_page();
173 165
@@ -177,25 +169,11 @@
177 169 * @since 5.3
178 170 *
179 171 * @param bool $is_white_page
180 172 */
181 - return apply_filters( 'frm_is_white_page', $is_white_page );
182 - }
173 + $is_white_page = apply_filters( 'frm_is_white_page', $is_white_page );
183 174
184 - /**
185 - * Check if the payments page should be styled as a white page.
186 - * Fallback to the Stripe, Authorize.Net, or PayPal add on for the "edit" action since
187 - * Stripe Lite does not have an edit view. Also fallback for bulk deleting, since that
188 - * isn't built into Lite. The pages we fall back to should not be styled as white pages.
189 - *
190 - * @since 6.27
191 - *
192 - * @return bool
193 - */
194 - private static function is_white_payments_page() {
195 - $action = FrmAppHelper::simple_get( 'action', 'sanitize_title' );
196 - $on_edit_page = in_array( $action, array( 'edit', 'new' ), true );
197 - return ! $on_edit_page && 'bulk_delete' !== $action;
175 + return $is_white_page;
198 176 }
199 177
200 178 /**
201 179 * Add a grey bg instead of white.
@@ -218,9 +196,8 @@
218 196 *
219 197 * @since 6.8
220 198 *
221 199 * @param bool $is_grey_page
222 - *
223 200 * @return bool
224 201 */
225 202 return apply_filters( 'frm_is_grey_page', $is_grey_page );
226 203 }
@@ -228,9 +205,8 @@
228 205 /**
229 206 * @since 6.8
230 207 *
231 208 * @param array $pages A list of page names to check.
232 - *
233 209 * @return bool
234 210 */
235 211 private static function is_page_in_list( $pages ) {
236 212 $get_page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
@@ -254,15 +230,13 @@
254 230 * @return void
255 231 */
256 232 public static function get_form_nav( $form, $show_nav = false, $title = 'show' ) {
257 233 $show_nav = FrmAppHelper::get_param( 'show_nav', $show_nav, 'get', 'absint' );
258 -
259 - if ( ! $show_nav || ! $form ) {
234 + if ( empty( $show_nav ) || ! $form ) {
260 235 return;
261 236 }
262 237
263 238 FrmForm::maybe_get_form( $form );
264 -
265 239 if ( ! is_object( $form ) ) {
266 240 return;
267 241 }
268 242
@@ -276,21 +250,21 @@
276 250 /**
277 251 * @return string
278 252 */
279 253 private static function get_current_page() {
254 + $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
255 + $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
256 + $current_page = isset( $_GET['page'] ) ? $page : $post_type;
257 +
280 258 if ( FrmAppHelper::is_view_builder_page() ) {
281 - return 'frm_display';
259 + $current_page = 'frm_display';
282 260 }
283 261
284 - $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
285 - $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
286 -
287 - return isset( $_GET['page'] ) ? $page : $post_type;
262 + return $current_page;
288 263 }
289 264
290 265 /**
291 266 * @param object $form
292 - *
293 267 * @return array
294 268 */
295 269 private static function get_form_nav_items( $form ) {
296 270 $id = $form->parent_form_id ? $form->parent_form_id : $form->id;
@@ -366,9 +340,8 @@
366 340 /**
367 341 * Adds a settings link to the plugins page
368 342 *
369 343 * @param array $links
370 - *
371 344 * @return array
372 345 */
373 346 public static function settings_link( $links ) {
374 347 $settings = array();
@@ -373,38 +346,28 @@
373 346 public static function settings_link( $links ) {
374 347 $settings = array();
375 348
376 349 if ( ! FrmAppHelper::pro_is_installed() ) {
377 - $is_expired = FrmAddonsController::is_license_expired();
378 -
379 - if ( $is_expired ) {
350 + if ( FrmAddonsController::is_license_expired() ) {
380 351 $label = __( 'Renew', 'formidable' );
381 352 } else {
382 353 $label = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_text' );
383 -
384 354 if ( ! $label ) {
385 355 $label = __( 'Upgrade to Pro', 'formidable' );
386 356 }
387 357 }
388 358
389 - $upgrade_content = $is_expired ? 'renew' : 'upgrade';
390 - $upgrade_link = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_link' );
391 -
392 - $utm = array(
393 - 'campaign' => 'plugin-row',
394 - 'content' => $upgrade_content,
395 - );
396 -
359 + $upgrade_link = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_link' );
397 360 if ( $upgrade_link ) {
398 - $upgrade_link = FrmAppHelper::maybe_add_missing_utm( $upgrade_link, $utm );
361 + $upgrade_link = FrmAppHelper::maybe_add_missing_utm( $upgrade_link, array( 'medium' => 'plugin-row' ) );
399 362 } else {
400 - $upgrade_link = FrmAppHelper::admin_upgrade_link( $utm );
363 + $upgrade_link = FrmAppHelper::admin_upgrade_link( 'plugin-row' );
401 364 }
402 365
403 366 $settings[] = '<a href="' . esc_url( $upgrade_link ) . '" target="_blank" rel="noopener"><b style="color:#1da867;font-weight:700;">' . esc_html( $label ) . '</b></a>';
404 - }//end if
367 + }
405 368
406 - $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . esc_html__( 'Build a Form', 'formidable' ) . '</a>';
369 + $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . __( 'Build a Form', 'formidable' ) . '</a>';
407 370
408 371 return array_merge( $settings, $links );
409 372 }
410 373
@@ -412,9 +375,9 @@
412 375 * @return void
413 376 */
414 377 public static function pro_get_started_headline() {
415 378 self::review_request();
416 - FrmAppHelper::min_pro_version_notice( '6.20' );
379 + FrmAppHelper::min_pro_version_notice( '6.0' );
417 380 }
418 381
419 382 /**
420 383 * Add admin notices as needed for reviews
@@ -489,9 +452,8 @@
489 452 *
490 453 * @param string $form_key
491 454 * @param string $title
492 455 * @param string $description
493 - *
494 456 * @return void
495 457 */
496 458 public static function api_email_form( $form_key, $title = '', $description = '' ) {
497 459 $user = wp_get_current_user();
@@ -538,14 +500,12 @@
538 500 * @return void
539 501 */
540 502 public static function install_js_fallback() {
541 503 FrmAppHelper::load_admin_wide_js();
542 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
543 504 ?>
544 505 <div id="frm_install_message"></div>
545 506 <script>jQuery(document).ready( frm_install_now );</script>
546 507 <?php
547 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
548 508 }
549 509
550 510 /**
551 511 * Check if the database is outdated
@@ -550,9 +510,8 @@
550 510 /**
551 511 * Check if the database is outdated
552 512 *
553 513 * @since 2.0.1
554 - *
555 514 * @return bool
556 515 */
557 516 public static function needs_update() {
558 517 $needs_upgrade = self::compare_for_update(
@@ -563,9 +522,9 @@
563 522 )
564 523 );
565 524
566 525 if ( ! $needs_upgrade ) {
567 - return apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
526 + $needs_upgrade = apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
568 527 }
569 528
570 529 return $needs_upgrade;
571 530 }
@@ -575,27 +534,23 @@
575 534 *
576 535 * @since 3.0.04
577 536 *
578 537 * @param array $atts
579 - *
580 538 * @return bool
581 539 */
582 540 public static function compare_for_update( $atts ) {
583 541 $db_version = get_option( $atts['option'] );
584 542
585 - if ( ! str_contains( $db_version, '-' ) ) {
586 - return true;
543 + if ( strpos( $db_version, '-' ) === false ) {
544 + $needs_upgrade = true;
545 + } else {
546 + $last_upgrade = explode( '-', $db_version );
547 + $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
548 + $new_version = version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
549 + $needs_upgrade = $needs_db_upgrade || $new_version;
587 550 }
588 551
589 - $last_upgrade = explode( '-', $db_version );
590 - $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
591 -
592 - if ( $needs_db_upgrade ) {
593 - return true;
594 - }
595 -
596 - // New plugin version.
597 - return version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
552 + return $needs_upgrade;
598 553 }
599 554
600 555 /**
601 556 * Check for database update and trigger js loading
@@ -624,13 +579,17 @@
624 579
625 580 if ( 'formidable-pro-upgrade' === FrmAppHelper::get_param( 'page' ) && ! FrmAppHelper::pro_is_installed() && current_user_can( 'frm_view_forms' ) ) {
626 581 $redirect = FrmSalesApi::get_best_sale_value( 'menu_cta_link' );
627 582 $utm = array(
628 - 'campaign' => 'upgrade',
629 - 'content' => 'submenu-upgrade',
583 + 'medium' => 'upgrade',
584 + 'content' => 'submenu-upgrade',
630 585 );
631 586
632 - $redirect = $redirect ? FrmAppHelper::maybe_add_missing_utm( $redirect, $utm ) : FrmAppHelper::admin_upgrade_link( $utm );
587 + if ( $redirect ) {
588 + $redirect = FrmAppHelper::maybe_add_missing_utm( $redirect, $utm );
589 + } else {
590 + $redirect = FrmAppHelper::admin_upgrade_link( $utm );
591 + }
633 592
634 593 wp_redirect( $redirect );
635 594 die();
636 595 }
@@ -642,32 +601,29 @@
642 601 self::network_upgrade_site();
643 602 }
644 603
645 604 if ( ! FrmAppHelper::doing_ajax() ) {
646 - // Don't continue during ajax calls
605 + // don't continue during ajax calls
647 606 self::admin_js();
648 607 }
649 608
650 609 self::trigger_page_load_hooks();
651 610
652 - if ( ! FrmAppHelper::is_admin_page( 'formidable' ) ) {
653 - return;
654 - }
611 + if ( FrmAppHelper::is_admin_page( 'formidable' ) ) {
612 + // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
613 + // This provides backward compatibility for old addons that use legacy modal templates.
614 + $action = FrmAppHelper::get_param( 'frm_action' );
615 + $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
616 + if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
617 + $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
618 + $url_param = $application_id ? '&applicationId=' . $application_id : '';
655 619
656 - // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
657 - // This provides backward compatibility for old addons that use legacy modal templates.
658 - $action = FrmAppHelper::get_param( 'frm_action' );
659 - $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
620 + wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
621 + exit;
622 + }
660 623
661 - if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
662 - $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
663 - $url_param = $application_id ? '&applicationId=' . $application_id : '';
664 -
665 - wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
666 - exit;
624 + FrmInbox::maybe_disable_screen_options();
667 625 }
668 -
669 - FrmInbox::maybe_disable_screen_options();
670 626 }
671 627
672 628 /**
673 629 * Get the current page and check for a possible function to trigger.
@@ -678,10 +634,9 @@
678 634 * @return void
679 635 */
680 636 private static function trigger_page_load_hooks() {
681 637 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
682 -
683 - if ( ! str_starts_with( $page, 'formidable-' ) ) {
638 + if ( strpos( $page, 'formidable-' ) !== 0 ) {
684 639 // Only trigger hooks on Formidable pages.
685 640 return;
686 641 }
687 642
@@ -687,9 +642,8 @@
687 642
688 643 $page = str_replace( array( 'formidable-', '-' ), array( '', ' ' ), $page );
689 644 $page = str_replace( ' ', '', ucwords( $page ) );
690 645 $class = 'Frm' . $page . 'Controller';
691 -
692 646 if ( class_exists( $class ) && method_exists( $class, 'load_page' ) ) {
693 647 call_user_func( array( $class, 'load_page' ) );
694 648 }
695 649 }
@@ -697,14 +651,13 @@
697 651 /**
698 652 * @return void
699 653 */
700 654 public static function admin_js() {
701 - $plugin_url = FrmAppHelper::plugin_url();
702 - $version = FrmAppHelper::plugin_version();
703 - $is_pro_min_v6_28 = FrmAppHelper::pro_is_installed() && FrmAppHelper::meets_min_pro_version( '6.28' );
704 - $frm_components_dependencies = $is_pro_min_v6_28 ? array( 'formidable_admin', 'formidable-pro-web-components' ) : array( 'formidable_admin' );
655 + $plugin_url = FrmAppHelper::plugin_url();
656 + $version = FrmAppHelper::plugin_version();
705 657
706 658 FrmAppHelper::load_admin_wide_js();
659 +
707 660 // Register component assets early to ensure they can be enqueued later in controllers.
708 661 wp_register_style( 'formidable-animations', $plugin_url . '/css/admin/animations.css', array(), $version );
709 662
710 663 if ( class_exists( 'FrmOverlayController' ) ) {
@@ -720,10 +673,10 @@
720 673 wp_register_style( 'formidable-grids', $plugin_url . '/css/frm_grids.css', array(), $version );
721 674
722 675 wp_register_script( 'formidable_dom', $plugin_url . '/js/admin/dom.js', array( 'jquery', 'jquery-ui-dialog', 'wp-i18n' ), $version, true );
723 676 wp_register_script( 'formidable_embed', $plugin_url . '/js/admin/embed.js', array( 'formidable_dom', 'jquery-ui-autocomplete' ), $version, true );
724 - self::register_popper2();
725 - wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '5.0.2', true );
677 + self::register_popper1();
678 + wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '4.6.1', true );
726 679
727 680 $settings_js_vars = array(
728 681 'currencies' => FrmCurrencyHelper::get_currencies(),
729 682 );
@@ -728,36 +681,51 @@
728 681 'currencies' => FrmCurrencyHelper::get_currencies(),
729 682 );
730 683 wp_register_script( 'formidable_settings', $plugin_url . '/js/admin/settings.js', array(), $version, true );
731 684 wp_localize_script( 'formidable_settings', 'frmSettings', $settings_js_vars );
732 - wp_register_script( 'formidable-web-components', $plugin_url . '/js/formidable-web-components.js', $frm_components_dependencies, $version, true );
733 685
734 686 if ( self::should_show_floating_links() ) {
735 687 self::enqueue_floating_links( $plugin_url, $version );
736 688 }
737 689
738 - wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', self::get_admin_js_dependencies(), $version, true );
690 + $dependencies = array(
691 + 'formidable_admin_global',
692 + 'jquery',
693 + 'jquery-ui-core',
694 + 'jquery-ui-draggable',
695 + 'jquery-ui-sortable',
696 + 'bootstrap_tooltip',
697 + 'bootstrap-multiselect',
698 + 'wp-i18n',
699 + // Required in WP versions older than 5.7
700 + 'wp-hooks',
701 + 'formidable_dom',
702 + 'formidable_embed',
703 + );
739 704
740 - wp_register_script(
741 - 'formidable_forms_list',
742 - $plugin_url . '/js/admin/forms-list.js',
743 - array(
744 - 'formidable_dom',
745 - ),
746 - $version,
747 - true
748 - );
705 + if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
706 + // We only need to load the color picker when editing styles.
707 + $dependencies[] = 'wp-color-picker';
708 + }
749 709
710 + wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', $dependencies, $version, true );
711 +
750 712 if ( FrmAppHelper::on_form_listing_page() ) {
751 713 // For the existing page dropdown in the Form embed modal.
752 714 wp_enqueue_script( 'jquery-ui-autocomplete' );
753 - wp_enqueue_script( 'formidable_forms_list' );
754 715 }
755 716
756 - wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '2.0', true );
717 + wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '1.1.1', true );
757 718
758 719 if ( ! class_exists( 'FrmTransHooksController', false ) ) {
759 - FrmTransLiteAppController::hide_gateway_fields_in_builder();
720 + /**
721 + * Gateway fields are included for add-on compatibility but we do not want it to be visible.
722 + * They do however need to be visible when the payments submodule is active.
723 + */
724 + wp_add_inline_style(
725 + 'formidable-admin',
726 + '#frm_builder_page li[data-ftype="gateway"] { display: none; }'
727 + );
760 728 }
761 729
762 730 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
763 731 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
@@ -762,15 +730,12 @@
762 730 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
763 731 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
764 732
765 733 global $pagenow;
766 -
767 - if ( str_starts_with( $page, 'formidable' ) || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
768 - self::enqueue_global_settings_scripts( $page );
769 -
734 + if ( strpos( $page, 'formidable' ) === 0 || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
770 735 wp_enqueue_script( 'admin-widgets' );
771 736 wp_enqueue_style( 'widgets' );
772 - self::maybe_deregister_popper1();
737 + self::maybe_deregister_popper2();
773 738 wp_enqueue_script( 'formidable_admin' );
774 739 wp_set_script_translations( 'formidable_admin', 'formidable' );
775 740 wp_enqueue_script( 'formidable_embed' );
776 741 wp_set_script_translations( 'formidable_embed', 'formidable' );
@@ -777,9 +742,8 @@
777 742 FrmAppHelper::localize_script( 'admin' );
778 743
779 744 wp_enqueue_style( 'formidable-animations' );
780 745 wp_enqueue_style( 'formidable-admin' );
781 -
782 746 if ( 'formidable-styles' !== $page && 'formidable-styles2' !== $page ) {
783 747 wp_enqueue_style( 'formidable-grids' );
784 748 self::maybe_enqueue_dropzone_css( $page );
785 749 } else {
@@ -795,9 +759,8 @@
795 759 wp_enqueue_script( 'formidable_entries' );
796 760 }
797 761
798 762 do_action( 'frm_enqueue_builder_scripts' );
799 - self::maybe_enqueue_legacy_paypal_assets();
800 763 self::include_upgrade_overlay();
801 764 self::include_info_overlay();
802 765 } elseif ( FrmAppHelper::is_view_builder_page() ) {
803 766 if ( isset( $_REQUEST['post_type'] ) ) {
@@ -803,13 +766,11 @@
803 766 if ( isset( $_REQUEST['post_type'] ) ) {
804 767 $post_type = sanitize_title( wp_unslash( $_REQUEST['post_type'] ) );
805 768 } elseif ( isset( $_REQUEST['post'] ) && absint( $_REQUEST['post'] ) ) {
806 769 $post = get_post( absint( wp_unslash( $_REQUEST['post'] ) ) );
807 -
808 770 if ( ! $post ) {
809 771 return;
810 772 }
811 -
812 773 $post_type = $post->post_type;
813 774 } else {
814 775 return;
815 776 }
@@ -827,37 +788,8 @@
827 788 self::enqueue_builder_assets( $plugin_url, $version );
828 789 }
829 790
830 791 /**
831 - * @since 6.27
832 - *
833 - * @return array
834 - */
835 - private static function get_admin_js_dependencies() {
836 - $dependencies = array(
837 - 'formidable_admin_global',
838 - 'jquery',
839 - 'jquery-ui-core',
840 - 'jquery-ui-draggable',
841 - 'jquery-ui-sortable',
842 - 'bootstrap_tooltip',
843 - 'bootstrap-multiselect',
844 - 'wp-i18n',
845 - // Required in WP versions older than 5.7
846 - 'wp-hooks',
847 - 'formidable_dom',
848 - 'formidable_embed',
849 - );
850 -
851 - if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
852 - // We only need to load the color picker when editing styles.
853 - $dependencies[] = 'wp-color-picker';
854 - }
855 -
856 - return $dependencies;
857 - }
858 -
859 - /**
860 792 * Enqueue the Form Builder assets.
861 793 *
862 794 * @since 6.24
863 795 *
@@ -862,9 +794,8 @@
862 794 * @since 6.24
863 795 *
864 796 * @param string $plugin_url The plugin URL.
865 797 * @param string $version The plugin version.
866 - *
867 798 * @return void
868 799 */
869 800 private static function enqueue_builder_assets( $plugin_url, $version ) {
870 801 wp_register_style( 'formidable-settings-components', $plugin_url . '/css/admin/frm-settings-components.css', array( 'formidable-admin', 'formidable-grids' ), $version );
@@ -878,30 +809,13 @@
878 809 wp_enqueue_script( 'formidable-settings-components' );
879 810 }
880 811
881 812 /**
882 - * Enqueues global settings scripts.
883 - *
884 - * @param string $page The `page` param in URL.
885 - *
886 - * @return void
887 - */
888 - private static function enqueue_global_settings_scripts( $page ) {
889 - if ( 'formidable-settings' !== $page ) {
890 - return;
891 - }
892 -
893 - wp_enqueue_style( 'wp-color-picker' );
894 - wp_enqueue_script( 'formidable_settings' );
895 - }
896 -
897 - /**
898 813 * Avoid loading dropzone CSS on the form list page. It isn't required there.
899 814 *
900 815 * @since 6.11
901 816 *
902 817 * @param string $page
903 - *
904 818 * @return void
905 819 */
906 820 private static function maybe_enqueue_dropzone_css( $page ) {
907 821 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -908,9 +822,8 @@
908 822 return;
909 823 }
910 824
911 825 $should_avoid_loading_dropzone = 'formidable' === $page && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
912 -
913 826 if ( ! $should_avoid_loading_dropzone ) {
914 827 wp_enqueue_style( 'formidable-dropzone' );
915 828 }
916 829 }
@@ -927,18 +840,12 @@
927 840 if ( ! FrmAppHelper::is_formidable_branding() ) {
928 841 return false;
929 842 }
930 843
931 - $should_show = FrmAppHelper::is_formidable_admin() && ! FrmAppHelper::is_style_editor_page() && ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
932 -
933 - /**
934 - * Filters whether the floating links should be displayed.
935 - *
936 - * @since 6.25.1
937 - *
938 - * @param bool $should_show Whether the floating links should be shown.
939 - */
940 - return apply_filters( 'frm_should_show_floating_links', $should_show );
844 + return FrmAppHelper::is_formidable_admin() &&
845 + ! FrmAppHelper::is_style_editor_page() &&
846 + ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) &&
847 + ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
941 848 }
942 849
943 850 /**
944 851 * @since 6.3.2
@@ -956,29 +863,8 @@
956 863 FrmUsageController::load_scripts();
957 864 }
958 865
959 866 /**
960 - * Enqueue legacy PayPal action settings styles when the PayPal add-on is active.
961 - *
962 - * @since 6.31
963 - *
964 - * @return void
965 - */
966 - private static function maybe_enqueue_legacy_paypal_assets() {
967 - if ( ! FrmAppHelper::is_form_builder_page() || ! class_exists( 'FrmPaymentsController' ) ) {
968 - return;
969 - }
970 -
971 - wp_register_style(
972 - 'formidable-legacy-paypal',
973 - FrmAppHelper::plugin_url() . '/css/admin/frm-legacy-paypal.css',
974 - array( 'formidable-admin' ),
975 - FrmAppHelper::plugin_version()
976 - );
977 - wp_enqueue_style( 'formidable-legacy-paypal' );
978 - }
979 -
980 - /**
981 867 * Enqueue required assets for the Legacy Views editor (Views v4.x).
982 868 *
983 869 * @since 6.1.2
984 870 *
@@ -986,9 +872,9 @@
986 872 */
987 873 private static function enqueue_legacy_views_assets() {
988 874 wp_enqueue_style( 'formidable-grids' );
989 875 wp_enqueue_script( 'jquery-ui-draggable' );
990 - self::maybe_deregister_popper1();
876 + self::maybe_deregister_popper2();
991 877 wp_enqueue_script( 'formidable_admin' );
992 878 wp_add_inline_style(
993 879 'formidable-admin',
994 880 '
@@ -1011,21 +897,21 @@
1011 897 }
1012 898 '
1013 899 );
1014 900 wp_enqueue_style( 'formidable-admin' );
1015 - wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
901 + wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() );
1016 902 FrmAppHelper::localize_script( 'admin' );
1017 903 self::include_info_overlay();
1018 904 }
1019 905
1020 906 /**
1021 - * Unregister Popper if the registered version is outdated.
907 + * Fix a Duplicator Pro conflict because it uses Popper 2. See issue #3459.
1022 908 *
1023 - * @since 6.26
909 + * @since 5.2.02.01
1024 910 *
1025 911 * @return void
1026 912 */
1027 - private static function maybe_deregister_popper1() {
913 + private static function maybe_deregister_popper2() {
1028 914 global $wp_scripts;
1029 915
1030 916 if ( ! array_key_exists( 'popper', $wp_scripts->registered ) ) {
1031 917 return;
@@ -1031,29 +917,26 @@
1031 917 return;
1032 918 }
1033 919
1034 920 $popper = $wp_scripts->registered['popper'];
1035 -
1036 - if ( ! version_compare( $popper->ver, '2.0', '<' ) ) {
1037 - return;
921 + if ( version_compare( $popper->ver, '2.0', '>=' ) ) {
922 + wp_deregister_script( 'popper' );
923 + self::register_popper1();
1038 924 }
1039 -
1040 - wp_deregister_script( 'popper' );
1041 - self::register_popper2();
1042 925 }
1043 926
1044 927 /**
1045 - * Register Popper required for Bootstrap 5.
928 + * Register Popper required for Bootstrap 4.
1046 929 *
1047 - * @since 6.26
930 + * @since 5.2.02.01
1048 931 *
1049 932 * @return void
1050 933 */
1051 - private static function register_popper2() {
934 + private static function register_popper1() {
1052 935 if ( ! self::should_register_popper() ) {
1053 936 return;
1054 937 }
1055 - wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array(), '2.11.8', true );
938 + wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array( 'jquery' ), '1.16.0', true );
1056 939 }
1057 940
1058 941 /**
1059 942 * Only register popper on Formidable pages.
@@ -1066,9 +949,8 @@
1066 949 private static function should_register_popper() {
1067 950 global $pagenow;
1068 951
1069 952 $post_id = FrmAppHelper::simple_get( 'post', 'absint' );
1070 -
1071 953 if ( 'post.php' === $pagenow && $post_id && 'frm_display' === get_post_type( $post_id ) ) {
1072 954 return true;
1073 955 }
1074 956
@@ -1073,16 +955,14 @@
1073 955 }
1074 956
1075 957 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1076 958 $is_views_post_type = 'frm_display' === $post_type;
1077 -
1078 959 if ( in_array( $pagenow, array( 'post-new.php', 'edit.php' ), true ) && $is_views_post_type ) {
1079 960 return true;
1080 961 }
1081 962
1082 963 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
1083 -
1084 - if ( str_starts_with( $page, 'formidable' ) ) {
964 + if ( strpos( $page, 'formidable' ) === 0 ) {
1085 965 return true;
1086 966 }
1087 967
1088 968 return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && FrmAppHelper::simple_get( 'taxonomy' ) === 'frm_application';
@@ -1096,15 +976,13 @@
1096 976 * @return void
1097 977 */
1098 978 private static function maybe_force_formidable_block_on_gutenberg_page() {
1099 979 global $pagenow;
1100 -
1101 980 if ( 'post.php' !== $pagenow ) {
1102 981 return;
1103 982 }
1104 983
1105 984 $form_id = FrmAppHelper::simple_get( 'frmForm', 'absint' );
1106 -
1107 985 if ( ! $form_id ) {
1108 986 return;
1109 987 }
1110 988
@@ -1152,9 +1030,9 @@
1152 1030 public static function create_rest_routes() {
1153 1031 $args = array(
1154 1032 'methods' => 'GET',
1155 1033 'callback' => 'FrmAppController::api_install',
1156 - 'permission_callback' => self::class . '::can_update_db',
1034 + 'permission_callback' => __CLASS__ . '::can_update_db',
1157 1035 );
1158 1036
1159 1037 register_rest_route( 'frm-admin/v1', '/install', $args );
1160 1038
@@ -1171,10 +1049,8 @@
1171 1049 * Make sure the install is only being run when we tell it to.
1172 1050 * We don't want to run manually by people calling the API.
1173 1051 *
1174 1052 * @since 4.06.02
1175 - *
1176 - * @return bool
1177 1053 */
1178 1054 public static function can_update_db() {
1179 1055 return get_transient( 'frm_updating_api' );
1180 1056 }
@@ -1204,9 +1080,9 @@
1204 1080 $response = rest_do_request( $request );
1205 1081 }
1206 1082
1207 1083 if ( $response->is_error() ) {
1208 - // If the remove post fails, use javascript instead
1084 + // if the remove post fails, use javascript instead
1209 1085 add_action( 'admin_notices', 'FrmAppController::install_js_fallback' );
1210 1086 }
1211 1087 }
1212 1088
@@ -1216,17 +1092,14 @@
1216 1092 *
1217 1093 * @return void
1218 1094 */
1219 1095 private static function maybe_add_wp_site_health() {
1220 - if ( class_exists( 'WP_Site_Health' ) ) {
1221 - return;
1096 + if ( ! class_exists( 'WP_Site_Health' ) ) {
1097 + $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1098 + if ( file_exists( $wp_site_health_path ) ) {
1099 + require_once $wp_site_health_path;
1100 + }
1222 1101 }
1223 -
1224 - $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1225 -
1226 - if ( file_exists( $wp_site_health_path ) ) {
1227 - require_once $wp_site_health_path;
1228 - }
1229 1102 }
1230 1103
1231 1104 /**
1232 1105 * @since 3.0
@@ -1234,14 +1107,12 @@
1234 1107 * @return true
1235 1108 */
1236 1109 public static function api_install() {
1237 1110 delete_transient( 'frm_updating_api' );
1238 -
1239 1111 if ( self::needs_update() ) {
1240 1112 $running = get_option( 'frm_install_running' );
1241 -
1242 1113 if ( false === $running || $running < strtotime( '-5 minutes' ) ) {
1243 - update_option( 'frm_install_running', time(), false );
1114 + update_option( 'frm_install_running', time(), 'no' );
1244 1115 self::install();
1245 1116 delete_option( 'frm_install_running' );
1246 1117 }
1247 1118 }
@@ -1289,13 +1160,8 @@
1289 1160
1290 1161 wp_die();
1291 1162 }
1292 1163
1293 - /**
1294 - * @param array $tables
1295 - *
1296 - * @return array
1297 - */
1298 1164 public static function drop_tables( $tables ) {
1299 1165 global $wpdb;
1300 1166 $tables[] = $wpdb->prefix . 'frm_fields';
1301 1167 $tables[] = $wpdb->prefix . 'frm_forms';
@@ -1329,9 +1195,9 @@
1329 1195 }
1330 1196
1331 1197 /**
1332 1198 * The payment cron is unscheduled when Formidable is deactivated.
1333 - * We need to add it back again on activation if any payment gateway is configured.
1199 + * We need to add it back again on activation if Stripe is configured.
1334 1200 *
1335 1201 * @since 6.5
1336 1202 *
1337 1203 * @return void
@@ -1336,13 +1202,9 @@
1336 1202 *
1337 1203 * @return void
1338 1204 */
1339 1205 private static function maybe_activate_payment_cron() {
1340 - $stripe_connected = FrmStrpLiteConnectHelper::at_least_one_mode_is_setup();
1341 - $square_connected = FrmSquareLiteConnectHelper::at_least_one_mode_is_setup();
1342 - $paypal_connected = FrmPayPalLiteConnectHelper::at_least_one_mode_is_setup();
1343 -
1344 - if ( ! $stripe_connected && ! $square_connected && ! $paypal_connected ) {
1206 + if ( ! FrmStrpLiteConnectHelper::stripe_connect_is_setup() ) {
1345 1207 return;
1346 1208 }
1347 1209
1348 1210 FrmTransLiteAppController::maybe_schedule_cron();
@@ -1347,15 +1209,14 @@
1347 1209
1348 1210 FrmTransLiteAppController::maybe_schedule_cron();
1349 1211 }
1350 1212
1351 - /**
1352 - * @param string $text
1353 - *
1354 - * @return string
1355 - */
1356 1213 public static function set_footer_text( $text ) {
1357 - return FrmAppHelper::is_formidable_admin() ? '' : $text;
1214 + if ( FrmAppHelper::is_formidable_admin() ) {
1215 + $text = '';
1216 + }
1217 +
1218 + return $text;
1358 1219 }
1359 1220
1360 1221 /**
1361 1222 * Add admin footer links.
@@ -1365,9 +1226,8 @@
1365 1226 * @return void
1366 1227 */
1367 1228 public static function add_admin_footer_links() {
1368 1229 FrmFormsController::include_device_too_small_message();
1369 -
1370 1230 if ( self::should_show_footer_links() ) {
1371 1231 include FrmAppHelper::plugin_path() . '/classes/views/shared/admin-footer-links.php';
1372 1232 }
1373 1233 }
@@ -1382,9 +1242,8 @@
1382 1242 private static function should_show_footer_links() {
1383 1243 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1384 1244 $is_formidable_page = FrmAppHelper::is_formidable_admin() || 'frm_logs' === $post_type;
1385 1245 $show_footer_links = $is_formidable_page;
1386 -
1387 1246 if ( FrmAppHelper::is_full_screen() || ! FrmAppHelper::is_formidable_branding() ) {
1388 1247 $show_footer_links = false;
1389 1248 }
1390 1249
@@ -1393,9 +1252,8 @@
1393 1252 *
1394 1253 * @since 6.7
1395 1254 *
1396 1255 * @param bool $show_footer_links
1397 - *
1398 1256 * @return bool
1399 1257 */
1400 1258 return apply_filters( 'frm_show_footer_links', $show_footer_links );
1401 1259 }
@@ -1422,9 +1280,8 @@
1422 1280 'icon' => 'frm_lock_simple',
1423 1281 );
1424 1282
1425 1283 $error_args = wp_parse_args( $error_args, $defaults );
1426 -
1427 1284 if ( ! isset( $error_args['cancel_text'] ) && ! empty( $error_args['cancel_url'] ) ) {
1428 1285 $error_args['cancel_text'] = __( 'Cancel', 'formidable' );
1429 1286 }
1430 1287
@@ -1441,9 +1298,8 @@
1441 1298 * @since 6.4
1442 1299 *
1443 1300 * @param string $plugin_url URL of the plugin.
1444 1301 * @param string $version Current version of the plugin.
1445 - *
1446 1302 * @return void
1447 1303 */
1448 1304 private static function enqueue_floating_links( $plugin_url, $version ) {
1449 1305 if ( ! $plugin_url || ! $version ) {
@@ -1463,20 +1319,10 @@
1463 1319 if ( function_exists( 'wp_set_script_translations' ) ) {
1464 1320 wp_set_script_translations( 's11-floating-links-config', 's11-' );
1465 1321 }
1466 1322
1467 - $upgrade_utm = array(
1468 - 'campaign' => 'floating-links',
1469 - 'content' => 'floating-links-upgrade',
1470 - );
1471 - $docs_utm = array(
1472 - 'campaign' => 'floating-links',
1473 - 'content' => 'floating-links-docs',
1474 - );
1475 1323 $floating_links_data = array(
1476 - 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1477 - 'upgradeUrl' => FrmAppHelper::admin_upgrade_link( $upgrade_utm ),
1478 - 'documentationUrl' => FrmAppHelper::admin_upgrade_link( $docs_utm, 'knowledgebase/' ),
1324 + 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1479 1325 );
1480 1326 wp_localize_script( 's11-floating-links-config', 's11FloatingLinksData', $floating_links_data );
1481 1327
1482 1328 /**
@@ -1494,9 +1340,8 @@
1494 1340 * @return bool
1495 1341 */
1496 1342 private static function in_our_pages() {
1497 1343 global $current_screen, $pagenow;
1498 -
1499 1344 if ( FrmAppHelper::is_formidable_admin() ) {
1500 1345 return true;
1501 1346 }
1502 1347
@@ -1503,9 +1348,13 @@
1503 1348 if ( ! empty( $current_screen->post_type ) && 'frm_logs' === $current_screen->post_type ) {
1504 1349 return true;
1505 1350 }
1506 1351
1507 - return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' );
1352 + if ( in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' ) ) {
1353 + return true;
1354 + }
1355 +
1356 + return false;
1508 1357 }
1509 1358
1510 1359 /**
1511 1360 * Handles actions related to the current screen.
@@ -1541,9 +1390,8 @@
1541 1390 foreach ( $actions as $action ) {
1542 1391 if ( empty( $wp_filter[ $action ]->callbacks ) ) {
1543 1392 continue;
1544 1393 }
1545 -
1546 1394 foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
1547 1395 foreach ( $callbacks as $callback_name => $callback ) {
1548 1396 if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
1549 1397 continue;
@@ -1559,18 +1407,14 @@
1559 1407 *
1560 1408 * @return void
1561 1409 */
1562 1410 private static function remember_custom_sort() {
1563 - $meta_key = self::get_sort_pref_user_meta_key();
1564 -
1565 - if ( false === $meta_key ) {
1411 + $screen = get_current_screen();
1412 + if ( ! $screen ) {
1566 1413 return;
1567 1414 }
1568 1415
1569 - $is_form_list = FrmAppHelper::is_admin_list_page();
1570 - $is_entry_list = FrmAppHelper::is_admin_list_page( 'formidable-entries' );
1571 -
1572 - if ( ! $is_form_list && ! $is_entry_list ) {
1416 + if ( ! FrmAppHelper::is_admin_list_page() && ! FrmAppHelper::is_admin_list_page( 'formidable-entries' ) ) {
1573 1417 return;
1574 1418 }
1575 1419
1576 1420 $orderby = FrmAppHelper::get_param( 'orderby' );
@@ -1578,37 +1422,29 @@
1578 1422 if ( ! $orderby ) {
1579 1423 return;
1580 1424 }
1581 1425
1582 - $user_id = get_current_user_id();
1583 - $order = FrmAppHelper::get_param( 'order' );
1584 - $new_sort = array(
1426 + $user_id = get_current_user_id();
1427 + $meta_key = 'frm_preferred_list_sort_' . $screen->id;
1428 + $order = FrmAppHelper::get_param( 'order' );
1429 +
1430 + $new_sort = array(
1585 1431 'orderby' => $orderby,
1586 1432 'order' => $order,
1587 1433 );
1588 - $previous_meta = get_user_meta( $user_id, $meta_key, true );
1589 - $current_sort = $previous_meta;
1590 - $form_id = $is_entry_list ? FrmAppHelper::simple_get( 'form', 'absint' ) : 0;
1591 1434
1592 - if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[ $form_id ] ) ) {
1593 - $current_sort = $current_sort[ $form_id ];
1594 - }
1435 + $current_sort = get_user_meta( $user_id, $meta_key, true );
1595 1436
1596 - if ( $new_sort === $current_sort ) {
1597 - return;
1437 + if ( $new_sort !== $current_sort ) {
1438 + update_user_meta(
1439 + $user_id,
1440 + $meta_key,
1441 + array(
1442 + 'orderby' => $orderby,
1443 + 'order' => $order,
1444 + )
1445 + );
1598 1446 }
1599 -
1600 - $new_meta = $new_sort;
1601 -
1602 - if ( $is_entry_list && $form_id && is_int( $form_id ) ) {
1603 - // Index meta by form ID.
1604 - $temp_meta = is_array( $previous_meta ) ? $previous_meta : array();
1605 - $temp_meta[ $form_id ] = $new_meta;
1606 - $new_meta = $temp_meta;
1607 - unset( $temp_meta );
1608 - }
1609 -
1610 - update_user_meta( $user_id, $meta_key, $new_meta );
1611 1447 }
1612 1448
1613 1449 /**
1614 1450 * Retrieve and apply any saved sorting preferences for the current screen.
@@ -1614,52 +1450,32 @@
1614 1450 * Retrieve and apply any saved sorting preferences for the current screen.
1615 1451 *
1616 1452 * @since 6.19
1617 1453 *
1618 - * @param string $orderby Reference to the current 'orderby' parameter.
1619 - * @param string $order Reference to the current 'order' parameter.
1620 - *
1454 + * @param string &$orderby Reference to the current 'orderby' parameter.
1455 + * @param string &$order Reference to the current 'order' parameter.
1621 1456 * @return void
1622 1457 */
1623 1458 public static function apply_saved_sort_preference( &$orderby, &$order ) {
1624 - $meta_key = self::get_sort_pref_user_meta_key();
1625 -
1626 - if ( false === $meta_key ) {
1459 + if ( ! function_exists( 'get_current_screen' ) ) {
1627 1460 return;
1628 1461 }
1629 1462
1630 - $preferred_list_sort = get_user_meta( get_current_user_id(), $meta_key, true );
1631 - $form_id = FrmAppHelper::simple_get( 'form', 'absint' );
1632 -
1633 - if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[ $form_id ] ) ) {
1634 - $preferred_list_sort = $preferred_list_sort[ $form_id ];
1635 - }
1636 -
1637 - if ( ! is_array( $preferred_list_sort ) || empty( $preferred_list_sort['orderby'] ) ) {
1463 + $screen = get_current_screen();
1464 + if ( ! $screen ) {
1638 1465 return;
1639 1466 }
1640 1467
1641 - $orderby = $preferred_list_sort['orderby'];
1468 + $user_id = get_current_user_id();
1469 + $preferred_list_sort = get_user_meta( $user_id, 'frm_preferred_list_sort_' . $screen->id, true );
1642 1470
1643 - if ( ! empty( $preferred_list_sort['order'] ) ) {
1644 - $order = $preferred_list_sort['order'];
1645 - }
1646 - }
1471 + if ( is_array( $preferred_list_sort ) && ! empty( $preferred_list_sort['orderby'] ) ) {
1472 + $orderby = $preferred_list_sort['orderby'];
1647 1473
1648 - /**
1649 - * Get a simple user meta key that only includes the screen ID.
1650 - *
1651 - * @since 6.25.1
1652 - *
1653 - * @return false|string
1654 - */
1655 - private static function get_sort_pref_user_meta_key() {
1656 - if ( ! function_exists( 'get_current_screen' ) ) {
1657 - return false;
1474 + if ( ! empty( $preferred_list_sort['order'] ) ) {
1475 + $order = $preferred_list_sort['order'];
1476 + }
1658 1477 }
1659 -
1660 - $screen = get_current_screen();
1661 - return $screen ? 'frm_preferred_list_sort_' . $screen->id : false;
1662 1478 }
1663 1479
1664 1480 /**
1665 1481 * Validate that the callback name is ours not from third-party.
@@ -1679,9 +1495,12 @@
1679 1495 *
1680 1496 * @return bool
1681 1497 */
1682 1498 private static function is_our_callback_array( $callback ) {
1683 - return ! empty( $callback['function'] ) && is_array( $callback['function'] ) && ! empty( $callback['function'][0] ) && self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1499 + return ! empty( $callback['function'] ) &&
1500 + is_array( $callback['function'] ) &&
1501 + ! empty( $callback['function'][0] ) &&
1502 + self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] );
1684 1503 }
1685 1504
1686 1505 /**
1687 1506 * In some cases, the DB tables may fail to install.
@@ -1692,9 +1511,10 @@
1692 1511 */
1693 1512 private static function add_missing_tables() {
1694 1513 FrmAppHelper::permission_check( 'frm_view_forms' );
1695 1514
1696 - $error = FrmInbox::check_for_error();
1515 + $inbox = new FrmInbox();
1516 + $error = $inbox->check_for_error();
1697 1517
1698 1518 if ( ! $error || 'failed-to-create-tables' !== $error['key'] ) {
1699 1519 // Confirm the inbox item with this CTA exists.
1700 1520 wp_safe_redirect( admin_url( 'admin.php?page=formidable' ) );
@@ -1726,21 +1546,6 @@
1726 1546 FrmAppHelper::permission_check( 'frm_view_forms' );
1727 1547 check_ajax_referer( 'frm_ajax', 'nonce' );
1728 1548 update_user_option( get_current_user_id(), 'frm_ignore_small_screen_warning', true );
1729 1549 wp_send_json_success();
1730 - }
1731 -
1732 - /**
1733 - * Enqueue the components scripts.
1734 - *
1735 - * @since 6.28
1736 - *
1737 - * @return void
1738 - */
1739 - public static function enqueue_components_scripts() {
1740 - if ( is_callable( array( 'FrmProFormsController', 'enqueue_pro_web_components_script' ) ) ) {
1741 - FrmProFormsController::enqueue_pro_web_components_script();
1742 - }
1743 -
1744 - wp_enqueue_script( 'formidable-web-components' );
1745 1550 }
1746 1551 }