| @@ -14,9 +14,8 @@ | ||
| 14 | 14 | |
| 15 | 15 | /** |
| 16 | 16 | * @param array $values |
| 17 | 17 | * @param bool|string[] $exclude |
| 18 | - * | |
| 19 | 18 | * @return array |
| 20 | 19 | */ |
| 21 | 20 | public static function validate( $values, $exclude = false ) { |
| 22 | 21 | FrmEntry::sanitize_entry_post( $values ); |
| @@ -23,12 +22,13 @@ | ||
| 23 | 22 | $errors = array(); |
| 24 | 23 | |
| 25 | 24 | if ( ! isset( $values['form_id'] ) || ! isset( $values['item_meta'] ) ) { |
| 26 | 25 | $errors['form'] = __( 'There was a problem with your submission. Please try again.', 'formidable' ); |
| 26 | + | |
| 27 | 27 | return $errors; |
| 28 | 28 | } |
| 29 | 29 | |
| 30 | - if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) { // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong | |
| 30 | + if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) { | |
| 31 | 31 | $frm_settings = FrmAppHelper::get_settings(); |
| 32 | 32 | $errors['form'] = $frm_settings->admin_permission; |
| 33 | 33 | } |
| 34 | 34 | |
| @@ -44,9 +44,9 @@ | ||
| 44 | 44 | self::validate_field( $posted_field, $errors, $values, $args ); |
| 45 | 45 | unset( $posted_field ); |
| 46 | 46 | } |
| 47 | 47 | |
| 48 | - if ( ! $errors ) { | |
| 48 | + if ( empty( $errors ) ) { | |
| 49 | 49 | self::spam_check( $exclude, $values, $errors ); |
| 50 | 50 | } |
| 51 | 51 | |
| 52 | 52 | /** |
| @@ -83,15 +83,9 @@ | ||
| 83 | 83 | $_POST['item_meta'] = array(); |
| 84 | 84 | } |
| 85 | 85 | } |
| 86 | 86 | |
| 87 | - /** | |
| 88 | - * @param array $values | |
| 89 | - * | |
| 90 | - * @return void | |
| 91 | - */ | |
| 92 | 87 | private static function set_item_key( &$values ) { |
| 93 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 94 | 88 | if ( ! isset( $values['item_key'] ) || $values['item_key'] == '' ) { |
| 95 | 89 | global $wpdb; |
| 96 | 90 | $values['item_key'] = FrmAppHelper::get_unique_key( '', $wpdb->prefix . 'frm_items', 'item_key' ); |
| 97 | 91 | $_POST['item_key'] = $values['item_key']; |
| @@ -97,14 +91,8 @@ | ||
| 97 | 91 | $_POST['item_key'] = $values['item_key']; |
| 98 | 92 | } |
| 99 | 93 | } |
| 100 | 94 | |
| 101 | - /** | |
| 102 | - * @param array $values | |
| 103 | - * @param array|string $exclude | |
| 104 | - * | |
| 105 | - * @return array | |
| 106 | - */ | |
| 107 | 95 | private static function get_fields_to_validate( $values, $exclude ) { |
| 108 | 96 | $where = apply_filters( 'frm_posted_field_ids', array( 'fi.form_id' => $values['form_id'] ) ); |
| 109 | 97 | |
| 110 | 98 | // Don't get subfields |
| @@ -110,9 +98,9 @@ | ||
| 110 | 98 | // Don't get subfields |
| 111 | 99 | $where['fr.parent_form_id'] = array( null, 0 ); |
| 112 | 100 | |
| 113 | 101 | // Don't get excluded fields (like file upload fields in the ajax validation) |
| 114 | - if ( $exclude ) { | |
| 102 | + if ( ! empty( $exclude ) ) { | |
| 115 | 103 | $where['fi.type not'] = $exclude; |
| 116 | 104 | } |
| 117 | 105 | |
| 118 | 106 | $fields = FrmField::getAll( $where, 'field_order' ); |
| @@ -127,16 +115,8 @@ | ||
| 127 | 115 | */ |
| 128 | 116 | return apply_filters( 'frm_fields_to_validate', $fields, compact( 'values', 'exclude', 'where' ) ); |
| 129 | 117 | } |
| 130 | 118 | |
| 131 | - /** | |
| 132 | - * @param object $posted_field | |
| 133 | - * @param array $errors | |
| 134 | - * @param array $values | |
| 135 | - * @param array $args | |
| 136 | - * | |
| 137 | - * @return void | |
| 138 | - */ | |
| 139 | 119 | public static function validate_field( $posted_field, &$errors, $values, $args = array() ) { |
| 140 | 120 | $defaults = array( |
| 141 | 121 | 'id' => $posted_field->id, |
| 142 | 122 | // The id of the repeat or embed form. |
| @@ -146,18 +126,23 @@ | ||
| 146 | 126 | // Exclude these field types from validation. |
| 147 | 127 | 'exclude' => array(), |
| 148 | 128 | |
| 149 | 129 | ); |
| 150 | - $args = wp_parse_args( $args, $defaults ); | |
| 151 | - $value = empty( $args['parent_field_id'] ) ? ( $values['item_meta'][ $args['id'] ] ?? '' ) : $values; | |
| 130 | + $args = wp_parse_args( $args, $defaults ); | |
| 152 | 131 | |
| 132 | + if ( empty( $args['parent_field_id'] ) ) { | |
| 133 | + $value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : ''; | |
| 134 | + } else { | |
| 135 | + // value is from a nested form | |
| 136 | + $value = $values; | |
| 137 | + } | |
| 138 | + | |
| 153 | 139 | // Check for values in "Other" fields |
| 154 | 140 | FrmEntriesHelper::maybe_set_other_validation( $posted_field, $value, $args ); |
| 155 | 141 | |
| 156 | 142 | self::maybe_clear_value_for_default_blank_setting( $posted_field, $value ); |
| 157 | 143 | |
| 158 | - $should_trim = is_array( $value ) && count( $value ) === 1 && isset( $value[0] ) && $posted_field->type !== 'checkbox'; | |
| 159 | - | |
| 144 | + $should_trim = is_array( $value ) && count( $value ) == 1 && isset( $value[0] ) && $posted_field->type !== 'checkbox'; | |
| 160 | 145 | if ( $should_trim ) { |
| 161 | 146 | $value = reset( $value ); |
| 162 | 147 | } |
| 163 | 148 | |
| @@ -164,9 +149,8 @@ | ||
| 164 | 149 | if ( ! is_array( $value ) ) { |
| 165 | 150 | $value = trim( $value ); |
| 166 | 151 | } |
| 167 | 152 | |
| 168 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 169 | 153 | if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) { |
| 170 | 154 | $errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' ); |
| 171 | 155 | } elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing |
| 172 | 156 | self::maybe_add_item_name( $value, $posted_field ); |
| @@ -180,9 +164,8 @@ | ||
| 180 | 164 | // Field might want to modify value before other parts of the system |
| 181 | 165 | // e.g. trim off excess values like in the case of fields with limit. |
| 182 | 166 | $value = apply_filters( 'frm_modify_posted_field_value', $value, $errors, $posted_field, $args ); |
| 183 | 167 | |
| 184 | - // phpcs:ignore Universal.Operators.StrictComparisons | |
| 185 | 168 | if ( $value != '' ) { |
| 186 | 169 | self::validate_phone_field( $errors, $posted_field, $value, $args ); |
| 187 | 170 | } |
| 188 | 171 | |
| @@ -232,18 +215,16 @@ | ||
| 232 | 215 | * |
| 233 | 216 | * @param stdClass $field |
| 234 | 217 | * @param array|string $value |
| 235 | 218 | * @param array $options |
| 236 | - * | |
| 237 | 219 | * @return bool |
| 238 | 220 | */ |
| 239 | - private static function option_is_valid( $field, $value, $options ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh | |
| 221 | + private static function option_is_valid( $field, $value, $options ) { | |
| 240 | 222 | if ( '' === $value ) { |
| 241 | 223 | return true; |
| 242 | 224 | } |
| 243 | 225 | |
| 244 | 226 | $field_object = FrmFieldFactory::get_field_type( $field->type, $field ); |
| 245 | - | |
| 246 | 227 | if ( ! $field_object->field_type_has_options_settings() ) { |
| 247 | 228 | return true; |
| 248 | 229 | } |
| 249 | 230 | |
| @@ -265,9 +246,9 @@ | ||
| 265 | 246 | foreach ( $value as $current_value ) { |
| 266 | 247 | $match = false; |
| 267 | 248 | |
| 268 | 249 | foreach ( $options as $key => $option ) { |
| 269 | - if ( str_starts_with( $key, 'other_' ) ) { | |
| 250 | + if ( strpos( $key, 'other_' ) === 0 ) { | |
| 270 | 251 | // Always return true if an other option is found. |
| 271 | 252 | return true; |
| 272 | 253 | } |
| 273 | 254 | |
| @@ -278,21 +259,18 @@ | ||
| 278 | 259 | $option_value = $option; |
| 279 | 260 | } |
| 280 | 261 | |
| 281 | 262 | $match = trim( $current_value ) === trim( $option_value ); |
| 282 | - | |
| 283 | 263 | if ( $match ) { |
| 284 | 264 | break; |
| 285 | 265 | } |
| 286 | 266 | |
| 287 | 267 | $match = trim( $current_value ) === trim( do_shortcode( $option_value ) ); |
| 288 | - | |
| 289 | 268 | if ( $match ) { |
| 290 | 269 | break; |
| 291 | 270 | } |
| 292 | 271 | |
| 293 | 272 | $match = self::is_filtered_match( $current_value, $option_value ); |
| 294 | - | |
| 295 | 273 | if ( $match ) { |
| 296 | 274 | break; |
| 297 | 275 | } |
| 298 | 276 | |
| @@ -297,9 +275,8 @@ | ||
| 297 | 275 | } |
| 298 | 276 | |
| 299 | 277 | if ( is_numeric( $current_value ) ) { |
| 300 | 278 | $match = (int) $current_value === (int) $option_value; |
| 301 | - | |
| 302 | 279 | if ( $match ) { |
| 303 | 280 | break; |
| 304 | 281 | } |
| 305 | 282 | } |
| @@ -321,25 +298,20 @@ | ||
| 321 | 298 | * @since 6.22 |
| 322 | 299 | * |
| 323 | 300 | * @param string $value |
| 324 | 301 | * @param string $option_value |
| 325 | - * | |
| 326 | 302 | * @return bool |
| 327 | 303 | */ |
| 328 | 304 | private static function is_filtered_match( $value, $option_value ) { |
| 329 | 305 | // First remove the wpautop filter so it doesn't add extra tags to $option_value. |
| 330 | 306 | $filter_priority = has_filter( 'the_content', 'wpautop' ); |
| 331 | - | |
| 332 | 307 | if ( is_numeric( $filter_priority ) ) { |
| 333 | 308 | remove_filter( 'the_content', 'wpautop', $filter_priority ); |
| 334 | 309 | } |
| 335 | - | |
| 336 | 310 | $filtered_option = apply_filters( 'the_content', $option_value ); |
| 337 | - | |
| 338 | 311 | if ( is_numeric( $filter_priority ) ) { |
| 339 | 312 | add_filter( 'the_content', 'wpautop', $filter_priority ); |
| 340 | 313 | } |
| 341 | - | |
| 342 | 314 | return trim( $value ) === trim( $filtered_option ); |
| 343 | 315 | } |
| 344 | 316 | |
| 345 | 317 | /** |
| @@ -347,11 +319,8 @@ | ||
| 347 | 319 | * This is to help avoid issues where the options could be based on a URL param for example. |
| 348 | 320 | * |
| 349 | 321 | * @since 6.21 |
| 350 | 322 | * |
| 351 | - * @param object $field_object The field object. | |
| 352 | - * @param array|string $value The value to validate. | |
| 353 | - * | |
| 354 | 323 | * @return bool |
| 355 | 324 | */ |
| 356 | 325 | private static function options_are_dynamic_based_on_hook( $field_object, $value ) { |
| 357 | 326 | $values = (array) $field_object; |
| @@ -364,9 +333,10 @@ | ||
| 364 | 333 | $option_value = $separate_value ? $option['value'] : $option['label']; |
| 365 | 334 | } else { |
| 366 | 335 | $option_value = $option; |
| 367 | 336 | } |
| 368 | - return do_shortcode( $option_value ); | |
| 337 | + $option_value = do_shortcode( $option_value ); | |
| 338 | + return $option_value; | |
| 369 | 339 | }; |
| 370 | 340 | |
| 371 | 341 | $values_options = array_map( $map_callback, $values['options'] ); |
| 372 | 342 | $field_object_options = array_map( $map_callback, $field_object->options ); |
| @@ -380,14 +350,11 @@ | ||
| 380 | 350 | * @since 5.2.02 |
| 381 | 351 | * |
| 382 | 352 | * @param array|string $value Field value. |
| 383 | 353 | * @param object $field Field object. |
| 384 | - * | |
| 385 | - * @return void | |
| 386 | 354 | */ |
| 387 | 355 | private static function maybe_add_item_name( $value, $field ) { |
| 388 | 356 | $item_name = false; |
| 389 | - | |
| 390 | 357 | if ( 'name' === $field->type ) { |
| 391 | 358 | $field_obj = FrmFieldFactory::get_field_object( $field ); |
| 392 | 359 | $item_name = $field_obj->get_display_value( $value ); |
| 393 | 360 | } elseif ( 'text' === $field->type ) { |
| @@ -404,14 +371,11 @@ | ||
| 404 | 371 | * Set $value to an empty string if it matches its label |
| 405 | 372 | * |
| 406 | 373 | * @param object $field |
| 407 | 374 | * @param string $value |
| 408 | - * | |
| 409 | - * @return void | |
| 410 | 375 | */ |
| 411 | 376 | private static function maybe_clear_value_for_default_blank_setting( $field, &$value ) { |
| 412 | 377 | $position = FrmField::get_option( $field, 'label' ); |
| 413 | - | |
| 414 | 378 | if ( ! $position ) { |
| 415 | 379 | $position = FrmStylesController::get_style_val( 'position', $field->form_id ); |
| 416 | 380 | } |
| 417 | 381 | |
| @@ -419,16 +383,8 @@ | ||
| 419 | 383 | $value = ''; |
| 420 | 384 | } |
| 421 | 385 | } |
| 422 | 386 | |
| 423 | - /** | |
| 424 | - * @param array $errors | |
| 425 | - * @param object $posted_field | |
| 426 | - * @param mixed $value | |
| 427 | - * @param array $args | |
| 428 | - * | |
| 429 | - * @return void | |
| 430 | - */ | |
| 431 | 387 | public static function validate_field_types( &$errors, $posted_field, $value, $args ) { |
| 432 | 388 | $field_obj = FrmFieldFactory::get_field_object( $posted_field ); |
| 433 | 389 | $args['value'] = $value; |
| 434 | 390 | $args['errors'] = $errors; |
| @@ -433,22 +389,13 @@ | ||
| 433 | 389 | $args['value'] = $value; |
| 434 | 390 | $args['errors'] = $errors; |
| 435 | 391 | |
| 436 | 392 | $new_errors = $field_obj->validate( $args ); |
| 437 | - | |
| 438 | - if ( $new_errors ) { | |
| 393 | + if ( ! empty( $new_errors ) ) { | |
| 439 | 394 | $errors = array_merge( $errors, $new_errors ); |
| 440 | 395 | } |
| 441 | 396 | } |
| 442 | 397 | |
| 443 | - /** | |
| 444 | - * @param array $errors | |
| 445 | - * @param object $field | |
| 446 | - * @param string $value | |
| 447 | - * @param array $args | |
| 448 | - * | |
| 449 | - * @return void | |
| 450 | - */ | |
| 451 | 398 | public static function validate_phone_field( &$errors, $field, $value, $args ) { |
| 452 | 399 | $format_value = FrmField::get_option( $field, 'format' ); |
| 453 | 400 | |
| 454 | 401 | if ( $field->type === 'phone' || ( $field->type === 'text' && $format_value && ! FrmCurrencyHelper::is_currency_format( $format_value ) ) ) { |
| @@ -459,13 +406,8 @@ | ||
| 459 | 406 | } |
| 460 | 407 | } |
| 461 | 408 | } |
| 462 | 409 | |
| 463 | - /** | |
| 464 | - * @param object $field | |
| 465 | - * | |
| 466 | - * @return string | |
| 467 | - */ | |
| 468 | 410 | public static function phone_format( $field ) { |
| 469 | 411 | if ( FrmField::is_option_empty( $field, 'format' ) ) { |
| 470 | 412 | $pattern = self::default_phone_format(); |
| 471 | 413 | } else { |
| @@ -477,19 +419,19 @@ | ||
| 477 | 419 | $pattern = html_entity_decode( $pattern ); |
| 478 | 420 | $pattern = apply_filters( 'frm_phone_pattern', $pattern, $field ); |
| 479 | 421 | |
| 480 | 422 | // Create a regexp if format is not already a regexp |
| 481 | - if ( ! str_starts_with( $pattern, '^' ) ) { | |
| 423 | + if ( strpos( $pattern, '^' ) !== 0 ) { | |
| 482 | 424 | $pattern = self::create_regular_expression_from_format( $pattern ); |
| 483 | 425 | } |
| 484 | 426 | |
| 485 | - return '/' . $pattern . '/'; | |
| 427 | + $pattern = '/' . $pattern . '/'; | |
| 428 | + | |
| 429 | + return $pattern; | |
| 486 | 430 | } |
| 487 | 431 | |
| 488 | 432 | /** |
| 489 | 433 | * @since 3.01 |
| 490 | - * | |
| 491 | - * @return string | |
| 492 | 434 | */ |
| 493 | 435 | private static function default_phone_format() { |
| 494 | 436 | return '^((\+\d{1,3}(-|.| )?\(?\d\)?(-| |.)?\d{1,5})|(\(?\d{2,6}\)?))(-|.| )?(\d{3,4})(-|.| )?(\d{4})(( x| ext)\d{1,5}){0,1}$'; |
| 495 | 437 | } |
| @@ -515,14 +457,13 @@ | ||
| 515 | 457 | $pattern = str_replace( 'a', '[a-zA-Z]', $pattern ); |
| 516 | 458 | $pattern = str_replace( '*', 'w', $pattern ); |
| 517 | 459 | $pattern = str_replace( '/', '\/', $pattern ); |
| 518 | 460 | |
| 519 | - if ( str_contains( $pattern, '\?' ) ) { | |
| 461 | + if ( strpos( $pattern, '\?' ) !== false ) { | |
| 520 | 462 | $parts = explode( '\?', $pattern ); |
| 521 | 463 | $pattern = ''; |
| 522 | - | |
| 523 | 464 | foreach ( $parts as $part ) { |
| 524 | - if ( ! $pattern ) { | |
| 465 | + if ( empty( $pattern ) ) { | |
| 525 | 466 | $pattern .= $part; |
| 526 | 467 | } else { |
| 527 | 468 | $pattern .= '(' . $part . ')?'; |
| 528 | 469 | } |
| @@ -527,10 +468,11 @@ | ||
| 527 | 468 | $pattern .= '(' . $part . ')?'; |
| 528 | 469 | } |
| 529 | 470 | } |
| 530 | 471 | } |
| 472 | + $pattern = '^' . $pattern . '$'; | |
| 531 | 473 | |
| 532 | - return '^' . $pattern . '$'; | |
| 474 | + return $pattern; | |
| 533 | 475 | } |
| 534 | 476 | |
| 535 | 477 | /** |
| 536 | 478 | * Check for spam. |
| @@ -537,10 +479,8 @@ | ||
| 537 | 479 | * |
| 538 | 480 | * @param bool $exclude |
| 539 | 481 | * @param array $values |
| 540 | 482 | * @param array $errors By reference. |
| 541 | - * | |
| 542 | - * @return void | |
| 543 | 483 | */ |
| 544 | 484 | public static function spam_check( $exclude, $values, &$errors ) { |
| 545 | 485 | if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) { |
| 546 | 486 | // Do not check spam on importing. |
| @@ -546,9 +486,9 @@ | ||
| 546 | 486 | // Do not check spam on importing. |
| 547 | 487 | return; |
| 548 | 488 | } |
| 549 | 489 | |
| 550 | - if ( $exclude || empty( $values['item_meta'] ) || ! empty( $errors ) ) { | |
| 490 | + if ( ! empty( $exclude ) || empty( $values['item_meta'] ) || ! empty( $errors ) ) { | |
| 551 | 491 | // only check spam if there are no other errors |
| 552 | 492 | return; |
| 553 | 493 | } |
| 554 | 494 | |
| @@ -553,9 +493,8 @@ | ||
| 553 | 493 | } |
| 554 | 494 | |
| 555 | 495 | $antispam_check = self::is_antispam_check( $values['form_id'] ); |
| 556 | 496 | $spam_msg = FrmAntiSpamController::get_default_spam_message(); |
| 557 | - | |
| 558 | 497 | if ( is_string( $antispam_check ) ) { |
| 559 | 498 | $errors['spam'] = $antispam_check; |
| 560 | 499 | } elseif ( self::is_honeypot_spam( $values ) || self::is_spam_bot() ) { |
| 561 | 500 | $errors['spam'] = $spam_msg; |
| @@ -560,9 +499,8 @@ | ||
| 560 | 499 | } elseif ( self::is_honeypot_spam( $values ) || self::is_spam_bot() ) { |
| 561 | 500 | $errors['spam'] = $spam_msg; |
| 562 | 501 | } else { |
| 563 | 502 | $is_spam = FrmAntiSpamController::is_spam( $values ); |
| 564 | - | |
| 565 | 503 | if ( $is_spam ) { |
| 566 | 504 | $errors['spam'] = $is_spam; |
| 567 | 505 | } |
| 568 | 506 | } |
| @@ -581,9 +519,8 @@ | ||
| 581 | 519 | * |
| 582 | 520 | * @since 5.0.13 |
| 583 | 521 | * |
| 584 | 522 | * @param array $values The values. |
| 585 | - * | |
| 586 | 523 | * @return bool |
| 587 | 524 | */ |
| 588 | 525 | private static function form_is_in_progress( $values ) { |
| 589 | 526 | return FrmAppHelper::pro_is_installed() && |
| @@ -602,9 +539,8 @@ | ||
| 602 | 539 | } |
| 603 | 540 | |
| 604 | 541 | /** |
| 605 | 542 | * @param array $values |
| 606 | - * | |
| 607 | 543 | * @return bool |
| 608 | 544 | */ |
| 609 | 545 | private static function is_honeypot_spam( $values ) { |
| 610 | 546 | $honeypot = new FrmHoneypot( $values['form_id'] ); |
| @@ -615,29 +551,30 @@ | ||
| 615 | 551 | * @return bool |
| 616 | 552 | */ |
| 617 | 553 | private static function is_spam_bot() { |
| 618 | 554 | $ip = FrmAppHelper::get_ip_address(); |
| 555 | + | |
| 619 | 556 | return empty( $ip ); |
| 620 | 557 | } |
| 621 | 558 | |
| 622 | 559 | /** |
| 623 | 560 | * @param array $values |
| 624 | - * | |
| 625 | 561 | * @return bool |
| 626 | 562 | */ |
| 627 | 563 | private static function is_akismet_spam( $values ) { |
| 628 | 564 | global $wpcom_api_key; |
| 629 | - return is_callable( 'Akismet::http_post' ) && ( get_option( 'wordpress_api_key' ) || $wpcom_api_key ) && self::akismet( $values ); | |
| 565 | + | |
| 566 | + return ( is_callable( 'Akismet::http_post' ) && ( get_option( 'wordpress_api_key' ) || $wpcom_api_key ) && self::akismet( $values ) ); | |
| 630 | 567 | } |
| 631 | 568 | |
| 632 | 569 | /** |
| 633 | 570 | * @param int $form_id |
| 634 | - * | |
| 635 | 571 | * @return bool |
| 636 | 572 | */ |
| 637 | 573 | private static function is_akismet_enabled_for_user( $form_id ) { |
| 638 | 574 | $form = FrmForm::getOne( $form_id ); |
| 639 | - return ! empty( $form->options['akismet'] ) && ( $form->options['akismet'] !== 'logged' || ! is_user_logged_in() ); | |
| 575 | + | |
| 576 | + return ( ! empty( $form->options['akismet'] ) && ( $form->options['akismet'] !== 'logged' || ! is_user_logged_in() ) ); | |
| 640 | 577 | } |
| 641 | 578 | |
| 642 | 579 | /** |
| 643 | 580 | * Checks spam using WordPress disallowed words and Frm denylist. |
| @@ -652,10 +589,8 @@ | ||
| 652 | 589 | |
| 653 | 590 | /** |
| 654 | 591 | * Check entries for Akismet spam |
| 655 | 592 | * |
| 656 | - * @param array $values Entry values. | |
| 657 | - * | |
| 658 | 593 | * @return bool true if is spam |
| 659 | 594 | */ |
| 660 | 595 | public static function akismet( $values ) { |
| 661 | 596 | if ( empty( $values['item_meta'] ) ) { |
| @@ -678,18 +613,13 @@ | ||
| 678 | 613 | |
| 679 | 614 | $query_string = _http_build_query( $datas, '', '&' ); |
| 680 | 615 | $response = Akismet::http_post( $query_string, 'comment-check' ); |
| 681 | 616 | |
| 682 | - return is_array( $response ) && $response[1] === 'true'; | |
| 617 | + return ( is_array( $response ) && $response[1] === 'true' ); | |
| 683 | 618 | } |
| 684 | 619 | |
| 685 | 620 | /** |
| 686 | 621 | * @since 2.0 |
| 687 | - * | |
| 688 | - * @param array $datas The array of values being sent to Akismet. | |
| 689 | - * @param array $values Entry values. | |
| 690 | - * | |
| 691 | - * @return void | |
| 692 | 622 | */ |
| 693 | 623 | private static function parse_akismet_array( &$datas, $values ) { |
| 694 | 624 | self::add_site_info_to_akismet( $datas ); |
| 695 | 625 | self::add_server_values_to_akismet( $datas ); |
| @@ -700,13 +630,8 @@ | ||
| 700 | 630 | self::add_user_info_to_akismet( $datas, $values ); |
| 701 | 631 | self::add_comment_content_to_akismet( $datas, $values ); |
| 702 | 632 | } |
| 703 | 633 | |
| 704 | - /** | |
| 705 | - * @param array $datas | |
| 706 | - * | |
| 707 | - * @return void | |
| 708 | - */ | |
| 709 | 634 | private static function add_site_info_to_akismet( &$datas ) { |
| 710 | 635 | $datas['blog'] = FrmAppHelper::site_url(); |
| 711 | 636 | $datas['user_ip'] = preg_replace( '/[^0-9., ]/', '', FrmAppHelper::get_ip_address() ); |
| 712 | 637 | $datas['user_agent'] = FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ); |
| @@ -718,14 +643,8 @@ | ||
| 718 | 643 | $datas['is_test'] = 'true'; |
| 719 | 644 | } |
| 720 | 645 | } |
| 721 | 646 | |
| 722 | - /** | |
| 723 | - * @param array $datas | |
| 724 | - * @param array $values | |
| 725 | - * | |
| 726 | - * @return void | |
| 727 | - */ | |
| 728 | 647 | private static function add_user_info_to_akismet( &$datas, $values ) { |
| 729 | 648 | $user_info = self::get_spam_check_user_info( $values ); |
| 730 | 649 | $datas = $datas + $user_info; |
| 731 | 650 | |
| @@ -740,9 +659,8 @@ | ||
| 740 | 659 | * @since 5.0.13 Separate code for guest. Handle value of embedded|repeater. |
| 741 | 660 | * @since 6.21 This changed from private to public. |
| 742 | 661 | * |
| 743 | 662 | * @param array $values Entry values after running through {@see FrmEntryValidate::prepare_values_for_spam_check()}. |
| 744 | - * | |
| 745 | 663 | * @return array |
| 746 | 664 | */ |
| 747 | 665 | public static function get_spam_check_user_info( $values ) { |
| 748 | 666 | if ( ! is_user_logged_in() ) { |
| @@ -765,9 +683,8 @@ | ||
| 765 | 683 | * |
| 766 | 684 | * @since 5.0.13 |
| 767 | 685 | * |
| 768 | 686 | * @param array $values Entry values after flattened. |
| 769 | - * | |
| 770 | 687 | * @return array |
| 771 | 688 | */ |
| 772 | 689 | private static function get_spam_check_user_info_for_guest( $values ) { |
| 773 | 690 | $datas = array( |
| @@ -799,10 +716,8 @@ | ||
| 799 | 716 | * |
| 800 | 717 | * @param array $datas Guest data. |
| 801 | 718 | * @param array $values The values. |
| 802 | 719 | * @param int|null $custom_index Custom index (or field ID). |
| 803 | - * | |
| 804 | - * @return void | |
| 805 | 720 | */ |
| 806 | 721 | private static function recursive_add_akismet_guest_info( &$datas, $values, $custom_index = null ) { |
| 807 | 722 | foreach ( $values as $index => $value ) { |
| 808 | 723 | if ( ! $datas['missing_keys'] ) { |
| @@ -815,12 +730,10 @@ | ||
| 815 | 730 | continue; |
| 816 | 731 | } |
| 817 | 732 | |
| 818 | 733 | $field_id = ! is_null( $custom_index ) ? $custom_index : $index; |
| 819 | - | |
| 820 | 734 | foreach ( $datas['missing_keys'] as $key_index => $key ) { |
| 821 | 735 | $found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'], $values ); |
| 822 | - | |
| 823 | 736 | if ( $found ) { |
| 824 | 737 | $datas[ $key ] = $value; |
| 825 | 738 | $datas['frm_duplicated'][] = $field_id; |
| 826 | 739 | unset( $datas['missing_keys'][ $key_index ] ); |
| @@ -848,12 +761,12 @@ | ||
| 848 | 761 | } |
| 849 | 762 | |
| 850 | 763 | switch ( $key ) { |
| 851 | 764 | case 'comment_author_email': |
| 852 | - return str_contains( $value, '@' ) && is_email( $value ); | |
| 765 | + return strpos( $value, '@' ) && is_email( $value ); | |
| 853 | 766 | |
| 854 | 767 | case 'comment_author_url': |
| 855 | - return str_starts_with( $value, 'http' ); | |
| 768 | + return 0 === strpos( $value, 'http' ); | |
| 856 | 769 | |
| 857 | 770 | case 'comment_author': |
| 858 | 771 | if ( $name_field_ids && in_array( $field_id, $name_field_ids, true ) ) { |
| 859 | 772 | // If there is name field in the form, we should always use it as author name. |
| @@ -858,9 +771,8 @@ | ||
| 858 | 771 | if ( $name_field_ids && in_array( $field_id, $name_field_ids, true ) ) { |
| 859 | 772 | // If there is name field in the form, we should always use it as author name. |
| 860 | 773 | return true; |
| 861 | 774 | } |
| 862 | - | |
| 863 | 775 | $form_id = FrmAppHelper::get_post_param( 'form_id', 0, 'absint' ); |
| 864 | 776 | $fields = self::get_name_text_fields( $form_id ); |
| 865 | 777 | |
| 866 | 778 | foreach ( $fields as $index => $field ) { |
| @@ -866,14 +778,12 @@ | ||
| 866 | 778 | foreach ( $fields as $index => $field ) { |
| 867 | 779 | if ( 'Name' !== $field->name ) { |
| 868 | 780 | continue; |
| 869 | 781 | } |
| 870 | - | |
| 871 | 782 | if ( isset( $fields[ $index + 1 ] ) && 'Last' === $fields[ $index + 1 ]->name ) { |
| 872 | 783 | if ( empty( $values[ absint( $fields[ $index + 1 ]->id ) ] ) ) { |
| 873 | 784 | continue; |
| 874 | 785 | } |
| 875 | - | |
| 876 | 786 | $value .= ' ' . $values[ $fields[ $index + 1 ]->id ]; |
| 877 | 787 | return true; |
| 878 | 788 | } |
| 879 | 789 | } |
| @@ -887,18 +797,15 @@ | ||
| 887 | 797 | * |
| 888 | 798 | * @since 6.17 |
| 889 | 799 | * |
| 890 | 800 | * @param int $form_id |
| 891 | - * | |
| 892 | 801 | * @return array |
| 893 | 802 | */ |
| 894 | 803 | private static function get_name_text_fields( $form_id ) { |
| 895 | 804 | $name_text_fields_is_initialized = is_array( self::$name_text_fields ); |
| 896 | - | |
| 897 | 805 | if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[ $form_id ] ) ) { |
| 898 | 806 | return self::$name_text_fields[ $form_id ]; |
| 899 | 807 | } |
| 900 | - | |
| 901 | 808 | if ( ! $name_text_fields_is_initialized ) { |
| 902 | 809 | self::$name_text_fields = array(); |
| 903 | 810 | } |
| 904 | 811 | self::$name_text_fields[ $form_id ] = FrmDb::get_results( |
| @@ -914,13 +821,8 @@ | ||
| 914 | 821 | |
| 915 | 822 | return self::$name_text_fields[ $form_id ]; |
| 916 | 823 | } |
| 917 | 824 | |
| 918 | - /** | |
| 919 | - * @param array $datas | |
| 920 | - * | |
| 921 | - * @return void | |
| 922 | - */ | |
| 923 | 825 | private static function add_server_values_to_akismet( &$datas ) { |
| 924 | 826 | foreach ( $_SERVER as $key => $value ) { |
| 925 | 827 | $include_value = is_string( $value ) && ! preg_match( '/^HTTP_COOKIE/', $key ) && preg_match( '/^(HTTP_|REMOTE_ADDR|REQUEST_URI|DOCUMENT_URI)/', $key ); |
| 926 | 828 | |
| @@ -938,10 +840,8 @@ | ||
| 938 | 840 | * @since 5.0.09 |
| 939 | 841 | * |
| 940 | 842 | * @param array $datas The array of values being sent to Akismet. |
| 941 | 843 | * @param array $values Entry values. |
| 942 | - * | |
| 943 | - * @return void | |
| 944 | 844 | */ |
| 945 | 845 | private static function add_comment_content_to_akismet( &$datas, $values ) { |
| 946 | 846 | if ( isset( $datas['frm_duplicated'] ) ) { |
| 947 | 847 | foreach ( $datas['frm_duplicated'] as $index ) { |
| @@ -962,14 +862,11 @@ | ||
| 962 | 862 | * |
| 963 | 863 | * @since 5.0.09 |
| 964 | 864 | * |
| 965 | 865 | * @param array $values Entry values. |
| 966 | - * | |
| 967 | - * @return void | |
| 968 | 866 | */ |
| 969 | 867 | private static function skip_adding_values_to_akismet( &$values ) { |
| 970 | 868 | $skipped_fields = self::get_akismet_skipped_field_ids( $values ); |
| 971 | - | |
| 972 | 869 | foreach ( $skipped_fields as $skipped_field ) { |
| 973 | 870 | if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) { |
| 974 | 871 | continue; |
| 975 | 872 | } |
| @@ -975,9 +872,8 @@ | ||
| 975 | 872 | } |
| 976 | 873 | |
| 977 | 874 | if ( self::should_really_skip_field( $skipped_field, $values ) ) { |
| 978 | 875 | unset( $values['item_meta'][ $skipped_field->id ] ); |
| 979 | - | |
| 980 | 876 | if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) { |
| 981 | 877 | unset( $values['item_meta']['other'][ $skipped_field->id ] ); |
| 982 | 878 | } |
| 983 | 879 | } |
| @@ -990,9 +886,8 @@ | ||
| 990 | 886 | * @since 5.02.04 |
| 991 | 887 | * |
| 992 | 888 | * @param object $field_data Object contains `id` and `options`. |
| 993 | 889 | * @param array $values Entry values. |
| 994 | - * | |
| 995 | 890 | * @return bool |
| 996 | 891 | */ |
| 997 | 892 | private static function should_really_skip_field( $field_data, $values ) { |
| 998 | 893 | if ( empty( $field_data->options ) ) { |
| @@ -1000,18 +895,18 @@ | ||
| 1000 | 895 | return true; |
| 1001 | 896 | } |
| 1002 | 897 | |
| 1003 | 898 | FrmAppHelper::unserialize_or_decode( $field_data->options ); |
| 1004 | - | |
| 1005 | 899 | if ( ! $field_data->options ) { |
| 1006 | 900 | // Check if an error happens when unserializing, or empty options. |
| 1007 | 901 | return true; |
| 1008 | 902 | } |
| 1009 | 903 | |
| 1010 | - $last_key = array_key_last( $field_data->options ); | |
| 904 | + end( $field_data->options ); | |
| 905 | + $last_key = key( $field_data->options ); | |
| 1011 | 906 | |
| 1012 | 907 | // If a choice field has no Other option. |
| 1013 | - if ( is_numeric( $last_key ) || ! str_starts_with( $last_key, 'other_' ) ) { | |
| 908 | + if ( is_numeric( $last_key ) || 0 !== strpos( $last_key, 'other_' ) ) { | |
| 1014 | 909 | return true; |
| 1015 | 910 | } |
| 1016 | 911 | |
| 1017 | 912 | // If a choice field has Other option, but Other is not selected. |
| @@ -1020,10 +915,9 @@ | ||
| 1020 | 915 | } |
| 1021 | 916 | |
| 1022 | 917 | // Check if submitted value is same as one of field option. |
| 1023 | 918 | foreach ( $field_data->options as $option ) { |
| 1024 | - $option_value = ! is_array( $option ) ? $option : ( $option['value'] ?? '' ); | |
| 1025 | - | |
| 919 | + $option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' ); | |
| 1026 | 920 | if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) { |
| 1027 | 921 | return true; |
| 1028 | 922 | } |
| 1029 | 923 | } |
| @@ -1038,9 +932,8 @@ | ||
| 1038 | 932 | * @since 5.0.13 Move out get_all_form_ids_and_flatten_meta() call and get `form_ids` from `$values`. |
| 1039 | 933 | * @since 5.2.04 This method returns array of object contains `id` and `options` instead of array of `id` only. |
| 1040 | 934 | * |
| 1041 | 935 | * @param array $values Entry values after running through {@see FrmEntryValidate::prepare_values_for_spam_check()}. |
| 1042 | - * | |
| 1043 | 936 | * @return array |
| 1044 | 937 | */ |
| 1045 | 938 | private static function get_akismet_skipped_field_ids( $values ) { |
| 1046 | 939 | if ( empty( $values['form_ids'] ) ) { |
| @@ -1066,10 +959,8 @@ | ||
| 1066 | 959 | * @since 5.0.13 |
| 1067 | 960 | * @since 6.21 This changed from private to public. |
| 1068 | 961 | * |
| 1069 | 962 | * @param array $values Entry values. |
| 1070 | - * | |
| 1071 | - * @return void | |
| 1072 | 963 | */ |
| 1073 | 964 | public static function prepare_values_for_spam_check( &$values ) { |
| 1074 | 965 | $form_ids = self::get_all_form_ids_and_flatten_meta( $values ); |
| 1075 | 966 | $values['form_ids'] = $form_ids; |
| @@ -1082,17 +973,15 @@ | ||
| 1082 | 973 | * @since 5.0.09 |
| 1083 | 974 | * @since 5.0.13 Convert name field value to string. |
| 1084 | 975 | * |
| 1085 | 976 | * @param array $values Entry values. |
| 1086 | - * | |
| 1087 | 977 | * @return array Form IDs. |
| 1088 | 978 | */ |
| 1089 | - private static function get_all_form_ids_and_flatten_meta( &$values ) { // phpcs:ignore SlevomatCodingStandard.Complexity.Cognitive.ComplexityTooHigh | |
| 979 | + private static function get_all_form_ids_and_flatten_meta( &$values ) { | |
| 1090 | 980 | $values['name_field_ids'] = array(); |
| 1091 | 981 | |
| 1092 | 982 | // Blacklist check for File field in the old version doesn't contain `form_id`. |
| 1093 | 983 | $form_ids = isset( $values['form_id'] ) ? array( absint( $values['form_id'] ) ) : array(); |
| 1094 | - | |
| 1095 | 984 | foreach ( $values['item_meta'] as $field_id => $value ) { |
| 1096 | 985 | if ( ! is_numeric( $field_id ) ) { |
| 1097 | 986 | // Maybe `other`. |
| 1098 | 987 | continue; |
| @@ -1126,9 +1015,10 @@ | ||
| 1126 | 1015 | } |
| 1127 | 1016 | |
| 1128 | 1017 | // Convert name array to string. |
| 1129 | 1018 | if ( isset( $subsubvalue['first'] ) && isset( $subsubvalue['last'] ) ) { |
| 1130 | - $subsubvalue = trim( implode( ' ', $subsubvalue ) ); | |
| 1019 | + $subsubvalue = trim( implode( ' ', $subsubvalue ) ); | |
| 1020 | + | |
| 1131 | 1021 | $values['name_field_ids'][] = $subsubindex; |
| 1132 | 1022 | } |
| 1133 | 1023 | |
| 1134 | 1024 | if ( is_array( $values['item_meta'][ $subsubindex ] ) ) { |
