PluginProbe
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More / 6.24
Formidable Forms – WordPress Form Builder for Contact Forms, Calculators, Quizzes & More v6.24
6.35 6.34 6.33.1 6.33 6.32.1 6.32 6.31 6.25 6.25.1 6.26 6.26.1 6.27 6.28 6.29 6.3 6.3.1 6.3.2 6.30 6.4 6.4.1 6.4.2 6.5 6.5.1 6.5.2 6.5.3 All 141 releases
← All changes | classes/controllers/FrmAppController.php +170 -320 6.306.24 View file →
@@ -9,9 +9,8 @@
9 9 * @return void
10 10 */
11 11 public static function menu() {
12 12 FrmAppHelper::maybe_add_permissions();
13 -
14 13 if ( ! current_user_can( 'frm_view_forms' ) ) {
15 14 return;
16 15 }
17 16
@@ -32,10 +31,8 @@
32 31 }
33 32
34 33 /**
35 34 * @since 3.05
36 - *
37 - * @return string
38 35 */
39 36 private static function menu_icon() {
40 37 $icon = FrmAppHelper::svg_logo(
41 38 array(
@@ -49,12 +46,8 @@
49 46 }
50 47
51 48 /**
52 49 * @since 3.0
53 - *
54 - * @param string $classes
55 - *
56 - * @return string
57 50 */
58 51 public static function add_admin_class( $classes ) {
59 52 if ( self::is_white_page() ) {
60 53 $classes .= ' frm-white-body ';
@@ -60,20 +53,17 @@
60 53 $classes .= ' frm-white-body ';
61 54 $classes .= self::get_os();
62 55
63 56 $page = str_replace( 'formidable-', '', FrmAppHelper::simple_get( 'page', 'sanitize_title' ) );
64 -
65 - if ( ! $page || $page === 'formidable' ) {
57 + if ( empty( $page ) || $page === 'formidable' ) {
66 58 $action = FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
67 -
68 - if ( in_array( $action, array( 'settings', 'edit', 'list' ), true ) ) {
59 + if ( in_array( $action, array( 'settings', 'edit', 'list' ) ) ) {
69 60 $page .= $action;
70 61 } else {
71 62 $page = $action;
72 63 }
73 64 }
74 -
75 - if ( $page ) {
65 + if ( ! empty( $page ) ) {
76 66 $classes .= ' frm-admin-page-' . $page;
77 67 }
78 68 }
79 69
@@ -81,17 +71,16 @@
81 71 $classes .= ' frm-grey-body ';
82 72 }
83 73
84 74 if ( FrmAppHelper::is_full_screen() ) {
85 - $add_class = '';
86 -
87 - if ( self::get_full_screen_setting() ) {
75 + $full_screen_on = self::get_full_screen_setting();
76 + $add_class = '';
77 + if ( $full_screen_on ) {
88 78 $add_class = ' frm-full-screen is-fullscreen-mode';
89 79
90 80 // Load the CSS for .is-fullscreen-mode.
91 81 wp_enqueue_style( 'wp-edit-post' );
92 82 }
93 -
94 83 $classes .= apply_filters( 'frm_admin_full_screen_class', $add_class );
95 84 }
96 85
97 86 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -114,10 +103,10 @@
114 103 */
115 104 private static function get_full_screen_setting() {
116 105 global $wpdb;
117 106 $meta_key = $wpdb->get_blog_prefix() . 'persisted_preferences';
118 - $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
119 107
108 + $prefs = get_user_meta( get_current_user_id(), $meta_key, true );
120 109 if ( $prefs && isset( $prefs['core/edit-post']['fullscreenMode'] ) ) {
121 110 return $prefs['core/edit-post']['fullscreenMode'];
122 111 }
123 112
@@ -131,24 +120,20 @@
131 120 */
132 121 private static function get_os() {
133 122 $agent = strtolower( FrmAppHelper::get_server_value( 'HTTP_USER_AGENT' ) );
134 123 $os = '';
135 -
136 - if ( str_contains( $agent, 'mac' ) ) {
124 + if ( strpos( $agent, 'mac' ) !== false ) {
137 125 $os = ' osx';
138 - } elseif ( str_contains( $agent, 'linux' ) ) {
126 + } elseif ( strpos( $agent, 'linux' ) !== false ) {
139 127 $os = ' linux';
140 - } elseif ( str_contains( $agent, 'windows' ) ) {
128 + } elseif ( strpos( $agent, 'windows' ) !== false ) {
141 129 $os = ' windows';
142 130 }
143 -
144 131 return $os;
145 132 }
146 133
147 134 /**
148 135 * @since 3.0
149 - *
150 - * @return bool
151 136 */
152 137 private static function is_white_page() {
153 138 $white_pages = array(
154 139 'formidable',
@@ -164,10 +149,17 @@
164 149 FrmFormTemplatesController::PAGE_SLUG,
165 150 FrmOnboardingWizardController::PAGE_SLUG,
166 151 );
167 152
168 - if ( self::is_white_payments_page() ) {
169 - $white_pages[] = 'formidable-payments';
153 + if ( ! class_exists( 'FrmTransHooksController', false ) && ! FrmTransLiteAppHelper::should_fallback_to_paypal() ) {
154 + // Only consider the payments page as a "white page" when the Payments submodule is off.
155 + // Otherwise this causes a lot of styling issues when the Stripe add-on (or Authorize.Net) is active.
156 +
157 + // Add an extra check to avoid white page styling on the PayPal "edit" action.
158 + // We fallback to the PayPal add on for the "edit" action since Stripe Lite does not have an edit view.
159 + if ( ! in_array( FrmAppHelper::simple_get( 'action' ), array( 'edit', 'new' ), true ) || ! is_callable( 'FrmPaymentsController::route' ) ) {
160 + $white_pages[] = 'formidable-payments';
161 + }
170 162 }
171 163
172 164 $is_white_page = self::is_page_in_list( $white_pages ) || self::is_grey_page() || FrmAppHelper::is_view_builder_page();
173 165
@@ -177,25 +169,11 @@
177 169 * @since 5.3
178 170 *
179 171 * @param bool $is_white_page
180 172 */
181 - return apply_filters( 'frm_is_white_page', $is_white_page );
182 - }
173 + $is_white_page = apply_filters( 'frm_is_white_page', $is_white_page );
183 174
184 - /**
185 - * Check if the payments page should be styled as a white page.
186 - * Fallback to the Stripe, Authorize.Net, or PayPal add on for the "edit" action since
187 - * Stripe Lite does not have an edit view. Also fallback for bulk deleting, since that
188 - * isn't built into Lite. The pages we fall back to should not be styled as white pages.
189 - *
190 - * @since 6.27
191 - *
192 - * @return bool
193 - */
194 - private static function is_white_payments_page() {
195 - $action = FrmAppHelper::simple_get( 'action', 'sanitize_title' );
196 - $on_edit_page = in_array( $action, array( 'edit', 'new' ), true );
197 - return ! $on_edit_page && 'bulk_delete' !== $action;
175 + return $is_white_page;
198 176 }
199 177
200 178 /**
201 179 * Add a grey bg instead of white.
@@ -218,9 +196,8 @@
218 196 *
219 197 * @since 6.8
220 198 *
221 199 * @param bool $is_grey_page
222 - *
223 200 * @return bool
224 201 */
225 202 return apply_filters( 'frm_is_grey_page', $is_grey_page );
226 203 }
@@ -228,9 +205,8 @@
228 205 /**
229 206 * @since 6.8
230 207 *
231 208 * @param array $pages A list of page names to check.
232 - *
233 209 * @return bool
234 210 */
235 211 private static function is_page_in_list( $pages ) {
236 212 $get_page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
@@ -254,15 +230,13 @@
254 230 * @return void
255 231 */
256 232 public static function get_form_nav( $form, $show_nav = false, $title = 'show' ) {
257 233 $show_nav = FrmAppHelper::get_param( 'show_nav', $show_nav, 'get', 'absint' );
258 -
259 - if ( ! $show_nav || ! $form ) {
234 + if ( empty( $show_nav ) || ! $form ) {
260 235 return;
261 236 }
262 237
263 238 FrmForm::maybe_get_form( $form );
264 -
265 239 if ( ! is_object( $form ) ) {
266 240 return;
267 241 }
268 242
@@ -276,21 +250,21 @@
276 250 /**
277 251 * @return string
278 252 */
279 253 private static function get_current_page() {
254 + $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
255 + $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
256 + $current_page = isset( $_GET['page'] ) ? $page : $post_type;
257 +
280 258 if ( FrmAppHelper::is_view_builder_page() ) {
281 - return 'frm_display';
259 + $current_page = 'frm_display';
282 260 }
283 261
284 - $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
285 - $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title', 'None' );
286 -
287 - return isset( $_GET['page'] ) ? $page : $post_type;
262 + return $current_page;
288 263 }
289 264
290 265 /**
291 266 * @param object $form
292 - *
293 267 * @return array
294 268 */
295 269 private static function get_form_nav_items( $form ) {
296 270 $id = $form->parent_form_id ? $form->parent_form_id : $form->id;
@@ -366,9 +340,8 @@
366 340 /**
367 341 * Adds a settings link to the plugins page
368 342 *
369 343 * @param array $links
370 - *
371 344 * @return array
372 345 */
373 346 public static function settings_link( $links ) {
374 347 $settings = array();
@@ -377,9 +350,8 @@
377 350 if ( FrmAddonsController::is_license_expired() ) {
378 351 $label = __( 'Renew', 'formidable' );
379 352 } else {
380 353 $label = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_text' );
381 -
382 354 if ( ! $label ) {
383 355 $label = __( 'Upgrade to Pro', 'formidable' );
384 356 }
385 357 }
@@ -384,9 +356,8 @@
384 356 }
385 357 }
386 358
387 359 $upgrade_link = FrmSalesApi::get_best_sale_value( 'plugin_page_cta_link' );
388 -
389 360 if ( $upgrade_link ) {
390 361 $upgrade_link = FrmAppHelper::maybe_add_missing_utm( $upgrade_link, array( 'medium' => 'plugin-row' ) );
391 362 } else {
392 363 $upgrade_link = FrmAppHelper::admin_upgrade_link( 'plugin-row' );
@@ -392,11 +363,11 @@
392 363 $upgrade_link = FrmAppHelper::admin_upgrade_link( 'plugin-row' );
393 364 }
394 365
395 366 $settings[] = '<a href="' . esc_url( $upgrade_link ) . '" target="_blank" rel="noopener"><b style="color:#1da867;font-weight:700;">' . esc_html( $label ) . '</b></a>';
396 - }//end if
367 + }
397 368
398 - $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . esc_html__( 'Build a Form', 'formidable' ) . '</a>';
369 + $settings[] = '<a href="' . esc_url( admin_url( 'admin.php?page=formidable' ) ) . '">' . __( 'Build a Form', 'formidable' ) . '</a>';
399 370
400 371 return array_merge( $settings, $links );
401 372 }
402 373
@@ -404,9 +375,9 @@
404 375 * @return void
405 376 */
406 377 public static function pro_get_started_headline() {
407 378 self::review_request();
408 - FrmAppHelper::min_pro_version_notice( '6.20' );
379 + FrmAppHelper::min_pro_version_notice( '6.0' );
409 380 }
410 381
411 382 /**
412 383 * Add admin notices as needed for reviews
@@ -481,9 +452,8 @@
481 452 *
482 453 * @param string $form_key
483 454 * @param string $title
484 455 * @param string $description
485 - *
486 456 * @return void
487 457 */
488 458 public static function api_email_form( $form_key, $title = '', $description = '' ) {
489 459 $user = wp_get_current_user();
@@ -530,14 +500,12 @@
530 500 * @return void
531 501 */
532 502 public static function install_js_fallback() {
533 503 FrmAppHelper::load_admin_wide_js();
534 - // phpcs:disable Generic.WhiteSpace.ScopeIndent
535 504 ?>
536 505 <div id="frm_install_message"></div>
537 506 <script>jQuery(document).ready( frm_install_now );</script>
538 507 <?php
539 - // phpcs:enable Generic.WhiteSpace.ScopeIndent
540 508 }
541 509
542 510 /**
543 511 * Check if the database is outdated
@@ -542,9 +510,8 @@
542 510 /**
543 511 * Check if the database is outdated
544 512 *
545 513 * @since 2.0.1
546 - *
547 514 * @return bool
548 515 */
549 516 public static function needs_update() {
550 517 $needs_upgrade = self::compare_for_update(
@@ -555,9 +522,9 @@
555 522 )
556 523 );
557 524
558 525 if ( ! $needs_upgrade ) {
559 - return apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
526 + $needs_upgrade = apply_filters( 'frm_db_needs_upgrade', $needs_upgrade );
560 527 }
561 528
562 529 return $needs_upgrade;
563 530 }
@@ -567,27 +534,23 @@
567 534 *
568 535 * @since 3.0.04
569 536 *
570 537 * @param array $atts
571 - *
572 538 * @return bool
573 539 */
574 540 public static function compare_for_update( $atts ) {
575 541 $db_version = get_option( $atts['option'] );
576 542
577 - if ( ! str_contains( $db_version, '-' ) ) {
578 - return true;
543 + if ( strpos( $db_version, '-' ) === false ) {
544 + $needs_upgrade = true;
545 + } else {
546 + $last_upgrade = explode( '-', $db_version );
547 + $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
548 + $new_version = version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
549 + $needs_upgrade = $needs_db_upgrade || $new_version;
579 550 }
580 551
581 - $last_upgrade = explode( '-', $db_version );
582 - $needs_db_upgrade = (int) $last_upgrade[1] < (int) $atts['new_db_version'];
583 -
584 - if ( $needs_db_upgrade ) {
585 - return true;
586 - }
587 -
588 - // New plugin version.
589 - return version_compare( $last_upgrade[0], $atts['new_plugin_version'], '<' );
552 + return $needs_upgrade;
590 553 }
591 554
592 555 /**
593 556 * Check for database update and trigger js loading
@@ -616,13 +579,17 @@
616 579
617 580 if ( 'formidable-pro-upgrade' === FrmAppHelper::get_param( 'page' ) && ! FrmAppHelper::pro_is_installed() && current_user_can( 'frm_view_forms' ) ) {
618 581 $redirect = FrmSalesApi::get_best_sale_value( 'menu_cta_link' );
619 582 $utm = array(
620 - 'campaign' => 'upgrade',
621 - 'content' => 'submenu-upgrade',
583 + 'medium' => 'upgrade',
584 + 'content' => 'submenu-upgrade',
622 585 );
623 586
624 - $redirect = $redirect ? FrmAppHelper::maybe_add_missing_utm( $redirect, $utm ) : FrmAppHelper::admin_upgrade_link( $utm );
587 + if ( $redirect ) {
588 + $redirect = FrmAppHelper::maybe_add_missing_utm( $redirect, $utm );
589 + } else {
590 + $redirect = FrmAppHelper::admin_upgrade_link( $utm );
591 + }
625 592
626 593 wp_redirect( $redirect );
627 594 die();
628 595 }
@@ -634,32 +601,29 @@
634 601 self::network_upgrade_site();
635 602 }
636 603
637 604 if ( ! FrmAppHelper::doing_ajax() ) {
638 - // Don't continue during ajax calls
605 + // don't continue during ajax calls
639 606 self::admin_js();
640 607 }
641 608
642 609 self::trigger_page_load_hooks();
643 610
644 - if ( ! FrmAppHelper::is_admin_page( 'formidable' ) ) {
645 - return;
646 - }
611 + if ( FrmAppHelper::is_admin_page( 'formidable' ) ) {
612 + // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
613 + // This provides backward compatibility for old addons that use legacy modal templates.
614 + $action = FrmAppHelper::get_param( 'frm_action' );
615 + $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
616 + if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
617 + $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
618 + $url_param = $application_id ? '&applicationId=' . $application_id : '';
647 619
648 - // Redirect to the "Form Templates" page if the 'frm_action' parameter matches specific actions.
649 - // This provides backward compatibility for old addons that use legacy modal templates.
650 - $action = FrmAppHelper::get_param( 'frm_action' );
651 - $trigger_name_modal = FrmAppHelper::get_param( 'triggerNewFormModal' );
620 + wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
621 + exit;
622 + }
652 623
653 - if ( $trigger_name_modal || in_array( $action, array( 'add_new', 'list_templates' ), true ) ) {
654 - $application_id = FrmAppHelper::simple_get( 'applicationId', 'absint' );
655 - $url_param = $application_id ? '&applicationId=' . $application_id : '';
656 -
657 - wp_safe_redirect( admin_url( 'admin.php?page=' . FrmFormTemplatesController::PAGE_SLUG . $url_param ) );
658 - exit;
624 + FrmInbox::maybe_disable_screen_options();
659 625 }
660 -
661 - FrmInbox::maybe_disable_screen_options();
662 626 }
663 627
664 628 /**
665 629 * Get the current page and check for a possible function to trigger.
@@ -670,10 +634,9 @@
670 634 * @return void
671 635 */
672 636 private static function trigger_page_load_hooks() {
673 637 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
674 -
675 - if ( ! str_starts_with( $page, 'formidable-' ) ) {
638 + if ( strpos( $page, 'formidable-' ) !== 0 ) {
676 639 // Only trigger hooks on Formidable pages.
677 640 return;
678 641 }
679 642
@@ -679,9 +642,8 @@
679 642
680 643 $page = str_replace( array( 'formidable-', '-' ), array( '', ' ' ), $page );
681 644 $page = str_replace( ' ', '', ucwords( $page ) );
682 645 $class = 'Frm' . $page . 'Controller';
683 -
684 646 if ( class_exists( $class ) && method_exists( $class, 'load_page' ) ) {
685 647 call_user_func( array( $class, 'load_page' ) );
686 648 }
687 649 }
@@ -689,14 +651,13 @@
689 651 /**
690 652 * @return void
691 653 */
692 654 public static function admin_js() {
693 - $plugin_url = FrmAppHelper::plugin_url();
694 - $version = FrmAppHelper::plugin_version();
695 - $is_pro_min_v6_28 = FrmAppHelper::pro_is_installed() && FrmAppHelper::meets_min_pro_version( '6.28' );
696 - $frm_components_dependencies = $is_pro_min_v6_28 ? array( 'formidable_admin', 'formidable-pro-web-components' ) : array( 'formidable_admin' );
655 + $plugin_url = FrmAppHelper::plugin_url();
656 + $version = FrmAppHelper::plugin_version();
697 657
698 658 FrmAppHelper::load_admin_wide_js();
659 +
699 660 // Register component assets early to ensure they can be enqueued later in controllers.
700 661 wp_register_style( 'formidable-animations', $plugin_url . '/css/admin/animations.css', array(), $version );
701 662
702 663 if ( class_exists( 'FrmOverlayController' ) ) {
@@ -712,10 +673,10 @@
712 673 wp_register_style( 'formidable-grids', $plugin_url . '/css/frm_grids.css', array(), $version );
713 674
714 675 wp_register_script( 'formidable_dom', $plugin_url . '/js/admin/dom.js', array( 'jquery', 'jquery-ui-dialog', 'wp-i18n' ), $version, true );
715 676 wp_register_script( 'formidable_embed', $plugin_url . '/js/admin/embed.js', array( 'formidable_dom', 'jquery-ui-autocomplete' ), $version, true );
716 - self::register_popper2();
717 - wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '5.0.2', true );
677 + self::register_popper1();
678 + wp_register_script( 'bootstrap_tooltip', $plugin_url . '/js/bootstrap.min.js', array( 'jquery', 'popper' ), '4.6.1', true );
718 679
719 680 $settings_js_vars = array(
720 681 'currencies' => FrmCurrencyHelper::get_currencies(),
721 682 );
@@ -720,25 +681,51 @@
720 681 'currencies' => FrmCurrencyHelper::get_currencies(),
721 682 );
722 683 wp_register_script( 'formidable_settings', $plugin_url . '/js/admin/settings.js', array(), $version, true );
723 684 wp_localize_script( 'formidable_settings', 'frmSettings', $settings_js_vars );
724 - wp_register_script( 'formidable-web-components', $plugin_url . '/js/formidable-web-components.js', $frm_components_dependencies, $version, true );
725 685
726 686 if ( self::should_show_floating_links() ) {
727 687 self::enqueue_floating_links( $plugin_url, $version );
728 688 }
729 689
730 - wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', self::get_admin_js_dependencies(), $version, true );
690 + $dependencies = array(
691 + 'formidable_admin_global',
692 + 'jquery',
693 + 'jquery-ui-core',
694 + 'jquery-ui-draggable',
695 + 'jquery-ui-sortable',
696 + 'bootstrap_tooltip',
697 + 'bootstrap-multiselect',
698 + 'wp-i18n',
699 + // Required in WP versions older than 5.7
700 + 'wp-hooks',
701 + 'formidable_dom',
702 + 'formidable_embed',
703 + );
731 704
705 + if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
706 + // We only need to load the color picker when editing styles.
707 + $dependencies[] = 'wp-color-picker';
708 + }
709 +
710 + wp_register_script( 'formidable_admin', $plugin_url . '/js/formidable_admin.js', $dependencies, $version, true );
711 +
732 712 if ( FrmAppHelper::on_form_listing_page() ) {
733 713 // For the existing page dropdown in the Form embed modal.
734 714 wp_enqueue_script( 'jquery-ui-autocomplete' );
735 715 }
736 716
737 - wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '2.0', true );
717 + wp_register_script( 'bootstrap-multiselect', $plugin_url . '/js/bootstrap-multiselect.js', array( 'jquery', 'bootstrap_tooltip', 'popper' ), '1.1.1', true );
738 718
739 719 if ( ! class_exists( 'FrmTransHooksController', false ) ) {
740 - FrmTransLiteAppController::hide_gateway_fields_in_builder();
720 + /**
721 + * Gateway fields are included for add-on compatibility but we do not want it to be visible.
722 + * They do however need to be visible when the payments submodule is active.
723 + */
724 + wp_add_inline_style(
725 + 'formidable-admin',
726 + '#frm_builder_page li[data-ftype="gateway"] { display: none; }'
727 + );
741 728 }
742 729
743 730 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
744 731 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
@@ -743,15 +730,12 @@
743 730 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
744 731 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
745 732
746 733 global $pagenow;
747 -
748 - if ( str_starts_with( $page, 'formidable' ) || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
749 - self::enqueue_global_settings_scripts( $page );
750 -
734 + if ( strpos( $page, 'formidable' ) === 0 || ( $pagenow === 'edit.php' && $post_type === 'frm_display' ) ) {
751 735 wp_enqueue_script( 'admin-widgets' );
752 736 wp_enqueue_style( 'widgets' );
753 - self::maybe_deregister_popper1();
737 + self::maybe_deregister_popper2();
754 738 wp_enqueue_script( 'formidable_admin' );
755 739 wp_set_script_translations( 'formidable_admin', 'formidable' );
756 740 wp_enqueue_script( 'formidable_embed' );
757 741 wp_set_script_translations( 'formidable_embed', 'formidable' );
@@ -758,9 +742,8 @@
758 742 FrmAppHelper::localize_script( 'admin' );
759 743
760 744 wp_enqueue_style( 'formidable-animations' );
761 745 wp_enqueue_style( 'formidable-admin' );
762 -
763 746 if ( 'formidable-styles' !== $page && 'formidable-styles2' !== $page ) {
764 747 wp_enqueue_style( 'formidable-grids' );
765 748 self::maybe_enqueue_dropzone_css( $page );
766 749 } else {
@@ -783,13 +766,11 @@
783 766 if ( isset( $_REQUEST['post_type'] ) ) {
784 767 $post_type = sanitize_title( wp_unslash( $_REQUEST['post_type'] ) );
785 768 } elseif ( isset( $_REQUEST['post'] ) && absint( $_REQUEST['post'] ) ) {
786 769 $post = get_post( absint( wp_unslash( $_REQUEST['post'] ) ) );
787 -
788 770 if ( ! $post ) {
789 771 return;
790 772 }
791 -
792 773 $post_type = $post->post_type;
793 774 } else {
794 775 return;
795 776 }
@@ -807,37 +788,8 @@
807 788 self::enqueue_builder_assets( $plugin_url, $version );
808 789 }
809 790
810 791 /**
811 - * @since 6.27
812 - *
813 - * @return array
814 - */
815 - private static function get_admin_js_dependencies() {
816 - $dependencies = array(
817 - 'formidable_admin_global',
818 - 'jquery',
819 - 'jquery-ui-core',
820 - 'jquery-ui-draggable',
821 - 'jquery-ui-sortable',
822 - 'bootstrap_tooltip',
823 - 'bootstrap-multiselect',
824 - 'wp-i18n',
825 - // Required in WP versions older than 5.7
826 - 'wp-hooks',
827 - 'formidable_dom',
828 - 'formidable_embed',
829 - );
830 -
831 - if ( FrmAppHelper::is_style_editor_page( 'edit' ) ) {
832 - // We only need to load the color picker when editing styles.
833 - $dependencies[] = 'wp-color-picker';
834 - }
835 -
836 - return $dependencies;
837 - }
838 -
839 - /**
840 792 * Enqueue the Form Builder assets.
841 793 *
842 794 * @since 6.24
843 795 *
@@ -842,9 +794,8 @@
842 794 * @since 6.24
843 795 *
844 796 * @param string $plugin_url The plugin URL.
845 797 * @param string $version The plugin version.
846 - *
847 798 * @return void
848 799 */
849 800 private static function enqueue_builder_assets( $plugin_url, $version ) {
850 801 wp_register_style( 'formidable-settings-components', $plugin_url . '/css/admin/frm-settings-components.css', array( 'formidable-admin', 'formidable-grids' ), $version );
@@ -858,30 +809,13 @@
858 809 wp_enqueue_script( 'formidable-settings-components' );
859 810 }
860 811
861 812 /**
862 - * Enqueues global settings scripts.
863 - *
864 - * @param string $page The `page` param in URL.
865 - *
866 - * @return void
867 - */
868 - private static function enqueue_global_settings_scripts( $page ) {
869 - if ( 'formidable-settings' !== $page ) {
870 - return;
871 - }
872 -
873 - wp_enqueue_style( 'wp-color-picker' );
874 - wp_enqueue_script( 'formidable_settings' );
875 - }
876 -
877 - /**
878 813 * Avoid loading dropzone CSS on the form list page. It isn't required there.
879 814 *
880 815 * @since 6.11
881 816 *
882 817 * @param string $page
883 - *
884 818 * @return void
885 819 */
886 820 private static function maybe_enqueue_dropzone_css( $page ) {
887 821 if ( ! FrmAppHelper::pro_is_installed() ) {
@@ -888,9 +822,8 @@
888 822 return;
889 823 }
890 824
891 825 $should_avoid_loading_dropzone = 'formidable' === $page && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
892 -
893 826 if ( ! $should_avoid_loading_dropzone ) {
894 827 wp_enqueue_style( 'formidable-dropzone' );
895 828 }
896 829 }
@@ -907,18 +840,12 @@
907 840 if ( ! FrmAppHelper::is_formidable_branding() ) {
908 841 return false;
909 842 }
910 843
911 - $should_show = FrmAppHelper::is_formidable_admin() && ! FrmAppHelper::is_style_editor_page() && ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) && ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
912 -
913 - /**
914 - * Filters whether the floating links should be displayed.
915 - *
916 - * @since 6.25.1
917 - *
918 - * @param bool $should_show Whether the floating links should be shown.
919 - */
920 - return apply_filters( 'frm_should_show_floating_links', $should_show );
844 + return FrmAppHelper::is_formidable_admin() &&
845 + ! FrmAppHelper::is_style_editor_page() &&
846 + ! FrmAppHelper::is_admin_page( 'formidable-views-editor' ) &&
847 + ! FrmAppHelper::simple_get( 'frm_action', 'sanitize_title' );
921 848 }
922 849
923 850 /**
924 851 * @since 6.3.2
@@ -945,9 +872,9 @@
945 872 */
946 873 private static function enqueue_legacy_views_assets() {
947 874 wp_enqueue_style( 'formidable-grids' );
948 875 wp_enqueue_script( 'jquery-ui-draggable' );
949 - self::maybe_deregister_popper1();
876 + self::maybe_deregister_popper2();
950 877 wp_enqueue_script( 'formidable_admin' );
951 878 wp_add_inline_style(
952 879 'formidable-admin',
953 880 '
@@ -970,21 +897,21 @@
970 897 }
971 898 '
972 899 );
973 900 wp_enqueue_style( 'formidable-admin' );
974 - wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
901 + wp_enqueue_script( 'formidable_legacy_views', FrmAppHelper::plugin_url() . '/js/admin/legacy-views.js', array( 'jquery', 'formidable_admin' ), FrmAppHelper::plugin_version() );
975 902 FrmAppHelper::localize_script( 'admin' );
976 903 self::include_info_overlay();
977 904 }
978 905
979 906 /**
980 - * Unregister Popper if the registered version is outdated.
907 + * Fix a Duplicator Pro conflict because it uses Popper 2. See issue #3459.
981 908 *
982 - * @since 6.26
909 + * @since 5.2.02.01
983 910 *
984 911 * @return void
985 912 */
986 - private static function maybe_deregister_popper1() {
913 + private static function maybe_deregister_popper2() {
987 914 global $wp_scripts;
988 915
989 916 if ( ! array_key_exists( 'popper', $wp_scripts->registered ) ) {
990 917 return;
@@ -990,29 +917,26 @@
990 917 return;
991 918 }
992 919
993 920 $popper = $wp_scripts->registered['popper'];
994 -
995 - if ( ! version_compare( $popper->ver, '2.0', '<' ) ) {
996 - return;
921 + if ( version_compare( $popper->ver, '2.0', '>=' ) ) {
922 + wp_deregister_script( 'popper' );
923 + self::register_popper1();
997 924 }
998 -
999 - wp_deregister_script( 'popper' );
1000 - self::register_popper2();
1001 925 }
1002 926
1003 927 /**
1004 - * Register Popper required for Bootstrap 5.
928 + * Register Popper required for Bootstrap 4.
1005 929 *
1006 - * @since 6.26
930 + * @since 5.2.02.01
1007 931 *
1008 932 * @return void
1009 933 */
1010 - private static function register_popper2() {
934 + private static function register_popper1() {
1011 935 if ( ! self::should_register_popper() ) {
1012 936 return;
1013 937 }
1014 - wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array(), '2.11.8', true );
938 + wp_register_script( 'popper', FrmAppHelper::plugin_url() . '/js/popper.min.js', array( 'jquery' ), '1.16.0', true );
1015 939 }
1016 940
1017 941 /**
1018 942 * Only register popper on Formidable pages.
@@ -1025,9 +949,8 @@
1025 949 private static function should_register_popper() {
1026 950 global $pagenow;
1027 951
1028 952 $post_id = FrmAppHelper::simple_get( 'post', 'absint' );
1029 -
1030 953 if ( 'post.php' === $pagenow && $post_id && 'frm_display' === get_post_type( $post_id ) ) {
1031 954 return true;
1032 955 }
1033 956
@@ -1032,16 +955,14 @@
1032 955 }
1033 956
1034 957 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1035 958 $is_views_post_type = 'frm_display' === $post_type;
1036 -
1037 959 if ( in_array( $pagenow, array( 'post-new.php', 'edit.php' ), true ) && $is_views_post_type ) {
1038 960 return true;
1039 961 }
1040 962
1041 963 $page = FrmAppHelper::simple_get( 'page', 'sanitize_title' );
1042 -
1043 - if ( str_starts_with( $page, 'formidable' ) ) {
964 + if ( strpos( $page, 'formidable' ) === 0 ) {
1044 965 return true;
1045 966 }
1046 967
1047 968 return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && FrmAppHelper::simple_get( 'taxonomy' ) === 'frm_application';
@@ -1055,15 +976,13 @@
1055 976 * @return void
1056 977 */
1057 978 private static function maybe_force_formidable_block_on_gutenberg_page() {
1058 979 global $pagenow;
1059 -
1060 980 if ( 'post.php' !== $pagenow ) {
1061 981 return;
1062 982 }
1063 983
1064 984 $form_id = FrmAppHelper::simple_get( 'frmForm', 'absint' );
1065 -
1066 985 if ( ! $form_id ) {
1067 986 return;
1068 987 }
1069 988
@@ -1111,9 +1030,9 @@
1111 1030 public static function create_rest_routes() {
1112 1031 $args = array(
1113 1032 'methods' => 'GET',
1114 1033 'callback' => 'FrmAppController::api_install',
1115 - 'permission_callback' => self::class . '::can_update_db',
1034 + 'permission_callback' => __CLASS__ . '::can_update_db',
1116 1035 );
1117 1036
1118 1037 register_rest_route( 'frm-admin/v1', '/install', $args );
1119 1038
@@ -1130,10 +1049,8 @@
1130 1049 * Make sure the install is only being run when we tell it to.
1131 1050 * We don't want to run manually by people calling the API.
1132 1051 *
1133 1052 * @since 4.06.02
1134 - *
1135 - * @return bool
1136 1053 */
1137 1054 public static function can_update_db() {
1138 1055 return get_transient( 'frm_updating_api' );
1139 1056 }
@@ -1163,9 +1080,9 @@
1163 1080 $response = rest_do_request( $request );
1164 1081 }
1165 1082
1166 1083 if ( $response->is_error() ) {
1167 - // If the remove post fails, use javascript instead
1084 + // if the remove post fails, use javascript instead
1168 1085 add_action( 'admin_notices', 'FrmAppController::install_js_fallback' );
1169 1086 }
1170 1087 }
1171 1088
@@ -1175,17 +1092,14 @@
1175 1092 *
1176 1093 * @return void
1177 1094 */
1178 1095 private static function maybe_add_wp_site_health() {
1179 - if ( class_exists( 'WP_Site_Health' ) ) {
1180 - return;
1096 + if ( ! class_exists( 'WP_Site_Health' ) ) {
1097 + $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1098 + if ( file_exists( $wp_site_health_path ) ) {
1099 + require_once $wp_site_health_path;
1100 + }
1181 1101 }
1182 -
1183 - $wp_site_health_path = ABSPATH . 'wp-admin/includes/class-wp-site-health.php';
1184 -
1185 - if ( file_exists( $wp_site_health_path ) ) {
1186 - require_once $wp_site_health_path;
1187 - }
1188 1102 }
1189 1103
1190 1104 /**
1191 1105 * @since 3.0
@@ -1193,14 +1107,12 @@
1193 1107 * @return true
1194 1108 */
1195 1109 public static function api_install() {
1196 1110 delete_transient( 'frm_updating_api' );
1197 -
1198 1111 if ( self::needs_update() ) {
1199 1112 $running = get_option( 'frm_install_running' );
1200 -
1201 1113 if ( false === $running || $running < strtotime( '-5 minutes' ) ) {
1202 - update_option( 'frm_install_running', time(), false );
1114 + update_option( 'frm_install_running', time(), 'no' );
1203 1115 self::install();
1204 1116 delete_option( 'frm_install_running' );
1205 1117 }
1206 1118 }
@@ -1248,13 +1160,8 @@
1248 1160
1249 1161 wp_die();
1250 1162 }
1251 1163
1252 - /**
1253 - * @param array $tables
1254 - *
1255 - * @return array
1256 - */
1257 1164 public static function drop_tables( $tables ) {
1258 1165 global $wpdb;
1259 1166 $tables[] = $wpdb->prefix . 'frm_fields';
1260 1167 $tables[] = $wpdb->prefix . 'frm_forms';
@@ -1302,15 +1209,14 @@
1302 1209
1303 1210 FrmTransLiteAppController::maybe_schedule_cron();
1304 1211 }
1305 1212
1306 - /**
1307 - * @param string $text
1308 - *
1309 - * @return string
1310 - */
1311 1213 public static function set_footer_text( $text ) {
1312 - return FrmAppHelper::is_formidable_admin() ? '' : $text;
1214 + if ( FrmAppHelper::is_formidable_admin() ) {
1215 + $text = '';
1216 + }
1217 +
1218 + return $text;
1313 1219 }
1314 1220
1315 1221 /**
1316 1222 * Add admin footer links.
@@ -1320,9 +1226,8 @@
1320 1226 * @return void
1321 1227 */
1322 1228 public static function add_admin_footer_links() {
1323 1229 FrmFormsController::include_device_too_small_message();
1324 -
1325 1230 if ( self::should_show_footer_links() ) {
1326 1231 include FrmAppHelper::plugin_path() . '/classes/views/shared/admin-footer-links.php';
1327 1232 }
1328 1233 }
@@ -1337,9 +1242,8 @@
1337 1242 private static function should_show_footer_links() {
1338 1243 $post_type = FrmAppHelper::simple_get( 'post_type', 'sanitize_title' );
1339 1244 $is_formidable_page = FrmAppHelper::is_formidable_admin() || 'frm_logs' === $post_type;
1340 1245 $show_footer_links = $is_formidable_page;
1341 -
1342 1246 if ( FrmAppHelper::is_full_screen() || ! FrmAppHelper::is_formidable_branding() ) {
1343 1247 $show_footer_links = false;
1344 1248 }
1345 1249
@@ -1348,9 +1252,8 @@
1348 1252 *
1349 1253 * @since 6.7
1350 1254 *
1351 1255 * @param bool $show_footer_links
1352 - *
1353 1256 * @return bool
1354 1257 */
1355 1258 return apply_filters( 'frm_show_footer_links', $show_footer_links );
1356 1259 }
@@ -1377,9 +1280,8 @@
1377 1280 'icon' => 'frm_lock_simple',
1378 1281 );
1379 1282
1380 1283 $error_args = wp_parse_args( $error_args, $defaults );
1381 -
1382 1284 if ( ! isset( $error_args['cancel_text'] ) && ! empty( $error_args['cancel_url'] ) ) {
1383 1285 $error_args['cancel_text'] = __( 'Cancel', 'formidable' );
1384 1286 }
1385 1287
@@ -1396,9 +1298,8 @@
1396 1298 * @since 6.4
1397 1299 *
1398 1300 * @param string $plugin_url URL of the plugin.
1399 1301 * @param string $version Current version of the plugin.
1400 - *
1401 1302 * @return void
1402 1303 */
1403 1304 private static function enqueue_floating_links( $plugin_url, $version ) {
1404 1305 if ( ! $plugin_url || ! $version ) {
@@ -1418,20 +1319,10 @@
1418 1319 if ( function_exists( 'wp_set_script_translations' ) ) {
1419 1320 wp_set_script_translations( 's11-floating-links-config', 's11-' );
1420 1321 }
1421 1322
1422 - $upgrade_utm = array(
1423 - 'campaign' => 'floating-links',
1424 - 'content' => 'floating-links-upgrade',
1425 - );
1426 - $docs_utm = array(
1427 - 'campaign' => 'floating-links',
1428 - 'content' => 'floating-links-docs',
1429 - );
1430 1323 $floating_links_data = array(
1431 - 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1432 - 'upgradeUrl' => FrmAppHelper::admin_upgrade_link( $upgrade_utm ),
1433 - 'documentationUrl' => FrmAppHelper::admin_upgrade_link( $docs_utm, 'knowledgebase/' ),
1324 + 'proIsInstalled' => FrmAppHelper::pro_is_installed(),
1434 1325 );
1435 1326 wp_localize_script( 's11-floating-links-config', 's11FloatingLinksData', $floating_links_data );
1436 1327
1437 1328 /**
@@ -1449,9 +1340,8 @@
1449 1340 * @return bool
1450 1341 */
1451 1342 private static function in_our_pages() {
1452 1343 global $current_screen, $pagenow;
1453 -
1454 1344 if ( FrmAppHelper::is_formidable_admin() ) {
1455 1345 return true;
1456 1346 }
1457 1347
@@ -1458,9 +1348,13 @@
1458 1348 if ( ! empty( $current_screen->post_type ) && 'frm_logs' === $current_screen->post_type ) {
1459 1349 return true;
1460 1350 }
1461 1351
1462 - return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' );
1352 + if ( in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' ) ) {
1353 + return true;
1354 + }
1355 +
1356 + return false;
1463 1357 }
1464 1358
1465 1359 /**
1466 1360 * Handles actions related to the current screen.
@@ -1496,9 +1390,8 @@
1496 1390 foreach ( $actions as $action ) {
1497 1391 if ( empty( $wp_filter[ $action ]->callbacks ) ) {
1498 1392 continue;
1499 1393 }
1500 -
1501 1394 foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
1502 1395 foreach ( $callbacks as $callback_name => $callback ) {
1503 1396 if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
1504 1397 continue;
@@ -1514,18 +1407,14 @@
1514 1407 *
1515 1408 * @return void
1516 1409 */
1517 1410 private static function remember_custom_sort() {
1518 - $meta_key = self::get_sort_pref_user_meta_key();
1519 -
1520 - if ( false === $meta_key ) {
1411 + $screen = get_current_screen();
1412 + if ( ! $screen ) {
1521 1413 return;
1522 1414 }
1523 1415
1524 - $is_form_list = FrmAppHelper::is_admin_list_page();
1525 - $is_entry_list = FrmAppHelper::is_admin_list_page( 'formidable-entries' );
1526 -
1527 - if ( ! $is_form_list && ! $is_entry_list ) {
1416 + if ( ! FrmAppHelper::is_admin_list_page() && ! FrmAppHelper::is_admin_list_page( 'formidable-entries' ) ) {
1528 1417 return;
1529 1418 }
1530 1419
1531 1420 $orderby = FrmAppHelper::get_param( 'orderby' );
@@ -1533,37 +1422,29 @@
1533 1422 if ( ! $orderby ) {
1534 1423 return;
1535 1424 }
1536 1425
1537 - $user_id = get_current_user_id();
1538 - $order = FrmAppHelper::get_param( 'order' );
1539 - $new_sort = array(
1426 + $user_id = get_current_user_id();
1427 + $meta_key = 'frm_preferred_list_sort_' . $screen->id;
1428 + $order = FrmAppHelper::get_param( 'order' );
1429 +
1430 + $new_sort = array(
1540 1431 'orderby' => $orderby,
1541 1432 'order' => $order,
1542 1433 );
1543 - $previous_meta = get_user_meta( $user_id, $meta_key, true );
1544 - $current_sort = $previous_meta;
1545 - $form_id = $is_entry_list ? FrmAppHelper::simple_get( 'form', 'absint' ) : 0;
1546 1434
1547 - if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[ $form_id ] ) ) {
1548 - $current_sort = $current_sort[ $form_id ];
1549 - }
1435 + $current_sort = get_user_meta( $user_id, $meta_key, true );
1550 1436
1551 - if ( $new_sort === $current_sort ) {
1552 - return;
1437 + if ( $new_sort !== $current_sort ) {
1438 + update_user_meta(
1439 + $user_id,
1440 + $meta_key,
1441 + array(
1442 + 'orderby' => $orderby,
1443 + 'order' => $order,
1444 + )
1445 + );
1553 1446 }
1554 -
1555 - $new_meta = $new_sort;
1556 -
1557 - if ( $is_entry_list && $form_id && is_int( $form_id ) ) {
1558 - // Index meta by form ID.
1559 - $temp_meta = is_array( $previous_meta ) ? $previous_meta : array();
1560 - $temp_meta[ $form_id ] = $new_meta;
1561 - $new_meta = $temp_meta;
1562 - unset( $temp_meta );
1563 - }
1564 -
1565 - update_user_meta( $user_id, $meta_key, $new_meta );
1566 1447 }
1567 1448
1568 1449 /**
1569 1450 * Retrieve and apply any saved sorting preferences for the current screen.
@@ -1569,52 +1450,32 @@
1569 1450 * Retrieve and apply any saved sorting preferences for the current screen.
1570 1451 *
1571 1452 * @since 6.19
1572 1453 *
1573 - * @param string $orderby Reference to the current 'orderby' parameter.
1574 - * @param string $order Reference to the current 'order' parameter.
1575 - *
1454 + * @param string &$orderby Reference to the current 'orderby' parameter.
1455 + * @param string &$order Reference to the current 'order' parameter.
1576 1456 * @return void
1577 1457 */
1578 1458 public static function apply_saved_sort_preference( &$orderby, &$order ) {
1579 - $meta_key = self::get_sort_pref_user_meta_key();
1580 -
1581 - if ( false === $meta_key ) {
1459 + if ( ! function_exists( 'get_current_screen' ) ) {
1582 1460 return;
1583 1461 }
1584 1462
1585 - $preferred_list_sort = get_user_meta( get_current_user_id(), $meta_key, true );
1586 - $form_id = FrmAppHelper::simple_get( 'form', 'absint' );
1587 -
1588 - if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[ $form_id ] ) ) {
1589 - $preferred_list_sort = $preferred_list_sort[ $form_id ];
1590 - }
1591 -
1592 - if ( ! is_array( $preferred_list_sort ) || empty( $preferred_list_sort['orderby'] ) ) {
1463 + $screen = get_current_screen();
1464 + if ( ! $screen ) {
1593 1465 return;
1594 1466 }
1595 1467
1596 - $orderby = $preferred_list_sort['orderby'];
1468 + $user_id = get_current_user_id();
1469 + $preferred_list_sort = get_user_meta( $user_id, 'frm_preferred_list_sort_' . $screen->id, true );
1597 1470
1598 - if ( ! empty( $preferred_list_sort['order'] ) ) {
1599 - $order = $preferred_list_sort['order'];
1600 - }
1601 - }
1471 + if ( is_array( $preferred_list_sort ) && ! empty( $preferred_list_sort['orderby'] ) ) {
1472 + $orderby = $preferred_list_sort['orderby'];
1602 1473
1603 - /**
1604 - * Get a simple user meta key that only includes the screen ID.
1605 - *
1606 - * @since 6.25.1
1607 - *
1608 - * @return false|string
1609 - */
1610 - private static function get_sort_pref_user_meta_key() {
1611 - if ( ! function_exists( 'get_current_screen' ) ) {
1612 - return false;
1474 + if ( ! empty( $preferred_list_sort['order'] ) ) {
1475 + $order = $preferred_list_sort['order'];
1476 + }
1613 1477 }
1614 -
1615 - $screen = get_current_screen();
1616 - return $screen ? 'frm_preferred_list_sort_' . $screen->id : false;
1617 1478 }
1618 1479
1619 1480 /**
1620 1481 * Validate that the callback name is ours not from third-party.
@@ -1634,9 +1495,12 @@
1634 1495 *
1635 1496 * @return bool
1636 1497 */
1637 1498 private static function is_our_callback_array( $callback ) {
1638 - return ! empty( $callback['function'] ) && is_array( $callback['function'] ) && ! empty( $callback['function'][0] ) && self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] ); // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong
1499 + return ! empty( $callback['function'] ) &&
1500 + is_array( $callback['function'] ) &&
1501 + ! empty( $callback['function'][0] ) &&
1502 + self::is_our_callback_string( is_object( $callback['function'][0] ) ? get_class( $callback['function'][0] ) : $callback['function'][0] );
1639 1503 }
1640 1504
1641 1505 /**
1642 1506 * In some cases, the DB tables may fail to install.
@@ -1647,9 +1511,10 @@
1647 1511 */
1648 1512 private static function add_missing_tables() {
1649 1513 FrmAppHelper::permission_check( 'frm_view_forms' );
1650 1514
1651 - $error = FrmInbox::check_for_error();
1515 + $inbox = new FrmInbox();
1516 + $error = $inbox->check_for_error();
1652 1517
1653 1518 if ( ! $error || 'failed-to-create-tables' !== $error['key'] ) {
1654 1519 // Confirm the inbox item with this CTA exists.
1655 1520 wp_safe_redirect( admin_url( 'admin.php?page=formidable' ) );
@@ -1681,21 +1546,6 @@
1681 1546 FrmAppHelper::permission_check( 'frm_view_forms' );
1682 1547 check_ajax_referer( 'frm_ajax', 'nonce' );
1683 1548 update_user_option( get_current_user_id(), 'frm_ignore_small_screen_warning', true );
1684 1549 wp_send_json_success();
1685 - }
1686 -
1687 - /**
1688 - * Enqueue the components scripts.
1689 - *
1690 - * @since 6.28
1691 - *
1692 - * @return void
1693 - */
1694 - public static function enqueue_components_scripts() {
1695 - if ( is_callable( array( 'FrmProFormsController', 'enqueue_pro_web_components_script' ) ) ) {
1696 - FrmProFormsController::enqueue_pro_web_components_script();
1697 - }
1698 -
1699 - wp_enqueue_script( 'formidable-web-components' );
1700 1550 }
1701 1551 }